haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
42,285 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

518 Commits

Author SHA1 Message Date
Mike Williams 37837dc392 PCB: introduce PCB_FIELD_T 2023-06-20 18:34:52 +00:00
Jeff Young 30336b2fe3 Unify go-back-one-step processing for drawing tools (and router). 
Also warps mouse on all go-back-one-step operations for better feedback.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14981

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9985
 2023-06-19 17:14:32 +01:00
Jeff Young ef6866757e Treat undo as backspace and/or escape when drawing. Ignore redo. 
Undo == backspace when drawing a polygon or chained lines.  Otherwise
it's an escape.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14961
 2023-06-16 22:08:21 +01:00
Jeff Young 9ed2458f00 Reset session drawing props after Board Setup. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14932
 2023-06-13 11:06:10 +01:00
Jeff Young 14f004d2a5 Hook up text variable auto-complete for PCBNew. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14777
 2023-05-25 10:24:50 +01:00
Jeff Young bbd6c80507 Collapse FP_* down into their PCB_* equivalents. 2023-03-31 22:57:46 +01:00
Jeff Young bb2a0f825a Orthogonal dimension are always cardinal, even when their start points are not. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13728
 2023-03-20 21:22:11 +00:00
Alex 8fe78101db Don't create 0-length tracks when placing via in the middle of a track. 2023-03-16 04:53:26 +03:00
Jeff Young 461def2719 Move automatic dimension processing inside PCB_DIMENSION_BASE. 
Also move dimension precision to an enum so it can get a proper dropdown
in the properties inspector.
 2023-03-05 15:19:06 +00:00
Jeff Young 23accffc6d Add Property Inspector support for dimension objects. 
Includes changing the class hierarchy so that dimension objects inherit
from PCB_TEXT rather than containing a PCB_TEXT member variable.
 2023-03-04 23:16:46 +00:00
Seth Hillbrand 1b8b216ac8 Bitmaps are not actually copper 
We report bitmaps as being 'on' a copper layer because they are
associated with it but they are not actually physical parts so should
not be included in the DRC checks

Additionally, Bitmaps effective shape starts are the top left corner
rather than the center (unclear why that was there in the first place)

Fixes https://gitlab.com/kicad/code/kicad/issues/14065
 2023-02-23 14:16:28 -08:00
Alex ecb28ddf1c Prevent ghost image after canceling bitmap placement. 2023-02-17 03:53:44 +03:00
Marek Roszko 4665823089 Turn on and fix MSVC compliance mode issues 
We want /permissive- to enable debug performance improvements in MSVC 17.5+.
This flag is also default under C++20 so we'll have to deal with these compile issues anyway at some point in the future.

In particular, MSVC becomes pedantic about ternary types.
See https://learn.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-170#ambiguous-conditional-operator-arguments

MSFT cites https://cplusplus.github.io/CWG/issues/1805.html
 2023-02-12 16:30:37 -05:00
jean-pierre charras 538ee12188 Pcb editor: fix crash when trying to activate the "place anchor" tool. 
"place anchor" tool exists only in the Fp editor. However, the hotkey
to activate this tool was also active in the board editor. Now disabled.
 2023-02-09 16:29:33 +01:00
Jeff Young 4c63b4e061 Class name <-> file name sync. 2022-12-29 18:05:57 +00:00
Seth Hillbrand 279edcefdc Don't break tracks without snap 
If the user asks to not snap to a track, we should also prevent the
track from snapping to the via

Fixes https://gitlab.com/kicad/code/kicad/issues/13142
 2022-12-14 13:51:42 -08:00
Seth Hillbrand b31349b679 Get consistent point for gfx import 
TopLeftItem() should always return same element for our import

Fixes https://gitlab.com/kicad/code/kicad/issues/13041
 2022-11-30 12:25:34 -08:00
Seth Hillbrand cf33f33899 Standardize placement tool modifiers 
PlaceImage, PlaceImportedGraphics and PlaceText need to handle the grid
and hotpoint snapping as well as the modifiers to disable them
 2022-11-30 10:57:42 -08:00
Jeff Young 074c087c21 Allow disabling of grid snapping while placing imported image. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13040
 2022-11-30 14:38:22 +00:00
Seth Hillbrand 47d86e5d9e Don't crash when canceling graphics import 
Grouped graphics need to have their group removed from the preview
before deleting the elements to avoid reading freed memory when
redrawing
 2022-11-23 16:21:06 -08:00
Jeff Young 9724f6e736 Don't allow zone filling during other editing operations. 
It's a very heavy op, and is likely to violate all manner of
assumptions the other ops make.

Fixes https://gitlab.com/kicad/code/kicad/issues/12736
 2022-11-14 23:39:49 +00:00
Seth Hillbrand 056f45cd70 Fixup most intersecting polygon points 
Remaining is the intersecting complex pad, so this keeps the error
message when drawing

Fixes https://gitlab.com/kicad/code/kicad/issues/12806
 2022-11-08 16:05:04 -08:00
Wayne Stambaugh 6a0db3e7e2 Fix Coverity warnings. 2022-10-26 14:39:44 -04:00
Wayne Stambaugh 598b09821a Coverity fixes. 2022-10-17 15:30:20 -04:00
Alex 165654f114 Expose Switch Arc Posture in context menu. 2022-10-07 08:28:13 +03:00
Alex d26b59a0bf Improve arc construction using angles from arc geometry manager. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11713
 2022-10-07 06:51:00 +03:00
jean-pierre charras 5990595619 When adding a bitmap, do not clone it during moving. 
Cloning is not necessary, and is memory consuming.
 2022-09-19 17:41:47 +02:00
Mike Williams 9304607624 TOOL_EVENT: make command string non-optional 
We're getting segfaults in places where this isn't checked. Also, add
some asserts so we can catch bad tool push/pop.

Removes all uses of GetCommandStr() and makes it private.
 2022-09-19 10:23:09 -04:00
Jeff Young 45d6b4a9fc Readability improvements. 2022-09-19 11:18:20 +01:00
Marek Roszko a8613ee80f Combine Iu2Millimeter & remove PcbMm2iu 2022-09-16 21:09:26 -04:00
Jeff Young d9f75556bd Fix old copy/paste error (from 2017, believe it or not). 
Fixes https://gitlab.com/kicad/code/kicad/issues/11487
 2022-09-16 11:25:27 +01:00
Mark Roszko b00178adb3 Nuke base_units from orbit 2022-09-16 04:38:10 +00:00
Jeff Young ce9adeaf51 Don't set FreeVia when we can't find a net. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12421
 2022-09-15 23:16:08 +01:00
Jeff Young eaccd40c75 Allow vias to connect <no net> tracks even when DRC checking is on. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12403
 2022-09-12 20:38:21 +01:00
Jeff Young c30a557810 ADDED netclass assignment from PCB canvas. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5975
 2022-09-03 19:29:59 +01:00
Seth Hillbrand b736460e71 Move optional access from value() to *operator 
`value()` throws.  Where we check for existence, we don't need to use
the throwing version and should just use the unprotected variant
 2022-08-30 13:59:39 -07:00
Jeff Young 09511d176c Quiet Coverity. 2022-08-26 17:05:25 +01:00
Seth Hillbrand f1261e71d4 Replace boost::optional with std::optional 2022-08-25 15:50:47 -07:00
Jeff Young 46df421064 ADDED defined pad groups for net-tie footprints 
Each pad group is allowed to short nets with other pads in its group.

Legacy footprints with the "net tie" keyword hack will get a single
group auto-created with all the footprint's pads in it.

DRC and the router now allow a track to collide with copper graphic items
while entering a net-tie pad as long as the closest point in the collision
is within the pad.

DRC (and the footprint checker) now check for copper items in the
footprint shorting pads which are not in the same pad group.

Fixes https://gitlab.com/kicad/code/kicad/issues/2265
 2022-08-19 18:54:20 +01:00
Alex 405be8d15f Bounds-awareness in Move, Rotate, point editor, drawing tool 2022-08-16 12:08:55 +00:00
Jeff Young a9536b5de9 CHANGED netclass assignments now done via canvas or via patterns. 2022-08-14 22:56:29 +01:00
Jeff Young 54213bb7f1 Cleanup and move to DRC_ENGINE's status reporter. 
1) brace formatting
2) get rid of some autos
3) get rid of a dyn_cast that CLion claims is bad
4) use DRC_ENGINE's status reporter
 2022-08-01 13:09:51 +01:00
Jeff Young 6f49b57f9b Cleanup & performance enhancements. 2022-08-01 13:09:51 +01:00
Jeff Young 2bf33321d1 Update constraint mode in status bar during move. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10465
 2022-07-27 18:57:45 +01:00
Jeff Young f41af10007 Clean up hole shapes for safety (smart pointer) and consistency. 2022-07-22 23:06:07 +01:00
Jeff Young b80fd5329d Clear dimension pointer after committing. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11864
 2022-07-22 09:31:09 +01:00
Mike Williams 3669cb4673 PCB Editor: Add User Background Images 2022-07-14 11:23:23 +00:00
Jeff Young e122dc38bd Add context menu item for clearing net highlighting. 
In selection tools, drawing tools, router tool, line_wire_bus tool.

Fixes https://gitlab.com/kicad/code/kicad/issues/11920
 2022-07-10 17:15:20 -06:00
Seth Hillbrand 0c47a09517 Ensure rectangles are normalized 
Normalize on creation and fixup rectangles previously saved with
inverted coordinates

Fixes https://gitlab.com/kicad/code/kicad/issues/11965
 2022-07-07 10:40:18 -07:00
Jeff Young 298edb09c3 Initialize TEXT_ATTRIBUTES justifications for text & textboxes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11805
 2022-06-20 17:03:37 +01:00
Jeff Young 73836b50fc Add proper collision test to via placer. 
Also moves DISALLOW constraint processing outside the loop as it
performs it's own loop over any objects referenced by the rules.

Fixes https://gitlab.com/kicad/code/kicad/issues/11832
 2022-06-19 21:57:49 +01:00
Jeff Young d40664d171 Handle double-click in dimension drawing tool. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11815
 2022-06-15 18:07:50 +01:00
Jeff Young d31bd4ea3e Use default text properties for textboxes. 
Also make sure text is mirrored when placed on back of board.

Fixes https://gitlab.com/kicad/code/kicad/issues/11739
 2022-06-03 18:48:09 +01:00
Jeff Young 155620cc9a Move H/V/45 mode from zone properties to toolbar. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8587
 2022-05-29 21:30:15 +01:00
Jeff Young 1fb7532859 Prepare for a more uniform implementation of H/V/45 mode. 2022-05-29 21:30:14 +01:00
Jeff Young 23fb4c7433 Uniformly use a single facility for location-less prime events. 
Also implements a uniform mechanism for avoiding auto-scroll after
a prime event or dialog which results in a mouse position at the
edge of the canvas.

Fixes https://gitlab.com/kicad/code/kicad/issues/11057
 2022-05-16 23:43:00 +01:00
Jeff Young f2fc78f380 Don't copy modifiers to prime events. 
The modifiers go with the hotkey, not with the action.

Fixes https://gitlab.com/kicad/code/kicad/issues/11618
 2022-05-16 13:51:40 +01:00
Jeff Young a49bb792bd Insert chevrons when placing vias near tracks. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10898
 2022-04-11 16:26:36 +01:00
Jeff Young 29eb5931c2 Be more careful with forced cursor positions. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9977
 2022-04-10 23:14:57 +01:00
Jeff Young 4f62960334 Update message panel from PCB point editor and SCH drawing tools. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11186
 2022-03-21 10:32:36 +00:00
Jeff Young ec5b7a57ec Consistency in via dimensions terminology. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11024
 2022-03-03 22:40:18 +00:00
Jeff Young d65f9ad2d8 Implement multi-layer stitching via logic. 2022-02-24 21:32:43 +00:00
Jeff Young 369f53bb19 Better DRC checking when placing vias. 2022-02-24 21:32:43 +00:00
Jeff Young 41f6e634c6 Partially integrate grid snapping with constraints. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10941
 2022-02-22 22:19:55 +00:00
Jeff Young 50a4d610a6 Be cognizant of flashed layers when generating pad shapes. 2022-02-11 13:10:52 +00:00
Seth Hillbrand 162545ddf0 Validate arc output when editing 
Handles checking output of the arc to ensure we don't end up generating
an invalid arc.  Also keeps the limit of the arc angle to be (360,360)
excluding 0.

Fixes https://gitlab.com/kicad/code/kicad/issues/10070

(cherry picked from commit 8fc831cbc2)
 2022-02-07 08:55:53 -08:00
Jeff Young 34a9a165c9 More wide-string declarations. 2022-02-05 22:26:31 +00:00
Jeff Young 5739505aa3 TextBoxes for PCBNew. 2022-01-31 20:00:47 +00:00
Jeff Young e84c574830 Some more EDA_ANGLE cleanup. 2022-01-16 19:16:18 +00:00
Jeff Young 89c0f8e297 Move to new font engine. 2022-01-02 14:57:03 +00:00
Marek Roszko c4c56de708 Neurotically update position wxPoint usages 2022-01-01 11:55:51 -05:00
Jeff Young 3a8ffd40b8 Fix dimension drawing bug. 2021-12-26 17:30:21 +00:00
Jeff Young fa908e1f98 Dimensions for footprints. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8441
 2021-12-24 21:10:28 +00:00
Jeff Young ed79f6e511 Clean up some TODOs. 2021-12-24 21:10:28 +00:00
Jeff Young 3f90b3e2a0 Keep line stroke params as long as layer doesn't change. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6210
 2021-12-24 16:13:51 +00:00
Jeff Young d28714167c All the preferences, all the time. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7877

Fixes https://gitlab.com/kicad/code/kicad/issues/5153
 2021-12-24 13:08:44 +00:00
Jeff Young 2bc86fa0a8 Shapes for schematic. 
ADDED arc, circle and rectangle shapes for schematic.  Shapes support
line styles and fill colors.

CHANGED sheet background color in Edit Text & Graphics Properties to
fill color (and it now affects shapes).

Pushed STROKE_PARAMS down into common and moved all shapes to using it
for stroke descriptions.
 2021-12-23 20:36:07 +00:00
Jeff Young 4b6bf3095a Radial dimensions. 
ADDED radial type dimensions.

Fixes https://gitlab.com/kicad/code/kicad/issues/2056
 2021-12-23 19:34:54 +00:00
dsa-t a7193e0932 Do not warp cursor to last location when footprint/text placement is activated from toolbar/menu. 
Also makes the footprint appear instantly after closing the dialog.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9840
 2021-12-07 22:48:56 +00:00
Jonathan Haas 04b0435c45 Snap to pads when placing via 
Fixes https://gitlab.com/kicad/code/kicad/issues/9873
 2021-12-06 15:54:49 +00:00
Wayne Stambaugh 53f5d616aa Coverity issue fixes. 2021-11-13 11:38:31 -05:00
Seth Hillbrand 8a3bc3fe4d Don't translate empty strings 
The _( "" ) msgid is reserved in gettext, so we need to avoid it in code
 2021-10-25 06:24:06 -07:00
Jeff Young c9d858eaf5 Add status bar message for constraint mode. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9282
 2021-10-24 14:04:12 +01:00
Jeff Young f9861b4a6c Finish arc rework and push out to file formats. 2021-10-15 12:45:43 +01:00
Jeff Young 9b9e379aa0 Overhaul arc internal model to not over-specify information. 2021-10-15 12:45:43 +01:00
Jeff Young 8b08c9e53f Shorter names before things get out of hand. 
Also, remove comments indicating CURVE is a Bezier.  Just call it a
BEZIER.
 2021-10-15 12:45:43 +01:00
Jeff Young a41944020d Push most of PCB_SHAPE impl down in to EDA_SHAPE. 2021-10-15 12:45:43 +01:00
jean-pierre charras da79a3dd69 Option graphics limited to 45deg in creation: separate options for brd and fp editors. 
Add these options in PANEL_EDIT_OPTIONS.
This option was previously living only in some context menus, not really visible.
 2021-10-02 16:43:31 +02:00
Marek Roszko 847c9e32c8 Don't allow the draw via tool to activate in the footprint editor 
Fix #9186
 2021-09-17 23:01:16 -04:00
Jeff Young fdfecf5932 Don't push view control settings to the previous active tool. 
See further comments in bug report.

Fixes https://gitlab.com/kicad/code/kicad/issues/9147
 2021-09-13 13:28:05 +01:00
Seth Hillbrand 092cdc0bb5 Move 45° limit to hotkey 
This assigns the "Tab" key to a general pcbnew 45° limitation.  Limit
can be enabled/disabled using context menu as well.

Removed the user preference for 45° limitation on graphic lines as that
is overlapping with the general limitation, which is not an editing
preference so much as a temporary adjustment to tool action.

Related to https://gitlab.com/kicad/code/kicad/-/issues/8490
 2021-09-05 13:42:51 -07:00
Seth Hillbrand e03257b55f Allow close placement of stitching vias 
When placing a stitching via for a bypass capacitor, it is common to
place it close to the relevant pad.  If the via does not have the
correct net, this will violate DRC and be prevented.

Checking for zone-based net assignments allows the workflow to proceed
 2021-09-01 15:52:35 -07:00
Jeff Young c51b1dad72 Generalize infobar MESSAGE_TYPE handling and use for DRC errors. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8782
 2021-08-01 21:51:39 +01:00
Jeff Young 6aaf4413b3 Fix kicad_string.h / string.cpp mismatch. 
They don't define a KiCad string class, so the header file name was
somewhat misleading. But the fact that they didn't match definitely
made coding more difficult.
 2021-07-29 16:03:25 +01:00
Jeff Young dd5676f4bc Implement a safer (RAII) tool re-entrancy guard. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8873
 2021-07-27 16:37:34 +01:00
Jeff Young 0fb864d596 Pull some name changes back from 7.0 to ease merging. 2021-07-21 20:58:59 +01:00
Wayne Stambaugh cf00319c85 More NULL expunging. 2021-07-20 07:27:18 -04:00
jean-pierre charras 9a865b1989 Fix a typo and a minor compil warning 2021-06-28 14:37:35 +02:00
Jeff Young 7efca0113d Reset m_inDrawingTool on exit. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8653
 2021-06-22 13:02:45 +01:00
Jeff Young b72545a432 Implement more aggressive re-entrancy blocking for drawing tools. 
A similar strategy was already implemented in Eeschema.

Also adds some safety around clearing of autopan and mouse capture.

Fixes https://gitlab.com/kicad/code/kicad/issues/6909
 2021-06-20 11:09:55 +01:00