24f9bfa13b
Fixed memory leaks
...
This is commit a9efbf47
2018-12-20 10:05:58 +01:00
83d851956c
classes MARKER rework: remove duplicate code. Better HitTest code (HitTest takes in account the actual shape)
2018-12-19 19:53:27 +01:00
15843ae01a
class MARKER rework: fix a few minor issues, remove duplicate code and add comments.
2018-12-19 15:13:31 +01:00
638b4384ec
eeschema: fix issue: Moving a hierarchical pin slightly move also other hierarchical pins
...
Fixes: lp:1808687
https://bugs.launchpad.net/kicad/+bug/1808687
2018-12-16 15:31:31 +01:00
e2ed0e6557
Move sheet pins in front of sheetedge & move them in by ½ line width
2018-12-15 20:15:19 +00:00
e307d9318b
Revert "Fixed memory leaks"
...
This reverts commit a9efbf4716
2018-12-11 10:12:44 -08:00
2c53ab3d8c
Fix debug assert.
2018-12-11 17:56:41 +00:00
63d4afb3ee
Support autopanning in GALified eeschema
...
Fixes: lp:1807234
* https://bugs.launchpad.net/kicad/+bug/1807234
2018-12-11 17:49:34 +01:00
a9efbf4716
Fixed memory leaks
2018-12-11 16:21:43 +01:00
7e1498a46f
Set the screen pointer to null before deleting the associated items
...
VIEW needs to be cleared before deleting the stored items. Otherwise it
may dereference stale pointers leading to a crash.
2018-12-11 16:21:43 +01:00
40dac0ecbb
Default sizes for edit frames in case prefs get deleted.
...
Fixes: lp:1807676
* https://bugs.launchpad.net/kicad/+bug/1807676
2018-12-10 12:23:16 +00:00
e50d9df76a
Eeschema: fix incorrect parsing of line color (r v b values).
...
Only the R and V were read, the parsing was stopping before reading the B value.
2018-12-09 17:59:24 +01:00
fd537c8230
eeschema: Do not clear highlights with NULL screen
...
When closing a project, the screen is released, so we need to avoid
cross-probe calls dereferencing the screen pointer.
Fixes: lp:1807501
* https://bugs.launchpad.net/kicad/+bug/1807501
2018-12-08 07:54:31 -08:00
a40cff18d3
PANEL_EESCHEMA_SETTINGS_BASE: very minor cosmetic enhancement.
2018-12-07 11:30:52 +01:00
f1c1c5db3f
Fix a minor compil warning
2018-12-07 11:22:03 +01:00
766156ed87
Fix for dark mode on macOS Mojave
...
Thanks to Scott Rapson and Justace Clutter for the solution.
Fixes: lp:1797989
* https://bugs.launchpad.net/kicad/+bug/1797989
2018-12-07 09:03:56 +01:00
3a0dbf48c8
Read Symbol Browser grid settings from Symbol Editor.
2018-12-07 00:26:10 +00:00
ed506dd05e
eeschema: Prevent excess link updates
...
Refreshing the symbols for each paint is excessive to catch the change
from library loads. Instead we catch them on the KIWAY MAIL update
2018-12-06 13:46:52 -08:00
b8de4e73bf
Eeschema: fix schematic symbol parsing bug.
...
Schematic symbol library link names are unquoted strings that can
contain non-ascii characters which breaks the parser. Converting
the line to uft-8 before breaking the string into tokens resolves
the issue.
2018-12-06 12:44:13 -05:00
742961119d
Eeschema: fix library symbol pin definition parsing bug.
...
Pin names are unquoted strings that can contain non-ascii characters
which breaks the parser. Converting the line to uft-8 before breaking
the string into tokens resolves the issue.
2018-12-06 11:47:20 -05:00
e94752a6cf
Added help string to select buttons.
...
Also moved highlight text string to help_common_strings.h
Fixes: lp:1497737
* https://bugs.launchpad.net/kicad/+bug/1497737
2018-12-05 20:13:03 -08:00
07ebc4df14
Fix schematic append clear annotation bug.
...
Clear the annotation of only the appended schematic and any sheets in it's
hierarchy. Do not clear the annotation of the symbols in the target sheet.
Fixes lp:1805695
https://bugs.launchpad.net/kicad/+bug/1805695
2018-12-05 17:12:11 -05:00
a61a51f26e
Eeschema: fix UTF8 character handling bug in legacy parser.
...
Iterating over unquoted strings as ASCII8 fails when ' ' character is
not the LSB of a UTF8 string with wide characters. Change parsing method
for unquoted strings to convert the entire line as UTF8 and then use
wxStringTokenizer to break the line into tokens at the ' ' characters.
Fixes lp:1806206
https://bugs.launchpad.net/kicad/+bug/1806206
2018-12-05 13:54:51 -05:00
58036382c1
eeschema: Fix slow redraw on net highlighting (by redrawing only modified items)
...
Fixes: lp:1806197
https://bugs.launchpad.net/kicad/+bug/1806197
2018-12-04 20:55:59 +01:00
ca5751fc46
Symbol Editor: update the view after relocating the anchor
2018-12-04 09:42:26 +01:00
61b749f0b2
Update dangling ends when resizing sheet.
...
Fixes: lp:1805127
* https://bugs.launchpad.net/kicad/+bug/1805127
2018-11-30 21:34:18 +00:00
ff6a3482ec
Remove on-kill-focus-validation.
...
Fixes: lp:1805361
* https://bugs.launchpad.net/kicad/+bug/1805361
2018-11-29 19:00:21 +00:00
6d8ca311f8
Fix a crash after clicking 'delete' button with empty Template Field Names grid
2018-11-29 14:09:07 +01:00
9b7d6a27de
Don't show dangling symbols at ends of wires with no-connect flags.
...
Fixes: lp:1805255
* https://bugs.launchpad.net/kicad/+bug/1805255
2018-11-27 14:44:13 +00:00
6bf0e17036
Fix typo which was keeping rename from working.
...
(Renaming the dialog window instead of the libentry doesn't really
do the trick.)
2018-11-25 01:51:45 +00:00
d2756bedf1
Keep state except when the filter changed.
...
(Used to be "except when filtering".)
Fixes: lp:1804293
* https://bugs.launchpad.net/kicad/+bug/1804293
2018-11-25 01:51:45 +00:00
239482ec98
Add tooltips to Symbol Properties dialogs.
...
Fixes: lp:1804931
* https://bugs.launchpad.net/kicad/+bug/1804931
2018-11-24 15:06:21 +00:00
2e1920abad
Add tooltips to library manager dialogs.
...
Fixes: lp:1804930
* https://bugs.launchpad.net/kicad/+bug/1804930
2018-11-24 15:06:21 +00:00
b2db49f4ac
Add browse buttons to Library Manager dialogs.
...
Fixes: lp:1804924
* https://bugs.launchpad.net/kicad/+bug/1804924
2018-11-24 15:06:21 +00:00
db7deff21b
DIALOG_SPICE_MODEL_BASE: fix minor wxWidgets alerts.
2018-11-23 10:21:57 +01:00
ed6c68a1e3
Clean up handling of component fields.
...
In particular the datasheet field and how its handled with aliases,
but also cleaning up duplicated functionality around aliases and
libids.
2018-11-22 21:31:45 +00:00
023a445e9f
Make sure original part record always has the write library nickname.
...
Fixes: lp:1804293
* https://bugs.launchpad.net/kicad/+bug/1804293
2018-11-21 19:51:04 +00:00
f934ce653f
A bit of safety to prevent dereferencing NULL.
2018-11-21 19:51:04 +00:00
ae6989f3a1
Don't trim entire wires.
...
Fixes: lp:1804297
* https://bugs.launchpad.net/kicad/+bug/1804297
2018-11-20 21:44:35 +00:00
d6ac303a8c
Don't dereference NULL when checking current part.
2018-11-20 20:21:29 +00:00
a958b23a11
Remove assert which fires incorrectly when emptying screen.
2018-11-20 20:21:29 +00:00
9145d6a0a3
Put library name in confirmation dialog when reverting library.
2018-11-20 20:21:29 +00:00
630baa3724
Code formatting
2018-11-20 17:54:10 +01:00
d405be95b8
Fix a symbol editor crash when clicking without any symbol loaded
2018-11-20 17:52:58 +01:00
ab3ff61faa
Eeschema: adjust the working/drawing area size on the page size.
...
This makes using Scrollbars more easy to use, especially for "small" page sizes like A or B.
Note also the working/drawing area size is bigger than the page size (3 times)
2018-11-20 15:11:22 +01:00
984d3f04ab
Update dangling ends after importing schematic content.
...
Fixes: lp:1803996
* https://bugs.launchpad.net/kicad/+bug/1803996
2018-11-19 20:47:31 +00:00
18dc618a13
Set color before drawing dangling symbols.
...
Fixes: lp:1804003
* https://bugs.launchpad.net/kicad/+bug/1804003
2018-11-19 20:29:48 +00:00
e715835c29
Copy dangling flag when cloning.
...
Fixes: lp:1804005
* https://bugs.launchpad.net/kicad/+bug/1804005
2018-11-19 19:07:40 +00:00
8522baf4a7
bom_plugins.cpp: fix incorrect command line for python scripts on Windows.
...
* On Windows, a python command line must be python <script_path>/script.py
and not python <script_path>\script.py
* Fix also a incorrect warning message when a script is not found.
2018-11-19 17:50:38 +01:00
2ee2d9014a
Populate BOM plugins list if the list is empty
...
Fixes: lp:1464893
* https://bugs.launchpad.net/kicad/+bug/1464893
2018-11-19 16:17:53 +01:00
15772e4b0b
BOM plugins refactor
...
Extended BOM_PLUGIN to a class and moved the plugin construction related code there.
2018-11-19 15:59:08 +01:00
240051fb26
Worksheet display in GAL mode: fix missing filename and (in Eeschema) sheet full name.
2018-11-19 10:21:28 +01:00
c539d6e0be
fix incorrect initialization of VIEW::m_boundary.
...
This parameter defines the working area (full page) size.
The fix is not perfect, because it does not take in account the page size.
However it is similar to the "old" initialization, before Eeschema GAL.
In Eeschema, a reasonable boundary size is used.
2018-11-18 20:04:17 +01:00
0de9cb345c
Add shortcuts to setting dialogs for track widths, via sizes and grid sizes.
...
Fixes: lp:1803671
* https://bugs.launchpad.net/kicad/+bug/1803671
2018-11-17 00:35:06 +00:00
b35b1bb644
Fix a few minor I18n issues.
...
Especially remove trailing and leading spaces in sentences, always annoying in translations, and never useful in sources.
2018-11-16 18:12:01 +01:00
e3bcd31bff
Added a dialog to confirm discarding unsaved changes in Pin Table dialog.
2018-11-16 16:10:53 +01:00
de1a8abd3e
Fix a crash after accepting changes from Pin Table dialog
...
Pin Table dialog replaces LIB_ITEMs, while one of them may still
be pointed to as the current library item. Certain wxUpdateUIEvent
will try to dereference the pointer, leading to a crash.
2018-11-16 14:13:28 +01:00
4050991d28
Move ERC marker focusing to GAL architecture.
...
Fixes: lp:1802537
* https://bugs.launchpad.net/kicad/+bug/1802537
2018-11-16 10:38:44 +00:00
acf696ca2d
Eeschema, worksheet view: fix missing initialisation of sheet count and sheet number
...
Fixes: lp:1803637
https://bugs.launchpad.net/kicad/+bug/1803637
2018-11-16 09:36:10 +01:00
1f3d5cee0e
Fix a few minor I18n issues.
2018-11-15 09:34:29 +01:00
bcc8c64256
Consider edge cuts items to have zero width when filling zones.
...
Fixes: lp:1797787
* https://bugs.launchpad.net/kicad/+bug/1797787
2018-11-14 23:45:32 +00:00
d65bb73d4e
Finish up remaining block operation inconsistencies.
...
In particular, don't move block back to start when duplicating,
and don't move crosshair back to start when doing a cut, copy, or
paste.
Also fixes undo for libEdit block duplicate.
Fixes: lp:1740138
* https://bugs.launchpad.net/kicad/+bug/1740138
2018-11-14 23:45:32 +00:00
ac2e400598
Re-instate schematic-scope to dangling ends.
...
Fixes: lp:1803117
* https://bugs.launchpad.net/kicad/+bug/1803117
2018-11-13 21:03:18 +00:00
a60066115b
Move no-connect symbols closer to the front for rendering.
...
Fixes: lp:1803124
* https://bugs.launchpad.net/kicad/+bug/1803124
2018-11-13 21:03:18 +00:00
298a033b9d
Fixed a crash on moving down the last field in the Symbol Properties dialog
2018-11-13 14:14:08 +01:00
44424dcbb3
Fixed a crash in Symbol Properties dialog
...
Fixes: lp:1802641
* https://bugs.launchpad.net/kicad/+bug/1802641
2018-11-13 14:02:16 +01:00
436f80a0bb
eeschema/dialogs/dialog_lib_edit_pin_base.cpp: fix a minor wxWidgets alert
2018-11-13 13:03:38 +01:00
4a9d538608
Fix typo when warping cursor (coords are world-coords).
...
Fixes: lp:1802811
* https://bugs.launchpad.net/kicad/+bug/1802811
2018-11-12 22:09:31 +00:00
0a71212929
Fix a few minor issues in SYMBOL_PREVIEW_WIDGET.
...
Fixes: lp:1802808
https://bugs.launchpad.net/kicad/+bug/1802808
2018-11-12 20:40:41 +01:00
0d3637c2ee
Fix a few minor I18n issues.
...
Avoid translation of debug messages.
2018-11-11 10:46:26 +01:00
f7cf40f2f4
Fix a few Coverity warnings.
...
Sometimes a dynamic_cast was used without testing the returned value.
Some are replaced by static_cast, when the dynamic_cast was useless.
2018-11-11 08:28:58 +01:00
f1f4473d8b
Footprint editor: add save view to PNG file.
...
Factor out save current canvas view to image file code from symbol editor
code so it can be used anywhere.
Add ability to save to any image format supported by wxBitmapType. See
https://docs.wxwidgets.org/3.0/gdicmn_8h.html#a90a1eb6d85b5044a99b706fd979f27f5 .
Currently only PNG output is implemented.
Please note that there is a minor bug that appears to be due to the
scroll bars which causes unfilled areas on the right and bottom edges
of the image. This always existed in the save symbol editor view
image but it was not as noticeable because by default the background
color is white. It is very noticeable in the footprint editor with
a black background.
The usual smattering of coding policy and comment fixes.
Fixes lp:1802127
https://bugs.launchpad.net/kicad/+bug/1802127
2018-11-09 08:32:36 -05:00
6860320b1b
Init LibEdit with unit & conversion when opening from schematic.
2018-11-08 21:27:15 +00:00
3de04e184b
Convert pasted objects to current unit and DeMorgan variant.
...
Fixes: lp:1797183
* https://bugs.launchpad.net/kicad/+bug/1797183
2018-11-08 21:27:15 +00:00
075f428aca
Include directories are implied by legacy_gal linkage
...
This avoids having to manually specify include/legacy_gal
in and legacy GAL targets, and harominizes with legacy_wx.
This also means .cpp files in common/legacy_gal do not
need to specify the legacy_gal subdirectory, so they
will continue to work as needed when legacy_wx is removed.
2018-11-08 07:52:36 -05:00
02f81d7419
Handle 'show page limits' in eeschema
2018-11-08 09:57:16 +01:00
cbd13c7127
Show dangling pins when moving items; don't when dragging.
...
Fixes: lp:1801962
* https://bugs.launchpad.net/kicad/+bug/1801962
Fixes: lp:1801959
* https://bugs.launchpad.net/kicad/+bug/1801959
2018-11-07 14:24:16 +00:00
d6bc402f14
Fix instantly disappearing pop-up menu in eeschema
...
Fixes: lp:1798453
* https://bugs.launchpad.net/kicad/+bug/1798453
2018-11-06 17:21:13 +01:00
8091573bf7
Fix disappearing schematic components
...
SCH_COMPONENTs should be added to VIEW only when symbol links are
resolved. Otherwise a dummy component bounding box will be used when
inserting a component to VIEW R-tree.
Fixes: lp:1801800
* https://bugs.launchpad.net/kicad/+bug/1801800
2018-11-06 11:25:47 +01:00
293bc52299
Fix off-grid block paste
...
Fixes: lp:1801625
* https://bugs.launchpad.net/kicad/+bug/1801625
2018-11-05 11:59:38 +01:00
fec8ab372e
Don't set the viewport when switching screens.
...
That's the job of ZoomAutomatique().
Fixes: lp:1799436
* https://bugs.launchpad.net/kicad/+bug/1799436
2018-11-04 19:17:53 +00:00
589e1f6a96
MSW and GTK need a separate dialog for opening/saving directories.
...
Fixes: lp:1801528
* https://bugs.launchpad.net/kicad/+bug/1801528
2018-11-04 12:35:01 +00:00
68b07d1aff
Add show/hide search tree to modedit, and fix it in libedit.
...
Fixes: lp:1801531
* https://bugs.launchpad.net/kicad/+bug/1801531
2018-11-04 12:35:01 +00:00
6e810a00e4
Warp mouse from context menu before dragging.
...
Fixes: lp:1798815
* https://bugs.launchpad.net/kicad/+bug/1798815
2018-11-04 12:35:01 +00:00
69952a7b9f
Improve updating of symbol and footprint trees.
...
In particular, update highlighting when changing footprints.
2018-11-02 19:55:30 +00:00
be0935b339
Eeschema: Update zoom/scale limits, due to recent change in GAL.
...
Fixes: lp:1797995
https://bugs.launchpad.net/kicad/+bug/1797995
2018-11-02 14:36:12 +01:00
d465af65a7
LIB_FIELD: fix incorrect text thickness for small sized texts.
...
Also remove duplicate code.
2018-11-02 11:36:07 +01:00
5e44686711
Eeschema, symbol editor: re-enable PNG export and fix a minor issue in SVG export (was in B&W mode instead of color).
...
Add a comment in plotter.h to avoid other errors when selecting plotting mode B&W or color
Fixes: lp:1801058
https://bugs.launchpad.net/kicad/+bug/1801058
2018-11-02 09:24:55 +01:00
bf42247971
Eeschema: fix potential crash when closing Kicad app.
...
The crash happens when a wxPaint event is fired after deleting the schematic frame.
It happened only on one Linux install.
Fixes: lp:1800874
* https://bugs.launchpad.net/kicad/+bug/1800874
2018-11-01 08:27:19 +01:00
6602e17edc
Add copyright header to sch_view.h
2018-10-31 19:17:30 +01:00
a18be5d37c
Adjust GAL world unit for eeschema
2018-10-31 19:17:30 +01:00
e81c3a59a2
Refactored and unified board editor and footprint editor print dialogs
2018-10-31 19:17:30 +01:00
17205b4599
Added VIEW::DataReference() for sharing data with another VIEW instance
2018-10-31 19:17:29 +01:00
a1fad9d3fe
Eeschema: allow dragging of text
...
Text doesn't have "special" handling of dragging, like connected items (it's
basically just a move). However, allowing "drag" to work on text makes
handling text consistent when dragging other items.
2018-10-31 16:19:03 +00:00
7985234556
Eeschema: Fix a subtle bug in SYMBOL_PREVIEW_WIDGET.
...
The dialog was using a LIB_ALIAS from library cache to show the symbol to the canvas without making a local copy.
Unfortunately, the library viewer is doing the same thing.
Now the GAL is used in Eeschema, a link to the VIEW used by the GAL canvas is stored in this class.
When The selector symbol dialog is used to choose a symbol to display in the Library viewer,
a race condition between the Library viewer GAL canvas and the dtor dialog that destroyed this link in the same instancied class.
Now, the SYMBOL_PREVIEW_WIDGET used in the dialog works on a local copy of the symbol to display.
2018-10-31 15:52:35 +01:00
c4cd81a906
Remove side-effect of LIB_FIELD::SetText().
...
Fixes: lp:1800545
* https://bugs.launchpad.net/kicad/+bug/1800545
2018-10-31 12:57:23 +00:00
6888268f74
Timestamps are long rather than int.
...
Fixes: lp:1800796
* https://bugs.launchpad.net/kicad/+bug/1800796
2018-10-31 10:19:59 +00:00
7b10490256
Library viewer: fix broken behavior of unit selector (could be Windows specific).
...
Remove a useless message in debug mode about LIB_ALIAS bounding box.
2018-10-30 17:51:12 +01:00
49c94fb928
Eeschema, library viewer: fix a Kicad assert.
2018-10-30 15:58:08 +01:00
4742c52250
Highlight symbol fields when selected.
2018-10-30 13:09:20 +00:00
364be90dc5
Fix translation issues with copy/paste block.
...
Also fix issues with paste not working at all from the context
menu in LibEdit.
Fixes: lp:1800513
* https://bugs.launchpad.net/kicad/+bug/1800513
2018-10-30 11:33:49 +00:00
4030eec939
Implement proper dangling end handling for block moves.
...
(Most of this is actually fixing the IsDanglingStateChanged() to
correctly indicate that it *updates* the dangling state, not just
tests it.)
2018-10-30 11:33:49 +00:00
b445b0fab2
Link eeschema with ngspice DLL
...
Adds a link-time dependency for libngspice, so that other tools may
detect ngspice as a KiCad dependency.
The library is still loaded with dlopen() as it gives a way to reload it
in case of problems. The DLL name is recognized during CMake
configuration and used to load the library at runtime.
2018-10-30 08:32:38 +01:00
4fc1f4db3e
LIB_ITEMs won't have parent in LibEdit.
2018-10-28 17:45:11 +00:00
a8c7bb0c92
Move library text items to LAYER_DEVICE. Only sch text items belong on LAYER_NOTES.
...
Fixes: lp:1800350
* https://bugs.launchpad.net/kicad/+bug/1800350
2018-10-28 17:45:11 +00:00
a96ebe8fac
Sort reference by their numeric content.
...
Fixes: lp:1464805
* https://bugs.launchpad.net/kicad/+bug/1464805
2018-10-28 17:45:11 +00:00
c49917c5a8
Dialog edit component in lib: Fix a few minor wxWidgets alerts.
2018-10-28 18:42:16 +01:00
d1db2c7621
Use fixed version for libngspice.so.0
...
CanonicalizeName only adds the lib prefix and .so suffix, so loading
libngspice.so fails until the development package is installed.
MAC/Windows code paths lookup soversion 0 of ngspice as well, as this
is the only compatible version.
2018-10-27 10:20:09 +02:00
4f11dc54fa
Draw selected child items in brightened colors.
...
Fixes: lp:1800114
* https://bugs.launchpad.net/kicad/+bug/1800114
2018-10-26 23:02:05 +01:00
c4ff17d3ec
Don't go to '-' numbering till the range reaches 3.
2018-10-26 23:02:05 +01:00
d953724365
Eeschema: fix bug: append schematic does not update canvas
...
Fixes: lp:1800144
https://bugs.launchpad.net/kicad/+bug/1800144
2018-10-26 16:42:14 +02:00
b075e76ede
Eeschema: fix a draw issue when aborting a move symbol field or a sheet pin.
...
The initial drawings were not updated, making the moved item invisible on screen.
Fixes: lp:1800142
https://bugs.launchpad.net/kicad/+bug/1800142
2018-10-26 15:27:20 +02:00
a3bbd32953
Fix minor compile warnings
2018-10-25 17:14:04 -07:00
ce34a713b4
Eeschema, make BOM tool add file dialog remember last used path.
...
Fixes lp:1797679
https://bugs.launchpad.net/kicad/+bug/1797679
2018-10-25 10:33:19 -04:00
3bf1dd7671
Eeschema, Hierarchical sheet: fix missing pen width call in draw function.
...
The hierarchical sheet was drawn (outline and texts) with a line thickness
that in fact the line thickness of the previously drawn item.
2018-10-25 15:12:34 +02:00
1baa904034
Dangling symbol fixes.
...
No dangling symbol for text items with a NO-CONNECT.
DanglingStateChanged doesn't work with dangling flag aggregators
(which return true if any child is dangling).
Then again, we don't actually use any of the aggregators anyway
so I removed them.
Fixes: lp:1799589
* https://bugs.launchpad.net/kicad/+bug/1799589
2018-10-24 23:51:18 +01:00
1f1bdc87bd
Update GAL with wire dimensions before changing them.
2018-10-24 23:18:53 +01:00
66a0f60b4c
Refresh preview items when Rotate or Mirror during move.
...
It's not enough to just refresh the canvas because the items are
hidden on the main canvas and copies are placed into the preview
group.
2018-10-24 22:00:50 +01:00
4524dce9bb
Tie up some loose ends from JP's SHEET_PIN fixes.
...
Fixes: lp:1799606
* https://bugs.launchpad.net/kicad/+bug/1799606
2018-10-24 22:00:50 +01:00
b9a9fe6c9e
Eeschema, remove option to import schematic that has not been remapped.
...
When importing an existing schematic into a sheet that was no remapped
to use the symbol library table, the user was given the option to ignore
the warning and proceed with the import. This would end up with all of
the imported symbol links being broke. In hindsight, this was a bad
idea so now the user cannot import schematics that have been remapped.
Fixes lp:1791280
https://bugs.launchpad.net/kicad/+bug/1791280
2018-10-24 15:38:02 -04:00
dc21a60531
Fix incorrect management of SCH_SHEET_PIN items when adding or removing them.
...
Especially new SCH_SHEET_PIN items were added twice, thus creating crashes.
Fixes: lp:1799606
https://bugs.launchpad.net/kicad/+bug/1799606
2018-10-24 16:19:28 +02:00
7d02c11880
Handle don't-always-display-cursor setting correctly.
...
Fixes: lp:1798448
* https://bugs.launchpad.net/kicad/+bug/1798448
2018-10-24 13:36:48 +01:00
c694c2e534
No more legacy graphics for eeschema.
2018-10-24 13:36:48 +01:00
96e65c7f23
Hide existing object when displaying moving preview.
...
Fixes: lp:1799478
* https://bugs.launchpad.net/kicad/+bug/1799478
2018-10-23 20:54:42 +01:00
0c06bdb1e0
Make sure aliases get their refs and values drawn correctly.
...
Fixes: lp:1799460
* https://bugs.launchpad.net/kicad/+bug/1799460
2018-10-23 20:54:42 +01:00
9f350820ad
Add field umbilical lines to GAL renderer.
2018-10-23 20:54:42 +01:00
1606329855
AdvanceDepth() strategy has been replaced with layer depths.
...
This is just a little bit of clean-up after-the-fact.
2018-10-23 20:54:42 +01:00
ce496ff993
libedit: refresh display after deleting graphic item.
2018-10-23 15:11:32 +02:00
3248c270ee
Update Eeschema BOM dialog html help text
...
Now links to relevant section in stable eeschema docs.
Fixes: lp:1798248
https://bugs.launchpad.net/kicad/+bug/1798248
2018-10-22 13:19:15 -04:00
7bba7a884a
Libedit: refresh display after creating/moving a graphic item
2018-10-22 13:41:38 +02:00
f17c18bcce
Remove AdvanceDepth() hacks in favour of proper layers.
...
Also removes the bounding-box cache since the last big merge
should have sorted out the Update(GEOMETRY) calls.
Fixes: lp:1797271
* https://bugs.launchpad.net/kicad/+bug/1797271
Fixes: lp:1797268
* https://bugs.launchpad.net/kicad/+bug/1797268
Fixes: lp:1797075
* https://bugs.launchpad.net/kicad/+bug/1797075
2018-10-21 15:55:56 +01:00
8ecdf58bad
Eeschema, load a new bitmap image from file: fix crash when aborting.
...
Remove duplicate code in edit_bitmap.cpp.
2018-10-21 10:59:06 +02:00
dafeb96765
Page layout bitmap size wrong in modern/GAL canvases.
...
The image scale set by pl_editor was not taken in account when drawing the page layout.
Fixes: lp:1798685
https://bugs.launchpad.net/kicad/+bug/1798685
2018-10-20 18:24:22 +02:00
576a0af293
Eeschema: make draw functions working with "old" libraries using a useless large negative line width (like -1000 or -2000 mils).
...
They are now clamped to -1.
This is only a workaround to avoid ugly artifacts
2018-10-20 13:08:33 +02:00
1116acd74b
Libedit: Fix broken handling of "common to all bodu style" property of lib draw items.
...
Fix a minor wxWidgets assert.
2018-10-20 12:38:36 +02:00
9757107b61
Spice netlist exporter: handle multiline directives
...
Fixes: lp:1797937
* https://bugs.launchpad.net/kicad/+bug/1797937
2018-10-19 17:33:01 +02:00
8f9b0f0235
Eeschema, spice netlist exporter: fix an issue that converted spice string commands to lowercase.
...
Therefore, it can breaks some commands, especially filenames.
Partial fix of bug 1797937.
2018-10-19 16:18:30 +02:00
c06e533689
Add hack to Resolve all symbols when painting.
...
Seems rather expensive, but this is what the Legacy canvas did.
In fairness, it does check the last-mod-date of the libraries
and skips it if they haven't changed.
Fixes: lp:1798446
* https://bugs.launchpad.net/kicad/+bug/1798446
2018-10-18 14:14:54 +01:00
baa4019448
Draw pin previews with the correct schematic background color.
...
Fixes: lp:1798447
* https://bugs.launchpad.net/kicad/+bug/1798447
2018-10-18 13:27:41 +01:00
c052b7f8ef
Fix segfault when deleting sheet pins.
2018-10-18 13:27:41 +01:00
8a54b1b3b7
Add view refresh calls for edit operations.
...
Note that the bug referenced in the "fixes" section is only one
of many addressed by this commit.
Fixes: lp:1798449
* https://bugs.launchpad.net/kicad/+bug/1798449
2018-10-18 12:12:48 +01:00
12567c7500
eeschema-gal: don't warp cursor back to mouse when using hotkey to emulate a mouse click
...
Fixes: lp:1797273
* https://bugs.launchpad.net/kicad/+bug/1797273
2018-10-17 23:25:36 +02:00
c22a247dbc
Fix undo issue primarily with libedit.
...
Fixes: lp:1797900
* https://bugs.launchpad.net/kicad/+bug/1797900
2018-10-17 13:10:36 +01:00
254e9f4a7e
Implement HardRedraw for eeschema and libedit.
2018-10-17 12:14:09 +01:00
e9a80a5d7f
Some minor dialog layout fixups.
2018-10-17 11:23:02 +01:00
924c0fa9ed
Fetch symbol chooser grid settings from the right place.
2018-10-17 11:14:01 +01:00
c19984e4de
Performance optimization for Symbol Fields Editor.
2018-10-17 02:04:44 +01:00
08e1379671
Add new sheet pins to view.
2018-10-16 22:54:12 +01:00
84c14c2971
Fix updating of the schematic symbols after a library save.
2018-10-16 17:07:59 +01:00
1114b5cfa9
Refresh item when its dangling state changes.
...
Fixes: lp:1797996
* https://bugs.launchpad.net/kicad/+bug/1797996
2018-10-16 17:07:59 +01:00
61f2dd21b1
Eeschema gal: fix some redraw issues for bitmap images and worksheet.
...
After edition, the worksheet was not updated on screen.
Bitmap images were not shown in opengl mode due to the fact all gal layers were cached.
2018-10-16 14:20:09 +02:00
7c960aa5fe
Eeschema: better limit for zoom out level
...
Fixes: lp:1797995
https://bugs.launchpad.net/kicad/+bug/1797995
2018-10-16 09:25:00 +02:00
5fe523f534
Place object borders in front of background fills.
...
This is required when rendering from the cache as the hardware
doesn't necessarily draw in the same order.
2018-10-15 19:59:47 +01:00
906c08afc6
Cross probing: ensure highlighted net in Eeschema is shown when cross probed from Pcbnew.
2018-10-15 20:16:48 +02:00
d66e0d4f7a
eeschema-gal: implemented EnableDepthTest() in GAL, fixed drawing order in eeschema
2018-10-15 00:09:59 +02:00
0777d11188
Eeschema Better fix for highlight visibility issue for cached items due to last change in code in opengl
2018-10-14 14:59:40 +02:00
9a62f508a4
Revert "Eeschema Fix highlight visibility issue for cached items due to last change in code"
...
This reverts commit b389236a72
2018-10-14 14:57:45 +02:00
b389236a72
Eeschema Fix highlight visibility issue for cached items due to last change in code
2018-10-14 12:47:06 +02:00
fff739631c
EEschema: fix wrong pin rendering for pin style PINSHAPE_OUTPUT_LOW
...
Fixes: lp:1797750
https://bugs.launchpad.net/kicad/+bug/1797750
2018-10-14 12:36:02 +02:00
0bd0558833
Auto-select reference numbers in PcbNew like we do in Eeschema.
2018-10-14 00:06:41 +01:00
275d5e336f
Fix issue with component children disappearing when canvas origin not in view.
2018-10-13 20:54:50 +01:00
29e0e6921b
Turn on OpenGL caching. Time to smoke out the bugs.
2018-10-13 15:53:54 +01:00
650478f757
Eeschema, highlight connection: show selected junctions and labels in highlight color
...
Previously, only wires were shown in highlight color.
2018-10-13 16:12:36 +02:00
9df7626e31
Fix issue: Symbol library editor: Moving pins jumps to origin
...
Also: remove outdated lines in code.
Fixes: lp:1797266
https://bugs.launchpad.net/kicad/+bug/1797266
2018-10-13 12:09:49 +02:00
aa622994e1
eeschema: Ensure is_moved flag is set when moving
...
Prior to placing, cleaning routines need to know which schematic items
are being moved to avoid cleaning them relative to themselves. The
IS_MOVED flag communicates this and is cleared by ClearDrawingState()
Fixes: lp:1797576
* https://bugs.launchpad.net/kicad/+bug/1797576
2018-10-12 17:08:10 -07:00
e988cd9c25
Fixed crash in footprint chooser in eeschema triggering in standalone/no-pcbnew mode
...
Fixes: lp:1797644
* https://bugs.launchpad.net/kicad/+bug/1797644
2018-10-12 23:43:08 +02:00
30f0e93dbb
Synchronize the GAL view after invoking 'autoplace fields' tool
...
Fixes: lp:1797268
* https://bugs.launchpad.net/kicad/+bug/1797268
2018-10-12 23:27:39 +02:00
92758ea4ef
eeschema: Fix minor compile warning
2018-10-11 15:31:10 -07:00
4f672f0d39
Fixing a number of dynamic_casts
...
Dynamic casts should only be used when we explicitly check for the
resulting pointer to be NULL. Where we know the class is castable we
can use static_cast, save on overhead and ensure our resulting pointer
is non-null.
2018-10-11 15:24:12 -07:00
dff92f915c
eeschema: Formatting grid table
...
Missing breaks could cause grid table to return odd text for bad values.
With the breaks, odd values are flagged for fixing
2018-10-11 14:45:23 -07:00
bfa7f16b44
Wrap printfs in DBG defines
...
This places the remaining printf statements behind DBG() macros to
suppress their output on release builds. We should remove these prior
to 5.1
2018-10-11 13:32:20 -07:00
4904ece0b5
eeschema gal: keep grid visibility setting when switching between back-ends
2018-10-11 18:45:18 +02:00
4d8534a7a6
libedit: Prevent segfault when deleting part
...
emptyScreen() sets the current part to NULL. This gracefully handles
the case by allowing a cleared screen when no part is currently
selected.
2018-10-11 09:22:54 -07:00
5c8c1cdb8f
Eeschema doesn't show highlight net until a screen redraw is made.
...
Fixes: lp:1796989
https://bugs.launchpad.net/kicad/+bug/1796989
2018-10-11 14:19:29 +02:00
bea75753dd
Eeschema fix: highlight component from pcbnew doesn't switch sheets
...
Fixes: lp:1797249
https://bugs.launchpad.net/kicad/+bug/1797249
2018-10-11 11:28:07 +02:00
0dfd0c5f52
Minot cosmetic enhancement
2018-10-11 11:26:59 +02:00
0090bea24e
eeschema-gal: cache & update bboxes of EDA_ITEMS on each redraw
2018-10-10 17:27:21 +02:00
9b027628ef
Symbol editor: Fix usability issues of mirror and rotation commands
...
Fix also mirrorX and mirrorY command to have the same behavior as the schematic editor
Fixes: lp:1797090
https://bugs.launchpad.net/kicad/+bug/1797090
2018-10-10 16:42:58 +02:00
06dccf715d
Code cleanup.
2018-10-10 14:28:03 +01:00
779ef044b7
Fix wxGrid column dragging bugs.
...
Close an open editor when dragging (as wxWidgets won't move it).
Make sure native column headers aren't in use where we need dragging:
their interaction with wxWidgets' dragging is buggy.
Fixes: lp:1796398
* https://bugs.launchpad.net/kicad/+bug/1796398
Fixes: lp:1796396
* https://bugs.launchpad.net/kicad/+bug/1796396
2018-10-09 21:33:43 +01:00
5f0ffe8490
Copy isDangling flag when changing label type.
...
Fixes: lp:1796775
* https://bugs.launchpad.net/kicad/+bug/1796775
2018-10-09 21:33:43 +01:00
55c1ca1191
Handle pin sorting properly for values.
...
The pin number sorter doesn't handle units at all, and seems to
stumble on negative numbers.
Fixes: lp:1796869
* https://bugs.launchpad.net/kicad/+bug/1796869
2018-10-09 14:56:29 +01:00
cbf74d6939
Fix off-grid block paste
...
Center point of a block may not always be located on a grid point,
therefore it needs to be rounded to the grid size to prevent off grid
component placement.
2018-10-09 11:08:56 +01:00
6e2b7521d0
Coding style and lint fixes.
2018-10-09 11:08:56 +01:00
06e63c3073
Add control over worksheet colour in eeschema.
2018-10-09 11:08:56 +01:00
637029c292
Remove polygon fix as it causes more issues than it solves.
2018-10-09 11:08:56 +01:00
5a910e9ee3
Make sure filled polygons are closed when rendering.
2018-10-09 11:08:56 +01:00
4a65df8281
Add default case in edit_label.cpp (-Wswitch)
...
This should never ben hit as it's defended against above,
but lack of a default causes lots of -Wswitch warnings, so
add an assert and a return.
2018-10-09 11:08:56 +01:00
9dfcc839a4
Fix color issues with cursor and sheet pins.
2018-10-09 11:08:56 +01:00
4a92a5e628
Fix a Eeschema crash when using a SYMBOL_PREVIEW_WIDGET. Fix also a few draw artifacts.
2018-10-09 11:08:56 +01:00
a6d014d959
Fix some artifacts when drawing items, both on Cairo and Opengl.
...
Fix also incorrect selection of De Morgan style selection in SYMBOL_PREVIEW_WIDGET.
2018-10-09 11:08:56 +01:00
2d5baac77d
Fix up zoom and pan issues entering/leaving sheets.
2018-10-09 11:08:56 +01:00
929786ce50
Fixes to grid color and some more CLangTidy fixes.
2018-10-09 11:08:56 +01:00
0af31e1bf0
Fix CLangTidy warnings and improve SNR.
2018-10-09 11:08:56 +01:00
0058ef5825
Eeschema: fix a crash at startup in OpenGL engine, when Eeschema is started from Kicad.
...
Can be platform dependent. The crash was due to a wxPaintEvent fired before the GAL engine is fully initialized.
2018-10-09 11:08:56 +01:00
88cdce8d62
Make SYMBOL_PREVIEW_WIDGET working, and using the canvas type of the caller. Fix an issue with F3 zoom key in libedit.
2018-10-09 11:08:56 +01:00
6f89b41f18
Cleanup.
2018-10-09 11:08:56 +01:00
3b59c6cf0a
Don't add item to view twice.
2018-10-09 11:08:56 +01:00
33386ec980
Fix zoom issues in Eeschema (F1 to F4 and popup zoom commands) Fix also not saving the Gal Canvas type on eeschema exit.
2018-10-09 11:08:56 +01:00
f283667fb0
add option to switch between opengl and cairo in eeschema (step 1)
2018-10-09 11:08:56 +01:00
f9faa6ea16
Reduce "Clarify Selection" menus.
2018-10-09 11:08:56 +01:00
97c83766db
Refresh issues around sheet pins.
2018-10-09 11:08:56 +01:00
96724af2c4
Ensure junctions and no-connects are visible even on fat wires.
...
Also adds a preference for junction size.
Fixes: lp:1545422
* https://bugs.launchpad.net/kicad/+bug/1545422
2018-10-09 11:08:56 +01:00
ca3751fbbb
Add GAL refresh for some more commands and remove unused DC params.
2018-10-09 11:08:56 +01:00
8e09aa554a
Improve dangling pin drawing logic.
2018-10-09 11:08:56 +01:00
268565ee41
Refresh component when children change.
2018-10-09 11:08:56 +01:00
37cfa3fed9
Cleanup unused and redundant stuff.
2018-10-09 11:08:56 +01:00
e2ea9b772a
Fix offset issue when moving text.
2018-10-09 11:08:56 +01:00
d9d2822fe0
Fix cross-probing.
2018-10-09 11:08:56 +01:00
9f9251c11d
Minor code cleanup.
2018-10-09 11:08:56 +01:00
2b6e3de90e
Get rid of asserts when adding line segments.
2018-10-09 11:08:56 +01:00
1a0f3b79cc
Fix SCH_BITMAP handling in gal.
2018-10-09 11:08:56 +01:00
e55763947e
Set the reight grid visibility at start. Display axis in libedit and viewlib.
2018-10-09 11:08:56 +01:00
98296334fd
Hook up panning options to GAL canvas.
2018-10-09 11:08:56 +01:00
5b602d02ab
Set block start position when grabbing single items.
2018-10-09 11:08:56 +01:00
6f0c6f946c
Fixup some more cursor issues.
2018-10-09 11:08:56 +01:00
b09a4b341c
Update moved items so they get reinserted into the RTree.
2018-10-09 11:08:56 +01:00
fee52e127f
Add line style drawing.
2018-10-09 11:08:56 +01:00
808beed191
Warp pointer after context-menu duplicate.
2018-10-09 11:08:56 +01:00
1e3a5c1b21
Fixup of last commit.
2018-10-09 11:08:55 +01:00
0063f2c12d
Stroke rectangles after filling so fill doesn't cover 1/2 of stroke.
2018-10-09 11:08:55 +01:00
48688b5074
Hook up "always show cursor" preference.
2018-10-09 11:08:55 +01:00
f1346030d7
sch_painter.cpp: fix a few incorrect color selections Fix also dangling symbol thickness of bus entries
2018-10-09 11:08:55 +01:00
4fe58922aa
Draw lines in wire, bus, or graphic color.
2018-10-09 11:08:55 +01:00
fa0124bee7
Enforce a minimum line thickness for labels.
2018-10-09 11:08:55 +01:00
4161bb6756
Overhaul block logic to support rotate/mirror on the fly.
...
The old code delayed duplicating till the end which means the
rotate/mirror would affect the original, and then be duplicated
leaving the original incorrectly rotated/mirrored.
2018-10-09 11:08:55 +01:00
906c52deff
minor compil warnings and drawings fix
2018-10-09 11:08:55 +01:00
3c82ad3220
Finish up the block rotate/mirror fixes.
...
Block rotate and mirror now work like they do in Pcbnew (that is
they're treated as part of the block move/duplicate/whatever
rather than finishing it).
Fixes: lp:1780794
* https://bugs.launchpad.net/kicad/+bug/1780794
2018-10-09 11:08:55 +01:00
924e56e076
WIP for block rotate and mirror.
...
Block rotate now doesn't drop the block, but it does introduce one
extra undo step per rotate.
Fixes: lp:1780794
* https://bugs.launchpad.net/kicad/+bug/1780794
2018-10-09 11:08:55 +01:00
7216eda202
Fix bugs in block operations.
...
1) when duplicating don’t keep original hidden until end of drag
2) reset selectionArea when showing it so it doesn’t flash in its previous location
3) center a pasted block on the cursor
4) don’t draw the source selectionArea when pasting a block
5) implement selection-style highlighting for contents of blocks
6) add pasted items to view so they don’t disappear when the block is placed
Fixes: lp:1747197
* https://bugs.launchpad.net/kicad/+bug/1747197
2018-10-09 11:08:55 +01:00
27df8937b8
Apply a bit of transparency for body backgrounds while dragging.
2018-10-09 11:08:55 +01:00
7d5e4de815
Implement MoveCursorToCrossHair.
2018-10-09 11:08:55 +01:00
cb8e6c0df5
Handle GAL view refresh for breaking wires.
2018-10-09 11:08:55 +01:00
38f38b16c0
Fix dissappearance of moved items.
2018-10-09 11:08:55 +01:00
5fd20ee786
Implementation of ERC markers.
2018-10-09 11:08:55 +01:00
47189034aa
Grid settings for LibEdit.
2018-10-09 11:08:55 +01:00
e45e3b3640
Fix bug with Preferences turning hidden items to black.
2018-10-09 11:08:55 +01:00
bbe1d996fd
Fix initialization order issue when switching symbols in LibEdit.
2018-10-09 11:08:55 +01:00
269e8159d4
Grid settings for LibEdit.
2018-10-09 11:08:55 +01:00
9e9db3afe5
Start an empty document with a reasonable grid size.
2018-10-09 11:08:55 +01:00
d7178c7833
Implement GAL refresh for a bunch of operations.
2018-10-09 11:08:55 +01:00
afeebc8944
Grid settings for Eeschema GAL.
...
Split antialiasing options out from display options. Move
antialiasing to common. Duplicate the rest of display options
for Eeschema.
Implement OnSelectGrid and hookup GAL canvas refresh to
SetPresetGrid.
Add Grid Settings... to View menu and move Show Grid from
preferences to View Menu to match Pcbnew.
2018-10-09 11:08:55 +01:00
8390b7a7ac
Don't paint GAL canvas when it isn't shown.
...
Fixes: lp:1790502
* https://bugs.launchpad.net/kicad/+bug/1790502
2018-10-09 11:08:55 +01:00
c5330ac0bf
Implement zoom for GAL canvas.
2018-10-09 11:08:55 +01:00
a67d8c60df
Fix text size measurement.
...
5.0 doesn't set the GAL's line width. It gets away with this since
it's using the same GAL to measure as to set up the drawing, so
the width happens to be set correctly for other reasons. 5.1 uses
a separate GAL and so isn't so lucky.
2018-10-09 11:08:55 +01:00
1c52824913
Rewrite unit/convert handling so it also works for LibEdit.
2018-10-09 11:08:55 +01:00
e9c974fcdc
Fix issues with orientation and justification.
...
Support all symbol orientations. (Yes, SCH_COMPONENT said only the
first 8 were used, but it lied.)
Fix cases where SetTextAttributes() was overwriting previously-
set justifications.
Correct rotation of vertical text.
Fix issue where bold global label would affect thickness of next
label's outline.
2018-10-09 11:08:55 +01:00
c3479154ca
Fix draw order issues in eeschema and libedit.
...
Eeschema (where only the parent component is in the view) uses
draw order.
LibEdit (where the individual items are in the view) uses the
viewPriority setting.
2018-10-09 11:08:55 +01:00
917943f8f8
Uniform handling of hidden objects.
2018-10-09 11:08:55 +01:00
17ce36d4b7
Add dangling end support for lables and lines.
2018-10-09 11:08:55 +01:00
6eafb9a2fd
Convert Rescue Symbols dialog previews to GAL.
2018-10-09 11:08:55 +01:00
893f7641ce
Handle hidden and dangling pins.
2018-10-09 11:08:55 +01:00
8a017d99d2
Fix pin drawing offsets and implement electrical type drawing.
2018-10-09 11:08:55 +01:00
538a5d49ee
Fix up GAL version of Symbol Viewer.
...
Also includes some preliminary work for supporting hidden pins,
pin electrical names, and other preferences.
2018-10-09 11:08:55 +01:00
da4fb4ae3a
Move galDisplayOptions access from pcbnew to common.
2018-10-09 11:08:55 +01:00
a03dc577f8
Add support for units.
2018-10-09 11:08:55 +01:00
7cbfa08ddd
Move symbol chooser dialog preview to GAL.
2018-10-09 11:08:55 +01:00
8e915ae8d8
Add support for LIB_ALIAS objects.
2018-10-09 11:08:55 +01:00
8b4f01b6b7
Add common property initialisation to sch_draw_panel.
2018-10-09 11:08:55 +01:00
a3563851b2
eeschema-gal: started work on library viewer canvas
2018-10-09 11:08:55 +01:00
48d36f854e
eeschema-gal: fix cursor shape switching
2018-10-09 11:08:55 +01:00
ccb594f599
eeschema-gal: support for global labels and bitmaps
2018-10-09 11:08:55 +01:00
d8b9899516
eeschema-gal: configurable worksheet & grid colors
2018-10-09 11:08:55 +01:00
5f7c923b8b
eeschema-gal: post-rebase fixes
2018-10-09 11:08:52 +01:00
90c7c60471
eeschema-gal: initial GALified version. Lots of stuff still to do!
2018-10-09 11:08:52 +01:00
14fed877c8
eeschema-gal: factor out libedit controller code into separate directory
2018-10-09 11:08:52 +01:00
c024fce625
eeschema-gal: moved libedit to a separate directory
2018-10-09 11:08:52 +01:00
cb90e5b9e2
libedit: Fix memory leak
...
The copy of the original lib_part was not released when aliases could
not be located.
2018-10-08 09:51:26 -07:00
d2906f7975
eeschema: fix mistaken wire removal bug
...
The wire between two points should not be trimmed if it starts or ends
on one of the component's connection points.
2018-10-08 08:42:06 -07:00
90df7a8b22
Sort references before removing duplicates.
...
std::unique only works within consecutive blocks, so the list must
be sorted first. (We need it sorted in the end anyway, so no
big deal.)
2018-10-08 00:14:07 +01:00
34ea79eddb
Fix LIB_ID illegal character tests.
...
The '/' and ':' are reserved and cannot be used in symbol or footprint
names. They will cause the LIB_ID parser and formatter to fail. While
it seems like they should be legal in symbol alias names, they will
trigger a symbol rescue the next time the schematic is loaded.
Use ID_SCH as in the Eagle schematic plugin rather than ID_ALIAS to
ensure symbol names do not need rescued the next time the schematic is
opened.
Remove ID_ALIAS since the rules for alias names are the same as the
rules for symbol names. Otherwise, allowing '/' and ':' in alias names
will force a symbol rescue on the next schematic load.
Fixes lp:1795600
https://bugs.launchpad.net/kicad/+bug/1795600
2018-10-07 09:09:27 -04:00
9a213207fb
Clearer titles for editing board footprints.
...
Also cleans up the naming on the symbol editor side.
2018-10-05 14:17:58 +01:00
8015334683
Don't resize hidden columns.
...
wxGrid columns are hidden by setting their width to 0. Resizing
them will "unhide" them.
Fixes: lp:1796150
* https://bugs.launchpad.net/kicad/+bug/1796150
2018-10-05 14:17:58 +01:00
c9ca1013b2
Make ModEdit and LibEdit library tree actions more consistent.
...
Adds Cut/Copy/Paste and Revert for footprints; introduces a new
shared Revert Changes? dialog; hooks up Add Library for footprints,
standardizes the Save As terminology.
2018-10-03 22:46:41 +01:00
3c2aafd7b7
Move Edit Symbol References to standard text/button control.
2018-09-29 22:07:31 +01:00
094f340359
Eeschema: Opening "Edit Symbol Fields" dialog crashes Eeschema
...
Fixes: lp:1795088
https://bugs.launchpad.net/kicad/+bug/1795088
2018-09-29 10:08:29 +02:00
19b1ae35ce
Don't assume GetFlags() != 0 means it's being edited.
...
It could just mean it's selected, highlighted or brightened.
Fixes: lp:1794624
* https://bugs.launchpad.net/kicad/+bug/1794624
2018-09-27 22:18:13 +01:00
6fdfd0932e
Use newer wxWidgets calls (old ones aren't available on MSW).
2018-09-27 18:53:46 +01:00
5703060d87
Turn off escaping names for now.
...
Fixes: lp:1794816
* https://bugs.launchpad.net/kicad/+bug/1794816
2018-09-27 17:21:49 +01:00
e456ecd0a1
Calculate column widths based on all data, not just shown data.
...
Also caps the calculated width at 1/3 of the default dialog width.
Fixes: lp:1794625
* https://bugs.launchpad.net/kicad/+bug/1794625
2018-09-27 16:57:25 +01:00
521183a587
Work in progress to allow arbitrary chars in references, etc.
2018-09-27 11:56:51 +01:00
618374db88
eeschema: Re-add auto-wire removal
...
Somewhere during v5 rc cycle, the trimming of wires laid over simple
components was removed. The wires were still removed as soon as the
user moved the component again. This corrects the first behavior to
intended action for simple components.
Fixes: lp:1794019
* https://bugs.launchpad.net/kicad/+bug/1794019
(cherry picked from commit 9831a14ef3
2018-09-24 08:31:50 -07:00
1253020a8b
Add missing header
2018-09-24 10:47:15 -04:00
c95c6c8db7
Scroll library into view after open from Kicad app.
...
Fixes: lp:1793621
* https://bugs.launchpad.net/kicad/+bug/1793621
2018-09-24 15:46:45 +01:00
533b26e8a1
Add hotkey for viewing symbol datasheet.
...
Also fixes a bug when there are multiple datasheets to choose from.
Fixes: lp:1793978
* https://bugs.launchpad.net/kicad/+bug/1793978
2018-09-24 15:46:45 +01:00
3c86bc951a
Eeschema: fix yet another lock file issues.
...
Reset lock file when saving a schematic sheet to a different file name.
This prevents a file is already open error from being displayed when
opening the original file.
Fixes lp:1788507
https://bugs.launchpad.net/kicad/+bug/1788507
2018-09-24 08:59:03 -04:00
b70d0f43b6
Fix minor compil warnings.
2018-09-24 13:12:47 +02:00
85ef058458
Spice simulator: change gain units to dBV
2018-09-22 19:05:04 +02:00
e6f2c49eae
Spice model editor: support for JFET models
2018-09-22 19:05:01 +02:00
f2f6dffd16
Refactored logic in Spice model editor dialog
...
- Removed redundant enums
- Stored Spice model description in an array
- Made code generic by using the model description array
2018-09-22 19:04:54 +02:00
5974899fa5
Clean up file locations and names.
2018-09-22 16:23:13 +01:00
618182dcd6
Use pin number sorting algorithm in pin table.
...
Fixes: lp:1793180
* https://bugs.launchpad.net/kicad/+bug/1793180
2018-09-19 22:23:18 +01:00
3f7e5d2ce4
Eeschema: fix minor bug in block handler.
...
Under certain conditions, it was possible for the block handler to be
entered with no mouse capture callback which would raise a rather
cryptic error message to the user. This should have always been an
assertion so users will not see this issue in release builds.
Fixes lp:1791839
https://bugs.launchpad.net/kicad/+bug/1791839
2018-09-19 15:32:51 -04:00
0b39b68d37
Generate error dialog when a symbol library can't be found.
...
Fixes: lp:1789047
* https://bugs.launchpad.net/kicad/+bug/1789047
2018-09-17 18:01:08 +01:00
e45afdb912
Revert absolute-path asserts and fix off-by-one bug.
...
Fixes: lp:1767582
* https://bugs.launchpad.net/kicad/+bug/1767582
2018-09-15 22:36:09 +01:00
02a3f83040
Implement poor-man's RTTI for use over KiWAY.
...
Fixes: lp:1777883
* https://bugs.launchpad.net/kicad/+bug/1777883
2018-09-15 20:06:42 +01:00
872e1e6532
Remove asserts for absolute paths.
...
You can, for instance, specify relative paths via the command
line.
Fixes: lp:1767582
* https://bugs.launchpad.net/kicad/+bug/1767582
2018-09-15 20:06:42 +01:00
3e61a32fbe
Attempt to use envVars when adding new libraries.
...
Fixes: lp:1785441
* https://bugs.launchpad.net/kicad/+bug/1785441
2018-09-15 20:06:42 +01:00
cac7479e33
Eeschema, fix broken instances of symbols in rescue dialog.
...
The symbol library table rescue candidate was only using the item name
of the library ID object which was being compared to the fully formatted
library ID causing a comparison failure so no instances of any rescued
symbols was shown in the dialog.
Fixes lp:1791805
https://bugs.launchpad.net/kicad/+bug/1791805
2018-09-14 17:42:14 -04:00
243b05b2c3
Fix range-based reference formatter.
...
Fixes: lp:1792483
* https://bugs.launchpad.net/kicad/+bug/1792483
2018-09-14 13:05:13 +01:00
Maciej Suminski
jean-pierre charras
Frank Severinsen
Seth Hillbrand
Jeff Young
Wayne Stambaugh
D4p0up
John Beard
Stefan Brüns
Michael Kavanagh
Tomasz Włostowski
Simon Richter