059a95a2f2
Lock generated tracks when routing.
...
Otherwise they lose their group status when being replaced by the
router (even if they weren't otherwise modified).
2023-10-19 11:39:01 +01:00
24ddc728e8
Add PCB_ACTIONS::regenerateAllTuning....
...
... and move GENERATOR_TOOL to RegenerateAllOfType().
2023-10-19 11:20:09 +01:00
7447700735
Fix typo.
2023-10-19 11:20:09 +01:00
16ec0faa7a
Reduce line-breaking.
...
Also simplifies handling of generator properties dialogs.
2023-10-19 11:19:57 +01:00
67f0f6e3b9
Rename class to match current terminology.
2023-10-19 01:31:13 +01:00
b089630b4c
Simplify Import Graphics.
...
Removed no-longer-required differentiation between importing
footprint vs board objects.
Renamed files to match the dialog.
Made Position At and Set Layer optional checkboxes.
Removed Group Items checkbox. (In the unlikely event that you don't
want a group, do an UnGroup after importing.)
Flattened out labelled-sizers in the dialog.
Removed importers blacklist, which hasn't been active for at least 4
years.
Fixed undo/redo bug that caused items to be no-longer-grouped after
a redo.
2023-10-19 01:31:13 +01:00
70917a14e7
Route from end: fix crash and snapping bug
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13992
2023-10-18 12:32:32 -04:00
5cd5194e89
SCH/PCB: warn before deleting footprint-only fields on sync
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15342
2023-10-18 11:33:17 -04:00
599a8304a6
Pcbnew, ConnectBoardShapes(): do not add 0 size segments to outlines.
...
Add also our standard copyright text.
2023-10-18 11:14:43 +02:00
db9734923c
DIALOG_CLEANUP_GRAPHICS: fix incorrect parameter passed to cleaner.CleanupBoard().
...
The fix board outlines was in fact always activated.
2023-10-18 09:40:26 +02:00
4ed8b14c12
Fix Mac build
...
Clang requires tighter forward declaration of derived enums
2023-10-17 09:26:00 -07:00
e793e30360
Fix typo.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15881
2023-10-17 13:34:58 +01:00
e5225abb62
Tuning mode is invariant.
...
Don't show target skew for length tuning, and don't show
target length for skew tuning.
2023-10-17 13:30:58 +01:00
89011e888c
More modern look & feel for tuning status popup.
...
(Also includes min and max info, and move string processing out
of router.)
2023-10-17 13:30:58 +01:00
390bd44f18
Cleanup.
2023-10-17 13:30:58 +01:00
9ed802e951
Support min/max rules in diff pair placer and skew placer.
2023-10-17 13:30:58 +01:00
9c4bb464ac
Improve tuning status popup colours.
2023-10-17 13:30:58 +01:00
f629898c8b
Coding policy fixes.
2023-10-17 08:07:15 -04:00
be1008cbd8
ADDED: Heal Shapes; Fix discontinuities in gfx import and Cleanup dialog.
2023-10-17 10:29:43 +03:00
bee6e6be01
AddMenuLanguageList should live in EDA_BASE_FRAME, its only user
2023-10-16 19:49:52 -04:00
584757f2df
Move the menu helpers to ui_common instead of sitting in bitmap for some reason
2023-10-16 19:40:46 -04:00
ba83e84b91
Move SaveCanvasImageToFile to EDA_DRAW_FRAME rather than leaking things to bitmaps
2023-10-16 18:33:11 -04:00
9d4e0ba439
add python api FocusOnItem
2023-10-16 22:28:47 +00:00
b5eee9dd7e
Coverity warning fixes.
2023-10-16 17:04:14 -04:00
a2e35aabae
Trim meander group items to just the tuning pattern.
2023-10-16 13:44:05 +01:00
2c9d43474d
Formatting.
2023-10-16 13:44:05 +01:00
64cc8dd6aa
Adjust dashed-box and edit-point locations to be outside meanders.
2023-10-16 13:44:05 +01:00
d51e058e24
Move diff-pair netname resolution to BOARD.
...
Also adds reporting of dp gap constaints and max uncoupled to track
selections, and max uncoupled during routing.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13748
2023-10-15 22:46:23 +01:00
2c02c26af4
Centralize min/opt/max printing.
2023-10-15 22:46:23 +01:00
ccc20348bf
Don't start with MEANDER_SIDE_DEFAULT.
...
It means we get a different default for left-to-right-drawn than we
do when going the other way.
Also fixes bug in PNS::DP_MEANDER_PLACER so that it honours side
specified in settings.
2023-10-15 17:59:11 +01:00
2450250ae7
Use "tuning pattern" in the GUI.
2023-10-15 17:59:11 +01:00
6baac175c5
Status bar messages for meanders.
2023-10-15 17:59:11 +01:00
2b28580f0c
Comments.
2023-10-15 17:59:11 +01:00
7efd414519
Fix minor Coverity and compil warnings
2023-10-15 15:55:31 +02:00
fd887ba929
Altium: support importing a single footprint.
2023-10-15 06:31:00 +03:00
254c8accc2
Remove some debugging messages.
2023-10-15 03:28:25 +03:00
d5d07e64c9
Use IsShownOnScreen(), not IsShown(), if you really want to know if its visible.
2023-10-14 23:51:37 +01:00
a16bdb7288
ADDED: Support EAGLE libraries directly in Symbol Library Table.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2214
2023-10-15 01:45:39 +03:00
9ed19192de
Improve editing values with {return} in text fields; Add hyperlink detection.
2023-10-15 01:45:39 +03:00
14d5a404b2
Don't leave deleted items in a group.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15797
2023-10-14 18:23:51 +01:00
504652b972
Regularize RunOnChildren() at the BOARD_ITEM level.
...
BOARD_ITEM sub-classes which don't have children simply don't
overrid it.
2023-10-14 15:04:18 +01:00
8028ea893f
Reduce public API of PCB_GENERATOR_MEANDERS.
...
It doesn't make a huge difference because the class is declared in
the .cpp file, but it still makes it easier to understand what is
conceptually public and what is not.
2023-10-14 15:04:18 +01:00
5f5113c80a
Pick up current rule values when editing meanders.
2023-10-14 15:04:18 +01:00
61bdee027b
Fix a crash when using length tuning tools.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15874
2023-10-14 16:53:28 +03:00
f7ed9cc5c7
Fix loading thru-hole pads when drill token is missing.
2023-10-14 15:42:13 +03:00
83af481688
Improve EAGLE file header detection.
2023-10-14 15:42:13 +03:00
805f1dfbc5
Pcbnew: when adding layers, do not change via layers.
...
Via layers are not defined by a LSET, and the code that used the new LSET
broke the Via start and/or end layers (for blind/buried vias)
Fixes #15856
https://gitlab.com/kicad/code/kicad/-/issues/15856
2023-10-14 08:48:22 +02:00
0a111e9fbb
Hook up layer-toggle command to router.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15812
2023-10-13 21:33:27 +01:00
2bc273f8bc
Don't fire event-parameter asserts when looking for a click event.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/KICAD-2CK
2023-10-13 20:31:01 +01:00
8d3047d6eb
Clear selection before deleting board layers.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15866
2023-10-13 18:20:33 +01:00
a69869f72a
Simplify undo/redo for pad edit mode.
...
Also simplifies high-contrast-mode handling to fix a bug when exiting
pad edit mode via an undo.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15845
2023-10-13 13:59:31 +01:00
62d959ed0e
Don't assume an error location for PAD::GetEffectivePolygon().
...
While ERROR_INSIDE was good for plotting, 3D generation, etc., it's
not good for generating router hulls.
Also reverts part of the change to always use polygons for PNS::SOLIDs. A single shape in a SHAPE_COMPOUND will be faster (and
more accurate).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14898
2023-10-13 13:59:26 +01:00
38c7fa6db9
Pcbnew: do not display the outlines of a very special zone used by DRC
...
to show layer mask bridges created by DRC to show these bridges.
This is not a real ZONE, just a container to displays these filled areas.
2023-10-13 14:25:49 +02:00
57efde1bbb
Pcbnew: rename ZONE* m_SolderMask to m_SolderMaskBridges
...
(It is a container to build bridges on solder mask layers by DRC, not real zone)
Disable also this special zone selection by adding it in
PCB_SELECTION_TOOL::itemPassesFilter
2023-10-13 09:57:21 +02:00
96f9f2c658
PNS: Allow for approximation error in hull clearance
...
Also revert to using exact hulls for non-compound shapes
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14898
2023-10-12 22:55:34 -04:00
660c407095
ADDED: Control of multi-layer plot order from plot dialog
...
Enabled by 0b136ae0
2023-10-12 21:52:37 -04:00
7cb198e021
fix SEGV in pcb_generator_meanders
2023-10-12 21:47:34 +02:00
79a45c4803
TestBoardOutlinesGraphicItems(): handle small arcs.
2023-10-12 19:59:11 +02:00
af020f4f9a
Fixes for diff-pair meander rectangle & edit points.
2023-10-12 17:54:34 +01:00
78ee6f2e42
Fix a couple of undo bugs.
...
The first caused items coming back from undo to be hidden.
The second caused them to be ungrouped from the parent meander.
2023-10-12 17:54:34 +01:00
cdc9c2e409
Fix undo bug where items come back hidden.
2023-10-12 17:54:34 +01:00
16d904d47e
Add support for diff-pair meanders.
2023-10-12 17:54:34 +01:00
d4b8b550f3
Go back to using VIEW::Hide() instead of ForcedTransparency().
...
(The issue was that the selection VIEW_GROUP drawing ignores the
HIDDEN flag so we need to make sure the PCB_GENERATOR_MEANDERS isn't
in the selection VIEW_GROUP while we're editing it.)
2023-10-12 17:54:34 +01:00
1b676985f6
Retire length tuning tool in favour of first-class meanders.
2023-10-12 17:54:34 +01:00
1ca477aeee
Unroll from PICKER_TOOL so we can handle amplitude/spacing events.
...
Also fixes a bug where we didn't clear the router on an <ESC>.
2023-10-12 17:54:34 +01:00
d6c2ad7503
Unroll from PICKER_TOOL so we can handle amplitude/spacing events.
...
Also fixes a bug where we didn't clear the router on an <ESC>.
2023-10-12 17:54:34 +01:00
1aeccc5895
Unroll from PICKER_TOOL so we can handle amplitude/spacing events.
2023-10-12 17:54:34 +01:00
a57c9967f3
Draw meander borders while placing.
2023-10-12 17:54:34 +01:00
4da3e0ff93
Make meander dashed-line borders constant size.
2023-10-12 17:54:34 +01:00
d04641c868
ADDED: support for editing target length in Meander Properties dialog.
...
Also supports overriding the custom rules.
2023-10-12 17:54:34 +01:00
e3c491424b
Coding policy, Doxygen comment, and spelling fixes.
2023-10-12 12:27:30 -04:00
a7d540ce94
TestBoardOutlinesGraphicItems(): add missing case.
...
DRC_TEST_PROVIDER_MISC::testOutline(): use a smaller size to dectedt small items.
2023-10-12 15:53:21 +02:00
499f3ca95b
DRC_TEST_PROVIDER_MISC::testOutline(): add test to detect questionable items.
...
Graphic items (segments, rects, circles) on Edge.Cuts can create issues when
building board outlines, when they are very small (a few nm in size), because
they are not easily handled when trying to search connected graphics.
Also protect RC_ITEM::SetItems() against null pointer.
Fixes #15865
https://gitlab.com/kicad/code/kicad/-/issues/15865
2023-10-12 14:48:24 +02:00
0ea85ec9f5
Restore fill polygons on proper layers when flipping zones.
2023-10-12 02:21:47 +03:00
0b136ae0df
CLI: Allow controlling layer order for multilayer plots
2023-10-11 00:18:58 +00:00
d8f35633d4
Modify interactive delete tool to respect groups & selection filter.
2023-10-10 16:04:54 +01:00
8c017be24a
Clearer naming.
2023-10-10 15:43:45 +01:00
0683313ecb
Fix ghosted image while moving meander.
...
Also cleans up some undo description strings. (They go in the menu
so they should be title-caps.)
2023-10-10 15:24:58 +01:00
d3b50f0607
Cleanup (no functional changes).
2023-10-10 13:42:42 +01:00
04e23bf5e3
Fix build.
2023-10-10 12:58:12 +01:00
d916e650f1
Tuning status popup for point editor.
2023-10-10 11:55:57 +01:00
bb74445dda
Code clarity.
2023-10-10 11:14:47 +01:00
4226839586
Switch to diff-pair mode if startItem is a diff-pair member.
2023-10-10 11:08:53 +01:00
099e5dd9e7
More undo bugs.
2023-10-09 22:32:32 +01:00
994f9f8823
Cleanup & compiler warnings.
2023-10-09 22:32:32 +01:00
642938455e
Add status popup for meander placer.
2023-10-09 22:32:32 +01:00
1afa6ddbd5
Rename getLineBetweenPoints() to getLine().
...
While it uses the first point to find the line, it in fact returns
the entire connection, not just the part between the two points.
2023-10-09 22:32:32 +01:00
44e0821e13
Fix some issues with undo.
...
Also fixes the baseline being visible while placing the meander.
2023-10-09 22:32:32 +01:00
d10b0b053e
Move meander placer picker tool from item highlighting to net highlighting.
2023-10-09 22:32:32 +01:00
b662ff4956
Improve graphical feedback while placing a meander.
2023-10-09 15:22:41 +01:00
60a2439a53
Better spacing in the meander properties dialog.
2023-10-09 15:22:41 +01:00
35d8635a6b
Default skew tuning lenght to diff between N/P, but allow override.
2023-10-09 15:22:41 +01:00
21adc0aac5
ADDED: Import vector graphics into Schematic editor (SVG, DXF).
2023-10-09 07:04:50 +03:00
60d069757a
ADDED: Import vector graphics into Symbol editor (SVG, DXF).
2023-10-09 07:04:50 +03:00
f4f8523c59
Rename pcbnew DIALOG_IMPORT_GFX -> DIALOG_IMPORT_GFX_PCB
2023-10-09 07:04:50 +03:00
c9d6e79d2d
Fix minor compil warnings.
2023-10-08 15:04:45 +02:00
b77df1eea4
Use advanced_config key EnableGenerators to enable menu entries for generators.
2023-10-08 02:41:17 +00:00
f11339f1f5
Add actions for generators to Tools menu.
2023-10-08 02:41:17 +00:00
af3bd15469
Avoid crash when length tuning+closing window.
2023-10-08 02:41:17 +00:00
08e0d8d98a
ADDED: Manager dialog for generative objects.
2023-10-08 02:41:17 +00:00
a4832dd3c8
ADDED: Interactive meander objects for length tuning.
2023-10-08 02:41:17 +00:00
455268f45e
Allow to specify meander initial side via meander settings.
2023-10-08 02:41:17 +00:00
ce8849f8bc
Skip move in meander placers if points match.
2023-10-08 02:41:17 +00:00
8b21a260c9
Refactor MEANDER_PLACER_BASE::cutTunedLine to SHAPE_LINE_CHAIN::Split.
2023-10-08 02:41:17 +00:00
6cfb05b4a3
Save/load generative objects in PCB file.
2023-10-08 02:41:17 +00:00
7b645aa541
Introduce GENERATORS_MGR.
2023-10-08 02:41:17 +00:00
546c7ed218
Introduce GENERATOR_TOOL.
2023-10-08 02:41:17 +00:00
be72e07e61
Introduce PCB_GENERATOR.
2023-10-08 02:41:17 +00:00
0fcb36bc2e
Add reselectItem action.
2023-10-08 02:41:17 +00:00
b4986030da
Include solder mask in STEP export stackup height.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15632
2023-10-07 10:28:38 +01:00
36853b0df4
Allow translation of "Open cancelled by user." in pcb_parser.cpp
2023-10-07 09:09:30 +03:00
280fe976c4
Add a re-entrancy guard to PCB_POINT_EDITOR.
2023-10-07 03:51:52 +03:00
74075fe4d6
Fix target skew not working properly in meander skew placer.
2023-10-07 03:51:26 +03:00
e4e769493c
Skip very short segments in MEANDER_SHAPE::forward.
2023-10-07 03:51:18 +03:00
da5f5536c8
Honour custom layer names for Layer_Top and Layer_Bottom.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15835
2023-10-06 21:55:57 +01:00
3f0067cbaa
Adjust colours in appropriate direction depending on background.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15841
2023-10-06 21:27:02 +01:00
83d896951a
Apply epsilon more uniformly to footprint checks.
...
Rotation can cause round-off errors even in ints.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15838
2023-10-06 21:04:23 +01:00
420cadab34
Separate meander settings from target length/skew.
...
Settings move to Board Setup, while target length is sourced from
the custom rules (or a text-entry dialog if no rules are active for
the track).
Target skew is sourced from the coupled-trace-length minus the
trace-to-be-tuned length.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12075
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15826
2023-10-06 19:46:55 +01:00
b9e1908ffe
Try to find a happier medium for text entry box widths.
...
Most dialogs have units outside the text entry, and the likelihood
of 14 significant digits & units is low enough to allow scrolling
in that case.
2023-10-06 19:46:55 +01:00
d7863b09c5
Move CORNER_STRATEGY out of SHAPE_POLY_SET.
2023-10-06 15:42:50 +03:00
bf29b25190
EAGLE PCB: fix a regression causing polygons not being imported.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15829
2023-10-06 01:13:58 +03:00
0876fb0985
Re-implement direct layer switching in the router tool
...
Also add a new framework to allow grouping actions that are similar into
a single context that can then be used for mass comparisons.
2023-10-05 13:34:25 +01:00
31c488bc23
NETINFO_ITEMs are owned by BOARD.
...
Lifecylce management must go through BOARD_COMMIT (or at least
the frame's undo/redo lists).
2023-10-04 21:01:33 +01:00
c2d7b26ebd
PCBNew: don't grab the wrong parameter type when placing vias
2023-10-04 12:17:15 -04:00
c45ebfcccd
Add hot key column on layer select dialog
2023-10-04 12:17:15 -04:00
37df47a3e7
genDrillMapFile: reduce the pen width used to plot oval shapes (better look)
2023-10-04 15:47:47 +02:00
9f5e583ced
Readability.
2023-10-03 17:14:03 +01:00
9b60e99660
Use wxSTAY_ON_TOP instead of wxFRAME_FLOAT_ON_PARENT for choosers.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15808
2023-10-03 14:49:50 +01:00
a3d83cdb6d
Pass symbol netlist from Field Properties dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15806
2023-10-02 23:41:06 +01:00
987e382f96
Add missing member variable initialization.
2023-10-02 22:18:31 +01:00
e242f54816
Fix crash trying to create a new board.
2023-10-02 22:12:07 +01:00
8760bd8c80
Reconcile "apply defaults to new footprints" with DRC lib checks.
...
Moves apply defaults settings to Board Setup (where they were
duplicated anyway due to an earlier botched merge).
Modifies the apply-to-graphics algorithm to skip copper shapes.
Modifies DRC library check to skip STROKE_PARAMS for non-copper
shapes.
2023-10-02 22:10:13 +01:00
2d3a8ee4c9
Readability and comments.
2023-10-02 20:56:16 +01:00
9d678e96cd
Improve spacing.
2023-10-02 16:33:26 +01:00
06446bb80e
Only expand lib tree when filtering.
2023-10-02 16:24:53 +01:00
7c8e74c156
Fields: fix redundant update messages
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15801
2023-10-02 11:02:10 -04:00
6d3b846eb5
Add more missing destructor event cleanups
2023-10-02 07:22:00 -04:00
eaa3ee43e9
Tighten terminology consistency in clearance & constraint reports.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15800
2023-10-02 11:12:18 +01:00
609dedda3c
Insert lazily-created-rows at right position in grid sizer.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15652
2023-10-02 11:12:18 +01:00
cf02bb171f
Expose exclusion flags in search pane.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15776
2023-10-01 22:46:34 +01:00
904bdc3c66
Use netclass values when reaching netclass entry.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15774
2023-10-01 21:01:46 +01:00
9214e47367
Only allow switching to enabled layers.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15779
2023-10-01 15:27:55 +01:00
bfbba632df
Guard GetModificationTime with IsValid otherwise it'll return based on INT64_MIN.
...
Fixes KICAD-3Z0
2023-10-01 09:43:09 -04:00
f1c5581802
Don't continue with a null board in board import
...
Some plugin is failing and returning a null-board when the usual convention was exceptions
Fixes KICAD-3ZJ
2023-10-01 09:38:44 -04:00
25cca5adfe
EasyEDA Std: fix polygon pad orientation.
2023-10-01 16:21:26 +03:00
9cca8e5970
EasyEDA Std: assign nets to PCB circles and rects.
2023-10-01 16:21:17 +03:00
7005dd7c48
altium: make special string parsing on pcb a bit more generic
...
Only special strings starting with a dot are supported. Parsing of concatenated special strings using quotes needs to be implemented, but at least a few test-cases are already there now.
2023-10-01 15:10:50 +02:00
3b3e4fd34a
Move duplicated code of plugin.cpp and sch_plugin.cpp into a new plugin_utils located in commons
2023-10-01 13:58:38 +02:00
629081af65
fix FOOTPRINT::GetLikelyAttribute() to follow the comments of
...
FOOTPRINT::CheckFootprintAttributes(): at least one through hole pad
means most probably a footprint through hole attribute.
2023-10-01 11:21:11 +02:00
311f041421
ADDED: Polygon boolean operations in PCB editor
...
This allows common operations like merging a pin courtyard
into the body courtyard in the fooprint editor, taking a
"bite" out of a polygon and so on,
For now, this only supports polygons made of straight lines.
There are some wierd cases when the operations result in nothing
(e.g. wen a big polygon is substracted from a smaller one that
it contains entirely). I have tried to do something senisble in
these cases, but there may be more optimal ways to handle it.
Relates-To: https://gitlab.com/kicad/code/kicad/-/issues/13025
2023-10-01 00:10:10 +01:00
Jeff Young
Mike Williams
jean-pierre charras
Seth Hillbrand
Wayne Stambaugh
Alex Shvartzkop
Marek Roszko
SYSUeric66
Jon Evans
Thomas Pointhuber
Ian McInerney
Hasan Jaafar
John Beard