haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
19,918 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

19918 Commits

Author SHA1 Message Date
Jeff Young 7b05e456cc Bug fixes for multiple symbol instances in complex hierarchies 
1) use SCH_COMPONENT::GetRef(), GetValue() and GetFootprint() when
instance-specific info is needed
2) update UpdateAllScreenReferences() to handle value and footprint.
3) BACKANNO is CvPcb's handler, not back annotation's handler.  Which
means it needs GUI behaviour, not back annotation behaviour.

Fixes https://gitlab.com/kicad/code/kicad/issues/5520
 2020-09-06 13:57:14 +01:00
Jeff Young b28332c5f1 Minor code cleanup. 2020-09-06 13:04:52 +01:00
Jeff Young d5fd09249b Save instance info on clipboard and reapply it when keeping annotations. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5522
 2020-09-06 11:32:28 +01:00
Jeff Young 133fb5cded Minor code cleanup. 2020-09-06 11:28:58 +01:00
Jeff Young a25dfb2ac9 Stop setting modify from ClearAnnotation(). 
It's a side-effect, and as it turns out every current caller has
special-case code to reset it afterwards.
 2020-09-06 11:26:39 +01:00
Jeff Young 4354fa7bde Another try at a solution for ctrl-/. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5480
 2020-09-05 22:44:00 +01:00
Jeff Young 1be1205734 Repair missing checkVisibilityOnly test. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5516
 2020-09-05 19:12:07 +01:00
Jeff Young adfcdc89af Repair parent pointer after SwapData() nukes it. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5523
 2020-09-05 18:51:56 +01:00
Jeff Young 5b81c6c70f Fix typo. 2020-09-05 18:51:19 +01:00
Jeff Young e782794f96 Flesh out object properties and DRC Rule syntax help. 2020-09-05 17:44:59 +01:00
jean-pierre charras 276d77a1d7 SETTINGS_MANAGER: Fix bug: ensure the destination folder exists. 
Better fix than a0df876d
For new users, if this folder does not exist, saving colors does not work,
because if this folder does not exist, it is not created.
 2020-09-05 13:04:49 +02:00
qu1ck 3dbebda168 Fix GetCustomShapeAsPolygon and add a unit test 
Fixes #5497
 2020-09-04 20:30:54 -07:00
Ian McInerney f28b60896c Allow toolbar items to cancel tools when pressed 
There was a regression in v6 where the zoom to selection toolbar
item wasn't canceling the tool when pressed and the tool was active
(it was in v5). This implements a more generic framework for canceling
tools on button presses.

Fixes https://gitlab.com/kicad/code/kicad/issues/5103
 2020-09-05 01:49:38 +01:00
Jeff Young 7893af2c60 insideArea should be outline-based, not fill-based. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5499
 2020-09-05 00:25:19 +01:00
Seth Hillbrand 3095d0e335 DRC_TREE: Allow indexing on triangulated zones 
Also move to BOARD_ITEM* as we might want to run DRC on non-copper items
 2020-09-04 15:53:49 -07:00
Michael Kavanagh e05069ce3c Enable sorting on hotkey widget 
Fixes https://gitlab.com/kicad/code/kicad/issues/5495
 2020-09-04 22:07:17 +00:00
Jeff Young d0d13766ae Use the layerSettings vector, not map. Map may not yet be valid. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5505
 2020-09-04 23:02:41 +01:00
Jeff Young 7e3f35d3fb Netclass dropdowns should be selects, not comboBoxes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5386
 2020-09-04 22:22:32 +01:00
Jeff Young f1f8f746f4 Also resolve worksheet textVar refs in DRC. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5506
 2020-09-04 21:55:10 +01:00
Jeff Young 16b85ed567 Fix for reading back-annotation data from sexpr sch format. 2020-09-04 21:41:47 +01:00
Jeff Young 5e9ec82642 Correctly resolve textVar refs in worksheet items in ERC. 
Also fixes a null-ptr bug in DRC.

Fixes https://gitlab.com/kicad/code/kicad/issues/5506
 2020-09-04 21:38:07 +01:00
Jeff Young 08dee31d9e Try and unify the background colors between panels and platforms. 
Also moves to WX_GRID to get rid of some wxGrid bugs, and moves the
provision of attrs to the GRID_TABLE (as those applied to the grid
are ignored when a table is specified).

Fixes https://gitlab.com/kicad/code/kicad/issues/5260
 2020-09-04 20:47:50 +01:00
Jeff Young c1889cefcf Try to make block-quote/unquote more keyboard-variation-friendly. 
Fixes https://gitlab.com/kicad/code/kicad/issues/git
 2020-09-04 20:47:50 +01:00
jean-pierre charras 2babcd5936 Do not translate debug strings 2020-09-04 20:29:22 +02:00
jean-pierre charras a0df876d58 SETTINGS_MANAGER::SaveColorSettings(): Ensure the destination folder exists. 
For new users, this folder noes not exists, and saving colors does not work.
If this folder does not exist, it is not created.
 2020-09-04 19:49:19 +02:00
Jeff Young 800d8acb00 Reinstate collapsable controls in Appearances widget. 
Also tries to fix highlighting on BOTH OSX and GTK (previuos efforts
have all worked only on one or the other).
 2020-09-04 17:45:07 +01:00
Jeff Young 2736becb8b Fix typo in Toggle Layers action and add descriptions to hotkeys lists. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5494
 2020-09-04 17:45:07 +01:00
Jeff Young be15053745 Allow back-annotation of differing values and footprints. 
Also fixes a couple of bugs where resolving a textVar reference
to the refDes or unit wouldn't get the correct value in a
hierarchical schematic. (Unlogged.)

Fixes https://gitlab.com/kicad/code/kicad/issues/5397
 2020-09-04 15:21:56 +00:00
Mario Luzeiro 306a8f57f7 3D-Viewer: Parameterize sampling options 2020-09-04 15:12:01 +00:00
Jeff Young ec576b5dfa DRC checks need to be done on current layer. 
Don't be fooled by the name "segment".  It might be a via which is
on multiple layers....

Fixes https://gitlab.com/kicad/code/kicad/issues/5503
 2020-09-04 15:05:03 +01:00
jean-pierre charras 0bd6e5d96e FIELDS_GRID_TABLE and TEXT_MOD_GRID_TABLE: fix incorrect position of checkboxes 
This is an issue specific to wxWidgets 3.1.4
 2020-09-04 15:41:51 +02:00
Jeff Young a728abe63c Simplify appearances controls presentation. 
Fixes some OSX bugs in panel background colouring.
Also adds a bit info to control titles.

Fixes https://gitlab.com/kicad/code/kicad/issues/5260
 2020-09-04 14:07:42 +01:00
Jeff Young 8ffad4b375 Only override color if net or netclass color is set. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5368
 2020-09-04 14:07:42 +01:00
Jeff Young 007580c4b8 ADDED pad:pin checks for DRC "Test footprints against schematic". 2020-09-04 14:07:42 +01:00
jean-pierre charras 15c4a7b066 DIALOG_LIB_EDIT_PIN_TABLE: fix incorrect handling of Cancel button 2020-09-04 09:49:54 +02:00
Seth Hillbrand 91914f1a71 Reverts premature Python 3 calls in favor of backwards compat. 
This reverts commits d8d8f4f670
and 9614f6d0d9.
 2020-09-03 20:05:38 -07:00
Jon Evans 686311f0b4 Make sure to show newly-enabled layers when changing board setup 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5478
 2020-09-03 18:05:29 -04:00
Jeff Young 904d186f6d Don't export hidden models to STEP. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5451
 2020-09-03 22:59:45 +01:00
Jon Evans a4d23fff12 Fix multi-unit pin check logic 
Typo name vs. number

Fixes https://gitlab.com/kicad/code/kicad/-/issues/5483
 2020-09-03 17:30:13 -04:00
Jeff Young 3573c8b967 ADDED hotkey for comment/uncomment line(s) in Scintilla. 
Useful primarily for DRC Rules editor.

Fixes https://gitlab.com/kicad/code/kicad/issues/5480
 2020-09-03 20:37:05 +01:00
Jeff Young 555b78e7ca Read/write COLOR4D::UNSPECIFIED in netinfo so you can clear colors. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5368
 2020-09-03 20:35:38 +01:00
Wayne Stambaugh 03423f13a1 Eeschema: fix broken new sheet path comparison on windows. 
Using wxFileName::GetPath( wxPATH_WITH_SEPARATOR ) does not include the
drive specifier (A:, B:, C:, etc.) on windows which fails the comparison
with the project path 100% of the time.  wxFileName::GetPathWithSep()
solves the issue nicely.

Fixes https://gitlab.com/kicad/code/kicad/issues/5077
 2020-09-03 11:11:14 -04:00
Jeff Young d1006138fd ADDED holeWallPlatingThickness to AdvancedCfg. 
Used for zone filling and DRC hole collision testing.  Allows us to
calculate the actual hole size from the finish hole size.

Fixes https://gitlab.com/kicad/code/kicad/issues/5468
 2020-09-03 16:00:07 +01:00
Jeff Young e535489a0a Pad settings need to be copied to both master *and* edited pad. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5447
 2020-09-03 15:03:09 +01:00
Jeff Young eccb1e612e Refresh net annotations on tracks, pads, etc. when name changes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5466
 2020-09-03 15:03:09 +01:00
Jeff Young 8609180406 Add all non-shape properties to dummy hole pad. 
This is required in case there are DRC Rules that are matching against
the properties.  It also allows any local clearance overrides to take
effect.

Fixes https://gitlab.com/kicad/code/kicad/issues/5468
 2020-09-03 15:03:09 +01:00
Jeff Young b0081606f7 Fix crash bug in Select All / Delete. 
We only expect footprint edge selections in the Footprint Editor.
They cause PCBNew's undo architecture to wrap itself in knots.
 2020-09-03 15:03:09 +01:00
Jeff Young 3ce1b2b44e Clean up Coverity warning. 2020-09-03 15:03:09 +01:00
Jeff Young 38e9217d54 Consolidate all DRC epsilon/threshold values to a single advancedCfg setting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5464
 2020-09-03 15:03:09 +01:00
Jeff Young 450519a4bd Sometimes a DRAW_PANEL_GAL wants its immediate parent and sometimes not. 
For instance, we get things like high-contrast-mode from the pad
dialog when rendering a pad preview, but we want the colours from the
parent PCB_BASE_FRAME.
 2020-09-03 15:03:09 +01:00