Seth Hillbrand
f4ac4be701
Fix naming of `updateTitle()`
...
This is a private function so should be lowercased to avoid confusion
2023-01-11 16:06:20 -08:00
Seth Hillbrand
8aff923710
Set dirty bit and handle undo for export remap
...
When remapping the exported symbols, we should keep this in the undo
stack (remapping, not the existence of the new elements) and set the
dirty bit for the file to ensure it is saved/autosaved
Fixes https://gitlab.com/kicad/code/kicad/issues/13493
2023-01-11 16:06:20 -08:00
Jeff Young
c3c5468817
Sort all findNext candidates in a single list.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13483
2023-01-11 23:42:45 +00:00
PJM
76a0d4c4c0
Eeeschema: Fixed logic to display unamed pins properly
...
CHANGED: This code previously checked "m_name.IsEmpty()" to choose the
correct formatting path, but that check fails if the pin is called "~"
which is the default for an empty pin name. Instead we get the final
display string that will be shown and check if it's empty.
Fixes https://gitlab.com/kicad/code/kicad/issues/13332
2023-01-11 21:45:32 +00:00
Seth Hillbrand
a206f6717d
Desaturate the symbols in DNP for print/plot
...
The desaturation should match screen display
Fixes https://gitlab.com/kicad/code/kicad/issues/13481
2023-01-11 13:44:08 -08:00
Graham Keeth
89a6e55e58
Add DNP columns/grouping info to BOM script headers
2023-01-11 20:42:44 +00:00
Seth Hillbrand
248399f771
Standardize print/plot terms
...
Use choice box for color/bw selection
"border and title block" -> "drawing sheet"
Fixes https://gitlab.com/kicad/code/kicad/issues/13128
2023-01-11 12:30:02 -08:00
Seth Hillbrand
8a26bf6c41
Tweak DNP display settings
...
Use ERC error color
Make lines 3 * default line width (instead of 4 *)
2023-01-11 11:29:46 -08:00
Wayne Stambaugh
c7ffb85bf7
Fix Eagle schematic import on duplicate symbol library names.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13434
2023-01-11 14:10:00 -05:00
Jeff Young
c89925578d
Move find/replace to own tool so it doesn't rob events from cross-probing.
2023-01-11 14:22:06 +00:00
Dag Lem
bc4e559581
Eagle schematic import: Corrected handling of curved symbol/wire
2023-01-11 12:31:46 +00:00
Jeff Young
f8ef15f174
Fix over-zealous delete.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13476
2023-01-11 12:16:28 +00:00
Jeff Young
30c9deb9d5
Flat(er) look for paged dialogs.
2023-01-11 01:11:25 +00:00
Seth Hillbrand
6cd750bb9c
Respect "Exclude from Board" flag in export
...
When exporting to board-based netlists, skip components marked for
exclude from Board
Fixes https://gitlab.com/kicad/code/kicad/issues/13422
2023-01-10 15:23:26 -08:00
Seth Hillbrand
786fc14df3
Explicitly call out DNP in BOM
...
Add DNP column and group output based on DNP
Fixes https://gitlab.com/kicad/code/kicad/issues/13466
2023-01-10 15:23:26 -08:00
Seth Hillbrand
3003d9476a
Respect exclude from BOM
...
Remove non-standard (and hidden) exclude from BOM field in favor of the
current standard flag
2023-01-10 15:23:26 -08:00
Roberto Fernandez Bautista
33249d37b0
EAGLE SCH: Improve detail of curved shape imports (0.01mm error)
...
Follow-up from https://gitlab.com/kicad/code/kicad/-/merge_requests/1445
2023-01-10 22:45:46 +01:00
Roberto Fernandez Bautista
99d02ac7c0
CADSTAR SCH: Load symbol shapes with correct fill state
...
Changes architecture of importer to use SHAPE_LINE_CHAIN.
For now lets just load symbol shapes like this, but we could update code
for all other loading operations (also in PCB).
FIxes https://gitlab.com/kicad/code/kicad/-/issues/8060
2023-01-10 22:28:01 +01:00
Dag Lem
7e01816b73
Eagle schematic import: Handling of polygons with curved sides
2023-01-10 20:45:40 +00:00
Wayne Stambaugh
366c3e7142
Revert "Fix value field visibility issues when importing Eagle schematics."
...
This reverts commit 4c5203fabf
.
2023-01-10 09:45:18 -05:00
Seth Hillbrand
f99e374559
Make DNP more visible
...
Adds red cross to the DNP display. Allows showing the DNP even when
plotting black/white
Fixes https://gitlab.com/kicad/code/kicad/issues/13456
2023-01-09 15:31:50 -08:00
Dag Lem
7c458c5aee
Eagle schematic import: Handling of curved plain/wire and segment/wire
2023-01-09 17:02:14 +00:00
Mike Williams
4274bd0bb7
Schematic: handle rotations that include junctions
...
Also fix lack of line cleanup on mirroring.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13436
2023-01-09 11:05:30 -05:00
Wayne Stambaugh
4c5203fabf
Fix value field visibility issues when importing Eagle schematics.
...
Eagle schematics do not show the value field when it's not defined or
when not package (footprint) is defined for the symbol which is the
case for power symbols. Don't show the value field in KiCad to bring
the view more in line with what Eagle displays.
Inspired by Stefan's merge request #13433 .
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13433
2023-01-09 10:45:45 -05:00
Jeff Young
c43050b91b
Remove safety around reading default parameter from Value field.
...
This should be OK now because we should be writing out all parameters
now (even if they're default value).
But perhaps more to the point, if we have the safety in there then
we miss cases where we really can't parse the model (value of "{VCC}")
and we need to fall back to a raw spice model.
Fixes https://gitlab.com/kicad/code/kicad/issues/13444
2023-01-09 15:24:45 +00:00
jean-pierre charras
be5810a1ce
EEschema, "Change To" context menu: do not allow converting SCH_SHEET_PINs
...
to something else.
SCH_SHEET_PIN are specific, handled by a SHEET, and the conversion to a label
cannot be done.
2023-01-09 15:30:36 +01:00
Dag Lem
8c8b4f43e7
Eagle schematic import: Added missing plain elements
2023-01-09 14:18:23 +00:00
Marek Roszko
9f71e9af03
Add arg to plot hidden symbol pins in cli
2023-01-08 22:39:38 -05:00
Marek Roszko
c514f6f094
Handle alias symbols in cli svg export
2023-01-08 22:19:06 -05:00
Wayne Stambaugh
9c0445ed98
Remove schematic editor standard dialog button static line separators.
2023-01-08 14:26:10 -05:00
Jeff Young
d65cf1b457
Check parameters before assuming we can handle the model.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13444
2023-01-08 18:00:22 +00:00
Jeff Young
063478b3dc
Implement brightening for Find Next hotkey actions.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13421
2023-01-08 14:34:38 +00:00
jean-pierre charras
4d5c4c4ea8
Ensure all selected items have their edit flags cleared after move.
...
Some sub-items like fields can be selected, and are not in the main item list.
Fixes #13435
https://gitlab.com/kicad/code/kicad/issues/13435
2023-01-08 11:52:21 +01:00
Jeff Young
c3ca1ce014
Tune the hit-test extra-slop for lines (and apply it to arcs too).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13429
2023-01-07 23:06:51 +00:00
Jeff Young
ee0e90e3b0
We no longer enforce either a non-empty value or name == value.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13424
2023-01-07 22:42:52 +00:00
Jeff Young
22144ae0d0
Fix bogus format string replacement type.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13426
2023-01-07 19:34:32 +00:00
Jeff Young
289d9bd6fb
Remove missed check for empty fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13424
2023-01-07 19:34:32 +00:00
jean-pierre charras
c2f7dbfc15
Eeschema, AlignElements(): fix broken align of lines (bus, wire, graphic line)
...
It was due to a recent change (commit d824b7f5
) for SCH_LINE_T in
SCH_MOVE_TOOL::moveItem()
2023-01-07 09:06:03 +01:00
Seth Hillbrand
03e12535a8
Include symbol flags in swap
...
Needed for undo/redo. All properties should be listed in the swap
Fixes https://gitlab.com/kicad/code/kicad/issues/13409
2023-01-06 14:40:39 -08:00
Jeff Young
8dc7baad3d
Cleanup actions should not activate tools. It causes all manner of side-effects.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13331
2023-01-06 22:15:20 +00:00
Seth Hillbrand
8cabc82f1c
Add highlight hinting to pin severity
2023-01-06 13:30:58 -08:00
Jeff Young
5bdc3a5721
Keep sim-enabled checkbox in sync with edits to fields grid.
2023-01-06 20:43:33 +00:00
Wayne Stambaugh
411669ab88
Fix schematic power symbol annotation paste bug.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13405
2023-01-06 13:55:13 -05:00
Seth Hillbrand
38a0b67e40
ngspice has specific chars that are reserved
...
This replaces all known reserved characters with '_'
Fixes https://gitlab.com/kicad/code/kicad/issues/13404
2023-01-06 09:36:49 -08:00
Jeff Young
4d7642a26c
Add number of pulses parameter to pulsed voltage/current sources.
...
Also don't suppress writing "0" valued parameters.
Fixes https://gitlab.com/kicad/code/kicad/issues/13401
Fixes https://gitlab.com/kicad/code/kicad/issues/13402
2023-01-06 13:45:56 +00:00
Marek Roszko
c57e6db79a
Turn off plotting hidden fields in the svg export cli
2023-01-05 23:32:24 -05:00
Marek Roszko
e056c96c10
Feed the sym svg export absolute paths for source lib
2023-01-05 22:28:01 -05:00
Seth Hillbrand
b6b5a8ef6e
Remove bus label syntax from severities dialog
2023-01-05 17:00:32 -08:00
Jeff Young
98f0959f39
Default common-to-all-units based on last-used setting.
...
(Or whether or not the symbol has interchangeable units when a new
symbol is loaded.)
Fixes https://gitlab.com/kicad/code/kicad/issues/13391
2023-01-06 00:34:16 +00:00
Seth Hillbrand
c29dfe026e
Force recursing annotation when set to auto
...
Automatic annotation should always annotate new elements regardless of
where in the hierarchy they are
Fixes https://gitlab.com/kicad/code/kicad/issues/13378
2023-01-05 15:03:38 -08:00
Jeff Young
933a5d45e1
Be more aggressive about clearing edit flags after operations.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13173
Fixes https://gitlab.com/kicad/code/kicad/issues/13385
2023-01-05 18:08:22 +00:00
Jeff Young
7af718f1a5
Don't use std::string for things with wxString APIs.
...
It's too bug-prone.
Fixes https://gitlab.com/kicad/code/kicad/issues/13380
2023-01-05 14:16:39 +00:00
Jeff Young
3b021d98be
Completely remove reading SCH grid sizes from config files.
...
It messes up too many things if you put metric grids in there.
Fixes https://gitlab.com/kicad/code/kicad/issues/13345
2023-01-05 12:25:43 +00:00
Stefan
c5d7e447c7
Bugfix: remove trailing comma after last ref
2023-01-05 08:29:01 +00:00
Jeff Young
985414fef9
Collapse pin-conflicts-map generator back to (mostly) a single path.
2023-01-05 00:02:44 +00:00
Wayne Stambaugh
6f7af062ff
Rename file component_reference_lister.cpp to sch_reference_list.cpp.
...
This matches the naming of the header file.
2023-01-04 16:31:17 -05:00
Seth Hillbrand
0e2943d781
Fix pinmap flat style on GTK
2023-01-04 12:48:15 -08:00
Wayne Stambaugh
d99e09014b
Rename SYMBOL_INSTANCE_REFERENCE to SCH_SYMBOL_INSTANCE.
2023-01-04 15:39:50 -05:00
Seth Hillbrand
fc86998bf6
Ensure duplicate pin names get unique nets
...
Same pin name != same net name unless the pins are explicitly connected
Also add pin number to all unconnected pads ensuring they have unique
nets
Fixes https://gitlab.com/kicad/code/kicad/issues/13236
2023-01-04 11:32:15 -08:00
Jeff Young
7c0b6c1e87
Restore old pin-conflicts-map algo for MSW and GTK.
2023-01-04 18:32:06 +00:00
Mike Williams
bd5d10cd7b
Schematic: remove more extraneous dangling symbols
2023-01-04 11:07:23 -05:00
Graham Keeth
fb9a388bce
Fix icon spacing in Annotation dialog/panel
2023-01-04 13:52:19 +00:00
Jeff Young
33d31be9b5
Fix last commit.
2023-01-04 13:38:28 +00:00
Jeff Young
b38370adae
Test for viability of using fontsize for pin conflicts map positioning.
2023-01-04 13:16:15 +00:00
Wayne Stambaugh
f5c5b00e40
Fix schematic annotation dialog bitmap layout issue.
2023-01-04 07:36:00 -05:00
Wayne Stambaugh
73b7dcbc35
Attempt to unify symbol annotation behavior between place and paste.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13330
2023-01-04 07:36:00 -05:00
jean-pierre charras
575a84f76c
Fix a compil issue on GTK
2023-01-04 13:15:56 +01:00
jean-pierre charras
d0f9ce897e
Do not use #elifdef , only available in C++23
...
replaced by #elif defined
2023-01-04 11:59:33 +01:00
Jeff Young
a8d2f7f71d
Round 2 for GTK.
2023-01-04 01:41:07 +00:00
Jeff Young
b9f1106781
Adjustments for GTK.
2023-01-04 01:18:02 +00:00
Jeff Young
c47de5a55d
Another round of adjustments for MSW pin conflicts map.
2023-01-04 00:33:58 +00:00
Jon Evans
ac3ed02283
Rework bitmap cache and enable it
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12405
2023-01-04 00:26:45 +00:00
Marek Roszko
8ab9934143
Use our own cmake module path variable to avoid conflicting with the main ones listy functional
2023-01-03 19:18:16 -05:00
Jeff Young
7d84d323a6
Pin conflicts map adjustments for MSW.
2023-01-04 00:12:16 +00:00
Jeff Young
13d196c509
Fix some issue in the pin conflicts map with button alignment on Mac.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13333
2023-01-03 23:39:48 +00:00
Graham Keeth
77ee82459e
add ERCE_NETCLASS_CONFLICT and ERCE_ENDPOINT_OFF_GRID to schematic setup
2023-01-03 23:23:46 +00:00
Mike Williams
1ba9a6abe3
Rotate/Mirror: unbreak immediate mode actions
2023-01-03 16:05:52 -05:00
Seth Hillbrand
cbe6cd3048
Don't move local vars
...
Copy ellision allows optimization if we don't explicitly move a local
variable in the return
2023-01-03 10:20:18 -08:00
Jeff Young
baa13b885f
Don't add Sim.Params unless it contains data, and update sallen key demo.
2023-01-03 17:20:23 +00:00
Jeff Young
9583b28063
Fix store-in-value bugs.
...
1) Always honour the dialog checkbox value.
2) Don't expect the absence of the primary parameter in Sim.Params to
mean that Value stores it. It might be the default parameter value.
3) Update spiceTypeInfo when matching legacy data to an internal model.
4) Initialize the store-in-value checkbox depending on whether or not
we found the primary parameter in the Value field.
2023-01-03 17:20:23 +00:00
Jeff Young
9b9795a87d
Reduce reliance on exception processing -- it's waay too bugy at present.
...
This moves some stuff to REPORTER APIs. Moving more stuff would be good,
but it probably too high-risk at present. We'll wait for 8.0 for that....
Fixes https://gitlab.com/kicad/code/kicad/issues/13359
2023-01-03 17:20:23 +00:00
Mike Williams
d1c2ab957b
Schematic: set current sheet after initializing screens
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13238
2023-01-03 12:11:31 -05:00
Jeff Young
fdc8f9c59d
Fix accidental deletion in "TEXT_ATTRIBUTES" commit.
2023-01-03 01:23:18 +00:00
Jeff Young
7f35323416
Re-enable sim model ERC testing.
2023-01-03 00:59:14 +00:00
Jeff Young
056349e5ea
Units for footprint preview widgets.
2023-01-02 22:12:26 +00:00
Jeff Young
c5948de2af
Update find status when switching sheets.
...
(Not just when switching sheet during find.)
Fixes https://gitlab.com/kicad/code/kicad/issues/13351
2023-01-02 18:49:28 +00:00
Jeff Young
277cd73204
TEXT_ATTRIBUTES doesn't hold the position.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13350
2023-01-02 17:36:21 +00:00
Jeff Young
fc346ea794
Iterator safety.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13341
2023-01-02 11:36:54 +00:00
jean-pierre charras
e8114dc49a
Minor compil and Coverity warnings fixes.
2023-01-02 10:21:42 +01:00
Jeff Young
6f16678d2d
Typo fix courtesy or aris-kimi.
2023-01-01 23:40:18 +00:00
jean-pierre charras
447d0d71d3
EEschema, Error/Info messages: do not add the unit id to single unit symbol ref
2023-01-01 11:21:05 +01:00
Gary Kim
8e8a3c7bdc
Do not translate name in version info
...
Leave the application name in version info untranslated when
viewed, copied, or used in a bug report.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13298
2022-12-31 20:28:45 -05:00
Jeff Young
62f0843579
Fix grammar error in warning string.
2022-12-31 18:54:36 +00:00
Jeff Young
55b8f0bc00
Gracefully fall back to raw spice when we can't parse the data.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13329
2022-12-31 18:52:26 +00:00
Jeff Young
77b361a077
Add reference material to SPICE model pin assignment tab.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13309
2022-12-31 18:52:26 +00:00
jean-pierre charras
9f56771611
Fix a typo
2022-12-31 11:41:04 +01:00
Jeff Young
5deee405da
Fill in built-in-model-type (which might not be the same as initial spice type).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13324
2022-12-31 01:07:46 +00:00
Jeff Young
62bec69d8c
Migrate field text attrs from legacy fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13323
2022-12-30 23:41:46 +00:00
Jeff Young
e9ed56e9a4
Fix small alignment issue in field properties dialog.
2022-12-30 15:29:36 +00:00
Jeff Young
c0e0cbceb0
Move eseries helper class to common.
...
Also improves some terminology for english-speakers.
Also substitues [] vector access (which creates empty elements) over
at() (which throws if the item is not found).
2022-12-29 18:05:57 +00:00