haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
35,208 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

2509 Commits

Author SHA1 Message Date
jean-pierre charras 20d1d0705e Fix a few issues related to field names and their translation. - Do not use translated field names outside strings displayed in dialogs. - fix code that does not work well with default locale. - fix some (not all) I18n issues in DIALOG_UPDATE_SYMBOL_FIELDS. 2022-05-13 11:45:37 +02:00
Seth Hillbrand bbc250720f Resolve title variable when plotting 
Be sure to use variable name if it exists when plotting the file

Fixes https://gitlab.com/kicad/code/kicad/issues/11608

(cherry picked from commit d971cbefcb)
 2022-05-12 15:31:15 -07:00
jean-pierre charras b68514afb1 Fix a wxWidgets alert. 2022-05-12 20:58:48 +02:00
Marek Roszko f85251ef75 Fix eda_doc not looking for schematic locally 
It looks like this was overlooked by Jeff in 2020 not realizing eda_doc isn't built under eeschema but common in cc9ac37a0e
 2022-05-10 21:28:48 -04:00
Mike Williams b7a77a9498 Schematic: Add CSV export to Symbol Fields Table 2022-05-09 12:02:12 -04:00
Jeff Young 8f937b17a2 Remove wxWidgets 3.0.x hack. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11540
 2022-05-07 23:24:55 +01:00
Jeff Young f9f0f6fe24 Implement cross-references for labels. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11564
 2022-05-07 21:10:04 +01:00
Jeff Young a644aad1cf Hand-code tab navigation from value field of Label Properties dialog. 
wxWidgets doesn't appear to handle it correctly, doing nothing on OSX
and potentially crashing on GTK.

Fixes https://gitlab.com/kicad/code/kicad/issues/11572
 2022-05-06 18:14:25 +01:00
Jeff Young 9c5aa5c3c1 Font and color for FIELDS_GRID_TABLE. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11459
 2022-05-06 00:06:00 +01:00
Jeff Young e80c5a4e4e Add text colour to Edit Text & Graphics Properties. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11459
 2022-05-06 00:06:00 +01:00
Jeff Young 804ab5609e Add dash-dot-dot to Edit Text & Graphics Properties. 
Also fixes a bug where textboxes and shapes  weren't correctly updated.

Fixes https://gitlab.com/kicad/code/kicad/issues/11522
 2022-05-02 17:22:13 +01:00
Jeff Young 6d44ca2145 Ellipsize long heirarchical paths. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11499
 2022-04-30 14:09:30 +01:00
Jeff Young 2cccd5b090 Fix minor layout issue in dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11490
 2022-04-27 17:14:33 +01:00
Jeff Young e6f11c5c39 Reset outline font if bold or italic changed. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11462
 2022-04-26 12:52:29 +01:00
Jeff Young 6738708a7f Disable background color when printing in black & white. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11180
 2022-04-24 19:46:57 +01:00
Jeff Young c6f83b6dec ADDED Duplicate Footprint, Rename Symbol and Rename Footprint. 2022-04-22 22:06:51 +01:00
Jeff Young eb1a238a53 Remove extra event handler. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11418
 2022-04-20 16:19:42 +01:00
Jeff Young fc2eb2d7c9 Fix missing line keeping tabs from switching. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11417
 2022-04-20 14:51:08 +01:00
Seth Hillbrand aac6f576c2 Fix broken comparison in pin_numbers 
Pin names like "+V" were incorrectly parsed as doubles leading to broken
comparisons.  These caused heap overflows when sorting pin tables

This corrects the comparison so that numeric sorts are only performed
when there is an actual number in the symbol segment.  Also adds unit
tests for common error cases
 2022-04-19 14:46:05 -07:00
Jeff Young 4ab2c93070 Update Selection Filter title bar with language changes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11421
 2022-04-19 21:12:13 +01:00
Jeff Young ffc28f23e5 Repair GetFullRef() and use it when running Symbol Fields Table filtering. 
(Previously GetFullRef() failed to add the number between the prefix letter
and the unit designator.)

Fixes https://gitlab.com/kicad/code/kicad/issues/11419
 2022-04-19 19:55:30 +01:00
Jeff Young c3bed8f6ee Resolve textvars before opening file browser. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6436
 2022-04-18 22:45:02 +01:00
Simon Richter 1e505d4c22 Remove a few call sites of SCH_SHEET::SetSize 
This function is dangerous and should be used only by parsers, and not even
those, really.

For new objects, the size can be passed to the constructor.
 2022-04-18 16:23:03 +02:00
Jeff Young 55a8fb39c4 ADDED filtering for Symbol Fields Table dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11224
 2022-04-17 20:02:58 +01:00
Jeff Young e09147db30 Cross-probing for ERC dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11411
 2022-04-17 00:33:56 +01:00
Jeff Young 7f4f5f2882 Save and re-load query string in Choose Symbol dialog. 
While this has been requested on its own, it's primarily done here
because wxWidgets decided to send a SEARCH_CANCEL from a wxSearchCtrl
when hitting <ENTER> if the search control holes the empty string.
This causes us to not do a symbol instert in the Chooser dialog.

Fixes https://gitlab.com/kicad/code/kicad/issues/10169

Fixes https://gitlab.com/kicad/code/kicad/issues/7699
 2022-04-17 00:33:56 +01:00
Jeff Young 184b67098f Meet user expectations on life-cycle of symbol fields. 
In other words, support empty fields.

Also adds deleting fields to Symbol Fields Table.

Fixes https://gitlab.com/kicad/code/kicad/issues/8999
 2022-04-12 22:11:31 +01:00
Roberto Fernandez Bautista 0015574a60 ${SHEETNAME} represents the sheet name + introduce ${SHEETPATH} 
CHANGED: The text variable ${SHEETNAME} now always represents the name of the
sheet when used anywhere in the schematic editor, including the title block

ADDED: A new text variable ${SHEETPATH} which is replaced with the path to the
current sheet - e.g. "/Sheet 1/Sheet 2".

To ensure backward compatibility, the default drawing sheet now uses
${SHEETPATH}. Custom drawing sheets will need to be manually edited.
 2022-04-09 15:45:58 +01:00
Wayne Stambaugh 239f0214ac Eeschema: add support for default schematic symbol instance data. 
Prior to fixing the schematic file change churn do to instance data
changing to the last selected sheet instance, the symbol instance data
was set rather than empty.  This change allows for users to set the
default instance data which is used for every new instance of the
schematic.

ADDED: Default schematic symbol instance data (unit and reference, value,
       and footprint fields) can be set to be used as the default settings
       for all new instances of the schematic.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11113
 2022-04-09 07:49:36 -04:00
Seth Hillbrand 4b0b4c0ddc Show non-driven error on single-pin nets 
Better to have both the single-pin error message and the non-driven
error message when an input pin is not connected than miss error
messages when the pin is connected to a blank net

Fixes https://gitlab.com/kicad/code/kicad/issues/10430

(cherry picked from commit e740db61f5)
 2022-04-06 16:54:04 -07:00
Jeff Young 67d54ecb4c A bit of dialog layout cleanup. 2022-04-06 16:58:26 +01:00
Jeff Young 06df90636b Rationalize negative line-width handling. 
Make "don't stroke" an explicit property in the GUI.
Silently enforce line width to >= 0 when stroking.
Make layouts between dialogs more consistent.
Interpret unspecified fill colour as layer colour.

Fixes https://gitlab.com/kicad/code/kicad/issues/11279
 2022-04-05 23:59:25 +01:00
Jeff Young 1594df3498 Fix egregious typo. 2022-04-05 20:10:25 +01:00
Jeff Young 0bd3341f0f Allow textboxes to have no text. (They still have a defined box.) 
Fixes https://gitlab.com/kicad/code/kicad/issues/11286
 2022-04-05 16:29:21 +01:00
Sylwester Kocjan 4719fdc9bf eeschema: rename m_exporter to m_circuitModel 2022-04-01 19:28:31 +00:00
Sylwester Kocjan f5dedd77c6 eeschema,sim: add SIMULATOR and SIM_MODEL interface 
SIMULATOR has now an Attach() method, which should be called
with proper SIMULATION_MODEL that should be simulated, before calling Run()

Concrete class of SIMULATION_MODEL for ngspice is NGSPICE_CIRCUIT_MODEL,
renamed from NETLIST_EXPORTER_PSPICE_SIM. DIALOG_SIM_SETTINGS relies
on above mentioned object, so it was added as an argument of the constructor.
 2022-04-01 19:28:31 +00:00
jean-pierre charras be6379a8f6 Fix minor Coverity and compil warnings. 2022-04-01 20:43:21 +02:00
Jeff Young 6f818f4c2e Editing support for sheet-pin fonts, text styles and text colors. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11300
 2022-04-01 19:26:27 +01:00
Seth Hillbrand 49c48e2fe0 Consistently handle env/prj variables 
User-defined variables cannot be used for internally-reserved variables

Fixes https://gitlab.com/kicad/code/kicad/issues/11232

(cherry picked from commit c23679d9bd)
 2022-03-31 17:05:53 -07:00
Jeff Young 6b99a937d8 Look for sheet pins inside sheets. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11297
 2022-03-31 22:10:45 +01:00
Jeff Young e8a543f1ea Colors for text in PL_Editor and Eeschema. 
Fixes https://gitlab.com/kicad/code/kicad/issues/1952
 2022-03-31 19:43:56 +01:00
Jeff Young 91ea0903d0 Add infobars for individual-item-color-overrides. 2022-03-29 20:41:03 +01:00
Seth Hillbrand 8706bea3c6 Fix renamed flag 
Snuck in between MR reviews
 2022-03-28 13:50:44 -07:00
Mike Williams 2a726a882f Schematic: new feature, force 45 degree lines 
* New modes to force 45 deg angle at beginning or end of line

* Backspace will undo most recent segment added

* / will toggle posture of 90 and 45 degree lines

* Added alg::signbit for convenience

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10869
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9175
 2022-03-28 16:07:23 -04:00
Jeff Young 48dd810cd1 ADDED grouping of selected pins in Pin Table. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4956
 2022-03-26 21:07:10 +00:00
Sylwester Kocjan 53ccd8bd67 eeschema,sim: refactor NETLIST_EXPORTER_PSPICE_SIM creation 2022-03-26 15:50:15 +00:00
jean-pierre charras 9a342458fa Fix a few Coverity and compil warnings. 2022-03-26 16:21:23 +01:00
Jeff Young 0652c7b429 More visible Synchronized Pins Mode informatics. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10340
 2022-03-26 15:16:08 +00:00
Jeff Young d5533e7999 ADDED unit-filtering for pin table. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9382
 2022-03-26 11:53:48 +00:00
Jeff Young e6c2b12ddf ADDED allow pin conversion to be edited in Pin Table. 
Added a De Morgan column.
 2022-03-26 11:53:48 +00:00
Jeff Young 2681ad6cfc Don't rely on HasConversion() for Symbol Properties in Symbol Editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11200
 2022-03-26 11:53:48 +00:00
Wayne Stambaugh 7da7864f5e Fix some Coverity issues. 2022-03-25 15:51:05 -04:00
Jeff Young 92a229eec7 ADDED separate user-defined color for page limits. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5271
 2022-03-24 14:11:41 +00:00
Wayne Stambaugh b87fc45e33 Fix broken symbol field table editor dialog. 
Do not use the symbol field string to populate the value and footprint
grid cells.  The field strings may be empty because the symbol has not
been instantiated yet by entering a sheet.  This fix makes an incorrect
assumption that the first instance value and footprint data in the symbol
is the same for all instances.

Note: this fix is incomplete because the value and footprint fields are
      can now be different between sheet instances.  The entire field
      table editor design will need to be rethought because the current
      grouping doesn't allow different value and footprint instance
      changes.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11194
 2022-03-23 11:46:49 -04:00
Jeff Young 8eb10c41d8 Name any unnamed fields so they don't clobber each other. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10039
 2022-03-22 18:08:05 +00:00
jean-pierre charras 2bba277c5e Unit binder: fix hang and DIALOG_WIRE_BUS_PROPERTIES: fix uninitialized variable. 
The hang can be Windows specific.
 2022-03-19 10:22:41 +01:00
Jeff Young 7b82c2ba85 Preload eeschema find with selection when appropriate. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11148
 2022-03-18 23:31:30 +00:00
Jeff Young 41c0009c51 Off-grid ERC warnings. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10379
 2022-03-17 20:23:56 +00:00
Jeff Young e68e2e973e Separate Line Properties dialog from Bus/Wire, and handle Junctions in Bus/Wire. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9979
 2022-03-16 14:56:32 +00:00
Jeff Young 7ab4d67e94 Make sure line style comboboxes get a default entry. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11083
 2022-03-11 23:19:16 +00:00
Jeff Young a9eb7a0e28 Make sure LIB_ID escape context allows for formatting constructs. 
Also make sure that value field is updated from name changes when the
symbol is a power symbol (even if it's from the schematic instead of
the library).

Fixes https://gitlab.com/kicad/code/kicad/issues/11093
 2022-03-10 13:46:42 +00:00
Seth Hillbrand 16a266301a Remove double-call of settings from Netlister 
Double-calls are no longer needed when using settings.  They can
interfere depending on how the system executes the commands.

Removing keeps the last used plugin as the default, rather than the last
selected

Fixes https://gitlab.com/kicad/code/kicad/issues/11094

(cherry picked from commit e8ef863861)
 2022-03-09 17:12:41 -08:00
Seth Hillbrand fd59179cd2 Avoid implementation dependent on events 
Adding a page in the ctor can generate events that change the default
page.  Instead, we set the default after all pages have been added,
avoiding the reset

Fixes https://gitlab.com/kicad/code/kicad/issues/10910

(cherry picked from commit 5314ba6440)
 2022-03-09 15:42:29 -08:00
Jeff Young d3716b9956 Reentrancy block for symbol editor symbol properties dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11060
 2022-03-07 10:26:18 +00:00
Jeff Young c5d85e0b7e Don't try to open cell editor on first focus. 
It hasn't worked since we rejiggered the default grid selection mode
anyway, and for some reason it eats <esc> key events after the dialog
has been resized.

Fixes https://gitlab.com/kicad/code/kicad/issues/11015
 2022-03-03 02:06:48 +00:00
Jeff Young fd4b4533b1 Remove some code that isn't used anymore. 2022-03-03 02:06:48 +00:00
Seth Hillbrand 8c36ba3653 Explicitly give unit values 
Removes the ability to hide symbol units in file formats.  This was
mostly the case for a while but there remained corner cases where we
left a default/hidden option

Fixes https://gitlab.com/kicad/code/kicad/issues/10888
 2022-03-02 16:01:08 -08:00
Jeff Young 67eb138a4b Fix copy/pasta. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10957
 2022-02-25 00:49:41 +00:00
Jeff Young 8a22dab83d Fix crash bug when adding rows to pin table and then pasting to unit. 2022-02-18 17:12:46 +00:00
Jeff Young 9584849aba Fix type which results in global fieldname templates being added to project. 2022-02-17 12:42:10 +00:00
Jeff Young d60ed70d54 Sync all fields between units when symbol is edited. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10610
 2022-02-17 12:42:10 +00:00
Jeff Young e499793147 Update alt pin assignments in other units. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10849
 2022-02-17 12:42:10 +00:00
jean-pierre charras 414dfb4745 Eeschema, DIALOG_TEXT_PROPERTIES and DIALOG_LIB_TEXTBOX_PROPERTIES: fix minor issues 
Fixes #10863
https://gitlab.com/kicad/code/kicad/issues/10863
 2022-02-15 15:38:08 +01:00
Mike Williams 1090403ca2 Schematic Preferences: fix grid assert on negative width 2022-02-13 22:27:41 +00:00
Werni 946f62d949 Add separate wildcard for OrCAD netlists 2022-02-11 09:24:20 +00:00
Jeff Young 3600b2ce3f Make sure temp sheet has a parent. 2022-02-08 17:09:17 +00:00
jean-pierre charras 2f79f579cc DIALOG_TEXT_PROPERTIES: do not show fill option for texts. 
It make sense only for text boxes.
Fixes #10786
https://gitlab.com/kicad/code/kicad/issues/10786
 2022-02-08 09:42:22 +01:00
Kevin Lannen f9b27a53b2 Eeschema: Edit pin numbers while grouped 
ADDED: The pin table pin numbers column supports editing the list of pin
numbers to add, remove, and rename pins.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/5620
 2022-02-07 17:45:16 +00:00
Kevin Lannen 631d5155ef Eeschema: Pin table support for multi unit symbols 
ADDED: Symbol editor pin table supports editing which unit each pin is
displayed on

Note: 6513 mentions being able to change the pin unit from the edit pin
menu. This does not add that feature.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6513
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/5470
 2022-02-07 17:45:16 +00:00
Kevin Lannen 56794ab829 Eeschema: Add pin count column to pin table 
ADDED: When the pin table is showing grouped pins, display a read-only column
that displays the number of pins in each row.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/2416
 2022-02-07 17:45:16 +00:00
Kevin Lannen 08ca19f95d Eeschema: Display pin count and duplicate pin list in pin table dialog 2022-02-07 17:45:16 +00:00
Jeff Young 624dc393bf Fix tooltip. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10708
 2022-02-07 17:36:40 +00:00
Jeff Young 79c7d55a40 Add a checkbox for LIB_SHAPE borders. (We already have them for LIB_TEXTBOXes.) 
Fixes https://gitlab.com/kicad/code/kicad/issues/10365
 2022-02-06 19:43:25 +00:00
Jeff Young b1cc784582 Harmonize interchangeable units checkboxes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10708
 2022-02-06 19:43:25 +00:00
Jeff Young 7ccac79192 More wxString wide literals. 2022-02-05 21:29:34 +00:00
Jeff Young bebfbce9b2 Move pcb file rep of text_boxes to strokes. 2022-02-01 16:29:59 +00:00
Seth Hillbrand 098e8f7d9b Revert "cmake: adding KICAD_MACOSX_APP_BUNDLE option" 
This reverts commit ea9f960cc1.

Reverted for updates as this currently breaks kicad-mac-builder
 2022-01-31 15:57:56 -08:00
Jeff Young f3cd36d1d7 Bring EEschema textboxes in line with PCBNew's. 
Also adds Border checkboxes and fixes a bunch of bugs.
 2022-01-31 21:46:40 +00:00
Jeff Young 5739505aa3 TextBoxes for PCBNew. 2022-01-31 20:00:47 +00:00
Jeff Young 60bcfd1bf1 Bug fixes in arc & textbox printing. 
Also removal of the no-longer-used clipping code from GR*.
 2022-01-31 20:00:47 +00:00
Davide Gerhard ea9f960cc1 cmake: adding KICAD_MACOSX_APP_BUNDLE option 
ADDED: with cmake KICAD_MACOSX_APP_BUNDLE option the user can disable
the macOS app bundle creation when compiling on macOS. This permit to
use/install KiCad like any other *nix platform (/usr/bin, /usr/share,
ecc.). By default, cmake build the app bundle.
 2022-01-28 15:49:37 -08:00
Jeff Young c6a8100d46 Schematic and symbol text boxes. 
Also fixes some plot bugs with arcs.

Also moves polygonization of arcs (when required) in plotting code
from 5 degrees to calculated based on ARC_HIGH_DEF.

Fixes https://gitlab.com/kicad/code/kicad/issues/5017
 2022-01-28 21:38:15 +00:00
Jeff Young 3409783d9f Break sch_text.h/.cpp into sch_text and sch_label. 
Also moves SCH_NETCLASS_FLAG to SCH_DIRECTIVE_LABEL, and remaps Altium
harnesses from SCH_TEXT to SCH_DIRECTIVE_LABEL.
 2022-01-28 21:38:15 +00:00
Seth Hillbrand 79403ef075 Readd yield call to give slice to system. 
Note:
- wxYield does not work here, indicating the need for locking
- wxYieldIfNeeded does not work, possibly for the same reason as wxYield
- Both Layout() and m_fieldGrid->Layout() need to be called even though
  the first should call the second.

Fixes https://gitlab.com/kicad/code/kicad/issues/5690
 2022-01-28 13:02:39 -08:00
Seth Hillbrand 9ab2eb391f Move delay selection out of UpdateUI 
Calling actions from within UpdateUI can cause loops that crash or
substantially slow

Fixes https://gitlab.com/kicad/code/kicad/issues/10616
 2022-01-26 16:05:40 -08:00
Seth Hillbrand 2dc031ee34 Prevent auto-column sizing when editor opens 
On GTK, some configurations will trigger a column resize, which will
close the current editor.  This blocks the column resize while the
editor is open, unless the resize continues, which indicates dragging of
the window edge

Fixes https://gitlab.com/kicad/code/kicad/issues/5690
 2022-01-25 17:59:15 -08:00
Seth Hillbrand b6ecbc596e Fix mistaken use of `m_width` 
This is a protected var in Linux but doesn't exist in Mac/MSW.  We use
the new m_fieldsSize
 2022-01-25 12:45:09 -08:00
Seth Hillbrand efb323d57d Another stab at https://gitlab.com/kicad/code/kicad/-/issues/5690 
This time, ensure that the grid is increased and the main form gets an
event
 2022-01-24 16:30:30 -08:00
Seth Hillbrand a054a46136 Force a size event to avoid multiple yields 
When the grid editor is shown, we also want to ensure that the grid gets
resized to account for the new editor.  Queuing the event will ensure
that happens after the editor is emplaced in the grid

Fixes https://gitlab.com/kicad/code/kicad/issues/5690

(cherry picked from commit fddfce4fb1)
 2022-01-24 15:32:17 -08:00
Seth Hillbrand 175c4fe67c Allow time to update editor 
On GTK, the full editor needs to be shown and, for some systems, the
editor will not show correctly.  By yielding we should allow the time to
recalculate sizes for the editor in the grid

Fixes https://gitlab.com/kicad/code/kicad/issues/5690

(cherry picked from commit 871556ebda)
 2022-01-24 09:58:10 -08:00
Fabien Corona 58e167013d SPICE: Add support for transmission lines 2022-01-23 17:23:22 +00:00
jean-pierre charras 2dbc89e5f2 DIALOG_SIM_SETTINGS: fix incorrect validation of DC souces in DC Transfer panel 
Fixes #10568
https://gitlab.com/kicad/code/kicad/issues/10568
 2022-01-23 16:22:12 +01:00
Jeff Young 29841ba315 Bring ERC & DRC dialogs into parity. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9350
 2022-01-22 22:27:41 +00:00
Seth Hillbrand 16aca901df Clear Undo list when renaming 
Our undo/redo list is tied to the screen that gets cleared when we
reload the file after renaming.  We need to clear the Undo list at this
point to prevent possible crashes when moving too far back in the stack

Fixes https://gitlab.com/kicad/code/kicad/issues/10504

(cherry picked from commit 323a069738)
 2022-01-20 11:29:05 -08:00
dsa-t bc1ff6756f Cross-probing/selection for multiple items (SCH->PCB) 2022-01-16 20:29:03 +00:00
Jeff Young 70ad554343 Coverity fixes. 2022-01-14 16:08:18 +00:00
Jeff Young e048e51f5d Improve SNR of EDA_ANGLE stuff. 2022-01-14 16:08:18 +00:00
jean-pierre charras d0f2c20235 Define our kicad font name only once, and do not translate it. 
Especially using a translated name breaks kicad config and files because
in non English languages both translated and not translated names were used in code.
 2022-01-13 14:32:55 +01:00
Jeff Young 062f5e3177 Undo for SCH_SHAPEs. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10373
 2022-01-11 18:33:54 +00:00
Jeff Young f9927ab675 Fix Text Properties dialog layout. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10368
 2022-01-11 16:00:38 +00:00
Jeff Young 267eca28cd Font support for global edit text & graphics dialogs. 2022-01-11 15:34:24 +00:00
Jeff Young aef2a3fca4 Default font for eeschema. 2022-01-08 16:47:45 +00:00
Jeff Young a2030a5956 GUI for font selection. 2022-01-08 16:47:45 +00:00
jean-pierre charras e00e9ff41f PANEL_TEMPLATE_FIELDNAMES: fix incorrect management of boolean options 
(it was impossible to disable them)
Fixes #10280
https://gitlab.com/kicad/code/kicad/issues/10280
 2022-01-06 19:00:52 +01:00
Seth Hillbrand 30549a5e6a Don't strip extensions twice in BOM export 
Exporting the Bill of Materials uses the netlist exporter.  Both of
these routines were stripping the extension, leading to projects like
"test.project.kicad_pro" having the project name stripped.  We separate
the BOM netlist export from generic plugin netlist export to allow the
correct behavior when exporting netlists and generating BOMs

Fixes https://gitlab.com/kicad/code/kicad/issues/10270

(cherry picked from commit bef762e652)
 2022-01-05 11:07:49 -08:00
jean-pierre charras cd0ac9e698 eeschema, DIALOG_FIELD_PROPERTIES: fix a few issues. 
(incorrect handling of H and V justify bitmap buttons
Fixes #10267
https://gitlab.com/kicad/code/kicad/issues/10267
 2022-01-05 17:25:18 +01:00
jean-pierre charras c2b54faceb CvPcb: fix crash due to a null pointer: pcbconfig() can return null. 
CvPcb has no config option and pcbconfig() returns nullptr.
In this case use default settings.
Fixes #10250
https://gitlab.com/kicad/code/kicad/issues/10250
 2022-01-04 14:51:32 +01:00
Jeff Young e21fa31f64 Rip out rest of macHack architecture. 2022-01-03 22:09:56 +00:00
Jeff Young 89c0f8e297 Move to new font engine. 2022-01-02 14:57:03 +00:00
Jeff Young 32dec0127e Fix some issues with Eeschema's Shape Properties dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10140
 2022-01-01 20:46:45 +00:00
Marek Roszko c4c56de708 Neurotically update position wxPoint usages 2022-01-01 11:55:51 -05:00
Marek Roszko cadc0639eb Update BASE_SCREEN to VECTOR2I 2022-01-01 11:30:33 -05:00
Marek Roszko 347e03363a Convert wxPoint/wxSize starting from EDA_RECT usages 2022-01-01 11:30:33 -05:00
Roberto Fernandez Bautista 701e256b3f Correctly handle excluding an ERC marker in eeschema when right clicking 
In addition, hide the option to exclude a marker if the selected marker
is already excluded.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/10173
 2021-12-30 17:14:36 +00:00
jean-pierre charras 7c3f0612f1 DIALOG_SPICE_MODEL: fix a cosmetic issue (no room for the help text) 
Fixes #10170
https://gitlab.com/kicad/code/kicad/issues/10170
 2021-12-30 09:19:00 +01:00
Mark Roszko 44dc602d6b Yeet wxPoint/wxSize out of PLOTTER 2021-12-29 19:02:50 +00:00
Jeff Young 86cb57f4a7 Cherry-pick TEXT_ATTRIBUTES and EDA_ANGLE from rockola/kicad-strokefont 2021-12-28 22:15:20 +00:00
Wayne Stambaugh 7b1b96c933 Fix broken tree book selection in paged dialogs. 
This only affected the tree controls that only parented sub-pages.  Do
not use the dialog ctor to select the initial page.  Queuing a page
changed event to fire after the dialog is shown is the proper solution.
 2021-12-28 09:43:57 -05:00
Frank Zeeman e618ef98e9 Add potentiometer code models to model selection 2021-12-28 02:53:39 +01:00
Marek Roszko 705aa64c24 Fix parent of schematic setup parent nodes 2021-12-27 19:08:41 -05:00
dsa-t d105e773a1 Update columns when height changes too 2021-12-25 15:26:43 +00:00
Alex 45c50535c5 Use GetUnobscuredSize in dialogs/panels 2021-12-25 15:26:43 +00:00
Alex c4a4862e8f Try with KIPLATFORM 2021-12-25 15:26:43 +00:00
dsa-t b0cca4a89e Symbol Fields Table: Make list look as good as possible on Windows too 2021-12-25 15:26:43 +00:00
Jeff Young ec104e4ab0 Add hint to symbol editor defaults. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9776
 2021-12-24 23:25:07 +00:00
Jeff Young 03a2723b67 Improve GUI of lib item colors. 2021-12-24 21:21:11 +00:00
Jonathan Haas e2fc105201 Add custom fill color selection to shape properties dialog 2021-12-24 21:21:04 +00:00
Jeff Young 24ce4d8aa2 Improve help text now that we're past string freeze. 2021-12-24 18:13:26 +00:00
Jeff Young c3552a940a Make sure standard OK/Cancel buttons respond to current language. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9635
 2021-12-24 18:13:11 +00:00
Jeff Young af13533b42 Add show/hide controls for ERC markers. 
ADDED show/hide controls for ERC warnings, ERC errors and ERC exclusions.

Fixes https://gitlab.com/kicad/code/kicad/issues/7270
 2021-12-24 17:38:50 +00:00
Jeff Young a6dd1bf09b Implement Reset to Defaults for all preferences panels. 2021-12-24 17:38:39 +00:00
Jeff Young 4cf3f44532 More consistency with hint messages. 2021-12-24 17:23:41 +00:00
Jeff Young 889970a449 SCH_NETCLASS_FLAGs and SCH_FIELDs for labels. 
ADDED: a new label type for netclass flags.
ADDED: the ability to define fields on labels.
 2021-12-24 16:13:27 +00:00
Jeff Young f7721dd274 Add highlight shadows for highlighted nets. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8817
 2021-12-24 15:43:28 +00:00
Jeff Young d28714167c All the preferences, all the time. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7877

Fixes https://gitlab.com/kicad/code/kicad/issues/5153
 2021-12-24 13:08:44 +00:00
Jeff Young f1410f0240 Line styles for PCBNew shapes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/2150
 2021-12-24 12:36:59 +00:00
Jeff Young 295a6408c3 User-configureable dash styles (and dash-dot-dot). 
ADDED: Schematic Setup properties for dash length and gap length.
ADDED: dash-dot-dot line style

Fixes https://gitlab.com/kicad/code/kicad/issues/2206
 2021-12-23 20:36:24 +00:00
Jeff Young 2bc86fa0a8 Shapes for schematic. 
ADDED arc, circle and rectangle shapes for schematic.  Shapes support
line styles and fill colors.

CHANGED sheet background color in Edit Text & Graphics Properties to
fill color (and it now affects shapes).

Pushed STROKE_PARAMS down into common and moved all shapes to using it
for stroke descriptions.
 2021-12-23 20:36:07 +00:00
Jeff Young 6e2460ad37 Add hot-updating of units in common wxGrids. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10020
 2021-12-23 16:54:03 +00:00
Jeff Young 8b52e969d6 Restore units to a bunch of wxGrids. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10063
 2021-12-23 16:54:03 +00:00
Jeff Young 1ca90f31bf Fix hidden column in DIALOG_SYMBOL_FIELDS_TABLE. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9987
 2021-12-15 00:03:33 +00:00
Wayne Stambaugh 755607b8f8 Fix a few wxUpdateUIEvent retrigger loops. 2021-12-13 15:46:13 -05:00
Jeff Young 653c7b78d7 Move NC pin logic so we set it before we need it. 
Also fixes drawing the dangling symbol in the Pin Properties dialog
and when printing.

Fixes https://gitlab.com/kicad/code/kicad/issues/9962
 2021-12-12 22:25:36 +00:00
dsa-t 4ccfc21324 Fix event id intersections when toggling some columns via popup. 
Also increases maximum show/hide column count to 50.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9765
 2021-12-13 00:35:44 +03:00
Jeff Young 88fc6d25a7 Correctly handle deleting multiple selections in some grids. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9952
 2021-12-12 17:28:17 +00:00
Wayne Stambaugh b7af66e3f9 Eeschema: fix broken page numbers when renaming a sheet file name. 
Always use full sheet paths when storing sheet instances.  Partial sheet
paths cannot be full resolved resulting in lost page numbers when renaming
sheet file name.

Fixes #9782
 2021-12-09 12:56:03 +00:00
Jeff Young c4336de868 Bug fixes in new dangling symbol drawing code. 2021-12-07 21:31:42 +00:00
Seth Hillbrand 84cdc9701f Partially reverts d877f041 
Based on discussion in https://gitlab.com/kicad/code/kicad/-/merge_requests/1029
we will keep the original behavior.  The new routines to get stock paths
are still useful (possibly in scripting) and are kept
 2021-12-06 16:14:40 -08:00
Jeff Young 2e342ed8c9 Draw dangling symbols on a separate layer. 
This allows us to draw them in front of wires, pins, and most
importantly, junction dots.

Fixes https://gitlab.com/kicad/code/kicad/issues/9667
 2021-12-06 18:50:50 +00:00
Wayne Stambaugh a03e6e4926 Revert "Eeschema: fix broken page numbers when renaming a sheet file name." 
This reverts commit a468a79948.
 2021-12-06 07:47:18 -05:00
dsa-t cb482eb8eb Symbol Fields Table: Highlight proper symbols even if they aren't annotated 2021-12-03 20:35:54 +00:00
Mikolaj Wielgus 9efbeaa064 Dark theme support for SPICE model editor 2021-12-03 03:41:32 +01:00
Franck Bourdonnec d877f04198 fixe paths 2021-12-02 20:23:00 +00:00
Wayne Stambaugh a468a79948 Eeschema: fix broken page numbers when renaming a sheet file name. 
Remove duplicate instance data saved in both root SCH_SCREEN and SCH_SHEET
objects that was causing them to be out of sync.  All sheet instance data
is stored in the SCH_SHEET object itself and rebuilt on the fly so it is
always current.

Remove Get/SetPageNumber from SCH_SHEET_PATH object so it doesn't obfuscate
where the actual sheet page number information exists.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9782
 2021-11-30 08:11:24 -05:00
Jeff Young a0711bdb56 Keep previous commit from violating string freeze. 2021-11-29 20:09:35 +00:00
Jeff Young 78be5df39a Don't allow negative line widths to shrink bounding box. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9776
 2021-11-29 20:02:03 +00:00
Jeff Young a0f1d77eaa Quiet wxWidgets assert. 2021-11-29 18:54:47 +00:00
jean-pierre charras 91363dd93c PANEL_EESCHEMA_COLOR_SETTINGS: fix a minor cosmetic issue. 2021-11-29 15:30:38 +01:00
Jeff Young 3a51fb6ac6 Be more consistent about annotation warngings. 
This can be a particular problem if you go to run ERC, it shows the
annotation warnging so you re-annotate (but don't notice that your
scope is set to Selection).

Also adds some missing defensive code around closing a modeless RC
checker before the document (which we had for DRC dialog but not the
ERC dialog).

Also fixes a missing override of GetSeverity which kept ERC messages
from having the right prefix.
 2021-11-29 14:24:45 +00:00
Roberto Fernandez Bautista dd219419a0 Quiet wxWidgets asserts (sheet & symbol properties dialogs) 
Ensure we don't set column size smaller than 1. If so, set to
-1 to auto size.
 2021-11-27 21:03:42 +00:00
Jeff Young 87e71072b1 Default line width to 0 in symbol editor. 
Also removes some atrophied settings for repeated non-pins in
symbol editor (which only ever repeats pins).

Fixes https://gitlab.com/kicad/code/kicad/issues/9776
 2021-11-27 11:53:38 +00:00
jean-pierre charras b8b8c0d34c dialog text properties: fix a focus issue. 
Fixes #9792
https://gitlab.com/kicad/code/kicad/issues/9792
 2021-11-27 10:08:30 +01:00
Seth Hillbrand 65fc47cb8f Don't lose track of the sheet's screen 
Corner cases need to clear screen before loading a new file.  Aborting
needs to restore the screen or risk segfaults

Fixes https://gitlab.com/kicad/code/kicad/issues/9739
 2021-11-23 10:57:12 -08:00
Jeff Young 5a5af91d88 Tidy up the SCH_PREVIEW_PANEL visibility flags. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9701
 2021-11-20 15:28:17 +00:00
Seth Hillbrand 766a09c338 Remove autocomplete when we lose focus 
Prevents the excess dropdown from persisting over windows

Fixes https://gitlab.com/kicad/code/kicad/issues/9651
 2021-11-19 17:24:16 -08:00
Simon Schaak 399f2c116e Symbol editor: save changed field properties 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9648
 2021-11-15 20:40:32 +01:00
Jeff Young b747ae5bdf Make sure redraw happens regardless of order of panel commits. 
(We don't control the order of the TransferDataFromWindow calls
for the various panels and here the junction dot size is dependant
on the default netclass wire size.  So that calc has to be done
after all the various TransferDataFromWindow calls are made.)

Fixes https://gitlab.com/kicad/code/kicad/issues/9541
 2021-11-13 23:20:56 +00:00
jean-pierre charras e218471d24 DIALOG_CHANGE_SYMBOLS: fix a bug introduced by my commit 686b32db 
the filtering for mandatory fields was disabled.
 2021-11-13 13:47:09 +01:00
Jeff Young 1e151b1bcb Fix effective pen width when plotting wires. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9625
 2021-11-12 16:27:55 +00:00
jean-pierre charras 686b32dbd3 fix issue in DIALOG_CHANGE_SYMBOLS, in non English locale. 
Mandatory field names where compared in list, using translated and not translated names.
Fixes #9596
https://gitlab.com/kicad/code/kicad/issues/9596
 2021-11-11 10:56:09 +01:00
Jeff Young 83e5208213 Fix a couple of holes in the IsTestEnabled() checks. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7270
 2021-11-04 16:24:06 +00:00
Seth Hillbrand cf6b18ec7e Remove escaped double-quotes 
For some reason, escaped double quotes in wxString::Format cause issues
on Mac.  We can replace them with single quotes in most places without
loss of clarity
 2021-11-03 17:03:14 -07:00
Jeff Young 179628d1d2 Repair field properties dialog for rotation and mirroring. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9508
 2021-11-03 18:11:59 +00:00
Simon Schaak f79cb382c4 Symbol editor: fix name corruption in pin table 
Discard changes to pin numbers of grouped pins in the pin table to avoid
setting all pins of the group to the same number.
 2021-11-01 22:10:13 +00:00
Jon Evans 80e372b7d9 Fix blank DC sources causing crash in dialog creation 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9482
 2021-10-30 11:17:10 -04:00
Jeff Young b967610e05 Remove confirmation for De Morgan (and spell his name right). 
Fixes https://gitlab.com/kicad/code/kicad/issues/9483
 2021-10-29 20:30:37 +01:00
jean-pierre charras c3a4c40d4c DIALOG_CHANGE_SYMBOLS: add missing skip event in wxFocusEvents. 
Fixes #9467
https://gitlab.com/kicad/code/kicad/issues/9467
 2021-10-27 17:17:44 +02:00
Jeff Young 3d2ffc12c1 Fix bugs in B&W plotting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9411
 2021-10-26 22:58:55 +01:00
Jeff Young c52cb229d0 Add unsaved-changes indication to Symbol Properties. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9443
 2021-10-25 12:35:04 +01:00
Jeff Young e30d867439 Use consistent terminology for various constraint modes. 2021-10-23 12:18:08 +01:00
Seth Hillbrand 927b633c01 Make sure spice command doesn't assert 
Fixes https://gitlab.com/kicad/code/kicad/issues/4328
 2021-10-22 16:50:29 -07:00
Jeff Young 4dcc847f85 Remove artificial limits from label increment control. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9340
 2021-10-22 22:20:20 +01:00
Wayne Stambaugh 0795fcb810 Minor dialog layout fixes. 2021-10-21 08:59:55 -04:00
jean-pierre charras bb4330db1e DIALOG_BOM: do not quote filename when calling the editor. 
Due to previous changes in code, filenames must be not quoted.
Fixes #9436
https://gitlab.com/kicad/code/kicad/issues/9436
 2021-10-21 13:53:52 +02:00
Seth Hillbrand 64bcaaefd1 Fix radiobox order for FILL_T 
Fixes https://gitlab.com/kicad/code/kicad/issues/9412
 2021-10-17 17:01:21 -07:00
Ian McInerney 5817a8b5f4 Remove unused m_host variable 
This variable isn't needed anymore after 5f53019290
pushed dark mode handling into the HTML window itself.
 2021-10-18 00:29:40 +01:00
Jeff Young b52529521e Replace individual LIB_* shapes with LIB_SHAPE (based on EDA_SHAPE). 
Also moves to more capable FILL_T model that can be shared.
 2021-10-15 12:45:43 +01:00
Mikolaj Wielgus 5f53019290 Substitute all wxHtmlWindow with HTML_WINDOW 
Remove other places where <body> tag is used to override the default
black-on-white theme.
 2021-10-12 07:07:15 +00:00
Seth Hillbrand 48f9dfa988 Revert "Fix grid cell highlight not functioning on Windows in the symbol pin table" 
This reverts commit 94552ed838.

Breaks cell-based copy/paste
 2021-10-10 08:04:11 -07:00
Jeff Young 57c7d663b0 Fix bone-headed mistake when moving panel disabling. 2021-10-07 00:17:42 +01:00
Jeff Young 95f841a037 A more nuanced method of making Board & Schematic Setup read-only. 
This one still allows you to scroll to see all contents.

Fixes https://gitlab.com/kicad/code/kicad/issues/9302
 2021-10-06 11:16:46 +01:00
Seth Hillbrand 854472d550 Prevent automatic RTree recaching 
Calling UpdateItem() may be performed by in a common loop, e.g. for(
SCH_ITEM* item : GetScreen()->Items() ) or similar.  We cannot call
GetScreen()->Update( SCH_ITEM* ) in this routine as it will remove and
re-add the item to the RTree, invalidating iterators.  If needed, the
items need to be cached to an external container before updating

Fixes https://gitlab.com/kicad/code/kicad/issues/9318
 2021-10-05 20:13:15 -07:00
Seth Hillbrand 9a8d1246cc We don't keep a CHANGELOG.TXT 
Direct interested readers to AUTHORS.TXT instead.
 2021-10-05 19:46:53 -07:00
Jeff Young 92008a089a Disable Board & Schematic Setup controls when project is locked. 
(or missing).

Fixes https://gitlab.com/kicad/code/kicad/issues/9302
 2021-10-04 16:47:27 +01:00
Jeff Young 7c432d7a50 When annotating for another feature, make sure scope is entire schematic. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9303
 2021-10-03 19:42:29 +01:00
Jeff Young 574bef2237 Normalize drawing sheet path to env vars & prj, not just prj. 
Also cleans up the dialog a bit.

Also changes the workings of NormalizePath to return the input if
it couldn't be shortened which saves open coding that behaviour in
all its callers.

Fixes https://gitlab.com/kicad/code/kicad/issues/9036
 2021-10-02 23:39:45 +01:00
Marek Roszko 94552ed838 Fix grid cell highlight not functioning on Windows in the symbol pin table 
Fixes https://gitlab.com/kicad/code/kicad/issues/9290
 2021-10-01 23:44:16 -04:00
Jeff Young 5f5ee7335d Formatting. 2021-10-01 21:49:14 +01:00
Jeff Young f606679164 Proper numeric sorting for intersheet refs. 
Also expunges the horrifically named std::remove and std::remove_if
(neither of which remove anything).
 2021-10-01 18:29:21 +01:00
Jeff Young b9596a0a5d Update dangling flags in color settings' preview. 2021-09-30 18:53:39 +01:00
Seth Hillbrand 2225c4e4ed Replace GetRows() with GetNumberRows() because wx 2021-09-28 10:48:04 -07:00
Seth Hillbrand 880f209563 When deleting pin row, show new highlight 
When the user deletes a pin row, they need to see which row is now
selected for them to delete again.  Otherwise, deleting will have
unexpected consequences
 2021-09-28 09:29:55 -07:00
Roberto Fernandez Bautista 7089a837f6 Update Editing Options Panel in eeschema with latest modifier keys 
We now use Long Click, Ctrl and Shift (Alt is no longer used)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9234
 2021-09-27 21:11:56 +01:00
Jeff Young c508c89a81 Pretty-up some warning messages. 2021-09-27 13:24:53 +01:00
Jeff Young f6571c18cb Formatting. 2021-09-26 11:02:57 +01:00
Jeff Young c9aebb8529 Fix symbol fields sorting. 
In the symbol fields table the reference contains only the letter, so
the number must be appended.  Conversely, we don't want the unit suffix
as all units are folded into a single symbol.

Fixes https://gitlab.com/kicad/code/kicad/issues/9238
 2021-09-25 21:24:16 +01:00
jean-pierre charras f11687c5e5 Do not allow sheet filename change from DIALOG_SCH_FIELD_PROPERTIES. 
It does not work. Changing a sheet filename is complex, and can be
made only in sheet properties dialog.
 2021-09-25 18:28:19 +02:00
Jeff Young 6e7ce09572 Use more descriptive terminology for preferred text editor. 
Also improves execution to allow the preferred editor to include
parameters, such as "/usr/bin/open -e".

Fixes https://gitlab.com/kicad/code/kicad/issues/9131
 2021-09-19 15:17:26 +01:00
Jeff Young 4779850c10 Add done messages to various plotters. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9172
 2021-09-18 10:39:57 +01:00
Jeff Young 2479e1d7b1 Improve common settings property grouping. 
Also moves apply-icon-scaling-to-fonts to its own checkbox.  (We used
to try to infer when to do it, but that turns out to be a rathole.)
 2021-09-16 18:31:44 +01:00
Jeff Young e2ce2e6ca9 Correct slight misalignment in Library Link fields. 2021-09-15 21:17:18 +01:00
Jeff Young b84d1456d5 KIFACE_I -> KIFACE_BASE. 2021-09-14 23:45:14 +01:00
Jeff Young 3aae3c6f65 Dark mode for a bunch of HTML dialogs. 
WX_HTML_REPORT_BOX
WX_HTML_REPORT_PANEL
HTML_MESSAGEBOX
DIALOG_DISPLAY_HTML_TEXT

Fixes https://gitlab.com/kicad/code/kicad/issues/9157

Fixes https://gitlab.com/kicad/code/kicad/issues/9156
 2021-09-14 21:23:57 +01:00
Jeff Young a5247471f7 Expunge a bunch more fixed font specs from wxFormBuilder files. 
Also removes the -1 sizing of the status bar on GTK and MSW.

Fixes https://gitlab.com/kicad/code/kicad/issues/8608
 2021-09-12 13:53:12 +01:00
Jeff Young 9c78e4cf54 Mac needs different font size handling than MSW & GTK. 
Mac already uses diverse font sizes (for instance, smaller fonts for
radio button groups), and the anti-aliasing is a lot better.  The
other platforms need a more limited range of sizes.

Fixes https://gitlab.com/kicad/code/kicad/issues/8608
 2021-09-11 23:40:31 +01:00
Jeff Young fbee62fc15 Tie font size scaling to when automatic icon scaling fails. 
It appears that SetSymbolicSize() and ConvertDialogToPixes() fail
under the same circumstances.
 2021-09-11 15:29:51 +01:00
Jeff Young 09ddcdbbca Fix logic error setting bold text. 
(Reported on Forum.)
 2021-09-11 12:01:41 +01:00
Jeff Young 7a822b55aa Another round of changes to attempt to fix the GTK font size issue. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8608
 2021-09-10 15:59:50 +01:00
Jeff Young 5325dce862 Naming consistency with DRC reports. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9121
 2021-09-09 13:37:57 +01:00
Jeff Young f013dbc7c4 More uniform handling of status fonts. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8608
 2021-09-08 21:34:22 +01:00
Wayne Stambaugh 41c7089417 Minor dialog layout improvements. 2021-09-07 08:06:02 -04:00
jean-pierre charras 07f0662ba9 Fix some issues in dialog_netlist.cpp , round 2 (work in progress) 
The netlist plugins added in dialog_netlist are now stored in eeschema config.
 2021-09-05 16:13:52 +02:00
Jeff Young 6818539f6d Repair is-selected logic in various global editors. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9090
 2021-09-04 18:10:25 +01:00
jean-pierre charras 1fe4aaa64f fix some issues in dialog_netlist.cpp (work in progress) 2021-09-03 20:38:29 +02:00
Roberto Fernandez Bautista a06f3f1d14 Don't update text items until modified explicitly 
Ensures that any complex formatting in text items created by importers
or pasted S-expressions is preserved.
 2021-09-03 19:25:53 +01:00
Jeff Young bc8245ca7b Attempt to untangle junction dot preferences. 2021-09-02 12:41:16 +01:00
Seth Hillbrand 8a305eec32 Remove broken RefDesStringCompare 
This function attempted a poor-man's natural compare but it assumed
specific structure of the string.  This broke for strings with
numberings that looked like decimals.

Instead, we use our natural string comparison function and remove the
references to this older function and its similar elements.

Fixes https://gitlab.com/kicad/code/kicad/issues/9067
 2021-09-01 11:48:01 -07:00
Jeff Young d92d9898ad Scale junction dots from wirewidth, not linewidth. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9040
 2021-09-01 19:44:18 +01:00
Jeff Young 21365fff3e Disambiguate JunctionDiameter from EffectiveJunctionDiameter. 
ADDED Junction Size and Color to Edit Text & Graphics properties.

The added feature is only because it's the only way to recover from
the buggy behaviour having changed all your junctions to overridden
values.

Also adds help texts to the Junction Dot Properties dialog to
specify how to get schematic dot sizes and eeschema colors.

Also fixes the terminology in the Line/Wire/Bus Properties dialog
(the default widths come from the netclasses, not from eeschema).

Fixes https://gitlab.com/kicad/code/kicad/issues/9040
 2021-08-31 12:18:02 +01:00
Sylwester Kocjan ddba9e2351 eeschema: fix of not updating spice primitive field 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8835
 2021-08-31 06:27:36 +00:00
Mike Williams 0b2e66d3b7 Infobar: Don't use animations on Windows/GTK 
Seems to cause issues on Windows where the animation locks the screen.
Doesn't effect Linux, possibly because wxWidgets uses a native GTK
infobar that doesn't animate anyway.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8987
 2021-08-27 17:38:16 +00:00
Sylwester Kocjan eefac5cc59 eeschema: fix in populating DC sim settings tab 
When filling drop-down list with sources, previous selection should be
saved in local variable and restored if it is still available.
 2021-08-20 19:23:13 +00:00
Seth Hillbrand bee3d78d78 Limit Eeschema find/replace entries 
Standardize maximum find/replace entries to 10

Fixes https://gitlab.com/kicad/code/kicad/issues/9007
 2021-08-20 11:48:02 -07:00
jean-pierre charras 13083c80c2 Eeschema, dialog Find: do not force a position on screen when reopen dlg. 
The last position will be used.
Fixes #8969
https://gitlab.com/kicad/code/kicad/issues/8969
 2021-08-19 15:40:38 +02:00
Wayne Stambaugh 46b959c3e3 Move plotter headers into include folder. 2021-08-18 16:38:31 -04:00
Wayne Stambaugh 6427197962 Remove duplicate headers in plot and associated code. 2021-08-17 15:41:25 -04:00
Jeff Young fc4d748bdc Fix bugs in sheets. 
1) Default_line_width is in mils, not IU.
2) Plot sheet fields.

Fixes https://gitlab.com/kicad/code/kicad/issues/8984
 2021-08-17 13:21:52 +01:00
Jeff Young 41619ebbe2 Decouple PROGRESS_REPORTER interface from implementations. 2021-08-14 21:05:49 +01:00
jean-pierre charras 08d7899f7e Rework on hint to user when pin scope control has no effect or unexpected result. 
A info banner is now shown (in synchronized mode) to inform an user when extra
pins are added to other units when a new pin is added.
A good info about the synchronized mode is not easy to create.
 2021-08-14 10:21:25 +02:00
Jon Evans 7075aece3a Hint to user when pin scope control has no effect 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8907
 2021-08-12 21:19:27 -04:00
Jeff Young fbb3f4b58d Escape names when migrating legacy libraries. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8951
 2021-08-12 22:07:57 +01:00
Jeff Young c536a4c4f2 Work around annoying wxWidgets assert. 2021-08-10 16:51:30 +01:00
Jeff Young 6eb59b9d9e Dialog naming conventions. 2021-08-06 20:54:26 +01:00
Jeff Young 48e0f68c7e Improve ease-of-use of color preferences. 2021-08-04 13:55:42 +01:00
Jeff Young 95b87ba29a Freshen microwave polygon dialog and remove a bunch of dead code. 2021-08-03 01:11:11 +01:00
david-beinder c34f45f646 Split global label size expansion from TextOffset setting 
Global label expansion ratio default is now 37.5%
Wire text offset default is now 15%
 2021-08-02 16:40:36 +00:00
Jeff Young 6aaf4413b3 Fix kicad_string.h / string.cpp mismatch. 
They don't define a KiCad string class, so the header file name was
somewhat misleading. But the fact that they didn't match definitely
made coding more difficult.
 2021-07-29 16:03:25 +01:00
Jeff Young f221220fe2 Rename layer ids file. 
It hasn't had anything to do with colors or visibility for some time
now.
 2021-07-29 16:03:25 +01:00
Mike Williams 934b6e4cdc Eeschema: fix symbol library link not showing 
In wxWidgets GTK, SetLabel() won't show anything. Seems like an old
wxWidgets issue:
https://forums.wxwidgets.org/viewtopic.php?t=20207
 2021-07-29 01:19:51 +00:00
Jeff Young 46338403e7 Unwrap some std::library typedefs. 2021-07-28 22:16:38 +01:00
Jeff Young 87e4a1c672 Remove cover type; capitalize class name; make filename equal classname. 2021-07-28 22:16:38 +01:00
Jeff Young 293f207356 Hopefully the last of the symbol id escaping issues. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8694
 2021-07-28 19:44:42 +01:00
Wayne Stambaugh f233f4a0a9 Expunge EDA_FILE_SELECTOR. 
EDA_FILE_SELECTOR was just an obfuscation of wxFileSelector().
 2021-07-28 14:12:51 -04:00
Jeff Young 6d4c454e8c Fix some more missing escaping for symbol ids. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8694
 2021-07-28 18:37:09 +01:00
Jeff Young 726f4d8016 Fix up some more cases of missing escaping for symbol names. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8694
 2021-07-28 16:40:38 +01:00
Wayne Stambaugh 37b200cb3e Pass wxString objects by reference instead of on the stack. 2021-07-27 08:41:27 -04:00
jean-pierre charras 8ff76de18e DIALOG_EDIT_ONE_FIELD: fix a non resizable widgets and fix a compil warning. 
Fixes #8877
https://gitlab.com/kicad/code/kicad/issues/8877
 2021-07-27 14:12:46 +02:00
Wayne Stambaugh 8fd83cbb95 Pass wxPoint objects by reference instead of on the stack. 2021-07-26 15:35:33 -04:00
Wayne Stambaugh 1a301d8eea Stop using wxDialog::EndModal() from inside dialogs. 
Calling wxDialog::EndModal() directly from inside the dialog is a
potential bug if the dialog is shown in the modeless or window modal
(quasi-modal).  Use the internal button events where possible and
check for the appropriate mode before calling the correct end dialog
function.
 2021-07-21 17:38:14 -04:00
Wayne Stambaugh cb72da294a More NULL expunging. 2021-07-16 16:13:41 -04:00
Seth Hillbrand d1c9572bcc Allow editing symbols when added to schematic 
We do not allow editing symbols in Legacy libraries, but once they are
added to the schematic, they become editable
 2021-07-16 12:08:57 -07:00
jean-pierre charras 4df3ba6a56 DIALOG_SPICE_MODEL: expand env var to open lib file selection dialog in the previous selected lib 2021-07-12 19:40:03 +02:00
Jeff Young 0b4bb9378b Use consistent terminology. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8777
 2021-07-12 11:59:07 +01:00
Marek Roszko 759f0e9a75 Be sure to stop the timer during widget destruction 
Also fix a comment elsewhere :D

Fixes #8772
 2021-07-11 19:17:34 -04:00
Jeff Young 5bd30232e8 Remove nag preventing setting shape to default line width. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8774
 2021-07-11 13:04:55 +01:00
Jeff Young 2fc4ee5c5f Upgrade "project is missing" to a warning. 2021-07-10 09:47:49 +01:00
Jeff Young a06b95bb1f Even out spacing around various panels. 2021-07-09 23:42:45 +01:00
Wayne Stambaugh dffe2661e6 Fix SPICE simulator plot bug. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1944
 2021-07-09 16:20:35 -04:00
jean-pierre charras 928c4e8ed7 DIALOG_SPICE_MODEL: expand environment vars in spice library path. 2021-07-09 18:22:59 +02:00
Mikolaj Wielgus 6dfd655a7f Save simulator checkbox settings in project file 
Fixes https://gitlab.com/kicad/code/kicad/issues/8450
 2021-07-06 10:06:51 +00:00
Jeff Young ea6769b702 The REPORTER interface is inherently line-based. 
Also fixes a bunch of error messages that were similar but not
identical (which just increases translation burden).

Fixes https://gitlab.com/kicad/code/kicad/issues/8723
 2021-07-05 13:41:06 +01:00
Jeff Young 6c161eec68 Autodetect plugin type when editing filename cell. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8687
 2021-07-04 18:21:16 +01:00
Jeff Young f46486bc3e Naming conventions. 2021-07-03 21:43:57 +01:00
Jeff Young 5507230b9b Minor dialog spacing issue. 2021-07-03 15:24:54 +01:00
Wayne Stambaugh 3f6811f413 Minor dialog layout improvements. 2021-07-02 11:36:06 -04:00
Jeff Young dacb5f58e8 Default bus entries to default (0 width and transparent color). 
Also adds some help text to the dialog so it's easier to figure out
what's going on.

Fixes https://gitlab.com/kicad/code/kicad/issues/8607
 2021-07-01 15:43:19 +01:00
Jeff Young 201c34345f Fix sheet filename if it's missing extension. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8619
 2021-07-01 15:43:19 +01:00
Jeff Young 00504368d6 Better label for fieldname filter, and single undo for all sheets. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8704
 2021-06-30 18:45:18 +01:00
Jeff Young b1b4caee6a Escape "naughty" characters in symbol names. 
It's tempting to say that we don't need to exclude filename chars
from symbols, but we might regret that decision down the road.  Better
to just escape them.

Fixes https://gitlab.com/kicad/code/kicad/issues/8694
 2021-06-30 13:12:57 +01:00
Jeff Young 0c2ac9a711 Move GUI font code to common. 
This also allows the Mac fixes for font facenames to be more
compartmentalized.

Fixes https://gitlab.com/kicad/code/kicad/issues/8657
 2021-06-29 18:27:58 +01:00
Jeff Young 6c67dfa032 Improve eeschema colour preview zoom-to-fit a bit. 2021-06-29 01:08:26 +01:00
Jeff Young a1dfc36233 More error message regularization. 2021-06-29 01:08:26 +01:00
Jeff Young e2a2c3282a Update fields list when source or target lib IDs change. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8263
 2021-06-28 20:38:19 +01:00
Jeff Young d296bec5b8 Differentiate aSingleLine mode for SCINTILLA_TRICKS 
This allows us to avoid the monospaced font (along with the tab-stop
handling), and process a <return> as an OK rather than just <shift> +
<return>.

Fixes https://gitlab.com/kicad/code/kicad/issues/8425
 2021-06-28 11:20:12 +01:00
Jeff Young 4aa8318dc2 More error message regularization. 2021-06-27 14:24:02 +01:00
Jeff Young 0dfb5fcaf9 Error message cleanup. 
wxString::Format is redundant in a wxLogXXX call.
Error messages should generally be translatable.
Error messages should use generally consistent sentence forms.
 2021-06-26 22:53:24 +01:00
Jeff Young 5c21f93803 Consistency in progress and error messages. 2021-06-26 13:23:43 +01:00
Jeff Young 27804e40e2 Go back to using space-width for tabs (instead of max-char-width). 
The max-char-width impl was buggy and never applied to PCBNew anyway.
Plus the stroke font has a max-char-width of 2.8 time the space width,
so it made for really wide tab spacing.

Also fixes a bug where the Scintilla editors weren't getting a
monospace font on Mac.  (This bug may also exist on the other
platforms, but each would need its own fix.)

Also moves more of the Scintalla customizations to SCINTILLA_TRICKS
where they can be shared.

Fixes https://gitlab.com/kicad/code/kicad/issues/8666
 2021-06-24 23:53:27 +01:00
PJM 15d36456a9 Eeschema: Save annotation starting value in project settings 
CHANGED: Added support for saving the starting value for annotation

Fixes https://gitlab.com/kicad/code/kicad/issues/8364
 2021-06-21 10:19:09 +00:00
Jeff Young e540752640 Allow all selected footprints/symbols to be changed. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7389
 2021-06-17 23:34:56 +01:00