haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
38,733 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

64 Commits

Author SHA1 Message Date
Jeff Young 1218f61d0a Implement undo/redo for footprint children. 
Our special-cases to handle the fact that we didn't do this had far
outgrown the code necessary to actually handle it.
 2023-07-15 17:37:31 +01:00
Jeff Young cf8294b5c2 Remove a bunch of blind (and a few redundant) static_casts. 2023-07-13 14:14:45 +01:00
StuartTylerRelytDesigns d26aa7dc20 Pcbnew moveIndividually ctrl-M mangles 2+ tracks 
CHANGED: moveIndividually ctrl-M not mangle tracks and add grid snapping

Fixes https://gitlab.com/kicad/code/kicad/issues/15124
 2023-07-08 09:11:53 +00:00
Jeff Young 7ed5963b4f Disable positioning tools when a move is in progress. 
Also fixes a typo in EDIT_TOOL::doMoveSelection().

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15090
 2023-06-30 20:37:03 +01:00
Jeff Young 773e1a1ab6 Actions with a COMMIT must be run synchronously. 
Note that "immediate" doesn't mean quite the same thing: while it will
enter the tool immediately, it won't necessarily finish the tool during
the call if the tool has an event loop.  So for something like Rotate
"immediate" and "synchronous" have the same behaviour, but for something
like Move they do not.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15085
 2023-06-30 18:57:37 +01:00
Jeff Young 1411b09178 Remove EDIT_TOOL's quasi-global BOARD_COMMIT. 
It had several encapsulation leakage issues, as well as poorly-defined
behaviour of undo for chained-actions (append-to-board, and then rotate
while moving, for instance).
 2023-06-27 17:04:18 +01:00
Ian McInerney 2fb6f19a84 Separate immediate and delayed action dispatch 
Using a boolean argument just leads to a lot of trailing booleans in the
function calls and is not user friendly. Instead, introduce PostAction()
to send an action that runs after the coroutine (equivalent to passing
false or the default argument), and leave RunAction as the immediate
execution function.
 2023-06-27 00:57:59 +01:00
Ian McInerney f14feafc6b Convert selection vector to EDA_ITEMS for base tool call 
The base tool expects a generic EDA_ITEMS, but the existing vector
doesn't easily cast, so add a temporary one.
 2023-06-20 21:52:50 +01:00
Ian McInerney b04e54dbea Switch TOOL_EVENT and TOOL_ACTION to have a std::any parameter 
Using std::any from C++17 allows for proper type handling in the
parameter field, removing the need for casting to void* and then casting
the void* to the desired type.
 2023-06-20 21:52:50 +01:00
Marek Roszko b41606ecf7 Use the correct printf format for the move individually status text 
Fixes sentry KICAD-1ZT
 2023-06-04 21:08:13 -04:00
Lucas Dumont c781fde236 pcbnew: don't move twice 
In pcbnew, if you press M to move your selection and press M again, then escape, you will trigger the https://gitlab.com/kicad/code/kicad/-/blob/master/common/tool/tools_holder.cpp#L106 assert
 2023-04-26 15:37:18 +00:00
jean-pierre charras 2f392352b5 EDIT_TOOL::doMoveSelection(): avoid calling PushTool() and, just after,PopTool() 
for the *same* event: TOOLS_HOLDER::PopTool() does not work fine in this case.
 2023-04-26 13:00:50 +02:00
Jeff Young 28028c941e Retire Local/Draw coords distinction from PAD (the last object to have it). 2023-04-02 18:02:41 +01:00
Jeff Young bbd6c80507 Collapse FP_* down into their PCB_* equivalents. 2023-03-31 22:57:46 +01:00
Marek Roszko 4665823089 Turn on and fix MSVC compliance mode issues 
We want /permissive- to enable debug performance improvements in MSVC 17.5+.
This flag is also default under C++20 so we'll have to deal with these compile issues anyway at some point in the future.

In particular, MSVC becomes pedantic about ternary types.
See https://learn.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-170#ambiguous-conditional-operator-arguments

MSFT cites https://cplusplus.github.io/CWG/issues/1805.html
 2023-02-12 16:30:37 -05:00
Mike Williams 47dc2379d8 PCB: Fix issues with grab unconnected 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13232
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13233
 2022-12-21 15:10:19 -05:00
Alex 75053cfc57 Remove normally unused code from Move function. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13222
 2022-12-21 19:06:32 +03:00
Seth Hillbrand 4fe35d0df1 More push/pop tool issues 
We need to pop the move tool off when it doesn't find anything to act on
so that the pushed tools under it on the stack can re-activate

Fixes https://gitlab.com/kicad/code/kicad/issues/13114
 2022-12-12 12:56:35 -08:00
jean-pierre charras 96a9ec4a0c Enhance compatibility with V6.0 for Intersheetrefs fields associated to GLOBAL labels. 
In V6.0, the identifier is "Intersheet References" and was not immediately
seen as Intersheetrefs field.
 2022-12-12 16:38:04 +01:00
Alex b4b25a7009 Fix Pack & Move footprints when working with groups. 2022-12-09 20:42:35 +03:00
Alex c1f82d0c80 Canceling Move cancels Pack too in Pack & Move footprints. 2022-12-09 20:41:56 +03:00
Jon Evans 0bc06d506c Properties: reselect after canceled move 2022-12-02 21:40:21 -05:00
Mike Williams 17bb57cc73 PCB: fix stale ratsnest between moves in Move Individually 2022-11-30 09:11:37 -05:00
Mike Williams ad6ef35c9f PCB: Add skip action to Move Individually 2022-11-29 15:42:03 +00:00
Mike Williams 4a4fab78a3 PCB: allow swap while moving 2022-11-28 14:16:08 -05:00
Jeff Young 9724f6e736 Don't allow zone filling during other editing operations. 
It's a very heavy op, and is likely to violate all manner of
assumptions the other ops make.

Fixes https://gitlab.com/kicad/code/kicad/issues/12736
 2022-11-14 23:39:49 +00:00
jean-pierre charras f51db4e093 Fix some Coverity and compil warnings. 2022-11-14 09:02:40 +01:00
Jeff Young 7089e99f4b Integrate move individually into move algo so other commands don't choke. 
Also adds commands to cancel and finish move individually.

Fixes https://gitlab.com/kicad/code/kicad/issues/12750

Fixes https://gitlab.com/kicad/code/kicad/issues/12749
 2022-11-13 13:18:42 +00:00
Jeff Young d9987e9569 Orig_items will have been invalidated by Revert. 
Don't use it to rebuild the selection.  Use the board_item flags instead.

Fixes https://gitlab.com/kicad/code/kicad/issues/12882
 2022-11-11 22:57:38 +00:00
Jeff Young 138f835672 Retire group bbox cache. 
It's too hard to maintain when changes to other items (the groups
members) affect it.
 2022-11-11 20:31:31 +00:00
Jeff Young 03ba14c6d3 Tighten lifecycle management of parent group pointers. 
Also adds some debugging to try to catch dangling pointers.

Also adds a cache for group bounding boxes (which will be expensive
to calculate for large groups).

Fixes https://gitlab.com/kicad/code/kicad/issues/12875
 2022-11-11 17:27:28 +00:00
Jeff Young 2cfe78170c Honour selection filter when picking move anchors. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12773
 2022-11-08 16:27:18 +00:00
Jeff Young bb618f2d55 Update pointEditor after cancelled move. 2022-11-05 16:50:54 +00:00
Jeff Young e3842514e7 Move courtyard collision setting to preferences. 
Also cleans up PCBNew/FPEditor edit options panel to be more in sync
with each other.
 2022-10-19 11:33:11 +01:00
Jeff Young e9f8454a67 No DRC engine in footprint editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12658
 2022-10-16 18:39:37 +01:00
Jeff Young de5980b92e Share more of the courtyard collision highlighting code. 2022-10-14 10:42:07 +01:00
Jeff Young 11dc5424cb Pull interactive courtyard checker out of move tool to share with router. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12594
 2022-10-14 00:48:37 +01:00
Jeff Young 8f1b4a9c03 Include cleanup. 2022-10-13 23:15:41 +01:00
Jeff Young 79dabdd484 Fix typo. 2022-10-07 23:52:47 +01:00
Jeff Young 04fec5016b Add keepout zones set to keepout footprints to footprint courtyard checker. 
(This is for the move tool, not DRC.  DRC uses more sophisticated keepout
processing which is too slow for the move tool, and doesn't let us know which
keepout area collided for collision highlighting.)

Fixes https://gitlab.com/kicad/code/kicad/issues/12594
 2022-10-07 22:23:37 +01:00
Jeff Young ba630971af Possible fix for move/esc/esc crash. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12553
 2022-09-30 23:05:55 +01:00
Mike Williams c1da59b560 Swap: disallow swapping tracks / wires 
Also fix missed shortcut change for S -> Shift-S

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12538
 2022-09-29 17:04:43 -04:00
Alex 4095172259 ADDED: Pack and Move Footprints, improved footprint spread algorithm. 2022-09-28 13:37:23 +00:00
Mike Williams e66393c4dd PCB Tools: Move Individually 
Allows moving a selection of components one by one.
 2022-09-26 16:17:41 -04:00
Jeff Young 513fc872bb Support both X and Y mirroring in FPEditor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12409
 2022-09-21 00:16:27 +01:00
Mike Williams 9304607624 TOOL_EVENT: make command string non-optional 
We're getting segfaults in places where this isn't checked. Also, add
some asserts so we can catch bad tool push/pop.

Removes all uses of GetCommandStr() and makes it private.
 2022-09-19 10:23:09 -04:00
Mike Williams de6e368ac6 PCB: Swap Tool 2022-09-12 09:39:43 -04:00
Jeff Young c30a557810 ADDED netclass assignment from PCB canvas. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5975
 2022-09-03 19:29:59 +01:00
Jeff Young b4492e0bd2 More EDA_RECE yeetage. 2022-08-31 17:19:50 +01:00
Seth Hillbrand b736460e71 Move optional access from value() to *operator 
`value()` throws.  Where we check for existence, we don't need to use
the throwing version and should just use the unprotected variant
 2022-08-30 13:59:39 -07:00