Maciej Suminski
72a70d61d8
Fixed the default value generated for Spice_Node_Sequence field
...
Values generated by NETLIST_EXPORTER_PSPICE::GetSpiceFieldDefVal()
and the actual value that was stored in a netlist differed when a
component has multiple units.
Due to that, the Spice model editor dialog incorrectly recognized
"alternate node sequence" value as the default one and cleared it
when the dialog was closed.
2018-05-03 11:29:34 +02:00
Jeff Young
bf135b0690
Change Libedit save icon from Save Library to Save All Libraries.
...
Also changes Save Library and Save Library As to work off the
visible selection if there is one.
Also implements enablement for Save All Libraries.
Fixes: lp:1764081
* https://bugs.launchpad.net/kicad/+bug/1764081
2018-05-02 23:41:00 +01:00
Jeff Young
af739f5b00
Check for duplicates when adding libraries.
...
This is particularly important when bulk adding (by director, etc.)
as otherwise the user might end up having to click OK to many
many error dialogs.
Fixes: lp:1764057
* https://bugs.launchpad.net/kicad/+bug/1764057
2018-05-02 21:49:57 +01:00
jean-pierre charras
7395949ae0
LIB_ID: fix incorrect detection of illegal chars, when values are not ASCII values.
...
Fixes: lp:1764055
https://bugs.launchpad.net/kicad/+bug/1764055
2018-04-30 11:46:24 +02:00
jean-pierre charras
b636aaddf6
Eeschema: fix incorrect UI messages in dialogs due to using UTF8 strings instead of wxStrings (unicode) to build them.
...
(Added a explicit to build a Unicode string in UI messages to avoid mistakes)
2018-04-30 11:46:23 +02:00
Jeff Young
7b734551d3
Make sure pin-caches are up-to-date before testing dangling ends.
...
Fixes: lp:1767745
* https://bugs.launchpad.net/kicad/+bug/1767745
2018-04-29 16:55:24 +01:00
Jeff Young
21ceb786ac
Clear annotations *after* rebuilding symbol links.
...
We need to symbol links to determine whether or not units are
locked (ie: non-interchangeable).
Fixes: lp:1767744
* https://bugs.launchpad.net/kicad/+bug/1767744
2018-04-29 15:09:28 +01:00
Jeff Young
91cfecaa12
Don't allow wxDataViewCtrl updates during model update.
...
Also checks to make sure libraries are activated before adding
them to the component tree.
Fixes: lp:1765286
* https://bugs.launchpad.net/kicad/+bug/1765286
2018-04-28 10:45:32 +01:00
Maciej Suminski
5a051358b7
Removed an obsolete comment
2018-04-28 01:19:42 +02:00
Maciej Suminski
9960416e32
Spice simulator: plot currents in DC sweep simulation
...
Fixes: lp:1767457
* https://bugs.launchpad.net/kicad/+bug/1767457
2018-04-28 01:14:00 +02:00
Maciej Suminski
4d6947b56a
Spice simulator: do not display V(0) in the signals list
2018-04-28 01:14:00 +02:00
Maciej Suminski
539d12b08f
Spice simulator: more elegant approach to generating Spice device names
...
Code fixing Spice device names (prefixing reference with a character
corresponding to the assigned device model type) that was duplicated in
a few places has been moved to a function (NETLIST_EXPORTER_PSPICE::GetSpiceDevice()).
2018-04-28 01:14:00 +02:00
Maciej Suminski
095112a902
Spice simulator: add device prefix only when necessary for DC sweep (missing in bc67d1ad
)
2018-04-27 23:09:58 +02:00
jean-pierre charras
502bed083d
Fix a minimal size for the spice simulator frame.
...
For an obscure reason, the minimal frame size fixed in EDA_BASE_FRAME was not working.
2018-04-27 20:35:23 +02:00
jean-pierre charras
a9dd5b5335
Sim spice fix: the frame size was not the last stored size (like for other frames) but a default fixed value.
...
The frame size (and its subframes) is now the last used.
2018-04-27 18:33:13 +02:00
Jeff Young
942d4e7658
Check footprint history list for validity.
...
Fixes: lp:1767108
* https://bugs.launchpad.net/kicad/+bug/1767108
2018-04-27 15:26:00 +01:00
Maciej Suminski
bc67d1ad8c
Spice simulator: prefix reference with device type only when necesary
...
Fixes: lp:1767271
* https://bugs.launchpad.net/kicad/+bug/1767271
Fixes: lp:1700853
* https://bugs.launchpad.net/kicad/+bug/1700853
2018-04-27 14:18:53 +02:00
Jeff Young
5e5e80d392
Don't allow panel to overwrite values set in Spice Model editor.
...
Fixes: lp:1766920
* https://bugs.launchpad.net/kicad/+bug/1766920
2018-04-26 19:13:19 +01:00
Jeff Young
6ccc8577ad
Hand-code calculation of field names column width.
...
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
2018-04-26 19:13:19 +01:00
Jeff Young
888c434776
Treat Mac as special case rather than GTK.
...
(Windows also needs the padding we use for GTK.)
2018-04-26 15:51:34 +01:00
Jeff Young
dcf02f5f67
Use a single calc-column-width-impl for Fields Editor.
...
Also adds calculation of the initial splitter position based on
the widths of the fields in the list.
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
2018-04-26 11:10:58 +01:00
Jeff Young
ac778bc5b4
Only draw hidden pins if requested or in LibEdit.
...
Fixes: lp:1742485
* https://bugs.launchpad.net/kicad/+bug/1742485
2018-04-25 20:07:22 +01:00
jean-pierre charras
68e69fe95d
eeschema: context menu pops up on 2nd click after ESC key was pressed twice
...
other very minor fixes
Fixes: lp:1766830
https://bugs.launchpad.net/kicad/+bug/1766830
2018-04-25 14:28:41 +02:00
jean-pierre charras
528a67b27c
Fix incorrect sizing of 2 columns in dialog, on GTK (issue perhaps depending on GTK/wxWidget version)
2018-04-25 12:07:43 +02:00
Maciej Suminski
26ee673a6b
Validate symbol alias names read from .dcm files
...
Fixes: lp:1766551
* https://bugs.launchpad.net/kicad/+bug/1766551
2018-04-25 10:15:44 +02:00
Jeff Young
4b3772cf07
Update value field when changing power symbol reference.
...
Fixes: lp:1765932
* https://bugs.launchpad.net/kicad/+bug/1765932
2018-04-25 00:36:08 +01:00
Jeff Young
7e29ff0bc4
Conditional compilation for global fields editor listbox.
2018-04-24 23:45:44 +01:00
Seth Hillbrand
2694a76785
Standardize colons in symbol library dialog
2018-04-23 12:33:21 -07:00
Seth Hillbrand
3e652f2d40
Standardize colons and units in spice model dialog
2018-04-23 12:31:23 -07:00
Seth Hillbrand
2baca1d650
Standardize colons and units in spice sim settings dialog
2018-04-23 12:31:17 -07:00
Seth Hillbrand
445c0e66fb
Align search field
2018-04-23 11:55:28 -07:00
Seth Hillbrand
722886c9c7
Standardize colons in schematic plot dialog
2018-04-23 11:53:18 -07:00
Seth Hillbrand
805c38ffc5
Standardize colons in new component dialog
2018-04-23 11:53:18 -07:00
Seth Hillbrand
60abff1c02
Standardize colons in library text dialog
2018-04-23 11:53:18 -07:00
Seth Hillbrand
424fe8acd4
Standardize colons in libedit pin dialog
2018-04-23 11:53:18 -07:00
Seth Hillbrand
2c1f14fce5
Standardize colons in draw item dialog
2018-04-23 11:53:18 -07:00
Seth Hillbrand
c55cb8c557
Standardize colons in ERC dialog
2018-04-23 11:53:18 -07:00
Seth Hillbrand
f451ffb877
Standardize colons in schematic editor options dialog
2018-04-23 11:53:18 -07:00
Seth Hillbrand
83319f74c3
Standardize colons in line style dialog
2018-04-23 11:53:18 -07:00
Seth Hillbrand
2da575d539
Standardize wording and colons in libentry fields dialog
2018-04-23 11:53:18 -07:00
Seth Hillbrand
617d9288ab
Standardize colons in edit label dialog
2018-04-23 11:53:18 -07:00
Seth Hillbrand
32bb6064d7
Standardize colons in edit schematic component dialog
2018-04-23 11:53:18 -07:00
Seth Hillbrand
07281d78ad
Standardize colons in edit component dialog
2018-04-23 11:53:18 -07:00
Seth Hillbrand
8c2a7138d1
Standardize colons in BOM dialog
2018-04-23 11:53:18 -07:00
Seth Hillbrand
4640a656a2
Standardize colons in annotate dialog
2018-04-23 11:53:18 -07:00
Jeff Young
aa71d41a59
Calculate column widths based on actual text & fontsize.
...
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
2018-04-23 18:24:10 +01:00
Maciej Suminski
50588dcd1e
Fix disabled 'save library' button in the symbol editor
...
With uninitialized COMPONENT_TREE::m_menuActive there were cases when
application logic erroneously decided to fetch the current library name
from the right click menu selection, even though there was no menu
opened, so an empty string was returned. Empty library name is
equivalent to no library loaded, therefore the save button appeared
disabled.
Fixes: lp:1765937
* https://bugs.launchpad.net/kicad/+bug/1765937
2018-04-23 15:29:26 +02:00
Maciej Suminski
cfa9916836
Prevent issuing a print command before the previous one is finished
...
Fixes: lp:1765965
* https://bugs.launchpad.net/kicad/+bug/1765965
2018-04-23 11:25:28 +02:00
Wayne Stambaugh
648803dcf7
Eeschema: fix missing part in part list bug in netlist exporter.
...
Use LIB_ID for LIB_PART_LESS_THAN comparison. This prevents parts with
library name clashes from being dropped from the part list.
2018-04-22 16:33:34 -04:00
Wayne Stambaugh
41c1657eb6
Eeschema: fix bug in sheet path loading logic.
...
When a relative sheet path was not in the project path or a subfolder
within the project path, the schematic path would be empty. Set the
base path to the project path when the schematic path is no within
the project path hierarchy.
2018-04-22 09:47:54 -04:00
jean-pierre charras
4202bb6af6
DIALOG_EDIT_COMPONENTS_LIBID: fix the minimal size (previous code to fix this size was not working)
2018-04-21 17:53:54 +02:00
Wayne Stambaugh
d776eaca83
Fix button sizer padding on symbol field edit dialog.
2018-04-20 19:19:13 -04:00
Jeff Young
4302394990
Consistency between dialog titles and menu items.
...
... and between eeschema and pcbnew.
Also moved the Symbol & Footprint library table tabs to the top
so it's more clear what "by Scope" means.
Fixes: lp:1765359
* https://bugs.launchpad.net/kicad/+bug/1765359
Fixes: lp:1765516
* https://bugs.launchpad.net/kicad/+bug/1765516
2018-04-20 15:33:46 +01:00
Maciej Suminski
554cb54a4f
Eagle SCH import: save project file after the full path is set
...
Fixes: lp:1765297
* https://bugs.launchpad.net/kicad/+bug/1765297
2018-04-20 10:04:41 +02:00
Jeff Young
5506efaee5
Add a SaveAndContinue button to the Fields Editor.
2018-04-19 23:13:19 +01:00
Jeff Young
b9239d8728
Add defensive coding for column widths in Fields Editor.
2018-04-19 21:39:25 +01:00
Jeff Young
9201417c06
Handle new fields in global field editor.
...
Fixes: lp:1765443
* https://bugs.launchpad.net/kicad/+bug/1765443
2018-04-19 20:33:03 +01:00
Maciej Suminski
1a5139b91f
eeschema: renamed 'Symbol Table' to 'Fields Editor'
...
Fixes: lp:1765360
* https://bugs.launchpad.net/kicad/+bug/1765360
2018-04-19 16:26:17 +02:00
Maciej Suminski
e3a06dca70
Fallback to system ngspice library when libngspice is not found in other paths on macOS
2018-04-19 14:48:31 +02:00
Maciej Suminski
2865084ce8
Library Field editor: validate alias name before changing it
...
When LIB_ALIAS is renamed, it validates the new name. In case the name
typed in the field edit dialog is invalid, there was a discrepancy
between the name used further in the code and the actual alias name.
Fixes: lp:1765375
* https://bugs.launchpad.net/kicad/+bug/1765375
2018-04-19 14:47:34 +02:00
Maciej Suminski
4526f40fe1
ngspice: add extra paths to search for libngspice
...
The main purpose of the patch is to load libngspice from macOS bundle.
There are also some additional paths that could make Windows developers
easier.
Fixes: lp:1630675
* https://bugs.launchpad.net/kicad/+bug/1630675
2018-04-19 11:43:29 +02:00
Maciej Suminski
a8ef222517
ngspice: keep the ngspice DLL handle as an automatic variable
2018-04-19 11:44:48 +02:00
Maciej Suminski
d3f23a62ec
Bundle libngspice, code models and init scripts for macOS
2018-04-19 11:44:48 +02:00
Jeff Young
442d1169a8
Adjust min sizes of Global Fields editor for Windows.
...
Also gets rid of a slew of unnecessary sizers in the dialog.
2018-04-18 20:37:20 +01:00
Simon Richter
7e47ef7471
Fix warnings for unreferenced local variables
2018-04-18 15:08:37 -04:00
jean-pierre charras
3179e40b57
Fix compil warning (perhaps 32 bit build specific)
2018-04-18 20:41:18 +02:00
Seth Hillbrand
7b3dc9c28d
Fix tabs->spaces
2018-04-18 08:22:52 -07:00
Maciej Suminski
41ac458e79
Fixed SCH_LEGACY_PLUGIN_CACHE::saveBezier()
2018-04-18 09:36:22 +02:00
Seth Hillbrand
794e8d8a04
Moving IsOk dialogs to correct parents
2018-04-17 17:27:15 -07:00
Seth Hillbrand
626c8a71f7
Reworking sheet duplication messages and annotation
...
The messages on sheet duplication are changed to reflect the action
perceived by the user when accepting/rejecting the change.
Annotation is also reset for duplicating sheets where maintaining
existing annotation would conflict with existing sheets.
2018-04-17 17:12:51 -07:00
Seth Hillbrand
fdd3f52e2d
Move debug msg to relevant section
2018-04-17 17:12:29 -07:00
Jeff Young
db2cda7271
Fix some merge issues.
2018-04-17 20:26:50 +01:00
Seth Hillbrand
2d5da8b04f
Fix assert when removing CurPart
...
Fixes: lp:1762099
* https://bugs.launchpad.net/kicad/+bug/1762099
2018-04-17 12:20:01 -07:00
Seth Hillbrand
853f73e6b7
Prevent duplicate sheetnames when using mouse copy
2018-04-17 12:01:03 -07:00
jean-pierre charras
854cb70052
Fix compil issue with gcc 4.8 on Ubuntu
2018-04-17 19:35:26 +02:00
Jeff Young
3be876c388
Cleanup of trace logs from Simon Richter.
2018-04-17 17:27:18 +01:00
jean-pierre charras
0294e41cbc
fix minor compil warnings (about signed/unsigned comparison)
2018-04-17 16:08:12 +02:00
Jeff Young
000457db7c
Move Fields Editor to wxGrid.
...
Makes in-place editing much easier and fixes some other issues
(see bug reports).
Fixed sorting bugs in References and added better sorting for
Values.
Removed Description column as it wasn't editable and caused more
confusion than value.
Removed auto-column-width after initial render.
Re-implemented undo/redo.
Fixes: lp:1749287
* https://bugs.launchpad.net/kicad/+bug/1749287
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
Fixes: lp:1759756
* https://bugs.launchpad.net/kicad/+bug/1759756
Fixes: lp:1763223
* https://bugs.launchpad.net/kicad/+bug/1763223
Fixes: lp:1761378
* https://bugs.launchpad.net/kicad/+bug/1761378
2018-04-17 11:39:44 +01:00
Jeff Young
12ec56bc15
Prevent reentrancy in footprint loading.
...
Also removes parallel implementation in favour of using the
normal one (with a new wxGauge-backed PROGRESS_REPORTER).
Fixes: lp:1764196
* https://bugs.launchpad.net/kicad/+bug/1764196
2018-04-16 23:19:08 +01:00
jean-pierre charras
2974a2c10a
Eeschema: fix broken generation of the project library cache.
...
Because the cache is broken, the rescue library was never created after missing library or change in lib.
This was due to the fact the symbol name inside the cache is broken, since commit a5844c9
,
because all illegal chars in symbol name are replaced by '_'.
Unfortunately, in library cache, the ':' (illegal in usual libraries) is used to build the cached symbol name.
so in lib cache, symbol names were broken, making this lib useless.
this fix allows the ':' char in symbol name in lib.
Fixes: lp:1764166
https://bugs.launchpad.net/kicad/+bug/1764166
2018-04-16 10:58:28 +02:00
jean-pierre charras
d2cf2fe61c
Eeschema, fix issue when rotating a hierarchical sheet: depending on the sheet size, the rotation center was not always on grid.
...
Therefore, in this case, pin sheets were no longer on grid.
Fixes: lp:1764270
https://bugs.launchpad.net/kicad/+bug/1764270
2018-04-16 10:39:34 +02:00
jean-pierre charras
3e64c9de38
Fix incorrect behavior of ReplaceIllegalFileNameChars( wxString& aName, int aReplaceChar ) for non ASCII8 chars.
...
(this function was using a comparison using chars to test wide chars)
Fixes: lp:1764055
https://bugs.launchpad.net/kicad/+bug/1764055
2018-04-15 10:06:53 +02:00
jean-pierre charras
07dc12fdd3
Fix incorrect UI management of Zoom to Selection, created by fix 2a419156
2018-04-14 17:44:17 +02:00
jean-pierre charras
4a254ee7f3
Eeschema, schematic file save issue: fix missing switch to C locale before saving files
...
The scale factor of bitmap images was incorrectly saved in countries using a comma as floating point separator
Fixes: lp:1763726
https://bugs.launchpad.net/kicad/+bug/1763726
2018-04-14 16:59:17 +02:00
Wayne Stambaugh
a1acec5f13
Revert broken hotkey fix.
...
The hotkey fix committed in 53b1ec81
broke non-us keyboards. Change the
hotkey help hotkey from '?' to Ctrl+F1 to prevent the hotkey list dialog
from being shown when placing a bus wire junction in Eeschema and when
changing the track posture in Pcbnew. This is still broken in the GAL
framework.
2018-04-14 08:24:25 -04:00
Jeff Young
2a419156e0
Don't try to check uncheckable menu items.
...
When updating toolbars make sure the events are coming from the
toolbar in question (and not the menus which share the same ID).
Fixes: lp:1763563
* https://bugs.launchpad.net/kicad/+bug/1763563
2018-04-13 21:42:31 +01:00
Wayne Stambaugh
81843c37a4
Organize trace debugging code for ease of maintenance.
2018-04-13 09:59:01 -04:00
Maciej Suminski
0e151687e3
Fixed a typo
2018-04-13 14:24:57 +02:00
Maciej Suminski
a41b2d6803
Fix names of added aliases
2018-04-13 14:24:57 +02:00
Maciej Suminski
b907fb856d
Fix names of libraries added to symbol/footprint library tables
2018-04-13 14:24:57 +02:00
Maciej Suminski
3f734eb1b5
Improved validation of library and entry names
...
Symbol/footprint library and entry have the same set of forbidden
characters with a single exception, space character. To accommodate for
this difference, LIB_ID validation and fix methods have been extended to
specify the LIB_ID type that is checked (schematic/board).
LIB_ID::HasIllegalChars() and LIB_ID::FixIllegalChars() had two different
sets of characters treated as invalid in LIB_IDs. The set has been
factored out to another function to avoid duplication.
2018-04-13 14:24:57 +02:00
Maciej Suminski
862fb430e7
eeschema: Fixed setting unit condition in the component properties dialog
2018-04-13 14:24:57 +02:00
Maciej Suminski
58c27398cb
Eagle SCH import: improved implicit connections resolution
...
Nets assigned by power pins are weak, meaning they are valid
as long as there is nothing else attached to such pins. This patch
checks whether there are other wires or pins attached to a power pin
before placing a global net label.
Fixes: lp:1755191
* https://bugs.launchpad.net/kicad/+bug/1755191
2018-04-12 18:12:22 +02:00
Jeff Young
5ef715f3d3
Scan all items when looking for the weak reference.
...
... not just those directly in the draw list.
Fixes: lp:1747037
* https://bugs.launchpad.net/kicad/+bug/1747037
2018-04-09 21:19:11 +01:00
Maciej Suminski
4b0d477c76
Symbol Editor: handle delete hotkey in block edit mode
2018-04-09 14:04:06 +02:00
Maciej Suminski
9bd6d5e97c
Fix mirror X/Y hotkeys in the Symbol Editor
...
Fixes: lp:1762136
* https://bugs.launchpad.net/kicad/+bug/1762136
2018-04-09 13:40:42 +02:00
Carsten Schoenert
a11714b1a4
fix misspelled 'an other' -> 'another'
2018-04-08 13:24:37 -04:00
Carsten Schoenert
1f32f7c55b
fix misspelled 'allows to' -> 'allows one to'
2018-04-08 13:24:18 -04:00
Maciej Suminski
cb2c447c23
Spice Simulator: add close buttons to plot tabs
...
Fixes: lp:1761902
* https://bugs.launchpad.net/kicad/+bug/1761902
2018-04-07 22:53:50 +02:00
Jeff Young
baef22df9a
Fix memory leak and push menu change to other apps.
...
Fixes: lp:1761848
* https://bugs.launchpad.net/kicad/+bug/1761848
2018-04-07 14:14:55 +01:00
Jeff Young
0bd5cc4470
Borrow LTSpice's unconnected net nomenclature.
...
Using an unqualified "?" results in all the unconnected pins
being connected to each other.
Fixes: lp:1720619
* https://bugs.launchpad.net/kicad/+bug/1720619
2018-04-07 11:01:56 +01:00
Maciej Suminski
e7ed415930
Eagle SCH import: handle implicit connections
...
Each named power input pin in Eagle creates an implicit connection to a
net with the name of the pin (e.g. GND, VCC). It is also done for the
units (gates in Eagle nomenclature) that have not been instantiated in
the schematics.
To emulate this behaviour in KiCad:
- Placed components are checked for power input pins, so they will have
global net labels attached to create the described implicit connections.
- As the components are placed, the remaining units of the symbol are
checked for power inputs to see if they need to be instantiated together
with global net labels.
Fixes: lp:1755191
* https://bugs.launchpad.net/kicad/+bug/1755191
2018-04-06 16:20:59 +02:00
Maciej Suminski
78c9b34b5d
Eagle SCH import: moved sheet bbox calculation to a function
2018-04-06 16:02:58 +02:00
Maciej Suminski
9ee698bbcd
Eagle SCH import: save the imported library file once the library section is processed
...
It is required to access symbol data in later import stages.
2018-04-06 16:02:18 +02:00
Jeff Young
591a303777
Make ERC options dialog clearer.
...
Fixes: lp:1667600
* https://bugs.launchpad.net/kicad/+bug/1667600
2018-04-06 14:51:09 +01:00
Jeff Young
611d5a0dc4
Standardize "assign footprints" terminology.
...
Fixes: lp:1760867
* https://bugs.launchpad.net/kicad/+bug/1760867
2018-04-06 11:26:59 +01:00
Seth Hillbrand
d1af5210e0
Libedit: Fix a few places where item could be NULL
...
Fixes: lp:1761058
* https://bugs.launchpad.net/kicad/+bug/1761058
2018-04-04 10:20:15 -07:00
Wayne Stambaugh
696ff81dc7
Load correct schematic page layout description file in stand alone mode.
...
Fixes lp:1678849
https://bugs.launchpad.net/kicad/+bug/1678849
2018-04-04 10:18:12 -04:00
Jeff Young
df43f071e1
Keep track of open sockets and dispose of them in d'tor.
...
Fixes: lp:1760936
* https://bugs.launchpad.net/kicad/+bug/1760936
2018-04-04 12:02:40 +01:00
Maciej Suminski
71bf488507
Eagle SCH importer: fixed open-collector pin type, simplified pin direction matching
2018-04-03 14:26:15 +02:00
Maciej Suminski
6d06ed3579
Eagle SCH importer: minor fixes
...
- set correct reference for components
- handle "pwr" direction for pins
- discarded a redundant variable
2018-04-03 14:26:15 +02:00
Maciej Suminski
dd56f16776
Fix symbol editor crash when modifying fields while a field is selected
...
Field Editor dialog calls LIB_EDIT::SetFields() that deletes the old
LIB_FIELD objects and creates new ones. If any of the old LIB_FIELD
objects had been selected before invoking the dialog, then one of the
update UI event handlers will crash trying to access the object.
2018-04-02 17:51:11 +02:00
jean-pierre charras
0171547154
Context menu: use same message for Zoom and Grid in Legacy mode and GAL mode.
...
a minor cosmetic other fix in Eeschema, edit submenu.
2018-04-01 21:09:52 +02:00
jean-pierre charras
e750417fa0
Eeschema: fix many wxASSERT when trying to open menus from the main menubar.
...
This is due to the fact the same ID was used for menuitems in menubar,
and tools in toobars.
Especially, some items were not compatible due to different attributes.
Windows does not accept the same ID for 2 items inside the same frame.
It creates issues (items not shown, Asserts, ...)
2018-04-01 20:58:27 +02:00
Seth Hillbrand
62fe78f08c
Eeschema: Simplify GetItem
...
Avoids calling HitTest on each item when it is not needed
2018-03-30 17:26:34 -07:00
Seth Hillbrand
7c70e969db
Prevent warning when renaming sheet name
...
Renaming a subsheet but keeping the filename should not present a
warning to the user. The was triggered due to comparing a
fully-qualified filename to a relative filename.
Fixes: lp:1744475
* https://bugs.launchpad.net/kicad/+bug/1744475
2018-03-29 13:51:02 -07:00
Maciej Suminski
eb9099238a
Eagle SCH import: Improved net label placement algorithm
...
Eagle support net labels that are naming wires not directly connected to
the labels. In KiCad it is not possible, therefore such detached net
labels need to be moved, so they touch the corresponding wire.
The initial algorithm did not take into account that a moved net label
might be placed on a wire crossing, effectively shorting two nets. This
commit improves the placement algorithm by avoiding the wire crossing
points when placing a label.
Fixes: lp:1748502
* https://bugs.launchpad.net/kicad/+bug/1748502
2018-03-29 12:16:11 +02:00
Maciej Suminski
88915f7940
SCH_EAGLE_PLUGIN::addBusEntries(): prevent operating on deleted objects
2018-03-29 12:11:36 +02:00
Maciej Suminski
99e79c077a
Eagle SCH import: Code formatting
2018-03-29 12:11:35 +02:00
Jeff Young
ba49bd0386
Allow XLS netlist exporters to specify a file extension.
...
Fixes: lp:1591779
* https://bugs.launchpad.net/kicad/+bug/1591779
2018-03-26 00:51:54 +01:00
Jeff Young
f4ce8766e3
Implement shared FOOTPRINT_LIST.
...
While we already cache the loaded footprint files, parsing said files
into the list is also time-intensive. Since the FOOTPRINT_LIST is
already hash-stamped against the current timestamps of the files that
make up the list, sharing a single copy of the list is quite
straight-forward.
2018-03-25 19:21:28 +01:00
Jeff Young
b24b0d5dfe
Dialog-ize CvPcb and implement proper Save.
...
Save now goes to disk (instead of just the in-memory schemaitc),
and the UI attempts to make this clear.
2018-03-25 19:21:27 +01:00
Wayne Stambaugh
8d8c422a19
Add zoom to selection menu entry to all editors.
...
Fixes lp:1753339
https://bugs.launchpad.net/kicad/+bug/1753339
2018-03-25 12:34:19 -04:00
Jon Evans
bfe9eff878
Don't use wxTE_RICH in label editing dialog
...
Fixes: lp:1742296
* https://bugs.launchpad.net/kicad/+bug/1742296
2018-03-24 22:31:34 -04:00
Marco Ciampa
4594fedc2c
Small typo in menubar
2018-03-24 10:36:40 -04:00
Jeff Young
d2d0660647
Open viewer even when FPID is invalid.
...
Just show an empty viewer.
2018-03-23 12:46:17 +00:00
Jeff Young
a0364a1137
Don't make user click twice to toggle checkbox in wxGrid.
2018-03-23 12:46:17 +00:00
Maciej Suminski
434b385a95
Eagle SCH importer: prepend # to references of symbols without assigned footprints
...
With hash character starting the reference value, schematic components
are considered as virtual and therefore netlist updater do not warn about
an unsigned footprint anymore. This approach is useful to handle logos,
frames or other virtual Eagle components.
Fixes: lp:1756281
* https://bugs.launchpad.net/kicad/+bug/1756281
2018-03-22 18:20:02 +01:00
Maciej Suminski
e9537953cd
Eagle SCH importer: reduced code duplication for importing labels
2018-03-22 18:20:02 +01:00
Maciej Suminski
97f8a3361e
Renamed ERC rule: "Test unique global labels" to "Test single instances of global labels"
2018-03-22 18:20:02 +01:00
Maciej Suminski
058f2bffd0
Spice simulator: safety check
2018-03-22 18:20:02 +01:00
Jon Evans
5b653c0c1e
Update MacOS icons
...
Fixes: lp:1750284
* https://bugs.launchpad.net/kicad/+bug/1750284
2018-03-22 11:45:42 -04:00
Maciej Suminski
e1c8822b9e
Component Properties dialog: catch IO_ERRORs when showing footprint viewer
2018-03-22 11:44:13 +01:00
Maciej Suminski
351fc0c343
eeschema: preserve unit number after pasting a component
...
Fixes: lp:1757373
* https://bugs.launchpad.net/kicad/+bug/1757373
2018-03-22 10:55:50 +01:00
Jeff Young
79fe134495
Init Footprint Viewer with current FPID.
...
Fixes: lp:1757421
* https://bugs.launchpad.net/kicad/+bug/1757421
2018-03-21 23:11:55 +00:00
Jeff Young
99e659ff54
Coverity fixes.
2018-03-21 23:11:55 +00:00
Maciej Suminski
bad462a228
Spice simulator: reload ngSpice dll on error
...
ngSpice frequently ends up a simulation with an error:
"Error: ngspice.dll cannot recover and awaits to be detached"
The only way forward is to reload the shared library and
reinitialize ngSpice.
Fixes: lp:1753101
* https://bugs.launchpad.net/kicad/+bug/1753101
2018-03-21 18:01:38 +01:00
Maciej Suminski
61e42ba392
Spice simulator: changed NGSPICE instance type to shared_ptr
...
It was yet another time when I tried to free a singleton pointer.
Let's make clear it is not meant to be freed manually.
2018-03-21 18:01:38 +01:00
Maciej Suminski
50053e7f27
Spice simulator: code formatting
2018-03-21 18:01:38 +01:00
Maciej Suminski
33620ecc85
Revert "libngspice is linked at compile time"
...
This reverts commit 75f8b20493
.
In case of problems, ngspice demands to be detached which is not
possible when it is linked at compile time.
2018-03-21 18:01:38 +01:00
Jon Evans
285bf79370
Fix strings for save/load project menu options; standardize on "Load"
...
Fixes: lp:1753659
* https://bugs.launchpad.net/kicad/+bug/1753659
2018-03-20 22:20:54 -04:00
Jeff Young
1a845bc4ad
Safer way to commit in-progress changes in wxGrid.
...
In some cases the wxGrid would attempt to close the editor in
the middle of the d'tor, resulting in segfaults.
2018-03-19 12:13:28 +00:00
Jeff Young
df924a5e68
Follow standard FBP naming conventions.
2018-03-18 22:17:27 +00:00
Jeff Young
1684fc735a
Defensive coding to attempt to prevent wxWidgets crash.
...
Fixes: lp:1756255
* https://bugs.launchpad.net/kicad/+bug/1756255
2018-03-16 19:02:25 +00:00
Wayne Stambaugh
3f52e87224
Standardize terminology for automatic zoom to "Zoom to Fit".
...
Fixes lp:1753336
https://bugs.launchpad.net/kicad/+bug/1753336
2018-03-16 08:38:36 -04:00
jean-pierre charras
819056df9d
Eeschema: Add footprint field to Cadstar netlist file.
...
Fixes: lp:1755996
https://bugs.launchpad.net/kicad/+bug/1755996
2018-03-16 13:20:00 +01:00
Jon Evans
2cc5c6fd45
Add ERC check in component editor for conflicting multi-unit pins
...
Fixes: lp:1680638
* https://bugs.launchpad.net/kicad/+bug/1680638
2018-03-15 11:11:43 -04:00
Jon Evans
0a81782b5d
Add ERC check that a pin appears in only one net
...
Fixes: lp:1680638
* https://bugs.launchpad.net/kicad/+bug/1680638
2018-03-15 11:11:43 -04:00
jean-pierre charras
e14a7c928c
Fix incorrect pin num string in cadstar and orcadpcb2 format
2018-03-15 09:15:49 +01:00
Jeff Young
3d12a6889b
Make sure ERC and DRC item lists respect color themes.
...
Fixes: lp:1492953
* https://bugs.launchpad.net/kicad/+bug/1492953
2018-03-14 14:15:16 +00:00