2577ebb94d
Increase dynamic ratsnest opacity for better visibility.
2022-10-07 21:50:12 +00:00
b8dfbe02ad
Fix some issues in STEP exporter
2022-10-07 18:53:31 +02:00
863184e3dc
Ensure node count is signed
...
Fixes a broken commit from a0865082fb
2022-10-07 08:14:53 -07:00
d44a52ceee
Make arc endpoint theta consistent with polar coordinate system.
2022-10-07 08:35:14 +03:00
19d270fe74
Text size sanity checking for TEXT_ITEMS_GRID.
...
Oh dear, there was a bunch going on here. Firstly the move from int
to long long int for ValueFromString() means that we were no longer
catching overflows (as we were C-style casting it back to int in many
places). But even when the overflow is caught, it would run in to
wxWidgets' empty string bug while trying to log it.
Fixes https://gitlab.com/kicad/code/kicad/issues/12577
2022-10-06 13:19:08 +01:00
b52106aa37
Formatting and commenting.
2022-10-06 13:19:08 +01:00
0a620816a8
Eeschema: edit arc: keep arc angle <= 180 degrees when moving a arc end.
2022-10-06 09:22:59 +02:00
40a279ae32
Hotglue the unit tests to work for now
...
The mocks never expected InitPgm to work and I accidentally fixed it for the kicad-cli
2022-10-05 17:12:32 -04:00
92f70a9fa2
Eeschema: ensure arcs are < 180 deg when creating them.
2022-10-05 11:33:12 +02:00
3fe004fd1b
New kicad-cli will now be the cli interface
2022-10-04 22:24:13 -04:00
a0865082fb
Fix compile warnings
2022-10-04 17:06:45 -07:00
0c7b6c3cbc
fix minor compil warnings
2022-10-04 19:51:51 +02:00
2be9586c38
Improve default new-library destination logic to be more project aware.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12570
2022-10-04 17:56:00 +01:00
4611817f25
Eeschema: fix a crash when invoking eeschema.exe with 2 filenames to open
...
Fix also a minor compil warning
2022-10-04 16:56:13 +02:00
7d16fba8f9
Fix launching of files
2022-10-04 07:32:22 -04:00
fb8a4c10f7
Shove kicad2step into pcbnew itself with a new cli
2022-10-04 01:53:37 +00:00
b716afd6f1
Clarify various uses of "Center"
...
Distinguish between the english verb "Center" and the noun "Center",
which may be translated differently
Fixes https://gitlab.com/kicad/code/kicad/issues/11109
2022-10-03 12:48:57 -07:00
46016cfc61
Remove duplicated text in Report Bug
...
Now that GitLab insists on inserting this text, we shouldn't duplicate
it in the Report Bug action
Fixes https://gitlab.com/kicad/code/kicad/issues/10939
2022-10-03 11:12:50 -07:00
01e6491046
Fix side-effect of multi-select in lib trees.
2022-10-03 19:11:31 +01:00
230762053d
Translate mod flags between wx and Kicad.
...
Also we have to use wxEVT_CHAR_HOOK instead of wxEVT_CHAR or up/down
end up getting handed to COMMON_TOOLS.
Fixes https://gitlab.com/kicad/code/kicad/issues/11034
2022-10-03 18:42:50 +01:00
2422b9a7c8
Simplification, formatting, and spelling.
2022-10-03 18:42:50 +01:00
e335c1c612
Fix for LIB_TREE hotkeys over canvas and possible fix for over LIB_TREE itself.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11034
2022-10-02 22:22:21 +01:00
1fc5ecae6e
Minor dialog layout improvements.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12497
2022-10-02 11:45:30 +01:00
7059ef9b89
Store netclass visibility separately from nets
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10290
2022-10-01 19:54:13 -04:00
1b38acd9c6
Add "Letter-like character" Omega for Unicode x2126
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12531
2022-10-01 16:39:00 -07:00
fdf9fcc24d
Fix missing token initializer
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12555
2022-10-01 12:15:49 -07:00
19378675f1
Ensure that token size is large enough
...
Input tokens can be arbitrary, so output needs to keep pace
Fixes https://gitlab.com/kicad/code/kicad/issues/12555
2022-10-01 11:30:30 -07:00
efdb67aa64
Minor fixes.
2022-10-01 18:42:02 +02:00
93239516d9
Remove ID from property fields
...
ID was not maintained or used other than to ensure unique fields.
Instead of saving, we assign the known IDs to specific field names and
sequentially create new IDs on load
Fixes https://gitlab.com/kicad/code/kicad/issues/12390
2022-09-30 17:19:53 -07:00
c0a666507c
Work around more instances of the wxWidgets color string locale bug.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12552
2022-09-30 20:56:25 +01:00
01572c0f7d
ADDED: Focus follows mouse between SCH and PCB editors (option).
2022-09-30 18:32:06 +00:00
f2de3e9f67
Minor cleanup.
2022-09-30 13:02:08 +01:00
519084546e
Ensure dtor throws into catch block
...
Explicitly destruct the GAL context to get StopDrawing throws in the
proper try block
Fixes https://gitlab.com/kicad/code/kicad/issues/12117
2022-09-29 15:26:39 -07:00
8ae48bb093
Ensure the socket server is killed during destruction of the kiway player
2022-09-28 21:37:19 -04:00
f3be769095
Fix comment placement
2022-09-28 21:19:19 -04:00
0b1b37a75f
Try and avoid a crash by suppressing the socket events first before deleting
...
Might fix a sentry issue, unknown
2022-09-28 21:18:09 -04:00
3d3b7d839c
Prevent out of scope lambda use
...
Keeping a function reference is only in scope when the call is
immediately executed, not when it enters its own event loop.
This commit also excises one more onUpdateUI call as it is not needed
Fixes https://gitlab.com/kicad/code/kicad/issues/12395
2022-09-28 17:18:04 -07:00
18d7a1b427
Update contributions
2022-09-28 13:49:30 -07:00
4095172259
ADDED: Pack and Move Footprints, improved footprint spread algorithm.
2022-09-28 13:37:23 +00:00
7d20418d6f
Fix compil issues and warnings, especially in ibis code.
2022-09-28 09:55:00 +02:00
46471247ff
Some header cleanup
2022-09-27 23:25:20 -04:00
1a43187fb7
Display the sentry uid in preferences
2022-09-27 19:31:32 -04:00
21c1c97bf3
Unbind search pane listview events on destruction to avoid event race
2022-09-27 19:16:29 -04:00
dc07ab9df1
Replace PROF_COUNTER with PROF_TIMER in some conditional places.
2022-09-27 14:07:47 +00:00
9e580b3116
Other -> Unspecified and a couple of other terminology improvements.
2022-09-27 12:15:18 +01:00
7584ccc758
Fix duplicate variable member m_userUnits, creating issues depending on
...
the way it was acceded (by name or by accessor).
2022-09-26 19:47:28 +02:00
d0b4fb7b32
Don't fail when reserving 0 vertices.
2022-09-26 12:18:45 +03:00
c50b4fb04f
Add relative to footprint 3d model path resolution
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2073
2022-09-25 22:56:16 -04:00
375b530dad
ADDED: Column selection and reordering in symbol chooser
2022-09-25 22:49:49 -04:00
8e96751af2
Strip out and migrate 3d search paths in favor of env vars
...
This mainly stops reading/writing 3dresolver.cfg
We still keep some sillyness for kicad2step for now
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9164
2022-09-25 21:29:52 -04:00
76a7a2b4bc
Fix asserting when drawing empty line of text.
2022-09-25 22:20:51 +01:00
2490ad1458
Fix search panel not remembering visibility
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12494
2022-09-25 11:56:41 -04:00
40ff7cb9bd
Fix some UI element spacing in settings panels
2022-09-25 15:41:39 +01:00
3a297093e6
Fix lambda capture in ACTION_TOOLBAR
2022-09-25 15:41:39 +01:00
28165c6a31
SEARCH_PANE_TAB: fix a typo and add missing event handler.
2022-09-25 16:40:08 +02:00
8f52821cd4
Add missing clear of children memory in outline node
2022-09-25 08:47:28 -04:00
7c44dbd9d6
Fix gcc compil warnings.
2022-09-25 11:01:25 +02:00
0595efd0a7
Make the page outline nodes goto page...
2022-09-24 23:37:55 -04:00
209e1b2086
Add naming of the outline page entries
2022-09-24 22:54:38 -04:00
a381a0acb2
Generalize bookmarks to support additional groups and names
2022-09-24 22:35:20 -04:00
6f8205235f
ADDED: Add outline support to schematic PDF and PCB plot
2022-09-24 21:45:48 -04:00
1683e552f7
Add/fix some variable initializations
2022-09-25 00:48:38 +01:00
659a6e5b04
Replace macHack as its requirement sadly never went away.
2022-09-24 23:50:45 +01:00
22cd2a3428
3D viewer: add option to show/hide fp not in position file.
...
Previously they were not shown, and this is really bad, because
"not in pos file" does not mean never mounted, and not even not mounted.
2022-09-24 13:58:31 +02:00
dcfcfd5f29
Don't run context menu actions when clicking outside the menu
2022-09-23 23:44:08 -04:00
f37086e840
Remove size handler that messes up column sizes
...
Could not reproduce an issue on wxGTK. If this causes problems
on other OS's, let's find a more appropriate fix
2022-09-23 22:08:33 -04:00
6310f84a57
Fix shadowed definition of EAGLE constant
2022-09-24 01:37:57 +01:00
201b45b41a
Remove call that crashes MySQL connector sometimes
...
It no longer is necessary anyway
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12471
2022-09-23 19:28:04 -04:00
bd28bd7a00
fix a few compil warnings
2022-09-23 18:30:42 +02:00
6ebb3baa3b
PCM: autoload libs from installed packages to global lib tables
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9713
2022-09-23 16:16:13 +00:00
bb1eb94aa0
Fix typo.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12467
2022-09-22 10:53:42 +01:00
c44e54756a
search panel: fix a crash and a refresh issue after selecting a second item
...
at least on W10/msys2
2022-09-21 19:36:35 +02:00
8eb68ee472
Add pin/unpin context menu to Symbol Chooser and Footprint Chooser.
...
Also moves some more code down into common so it can be shared.
Fixes https://gitlab.com/kicad/code/kicad/issues/12384
2022-09-21 14:45:12 +01:00
25f1f7b0df
Fix a compil issue on GCC
2022-09-21 09:04:31 +02:00
ec25463fed
Allow multi-selecting from the search pane
...
Fix https://gitlab.com/kicad/code/kicad/-/issues/12476
2022-09-20 23:58:49 -04:00
30dbcbbcf5
Only search the current tab on events
2022-09-20 23:38:06 -04:00
f851526c67
Plotters: make virtual void PLOTTER::Arc() using arc angles protected.
...
Using arc angles to plot an arc is really error prone due to different
options between plotters, and angles defined in Kicad, using this version of
arc plotting from Kicad is no longer allowed in Kicad code.
2022-09-20 18:55:20 +02:00
7f34586c7e
Allow text variable resolution through properties in drawing sheet text.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12473
2022-09-20 15:28:05 +01:00
bbaf5a21c2
Eeschema: fix a plot issue with arcs.
...
Arcs are really error prone, due to different Y axis orientation, and geometry transforms.
Probably we should remove plot and print functions using arc angles as parameters
that are a can of worms.
Fixes #12465
https://gitlab.com/kicad/code/kicad/issues/12465
2022-09-20 16:04:17 +02:00
7e8b6083f4
Try to find a better brace highlight color strategy.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12467
2022-09-20 13:31:38 +01:00
30a4d3d2de
Coverity fixes.
2022-09-20 00:19:15 +01:00
7fe3999457
Fix a bit of fall-out from making command strings non-optional.
2022-09-20 00:08:12 +01:00
64a6fc0fd4
Push UNITS_PROVIDER down into a low-level mixin.
...
This allows us to also construct cheap UNIT_PROVIDERs for specific
tasks when necessary.
2022-09-19 17:10:59 +01:00
9304607624
TOOL_EVENT: make command string non-optional
...
We're getting segfaults in places where this isn't checked. Also, add
some asserts so we can catch bad tool push/pop.
Removes all uses of GetCommandStr() and makes it private.
2022-09-19 10:23:09 -04:00
b7ba24b2d9
TOOL_EVENT: fix lifetime issues with const aEvent& refs
...
Without this the event is on the stack, and as soon as the tool calls
Wait(), the event will be deallocated. The aEvent reference will then
point to invalid memory.
2022-09-19 07:59:11 -04:00
45d6b4a9fc
Readability improvements.
2022-09-19 11:18:20 +01:00
bdf4cf51b8
Add a missing statement in segments reservation.
...
Also adds an assert in FinishItem.
Fixes https://gitlab.com/kicad/code/kicad/issues/12448
2022-09-19 02:36:21 +00:00
63295cfb9e
Remove unused vars
2022-09-18 08:49:07 -04:00
f26a6f76e4
IUToMils should return int
...
It was already truncating even in old code...lets just clean this up
2022-09-17 09:27:27 -04:00
97963a2bba
Better after base_units.cpp changes in python stuff.
...
Move an include to kicad.i
2022-09-17 11:21:48 +02:00
ece23d434b
Split up Double2Str to a format function to make its use case clear
2022-09-17 00:10:22 -04:00
59a9ddac20
Convert the primary file io formatter for doubles
2022-09-16 23:20:15 -04:00
3d5913c825
Remove convert_to_biu.h, merge contents to base_units.h
2022-09-16 21:09:28 -04:00
0f2411587e
Remove Millimeter2iu
2022-09-16 21:09:27 -04:00
7a5829f8d6
Move IU2Mils
2022-09-16 21:09:27 -04:00
61e11d6896
Strip out Mils2Iu
2022-09-16 21:09:27 -04:00
ee48c8d232
Remove some more
2022-09-16 21:09:26 -04:00
a8613ee80f
Combine Iu2Millimeter & remove PcbMm2iu
2022-09-16 21:09:26 -04:00
85e8d1eb38
Try re-organizing the events for the search ctrl to allow MSW icon to be shown.
...
See further comments in bug report.
Fixes https://gitlab.com/kicad/code/kicad/issues/11743
2022-09-16 17:04:46 +01:00
4de264ddaa
Don't steal up/down arrows from textboxes and the like.
2022-09-16 16:52:26 +01:00
4f453d6b92
Remove turning the cursor on in FocusOnLocation.
...
We don't (at present) have any good way to turn it back off.
Fixes https://gitlab.com/kicad/code/kicad/issues/12440
2022-09-16 16:44:18 +01:00
cf1565a16a
Bug fixes for layer expression processing.
...
1) Push a VAR onto the stack, not a resolved value
2) Don't collapse a PCB_LAYER_VALUE to a VALUE during processing
3) Make sure we run overloaded operators from the correct side
Fixes https://gitlab.com/kicad/code/kicad/issues/12437
2022-09-16 14:14:43 +01:00
b00178adb3
Nuke base_units from orbit
2022-09-16 04:38:10 +00:00
9a4a68fb5e
Hide search button on MSW.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11743
2022-09-15 23:23:23 +01:00
a21d24a4c8
Experiment with loading recent searches into the search menu.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11743
2022-09-15 14:44:02 +01:00
da9be1a812
ADDED: Multi-selection cut/copy/paste in symbol editor library tree
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11505
2022-09-14 22:20:38 -04:00
c48286b879
Fix missing variable initialization.
2022-09-15 00:45:29 +01:00
12ee8b5d7c
Improve DRC cross-probing a bit.
2022-09-15 00:45:29 +01:00
0180bcf90a
ADDED: Implement Drag and Drop
...
dropping files to Kicad manager :
*.kicad_pro, *.pro -> open project;
gerber and job files -> open in Gerbview editor;
Eagle and Cadstar files -> open project.
dropping file to schematic editor -> append schematic;
dropping library file to Symbol editor -> add library;
dropping board file to PCB editor -> append board;
dropping library or footprint file to Footprint editor -> add library or import footprint;
dropping ZIP file or gerber files to Gerbview editor -> open files;
dropping sheet file to Drawing Sheet editor -> open sheet.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11638
2022-09-14 22:28:09 +00:00
b97f9ea329
Add support for symbol unit display names in eeschema and symbol editor
2022-09-14 22:11:37 +00:00
bd8b737c44
GAL: Do better job at reserving vertices.
2022-09-14 16:07:47 +00:00
75ae0d8e5e
Revert "Use {fmt} for double -> string conversions"
...
This reverts commit 03fff6e58d
2022-09-14 10:56:50 +00:00
281b9d405a
ADDED ability to specify where pad number (& net name) go on custom shaped pads.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6627
2022-09-14 11:37:20 +01:00
03fff6e58d
Use {fmt} for double -> string conversions
...
Faster at printing floats than sprintf due to the modern algos
2022-09-13 23:17:15 -04:00
f304e2d4f6
ADDED: Search/inspect pane
2022-09-14 02:59:57 +00:00
7bd8cfd7f9
Added common option to hide scrollbars
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9093
2022-09-13 22:15:27 +03:00
bde2d388f1
Fix a very serious memory leak in OUTLINE_FONT::getTextAsGlyphs().
2022-09-13 17:55:12 +02:00
4f3db82c68
Add debugging support for KiCad2Step command line generation.
2022-09-12 14:30:07 -04:00
9cda5e200c
Hotkeys: Swap on Shift S and revert old actions back to S
2022-09-12 14:18:54 -04:00
37d2addf0e
Icons: add swap
2022-09-12 11:11:49 -04:00
f70e1d0f22
SCH/PCB: Set Swap hotkey to 'S'
...
* Move Add Sheet to Shift+S in Schematic Editor
* Move Set Grid Origin to Shift+S in PCB Editor
2022-09-12 11:11:49 -04:00
fcfb9cc5ad
Selection: track selection order
2022-09-12 09:39:43 -04:00
d95847ae79
Add missing format specifier to UnescapeString.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9542
2022-09-12 01:48:23 +01:00
b4e71de89f
LIB_IDs can have forward slashes
2022-09-11 10:11:25 -04:00
1b104f20b6
Don't give Scintilla a colour with alpha; it doesn't know what to do.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10829
2022-09-11 13:08:31 +01:00
da7eaeffd2
Move IsOK() to wxRichMessageDialog so it handles <ESC> properly.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12360
2022-09-11 12:21:16 +01:00
a9877ab117
Include markdown files in project view.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12178
2022-09-10 21:11:24 +01:00
52ea9d0bc5
Don't allow preview canvases to steal focus when keyboard navigating preferences tree.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10407
2022-09-10 20:15:49 +01:00
d5430906d4
Make sure cursor settings get saved.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11663
2022-09-10 18:43:32 +01:00
b95d9d660d
Move gerbview colors to preferences dialog.
2022-09-10 16:11:24 +01:00
f87bf3c46d
Special case up-key so it can get past headers in paged dialogs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10078
2022-09-10 09:31:27 +01:00
09ef7c8f1e
Add RPT_SEVERITY_DEBUG for developer-type messages
...
Move a bunch of importer messages out of the user-visible space as they
are not information that the average user can act on.
2022-09-09 17:21:47 -07:00
59f546ced0
Allow recursion up the sheet hierarchy for text variable resolution.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11953
2022-09-10 00:04:20 +01:00
df35576cf9
fix my previous commit ( c0661468) broken.
2022-09-09 19:00:47 +02:00
c06614689e
OPENGL_GAL: disable bitmap image caching due to serious issues (memory leak)
...
It was re-enabled by commit cbc3bfbf
2022-09-09 18:37:30 +02:00
f179754118
Implement add-new-on-return for some of our grids.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12335
2022-09-09 13:41:13 +01:00
087550ebd3
Get 3d plugins working for running from build dir
2022-09-08 21:49:10 -04:00
c13b938a4b
Free memory when unused, forgotten in my commit d4feb59e
2022-09-08 13:07:36 +02:00
d4feb59ed9
OPENGL_GAL, draw bitmap: Rebuild the bitmap cache if the bitmap itself was rotated.
...
Fixes #12378
https://gitlab.com/kicad/code/kicad/issues/12378
Fix also a Coverity warning.
2022-09-08 12:00:43 +02:00
9523586bf1
Remove atrophied PCB NO_CONNECTS layer and its colour.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12316
2022-09-08 00:28:31 +01:00
6f5281258e
Separate text-thickness clamping into strict and lenient modes.
...
We used to use the bold setting, but since PCBNew allows you to
directly define the width you end up with settings in between normal
and bold that get clamped to the normal max.
Fixes https://gitlab.com/kicad/code/kicad/issues/12367
2022-09-08 00:28:30 +01:00
89310bc403
"Cleaner" pan fix and add internal setter on state
2022-09-07 07:19:39 -04:00
59e9225619
Remove accidental debug code
2022-09-06 23:09:07 -04:00
971a8489b3
Hackfix the autopan on Windows
...
Autopanning is kinda doesn't jive with how events work on Windows
This is a hackfix for testing
Kinda fix https://gitlab.com/kicad/code/kicad/-/issues/11425
2022-09-06 23:07:59 -04:00
1520a1d372
Use cached untranslated header for looking up width
2022-09-06 09:18:34 -04:00
b80824951e
Clean up some of the PDF hypertext stuff, and add opening HTTP[S] urls.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12153
2022-09-06 13:59:52 +01:00
8afc1db7a6
Property popups for symbols, labels, sheets, and footprints in PDF.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5521
2022-09-06 13:59:52 +01:00
90996d0698
Don't toggle checkboxes selected rows if only one row is selected
2022-09-05 16:50:54 -04:00
e294fe2074
ADDED: Dynamic field columns in symbol chooser
...
CHANGED: Symbol chooser search now considers custom symbol fields
Visible columns can be controlled in database libraries.
In standard KiCad libraries, we show columns for all custom fields for now.
Customizable column visibility will be added in the future.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11946
2022-09-05 16:38:14 -04:00
6013c796dd
Fix TRANSFORM::MapAngles (Third time lucky?)
...
Use epsilon value to decide whether we should swap the angles
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12346
2022-09-04 23:21:29 +02:00
895a8a8dbc
Work around focus issues for status popups.
...
Autoscroll wasn't working on Mac because the status popup's panel
has the focus. This *may* also fix a problem on MSW of the auto-scroll
not being cancel-able.
Fixes https://gitlab.com/kicad/code/kicad/issues/11425
2022-09-04 21:08:01 +01:00
26ba8e1938
Don't use recursive mutex for nicknames anymore
2022-09-04 13:01:32 -04:00
a5246a6df7
DbLib: Support showing field names
2022-09-04 13:01:32 -04:00
71724bea0c
Remove curly brace from string encoding.
...
It causes issues with formatting constructs and text variable refs,
and it's not a reserved character even in filenames.
Fixes https://gitlab.com/kicad/code/kicad/issues/12351
2022-09-04 10:34:32 +01:00
efae2bbb4c
Better feedback for netclass assignment patterns.
2022-09-03 21:33:56 +01:00
c30a557810
ADDED netclass assignment from PCB canvas.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5975
2022-09-03 19:29:59 +01:00
977b6cd8f3
PCM: add ability to pin packages
...
Pinned packages don't affect available update notification and will not
be updated with "Update All" button. Manual update is still possible but
will trigger a confirmation dialog.
2022-09-03 17:07:55 +00:00
112f089485
Fix TRANSFORM::MapAngles for other transformations than y=-y
...
Tested on transformation that results in: y=-y & x=-x
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12345
2022-09-03 00:28:15 +02:00
b0aba0fdf3
Cache works better with unique keys
2022-09-01 23:11:35 -04:00
60f6bb8c77
DbLib: Fixes for MySQL ODBC driver
...
SQLSetConnectAttr crashes for this driver, and SQLSetStmtAttr is the ODBC3 way anyway.
2022-09-01 00:24:56 -04:00
9188838e50
RIP EDA_RECT.
2022-08-31 23:57:24 +01:00
b4492e0bd2
More EDA_RECE yeetage.
2022-08-31 17:19:50 +01:00
f17a865593
Move EDA_ITEM hitTest to BOX2I.
2022-08-31 17:18:45 +01:00
3857e68452
Python, swig: add definition of BOX2I
2022-08-31 17:18:46 +02:00
2dc6300501
Move EDA_ITEM bounding boxes to BOX2I.
2022-08-31 10:16:55 +01:00
ae879c8f02
DbLib: Add single-row query cache
...
Since single-row queries are performed rapid-fire during certain actions like
stepping through the symbol browser, there is high value in caching them for
a small amount of time. The default cache parameters will keep results for
10 seconds, which errs on the side of getting fresh data from the database
on most user interactions.
2022-08-30 22:18:36 -04:00
5679b9dbdc
Remove a few EDA_RECT instances.
2022-08-31 01:22:49 +01:00
0c8787cbb9
Some more wxPoint/EDA_RECT yeeting.
2022-08-31 00:44:33 +01:00
b736460e71
Move optional access from value() to *operator
...
`value()` throws. Where we check for existence, we don't need to use
the throwing version and should just use the unprotected variant
2022-08-30 13:59:39 -07:00
91fbb5c957
Don't prevent immediate actions while router active
...
Immediate actions that can take place are useful. We should only be
preventing immediate actions while actively routing or dragging
Fixes https://gitlab.com/kicad/code/kicad/issues/12311
2022-08-30 10:31:29 -07:00
63386ba64d
Pointer safety for ERC/DRC dialogs.
...
Also makes the "Edit ingored violations" easier to find.
Fixes https://gitlab.com/kicad/code/kicad/issues/12308
2022-08-30 12:07:19 +01:00
8dddc07f26
Remove #ifndef that's redundant
...
This seems to date back to once upon a time when gerbview didn't even use base_units
2022-08-29 23:24:48 -04:00
a8a75a91e1
Try and fix file encoding
2022-08-29 20:57:14 -04:00
03aa63bd50
Move 5 helpers to EDA_UNIT_UTILS since they aren't iu specific
2022-08-29 20:11:03 -04:00
99f8bb3219
panel_gal_display_options can be common
2022-08-29 18:18:38 -04:00
f0956e48f2
Make EDA_TEXT common
...
Since EDA_TEXT is a base class, we can just force the child classes to pass the correct iu scaled size
ALLOW_BOLD_THICKNESS removed because it's a pre-custom font holdover
2022-08-29 07:31:03 -04:00
1a7157fe37
Remove unused include
2022-08-29 07:31:03 -04:00
b1eff8abd4
Fix leftover base_screen.cpp
2022-08-28 19:41:52 -04:00
5ebd3b2d80
Make EDA_SHAPE common
...
Looks like it's dependency on unit macros was dropped some time ago
2022-08-28 19:35:41 -04:00
ba3e31bd09
GRID_TRICKS: Allow toggling checkboxes in a set of selected rows
2022-08-28 18:30:08 -04:00
48f77973da
Another try at getting the Link combobox working on MSW.
2022-08-28 23:25:01 +01:00
abc7335fd7
Cosmetic enhancement: add two missing icons
2022-08-28 16:01:26 +02:00
474d732d94
Fix for wx3.2
2022-08-28 08:53:25 -04:00
7d73376bbd
Fix assertion when no netclass assignments exist
2022-08-28 08:28:13 -04:00
95fd7cb80a
Move wxComboBox to wxBitmapComboBox in hopes it will work better.
...
(Not sure if it solves the MSW issues yet, but at least it highlights
the items in the dropdown on rollover on OSX.)
Also added some text to the dropdown menu for intersheet references in
the PDF.
2022-08-28 12:05:27 +01:00
c0d2052e4b
PDF hypertext menus for intersheet references.
2022-08-27 23:58:13 +01:00
560dc7d2b6
Underline for hypertext rollovers.
2022-08-27 23:58:13 +01:00
49354e52a8
Add support for sub-libraries concept
...
Sub-libraries allow a single-level hierarchy inside a symbol library.
This is useful for database libraries and for supporting other EDA library types where a
single file can contain multiple logical groupings of symbols.
2022-08-27 18:47:39 -04:00
a76d1a791d
Hyperlinks: Don't forget about file:// protocol
2022-08-27 23:16:28 +01:00
f73a3f852e
Hyperlinks: Fix URL validation for https
2022-08-27 22:45:19 +01:00
122a6d7f46
Move hypertext linking to user-page-numbers.
...
Also moves most navigation code to SCH_NAVIGATION_TOOL.
Also changes page number href to anchor syntax ('#foo').
Also adds hypertext processing to SCH_TEXTBOXes.
Also adds combobox with schematic pages to text properties dialog.
2022-08-27 19:17:43 +01:00
9b007ca4bf
ADDED: Go to page hyperlinks in schematic editor (virtual page numbers)
...
The problem is that "real" page numbers can be duplicated, so we work around it
by using virtual page numbers instead which are guaranteed unique.
Example "goto:3" will go to page 3. If customised page numbers are used such as
a, b, c, then to go to page b, we should specify goto:2 (i.e. the virtual page
number).
2022-08-27 19:17:42 +01:00
5d90f3f54f
WIP - fix up parsing + generalise to the pcb
2022-08-27 19:17:42 +01:00
3cd867e656
WIP - add hyperlinks to pages within pdf
2022-08-27 19:17:42 +01:00
f788945cf4
Add pdf output to hyperlinks
2022-08-27 19:17:42 +01:00
366b0ab08b
Fix variable naming in pdf plotter
2022-08-27 19:17:42 +01:00
20ed9b475b
Configurable hyperlink hovering color
2022-08-27 19:17:42 +01:00
840bcffefb
ADDED: Hyperlinks on text items in Schematic Editor
2022-08-27 19:17:42 +01:00
9acc5ac7ea
base_screen became free of base_unitry awhile ago
2022-08-27 14:02:51 -04:00
bf964d8678
Commonize page_info by simply making the Iu scale a parameter on call.
2022-08-27 13:36:00 -04:00
7d5bdd23de
more cleanup TRANSFORM::MapAngles
2022-08-27 12:51:33 +01:00
5cae80d737
Cleanup asserts in TRANSFORM::MapAngles
2022-08-27 12:51:33 +01:00
029cc65b34
EDA_SHAPE: Remove m_upsideDownCoords hack (Fixes hitTest routine)
2022-08-27 12:51:32 +01:00
2812794742
Move TRANSFORM to common
2022-08-27 12:51:32 +01:00
4b5c5aa6b6
Preferences dialog: avoid crash on opening if a dll is missing.
...
Fixes #12273
https://gitlab.com/kicad/code/kicad/issues/12273
2022-08-27 11:36:37 +02:00
300d92438c
Allow hiding symbol library tables from symbol chooser
...
Hidden but loaded libraries are useful when using database libraries
2022-08-26 20:18:40 -04:00
d22fc24d9e
Attempt to fix MSVC build
2022-08-26 12:51:14 -04:00
5c7f1083c7
database_connection.cpp: Fix compil issues on msys2. these issues are
...
due to "old" (or not existing) types used in sql.h
2022-08-26 18:15:57 +02:00
3da2f79d0e
Fix initialisation order issue in PANEL_SETUP_NETCLASSES.
2022-08-26 17:05:25 +01:00
146495672e
Utilize our combine_hash routine for multiple hash
...
We should be using the one routine every time we want to build a hash
from indepedent values rather than rebuilding it differently in multiple
places
2022-08-26 08:45:13 -07:00
06786c34d7
Blacklist hashes for 2d integer elements
...
The hash table for integer hashes is extremely limited and places most
elements in the same buckets. This leads to a linear search time for
structures built on this.
This blocks hashes, directing the coder to utilize std::set or std::map
structures instead of hash tables for implementing integer-based
lookups.
2022-08-26 08:43:37 -07:00
ed02d7c974
Spread bitmap store hash table elements
...
XOR of two sequential ints makes for an inefficient hash table. The
hash_combine function is intended for this purpose
2022-08-26 08:43:37 -07:00
ae6a2a6443
ADDED: Database libraries MVP
...
Allows placing parts from an external database that reference symbols from another loaded library.
Includes:
- nanodbc wrapper
- database schematic library plugin
- basic tests
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7436
2022-08-26 10:51:13 -04:00
31c24f4421
Add nanodbc
2022-08-26 09:38:11 -04:00
f1261e71d4
Replace boost::optional with std::optional
2022-08-25 15:50:47 -07:00
c491cd01c5
Silence property warnings
2022-08-25 13:39:38 -07:00
8a02f2f809
DIALOG_PASTE_SPECIAL: Set focus on OK button
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12285
2022-08-25 20:25:23 +01:00
a306246558
Fix a few (minor) compil and Coverity warnings.
2022-08-25 20:21:00 +02:00
27c31061b1
Set locale in SaveToFile routine before calling json stuff.
...
It avoid wxWidgets alerts about locale when running some python scripts
2022-08-24 07:36:57 +02:00
e30f059b43
Silence uninitialized warning
2022-08-23 23:51:42 -04:00
fc99b3ba95
Don't link gdiplus everywhere anymore
...
Tested on msys2 which is the only place it would have been buggy
CMake seems to share the gdiplus linkage with the other dependencies automatically now
2022-08-23 23:51:35 -04:00
e0f28fc4e1
Replace wxFindReplaceData with our own container
...
By dropping the flags, we can be strict with options.
Also it makes future usage of search functionality a little more "UI" framework independent
2022-08-23 22:16:51 -04:00
7a8b188569
Fix Sentry crash for font loads
...
We cache newstroke loading, but if we have threaded loads, we might ask
multiple threads to load the newstroke font at the same time. This
causes conflicts in the vector allocations->crashes
2022-08-23 09:51:20 -07:00
284917b999
Fix assertion when rendering layer editor
2022-08-22 21:32:33 -04:00
7208ceb5f1
Handle mils in property panel
2022-08-22 21:32:33 -04:00
bfdb39f418
Properties Panel: Plain-language descriptive noun function of EDA_ITEM
2022-08-22 21:32:33 -04:00
f5a75a4001
Minor nullptr fixes
2022-08-22 21:32:33 -04:00
f5597238fb
Properties: add color swatch to layer enum
2022-08-22 21:32:33 -04:00
239fd29da4
Use checkbox mode for boolean props
2022-08-22 21:32:33 -04:00
91c15b7e21
Properties panel appearance tweaks
2022-08-22 21:32:33 -04:00
3c6e8aea0f
Properties panel: post-rebase fixes and hide by default
...
Remove layer widget re-added by Orson's rebase
2022-08-22 21:32:33 -04:00
990ea5595e
Properties: Fixed a startup crash
2022-08-22 21:32:33 -04:00
af71d42307
Renamed PROPERTY_TYPE enum names to avoid a conflict on MSYS2
2022-08-22 21:32:32 -04:00
c37c429c75
Rename PROPERTY_PANEL::Update() to PROPERTY_PANEL::UpdateData()
...
The base class (wxPanel) already provides Update() method,
which should not be overridden.
2022-08-22 21:32:32 -04:00
7f00efe6cf
Properties: Fixed conditional properties using enum values in the conditions
...
When wxAny holds an enum, it cannot be compared with an integer due to a
missing conversion function. In such case, conditional properties
compare a raw value rather than wxAny.
2022-08-22 21:32:32 -04:00
8fa513e903
Properties: fix Properties panel refresh
2022-08-22 21:32:32 -04:00
f6f6ebd5f9
WIP: Properties GUI
2022-08-22 21:32:32 -04:00
95fd58b25a
Properties meta-data for pcbnew classes
2022-08-22 21:32:00 -04:00
32461c91e9
Wide status bars can afford to give the text more room.
2022-08-22 22:33:38 +01:00
3a76d42630
Cross-probing/selection for multiple items (PCB -> SCH)
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10469
2022-08-22 19:33:39 +00:00
f42b66bc1c
Regularize ellipsization of menu and status text.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12257
2022-08-22 17:52:58 +01:00
4f0136db3b
Attempt to fix std::initializer_list lifetime issue.
2022-08-21 20:54:41 +01:00
b2a2d66005
Move Bus Definitions to common GUI paradigm in Schematic Setup.
...
Also includes a change to the std::initializer_list stuff to try and
fix a crash.
2022-08-21 12:29:51 +01:00
a5283d91eb
shape.i: disable a SWIG warning (warn 509) creating noise for this file.
2022-08-21 08:29:19 +02:00
aa2ad3b44c
Move KICAD_T[] to std::initializer_list<KICAD_T>.
2022-08-20 10:28:11 +01:00
46df421064
ADDED defined pad groups for net-tie footprints
...
Each pad group is allowed to short nets with other pads in its group.
Legacy footprints with the "net tie" keyword hack will get a single
group auto-created with all the footprint's pads in it.
DRC and the router now allow a track to collide with copper graphic items
while entering a net-tie pad as long as the closest point in the collision
is within the pad.
DRC (and the footprint checker) now check for copper items in the
footprint shorting pads which are not in the same pad group.
Fixes https://gitlab.com/kicad/code/kicad/issues/2265
2022-08-19 18:54:20 +01:00
508df402f6
Cleanup.
2022-08-19 18:54:19 +01:00
e0fbe2542f
Fix a few compil and Coverity warnings.
2022-08-19 10:53:29 +02:00
5ed7e28252
Remove KICAD_OCC build option
...
We don't really support builds without OCC these days. Removing to
clear up build flags and settings
2022-08-18 17:06:29 -07:00
f4fa3b02c5
PCM: automatic check for repository updates
2022-08-18 20:41:43 +00:00
97d7ee1f30
Remove `/` from our forbidden LIB_ID list
...
It is still forbidden from footprint file names but that is handled
separately and it should not be forbidden in symbol files at all
2022-08-18 12:49:40 -07:00
afacec3acb
Protect RC_TREE_MODEL::GetValue() against null pointer
2022-08-18 10:14:02 +02:00
19e27ef587
Avoid missing null check in RC_TREE_MODEL::DeleteItems
2022-08-17 07:12:26 -04:00
371f6d917f
Use VECTOR2I::extended_type instead of long, and int for numeric limits.
2022-08-16 12:08:55 +00:00
6d739ca9da
Improve handling of long distances
2022-08-16 12:08:55 +00:00
d33830e570
Switch sentry to commit hash for kicad nightly releases
2022-08-15 20:57:44 -04:00
2ee6f67892
Handle leading whitespace with std::from_chars
...
Testing the parsers, this doesn't generally happen but there was a comment about it before the changes
2022-08-15 19:30:43 -04:00
e4ba1d4879
Remove unused string helper
2022-08-15 19:12:45 -04:00
a3dc38cb32
Update schema versions so we can patch bad data from earlier bug.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12180
2022-08-15 23:48:38 +01:00
e015f5b086
Formatting.
2022-08-15 23:48:38 +01:00
34a5a32a52
Prevent GTK from zero-ing out column size
...
Related to https://gitlab.com/kicad/code/kicad/-/issues/12180
2022-08-15 14:24:02 -07:00
7155d1af29
Fix a few more compile warnings.
2022-08-15 15:15:35 -04:00
759e1a64ef
Fix broken const ref in wildcard
2022-08-15 12:09:30 -07:00
35ac39844f
Clean up some auto usage
...
Don't make new copies of shared_ptr if we can use references. Keep auto
usage down to hard-to-type-out sequences
2022-08-15 11:29:45 -07:00
1f347582f8
Introduce new marker type so we can track DRC errors on the drawing sheet.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12221
2022-08-15 18:03:03 +01:00
4b3ac52b1d
Fix shadowed variables
2022-08-15 08:03:30 -07:00
898ec0d094
Fix wxWidgets 3.1 and later deprecated build warnings.
...
wxWidgets 3.1 has deprecated wxPATH_NORM_ALL when normalizing file
paths when calling wxFileName::Normalize(). This change keeps the
existing behavior except in places where our own internal
ExpandEnvVarSubstitutions() to expand environment variables.
2022-08-15 08:00:40 -04:00
6365a37042
Add {fmt} library
2022-08-14 22:49:55 -04:00
c418b25756
Centralize the parseDouble functions in the parsers and gcc specialcase
2022-08-14 18:46:19 -04:00
84138d5039
Fix bug adding netclass in Eeschema.
2022-08-14 23:26:40 +01:00
86938aa425
Read, write and process the board-wide Allow soldermask bridges in FPs.
2022-08-14 22:56:29 +01:00
a9536b5de9
CHANGED netclass assignments now done via canvas or via patterns.
2022-08-14 22:56:29 +01:00
18ac169ac7
Add contexts to EDA_COMBINED_MATCHER.
2022-08-14 22:56:29 +01:00
4472435380
Fix broken constructor
2022-08-14 12:57:22 -04:00
a070959209
Switch from strtod to std::from_chars for performance
2022-08-14 16:19:24 +00:00
90a62d8b02
Use fgetc directly under msvc in richio
...
getc is a real function instead of macro like under gcc implementations. This adds a tiny cost of calls.
2022-08-14 16:19:24 +00:00
fd6564cc82
Allow KIID to directly take in std::string
...
Reduces multibyte conversion banging on library load. uuids already are ASCII by their nature and the logic checks that or else it generates a new kiid.
2022-08-14 16:19:24 +00:00
bbc0c61ccb
kiid.cpp: Fix Boost version incompatibility and use of boost::*::detail
...
Fix compile with Boost 1.65.1 (and possibly some or all of the 1.59-1.66
range); remove dependence on private boost::*::detail members.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12175
Comment tweaks by Mark Roszko @mroszko
2022-08-11 19:42:07 +00:00
39de92bba2
DIALOG_COLOR_PICKER: fix an issue in DC.SetDeviceOrigin() due to changes in wxWidgets.
...
DC.SetDeviceOrigin() behavior has changed in version 3.1.7 (or 3.1.6), and the settings
needs a small change.
Fixes #12204
https://gitlab.com/kicad/code/kicad/issues/12204
2022-08-11 10:15:50 +02:00
67d149ca73
QA: Use wxLogError() (not wxLogDebug()) in DisplayError[Message]()
2022-08-09 21:08:48 +02:00
2e2264cb74
Minor cleanup.
2022-08-09 08:46:12 +01:00
f695ae5522
Generate const keyword_hash maps at compile time
...
Or else the map gets pointlessly recreated during footprint loading thousands of times
2022-08-09 00:56:49 -04:00
a11f48ef10
Markers provider is no longer responsible for all markers.
...
Unconnected items and schematic partity violations are also now
represented by markers, so the ERC/DRC window itself needs to do
the deep-delete.
Fixes https://gitlab.com/kicad/code/kicad/issues/12182
2022-08-08 22:02:20 +01:00
51b905ba32
Move Configure Paths help inside dialog.
...
This allows us to switch back to a standard modal dialog (instead of
quasi-modal, which has problems with Ctrl-V in a search box inside a
standard file dialog -- such as when picking a path).
Fixes https://gitlab.com/kicad/code/kicad/issues/9473
2022-08-07 11:28:16 +01:00
5c9aed62aa
Use wxWidgets IDs for cut/copy/paste.
...
This allows them to work in places like search boxes in standard file
dialogs. If wxWidgets doesn't find the standard IDs in our menus
then it won't enable them.
2022-08-07 11:28:16 +01:00
509d233d97
Fix knockout text bounding boxes and hit testing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12133
2022-08-06 00:00:04 +01:00
d0d19423e0
Eeschema: Try to fix bitmap printing in wx version > 3.1.5
...
We had on a regular basis problems when printing bitmaps.
Probably due to issues in wx and in our code.
2022-08-04 14:25:52 +02:00
e4b6da287f
Fix errant string format char.
2022-08-03 14:27:56 +01:00
96f01d33c8
Performance improvements.
...
1) Move a bunch of std::map's to std::unordered_map to get constant-time
look-ups
2) Lengthen progress-reporting intervals to spend more time doing work
and less time talking about it
3) Reverse order of SHAPE_LINE_CHAINs in thermal intersection checks to
make (much) better use of bbox caches
4) Don't re-generate bboxes we already have
5) Fix some autos that weren't by reference (and were therefore copying
large datasets)
6) Rename delta progressDelta so it's easier to search for in future
7) Get rid of a few more autos (because I don't like them)
8) Pass large items to lambdas by reference
Fixes https://gitlab.com/kicad/code/kicad/issues/12130
2022-08-03 11:59:42 +01:00
0304ad4494
Move connection width testing to rule system.
...
Also copies connection width progress reporting architecture over to
the sliver checker.
2022-08-01 13:09:51 +01:00
6f49b57f9b
Cleanup & performance enhancements.
2022-08-01 13:09:51 +01:00
d1ff8f4781
PROGRESS_REPORTER_BASE: call code to resize it only if the message has change.
...
In wxWidgets 3.15 (and perhaps older version) the call to GetTextExtent() probably
creates major issues when called too many times, at least oo msys2.
It was probably also time costly.
Calling it and resize the PROGRESS_REPORTER only when needed fixes these serious issues.
Issues happened only when the board has a lot of zones (when teardrops are added)
2022-08-01 13:18:50 +02:00
32551cf1ea
minor coding style fix.
2022-07-31 18:35:37 +02:00
4bfbf91369
3D viewer: Fix incorrect behavior when moving the scene
...
Fixes #12114
https://gitlab.com/kicad/code/kicad/issues/12114
2022-07-30 13:27:25 +02:00
7cf5138c63
Sim: Bugfixes, mostly for MS Windows compilation errors
...
Unfortunately, Windows headers define a lot of macros for common words,
so we had to rename some enums to not collide.
We also fix some of the many bugs related to the new simulation
architecture and the Spice Model Editor dialog.
2022-07-30 02:25:34 +00:00
a8505d9c76
SEARCH_RESULT -> INSPECT_RESULT
...
To fix the name squatting it's doing for future functionality
2022-07-29 20:01:10 -04:00
490875e222
Fix a missing call to aEvent.Skip() in commit 753f2f3.
...
Any wxSizeEvent handler must call Skip() to propagate the event.
2022-07-29 16:46:35 +02:00
905df71977
Fix an issue when printing bitmaps when not on wxWidgets 3.1.6 and 3.1.7
...
Commit 6e35d5473048cf6df
2022-07-29 13:09:20 +02:00
048cf6df7a
Fix an issue when printing bitmaps when not on wxWidgets 3.1.6
...
Commit 6e35d5473Fixes #12108
https://gitlab.com/kicad/code/kicad/issues/12108
2022-07-29 10:26:45 +02:00
753f2f3e4c
Display descriptions in second column of library trees.
...
Also fixes some bugs in how the columns are sized.
Fixes https://gitlab.com/kicad/code/kicad/issues/12090
2022-07-28 14:51:47 +01:00
Alex
jean-pierre charras
Seth Hillbrand
Jeff Young
Marek Roszko
Jon Evans
Ian McInerney
qu1ck
Mike Williams
lulu731
kliment
aris-kimi
Wayne Stambaugh
Roberto Fernandez Bautista
Maciej Suminski
Forrest Voight
Mikolaj Wielgus