haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
35,119 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

8945 Commits

Author SHA1 Message Date
Mikolaj Wielgus 1965411bf5 Sim: Remove the parsing exception for LTspice compat 
Silently ignoring this may be a cure worse than disease.
 2022-10-18 23:19:48 +02:00
Wayne Stambaugh 2a13c0af2e Revert commented out code. 2022-10-18 16:07:14 -04:00
Jeff Young 1964087960 Fix some instance-data issues in netlist exporters. 
Also removes the final requirements for setting the current sheet so
that we no longer need to do a save/restore.
 2022-10-18 17:26:34 +01:00
Mikolaj Wielgus 6e874f4c1e Ngspice: Preload a basically empty circuit to avoid error messages 
Fixes https://gitlab.com/kicad/code/kicad/issues/12481
 2022-10-18 05:48:01 +02:00
Wayne Stambaugh 598b09821a Coverity fixes. 2022-10-17 15:30:20 -04:00
jean-pierre charras aa36e15d66 Eeschema, Print preview: fix a incorrect initial size on wx 3.1.7 (and later) 
Due to internal changes in wxWidgets, the initial size of the frame was not taken in account.
 2022-10-17 10:49:28 +02:00
Mikolaj Wielgus 2475a703d6 Sim Model Editor: Checkbox for toggling inference 2022-10-16 05:10:57 +02:00
Mikolaj Wielgus c8e13813d9 Sim: Rename Sim_Disabled field to Sim_Enable 2022-10-16 00:49:44 +02:00
Wayne Stambaugh b109136c5c Fix complex hierarchy instance data when loading legacy schematic. 2022-10-15 14:50:06 -04:00
Wayne Stambaugh f782323960 Fix yet another symbol instance issue when loading legacy schematics. 2022-10-15 14:16:03 -04:00
Jeff Young 254dff2813 Add do_not_autoplace to schematic parser and printer. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12657
 2022-10-15 19:09:25 +01:00
Mikolaj Wielgus c3d5b3b3e5 Sim: Only store device type in reference, not full model type 
Instead of Reference="VSIN1", Value="dc=1 ampl=2 f=3", it's now
Reference="V1", Value="SIN dc=1 ampl=2 f=3".
 2022-10-15 19:36:26 +02:00
Marek Roszko 6ce714d537 Use wxCHECK instead of wxCHECK2 2022-10-15 11:25:15 -04:00
Marek Roszko ce2d091588 wxCHECK2 needs an actual "op", in this case return 2022-10-14 21:01:49 -04:00
Seth Hillbrand 5c974f8cd0 Don't arbitrarily close tags that are not open 
Fixes https://gitlab.com/kicad/code/kicad/issues/12647
 2022-10-14 15:30:51 -07:00
Jeff Young 668180f96a Add "show field names" to Global Edit Text & Graphics Properties. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12641
 2022-10-14 23:04:09 +01:00
Jeff Young 7ffdfb1067 Clear Scintilla undo history after setting initial text. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12650
 2022-10-14 22:01:20 +01:00
Wayne Stambaugh 41461f7a69 Improve symbol rescue dialog. 
* Fix some minor layout issues on Linux.
* Use button labels to clarify rescue actions.
 2022-10-13 10:37:04 -04:00
Jeff Young f9a791e2b0 Copy font across when changing text type. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12629
 2022-10-12 23:49:40 +01:00
Wayne Stambaugh 430098791e Another attempt to fix schematic symbol rescue issues. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12624
 2022-10-12 16:57:09 -04:00
Jeff Young 8dea227da7 Special cases for sheet-pin dragging. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11949
 2022-10-12 16:36:54 +01:00
Jeff Young 3231bc5be3 Formatting and cleanup. 2022-10-12 16:36:54 +01:00
Jeff Young 5507748fa9 Make sure bounding box is not degenerate. 2022-10-12 16:36:54 +01:00
jean-pierre charras 806b5fab0e SYMBOL_LIBRARY_MANAGER::SaveLibrary(): Add missing code. 
It fixes an issue after deleting a symbol and trying to save the library:
The library, although saved, was always flagged as modified.
 2022-10-12 15:56:41 +02:00
Mikolaj Wielgus c857e533a9 Sim: Fix crash when a field tries to set an inexistent parameter 
Refactored SetParamValue() and friends to use exceptions instead of
return values.
 2022-10-12 04:27:48 +02:00
Mikolaj Wielgus 6ae333a116 Sim Model Editor: Fix crash when opening sources 2022-10-12 04:27:48 +02:00
Jeff Young bd1114d94d Move footprint properties dialogs to symbol properties grid resizing strategy. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9883
 2022-10-12 00:38:44 +01:00
Jeff Young e02c05d38f Add unit and eval support to WX_GRIDs. 
Fixes https://gitlab.com/kicad/code/kicad/issues/1871

Fixes https://gitlab.com/kicad/code/kicad/issues/4285
 2022-10-11 23:40:58 +01:00
Jeff Young ad5df7f4cc More busy cursor tightening. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11648
 2022-10-11 23:40:58 +01:00
Wayne Stambaugh 148467d2a1 Fix schematic symbol rescue issues. 
This fix makes some fundamental changes to the way symbols are rescued:

* The new symbol library file format is used when rescuing symbols defined
  in the symbol library table.
* The original library nickname is appended to the symbol name rather than
  the rescue library nickname when rescuing symbol defined in the symbol
  library table.
* Escaping strings has been removed from legacy library rescues since the
  legacy library file format never supported it.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/12525

Fixes https://gitlab.com/kicad/code/kicad/-/issues/12624
 2022-10-11 16:18:59 -04:00
Jeff Young 8206283a20 Code clarity. 2022-10-11 11:22:26 +01:00
Jeff Young 3967435f94 Tighter control of busy cursor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11648
 2022-10-11 11:22:26 +01:00
Jeff Young d3797dd183 Code clarity. (No functional changes.) 
Also some more error message cleanup for consistency.
 2022-10-11 11:22:26 +01:00
Jeff Young 8a9e92bc01 More consistency in error messages. 2022-10-11 11:22:26 +01:00
Mikolaj Wielgus d47752ad75 Sim Model Editor: Fix displaying Ibis pin list 2022-10-11 02:22:59 +02:00
Mikolaj Wielgus d9eb76eae0 Sim: Refactor SPICE_GENERATOR methods to accept a single SPICE_ITEM 2022-10-11 02:22:59 +02:00
Jeff Young 1825905011 Replace more-than-half-line algorithm with greedy/stingy check. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10860
 2022-10-10 20:23:48 +01:00
Jeff Young cb20a39693 Always select whole lines with greedy selection. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10869
 2022-10-10 20:17:15 +01:00
Jeff Young 3221877fe8 Push autosave-require down in to EDA_BASE_FRAME. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11790
 2022-10-10 14:03:52 +01:00
Jeff Young be6f08deca Code clarity. (No functional changes.) 2022-10-10 14:03:52 +01:00
Mikolaj Wielgus 6d958c5a3b Sim: Remove some superfluous class members 2022-10-10 13:49:43 +02:00
Mikolaj Wielgus 4931b80066 Sim: Resolve name collisions for generated model names 2022-10-10 13:38:35 +02:00
Mikolaj Wielgus 72402cf687 Sim: Override base model type if there's a Sim_Type field 2022-10-09 20:46:05 +02:00
jean-pierre charras 79c301800a Eeschema printing: fix some issues. 
The offset setting was incorrect when using wxAffineMatrix2D.
It was especially visible when printing more than one sheet.
Note also when not using wxAffineMatrix2D, all pages must have the same orientation
(PORTRAIT/LANDSCAPE is not managed)
Fixes #12211
https://gitlab.com/kicad/code/kicad/issues/12211
 2022-10-09 18:20:19 +02:00
jean-pierre charras f5fd12c002 Symbol Editor: Fix reverting changes on a root symbol: derived symbols are displayed wrong 
Reverting changes broke links between derived symbols and the root symbol.
Now fixed by do not delete and recreate reverted symbol.
Fixes #10792
https://gitlab.com/kicad/code/kicad/issues/10792
 2022-10-08 15:56:24 +02:00
Mikolaj Wielgus 994274fe9f Move IBIS model Spice code generation to SIM_MODEL_KIBIS 
IBIS drivers are temporarily broken. Will fix is subsequent commits.
 2022-10-08 03:01:52 +02:00
Seth Hillbrand a5da46459c Be sure to update UUID when placing new elements 
Fixes https://gitlab.com/kicad/code/kicad/issues/12588
 2022-10-07 16:32:41 -07:00
jean-pierre charras 8c19bf4815 eeschema: fix arc orientation issue when reading old symbol libs (version 20210619). 
Fixes #12514
https://gitlab.com/kicad/code/kicad/issues/12514
 2022-10-07 16:57:45 +02:00
jean-pierre charras 01a1d148e6 Make a sentence understandable and translatable. 
Fix a minor compil warning
 2022-10-07 10:11:02 +02:00
Seth Hillbrand b4c18dd22a Correct error message when unit counts differ 
Testing if the symbol associated with unit X has a different number of
total units than the symbol associated with unit Y should report the
actual error to the user.

This cleans the various display of these error messages

Fixes https://gitlab.com/kicad/code/kicad/issues/10237
 2022-10-06 15:41:16 -07:00
Seth Hillbrand f369cc23a9 Handle arbitrary unit counts 2022-10-06 15:41:16 -07:00
Jeff Young 19d270fe74 Text size sanity checking for TEXT_ITEMS_GRID. 
Oh dear, there was a bunch going on here.  Firstly the move from int
to long long int for ValueFromString() means that we were no longer
catching overflows (as we were C-style casting it back to int in many
places).  But even when the overflow is caught, it would run in to
wxWidgets' empty string bug while trying to log it.

Fixes https://gitlab.com/kicad/code/kicad/issues/12577
 2022-10-06 13:19:08 +01:00
Mikolaj Wielgus 6f2b2d7e19 Sim: Minor SIM_LIBRARY cleanup 2022-10-06 14:08:01 +02:00
Mikolaj Wielgus b95f4ec6bb Sim: Use the new library manager class in Spice netlist exporter 
Temporarily comment out IBIS processing.
 2022-10-06 09:49:29 +02:00
Alex c019ae3b89 Add missing include 2022-10-05 20:21:38 +03:00
Seth Hillbrand a0aff2dc70 Set the proper symbol parent when duplicating 
We need to handle both the case where the new symbol is an alias as well
as free the proper memory after loading symbols in the duplicate

Fixes https://gitlab.com/kicad/code/kicad/issues/12578
 2022-10-05 09:46:13 -07:00
Mikolaj Wielgus 6df774a62f Commit missing sin_lib_mgr.{cpp,h} 2022-10-05 18:08:25 +02:00
Mikolaj Wielgus 44799c830d Sim: Create a class to manage sim libs and inherited models 2022-10-05 17:19:28 +02:00
Wayne Stambaugh 0336cff8d6 Allow schematic symbol value and footprint fields to be instantiated. 2022-10-05 11:12:21 -04:00
Mikolaj Wielgus 8e34dae347 Sim Model Editor: Fix exclude symbol checkbox 
Fixes https://gitlab.com/kicad/code/kicad/issues/12344
 2022-10-05 11:24:46 +02:00
Wayne Stambaugh 03d847118a Fix crash when copying symbol in schematic editor. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12574
 2022-10-04 17:51:58 -04:00
Mikolaj Wielgus 2f756d9d23 Sim Model Editor: Fix Model panel sizing 2022-10-04 23:47:52 +02:00
Mikolaj Wielgus e99d531c88 Sim: LTspice model compat: Ignore spurious values 
Also fix parsing type in ako models
 2022-10-04 22:44:26 +02:00
Wayne Stambaugh a11c40197f Expunge default symbol instance from schematic file format. 
Now that importing hierarchical sheets "properly" imports instance data,
the default symbol instance setting doesn't have any meaning.
 2022-10-04 15:42:41 -04:00
Mikolaj Wielgus 120b569048 Sim: Support ako models 2022-10-04 17:48:10 +02:00
Mikolaj Wielgus c2765f40ca Sim Model Dialog: Fix nullptr dereference 2022-10-04 17:48:10 +02:00
jean-pierre charras 4611817f25 Eeschema: fix a crash when invoking eeschema.exe with 2 filenames to open 
Fix also a minor compil warning
 2022-10-04 16:56:13 +02:00
Seth Hillbrand f5f6d44a48 Correctly increment field IDs 
Setting to -1 is no longer valid despite the previous comment as this
will pick out a single non-mandatory field to save

Fixes https://gitlab.com/kicad/code/kicad/issues/12567
 2022-10-03 21:50:29 -07:00
Mark Roszko fb8a4c10f7 Shove kicad2step into pcbnew itself with a new cli 2022-10-04 01:53:37 +00:00
Jeff Young c5f8587898 Use closest point for duplicate anchor rather than top-left. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10004
 2022-10-03 23:28:58 +01:00
Jeff Young 7bb0275d3c Fix incompatibility with old rubber-band wire algo and new ortho wire drag alog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11948
 2022-10-03 22:12:23 +01:00
Jeff Young c6284f4835 Formatting. 2022-10-03 22:12:23 +01:00
Mikolaj Wielgus c464c5b87b Sim: cleanup: use unique_ptr for PARAM::value 2022-10-03 22:15:14 +02:00
Seth Hillbrand 9186be600b Fix resource leak 2022-10-02 21:10:27 -07:00
Jeff Young e335c1c612 Fix for LIB_TREE hotkeys over canvas and possible fix for over LIB_TREE itself. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11034
 2022-10-02 22:22:21 +01:00
Seth Hillbrand e055302a3c Allow printing backgrounds prior to foreground 
Eeschema shows background fills on a different z-level than the rest of
the symbols/elements.  Print the backgrounds prior to the foregrounds in
order to preserve this view for print output

Fixes https://gitlab.com/kicad/code/kicad/issues/12559
 2022-10-02 13:23:54 -07:00
Wayne Stambaugh 2b387ae9c3 Move schematic symbol instance data back into symbol definition. 
This change reverts the storage of all symbol instance data in the root
schematic.  This was done because it's not possible to reuse instance
data when importing from sub-sheets.

There has been a fundamental change in how sheet paths are store in the
instance data.  The root schematic UUID is always used when saving the
instance data.  To prevent file churn, the virtual root sheet UUID is set
to the root schematic UUID when loading the project.  This provides a way
to determine the project that stored the instance data.  All uses of paths
without root sheet have been expunged from the code.

The sheet instance data is still saved only in the root sheet for the
time being.  New sheet instances will be automatically assigned an page
number based on the incremental virtual sheet page number.  Sheet page
numbers will not be imported.

Added project name to instance data to improve the readability of the
schematic file format.  It also creates an opportunity to remove orphaned
instance data by project name rather than cryptic UUIDs.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/12472
 2022-10-02 15:06:42 -04:00
Jeff Young 27296b5043 Quote all bus members when writing to file. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12447
 2022-10-02 17:43:47 +01:00
Jeff Young eea8c7a8fd Handle netclasses assigned to bus labels. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12546
 2022-10-02 15:01:16 +01:00
Jeff Young c089afb408 Improve default net pattern to be all members of bus instead of first member. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12546
 2022-10-01 22:58:11 +01:00
Seth Hillbrand 9adae0e8ba Avoid double-processing SCH_ITEMs 
Elements such as zero-length lines might get into the connection map,
causing the system to process them twice.  This can cause allocation
errors when both are performed at the same time

Fixes https://gitlab.com/kicad/code/kicad/issues/12278
 2022-10-01 12:28:39 -07:00
jean-pierre charras efdb67aa64 Minor fixes. 2022-10-01 18:42:02 +02:00
Seth Hillbrand 93239516d9 Remove ID from property fields 
ID was not maintained or used other than to ensure unique fields.
Instead of saving, we assign the known IDs to specific field names and
sequentially create new IDs on load

Fixes https://gitlab.com/kicad/code/kicad/issues/12390
 2022-09-30 17:19:53 -07:00
Jeff Young c0a666507c Work around more instances of the wxWidgets color string locale bug. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12552
 2022-09-30 20:56:25 +01:00
Mikolaj Wielgus 0d369f700f Sim: Basic cleanup after KIBIS merge 
- Some preliminary refactoring,
- Use multiple types for IBIS drivers instead of a wftype variable,
- Remove the m_requiresUIUpdate variable and its accessors.
 2022-09-30 16:17:00 +02:00
Mikolaj Wielgus 62f89ba0d6 Sim GUI: Remove irrelevant references to Spice 2022-09-30 14:32:57 +02:00
Jeff Young 67caebe4c4 When the sash button is right next to the fp dropdown they look related. 2022-09-30 13:02:08 +01:00
Mike Williams c1da59b560 Swap: disallow swapping tracks / wires 
Also fix missed shortcut change for S -> Shift-S

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12538
 2022-09-29 17:04:43 -04:00
Wayne Stambaugh 979b4a4eb7 Revert "Move schematic symbol instance data back into symbol definition." 
This reverts commit 7984e114db.
 2022-09-29 15:33:23 -04:00
Wayne Stambaugh a60ed99510 Revert "Add project name to symbol instance data." 
This reverts commit 4b276b339a.
 2022-09-29 15:33:23 -04:00
Wayne Stambaugh 4b276b339a Add project name to symbol instance data. 
This improves the readability of the schematic file format and creates
an opportunity to remove orphaned instance data by project name rather
than cryptic UUIDs.
 2022-09-29 17:47:57 +00:00
Wayne Stambaugh 7984e114db Move schematic symbol instance data back into symbol definition. 
This change reverts the storage of all symbol instance data in the root
schematic.  This was done because it's not possible to reuse instance
data when importing from sub-sheets.

There has been a fundamental change in how sheet paths are store in the
instance data.  The root schematic UUID is always used when saving the
instance data.  To prevent file churn, the virtual root sheet UUID is set
to the root schematic UUID when loading the project.  This provides a way
to determine the project that stored the instance data.  All uses of paths
without root sheet have been expunged from the code.

The sheet instance data is still saved only in the root sheet for the
time being.  New sheet instances will be automatically assigned an page
number based on the incremental virtual sheet page number.  Sheet page
numbers will not be imported.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/12472
 2022-09-29 17:47:57 +00:00
jean-pierre charras 46b0c116cd fix a compil warning. 2022-09-29 13:06:50 +02:00
Fabien Corona 7e486327d9 Ibis differential and PRBS models 2022-09-29 08:35:01 +00:00
jean-pierre charras dcc325b3b2 More about fix compil issues and warnings, especially in ibis code. 
A few are msys2 specific and due to include files order.
 2022-09-28 11:26:07 +02:00
Mikolaj Wielgus b3b2b8b3f0 Sim: Don't hold KIBIS in MODEL_TYPE enum 
Fixes pipeline error.
 2022-09-28 11:14:50 +02:00
Mikolaj Wielgus b7c8570b2a Sim: Fix infinite recursion 2022-09-28 11:14:50 +02:00
Alex df59f6cfdb Update connectivity for net highlighting on demand. 2022-09-27 21:24:01 +00:00
Fabien Corona 528fe4d371 Add Ibis to spice model editor 
ADDED: IBIS models are now supported in Sim Model Editor
 2022-09-27 20:47:00 +00:00
Alex dc07ab9df1 Replace PROF_COUNTER with PROF_TIMER in some conditional places. 2022-09-27 14:07:47 +00:00
Jeff Young 83a7ab2449 Initialize resolved status of newly created wires during drag operation. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12522
 2022-09-27 14:12:06 +01:00
Jeff Young 7f63c70702 Add include for Linux builds. 2022-09-27 12:31:47 +01:00
Jeff Young fb80f83335 Formatting. 2022-09-27 11:12:58 +01:00
Jeff Young 9ce4f0a0b5 ADDED setting page number from hierarchy tree. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8352
 2022-09-26 21:58:04 +01:00
Jeff Young ce0affedb1 Coding conventions. 2022-09-26 21:58:04 +01:00
Jeff Young 838bd7292c Default intersheet ref field visibility to off, and show warning 
when user tries to edit via Symbol Properties or Field Propeties.
 2022-09-26 21:00:46 +01:00
Jeff Young 10d8db482e Init intersheet refs field pos to local {0,0}, not global {0,0} 
Fixes https://gitlab.com/kicad/code/kicad/issues/12517
 2022-09-26 21:00:46 +01:00
jean-pierre charras 7584ccc758 Fix duplicate variable member m_userUnits, creating issues depending on 
the way it was acceded (by name or by accessor).
 2022-09-26 19:47:28 +02:00
Jeff Young d0ff90eb6e Support mirroring of multiple SCH_FIELDs at once. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12512
 2022-09-26 17:44:52 +01:00
Jeff Young 58874a591b Improve tooltips. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12510
 2022-09-26 17:44:52 +01:00
Marek Roszko 59d62f7df1 Untangle some includes 2022-09-25 11:37:06 -04:00
Ian McInerney 40ff7cb9bd Fix some UI element spacing in settings panels 2022-09-25 15:41:39 +01:00
Ian McInerney b363e0f300 Simplify lib shape properties dialog code 
Since 34e706bcbc it is assumed that the
shape passed in exists, so testing for a null pointer is pointless
(it will always be non-null). Also hardcode the assumption the shape is
non-null in the constructor using an assert.
 2022-09-25 15:41:39 +01:00
Marek Roszko 2646be730d Don't place bookmarks for power symbols (like GND) 2022-09-25 08:50:48 -04:00
Marek Roszko 209e1b2086 Add naming of the outline page entries 2022-09-24 22:54:38 -04:00
Marek Roszko f2377b447d Add hierarchical label group in pdf outline 2022-09-24 22:36:06 -04:00
Marek Roszko a381a0acb2 Generalize bookmarks to support additional groups and names 2022-09-24 22:35:20 -04:00
Marek Roszko 6f8205235f ADDED: Add outline support to schematic PDF and PCB plot 2022-09-24 21:45:48 -04:00
Ian McInerney 44c2782d39 Fix more for loops making copies of iterates 2022-09-25 00:48:38 +01:00
Ian McInerney 1683e552f7 Add/fix some variable initializations 2022-09-25 00:48:38 +01:00
Jeff Young 5fc02a63a3 Use netclass colours for label graphics, text and fields. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4984
 2022-09-24 23:51:40 +01:00
Jeff Young 659a6e5b04 Replace macHack as its requirement sadly never went away. 2022-09-24 23:50:45 +01:00
jean-pierre charras a9d31348b1 Eeschema, print and plot: fix arc issue for lib arcs == 180 deg 
Fixes #12502
https://gitlab.com/kicad/code/kicad/issues/12502
 2022-09-24 10:00:21 +02:00
Ian McInerney d9846a006a Get lib shape fill color from settings if not specified by shape 2022-09-24 03:46:06 +01:00
Ian McInerney fdb97a46c1 Don't copy items in for loops when not needed 2022-09-24 03:46:06 +01:00
Jon Evans 35520c78e4 Fix missing virtual dtor 2022-09-23 21:44:15 -04:00
Jon Evans 2089374f53 ADDED: Export symbols from schematic to library 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11433
 2022-09-23 21:23:01 -04:00
Ian McInerney c71c192372 Fix warning generated by sim string changes 2022-09-24 01:37:57 +01:00
jean-pierre charras bd28bd7a00 fix a few compil warnings 2022-09-23 18:30:42 +02:00
qu1ck 6ebb3baa3b PCM: autoload libs from installed packages to global lib tables 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9713
 2022-09-23 16:16:13 +00:00
Alex 58b03b0a1c Small optimizations. 2022-09-22 17:22:04 +00:00
Alex f75266d130 Keep selection order in SCH->PCB cross-selection. 2022-09-22 11:43:37 +00:00
Mikolaj Wielgus e27969217c Add missing virtual destructor in SPICE_GENERATOR 2022-09-22 11:17:07 +02:00
Mikolaj Wielgus e4865ce543 Excise wxString from simulation 2022-09-22 07:41:52 +02:00
Jeff Young fc10db25ba Netclass directive and label conversion improvements. 
1) Copy label fields when converting.
2) Don't assume netclass directive should be net name -- this is very
unlikely.
3) Don't show font controls in Netclass Directive Properties dialog --
there's no basic text associated witha  Directive Label.
 2022-09-22 01:22:19 +01:00
jean-pierre charras b6663a1c41 minor fixes. 2022-09-21 15:49:50 +02:00
Jeff Young 8eb68ee472 Add pin/unpin context menu to Symbol Chooser and Footprint Chooser. 
Also moves some more code down into common so it can be shared.

Fixes https://gitlab.com/kicad/code/kicad/issues/12384
 2022-09-21 14:45:12 +01:00
jean-pierre charras 78087597cd Avoid including plotters/plotter.h in many files. 
It avoid a large rebuild when modifying the plot code.
 2022-09-21 08:52:34 +02:00
Mikolaj Wielgus 0e0c4df4da Fix build with -DKICAD_SPICE=OFF 2022-09-20 20:31:14 +02:00
jean-pierre charras f851526c67 Plotters: make virtual void PLOTTER::Arc() using arc angles protected. 
Using arc angles to plot an arc is really error prone due to different
options between plotters, and angles defined in Kicad, using this version of
arc plotting from Kicad is no longer allowed in Kicad code.
 2022-09-20 18:55:20 +02:00
jean-pierre charras fd4cd17f4f fix a compil warning 2022-09-20 18:55:20 +02:00
Jeff Young 7f34586c7e Allow text variable resolution through properties in drawing sheet text. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12473
 2022-09-20 15:28:05 +01:00
jean-pierre charras bbaf5a21c2 Eeschema: fix a plot issue with arcs. 
Arcs are really error prone, due to different Y axis orientation, and geometry transforms.
Probably we should remove plot and print functions using arc angles as parameters
that are a can of worms.
Fixes #12465
https://gitlab.com/kicad/code/kicad/issues/12465
 2022-09-20 16:04:17 +02:00
Mikolaj Wielgus 2bf6791352 Sim: Move SIM_LIBRARY_SPICE parsing facilities to a new class 
This leaves SIM_LIBRARY_SPICE very small, but it will grow larger later.
 2022-09-20 08:17:51 +02:00
Jeff Young 30a4d3d2de Coverity fixes. 2022-09-20 00:19:15 +01:00
Seth Hillbrand 4b20eb9cb0 Remove debugging code 2022-09-19 15:25:06 -07:00
Seth Hillbrand e0f7c3b057 Properly handle non-connected labels in ERC 
All labels need to be attached to a net that has at least 2 pins in
order for this to be a valid net.  To check for the existing pins, we
need to interate over all subgraphs in the net, counting pins
 2022-09-19 15:18:32 -07:00
Jeff Young 64a6fc0fd4 Push UNITS_PROVIDER down into a low-level mixin. 
This allows us to also construct cheap UNIT_PROVIDERs for specific
tasks when necessary.
 2022-09-19 17:10:59 +01:00
jean-pierre charras 5990595619 When adding a bitmap, do not clone it during moving. 
Cloning is not necessary, and is memory consuming.
 2022-09-19 17:41:47 +02:00
Mike Williams 9304607624 TOOL_EVENT: make command string non-optional 
We're getting segfaults in places where this isn't checked. Also, add
some asserts so we can catch bad tool push/pop.

Removes all uses of GetCommandStr() and makes it private.
 2022-09-19 10:23:09 -04:00
Jeff Young 45d6b4a9fc Readability improvements. 2022-09-19 11:18:20 +01:00
Mikolaj Wielgus 8599323dce Sim: Move Spice model parsing to a separate class hierarchy 
Roughly analogous to the SPICE_GENERATOR hierarchy.
 2022-09-19 07:24:46 +02:00
Mikolaj Wielgus 0efc1149af Sim: Create a common base class for models sourced from Spice libs 2022-09-18 21:25:28 +02:00
Marek Roszko 63295cfb9e Remove unused vars 2022-09-18 08:49:07 -04:00
Mikolaj Wielgus 3b94624e90 Commit forgotten files 
I must stop forgetting to commit new and renamed files.
 2022-09-18 07:27:47 +02:00
Mikolaj Wielgus a8d7a845b6 Sim: Rename SIM_MODEL_SPICE to SIM_MODEL_RAW_SPICE 2022-09-18 07:25:56 +02:00
Mikolaj Wielgus 4128a5533f Sim LTspice compat: Ignore mfg, icrating, vceo, type params 2022-09-18 04:14:57 +02:00
Mikolaj Wielgus dcb3f16fbc Sim: Don't use long type in SIM_VALUE 2022-09-18 02:25:40 +02:00
Jeff Young e6c8cf0f03 Don't escape spaces in bus groups and transfer hyperlinks. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12451

Fixes https://gitlab.com/kicad/code/kicad/issues/12452
 2022-09-17 20:56:50 +01:00
Mikolaj Wielgus 15b5b48992 Sim: More descriptive parsing errors in all Spice parsers 
In my previous commit, which changed Spice parsing errors to be more
descriptive, I forgot to apply this to all invocations of the Spice
parser. This commit corrects that.
 2022-09-17 08:46:45 +02:00
Mikolaj Wielgus 5fa0a1a064 Sim: Output more descriptive parsing errors 2022-09-17 08:29:18 +02:00
Marek Roszko 5f85c3b8b9 Fix everything loading DNP 2022-09-17 00:21:05 -04:00
Marek Roszko ece23d434b Split up Double2Str to a format function to make its use case clear 2022-09-17 00:10:22 -04:00
Marek Roszko 3d5913c825 Remove convert_to_biu.h, merge contents to base_units.h 2022-09-16 21:09:28 -04:00
Marek Roszko 66e8931405 Remove IU_PER_MM thats standalone 2022-09-16 21:09:27 -04:00
Marek Roszko 7a5829f8d6 Move IU2Mils 2022-09-16 21:09:27 -04:00
Marek Roszko 61e11d6896 Strip out Mils2Iu 2022-09-16 21:09:27 -04:00
Marek Roszko e6ed275c25 Repoint IU_PER_MILS 2022-09-16 21:09:26 -04:00
Marek Roszko a8613ee80f Combine Iu2Millimeter & remove PcbMm2iu 2022-09-16 21:09:26 -04:00
Seth Hillbrand e0a6ff3f14 Don't hold on to the background print color option 
When printing b/w we need to set the print background to off otherwise
we can inadvertently get backgrounds printing
 2022-09-16 17:23:06 -07:00
Mikolaj Wielgus d48ec3aa8c Sim: Slightly simplify grammars 2022-09-17 02:18:23 +02:00
Seth Hillbrand 524b129c64 ADDED: Support for explicit DNP field 
Dims elements shown as DNP.  Adds property `dnp` to explicitly denote
parts that should not be populated. These parts are not included in X/Y
files
 2022-09-16 22:26:16 +00:00
Jeff Young 2aa8facacd Reconcile SPIN_STYLE and text alignment/rotation controls. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12443
 2022-09-16 20:01:18 +01:00
Jeff Young 907cafef6d Update font size before querying properties dependent on it (like the text margin). 
Fixes https://gitlab.com/kicad/code/kicad/issues/12444
 2022-09-16 18:57:12 +01:00
jean-pierre charras dd1abcbee9 Fix a UTF8 convert issue in some BOM python scripts. 
Fixes #12435
https://gitlab.com/kicad/code/kicad/issues/12435
 2022-09-16 10:25:51 +02:00
Mikolaj Wielgus 545212eb13 Sim Window: Support dark theme 2022-09-16 06:57:27 +02:00
Mark Roszko b00178adb3 Nuke base_units from orbit 2022-09-16 04:38:10 +00:00
Mikolaj Wielgus 4ae2225b6d Sim: Replace all wxStrings with std::strings in SIM_VALUE 2022-09-16 06:11:14 +02:00
Mikolaj Wielgus d19b2dbfe4 Sim Model Editor: Display error when failing to set parameter 2022-09-16 05:44:23 +02:00
Mikolaj Wielgus ce3fe46751 Sim Window: Display latest netlist without having to run sim 
Fixes https://gitlab.com/kicad/code/kicad/issues/11787
 2022-09-16 03:12:28 +02:00
Jeff Young 1e64db779c Fix some issues in ERC error messages. 
1) use consistent punctuation
2) make sure all are translated

Fixes https://gitlab.com/kicad/code/kicad/issues/12432
 2022-09-15 23:43:46 +01:00
jean-pierre charras 8a0384e2f6 crossprobing pcb->schematic: handle correctly empty sheets. 
(filtering selection candidates was not made for empty sheets)
Fixes #12427
https://gitlab.com/kicad/code/kicad/issues/12427
 2022-09-15 17:52:57 +02:00
Wayne Stambaugh aeb4021854 Add missing symbol library file format version change. 
This was back dated to the original merge date.  See merge request #1302.
 2022-09-15 10:54:34 -04:00
jean-pierre charras fb793d9a62 Recreate panel_eeschema_editing_options_base.cpp: there were strange tooltips. 
Looks like the file was edited by hand.
 2022-09-15 16:13:51 +02:00
Jeff Young a21d24a4c8 Experiment with loading recent searches into the search menu. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11743
 2022-09-15 14:44:02 +01:00
jean-pierre charras 83fb06ff75 Fix compil and Coverity warnings. 2022-09-15 10:50:14 +02:00
Mikolaj Wielgus 907ad27e7f Sim: Move SPICE_GENERATOR class to a new file 2022-09-15 05:26:23 +02:00
Jon Evans da9be1a812 ADDED: Multi-selection cut/copy/paste in symbol editor library tree 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11505
 2022-09-14 22:20:38 -04:00
lulu731 0180bcf90a ADDED: Implement Drag and Drop 
dropping files to Kicad manager :
  *.kicad_pro, *.pro -> open project;
  gerber and job files -> open in Gerbview editor;
  Eagle and Cadstar files -> open project.
dropping file to schematic editor -> append schematic;
dropping library file to Symbol editor -> add library;
dropping board file to PCB editor -> append board;
dropping library or footprint file to Footprint editor -> add library or import footprint;
dropping ZIP file or gerber files to Gerbview editor -> open files;
dropping sheet file to Drawing Sheet editor -> open sheet.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11638
 2022-09-14 22:28:09 +00:00
kliment b97f9ea329 Add support for symbol unit display names in eeschema and symbol editor 2022-09-14 22:11:37 +00:00
Mikolaj Wielgus e4c5bc6c66 Sim: Refactor Spice code generation to a new SPICE_GENERATOR class 2022-09-14 09:36:49 +02:00
Marek Roszko e473e71ef8 Restore the original lib property file indentation 2022-09-13 23:39:35 -04:00
Mikolaj Wielgus ba723d36c9 Sim: Don't generate .model line when there's no instance param overrides 2022-09-14 03:16:53 +02:00
aris-kimi 7cc14100fe Modify some sizers in Preferences, Symbol Editor 
Display and Editing Options

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11721
 2022-09-13 22:05:32 +03:00
Jeff Young ef05069ebc ADDED 2 new vars: EXCLUDE_FROM_BOM and EXCLUDE_FROM_BOARD. 2022-09-13 13:47:24 +01:00
Jeff Young d3d5d0f46e Distinguish between user added fields and those found in symbols. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11511

Fixes https://gitlab.com/kicad/code/kicad/issues/8999
 2022-09-12 23:39:33 +01:00
Seth Hillbrand 60374daa49 Fix ERC global label unit tests 
Need to test all units in the subgraph as there are chances that the
subgraph might have more than one label, which needs to be consistently
handled
 2022-09-12 13:16:45 -07:00
Mike Williams 9cda5e200c Hotkeys: Swap on Shift S and revert old actions back to S 2022-09-12 14:18:54 -04:00
Mike Williams 37d2addf0e Icons: add swap 2022-09-12 11:11:49 -04:00
Mike Williams f70e1d0f22 SCH/PCB: Set Swap hotkey to 'S' 
* Move Add Sheet to Shift+S in Schematic Editor
* Move Set Grid Origin to Shift+S in PCB Editor
 2022-09-12 11:11:49 -04:00
Mike Williams 926f979ebc Schematic: Add swap action 2022-09-12 11:11:49 -04:00
Mikolaj Wielgus 0e0d1a34f5 Sim: Spice grammar fixes 
- Fix parsing .model lines with model names containingnon-alphanumeric
  characters like - and _,
- Fix parsing libraries in which EOF is not preceded by a newline.

Fixes https://gitlab.com/kicad/code/kicad/issues/12394
 2022-09-12 04:05:17 +02:00
Jeff Young 45fb0107a0 Copy field properly. 
Offset for new parent, and set parent property.

Fixes https://gitlab.com/kicad/code/kicad/issues/12376
 2022-09-11 23:16:34 +01:00
Jeff Young fb48bef49f Formatting. 2022-09-11 23:13:37 +01:00
Jeff Young 536561f7b3 Move bus aliases to std::set. 
This is mostly to output the aliases sorted (for ease of VCS integration),
but also because a btree will be faster than hashing on a small dataset.

Fixes https://gitlab.com/kicad/code/kicad/issues/11890
 2022-09-11 19:48:08 +01:00
Mikolaj Wielgus e56635a02b Sim: Add mutual inductor model 2022-09-11 19:23:01 +02:00
Jon Evans 371985b3e2 Autoplace fields if enabled after changing symbol 2022-09-11 10:11:25 -04:00
Mikolaj Wielgus 91358dfcac Sim Model Editor: Fix Enable/Disable of parameters 
Only SIM_STRING_PROPERTY-based parameters were updated.
 2022-09-11 15:24:16 +02:00
WhiteChairFromIkea 50716ed8f2 Simplify "Remove fields" 2022-09-11 12:28:53 +00:00
Jeff Young 5d468ca759 Use MESSAGE_TYPE::OUTDATED_SAVE for read-only infobar messages as well. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12252
 2022-09-10 21:27:10 +01:00
Jeff Young eb70934457 Fix type in SelectConnection. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12341
 2022-09-10 20:56:35 +01:00
Jeff Young bb0bd29715 Improve tooltips. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10843
 2022-09-10 19:04:38 +01:00
Jeff Young 83615de81f Move FILL_WITH_COLOR from background to device layer. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12393
 2022-09-10 10:27:49 +01:00
Jeff Young fdc00ed22d Fix uninitialized variable. 2022-09-10 10:25:52 +01:00
Jeff Young bcaca947b9 Don't display busy cursor over remap symbols dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11648
 2022-09-10 09:31:27 +01:00
Jeff Young f87bf3c46d Special case up-key so it can get past headers in paged dialogs. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10078
 2022-09-10 09:31:27 +01:00
Mikolaj Wielgus 1b7ff376b0 Sim: Simplify generated .model cards 
One parameter per line instead of wrapping after a certain line width.
Consistent with the formatting in the recently added generation of
.subckt cards from the schematic.
 2022-09-10 02:45:48 +02:00
Seth Hillbrand 05cdf915d0 Show ERC errors when any label only has 1 pin 
To be connected, the label must have at least two pins on a subgraph
(or, in the case of a hierarchical label, two pins somewhere in its
connection)

Fixes https://gitlab.com/kicad/code/kicad/issues/7203
 2022-09-09 17:21:57 -07:00
Seth Hillbrand 16479277cc Catch connection errors when stacked pins have NC flags 
Don't flag the error as having a connected net with an NC flag.  Stacked
pins are not connected in that sense, so are allowed an NC flag
 2022-09-09 17:21:57 -07:00
Seth Hillbrand f2e3329617 Add ERC QA tests 2022-09-09 17:21:57 -07:00
Seth Hillbrand 09ef7c8f1e Add RPT_SEVERITY_DEBUG for developer-type messages 
Move a bunch of importer messages out of the user-visible space as they
are not information that the average user can act on.
 2022-09-09 17:21:47 -07:00
Jeff Young 59f546ced0 Allow recursion up the sheet hierarchy for text variable resolution. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11953
 2022-09-10 00:04:20 +01:00
Mikolaj Wielgus 4f5998ee6b Spice Model Exporter: Export port directions as comments 
Also fix missing subcircuit name.

Fixes https://gitlab.com/kicad/code/kicad/issues/11813
 2022-09-09 23:49:17 +02:00
jean-pierre charras aeb7447102 Fix a compil issue on wxWidgets version < 3.1.6 
wxSpinCtrl::SetIncrement() exists only in version >= 3.1.6
 2022-09-09 20:14:38 +02:00
Wayne Stambaugh 26e7261b20 Eeschema: fix schematic symbol library cache refresh bug. 
Please note that this changes the LIB_PIN object name comparison from case
insensitive to case sensitive.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/12342
 2022-09-09 13:30:34 -04:00
Jeff Young b2a29e08a4 Improve repeat-last-item to handle unfold-from-bus. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12018
 2022-09-09 18:09:09 +01:00
Jeff Young 4973816f90 Fix errant format specifier. 2022-09-09 18:09:09 +01:00
Jeff Young 6507a4165e Work around odd issue with wxWidgets initializing control wrong. 2022-09-09 18:09:09 +01:00
Mikolaj Wielgus 0184875d26 Commit missing files 2022-09-09 18:14:33 +02:00
Mikolaj Wielgus 300a1c4144 Add a new schematic exporter to Spice .subckt model 
An option to use the current sheet as root is added to both the original
and new (.subckt model) exporters.
 2022-09-09 16:18:48 +02:00
Jeff Young f2abf0832a Filter pins by unit. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12076
 2022-09-09 13:41:13 +01:00
Jeff Young f179754118 Implement add-new-on-return for some of our grids. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12335
 2022-09-09 13:41:13 +01:00
Jeff Young d030f03844 Don't allow a SaveAs to overwrite the root sheet. 
Also prevents EESchema from loading sheets which recurse.

Fixes https://gitlab.com/kicad/code/kicad/issues/10872
 2022-09-08 23:43:07 +01:00
WhiteChairFromIkea 758ba5ab18 Altium sch: Import circle-like ellipses as circles for now 2022-09-08 16:55:32 +00:00
jean-pierre charras 2033d9a6c5 SCH_LABEL_BASE::ResolveTextVar(): Protect against null pointer 
It can happen in QA tests.
 2022-09-08 17:12:32 +02:00
Jeff Young 9bed145475 Allow the current sheet a chance to resolve text variables. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8692
 2022-09-08 14:10:18 +01:00
Marek Roszko 9f522e1343 Forgot to actually change the fmt specifiers... 2022-09-08 07:17:58 -04:00
WhiteChairFromIkea 77046e9506 Add "Open file after plot" to Plot dialog 2022-09-08 11:11:20 +00:00
Marek Roszko 5b96736059 LOCALE_IO is expensive to hammer, use fmt 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12377
 2022-09-08 07:04:45 -04:00
Jeff Young 6f5281258e Separate text-thickness clamping into strict and lenient modes. 
We used to use the bold setting, but since PCBNew allows you to
directly define the width you end up with settings in between normal
and bold that get clamped to the normal max.

Fixes https://gitlab.com/kicad/code/kicad/issues/12367
 2022-09-08 00:28:30 +01:00
Jeff Young b874aaac5e Add display options to Symbol Browser toolbar. 
Particularly important on Mac where the menubar is disabled when the
frame is used in modal mode.

Also adds a display control to override the symbol's show pin numbers
setting.

Fixes https://gitlab.com/kicad/code/kicad/issues/7789
 2022-09-08 00:28:30 +01:00
Jeff Young f4de7bfc48 Improve dialog layout. 2022-09-08 00:28:30 +01:00
jean-pierre charras 8b96e6fa44 orcadpcb2 netlist export: fix an issue with duplicated pins in multi-unit symbols. 
Due to some changes in code, pins common to units were written more than once.
 2022-09-07 17:13:04 +02:00
Alex d67c81a657 When deselecting items, pick only selected ones. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10292
 2022-09-06 19:44:29 +00:00
Jeff Young b80824951e Clean up some of the PDF hypertext stuff, and add opening HTTP[S] urls. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12153
 2022-09-06 13:59:52 +01:00
Jeff Young 59dc6c8e45 Add wire and bus popups for PDF export. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12157
 2022-09-06 13:59:52 +01:00
Jeff Young 8afc1db7a6 Property popups for symbols, labels, sheets, and footprints in PDF. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5521
 2022-09-06 13:59:52 +01:00
Jeff Young c337c12410 Don't double-flip justification. (The transform already flips it.) 
Fixes https://gitlab.com/kicad/code/kicad/issues/11673
 2022-09-06 13:59:52 +01:00
Jeff Young 9e8e241924 Fix some missing swatch background colours in EEschema dialogs. 2022-09-06 13:59:52 +01:00
jean-pierre charras 3e257794c0 Legacy symbol library reader: fix incorrect arc angle in some symbols. 
Fixes #12346
https://gitlab.com/kicad/code/kicad/issues/12346
 2022-09-06 08:29:38 +02:00