haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
33,672 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

8430 Commits

Author SHA1 Message Date
Jeff Young 70aec5d576 Don't drag both ends after Break Wire. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11915
 2022-07-08 23:03:41 -06:00
Jeff Young 0953395c87 LIB_SHAPE slightly abuses SHAPE_POLY_SET by using it for line chains. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11956
 2022-07-08 21:35:40 -06:00
Jeff Young ded611aed5 Patch annoying large checkbox cols in wxWidgets 3.1.x on OSX. 2022-07-08 17:27:05 -06:00
Jeff Young 5479514819 Honour m_resolveTextVars flag for properties as well as fields. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11937
 2022-07-08 17:27:05 -06:00
Jeff Young a16fc5b537 Go back to native headers for Symbol Fields dialog. 
Some of the drag issues are fixed in wxWidgets 3.1.x, and the balance
of problems now favours native.

Fixes https://gitlab.com/kicad/code/kicad/issues/9771

Fixes https://gitlab.com/kicad/code/kicad/issues/11835

Fixes https://gitlab.com/kicad/code/kicad/issues/11836
 2022-07-08 17:27:05 -06:00
Jeff Young fe1bff7d29 Remove empty infobar message. 
I'm not sure what this was for, but it seems like a bad idea and I
got a few crashes near here.
 2022-07-08 17:27:05 -06:00
Jeff Young 62cef3d830 Add LAYER_PRIVATE_NOTES for private text & graphics in symbol editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11957
 2022-07-08 17:27:05 -06:00
jean-pierre charras f47a4ec92a Eeschema: fix typo in commit 428bbc2 that make it not working. 2022-07-08 09:48:34 +02:00
Seth Hillbrand 428bbc201b Ensure last column of csv export has terminator 
Last shown column can be different from the last exported column

Fixes https://gitlab.com/kicad/code/kicad/issues/11981
 2022-07-07 11:23:18 -07:00
Seth Hillbrand 6fef054c51 Handle basic rounding error in schematic import 
The fractional part of Altium schematic units is an integer number of
1/10000 mil segments, which is 2.54 nm.  The internal unit of eeschema
is 10 nm, so each fractional unit in Altium is 0.254 base eeschema
units.  To be consistent with
cf33cfcad1
we round to the nearest 10nm for each element

Fixes https://gitlab.com/kicad/code/kicad/issues/11742
 2022-07-07 11:13:11 -07:00
jean-pierre charras 4db72f2d55 Fix minor compil and Coverity warnings. 2022-07-07 12:38:34 +02:00
jean-pierre charras 7b28804f67 Fix a minor compil and Coverity warning 2022-07-06 13:54:17 +02:00
Seth Hillbrand ff54b8c718 Overplot schematic symbol fields and pins 
In the absence of z-ordering, we need to ensure that pin text and symbol
fields are always visible in plots as they are in the schematic window.
We do this by overplotting the fields/pins when symbols overlap each
other.

This can be removed if/when we implement https://gitlab.com/kicad/code/kicad/-/issues/2211

Fixes https://gitlab.com/kicad/code/kicad/issues/11969
 2022-07-05 16:39:53 -07:00
Miklos Marton d30af7c164 eeschema: Add automatic rotate feature for placing global and 
hierarchial labels
 2022-07-05 17:02:45 +00:00
Seth Hillbrand cde30d3dba Clarify cross-probing options 
Previous the cross-probing options were mixed between sending and
receiving cross-probe events.  This clarifies so that all of the pcbnew
cross-probe options deal with whether the cross-probe is seen in pcbnew
and all of the eeschema options deal with seeing the event in eeschema.

Also updates the wording in the options panels to be the same where
possible and adds tooltips

Fixes https://gitlab.com/kicad/code/kicad/issues/11454
 2022-07-01 16:47:09 -07:00
Seth Hillbrand 939313088e Units are stored in the instance data 
At the moment, units are stored in the instance data, so when loading
the file, all symbols will have bbox for the first unit.  After calling
`UpdateUnit()`, we need to recache the rtree bounding boxes to get
correct hit tests

Fixes https://gitlab.com/kicad/code/kicad/issues/11681
 2022-06-30 14:59:17 -07:00
Marek Roszko 9b0531db54 Drop xsl/xslt files 
Users may still use xsltproc with kicad as the invocation of third party tools remains.
We simply are not maintaining these xsl sample scripts anymore nor bundling xsltproc.

Fix https://gitlab.com/kicad/code/kicad/-/issues/9074
 2022-06-29 21:22:34 -04:00
Mike Williams 66b3b48e93 Library Editor: Fix missing automatic annotation 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11818
 2022-06-29 14:17:21 +00:00
Jeff Young dbbdc9d2e6 Don't rely on the penWidth already being set when setting the dash style. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11908
 2022-06-29 07:34:45 -06:00
Jeff Young 4a8aaefdc0 Implement line style printing for LIB_SHAPE. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11883
 2022-06-29 07:34:45 -06:00
Seth Hillbrand 66d3bf2bc2 Refresh draw objects when common settings change 
Common settings may change colors so make sure that we refresh the draw
objects when the settings change to draw them in the proper colors.
Failing to do this may also cause left over lines on the screen
depending on OpenGL drivers

Fixes https://gitlab.com/kicad/code/kicad/issues/11921

(cherry picked from commit 8aabdcff9c)
 2022-06-28 16:46:19 -07:00
Seth Hillbrand 6a8519dfd9 Fix ERC error missing on stacked pins 
Stacked pins are not connected, so they should be flagged as such.  This
checks for stacked pins that are not part of different symbols

Fixes https://gitlab.com/kicad/code/kicad/issues/11926

(cherry picked from commit 90ef84b958)
 2022-06-28 15:04:14 -07:00
Wayne Stambaugh 4e7b5b9784 Eeschema: fix project rescue bug. 
When a rescue library already existed, the disabled writing of legacy
symbol library table entries prevented the rescue library from being
updated.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11897
 2022-06-28 15:05:06 -04:00
Mike Williams 252afe41f3 Schematic: remove old, invalid angle choice from editing options 2022-06-28 16:29:14 +00:00
Jeff Young 83a2f43661 Apply DRC fixes to ERC. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11844
 2022-06-27 21:07:03 -06:00
Jeff Young d5a6452934 Get rid of special default line style for Eeschema. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11882
 2022-06-27 19:12:45 -06:00
Jeff Young d9cfbc7b96 Fix missing SCH_LABEL case in SCH_PLUGIN. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11913
 2022-06-27 16:21:32 -06:00
Jeff Young 14886e426b Move prior fix from SCH_GLOBAL_LABEL to SCH_LABEL_BASE. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11768
 2022-06-26 20:55:25 -06:00
Seth Hillbrand 03c279ffd4 ADDED: Threadpool 
Thread pools are long-lasting executors that have close to zero overhead
when launching new jobs.  This is advantageous over creating new threads
as we can use this for threading smalling jobs and smaller quanta.  It
also avoids the heuristics needed to determine the optimal number of
threads to spawn
 2022-06-24 22:59:24 +00:00
jean-pierre charras de45e2b1fd Textbox in symbols: fix incorrect position of the box when printing. 
Fixes #11884
https://gitlab.com/kicad/code/kicad/issues/11884
 2022-06-24 17:08:29 +02:00
jean-pierre charras 554b31bb2a eeschema: fix crash when changing the GAL engine, especially if the grid is shown. 
GetGAL()->DrawGrid() was called when switching the engine, outside a paint event,
thus creating a crash (at least on Windows) probably because the new Gal stuff was
not fully initialized.
 2022-06-24 15:49:28 +02:00
Seth Hillbrand 7b9dc1b9f0 Fix Eeschema Arc plotting 
The start/end point plotting is not reliable for eeschema.  We need to
preconvert to angles to get the correct winding as the default plotter
conversion in the PLOTTER class makes pcbnew-based assumptions

Fixes https://gitlab.com/kicad/code/kicad/issues/11885
 2022-06-22 16:46:28 -07:00
Ian McInerney b51d8c9825 Introduce new CMake variable to store kiface install location 2022-06-22 23:40:25 +01:00
jean-pierre charras 82b2df67be Add 2 automatically generated files to the source tree. 
These files are needed by translators, so it is better to add them to the source
without need to build kicad.
 2022-06-22 08:51:04 +02:00
Seth Hillbrand a852286eb5 Cleanup compile warnings 2022-06-21 17:04:56 -07:00
Miklós Márton f2382a7bd1 Add Make selected active/inactive actions to the symbol libraries 
context menu

Fixes #11372
 2022-06-21 23:32:02 +00:00
Seth Hillbrand aeef5b00a8 Unify symbol browser/editor unit display 
Fixes https://gitlab.com/kicad/code/kicad/issues/11881
 2022-06-21 16:22:54 -07:00
Jeff Young 494d79423e Fix typo. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11809
 2022-06-19 20:56:22 +01:00
Jeff Young 45ab15dc95 Use unit references in status bar. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11854
 2022-06-19 12:54:30 +01:00
jean-pierre charras 50b68df666 Eeschema, SCH_PIN: fix incorrect initialization of m_layer member (now is LAYER_PIN) 
m_layer was not re-initialized in CTOR, so it was the default value (LAYER_WIRE)
This is incorrect for a pin, and can create errors in some functions (like IsType() )
Fixes #1818
https://gitlab.com/kicad/code/kicad/issues/1818
 2022-06-17 11:01:49 +02:00
Jeff Young 34e706bcbc Border colours and line styles for symbol editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11810
 2022-06-16 14:52:38 +01:00
jean-pierre charras c79dd09464 PANEL_SYM_LIB_TABLE: fix a bug in filenames from wxFileDialog dialog. 
We want the full path, so use GetPaths.
GetFilenames sometimes return the full path in wxWidgets 3.1.7, not always the filename
Fixes #11821
https://gitlab.com/kicad/code/kicad/issues/11821
 2022-06-16 13:04:27 +02:00
Roberto Fernandez Bautista 8725c3a35f CADSTAR Schematic: Load symbols even if part definition is incomplete 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11671
 2022-06-15 19:47:50 +01:00
jean-pierre charras 631eecd7d6 symbol_checker: better message about reference prefix. 2022-06-15 18:37:27 +02:00
Jeff Young 2c280e83c3 Handle junctions in MarkConnections. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8579
 2022-06-15 16:28:33 +01:00
jean-pierre charras b56917210d symbol_checker: add test for valid reference prefix. 2022-06-14 20:45:26 +02:00
jean-pierre charras 1140fd0fb0 Eeschema, context menus: move edit value, ref and footprint to a submenu. 
remove also Select All menuitem from the move context menu.
 2022-06-13 11:35:17 +02:00
Jeff Young 52bc2511cd Add a radioButton mode to IMAGE_BUTTON. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11797
 2022-06-12 20:09:46 +01:00
Jeff Young c6604e3576 Labels can connect directly to symbols, other labels, etc. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11768
 2022-06-12 18:15:58 +01:00
Jeff Young 69c1f88e53 Update symbol instances after sheet rename. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11782
 2022-06-12 15:46:37 +01:00
Marek Roszko 08dbc3a53c Move the symbol editor to the new filedlg customize 2022-06-11 22:59:59 -04:00
Marek Roszko ff94d289c7 Move the eeschema standalone to the new save dialog 2022-06-11 22:06:42 -04:00
Jeff Young a0421b172a Add missing color swatch to Symbol Editor Text Properties. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11791
 2022-06-11 22:14:14 +01:00
Jeff Young e4798199c6 Handle alt pins in plot code. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11728
 2022-06-10 22:38:01 +01:00
Jeff Young 29900cad34 Add create-wire logic to labels. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11768
 2022-06-10 22:38:01 +01:00
jean-pierre charras e0f0bb2edd Eeschema: Fix issues when converting a label/text to another label text type. 
- make convert to/from SCH_DIRECTIVE_LABEL working.
- Autoplace fields of new labels
Fixes #11779
https://gitlab.com/kicad/code/kicad/issues/11779
 2022-06-10 14:13:22 +02:00
jean-pierre charras b712c2c0da Eeschema: fixes about Hierarchy panel/pane handling 2022-06-09 19:43:09 +02:00
Jeff Young bce1fd337b Second tool hotkey accepts action (ie: acts as click). 
Fixes https://gitlab.com/kicad/code/kicad/issues/11729
 2022-06-09 16:54:04 +01:00
jean-pierre charras 35bde4710c Eeschema, context menu selection: move convert to ... menuitems to a submenu. 
Add also missing icons in a few menuitems.
Fixes #11776
https://gitlab.com/kicad/code/kicad/issues/11776
 2022-06-09 16:46:21 +02:00
jean-pierre charras ef2e51b493 Eeschema: code refactor and fix missing save project setting when closing the sch editor. 2022-06-09 13:39:09 +02:00
Jeff Young 6bfd106bed Add missing text colour to symbol editor textbox dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11770
 2022-06-09 10:37:23 +01:00
Jeff Young b710982875 Fix broken logic for hidden pins. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11771
 2022-06-09 10:37:23 +01:00
Jeff Young 6e50a3518f Fix typo. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11769
 2022-06-08 23:53:18 +01:00
Jeff Young ec40a98fe2 wxT 2022-06-08 23:53:18 +01:00
jean-pierre charras b401e98c80 Eeschema, hierarchy navigator: fixes and enhancements. 
Work in progress.
 2022-06-08 18:23:03 +02:00
Jeff Young 46fd32b738 Update grid attributes after sorting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11753
 2022-06-08 15:25:13 +01:00
Jeff Young 34932e097c Minor dialog cleanup. 2022-06-08 15:25:13 +01:00
Jeff Young c55a0e4561 Separate last-created-params for textboxes from shapes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11755
 2022-06-08 15:25:13 +01:00
jean-pierre charras 185016b84b Eeschema, Hierarchy navigator: add tool to Hide/show the panel. 
Add also a close button to the pane.
 2022-06-07 11:11:10 +02:00
Jeff Young 244042ce51 Keep footprint selection in Symbol Chooser history list. 
Fixes https://gitlab.com/kicad/code/kicad/issues/1841
 2022-06-06 22:24:02 +01:00
Wayne Stambaugh dfea73f78c Eeschema: fix symbol library remap bug. 
The original decision to escape the legacy symbol library names results
in them being escaped every time they are opened which cause the curly
braces '}' from the original escaping to be escaped on subsequent
openings.  This resulted in the symbol library names in the rescue
library not matching the library ID in the schematic.

This fix is likely to have other corner case bugs given the potential
for escaped characters in legacy symbol libraries.  Given that we now
have escaped rescue libraries in play, removing the escaping will only
result in more issues so we will have to fix the corner cases as we go.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11563
 2022-06-05 17:00:57 -04:00
jean-pierre charras 9f38fa43cd Fix some minor compil and Coverity warnings. 2022-06-05 11:44:49 +02:00
Jeff Young 31316760f6 Separate power and symbol saved search strings. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11747
 2022-06-04 22:15:39 +01:00
Jeff Young 718bb461d2 Textbox defaults for libedit. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11739
 2022-06-04 21:25:37 +01:00
Roberto Fernandez Bautista ecbf5c1e14 Don't display unit in single unit symbols of annotation error message 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11748
 2022-06-04 16:04:33 +02:00
Jeff Young 099061f46d Process nested formatting within a variable cross-reference. 2022-06-04 00:34:14 +01:00
Roberto Fernandez Bautista 78e465bbd8 Fix crash in sch_navigate_tool when history was empty 2022-06-03 23:07:12 +02:00
Jeff Young ce79a16ed8 Use default schematic text size for textboxes. 
Also adds support for remembering stroke info, fill info, and
spin style for sch text boxes.

Fixes https://gitlab.com/kicad/code/kicad/issues/11739
 2022-06-03 21:48:12 +01:00
Seth Hillbrand 407514919d Prevent null dereference 2022-06-03 10:05:55 -07:00
Mike Williams 8d51b6b6d3 Schematic: Add icons for Any/90/45 angle modes 
Also add a dark mode icon for existing 45hv icon.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11332
 2022-06-03 15:04:52 +00:00
Mike Williams 857990a883 Hierarchy: turn into a left side pane 
Drop auto-closing option as well.
 2022-06-02 21:56:17 +00:00
Jeff Young aaff163d7c Repair Eagle importer page number handling. 
The root sheet needs a page number, and the other sheets need to not
have their last step in the path duplicated.

Fixes https://gitlab.com/kicad/code/kicad/issues/11409
 2022-05-31 17:48:38 +01:00
Jeff Young abba1b04bd Add "Enter Sheet" to Sheet tool (context menu & double-click). 
Fixes https://gitlab.com/kicad/code/kicad/issues/11531
 2022-05-30 14:08:26 +01:00
jean-pierre charras 2701642b1b minor fixes and French translation update 2022-05-30 11:23:20 +02:00
Jeff Young d5d8d36d86 Implement expanding Select Connection. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8579
 2022-05-29 22:51:33 +01:00
Eduardo Behr f246646d7a Fix severe simulation memory leaks 2022-05-28 20:40:24 +00:00
Mike Williams f2cf934083 Schematic: Annotation Tweaks 
Fix newly placed symbols to be annotated and not show a ? until
placement.
 2022-05-27 15:54:00 +00:00
Mike Williams efa23a5cbe Schematic: better automatic/recursive annotate 2022-05-27 15:54:00 +00:00
Mike Williams 7f3e5e9b79 Schematic: add recursive annotation control 2022-05-27 15:54:00 +00:00
Mike Williams 85516a4691 Schematic: add automatic annotation toggle 2022-05-27 15:54:00 +00:00
Mike Williams dabd42bbc4 Schematic: Automatic Symbol Annotation 2022-05-27 15:54:00 +00:00
Jeff Young 6114a5d72c Escape pin names when used as netnames. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11687
 2022-05-26 23:54:55 +01:00
Jeff Young cb15bd1635 Fix compile issue. 2022-05-26 10:54:54 +01:00
Jeff Young 616e9b4f4b Be cognizant of symbol transform when setting justification. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11465
 2022-05-26 10:54:08 +01:00
Roberto Fernandez Bautista 55f22c526a Fix annotation of incomplete multi-unit symbols and re-annotation of duplicates 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11496
 2022-05-26 09:23:36 +00:00
Seth Hillbrand 11ae5b75b7 Remove broken assert 
Fixes compile issue for linux/gcc which expects a boolean in the assert
statement that it cannot find from std::map
 2022-05-25 16:36:47 -07:00
Eduardo Behr 6aa50304d9 Eeschema: Fixing simulation plot CSV exporter 2022-05-25 15:00:03 +00:00
Miklós Márton 487c8f8e39 symbol editor: Improve pin duplication 
When duplicating pins in the symbol editor the duplicated pins will have
unique pin numbers assigned if the duplication target had the pin number
specified
 2022-05-25 00:02:16 +00:00
Fabien Corona 0536ab4f6c Remove kicad_pair in transmission lines 
This was a misread from the ngspice doc
 2022-05-25 00:00:07 +00:00
jean-pierre charras eae5e9f00e Symbol checker: fix incorrect test for duplicate pins. 
Fixes #11660
https://gitlab.com/kicad/code/kicad/issues/11660
 2022-05-23 11:20:12 +02:00
Roberto Fernandez Bautista ea29c66608 Fix formatting 2022-05-22 07:14:24 +00:00
Chetan Shinde 4e5febdb19 Fixes the import pin issue, that the they are shown in two different way https://gitlab.com/kicad/code/kicad/-/issues/11391 2022-05-22 04:42:22 +00:00
Jeff Young 8e94c307d2 Provide default case for mirroring single objects. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11649
 2022-05-21 22:50:55 +01:00
Jeff Young d381fd8b29 Typo. 
LIB_SYMBOL's value field is the name; SCH_SYMBOL's value field is not.

Fixes https://gitlab.com/kicad/code/kicad/issues/11556
 2022-05-20 18:01:01 +01:00
Jeff Young 23fb4c7433 Uniformly use a single facility for location-less prime events. 
Also implements a uniform mechanism for avoiding auto-scroll after
a prime event or dialog which results in a mouse position at the
edge of the canvas.

Fixes https://gitlab.com/kicad/code/kicad/issues/11057
 2022-05-16 23:43:00 +01:00
Jeff Young f2fc78f380 Don't copy modifiers to prime events. 
The modifiers go with the hotkey, not with the action.

Fixes https://gitlab.com/kicad/code/kicad/issues/11618
 2022-05-16 13:51:40 +01:00
jean-pierre charras 359c99991b Eeschema: do not leave a temporary flag set after use in draw symbol function. 
Fixes #11617
https://gitlab.com/kicad/code/kicad/issues/11617
 2022-05-15 18:35:07 +02:00
Roberto Fernandez Bautista 9049c907a1 Fix wxWidgets assert in symbol preview widgets 2022-05-15 15:26:53 +01:00
Jeff Young 79a0ce9137 Unset forced cursor before leaving two-click place. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11607
 2022-05-14 22:38:54 +01:00
Jeff Young 38e5faf21b Overhaul bitmap text for performance. 
Also adjusts metrics to better match stroke font.

Also removes text-halo highlighting as it's too expensive to re-render
when the zoom changes.

Fixes https://gitlab.com/kicad/code/kicad/issues/11460
 2022-05-14 20:09:54 +01:00
Jonathan Haas 5802ede3fd Change default value of MatchByReference to false. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11382
 2022-05-14 12:41:25 +00:00
Marek Roszko 88c7322a0d EDA_TEXT Get/SetTextSize should use VECTOR2I 2022-05-14 08:16:15 -04:00
jean-pierre charras 45b167dff5 Some fixes related to translated/not translated mandatory field names. DIALOG_SYMBOL_FIELDS_TABLE: add new fields to symbols only if the field is not empty. 2022-05-13 11:45:38 +02:00
jean-pierre charras 20d1d0705e Fix a few issues related to field names and their translation. - Do not use translated field names outside strings displayed in dialogs. - fix code that does not work well with default locale. - fix some (not all) I18n issues in DIALOG_UPDATE_SYMBOL_FIELDS. 2022-05-13 11:45:37 +02:00
Seth Hillbrand bbc250720f Resolve title variable when plotting 
Be sure to use variable name if it exists when plotting the file

Fixes https://gitlab.com/kicad/code/kicad/issues/11608

(cherry picked from commit d971cbefcb)
 2022-05-12 15:31:15 -07:00
jean-pierre charras b68514afb1 Fix a wxWidgets alert. 2022-05-12 20:58:48 +02:00
Marek Roszko 5c4f49351d Remove extra compilation of common.cpp 
It's already built in the common target, no eeschema specific code
 2022-05-10 21:31:31 -04:00
Marek Roszko f85251ef75 Fix eda_doc not looking for schematic locally 
It looks like this was overlooked by Jeff in 2020 not realizing eda_doc isn't built under eeschema but common in cc9ac37a0e
 2022-05-10 21:28:48 -04:00
dsa-t ad066ef09a Fix cross-probing in complex hierarchies, remove unused code. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11493
 2022-05-09 23:22:03 +03:00
jean-pierre charras 4bd349d922 Update some demos 2022-05-09 19:06:14 +02:00
Mike Williams b7a77a9498 Schematic: Add CSV export to Symbol Fields Table 2022-05-09 12:02:12 -04:00
Jeff Young 8f937b17a2 Remove wxWidgets 3.0.x hack. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11540
 2022-05-07 23:24:55 +01:00
Jeff Young f9f0f6fe24 Implement cross-references for labels. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11564
 2022-05-07 21:10:04 +01:00
Seth Hillbrand 5cd3c07862 Catch throws in DeleteSymbol 
DeleteSymbol may call SaveSymbol if the name is changed.  In this case,
SaveSymbol may throw back and needs to be caught

Fixes https://gitlab.com/kicad/code/kicad/issues/11566

(cherry picked from commit e05c8f8852)
 2022-05-06 16:13:59 -07:00
Miklós Márton 7e20c0ed9c eeschema: removed unused code 
Fixes #11533
 2022-05-06 17:17:55 +00:00
Jeff Young a644aad1cf Hand-code tab navigation from value field of Label Properties dialog. 
wxWidgets doesn't appear to handle it correctly, doing nothing on OSX
and potentially crashing on GTK.

Fixes https://gitlab.com/kicad/code/kicad/issues/11572
 2022-05-06 18:14:25 +01:00
Seth Hillbrand 5f7ac58f95 Catch errors when saving individual symbols 
Fixes https://gitlab.com/kicad/code/kicad/issues/11566

(cherry picked from commit f4d4f23876)
 2022-05-06 09:55:28 -07:00
Wayne Stambaugh a19490b097 Eeschema: fix broken project symbol rescue. 
The legacy symbol library plugin code was changed to escape symbol names
which broke the LIB_ID string comparison when checking to see if symbols
needed to be rescued.  Escaping the LIB_ID names before comparison resolves
the issue.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11563
 2022-05-06 08:50:09 -04:00
jean-pierre charras 32077673e8 Symbol editor crash: Fix use of a null pointer. 
LIB_TEXT::Clone() did not copy a member set to nullptr.
Fixes #11569
https://gitlab.com/kicad/code/kicad/issues/11569
 2022-05-06 12:51:26 +02:00
Jeff Young 1751c8e1cf Save selection *before* clearing it. Saving after doesn't do much good. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11242
 2022-05-06 00:06:00 +01:00
Jeff Young 9c5aa5c3c1 Font and color for FIELDS_GRID_TABLE. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11459
 2022-05-06 00:06:00 +01:00
Jeff Young e80c5a4e4e Add text colour to Edit Text & Graphics Properties. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11459
 2022-05-06 00:06:00 +01:00
Simon Richter bd7447cff3 Fix variable name 
This is the top left position, not the top right.
 2022-05-05 10:27:19 +00:00
Jeff Young f14dc9e305 Don't plot private symbol text. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11548
 2022-05-03 19:41:20 +01:00
Jeff Young babfb29c54 Formatting cleanup. 2022-05-03 13:39:14 +01:00
Jeff Young 67f352717e Fix dodgy type-cast and init line-widths to "inherit". 
Fixes https://gitlab.com/kicad/code/kicad/issues/11535
 2022-05-03 13:39:14 +01:00
jean-pierre charras 3f470359a2 Eeschema, backannotate: fix minor issues in displayed messages. 
Fixes #11530
https://gitlab.com/kicad/code/kicad/issues/11530
 2022-05-03 09:20:46 +02:00
Seth Hillbrand a56955443f Fix botched commit 
(cherry picked from commit ba276fe470)
 2022-05-02 16:29:07 -07:00
Seth Hillbrand 2079d15b3f Catch IO_ERRORs that we throw 
FILEOUTPUT_FORMATTER likes to throw when it gets an issue.  We need to
catch this to avoid the app falling apart

Fixes https://gitlab.com/kicad/code/kicad/issues/11516

(cherry picked from commit 4d47857738)
 2022-05-02 15:15:52 -07:00
Jeff Young f6f316bd8c Promote field selection to field-owner for Autoplace. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11529
 2022-05-02 20:11:21 +01:00
Jeff Young d2610736ff Fix bugs with printing bordered shapes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11536
 2022-05-02 19:45:55 +01:00
Jeff Young 585ea85f95 LIB_SHAPE default line style is SOLID, not DASHED. 
(Copy/paste error from SCH_SHAPE.)

Fixes https://gitlab.com/kicad/code/kicad/issues/11527
 2022-05-02 17:22:13 +01:00
Jeff Young 036d283433 Don't muck with linestyle default when setting it. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11520
 2022-05-02 17:22:13 +01:00
Jeff Young 804ab5609e Add dash-dot-dot to Edit Text & Graphics Properties. 
Also fixes a bug where textboxes and shapes  weren't correctly updated.

Fixes https://gitlab.com/kicad/code/kicad/issues/11522
 2022-05-02 17:22:13 +01:00
jean-pierre charras 50223c9337 Eeschema print: Do not print private graphics in symbols. 
Fixes #11532
https://gitlab.com/kicad/code/kicad/issues/11532
 2022-05-02 16:29:08 +02:00
jean-pierre charras ece15b6472 Fix a compil warning (shadowed var). 2022-05-02 15:25:55 +02:00
Jeff Young dfa6b9ed15 Reset plotter dash-style after use. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11527
 2022-05-02 13:21:46 +01:00
jean-pierre charras 40c75c74fa EEschema/Cvpcb: make assign footprints from CvPcb undoable. 
Fixes #11508
https://gitlab.com/kicad/code/kicad/issues/11508
 2022-05-02 12:49:14 +02:00
Jeff Young 772bdc4bbf Turn off auto-dialog for text objects when immediateActions == false. 2022-05-02 11:25:40 +01:00
Jeff Young de0bb26c4c Init global label's intersheet ref's visibility from schematic settings. 2022-05-02 09:42:38 +01:00
Miklós Márton 7ebdb4853c Do not open label edit dialog when adding label to an already named wire 2022-05-02 08:42:15 +00:00
Jeff Young 6d44ca2145 Ellipsize long heirarchical paths. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11499
 2022-04-30 14:09:30 +01:00
Jeff Young 9fbf8e6f5d Respect default layer color for textbox borders. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11497
 2022-04-29 14:10:48 +01:00
Jeff Young dc1e063b00 Iron out some issues with linestyle handling in SCH printing and plotting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11498
 2022-04-29 13:52:30 +01:00
Jeff Young 3589eb33f0 Handle text color when printing and plotting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11491
 2022-04-29 10:51:00 +01:00
Jeff Young 2cccd5b090 Fix minor layout issue in dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11490
 2022-04-27 17:14:33 +01:00
Jeff Young 8a97a46e6b Release file before re-loading it for Revert. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11481
 2022-04-26 22:28:35 +01:00
Jeff Young e0f2a5f07c Update findnext to handle new instance data architecture. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11424
 2022-04-26 20:21:15 +01:00
Jeff Young 47e002a33d Add font to status bar for text objects. 2022-04-26 18:52:53 +01:00
Jeff Young e6f11c5c39 Reset outline font if bold or italic changed. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11462
 2022-04-26 12:52:29 +01:00
Jeff Young 85680886f8 Adjust outline font SCH_TEXT positioning so it better matches SCH_FIELD text. 2022-04-26 12:52:29 +01:00
Seth Hillbrand 25474b347c Fix frustration with mirroring autoplaced fields 
When the user asks to mirror a symbol is is frequently to get the
reference/value on the other side of the symbol for placement purposes.
Autoplacing the fields here keeps the text where they were initially
which can be frustating to work around.

This commit treats the mirror command as a user request to change where
the fields are
 2022-04-25 12:50:45 -07:00
Seth Hillbrand 1a70465927 Use instance data to store values 
Previous use of instance was as an "override" of the default value.
This has changed to be used as the primary storage location for all
values.  This means that we cannot clear the instance data when setting
a new value for all instances, instead we have to change the instance
data and the default value is superfluous

Fixes https://gitlab.com/kicad/code/kicad/issues/11439
 2022-04-25 12:47:48 -07:00
Jeff Young f5d612eaed Switch <insert> replacement on OSX to <f1>. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11413
 2022-04-25 10:01:33 +01:00
Jeff Young 90bfe2d94b Remove Save Copy As from fp editor, and rename to Save a Copy elsewhere. 
It's still used by Eeschema and PCBNew when not in stand-alone mode.

Fixes https://gitlab.com/kicad/code/kicad/issues/9185
 2022-04-24 19:46:57 +01:00
Jeff Young 6738708a7f Disable background color when printing in black & white. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11180
 2022-04-24 19:46:57 +01:00
Jeff Young 52eb210aa8 Initialize virtual page no. to something more reasonable. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11295
 2022-04-24 19:46:57 +01:00
jean-pierre charras 3bc34590c7 Eeschema: fix missing call to UpdateMessagePanel() due to commit e09147db. 
EE_INSPECTION_TOOL::UpdateMessagePanel was called by EVENTS::SelectedEvent
But This event after commit calls E_INSPECTION_TOOL::CrossProbe(),
and no longer UpdateMessagePanel.
So CrossProbe() now calls UpdateMessagePanel.
Fixes #11447
https://gitlab.com/kicad/code/kicad/issues/11447
 2022-04-24 18:40:10 +02:00
Jeff Young c6f83b6dec ADDED Duplicate Footprint, Rename Symbol and Rename Footprint. 2022-04-22 22:06:51 +01:00
Mike Williams b42365190e Schematic/PCB: deleting fields sets them to invisible 2022-04-21 16:20:23 +00:00
Jeff Young eb1a238a53 Remove extra event handler. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11418
 2022-04-20 16:19:42 +01:00
Jeff Young fc2eb2d7c9 Fix missing line keeping tabs from switching. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11417
 2022-04-20 14:51:08 +01:00
Seth Hillbrand aac6f576c2 Fix broken comparison in pin_numbers 
Pin names like "+V" were incorrectly parsed as doubles leading to broken
comparisons.  These caused heap overflows when sorting pin tables

This corrects the comparison so that numeric sorts are only performed
when there is an actual number in the symbol segment.  Also adds unit
tests for common error cases
 2022-04-19 14:46:05 -07:00
Jeff Young 4ab2c93070 Update Selection Filter title bar with language changes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11421
 2022-04-19 21:12:13 +01:00
Jeff Young ffc28f23e5 Repair GetFullRef() and use it when running Symbol Fields Table filtering. 
(Previously GetFullRef() failed to add the number between the prefix letter
and the unit designator.)

Fixes https://gitlab.com/kicad/code/kicad/issues/11419
 2022-04-19 19:55:30 +01:00
Jeff Young 08f15fe587 ADDED New Library functionality to Footprint/Symbol Save As. 
Fixes https://gitlab.com/kicad/code/kicad/issues/2343
 2022-04-19 19:55:30 +01:00
Jeff Young 84f620a96e Minor dialog beautification. 2022-04-19 19:55:30 +01:00
Jeff Young c3bed8f6ee Resolve textvars before opening file browser. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6436
 2022-04-18 22:45:02 +01:00
Jeff Young cc18c31cb5 Fix some layout issues in the Project Template Selector. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5222
 2022-04-18 22:45:02 +01:00
Mike Williams 653baf270c Schematic: drag created / changed segments need junction checks 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10844
 2022-04-18 17:24:02 +00:00
Simon Richter 801c5deb87 Fix minimum size calculation for new hierarchical sheets 
These constants are given in mil, but are used in a context of internal
units.
 2022-04-18 15:01:59 +00:00
Simon Richter 1e505d4c22 Remove a few call sites of SCH_SHEET::SetSize 
This function is dangerous and should be used only by parsers, and not even
those, really.

For new objects, the size can be passed to the constructor.
 2022-04-18 16:23:03 +02:00
Jeff Young 55a8fb39c4 ADDED filtering for Symbol Fields Table dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11224
 2022-04-17 20:02:58 +01:00
Jeff Young 71c2cb3180 ADDED revert for pcbnew and eeschema. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6802
 2022-04-17 20:02:58 +01:00
jean-pierre charras 38c54ffa8f Eeschema, Symbol Library Browser: fix crash when left clicking on the canvas. 2022-04-17 09:54:19 +02:00
Jeff Young e09147db30 Cross-probing for ERC dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11411
 2022-04-17 00:33:56 +01:00
Jeff Young 7f4f5f2882 Save and re-load query string in Choose Symbol dialog. 
While this has been requested on its own, it's primarily done here
because wxWidgets decided to send a SEARCH_CANCEL from a wxSearchCtrl
when hitting <ENTER> if the search control holes the empty string.
This causes us to not do a symbol instert in the Chooser dialog.

Fixes https://gitlab.com/kicad/code/kicad/issues/10169

Fixes https://gitlab.com/kicad/code/kicad/issues/7699
 2022-04-17 00:33:56 +01:00
Seth Hillbrand 250a246761 Clear flags after we're done with them 
The CANDIDATE flag is a temporary element that should not be maintained
outside of the routine in which is it temporarily set

Fixes https://gitlab.com/kicad/code/kicad/issues/11361
 2022-04-16 15:45:17 -07:00
jean-pierre charras 65f7d9f97a EEschema: move symbol checker code in symbol_checker.cpp. 
- Add some tests for Power symbols.
- Fix incorrect print format in some messages.
 2022-04-16 18:56:06 +02:00
Seth Hillbrand ce9bd780d1 Fix crash due to cleared view data 
When changing fields, we need to update the view before allowing canvas
updates

(cherry picked from commit 851f893e8e)
 2022-04-15 15:14:29 -07:00
Jeff Young 4ee6cfe5b6 Disable all use of the default instance reference prefix for annotation. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11385
 2022-04-14 17:55:35 +01:00
Jeff Young 6ef6e37edb Disable using default instance data when writing to clipboard. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11379
 2022-04-14 17:09:27 +01:00
Jeff Young 160240166c Cleanup. 2022-04-14 17:09:27 +01:00
Jeff Young 034b57d9c0 When reannotating keep existing prefix in most cases. 
(Execption is reannotating entire schematic, in which case we reset
all of them.)

Fixes https://gitlab.com/kicad/code/kicad/issues/11379
 2022-04-13 23:38:45 +01:00
Jeff Young 184b67098f Meet user expectations on life-cycle of symbol fields. 
In other words, support empty fields.

Also adds deleting fields to Symbol Fields Table.

Fixes https://gitlab.com/kicad/code/kicad/issues/8999
 2022-04-12 22:11:31 +01:00
Roberto Fernandez Bautista 85f6ff48e7 CADSTAR Sch: Clear symbol of all elements before overwriting with new one 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11378
 2022-04-12 21:34:23 +01:00
Jeff Young 306dfef7e5 Fix typo. 2022-04-12 19:18:15 +01:00
Jeff Young 576f3dc2fd Keep pins aligned to grid when possible. 
This uses the first pin as the anchor point in a mulitple-item
selection.

Fixes https://gitlab.com/kicad/code/kicad/issues/11151
 2022-04-12 18:14:21 +01:00
Marek Roszko f88e0481c8 Change the behavior of ACTION_MENU::Add to require clones if required outside the function 
This reverts commit 2a5769607f.
 2022-04-11 19:03:01 -04:00
Jeff Young 16acba34d3 Don't save schematic symbol back to lib manager. 
Also, since it doesn't get saved, changing symbols will lose any edits.
Make sure to ask the user first.

Fixes https://gitlab.com/kicad/code/kicad/issues/10767
 2022-04-11 22:43:39 +01:00
Seth Hillbrand 2a5769607f Revert "Change the behavior of ACTION_MENU::Add to require clones if required outside the function" 
This reverts commit 403992a6f4.
 2022-04-11 11:39:03 -07:00
Jeff Young 546b3bfbc0 Select wire ends in select all. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10958
 2022-04-11 19:36:54 +01:00
jean-pierre charras f0f10a43a2 Ensure "Clear Recent Files" menuitem titles are updated after language change. 
(missing fixes in commit ac8e2d076)
 2022-04-11 18:11:17 +02:00
Jeff Young 74a578047c Make sure to add any now-necessary junctions after a rotate. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11242
 2022-04-11 12:02:20 +01:00
Jeff Young 8358685920 Dual-purpose IsMovableFromAnchorPoint to keep from moving symbols off-grid. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11360
 2022-04-11 12:02:20 +01:00
jean-pierre charras ac8e2d0768 Ensure "Open Recent" and "Clear files" menu titles are updated after language change. 2022-04-11 11:09:05 +02:00
Marek Roszko 403992a6f4 Change the behavior of ACTION_MENU::Add to require clones if required outside the function 
Fix https://gitlab.com/kicad/code/kicad/-/issues/10994
 2022-04-10 22:38:13 -04:00
Marek Roszko 5bb2cdf73d Revert "Stop leaking submenu items" 
This reverts commit 34c70a51ea.
 2022-04-10 22:33:43 -04:00
Marek Roszko 34c70a51ea Stop leaking submenu items 
Our menu bar code is interestingly complex. But we were throwing away newly made menu items to the void in the cases of constructed on the fly submenus
 2022-04-10 22:04:48 -04:00
Jeff Young 117bd4fc22 Adjust LIB_SYMBOL compare for use with ERC. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10783
 2022-04-09 20:12:29 +01:00
Roberto Fernandez Bautista 0015574a60 ${SHEETNAME} represents the sheet name + introduce ${SHEETPATH} 
CHANGED: The text variable ${SHEETNAME} now always represents the name of the
sheet when used anywhere in the schematic editor, including the title block

ADDED: A new text variable ${SHEETPATH} which is replaced with the path to the
current sheet - e.g. "/Sheet 1/Sheet 2".

To ensure backward compatibility, the default drawing sheet now uses
${SHEETPATH}. Custom drawing sheets will need to be manually edited.
 2022-04-09 15:45:58 +01:00
Wayne Stambaugh 239f0214ac Eeschema: add support for default schematic symbol instance data. 
Prior to fixing the schematic file change churn do to instance data
changing to the last selected sheet instance, the symbol instance data
was set rather than empty.  This change allows for users to set the
default instance data which is used for every new instance of the
schematic.

ADDED: Default schematic symbol instance data (unit and reference, value,
       and footprint fields) can be set to be used as the default settings
       for all new instances of the schematic.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11113
 2022-04-09 07:49:36 -04:00
Jeff Young 007906cd16 Fix a degeneracy bug in arc collisions. 
This also fixes a failure to use the correct effective width for
shapes (which might, for instance, inherit their widths from schematic
defaults, netclasses, etc.).

Fixes https://gitlab.com/kicad/code/kicad/issues/11358
 2022-04-08 16:15:58 +01:00
Seth Hillbrand 702623ef87 Don't flag pin missing driver when there is an NC 
The NC flag indicates user intention to override the lack of connection
to input pins

(cherry picked from commit e02229a234)
 2022-04-07 09:35:23 -07:00
Jeff Young c17b90c8dc Run pinning on sides as well as corners. 
Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the
upside-down coordinate system.

Fixes https://gitlab.com/kicad/code/kicad/issues/11339
 2022-04-07 11:51:58 +01:00
Seth Hillbrand 4b0b4c0ddc Show non-driven error on single-pin nets 
Better to have both the single-pin error message and the non-driven
error message when an input pin is not connected than miss error
messages when the pin is connected to a blank net

Fixes https://gitlab.com/kicad/code/kicad/issues/10430

(cherry picked from commit e740db61f5)
 2022-04-06 16:54:04 -07:00
Jeff Young 356d565d48 Normalize rectangular shapes before feeding to point editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11339
 2022-04-06 18:18:29 +01:00
Jeff Young 67d54ecb4c A bit of dialog layout cleanup. 2022-04-06 16:58:26 +01:00
Jeff Young 06df90636b Rationalize negative line-width handling. 
Make "don't stroke" an explicit property in the GUI.
Silently enforce line width to >= 0 when stroking.
Make layouts between dialogs more consistent.
Interpret unspecified fill colour as layer colour.

Fixes https://gitlab.com/kicad/code/kicad/issues/11279
 2022-04-05 23:59:25 +01:00
Sylwester Kocjan a9c61d21ca eeschema: fix crash when closing simulation frame 
Destructor of SIM_PLOT_FRAME calls sim->Attach( nullptr ) in order to destroy
circuit model (former netlist exporter). If this is skipped, eeschema crashes
when program is closed. nullptr is a valid parameter for Attach()
 2022-04-05 19:28:05 +00:00
Jeff Young 1594df3498 Fix egregious typo. 2022-04-05 20:10:25 +01:00
Jeff Young 0bd3341f0f Allow textboxes to have no text. (They still have a defined box.) 
Fixes https://gitlab.com/kicad/code/kicad/issues/11286
 2022-04-05 16:29:21 +01:00
Jeff Young ed361925ba Repair code that was supposed to be after LoadSymbol(). 
(Even the comment said so.)

Fixes https://gitlab.com/kicad/code/kicad/issues/11199
 2022-04-05 14:38:05 +01:00
Jeff Young 68ca385e07 On-the-fly translations for pin electrical types. 
Also add on-the-fly translation for editor title bars.

Fixes https://gitlab.com/kicad/code/kicad/issues/11324
 2022-04-05 13:57:28 +01:00
Jeff Young 3196857449 Fix incorrectly initialized variable. 
The SCH_ITEM default is LAYER_WIRE, which we don't want for a symbol.

Fixes https://gitlab.com/kicad/code/kicad/issues/11307
 2022-04-05 13:57:28 +01:00
markus-bonk dc8556726b Fix building QA tests with options -DKICAD_USE_3DCONNEXION=ON 2022-04-05 06:47:49 +00:00
Jeff Young 3f9cfc0ac1 Fix incorrect m_SyncPinEdit setting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11331
 2022-04-04 16:56:53 +01:00
Sylwester Kocjan 05fbe47a1b eeschema: two fixes for simulation tuners 
- fix irrelevant warning message box when tuners moved
  too quickly and simulation was slow
- fix for rerun simulation when tuning and result tab was changed
 2022-04-02 15:05:54 +00:00
Seth Hillbrand 0625e20fc0 Cleanup spacemouse plugin 
Sets std:: convention and unifies the defined/non-defined interface
 2022-04-01 15:14:41 -07:00
Jeff Young a12f77b8f6 Don't render fills in black & white mode. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11303
 2022-04-01 21:24:56 +01:00
Seth Hillbrand 5d5a2f9270 Allow common greek letters in passive regex 
Adds common letters (µ and Ω) as prefix and unit

Fixes https://gitlab.com/kicad/code/kicad/issues/11289

(cherry picked from commit 15fe2f2fd0)
 2022-04-01 12:51:43 -07:00
Sylwester Kocjan 4719fdc9bf eeschema: rename m_exporter to m_circuitModel 2022-04-01 19:28:31 +00:00
Sylwester Kocjan f5dedd77c6 eeschema,sim: add SIMULATOR and SIM_MODEL interface 
SIMULATOR has now an Attach() method, which should be called
with proper SIMULATION_MODEL that should be simulated, before calling Run()

Concrete class of SIMULATION_MODEL for ngspice is NGSPICE_CIRCUIT_MODEL,
renamed from NETLIST_EXPORTER_PSPICE_SIM. DIALOG_SIM_SETTINGS relies
on above mentioned object, so it was added as an argument of the constructor.
 2022-04-01 19:28:31 +00:00
jean-pierre charras be6379a8f6 Fix minor Coverity and compil warnings. 2022-04-01 20:43:21 +02:00
Jeff Young 6f818f4c2e Editing support for sheet-pin fonts, text styles and text colors. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11300
 2022-04-01 19:26:27 +01:00
jean-pierre charras 5d9668938b SYMBOL_EDITOR_CONTROL::DuplicateSymbol(): fix incorrect validation test. 
DuplicateSymbol() is called both to duplicate and paste. Only duplicate
needs a test to know if a symbol is selected.
Fixes #11053
https://gitlab.com/kicad/code/kicad/issues/11053
 2022-04-01 10:42:20 +02:00
Seth Hillbrand 49c48e2fe0 Consistently handle env/prj variables 
User-defined variables cannot be used for internally-reserved variables

Fixes https://gitlab.com/kicad/code/kicad/issues/11232

(cherry picked from commit c23679d9bd)
 2022-03-31 17:05:53 -07:00
Jeff Young 6b99a937d8 Look for sheet pins inside sheets. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11297
 2022-03-31 22:10:45 +01:00
markus-bonk 1a9ef4bd0f Add support for using a SpaceMouse to pan & zoom in the schematic editor. 2022-03-31 19:03:41 +00:00
Jeff Young e8a543f1ea Colors for text in PL_Editor and Eeschema. 
Fixes https://gitlab.com/kicad/code/kicad/issues/1952
 2022-03-31 19:43:56 +01:00
Jeff Young 748cc1a59a Pay better attention to aPlotter->GetColorMode(). 
Fixes https://gitlab.com/kicad/code/kicad/issues/11287
 2022-03-30 20:38:24 +01:00
Jeff Young 7c21a0bdd4 Dirty text render caches in point editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11284
 2022-03-30 16:32:23 +01:00
Jeff Young 5c7b022f40 Be more pedantic about setting GAL line width. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11280
 2022-03-30 16:32:23 +01:00
Jeff Young 91ea0903d0 Add infobars for individual-item-color-overrides. 2022-03-29 20:41:03 +01:00
Jeff Young 8dc680adbb Implement align-to-grid for sheets. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11201
 2022-03-29 19:31:02 +01:00
Seth Hillbrand 719874fe9c Thread the connectivity vector updates 
Now that we are dealing with individual connection elements that do not
update their connected elements as well, we can thread the update, just
being careful to guard any remaining updates (bus_enty/busLine) that
need reciprocal updating

Fixes https://gitlab.com/kicad/code/kicad/issues/10974

(cherry picked from commit 6a53e318e5)
 2022-03-28 15:36:55 -07:00
Seth Hillbrand 6a33bcdc78 Avoid generating SCH_CONNECTION if not needed 
If the SCH_ITEM has already been processed, the extra time needed to
iterated over the memberset and get the SCH_CONNECTION when we won't use
it is not neccesary.

Fixes https://gitlab.com/kicad/code/kicad/issues/10974

(cherry picked from commit 776a28a10e)
 2022-03-28 15:36:55 -07:00
Seth Hillbrand 41f7354b7a Handle connection vector inline 
Normally, you will gain by resursing a nested loop only over the
pairs that are not already handled.  In this case, however, you lose
time because you step outside of the cache by adding the reciprocal test
at each step.

Instead, we process one element at a time, keeping it cached and loop
over all other elements to add to the connection.  This saves us about
75% of the time for larger loops (e.g. stacked power pins on a large
BGA)

Fixes https://gitlab.com/kicad/code/kicad/issues/10974

(cherry picked from commit 3a98eacdb9)
 2022-03-28 15:36:55 -07:00
Jeff Young 09ba7468ae A better is-modified test. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10791
 2022-03-28 21:54:24 +01:00
Jeff Young 4ee6f9e138 Make sure setting the cursor gets put into the right tool context. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10141
 2022-03-28 21:54:24 +01:00