08dbc3a53c
Move the symbol editor to the new filedlg customize
2022-06-11 22:59:59 -04:00
ff94d289c7
Move the eeschema standalone to the new save dialog
2022-06-11 22:06:42 -04:00
a0421b172a
Add missing color swatch to Symbol Editor Text Properties.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11791
2022-06-11 22:14:14 +01:00
e4798199c6
Handle alt pins in plot code.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11728
2022-06-10 22:38:01 +01:00
29900cad34
Add create-wire logic to labels.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11768
2022-06-10 22:38:01 +01:00
e0f0bb2edd
Eeschema: Fix issues when converting a label/text to another label text type.
...
- make convert to/from SCH_DIRECTIVE_LABEL working.
- Autoplace fields of new labels
Fixes #11779
https://gitlab.com/kicad/code/kicad/issues/11779
2022-06-10 14:13:22 +02:00
b712c2c0da
Eeschema: fixes about Hierarchy panel/pane handling
2022-06-09 19:43:09 +02:00
bce1fd337b
Second tool hotkey accepts action (ie: acts as click).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11729
2022-06-09 16:54:04 +01:00
35bde4710c
Eeschema, context menu selection: move convert to ... menuitems to a submenu.
...
Add also missing icons in a few menuitems.
Fixes #11776
https://gitlab.com/kicad/code/kicad/issues/11776
2022-06-09 16:46:21 +02:00
ef2e51b493
Eeschema: code refactor and fix missing save project setting when closing the sch editor.
2022-06-09 13:39:09 +02:00
6bfd106bed
Add missing text colour to symbol editor textbox dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11770
2022-06-09 10:37:23 +01:00
b710982875
Fix broken logic for hidden pins.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11771
2022-06-09 10:37:23 +01:00
6e50a3518f
Fix typo.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11769
2022-06-08 23:53:18 +01:00
ec40a98fe2
wxT
2022-06-08 23:53:18 +01:00
b401e98c80
Eeschema, hierarchy navigator: fixes and enhancements.
...
Work in progress.
2022-06-08 18:23:03 +02:00
46fd32b738
Update grid attributes after sorting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11753
2022-06-08 15:25:13 +01:00
34932e097c
Minor dialog cleanup.
2022-06-08 15:25:13 +01:00
c55a0e4561
Separate last-created-params for textboxes from shapes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11755
2022-06-08 15:25:13 +01:00
185016b84b
Eeschema, Hierarchy navigator: add tool to Hide/show the panel.
...
Add also a close button to the pane.
2022-06-07 11:11:10 +02:00
244042ce51
Keep footprint selection in Symbol Chooser history list.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/1841
2022-06-06 22:24:02 +01:00
dfea73f78c
Eeschema: fix symbol library remap bug.
...
The original decision to escape the legacy symbol library names results
in them being escaped every time they are opened which cause the curly
braces '}' from the original escaping to be escaped on subsequent
openings. This resulted in the symbol library names in the rescue
library not matching the library ID in the schematic.
This fix is likely to have other corner case bugs given the potential
for escaped characters in legacy symbol libraries. Given that we now
have escaped rescue libraries in play, removing the escaping will only
result in more issues so we will have to fix the corner cases as we go.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11563
2022-06-05 17:00:57 -04:00
9f38fa43cd
Fix some minor compil and Coverity warnings.
2022-06-05 11:44:49 +02:00
31316760f6
Separate power and symbol saved search strings.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11747
2022-06-04 22:15:39 +01:00
718bb461d2
Textbox defaults for libedit.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11739
2022-06-04 21:25:37 +01:00
ecbf5c1e14
Don't display unit in single unit symbols of annotation error message
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11748
2022-06-04 16:04:33 +02:00
099061f46d
Process nested formatting within a variable cross-reference.
2022-06-04 00:34:14 +01:00
78e465bbd8
Fix crash in sch_navigate_tool when history was empty
2022-06-03 23:07:12 +02:00
ce79a16ed8
Use default schematic text size for textboxes.
...
Also adds support for remembering stroke info, fill info, and
spin style for sch text boxes.
Fixes https://gitlab.com/kicad/code/kicad/issues/11739
2022-06-03 21:48:12 +01:00
407514919d
Prevent null dereference
2022-06-03 10:05:55 -07:00
8d51b6b6d3
Schematic: Add icons for Any/90/45 angle modes
...
Also add a dark mode icon for existing 45hv icon.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11332
2022-06-03 15:04:52 +00:00
857990a883
Hierarchy: turn into a left side pane
...
Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
aaff163d7c
Repair Eagle importer page number handling.
...
The root sheet needs a page number, and the other sheets need to not
have their last step in the path duplicated.
Fixes https://gitlab.com/kicad/code/kicad/issues/11409
2022-05-31 17:48:38 +01:00
abba1b04bd
Add "Enter Sheet" to Sheet tool (context menu & double-click).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11531
2022-05-30 14:08:26 +01:00
2701642b1b
minor fixes and French translation update
2022-05-30 11:23:20 +02:00
d5d8d36d86
Implement expanding Select Connection.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8579
2022-05-29 22:51:33 +01:00
f246646d7a
Fix severe simulation memory leaks
2022-05-28 20:40:24 +00:00
f2cf934083
Schematic: Annotation Tweaks
...
Fix newly placed symbols to be annotated and not show a ? until
placement.
2022-05-27 15:54:00 +00:00
efa23a5cbe
Schematic: better automatic/recursive annotate
2022-05-27 15:54:00 +00:00
7f3e5e9b79
Schematic: add recursive annotation control
2022-05-27 15:54:00 +00:00
85516a4691
Schematic: add automatic annotation toggle
2022-05-27 15:54:00 +00:00
dabd42bbc4
Schematic: Automatic Symbol Annotation
2022-05-27 15:54:00 +00:00
6114a5d72c
Escape pin names when used as netnames.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11687
2022-05-26 23:54:55 +01:00
cb15bd1635
Fix compile issue.
2022-05-26 10:54:54 +01:00
616e9b4f4b
Be cognizant of symbol transform when setting justification.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11465
2022-05-26 10:54:08 +01:00
55f22c526a
Fix annotation of incomplete multi-unit symbols and re-annotation of duplicates
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11496
2022-05-26 09:23:36 +00:00
11ae5b75b7
Remove broken assert
...
Fixes compile issue for linux/gcc which expects a boolean in the assert
statement that it cannot find from std::map
2022-05-25 16:36:47 -07:00
6aa50304d9
Eeschema: Fixing simulation plot CSV exporter
2022-05-25 15:00:03 +00:00
487c8f8e39
symbol editor: Improve pin duplication
...
When duplicating pins in the symbol editor the duplicated pins will have
unique pin numbers assigned if the duplication target had the pin number
specified
2022-05-25 00:02:16 +00:00
0536ab4f6c
Remove kicad_pair in transmission lines
...
This was a misread from the ngspice doc
2022-05-25 00:00:07 +00:00
eae5e9f00e
Symbol checker: fix incorrect test for duplicate pins.
...
Fixes #11660
https://gitlab.com/kicad/code/kicad/issues/11660
2022-05-23 11:20:12 +02:00
ea29c66608
Fix formatting
2022-05-22 07:14:24 +00:00
4e5febdb19
Fixes the import pin issue, that the they are shown in two different way https://gitlab.com/kicad/code/kicad/-/issues/11391
2022-05-22 04:42:22 +00:00
8e94c307d2
Provide default case for mirroring single objects.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11649
2022-05-21 22:50:55 +01:00
d381fd8b29
Typo.
...
LIB_SYMBOL's value field is the name; SCH_SYMBOL's value field is not.
Fixes https://gitlab.com/kicad/code/kicad/issues/11556
2022-05-20 18:01:01 +01:00
23fb4c7433
Uniformly use a single facility for location-less prime events.
...
Also implements a uniform mechanism for avoiding auto-scroll after
a prime event or dialog which results in a mouse position at the
edge of the canvas.
Fixes https://gitlab.com/kicad/code/kicad/issues/11057
2022-05-16 23:43:00 +01:00
f2fc78f380
Don't copy modifiers to prime events.
...
The modifiers go with the hotkey, not with the action.
Fixes https://gitlab.com/kicad/code/kicad/issues/11618
2022-05-16 13:51:40 +01:00
359c99991b
Eeschema: do not leave a temporary flag set after use in draw symbol function.
...
Fixes #11617
https://gitlab.com/kicad/code/kicad/issues/11617
2022-05-15 18:35:07 +02:00
9049c907a1
Fix wxWidgets assert in symbol preview widgets
2022-05-15 15:26:53 +01:00
79a0ce9137
Unset forced cursor before leaving two-click place.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11607
2022-05-14 22:38:54 +01:00
38e5faf21b
Overhaul bitmap text for performance.
...
Also adjusts metrics to better match stroke font.
Also removes text-halo highlighting as it's too expensive to re-render
when the zoom changes.
Fixes https://gitlab.com/kicad/code/kicad/issues/11460
2022-05-14 20:09:54 +01:00
5802ede3fd
Change default value of MatchByReference to false.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11382
2022-05-14 12:41:25 +00:00
88c7322a0d
EDA_TEXT Get/SetTextSize should use VECTOR2I
2022-05-14 08:16:15 -04:00
45b167dff5
Some fixes related to translated/not translated mandatory field names. DIALOG_SYMBOL_FIELDS_TABLE: add new fields to symbols only if the field is not empty.
2022-05-13 11:45:38 +02:00
20d1d0705e
Fix a few issues related to field names and their translation. - Do not use translated field names outside strings displayed in dialogs. - fix code that does not work well with default locale. - fix some (not all) I18n issues in DIALOG_UPDATE_SYMBOL_FIELDS.
2022-05-13 11:45:37 +02:00
bbc250720f
Resolve title variable when plotting
...
Be sure to use variable name if it exists when plotting the file
Fixes https://gitlab.com/kicad/code/kicad/issues/11608
(cherry picked from commit d971cbefcb
2022-05-12 15:31:15 -07:00
b68514afb1
Fix a wxWidgets alert.
2022-05-12 20:58:48 +02:00
5c4f49351d
Remove extra compilation of common.cpp
...
It's already built in the common target, no eeschema specific code
2022-05-10 21:31:31 -04:00
f85251ef75
Fix eda_doc not looking for schematic locally
...
It looks like this was overlooked by Jeff in 2020 not realizing eda_doc isn't built under eeschema but common in cc9ac37a0e
2022-05-10 21:28:48 -04:00
ad066ef09a
Fix cross-probing in complex hierarchies, remove unused code.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11493
2022-05-09 23:22:03 +03:00
4bd349d922
Update some demos
2022-05-09 19:06:14 +02:00
b7a77a9498
Schematic: Add CSV export to Symbol Fields Table
2022-05-09 12:02:12 -04:00
8f937b17a2
Remove wxWidgets 3.0.x hack.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11540
2022-05-07 23:24:55 +01:00
f9f0f6fe24
Implement cross-references for labels.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11564
2022-05-07 21:10:04 +01:00
5cd3c07862
Catch throws in DeleteSymbol
...
DeleteSymbol may call SaveSymbol if the name is changed. In this case,
SaveSymbol may throw back and needs to be caught
Fixes https://gitlab.com/kicad/code/kicad/issues/11566
(cherry picked from commit e05c8f8852
2022-05-06 16:13:59 -07:00
7e20c0ed9c
eeschema: removed unused code
...
Fixes #11533
2022-05-06 17:17:55 +00:00
a644aad1cf
Hand-code tab navigation from value field of Label Properties dialog.
...
wxWidgets doesn't appear to handle it correctly, doing nothing on OSX
and potentially crashing on GTK.
Fixes https://gitlab.com/kicad/code/kicad/issues/11572
2022-05-06 18:14:25 +01:00
5f7ac58f95
Catch errors when saving individual symbols
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11566
(cherry picked from commit f4d4f23876
2022-05-06 09:55:28 -07:00
a19490b097
Eeschema: fix broken project symbol rescue.
...
The legacy symbol library plugin code was changed to escape symbol names
which broke the LIB_ID string comparison when checking to see if symbols
needed to be rescued. Escaping the LIB_ID names before comparison resolves
the issue.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11563
2022-05-06 08:50:09 -04:00
32077673e8
Symbol editor crash: Fix use of a null pointer.
...
LIB_TEXT::Clone() did not copy a member set to nullptr.
Fixes #11569
https://gitlab.com/kicad/code/kicad/issues/11569
2022-05-06 12:51:26 +02:00
1751c8e1cf
Save selection *before* clearing it. Saving after doesn't do much good.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11242
2022-05-06 00:06:00 +01:00
9c5aa5c3c1
Font and color for FIELDS_GRID_TABLE.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11459
2022-05-06 00:06:00 +01:00
e80c5a4e4e
Add text colour to Edit Text & Graphics Properties.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11459
2022-05-06 00:06:00 +01:00
bd7447cff3
Fix variable name
...
This is the top left position, not the top right.
2022-05-05 10:27:19 +00:00
f14dc9e305
Don't plot private symbol text.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11548
2022-05-03 19:41:20 +01:00
babfb29c54
Formatting cleanup.
2022-05-03 13:39:14 +01:00
67f352717e
Fix dodgy type-cast and init line-widths to "inherit".
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11535
2022-05-03 13:39:14 +01:00
3f470359a2
Eeschema, backannotate: fix minor issues in displayed messages.
...
Fixes #11530
https://gitlab.com/kicad/code/kicad/issues/11530
2022-05-03 09:20:46 +02:00
a56955443f
Fix botched commit
...
(cherry picked from commit ba276fe470
2022-05-02 16:29:07 -07:00
2079d15b3f
Catch IO_ERRORs that we throw
...
FILEOUTPUT_FORMATTER likes to throw when it gets an issue. We need to
catch this to avoid the app falling apart
Fixes https://gitlab.com/kicad/code/kicad/issues/11516
(cherry picked from commit 4d47857738
2022-05-02 15:15:52 -07:00
f6f316bd8c
Promote field selection to field-owner for Autoplace.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11529
2022-05-02 20:11:21 +01:00
d2610736ff
Fix bugs with printing bordered shapes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11536
2022-05-02 19:45:55 +01:00
585ea85f95
LIB_SHAPE default line style is SOLID, not DASHED.
...
(Copy/paste error from SCH_SHAPE.)
Fixes https://gitlab.com/kicad/code/kicad/issues/11527
2022-05-02 17:22:13 +01:00
036d283433
Don't muck with linestyle default when setting it.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11520
2022-05-02 17:22:13 +01:00
804ab5609e
Add dash-dot-dot to Edit Text & Graphics Properties.
...
Also fixes a bug where textboxes and shapes weren't correctly updated.
Fixes https://gitlab.com/kicad/code/kicad/issues/11522
2022-05-02 17:22:13 +01:00
50223c9337
Eeschema print: Do not print private graphics in symbols.
...
Fixes #11532
https://gitlab.com/kicad/code/kicad/issues/11532
2022-05-02 16:29:08 +02:00
ece15b6472
Fix a compil warning (shadowed var).
2022-05-02 15:25:55 +02:00
dfa6b9ed15
Reset plotter dash-style after use.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11527
2022-05-02 13:21:46 +01:00
40c75c74fa
EEschema/Cvpcb: make assign footprints from CvPcb undoable.
...
Fixes #11508
https://gitlab.com/kicad/code/kicad/issues/11508
2022-05-02 12:49:14 +02:00
772bdc4bbf
Turn off auto-dialog for text objects when immediateActions == false.
2022-05-02 11:25:40 +01:00
de0bb26c4c
Init global label's intersheet ref's visibility from schematic settings.
2022-05-02 09:42:38 +01:00
7ebdb4853c
Do not open label edit dialog when adding label to an already named wire
2022-05-02 08:42:15 +00:00
6d44ca2145
Ellipsize long heirarchical paths.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11499
2022-04-30 14:09:30 +01:00
9fbf8e6f5d
Respect default layer color for textbox borders.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11497
2022-04-29 14:10:48 +01:00
dc1e063b00
Iron out some issues with linestyle handling in SCH printing and plotting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11498
2022-04-29 13:52:30 +01:00
3589eb33f0
Handle text color when printing and plotting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11491
2022-04-29 10:51:00 +01:00
2cccd5b090
Fix minor layout issue in dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11490
2022-04-27 17:14:33 +01:00
8a97a46e6b
Release file before re-loading it for Revert.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11481
2022-04-26 22:28:35 +01:00
e0f2a5f07c
Update findnext to handle new instance data architecture.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11424
2022-04-26 20:21:15 +01:00
47e002a33d
Add font to status bar for text objects.
2022-04-26 18:52:53 +01:00
e6f11c5c39
Reset outline font if bold or italic changed.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11462
2022-04-26 12:52:29 +01:00
85680886f8
Adjust outline font SCH_TEXT positioning so it better matches SCH_FIELD text.
2022-04-26 12:52:29 +01:00
25474b347c
Fix frustration with mirroring autoplaced fields
...
When the user asks to mirror a symbol is is frequently to get the
reference/value on the other side of the symbol for placement purposes.
Autoplacing the fields here keeps the text where they were initially
which can be frustating to work around.
This commit treats the mirror command as a user request to change where
the fields are
2022-04-25 12:50:45 -07:00
1a70465927
Use instance data to store values
...
Previous use of instance was as an "override" of the default value.
This has changed to be used as the primary storage location for all
values. This means that we cannot clear the instance data when setting
a new value for all instances, instead we have to change the instance
data and the default value is superfluous
Fixes https://gitlab.com/kicad/code/kicad/issues/11439
2022-04-25 12:47:48 -07:00
f5d612eaed
Switch <insert> replacement on OSX to <f1>.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11413
2022-04-25 10:01:33 +01:00
90bfe2d94b
Remove Save Copy As from fp editor, and rename to Save a Copy elsewhere.
...
It's still used by Eeschema and PCBNew when not in stand-alone mode.
Fixes https://gitlab.com/kicad/code/kicad/issues/9185
2022-04-24 19:46:57 +01:00
6738708a7f
Disable background color when printing in black & white.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11180
2022-04-24 19:46:57 +01:00
52eb210aa8
Initialize virtual page no. to something more reasonable.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11295
2022-04-24 19:46:57 +01:00
3bc34590c7
Eeschema: fix missing call to UpdateMessagePanel() due to commit e09147db.
...
EE_INSPECTION_TOOL::UpdateMessagePanel was called by EVENTS::SelectedEvent
But This event after commit calls E_INSPECTION_TOOL::CrossProbe(),
and no longer UpdateMessagePanel.
So CrossProbe() now calls UpdateMessagePanel.
Fixes #11447
https://gitlab.com/kicad/code/kicad/issues/11447
2022-04-24 18:40:10 +02:00
c6f83b6dec
ADDED Duplicate Footprint, Rename Symbol and Rename Footprint.
2022-04-22 22:06:51 +01:00
b42365190e
Schematic/PCB: deleting fields sets them to invisible
2022-04-21 16:20:23 +00:00
eb1a238a53
Remove extra event handler.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11418
2022-04-20 16:19:42 +01:00
fc2eb2d7c9
Fix missing line keeping tabs from switching.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11417
2022-04-20 14:51:08 +01:00
aac6f576c2
Fix broken comparison in pin_numbers
...
Pin names like "+V" were incorrectly parsed as doubles leading to broken
comparisons. These caused heap overflows when sorting pin tables
This corrects the comparison so that numeric sorts are only performed
when there is an actual number in the symbol segment. Also adds unit
tests for common error cases
2022-04-19 14:46:05 -07:00
4ab2c93070
Update Selection Filter title bar with language changes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11421
2022-04-19 21:12:13 +01:00
ffc28f23e5
Repair GetFullRef() and use it when running Symbol Fields Table filtering.
...
(Previously GetFullRef() failed to add the number between the prefix letter
and the unit designator.)
Fixes https://gitlab.com/kicad/code/kicad/issues/11419
2022-04-19 19:55:30 +01:00
08f15fe587
ADDED New Library functionality to Footprint/Symbol Save As.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2343
2022-04-19 19:55:30 +01:00
84f620a96e
Minor dialog beautification.
2022-04-19 19:55:30 +01:00
c3bed8f6ee
Resolve textvars before opening file browser.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6436
2022-04-18 22:45:02 +01:00
cc18c31cb5
Fix some layout issues in the Project Template Selector.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5222
2022-04-18 22:45:02 +01:00
653baf270c
Schematic: drag created / changed segments need junction checks
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10844
2022-04-18 17:24:02 +00:00
801c5deb87
Fix minimum size calculation for new hierarchical sheets
...
These constants are given in mil, but are used in a context of internal
units.
2022-04-18 15:01:59 +00:00
1e505d4c22
Remove a few call sites of SCH_SHEET::SetSize
...
This function is dangerous and should be used only by parsers, and not even
those, really.
For new objects, the size can be passed to the constructor.
2022-04-18 16:23:03 +02:00
55a8fb39c4
ADDED filtering for Symbol Fields Table dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11224
2022-04-17 20:02:58 +01:00
71c2cb3180
ADDED revert for pcbnew and eeschema.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6802
2022-04-17 20:02:58 +01:00
38c54ffa8f
Eeschema, Symbol Library Browser: fix crash when left clicking on the canvas.
2022-04-17 09:54:19 +02:00
e09147db30
Cross-probing for ERC dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11411
2022-04-17 00:33:56 +01:00
7f4f5f2882
Save and re-load query string in Choose Symbol dialog.
...
While this has been requested on its own, it's primarily done here
because wxWidgets decided to send a SEARCH_CANCEL from a wxSearchCtrl
when hitting <ENTER> if the search control holes the empty string.
This causes us to not do a symbol instert in the Chooser dialog.
Fixes https://gitlab.com/kicad/code/kicad/issues/10169
Fixes https://gitlab.com/kicad/code/kicad/issues/7699
2022-04-17 00:33:56 +01:00
250a246761
Clear flags after we're done with them
...
The CANDIDATE flag is a temporary element that should not be maintained
outside of the routine in which is it temporarily set
Fixes https://gitlab.com/kicad/code/kicad/issues/11361
2022-04-16 15:45:17 -07:00
65f7d9f97a
EEschema: move symbol checker code in symbol_checker.cpp.
...
- Add some tests for Power symbols.
- Fix incorrect print format in some messages.
2022-04-16 18:56:06 +02:00
ce9bd780d1
Fix crash due to cleared view data
...
When changing fields, we need to update the view before allowing canvas
updates
(cherry picked from commit 851f893e8e
2022-04-15 15:14:29 -07:00
4ee6cfe5b6
Disable all use of the default instance reference prefix for annotation.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11385
2022-04-14 17:55:35 +01:00
6ef6e37edb
Disable using default instance data when writing to clipboard.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11379
2022-04-14 17:09:27 +01:00
160240166c
Cleanup.
2022-04-14 17:09:27 +01:00
034b57d9c0
When reannotating keep existing prefix in most cases.
...
(Execption is reannotating entire schematic, in which case we reset
all of them.)
Fixes https://gitlab.com/kicad/code/kicad/issues/11379
2022-04-13 23:38:45 +01:00
184b67098f
Meet user expectations on life-cycle of symbol fields.
...
In other words, support empty fields.
Also adds deleting fields to Symbol Fields Table.
Fixes https://gitlab.com/kicad/code/kicad/issues/8999
2022-04-12 22:11:31 +01:00
85f6ff48e7
CADSTAR Sch: Clear symbol of all elements before overwriting with new one
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11378
2022-04-12 21:34:23 +01:00
306dfef7e5
Fix typo.
2022-04-12 19:18:15 +01:00
576f3dc2fd
Keep pins aligned to grid when possible.
...
This uses the first pin as the anchor point in a mulitple-item
selection.
Fixes https://gitlab.com/kicad/code/kicad/issues/11151
2022-04-12 18:14:21 +01:00
f88e0481c8
Change the behavior of ACTION_MENU::Add to require clones if required outside the function
...
This reverts commit 2a5769607f
2022-04-11 19:03:01 -04:00
16acba34d3
Don't save schematic symbol back to lib manager.
...
Also, since it doesn't get saved, changing symbols will lose any edits.
Make sure to ask the user first.
Fixes https://gitlab.com/kicad/code/kicad/issues/10767
2022-04-11 22:43:39 +01:00
2a5769607f
Revert "Change the behavior of ACTION_MENU::Add to require clones if required outside the function"
...
This reverts commit 403992a6f4
2022-04-11 11:39:03 -07:00
546b3bfbc0
Select wire ends in select all.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10958
2022-04-11 19:36:54 +01:00
f0f10a43a2
Ensure "Clear Recent Files" menuitem titles are updated after language change.
...
(missing fixes in commit ac8e2d076
2022-04-11 18:11:17 +02:00
74a578047c
Make sure to add any now-necessary junctions after a rotate.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11242
2022-04-11 12:02:20 +01:00
8358685920
Dual-purpose IsMovableFromAnchorPoint to keep from moving symbols off-grid.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11360
2022-04-11 12:02:20 +01:00
ac8e2d0768
Ensure "Open Recent" and "Clear files" menu titles are updated after language change.
2022-04-11 11:09:05 +02:00
403992a6f4
Change the behavior of ACTION_MENU::Add to require clones if required outside the function
...
Fix https://gitlab.com/kicad/code/kicad/-/issues/10994
2022-04-10 22:38:13 -04:00
5bb2cdf73d
Revert "Stop leaking submenu items"
...
This reverts commit 34c70a51ea
2022-04-10 22:33:43 -04:00
34c70a51ea
Stop leaking submenu items
...
Our menu bar code is interestingly complex. But we were throwing away newly made menu items to the void in the cases of constructed on the fly submenus
2022-04-10 22:04:48 -04:00
117bd4fc22
Adjust LIB_SYMBOL compare for use with ERC.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10783
2022-04-09 20:12:29 +01:00
0015574a60
${SHEETNAME} represents the sheet name + introduce ${SHEETPATH}
...
CHANGED: The text variable ${SHEETNAME} now always represents the name of the
sheet when used anywhere in the schematic editor, including the title block
ADDED: A new text variable ${SHEETPATH} which is replaced with the path to the
current sheet - e.g. "/Sheet 1/Sheet 2".
To ensure backward compatibility, the default drawing sheet now uses
${SHEETPATH}. Custom drawing sheets will need to be manually edited.
2022-04-09 15:45:58 +01:00
239f0214ac
Eeschema: add support for default schematic symbol instance data.
...
Prior to fixing the schematic file change churn do to instance data
changing to the last selected sheet instance, the symbol instance data
was set rather than empty. This change allows for users to set the
default instance data which is used for every new instance of the
schematic.
ADDED: Default schematic symbol instance data (unit and reference, value,
and footprint fields) can be set to be used as the default settings
for all new instances of the schematic.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11113
2022-04-09 07:49:36 -04:00
007906cd16
Fix a degeneracy bug in arc collisions.
...
This also fixes a failure to use the correct effective width for
shapes (which might, for instance, inherit their widths from schematic
defaults, netclasses, etc.).
Fixes https://gitlab.com/kicad/code/kicad/issues/11358
2022-04-08 16:15:58 +01:00
702623ef87
Don't flag pin missing driver when there is an NC
...
The NC flag indicates user intention to override the lack of connection
to input pins
(cherry picked from commit e02229a234
2022-04-07 09:35:23 -07:00
c17b90c8dc
Run pinning on sides as well as corners.
...
Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the
upside-down coordinate system.
Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 11:51:58 +01:00
4b0b4c0ddc
Show non-driven error on single-pin nets
...
Better to have both the single-pin error message and the non-driven
error message when an input pin is not connected than miss error
messages when the pin is connected to a blank net
Fixes https://gitlab.com/kicad/code/kicad/issues/10430
(cherry picked from commit e740db61f5
2022-04-06 16:54:04 -07:00
356d565d48
Normalize rectangular shapes before feeding to point editor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-06 18:18:29 +01:00
67d54ecb4c
A bit of dialog layout cleanup.
2022-04-06 16:58:26 +01:00
06df90636b
Rationalize negative line-width handling.
...
Make "don't stroke" an explicit property in the GUI.
Silently enforce line width to >= 0 when stroking.
Make layouts between dialogs more consistent.
Interpret unspecified fill colour as layer colour.
Fixes https://gitlab.com/kicad/code/kicad/issues/11279
2022-04-05 23:59:25 +01:00
a9c61d21ca
eeschema: fix crash when closing simulation frame
...
Destructor of SIM_PLOT_FRAME calls sim->Attach( nullptr ) in order to destroy
circuit model (former netlist exporter). If this is skipped, eeschema crashes
when program is closed. nullptr is a valid parameter for Attach()
2022-04-05 19:28:05 +00:00
1594df3498
Fix egregious typo.
2022-04-05 20:10:25 +01:00
0bd3341f0f
Allow textboxes to have no text. (They still have a defined box.)
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11286
2022-04-05 16:29:21 +01:00
ed361925ba
Repair code that was supposed to be after LoadSymbol().
...
(Even the comment said so.)
Fixes https://gitlab.com/kicad/code/kicad/issues/11199
2022-04-05 14:38:05 +01:00
68ca385e07
On-the-fly translations for pin electrical types.
...
Also add on-the-fly translation for editor title bars.
Fixes https://gitlab.com/kicad/code/kicad/issues/11324
2022-04-05 13:57:28 +01:00
3196857449
Fix incorrectly initialized variable.
...
The SCH_ITEM default is LAYER_WIRE, which we don't want for a symbol.
Fixes https://gitlab.com/kicad/code/kicad/issues/11307
2022-04-05 13:57:28 +01:00
dc8556726b
Fix building QA tests with options -DKICAD_USE_3DCONNEXION=ON
2022-04-05 06:47:49 +00:00
3f9cfc0ac1
Fix incorrect m_SyncPinEdit setting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11331
2022-04-04 16:56:53 +01:00
05fbe47a1b
eeschema: two fixes for simulation tuners
...
- fix irrelevant warning message box when tuners moved
too quickly and simulation was slow
- fix for rerun simulation when tuning and result tab was changed
2022-04-02 15:05:54 +00:00
0625e20fc0
Cleanup spacemouse plugin
...
Sets std:: convention and unifies the defined/non-defined interface
2022-04-01 15:14:41 -07:00
a12f77b8f6
Don't render fills in black & white mode.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11303
2022-04-01 21:24:56 +01:00
5d5a2f9270
Allow common greek letters in passive regex
...
Adds common letters (µ and Ω) as prefix and unit
Fixes https://gitlab.com/kicad/code/kicad/issues/11289
(cherry picked from commit 15fe2f2fd0
2022-04-01 12:51:43 -07:00
4719fdc9bf
eeschema: rename m_exporter to m_circuitModel
2022-04-01 19:28:31 +00:00
f5dedd77c6
eeschema,sim: add SIMULATOR and SIM_MODEL interface
...
SIMULATOR has now an Attach() method, which should be called
with proper SIMULATION_MODEL that should be simulated, before calling Run()
Concrete class of SIMULATION_MODEL for ngspice is NGSPICE_CIRCUIT_MODEL,
renamed from NETLIST_EXPORTER_PSPICE_SIM. DIALOG_SIM_SETTINGS relies
on above mentioned object, so it was added as an argument of the constructor.
2022-04-01 19:28:31 +00:00
be6379a8f6
Fix minor Coverity and compil warnings.
2022-04-01 20:43:21 +02:00
6f818f4c2e
Editing support for sheet-pin fonts, text styles and text colors.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11300
2022-04-01 19:26:27 +01:00
5d9668938b
SYMBOL_EDITOR_CONTROL::DuplicateSymbol(): fix incorrect validation test.
...
DuplicateSymbol() is called both to duplicate and paste. Only duplicate
needs a test to know if a symbol is selected.
Fixes #11053
https://gitlab.com/kicad/code/kicad/issues/11053
2022-04-01 10:42:20 +02:00
49c48e2fe0
Consistently handle env/prj variables
...
User-defined variables cannot be used for internally-reserved variables
Fixes https://gitlab.com/kicad/code/kicad/issues/11232
(cherry picked from commit c23679d9bd
2022-03-31 17:05:53 -07:00
6b99a937d8
Look for sheet pins inside sheets.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11297
2022-03-31 22:10:45 +01:00
1a9ef4bd0f
Add support for using a SpaceMouse to pan & zoom in the schematic editor.
2022-03-31 19:03:41 +00:00
e8a543f1ea
Colors for text in PL_Editor and Eeschema.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/1952
2022-03-31 19:43:56 +01:00
748cc1a59a
Pay better attention to aPlotter->GetColorMode().
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11287
2022-03-30 20:38:24 +01:00
7c21a0bdd4
Dirty text render caches in point editor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11284
2022-03-30 16:32:23 +01:00
5c7b022f40
Be more pedantic about setting GAL line width.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11280
2022-03-30 16:32:23 +01:00
91ea0903d0
Add infobars for individual-item-color-overrides.
2022-03-29 20:41:03 +01:00
8dc680adbb
Implement align-to-grid for sheets.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11201
2022-03-29 19:31:02 +01:00
719874fe9c
Thread the connectivity vector updates
...
Now that we are dealing with individual connection elements that do not
update their connected elements as well, we can thread the update, just
being careful to guard any remaining updates (bus_enty/busLine) that
need reciprocal updating
Fixes https://gitlab.com/kicad/code/kicad/issues/10974
(cherry picked from commit 6a53e318e5
2022-03-28 15:36:55 -07:00
6a33bcdc78
Avoid generating SCH_CONNECTION if not needed
...
If the SCH_ITEM has already been processed, the extra time needed to
iterated over the memberset and get the SCH_CONNECTION when we won't use
it is not neccesary.
Fixes https://gitlab.com/kicad/code/kicad/issues/10974
(cherry picked from commit 776a28a10e
2022-03-28 15:36:55 -07:00
41f7354b7a
Handle connection vector inline
...
Normally, you will gain by resursing a nested loop only over the
pairs that are not already handled. In this case, however, you lose
time because you step outside of the cache by adding the reciprocal test
at each step.
Instead, we process one element at a time, keeping it cached and loop
over all other elements to add to the connection. This saves us about
75% of the time for larger loops (e.g. stacked power pins on a large
BGA)
Fixes https://gitlab.com/kicad/code/kicad/issues/10974
(cherry picked from commit 3a98eacdb9
2022-03-28 15:36:55 -07:00
09ba7468ae
A better is-modified test.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10791
2022-03-28 21:54:24 +01:00
4ee6f9e138
Make sure setting the cursor gets put into the right tool context.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10141
2022-03-28 21:54:24 +01:00
8706bea3c6
Fix renamed flag
...
Snuck in between MR reviews
2022-03-28 13:50:44 -07:00
2a726a882f
Schematic: new feature, force 45 degree lines
...
* New modes to force 45 deg angle at beginning or end of line
* Backspace will undo most recent segment added
* / will toggle posture of 90 and 45 degree lines
* Added alg::signbit for convenience
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10869
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9175
2022-03-28 16:07:23 -04:00
e51ab86225
Schematic Drag: fixes and improvements
...
Fixes:
* Various special cases around junctions on pins and dragging.
* Some rotations of endpoints resulting in a 45 degree rotate.
* Some cases where it was possible to get a line with neither
endpoint selected, and also substractive unselecting only one of two
selected endpoints unselecting both.
* Use line midpoint for sorting. Start and endpoints aren't
consistent in the order they appear on the X or Y axis. So,
we need to use the midpoint for our position for consistent
sorting when dragging groups of parallel lines where some
have the start and end reversed.
Other:
* Rename TEMP_SELECTED TO SELECTED_BY_DRAG. This is the actual meaning
of the flag, and should reduce confusion as
to when it should be used.
* Move usage of TEMP_SELECTED as an algorithmic mark to CANDIDATE
instead.
* Fix mistaken clearing of START_POINT and ENDPOINT.
* Move endpoint setting and clearing out of narrowSelection, and into
selectPoint and selectMultiple.
* Don't show dangling end warnings on new lines
2022-03-28 16:02:48 -04:00
47f4503564
SCH textboxes start/end -> at/size.
...
The at token can handle an angle; start/end does not.
Fixes https://gitlab.com/kicad/code/kicad/issues/11252
2022-03-28 11:16:39 +01:00
343b2681d4
Midpoints for eeschema rectangles and text boxes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10362
2022-03-28 11:16:39 +01:00
265ff90e19
Use selection highlight color for sel shadows even when brightened.
...
This allows Find & Change to show both matches and current match.
Fixes https://gitlab.com/kicad/code/kicad/issues/11101
2022-03-28 11:16:39 +01:00
cfe0003ca4
Eeschema: fix misplaced nullptr test that prevent saving SCH_TEXT items.
...
Fixes #11250
https://gitlab.com/kicad/code/kicad/issues/11250
2022-03-27 18:48:55 +02:00
38bd612c01
sch_sexpr_parser.cpp: allows reading a polyline descr with more than 2 points
...
In symbols, a polyline descr is already a true polyline / polygon descr.
In schematic, a polyline descr was restricted to only 2 points (a line).
A true polyline / polygon descr is now allowed in schematic that support already
polygons.
For compatibility reason, a 2 points polygon (SCH_SHAPE) is converted to a SCH_LINE.
2022-03-27 10:31:21 +02:00
48dd810cd1
ADDED grouping of selected pins in Pin Table.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4956
2022-03-26 21:07:10 +00:00
a54457386c
Enable immediate mode for pin tool.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10156
2022-03-26 21:07:10 +00:00
53ccd8bd67
eeschema,sim: refactor NETLIST_EXPORTER_PSPICE_SIM creation
2022-03-26 15:50:15 +00:00
9a342458fa
Fix a few Coverity and compil warnings.
2022-03-26 16:21:23 +01:00
0652c7b429
More visible Synchronized Pins Mode informatics.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10340
2022-03-26 15:16:08 +00:00
1c158a4ea4
Use a standard HTML reporter for Symbol Checker.
2022-03-26 14:22:31 +00:00
d5533e7999
ADDED unit-filtering for pin table.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9382
2022-03-26 11:53:48 +00:00
e6c2b12ddf
ADDED allow pin conversion to be edited in Pin Table.
...
Added a De Morgan column.
2022-03-26 11:53:48 +00:00
2681ad6cfc
Don't rely on HasConversion() for Symbol Properties in Symbol Editor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11200
2022-03-26 11:53:48 +00:00
7da7864f5e
Fix some Coverity issues.
2022-03-25 15:51:05 -04:00
c686105afc
Correctly order swap test
...
MapAngles() will modify parameters and C++ does not guarantee LTR
evaluation, so we need to separate the calls into the proper order
before comparing the returns
Fixes https://gitlab.com/kicad/code/kicad/issues/11135
2022-03-24 09:23:50 -07:00
92a229eec7
ADDED separate user-defined color for page limits.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5271
2022-03-24 14:11:41 +00:00
b87fc45e33
Fix broken symbol field table editor dialog.
...
Do not use the symbol field string to populate the value and footprint
grid cells. The field strings may be empty because the symbol has not
been instantiated yet by entering a sheet. This fix makes an incorrect
assumption that the first instance value and footprint data in the symbol
is the same for all instances.
Note: this fix is incomplete because the value and footprint fields are
can now be different between sheet instances. The entire field
table editor design will need to be rethought because the current
grouping doesn't allow different value and footprint instance
changes.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11194
2022-03-23 11:46:49 -04:00
535ecb9b7b
Don't leave dangling pointers to old document when importing.
...
This goes for both selection pointers and undo/redo pointers.
Fixes https://gitlab.com/kicad/code/kicad/issues/10145
2022-03-22 18:08:05 +00:00
8eb10c41d8
Name any unnamed fields so they don't clobber each other.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10039
2022-03-22 18:08:05 +00:00
21144481d2
PLOTTER: do not clamp coordinates to an arbitrary value.
...
Previously, coordinates were clamped to +- 60 inches. It makes no sense to
clamp them at plotter level: max cooed depends on the editor (schematic/board...)
Rename MAX_PAGE_SIZE_MILS to MAX_PAGE_SIZE_EESCHEMA_MILS and use it only for Eeschema.
Fixes #11196
https://gitlab.com/kicad/code/kicad/issues/11196
2022-03-22 10:32:36 +01:00
e336a0e403
Improve sheet schematic import messages and simplify code.
...
There was also a logic bug when the selected schematic was in a different
path than the current project and was already part of the current project.
The symbol library table reconciliation code was still run which was wrong.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11075
2022-03-21 17:09:49 -04:00
2fed8aa4b8
eeschema: Add sync functions to SPICE_SIMULATOR
...
SPICE simulator can be called also during IBIS model determination,
and in the future in ERC. Therefore a necessity arises to implement
exclusive access.
2022-03-21 19:10:08 +00:00
e77a71bf7a
Fix typo found in code review.
2022-03-21 10:32:36 +00:00
4f62960334
Update message panel from PCB point editor and SCH drawing tools.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11186
2022-03-21 10:32:36 +00:00
58c146a7c0
ADDED ki_description and ki_keywords to footprint properties.
...
Also a bunch of wxT().
Fixes https://gitlab.com/kicad/code/kicad/issues/7783
2022-03-19 23:16:56 +00:00
cc165129fd
Special case undo for items with instance data.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11102
2022-03-19 19:37:01 +00:00
63b5ad7df1
Fix some issues with global-label fields' bounding boxes.
2022-03-19 19:37:01 +00:00
2bba277c5e
Unit binder: fix hang and DIALOG_WIRE_BUS_PROPERTIES: fix uninitialized variable.
...
The hang can be Windows specific.
2022-03-19 10:22:41 +01:00
7b82c2ba85
Preload eeschema find with selection when appropriate.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11148
2022-03-18 23:31:30 +00:00
41c0009c51
Off-grid ERC warnings.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10379
2022-03-17 20:23:56 +00:00
77c52ad5df
Fix a compil warning (shadowed var).
2022-03-17 20:13:17 +01:00
400cff994d
Update value & footprint from clipboard whether keeping annotation or not.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11116
2022-03-17 18:19:13 +00:00
deb7a0beff
Avoid marking symbols that will not be processed
...
We want to shorting the processing time by marking symbols that have
already been processed. But we must avoid marking symbols that will not
be processed due to their other flags
Fixes https://gitlab.com/kicad/code/kicad/issues/11164
(cherry picked from commit 2208e0db16
2022-03-17 10:10:56 -07:00
05bca282f7
Re-entrancy blocker for line/wire/bus tool.
...
Also clear infobar messages after a cancelInteractive.
Fixes https://gitlab.com/kicad/code/kicad/issues/11155
2022-03-17 15:27:33 +00:00
e68e2e973e
Separate Line Properties dialog from Bus/Wire, and handle Junctions in Bus/Wire.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9979
2022-03-16 14:56:32 +00:00
1434988bf8
Formatting.
2022-03-16 14:56:32 +00:00
c16090cc42
Improve sheet schematic import from different project message.
...
https://gitlab.com/kicad/code/kicad/-/issues/11075
2022-03-15 18:16:56 -04:00
1f5ec30566
Fix and issue about 180 deg arcs in symbols from "old" libraries.
...
Can be seen with lib version 20201005, not with latest version.
The fix is similar to commit 8a17fb8dFixes #11130
https://gitlab.com/kicad/code/kicad/issues/11130
2022-03-15 11:31:58 +01:00
2cb719f0cf
Fix crash in SCH_LABEL_BASE::IsType() when the item is not living in a schematic.
...
It happens for instance when copying the item from the clipboard.
Fixes #11128
https://gitlab.com/kicad/code/kicad/issues/11128
2022-03-14 09:23:16 +01:00
38cde901b0
Don't use last-resolved caches for graphic lines.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11127
2022-03-14 00:31:56 +00:00
ec44dfa60f
Unescape value fields when pasting from legacy schematics.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11124
2022-03-13 22:17:44 +00:00
d653484d72
Move connected_items from hash table to tree
...
This gains about 10% speed in heavily connected sheets
Fixes https://gitlab.com/kicad/code/kicad/issues/10974
(cherry picked from commit 187aa1c171
2022-03-11 16:58:38 -08:00
5b5c7d41b4
Break up buildConnectionGraph for debugging
...
Needed to find bottlenecks in fns, so break out individual sections of
the massive function for easier understanding.
buildItemSubgraphs (one section of the previous function) would build
millions of connections that were never used as stacked pins created X!
connections. Also tested using sets instead of lists and keeping unique
lists to avoid flagging but none of these were as performant as using
flags to remember which items had already been processed.
Fixes https://gitlab.com/kicad/code/kicad/issues/10974
(cherry picked from commit 17b1b68ac7
2022-03-11 16:58:38 -08:00
7ab4d67e94
Make sure line style comboboxes get a default entry.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11083
2022-03-11 23:19:16 +00:00
dd1dbb81f6
Improve shared schematic file churn heuristics.
...
The previous solution cleared all of the fields and force the unit setting
to unit one which would have less than desirable effects when reusing a
schematic in another project. This solution forces all of the instance
settings to the first sheet instance of the current project to prevent file
change churn when changing shared sheets in the current project.
This will not prevent shared schematic file changes when the first sheet
instance data differs between projects.
2022-03-11 12:37:30 -05:00
bf5d585e24
Reduce shared schematic file change churn.
2022-03-11 00:32:34 +00:00
a9eb7a0e28
Make sure LIB_ID escape context allows for formatting constructs.
...
Also make sure that value field is updated from name changes when the
symbol is a power symbol (even if it's from the schematic instead of
the library).
Fixes https://gitlab.com/kicad/code/kicad/issues/11093
2022-03-10 13:46:42 +00:00
16a266301a
Remove double-call of settings from Netlister
...
Double-calls are no longer needed when using settings. They can
interfere depending on how the system executes the commands.
Removing keeps the last used plugin as the default, rather than the last
selected
Fixes https://gitlab.com/kicad/code/kicad/issues/11094
(cherry picked from commit e8ef863861
2022-03-09 17:12:41 -08:00
fd59179cd2
Avoid implementation dependent on events
...
Adding a page in the ctor can generate events that change the default
page. Instead, we set the default after all pages have been added,
avoiding the reset
Fixes https://gitlab.com/kicad/code/kicad/issues/10910
(cherry picked from commit 5314ba6440
2022-03-09 15:42:29 -08:00
6934bc124c
Move temp save files to temporary directory
...
Avoid excess writes to the project directory to dodge issues with remote
file systems not fully writing data.
wxRename works across disk boundaries (in theory) and falls back to
wxCopy/wxRemove when it fails
Fixes https://gitlab.com/kicad/code/kicad/issues/10747
2022-03-07 20:13:28 -08:00
c9fb95b888
Fix the order of evaluation in the arc printing
...
MapAngles will adjust by small amounts the angles t1 and t2. This
adjustment will determine the CW/CCW drawing. Therefore, the MapAngles
needs to be called explicitly before the Normalize180() call.
Left-to-Right evaluation is not a given for MSVC
Fixes https://gitlab.com/kicad/code/kicad/issues/11050
2022-03-07 16:43:13 -08:00
bf0f2aa4a8
Adjust bitmap text spacing a bit so it's closer to the stroke font.
...
This helps the text better match the highlighting when it gets small
enough that we switch to the bitmap font for performance.
2022-03-07 20:30:50 +00:00
1f745b000d
Special-case synthetic click after tool selection.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11057
2022-03-07 20:30:50 +00:00
39fa4e2065
Include textbox in movable objects.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11058
2022-03-07 10:33:59 +00:00
d3716b9956
Reentrancy block for symbol editor symbol properties dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11060
2022-03-07 10:26:18 +00:00
4923f02651
Reset GAL pen width between drawing text and border.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11059
2022-03-06 20:32:28 +00:00
3969045009
Don't bitmap multi-line SCH_TEXT.
...
The linespacing isn't even close and multi-line text is also likely to
have longer lines which makes the X offset get way off too.
2022-03-06 20:17:56 +00:00
6b3ed89248
Handle justified LIB_TEXT.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11052
2022-03-06 19:54:06 +00:00
14304215b3
Copy m_private flag in LIB_TEXT's clone().
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11051
2022-03-06 17:00:13 +00:00
c919817c18
Don't reserve space for private items when autoplacing.
2022-03-06 16:12:49 +00:00
dbfdd3fb56
Fix some Coverity warnings.
2022-03-06 09:48:33 +01:00
8fd87e1f04
Change connectivity item group from set to vector
...
Reserve space for new items to speed construction of connectivity graph
Fixes https://gitlab.com/kicad/code/kicad/issues/10974
(cherry picked from commit 7aebc4b11f
2022-03-05 13:04:11 -05:00
cd7141fd10
Cache read arc data for stability
...
Arcs can be altered by the process of changing from on-disk
representation to in-memory representation. Saving back to disk without
modifying the arc should not modify the calculated values.
This stores a copy of the on-disk representation that is only used to
save back to disk in the event that the arc is not modified during
editing.
Fixes https://gitlab.com/kicad/code/kicad/issues/10442
2022-03-04 15:20:31 -08:00
7ecc70a79d
Duplicate from selected or current
...
When double-clicking to open a symbol, it is no longer selected in the
tree. We need to use the `GetTargetLibId()` to pick the correct symbol
(first selected, then current) when using the duplicate command
Fixes https://gitlab.com/kicad/code/kicad/issues/11034
(cherry picked from commit 802d20c409
2022-03-03 16:04:22 -08:00
c025b4c73d
Save all stroke parameters of sch & lib shapes.
...
We were failing to save the line style, which caused ERC errors when
DEFAULT != SOLID.
2022-03-03 14:37:04 +00:00
76535d8572
Make LIB_ITEM::COMPARE_FLAGS really a flags field, and add ERC.
...
Before they were 1/2 treated as flags and 1/2 treated as a mode enum.
The ERC flag relaxes constraints on data that is settable in the
schematic editor.
Fixes https://gitlab.com/kicad/code/kicad/issues/11018
2022-03-03 13:27:18 +00:00
a0d68b8426
SCH_DIRECTIVE_LABEL: add missing virtual SwapData.
...
Fixes #11027
https://gitlab.com/kicad/code/kicad/issues/11027
2022-03-03 10:27:17 +01:00
c5d85e0b7e
Don't try to open cell editor on first focus.
...
It hasn't worked since we rejiggered the default grid selection mode
anyway, and for some reason it eats <esc> key events after the dialog
has been resized.
Fixes https://gitlab.com/kicad/code/kicad/issues/11015
2022-03-03 02:06:48 +00:00
fd4b4533b1
Remove some code that isn't used anymore.
2022-03-03 02:06:48 +00:00
548936bb22
Fix broken unit select context menu
...
The fix for https://gitlab.com/kicad/code/kicad/issues/10529 kicked the
subsequent IDs for unit selection off the maximum ID value for popup
menus. This increases the maximum popup number (integers are free)
(cherry picked from commit 79b6991d7b
2022-03-02 16:33:28 -08:00
8c36ba3653
Explicitly give unit values
...
Removes the ability to hide symbol units in file formats. This was
mostly the case for a while but there remained corner cases where we
left a default/hidden option
Fixes https://gitlab.com/kicad/code/kicad/issues/10888
2022-03-02 16:01:08 -08:00
984eb0fb40
Handle locally-coded file names for sheets
...
Windows can accidentally create forward slash-coded files. This simply
converts them to the proper unix-coded value when set
Fixes https://gitlab.com/kicad/code/kicad/issues/10964
(cherry picked from commit 429544c188
2022-03-01 17:23:30 -08:00
61acd607ad
Ensure fields are properly ordered
...
When reading sheet fields, we need to maintain a consistent order for
the mandatory fields as they are dereferenced by place. We force this
during the `SetFields()` call.
(cherry picked from commit 8385ce3021
2022-03-01 17:10:35 -08:00
ac87d5e940
Resolve text when requested
...
Getting resolved text for a symbol should always happen, even if we have
unresolved data in the instances
Fixes https://gitlab.com/kicad/code/kicad/issues/11003
(cherry picked from commit acb5ce7108
2022-03-01 15:11:06 -08:00
79ad15b4fa
Fix copy/pasta.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11005
2022-03-01 14:59:29 +00:00
4dc652497d
Put device-coloured fills on device layer.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10993
2022-02-28 21:11:01 +00:00
eb06ecab10
Avoid resolving text vars without screen
...
We need to keep the screen blank while initially loading a sheet before
the hierarchy is developed. Avoid resolving text variables during this
process
Fixes https://gitlab.com/kicad/code/kicad/issues/11000
(cherry picked from commit 63b06af6b1
2022-02-28 12:28:02 -08:00
b55bda8d6f
Font support for drawing sheet editor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10306
2022-02-28 18:05:26 +00:00
5503afc09a
Schematic: disallow center rotation, allow both endpoint rotations
...
Center rotation will often misalign lines to the grid, which is bad
until fix off grid items on the schematic.
We can rotate a connection end into a new connection or to become
collinear with an existing line, so we need to check for this at the end
of rotation.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10565
(cherry picked from commit 7d4cb91f39
2022-02-28 08:50:12 -08:00
f241617478
Be more careful about non-visible elements in fields autoplacer.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10774
2022-02-28 00:18:39 +00:00
c4d2ac570f
Don't allow break commands (or labelling cmds) on multiple wire selections.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10934
2022-02-27 23:15:07 +00:00
1f16092e29
Infobar warning if symbol loading was cancelled.
...
Also makes sure the progress dialog is closed when we're done reading
symbols (it used to stay up for much of the symbol editor initialization).
Also makes sure that any cancel in the preLoad step is honoured in the
sync step. (The preload is done because it is multi-threaded and therefore
faster than the single-threaded sync.)
Also makes sure that individual threads pay attention to the cancellation,
not just the GUI thread.
Fixes https://gitlab.com/kicad/code/kicad/issues/8372
2022-02-27 17:06:08 +00:00
535ea800c0
Honor modifier keys in diambiguation
...
Needs to be reset for the new action before selecting elements at a
point.
Fixes https://gitlab.com/kicad/code/kicad/issues/9712
(cherry picked from commit a30ad0b54a
2022-02-25 16:16:15 -08:00
78620347c8
Fixing Eagle refs that do not work with KiCad
...
KiCad has stricter requirements for what consititutes an annotated
symbol. This checks for and corrects annotations that begin with '#',
do not begin with a non-numeric character or do not end with a number
2022-02-25 23:42:47 +00:00
faa3829ad4
Add MRU to image placement tools
2022-02-25 13:18:43 -08:00
6d8507d44f
Formatting.
2022-02-25 17:36:35 +00:00
4c81bac9e3
Eeschema: ensure ERC exclusions list is up to date before saving it in *.kicad_pro
...
Fixes #10339
https://gitlab.com/kicad/code/kicad/issues/10339
2022-02-25 18:21:46 +01:00
67eb138a4b
Fix copy/pasta.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10957
2022-02-25 00:49:41 +00:00
a29968fa91
Make sure bitmap fallback is only used for non-cached text.
...
Also fixes backwards vertical justification for bitmap text.
Fixes https://gitlab.com/kicad/code/kicad/issues/10956
2022-02-24 18:16:45 +00:00
2042b08127
Performance optimizations for drawing (small) text.
2022-02-23 12:09:36 +00:00
d58427a519
Don't kill entire OpenGL cache on undo.
...
The comment regarding bitmaps was true for one more month in 2018, but
hasn't been true for the last 3 years, and clearing the cache is a huge
performance hit.
2022-02-22 23:09:55 +00:00
c7dda3fbec
Formatting.
2022-02-22 22:19:55 +00:00
e35c3f2b99
Schematic: handle switching h/v mode better while drawing lines
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10859
2022-02-21 17:03:43 +00:00
a2772b3363
Don't crash on highight net during drag.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10866
2022-02-21 13:30:15 +00:00
b0d7c82e64
Disable grid when ctrl/cmd key is down.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9995
2022-02-20 16:50:30 +00:00
d0749c4e9a
Schematic: more drag undo fixes
...
Drag was not clearing IS_CHANGED status of items that were moved by the
drag, but weren't selected or created by it.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10845
2022-02-20 11:49:18 +00:00
Marek Roszko
Jeff Young
jean-pierre charras
Wayne Stambaugh
Roberto Fernandez Bautista
Seth Hillbrand
Mike Williams
Eduardo Behr
Miklós Márton
Fabien Corona
Chetan Shinde
Jonathan Haas
dsa-t
Simon Richter
Sylwester Kocjan
markus-bonk
Steffen Mauch