Seth Hillbrand
4f672f0d39
Fixing a number of dynamic_casts
...
Dynamic casts should only be used when we explicitly check for the
resulting pointer to be NULL. Where we know the class is castable we
can use static_cast, save on overhead and ensure our resulting pointer
is non-null.
2018-10-11 15:24:12 -07:00
Seth Hillbrand
a16e21665a
view_layers: Initialize variables
...
Fixes a couple spots where uninitialized variables cause unknown results.
2018-10-11 14:08:35 -07:00
Jeff Young
a69635f539
Adjustment to net selector list sizing for GTK.
...
Thanks to John Beard.
2018-10-11 18:53:00 +01:00
Jeff Young
9f7bc6a9f9
A bit of a hack to keep OpenGL from puking.
2018-10-11 18:53:00 +01:00
Jeff Young
94cc1efbcc
Clear filter when poping up net selector.
...
Even when useful it's unexpected, and GTK has issues with focus
and selection inside the control, making it hard to clear.
2018-10-11 11:58:39 +01:00
Jeff Young
ff85798918
Increase list-item padding for GTK net selector.
2018-10-11 11:58:39 +01:00
jean-pierre charras
0dfd0c5f52
Minot cosmetic enhancement
2018-10-11 11:26:59 +02:00
Ronnie Gaensli
ab1f016132
Fix assert freeze of eeschema when ToHSV, h is Nan
...
Fixes: lp:1797006
* https://bugs.launchpad.net/kicad/+bug/1797006
2018-10-10 21:22:26 +02:00
Jeff Young
a0b8755f47
Filter <space> out of net filter box.
2018-10-10 19:49:06 +01:00
Jeff Young
01843290fc
Exclude space from net filter.
2018-10-10 19:49:06 +01:00
Jeff Young
609d497870
Remember settings in Global Track & Via Properties dialog.
2018-10-10 19:49:06 +01:00
Jeff Young
14721829d7
Hook up keyboard events to parent combobox of net selector.
2018-10-10 14:02:25 +01:00
Jeff Young
779ef044b7
Fix wxGrid column dragging bugs.
...
Close an open editor when dragging (as wxWidgets won't move it).
Make sure native column headers aren't in use where we need dragging:
their interaction with wxWidgets' dragging is buggy.
Fixes: lp:1796398
* https://bugs.launchpad.net/kicad/+bug/1796398
Fixes: lp:1796396
* https://bugs.launchpad.net/kicad/+bug/1796396
2018-10-09 21:33:43 +01:00
jean-pierre charras
37c2743fec
Fix a minor compil warning.
2018-10-09 17:03:43 +02:00
Jeff Young
bc69330fe0
Make sure filter text goes at the end.
...
Some platforms select-all on focus, meaning each character would
replace the pre-existing string.
2018-10-09 14:56:29 +01:00
Seth Hillbrand
81483a9670
ARC_ASSIST: Fix return type in bool check
...
The return for special angle check is boolean.
2018-10-09 05:37:48 -07:00
John Beard
c75d4b9ba1
Fix -Wreorder warning in common view-overlay.cpp
...
Simple fix - m_radius comes after m_{start,end}Angle in the class member list.
2018-10-09 11:08:56 +01:00
Jeff Young
9dfcc839a4
Fix color issues with cursor and sheet pins.
2018-10-09 11:08:56 +01:00
jean-pierre charras
4a92a5e628
Fix a Eeschema crash when using a SYMBOL_PREVIEW_WIDGET. Fix also a few draw artifacts.
2018-10-09 11:08:56 +01:00
jean-pierre charras
a6d014d959
Fix some artifacts when drawing items, both on Cairo and Opengl.
...
Fix also incorrect selection of De Morgan style selection in SYMBOL_PREVIEW_WIDGET.
2018-10-09 11:08:56 +01:00
Jeff Young
2d5baac77d
Fix up zoom and pan issues entering/leaving sheets.
2018-10-09 11:08:56 +01:00
jean-pierre charras
b42f94e27b
Eeschema, Cairo backend: fix a minor but annoying render issue.
2018-10-09 11:08:56 +01:00
jean-pierre charras
88cdce8d62
Make SYMBOL_PREVIEW_WIDGET working, and using the canvas type of the caller. Fix an issue with F3 zoom key in libedit.
2018-10-09 11:08:56 +01:00
Jeff Young
6f89b41f18
Cleanup.
2018-10-09 11:08:56 +01:00
jean-pierre charras
33386ec980
Fix zoom issues in Eeschema (F1 to F4 and popup zoom commands) Fix also not saving the Gal Canvas type on eeschema exit.
2018-10-09 11:08:56 +01:00
jean-pierre charras
f283667fb0
add option to switch between opengl and cairo in eeschema (step 1)
2018-10-09 11:08:56 +01:00
jean-pierre charras
58916a200e
Eeschema: Fix a crash at start in Debug mode
2018-10-09 11:08:56 +01:00
Jeff Young
e2ea9b772a
Fix offset issue when moving text.
2018-10-09 11:08:56 +01:00
jean-pierre charras
e55763947e
Set the reight grid visibility at start. Display axis in libedit and viewlib.
2018-10-09 11:08:56 +01:00
Jeff Young
fee52e127f
Add line style drawing.
2018-10-09 11:08:56 +01:00
Jeff Young
1e3a5c1b21
Fixup of last commit.
2018-10-09 11:08:55 +01:00
Jeff Young
0063f2c12d
Stroke rectangles after filling so fill doesn't cover 1/2 of stroke.
2018-10-09 11:08:55 +01:00
Jeff Young
3c82ad3220
Finish up the block rotate/mirror fixes.
...
Block rotate and mirror now work like they do in Pcbnew (that is
they're treated as part of the block move/duplicate/whatever
rather than finishing it).
Fixes: lp:1780794
* https://bugs.launchpad.net/kicad/+bug/1780794
2018-10-09 11:08:55 +01:00
Jeff Young
7216eda202
Fix bugs in block operations.
...
1) when duplicating don’t keep original hidden until end of drag
2) reset selectionArea when showing it so it doesn’t flash in its previous location
3) center a pasted block on the cursor
4) don’t draw the source selectionArea when pasting a block
5) implement selection-style highlighting for contents of blocks
6) add pasted items to view so they don’t disappear when the block is placed
Fixes: lp:1747197
* https://bugs.launchpad.net/kicad/+bug/1747197
2018-10-09 11:08:55 +01:00
Jeff Young
cb8e6c0df5
Handle GAL view refresh for breaking wires.
2018-10-09 11:08:55 +01:00
Jeff Young
38f38b16c0
Fix dissappearance of moved items.
2018-10-09 11:08:55 +01:00
Jeff Young
5fd20ee786
Implementation of ERC markers.
2018-10-09 11:08:55 +01:00
Jeff Young
58100b62e6
Legacy colors are not stored under a "4D" name.
2018-10-09 11:08:55 +01:00
Jeff Young
d7178c7833
Implement GAL refresh for a bunch of operations.
2018-10-09 11:08:55 +01:00
Jeff Young
afeebc8944
Grid settings for Eeschema GAL.
...
Split antialiasing options out from display options. Move
antialiasing to common. Duplicate the rest of display options
for Eeschema.
Implement OnSelectGrid and hookup GAL canvas refresh to
SetPresetGrid.
Add Grid Settings... to View menu and move Show Grid from
preferences to View Menu to match Pcbnew.
2018-10-09 11:08:55 +01:00
Jeff Young
c5330ac0bf
Implement zoom for GAL canvas.
2018-10-09 11:08:55 +01:00
Jeff Young
a67d8c60df
Fix text size measurement.
...
5.0 doesn't set the GAL's line width. It gets away with this since
it's using the same GAL to measure as to set up the drawing, so
the width happens to be set correctly for other reasons. 5.1 uses
a separate GAL and so isn't so lucky.
2018-10-09 11:08:55 +01:00
Jeff Young
b002b96db6
Fix a crash when aborting a block command.
2018-10-09 11:08:55 +01:00
Jeff Young
515135579b
UseGalCanvas() no longer means ToolManager() exists.
2018-10-09 11:08:55 +01:00
Jeff Young
da4fb4ae3a
Move galDisplayOptions access from pcbnew to common.
2018-10-09 11:08:55 +01:00
Tomasz Wlostowski
48d36f854e
eeschema-gal: fix cursor shape switching
2018-10-09 11:08:55 +01:00
Tomasz Wlostowski
ccb594f599
eeschema-gal: support for global labels and bitmaps
2018-10-09 11:08:55 +01:00
Tomasz Wlostowski
d9f0dc63a5
eeschema-gal: temporarily disable scrollbar code (causes crashes after Jeff's changes)
2018-10-09 11:08:55 +01:00
Tomasz Wlostowski
b604f007d7
eeschema-gal: don't use kiROUND in the geometry library as it brings in a s*****load of wx dependencies due to #include <base_units.h>
2018-10-09 11:08:55 +01:00
Tomasz Wlostowski
5f7c923b8b
eeschema-gal: post-rebase fixes
2018-10-09 11:08:52 +01:00