209ff933e7
Sim: Ignore everything between principal value and parameter-value pairs
2022-10-21 18:55:40 +02:00
f95e77499b
Sim: Make exception messages slightly more verbose
2022-10-21 08:15:29 +02:00
9819fa43dd
Sim: Allow principal value in Value field to be followed by regular params
2022-10-21 08:14:13 +02:00
d01dcc1c51
Sim: Interpret anything starting with .inc as .include
2022-10-20 05:13:32 +02:00
662f6c7d83
Sim: Don't match newlines in model names
...
This caused errors in AKO models with no overrides.
2022-10-20 04:00:33 +02:00
7ad927671d
Sim Ltspice compat: Narrow ignoring undocumented parameters
2022-10-20 04:00:33 +02:00
5878749ed2
Sim LTspice compat: Ignore undocumented LTspice diode parameters
2022-10-20 04:00:33 +02:00
85805bdad7
Fix broken legacy file format symbol instance data import.
2022-10-19 12:23:28 -04:00
c4db7337d0
NETLIST_EXPORTER_SPICE: add missing switch to "C" locale (missing LOCALE_IO).
...
It breaks spice netlist in countries using a comma as floating number separator.
2022-10-19 11:50:35 +02:00
7378aaae9d
Sim: Ignore the "mfg" parameter in all models
2022-10-19 06:53:39 +02:00
952f3da53f
Sim: Only set sim command if the sheet sim command is different
2022-10-19 03:02:32 +02:00
f68df09696
Sim: Fix analysis set from GUI
2022-10-19 02:32:50 +02:00
1965411bf5
Sim: Remove the parsing exception for LTspice compat
...
Silently ignoring this may be a cure worse than disease.
2022-10-18 23:19:48 +02:00
2a13c0af2e
Revert commented out code.
2022-10-18 16:07:14 -04:00
1964087960
Fix some instance-data issues in netlist exporters.
...
Also removes the final requirements for setting the current sheet so
that we no longer need to do a save/restore.
2022-10-18 17:26:34 +01:00
6e874f4c1e
Ngspice: Preload a basically empty circuit to avoid error messages
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12481
2022-10-18 05:48:01 +02:00
598b09821a
Coverity fixes.
2022-10-17 15:30:20 -04:00
aa36e15d66
Eeschema, Print preview: fix a incorrect initial size on wx 3.1.7 (and later)
...
Due to internal changes in wxWidgets, the initial size of the frame was not taken in account.
2022-10-17 10:49:28 +02:00
2475a703d6
Sim Model Editor: Checkbox for toggling inference
2022-10-16 05:10:57 +02:00
c8e13813d9
Sim: Rename Sim_Disabled field to Sim_Enable
2022-10-16 00:49:44 +02:00
b109136c5c
Fix complex hierarchy instance data when loading legacy schematic.
2022-10-15 14:50:06 -04:00
f782323960
Fix yet another symbol instance issue when loading legacy schematics.
2022-10-15 14:16:03 -04:00
254dff2813
Add do_not_autoplace to schematic parser and printer.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12657
2022-10-15 19:09:25 +01:00
c3d5b3b3e5
Sim: Only store device type in reference, not full model type
...
Instead of Reference="VSIN1", Value="dc=1 ampl=2 f=3", it's now
Reference="V1", Value="SIN dc=1 ampl=2 f=3".
2022-10-15 19:36:26 +02:00
6ce714d537
Use wxCHECK instead of wxCHECK2
2022-10-15 11:25:15 -04:00
ce2d091588
wxCHECK2 needs an actual "op", in this case return
2022-10-14 21:01:49 -04:00
5c974f8cd0
Don't arbitrarily close tags that are not open
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12647
2022-10-14 15:30:51 -07:00
668180f96a
Add "show field names" to Global Edit Text & Graphics Properties.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12641
2022-10-14 23:04:09 +01:00
7ffdfb1067
Clear Scintilla undo history after setting initial text.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12650
2022-10-14 22:01:20 +01:00
41461f7a69
Improve symbol rescue dialog.
...
* Fix some minor layout issues on Linux.
* Use button labels to clarify rescue actions.
2022-10-13 10:37:04 -04:00
f9a791e2b0
Copy font across when changing text type.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12629
2022-10-12 23:49:40 +01:00
430098791e
Another attempt to fix schematic symbol rescue issues.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12624
2022-10-12 16:57:09 -04:00
8dea227da7
Special cases for sheet-pin dragging.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11949
2022-10-12 16:36:54 +01:00
3231bc5be3
Formatting and cleanup.
2022-10-12 16:36:54 +01:00
5507748fa9
Make sure bounding box is not degenerate.
2022-10-12 16:36:54 +01:00
806b5fab0e
SYMBOL_LIBRARY_MANAGER::SaveLibrary(): Add missing code.
...
It fixes an issue after deleting a symbol and trying to save the library:
The library, although saved, was always flagged as modified.
2022-10-12 15:56:41 +02:00
c857e533a9
Sim: Fix crash when a field tries to set an inexistent parameter
...
Refactored SetParamValue() and friends to use exceptions instead of
return values.
2022-10-12 04:27:48 +02:00
6ae333a116
Sim Model Editor: Fix crash when opening sources
2022-10-12 04:27:48 +02:00
bd1114d94d
Move footprint properties dialogs to symbol properties grid resizing strategy.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9883
2022-10-12 00:38:44 +01:00
e02c05d38f
Add unit and eval support to WX_GRIDs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/1871
Fixes https://gitlab.com/kicad/code/kicad/issues/4285
2022-10-11 23:40:58 +01:00
ad5df7f4cc
More busy cursor tightening.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11648
2022-10-11 23:40:58 +01:00
148467d2a1
Fix schematic symbol rescue issues.
...
This fix makes some fundamental changes to the way symbols are rescued:
* The new symbol library file format is used when rescuing symbols defined
in the symbol library table.
* The original library nickname is appended to the symbol name rather than
the rescue library nickname when rescuing symbol defined in the symbol
library table.
* Escaping strings has been removed from legacy library rescues since the
legacy library file format never supported it.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12525
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12624
2022-10-11 16:18:59 -04:00
8206283a20
Code clarity.
2022-10-11 11:22:26 +01:00
3967435f94
Tighter control of busy cursor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11648
2022-10-11 11:22:26 +01:00
d3797dd183
Code clarity. (No functional changes.)
...
Also some more error message cleanup for consistency.
2022-10-11 11:22:26 +01:00
8a9e92bc01
More consistency in error messages.
2022-10-11 11:22:26 +01:00
d47752ad75
Sim Model Editor: Fix displaying Ibis pin list
2022-10-11 02:22:59 +02:00
d9eb76eae0
Sim: Refactor SPICE_GENERATOR methods to accept a single SPICE_ITEM
2022-10-11 02:22:59 +02:00
1825905011
Replace more-than-half-line algorithm with greedy/stingy check.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10860
2022-10-10 20:23:48 +01:00
cb20a39693
Always select whole lines with greedy selection.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10869
2022-10-10 20:17:15 +01:00
3221877fe8
Push autosave-require down in to EDA_BASE_FRAME.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11790
2022-10-10 14:03:52 +01:00
be6f08deca
Code clarity. (No functional changes.)
2022-10-10 14:03:52 +01:00
6d958c5a3b
Sim: Remove some superfluous class members
2022-10-10 13:49:43 +02:00
4931b80066
Sim: Resolve name collisions for generated model names
2022-10-10 13:38:35 +02:00
72402cf687
Sim: Override base model type if there's a Sim_Type field
2022-10-09 20:46:05 +02:00
79c301800a
Eeschema printing: fix some issues.
...
The offset setting was incorrect when using wxAffineMatrix2D.
It was especially visible when printing more than one sheet.
Note also when not using wxAffineMatrix2D, all pages must have the same orientation
(PORTRAIT/LANDSCAPE is not managed)
Fixes #12211
https://gitlab.com/kicad/code/kicad/issues/12211
2022-10-09 18:20:19 +02:00
f5fd12c002
Symbol Editor: Fix reverting changes on a root symbol: derived symbols are displayed wrong
...
Reverting changes broke links between derived symbols and the root symbol.
Now fixed by do not delete and recreate reverted symbol.
Fixes #10792
https://gitlab.com/kicad/code/kicad/issues/10792
2022-10-08 15:56:24 +02:00
994274fe9f
Move IBIS model Spice code generation to SIM_MODEL_KIBIS
...
IBIS drivers are temporarily broken. Will fix is subsequent commits.
2022-10-08 03:01:52 +02:00
a5da46459c
Be sure to update UUID when placing new elements
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12588
2022-10-07 16:32:41 -07:00
8c19bf4815
eeschema: fix arc orientation issue when reading old symbol libs (version 20210619).
...
Fixes #12514
https://gitlab.com/kicad/code/kicad/issues/12514
2022-10-07 16:57:45 +02:00
01a1d148e6
Make a sentence understandable and translatable.
...
Fix a minor compil warning
2022-10-07 10:11:02 +02:00
b4c18dd22a
Correct error message when unit counts differ
...
Testing if the symbol associated with unit X has a different number of
total units than the symbol associated with unit Y should report the
actual error to the user.
This cleans the various display of these error messages
Fixes https://gitlab.com/kicad/code/kicad/issues/10237
2022-10-06 15:41:16 -07:00
f369cc23a9
Handle arbitrary unit counts
2022-10-06 15:41:16 -07:00
19d270fe74
Text size sanity checking for TEXT_ITEMS_GRID.
...
Oh dear, there was a bunch going on here. Firstly the move from int
to long long int for ValueFromString() means that we were no longer
catching overflows (as we were C-style casting it back to int in many
places). But even when the overflow is caught, it would run in to
wxWidgets' empty string bug while trying to log it.
Fixes https://gitlab.com/kicad/code/kicad/issues/12577
2022-10-06 13:19:08 +01:00
6f2b2d7e19
Sim: Minor SIM_LIBRARY cleanup
2022-10-06 14:08:01 +02:00
b95f4ec6bb
Sim: Use the new library manager class in Spice netlist exporter
...
Temporarily comment out IBIS processing.
2022-10-06 09:49:29 +02:00
c019ae3b89
Add missing include
2022-10-05 20:21:38 +03:00
a0aff2dc70
Set the proper symbol parent when duplicating
...
We need to handle both the case where the new symbol is an alias as well
as free the proper memory after loading symbols in the duplicate
Fixes https://gitlab.com/kicad/code/kicad/issues/12578
2022-10-05 09:46:13 -07:00
6df774a62f
Commit missing sin_lib_mgr.{cpp,h}
2022-10-05 18:08:25 +02:00
44799c830d
Sim: Create a class to manage sim libs and inherited models
2022-10-05 17:19:28 +02:00
0336cff8d6
Allow schematic symbol value and footprint fields to be instantiated.
2022-10-05 11:12:21 -04:00
8e34dae347
Sim Model Editor: Fix exclude symbol checkbox
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12344
2022-10-05 11:24:46 +02:00
03d847118a
Fix crash when copying symbol in schematic editor.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12574
2022-10-04 17:51:58 -04:00
2f756d9d23
Sim Model Editor: Fix Model panel sizing
2022-10-04 23:47:52 +02:00
e99d531c88
Sim: LTspice model compat: Ignore spurious values
...
Also fix parsing type in ako models
2022-10-04 22:44:26 +02:00
a11c40197f
Expunge default symbol instance from schematic file format.
...
Now that importing hierarchical sheets "properly" imports instance data,
the default symbol instance setting doesn't have any meaning.
2022-10-04 15:42:41 -04:00
120b569048
Sim: Support ako models
2022-10-04 17:48:10 +02:00
c2765f40ca
Sim Model Dialog: Fix nullptr dereference
2022-10-04 17:48:10 +02:00
4611817f25
Eeschema: fix a crash when invoking eeschema.exe with 2 filenames to open
...
Fix also a minor compil warning
2022-10-04 16:56:13 +02:00
f5f6d44a48
Correctly increment field IDs
...
Setting to -1 is no longer valid despite the previous comment as this
will pick out a single non-mandatory field to save
Fixes https://gitlab.com/kicad/code/kicad/issues/12567
2022-10-03 21:50:29 -07:00
fb8a4c10f7
Shove kicad2step into pcbnew itself with a new cli
2022-10-04 01:53:37 +00:00
c5f8587898
Use closest point for duplicate anchor rather than top-left.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10004
2022-10-03 23:28:58 +01:00
7bb0275d3c
Fix incompatibility with old rubber-band wire algo and new ortho wire drag alog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11948
2022-10-03 22:12:23 +01:00
c6284f4835
Formatting.
2022-10-03 22:12:23 +01:00
c464c5b87b
Sim: cleanup: use unique_ptr for PARAM::value
2022-10-03 22:15:14 +02:00
9186be600b
Fix resource leak
2022-10-02 21:10:27 -07:00
e335c1c612
Fix for LIB_TREE hotkeys over canvas and possible fix for over LIB_TREE itself.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11034
2022-10-02 22:22:21 +01:00
e055302a3c
Allow printing backgrounds prior to foreground
...
Eeschema shows background fills on a different z-level than the rest of
the symbols/elements. Print the backgrounds prior to the foregrounds in
order to preserve this view for print output
Fixes https://gitlab.com/kicad/code/kicad/issues/12559
2022-10-02 13:23:54 -07:00
2b387ae9c3
Move schematic symbol instance data back into symbol definition.
...
This change reverts the storage of all symbol instance data in the root
schematic. This was done because it's not possible to reuse instance
data when importing from sub-sheets.
There has been a fundamental change in how sheet paths are store in the
instance data. The root schematic UUID is always used when saving the
instance data. To prevent file churn, the virtual root sheet UUID is set
to the root schematic UUID when loading the project. This provides a way
to determine the project that stored the instance data. All uses of paths
without root sheet have been expunged from the code.
The sheet instance data is still saved only in the root sheet for the
time being. New sheet instances will be automatically assigned an page
number based on the incremental virtual sheet page number. Sheet page
numbers will not be imported.
Added project name to instance data to improve the readability of the
schematic file format. It also creates an opportunity to remove orphaned
instance data by project name rather than cryptic UUIDs.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12472
2022-10-02 15:06:42 -04:00
27296b5043
Quote all bus members when writing to file.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12447
2022-10-02 17:43:47 +01:00
eea8c7a8fd
Handle netclasses assigned to bus labels.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12546
2022-10-02 15:01:16 +01:00
c089afb408
Improve default net pattern to be all members of bus instead of first member.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12546
2022-10-01 22:58:11 +01:00
9adae0e8ba
Avoid double-processing SCH_ITEMs
...
Elements such as zero-length lines might get into the connection map,
causing the system to process them twice. This can cause allocation
errors when both are performed at the same time
Fixes https://gitlab.com/kicad/code/kicad/issues/12278
2022-10-01 12:28:39 -07:00
efdb67aa64
Minor fixes.
2022-10-01 18:42:02 +02:00
93239516d9
Remove ID from property fields
...
ID was not maintained or used other than to ensure unique fields.
Instead of saving, we assign the known IDs to specific field names and
sequentially create new IDs on load
Fixes https://gitlab.com/kicad/code/kicad/issues/12390
2022-09-30 17:19:53 -07:00
c0a666507c
Work around more instances of the wxWidgets color string locale bug.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12552
2022-09-30 20:56:25 +01:00
0d369f700f
Sim: Basic cleanup after KIBIS merge
...
- Some preliminary refactoring,
- Use multiple types for IBIS drivers instead of a wftype variable,
- Remove the m_requiresUIUpdate variable and its accessors.
2022-09-30 16:17:00 +02:00
62f89ba0d6
Sim GUI: Remove irrelevant references to Spice
2022-09-30 14:32:57 +02:00
67caebe4c4
When the sash button is right next to the fp dropdown they look related.
2022-09-30 13:02:08 +01:00
c1da59b560
Swap: disallow swapping tracks / wires
...
Also fix missed shortcut change for S -> Shift-S
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12538
2022-09-29 17:04:43 -04:00
Mikolaj Wielgus
Wayne Stambaugh
jean-pierre charras
Jeff Young
Marek Roszko
Seth Hillbrand
Alex
Mike Williams