haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
34,754 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

14147 Commits

Author SHA1 Message Date
Jeff Young ce2dbdec75 Formatting and a bit of cleanup. 2022-10-21 18:41:39 +01:00
Jeff Young d16b23d16e Name shortening and line-break reduction. 2022-10-21 18:41:39 +01:00
Seth Hillbrand d1bf889e71 Resolve embedded text vars 
Title Block text variables are embedded into the pcb file and should
be used for resolving when the project file is missing
 2022-10-21 08:37:37 -07:00
Alex 67985510a8 Fix selecting pads of footprints in groups. 2022-10-21 17:13:24 +03:00
Jeff Young 585fac19c6 Copy connected-only and keep-top-bottom properties. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12691
 2022-10-21 00:05:11 +01:00
Jeff Young 6fd195c389 Use comma to separate diff pair nets/netclassse rather than /. 
("/" is problematic because it's more likely to appear in netnames.)

Fixes https://gitlab.com/kicad/code/kicad/issues/12592
 2022-10-21 00:05:11 +01:00
Jeff Young 3451506d25 Slight performance improvement. 2022-10-20 18:37:48 +01:00
Jeff Young 323c04af2c Fix order-of-ops issue with calling collide before tesselating. 2022-10-20 18:37:48 +01:00
jean-pierre charras 6aa515e2f8 board_stackup_manager: fix incorrect behavior when adding a new dielectric layer. 
Fixes #12680
https://gitlab.com/kicad/code/kicad/issues/12680
 2022-10-20 11:27:35 +02:00
Jeff Young e3842514e7 Move courtyard collision setting to preferences. 
Also cleans up PCBNew/FPEditor edit options panel to be more in sync
with each other.
 2022-10-19 11:33:11 +01:00
Jeff Young 403cc50e7c Don't exit group when the cancel went to another tool. 
Also fixes a bug where the group border didn't get updated immediately
on enter/exit.

Fixes https://gitlab.com/kicad/code/kicad/issues/12669
 2022-10-18 17:53:06 +01:00
Jeff Young 8d40bf25d6 Need to setup outline mode stuff if it's turned on late. 2022-10-18 14:41:27 +01:00
Jeff Young 1f0fa3ef63 Fix bug in new optionally-flashed via/pad zone fill logic. 2022-10-18 14:02:47 +01:00
Jeff Young 4633d251a5 Remove single-zone-fill and unfill. 
These are incompatible with our zone-priority-based algorithms.
 2022-10-18 13:45:28 +01:00
Jeff Young 437d2c4589 Overhaul of remove-unconnected's zone filling and drawing strategies. 
1) The highest priority zone that a via/pad collides with "owns" its
connectivity state.  Once set, lower priority zones cannot change it --
and in fact, if they would have connected to it are forced not to.

2) The connectivity state goes with the zone fill state, and therefore
must be saved in the file.

3) Display of remove-unconnected's pads is no longer done in GetViewLOD()
(which isn't called for selected items), and is instead done in PCB_PAINTER.
This allows us to draw the full pad in outline mode when a via/pad is
selected which would otherwise only show the hole.

4) Note that in some cases this will still generate DRC errors -- in
particular when a via nearly collides with a higher priority zone it
won't get "owned" by that zone and may therefore have insufficient
clearance if said zone concludes it's unconnected and a subsequent
(lower priority) zone connects to it (causing it to now become flashed).

Fixes https://gitlab.com/kicad/code/kicad/issues/11299
 2022-10-18 13:05:42 +01:00
Wayne Stambaugh 598b09821a Coverity fixes. 2022-10-17 15:30:20 -04:00
Jeff Young 92f1ee556f Don't fill drawing sheet rects with transparent fill. 
It might make sense to do that with board and/or schematic items for
hit-testing or something, but it definitely doesn't make any sense for
the drawing sheet border.

Also, when reading in items with a transparent fill, treat them as
unfilled (otherwise we get filled with layer colour in at least PCBNew).
 2022-10-17 17:51:11 +01:00
Jeff Young 413fd82813 Re-entrancy guard for router tool. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12604
 2022-10-17 13:21:07 +01:00
Jeff Young 46752499df We need both a tool-oriented delete and one that doesn't push/pop, etc. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12600
 2022-10-17 13:21:07 +01:00
jean-pierre charras f3bb34779a TransformTextShapeWithClearanceToPolygon() add optimization for 3D viewer. 
This function convert a text shape to a set of polygons for the 3D viewer.
Texts shapes are a bit special and can generate a lot of small overlapping polygons.
These polygons are now merged before being added to the list of polygons handled
by the 3D viewer draw functions.
Locally merging polygons is usually not efficient but in this case it can speedup
the 3D viewer (up to 10x).
Mainly noticeable for silkscreen layers when the "copper" thickness is shown
 2022-10-17 07:32:30 +02:00
Jeff Young 3e53426b6c Use same ratsnest colours in the router as the rest of KiCad. 2022-10-16 22:21:14 +01:00
Jeff Young e9f8454a67 No DRC engine in footprint editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12658
 2022-10-16 18:39:37 +01:00
Jeff Young 631980b0ab We were saving the old board pointer, but not updating the current one. 
This also makes a few other adjustments to order and to where we look
for the enabled layers which should make it more robust.

Fixes https://gitlab.com/kicad/code/kicad/issues/10925
 2022-10-16 18:39:37 +01:00
Jeff Young 73e1676bdb Fix const-reference property access. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12639
 2022-10-15 20:22:38 +01:00
Jeff Young d1fb32f26c Formatting. 2022-10-15 19:09:25 +01:00
Jeff Young 4af98827fd Revert change for 11299, and update removed-pad items after zone fills. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12645
 2022-10-15 16:06:57 +01:00
Jeff Young b012cc1ac3 Don't resolve footprint text variables in footprint editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12658
 2022-10-15 16:05:22 +01:00
Jeff Young 0d7185c2ff Fix mismatch between PCB_VIA defaults and file format defaults. 2022-10-15 11:17:58 +01:00
jean-pierre charras a855c9a40c Fix not handled exceptions. 2022-10-15 10:27:00 +02:00
jean-pierre charras 8098db2a20 BuildBoardPolygonOutlines: enable multiple main outlines: it works fine in 3D viewer. 2022-10-15 09:33:27 +02:00
Seth Hillbrand 697056fa7e Correctly sort positions for default align 
When not aligning under mouse cursor, choose the X-most element where X
is top/bottom/left/right.  Previous sorting was not correct for two
directions

Fixes https://gitlab.com/kicad/code/kicad/issues/12627
 2022-10-14 16:15:06 -07:00
Jeff Young 7ffdfb1067 Clear Scintilla undo history after setting initial text. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12650
 2022-10-14 22:01:20 +01:00
Jeff Young 6f9bc0980b Refactor poly outline generator to handle multiple outlines. 
Note: disjoint outlines are handled in footprint courtyards, but not
for board outlines.

Fixes https://gitlab.com/kicad/code/kicad/issues/7660
 2022-10-14 20:32:04 +01:00
Jeff Young 6357c83a8c Debug code to try and catch Undo/SyncWorld mismatch. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12640
 2022-10-14 13:25:25 +01:00
Jeff Young 07d9671126 Repair unbalanced UndoRedoBlock call. 2022-10-14 11:44:04 +01:00
Jeff Young b01bf081d8 Cleanup. 2022-10-14 11:12:25 +01:00
Jeff Young de5980b92e Share more of the courtyard collision highlighting code. 2022-10-14 10:42:07 +01:00
Jeff Young 11dc5424cb Pull interactive courtyard checker out of move tool to share with router. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12594
 2022-10-14 00:48:37 +01:00
Jeff Young 8f1b4a9c03 Include cleanup. 2022-10-13 23:15:41 +01:00
Jeff Young 3090363cd5 Copy via flags down to the level the router consumes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12591
 2022-10-13 17:41:42 +01:00
Jeff Young 46a41e2e34 Pin 0-sized pads at 1um rather than throwing them out. 
(See bug report for more commentary.)

Fixes https://gitlab.com/kicad/code/kicad/issues/12617
 2022-10-13 14:47:50 +01:00
Jeff Young 08260661b8 Force flashing when generating SOLIDs. 
We only have a single SOLID per pad, so the solid's shape must always
be the flashed shape and then we can do layer-specific flashing tests
internally.

Fixes https://gitlab.com/kicad/code/kicad/issues/12458
 2022-10-13 13:05:51 +01:00
Jeff Young d1450e1802 Commenting. 2022-10-13 13:05:51 +01:00
Jeff Young 8b9cbd5805 Don't reset editPad if it still exists after model reset. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12630
 2022-10-13 00:07:30 +01:00
Jeff Young efa14e501c Cleanup. 2022-10-12 16:36:54 +01:00
jean-pierre charras d0d625dcb5 BOARD_INSPECTION_TOOL::LocalRatsnestTool(): set a suitable cursor when activated. 2022-10-12 15:56:41 +02:00
Jeff Young bd1114d94d Move footprint properties dialogs to symbol properties grid resizing strategy. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9883
 2022-10-12 00:38:44 +01:00
Jeff Young e02c05d38f Add unit and eval support to WX_GRIDs. 
Fixes https://gitlab.com/kicad/code/kicad/issues/1871

Fixes https://gitlab.com/kicad/code/kicad/issues/4285
 2022-10-11 23:40:58 +01:00
Seth Hillbrand c9f11827a7 Don't connect disparate nets 
Only some elements get their nets assigned based on connectivity.  Other
elements should be keps in different clusters for connection

Fixes https://gitlab.com/kicad/code/kicad/issues/12622
 2022-10-11 15:03:51 -07:00
Jeff Young 57a6aeb86a Redraw ratsnest after removing teardrops. 
No, I don't know why this is needed.  But after a couple of hours trying
to chase it down, return-on-investment is fading....

Fixes https://gitlab.com/kicad/code/kicad/issues/12420
 2022-10-10 21:07:18 +01:00
Jeff Young 83310659fd Basic geometry: R != D. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12601
 2022-10-10 19:18:37 +01:00
Jeff Young 8470b178cd Use actual pad shapes or built outline instead of effective shpaes for anchors. 
The effective shapes don't work very well in the custom pad or rounded
rectangle cases, and they're somewhat slower in some of the other cases.

Fixes https://gitlab.com/kicad/code/kicad/issues/12601
 2022-10-10 18:11:32 +01:00
Jeff Young 3221877fe8 Push autosave-require down in to EDA_BASE_FRAME. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11790
 2022-10-10 14:03:52 +01:00
Jeff Young be6f08deca Code clarity. (No functional changes.) 2022-10-10 14:03:52 +01:00
Jeff Young b2f05c758b We don't always have a line when dragging. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12612
 2022-10-10 11:44:17 +01:00
Jeff Young ea6fb84351 Formatting. 2022-10-10 11:44:17 +01:00
aris-kimi 6bc00eabaf dialog_dxf_import dialog minor UI fixes 2022-10-10 02:51:24 +00:00
Jeff Young 35a14b8e5d Better error messages (and make an empty pad an error, not a warning). 2022-10-09 20:28:54 +01:00
Jeff Young e866dfe137 Avoid trying to draw empty pads. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12605
 2022-10-09 20:28:54 +01:00
Jeff Young 4a66203493 Update zone layers for all layers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12128
 2022-10-08 23:27:59 +01:00
Marek Roszko 3b63ce8a48 Don't use the 3d resolver config anymore 2022-10-08 14:27:10 -04:00
jean-pierre charras 27f8abd8a1 Fix compatibility with wxWidgets 3.0 
change wxOVERRIDE -> override
 2022-10-08 17:34:37 +02:00
jean-pierre charras faae4f9eea kicad2step: force immediate printing of messages (mingw issue: we need to flush the stdout buffer) 2022-10-08 16:43:14 +02:00
Marek Roszko aaa1d166a7 Redirect step export output to a pretty window 2022-10-08 09:48:00 -04:00
Jeff Young 51c20da93e Areas might have layers defined in area as well as rule. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12584
 2022-10-07 23:52:47 +01:00
Jeff Young 79dabdd484 Fix typo. 2022-10-07 23:52:47 +01:00
Alex 2577ebb94d Increase dynamic ratsnest opacity for better visibility. 2022-10-07 21:50:12 +00:00
Jeff Young 04fec5016b Add keepout zones set to keepout footprints to footprint courtyard checker. 
(This is for the move tool, not DRC.  DRC uses more sophisticated keepout
processing which is too slow for the move tool, and doesn't let us know which
keepout area collided for collision highlighting.)

Fixes https://gitlab.com/kicad/code/kicad/issues/12594
 2022-10-07 22:23:37 +01:00
Jeff Young d6f1d5da76 Start-routing list needs to be a white list, not a black list. 
We check the collisions later in the same routine, which is where all
the black-listed objects come in.

Fixes https://gitlab.com/kicad/code/kicad/issues/12595
 2022-10-07 18:18:02 +01:00
jean-pierre charras b8dfbe02ad Fix some issues in STEP exporter 2022-10-07 18:53:31 +02:00
Jeff Young bc58480e24 Missed some other uses of m_startItem in previous commit. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12592
 2022-10-07 14:01:46 +01:00
Jeff Young cbb997a3b5 Use GetCurrentNets(), not m_startItem for message panel updates. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12592
 2022-10-07 10:34:11 +01:00
jean-pierre charras 01a1d148e6 Make a sentence understandable and translatable. 
Fix a minor compil warning
 2022-10-07 10:11:02 +02:00
Alex 165654f114 Expose Switch Arc Posture in context menu. 2022-10-07 08:28:13 +03:00
Alex d26b59a0bf Improve arc construction using angles from arc geometry manager. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11713
 2022-10-07 06:51:00 +03:00
Alex 2741d0eb4b Fix crash on Specctra import. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12583
 2022-10-07 03:03:34 +03:00
Alex 22917860ef Move Enter Group for easier access. 2022-10-07 03:03:33 +03:00
Jeff Young 098e96f1c7 Use more precise formatting in DRC messages when less precise values are identical. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12587
 2022-10-06 22:18:53 +01:00
Jeff Young 9119b5072a Respect DRCEpsilon in diff-pair coupling test. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12587
 2022-10-06 22:18:53 +01:00
Jeff Young d6c7f46842 Formatting. 2022-10-06 22:18:53 +01:00
Alex 0fea6f5ac3 Fix selection and entering in nested groups. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12586
 2022-10-06 21:02:36 +03:00
aris-kimi f818f3a445 Fix footprint rule and zone area anchors 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12575
 2022-10-06 15:29:18 +00:00
Jeff Young 40ad5b6de3 Broaden reset-sizes-after-layer-switch algorithm. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12576
 2022-10-06 15:50:22 +01:00
Jeff Young 6927e75eae Handle keepout areas with holes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12581
 2022-10-06 15:08:56 +01:00
Jeff Young 19d270fe74 Text size sanity checking for TEXT_ITEMS_GRID. 
Oh dear, there was a bunch going on here.  Firstly the move from int
to long long int for ValueFromString() means that we were no longer
catching overflows (as we were C-style casting it back to int in many
places).  But even when the overflow is caught, it would run in to
wxWidgets' empty string bug while trying to log it.

Fixes https://gitlab.com/kicad/code/kicad/issues/12577
 2022-10-06 13:19:08 +01:00
Jeff Young d8a3ba7917 Update router sizes when switching layers. 
We may have layer-specific rules involved.  Note that at some point
we also need to do something similar on every "fix route" step to
handle area-specific rules.

Fixes https://gitlab.com/kicad/code/kicad/issues/12576
 2022-10-05 16:45:42 +01:00
Mark Roszko 6ddc5c1a6e Fix run from build dir for step 2022-10-05 03:53:56 +00:00
Marek Roszko 3fe004fd1b New kicad-cli will now be the cli interface 2022-10-04 22:24:13 -04:00
Seth Hillbrand 87171f53c7 Speedup dynamic ratsnest 
Removes some unneeded calculations and threads the remaining.

Threading was previously removed to avoid overhead issues with small
boards.  This is no longer needed with the thread pool implementation

Fixes https://gitlab.com/kicad/code/kicad/issues/12131
 2022-10-04 17:06:45 -07:00
Seth Hillbrand a0865082fb Fix compile warnings 2022-10-04 17:06:45 -07:00
jean-pierre charras 0c7b6c3cbc fix minor compil warnings 2022-10-04 19:51:51 +02:00
Seth Hillbrand b4f3390626 Drill size is absolute 
Use hole plating size for visibility only, not zone filling, routing or
DRC
 2022-10-04 09:52:40 -07:00
Jeff Young 436d75e7f9 Try to reconcile SELECTION and BRIGHTENED use of overlay. 
For some reason the overlay doesn't get redrawn during the PCBNew
selection disambiguation menu, so we need to not hide BRIGHTENED
items.

Fixes https://gitlab.com/kicad/code/kicad/issues/12547
 2022-10-04 17:01:56 +01:00
Jeff Young 524a43f95e Don't select footprints on the wrong side if not visible. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12483
 2022-10-04 13:22:06 +01:00
Mark Roszko fb8a4c10f7 Shove kicad2step into pcbnew itself with a new cli 2022-10-04 01:53:37 +00:00
Seth Hillbrand b716afd6f1 Clarify various uses of "Center" 
Distinguish between the english verb "Center" and the noun "Center",
which may be translated differently

Fixes https://gitlab.com/kicad/code/kicad/issues/11109
 2022-10-03 12:48:57 -07:00
Seth Hillbrand 15d52c91e4 Clear ratsnest when removing nets 
While we can keep the vector for nets, we need to ensure that the data
are cleared to prevent stale pointer access

Fixes https://gitlab.com/kicad/code/kicad/issues/12564
 2022-10-03 09:33:31 -07:00
Jeff Young 97d4df4154 Better thread safety for zone boundingbox caches. 2022-10-02 19:30:43 +01:00
Jeff Young adbbceacda Make footprint type check more narrow, and set default to ignore. 2022-10-02 18:19:43 +01:00
Jeff Young 1fc5ecae6e Minor dialog layout improvements. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12497
 2022-10-02 11:45:30 +01:00