981aafd5d9
Allow non-named tool in Remove()
...
The tool command string was optional and not set when calling Remove()
through the Cut action. Referencing the value causes unhandled
assertions. We don't actually need the value because we don't pop
anything without a match. The empty string will not match
Fixes https://gitlab.com/kicad/code/kicad/issues/12562
2022-10-02 13:43:33 -07:00
22e9985f5d
Use more basic strings which have already been translated.
2022-09-29 23:58:35 +01:00
c16e86be9a
Use router's connectivity algorithm, not CONNECTIVITY_DATA's.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
(cherry picked from commit 107f409106
2022-09-28 15:01:29 +01:00
b0e2aeb972
Apply the same accuracy band to connectivity as we use for hittesting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
(cherry picked from commit 9cf3c529d3
2022-09-28 14:58:43 +01:00
fc06192643
More improvements to drag tool selection disambiguation.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
(cherry picked from commit 2743fd583f
2022-09-28 14:57:22 +01:00
2faaa0a042
Improve drop-a-knee-selection-to-a-single-segment algorithm.
...
In particular, don't rely on there being only two items in the
collector at the start.
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
(cherry picked from commit a619ef9d53
2022-09-28 14:56:11 +01:00
e8a10939b5
Fix old copy/paste error (from 2017, believe it or not).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11487
(cherry picked from commit d9f75556bd
2022-09-28 13:55:44 +01:00
44ec38ad2d
Fix logic around Select All inside an entered group.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12411
(cherry picked from commit 2d3b8d6393
2022-09-28 13:31:16 +01:00
4a5fdd4214
Display crosshairs in picker tools.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10183
(cherry picked from commit 0a5ca5b485
2022-09-28 13:29:32 +01:00
fe7ed364b6
Allow vias to connect <no net> tracks even when DRC checking is on.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12403
(cherry picked from commit eaccd40c75
2022-09-28 13:26:12 +01:00
e21995c401
Prune pasted data of non-enabled layers.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11997
(cherry picked from commit 5b3bd9be83
2022-09-28 12:47:14 +01:00
440d324c9e
Don't prevent immediate actions while router active
...
Immediate actions that can take place are useful. We should only be
preventing immediate actions while actively routing or dragging
Fixes https://gitlab.com/kicad/code/kicad/issues/12311
(cherry picked from commit 91fbb5c957
2022-09-06 11:04:33 -07:00
ea3f6c8406
Make sure dirty flag gets set, and leave save enabled regardless.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11824
(cherry picked from commit 09773e3e2e
2022-09-02 01:11:20 +01:00
9d0d45450b
Account for groups in undo of Position Relative To.
...
Also fixes a bug were pads weren't correctly being found for anchoring
the selection before the Position Relative To.
Fixes https://gitlab.com/kicad/code/kicad/issues/11793
(cherry picked from commit 1e68c353f1
2022-09-01 16:25:41 +01:00
962df45b65
Fix some issues in PCB_SELECTION_TOOL::selectAllItemsOnSheet():
...
especially a typo that prevent working on root sheet.
Clearly, commit 6b2bb4d8
2022-08-20 13:04:06 +02:00
36a0c2a9cc
Fix issue with caches not being initialized when printing msg bar.
...
(cherry picked from commit 43df863df2
2022-08-04 13:04:21 +01:00
4ac48ad829
Cherry-pick of 2bf33321d1.
2022-08-04 09:29:45 +01:00
7b5e3feb19
By-hand cherry-pick of 004abcd370.
2022-08-04 00:05:48 +01:00
3f448a7eaa
Clear dimension pointer after committing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11864
(cherry picked from commit b80fd5329d
2022-07-28 10:46:02 +01:00
e06e65cdde
Add newly-drawn objects to any entered group.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11912
(cherry picked from commit 654740b90d
2022-07-25 21:02:26 +01:00
0f882d91e5
Add proper collision test to via placer.
...
Also moves DISALLOW constraint processing outside the loop as it
performs it's own loop over any objects referenced by the rules.
Fixes https://gitlab.com/kicad/code/kicad/issues/11832
(cherry picked from commit 73836b50fc
2022-07-25 20:16:01 +01:00
0bc97b7952
Handle double-click in dimension drawing tool.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11815
(cherry picked from commit d40664d171
2022-07-25 18:35:29 +01:00
a8c0bc0430
Keep track of blocking windows
...
Allows the calling KiWAY player to send messages to the blocking window
before signaling a separate call
Fixes https://gitlab.com/kicad/code/kicad/issues/11891
Fixes https://gitlab.com/kicad/code/kicad/issues/11772
(cherry picked from commit b5bf1da251
2022-07-18 09:47:32 -07:00
63e638cfab
Enforce group selection to abide by L/R behavior
...
When selecting greedy (right to left), selecting any part of the group
will get the whole group. When selecting left to right, we must select
all items in the group to get the grouped items unless we are in the
group itself
Fixes https://gitlab.com/kicad/code/kicad/issues/11902
(cherry picked from commit e87ba10a5a
2022-07-18 09:45:10 -07:00
926818097b
Fix compatibility issues with wxWidgets 3.2 and gcc 12.1:
...
hastable.h: remove deprecated binary/unary base class not actually needed.
Fix compil warnings.
From master branch.
2022-07-12 18:24:12 +02:00
042b49ee7b
Update message panel from PCB point editor and SCH drawing tools.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11961
(cherry picked from commit 4f62960334
2022-07-06 19:48:09 -07:00
3a8ad7165b
Clear point editor before recombining pad.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11731
(cherry picked from commit bd51b33f65
2022-06-08 15:58:52 +01:00
aac4f30b7d
Fix zone merge intersection algorithm.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11492
(cherry picked from commit 5f10c15a87
2022-05-31 23:21:43 +01:00
6b2bb4d808
Allow sheet recursion, fix sheet paths in "Highlight on PCB".
...
"Highlight on PCB" and "Select" - "Items in Same Hierarchical Sheet"
actions were extended to select items on subsheets too.
"Highlight on PCB" now uses a proper full sheet path, allowing it to
work in subsheets.
Fixes https://gitlab.com/kicad/code/kicad/issues/11493
2022-05-25 23:38:52 +00:00
936040fe8b
Remove extra test.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10364
Fixes https://gitlab.com/kicad/code/kicad/issues/10364
(cherry picked from commit c78a47c3fb
2022-05-09 00:36:27 +01:00
821fe6ea42
Don't set the dirty bit when running DRC
...
Dirty bit is set in the zone filler separately, there is no action in
the DRC that needs to be saved
Fixes https://gitlab.com/kicad/code/kicad/issues/11344
2022-04-06 17:03:01 -07:00
fdfe5a813e
Clamp cursor to limits of coordinates representation
...
Also improves large distance handling.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8846
(cherry picked from commit 68655540eb
2022-04-04 13:38:50 -07:00
636d009860
Added footprint rule area anchors
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10461
(cherry picked from commit 47c0672ff3
2022-04-04 13:38:00 -07:00
1adfca8f2d
Don't re-fetch selection when running select-in-same-sheet.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11110
(cherry picked from commit a35ae8cdce
2022-04-03 18:20:32 +01:00
6706a5c462
Skip zero-size elements when converting
...
Also fixes an assertion when converting to polygon from the board editor
Fixes https://gitlab.com/kicad/code/kicad/issues/11313
2022-04-01 13:22:08 -07:00
e5ea37507c
Exclude hidden text from selection in FP Editor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11111
(cherry picked from commit 06c1bccccd
2022-03-16 15:15:01 +00:00
23479821e3
Fix issue with 9396735733
...
Need to select unconditionally target layer if not on copper
2022-03-02 10:46:59 -08:00
9396735733
Select the copper layer before processing
...
If we are converting to tracks, the copper layer needs to be selected
before any other elements are processed, otherwise, we end up with the
default undefined layer
Fixes https://gitlab.com/kicad/code/kicad/issues/11025
2022-03-02 10:17:16 -08:00
0b98acfe12
Freeze TEDIT in place
...
Avoids updating the TEDIT field, preventing merge conflicts and unneeded
VCS cruft
2022-03-01 15:53:07 -08:00
1c6f3f8f0d
Drop a knee between tracks to a single item when dragging.
...
This prevents the disambiguation menu from coming up when we don't
really care which element we start the drag on.
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
(cherry picked from commit ae85f57577
2022-02-27 18:20:25 +00:00
a30ad0b54a
Honor modifier keys in diambiguation
...
Needs to be reset for the new action before selecting elements at a
point.
Fixes https://gitlab.com/kicad/code/kicad/issues/9712
2022-02-25 16:15:56 -08:00
54f621c570
Use board polygon instead of bbox for size
...
Board BBox uses the visible size of the board, which includes edge cut
thickness. This is not appropriate for the Board characteristics.
Using the outline polygon gives accurate results and falls back to a
bounding box in the case where the outline is invalid
Fixes https://gitlab.com/kicad/code/kicad/issues/10972
2022-02-25 11:13:01 -08:00
5f1976f341
fixup! Better DRC checking when placing vias.
2022-02-25 10:40:05 +00:00
5129143bcb
Layer visibilities aren't stored in project for footprint editor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10953
(cherry picked from commit 5c54f40eae
2022-02-25 10:40:05 +00:00
d7d31e4b76
Implement multi-layer stitching via logic.
...
(cherry picked from commit d65f9ad2d8
2022-02-25 10:40:05 +00:00
b00f855c26
Better DRC checking when placing vias.
...
(cherry picked from commit 369f53bb19
2022-02-25 10:40:05 +00:00
b24f51908b
Fix nullptr error (no router tool in footprint editor).
...
(cherry picked from commit df3291c59d
2022-02-20 16:57:54 +00:00
246b6fcdd6
Use router to update message panel when routing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10068
2022-02-20 13:54:01 +00:00
02ec87b036
Cancel or commit pad edit mode when switching footprints.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10209
(cherry picked from commit 85805b95ba
2022-02-20 01:03:08 +00:00
fd4ac7c5df
Error messages for zone merging.
...
Also fixes a bug where zones meeting at a point would get merged
resulting in a self-intersecting zone.
Also fixes a bug where undo would not be handled correctly when zones
could not be merged.
Fixes https://gitlab.com/kicad/code/kicad/issues/10466
(cherry picked from commit d5a2059c21
2022-02-13 18:30:32 +00:00
Seth Hillbrand
Jeff Young
jean-pierre charras
Alex
aris-kimi