Calling wxDialog::EndModal() directly from inside the dialog is a
potential bug if the dialog is shown in the modeless or window modal
(quasi-modal). Use the internal button events where possible and
check for the appropriate mode before calling the correct end dialog
function.
Found via `codespell -q 3 -S *.po,./thirdparty -L aactual,acount,aline,alocation,alog,anormal,anumber,aother,apoints,aparent,aray,dout,einstance,modul,ot,overide,serie,te,,tesselate,tesselator,tht`
Print function needs to use brackets to be compatible
both with the python2 and python3.
Without this fix following error was generated
with flags
-DKICAD_SCRIPTING_MODULES=ON
-DKICAD_SCRIPTING_PYTHON3=ON
/usr/share/kicad/demos/python_scripts_examples/gen_gerber_and_drill_files_board.py", line 95
print 'plot %s' % pctl.GetPlotFileName()
^
SyntaxError: invalid syntax
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8303
Signed-off-by: Mika Laitio <lamikr@gmail.com>
This fix required sorting all of the LIB_PART draw items to ensure
accurate comparison between the symbols stored in the schematic and the
original library symbols. This has a noticeable impact on symbol library
load performance. It may also cause significant changes the next time
the library is saved due to changes in the draw item sorting. Hashing
may be a better solution here but this addressed the immediate problem.
A skeleton method SCH_SCREEN::SwapSymbolLinks() was added because there
is most likely an issue with orphaned symbols in the schematic library
symbol cache during undo/redo operations. More testing is required to
verify this.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7263
jean-pierre charras
Mikolaj Wielgus
Seth Hillbrand
Wayne Stambaugh
luz paz
luz paz
Mika Laitio
Jon Evans
Dominik Wernberger
Johannes Maibaum