9a67dc56f9
Clean up assumption that field_id < MANDATORY means its mandatory.
...
It looks good, but non-mandatory fields have an ID of -1, so it
doesn't actually work. Some places got around this by converting
the ID to unsigned, but this just hides the real issue from
unsuspecting coders.
Fixes https://gitlab.com/kicad/code/kicad/issues/4140
2020-04-01 15:59:52 +01:00
029b1b0b22
Eeschema: void CollectOtherUnits(): do not try to collect others units
...
of a not annotated component.
Fixes #4142
https://gitlab.com/kicad/code/kicad/issues/4142
2020-04-01 16:03:22 +02:00
e811101567
fix a few Coverity warnings.
2020-04-01 09:34:44 +02:00
00d9e77e7f
3D viewer: fix a minor problem: to many rotations when typing Shift+z or Shift+y
...
more than once.
Fixes #4135
https://gitlab.com/kicad/code/kicad/issues/4135
2020-03-31 17:35:45 +02:00
3a107e5484
Better generation of drill maps in PS, PDF, SVG formats.
...
These formats use a defined page size (currently A4), and therefore
the drill list cannot be outside the page.
When there are a lot of drill diameters it can happen.
Now the long lists are plotted on more than one column.
2020-03-31 16:48:03 +02:00
13d3f57fce
Implement a different solution to refreshing lib trees.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4110
2020-03-31 02:09:31 +01:00
3047cf5419
Fix Linux compile issue.
2020-03-30 17:35:11 +01:00
eb855d40bb
Restore lib tree refreshing, but don't attempt to refresh tree root.
2020-03-30 17:30:26 +01:00
add4c3d4ea
Only append number to name if it already exists.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4130
2020-03-30 17:30:26 +01:00
58e03be23c
Fix a compil issue.
2020-03-30 17:38:19 +02:00
cbef95256b
Share multi-unit updating code between Sym Props and Edit Field.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4103
2020-03-30 14:15:59 +01:00
7f8f17bd82
Remove empty file.
2020-03-30 14:15:59 +01:00
a1d62e0622
Improve some comments.
2020-03-30 14:15:59 +01:00
132d4d3ffa
Clean up compiler warning.
2020-03-30 14:15:59 +01:00
41b5872f12
Add ERC & DRC checks for unresolved variables.
2020-03-30 14:15:59 +01:00
4990d1e7b2
Variable substitution framework.
...
This implements editing of variables and moving SCH_FIELDs,
TEXTE_MODULEs, TEXTE_PCB and worksheet items over to the new
framework.
2020-03-30 14:15:59 +01:00
9c2a260a27
Eeschema: Fix SCH_FIELD::SetPosition() bug
...
Fixes #4129
https://gitlab.com/kicad/code/kicad/issues/4129
Fixes #4062
https://gitlab.com/kicad/code/kicad/issues/4062
2020-03-30 13:26:14 +02:00
6e47f147aa
A few Coverity fixes.
2020-03-30 09:50:26 +02:00
34aee50ae1
Rework plotting colors to ensure color settings are always available
2020-03-29 21:43:18 -04:00
570ea62b64
Fix discrepancy between ASCII and CSV fp pos files
...
Fixes https://gitlab.com/kicad/code/kicad/issues/3897
2020-03-29 16:55:01 +00:00
9d2712a824
Fix a few Coverity warnings.
...
It also fix:
Fixes #4082
https://gitlab.com/kicad/code/kicad/issues/4082
2020-03-29 18:42:24 +02:00
259d7a47d4
Pcbnew: enhancements:
...
Plot Gerber format default values: X2 attributes enabled.
Gerber job file: use a trick to truncate floating values to 4 digits in mantissa.
It gives a much better readability and 0.1 micron is enough for
mechanical dimensions
2020-03-29 15:35:47 +02:00
d30fb79706
Fix mismatch in tool name and activation action.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4110
2020-03-29 13:27:18 +01:00
c29c3d9cc1
Diferentiate action types in the tool trace
2020-03-28 22:01:35 +00:00
2c86b3d8cf
Fix documentation link in the scripting docs
...
Fixes https://gitlab.com/kicad/code/kicad/issues/3735
2020-03-28 22:01:09 +00:00
42a876d963
Fix a duplicate definition of the TOOL_DISPATCHER.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4110
2020-03-28 18:44:34 +00:00
88c4254bb5
Discourage use of wxDataViews. WX_GRID is much less problematic.
2020-03-28 16:09:40 +00:00
5134856f18
Rationalise 3D settings data-structure.
...
Move the camera out to its own so that everything else is board-
related, and then rename BOARD_ADAPTER.
At some point the flags should probably be moved out too, and they
can have the EDA_3D_SETTINGS name.
2020-03-28 16:09:40 +00:00
3e247a70d5
Gerber plot: new algo to generate solder mask layers with non 0 min thickness mask
...
Previously, all overlapping polygons (pads and min thickness areas to remove) were
merged.
Drawback: pads attributes are lost. In Gerber this is annoying.
Now the pads are plot as flashed or Regions items, and min thickness areas are added
but shapes are not merged and keep their attributes.
2020-03-28 16:32:46 +01:00
615deb40f3
Eeschema: move, mirror and rotate block: fix some issues.
...
Fixes #4111
https://gitlab.com/kicad/code/kicad/issues/4111
2020-03-28 13:17:59 +01:00
c41199f048
lib_tree.cpp: Fix a lot of wxWidgets alerts on Windows.
...
On Windows calling m_adapter->RefreshTree() to refresh the tree does not work fine.
Just calling Refresh() is enough.
2020-03-28 11:00:54 +01:00
aebfbda183
DRC dialog: fix a crash when clicking on a item in Footprint Warning panel:
...
if the warning is a missing footprint, obviously there is no marker associated.
It creates a crash due to a null pointer.
Fixes #4114
https://gitlab.com/kicad/code/kicad/issues/4114
2020-03-28 11:00:54 +01:00
53a98b45f0
DIALOG_ABOUT_BASE: fix a minor wxWidgets alert
2020-03-28 11:00:54 +01:00
873a633181
Gerber: fix a minor issue in OBLONG standard aperture:
...
- incorrect (too big) bounding box.
- HitTest did not test the exact shape.
2020-03-27 16:15:39 +01:00
de7154e8e9
Gerber plotter: Non horiz or vertical oval pads: better plot output:
...
These pads were plotted as a segment. This is not the right way.
Pads must be flashed or plotted as regions, not painted.
They are now plotted as Gerber regions round rectangle pads.
These regions are similar to flashed pads.
2020-03-27 10:34:41 +01:00
e46e2e4e79
Add Code of Conduct
...
Fixes https://gitlab.com/kicad/code/kicad/issues/3998
2020-03-26 11:10:34 -05:00
74957bc7e3
Footprint editor: re-enable a internal copper layer to add/edit keep-out zones
...
on internal layers in footprints.
Fixes #4096
https://gitlab.com/kicad/code/kicad/issues/4096
2020-03-26 16:53:46 +01:00
04d6ea982d
3D viewer: fix an issue with solder paste layer having negative clearance.
...
The code tried to draw outlines with segments having a negative thickness.
It happens mainly on solder paste layers.
Fixes #4090
https://gitlab.com/kicad/code/kicad/issues/4090
2020-03-26 13:46:14 +01:00
6e27904791
More code hygiene.
2020-03-25 18:06:18 +00:00
ba36fc0009
Fix some Coverity issues.
2020-03-25 14:38:43 +00:00
5f7bcb9c34
3D viewer: fix a minor issue in solder paste rect pads:
...
the solder paste mask clearance was no taken in account for rect and trap shapes.
2020-03-25 13:04:30 +01:00
69dcee9450
Kicad manager: fix an issue on Windows when killing Kicad.
...
For some obscure reason, on Windows, when killing Kicad from the Windows
task manager if a editor frame (schematic, library, board editor, fp editor)
is open and has some edition to save, OnCloseWindow is run twice
*at the same time*, creating race conditions between OnCloseWindow() code.
Fixes #4072
https://gitlab.com/kicad/code/kicad/issues/4072
2020-03-25 09:26:47 +01:00
18ad186b99
Fix plotting without Pgm context
2020-03-24 21:45:58 -04:00
d69ebfae49
Push tool framework base down into TOOL_HOLDER.
...
This allows us to use it outside of EDA_BASE_FRAMEs (in this case, in
PANEL_PREVIEW_3D.)
2020-03-24 19:00:25 +00:00
14788eec94
Performance improvement in wx_grid column label height calc.
...
Don't call GetColLabelValue() repeatedly. It's expensive as it doesn't
cache the string translations.
2020-03-24 19:00:25 +00:00
c4aed3a8de
Add user-configurability of the LibEdit axes color.
2020-03-24 19:00:25 +00:00
5f60d955be
minor fix for commit eb250b4cb
2020-03-24 18:43:15 +01:00
eb250b4cb0
PCB_PAINTER: minor fix: display better pad shapes on solder paste layers.
...
the parameter margin percent was badly handled for rectangular/oval pads,
giving an incorrect solder paste shape for non 0.0 values
now it is is correctly handled.
2020-03-24 18:29:12 +01:00
99a28fa3e5
Fix typos in comments.
2020-03-24 16:24:53 +00:00
cf25975876
EEschema: Fix back annotation
...
Repairs back annotation after some schematic code modifications
2020-03-24 10:53:00 +00:00
Jeff Young
jean-pierre charras
Jon Evans
Michael Kavanagh
Ian McInerney
Seth Hillbrand
Yegor Yefremov
Alexander