kicad/eeschema
Maciej Suminski 50588dcd1e Fix disabled 'save library' button in the symbol editor
With uninitialized COMPONENT_TREE::m_menuActive there were cases when
application logic erroneously decided to fetch the current library name
from the right click menu selection, even though there was no menu
opened, so an empty string was returned. Empty library name is
equivalent to no library loaded, therefore the save button appeared
disabled.

Fixes: lp:1765937
* https://bugs.launchpad.net/kicad/+bug/1765937
2018-04-23 15:29:26 +02:00
..
dialogs Prevent issuing a print command before the previous one is finished 2018-04-23 11:25:28 +02:00
netlist_exporters Eeschema: fix missing part in part list bug in netlist exporter. 2018-04-22 16:33:34 -04:00
plugins Allow XLS netlist exporters to specify a file extension. 2018-03-26 00:51:54 +01:00
qa Pass -DBOOST_TEST_DYN_LINK to all parts of test 2017-12-06 19:28:57 -05:00
sim Fallback to system ngspice library when libngspice is not found in other paths on macOS 2018-04-19 14:48:31 +02:00
widgets Fix disabled 'save library' button in the symbol editor 2018-04-23 15:29:26 +02:00
CMakeLists.txt Bundle libngspice, code models and init scripts for macOS 2018-04-19 11:44:48 +02:00
Info.plist macOS: standardise CFBundleName to application names. 2018-03-05 01:14:00 +00:00
annotate.cpp Add a start number to annotate. 2018-02-19 09:32:54 -05:00
autoplace_fields.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
backanno.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
block.cpp eeschema: preserve unit number after pasting a component 2018-03-22 10:55:50 +01:00
block_libedit.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
bus-wire-junction.cpp Merges a line after manually removing its junction. 2018-02-03 10:50:10 +01:00
busentry.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
class_libentry.cpp Library Field editor: validate alias name before changing it 2018-04-19 14:47:34 +02:00
class_libentry.h Library Field editor: validate alias name before changing it 2018-04-19 14:47:34 +02:00
class_library.cpp Coverity fixes. 2018-03-21 23:11:55 +00:00
class_library.h Eeschema: fix potential symbol cache library name collisions. 2017-12-08 08:32:23 -05:00
cmp_library.keywords 1) Add "rules" to base of tree for copying into BZR_HOME/rules. 2013-05-25 23:36:44 -05:00
cmp_library_lexer.cpp 1) Add "rules" to base of tree for copying into BZR_HOME/rules. 2013-05-25 23:36:44 -05:00
cmp_tree_model.cpp CMP_TREE_MODEL: Reset SearchTextNormalized flag when a node is updated 2018-02-09 11:00:32 +01:00
cmp_tree_model.h Add library descriptions to component tree. 2018-02-07 08:45:33 +01:00
cmp_tree_model_adapter.cpp Add library descriptions to component tree. 2018-02-07 08:45:33 +01:00
cmp_tree_model_adapter.h Extracted CMP_TREE_MODEL_ADAPTER_BASE class 2017-11-21 23:18:55 +01:00
cmp_tree_model_adapter_base.cpp Defensive coding to attempt to prevent wxWidgets crash. 2018-03-16 19:02:25 +00:00
cmp_tree_model_adapter_base.h Add library descriptions to component tree. 2018-02-07 08:45:33 +01:00
component_references_lister.cpp Move Fields Editor to wxGrid. 2018-04-17 11:39:44 +01:00
controle.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
cross-probing.cpp Fix warnings for unreferenced local variables 2018-04-18 15:08:37 -04:00
dialog_erc_listbox.h Make sure ERC and DRC item lists respect color themes. 2018-03-14 14:15:16 +00:00
drc_erc_item.cpp Add ERC check that a pin appears in only one net 2018-03-15 11:11:43 -04:00
edit_bitmap.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
edit_component_in_schematic.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
edit_label.cpp fix misspelled 'an other' -> 'another' 2018-04-08 13:24:37 -04:00
eeredraw.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
eeschema.cpp Keep track of open sockets and dispose of them in d'tor. 2018-04-04 12:02:40 +01:00
eeschema.icns Update MacOS icons 2018-03-22 11:45:42 -04:00
eeschema.rc Remove old xpm icons files 2012-04-07 13:09:57 +02:00
eeschema_config.cpp Fix strings for save/load project menu options; standardize on "Load" 2018-03-20 22:20:54 -04:00
eeschema_config.h Implement primitive icon scaling for high DPI 2018-01-10 21:26:06 -07:00
eeschema_doc.icns Update MacOS icons 2018-03-22 11:45:42 -04:00
eeschema_id.h Eeschema: fix many wxASSERT when trying to open menus from the main menubar. 2018-04-01 20:58:27 +02:00
erc.cpp fix misspelled 'an other' -> 'another' 2018-04-08 13:24:37 -04:00
erc.h fix misspelled 'an other' -> 'another' 2018-04-08 13:24:37 -04:00
events_called_functions_for_edit.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
files-io.cpp Eagle SCH import: save project file after the full path is set 2018-04-20 10:04:41 +02:00
find.cpp Organize trace debugging code for ease of maintenance. 2018-04-13 09:59:01 -04:00
general.h Clear symbol library list from project file after remapping. 2017-11-09 18:50:23 -05:00
generate_alias_info.cpp Standardize Keywords->Key words 2018-03-09 09:43:53 -08:00
generate_alias_info.h Convert component chooser dialog over to use symbol library table. 2017-11-09 18:50:18 -05:00
getpart.cpp Prevent reentrancy in footprint loading. 2018-04-16 23:19:08 +01:00
help_common_strings.h Standardize terminology for automatic zoom to "Zoom to Fit". 2018-03-16 08:38:36 -04:00
hierarch.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
highlight_connection.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
hotkeys.cpp Revert broken hotkey fix. 2018-04-14 08:24:25 -04:00
hotkeys.h Eeschema: New menubar structure 2018-02-22 20:43:21 -05:00
invoke_sch_dialog.h fix misspelled 'an other' -> 'another' 2018-04-08 13:24:37 -04:00
lib_arc.cpp Fix code after renaming files 2018-01-29 16:40:22 +01:00
lib_arc.h Symbol library load performance enhancements. 2018-01-27 08:29:43 -05:00
lib_bezier.cpp Fix code after renaming files 2018-01-29 16:40:22 +01:00
lib_bezier.h Symbol library load performance enhancements. 2018-01-27 08:29:43 -05:00
lib_circle.cpp Fix code after renaming files 2018-01-29 16:40:22 +01:00
lib_circle.h Symbol library load performance enhancements. 2018-01-27 08:29:43 -05:00
lib_collectors.cpp rename class_collector.h to collector.h 2018-02-04 10:49:37 +01:00
lib_collectors.h rename class_collector.h to collector.h 2018-02-04 10:49:37 +01:00
lib_draw_item.cpp Fix code after renaming files 2018-01-29 16:40:22 +01:00
lib_draw_item.h Fix code after renaming files 2018-01-29 11:37:29 +01:00
lib_edit_frame.cpp Fix tabs->spaces 2018-04-18 08:22:52 -07:00
lib_edit_frame.h Libedit: Fix a few places where item could be NULL 2018-04-04 10:20:15 -07:00
lib_export.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
lib_field.cpp Replace illegal characters in LIB_{ALIAS,PART} LIB_IDs 2018-03-08 09:48:34 +01:00
lib_field.h Symbol library load performance enhancements. 2018-01-27 08:29:43 -05:00
lib_manager.cpp Symbol Editor: fix a crash when saving/reverting a library not present in sym-lib-table 2018-02-16 12:13:02 +01:00
lib_manager.h Symbol Editor: fix a crash when saving/reverting a library not present in sym-lib-table 2018-02-16 12:13:02 +01:00
lib_manager_adapter.cpp Add library descriptions to component tree. 2018-02-07 08:45:33 +01:00
lib_manager_adapter.h Add '*' to modified files in libedit cmptree, and change highlighting. 2018-01-22 10:37:06 +01:00
lib_pin.cpp Cleanup of trace logs from Simon Richter. 2018-04-17 17:27:18 +01:00
lib_pin.h More performance optimizations for symbol libraries 2018-01-30 10:31:51 -05:00
lib_polyline.cpp Fix code after renaming files 2018-01-29 16:40:22 +01:00
lib_polyline.h Symbol library load performance enhancements. 2018-01-27 08:29:43 -05:00
lib_rectangle.cpp Fix code after renaming files 2018-01-29 16:40:22 +01:00
lib_rectangle.h Symbol library load performance enhancements. 2018-01-27 08:29:43 -05:00
lib_text.cpp Fix code after renaming files 2018-01-29 16:40:22 +01:00
lib_text.h Symbol library load performance enhancements. 2018-01-27 08:29:43 -05:00
libarch.cpp Fix warnings for unreferenced local variables 2018-04-18 15:08:37 -04:00
libedit.cpp Fix incorrect behavior of ReplaceIllegalFileNameChars( wxString& aName, int aReplaceChar ) for non ASCII8 chars. 2018-04-15 10:06:53 +02:00
libedit_onleftclick.cpp Libedit: Fix a few places where item could be NULL 2018-04-04 10:20:15 -07:00
libedit_onrightclick.cpp Added 'Paste' to eeschema context menus 2018-03-13 17:26:33 +01:00
libedit_plot_component.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
libedit_undo_redo.cpp Coverity fixes 2018-02-15 10:27:01 +01:00
libfield.cpp Library Field editor: validate alias name before changing it 2018-04-19 14:47:34 +02:00
list_operations.h Eeschema: removed protos.h 2017-11-21 23:18:55 +01:00
menubar.cpp Consistency between dialog titles and menu items. 2018-04-20 15:33:46 +01:00
menubar_libedit.cpp Fix memory leak and push menu change to other apps. 2018-04-07 14:14:55 +01:00
netlist.h Fixed Spice netlist export options and added a few new flags 2016-08-11 14:41:20 +02:00
netlist_generator.cpp Moving IsOk dialogs to correct parents 2018-04-17 17:27:15 -07:00
netlist_object.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
netlist_object.h fix misspelled 'an other' -> 'another' 2018-04-08 13:24:37 -04:00
netlist_object_list.cpp Remove not used ListNets() methods 2018-03-04 18:04:19 +01:00
onleftclick.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
onrightclick.cpp Added 'Paste' to eeschema context menus 2018-03-13 17:26:33 +01:00
operations_on_items_lists.cpp Prevent duplicate sheetnames when using mouse copy 2018-04-17 12:01:03 -07:00
pin_number.cpp Compress consecutive numbers in pin summary. 2016-01-13 14:18:05 -05:00
pin_number.h Add pin number summary 2016-01-13 14:17:54 -05:00
pin_shape.cpp Remove some extra semicolons 2017-11-09 19:52:18 +01:00
pin_shape.h Enum refactoring and shiny icons in dialog_lib_edit_pin_table 2016-02-28 18:33:29 +01:00
pin_type.cpp Enum refactoring and shiny icons in dialog_lib_edit_pin_table 2016-02-28 18:33:29 +01:00
pin_type.h Enum refactoring and shiny icons in dialog_lib_edit_pin_table 2016-02-28 18:33:29 +01:00
pinedit.cpp fix misspelled 'an other' -> 'another' 2018-04-08 13:24:37 -04:00
plot_schematic_DXF.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
plot_schematic_HPGL.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
plot_schematic_PDF.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
plot_schematic_PS.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
plot_schematic_SVG.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
project_rescue.cpp Improved validation of library and entry names 2018-04-13 14:24:57 +02:00
project_rescue.h Do not append "RESCUE" to symbol names when rescuing symbols. 2018-03-03 15:34:26 -05:00
sch_base_frame.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
sch_base_frame.h fix misspelled 'an other' -> 'another' 2018-04-08 13:24:37 -04:00
sch_bitmap.cpp Remove all schematic object load and save code. 2017-11-18 08:53:13 -05:00
sch_bitmap.h Update code after file renaming 2018-01-29 09:39:49 +01:00
sch_bus_entry.cpp rename files: update filenames in sources 2018-01-28 19:12:26 +01:00
sch_bus_entry.h Eeschema: Adding connection block selections 2017-12-20 10:04:25 -05:00
sch_collectors.cpp Organize trace debugging code for ease of maintenance. 2018-04-13 09:59:01 -04:00
sch_collectors.h Don't rely on live pointers in search data. 2018-02-12 11:46:39 -05:00
sch_component.cpp Fix warnings for unreferenced local variables 2018-04-18 15:08:37 -04:00
sch_component.h Eagle SCH import: improved implicit connections resolution 2018-04-12 18:12:22 +02:00
sch_eagle_plugin.cpp Improved validation of library and entry names 2018-04-13 14:24:57 +02:00
sch_eagle_plugin.h Eagle SCH import: improved implicit connections resolution 2018-04-12 18:12:22 +02:00
sch_edit_frame.cpp Fix warnings for unreferenced local variables 2018-04-18 15:08:37 -04:00
sch_edit_frame.h fix misspelled 'an other' -> 'another' 2018-04-08 13:24:37 -04:00
sch_field.cpp Cleanup of trace logs from Simon Richter. 2018-04-17 17:27:18 +01:00
sch_field.h Fix unnecessary value parameter detected by clang-tidy. - Replace value parameter by const reference parameter or move-assignement in some cases 2018-01-09 18:55:51 -05:00
sch_io_mgr.cpp Fix quotes in UI messages 2017-12-15 07:33:07 -05:00
sch_io_mgr.h Eeschema: allow for partial schematic loading. 2017-12-06 19:11:09 -05:00
sch_item_struct.cpp Organize trace debugging code for ease of maintenance. 2018-04-13 09:59:01 -04:00
sch_item_struct.h Cleanup of trace logs from Simon Richter. 2018-04-17 17:27:18 +01:00
sch_junction.cpp Fix code after renaming files, and a bit of code cleanup (remove useless includes and multiple includes of the same files) 2018-01-30 09:57:25 +01:00
sch_junction.h Eeschema: Adding connection block selections 2017-12-20 10:04:25 -05:00
sch_legacy_plugin.cpp Eeschema: fix bug in sheet path loading logic. 2018-04-22 09:47:54 -04:00
sch_legacy_plugin.h Eeschema: allow for partial schematic loading. 2017-12-06 19:11:09 -05:00
sch_line.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
sch_line.h Eeschema: Adding connection block selections 2017-12-20 10:04:25 -05:00
sch_marker.cpp Fix code after renaming files 2018-01-29 16:40:22 +01:00
sch_marker.h Rename a few files 2018-01-28 22:02:31 +01:00
sch_no_connect.cpp Fix code after renaming files, and a bit of code cleanup (remove useless includes and multiple includes of the same files) 2018-01-30 09:57:25 +01:00
sch_no_connect.h Eeschema: Adding connection block selections 2017-12-20 10:04:25 -05:00
sch_plugin.cpp Fix quotes in UI messages 2017-12-15 07:33:07 -05:00
sch_reference_list.h Move Fields Editor to wxGrid. 2018-04-17 11:39:44 +01:00
sch_screen.cpp fix misspelled 'an other' -> 'another' 2018-04-08 13:24:37 -04:00
sch_screen.h Fix code after renaming files, and a bit of code cleanup (remove useless includes and multiple includes of the same files) 2018-01-30 09:57:25 +01:00
sch_sheet.cpp Cleanup of trace logs from Simon Richter. 2018-04-17 17:27:18 +01:00
sch_sheet.h Eeschema: Adding connection block selections 2017-12-20 10:04:25 -05:00
sch_sheet_path.cpp Add a start number to annotate. 2018-02-19 09:32:54 -05:00
sch_sheet_path.h fix misspelled 'allows to' -> 'allows one to' 2018-04-08 13:24:18 -04:00
sch_sheet_pin.cpp Cleanup of trace logs from Simon Richter. 2018-04-17 17:27:18 +01:00
sch_text.cpp Cleanup of trace logs from Simon Richter. 2018-04-17 17:27:18 +01:00
sch_text.h Eeschema: Adding connection block selections 2017-12-20 10:04:25 -05:00
sch_validators.cpp Forbid colon, slash and backslash characters in symbol names 2017-12-21 13:56:35 +01:00
sch_validators.h Add more "override" markers. 2016-09-25 13:59:41 -04:00
schedit.cpp Fix incorrect UI management of Zoom to Selection, created by fix 2a419156 2018-04-14 17:44:17 +02:00
schematic_undo_redo.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
selpart.cpp Fix warnings for unreferenced local variables 2018-04-18 15:08:37 -04:00
sheet.cpp Reworking sheet duplication messages and annotation 2018-04-17 17:12:51 -07:00
sheetlab.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
symbdraw.cpp Libedit: Fix a few places where item could be NULL 2018-04-04 10:20:15 -07:00
symbedit.cpp Fix warnings for unreferenced local variables 2018-04-18 15:08:37 -04:00
symbol_lib_table.cpp Load each symbol library atomically for better performance. 2018-01-24 19:21:56 -05:00
symbol_lib_table.h Load each symbol library atomically for better performance. 2018-01-24 19:21:56 -05:00
template_fieldnames.cpp Symbol library load performance enhancements. 2018-01-27 08:29:43 -05:00
template_fieldnames.h Fix code after renaming files 2018-01-29 16:40:22 +01:00
template_fieldnames.keywords
tool_lib.cpp Standardize terminology for automatic zoom to "Zoom to Fit". 2018-03-16 08:38:36 -04:00
tool_sch.cpp Standardize terminology for automatic zoom to "Zoom to Fit". 2018-03-16 08:38:36 -04:00
tool_viewlib.cpp Fix memory leak and push menu change to other apps. 2018-04-07 14:14:55 +01:00
transform.cpp Fix code after renaming files 2018-01-29 11:37:29 +01:00
transform.h Remove unnecessary TRANSFORM::operator= 2017-02-19 22:13:50 -05:00
viewlib_frame.cpp Fix warnings for unreferenced local variables 2018-04-18 15:08:37 -04:00
viewlib_frame.h Fix code after renaming files, and a bit of code cleanup (remove useless includes and multiple includes of the same files) 2018-01-30 09:57:25 +01:00
viewlibs.cpp Fix warnings for unreferenced local variables 2018-04-18 15:08:37 -04:00