e2bc7557cc
1) For a while now we've been using a calculated seg count from a given maxError, and a correction factor to push the radius out so that all the error is outside the arc/circle. However, the second calculation (which pre-dates the first) is pretty much just the inverse of the first (and yields nothing more than maxError back). This is particularly sub-optimal given the cost of trig functions. 2) There are a lot of old optimizations to reduce segcounts in certain situations, someting that our error-based calculation compensates for anyway. (Smaller radii need fewer segments to meet the maxError condition.) But perhaps more importantly we now surface maxError in the UI and we don't really want to call it "Max deviation except when it's not". 3) We were also clamping the segCount twice: once in the calculation routine and once in most of it's callers. Furthermore, the caller clamping was inconsistent (both in being done and in the clamping value). We now clamp only in the calculation routine. 4) There's no reason to use the correction factors in the 3Dviewer; it's just a visualization and whether the polygonization error is inside or outside the shape isn't really material. 5) The arc-correction-disabling stuff (used for solder mask layer) was somewhat fragile in that it depended on the caller to turn it back on afterwards. It's now only exposed as a RAII object which automatically cleans up when it goes out of scope. 6) There were also bugs in a couple of the polygonization routines where we'd accumulate round-off error in adding up the segments and end up with an overly long last segment (which of course would voilate the error max). This was the cause of the linked bug and also some issues with vias that we had fudged in the past with extra clearance. Fixes https://gitlab.com/kicad/code/kicad/issues/5567 |
||
|---|---|---|
| .. | ||
| convex_hull.h | ||
| direction45.h | ||
| geometry_utils.h | ||
| poly_grid_partition.h | ||
| polygon_test_point_inside.h | ||
| polygon_triangulation.h | ||
| seg.h | ||
| shape.h | ||
| shape_arc.h | ||
| shape_circle.h | ||
| shape_compound.h | ||
| shape_file_io.h | ||
| shape_index.h | ||
| shape_index_list.h | ||
| shape_line_chain.h | ||
| shape_null.h | ||
| shape_poly_set.h | ||
| shape_rect.h | ||
| shape_segment.h | ||
| shape_simple.h | ||