Indent the jtbp_close() function consistently with tabs in order to fix
for GCC 7's flagging of this warning:
drivers/jtdev_bus_pirate.c: In function ‘jtbp_close’:
drivers/jtdev_bus_pirate.c:189:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
if(write(p->port, &out_buff, 1));
^~
drivers/jtdev_bus_pirate.c:191:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
close(p->port);
^~~~~
Signed-off-by: Andrew Bradford <andrew@bradfordembedded.com>
This is extremely slow at programming things, but is very useful for
unbricking an MSP-FET430UIF if you have a bus pirate and no other
programmers around.
According to (not very good) documentation and empiric testing
BSL expects sizes of buffers sends to both sides to be even.
The same applies to memory addresses.
This commit moves the definitions of UNAME_* above the initial check
of the OS environment variable. Previously, UNAME_O would not be set
in the case where OS is Windows_NT. Builds would incorrectly use Windows
OS_LIBS and OS_CFLAGS in a Cygwin build environment. The tree now builds
cleanly with Cygwin's libusb-1.0 and libreadline development packages
installed.
Using Cygwin's serial port mappings for MSP-FET430UIF:
$ mspdebug -d /dev/ttyS1 uif
MSPDebug version 0.24 - debugging tool for MSP430 MCUs
Copyright (C) 2009-2016 Daniel Beer <dlbeer@gmail.com>
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Chip info database from MSP430.dll v3.3.1.4 Copyright (C) 2013 TI, Inc.
Trying to open /dev/ttyS1 at 460800 bps...
Initializing FET...
FET protocol version is 20408002
Set Vcc: 3000 mV
Configured for Spy-Bi-Wire
Device ID: 0x0580
Code start address: 0x5c00
Code size : 262144 byte = 256 kb
RAM start address: 0x1c00
RAM end address: 0x5bff
RAM size : 16384 byte = 16 kb
Device: MSP430F5438A
Number of breakpoints: 8
fet: FET returned NAK
warning: device does not support power profiling
Chip ID data:
ver_id: 8005
ver_sub_id: 0000
revision: 13
fab: 55
self: 5555
config: 13
Device: MSP430F5438A
[...]
Andrew Bradford
Daniel Beer
Alex Orange
Emmanuel Blot
Jan Pohanka
Tamas TEVESZ
Glyn Hudson
Hiroki Mori
John Pitney
Derald D. Woods
David Siroky
zcsahok