fb6de689b9
Factor an EDIT_TOOL selection routine
...
Also add some commentary to other EDIT_TOOL selection functions.
2017-02-01 09:57:58 +01:00
45b60b1bb0
Add exchange modules GAL tool (in EDIT_TOOL)
...
Includes tool action and the transistion binding in EDIT_TOOL.
Fixes: lp:1541460
* https://bugs.launchpad.net/kicad/+bug/1541460
2017-02-01 09:57:36 +01:00
9627f063ff
Added missing handler for 'activate' events in EDIT_TOOL
...
Fixes: lp:1660306
* https://bugs.launchpad.net/kicad/+bug/1660306
2017-01-30 14:05:44 +01:00
0f5bfdb156
Add mirror tool action for GAL module editor
...
This is basically a simple clone of the legacy tool with a few minor
tidy-ups for GAL mode.
Fixes: lp:1619301
* https://bugs.launchpad.net/kicad/+bug/1619301
2017-01-25 20:17:28 +01:00
e5fbd0c442
Fixed crash upon finished zone drawing in GAL.
...
In principle, this patch reverts 2eefa117https://bugs.launchpad.net/kicad/+bug/1657569
2017-01-18 22:06:23 +01:00
75fb04d650
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops
...
There used to be a number of TOOL_ACTIONs that had entries both in
SetTransitions() and the event loop, which seemed redundant and
troublesome.
Now it is not necessary anymore, transitions setup is enough to execute
associated actions.
2017-01-18 14:20:39 +01:00
2eefa11732
SELECTION has-a VIEW_GROUP instead of being-a VIEW_GROUP
...
Fixed numerous warnings caused by hidden overloaded methods
provided in both classes (Add(), Remove(), etc.)
2017-01-18 13:22:41 +01:00
004ca3c6f9
Fixed a memory leak in VIEW_ITEM (proper way of doing 9bc2bb2)
...
The problem with simple deleting VIEW_ITEM_DATA upon VIEW_ITEM removal was
caused by the default copy constructors that copied pointers.
Once a copy of an item was destroyed, the VIEW_ITEM_DATA has been
destroyed, effectively invalidating m_viewPrivData for the other item.
2017-01-16 14:57:50 +01:00
c50d28d94d
Access tools' TOOL_MENUs rather than CONDITIONAL_MENUs
...
This means that non-top-level tools, for example EDIT_TOOL and
PCB_EDITOR_CONTROL can submit their own menus to the top-level tool's
TOOL_MENU, which will then retain a reference to it and make it
available for the CONTEXT_MENU that is shown.
2017-01-12 14:34:03 +01:00
2972f6fbc7
Fix shadowed local variable
2016-12-20 17:51:55 +01:00
89055c4425
Code formatting
2016-12-12 16:45:52 +01:00
1c1f4e9a50
Refactoring of VIEW/VIEW_ITEM classes:
...
- Remove dependency of EDA_ITEM on VIEW
- VIEW_ITEM is now a pure virtual interface
2016-12-12 16:45:52 +01:00
27a10e8597
Multiple simplifications to GAL tools in PCBNew:
...
- Finalize transition to BOARD_COMMIT (removed all remaining uses of PICKED_ITEMS_LIST) and implicit view/ratsnest updates
- Simplified SELECTION class, it now can be directly added to a VIEW
- Removed unnecesary casts and templates
- Introduced C++11 features (range based for, lambdas) where they improve code readability
- Added non-undoable COMMITs, which can be used to propagate change notifications to interested listeners (e.g. ratsnest/view)
2016-12-12 16:45:52 +01:00
bcfc1e7a3f
fix shadowed local variables
2016-11-25 16:00:42 +01:00
ad088db6d2
Add more "override" markers.
2016-09-25 13:59:41 -04:00
6a9c1cb6a1
Split the undo/redo event into the two stages "pre" and "post" for convenient synchronization of dependent state.
2016-09-23 13:29:25 +02:00
6701b80f77
Converted global deletion, global text size setting & module exchange to BOARD_COMMIT.
2016-09-12 13:45:57 +02:00
303a6928ab
Changed pointEditorUpdate to editModifiedSelection.
2016-09-12 13:45:57 +02:00
ad1111748e
Removed 'undo inhibit' in EDIT_TOOL
2016-09-12 13:45:57 +02:00
5a1f52bf30
Modified tools to use BOARD_COMMIT.
2016-09-12 13:45:57 +02:00
b815ea7865
Removed remaining m_editModules flags.
2016-09-12 11:50:06 +02:00
9861b35707
EDIT_TOOL::hoverSelection() works with current selection.
2016-09-12 11:50:06 +02:00
a5b7a7ca0a
Changed DuplicateAndAddItem() to parametrized Duplicate().
2016-09-12 11:50:06 +02:00
1924507001
Added a PCB_TOOL subclass.
2016-09-12 11:50:06 +02:00
ff6bdeee4b
Removed a number 'if(m_editModules)' sections from pcbnew tools.
2016-09-12 11:50:06 +02:00
1dd43d1d98
Unified undo buffer handling code for PCB & module editor.
...
Replaced UR_MODEDIT with UR_CHANGED.
2016-09-12 11:50:06 +02:00
1b2fd6a382
Replace BOOST_FOREACH with C++11 range based for.
2016-06-29 16:07:55 -04:00
fde12ebd25
Replace boost::function and boost::bind with their std:: counterparts
2016-06-29 12:23:11 +02:00
e2cc78b2b5
Code cleanup: remove dead code (some removed methods were broken), and update or add comments.
2016-06-01 11:28:07 +02:00
a30c8d7848
Coverity fixes.
2016-05-11 11:18:27 +02:00
dd10c577ec
Added SELECTION_CONDITIONS::OnlyTypes() variant that takes KICAD_T[]4
2016-05-04 18:35:20 +02:00
b8a91c7a98
Enhancements in Create array tool (bad parameters detection and disable parms when not applicable)
2016-04-02 14:52:29 +02:00
60d93d024c
pcbnew: don't pick up selection after unsuccessful Duplicate
...
Following rev 6627 (git 2777182
2016-03-18 07:15:50 -04:00
b237d81b75
Create Array dialog: some fixes:
...
* No initial copied object changed (this was a serious bug to modify these objects. Previous version modified references and other texts using a very stupid algorithm).
It also fixes bug 1549231
* only new pads are numbered (therefore renumbering is used only in footprint editor)
* remove not working and useless feature in circular array: now only use number for pads (others options using alphabetical letters are removed: did not work corectly, and were useless)
* a more clear option is used to choose if the pads are numbered from a choosen value, or from the first avaible value
* Adding a warning messsage if a parameter is incorrect.
2016-03-07 08:13:06 +01:00
712ff51d3f
Clarify assignment as conditional in EDIT_TOOL::Main
2016-01-11 17:12:11 -05:00
203e8156a1
pcbnew asks before rotating/flipping a locked item (GAL).
2016-01-05 17:01:59 +01:00
0cad702fc7
Fixed footprint editor crash on ref/val text layer change (GAL).
2015-08-15 16:00:34 +02:00
e3cbfb0609
Better way of handling changes in EDIT_TOOL (GAL).
2015-07-31 17:40:19 +02:00
c632f3db18
Update ratsnest on footprint change (GAL).
2015-07-28 17:33:18 +02:00
6983f90b9f
Align cursor to the grid when dragging multiple items (GAL).
2015-07-28 10:28:59 +02:00
d010703eaf
Fixed cursor freeze in pcbnew (GAL).
2015-07-24 10:58:47 +02:00
74584e2081
Fixed crash on undo layer change in TEXTE_MODULE.
2015-07-24 09:42:46 +02:00
982eee7905
Do not invoke PNS inline dragging when 'Duplicate' is run.
2015-07-24 09:42:45 +02:00
36d3d9f78e
Cursor warps to the drag origin (GAL).
2015-07-15 17:32:30 +02:00
6a6ea35335
Fixed assert on double 'Move' command invocation (GAL).
2015-07-15 14:08:52 +02:00
59af7a96f8
Minor code cleaning.
2015-07-15 14:08:52 +02:00
36d1818b54
Fixed snapping problem when commands are issued from the context menu (GAL).
2015-07-15 14:08:51 +02:00
33e1797116
Tracks & vias properties dialog.
2015-07-09 13:35:51 +02:00
e7099036d7
Fixed one key delay when moving items with arrow keys (GAL).
2015-07-07 18:36:50 +02:00
1b4daade82
GRID_HELPER anchors for vias (GAL).
2015-07-07 18:36:32 +02:00
891bd3d629
Do not show 'Properties' menu entry if there is more than one item selected (GAL).
2015-07-03 20:58:11 +02:00
766da1e494
Code formatting.
2015-07-02 16:11:15 +02:00
0ade919a98
router: fix shortcut crash & inline dragging for inline dragging P&S
2015-07-02 16:10:07 +02:00
171d39c8d0
router: invoke interactive drag when dragging traces/vias in edit tool (disabled by default)
2015-07-02 16:09:56 +02:00
b5ef511063
Fixed alignment to grid when there is a grid offset (GAL).
2015-06-30 14:08:03 +02:00
ac6a90afa3
Update ratsnest after properties are changed.
2015-06-25 17:36:57 +02:00
12adb25a71
Fixed 'Edit in footprint editor' hotkey (GAL).
2015-06-16 15:27:59 +02:00
2047d87317
Minor fixes (Bug #1414328 and Bug #1440312 ). Remove translatable attribute in a debug message.
...
tools/edit_tool.cpp: remove limitation (GAL mode) to delete the last pad in a footprint (a footprint can have 0 pad, for instance a logo)
2015-05-01 17:01:09 +02:00
958046ddb2
Moved SELECTION_TOOL context menu to a separate class.
2015-04-30 10:46:08 +02:00
b8295b6af8
Code formatting.
2015-04-30 10:46:07 +02:00
946b9d1933
setTransitions() are called automatically for tools.
2015-04-30 10:46:03 +02:00
20dfe9ca29
Minor fixes: dialog_create_array.* files: clean code ( remove useless declarations and functions ).
...
fix a few coverity warnings about not initialized members in ctors.
2015-04-22 18:39:49 +02:00
c519eea12b
3D viewer: fix (the fix is not perfect) a minor issue in zone rendering: copper thickness was not good when the option 'Show Holes in Zones" was OFF, and "Show Copper Thickness" ON.
...
Fix a few coverity minor warnings.
2015-04-12 19:44:46 +02:00
cbf487c598
Pcbnew: duplicate and create array: popup menus in legacy mode: remove these options for a few items which cannot be (safely) duplicated (pads in board editor, and a few others )
...
Modedit, GAL mode: fix a crash when a duplicated area includes the ref or value fields.
Add missing bitmap for pad enumerate.
fix bad flag for Portuguese language.
Fix a few typo in messages.
2015-04-03 21:10:09 +02:00
589dd442f5
Clippy returns home.
2015-04-02 09:18:45 +02:00
8be73ad05a
KiCad assistant.
2015-03-31 23:45:02 +02:00
900ecbae9d
Fix for cancellation of duplicate in GAL mode.
2015-03-16 10:25:40 +01:00
161b360297
Fixed frozen cursor (GAL).
2015-03-03 11:55:23 +01:00
0dd9efd9db
Merged the differential pair router & length tuning tool.
2015-03-03 11:50:50 +01:00
0975e3e5bd
Move exact dialog: make all messages translatable. Fix minor issues (some can be Windows specific). Remove useless declarations. Fix coding style issues
...
Fix minor warnings from cppcheck.
2015-02-22 15:43:44 +01:00
de03accdb1
Coverity report fixes.
2015-02-21 14:58:39 +01:00
3e9bb6b887
SELECTION::GetCenter() returns VECTOR2I instead of wxPoint.
2015-02-20 11:40:36 +01:00
f7a32e839e
Moved UndoInhibit related functions from TOOL_MANAGER to EDIT_TOOL.
2015-02-19 14:53:31 +01:00
9bed4814a3
Ratsnest update in 'Create array' tool (GAL).
2015-02-18 20:29:52 +01:00
f06690c8d3
Merged lp:~john-j-beard/kicad/moveexact.
2015-02-18 20:27:00 +01:00
4fb9bce354
Code formatting.
2015-02-18 17:53:46 +01:00
e5deafb4bb
bulk improvements for selection and edit tools (GAL) disambiguatin heuristics and smarter grid alignment
2015-02-18 01:10:20 +01:00
b0ad779ee4
Calming down the Coverity report.
2015-02-15 23:21:52 +01:00
902d0e3f1f
Tools are processing const TOOL_EVENT& (Tool Framework).
2015-02-14 21:28:47 +01:00
8c6313ac1a
Extend arrays and duplicate to pcbnew (GAL and legacy), covering modules, text, lines, tracks, dimensions and targets.
...
Text arrays can now use "%s" as a placeholder to be substituted with the array index.
Also expand menu options for move exact, arrays and duplicate.
Minor fixes for arrays - use proper unit parsing, add numbering start for circular arrays
Add circle radius indicator to array dialogue
2015-02-12 03:22:24 +00:00
4f3672da4d
Add "move exact" and "duplicate" tools to pcbnew
2015-02-12 03:22:24 +00:00
62e2537e73
selection_tool: Renamed selectSingle to selectCursor.
2014-11-21 11:49:28 +01:00
424aac6cf2
TEXTE_MODULE cleanup in preparation for text on different layers
...
- Removed the friends MODULE and FOOTPRINT_EDIT_FRAME from TEXTE_MODULE
(as in the @todo comment)
- Refactored the Rotate/Flip/Mirror for text in modules into the
TEXTE_MODULE class itself (members RotateWithModule, FlipWithModule,
MirrorWithModule)
- New behaviour in coloring text on screen: reference and value still
take the color from the MOD_TEXT_FR_VISIBLE and MOD_TEXT_BK_VISIBLE
visibles; other text takes the color of the layer containing it
(except when hidden, obviously) but still get its visibility
controlled by those visibles (probably the most intuitive and useful
behaviour)
- Still need to decide: should text on a layer be hidden when the layer
is? Probably yes (still to be implemented);
- Some comment fixed and many cast converted to static_cast
2014-09-10 17:18:42 +02:00
9fca82c23f
pcbnew: bugfix for crashes when canvas is switched while dragging items (GAL).
2014-09-08 14:09:20 +02:00
bcdd3d7bb9
Items are either dragged by their origin or moved by a vector (depending on the number of selected items) (GAL).
2014-08-06 09:35:03 +02:00
94a46bf2df
Fixed pcbnew crash when a locked footprint is dragged from an edge of the screen.
2014-08-01 11:28:08 +02:00
f24075bbf5
Fixed offset of dragged items when the moving tool is invoked by the hotkey (GAL).
2014-07-15 16:33:46 +02:00
4068d6c858
Selection tool uses the real drag origin to compute offset when dragging items.
2014-07-09 16:50:31 +02:00
433e17a582
Support for "locked" property for modules (GAL).
2014-07-09 16:50:31 +02:00
c1eda6b88c
Some of the Tool Actions need to be run in immediate mode - fixed.
2014-07-09 16:50:31 +02:00
49dd416c53
Dragged items offset is cleared when dragging is finished.
2014-07-09 16:50:31 +02:00
0953d5730b
Clear selection before opening the module editor.
2014-07-09 16:44:23 +02:00
b1837615aa
Added event queue to handle events at the end of the event processing cycle.
2014-07-09 16:25:50 +02:00
2b0e27f132
Introduced SELECTION_CONDITIONS to determine which menu entries should be visible in the SELECTION_TOOL context menu, depending on the selection.
2014-07-09 15:10:32 +02:00
bfa15d8db0
Moved SELECTION out of SELECTION_TOOL class.
2014-07-09 15:10:32 +02:00
ed88c40be5
Moved module editor-specific tools to a separate class (MODULE_TOOLS).
2014-07-09 15:02:56 +02:00
e3c4f425dc
Fixed wrong reference point for copied items in subsequent module editor invocations (GAL).
2014-07-09 14:23:13 +02:00
ac8ee56e51
Pasted module texts are rotated in the right way.
2014-07-09 14:23:13 +02:00
5941f196c3
Reference point is selected for copied items. Enabled autopanning for copy & paste operations (module editor/GAL).
2014-07-09 14:23:13 +02:00
95a4f61eee
wxWidgets 2.8 compatibility fix.
2014-07-09 14:23:13 +02:00
5e48a79639
Copy & paste for module editor (GAL).
2014-07-09 14:22:29 +02:00
ae431bbb05
Added MODULE::Add( BOARD_ITEM* )/Remove( BOARD_ITEM* )/Delete( BOARD_ITEM* ).
...
Removed MODULE::AddPad().
2014-07-09 14:22:29 +02:00
637919a699
Added support for pads, texts and graphics removal in module editor (GAL).
2014-07-09 14:01:06 +02:00
5d1ec2b204
Restored invocation of SELECTION_TOOL commands with TOOL_ACTIONs.
2014-07-09 13:50:27 +02:00
5ce29330b1
Restored support for custom angle rotation.
2014-07-09 13:50:27 +02:00
6e0bd1eedc
Adapted tools to PCB_BASE{_EDIT}_FRAME.
2014-07-09 13:50:27 +02:00
b0f3e79e54
Created a common interface for edit frames.
2014-07-09 13:50:27 +02:00
2ee890d74b
Minor changes.
2014-07-09 11:59:24 +02:00
a6dac245c0
Removed TOOL_ACTIONs: selectionSingle, selectionClear. SELECTION_TOOL methods are called directly instead.
2014-07-09 11:59:24 +02:00
a24576f3ce
Initial version of the GAL-based Module Editor.
2014-07-09 11:22:43 +02:00
553996e7be
bugfix: pads edited with properties dialog were not refreshed.
...
bugfix: changing track width/via size using the dropdown menu when custom size was enabled did not change anything.
2014-07-09 11:22:43 +02:00
95a6e8deb2
Dragging items by their origin is optional (activated by dragging elements with Ctrl held).
2014-06-23 16:12:59 +02:00
f5de166a7e
Removed an unused parameter from TOOL_BASE::getModel<T>() method.
2014-06-06 14:59:25 +02:00
afbe21fe70
Single items are dragged by their origin in GAL canvas.
2014-06-05 09:55:53 +02:00
517bfa3570
Minor code cleaning.
2014-06-04 18:01:01 +02:00
655721d9ae
Added missing changes required for updating footprints with the module editor.
2014-05-22 15:01:58 +02:00
957f959e90
Fixed bug 1321936: changing a footprint for a set of modules relocates them in GAL canvas.
...
Changes introduced by the module editor are updated in GAL canvas.
2014-05-22 12:06:45 +02:00
562beafcde
Fixed modification point for EDIT_TOOL when the tool is not active.
2014-05-13 11:22:51 +02:00
9325a9e74d
Fixed rotation/flip point.
2014-05-13 11:22:51 +02:00
a0801e2d8e
Pad properties are back.
2014-05-13 11:22:51 +02:00
929008c6c3
SELECTION_TOOL updates dragging offset after rotating/flipping.
...
Cursor position is saved as a field in order to avoid drifting of items while they are being dragged and rotated/flipped.
2014-05-13 11:22:51 +02:00
e6fd3934d1
Fixed ratsnest update after removing items.
2014-04-09 16:57:22 +02:00
14687a45a7
Fixed occasional crashes on undo/redo while dragging.
2014-04-04 12:56:50 +02:00
1ef68d73e5
Fixed missing transitions for EDIT_TOOLs.
2014-04-03 10:24:27 +02:00
b6aa832f83
Converted std::bind1st to boost::bind.
2014-04-02 16:30:48 +02:00
e79934b03d
If tool was previously active and it is called again, it is brought to the top of the active tool stack.
...
It fixes issue of dragging of items that have EDIT_POINTs, when dragging was activated by hovering over an item and using hot key.
2014-04-01 14:35:09 +02:00
1fa49ce7f0
Fixed drifting for items dragged using EDIT_TOOL.
2014-04-01 13:30:31 +02:00
093e311a8d
Fixed a few ratsnest glitches in GAL.
2014-03-19 15:33:13 +01:00
f87f12e222
Added TOOL_ACTION for updating EDIT_POINTS.
...
EDIT_POINTs show up when there is only one item selected (now after deselection as well).
2014-02-28 16:53:28 +01:00
c5c83bd271
Added TOOL_MANAGER & ACTION_MANAGER::RunAction( const TOOL_ACTION aAction ).
...
Selection clearing is invoked using TOOL_ACTION object rather than its name.
2014-02-28 15:46:05 +01:00
597e98dbf4
Cursor is in world coordinates.
2014-02-13 20:23:28 +01:00
17c030aa98
Fixed removal of items in the KiCad-default style.
2014-02-05 11:08:34 +01:00
f922533978
Added possibility for editing pads properties.
2014-02-05 09:05:27 +01:00
8df0f769f7
Added KiCad-style modification methods (hover over an item and press a hot key, without selecting first).
...
Modification point is selected basing on the number of selected items.
Rotation angle setting (Preferences->General) is taken into account while rotating.
2014-02-04 17:27:00 +01:00
625dcddb27
Added 2 tool actions:
...
- pcbnew.InteractiveSelection.Single for selecting a single item
- pcbnew.InteractiveSelection.Clear for clearing the selection
Made SELECTION_TOOL::clearSelection private.
2014-02-04 16:03:56 +01:00
106fa9bbd8
Edit tool may still be activated if it was invoked with no selected items.
2014-02-04 14:21:29 +01:00
bec24b6c7f
Ratsnest is updated after rotation, flip, undo/redo operations.
...
Fixed crashes of ratsnest when a pointer for an item has changed after undo/redo operations.
Vias are properly removed from ratsnest (pcbnew/class_board.cpp).
2014-01-29 10:17:14 +01:00
83f7c7e35e
Added RN_DATA::Add()/Remove() methods.
...
RN_DATA::Update()/AddSimple() take BOARD_ITEM* as the parameter (instead of being split to versions with BOARD_CONNECTED_ITEM* and MODULE*), to make the code look clearer.
2014-01-28 16:30:58 +01:00
8f054a606f
Fixed snapping and ratsnest update for EDIT_TOOL.
2014-01-07 17:23:17 +01:00
84c496e138
Upstream merge
2013-12-19 11:15:27 +01:00
7ce91d4e38
Fixed zone area removal (& undoing) using the EDIT_TOOL.
2013-12-18 17:16:15 +01:00
f4de2877f3
Added possibility of removing selected items while dragging.
2013-12-18 15:38:38 +01:00
fd0a3348ea
More elegant way of handling interruption of current modifications.
2013-12-18 15:11:12 +01:00
c1d6e44413
Speed optimization during selection of multiple items.
...
Removed debug output.
2013-12-18 15:09:09 +01:00
873235304e
SELECTION_TOOL uses ITEMS_PICKED_LIST to store selected items.
...
Modifications done using the EDIT_TOOL are saved using the default KiCad's undo buffer.
If there is only one item selected, info about the item is displayed in the bottom status bar.
2013-12-18 14:33:34 +01:00
7e60cc530a
Comments.
2013-12-09 11:07:30 +01:00
a3909d4f71
Added removal of BOARD_ITEMs for the TOOL_FRAMEWORK.
2013-12-09 11:01:05 +01:00
John Beard
Maciej Suminski
Maciej Suminski
jean-pierre charras
Tomasz Włostowski
Simon Richter
decimad
Chris Pavlina
Simon Wells
Lorenzo Marcantonio