haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
35,064 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

2667 Commits

Author SHA1 Message Date
Wayne Stambaugh 598b09821a Coverity fixes. 2022-10-17 15:30:20 -04:00
Jeff Young 46752499df We need both a tool-oriented delete and one that doesn't push/pop, etc. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12600
 2022-10-17 13:21:07 +01:00
Jeff Young e9f8454a67 No DRC engine in footprint editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12658
 2022-10-16 18:39:37 +01:00
Jeff Young 4af98827fd Revert change for 11299, and update removed-pad items after zone fills. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12645
 2022-10-15 16:06:57 +01:00
Seth Hillbrand 697056fa7e Correctly sort positions for default align 
When not aligning under mouse cursor, choose the X-most element where X
is top/bottom/left/right.  Previous sorting was not correct for two
directions

Fixes https://gitlab.com/kicad/code/kicad/issues/12627
 2022-10-14 16:15:06 -07:00
Jeff Young de5980b92e Share more of the courtyard collision highlighting code. 2022-10-14 10:42:07 +01:00
Jeff Young 11dc5424cb Pull interactive courtyard checker out of move tool to share with router. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12594
 2022-10-14 00:48:37 +01:00
Jeff Young 8f1b4a9c03 Include cleanup. 2022-10-13 23:15:41 +01:00
Jeff Young 8b9cbd5805 Don't reset editPad if it still exists after model reset. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12630
 2022-10-13 00:07:30 +01:00
jean-pierre charras d0d625dcb5 BOARD_INSPECTION_TOOL::LocalRatsnestTool(): set a suitable cursor when activated. 2022-10-12 15:56:41 +02:00
Jeff Young 83310659fd Basic geometry: R != D. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12601
 2022-10-10 19:18:37 +01:00
Jeff Young 8470b178cd Use actual pad shapes or built outline instead of effective shpaes for anchors. 
The effective shapes don't work very well in the custom pad or rounded
rectangle cases, and they're somewhat slower in some of the other cases.

Fixes https://gitlab.com/kicad/code/kicad/issues/12601
 2022-10-10 18:11:32 +01:00
Jeff Young 79dabdd484 Fix typo. 2022-10-07 23:52:47 +01:00
Jeff Young 04fec5016b Add keepout zones set to keepout footprints to footprint courtyard checker. 
(This is for the move tool, not DRC.  DRC uses more sophisticated keepout
processing which is too slow for the move tool, and doesn't let us know which
keepout area collided for collision highlighting.)

Fixes https://gitlab.com/kicad/code/kicad/issues/12594
 2022-10-07 22:23:37 +01:00
Alex 165654f114 Expose Switch Arc Posture in context menu. 2022-10-07 08:28:13 +03:00
Alex d26b59a0bf Improve arc construction using angles from arc geometry manager. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11713
 2022-10-07 06:51:00 +03:00
Alex 22917860ef Move Enter Group for easier access. 2022-10-07 03:03:33 +03:00
aris-kimi f818f3a445 Fix footprint rule and zone area anchors 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12575
 2022-10-06 15:29:18 +00:00
Jeff Young 436d75e7f9 Try to reconcile SELECTION and BRIGHTENED use of overlay. 
For some reason the overlay doesn't get redrawn during the PCBNew
selection disambiguation menu, so we need to not hide BRIGHTENED
items.

Fixes https://gitlab.com/kicad/code/kicad/issues/12547
 2022-10-04 17:01:56 +01:00
Jeff Young 524a43f95e Don't select footprints on the wrong side if not visible. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12483
 2022-10-04 13:22:06 +01:00
Jeff Young ba630971af Possible fix for move/esc/esc crash. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12553
 2022-09-30 23:05:55 +01:00
Jeff Young 6a6ef9b1f4 Bring adding-to-group and hiding in sync. 2022-09-30 16:45:00 +01:00
Mike Williams c1da59b560 Swap: disallow swapping tracks / wires 
Also fix missed shortcut change for S -> Shift-S

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12538
 2022-09-29 17:04:43 -04:00
Jeff Young d67437a2aa Move ratsnest exclusion processing to a post-pass. 
Also fixes a few cases where we were unnecessarily rebuilding
connectivity more than once for an operation.
 2022-09-29 17:08:49 +01:00
Seth Hillbrand 9894acea76 Spelling 2022-09-28 17:09:43 -07:00
Alex 4095172259 ADDED: Pack and Move Footprints, improved footprint spread algorithm. 2022-09-28 13:37:23 +00:00
Jeff Young 3a7068b346 Iterate on a copy of the selection since we're going to delete from it. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12484
 2022-09-27 23:54:19 +01:00
Mike Williams 700edb95e3 PCB Actions: Grab Unconnected 
Grabs the nearest unconnected item for each selected footprint/pad.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/1986
 2022-09-26 16:17:41 -04:00
Mike Williams f4a3062684 PCB: Select Unconnected 
Selects the all unconnected items for each selected routable item.
 2022-09-26 16:17:41 -04:00
Mike Williams e66393c4dd PCB Tools: Move Individually 
Allows moving a selection of components one by one.
 2022-09-26 16:17:41 -04:00
Marek Roszko 2490ad1458 Fix search panel not remembering visibility 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12494
 2022-09-25 11:56:41 -04:00
Marek Roszko 59d62f7df1 Untangle some includes 2022-09-25 11:37:06 -04:00
Jeff Young 7e71dc084c Implement Mirror H/V for tracks and vias. 
While not that often useful, it's really annoying that it doesn't work
when you *do* find a use-case for it.

Fixes https://gitlab.com/kicad/code/kicad/issues/6853
 2022-09-24 19:55:48 +01:00
Jeff Young 328cc27020 Add pad-recombining to FPEditor's Cleanup Graphics. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12487
 2022-09-24 19:34:06 +01:00
jean-pierre charras 28f836ab5c Fix overzealous string replacement 2022-09-23 10:56:58 +02:00
Jeff Young 897135a4f0 Support mirroring on the board too. 
Also fixes a few bugs in FP item mirroring.

Fixes https://gitlab.com/kicad/code/kicad/issues/2168
 2022-09-22 15:05:58 +01:00
Jeff Young 8eb68ee472 Add pin/unpin context menu to Symbol Chooser and Footprint Chooser. 
Also moves some more code down into common so it can be shared.

Fixes https://gitlab.com/kicad/code/kicad/issues/12384
 2022-09-21 14:45:12 +01:00
Jeff Young 513fc872bb Support both X and Y mirroring in FPEditor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12409
 2022-09-21 00:16:27 +01:00
Seth Hillbrand 0150655ed3 Fix missing DRC check with via 
When the via is first and not second in our ordering, the hole-copper
clearance was not checked as the track did not have a hole.

We also calculated the NPTH-via clearance incorrectly in the inspector
 2022-09-20 13:43:01 -07:00
Jeff Young 64a6fc0fd4 Push UNITS_PROVIDER down into a low-level mixin. 
This allows us to also construct cheap UNIT_PROVIDERs for specific
tasks when necessary.
 2022-09-19 17:10:59 +01:00
jean-pierre charras 5990595619 When adding a bitmap, do not clone it during moving. 
Cloning is not necessary, and is memory consuming.
 2022-09-19 17:41:47 +02:00
Mike Williams ca0c9f12e0 PCB Editor: Unroute Footprint 
Also works on selected pads.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/1955
 2022-09-19 10:37:10 -04:00
Mike Williams 9304607624 TOOL_EVENT: make command string non-optional 
We're getting segfaults in places where this isn't checked. Also, add
some asserts so we can catch bad tool push/pop.

Removes all uses of GetCommandStr() and makes it private.
 2022-09-19 10:23:09 -04:00
Jeff Young 45d6b4a9fc Readability improvements. 2022-09-19 11:18:20 +01:00
Jeff Young 1566bd8b14 Make sure a collector has a guide before handing it to a client filter. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12460
 2022-09-18 18:14:47 +01:00
Marek Roszko 3d5913c825 Remove convert_to_biu.h, merge contents to base_units.h 2022-09-16 21:09:28 -04:00
Marek Roszko 66e8931405 Remove IU_PER_MM thats standalone 2022-09-16 21:09:27 -04:00
Marek Roszko e6ed275c25 Repoint IU_PER_MILS 2022-09-16 21:09:26 -04:00
Marek Roszko a8613ee80f Combine Iu2Millimeter & remove PcbMm2iu 2022-09-16 21:09:26 -04:00
Jeff Young 107f409106 Use router's connectivity algorithm, not CONNECTIVITY_DATA's. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-09-16 22:49:20 +01:00
Jeff Young d9f75556bd Fix old copy/paste error (from 2017, believe it or not). 
Fixes https://gitlab.com/kicad/code/kicad/issues/11487
 2022-09-16 11:25:27 +01:00
Mark Roszko b00178adb3 Nuke base_units from orbit 2022-09-16 04:38:10 +00:00
Jeff Young ce9adeaf51 Don't set FreeVia when we can't find a net. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12421
 2022-09-15 23:16:08 +01:00
lulu731 0180bcf90a ADDED: Implement Drag and Drop 
dropping files to Kicad manager :
  *.kicad_pro, *.pro -> open project;
  gerber and job files -> open in Gerbview editor;
  Eagle and Cadstar files -> open project.
dropping file to schematic editor -> append schematic;
dropping library file to Symbol editor -> add library;
dropping board file to PCB editor -> append board;
dropping library or footprint file to Footprint editor -> add library or import footprint;
dropping ZIP file or gerber files to Gerbview editor -> open files;
dropping sheet file to Drawing Sheet editor -> open sheet.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11638
 2022-09-14 22:28:09 +00:00
Jeff Young 2d3b8d6393 Fix logic around Select All inside an entered group. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12411
 2022-09-14 12:24:51 +01:00
Jeff Young 281b9d405a ADDED ability to specify where pad number (& net name) go on custom shaped pads. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6627
 2022-09-14 11:37:20 +01:00
Jeff Young f91487aa36 Don't overwrite titleblock and pageinfo when appending board. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11650
 2022-09-14 11:37:20 +01:00
Mark Roszko f304e2d4f6 ADDED: Search/inspect pane 2022-09-14 02:59:57 +00:00
Mike Williams 1a023f5dd0 PCB Editor: (Auto)Route Selected (From Other End) 
3x Selection-Based Routing Tools. Takes a selection of routable objects
and routes them one at a time individually, with an attempted finish, or
from the other end, depending on the action given.
 2022-09-13 15:06:36 +00:00
Jeff Young 0a5ca5b485 Display crosshairs in picker tools. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10183
 2022-09-13 01:40:43 +01:00
Jeff Young c2643f53cf Tighter control over lambda capture. 2022-09-12 20:51:15 +01:00
Jeff Young eaccd40c75 Allow vias to connect <no net> tracks even when DRC checking is on. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12403
 2022-09-12 20:38:21 +01:00
Mike Williams 37d2addf0e Icons: add swap 2022-09-12 11:11:49 -04:00
Mike Williams f70e1d0f22 SCH/PCB: Set Swap hotkey to 'S' 
* Move Add Sheet to Shift+S in Schematic Editor
* Move Set Grid Origin to Shift+S in PCB Editor
 2022-09-12 11:11:49 -04:00
Mike Williams de6e368ac6 PCB: Swap Tool 2022-09-12 09:39:43 -04:00
Jeff Young 9cf3c529d3 Apply the same accuracy band to connectivity as we use for hittesting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-09-09 21:42:21 +01:00
Jeff Young 5b3bd9be83 Prune pasted data of non-enabled layers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11997
 2022-09-09 21:02:08 +01:00
Jeff Young 98e760da93 Coverity-suggested improvements. 2022-09-09 13:41:13 +01:00
Jeff Young 2743fd583f More improvements to drag tool selection disambiguation. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-09-08 23:43:07 +01:00
Jeff Young a619ef9d53 Improve drop-a-knee-selection-to-a-single-segment algorithm. 
In particular, don't rely on there being only two items in the
collector at the start.

Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-09-08 14:10:18 +01:00
jean-pierre charras 6b3d36b6c3 CONVERT_TOOL: also show the "Create From Selection" menu if a array can be created 
The "Create Array" sub-menu was recently moved to this menu, so it must me
shown as soon as an array can be created.
 2022-09-07 10:53:27 +02:00
Alex d67c81a657 When deselecting items, pick only selected ones. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10292
 2022-09-06 19:44:29 +00:00
jean-pierre charras 963a17f5b5 fix a compil warning 2022-09-05 18:33:17 +02:00
Jeff Young 895a8a8dbc Work around focus issues for status popups. 
Autoscroll wasn't working on Mac because the status popup's panel
has the focus.  This *may* also fix a problem on MSW of the auto-scroll
not being cancel-able.

Fixes https://gitlab.com/kicad/code/kicad/issues/11425
 2022-09-04 21:08:01 +01:00
Jeff Young efae2bbb4c Better feedback for netclass assignment patterns. 2022-09-03 21:33:56 +01:00
Jeff Young c30a557810 ADDED netclass assignment from PCB canvas. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5975
 2022-09-03 19:29:59 +01:00
Jeff Young 09773e3e2e Make sure dirty flag gets set, and leave save enabled regardless. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11824
 2022-09-01 14:27:16 +01:00
Jeff Young 9188838e50 RIP EDA_RECT. 2022-08-31 23:57:24 +01:00
Jeff Young b4492e0bd2 More EDA_RECE yeetage. 2022-08-31 17:19:50 +01:00
Jeff Young ebe9617e77 More EDA_RECT expungification, and an attempt to fix the python test. 2022-08-31 17:19:48 +01:00
Jeff Young 5679b9dbdc Remove a few EDA_RECT instances. 2022-08-31 01:22:49 +01:00
Jeff Young 0c8787cbb9 Some more wxPoint/EDA_RECT yeeting. 2022-08-31 00:44:33 +01:00
Seth Hillbrand b736460e71 Move optional access from value() to *operator 
`value()` throws.  Where we check for existence, we don't need to use
the throwing version and should just use the unprotected variant
 2022-08-30 13:59:39 -07:00
Mike Williams a176bf383e Properties: pick up single selections 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12302
 2022-08-30 13:59:37 -04:00
Seth Hillbrand 91fbb5c957 Don't prevent immediate actions while router active 
Immediate actions that can take place are useful.  We should only be
preventing immediate actions while actively routing or dragging

Fixes https://gitlab.com/kicad/code/kicad/issues/12311
 2022-08-30 10:31:29 -07:00
Jeff Young 63386ba64d Pointer safety for ERC/DRC dialogs. 
Also makes the "Edit ingored violations" easier to find.

Fixes https://gitlab.com/kicad/code/kicad/issues/12308
 2022-08-30 12:07:19 +01:00
Jeff Young 2d68cdff94 Better reporting of hole-to-hole clearances and clearance resolutions. 2022-08-29 17:37:49 +01:00
Jeff Young b886ec728e Copy shape data when converting PCB TEXTBOX to FP. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12298
 2022-08-28 21:34:13 +01:00
jean-pierre charras 3b4c5f0dc4 French translation update 2022-08-27 09:10:02 +02:00
Jeff Young 09511d176c Quiet Coverity. 2022-08-26 17:05:25 +01:00
Seth Hillbrand 06786c34d7 Blacklist hashes for 2d integer elements 
The hash table for integer hashes is extremely limited and places most
elements in the same buckets.  This leads to a linear search time for
structures built on this.

This blocks hashes, directing the coder to utilize std::set or std::map
structures instead of hash tables for implementing integer-based
lookups.
 2022-08-26 08:43:37 -07:00
Seth Hillbrand f1261e71d4 Replace boost::optional with std::optional 2022-08-25 15:50:47 -07:00
Seth Hillbrand fb74bdb059 Don't consider rule area zones in priority calc 2022-08-25 10:12:58 -07:00
Seth Hillbrand e661545ecf Choose the first unused priority value for zones 
Default the new zone priority value to the lowest available unused
priority.  Ensures that, by default, a new zone has a unique priority
level preventing zones from unintenionally shorting
 2022-08-25 10:05:30 -07:00
Seth Hillbrand 418df36790 Avoid teardrops in priority calculation 
When choosing a new priority value, don't look at teardrops (which have
high priority)
 2022-08-25 08:41:14 -07:00
Seth Hillbrand 3e4cfab254 Set new zone priority to unique number 
Previously new zones' priorities were all set to 0.  This is almost
always wrong and can lead to unintended conflicts.  The new zone default
value is now set to one higher than the largest number on the board.
This is a better default value because it will not conflict with
existing values.
 2022-08-24 16:37:57 -07:00
Jeff Young 1871812f2b Consolidate on a more widely used sub-type architecture. 2022-08-23 12:57:55 +01:00
Maciej Suminski f6f6ebd5f9 WIP: Properties GUI 2022-08-22 21:32:32 -04:00
Jeff Young 1e68c353f1 Account for groups in undo of Position Relative To. 
Also fixes a bug were pads weren't correctly being found for anchoring
the selection before the Position Relative To.

Fixes https://gitlab.com/kicad/code/kicad/issues/11793
 2022-08-22 22:33:38 +01:00
Alex 3a76d42630 Cross-probing/selection for multiple items (PCB -> SCH) 
Fixes https://gitlab.com/kicad/code/kicad/issues/10469
 2022-08-22 19:33:39 +00:00