kicad

Commit Graph

Author	SHA1	Message	Date
Jeff Young	c243c7e1b8	Don't lock user out of OK'ing libraries dialog.	2022-07-11 19:04:08 -06:00
Alex	aaf99eb0cc	Performance optimizations.	2022-07-11 21:25:12 +00:00
Mike Williams	e454595348	Eeschema: Changing pin length adjusts offset according to orientation ADDED: When pin length is changed now, the pin position is adjusted according to its orientation such that the connection point for wires moves instead of the other side of the stem base. For pins coming out of component boxes, etc. this keeps them attached to the box while the length is changed.	2022-07-11 13:58:06 -04:00
Jeff Young	0a623bff9f	Save fp browser list widths and apply known hack to work around wxWidgets bug. Fixes https://gitlab.com/kicad/code/kicad/issues/11744 Fixes https://gitlab.com/kicad/code/kicad/issues/11745	2022-07-10 23:07:04 -06:00
Jeff Young	d07c6699ce	Bring symbol editor in line with eeschema for empty text. Fixes https://gitlab.com/kicad/code/kicad/issues/11799	2022-07-10 20:37:26 -06:00
Jeff Young	4685dc49cc	Show more than 9 items in disambiguation menu. (But only the first 9 get hotkeys.) Fixes https://gitlab.com/kicad/code/kicad/issues/11966	2022-07-10 20:11:22 -06:00
Jeff Young	b759d860c0	Don't disambiguate if the user is dragging a multiple selection. Fixes https://gitlab.com/kicad/code/kicad/issues/10108	2022-07-10 19:45:56 -06:00
Jeff Young	e122dc38bd	Add context menu item for clearing net highlighting. In selection tools, drawing tools, router tool, line_wire_bus tool. Fixes https://gitlab.com/kicad/code/kicad/issues/11920	2022-07-10 17:15:20 -06:00
Jeff Young	98c7572f5e	Minor dialogs fixes for Mac.	2022-07-10 11:30:25 -06:00
Jeff Young	63d83f4186	Minor dialogs fixes for Mac.	2022-07-10 11:15:52 -06:00
Jeff Young	1ce3744c70	Honour stroke colour in LIB_SHAPE. Fixes https://gitlab.com/kicad/code/kicad/issues/11955	2022-07-10 10:47:22 -06:00
Jeff Young	eb27a3f8b9	Added pinning support to various EDA_LIST_DIALOGs. Footprint Save As, Symbol Save As, etc.	2022-07-09 20:44:49 -06:00
Jeff Young	05219e4d9a	Add pinned library support to Choose Symbol and Choose Footprint.	2022-07-09 20:06:31 -06:00
Jeff Young	190fb23e88	Add pinned library support to Footprint and Symbol Viewers. Also includes adding libraray and symbol filters to Symbol Viewer.	2022-07-09 17:41:10 -06:00
Jeff Young	00fc225306	Give <esc>-with-no-selection-clears-net-highlight a test. Fixes https://gitlab.com/kicad/code/kicad/issues/8760	2022-07-09 11:56:16 -06:00
jean-pierre charras	fb5604022c	Eeschema: DIALOG_SCH_FIND: ensure the search flags actually used are up to date. Flags are encoded using internal wx values, that can change with wxWidgets versions. They need to be always rebuilt from the displayed options in dialog. Fixes #11960 https://gitlab.com/kicad/code/kicad/issues/11960	2022-07-09 10:28:53 +02:00
Jeff Young	70aec5d576	Don't drag both ends after Break Wire. Fixes https://gitlab.com/kicad/code/kicad/issues/11915	2022-07-08 23:03:41 -06:00
Jeff Young	0953395c87	LIB_SHAPE slightly abuses SHAPE_POLY_SET by using it for line chains. Fixes https://gitlab.com/kicad/code/kicad/issues/11956	2022-07-08 21:35:40 -06:00
Jeff Young	ded611aed5	Patch annoying large checkbox cols in wxWidgets 3.1.x on OSX.	2022-07-08 17:27:05 -06:00
Jeff Young	5479514819	Honour m_resolveTextVars flag for properties as well as fields. Fixes https://gitlab.com/kicad/code/kicad/issues/11937	2022-07-08 17:27:05 -06:00
Jeff Young	a16fc5b537	Go back to native headers for Symbol Fields dialog. Some of the drag issues are fixed in wxWidgets 3.1.x, and the balance of problems now favours native. Fixes https://gitlab.com/kicad/code/kicad/issues/9771 Fixes https://gitlab.com/kicad/code/kicad/issues/11835 Fixes https://gitlab.com/kicad/code/kicad/issues/11836	2022-07-08 17:27:05 -06:00
Jeff Young	fe1bff7d29	Remove empty infobar message. I'm not sure what this was for, but it seems like a bad idea and I got a few crashes near here.	2022-07-08 17:27:05 -06:00
Jeff Young	62cef3d830	Add LAYER_PRIVATE_NOTES for private text & graphics in symbol editor. Fixes https://gitlab.com/kicad/code/kicad/issues/11957	2022-07-08 17:27:05 -06:00
jean-pierre charras	f47a4ec92a	Eeschema: fix typo in commit `428bbc2` that make it not working.	2022-07-08 09:48:34 +02:00
Seth Hillbrand	428bbc201b	Ensure last column of csv export has terminator Last shown column can be different from the last exported column Fixes https://gitlab.com/kicad/code/kicad/issues/11981	2022-07-07 11:23:18 -07:00
Seth Hillbrand	6fef054c51	Handle basic rounding error in schematic import The fractional part of Altium schematic units is an integer number of 1/10000 mil segments, which is 2.54 nm. The internal unit of eeschema is 10 nm, so each fractional unit in Altium is 0.254 base eeschema units. To be consistent with `cf33cfcad1` we round to the nearest 10nm for each element Fixes https://gitlab.com/kicad/code/kicad/issues/11742	2022-07-07 11:13:11 -07:00
jean-pierre charras	4db72f2d55	Fix minor compil and Coverity warnings.	2022-07-07 12:38:34 +02:00
jean-pierre charras	7b28804f67	Fix a minor compil and Coverity warning	2022-07-06 13:54:17 +02:00
Seth Hillbrand	ff54b8c718	Overplot schematic symbol fields and pins In the absence of z-ordering, we need to ensure that pin text and symbol fields are always visible in plots as they are in the schematic window. We do this by overplotting the fields/pins when symbols overlap each other. This can be removed if/when we implement https://gitlab.com/kicad/code/kicad/-/issues/2211 Fixes https://gitlab.com/kicad/code/kicad/issues/11969	2022-07-05 16:39:53 -07:00
Miklos Marton	d30af7c164	eeschema: Add automatic rotate feature for placing global and hierarchial labels	2022-07-05 17:02:45 +00:00
Seth Hillbrand	cde30d3dba	Clarify cross-probing options Previous the cross-probing options were mixed between sending and receiving cross-probe events. This clarifies so that all of the pcbnew cross-probe options deal with whether the cross-probe is seen in pcbnew and all of the eeschema options deal with seeing the event in eeschema. Also updates the wording in the options panels to be the same where possible and adds tooltips Fixes https://gitlab.com/kicad/code/kicad/issues/11454	2022-07-01 16:47:09 -07:00
Seth Hillbrand	939313088e	Units are stored in the instance data At the moment, units are stored in the instance data, so when loading the file, all symbols will have bbox for the first unit. After calling `UpdateUnit()`, we need to recache the rtree bounding boxes to get correct hit tests Fixes https://gitlab.com/kicad/code/kicad/issues/11681	2022-06-30 14:59:17 -07:00
Marek Roszko	9b0531db54	Drop xsl/xslt files Users may still use xsltproc with kicad as the invocation of third party tools remains. We simply are not maintaining these xsl sample scripts anymore nor bundling xsltproc. Fix https://gitlab.com/kicad/code/kicad/-/issues/9074	2022-06-29 21:22:34 -04:00
Mike Williams	66b3b48e93	Library Editor: Fix missing automatic annotation Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11818	2022-06-29 14:17:21 +00:00
Jeff Young	dbbdc9d2e6	Don't rely on the penWidth already being set when setting the dash style. Fixes https://gitlab.com/kicad/code/kicad/issues/11908	2022-06-29 07:34:45 -06:00
Jeff Young	4a8aaefdc0	Implement line style printing for LIB_SHAPE. Fixes https://gitlab.com/kicad/code/kicad/issues/11883	2022-06-29 07:34:45 -06:00
Seth Hillbrand	66d3bf2bc2	Refresh draw objects when common settings change Common settings may change colors so make sure that we refresh the draw objects when the settings change to draw them in the proper colors. Failing to do this may also cause left over lines on the screen depending on OpenGL drivers Fixes https://gitlab.com/kicad/code/kicad/issues/11921 (cherry picked from commit `8aabdcff9c`)	2022-06-28 16:46:19 -07:00
Seth Hillbrand	6a8519dfd9	Fix ERC error missing on stacked pins Stacked pins are not connected, so they should be flagged as such. This checks for stacked pins that are not part of different symbols Fixes https://gitlab.com/kicad/code/kicad/issues/11926 (cherry picked from commit `90ef84b958`)	2022-06-28 15:04:14 -07:00
Wayne Stambaugh	4e7b5b9784	Eeschema: fix project rescue bug. When a rescue library already existed, the disabled writing of legacy symbol library table entries prevented the rescue library from being updated. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11897	2022-06-28 15:05:06 -04:00
Mike Williams	252afe41f3	Schematic: remove old, invalid angle choice from editing options	2022-06-28 16:29:14 +00:00
Jeff Young	83a2f43661	Apply DRC fixes to ERC. Fixes https://gitlab.com/kicad/code/kicad/issues/11844	2022-06-27 21:07:03 -06:00
Jeff Young	d5a6452934	Get rid of special default line style for Eeschema. Fixes https://gitlab.com/kicad/code/kicad/issues/11882	2022-06-27 19:12:45 -06:00
Jeff Young	d9cfbc7b96	Fix missing SCH_LABEL case in SCH_PLUGIN. Fixes https://gitlab.com/kicad/code/kicad/issues/11913	2022-06-27 16:21:32 -06:00
Jeff Young	14886e426b	Move prior fix from SCH_GLOBAL_LABEL to SCH_LABEL_BASE. Fixes https://gitlab.com/kicad/code/kicad/issues/11768	2022-06-26 20:55:25 -06:00
Seth Hillbrand	03c279ffd4	ADDED: Threadpool Thread pools are long-lasting executors that have close to zero overhead when launching new jobs. This is advantageous over creating new threads as we can use this for threading smalling jobs and smaller quanta. It also avoids the heuristics needed to determine the optimal number of threads to spawn	2022-06-24 22:59:24 +00:00
jean-pierre charras	de45e2b1fd	Textbox in symbols: fix incorrect position of the box when printing. Fixes #11884 https://gitlab.com/kicad/code/kicad/issues/11884	2022-06-24 17:08:29 +02:00
jean-pierre charras	554b31bb2a	eeschema: fix crash when changing the GAL engine, especially if the grid is shown. GetGAL()->DrawGrid() was called when switching the engine, outside a paint event, thus creating a crash (at least on Windows) probably because the new Gal stuff was not fully initialized.	2022-06-24 15:49:28 +02:00
Seth Hillbrand	7b9dc1b9f0	Fix Eeschema Arc plotting The start/end point plotting is not reliable for eeschema. We need to preconvert to angles to get the correct winding as the default plotter conversion in the PLOTTER class makes pcbnew-based assumptions Fixes https://gitlab.com/kicad/code/kicad/issues/11885	2022-06-22 16:46:28 -07:00
Ian McInerney	b51d8c9825	Introduce new CMake variable to store kiface install location	2022-06-22 23:40:25 +01:00
jean-pierre charras	82b2df67be	Add 2 automatically generated files to the source tree. These files are needed by translators, so it is better to add them to the source without need to build kicad.	2022-06-22 08:51:04 +02:00
Seth Hillbrand	a852286eb5	Cleanup compile warnings	2022-06-21 17:04:56 -07:00
Miklós Márton	f2382a7bd1	Add Make selected active/inactive actions to the symbol libraries context menu Fixes #11372	2022-06-21 23:32:02 +00:00
Seth Hillbrand	aeef5b00a8	Unify symbol browser/editor unit display Fixes https://gitlab.com/kicad/code/kicad/issues/11881	2022-06-21 16:22:54 -07:00
Jeff Young	494d79423e	Fix typo. Fixes https://gitlab.com/kicad/code/kicad/issues/11809	2022-06-19 20:56:22 +01:00
Jeff Young	45ab15dc95	Use unit references in status bar. Fixes https://gitlab.com/kicad/code/kicad/issues/11854	2022-06-19 12:54:30 +01:00
jean-pierre charras	50b68df666	Eeschema, SCH_PIN: fix incorrect initialization of m_layer member (now is LAYER_PIN) m_layer was not re-initialized in CTOR, so it was the default value (LAYER_WIRE) This is incorrect for a pin, and can create errors in some functions (like IsType() ) Fixes #1818 https://gitlab.com/kicad/code/kicad/issues/1818	2022-06-17 11:01:49 +02:00
Jeff Young	34e706bcbc	Border colours and line styles for symbol editor. Fixes https://gitlab.com/kicad/code/kicad/issues/11810	2022-06-16 14:52:38 +01:00
jean-pierre charras	c79dd09464	PANEL_SYM_LIB_TABLE: fix a bug in filenames from wxFileDialog dialog. We want the full path, so use GetPaths. GetFilenames sometimes return the full path in wxWidgets 3.1.7, not always the filename Fixes #11821 https://gitlab.com/kicad/code/kicad/issues/11821	2022-06-16 13:04:27 +02:00
Roberto Fernandez Bautista	8725c3a35f	CADSTAR Schematic: Load symbols even if part definition is incomplete Fixes https://gitlab.com/kicad/code/kicad/-/issues/11671	2022-06-15 19:47:50 +01:00
jean-pierre charras	631eecd7d6	symbol_checker: better message about reference prefix.	2022-06-15 18:37:27 +02:00
Jeff Young	2c280e83c3	Handle junctions in MarkConnections. Fixes https://gitlab.com/kicad/code/kicad/issues/8579	2022-06-15 16:28:33 +01:00
jean-pierre charras	b56917210d	symbol_checker: add test for valid reference prefix.	2022-06-14 20:45:26 +02:00
jean-pierre charras	1140fd0fb0	Eeschema, context menus: move edit value, ref and footprint to a submenu. remove also Select All menuitem from the move context menu.	2022-06-13 11:35:17 +02:00
Jeff Young	52bc2511cd	Add a radioButton mode to IMAGE_BUTTON. Fixes https://gitlab.com/kicad/code/kicad/issues/11797	2022-06-12 20:09:46 +01:00
Jeff Young	c6604e3576	Labels can connect directly to symbols, other labels, etc. Fixes https://gitlab.com/kicad/code/kicad/issues/11768	2022-06-12 18:15:58 +01:00
Jeff Young	69c1f88e53	Update symbol instances after sheet rename. Fixes https://gitlab.com/kicad/code/kicad/issues/11782	2022-06-12 15:46:37 +01:00
Marek Roszko	08dbc3a53c	Move the symbol editor to the new filedlg customize	2022-06-11 22:59:59 -04:00
Marek Roszko	ff94d289c7	Move the eeschema standalone to the new save dialog	2022-06-11 22:06:42 -04:00
Jeff Young	a0421b172a	Add missing color swatch to Symbol Editor Text Properties. Fixes https://gitlab.com/kicad/code/kicad/issues/11791	2022-06-11 22:14:14 +01:00
Jeff Young	e4798199c6	Handle alt pins in plot code. Fixes https://gitlab.com/kicad/code/kicad/issues/11728	2022-06-10 22:38:01 +01:00
Jeff Young	29900cad34	Add create-wire logic to labels. Fixes https://gitlab.com/kicad/code/kicad/issues/11768	2022-06-10 22:38:01 +01:00
jean-pierre charras	e0f0bb2edd	Eeschema: Fix issues when converting a label/text to another label text type. - make convert to/from SCH_DIRECTIVE_LABEL working. - Autoplace fields of new labels Fixes #11779 https://gitlab.com/kicad/code/kicad/issues/11779	2022-06-10 14:13:22 +02:00
jean-pierre charras	b712c2c0da	Eeschema: fixes about Hierarchy panel/pane handling	2022-06-09 19:43:09 +02:00
Jeff Young	bce1fd337b	Second tool hotkey accepts action (ie: acts as click). Fixes https://gitlab.com/kicad/code/kicad/issues/11729	2022-06-09 16:54:04 +01:00
jean-pierre charras	35bde4710c	Eeschema, context menu selection: move convert to ... menuitems to a submenu. Add also missing icons in a few menuitems. Fixes #11776 https://gitlab.com/kicad/code/kicad/issues/11776	2022-06-09 16:46:21 +02:00
jean-pierre charras	ef2e51b493	Eeschema: code refactor and fix missing save project setting when closing the sch editor.	2022-06-09 13:39:09 +02:00
Jeff Young	6bfd106bed	Add missing text colour to symbol editor textbox dialog. Fixes https://gitlab.com/kicad/code/kicad/issues/11770	2022-06-09 10:37:23 +01:00
Jeff Young	b710982875	Fix broken logic for hidden pins. Fixes https://gitlab.com/kicad/code/kicad/issues/11771	2022-06-09 10:37:23 +01:00
Jeff Young	6e50a3518f	Fix typo. Fixes https://gitlab.com/kicad/code/kicad/issues/11769	2022-06-08 23:53:18 +01:00
Jeff Young	ec40a98fe2	wxT	2022-06-08 23:53:18 +01:00
jean-pierre charras	b401e98c80	Eeschema, hierarchy navigator: fixes and enhancements. Work in progress.	2022-06-08 18:23:03 +02:00
Jeff Young	46fd32b738	Update grid attributes after sorting. Fixes https://gitlab.com/kicad/code/kicad/issues/11753	2022-06-08 15:25:13 +01:00
Jeff Young	34932e097c	Minor dialog cleanup.	2022-06-08 15:25:13 +01:00
Jeff Young	c55a0e4561	Separate last-created-params for textboxes from shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/11755	2022-06-08 15:25:13 +01:00
jean-pierre charras	185016b84b	Eeschema, Hierarchy navigator: add tool to Hide/show the panel. Add also a close button to the pane.	2022-06-07 11:11:10 +02:00
Jeff Young	244042ce51	Keep footprint selection in Symbol Chooser history list. Fixes https://gitlab.com/kicad/code/kicad/issues/1841	2022-06-06 22:24:02 +01:00
Wayne Stambaugh	dfea73f78c	Eeschema: fix symbol library remap bug. The original decision to escape the legacy symbol library names results in them being escaped every time they are opened which cause the curly braces '}' from the original escaping to be escaped on subsequent openings. This resulted in the symbol library names in the rescue library not matching the library ID in the schematic. This fix is likely to have other corner case bugs given the potential for escaped characters in legacy symbol libraries. Given that we now have escaped rescue libraries in play, removing the escaping will only result in more issues so we will have to fix the corner cases as we go. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11563	2022-06-05 17:00:57 -04:00
jean-pierre charras	9f38fa43cd	Fix some minor compil and Coverity warnings.	2022-06-05 11:44:49 +02:00
Jeff Young	31316760f6	Separate power and symbol saved search strings. Fixes https://gitlab.com/kicad/code/kicad/issues/11747	2022-06-04 22:15:39 +01:00
Jeff Young	718bb461d2	Textbox defaults for libedit. Fixes https://gitlab.com/kicad/code/kicad/issues/11739	2022-06-04 21:25:37 +01:00
Roberto Fernandez Bautista	ecbf5c1e14	Don't display unit in single unit symbols of annotation error message Fixes https://gitlab.com/kicad/code/kicad/-/issues/11748	2022-06-04 16:04:33 +02:00
Jeff Young	099061f46d	Process nested formatting within a variable cross-reference.	2022-06-04 00:34:14 +01:00
Roberto Fernandez Bautista	78e465bbd8	Fix crash in sch_navigate_tool when history was empty	2022-06-03 23:07:12 +02:00
Jeff Young	ce79a16ed8	Use default schematic text size for textboxes. Also adds support for remembering stroke info, fill info, and spin style for sch text boxes. Fixes https://gitlab.com/kicad/code/kicad/issues/11739	2022-06-03 21:48:12 +01:00
Seth Hillbrand	407514919d	Prevent null dereference	2022-06-03 10:05:55 -07:00
Mike Williams	8d51b6b6d3	Schematic: Add icons for Any/90/45 angle modes Also add a dark mode icon for existing 45hv icon. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11332	2022-06-03 15:04:52 +00:00
Mike Williams	857990a883	Hierarchy: turn into a left side pane Drop auto-closing option as well.	2022-06-02 21:56:17 +00:00
Jeff Young	aaff163d7c	Repair Eagle importer page number handling. The root sheet needs a page number, and the other sheets need to not have their last step in the path duplicated. Fixes https://gitlab.com/kicad/code/kicad/issues/11409	2022-05-31 17:48:38 +01:00
Jeff Young	abba1b04bd	Add "Enter Sheet" to Sheet tool (context menu & double-click). Fixes https://gitlab.com/kicad/code/kicad/issues/11531	2022-05-30 14:08:26 +01:00
jean-pierre charras	2701642b1b	minor fixes and French translation update	2022-05-30 11:23:20 +02:00
Jeff Young	d5d8d36d86	Implement expanding Select Connection. Fixes https://gitlab.com/kicad/code/kicad/issues/8579	2022-05-29 22:51:33 +01:00
Eduardo Behr	f246646d7a	Fix severe simulation memory leaks	2022-05-28 20:40:24 +00:00
Mike Williams	f2cf934083	Schematic: Annotation Tweaks Fix newly placed symbols to be annotated and not show a ? until placement.	2022-05-27 15:54:00 +00:00
Mike Williams	efa23a5cbe	Schematic: better automatic/recursive annotate	2022-05-27 15:54:00 +00:00
Mike Williams	7f3e5e9b79	Schematic: add recursive annotation control	2022-05-27 15:54:00 +00:00
Mike Williams	85516a4691	Schematic: add automatic annotation toggle	2022-05-27 15:54:00 +00:00
Mike Williams	dabd42bbc4	Schematic: Automatic Symbol Annotation	2022-05-27 15:54:00 +00:00
Jeff Young	6114a5d72c	Escape pin names when used as netnames. Fixes https://gitlab.com/kicad/code/kicad/issues/11687	2022-05-26 23:54:55 +01:00
Jeff Young	cb15bd1635	Fix compile issue.	2022-05-26 10:54:54 +01:00
Jeff Young	616e9b4f4b	Be cognizant of symbol transform when setting justification. Fixes https://gitlab.com/kicad/code/kicad/issues/11465	2022-05-26 10:54:08 +01:00
Roberto Fernandez Bautista	55f22c526a	Fix annotation of incomplete multi-unit symbols and re-annotation of duplicates Fixes https://gitlab.com/kicad/code/kicad/-/issues/11496	2022-05-26 09:23:36 +00:00
Seth Hillbrand	11ae5b75b7	Remove broken assert Fixes compile issue for linux/gcc which expects a boolean in the assert statement that it cannot find from std::map	2022-05-25 16:36:47 -07:00
Eduardo Behr	6aa50304d9	Eeschema: Fixing simulation plot CSV exporter	2022-05-25 15:00:03 +00:00
Miklós Márton	487c8f8e39	symbol editor: Improve pin duplication When duplicating pins in the symbol editor the duplicated pins will have unique pin numbers assigned if the duplication target had the pin number specified	2022-05-25 00:02:16 +00:00
Fabien Corona	0536ab4f6c	Remove kicad_pair in transmission lines This was a misread from the ngspice doc	2022-05-25 00:00:07 +00:00
jean-pierre charras	eae5e9f00e	Symbol checker: fix incorrect test for duplicate pins. Fixes #11660 https://gitlab.com/kicad/code/kicad/issues/11660	2022-05-23 11:20:12 +02:00
Roberto Fernandez Bautista	ea29c66608	Fix formatting	2022-05-22 07:14:24 +00:00
Chetan Shinde	4e5febdb19	Fixes the import pin issue, that the they are shown in two different way https://gitlab.com/kicad/code/kicad/-/issues/11391	2022-05-22 04:42:22 +00:00
Jeff Young	8e94c307d2	Provide default case for mirroring single objects. Fixes https://gitlab.com/kicad/code/kicad/issues/11649	2022-05-21 22:50:55 +01:00
Jeff Young	d381fd8b29	Typo. LIB_SYMBOL's value field is the name; SCH_SYMBOL's value field is not. Fixes https://gitlab.com/kicad/code/kicad/issues/11556	2022-05-20 18:01:01 +01:00
Jeff Young	23fb4c7433	Uniformly use a single facility for location-less prime events. Also implements a uniform mechanism for avoiding auto-scroll after a prime event or dialog which results in a mouse position at the edge of the canvas. Fixes https://gitlab.com/kicad/code/kicad/issues/11057	2022-05-16 23:43:00 +01:00
Jeff Young	f2fc78f380	Don't copy modifiers to prime events. The modifiers go with the hotkey, not with the action. Fixes https://gitlab.com/kicad/code/kicad/issues/11618	2022-05-16 13:51:40 +01:00
jean-pierre charras	359c99991b	Eeschema: do not leave a temporary flag set after use in draw symbol function. Fixes #11617 https://gitlab.com/kicad/code/kicad/issues/11617	2022-05-15 18:35:07 +02:00
Roberto Fernandez Bautista	9049c907a1	Fix wxWidgets assert in symbol preview widgets	2022-05-15 15:26:53 +01:00
Jeff Young	79a0ce9137	Unset forced cursor before leaving two-click place. Fixes https://gitlab.com/kicad/code/kicad/issues/11607	2022-05-14 22:38:54 +01:00
Jeff Young	38e5faf21b	Overhaul bitmap text for performance. Also adjusts metrics to better match stroke font. Also removes text-halo highlighting as it's too expensive to re-render when the zoom changes. Fixes https://gitlab.com/kicad/code/kicad/issues/11460	2022-05-14 20:09:54 +01:00
Jonathan Haas	5802ede3fd	Change default value of MatchByReference to false. Fixes https://gitlab.com/kicad/code/kicad/issues/11382	2022-05-14 12:41:25 +00:00
Marek Roszko	88c7322a0d	EDA_TEXT Get/SetTextSize should use VECTOR2I	2022-05-14 08:16:15 -04:00
jean-pierre charras	45b167dff5	Some fixes related to translated/not translated mandatory field names. DIALOG_SYMBOL_FIELDS_TABLE: add new fields to symbols only if the field is not empty.	2022-05-13 11:45:38 +02:00
jean-pierre charras	20d1d0705e	Fix a few issues related to field names and their translation. - Do not use translated field names outside strings displayed in dialogs. - fix code that does not work well with default locale. - fix some (not all) I18n issues in DIALOG_UPDATE_SYMBOL_FIELDS.	2022-05-13 11:45:37 +02:00
Seth Hillbrand	bbc250720f	Resolve title variable when plotting Be sure to use variable name if it exists when plotting the file Fixes https://gitlab.com/kicad/code/kicad/issues/11608 (cherry picked from commit `d971cbefcb`)	2022-05-12 15:31:15 -07:00
jean-pierre charras	b68514afb1	Fix a wxWidgets alert.	2022-05-12 20:58:48 +02:00
Marek Roszko	5c4f49351d	Remove extra compilation of common.cpp It's already built in the common target, no eeschema specific code	2022-05-10 21:31:31 -04:00
Marek Roszko	f85251ef75	Fix eda_doc not looking for schematic locally It looks like this was overlooked by Jeff in 2020 not realizing eda_doc isn't built under eeschema but common in `cc9ac37a0e`	2022-05-10 21:28:48 -04:00
dsa-t	ad066ef09a	Fix cross-probing in complex hierarchies, remove unused code. Fixes https://gitlab.com/kicad/code/kicad/issues/11493	2022-05-09 23:22:03 +03:00
jean-pierre charras	4bd349d922	Update some demos	2022-05-09 19:06:14 +02:00
Mike Williams	b7a77a9498	Schematic: Add CSV export to Symbol Fields Table	2022-05-09 12:02:12 -04:00
Jeff Young	8f937b17a2	Remove wxWidgets 3.0.x hack. Fixes https://gitlab.com/kicad/code/kicad/issues/11540	2022-05-07 23:24:55 +01:00
Jeff Young	f9f0f6fe24	Implement cross-references for labels. Fixes https://gitlab.com/kicad/code/kicad/issues/11564	2022-05-07 21:10:04 +01:00
Seth Hillbrand	5cd3c07862	Catch throws in DeleteSymbol DeleteSymbol may call SaveSymbol if the name is changed. In this case, SaveSymbol may throw back and needs to be caught Fixes https://gitlab.com/kicad/code/kicad/issues/11566 (cherry picked from commit `e05c8f8852`)	2022-05-06 16:13:59 -07:00
Miklós Márton	7e20c0ed9c	eeschema: removed unused code Fixes #11533	2022-05-06 17:17:55 +00:00
Jeff Young	a644aad1cf	Hand-code tab navigation from value field of Label Properties dialog. wxWidgets doesn't appear to handle it correctly, doing nothing on OSX and potentially crashing on GTK. Fixes https://gitlab.com/kicad/code/kicad/issues/11572	2022-05-06 18:14:25 +01:00
Seth Hillbrand	5f7ac58f95	Catch errors when saving individual symbols Fixes https://gitlab.com/kicad/code/kicad/issues/11566 (cherry picked from commit `f4d4f23876`)	2022-05-06 09:55:28 -07:00
Wayne Stambaugh	a19490b097	Eeschema: fix broken project symbol rescue. The legacy symbol library plugin code was changed to escape symbol names which broke the LIB_ID string comparison when checking to see if symbols needed to be rescued. Escaping the LIB_ID names before comparison resolves the issue. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11563	2022-05-06 08:50:09 -04:00
jean-pierre charras	32077673e8	Symbol editor crash: Fix use of a null pointer. LIB_TEXT::Clone() did not copy a member set to nullptr. Fixes #11569 https://gitlab.com/kicad/code/kicad/issues/11569	2022-05-06 12:51:26 +02:00
Jeff Young	1751c8e1cf	Save selection before clearing it. Saving after doesn't do much good. Fixes https://gitlab.com/kicad/code/kicad/issues/11242	2022-05-06 00:06:00 +01:00
Jeff Young	9c5aa5c3c1	Font and color for FIELDS_GRID_TABLE. Fixes https://gitlab.com/kicad/code/kicad/issues/11459	2022-05-06 00:06:00 +01:00
Jeff Young	e80c5a4e4e	Add text colour to Edit Text & Graphics Properties. Fixes https://gitlab.com/kicad/code/kicad/issues/11459	2022-05-06 00:06:00 +01:00
Simon Richter	bd7447cff3	Fix variable name This is the top left position, not the top right.	2022-05-05 10:27:19 +00:00
Jeff Young	f14dc9e305	Don't plot private symbol text. Fixes https://gitlab.com/kicad/code/kicad/issues/11548	2022-05-03 19:41:20 +01:00
Jeff Young	babfb29c54	Formatting cleanup.	2022-05-03 13:39:14 +01:00
Jeff Young	67f352717e	Fix dodgy type-cast and init line-widths to "inherit". Fixes https://gitlab.com/kicad/code/kicad/issues/11535	2022-05-03 13:39:14 +01:00
jean-pierre charras	3f470359a2	Eeschema, backannotate: fix minor issues in displayed messages. Fixes #11530 https://gitlab.com/kicad/code/kicad/issues/11530	2022-05-03 09:20:46 +02:00
Seth Hillbrand	a56955443f	Fix botched commit (cherry picked from commit `ba276fe470`)	2022-05-02 16:29:07 -07:00
Seth Hillbrand	2079d15b3f	Catch IO_ERRORs that we throw FILEOUTPUT_FORMATTER likes to throw when it gets an issue. We need to catch this to avoid the app falling apart Fixes https://gitlab.com/kicad/code/kicad/issues/11516 (cherry picked from commit `4d47857738`)	2022-05-02 15:15:52 -07:00
Jeff Young	f6f316bd8c	Promote field selection to field-owner for Autoplace. Fixes https://gitlab.com/kicad/code/kicad/issues/11529	2022-05-02 20:11:21 +01:00
Jeff Young	d2610736ff	Fix bugs with printing bordered shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/11536	2022-05-02 19:45:55 +01:00
Jeff Young	585ea85f95	LIB_SHAPE default line style is SOLID, not DASHED. (Copy/paste error from SCH_SHAPE.) Fixes https://gitlab.com/kicad/code/kicad/issues/11527	2022-05-02 17:22:13 +01:00
Jeff Young	036d283433	Don't muck with linestyle default when setting it. Fixes https://gitlab.com/kicad/code/kicad/issues/11520	2022-05-02 17:22:13 +01:00
Jeff Young	804ab5609e	Add dash-dot-dot to Edit Text & Graphics Properties. Also fixes a bug where textboxes and shapes weren't correctly updated. Fixes https://gitlab.com/kicad/code/kicad/issues/11522	2022-05-02 17:22:13 +01:00
jean-pierre charras	50223c9337	Eeschema print: Do not print private graphics in symbols. Fixes #11532 https://gitlab.com/kicad/code/kicad/issues/11532	2022-05-02 16:29:08 +02:00
jean-pierre charras	ece15b6472	Fix a compil warning (shadowed var).	2022-05-02 15:25:55 +02:00
Jeff Young	dfa6b9ed15	Reset plotter dash-style after use. Fixes https://gitlab.com/kicad/code/kicad/issues/11527	2022-05-02 13:21:46 +01:00
jean-pierre charras	40c75c74fa	EEschema/Cvpcb: make assign footprints from CvPcb undoable. Fixes #11508 https://gitlab.com/kicad/code/kicad/issues/11508	2022-05-02 12:49:14 +02:00
Jeff Young	772bdc4bbf	Turn off auto-dialog for text objects when immediateActions == false.	2022-05-02 11:25:40 +01:00
Jeff Young	de0bb26c4c	Init global label's intersheet ref's visibility from schematic settings.	2022-05-02 09:42:38 +01:00
Miklós Márton	7ebdb4853c	Do not open label edit dialog when adding label to an already named wire	2022-05-02 08:42:15 +00:00
Jeff Young	6d44ca2145	Ellipsize long heirarchical paths. Fixes https://gitlab.com/kicad/code/kicad/issues/11499	2022-04-30 14:09:30 +01:00
Jeff Young	9fbf8e6f5d	Respect default layer color for textbox borders. Fixes https://gitlab.com/kicad/code/kicad/issues/11497	2022-04-29 14:10:48 +01:00
Jeff Young	dc1e063b00	Iron out some issues with linestyle handling in SCH printing and plotting. Fixes https://gitlab.com/kicad/code/kicad/issues/11498	2022-04-29 13:52:30 +01:00
Jeff Young	3589eb33f0	Handle text color when printing and plotting. Fixes https://gitlab.com/kicad/code/kicad/issues/11491	2022-04-29 10:51:00 +01:00
Jeff Young	2cccd5b090	Fix minor layout issue in dialog. Fixes https://gitlab.com/kicad/code/kicad/issues/11490	2022-04-27 17:14:33 +01:00
Jeff Young	8a97a46e6b	Release file before re-loading it for Revert. Fixes https://gitlab.com/kicad/code/kicad/issues/11481	2022-04-26 22:28:35 +01:00
Jeff Young	e0f2a5f07c	Update findnext to handle new instance data architecture. Fixes https://gitlab.com/kicad/code/kicad/issues/11424	2022-04-26 20:21:15 +01:00
Jeff Young	47e002a33d	Add font to status bar for text objects.	2022-04-26 18:52:53 +01:00
Jeff Young	e6f11c5c39	Reset outline font if bold or italic changed. Fixes https://gitlab.com/kicad/code/kicad/issues/11462	2022-04-26 12:52:29 +01:00
Jeff Young	85680886f8	Adjust outline font SCH_TEXT positioning so it better matches SCH_FIELD text.	2022-04-26 12:52:29 +01:00
Seth Hillbrand	25474b347c	Fix frustration with mirroring autoplaced fields When the user asks to mirror a symbol is is frequently to get the reference/value on the other side of the symbol for placement purposes. Autoplacing the fields here keeps the text where they were initially which can be frustating to work around. This commit treats the mirror command as a user request to change where the fields are	2022-04-25 12:50:45 -07:00
Seth Hillbrand	1a70465927	Use instance data to store values Previous use of instance was as an "override" of the default value. This has changed to be used as the primary storage location for all values. This means that we cannot clear the instance data when setting a new value for all instances, instead we have to change the instance data and the default value is superfluous Fixes https://gitlab.com/kicad/code/kicad/issues/11439	2022-04-25 12:47:48 -07:00
Jeff Young	f5d612eaed	Switch <insert> replacement on OSX to <f1>. Fixes https://gitlab.com/kicad/code/kicad/issues/11413	2022-04-25 10:01:33 +01:00
Jeff Young	90bfe2d94b	Remove Save Copy As from fp editor, and rename to Save a Copy elsewhere. It's still used by Eeschema and PCBNew when not in stand-alone mode. Fixes https://gitlab.com/kicad/code/kicad/issues/9185	2022-04-24 19:46:57 +01:00
Jeff Young	6738708a7f	Disable background color when printing in black & white. Fixes https://gitlab.com/kicad/code/kicad/issues/11180	2022-04-24 19:46:57 +01:00
Jeff Young	52eb210aa8	Initialize virtual page no. to something more reasonable. Fixes https://gitlab.com/kicad/code/kicad/issues/11295	2022-04-24 19:46:57 +01:00
jean-pierre charras	3bc34590c7	Eeschema: fix missing call to UpdateMessagePanel() due to commit `e09147db`. EE_INSPECTION_TOOL::UpdateMessagePanel was called by EVENTS::SelectedEvent But This event after commit calls E_INSPECTION_TOOL::CrossProbe(), and no longer UpdateMessagePanel. So CrossProbe() now calls UpdateMessagePanel. Fixes #11447 https://gitlab.com/kicad/code/kicad/issues/11447	2022-04-24 18:40:10 +02:00
Jeff Young	c6f83b6dec	ADDED Duplicate Footprint, Rename Symbol and Rename Footprint.	2022-04-22 22:06:51 +01:00
Mike Williams	b42365190e	Schematic/PCB: deleting fields sets them to invisible	2022-04-21 16:20:23 +00:00
Jeff Young	eb1a238a53	Remove extra event handler. Fixes https://gitlab.com/kicad/code/kicad/issues/11418	2022-04-20 16:19:42 +01:00
Jeff Young	fc2eb2d7c9	Fix missing line keeping tabs from switching. Fixes https://gitlab.com/kicad/code/kicad/issues/11417	2022-04-20 14:51:08 +01:00
Seth Hillbrand	aac6f576c2	Fix broken comparison in pin_numbers Pin names like "+V" were incorrectly parsed as doubles leading to broken comparisons. These caused heap overflows when sorting pin tables This corrects the comparison so that numeric sorts are only performed when there is an actual number in the symbol segment. Also adds unit tests for common error cases	2022-04-19 14:46:05 -07:00
Jeff Young	4ab2c93070	Update Selection Filter title bar with language changes. Fixes https://gitlab.com/kicad/code/kicad/issues/11421	2022-04-19 21:12:13 +01:00
Jeff Young	ffc28f23e5	Repair GetFullRef() and use it when running Symbol Fields Table filtering. (Previously GetFullRef() failed to add the number between the prefix letter and the unit designator.) Fixes https://gitlab.com/kicad/code/kicad/issues/11419	2022-04-19 19:55:30 +01:00
Jeff Young	08f15fe587	ADDED New Library functionality to Footprint/Symbol Save As. Fixes https://gitlab.com/kicad/code/kicad/issues/2343	2022-04-19 19:55:30 +01:00
Jeff Young	84f620a96e	Minor dialog beautification.	2022-04-19 19:55:30 +01:00
Jeff Young	c3bed8f6ee	Resolve textvars before opening file browser. Fixes https://gitlab.com/kicad/code/kicad/issues/6436	2022-04-18 22:45:02 +01:00
Jeff Young	cc18c31cb5	Fix some layout issues in the Project Template Selector. Fixes https://gitlab.com/kicad/code/kicad/issues/5222	2022-04-18 22:45:02 +01:00
Mike Williams	653baf270c	Schematic: drag created / changed segments need junction checks Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10844	2022-04-18 17:24:02 +00:00
Simon Richter	801c5deb87	Fix minimum size calculation for new hierarchical sheets These constants are given in mil, but are used in a context of internal units.	2022-04-18 15:01:59 +00:00
Simon Richter	1e505d4c22	Remove a few call sites of SCH_SHEET::SetSize This function is dangerous and should be used only by parsers, and not even those, really. For new objects, the size can be passed to the constructor.	2022-04-18 16:23:03 +02:00
Jeff Young	55a8fb39c4	ADDED filtering for Symbol Fields Table dialog. Fixes https://gitlab.com/kicad/code/kicad/issues/11224	2022-04-17 20:02:58 +01:00
Jeff Young	71c2cb3180	ADDED revert for pcbnew and eeschema. Fixes https://gitlab.com/kicad/code/kicad/issues/6802	2022-04-17 20:02:58 +01:00
jean-pierre charras	38c54ffa8f	Eeschema, Symbol Library Browser: fix crash when left clicking on the canvas.	2022-04-17 09:54:19 +02:00
Jeff Young	e09147db30	Cross-probing for ERC dialog. Fixes https://gitlab.com/kicad/code/kicad/issues/11411	2022-04-17 00:33:56 +01:00
Jeff Young	7f4f5f2882	Save and re-load query string in Choose Symbol dialog. While this has been requested on its own, it's primarily done here because wxWidgets decided to send a SEARCH_CANCEL from a wxSearchCtrl when hitting <ENTER> if the search control holes the empty string. This causes us to not do a symbol instert in the Chooser dialog. Fixes https://gitlab.com/kicad/code/kicad/issues/10169 Fixes https://gitlab.com/kicad/code/kicad/issues/7699	2022-04-17 00:33:56 +01:00
Seth Hillbrand	250a246761	Clear flags after we're done with them The CANDIDATE flag is a temporary element that should not be maintained outside of the routine in which is it temporarily set Fixes https://gitlab.com/kicad/code/kicad/issues/11361	2022-04-16 15:45:17 -07:00
jean-pierre charras	65f7d9f97a	EEschema: move symbol checker code in symbol_checker.cpp. - Add some tests for Power symbols. - Fix incorrect print format in some messages.	2022-04-16 18:56:06 +02:00
Seth Hillbrand	ce9bd780d1	Fix crash due to cleared view data When changing fields, we need to update the view before allowing canvas updates (cherry picked from commit `851f893e8e`)	2022-04-15 15:14:29 -07:00
Jeff Young	4ee6cfe5b6	Disable all use of the default instance reference prefix for annotation. Fixes https://gitlab.com/kicad/code/kicad/issues/11385	2022-04-14 17:55:35 +01:00
Jeff Young	6ef6e37edb	Disable using default instance data when writing to clipboard. Fixes https://gitlab.com/kicad/code/kicad/issues/11379	2022-04-14 17:09:27 +01:00
Jeff Young	160240166c	Cleanup.	2022-04-14 17:09:27 +01:00
Jeff Young	034b57d9c0	When reannotating keep existing prefix in most cases. (Execption is reannotating entire schematic, in which case we reset all of them.) Fixes https://gitlab.com/kicad/code/kicad/issues/11379	2022-04-13 23:38:45 +01:00
Jeff Young	184b67098f	Meet user expectations on life-cycle of symbol fields. In other words, support empty fields. Also adds deleting fields to Symbol Fields Table. Fixes https://gitlab.com/kicad/code/kicad/issues/8999	2022-04-12 22:11:31 +01:00
Roberto Fernandez Bautista	85f6ff48e7	CADSTAR Sch: Clear symbol of all elements before overwriting with new one Fixes https://gitlab.com/kicad/code/kicad/-/issues/11378	2022-04-12 21:34:23 +01:00
Jeff Young	306dfef7e5	Fix typo.	2022-04-12 19:18:15 +01:00
Jeff Young	576f3dc2fd	Keep pins aligned to grid when possible. This uses the first pin as the anchor point in a mulitple-item selection. Fixes https://gitlab.com/kicad/code/kicad/issues/11151	2022-04-12 18:14:21 +01:00
Marek Roszko	f88e0481c8	Change the behavior of ACTION_MENU::Add to require clones if required outside the function This reverts commit `2a5769607f`.	2022-04-11 19:03:01 -04:00
Jeff Young	16acba34d3	Don't save schematic symbol back to lib manager. Also, since it doesn't get saved, changing symbols will lose any edits. Make sure to ask the user first. Fixes https://gitlab.com/kicad/code/kicad/issues/10767	2022-04-11 22:43:39 +01:00
Seth Hillbrand	2a5769607f	Revert "Change the behavior of ACTION_MENU::Add to require clones if required outside the function" This reverts commit `403992a6f4`.	2022-04-11 11:39:03 -07:00
Jeff Young	546b3bfbc0	Select wire ends in select all. Fixes https://gitlab.com/kicad/code/kicad/issues/10958	2022-04-11 19:36:54 +01:00
jean-pierre charras	f0f10a43a2	Ensure "Clear Recent Files" menuitem titles are updated after language change. (missing fixes in commit `ac8e2d076`)	2022-04-11 18:11:17 +02:00
Jeff Young	74a578047c	Make sure to add any now-necessary junctions after a rotate. Fixes https://gitlab.com/kicad/code/kicad/issues/11242	2022-04-11 12:02:20 +01:00
Jeff Young	8358685920	Dual-purpose IsMovableFromAnchorPoint to keep from moving symbols off-grid. Fixes https://gitlab.com/kicad/code/kicad/issues/11360	2022-04-11 12:02:20 +01:00
jean-pierre charras	ac8e2d0768	Ensure "Open Recent" and "Clear files" menu titles are updated after language change.	2022-04-11 11:09:05 +02:00
Marek Roszko	403992a6f4	Change the behavior of ACTION_MENU::Add to require clones if required outside the function Fix https://gitlab.com/kicad/code/kicad/-/issues/10994	2022-04-10 22:38:13 -04:00
Marek Roszko	5bb2cdf73d	Revert "Stop leaking submenu items" This reverts commit `34c70a51ea`.	2022-04-10 22:33:43 -04:00
Marek Roszko	34c70a51ea	Stop leaking submenu items Our menu bar code is interestingly complex. But we were throwing away newly made menu items to the void in the cases of constructed on the fly submenus	2022-04-10 22:04:48 -04:00
Jeff Young	117bd4fc22	Adjust LIB_SYMBOL compare for use with ERC. Fixes https://gitlab.com/kicad/code/kicad/issues/10783	2022-04-09 20:12:29 +01:00
Roberto Fernandez Bautista	0015574a60	${SHEETNAME} represents the sheet name + introduce ${SHEETPATH} CHANGED: The text variable ${SHEETNAME} now always represents the name of the sheet when used anywhere in the schematic editor, including the title block ADDED: A new text variable ${SHEETPATH} which is replaced with the path to the current sheet - e.g. "/Sheet 1/Sheet 2". To ensure backward compatibility, the default drawing sheet now uses ${SHEETPATH}. Custom drawing sheets will need to be manually edited.	2022-04-09 15:45:58 +01:00
Wayne Stambaugh	239f0214ac	Eeschema: add support for default schematic symbol instance data. Prior to fixing the schematic file change churn do to instance data changing to the last selected sheet instance, the symbol instance data was set rather than empty. This change allows for users to set the default instance data which is used for every new instance of the schematic. ADDED: Default schematic symbol instance data (unit and reference, value, and footprint fields) can be set to be used as the default settings for all new instances of the schematic. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11113	2022-04-09 07:49:36 -04:00
Jeff Young	007906cd16	Fix a degeneracy bug in arc collisions. This also fixes a failure to use the correct effective width for shapes (which might, for instance, inherit their widths from schematic defaults, netclasses, etc.). Fixes https://gitlab.com/kicad/code/kicad/issues/11358	2022-04-08 16:15:58 +01:00
Seth Hillbrand	702623ef87	Don't flag pin missing driver when there is an NC The NC flag indicates user intention to override the lack of connection to input pins (cherry picked from commit `e02229a234`)	2022-04-07 09:35:23 -07:00
Jeff Young	c17b90c8dc	Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339	2022-04-07 11:51:58 +01:00
Seth Hillbrand	4b0b4c0ddc	Show non-driven error on single-pin nets Better to have both the single-pin error message and the non-driven error message when an input pin is not connected than miss error messages when the pin is connected to a blank net Fixes https://gitlab.com/kicad/code/kicad/issues/10430 (cherry picked from commit `e740db61f5`)	2022-04-06 16:54:04 -07:00
Jeff Young	356d565d48	Normalize rectangular shapes before feeding to point editor. Fixes https://gitlab.com/kicad/code/kicad/issues/11339	2022-04-06 18:18:29 +01:00
Jeff Young	67d54ecb4c	A bit of dialog layout cleanup.	2022-04-06 16:58:26 +01:00
Jeff Young	06df90636b	Rationalize negative line-width handling. Make "don't stroke" an explicit property in the GUI. Silently enforce line width to >= 0 when stroking. Make layouts between dialogs more consistent. Interpret unspecified fill colour as layer colour. Fixes https://gitlab.com/kicad/code/kicad/issues/11279	2022-04-05 23:59:25 +01:00
Sylwester Kocjan	a9c61d21ca	eeschema: fix crash when closing simulation frame Destructor of SIM_PLOT_FRAME calls sim->Attach( nullptr ) in order to destroy circuit model (former netlist exporter). If this is skipped, eeschema crashes when program is closed. nullptr is a valid parameter for Attach()	2022-04-05 19:28:05 +00:00
Jeff Young	1594df3498	Fix egregious typo.	2022-04-05 20:10:25 +01:00
Jeff Young	0bd3341f0f	Allow textboxes to have no text. (They still have a defined box.) Fixes https://gitlab.com/kicad/code/kicad/issues/11286	2022-04-05 16:29:21 +01:00
Jeff Young	ed361925ba	Repair code that was supposed to be after LoadSymbol(). (Even the comment said so.) Fixes https://gitlab.com/kicad/code/kicad/issues/11199	2022-04-05 14:38:05 +01:00
Jeff Young	68ca385e07	On-the-fly translations for pin electrical types. Also add on-the-fly translation for editor title bars. Fixes https://gitlab.com/kicad/code/kicad/issues/11324	2022-04-05 13:57:28 +01:00
Jeff Young	3196857449	Fix incorrectly initialized variable. The SCH_ITEM default is LAYER_WIRE, which we don't want for a symbol. Fixes https://gitlab.com/kicad/code/kicad/issues/11307	2022-04-05 13:57:28 +01:00
markus-bonk	dc8556726b	Fix building QA tests with options -DKICAD_USE_3DCONNEXION=ON	2022-04-05 06:47:49 +00:00
Jeff Young	3f9cfc0ac1	Fix incorrect m_SyncPinEdit setting. Fixes https://gitlab.com/kicad/code/kicad/issues/11331	2022-04-04 16:56:53 +01:00
Sylwester Kocjan	05fbe47a1b	eeschema: two fixes for simulation tuners - fix irrelevant warning message box when tuners moved too quickly and simulation was slow - fix for rerun simulation when tuning and result tab was changed	2022-04-02 15:05:54 +00:00
Seth Hillbrand	0625e20fc0	Cleanup spacemouse plugin Sets std:: convention and unifies the defined/non-defined interface	2022-04-01 15:14:41 -07:00
Jeff Young	a12f77b8f6	Don't render fills in black & white mode. Fixes https://gitlab.com/kicad/code/kicad/issues/11303	2022-04-01 21:24:56 +01:00
Seth Hillbrand	5d5a2f9270	Allow common greek letters in passive regex Adds common letters (µ and Ω) as prefix and unit Fixes https://gitlab.com/kicad/code/kicad/issues/11289 (cherry picked from commit `15fe2f2fd0`)	2022-04-01 12:51:43 -07:00
Sylwester Kocjan	4719fdc9bf	eeschema: rename m_exporter to m_circuitModel	2022-04-01 19:28:31 +00:00
Sylwester Kocjan	f5dedd77c6	eeschema,sim: add SIMULATOR and SIM_MODEL interface SIMULATOR has now an Attach() method, which should be called with proper SIMULATION_MODEL that should be simulated, before calling Run() Concrete class of SIMULATION_MODEL for ngspice is NGSPICE_CIRCUIT_MODEL, renamed from NETLIST_EXPORTER_PSPICE_SIM. DIALOG_SIM_SETTINGS relies on above mentioned object, so it was added as an argument of the constructor.	2022-04-01 19:28:31 +00:00
jean-pierre charras	be6379a8f6	Fix minor Coverity and compil warnings.	2022-04-01 20:43:21 +02:00
Jeff Young	6f818f4c2e	Editing support for sheet-pin fonts, text styles and text colors. Fixes https://gitlab.com/kicad/code/kicad/issues/11300	2022-04-01 19:26:27 +01:00
jean-pierre charras	5d9668938b	SYMBOL_EDITOR_CONTROL::DuplicateSymbol(): fix incorrect validation test. DuplicateSymbol() is called both to duplicate and paste. Only duplicate needs a test to know if a symbol is selected. Fixes #11053 https://gitlab.com/kicad/code/kicad/issues/11053	2022-04-01 10:42:20 +02:00
Seth Hillbrand	49c48e2fe0	Consistently handle env/prj variables User-defined variables cannot be used for internally-reserved variables Fixes https://gitlab.com/kicad/code/kicad/issues/11232 (cherry picked from commit `c23679d9bd`)	2022-03-31 17:05:53 -07:00
Jeff Young	6b99a937d8	Look for sheet pins inside sheets. Fixes https://gitlab.com/kicad/code/kicad/issues/11297	2022-03-31 22:10:45 +01:00
markus-bonk	1a9ef4bd0f	Add support for using a SpaceMouse to pan & zoom in the schematic editor.	2022-03-31 19:03:41 +00:00
Jeff Young	e8a543f1ea	Colors for text in PL_Editor and Eeschema. Fixes https://gitlab.com/kicad/code/kicad/issues/1952	2022-03-31 19:43:56 +01:00
Jeff Young	748cc1a59a	Pay better attention to aPlotter->GetColorMode(). Fixes https://gitlab.com/kicad/code/kicad/issues/11287	2022-03-30 20:38:24 +01:00
Jeff Young	7c21a0bdd4	Dirty text render caches in point editor. Fixes https://gitlab.com/kicad/code/kicad/issues/11284	2022-03-30 16:32:23 +01:00
Jeff Young	5c7b022f40	Be more pedantic about setting GAL line width. Fixes https://gitlab.com/kicad/code/kicad/issues/11280	2022-03-30 16:32:23 +01:00
Jeff Young	91ea0903d0	Add infobars for individual-item-color-overrides.	2022-03-29 20:41:03 +01:00
Jeff Young	8dc680adbb	Implement align-to-grid for sheets. Fixes https://gitlab.com/kicad/code/kicad/issues/11201	2022-03-29 19:31:02 +01:00
Seth Hillbrand	719874fe9c	Thread the connectivity vector updates Now that we are dealing with individual connection elements that do not update their connected elements as well, we can thread the update, just being careful to guard any remaining updates (bus_enty/busLine) that need reciprocal updating Fixes https://gitlab.com/kicad/code/kicad/issues/10974 (cherry picked from commit `6a53e318e5`)	2022-03-28 15:36:55 -07:00
Seth Hillbrand	6a33bcdc78	Avoid generating SCH_CONNECTION if not needed If the SCH_ITEM has already been processed, the extra time needed to iterated over the memberset and get the SCH_CONNECTION when we won't use it is not neccesary. Fixes https://gitlab.com/kicad/code/kicad/issues/10974 (cherry picked from commit `776a28a10e`)	2022-03-28 15:36:55 -07:00
Seth Hillbrand	41f7354b7a	Handle connection vector inline Normally, you will gain by resursing a nested loop only over the pairs that are not already handled. In this case, however, you lose time because you step outside of the cache by adding the reciprocal test at each step. Instead, we process one element at a time, keeping it cached and loop over all other elements to add to the connection. This saves us about 75% of the time for larger loops (e.g. stacked power pins on a large BGA) Fixes https://gitlab.com/kicad/code/kicad/issues/10974 (cherry picked from commit `3a98eacdb9`)	2022-03-28 15:36:55 -07:00
Jeff Young	09ba7468ae	A better is-modified test. Fixes https://gitlab.com/kicad/code/kicad/issues/10791	2022-03-28 21:54:24 +01:00
Jeff Young	4ee6f9e138	Make sure setting the cursor gets put into the right tool context. Fixes https://gitlab.com/kicad/code/kicad/issues/10141	2022-03-28 21:54:24 +01:00
Seth Hillbrand	8706bea3c6	Fix renamed flag Snuck in between MR reviews	2022-03-28 13:50:44 -07:00
Mike Williams	2a726a882f	Schematic: new feature, force 45 degree lines * New modes to force 45 deg angle at beginning or end of line * Backspace will undo most recent segment added * / will toggle posture of 90 and 45 degree lines * Added alg::signbit for convenience Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10869 Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9175	2022-03-28 16:07:23 -04:00
Mike Williams	e51ab86225	Schematic Drag: fixes and improvements Fixes: * Various special cases around junctions on pins and dragging. * Some rotations of endpoints resulting in a 45 degree rotate. * Some cases where it was possible to get a line with neither endpoint selected, and also substractive unselecting only one of two selected endpoints unselecting both. * Use line midpoint for sorting. Start and endpoints aren't consistent in the order they appear on the X or Y axis. So, we need to use the midpoint for our position for consistent sorting when dragging groups of parallel lines where some have the start and end reversed. Other: * Rename TEMP_SELECTED TO SELECTED_BY_DRAG. This is the actual meaning of the flag, and should reduce confusion as to when it should be used. * Move usage of TEMP_SELECTED as an algorithmic mark to CANDIDATE instead. * Fix mistaken clearing of START_POINT and ENDPOINT. * Move endpoint setting and clearing out of narrowSelection, and into selectPoint and selectMultiple. * Don't show dangling end warnings on new lines	2022-03-28 16:02:48 -04:00
Jeff Young	47f4503564	SCH textboxes start/end -> at/size. The at token can handle an angle; start/end does not. Fixes https://gitlab.com/kicad/code/kicad/issues/11252	2022-03-28 11:16:39 +01:00
Jeff Young	343b2681d4	Midpoints for eeschema rectangles and text boxes. Fixes https://gitlab.com/kicad/code/kicad/issues/10362	2022-03-28 11:16:39 +01:00
Jeff Young	265ff90e19	Use selection highlight color for sel shadows even when brightened. This allows Find & Change to show both matches and current match. Fixes https://gitlab.com/kicad/code/kicad/issues/11101	2022-03-28 11:16:39 +01:00
jean-pierre charras	cfe0003ca4	Eeschema: fix misplaced nullptr test that prevent saving SCH_TEXT items. Fixes #11250 https://gitlab.com/kicad/code/kicad/issues/11250	2022-03-27 18:48:55 +02:00
jean-pierre charras	38bd612c01	sch_sexpr_parser.cpp: allows reading a polyline descr with more than 2 points In symbols, a polyline descr is already a true polyline / polygon descr. In schematic, a polyline descr was restricted to only 2 points (a line). A true polyline / polygon descr is now allowed in schematic that support already polygons. For compatibility reason, a 2 points polygon (SCH_SHAPE) is converted to a SCH_LINE.	2022-03-27 10:31:21 +02:00
Jeff Young	48dd810cd1	ADDED grouping of selected pins in Pin Table. Fixes https://gitlab.com/kicad/code/kicad/issues/4956	2022-03-26 21:07:10 +00:00
Jeff Young	a54457386c	Enable immediate mode for pin tool. Fixes https://gitlab.com/kicad/code/kicad/issues/10156	2022-03-26 21:07:10 +00:00
Sylwester Kocjan	53ccd8bd67	eeschema,sim: refactor NETLIST_EXPORTER_PSPICE_SIM creation	2022-03-26 15:50:15 +00:00
jean-pierre charras	9a342458fa	Fix a few Coverity and compil warnings.	2022-03-26 16:21:23 +01:00
Jeff Young	0652c7b429	More visible Synchronized Pins Mode informatics. Fixes https://gitlab.com/kicad/code/kicad/issues/10340	2022-03-26 15:16:08 +00:00
Jeff Young	1c158a4ea4	Use a standard HTML reporter for Symbol Checker.	2022-03-26 14:22:31 +00:00
Jeff Young	d5533e7999	ADDED unit-filtering for pin table. Fixes https://gitlab.com/kicad/code/kicad/issues/9382	2022-03-26 11:53:48 +00:00
Jeff Young	e6c2b12ddf	ADDED allow pin conversion to be edited in Pin Table. Added a De Morgan column.	2022-03-26 11:53:48 +00:00
Jeff Young	2681ad6cfc	Don't rely on HasConversion() for Symbol Properties in Symbol Editor. Fixes https://gitlab.com/kicad/code/kicad/issues/11200	2022-03-26 11:53:48 +00:00
Wayne Stambaugh	7da7864f5e	Fix some Coverity issues.	2022-03-25 15:51:05 -04:00
Seth Hillbrand	c686105afc	Correctly order swap test MapAngles() will modify parameters and C++ does not guarantee LTR evaluation, so we need to separate the calls into the proper order before comparing the returns Fixes https://gitlab.com/kicad/code/kicad/issues/11135	2022-03-24 09:23:50 -07:00
Jeff Young	92a229eec7	ADDED separate user-defined color for page limits. Fixes https://gitlab.com/kicad/code/kicad/issues/5271	2022-03-24 14:11:41 +00:00
Wayne Stambaugh	b87fc45e33	Fix broken symbol field table editor dialog. Do not use the symbol field string to populate the value and footprint grid cells. The field strings may be empty because the symbol has not been instantiated yet by entering a sheet. This fix makes an incorrect assumption that the first instance value and footprint data in the symbol is the same for all instances. Note: this fix is incomplete because the value and footprint fields are can now be different between sheet instances. The entire field table editor design will need to be rethought because the current grouping doesn't allow different value and footprint instance changes. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11194	2022-03-23 11:46:49 -04:00
Jeff Young	535ecb9b7b	Don't leave dangling pointers to old document when importing. This goes for both selection pointers and undo/redo pointers. Fixes https://gitlab.com/kicad/code/kicad/issues/10145	2022-03-22 18:08:05 +00:00
Jeff Young	8eb10c41d8	Name any unnamed fields so they don't clobber each other. Fixes https://gitlab.com/kicad/code/kicad/issues/10039	2022-03-22 18:08:05 +00:00
jean-pierre charras	21144481d2	PLOTTER: do not clamp coordinates to an arbitrary value. Previously, coordinates were clamped to +- 60 inches. It makes no sense to clamp them at plotter level: max cooed depends on the editor (schematic/board...) Rename MAX_PAGE_SIZE_MILS to MAX_PAGE_SIZE_EESCHEMA_MILS and use it only for Eeschema. Fixes #11196 https://gitlab.com/kicad/code/kicad/issues/11196	2022-03-22 10:32:36 +01:00
Wayne Stambaugh	e336a0e403	Improve sheet schematic import messages and simplify code. There was also a logic bug when the selected schematic was in a different path than the current project and was already part of the current project. The symbol library table reconciliation code was still run which was wrong. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11075	2022-03-21 17:09:49 -04:00
Sylwester Kocjan	2fed8aa4b8	eeschema: Add sync functions to SPICE_SIMULATOR SPICE simulator can be called also during IBIS model determination, and in the future in ERC. Therefore a necessity arises to implement exclusive access.	2022-03-21 19:10:08 +00:00
Jeff Young	e77a71bf7a	Fix typo found in code review.	2022-03-21 10:32:36 +00:00
Jeff Young	4f62960334	Update message panel from PCB point editor and SCH drawing tools. Fixes https://gitlab.com/kicad/code/kicad/issues/11186	2022-03-21 10:32:36 +00:00
Jeff Young	58c146a7c0	ADDED ki_description and ki_keywords to footprint properties. Also a bunch of wxT(). Fixes https://gitlab.com/kicad/code/kicad/issues/7783	2022-03-19 23:16:56 +00:00
Jeff Young	cc165129fd	Special case undo for items with instance data. Fixes https://gitlab.com/kicad/code/kicad/issues/11102	2022-03-19 19:37:01 +00:00
Jeff Young	63b5ad7df1	Fix some issues with global-label fields' bounding boxes.	2022-03-19 19:37:01 +00:00
jean-pierre charras	2bba277c5e	Unit binder: fix hang and DIALOG_WIRE_BUS_PROPERTIES: fix uninitialized variable. The hang can be Windows specific.	2022-03-19 10:22:41 +01:00
Jeff Young	7b82c2ba85	Preload eeschema find with selection when appropriate. Fixes https://gitlab.com/kicad/code/kicad/issues/11148	2022-03-18 23:31:30 +00:00
Jeff Young	41c0009c51	Off-grid ERC warnings. Fixes https://gitlab.com/kicad/code/kicad/issues/10379	2022-03-17 20:23:56 +00:00
jean-pierre charras	77c52ad5df	Fix a compil warning (shadowed var).	2022-03-17 20:13:17 +01:00
Jeff Young	400cff994d	Update value & footprint from clipboard whether keeping annotation or not. Fixes https://gitlab.com/kicad/code/kicad/issues/11116	2022-03-17 18:19:13 +00:00
Seth Hillbrand	deb7a0beff	Avoid marking symbols that will not be processed We want to shorting the processing time by marking symbols that have already been processed. But we must avoid marking symbols that will not be processed due to their other flags Fixes https://gitlab.com/kicad/code/kicad/issues/11164 (cherry picked from commit `2208e0db16`)	2022-03-17 10:10:56 -07:00
Jeff Young	05bca282f7	Re-entrancy blocker for line/wire/bus tool. Also clear infobar messages after a cancelInteractive. Fixes https://gitlab.com/kicad/code/kicad/issues/11155	2022-03-17 15:27:33 +00:00
Jeff Young	e68e2e973e	Separate Line Properties dialog from Bus/Wire, and handle Junctions in Bus/Wire. Fixes https://gitlab.com/kicad/code/kicad/issues/9979	2022-03-16 14:56:32 +00:00
Jeff Young	1434988bf8	Formatting.	2022-03-16 14:56:32 +00:00
Wayne Stambaugh	c16090cc42	Improve sheet schematic import from different project message. https://gitlab.com/kicad/code/kicad/-/issues/11075	2022-03-15 18:16:56 -04:00
jean-pierre charras	1f5ec30566	Fix and issue about 180 deg arcs in symbols from "old" libraries. Can be seen with lib version 20201005, not with latest version. The fix is similar to commit `8a17fb8d`, but for arcs defined by start, end, angles (modify 180 deg arcs) Fixes #11130 https://gitlab.com/kicad/code/kicad/issues/11130	2022-03-15 11:31:58 +01:00
jean-pierre charras	2cb719f0cf	Fix crash in SCH_LABEL_BASE::IsType() when the item is not living in a schematic. It happens for instance when copying the item from the clipboard. Fixes #11128 https://gitlab.com/kicad/code/kicad/issues/11128	2022-03-14 09:23:16 +01:00
Jeff Young	38cde901b0	Don't use last-resolved caches for graphic lines. Fixes https://gitlab.com/kicad/code/kicad/issues/11127	2022-03-14 00:31:56 +00:00
Jeff Young	ec44dfa60f	Unescape value fields when pasting from legacy schematics. Fixes https://gitlab.com/kicad/code/kicad/issues/11124	2022-03-13 22:17:44 +00:00
Seth Hillbrand	d653484d72	Move connected_items from hash table to tree This gains about 10% speed in heavily connected sheets Fixes https://gitlab.com/kicad/code/kicad/issues/10974 (cherry picked from commit `187aa1c171`)	2022-03-11 16:58:38 -08:00
Seth Hillbrand	5b5c7d41b4	Break up buildConnectionGraph for debugging Needed to find bottlenecks in fns, so break out individual sections of the massive function for easier understanding. buildItemSubgraphs (one section of the previous function) would build millions of connections that were never used as stacked pins created X! connections. Also tested using sets instead of lists and keeping unique lists to avoid flagging but none of these were as performant as using flags to remember which items had already been processed. Fixes https://gitlab.com/kicad/code/kicad/issues/10974 (cherry picked from commit `17b1b68ac7`)	2022-03-11 16:58:38 -08:00
Jeff Young	7ab4d67e94	Make sure line style comboboxes get a default entry. Fixes https://gitlab.com/kicad/code/kicad/issues/11083	2022-03-11 23:19:16 +00:00
Wayne Stambaugh	dd1dbb81f6	Improve shared schematic file churn heuristics. The previous solution cleared all of the fields and force the unit setting to unit one which would have less than desirable effects when reusing a schematic in another project. This solution forces all of the instance settings to the first sheet instance of the current project to prevent file change churn when changing shared sheets in the current project. This will not prevent shared schematic file changes when the first sheet instance data differs between projects.	2022-03-11 12:37:30 -05:00
Wayne Stambaugh	bf5d585e24	Reduce shared schematic file change churn.	2022-03-11 00:32:34 +00:00
Jeff Young	a9eb7a0e28	Make sure LIB_ID escape context allows for formatting constructs. Also make sure that value field is updated from name changes when the symbol is a power symbol (even if it's from the schematic instead of the library). Fixes https://gitlab.com/kicad/code/kicad/issues/11093	2022-03-10 13:46:42 +00:00
Seth Hillbrand	16a266301a	Remove double-call of settings from Netlister Double-calls are no longer needed when using settings. They can interfere depending on how the system executes the commands. Removing keeps the last used plugin as the default, rather than the last selected Fixes https://gitlab.com/kicad/code/kicad/issues/11094 (cherry picked from commit `e8ef863861`)	2022-03-09 17:12:41 -08:00
Seth Hillbrand	fd59179cd2	Avoid implementation dependent on events Adding a page in the ctor can generate events that change the default page. Instead, we set the default after all pages have been added, avoiding the reset Fixes https://gitlab.com/kicad/code/kicad/issues/10910 (cherry picked from commit `5314ba6440`)	2022-03-09 15:42:29 -08:00
Seth Hillbrand	6934bc124c	Move temp save files to temporary directory Avoid excess writes to the project directory to dodge issues with remote file systems not fully writing data. wxRename works across disk boundaries (in theory) and falls back to wxCopy/wxRemove when it fails Fixes https://gitlab.com/kicad/code/kicad/issues/10747	2022-03-07 20:13:28 -08:00
Seth Hillbrand	c9fb95b888	Fix the order of evaluation in the arc printing MapAngles will adjust by small amounts the angles t1 and t2. This adjustment will determine the CW/CCW drawing. Therefore, the MapAngles needs to be called explicitly before the Normalize180() call. Left-to-Right evaluation is not a given for MSVC Fixes https://gitlab.com/kicad/code/kicad/issues/11050	2022-03-07 16:43:13 -08:00
Jeff Young	bf0f2aa4a8	Adjust bitmap text spacing a bit so it's closer to the stroke font. This helps the text better match the highlighting when it gets small enough that we switch to the bitmap font for performance.	2022-03-07 20:30:50 +00:00
Jeff Young	1f745b000d	Special-case synthetic click after tool selection. Fixes https://gitlab.com/kicad/code/kicad/issues/11057	2022-03-07 20:30:50 +00:00
Jeff Young	39fa4e2065	Include textbox in movable objects. Fixes https://gitlab.com/kicad/code/kicad/issues/11058	2022-03-07 10:33:59 +00:00
Jeff Young	d3716b9956	Reentrancy block for symbol editor symbol properties dialog. Fixes https://gitlab.com/kicad/code/kicad/issues/11060	2022-03-07 10:26:18 +00:00
Jeff Young	4923f02651	Reset GAL pen width between drawing text and border. Fixes https://gitlab.com/kicad/code/kicad/issues/11059	2022-03-06 20:32:28 +00:00
Jeff Young	3969045009	Don't bitmap multi-line SCH_TEXT. The linespacing isn't even close and multi-line text is also likely to have longer lines which makes the X offset get way off too.	2022-03-06 20:17:56 +00:00
Jeff Young	6b3ed89248	Handle justified LIB_TEXT. Fixes https://gitlab.com/kicad/code/kicad/issues/11052	2022-03-06 19:54:06 +00:00
Jeff Young	14304215b3	Copy m_private flag in LIB_TEXT's clone(). Fixes https://gitlab.com/kicad/code/kicad/issues/11051	2022-03-06 17:00:13 +00:00
Jeff Young	c919817c18	Don't reserve space for private items when autoplacing.	2022-03-06 16:12:49 +00:00
jean-pierre charras	dbfdd3fb56	Fix some Coverity warnings.	2022-03-06 09:48:33 +01:00
Seth Hillbrand	8fd87e1f04	Change connectivity item group from set to vector Reserve space for new items to speed construction of connectivity graph Fixes https://gitlab.com/kicad/code/kicad/issues/10974 (cherry picked from commit `7aebc4b11f`)	2022-03-05 13:04:11 -05:00
Seth Hillbrand	cd7141fd10	Cache read arc data for stability Arcs can be altered by the process of changing from on-disk representation to in-memory representation. Saving back to disk without modifying the arc should not modify the calculated values. This stores a copy of the on-disk representation that is only used to save back to disk in the event that the arc is not modified during editing. Fixes https://gitlab.com/kicad/code/kicad/issues/10442	2022-03-04 15:20:31 -08:00
Seth Hillbrand	7ecc70a79d	Duplicate from selected or current When double-clicking to open a symbol, it is no longer selected in the tree. We need to use the `GetTargetLibId()` to pick the correct symbol (first selected, then current) when using the duplicate command Fixes https://gitlab.com/kicad/code/kicad/issues/11034 (cherry picked from commit `802d20c409`)	2022-03-03 16:04:22 -08:00
Jeff Young	c025b4c73d	Save all stroke parameters of sch & lib shapes. We were failing to save the line style, which caused ERC errors when DEFAULT != SOLID.	2022-03-03 14:37:04 +00:00
Jeff Young	76535d8572	Make LIB_ITEM::COMPARE_FLAGS really a flags field, and add ERC. Before they were 1/2 treated as flags and 1/2 treated as a mode enum. The ERC flag relaxes constraints on data that is settable in the schematic editor. Fixes https://gitlab.com/kicad/code/kicad/issues/11018	2022-03-03 13:27:18 +00:00
jean-pierre charras	a0d68b8426	SCH_DIRECTIVE_LABEL: add missing virtual SwapData. Fixes #11027 https://gitlab.com/kicad/code/kicad/issues/11027	2022-03-03 10:27:17 +01:00
Jeff Young	c5d85e0b7e	Don't try to open cell editor on first focus. It hasn't worked since we rejiggered the default grid selection mode anyway, and for some reason it eats <esc> key events after the dialog has been resized. Fixes https://gitlab.com/kicad/code/kicad/issues/11015	2022-03-03 02:06:48 +00:00
Jeff Young	fd4b4533b1	Remove some code that isn't used anymore.	2022-03-03 02:06:48 +00:00
Seth Hillbrand	548936bb22	Fix broken unit select context menu The fix for https://gitlab.com/kicad/code/kicad/issues/10529 kicked the subsequent IDs for unit selection off the maximum ID value for popup menus. This increases the maximum popup number (integers are free) (cherry picked from commit `79b6991d7b`)	2022-03-02 16:33:28 -08:00
Seth Hillbrand	8c36ba3653	Explicitly give unit values Removes the ability to hide symbol units in file formats. This was mostly the case for a while but there remained corner cases where we left a default/hidden option Fixes https://gitlab.com/kicad/code/kicad/issues/10888	2022-03-02 16:01:08 -08:00
Seth Hillbrand	984eb0fb40	Handle locally-coded file names for sheets Windows can accidentally create forward slash-coded files. This simply converts them to the proper unix-coded value when set Fixes https://gitlab.com/kicad/code/kicad/issues/10964 (cherry picked from commit `429544c188`)	2022-03-01 17:23:30 -08:00
Seth Hillbrand	61acd607ad	Ensure fields are properly ordered When reading sheet fields, we need to maintain a consistent order for the mandatory fields as they are dereferenced by place. We force this during the `SetFields()` call. (cherry picked from commit `8385ce3021`)	2022-03-01 17:10:35 -08:00
Seth Hillbrand	ac87d5e940	Resolve text when requested Getting resolved text for a symbol should always happen, even if we have unresolved data in the instances Fixes https://gitlab.com/kicad/code/kicad/issues/11003 (cherry picked from commit `acb5ce7108`)	2022-03-01 15:11:06 -08:00
Jeff Young	79ad15b4fa	Fix copy/pasta. Fixes https://gitlab.com/kicad/code/kicad/issues/11005	2022-03-01 14:59:29 +00:00
Jeff Young	4dc652497d	Put device-coloured fills on device layer. Fixes https://gitlab.com/kicad/code/kicad/issues/10993	2022-02-28 21:11:01 +00:00
Seth Hillbrand	eb06ecab10	Avoid resolving text vars without screen We need to keep the screen blank while initially loading a sheet before the hierarchy is developed. Avoid resolving text variables during this process Fixes https://gitlab.com/kicad/code/kicad/issues/11000 (cherry picked from commit `63b06af6b1`)	2022-02-28 12:28:02 -08:00
Jeff Young	b55bda8d6f	Font support for drawing sheet editor. Fixes https://gitlab.com/kicad/code/kicad/issues/10306	2022-02-28 18:05:26 +00:00
Mike Williams	5503afc09a	Schematic: disallow center rotation, allow both endpoint rotations Center rotation will often misalign lines to the grid, which is bad until fix off grid items on the schematic. We can rotate a connection end into a new connection or to become collinear with an existing line, so we need to check for this at the end of rotation. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10565 (cherry picked from commit `7d4cb91f39`)	2022-02-28 08:50:12 -08:00
Jeff Young	f241617478	Be more careful about non-visible elements in fields autoplacer. Fixes https://gitlab.com/kicad/code/kicad/issues/10774	2022-02-28 00:18:39 +00:00
Jeff Young	c4d2ac570f	Don't allow break commands (or labelling cmds) on multiple wire selections. Fixes https://gitlab.com/kicad/code/kicad/issues/10934	2022-02-27 23:15:07 +00:00
Jeff Young	1f16092e29	Infobar warning if symbol loading was cancelled. Also makes sure the progress dialog is closed when we're done reading symbols (it used to stay up for much of the symbol editor initialization). Also makes sure that any cancel in the preLoad step is honoured in the sync step. (The preload is done because it is multi-threaded and therefore faster than the single-threaded sync.) Also makes sure that individual threads pay attention to the cancellation, not just the GUI thread. Fixes https://gitlab.com/kicad/code/kicad/issues/8372	2022-02-27 17:06:08 +00:00
Seth Hillbrand	535ea800c0	Honor modifier keys in diambiguation Needs to be reset for the new action before selecting elements at a point. Fixes https://gitlab.com/kicad/code/kicad/issues/9712 (cherry picked from commit `a30ad0b54a`)	2022-02-25 16:16:15 -08:00
Steffen Mauch	78620347c8	Fixing Eagle refs that do not work with KiCad KiCad has stricter requirements for what consititutes an annotated symbol. This checks for and corrects annotations that begin with '#', do not begin with a non-numeric character or do not end with a number	2022-02-25 23:42:47 +00:00
Seth Hillbrand	faa3829ad4	Add MRU to image placement tools	2022-02-25 13:18:43 -08:00
Jeff Young	6d8507d44f	Formatting.	2022-02-25 17:36:35 +00:00
jean-pierre charras	4c81bac9e3	Eeschema: ensure ERC exclusions list is up to date before saving it in *.kicad_pro Fixes #10339 https://gitlab.com/kicad/code/kicad/issues/10339	2022-02-25 18:21:46 +01:00
Jeff Young	67eb138a4b	Fix copy/pasta. Fixes https://gitlab.com/kicad/code/kicad/issues/10957	2022-02-25 00:49:41 +00:00
Jeff Young	a29968fa91	Make sure bitmap fallback is only used for non-cached text. Also fixes backwards vertical justification for bitmap text. Fixes https://gitlab.com/kicad/code/kicad/issues/10956	2022-02-24 18:16:45 +00:00
Jeff Young	2042b08127	Performance optimizations for drawing (small) text.	2022-02-23 12:09:36 +00:00
Jeff Young	d58427a519	Don't kill entire OpenGL cache on undo. The comment regarding bitmaps was true for one more month in 2018, but hasn't been true for the last 3 years, and clearing the cache is a huge performance hit.	2022-02-22 23:09:55 +00:00
Jeff Young	c7dda3fbec	Formatting.	2022-02-22 22:19:55 +00:00
Mike Williams	e35c3f2b99	Schematic: handle switching h/v mode better while drawing lines Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10859	2022-02-21 17:03:43 +00:00
Jeff Young	a2772b3363	Don't crash on highight net during drag. Fixes https://gitlab.com/kicad/code/kicad/issues/10866	2022-02-21 13:30:15 +00:00
Jeff Young	b0d7c82e64	Disable grid when ctrl/cmd key is down. Fixes https://gitlab.com/kicad/code/kicad/issues/9995	2022-02-20 16:50:30 +00:00
Mike Williams	d0749c4e9a	Schematic: more drag undo fixes Drag was not clearing IS_CHANGED status of items that were moved by the drag, but weren't selected or created by it. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10845	2022-02-20 11:49:18 +00:00
Seth Hillbrand	d1a4daefbb	wxPoint->VECTOR2I correction for master	2022-02-19 19:14:41 -08:00
Seth Hillbrand	24ac516135	Trim wires based on how many pins they intersect If a wire intersects more than 2 pins from the same symbol, we don't trim connections. If the wire intersects exactly two pins from a single symbol, we remove the wire between the pins. We avoided doing this before because we didn't have a good metric for trimming vs. not. But the per-symbol calculation feels like the least surprising option. Fixes https://gitlab.com/kicad/code/kicad/issues/10909 Fixes https://gitlab.com/kicad/code/kicad/issues/1857 (cherry picked from commit `75a4036e45`)	2022-02-19 16:54:45 -08:00
Thomas Pointhuber	8ef7252330	altium: Don't use string concatenation for paths pointing in the compound file * std::vector do not need to be split apart again * supports backslash in footprint names	2022-02-19 16:46:20 +01:00
Jeff Young	510dc28a5c	Resolve text variables before attempting to open datasheet.	2022-02-19 14:59:50 +00:00
Jeff Young	8a22dab83d	Fix crash bug when adding rows to pin table and then pasting to unit.	2022-02-18 17:12:46 +00:00
Jeff Young	a678b78091	Implement SCH_MARKER::GetSeverity(). Fixes https://gitlab.com/kicad/code/kicad/issues/10893	2022-02-18 12:14:38 +00:00
Jeff Young	944fe9637d	Fix error that prevent drawing pin selection highlighting.	2022-02-17 19:02:51 +00:00
Wayne Stambaugh	35f85dd900	Eeschema: fix broken symbol library rescue. Apparently at some point during V5 development, symbol cache library names were saved by replacing the LIB_ID separator character ':' with '_'. This caused the cache look up to fail there by skipping the symbol rescue which could result in broken schematics. I have no idea where this happened during V5 development. The video demo in the HEAD of the 5.1 branch shows the issue. All of the other demo cache libraries are correct. Fixes https://gitlab.com/kicad/code/kicad/-/issues/10488 (cherry picked from commit `c6c4f9ae4b`)	2022-02-17 09:16:33 -05:00
Jeff Young	9584849aba	Fix type which results in global fieldname templates being added to project.	2022-02-17 12:42:10 +00:00
Jeff Young	d60ed70d54	Sync all fields between units when symbol is edited. Fixes https://gitlab.com/kicad/code/kicad/issues/10610	2022-02-17 12:42:10 +00:00
Jeff Young	e499793147	Update alt pin assignments in other units. Fixes https://gitlab.com/kicad/code/kicad/issues/10849	2022-02-17 12:42:10 +00:00
Mike Williams	567168fffc	Schematic: make grabbing whole lines more intuitive Selecting end and midpoint will select whole line. Some changes for orthogonal dragging made this worse than in 6.0. Improves, but does not fully resolve: https://gitlab.com/kicad/code/kicad/-/issues/10860	2022-02-16 19:15:55 +00:00
Jeff Young	bc7742cb2e	Various text object defaults don't necessarily match file defaults. Fixes https://gitlab.com/kicad/code/kicad/issues/10862	2022-02-15 23:25:59 +00:00
Jeff Young	ab5489ad30	Fix typo. Fixes https://gitlab.com/kicad/code/kicad/issues/10390	2022-02-15 22:40:24 +00:00
Mike Williams	97797c44b9	Schematic: added drag wires undo/redo fix Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10845	2022-02-15 19:31:17 +00:00
Seth Hillbrand	45a1a9a715	Replace awkward double cast with binary logic The use of XOR with integers here is needed as MSVC doesn't implement the use of std::signbit for integers and casting up to double just to get the signbit feels wrong	2022-02-15 10:13:59 -08:00
jean-pierre charras	414dfb4745	Eeschema, DIALOG_TEXT_PROPERTIES and DIALOG_LIB_TEXTBOX_PROPERTIES: fix minor issues Fixes #10863 https://gitlab.com/kicad/code/kicad/issues/10863	2022-02-15 15:38:08 +01:00
Marek Roszko	3129f96686	Add awkward cast to double due to msvc conflict https://github.com/microsoft/STL/issues/519	2022-02-14 21:43:11 -05:00
Mike Williams	9c59c4ee12	Schematic: orthogonal drag bends should depend on move direction Prevents overlapping lines when possible. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10844	2022-02-14 22:52:34 +00:00
jean-pierre charras	876061369b	Fix some Pcbnew crashes due to null pointers	2022-02-14 13:46:05 +01:00
Jeff Young	4e5b30ad80	Rewrite autostart to not need connectivity. Fixes https://gitlab.com/kicad/code/kicad/issues/10579	2022-02-14 01:15:06 +00:00
Mike Williams	1090403ca2	Schematic Preferences: fix grid assert on negative width	2022-02-13 22:27:41 +00:00
Mike Williams	013d6d088f	Eeschema: fix pin starting wire bus bug Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10819	2022-02-13 15:02:09 +00:00
jean-pierre charras	7e6829e834	Fix minor compil warnings	2022-02-12 11:43:38 +01:00
Jeff Young	33e57930bc	Implement undo for Eeschema find/replace. Fixes https://gitlab.com/kicad/code/kicad/issues/10824	2022-02-11 22:09:22 +00:00
Mike Williams	21b59b4b6a	Eeschema: fix bus label drag adding a line Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10822	2022-02-11 21:30:50 +00:00
Jeff Young	940e03e567	Remove arc end swapping when parsing. See: `2366b06e77 (note_839061664)`	2022-02-11 13:10:52 +00:00
Werni	946f62d949	Add separate wildcard for OrCAD netlists	2022-02-11 09:24:20 +00:00
Jeff Young	082c6f5bd6	Make sure plotter uses default font when specified.	2022-02-10 20:33:06 +00:00
Jeff Young	f11b8011cd	Separate plotting into background and foreground. Fixes https://gitlab.com/kicad/code/kicad/issues/10390	2022-02-10 20:33:06 +00:00
Mike Williams	a5e8575091	Eeschema: Implement orthogonal dragging Fixes https://gitlab.com/kicad/code/kicad/-/issues/1956	2022-02-10 18:38:40 +00:00
Jeff Young	2366b06e77	Don't parse multiple items in a single c'tor or function call. The C++ optimizer is not always your friend and may do them in the reverse order.	2022-02-10 17:54:13 +00:00
Jeff Young	d33d092e8e	Add a second fix for backwards arcs. This one should also be good when we support larger-than-180 degree arcs.	2022-02-10 15:46:02 +00:00
Jeff Young	cb8e803788	Formatting.	2022-02-10 13:04:29 +00:00
jean-pierre charras	b9843a23eb	Eeschema, legacy *lib files: fix issues with 180 deg arcs. 180 deg arcs are a limit, so when importing them convert them to slightly smaller arc (arc angle = 179.5 deg) Fixes #10455 https://gitlab.com/kicad/code/kicad/issues/10455	2022-02-10 12:45:54 +01:00
Jeff Young	7b84e0a7d9	Make printing/plotting/drawing of LIB and SCH arcs consistent. Fixes https://gitlab.com/kicad/code/kicad/issues/10801	2022-02-10 00:35:24 +00:00
Wayne Stambaugh	3f8f90db9f	Factor out common s-expression library cache source code.	2022-02-09 11:20:14 -05:00
Wayne Stambaugh	7181f0b40b	Fix clang broken build.	2022-02-09 07:55:50 -05:00
Wayne Stambaugh	fe82f2dd40	Factor out common schematic s-expression source code.	2022-02-08 14:44:38 -05:00
Jeff Young	58c38d2830	Don't nanny users about what constitutes quality graphics. Fixes https://gitlab.com/kicad/code/kicad/issues/10788 Fixes https://gitlab.com/kicad/code/kicad/issues/10374	2022-02-08 17:35:48 +00:00
Jeff Young	3600b2ce3f	Make sure temp sheet has a parent.	2022-02-08 17:09:17 +00:00
jean-pierre charras	2f79f579cc	DIALOG_TEXT_PROPERTIES: do not show fill option for texts. It make sense only for text boxes. Fixes #10786 https://gitlab.com/kicad/code/kicad/issues/10786	2022-02-08 09:42:22 +01:00
Mike Williams	7c91cd73e3	Eeschema: unconnected ends of wire entries should allow auto start wires	2022-02-07 23:31:24 +00:00
Wayne Stambaugh	fc3cad0b54	Hash symbol libraries per library rather than statically per cache type.	2022-02-07 15:40:21 -05:00
Kevin Lannen	f9b27a53b2	Eeschema: Edit pin numbers while grouped ADDED: The pin table pin numbers column supports editing the list of pin numbers to add, remove, and rename pins. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/5620	2022-02-07 17:45:16 +00:00
Kevin Lannen	631d5155ef	Eeschema: Pin table support for multi unit symbols ADDED: Symbol editor pin table supports editing which unit each pin is displayed on Note: 6513 mentions being able to change the pin unit from the edit pin menu. This does not add that feature. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6513 Fixes: https://gitlab.com/kicad/code/kicad/-/issues/5470	2022-02-07 17:45:16 +00:00
Kevin Lannen	56794ab829	Eeschema: Add pin count column to pin table ADDED: When the pin table is showing grouped pins, display a read-only column that displays the number of pins in each row. Fixes https://gitlab.com/kicad/code/kicad/-/issues/2416	2022-02-07 17:45:16 +00:00
Kevin Lannen	08ca19f95d	Eeschema: Display pin count and duplicate pin list in pin table dialog	2022-02-07 17:45:16 +00:00
Jeff Young	624dc393bf	Fix tooltip. Fixes https://gitlab.com/kicad/code/kicad/issues/10708	2022-02-07 17:36:40 +00:00
Jeff Young	79c7d55a40	Add a checkbox for LIB_SHAPE borders. (We already have them for LIB_TEXTBOXes.) Fixes https://gitlab.com/kicad/code/kicad/issues/10365	2022-02-06 19:43:25 +00:00
Jeff Young	0ffa1288ee	Regularize how penWidths are fetched. Fixes https://gitlab.com/kicad/code/kicad/issues/git	2022-02-06 19:43:25 +00:00
Jeff Young	aedfe08bad	Show pin dangling symbols in Symbol Editor. Even though we don't have connections they're a still a good visual indication of which end of the pin is which. Fixes https://gitlab.com/kicad/code/kicad/issues/10742	2022-02-06 19:43:25 +00:00
Jeff Young	b1cc784582	Harmonize interchangeable units checkboxes. Fixes https://gitlab.com/kicad/code/kicad/issues/10708	2022-02-06 19:43:25 +00:00
Jeff Young	cc69849719	Fix definition of nonFields to include textboxes. Fixes https://gitlab.com/kicad/code/kicad/issues/10771	2022-02-06 19:43:25 +00:00
Jeff Young	b57ac3d517	Handle SCH_TEXTBOX in SCH_SEXPR_PLUGIN::Format. Fixes https://gitlab.com/kicad/code/kicad/issues/10771	2022-02-06 19:43:25 +00:00
Marek Roszko	d9c04da407	Sprinkle in some make_unique	2022-02-05 21:26:36 -05:00
Marek Roszko	41f54349a5	Replace inserts/push_backs with emplace in some spots	2022-02-05 19:53:31 -05:00
Jeff Young	7ccac79192	More wxString wide literals.	2022-02-05 21:29:34 +00:00
Jeff Young	8d3e1639d0	Update text variables when they change. Fixes https://gitlab.com/kicad/code/kicad/issues/10734	2022-02-04 12:52:46 +00:00
Marek Roszko	ca7840334c	Mark some limits as constexpr gcc doesn't need it and computes during compile regardless, but experimenting in godbolt, both clang and MSVC actually do need it or else it's partially computed at runtime	2022-02-04 07:50:13 -05:00
Seth Hillbrand	3badd53a96	Setup selection when repeating We need the item to be currently selected when repeating the last symbol insert. This ensures we have a valid selection before starting the move tool and possibly getting odd system behavior from mouse positions Fixes https://gitlab.com/kicad/code/kicad/issues/10619 (cherry picked from commit `7642a9db79`)	2022-02-03 17:09:59 -08:00
Jeff Young	b9eb3e9b05	Be more explicit about string conversions.	2022-02-03 23:07:41 +00:00
Seth Hillbrand	b7c31d3b5b	When undoing creation of the sheet, get out first We can't stay in a sheet that is deleted by the action of undo. Checks the current sheet and, if we are currently using it, ensures that the following action is to leave the current sheet Fixes https://gitlab.com/kicad/code/kicad/issues/10733 (cherry picked from commit `ccf2a63f45`)	2022-02-03 11:19:51 -08:00
Jeff Young	3d0b03515d	Fix bad field names when ID == -1. Fixes https://gitlab.com/kicad/code/kicad/issues/10548	2022-02-03 12:38:56 +00:00
Marek Roszko	fa1d316d84	Fix windows build error	2022-02-02 17:43:47 -05:00
Wayne Stambaugh	e590d07224	Fix clang build error.	2022-02-02 07:44:11 -05:00
Wayne Stambaugh	9260431fe4	Abstract out symbol library parser object.	2022-02-02 07:07:39 -05:00
Wayne Stambaugh	6fcc6f7c9d	Factor out common legacy schematic and symbol library parser code.	2022-02-01 16:30:15 -05:00
Jeff Young	bebfbce9b2	Move pcb file rep of text_boxes to strokes.	2022-02-01 16:29:59 +00:00
Jeff Young	a1009d7899	Fix assertion failure for labels.	2022-02-01 12:01:04 +00:00
Seth Hillbrand	59e43527a0	Add dummy defaults for textbox	2022-01-31 16:26:37 -08:00
Jeff Young	4243d7b055	Bug fixes for color handling.	2022-02-01 00:21:08 +00:00
Seth Hillbrand	098e8f7d9b	Revert "cmake: adding KICAD_MACOSX_APP_BUNDLE option" This reverts commit `ea9f960cc1`. Reverted for updates as this currently breaks kicad-mac-builder	2022-01-31 15:57:56 -08:00
Jeff Young	f3cd36d1d7	Bring EEschema textboxes in line with PCBNew's. Also adds Border checkboxes and fixes a bunch of bugs.	2022-01-31 21:46:40 +00:00
Jeff Young	5739505aa3	TextBoxes for PCBNew.	2022-01-31 20:00:47 +00:00
Jeff Young	60bcfd1bf1	Bug fixes in arc & textbox printing. Also removal of the no-longer-used clipping code from GR*.	2022-01-31 20:00:47 +00:00
Roberto Fernandez Bautista	25a7de730c	eeschema/CMakeLists.txt Sort sources alphabetically	2022-01-31 19:51:01 +00:00
jean-pierre charras	64f2adbc31	SCH_PAINTER, draw filled LIB_SHAPE: fix incorrect selection of fill color.	2022-01-30 10:20:49 +01:00
jean-pierre charras	b4826ce304	LIB_TEXT: fix incorrect position of the drawn text. Fixes #10654 https://gitlab.com/kicad/code/kicad/issues/10654	2022-01-30 09:11:16 +01:00
Seth Hillbrand	38706fdd95	Fully select a line for transformation When not trying to select points, we need to ensure that the full line is selected for transformation Fixes https://gitlab.com/kicad/code/kicad/issues/10566 (cherry picked from commit `70d00689ca`)	2022-01-29 17:37:30 -08:00
Wayne Stambaugh	b36e31c49f	Factor out common and remove dead legacy symbol library code.	2022-01-29 14:13:00 -05:00
Davide Gerhard	ea9f960cc1	cmake: adding KICAD_MACOSX_APP_BUNDLE option ADDED: with cmake KICAD_MACOSX_APP_BUNDLE option the user can disable the macOS app bundle creation when compiling on macOS. This permit to use/install KiCad like any other *nix platform (/usr/bin, /usr/share, ecc.). By default, cmake build the app bundle.	2022-01-28 15:49:37 -08:00
Jeff Young	c6a8100d46	Schematic and symbol text boxes. Also fixes some plot bugs with arcs. Also moves polygonization of arcs (when required) in plotting code from 5 degrees to calculated based on ARC_HIGH_DEF. Fixes https://gitlab.com/kicad/code/kicad/issues/5017	2022-01-28 21:38:15 +00:00
Jeff Young	3409783d9f	Break sch_text.h/.cpp into sch_text and sch_label. Also moves SCH_NETCLASS_FLAG to SCH_DIRECTIVE_LABEL, and remaps Altium harnesses from SCH_TEXT to SCH_DIRECTIVE_LABEL.	2022-01-28 21:38:15 +00:00
Seth Hillbrand	79403ef075	Readd yield call to give slice to system. Note: - wxYield does not work here, indicating the need for locking - wxYieldIfNeeded does not work, possibly for the same reason as wxYield - Both Layout() and m_fieldGrid->Layout() need to be called even though the first should call the second. Fixes https://gitlab.com/kicad/code/kicad/issues/5690	2022-01-28 13:02:39 -08:00
Franck	a6203617d9	Fix Altium schematic port component import assertion. Fixes https://gitlab.com/kicad/code/kicad/-/issues/10322 Fixes https://gitlab.com/kicad/code/kicad/-/issues/10401	2022-01-28 15:52:30 +00:00
Mike Williams	ecb32b1fb0	Eeschema: hover start from wire end should copy wire properties Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10128	2022-01-27 17:17:45 +00:00
Seth Hillbrand	9ab2eb391f	Move delay selection out of UpdateUI Calling actions from within UpdateUI can cause loops that crash or substantially slow Fixes https://gitlab.com/kicad/code/kicad/issues/10616	2022-01-26 16:05:40 -08:00
jean-pierre charras	8a17fb8d19	SCH_SEXPR_PARSER::parseArc(): fix a very annoying issue: each time the lib or sch files are saved and reopened, 180 deg arcs were flipped. This fix is a workaround, but avoid flipped arcs after saving/reopening these files.	2022-01-26 18:19:52 +01:00
Seth Hillbrand	2dc031ee34	Prevent auto-column sizing when editor opens On GTK, some configurations will trigger a column resize, which will close the current editor. This blocks the column resize while the editor is open, unless the resize continues, which indicates dragging of the window edge Fixes https://gitlab.com/kicad/code/kicad/issues/5690	2022-01-25 17:59:15 -08:00
Seth Hillbrand	b6ecbc596e	Fix mistaken use of `m_width` This is a protected var in Linux but doesn't exist in Mac/MSW. We use the new m_fieldsSize	2022-01-25 12:45:09 -08:00
Seth Hillbrand	efb323d57d	Another stab at https://gitlab.com/kicad/code/kicad/-/issues/5690 This time, ensure that the grid is increased and the main form gets an event	2022-01-24 16:30:30 -08:00
Seth Hillbrand	a054a46136	Force a size event to avoid multiple yields When the grid editor is shown, we also want to ensure that the grid gets resized to account for the new editor. Queuing the event will ensure that happens after the editor is emplaced in the grid Fixes https://gitlab.com/kicad/code/kicad/issues/5690 (cherry picked from commit `fddfce4fb1`)	2022-01-24 15:32:17 -08:00
Seth Hillbrand	be5bb8c4bd	Enforce strictly weak ordering in sheets This ensures that irreflexivity is given in sort ordering. This may have been triggering issues in MacOS when adding sheets Fixes https://gitlab.com/kicad/code/kicad/issues/10557 (cherry picked from commit `a1615cce7e`)	2022-01-24 10:41:21 -08:00
Seth Hillbrand	175c4fe67c	Allow time to update editor On GTK, the full editor needs to be shown and, for some systems, the editor will not show correctly. By yielding we should allow the time to recalculate sizes for the editor in the grid Fixes https://gitlab.com/kicad/code/kicad/issues/5690 (cherry picked from commit `871556ebda`)	2022-01-24 09:58:10 -08:00
Seth Hillbrand	0926eb3287	Get all eeschema layers properly ordered Layers not in the given order are drawn behind everyone else. Missing the text prevents global labels from showing properly in GAL order Fixes https://gitlab.com/kicad/code/kicad/issues/10546 (cherry picked from commit `f12d0cb0e2`)	2022-01-23 10:04:32 -08:00
Fabien Corona	58e167013d	SPICE: Add support for transmission lines	2022-01-23 17:23:22 +00:00
jean-pierre charras	2dbc89e5f2	DIALOG_SIM_SETTINGS: fix incorrect validation of DC souces in DC Transfer panel Fixes #10568 https://gitlab.com/kicad/code/kicad/issues/10568	2022-01-23 16:22:12 +01:00
Jeff Young	0283e2c246	Highlighting for schematic shapes when fill shapes is turned off. Fixes https://gitlab.com/kicad/code/kicad/issues/10372	2022-01-22 22:27:41 +00:00
Jeff Young	29841ba315	Bring ERC & DRC dialogs into parity. Fixes https://gitlab.com/kicad/code/kicad/issues/9350	2022-01-22 22:27:41 +00:00
Jeff Young	de49f5090d	Formatting (and auto reduction).	2022-01-22 12:16:07 +00:00
Jeff Young	4665cdcdc5	Allow more (lots more) unfold from bus menu entries. Fixes https://gitlab.com/kicad/code/kicad/issues/10529	2022-01-21 17:41:05 +00:00
jean-pierre charras	242e66355c	SYMBOL_VIEWER_FRAME: fix refresh of the canvas after selecting a new symbol.	2022-01-21 16:37:58 +01:00
jean-pierre charras	694ae59664	fix a minor compil warning (shadowed vars)	2022-01-21 14:09:42 +01:00
Jeff Young	c8a50d9b50	Remove unit-less angles from VECTOR2I/D APIs.	2022-01-20 23:58:20 +00:00
Seth Hillbrand	16aca901df	Clear Undo list when renaming Our undo/redo list is tied to the screen that gets cleared when we reload the file after renaming. We need to clear the Undo list at this point to prevent possible crashes when moving too far back in the stack Fixes https://gitlab.com/kicad/code/kicad/issues/10504 (cherry picked from commit `323a069738`)	2022-01-20 11:29:05 -08:00
Seth Hillbrand	cffc99e384	Don't close filled polylines when printing Eeschema/libedit support open, filled polylines. When printing, this should be drawn as a fill, followed by the polyline to avoid assumptions about closed polygons in the graphic code Fixes https://gitlab.com/kicad/code/kicad/issues/10537 (cherry picked from commit `615eda816e`)	2022-01-20 10:54:36 -08:00
Jeff Young	3ba89f50ef	Maybe, just maybe, fix LibEdit arc parsing. Fixes https://gitlab.com/kicad/code/kicad/issues/10455	2022-01-19 22:22:18 +00:00
Jeff Young	8445783216	Fix backwards arcs in legacy LIB_ARCs. Fixes https://gitlab.com/kicad/code/kicad/issues/10455	2022-01-18 14:08:47 +00:00
jean-pierre charras	380cb452b2	fix an issue in a bom script (extra empty lines created) Fixes #10473 https://gitlab.com/kicad/code/kicad/issues/10473	2022-01-18 13:49:50 +01:00
jean-pierre charras	25fca2abb7	fix a minor compil warning	2022-01-18 13:49:50 +01:00
Jeff Young	f310a5b986	Excise deci-degrees from trigo.	2022-01-18 11:44:55 +00:00
Jeff Young	b828355206	A bit more angle cleanup.	2022-01-18 09:48:24 +00:00
Jeff Young	de31b813f3	Angle cleanup in the Cadstar importer.	2022-01-18 02:31:37 +00:00
Jeff Young	622f94e7b9	Angle cleanup in Altium importer.	2022-01-18 02:31:37 +00:00
Jeff Young	0218b782f4	Angle cleanup in Eagle importer.	2022-01-18 02:31:37 +00:00
Jeff Young	dcaec78cc5	A bit more angle cleanup.	2022-01-18 02:18:55 +00:00
Thomas Pointhuber	0129e49b79	altium: Introduce new ALTIUM_COMPOUND_FILE object to handle file opening and searching for streams at a central place	2022-01-17 19:54:26 +01:00
Jeff Young	2defd8d911	Move show-bounding-boxes to a tool on the toolbars.	2022-01-17 11:56:40 +00:00
Jeff Young	5cc3368b14	Fix bounding boxes and hittesting for arcs in eeschema.	2022-01-16 23:54:59 +00:00
Jeff Young	e61144d45a	Finish with EDA_ANGLE.	2022-01-16 21:15:40 +00:00
dsa-t	bc1ff6756f	Cross-probing/selection for multiple items (SCH->PCB)	2022-01-16 20:29:03 +00:00
Jeff Young	e84c574830	Some more EDA_ANGLE cleanup.	2022-01-16 19:16:18 +00:00
jean-pierre charras	516d038bdf	Eeschema: fix incorrect stored rotation value in file of the global and hierarch. labels. The stored value was the rotation of the text (always 0 or 90 deg), but these labels can also be rotated by -90 or 180 deg Fixes #10450 https://gitlab.com/kicad/code/kicad/issues/10450 Fixes #10457 https://gitlab.com/kicad/code/kicad/issues/10457	2022-01-16 17:19:36 +01:00
Jeff Young	9b661aea10	EDA_ANGLE for plotters. Also fixes a compile error in the PNS Playground.	2022-01-16 01:19:45 +00:00
Jeff Young	2b14b60c32	Resolve text variables in eeschema before passing to pcbnew. Fixes https://gitlab.com/kicad/code/kicad/issues/10429	2022-01-15 01:30:03 +00:00
Jeff Young	a533d64417	Apply default line style. Fixes https://gitlab.com/kicad/code/kicad/issues/10388	2022-01-14 16:08:19 +00:00
Jeff Young	07013d00e1	More EDA_ANGLE.	2022-01-14 16:08:19 +00:00
Jeff Young	1b19ff5f42	More EDA_ANGLE changes.	2022-01-14 16:08:19 +00:00
Jeff Young	70ad554343	Coverity fixes.	2022-01-14 16:08:18 +00:00
Jeff Young	e048e51f5d	Improve SNR of EDA_ANGLE stuff.	2022-01-14 16:08:18 +00:00
jean-pierre charras	d0f2c20235	Define our kicad font name only once, and do not translate it. Especially using a translated name breaks kicad config and files because in non English languages both translated and not translated names were used in code.	2022-01-13 14:32:55 +01:00
Seth Hillbrand	e244ce1431	Fix cherry-picked wxPoint	2022-01-12 15:49:03 -08:00
Seth Hillbrand	d3f24308e6	Handle rotated symbol rectangles in Eagle import Fixes https://gitlab.com/kicad/code/kicad/issues/10360 (cherry picked from commit `dcb8f29317`)	2022-01-12 15:11:18 -08:00

... 8 9 10 11 12 ...

8696 Commits