Jeff Young
cbff011e3c
Don't delete default intersheetrefs field from global labels.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14493
(cherry picked from commit a226f7fc14
)
2023-04-09 19:04:33 +01:00
jean-pierre charras
e991ae504b
DIALOG_IMAGE_PROPERTIES: fix some issues:
...
- add missing panel_image_properties_base.fpb file
- fix not displayed image.
From master branch
2023-04-08 17:04:02 +02:00
Seth Hillbrand
39dcd0a352
Handle nested netclass assignments
...
Netclass directives should not be overriden, instead hold our error
checking for actually missing nets
Fixes https://gitlab.com/kicad/code/kicad/issues/14494
(cherry picked from commit 012737593b
)
2023-04-06 17:38:42 -07:00
Jeff Young
dce2247925
Improve scoping control of connetion members.
...
(The real bug here is that CONNECTION_GRAPH::assignNetCodesToBus() was
growing the bus aliases members list because it used a non-const
reference to it as a local storage list. The const scoping of it will
prevent this type of error in future.)
Fixes https://gitlab.com/kicad/code/kicad/issues/14269
2023-04-04 11:35:06 +01:00
Jeff Young
9a57c11348
Possible protection from acessing deleted window data.
...
(Long shot for Sentry KICAD-MM.)
(cherry picked from commit bd60f38569
)
2023-04-03 23:47:09 +01:00
Jeff Young
a21e7a5eee
Don't pass a FRAME-based UNITS_PROVIDER to a modeless dialog.
...
(The dialog may outlive said frame.)
Should fix Sentry KICAD-3A.
(cherry picked from commit 9b4627e782
)
2023-04-03 17:20:06 +01:00
Jeff Young
927b5ae707
Use enums for column ids.
...
(The nickname, in particular, is no longer column 1.)
Fixes https://gitlab.com/kicad/code/kicad/issues/14291
2023-04-02 15:28:11 +01:00
Jon Evans
b22ff229db
DbLib: Get rid of some GCC warnings
...
(cherry picked from commit c35cefe1d5
)
2023-03-26 19:48:58 -04:00
Roberto Fernandez Bautista
97c018118d
CADSTAR Sch: TERMATTR may have more than one attribute subnode
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13526
(cherry picked from commit fc04f5135f
)
2023-03-26 14:55:06 +00:00
Jeff Young
7931f315b1
Manually cherry-pick some fixes back from master.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14424
2023-03-26 11:00:23 +01:00
jean-pierre charras
f2ce9cf857
Plot symbol graphic texts: fix incorrect position of texts in some rotations.
...
The plot code is now similar to the one for symbol fields
From master branch.
Fixes #14327
https://gitlab.com/kicad/code/kicad/issues/14327
2023-03-25 18:27:35 +01:00
Jeff Young
d4a312d6cb
Move separation of model name from params earlier in the process.
...
We need just the model name when we look for a match in the library file.
(cherry picked from commit 60aadfee40
)
2023-03-25 15:37:57 +00:00
Marek Roszko
434161687e
Fix cli crash due to dialogs buried in the pcb parser...
...
Fixes sentry KICAD-Q2
(cherry picked from commit 8a8589b9db
)
2023-03-24 23:53:15 +00:00
Jon Evans
b0b9e66fad
Move to requiring explicit action to save project settings
...
(cherry picked from commit 610e787ada
)
Fixes https://gitlab.com/kicad/code/kicad/issues/14414
2023-03-24 11:49:50 -07:00
Seth Hillbrand
89488a43b9
Pins are case-sensitive
...
Cleanup should remove mis-matched cases
Fixes https://gitlab.com/kicad/code/kicad/issues/14415
(cherry picked from commit 0984599624
)
2023-03-24 11:35:20 -07:00
Jon Evans
2ada171806
Be more flexible about extracting booleans from database
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14376
(cherry picked from commit dd8b52af93
)
2023-03-23 01:25:09 +00:00
Jeff Young
7026cfe140
Split name from additional params only when model is a library reference.
...
(cherry picked from commit b8cf7cc080
)
2023-03-22 14:12:42 +00:00
Jeff Young
b7cd1dd764
Handle single-token flag parameters.
...
Also fixes a bug where all VDMOS instance parameters weren't marked as
instance parameters.
Also fixes a bug where VDMOS thermal models weren't supported (they
have two extra pins: Tj and Tcase).
(cherry picked from commit 5bda3b99f9
)
2023-03-22 14:12:42 +00:00
Jeff Young
09bb8fc4f4
Don't include non-overridden parameters in Sim.Params.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14369
(cherry picked from commit 9dc16eb014
)
2023-03-22 14:12:42 +00:00
Jeff Young
1614dc975a
Separate legacy model name from parameters.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13988
(cherry picked from commit 39a801423e
)
2023-03-21 13:31:20 +00:00
Jeff Young
a713ee852c
Ignore extraneous LTSpice parameters for VDMOS models.
...
Also adds special case handling of VDMOS syntax to allow parens (or extra
spaces, linebreaks, etc.) between "VDMOS" and "NCHAN"/"PCHAN".
Fixes https://gitlab.com/kicad/code/kicad/issues/14299
2023-03-20 16:16:13 +00:00
Jeff Young
1dc9583e06
Don't attempt to load unknown plot types.
2023-03-20 10:24:22 +00:00
Jeff Young
3afe02ac1f
Make sure legend reflects gain/phase for AC small signal analyses.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14301
(cherry picked from commit ec6d709929
)
2023-03-20 10:24:22 +00:00
Jeff Young
9d457dc0ab
Less nagging. (If we need a field name, then create one.)
...
Also cleans up empty fields when exiting the dialog.
2023-03-19 19:15:28 +00:00
Jeff Young
044c301d64
Remove accelerator keys from schematic find/replace dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14304
(cherry picked from commit afe813cae5
)
2023-03-18 23:38:09 +00:00
Jeff Young
fb02e55424
Don't pass a REPORTER when checking for overrides.
...
It fails the unit tests (as it generates a message whenever no override
is found).
2023-03-17 15:30:24 +00:00
Jeff Young
70e86434ef
Manual cherry-pick of much of 6d296038f3
2023-03-17 14:12:58 +00:00
Jeff Young
64641c28ef
Handle underscore in parameter names.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14308
(cherry picked from commit 222cd4d009
)
2023-03-16 23:51:56 +00:00
jean-pierre charras
69e9f4ada2
DIALOG_LABEL_PROPERTIES, add global label: better filtering of candidates.
...
The list of candidates (names) must be restricted to existing global labels
and symbols creating a global net name: power symbols having only one power
input pin (a power output does not create net name).
Fixes #14319
https://gitlab.com/kicad/code/kicad/issues/14319
2023-03-16 16:01:18 +01:00
Wayne Stambaugh
d28cf632e4
Coverity fixes and code cleaning.
...
(cherry picked from commit a1fb8e1b1d
)
2023-03-16 10:59:05 -04:00
jean-pierre charras
25f40566ed
Symbol editor: fix incorrect position of fields when loading a symbol from schematic.
...
In symbol editor, symbols are always shown not mirrored, not rotated.
So if the loaded symbol from schematic was rotated/mirrored, the position
of fields must be recalculated for the rotation 0, no mirror.
From master branch
2023-03-15 18:03:11 +01:00
Jeff Young
94057886a3
Support SHEET_PATH when printing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14233
(cherry picked from commit dc78797274
)
2023-03-14 11:56:33 +00:00
Jeff Young
b2679b7648
Swap pins for undo.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14100
(cherry picked from commit c266913ec7
)
2023-03-14 11:56:33 +00:00
Jeff Young
c5a69f073c
Added PSPICE/LTSPICE JFET model parameters.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12425
(cherry picked from commit 3bc5e3dd8a
)
2023-03-12 21:05:06 +00:00
Jeff Young
3025671b1a
Add missing command to SPICE directives list.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14215
(cherry picked from commit 6d29088668
)
2023-03-12 21:04:50 +00:00
Wayne Stambaugh
9e1fd16329
Coverity fixes and code cleaning.
...
(cherry picked from commit 4e99812145
)
2023-03-10 11:21:19 -05:00
Salvador E. Tropea
f135881bd6
Use constants for the names of the built-in colors
...
- Avoid repetition and errors from typos
- Allow simple changes
- Simpler data type handling, the constants are wxString
2023-03-07 10:32:18 +00:00
Seth Hillbrand
839301f81e
Revert "Consolidated ERC fixes"
...
This reverts commit 2127712115
.
Version uses functions only available in the master branch. Will revert
for 7.0.2 to allow targeted update
2023-03-06 21:22:55 -08:00
James J
2127712115
Consolidated ERC fixes
...
- Consistent calculation of IsStacked() for pins across ERC checks
- Correct placement of ERC marker for unresolved field variables
- Add sheet-specific paths to two ERC check results
(cherry picked from commit 39e56485fc
)
2023-03-06 16:38:11 -08:00
Graham Keeth
9b2aeda51e
Fix column offset in BOM script
...
Debugged by @svk28
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14128
(cherry picked from commit cc110399ea
)
2023-03-06 16:23:31 -08:00
JamesJCode
b82020722b
Eeschema netlist output: Propagate NC across hierarchical schematics
...
Fixes #12580
Additionally does not export no_connect netlist annotation on pins
which are both connected to another pin and a NC item, unless all
connected pins are stacked at the symbol level.
Adds testing of pin types to netlist QA unit tests.
(cherry picked from commit 9dca70a773
)
2023-03-06 16:22:25 -08:00
Jeff Young
4076461347
Make SPICE netlist title explicit.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14183
(cherry picked from commit 6838de962b
)
2023-03-06 23:09:51 +00:00
aris-kimi
f1e060902b
Simulator: Fix RLGC c unit
...
(Cherry-picked from db2780090c
)
2023-03-06 15:59:54 +00:00
aris-kimi
05ab9e3836
Simulator: Fix diode ibv unit
...
(Cherry-picked from 5b43dc4e7b
)
2023-03-06 14:20:33 +00:00
Jeff Young
a4e0f1f7aa
Support both wxWidgets APIs for excluded characters.
...
(Sadly they're mutually incompatible.)
Fixes https://gitlab.com/kicad/code/kicad/issues/14153
(cherry picked from commit b5060d2951
)
2023-03-06 14:17:11 +00:00
Jeff Young
a8f27d13e6
Use name (even for fallback models) *if* it's specified in dropdown.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12425
(cherry picked from commit 7547e550aa
)
2023-03-06 11:18:14 +00:00
Alex
8f1237e629
bom_csv_grouped_extra: use field-specific methods for data.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14129
(cherry picked from commit c1f4911d7e
)
2023-03-05 00:26:46 +00:00
Wayne Stambaugh
2c7f44f78d
Coverity fixes and code cleaning.
...
(cherry picked from commit 789bf6455a
)
2023-03-04 13:14:59 -05:00
Jeff Young
9b61b350fe
Don't commit changes on paint events or updateUI events.
...
Also use std::numeric_limits::epsilon for comparing doubles.
Fixes https://gitlab.com/kicad/code/kicad/issues/13851
(cherry picked from commit d714ff8549
)
2023-03-04 00:10:39 +00:00
Alex
e3cf65fbdf
Fix bitmap scaling when reading legacy schematic as well.
...
(cherry picked from commit bfc3e2d29b
)
2023-03-03 22:39:38 +00:00
Jeff Young
e51d43568e
Prefer Clamp() to std::min( std::max() ).
...
(cherry picked from commit d545216432
)
2023-03-03 21:32:19 +00:00
Seth Hillbrand
adc7a3ba4a
Correct parent symbol for lib_text
...
The edited symbol should be pulled from the parent window when there is
not an existing text object
(cherry picked from commit 59fc62e898
)
2023-03-03 12:40:56 -08:00
Jeff Young
94ec6cc362
Convert inline models in Sim.Params fields to SPICE syntax.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14157
(cherry picked from commit 14f1f3ec79
)
2023-03-03 18:18:32 +00:00
Jeff Young
bbdb5eb6e3
Use resolved fields when generating LIB_TREE info.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13737
(cherry picked from commit 2fb24347ad
)
2023-03-03 17:23:13 +00:00
Jeff Young
e487ca8bd8
Handle alternate pin definitions when printing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14122
(cherry picked from commit 2973d292d9
)
2023-03-03 12:57:03 +00:00
Jeff Young
f5b0e20f78
The screen for undo is the screen that *owns* the SCH_SHEET...
...
... not the screen the SCH_SHEET owns.
Fixes https://gitlab.com/kicad/code/kicad/issues/14099
(cherry picked from commit 5849458476
)
2023-03-03 00:23:41 +00:00
Jeff Young
8619705e44
Hook up AddField handler to GRID_TRICKS for SCH dialogs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/git/14153
2023-03-02 18:16:02 +00:00
Jeff Young
c216ed2d1f
Make SME prop-grid hack Mac-only.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13852
(cherry picked from commit dcba555d44
)
2023-03-02 14:59:57 +00:00
Jeff Young
3a95826b42
Move only-write-model-if-it-contains-overrides up to base class.
...
It's necessary to keep us from writing out model lines for included
models and fall-backs of included models.
(cherry picked from commit f5edcf82f2
)
2023-03-01 13:44:26 +00:00
jean-pierre charras
dcc1009162
plotters rework: add plot fct to use TEXT_ATTRIBUTES class to pass text settings
...
Old PLOTTER::Text is not (yet) removed, but it use negative text size
to mirrored text, which is not really compatible with some plotters (especially PDF).
Using TEXT_ATTRIBUTES is much easy and much better,
so PLOTTER::PlotText() is added.
Note: "old" PLOTTER::Text() is not removed yet.
From master, commit 51d46c0e73
2023-03-01 10:45:23 +01:00
qu1ck
90eb5e9c31
PCM: auto reload global libs after dialog is run
...
This adds Reset() method to KIFACE to reload global libs stored in
global static vars.
Also refactors some lib reload code in various frames to have
common MAIL_RELOAD_LIB handler.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12500
(cherry picked from commit 2975f53647
)
2023-02-28 16:48:28 -05:00
Seth Hillbrand
17c34c88dc
Avoid forcing all units
...
When the enduser is not allowed to change the status of "common to all
units", then it should be disabled
Fixes https://gitlab.com/kicad/code/kicad/issues/14084
(cherry picked from commit 3207d1386e
)
2023-02-28 13:42:51 -08:00
aris-kimi
ff6f658f9d
Simulator: Fix some cases with initial conditions
...
(cherry picked from commit 4a761179d0
)
2023-02-28 21:31:45 +00:00
jean-pierre charras
764ddd4773
Fix compil warnings.
2023-02-28 18:00:22 +01:00
Graham Keeth
f7d9f1f69d
Fix SPICE pins for BJTs and MESFETs
...
- MESFETs don't have a substrate/bulk pin
- BJTs have a substrate pin, and HICUM/VBIC have TJ
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13848
(cherry picked from commit 6af3dadaee
)
2023-02-28 14:21:12 +00:00
Jeff Young
42efd2d005
Make substrate and thermal junction nodes optional.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14083
(cherry picked from commit 1fdc81e68d
)
2023-02-28 14:21:12 +00:00
Jeff Young
d32e13daee
Clear model name when switching to internal model.
...
Also fixes a bug to ensure that a modelLine gets written when using
an internal model.
Fixes https://gitlab.com/kicad/code/kicad/issues/14083
(cherry picked from commit 2e5bf0210a
)
2023-02-28 14:21:12 +00:00
Jeff Young
e82c21e944
Get rid of m_sortedSymbolPinList in favour of a properly scoped variable.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14083
(cherry picked from commit 2a79a453ec
)
2023-02-28 14:21:12 +00:00
Jeff Young
59d8110801
Always highlight children when they're selected on their own.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13876
(cherry picked from commit a1ceb585c7
)
2023-02-28 14:21:11 +00:00
Jeff Young
d028b381fa
Make SIM_MODEL_SPICE_FALLBACK act more like the model it's a fallback for.
...
In particular, install/show the parameters, and keep the existing name
field.
Fixes https://gitlab.com/kicad/code/kicad/issues/14102
(cherry picked from commit 281fde71b9
)
2023-02-28 14:21:11 +00:00
Roberto Fernandez Bautista
c96f0f2396
Fix CADSTAR importer memory leaks
...
We were leaking the xml tree when throwing exceptions
(cherry picked from commit b03366c9e8
)
2023-02-27 22:58:41 +00:00
Fabien Corona
46c8985661
sim - switches: open <-> closed in description
2023-02-27 19:04:48 +01:00
Jeff Young
b3c6f559b2
Don't eval empty string.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13756
(cherry picked from commit 79f13ea9c7
)
2023-02-26 23:14:40 +00:00
Jeff Young
4aba595b2b
Add second instance of "don't mess up user formatting" fix.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13989
(cherry picked from commit 4b427b2d0c
)
2023-02-26 22:00:20 +00:00
Jeff Young
4ffe742b69
Log new undo record at the start of Change Symbols.
...
Also fixes a bug where the "screen" variable was used with stale
data.
Fixes https://gitlab.com/kicad/code/kicad/issues/14061
(cherry picked from commit 2b96161d0e
)
2023-02-26 21:58:57 +00:00
Roberto Fernandez Bautista
955bd5a6d1
CADSTAR Sch: Fix loading of graphical arc shapes
...
Correctly load arc shapes as real arcs instead of approximating now that
v7 supports graphical arcs in the schematic.
Also fix calculation of arc geometry for ccw arcs.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14101
(cherry picked from commit 698d0b7e92
)
2023-02-26 18:47:39 +00:00
Jon Evans
d08157f7db
Re-disable validator for VALUE and add comment explaining it
2023-02-25 08:05:42 -05:00
Jon Evans
981bf328ae
Value field needs to use the normal text control
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14056
2023-02-24 22:18:31 -05:00
Jeff Young
f604bcb557
Only write included models if they have overridden parameters.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13953
(cherry picked from commit 5a12e5ee76
)
2023-02-24 20:47:22 +00:00
Jeff Young
eccf9eb4a4
Change strategy for committing values from SIM_MODEL propGrid.
...
Note that the PCB editor's propGrid doesn't seem to need this workaround,
but I haven't yet figured out what's different between it and the sim model
propGrid.
Fixes https://gitlab.com/kicad/code/kicad/issues/13852
(cherry picked from commit c188318174
)
2023-02-24 20:47:22 +00:00
Jeff Young
39403fa885
Cleanup some dead code, and add a potentially needed fix for non-Mac.
...
(The Mac bug is fixed in 4e5b1da81fce7cd9ffedaec878ed07bfcfff4fe2 in
our wxWidgets fork.)
(cherry picked from commit 200a06a677
)
2023-02-24 20:47:22 +00:00
Jeff Young
5e7cc30564
Don't mess up user formatting if eval'ing didn't actually change value.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13989
(cherry picked from commit 8059edff0e
)
2023-02-24 20:47:22 +00:00
Jeff Young
f942b4c657
Don't allow extra text in Sim.* fields.
...
(In particular, the field name.)
Fixes https://gitlab.com/kicad/code/kicad/issues/13996
(cherry picked from commit 71df3f9edb
)
2023-02-24 20:47:22 +00:00
Jeff Young
f5aeb5b068
More dead code removal and a bit of formatting and const& for strings.
...
(cherry picked from commit a126d961d8
)
2023-02-24 20:47:22 +00:00
Jeff Young
7f6cb9b07b
Remove most of SIM_VALUE in favour of good old wxString.
...
This allows us to save the user's intent, including units, formatting,
and crucially variable references.
(cherry picked from commit 68fe146861
)
2023-02-24 20:47:22 +00:00
Jeff Young
db3657d411
Terminology and more dead code.
...
(cherry picked from commit 29f21cdde6
)
2023-02-24 20:47:22 +00:00
Jeff Young
38e5da724d
Remove dead and redundant code.
...
(cherry picked from commit 90adc26b73
)
2023-02-24 20:47:22 +00:00
Jeff Young
962b2d45ef
Implement default levels for JFETs, MOSFETs and MESFETs.
...
(cherry picked from commit fe2679d965
)
2023-02-22 18:04:23 +00:00
Jeff Young
7894b41277
Don't allow 0 field text size.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13987
(cherry picked from commit cb71ea872b
)
2023-02-22 18:04:23 +00:00
Jeff Young
51d0b8d2b5
Don't allow SCH_LABEL_LOCATE_ANY_T to steal SCH_LABEL_LOCATE_WIRE_T's items.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13936
(cherry picked from commit 5967ab9a4d
)
2023-02-22 18:04:23 +00:00
Jeff Young
7b992a1dc4
Correctly netlist a voltage source with both AC and DC values.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13912
(cherry picked from commit c618bb7046
)
2023-02-22 18:04:21 +00:00
Jeff Young
2f8615c6c4
Don't use the just-in-time model resolver when updating the dialog.
...
If it changes in the middle it will leave you in a world of hurt.
Also don't update the library after a loss-of-focus unless the path
really changed.
Fixes https://gitlab.com/kicad/code/kicad/issues/13869
Fixes https://gitlab.com/kicad/code/kicad/issues/13854
(cherry picked from commit 64f1808d60
)
2023-02-22 17:53:10 +00:00
Marek Roszko
fd4a0dbedf
Fix up handling of font names available in multiple names
...
ttf fonts can declare multiple language names. Many by default opt to just declare one and not tag it any particular language.
However, there are CJK languages that typically leverage this function the most. They'll tag both a "en" and a cjk lang family name in CJK characters.
To be as user friendly as possible, we need to display said fonts in the CJK languages if KiCad to set to such a locale.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14011
(cherry picked from commit 39e69a3d29
)
2023-02-22 01:27:09 +00:00
Fabien Corona
c00a98fed4
Revert "sim - Remember the option to save powers"
...
This reverts commit 74dcc1b9d5
.
2023-02-20 20:59:52 +01:00
Fabien Corona
74dcc1b9d5
sim - Remember the option to save powers
...
Fixes #13978
(cherry picked from commit 2a3b70b7eb
)
2023-02-20 19:38:19 +00:00
Fabien Corona
17241b3543
sim - missing assignment
2023-02-20 18:15:37 +01:00
Fabien Corona
a4a859f47b
sim - Check FindParam() results before using them
2023-02-20 18:14:48 +01:00
Fabien Corona
b66ed8bc41
sim - don't write dc parameter twice
2023-02-20 18:13:44 +01:00
Fabien Corona
754feff5e7
sim - allow sources that are both AC and TRAN
2023-02-20 18:12:36 +01:00
Fabien Corona
cd1b425a80
sim: VSIN - allow user to specify a phase
...
TD is not the same as PHASE.
TD is the delay before the source turns on.
PHASE is ... the phase
If only TD is set, the signal starts later, but the phase is still 0 when compared to the t=0 of the simulation.
(cherry picked from commit 39a1b14a0f
)
2023-02-20 08:45:09 +00:00
Marek Roszko
5d793193e0
Fix crash by using a shared_mutex to read/write lock the nickIndex
...
Fixes sentry kicad-ax
2023-02-18 13:02:25 -05:00
Alex
b63d0a3138
Keep image sizes when loading/saving 7.0- schematic file formats.
...
Previously, images were assumed to have 300 PPI density when loading from
schematic, but not after initial placement.
(cherry picked from commit bd4758e4df
)
2023-02-17 01:50:01 +00:00
Alex
7949c09183
Prevent ghost image after canceling bitmap placement.
...
(cherry picked from commit ecb28ddf1c
)
2023-02-17 01:49:47 +00:00
Jon Evans
9f44809164
Revert "Handle another case where schematic view was being cleared"
...
This reverts commit 245ce7259c
.
2023-02-16 16:44:30 -05:00
Jon Evans
f7ccb18af5
Revert "Symbol editor: stop removing overlay from view"
...
This reverts commit f36cd60fdb
.
2023-02-16 16:44:20 -05:00
Jon Evans
cca9945867
Revert "Fix handling of selection overlay in schematic editor"
...
This reverts commit e2711a6121
.
This ended up being too complex for 7.0
2023-02-16 16:43:57 -05:00
Jon Evans
245ce7259c
Handle another case where schematic view was being cleared
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13944
(cherry picked from commit ec2fc161e1
)
2023-02-16 13:25:44 +00:00
Jon Evans
f36cd60fdb
Symbol editor: stop removing overlay from view
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13944
(cherry picked from commit 955a5a13eb
)
2023-02-16 13:17:34 +00:00
Jon Evans
e2711a6121
Fix handling of selection overlay in schematic editor
...
We weren't actually using the overlay group at all
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11142
(cherry picked from commit 0f18a36f8f
)
2023-02-16 02:17:36 +00:00
Jon Evans
08c6d9ce96
Set PPI properly in schematic bitmaps, too
...
(cherry picked from commit e8a88411ea
)
2023-02-15 02:37:22 +00:00
Jon Evans
37091df142
Symbol chooser: save UI settings even when canceled
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13903
(cherry picked from commit 29c4482bc8
)
2023-02-14 18:27:31 -05:00
Jon Evans
21081cf80f
Handle custom columns in symbol tree synchronizing adapter
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13907
(cherry picked from commit 0913552f84
)
2023-02-14 18:27:21 -05:00
Seth Hillbrand
d1ca84aa43
Don't desaturate the selection shadow
...
Selection shadows are helpful when showing which elements are selected
and there is no benefit (and some downside) to having their color
removed.
Fixes https://gitlab.com/kicad/code/kicad/issues/13878
(cherry picked from commit 9f8b25a0b0
)
2023-02-14 10:22:49 -08:00
Jeff Young
f4b2b1b03f
Workaround wxWidgets enforced min pen width by using transparent pen.
...
Also fixes some bugs in our shape printing code when a border is not
specified but a fill is.
Fixes https://gitlab.com/kicad/code/kicad/issues/13891
(cherry picked from commit 03484aedbc
)
2023-02-14 14:45:24 +00:00
Jeff Young
7816652078
Account for border when calculating text margin for text boxes.
...
Also fixes some unnoticed issues with the textbox dialogs (probably
dating from the move to wxWidgets 3.2).
Fixes https://gitlab.com/kicad/code/kicad/issues/13877
2023-02-13 17:07:42 +00:00
Jeff Young
20aacc7026
Don't confuse .OP with .OPTIONS.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13849
(cherry picked from commit d6bef19811
)
2023-02-13 13:34:40 +00:00
Jeff Young
49938cfd09
Fix layout issue in IBIS fields.
2023-02-13 12:42:42 +00:00
Jeff Young
53a4ed6b24
ReadDataFields must be a separate step from Create.
...
Create() is done without execption processing, while ReadDataFields
should have exception processing.
(This also fixes a case where exception processing on ReadDataFields
was missing.)
Also fixes a bug where the pinSelect menu wasn't checked for -1 before
fetching.
Fixes https://gitlab.com/kicad/code/kicad/issues/13856
2023-02-13 12:42:42 +00:00
Jeff Young
7e2ccbf909
Prepend correct SPICE prefix when necessary for plotting currents.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13850
(cherry picked from commit a22964a977
)
2023-02-13 10:59:32 +00:00
Jeff Young
77fa61e6fc
Make sure screen RTrees are updated when changing bounding boxes.
...
(cherry picked from commit 7bc79c17d4
)
2023-02-13 10:54:59 +00:00
Jeff Young
94c450ad16
Bug fixes for LIB_PIN boundbox generation.
...
(cherry picked from commit 9ce5978c3d
)
2023-02-13 10:54:55 +00:00
Jeff Young
a292bf7c83
Don't dirty connectivity when moving non-reference SCH_FIELD.
...
(cherry picked from commit 2e9ed67e05
)
2023-02-13 10:54:49 +00:00
Marek Roszko
b24ee1c44f
Prevent a crash when a spice SW_I lacks two pin net names
...
Fixes KICAD-5D
(cherry picked from commit 2cc3d8e9bc
)
2023-02-13 03:32:07 +00:00
Jon Evans
a6776edc26
Try to resolve worksheet filename before saving it
...
The new code was added to handle saving imported worksheets,
but it is possible to specify relative paths to worksheets
not only to the project folder but also to the global
templates directories.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13834
2023-02-11 10:33:23 -05:00
Alex
93020cf78f
Set select_pin_selects_symbol to false by default.
2023-02-11 16:51:55 +03:00
Alex
81a55c42a1
Fix unintentional string change in IBIS parser.
2023-02-11 02:19:06 +03:00
Paweł Płóciennik
06e3e63b96
Eeschema: text properties: reference field autocomplete ignores first char.
2023-02-10 21:56:03 +00:00
Marek Roszko
c22fb390ec
Set the text proeprties grid bag to avoid reserving space for hidden cells
2023-02-09 23:04:51 -05:00
Jeff Young
d4ca54a798
Handle global label offset when plotting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13301
2023-02-09 18:02:21 +00:00
jean-pierre charras
3d23d0e16a
Fix compatibility with wxWidgets 3.0.5
...
Fixes #13808
https://gitlab.com/kicad/code/kicad/issues/13808
2023-02-07 21:09:03 +01:00
Jeff Young
77d4704b45
Don't return a lib-tree symbol if the lib-tree is hidden.
2023-02-07 15:53:14 +00:00
Chris Morgan
e14f0848fa
SCH_EDITOR_CONTROL::Paste() - Adjust refdes behavior to match when creating new symbols
...
Pass 'false' as aStartAtCurrent to ReannotateByOptions(). Causes Pasing() symbols to start at the first available refdes after the currently
configured annotate start number, m_annotateStartNum.
Fixes #13342
2023-02-06 14:05:04 +00:00
jean-pierre charras
4065e413ea
Ibis parser: do not report activity when there are no errors.
...
The dialog to add a library expects no message when there are no error.
Fixes #13794
https://gitlab.com/kicad/code/kicad/issues/13794
2023-02-06 12:55:52 +01:00
jean-pierre charras
92724ff09f
Coding style fix.
2023-02-06 07:59:17 +01:00
Jeff Young
3ecd6ec186
Fix variable updating in SCH_FIELDs (which are not directly in the view).
2023-02-05 20:51:03 +00:00
jean-pierre charras
fb225acefc
Eeschema, ExportSymbolsToLibrary(): fix not working replace library.
...
When exporting symbols of the schematic to a new library, if this library
exists the dialog ask for overwriting it, but it did not work.
Fixed now.
2023-02-05 18:41:58 +01:00
Wayne Stambaugh
baeeeec492
Fix broken update symbol from library.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13782
2023-02-05 10:36:18 -05:00
Jeff Young
d1f6ba77e8
Better error reporting, and don't infer models with library references.
2023-02-04 20:55:52 +00:00
Jeff Young
9be872a85a
Better bounds checking for DIALOG_SIM_MODEL::curModel().
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13767
2023-02-04 20:16:50 +00:00
Jeff Young
56a1cdb4dc
Allow a limited set of un-braced expressions in SPICE model values.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13768
2023-02-04 19:49:48 +00:00
Jeff Young
f588da2bef
Bounds checking for DIALOG_SIM_MODEL::curModel().
2023-02-04 19:17:13 +00:00
Wayne Stambaugh
52b07b8bac
Fix duplicate symbol value fields when importing Eagle schematic.
...
Don't use the value field when adding Eagle part attributes to a symbol.
This issue was cause by using a mandatory symbol field ID instead of
using the next available field ID when adding new fields to as symbol.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13468
2023-02-04 12:37:41 -05:00
jean-pierre charras
6b5eeeb861
Preferences dialog: try to reduce its width, in non English languages.
...
Remove some useless spacers, and do not force some widgets to have a to
large size (by removing empty areas).
Work in progress: one panel is still too big.
2023-02-04 14:36:14 +01:00
Jeff Young
e8397a33bb
Refrain from copying SPICE_INFO.
2023-02-04 00:05:50 +00:00
Graham Keeth
a51dc8c9de
HiSIM_HV MOSFET models are *not* the default type
...
The ngspice manual does not indicate that there is any default
model type. This change ensures we get a `level=xy` written out to the
.model line when we select a HiSIM_HV model.
2023-02-04 00:03:25 +00:00
Graham Keeth
5abe1a201b
spice: generate .model lines for all device types
...
- generate .model lines in spice netlist for all device types that need
one
- add "level=<n>" to .model line for non-default model levels. This is
necessary to allow more sophisticated models to be used, and some
devices *always* need a level specified (e.g. JFETs)
- add "version=<n>" to .model line for models that have multiple
versions available (AFAIK only affects HiSIM_HV MOSFET models)
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13775
2023-02-04 00:03:25 +00:00
Graham Keeth
41c4ee2245
ngspice requires J prefix for JFETs in netlist
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13774
2023-02-04 00:03:25 +00:00
Jeff Young
ed5fb2769f
Allow more characters (in particular '_') in code model names.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13769
2023-02-03 23:49:53 +00:00
Jeff Young
71b8a2112c
Coverty fixes.
2023-02-03 15:09:24 +00:00
Wayne Stambaugh
a94d8a7e78
Use references instead of copies in map pair for loops.
2023-02-03 10:00:09 -05:00