Commit Graph

31868 Commits

Author SHA1 Message Date
Jeff Young 2dd04ea43a Protect move tool from re-entrancy.
m_dragInProgress is usually sufficient, except when we haven't started
one yet.  In any case, conflating the two is probably a bad idea.

Fixes https://gitlab.com/kicad/code/kicad/issues/12936

(cherry picked from commit bc271a8d15)
2022-11-29 23:16:48 +00:00
Jeff Young d7a7ddd80e Allow pads in selection and filter them for free-pads later.
Fixes https://gitlab.com/kicad/code/kicad/issues/12912

(cherry picked from commit cefc5268ab)
2022-11-29 23:15:39 +00:00
Jeff Young 27676f4388 Add mapping for -rescue.lib in project Save As.
Fixes https://gitlab.com/kicad/code/kicad/issues/12503

(cherry picked from commit 5366fa8cee)
2022-11-29 23:14:10 +00:00
Jeff Young 2f47857abc Move zone borders back to their "host" layer.
Zone borders shouldn't be affected by zone-opacity control; we always
draw them in full layer opacity.

Fixes https://gitlab.com/kicad/code/kicad/issues/12438

(cherry picked from commit 25f06eed8c)
2022-11-29 23:05:50 +00:00
Jeff Young ede21ed6ae Handle string escaping for Find/Replace in labels.
Fixes https://gitlab.com/kicad/code/kicad/issues/12789

(cherry picked from commit ae9405a4d3)
2022-11-29 22:54:14 +00:00
Jeff Young a09a3dfe68 Be careful of interveneing priority zones when doing divot prevention.
Fixes https://gitlab.com/kicad/code/kicad/issues/12797

(cherry picked from commit 1f4e51b008)
2022-11-29 22:43:41 +00:00
Jeff Young e083cbaf50 Allow a single net collision with a free pad.
(cherry picked from commit 3534cfbba8)
2022-11-29 22:16:15 +00:00
Seth Hillbrand 9d401b00d8 Allow groups in groups
This was allowed in the qa test, so we allow it going forward

(cherry picked from commit 137b4de1c2)
2022-11-28 11:28:51 -08:00
Seth Hillbrand 25e3b6c1bf Ignore generated files 2022-11-28 11:10:16 -08:00
Seth Hillbrand 2029fc4e8f Don't use modifiers when moving with keyboard
The modifier keys on the keyboard control the motion spacing (Ctrl) and
shouldn't be confused with the modifier key used to disable grid
snapping when moving with the mouse (also Ctrl)

Fixes https://gitlab.com/kicad/code/kicad/issues/13027

(cherry picked from commit 4f6b853756)
2022-11-28 11:06:24 -08:00
Seth Hillbrand c9cc29593a Don't add non-groupable items to groups
This is a re-implementation of 259e41be

Fixes https://gitlab.com/kicad/code/kicad/issues/13026
2022-11-28 09:26:48 -08:00
Seth Hillbrand 42bd43407a Remove clone's group info 2022-11-28 09:17:17 -08:00
Seth Hillbrand de05a513f3 Prevent mirror of text elements
While we never allow the creation of mirrored text elements in the
schematic and symbol library editors, external generation of symbols may
cause the property to be set, which can then never be changed.  This
leaves the property unset for all elements

Fixes https://gitlab.com/kicad/code/kicad/issues/13007

(cherry picked from commit f1556ed801)
2022-11-26 10:51:03 -08:00
Seth Hillbrand 554d82b2a4 Ensure that we clear deleted values
When throwing on an invalid value, we may end up freeing the same tree
twice.  This is generally not an issue but we need to mark the freed
memory as null to avoid a double free

Fixes https://gitlab.com/kicad/code/kicad/issues/12981

(cherry picked from commit 62863d6c5b)
2022-11-25 10:47:03 -08:00
Seth Hillbrand 3b3e86b968 Remove structured binding from v6 commit
C++17 is only for the master branch
2022-11-25 10:43:10 -08:00
Seth Hillbrand f6ca98061c Add terrible hack to get subgraph netname
In certain cases, the subgraph does not receive the proper netname,
preventing us from checking for correct pin counts.  This is a backwards
iteration of the net name <-> subgraph map to extract the proper name
and sibling subgraphs

Fixes https://gitlab.com/kicad/code/kicad/issues/12165

Fixes https://gitlab.com/kicad/code/kicad/issues/12814

(cherry picked from commit 938645b29d)
2022-11-25 08:51:12 -08:00
Tomasz Wlostowski cca7f1dbda router: use actual snap point position for routability checks of a segment instead of the segment endpoint(s).
Explanation:
- place a long segment A with something violating the rules close to its endpoint
- try to start routing in the 2/3 of the length of A (on the obstacle side)
- bummer - the router picks the nearest endpoint of A for the collision check (even though we don't care about this collision since we want to route far away from it)

(cherry picked from commit e558893851)
2022-11-23 06:57:11 -08:00
Seth Hillbrand 2cf4cb937f Fix graphic snapping
If the user has requested the ability to snap to graphics, we want to
add any of the graphical layers to the limit list
2022-11-23 06:57:11 -08:00
jean-pierre charras c3b9c65fd6 Gerbview, read zip archive: do not generate a error message for directory names.
A directory is not a file, and is now just skipped.
From master branch
2022-11-22 17:08:18 +01:00
Wayne Stambaugh d9a1703bcc Fix broken schematic instance data loading legacy files (<=5.1). 2022-11-18 10:07:59 -05:00
Wayne Stambaugh a22c466639 Fix broken legacy schematic file save. 2022-11-17 12:23:14 -05:00
Mark Roszko 9a2f83537d Restore missing libxslt 2022-11-15 03:27:48 +00:00
jean-pierre charras f136f3d7ee pcbnew, SVG import: fix an issue for SVG files using a CR+LF end of file
The issue was in a validity test working only if CR+LF is not replaced by LF
Fixes #10096
https://gitlab.com/kicad/code/kicad/issues/10096
2022-11-09 09:36:06 +01:00
Seth Hillbrand 61d4a5bfbe Resolve embedded text vars
Title Block text variables are embedded into the pcb file and should
be used for resolving when the project file is missing

(cherry picked from commit d1bf889e71)
2022-11-03 10:26:06 -07:00
Mike Williams 6289a82a18 PCB Router: return to original active layer after routing
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12313
(cherry picked from commit fa3e9efdce)
2022-11-03 10:16:26 -07:00
Marek Roszko 6ca2f6a6e1 Try a hackfix for windows icon scaling
Related https://gitlab.com/kicad/code/kicad/-/issues/11880


(cherry picked from commit 321d6e3ea8)
2022-10-31 21:47:11 +00:00
Marek Roszko 2ff3fac7b3 Don't fix the visibility icon size or it will never scale properly
Related https://gitlab.com/kicad/code/kicad/-/issues/11880


(cherry picked from commit c0f8810759)
2022-10-31 21:46:53 +00:00
Mark Roszko 08452433e8 Check the process exit code rather than output variable for git header creation 2022-10-29 18:39:02 +00:00
Wayne Stambaugh 39b9b3e570 Begin version 6.0.10 development. 2022-10-28 16:55:26 -04:00
Wayne Stambaugh b29f91cc15 Tag release version 6.0.9. 2022-10-28 16:51:23 -04:00
Jon Evans f81313068e ERC: Include power connections in multiple driver test
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12138


(cherry picked from commit 141c1f020e)
2022-10-28 02:55:42 +00:00
Jeff Young 882756b676 Fix typo.
Fixes https://gitlab.com/kicad/code/kicad/issues/12753


(cherry picked from commit c026c3af7b)
2022-10-25 17:40:33 +00:00
Jeff Young 8c3cd200d1 Clean up layer handling and normalize to remove magic numbers.
Fixes https://gitlab.com/kicad/code/kicad/issues/12747

(cherry picked from commit 5fe5534822)
2022-10-25 14:21:03 +01:00
Jeff Young a5fd03df88 Don't delete pin out from under selection & move tools.
Fixes https://gitlab.com/kicad/code/kicad/issues/12610

(cherry picked from commit 3cb6a80954)
2022-10-25 14:21:03 +01:00
Jon Evans 2d2912c23d Improve logic of Position Relative tool
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12672
2022-10-24 18:46:15 -04:00
Jeff Young 3106f6c9f4 We must check clearance on all layers of multi-layer items.
(One layer may have a custom rule.)

Fixes https://gitlab.com/kicad/code/kicad/issues/12733

(cherry picked from commit 2dec37f806)
2022-10-24 10:57:07 +01:00
Jeff Young fde2b429b9 Make sure pair caches are layer-specific where they need to be.
(cherry picked from commit 909358e643)
2022-10-24 10:57:07 +01:00
Wayne Stambaugh 0593663462 Fix 3D viewer canvas timer event clash.
Manual cherry-pick of commit f6297d328c.
2022-10-23 07:53:51 -04:00
Marek Roszko bce8c95647 Avoid netlist export dialog crash from trying to delete a non-custom format
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12229
2022-10-22 16:41:32 -04:00
Marek Roszko 4d729110d5 Fix build error due to C++17 use 2022-10-22 16:38:17 -04:00
Mark Roszko 6c2b9eb433 Bring 6.0 msvc ci in line with master 2022-10-22 17:12:29 +00:00
jean-pierre charras df223cced4 pl_editor: fix a crash when trying to delete an item during its creation.
Fixes #12717
https://gitlab.com/kicad/code/kicad/issues/12717
2022-10-22 18:32:46 +02:00
jean-pierre charras 8e331628b6 Do not add a title/comment in mandatory field strings when writting netlists.
This is mainly for "Sheetfile" property because current it is the only one
that has a title when plotting/drawing it.
2022-10-22 15:38:26 +02:00
Mikolaj Wielgus ceaf3fc72d Ngspice: Preload a basically empty circuit to avoid error messages
Fixes https://gitlab.com/kicad/code/kicad/issues/12481

(cherry picked from commit 6e874f4c1e)
2022-10-21 09:22:53 -07:00
Seth Hillbrand b004d7a1cb Fix ERC global label unit tests
Need to test all units in the subgraph as there are chances that the
subgraph might have more than one label, which needs to be consistently
handled

(cherry picked from commit 60374daa49)
2022-10-21 09:17:11 -07:00
Seth Hillbrand f3ff9ddd31 Show ERC errors when any label only has 1 pin
To be connected, the label must have at least two pins on a subgraph
(or, in the case of a hierarchical label, two pins somewhere in its
connection)

Fixes https://gitlab.com/kicad/code/kicad/issues/7203

(cherry picked from commit 05cdf915d0)
2022-10-21 09:11:24 -07:00
jean-pierre charras e5fa18c9b1 fix an issue in a bom script (extra empty lines created)
Fixes #10473
https://gitlab.com/kicad/code/kicad/issues/10473

(cherry picked from commit 380cb452b2)
2022-10-21 09:10:30 -07:00
Seth Hillbrand d52f246b2a Allow up to three discarded characters when detecting gerbers
Some layout programs add a blank block at the beginning but include the
terminating '*' on a line before starting the actual data.  This is
ignored by GerbView so we all this type of behavior in the mimetype file
detection as well

Suggested by Mark Jeronimus

Fixes https://gitlab.com/kicad/code/kicad/issues/12097

(cherry picked from commit 64335d94d7)
2022-10-21 09:10:01 -07:00
Seth Hillbrand 3dfbe582db Add "Letter-like character" Omega for Unicode x2126
Fixes https://gitlab.com/kicad/code/kicad/issues/12531

(cherry picked from commit 1b38acd9c6)
2022-10-21 09:08:58 -07:00
Seth Hillbrand 431aa88612 Allow printing backgrounds prior to foreground
Eeschema shows background fills on a different z-level than the rest of
the symbols/elements.  Print the backgrounds prior to the foregrounds in
order to preserve this view for print output

Fixes https://gitlab.com/kicad/code/kicad/issues/12559

(cherry picked from commit e055302a3c)
2022-10-21 09:00:13 -07:00