Jeff Young
36a139acb3
Tighten up hittest logic for junctions and lines.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6348
2020-11-10 18:08:25 +00:00
Wayne Stambaugh
4ea3914d4e
Coverity fixes.
...
CIDs: 312996, 305508, 305509, 305510, 312992, 312997, 312994, 312995,
312968, and 306650.
2020-11-10 08:50:16 -05:00
jean-pierre charras
79dd6e6476
Eeschema, ERC: fix missing call to subgraph->ResolveDrivers() when test driver
...
conflicts (more than one name for a net) is disabled.
This missing call was creating issues in tests that need a full connection
calculation, especially ercCheckFloatingWires()
2020-11-10 11:30:30 +01:00
Jeff Young
4889f9bb7c
Fix typo in net label orientation calculation.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6333
2020-11-09 12:07:40 +00:00
Thomas Pointhuber
8665098757
Don't write translated strings from the plugin cache
...
Followup for b7f115bf5f
2020-11-09 07:33:46 +00:00
Jeff Young
1f5213946e
Restore accidentally-removed allowsSpaces architecture.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6252
2020-11-08 00:34:04 +00:00
Jeff Young
c6ba4cdd19
Naming conventions.
2020-11-07 21:55:18 +00:00
Jeff Young
bfd8a62852
Formatting and naming conventions.
2020-11-07 18:50:30 +00:00
Jeff Young
91ba002da7
Make sure move machinery gets initialized if we're going to use it.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6293
2020-11-06 12:21:31 +00:00
Marek Roszko
08ca80a2d8
Smooth out redrawing of toolbars by not letting wx pointlessly calculate both orientations
...
Monkey patch
Fix #5705
2020-11-05 20:56:14 -05:00
Jeff Young
670fc645de
More fixes for initializing imported filenames.
2020-11-06 01:33:14 +00:00
Jeff Young
3630f32c26
Initialize newly imported files with current schematic extension.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6083
2020-11-05 23:24:59 +00:00
Jeff Young
44400ca413
Formatting, some i18n, and shorter log messages.
2020-11-05 23:19:47 +00:00
Wayne Stambaugh
ae4614bfbd
Symbol editor: do not allow paste into derived symbols.
...
Don't allow select all, copy, cut, paste, or duplicate if the current
symbol is an alias.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6050
2020-11-04 15:00:09 -05:00
PJM
43176a5b29
Eeschema: Add Schematic Setup GUI to set junction dot size from list
...
CHANGED: In Schematic Setup->General->Formatting->Connections, added
pulldown for "Junction dot size" with values none, smallest, small
default, large, largest" Added support in "sch_painter.cpp" to not
paint junction when they have a diameter of "1" which is what "none"
sets as the diameter.
2020-11-04 01:49:41 +00:00
Ian McInerney
3d47eb0d49
Fix localization of the menu strings with accelerator strings
...
The accelerator strings really shouldn't be part of the translation,
and some translations have cause the accelerator keys to be incorrectly
handled. It is simpler to make it separate and just join them to the
translated string.
Make all accelerator modifiers use lowercased Ctrl instead of CTRL
to be the same as the other modifiers.
Fixes https://gitlab.com/kicad/code/kicad/issues/5992
2020-11-04 01:31:52 +00:00
Ian McInerney
123fe5a887
Sort root symbols by name in new symbol dialog
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5910
2020-11-04 01:31:52 +00:00
Jeff Young
88abcc1287
Fix broken handling of closing ERC dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6277
2020-11-04 01:08:21 +00:00
Jeff Young
5507575d64
Move ERC dialog to EE_INSPECTION_TOOL and kill when resetting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6111
2020-11-03 20:27:44 +00:00
Jeff Young
4be6a27a39
Report error when pin for backannotate can't be found.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6263
2020-11-03 18:53:14 +00:00
Jeff Young
2a8ea25209
Null pointer safety.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6263
2020-11-03 15:47:38 +00:00
Wayne Stambaugh
52e9ec5954
Symbol editor: fix library symbol tree modified state bug.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5573
2020-11-03 09:33:06 -05:00
Jeff Young
bd103c133d
Don't save junction colours when they're inherited.
...
Also fixes Edit Text & Graphics Properties to be able to clear
colours from junctions.
Fixes https://gitlab.com/kicad/code/kicad/issues/6018
2020-11-03 14:07:50 +00:00
Jeff Young
6a3c868db5
Don't copy lastDriver when cloning connection.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6018
2020-11-03 14:07:50 +00:00
Jeff Young
c1ecb4257d
Fix error with empty sheet paths.
2020-11-02 18:05:56 +00:00
Michael Kavanagh
20bb3b194f
Eeschema: Display the root sheet name to the user
...
Instead of just `/` denoting the root sheet, use the filename
in preparation for non-hierarchical multi-sheet schematics
2020-11-02 17:50:13 +00:00
Michael Kavanagh
644546cd83
Cleanup PathHumanReadable and remove dead code
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6152
2020-11-02 17:50:13 +00:00
jean-pierre charras
2e92cc7958
ERC: use separate tests for input pins and power input pins.
...
Input pins can be driven by many pin types: output, passive, 3state, I/O
But Power pins can be driven by only power output pins, and cannot
use the same criteria in ERC tests.
2020-11-02 12:41:58 +01:00
Jeff Young
7c505da368
Make sure ERC tests honour the severity settings.
...
(And in particular, IGNORE.)
Fixes https://gitlab.com/kicad/code/kicad/issues/6178
2020-11-01 17:38:24 +00:00
Wayne Stambaugh
042e5956c2
Fix library table dialog tab labels.
2020-11-01 09:13:55 -05:00
Wayne Stambaugh
cf59468de2
Fix library table dialog tab appearance in dark mode.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6236
2020-11-01 08:30:27 -05:00
Marek Roszko
fbcbed5543
Add acceleratedGraphics prompt for eeschema
2020-10-31 17:49:50 -04:00
Marek Roszko
7203a51fec
Fix bad include path
2020-10-31 16:42:24 -04:00
Wayne Stambaugh
3dde4e5616
Eeschema: fix yet another symbol properties dialog layout issue.
...
Stop trying to make a read only wxTextCtrl with a custom font work
for displaying the symbol library identifier and use an ellipsized
wxStaticText control with the standard font instead.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6240
2020-10-31 08:36:59 -04:00
Jeff Young
6cefec64ea
Commit pending changes before quitting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6239
2020-10-31 11:50:11 +00:00
Jeff Young
92d6988f10
Keep pin positions stable when resizing sheet.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6196
2020-10-31 11:49:07 +00:00
Jeff Young
bddc97df30
LibEdit -> SymbolEditor
2020-10-31 10:28:21 +00:00
Jeff Young
0d8789935d
Refactoring. Push editing code to toolset.
2020-10-31 10:28:21 +00:00
Jeff Young
de013ee60a
Selection center is center of visible items.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6188
2020-10-30 23:37:35 +00:00
jean-pierre charras
4314e4dc93
Update French translation and fixes minor I18n issues.
2020-10-30 21:01:15 +01:00
Jeff Young
9065908859
Update SCH_SCREEN's RTree when moving items.
...
Or when modifying geometric shape/properties.
Fixes https://gitlab.com/kicad/code/kicad/issues/5922
2020-10-30 15:26:07 +00:00
Jeff Young
45618327cf
Fix crash bug closing schematic with sheet selected.
2020-10-30 15:26:07 +00:00
Wayne Stambaugh
a1508d2531
Symbol editor: minor symbol properties dialog layout fixes.
2020-10-30 10:49:24 -04:00
Wayne Stambaugh
a5e628a552
Symbol editor: fix missing footprint filter support for derived symbols.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6038
2020-10-30 09:28:54 -04:00
Jeff Young
1d110d5414
Move a couple more dialogs to QuasiModal for syntax help.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5897
2020-10-29 22:55:33 +00:00
jean-pierre charras
5abb61e195
DIALOG_FIELDS_EDITOR_GLOBAL: fix a few minor issues.
2020-10-29 17:27:38 +01:00
Wayne Stambaugh
9101e61c06
Symbol editor, fix saving legacy symbol library bug.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6157
2020-10-29 08:22:38 -04:00
Jeff Young
d26d93b32c
Remove shadow version of autoplace fields variable.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6199
2020-10-28 22:48:23 +00:00
Jeff Young
c9d7bdc340
Hook up AutoplaceFields for sheets.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6197
2020-10-28 22:32:36 +00:00
Wayne Stambaugh
d90d734166
Eeschema: fix symbol rescue bug.
...
Loading the schematic symbol preserves the invalid LIB_ID characters in
the symbol name. Unfortunately, loading the library symbol automatically
fixes the invalid characters so this caused the symbol rescue to not find
library symbols with invalid characters. Replacing the invalid characters
in the schematic symbol name during rescue fixed the issue. This fix
isn't perfect because there is the off chance that replacing the invalid
characters could lead to a name clash in the library resulting in the
incorrect symbol to be rescued.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2319
2020-10-28 09:31:10 -04:00
Jeff Young
a6d4ce2a5c
Finish impl of alternate pins.
...
It appears this got shelved while waiting for the sexpr format to be
firmed up, and then I forgot about it.
Fixes https://gitlab.com/kicad/code/kicad/issues/6189
2020-10-28 13:01:42 +00:00
jean-pierre charras
ceb4b56134
DIALOG_FIELDS_EDITOR_GLOBAL: fix crash due to a missing column used in code.
...
Fix column sizes.
Fixes #6191
https://gitlab.com/kicad/code/kicad/issues/6191
2020-10-28 11:22:52 +01:00
Jon Evans
49fd95f58d
Bus-wire entries can't propagate through bus junctions
...
This fixes strange connectivity issues observed if you manage
to get a bus junction touching a bus-wire entry.
2020-10-27 22:05:35 -04:00
Jon Evans
70c90266a8
Fix crash when loading new schematic with something selected
2020-10-27 22:05:35 -04:00
Jon Evans
31d502735c
Better messages for bus entry conflict ERC
2020-10-27 22:05:35 -04:00
Thomas Pointhuber
2d59bb8156
altium: initial code to insert sheets (but not parse them)
2020-10-27 15:51:57 +01:00
Thomas Pointhuber
3f0edb6f83
altium: introduce workaround until symbols are parsed with their real orientation
2020-10-27 15:51:57 +01:00
Thomas Pointhuber
00af4e123e
altium: improve support for ports, using the knowledge about terminal points
...
Still not perfect, but better than the previous version.
2020-10-27 15:51:57 +01:00
Werni
a7d5d1f091
Add more consts all over the place
2020-10-27 11:03:35 +00:00
Ian McInerney
6bd3b0afa4
Various Coverity fixes
2020-10-27 00:25:08 +00:00
Ian McInerney
31e626f279
Cleanup creation of all our smart pointers
2020-10-26 23:52:44 +00:00
jean-pierre charras
976b7e1c47
Eeschema: Move last netlist code to netlist_exporters folder
2020-10-26 18:40:58 +01:00
Thomas Pointhuber
52d8501563
altium: initial parsing of designator and some parameters
2020-10-26 18:27:29 +01:00
Thomas Pointhuber
52b5e4d0b3
altium: initial code to parse ports. Includes a hack until we know which side to connect to.
...
Fix: https://gitlab.com/kicad/code/kicad/-/issues/6056
2020-10-26 18:27:29 +01:00
Wayne Stambaugh
f7084afb72
Eeschema: fix annotation bug.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6154
2020-10-26 13:01:36 -04:00
Jeff Young
d7ee5fe97f
Apply wxWidgets hack to get saved component tree widths restored.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6036
2020-10-26 15:36:07 +00:00
Marek Roszko
1984581c46
Remove common.h from more headers
2020-10-25 22:29:53 -04:00
Marek Roszko
9de0ff22c1
Rename Mirror template to MIRRORVAL to avoid shadowing
...
I am bad at naming creativity here, but hey, it's unique
2020-10-25 20:44:22 -04:00
Marek Roszko
14c18b7e64
Move ui functions out of common and into ui_common
2020-10-25 20:01:12 -04:00
Marek Roszko
91e5611341
Move dialog_configure_paths.h and dialog_edit_library_tables.h to dialogs folder
2020-10-25 20:01:12 -04:00
Marek Roszko
e49ac45b84
HTML_MESSAGE_BOX is a dialog
2020-10-25 20:01:12 -04:00
Marek Roszko
a785f70ea1
msgpanel is a widget, shove it to the right folder.
2020-10-25 20:01:12 -04:00
Jon Evans
ec11697660
Language update for autostart wires checkbox
2020-10-25 18:37:54 -04:00
Jon Evans
2edd246f36
Use explicit message for multiple drivers ERC
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/3980
2020-10-25 18:30:22 -04:00
Jon Evans
ee08a3488f
Fix missing driver conflict ERC
2020-10-25 18:13:03 -04:00
Jon Evans
0e9efef7aa
Never show footprints in power symbol chooser mode
2020-10-25 17:27:06 -04:00
Jon Evans
48a67e1ff8
Set a few more ERCs to be warnings by default
2020-10-25 16:32:15 -04:00
Jeff Young
2f1e755f66
Update preference panel names.
2020-10-25 19:51:03 +00:00
Jeff Young
4789794e0e
Minor dialog spacing normalization.
2020-10-25 13:38:15 +00:00
Jeff Young
51dff1c822
Live update sheetpath.
...
Also makes it a static text to get rid of the spacing/clipping
problems it has been having.
Fixes https://gitlab.com/kicad/code/kicad/issues/6152
2020-10-25 13:37:40 +00:00
Wayne Stambaugh
189792cd4c
Eeschema: fix sheet properties dialog sheet path bug.
2020-10-25 08:08:10 -04:00
Wayne Stambaugh
15c2181a89
Eeschema: fix sheet properties dialog page number bug.
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6151
2020-10-25 07:32:20 -04:00
jean-pierre charras
d6f91c810f
Fix a few compil and Coverity warnings.
2020-10-25 10:02:07 +01:00
Marek Roszko
e928b2d8fd
Split EDA_UNITS out from common.
2020-10-25 00:02:52 -04:00
Jeff Young
346b7178b7
Repair the way other units are collected when syncing symbol fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6106
2020-10-24 22:39:53 +01:00
Jeff Young
1f21a93b39
Don't require power symbols to be annotated.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6112
2020-10-24 19:46:08 +01:00
Thomas Pointhuber
f34ee00a8b
altium: import power port in all their different shapes
2020-10-24 18:40:54 +02:00
Marek Roszko
1c848622d7
Remove junctions as auto wire targets
...
Fix #6100
2020-10-24 10:09:42 -04:00
Wayne Stambaugh
4ac4cc14ee
Eeschema: fix new sheet page number bug.
...
Msys2 builds on windows still don't support the %z printf specifier so
convert to integer and use %d.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6142
2020-10-24 09:08:56 -04:00
Marek Roszko
81a7afc76e
Use kicad_algo directly rather than common.h
2020-10-24 08:53:11 -04:00
Marek Roszko
77ece552f7
Remove macros.h from files that don't need it
2020-10-24 08:28:02 -04:00
Marek Roszko
c173ea14b7
Quiet MSVC warning about bool OR int
2020-10-24 00:50:37 -04:00
Marek Roszko
1c0700fbc4
Quiet gcc warning about assignment
2020-10-24 00:50:02 -04:00
Marek Roszko
eeac3cb4d5
Nix some more common.h includes
2020-10-24 00:38:25 -04:00
Marek Roszko
304e5faf36
Move wxStringSplit to kicad_string
2020-10-24 00:17:07 -04:00
Seth Hillbrand
b7f115bf5f
Don't write translated strings
...
Even though the translation isn't used, the choice of locale can create
unwanted diffs
2020-10-23 19:53:25 -07:00
Marek Roszko
1d559108c8
Move LOCALE_IO out of common.h
2020-10-23 21:49:42 -04:00
Jon Evans
50cff57b9a
Explicit bools for MS
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6146
2020-10-23 21:35:23 -04:00
Jeff Young
c5a86126d2
Be more clever about making sheet names unique.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6123
2020-10-23 23:55:45 +01:00
jean-pierre charras
db66e16f71
SymbolEditor: Ask to save local edits in schematic on symbol editor window closure
...
Previously, Asking for save, cancel... was made for a symbol coming from lib
but not when the symbol come from the schematic editor.
Fixes #6132
https://gitlab.com/kicad/code/kicad/issues/6132
2020-10-23 17:56:15 +02:00
Thomas Pointhuber
b7c2d64333
altium: Correctly parse multiunit symbols
...
Followup to https://gitlab.com/kicad/code/kicad/-/issues/6055
2020-10-23 17:20:07 +02:00
Thomas Pointhuber
adfc74f93a
altium: Add initial support for multiunit symbols
...
Fix: https://gitlab.com/kicad/code/kicad/-/issues/6055
2020-10-23 17:04:59 +02:00
Thomas Pointhuber
0d3d3e0d7c
altium: parse symbol description, remove dependency on legacy plugin
2020-10-23 17:04:59 +02:00
Thomas Pointhuber
47786fa976
altium: Correctly handle symbol names containing invalid chars
...
Fix: https://gitlab.com/kicad/code/kicad/-/issues/6082
2020-10-23 14:30:29 +02:00
Wayne Stambaugh
d8ffea881e
Improve dialog static sizer box consistency.
...
Remove colons from the end of static sizer box labels from a few dialogs so
they are consistent with all dialogs.
2020-10-22 22:00:04 -04:00
Jon Evans
922304f980
Guard against missing theme in DIALOG_PLOT_SCHEMATIC
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6124
2020-10-22 21:21:27 -04:00
Wayne Stambaugh
ed03ca7ad0
Symbol editor: improve save all behavior for read only libraries.
...
Instead of forcing the user to save modified read only libraries to a
different file name, an info bar is displayed warning the user that read
only libraries need to be saved as a different library. All modified
non-read only libraries are saved as normal.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4668
2020-10-22 07:49:00 -04:00
Jeff Young
d785dae88b
DIALOG_EDIT_COMPONENT_IN_LIB -> DIALOG_LIB_SYMBOL_PROPERTIES.
2020-10-22 10:41:21 +01:00
Jon Evans
7d09681f9e
Improve reporting on NC and global label ERCs
2020-10-21 22:14:04 -04:00
Jon Evans
601a63b63a
Better prioritization for non-driven pin ERC
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1881
2020-10-21 21:47:00 -04:00
Jon Evans
af28634df1
Bring Pin Not Driven ERC to the new system
...
Also reword the error title to be a bit more clear
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5681
2020-10-21 21:35:09 -04:00
Jon Evans
2153a7655b
Try harder not to give a read-only path to save dialog
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5937
2020-10-21 20:55:43 -04:00
Seth Hillbrand
b39fb3374d
Fix fat fingered error
2020-10-21 14:41:14 -07:00
Seth Hillbrand
69d47c90ea
Unify sentences in translation
2020-10-21 12:31:21 -07:00
aris-kimi
d90faa26a5
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6095
2020-10-21 18:35:39 +00:00
Jeff Young
176f461b2c
Fix a corner case of wire merging.
...
We want to look for a junction before merging two touching colinear
segments, but the old code would also check for a junction when
merging two overlapping segments, which is not what you want.
Fixes https://gitlab.com/kicad/code/kicad/issues/5960
2020-10-21 18:51:47 +01:00
Jeff Young
339fa5e0e3
Hack around the mess that we've made of line styles. :(
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5960
2020-10-21 18:51:47 +01:00
Seth Hillbrand
f8a4edb1c9
First pass renaming module to footprint
...
This is mostly in comments and the few remainin text strings that
reference module
2020-10-20 20:49:11 -07:00
Ian McInerney
06bf7943b7
Minor warning fixes
2020-10-21 00:30:50 +01:00
Jeff Young
7a41ff74df
Fix undo of DeMorgan conversion.
2020-10-21 00:04:04 +01:00
Jeff Young
e5089d783d
Remove multi-label entry feature.
...
It was causing problems with surprising behaviour and issues with
allowing spaces in existing labels. We'll work on something better
for 7.0....
Fixes https://gitlab.com/kicad/code/kicad/issues/6073
2020-10-20 22:53:44 +01:00
Jeff Young
e497639320
Don't allow both DeMorgan alternates and general pin alternates.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6087
2020-10-20 22:26:47 +01:00
Jeff Young
83890f8d3a
Move label editors to QuasiModal so the Syntax Help window can be shown.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5437
2020-10-20 22:26:47 +01:00
Seth Hillbrand
661e85d705
Standardize "Key words" to "Keywords"
2020-10-20 13:18:48 -07:00
Seth Hillbrand
2a43b88115
Standardize PostScript capitalizaiton
2020-10-20 13:09:13 -07:00
Seth Hillbrand
316ca120e8
Don't translate spice prefixes or numbers
2020-10-20 12:51:23 -07:00
Seth Hillbrand
4085757aeb
Remove beginning/ending spaces in translations
...
Adding space padding makes translations more difficult by increasing
string counts
2020-10-20 12:08:04 -07:00
Ian McInerney
7c9acc605d
Introduce a new number badge UI element for DRC and ERC reporting
...
This new badge allows for proper UI scaling and will not cut off
the number being displayed.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5734
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6011
2020-10-20 02:35:48 +01:00
Jeff Young
8f67557a65
Separate display and canonical names in Edit Symbol Fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6066
2020-10-19 23:58:07 +01:00
Wayne Stambaugh
c79d6391dd
Eeschema: minor plot dialog layout fixes.
2020-10-19 14:34:43 -04:00
Wayne Stambaugh
8ff51d8899
Eeschema: add schematic sheet page number.
...
The groundwork has now been laid for per sheet instance data. Initially
this only supports sheet page numbers but could be expanded to include
other per sheet instance information.
ADDED: Support for user defined schematic page numbers.
2020-10-19 14:05:45 -04:00
Jeff Young
d0ddc909dc
Handle hierarchical symbols when performing "lib symbol changed" check.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6002
2020-10-19 15:37:47 +01:00
Jeff Young
3100273db1
Don't invalidate itterator by adding markers inside loop.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6002
2020-10-19 15:32:59 +01:00
Jeff Young
725082786e
Move ERC dialog to DRC architecture.
...
This is mainly to remove the annotation nag dialogs in favour of the
HTML links. But it also allows you to see more than a few messages,
and implements a progress reporter architecture if the ERC checks ever
get slow enough to benefit from it.
2020-10-19 15:17:49 +01:00
jean-pierre charras
539ac4c214
Remove a few include<wx/wx.h> in many files that do not actually use this include.
2020-10-19 09:00:50 +02:00
Jeff Young
16d5f95981
Meet irreflexive requirements of std::sort
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6053
2020-10-18 21:03:01 +01:00
Jeff Young
dd53b9c399
Bail on 45º text in pin conflicts map.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5515
2020-10-18 20:28:23 +01:00
Jon Evans
e735d21824
Maximize main editors by default if config is missing
...
Also set default size for other windows to something slightly
larger than it was before
2020-10-18 14:38:55 -04:00
Jon Evans
c388bf0f92
Update default color theme
...
Blue is the new green :)
ADDED: built-in read-only color themes support
Classic theme is still available for those who love it
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1991
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4259
2020-10-18 14:12:54 -04:00
jean-pierre charras
0044c6b48a
Add missing includes
2020-10-18 19:22:15 +02:00
jean-pierre charras
f6b4b66a86
Avoid include wx/wx.h in many files that do not actually use this include.
...
Including wx.h includes the full set of wxWidgets include files, that is not good,
and can create some conflicts with some Windows headers on msys2.
2020-10-18 18:21:34 +02:00
Jeff Young
ebc0d47239
More pinmap spacing adjustments for MSW.
2020-10-18 14:20:36 +01:00
Thomas Pointhuber
b28f397614
altium: fix unsigned overflow inside loop
...
Fix: https://gitlab.com/kicad/code/kicad/-/issues/6044
2020-10-18 15:11:12 +02:00
Jeff Young
9f16b68bde
Better centreing of pin conflict map col labels.
2020-10-18 12:08:16 +01:00
Jeff Young
6ce803b77c
Push/pop move tool even when there's nothing to move.
...
This keeps other tools from having the special-case an empty move.
Fixes https://gitlab.com/kicad/code/kicad/issues/6048
2020-10-18 12:08:15 +01:00
Jeff Young
688a031793
Fix broken logic when updating fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6024
2020-10-18 00:51:58 +01:00
Jeff Young
6dfcfb0177
Rename DIALOG_EDIT_COMPONENT_IN_SCHEMATIC -> DIALOG_SYMBOL_PROPERTIES
2020-10-18 00:26:37 +01:00
Jeff Young
a6166c8ccc
Select just reference number when editing reference field.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6004
2020-10-18 00:26:37 +01:00
Jeff Young
81e1bc9df0
Keep track of driver changes so the view can be updated.
...
Also make renaming of nets a bit more stable.
Fixes https://gitlab.com/kicad/code/kicad/issues/6018
2020-10-17 20:40:05 +01:00
Ian McInerney
229194c76b
Fix flags and remove unicode from string in eeschema dialog
...
* Remove unicode quotes and ellipses from a tooltip string. Our
translation framework can't handle these, and they caused errors
generating the cpp file.
* Remove an assert generated when opening the dialog on 3.1 due to the
wxALIGN_CENTER_VERTICAL and wxEXPAND flags being used together.
* Add a left border to the general static box items so they aren't
squashed against the line.
2020-10-17 15:46:52 +01:00
Thomas Pointhuber
39e55d8559
altium: parse bus-entry
2020-10-17 16:05:47 +02:00
Thomas Pointhuber
5793c899dd
altium: use correct default entry in record
2020-10-17 16:05:47 +02:00
Thomas Pointhuber
034a6bfe0d
altium: parse sheet size and align everyhting inside the sheet
2020-10-17 16:05:47 +02:00
Thomas Pointhuber
1ce215a1f2
altium: parse fonts from sheet record and use them for label styling
2020-10-17 16:05:47 +02:00
Thomas Pointhuber
a6072a40f5
altium: add initial support for labels
2020-10-17 16:05:47 +02:00
Thomas Pointhuber
a981ffe8c7
altium: fix compilation issue due to rebase
2020-10-17 13:45:33 +00:00
Thomas Pointhuber
1400e5cdb9
altium: improve orientation of net label
...
It is interesting, because altium allows text which is upside-down. Of course, KiCad does
not allow this sensless thing.
2020-10-17 13:45:33 +00:00
Thomas Pointhuber
ad93396d35
altium: parse no_erc record
2020-10-17 13:45:33 +00:00
Thomas Pointhuber
79a02d7997
altium: initial version for rounded rectangle (without rounded corners for now)
2020-10-17 13:45:33 +00:00
Thomas Pointhuber
9199d1ff63
altium: fix line style and filling
2020-10-17 13:45:33 +00:00
Thomas Pointhuber
06df80a88d
altium: add arc and line segment, fixup bezier parsing
2020-10-17 13:45:33 +00:00
Thomas Pointhuber
fa8208182a
altium: add support for bezier (symbol only) and polyline
2020-10-17 13:45:33 +00:00
Thomas Pointhuber
19cfd7bd3a
altium: add non working fix for rounding error
2020-10-17 13:45:33 +00:00
Thomas Pointhuber
0b190f02dc
altium: reduce code duplication for unit parsing
2020-10-17 13:45:33 +00:00
Thomas Pointhuber
56a60ffbed
altium: add (emulated) support for polygons
2020-10-17 13:45:33 +00:00
Thomas Pointhuber
b4b8e31177
altium: add support for junction
2020-10-17 13:45:33 +00:00
Thomas Pointhuber
30ea1a274e
altium: add some more pin types, and reverse engineer symbol outer and symbol inner
2020-10-17 13:45:33 +00:00
Thomas Pointhuber
53d90431ea
altium: correctly parse pins
...
TODO: for now, we assume the component is not rotated, simply because this would require me to
write quite a bit of helper methods to handle all those different rotation cases ;)
2020-10-17 13:45:33 +00:00
jean-pierre charras
114f9062f1
EEschema, save correct line style in file when style == DEFAULT.
...
previously, when a graphic line style was set to Default,
the line style saved in file was always SOLID.
This is incorrect for graphic lines
Fixes #6017
https://gitlab.com/kicad/code/kicad/issues/6017
2020-10-17 15:18:14 +02:00
jean-pierre charras
98710e2742
Eeschema, parser: allows using "default" as line style.
...
It is allowed in Eeschema code, so allow it if found in a .kicad_sch file,
just in case.
However it is not yet in use in .kicad_sch files to avoid breaking previous Kicad versions
2020-10-17 12:39:51 +02:00
jean-pierre charras
a9619c051b
Better name for a plot style variable and accessors.
...
Accessors were previously GetType() and SetType(), but this is a bad name:
These names are already widely used in code as accessors for a data type.
We do not set a data type, but a style, so use a better name (GetPlotStyle/SetPlotStyle).
2020-10-17 12:00:43 +02:00
Seth Hillbrand
971eb529f4
Separate strings into full strings
2020-10-16 23:10:47 -07:00
Seth Hillbrand
0d6684bdf0
Freeze GUI as well to prevent wx updates
...
The tree model may get updated by a redraw, so we need to freeze both
the model and the view while updating
Fixes https://gitlab.com/kicad/code/kicad/issues/5872
2020-10-16 08:28:14 -07:00
Marek Roszko
a1c75748a0
Remove GetChars(), a wxWidgets 2.9 compatibility hack
2020-10-15 20:53:25 -04:00
Marek Roszko
a2c3bdec0d
Remove kicad_string.h from netlist_exporter.h
2020-10-15 18:48:53 -04:00
Jeff Young
128910c602
Pass unhandled command events from Symbol Editor move tool.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6015
2020-10-15 18:43:23 +01:00
Jeff Young
445b9df827
Don't output pins to net if parent symbol isn't included on board.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5984
2020-10-15 18:32:52 +01:00
jean-pierre charras
1c5aad1f9e
Hierarchical schematic with subsheets in subdirectory: fix plot filenames.
...
When creating an unique filename to plot a subsheet, the subdirectory name is
used to create the unique filename, but should not be used as a directory,
otherwise the plot file is not created at the right place (and sometimes
cannot be created)
2020-10-15 18:07:00 +02:00
Marek Roszko
bfd5da0159
Add missing include (under some configurations)
2020-10-15 07:34:38 -04:00
Ian McInerney
5f4b0eb0fb
Fix formatting and overzealous renaming for FILL_TYPE
2020-10-15 11:24:49 +01:00
Marek Roszko
1538d737e7
Split out FILL_T to its own header to avoid spreading eda_item everywhere
2020-10-14 21:51:23 -04:00
Marek Roszko
5302f7ce73
Remove kicad_string.h from eda_text.h
2020-10-14 19:18:38 -04:00
Jeff Young
90da5fccbd
Disambiguate backannotation (Update Schematic from PCB) from Cvpcb.
2020-10-14 21:07:10 +01:00
Marek Roszko
12d21e34e2
Remove trigo.h from eda_text.h
2020-10-13 23:37:48 -04:00
Marek Roszko
ad191fda52
Unwrap eda_base_frame from base_screen
2020-10-13 21:52:57 -04:00
Marek Roszko
b2e9f6987d
Split base_struct into eda_item and eda_rect
2020-10-13 21:24:50 -04:00
Marek Roszko
2c86363aa0
Relocate the page_layout includes to a page_layout folder
2020-10-13 20:33:33 -04:00
Jon Evans
d1bdfb7253
Clear selection before adding new lines in immediate mode
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4266
2020-10-13 19:16:48 -04:00
Jon Evans
cb1d416e5a
Use settings keys, not error codes, for ERC/DRC reports
...
Error codes can shift around if the enum ordering is
not maintained, which is more fragile than the settings
key which should never be changed after a new code is
created.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6001
2020-10-13 18:03:07 -04:00
Jeff Young
fd874d8345
Check to see if isolating junction is part of the drag or not.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5960
2020-10-13 13:52:49 +01:00
Jon Evans
7b5d628e4b
Eeschema: fix save-as dispatching from new file
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5937
2020-10-12 20:06:55 -04:00
Michael Kavanagh
5f6d309d36
Eeschema: REMOVED "Update from Symbol Library"
...
This is effectively duplicated by "Update Symbol(s) from Library".
Fixes https://gitlab.com/kicad/code/kicad/issues/5217
2020-10-12 22:44:53 +00:00
Michael Kavanagh
8930e48cf3
Cleanup dead code
...
Remove leftovers from e4bc1eb3bf
2020-10-12 22:44:53 +00:00
Michael Kavanagh
c40483d18a
Cleanup: Move KiCad files into plugins folder
2020-10-12 16:36:08 +00:00
Jeff Young
0efe073dec
Add wires between selected wires and unselected junctions when dragging.
...
Also fixes a bug where the auto-start-wire stuff was messing up the seleciton
when the selection tool wasn't at the top of the tool stack.
Fixes https://gitlab.com/kicad/code/kicad/issues/5960
2020-10-12 11:46:08 +01:00
Jeff Young
fbb20d08cd
Don't allow netclass assignment to auto-generated net-names.
...
They can change the next time they're generated so it's just asking
for heartache.
Fixes https://gitlab.com/kicad/code/kicad/issues/5972
2020-10-12 00:30:18 +01:00
Marek Roszko
03074ae6ed
Kick the selection tool to activate (and thus update cursors) on exiting some picker tools
2020-10-11 13:12:29 -04:00
PJM
91db6a770c
Eeschema: Add missing tooltips to left toolbar buttons
...
CHANGED: The button in the left toolbar for hiding/showing hidden
pins, and the button for forcing/relaxing H&V only wire mode had
no tooltips. This MR adds them.
2020-10-11 13:55:36 +00:00
Marek Roszko
558f4b4b51
Add new place cursor, fix cursor hotpoints again
2020-10-10 23:45:21 -04:00
Marek Roszko
310786333d
Add missing cursors for bus, graphic lines, and hier labels
...
Fix #5949
2020-10-10 18:25:44 -04:00
Mark Roszko
a8bd0a9b84
Handle Windows manifests ourselves and add dpi awareness option
2020-10-10 19:08:23 +00:00
Michael Kavanagh
b2124a34dc
Add grid properties context menu to grid toolbar
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5663
2020-10-10 14:44:03 +00:00
Ian McInerney
5aa796b5fe
Cleanup compiler warnings
2020-10-10 15:24:35 +01:00
Jon Evans
1df35145b5
Not all items are drivers
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5946
2020-10-10 09:16:31 -04:00
Franck Jullien
fc93a04751
eeschema: iref: use GetParentLabel instead of GetParent
2020-10-09 02:37:51 +00:00
Jon Evans
61f731aa1d
Fix disambiguation for vector buses with different ranges
...
Previously disambiguation was looking for exact matches,
but vector buses are permitted to have different ranges and
still participate in merging, so they need to be disambiguated.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5925
2020-10-08 22:26:24 -04:00
Marek Roszko
bd30a4a406
Add selection lasso and window cursors
2020-10-08 21:25:21 -04:00
Jon Evans
8f4fba4c67
Don't deallocate absorbed SGs anymore
...
Now there is some code depending on access to them
outside the context of connectivity calculation...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5928
2020-10-08 21:24:35 -04:00
Marek Roszko
f238d05ead
Add COMPONENT cursor
2020-10-08 20:52:58 -04:00
Marek Roszko
6cf4016a64
Add net and global label cursors
2020-10-08 20:52:58 -04:00
Jeff Young
fd22fe8e37
Show preview item in drawing tool before mouse is moved.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5922
2020-10-08 19:56:09 +01:00
Jeff Young
4095edda07
Add Properties support to Junction and Bus Entry tools.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5907
2020-10-08 18:11:06 +01:00
Ian McInerney
2b839c6c9c
Ensure command events are passed when placing junctions
...
We only handle specific command events in the handler, so we
must pass the rest to allow other tools to work.
Fixes https://gitlab.com/kicad/code/kicad/issues/5922
2020-10-08 17:58:06 +01:00
Marek Roszko
7e974e5ccc
Use the snapped cursor position used for detection for the wire tool autostart
...
Fixes #5902
2020-10-07 23:57:26 -04:00
Marek Roszko
f5e0754f65
Use the setCursor lambda pattern and fix up the initial cursor states
2020-10-07 23:26:14 -04:00
Mark Roszko
d9485129c8
Implement more context specific cursors using both stock and custom cursors.
2020-10-08 00:50:28 +00:00
Jeff Young
809f4c2ffb
Finish single-click-place drawing tool on double-click.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5907
2020-10-07 18:30:55 +01:00
Jeff Young
4565631728
Finish moving eeschema assigned netclasses to sheet-path-relative.
...
Also adds code for the case where a new label is created on a net
with an existing netclass assignment.
Fixes https://gitlab.com/kicad/code/kicad/issues/5886
2020-10-07 16:31:55 +01:00
Wayne Stambaugh
5127d6c772
Eeschema: add ERC check for library symbol issues.
...
ADDED: ERC check for library symbols that have changed since they were
added to the schematic or have broken symbol library links.
2020-10-07 09:15:31 -04:00
Seth Hillbrand
504f57811a
Remove a hard-coded parameter
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5373
2020-10-06 14:26:22 -07:00
Seth Hillbrand
8c367cce8d
Separate ki_fp_filters by spaces
...
Multiple footprint filters will no be separated by spaces for easier
parsing as an array
2020-10-06 14:26:22 -07:00
Michael Kavanagh
006e383f2a
Move sch_text help into markdown file
2020-10-06 17:18:35 +00:00
Jeff Young
30c2ca67d9
Fix typo.
2020-10-06 14:23:10 +01:00
Jeff Young
e9d372f4b7
Allow spaces in sheet filenames.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5736
2020-10-06 14:21:18 +01:00
Jon Evans
76bfa47a77
Allow creating new projects when doing a Save As in eeschema
2020-10-05 22:36:26 -04:00
Ian McInerney
43c14face0
Switch to showing metric/imperial units in comboboxes and menus
...
This will always show 1 unit from each system, with the primary unit
being the current frame unit and the secondary unit being the
most recent unit used from the other system. These are saved in
the settings, so they are saved between runs.
2020-10-05 20:26:33 +01:00
Michael Kavanagh
1416280662
Cleanup: Move Eagle files into plugins folder
2020-10-05 14:19:07 +00:00
Jeff Young
63a0f537d8
Performance enhancement: check hierarchy validity only when necessary.
2020-10-05 13:49:29 +01:00
Jeff Young
7a7de027a7
Fix order of operations for setting underline.
2020-10-05 12:32:47 +01:00
Jeff Young
c9096c7168
Re-enable selection of intersheet references.
...
Un-modified roll-overs and clicks still produce hypertext action, but
modified clicks and drag-selects will select.
2020-10-05 11:55:33 +01:00
Mark Roszko
a28a0e14ba
Fix conversion warnings
2020-10-05 10:41:14 +00:00
Jon Evans
e27786de2d
Fix double call of OnPgmExit
...
Also fix bad filename being passed to pcbnew when starting
from a blank schematic in standalone mode
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5786
2020-10-04 18:39:33 -04:00
Ian McInerney
6c2433fed6
eeschema: Fix nullptr reference in intersheet references
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5881
2020-10-04 22:28:35 +01:00
Jon Evans
bdb18022c0
Flag all dangling labels, not just isolated ones
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1788
2020-10-04 17:13:42 -04:00
Ian McInerney
8c09f28b28
libedit: Fix dialog spacing
2020-10-04 17:53:55 +01:00
Ian McInerney
8b0fb9f4cf
Remove units and polar settings from the preferences panels
...
These options are already available in menus, toolbars and hotkeys,
so having them in the preferences pane is more trouble than it is
worth.
2020-10-04 17:53:55 +01:00
Ian McInerney
122bd7ca7c
Make the statubar aware of mils units
...
Switch Eeschema to use the built-in printing routines
because its precisions are close to those and it is
cleaner.
Give mils a precision of 2 decimal places to match
the precision shown in inches.
2020-10-04 17:53:55 +01:00
Ian McInerney
b1bd1f2a97
Introduce new action to switch to mils as a unit
2020-10-04 17:53:55 +01:00
Jeff Young
44580acee2
Clean up some compiler warnings.
2020-10-03 22:55:34 +01:00
Mikolaj Wielgus
d14761bee6
Fix inches being sometimes used instead of mils
2020-10-03 20:06:56 +00:00
Mikolaj Wielgus
400c15b8eb
Add mils to units, remove useMils variables
2020-10-03 20:06:56 +00:00
Marek Roszko
676f3221cc
Fix symbol editor glitches due to autostart trying to start
2020-10-03 15:47:08 -04:00
Marek Roszko
0b2b8b150d
Use the event position always instead of the view cursor position
...
Fix #5850
2020-10-03 15:20:32 -04:00
Ian McInerney
454c4f1783
Minor fixup to intersheet reference files
2020-10-03 19:09:18 +01:00
jean-pierre charras
0b23cb7dbb
more cleanup about removing useless include
2020-10-03 15:26:03 +02:00
jean-pierre charras
e76736b7bf
Fix a few Coverity warnings
2020-10-03 12:47:41 +02:00
jean-pierre charras
bda275de46
more cleanup about removing useless include
2020-10-03 11:48:16 +02:00
jean-pierre charras
b38cef409b
Rename CopyFile() to KiCopyFile() to avoid name colliding with a windows header.
...
Using CopyFile() that can collide with a windows header create hard to
understand errors, including link errors.
Renaming this function avoids these strange errors.
2020-10-03 10:08:21 +02:00
Roberto Fernandez Bautista
ab18c8e219
eeschema: Add "All supported formats" drop-down to the "Import Non Kicad Schematic" file dialog
2020-10-03 02:19:13 +00:00
Marek Roszko
b0ffbcaba1
Fix #5850
2020-10-03 02:10:56 +00:00