jean-pierre charras
7856061cf0
Fix a few wxWidget asserts related to not existing block operations from mouse drag command.
...
block rotate and block mirror are not implemented in HandleBlockPlace.
(only available from context menu)
Fixes: lp:1847554
https://bugs.launchpad.net/kicad/+bug/1847554
2019-10-10 10:07:15 +02:00
jean-pierre charras
0210e414d2
Fp editor, DIALOG_FOOTPRINT_FP_EDITOR: fix a very annoying issue: the value field was copuled to the fp name. Unlike schematic symbols, the value field and the footprint name are 2 different fields. So coupling these fields in the DIALOG_FOOTPRINT_FP_EDITOR dialog created serious issues.
...
Fixes: lp:1846533
https://bugs.launchpad.net/kicad/+bug/1846533
2019-10-09 18:58:23 +02:00
jean-pierre charras
41231e8ae2
Gerber file generation: fix incorrect aperFunction attribute for graphic items on edge cut layer.
...
Was NonConductor. Must be Profile.
From master branch.
2019-10-09 16:02:45 +02:00
jean-pierre charras
ba2e34682e
Gerbview: enhancement: show attributes for polygons (Regions in Gerber dialect) that have no DCode
...
This change is needed to follow current specifications in Gerber X2
2019-10-08 10:25:25 +02:00
jean-pierre charras
b234ff9234
Eeschema: fix issues with pin shapes related to clock input pin shapes.
...
Fixes from master, commit eaea03217:
* Fix not drawn shapes for clock low, inverted clock and broken shape for falling edge clock
* Especially, shape for falling edge clock was a not existing shape, therefore useless.
* now falling edge clock and clock low shape are similar.
2019-10-08 10:11:56 +02:00
Ian McInerney
3442cc3d1a
pcbnew: Don't reset router settings when breaking a track
...
Calling Init() in an action routine will reset the router
settings to the state they were in when first starting pcbnew.
The Init() function is automatically called when the tool is created.
Fixes: lp:1843810
* https://bugs.launchpad.net/kicad/+bug/1843810
2019-10-07 16:10:22 -04:00
Ian McInerney
e618e34c94
pcbnew: Clean up extension handling in graphics plugins
...
* Fix wildcard display in the file selector dialog (on GTK
it would show the regex to the user)
* Move the file extension comparison into a common function
(cherry picked from commit b33c3a5ad8
)
2019-10-04 16:01:15 -04:00
Adam Wolf
105c3b0a4c
Add additional ngspice codemodel path for launching from standalone eeschema on macOS.
...
(cherry picked from commit c7c49cee5a
)
2019-10-04 14:33:23 -04:00
Ian McInerney
69d0446019
Update pleditor path for run from build directory
...
(cherry picked from commit 3a2dbf7786
)
2019-10-04 07:58:17 -04:00
jean-pierre charras
078045f73b
Gerbview: fix incorrect canvas type saving after closing Gerbview.
...
Was due to the fact the canvas type was now saved into m_canvasType when opening Gerbview.
2019-10-02 18:30:36 +02:00
jean-pierre charras
78af1daa2e
Fix an issue in DIALOG_NETLIST: if the netlist filename does not exist, one cannot always modify the entered name.
...
(from master branch)
2019-09-30 19:43:25 +02:00
jean-pierre charras
0bd0d57a81
Cairo print, on GTK: use a better DPI definition to avoid artifacts rendering (GTK specific) Previously, a 600 DPI was used to set device scale (can create minor visible rounding issues). Using now 4800 DPI to reduce these rounding artifacts.
...
Fixes: lp:1845229
https://bugs.launchpad.net/kicad/+bug/1845229
2019-09-27 11:17:58 +02:00
jean-pierre charras
9dd5b6ce37
simulator: plot curves: fix incorrect draw area limits calculation when zooming.
...
Fixes: lp:1674132
https://bugs.launchpad.net/kicad/+bug/1674132
2019-09-26 16:30:28 +02:00
Seth Hillbrand
d862cdaa72
pcbnew: properly close tags when handling bad poly
...
The parenthesis depth is 2 when the polygon isn't closed. This
shouldn't happen but we have the fall-through to handle odd cases
Fixes: lp:1844872
* https://bugs.launchpad.net/kicad/+bug/1844872
2019-09-21 09:25:16 -07:00
Seth Hillbrand
4f57de9688
connectivity: Use pad anchor for connections
...
The pad should use its anchor point rather than the geometrical center
of the pad for connections.
2019-09-19 13:25:26 -07:00
Seth Hillbrand
92b6e05909
connectivity: Check all anchors for connection
...
With pads, we should check available anchor points for each connection,
increasing probability of finding connection to match fill algorithm
Fixes: lp:1844661
* https://bugs.launchpad.net/kicad/+bug/1844661
(cherry picked from commit b7128639f8
)
2019-09-19 12:46:03 -07:00
Ian McInerney
2bd0bae2f7
Remove unneeded wxWidgets version checks in the code
...
Now that the minimum version is 3.0.0, we don't need to actually
check if the version is greater than 3.0.0 inside the code.
(cherry picked from commit a37d8f2859
)
2019-09-18 14:27:30 -04:00
Wayne Stambaugh
69b5d24f28
Eeschema: do not save legacy symbol libraries in schematic file.
...
Fixes lp:1843473
https://bugs.launchpad.net/kicad/+bug/1843473
(cherry picked from commit 7cf42bb308
)
2019-09-18 14:24:20 -04:00
Wayne Stambaugh
e5dcb9d9da
Eeschema: improve error message when writing cache library.
...
Remove duplicate missing symbol names from the extended error message.
Fixes lp:1842452
https://bugs.launchpad.net/kicad/+bug/1842452
(cherry picked from commit 18667377f7
)
2019-09-13 15:58:37 -04:00
jean-pierre charras
4db8638f7e
PANEL_SETUP_NETCLASSES: fix not working (immediately closed) wxChoice widgets to select a filter This happens with wxWidgets 3.0.4 on Windows and is a side effect of a call to Layout(). The fix just calls Layout() only when needed.
...
Fixes: lp:1843594
https://bugs.launchpad.net/kicad/+bug/1843594
2019-09-13 11:53:03 +02:00
Jeff Young
cec885daf9
Partial cherry-pick of f1790c24e5
.
...
Fixes: lp:1842199
* https://bugs.launchpad.net/kicad/+bug/1842199
2019-09-12 22:15:36 +01:00
Michal Jahelka
90fbf27114
c3d_render_ogl_legacy.cpp: initialize m_Emissive member of SMATERIAL to be sure it is set to 0, 0, 0
2019-09-10 17:46:35 +02:00
Jeff Young
f1436cec9b
Restore PointCloserThan() behaviour to really be "closer than".
...
Change calls which really want it to be "closer than or equal" to
distance + 1.
Fixes: lp:1843329
* https://bugs.launchpad.net/kicad/+bug/1843329
(cherry picked from commit 25fa2131d2
)
2019-09-10 12:57:52 +01:00
Jeff Young
cf968cb6b5
Performance enhancement.
2019-09-09 23:22:29 +01:00
Jeff Young
2278f40051
Fix zero failure in SEG::PointCloserThan().
...
Fixes: lp:1843329
* https://bugs.launchpad.net/kicad/+bug/1843329
2019-09-09 23:22:29 +01:00
Ian McInerney
18a76d3a87
Manually put the UNIT_BINDER text on the primary selection clipboard
...
The OnKillFocus handler of the UNIT_BINDER replaces the text in the
control with the evaluated string, which removes the selection. To
get the original text on the primary selection clipboard, we must
add it ourselves.
Fixes: lp:1794623
* https://bugs.launchpad.net/kicad/+bug/1794623
2019-09-09 09:02:23 -07:00
Jeff Young
6a65461ec7
Replace buggy code in TestSegmentHit() with call to SEG::PointCloserThan()
...
Fixes: lp:1843101
* https://bugs.launchpad.net/kicad/+bug/1843101
(cherry picked from commit 6f0d8c3eac
)
2019-09-08 12:40:33 +01:00
Jeff Young
a5a0a7c4f3
Fix bug with high-frequency plots.
...
Fixes: lp:1839712
* https://bugs.launchpad.net/kicad/+bug/1839712
(cherry picked from commit 2ac270ce8e
)
2019-09-08 01:12:33 +01:00
Jeff Young
f1e6f8042c
Check for dup layer names in the GUI, not in the internals.
...
Doing so in the internals keeps users from being able to swap layer
names as the dialog does each layer name change individually.
Fixes: lp:1842665
* https://bugs.launchpad.net/kicad/+bug/1842665
(cherry picked from commit f491b7fff7
)
2019-09-07 23:57:49 +01:00
Jeff Young
848873d87e
Add some protection against newlines sneaking into the file.
...
Fixes: lp:1842943
* https://bugs.launchpad.net/kicad/+bug/1842943
2019-09-07 02:32:56 +01:00
Jeff Young
75bb864237
Workaround wxWidgets inability to find the default PDF viewer.
...
Fixes: lp:1843061
* https://bugs.launchpad.net/kicad/+bug/1843061
(cherry picked from commit d55f4d05b4
)
2019-09-07 00:07:06 +01:00
Ian McInerney
d5275b16aa
eeschema: Find the closest line end to the mouse when grabbing
...
Fixes: lp:1842175
* https://bugs.launchpad.net/kicad/+bug/1842175
2019-09-06 14:16:56 -07:00
Seth Hillbrand
15d1b6cef0
eeschema: Handle broken spin style value
...
The spin style is stored as a numeric and can be corrupted. We handle
this by triggering assertions for debugging the bad value while
resetting to default if we have non-valid spin values that are outside
the array.
Fixes: lp:1843091
* https://bugs.launchpad.net/kicad/+bug/1843091
(cherry picked from commit c3226653cc
)
2019-09-06 13:18:34 -07:00
Wayne Stambaugh
6d4dd3e17a
Pcbnew: fix size of graphics import warning dialog.
...
Use the HTML_MESSAGE_BOX window to present the warning messages rather
than wxMessageBox which would overflow the display when there were a lot
of graphic items that could not be parsed.
Fixes lp:1839565
https://bugs.launchpad.net/kicad/+bug/1839565
(cherry picked from commit 24454f5105
)
2019-09-06 14:59:40 -04:00
Ian McInerney
649c22a34e
wxWidgets compatibility fixes
...
* Remove unneeded check
* Fix WX_GRID since upstream renamed a variable in 3.1.3
(cherry picked from commit 8d86d94a4d
)
2019-09-06 08:48:03 -04:00
Jeff Young
8d04d39036
Cherry-pick of https://git.launchpad.net/kicad/patch/?id=c03535343c67c17ddf0ac18621743d9cf762eb05
...
Fixes: lp:1842652
* https://bugs.launchpad.net/kicad/+bug/1842652
2019-09-04 20:08:39 +01:00
Jeff Young
0e90c719b0
Update description in footprint tree when it's edited.
...
Fixes: lp:1842660
* https://bugs.launchpad.net/kicad/+bug/1842660
(cherry picked from commit 6688e80131
)
2019-09-04 17:24:17 +01:00
jean-pierre charras
a79526cad8
Footprint viewers: force cairo canvas instead of legacy canvas when the legacy canvas is selected in the board editor.
...
Legacy canvas does not work in footprint preview panel and does not work fine in footprint viewer frame.
Fixes: lp:1842483
https://bugs.launchpad.net/kicad/+bug/1842483
2019-09-04 16:00:54 +02:00
jean-pierre charras
d05d8b6100
Pcbnew: Fix incorrect canvas type saved in config, when the type is legacy canvas.
2019-09-04 11:22:55 +02:00
Jeff Young
9856867954
Correct tooltip for Footprint Filter icon on Cvpcb toolbar.
...
Fixes: lp:1842477
* https://bugs.launchpad.net/kicad/+bug/1842477
2019-09-03 19:46:39 +01:00
Ian McInerney
19064b680e
Make the extension check for graphics import case insensitive
...
The regex for the file extension that matches against all case
possibilities is only built on Linux.
Fixes: lp:1842180
* https://bugs.launchpad.net/kicad/+bug/1842180
2019-09-02 10:03:39 +02:00
jean-pierre charras
95265c765b
Pcbnew, DIALOG_TEXT_PROPERTIES: make lines thickness editable when editing a dimension.
...
From Master branch (commit 762dabd7
)
Fixes: lp:1841797
https://bugs.launchpad.net/kicad/+bug/1841797
2019-09-02 10:03:39 +02:00
Jeff Young
1ed8912f57
Workaround an issue where a throw terminates (even when there's a catch for it).
...
You can trigger it before this fix by running Cvpcb when a .kicad_mod file is
incorrectly set as "Legacy" in your footprint table.
(cherry picked from commit e269b5d1b9
)
2019-09-01 12:37:58 +01:00
Jeff Young
82a0eb4413
Use Move() instead of SetPosition() so that the second pt gets updated too.
...
Fixes: lp:1841989
* https://bugs.launchpad.net/kicad/+bug/1841989
(cherry picked from commit 315a99e0fe
)
2019-08-30 23:32:54 +01:00
Jeff Young
be7215402b
Partial cherry-pick of 79d062aefc
.
2019-08-30 13:47:39 +01:00
Seth Hillbrand
4500b064d8
Handle active layer overloading
...
Setting the active layer should be tied to the events that are triggered
by the layer change and overloaded for each frame. This ties the hotkey
back to these events.
Note: In the 5.1 cherry-pick this also adds the missing hotkey to
footprint editor
Fixes: lp:1838244
* https://bugs.launchpad.net/kicad/+bug/1838244
(cherry picked from commit 494d0de9b8
)
2019-08-28 05:57:48 -07:00
jean-pierre charras
93d191d7c9
fix compil error
2019-08-28 10:05:25 +02:00
jean-pierre charras
1607ceaf3e
Eeschema, symbol tree selector: make the selected lib and symbol readable.
...
Previously, the background was highlighted, but not the text.
On Windows, the text was unreadable, until it was selected.
From Master, commit 34e00bdb
.
2019-08-28 09:34:46 +02:00
Jeff Young
5b24ea9dd9
Clearance should be in mils, not inches.
...
Fixes: lp:1841360
* https://bugs.launchpad.net/kicad/+bug/1841360
(cherry picked from commit 7c85dc6cd7
)
2019-08-27 21:15:54 +01:00
Jeff Young
c879dcaf7d
Sort pins by number when grouping by name.
...
Fixes: lp:1828648
* https://bugs.launchpad.net/kicad/+bug/1828648
(cherry picked from commit 97212acecb
)
2019-08-27 21:15:17 +01:00