haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
12,759 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

3419 Commits

Author SHA1 Message Date
Wayne Stambaugh a1acec5f13 Revert broken hotkey fix. 
The hotkey fix committed in 53b1ec81 broke non-us keyboards.  Change the
hotkey help hotkey from '?' to Ctrl+F1 to prevent the hotkey list dialog
from being shown when placing a bus wire junction in Eeschema and when
changing the track posture in Pcbnew.  This is still broken in the GAL
framework.
 2018-04-14 08:24:25 -04:00
Jeff Young 2a419156e0 Don't try to check uncheckable menu items. 
When updating toolbars make sure the events are coming from the
toolbar in question (and not the menus which share the same ID).

Fixes: lp:1763563
* https://bugs.launchpad.net/kicad/+bug/1763563
 2018-04-13 21:42:31 +01:00
Wayne Stambaugh 81843c37a4 Organize trace debugging code for ease of maintenance. 2018-04-13 09:59:01 -04:00
Maciej Suminski 0e151687e3 Fixed a typo 2018-04-13 14:24:57 +02:00
Maciej Suminski a41b2d6803 Fix names of added aliases 2018-04-13 14:24:57 +02:00
Maciej Suminski b907fb856d Fix names of libraries added to symbol/footprint library tables 2018-04-13 14:24:57 +02:00
Maciej Suminski 3f734eb1b5 Improved validation of library and entry names 
Symbol/footprint library and entry have the same set of forbidden
characters with a single exception, space character. To accommodate for
this difference, LIB_ID validation and fix methods have been extended to
specify the LIB_ID type that is checked (schematic/board).

LIB_ID::HasIllegalChars() and LIB_ID::FixIllegalChars() had two different
sets of characters treated as invalid in LIB_IDs. The set has been
factored out to another function to avoid duplication.
 2018-04-13 14:24:57 +02:00
Maciej Suminski 862fb430e7 eeschema: Fixed setting unit condition in the component properties dialog 2018-04-13 14:24:57 +02:00
Maciej Suminski 58c27398cb Eagle SCH import: improved implicit connections resolution 
Nets assigned by power pins are weak, meaning they are valid
as long as there is nothing else attached to such pins. This patch
checks whether there are other wires or pins attached to a power pin
before placing a global net label.

Fixes: lp:1755191
* https://bugs.launchpad.net/kicad/+bug/1755191
 2018-04-12 18:12:22 +02:00
Jeff Young 5ef715f3d3 Scan all items when looking for the weak reference. 
... not just those directly in the draw list.

Fixes: lp:1747037
* https://bugs.launchpad.net/kicad/+bug/1747037
 2018-04-09 21:19:11 +01:00
Maciej Suminski 4b0d477c76 Symbol Editor: handle delete hotkey in block edit mode 2018-04-09 14:04:06 +02:00
Maciej Suminski 9bd6d5e97c Fix mirror X/Y hotkeys in the Symbol Editor 
Fixes: lp:1762136
* https://bugs.launchpad.net/kicad/+bug/1762136
 2018-04-09 13:40:42 +02:00
Carsten Schoenert a11714b1a4 fix misspelled 'an other' -> 'another' 2018-04-08 13:24:37 -04:00
Carsten Schoenert 1f32f7c55b fix misspelled 'allows to' -> 'allows one to' 2018-04-08 13:24:18 -04:00
Maciej Suminski cb2c447c23 Spice Simulator: add close buttons to plot tabs 
Fixes: lp:1761902
* https://bugs.launchpad.net/kicad/+bug/1761902
 2018-04-07 22:53:50 +02:00
Jeff Young baef22df9a Fix memory leak and push menu change to other apps. 
Fixes: lp:1761848
* https://bugs.launchpad.net/kicad/+bug/1761848
 2018-04-07 14:14:55 +01:00
Jeff Young 0bd5cc4470 Borrow LTSpice's unconnected net nomenclature. 
Using an unqualified "?" results in all the unconnected pins
being connected to each other.

Fixes: lp:1720619
* https://bugs.launchpad.net/kicad/+bug/1720619
 2018-04-07 11:01:56 +01:00
Maciej Suminski e7ed415930 Eagle SCH import: handle implicit connections 
Each named power input pin in Eagle creates an implicit connection to a
net with the name of the pin (e.g. GND, VCC). It is also done for the
units (gates in Eagle nomenclature) that have not been instantiated in
the schematics.

To emulate this behaviour in KiCad:
- Placed components are checked for power input pins, so they will have
global net labels attached to create the described implicit connections.
- As the components are placed, the remaining units of the symbol are
checked for power inputs to see if they need to be instantiated together
with global net labels.

Fixes: lp:1755191
* https://bugs.launchpad.net/kicad/+bug/1755191
 2018-04-06 16:20:59 +02:00
Maciej Suminski 78c9b34b5d Eagle SCH import: moved sheet bbox calculation to a function 2018-04-06 16:02:58 +02:00
Maciej Suminski 9ee698bbcd Eagle SCH import: save the imported library file once the library section is processed 
It is required to access symbol data in later import stages.
 2018-04-06 16:02:18 +02:00
Jeff Young 591a303777 Make ERC options dialog clearer. 
Fixes: lp:1667600
* https://bugs.launchpad.net/kicad/+bug/1667600
 2018-04-06 14:51:09 +01:00
Jeff Young 611d5a0dc4 Standardize "assign footprints" terminology. 
Fixes: lp:1760867
* https://bugs.launchpad.net/kicad/+bug/1760867
 2018-04-06 11:26:59 +01:00
Seth Hillbrand d1af5210e0 Libedit: Fix a few places where item could be NULL 
Fixes: lp:1761058
* https://bugs.launchpad.net/kicad/+bug/1761058
 2018-04-04 10:20:15 -07:00
Wayne Stambaugh 696ff81dc7 Load correct schematic page layout description file in stand alone mode. 
Fixes lp:1678849

https://bugs.launchpad.net/kicad/+bug/1678849
 2018-04-04 10:18:12 -04:00
Jeff Young df43f071e1 Keep track of open sockets and dispose of them in d'tor. 
Fixes: lp:1760936
* https://bugs.launchpad.net/kicad/+bug/1760936
 2018-04-04 12:02:40 +01:00
Maciej Suminski 71bf488507 Eagle SCH importer: fixed open-collector pin type, simplified pin direction matching 2018-04-03 14:26:15 +02:00
Maciej Suminski 6d06ed3579 Eagle SCH importer: minor fixes 
- set correct reference for components
- handle "pwr" direction for pins
- discarded a redundant variable
 2018-04-03 14:26:15 +02:00
Maciej Suminski dd56f16776 Fix symbol editor crash when modifying fields while a field is selected 
Field Editor dialog calls LIB_EDIT::SetFields() that deletes the old
LIB_FIELD objects and creates new ones. If any of the old LIB_FIELD
objects had been selected before invoking the dialog, then one of the
update UI event handlers will crash trying to access the object.
 2018-04-02 17:51:11 +02:00
jean-pierre charras 0171547154 Context menu: use same message for Zoom and Grid in Legacy mode and GAL mode. 
a minor cosmetic other fix in Eeschema, edit submenu.
 2018-04-01 21:09:52 +02:00
jean-pierre charras e750417fa0 Eeschema: fix many wxASSERT when trying to open menus from the main menubar. 
This is due to the fact the same ID was used for menuitems in menubar,
and tools in toobars.
Especially, some items were not compatible due to different attributes.

Windows does not accept the same ID for 2 items inside the same frame.
It creates issues (items not shown, Asserts, ...)
 2018-04-01 20:58:27 +02:00
Seth Hillbrand 62fe78f08c Eeschema: Simplify GetItem 
Avoids calling HitTest on each item when it is not needed
 2018-03-30 17:26:34 -07:00
Seth Hillbrand 7c70e969db Prevent warning when renaming sheet name 
Renaming a subsheet but keeping the filename should not present a
warning to the user.  The was triggered due to comparing a
fully-qualified filename to a relative filename.

Fixes: lp:1744475
* https://bugs.launchpad.net/kicad/+bug/1744475
 2018-03-29 13:51:02 -07:00
Maciej Suminski eb9099238a Eagle SCH import: Improved net label placement algorithm 
Eagle support net labels that are naming wires not directly connected to
the labels. In KiCad it is not possible, therefore such detached net
labels need to be moved, so they touch the corresponding wire.

The initial algorithm did not take into account that a moved net label
might be placed on a wire crossing, effectively shorting two nets. This
commit improves the placement algorithm by avoiding the wire crossing
points when placing a label.

Fixes: lp:1748502
* https://bugs.launchpad.net/kicad/+bug/1748502
 2018-03-29 12:16:11 +02:00
Maciej Suminski 88915f7940 SCH_EAGLE_PLUGIN::addBusEntries(): prevent operating on deleted objects 2018-03-29 12:11:36 +02:00
Maciej Suminski 99e79c077a Eagle SCH import: Code formatting 2018-03-29 12:11:35 +02:00
Jeff Young ba49bd0386 Allow XLS netlist exporters to specify a file extension. 
Fixes: lp:1591779
* https://bugs.launchpad.net/kicad/+bug/1591779
 2018-03-26 00:51:54 +01:00
Jeff Young f4ce8766e3 Implement shared FOOTPRINT_LIST. 
While we already cache the loaded footprint files, parsing said files
into the list is also time-intensive.  Since the FOOTPRINT_LIST is
already hash-stamped against the current timestamps of the files that
make up the list, sharing a single copy of the list is quite
straight-forward.
 2018-03-25 19:21:28 +01:00
Jeff Young b24b0d5dfe Dialog-ize CvPcb and implement proper Save. 
Save now goes to disk (instead of just the in-memory schemaitc),
and the UI attempts to make this clear.
 2018-03-25 19:21:27 +01:00
Wayne Stambaugh 8d8c422a19 Add zoom to selection menu entry to all editors. 
Fixes lp:1753339

https://bugs.launchpad.net/kicad/+bug/1753339
 2018-03-25 12:34:19 -04:00
Jon Evans bfe9eff878 Don't use wxTE_RICH in label editing dialog 
Fixes: lp:1742296
* https://bugs.launchpad.net/kicad/+bug/1742296
 2018-03-24 22:31:34 -04:00
Marco Ciampa 4594fedc2c Small typo in menubar 2018-03-24 10:36:40 -04:00
Jeff Young d2d0660647 Open viewer even when FPID is invalid. 
Just show an empty viewer.
 2018-03-23 12:46:17 +00:00
Jeff Young a0364a1137 Don't make user click twice to toggle checkbox in wxGrid. 2018-03-23 12:46:17 +00:00
Maciej Suminski 434b385a95 Eagle SCH importer: prepend # to references of symbols without assigned footprints 
With hash character starting the reference value, schematic components
are considered as virtual and therefore netlist updater do not warn about
an unsigned footprint anymore. This approach is useful to handle logos,
frames or other virtual Eagle components.

Fixes: lp:1756281
* https://bugs.launchpad.net/kicad/+bug/1756281
 2018-03-22 18:20:02 +01:00
Maciej Suminski e9537953cd Eagle SCH importer: reduced code duplication for importing labels 2018-03-22 18:20:02 +01:00
Maciej Suminski 97f8a3361e Renamed ERC rule: "Test unique global labels" to "Test single instances of global labels" 2018-03-22 18:20:02 +01:00
Maciej Suminski 058f2bffd0 Spice simulator: safety check 2018-03-22 18:20:02 +01:00
Jon Evans 5b653c0c1e Update MacOS icons 
Fixes: lp:1750284
* https://bugs.launchpad.net/kicad/+bug/1750284
 2018-03-22 11:45:42 -04:00
Maciej Suminski e1c8822b9e Component Properties dialog: catch IO_ERRORs when showing footprint viewer 2018-03-22 11:44:13 +01:00
Maciej Suminski 351fc0c343 eeschema: preserve unit number after pasting a component 
Fixes: lp:1757373
* https://bugs.launchpad.net/kicad/+bug/1757373
 2018-03-22 10:55:50 +01:00
Jeff Young 79fe134495 Init Footprint Viewer with current FPID. 
Fixes: lp:1757421
* https://bugs.launchpad.net/kicad/+bug/1757421
 2018-03-21 23:11:55 +00:00
Jeff Young 99e659ff54 Coverity fixes. 2018-03-21 23:11:55 +00:00
Maciej Suminski bad462a228 Spice simulator: reload ngSpice dll on error 
ngSpice frequently ends up a simulation with an error:
"Error: ngspice.dll cannot recover and awaits to be detached"
The only way forward is to reload the shared library and
reinitialize ngSpice.

Fixes: lp:1753101
* https://bugs.launchpad.net/kicad/+bug/1753101
 2018-03-21 18:01:38 +01:00
Maciej Suminski 61e42ba392 Spice simulator: changed NGSPICE instance type to shared_ptr 
It was yet another time when I tried to free a singleton pointer.
Let's make clear it is not meant to be freed manually.
 2018-03-21 18:01:38 +01:00
Maciej Suminski 50053e7f27 Spice simulator: code formatting 2018-03-21 18:01:38 +01:00
Maciej Suminski 33620ecc85 Revert "libngspice is linked at compile time" 
This reverts commit 75f8b20493.
In case of problems, ngspice demands to be detached which is not
possible when it is linked at compile time.
 2018-03-21 18:01:38 +01:00
Jon Evans 285bf79370 Fix strings for save/load project menu options; standardize on "Load" 
Fixes: lp:1753659
* https://bugs.launchpad.net/kicad/+bug/1753659
 2018-03-20 22:20:54 -04:00
Jeff Young 1a845bc4ad Safer way to commit in-progress changes in wxGrid. 
In some cases the wxGrid would attempt to close the editor in
the middle of the d'tor, resulting in segfaults.
 2018-03-19 12:13:28 +00:00
Jeff Young df924a5e68 Follow standard FBP naming conventions. 2018-03-18 22:17:27 +00:00
Jeff Young 1684fc735a Defensive coding to attempt to prevent wxWidgets crash. 
Fixes: lp:1756255
* https://bugs.launchpad.net/kicad/+bug/1756255
 2018-03-16 19:02:25 +00:00
Wayne Stambaugh 3f52e87224 Standardize terminology for automatic zoom to "Zoom to Fit". 
Fixes lp:1753336

https://bugs.launchpad.net/kicad/+bug/1753336
 2018-03-16 08:38:36 -04:00
jean-pierre charras 819056df9d Eeschema: Add footprint field to Cadstar netlist file. 
Fixes: lp:1755996
https://bugs.launchpad.net/kicad/+bug/1755996
 2018-03-16 13:20:00 +01:00
Jon Evans 2cc5c6fd45 Add ERC check in component editor for conflicting multi-unit pins 
Fixes: lp:1680638
* https://bugs.launchpad.net/kicad/+bug/1680638
 2018-03-15 11:11:43 -04:00
Jon Evans 0a81782b5d Add ERC check that a pin appears in only one net 
Fixes: lp:1680638
* https://bugs.launchpad.net/kicad/+bug/1680638
 2018-03-15 11:11:43 -04:00
jean-pierre charras e14a7c928c Fix incorrect pin num string in cadstar and orcadpcb2 format 2018-03-15 09:15:49 +01:00
Jeff Young 3d12a6889b Make sure ERC and DRC item lists respect color themes. 
Fixes: lp:1492953
* https://bugs.launchpad.net/kicad/+bug/1492953
 2018-03-14 14:15:16 +00:00
Maciej Suminski 83efd6b8a3 Added 'Paste' to eeschema context menus 
Fixes: lp:1754891
* https://bugs.launchpad.net/kicad/+bug/1754891
 2018-03-13 17:26:33 +01:00
Jon Evans 935a5cada8 Fix typo in conditional check 
Fixes: lp:1755265
* https://bugs.launchpad.net/kicad/+bug/1755265
 2018-03-12 22:15:27 -04:00
Jeff Young f32f14dc8f Add WX_TEXT_ENTRY_DIALOG which inherits from DIALOG_SHIM. 
Fixes: lp:1754977
* https://bugs.launchpad.net/kicad/+bug/1754977
 2018-03-12 22:45:51 +00:00
Jeff Young 3d32ee774e Translatable strings must be ASCII7 for translation tools. 2018-03-12 19:54:07 +00:00
Jeff Young 4eedb3a27d The _() macro affords some nullptr safety over a naked immediate. 
Fixes: lp:1477448
* https://bugs.launchpad.net/kicad/+bug/1477448
 2018-03-12 19:18:05 +00:00
Tomasz Wlostowski b1f613071d eeschema: workaround for 64kByte string length limit in wxString::Format() causing segfaults in netlist update under Windows 
Fixes: lp:1754402
* https://bugs.launchpad.net/kicad/+bug/1754402
 2018-03-12 18:26:25 +01:00
jean-pierre charras 17f6d09935 Page layout editor: fix incorrect management of block operation in context (popup) menu. 2018-03-11 18:38:27 +01:00
Seth Hillbrand ce8d5787f7 Standardize Hierarchy wording 2018-03-09 09:43:54 -08:00
Seth Hillbrand 649809a38f Standardize Keywords->Key words 2018-03-09 09:43:53 -08:00
hauptmech eeeed88425 Use fixed width on first Symbol Table column 
Autosize when the reference field is a list of all components was too long.

Fixes: lp:1753330
* https://bugs.launchpad.net/kicad/+bug/1753330
 2018-03-08 20:59:46 -05:00
Jeff Young 4693fd6200 Resolve env vars when looking up documentation files. 
Fixes: lp:1729276
* https://bugs.launchpad.net/kicad/+bug/1729276
 2018-03-08 23:51:10 +00:00
Seth Hillbrand 33423fe88d Standardize capitalization 
Messages should start with capitalized letter
 2018-03-08 12:33:32 -08:00
Seth Hillbrand 8ff91cc0da Standardize hotkeys table 2018-03-08 12:33:32 -08:00
Seth Hillbrand de8716bcc2 Standardize open web browser 2018-03-08 12:33:32 -08:00
Seth Hillbrand f76b89cf99 Standardize error message in Eeschema 2018-03-08 12:33:32 -08:00
Seth Hillbrand 3cbf5f4942 Spelling indentifier -> identifier 2018-03-08 12:33:32 -08:00
Maciej Suminski b3601bd540 SCH_LEGACY_PLUGIN_CACHE: Rename conflicting aliases 2018-03-08 09:48:41 +01:00
Maciej Suminski d74bb131e1 SCH_LEGACY_PLUGIN_CACHE: Do not add the root alias for loaded symbols 
The root alias is added in the loop iterating through all aliases.
 2018-03-08 09:48:41 +01:00
Maciej Suminski a5844c9bb8 Replace illegal characters in LIB_{ALIAS,PART} LIB_IDs 
Schematic components have illegal characters replaced during load,
leading to broken component-symbol links. To avoid this, library symbols
should have their names fixed in the same way.

Fixes: lp:1752419
* https://bugs.launchpad.net/kicad/+bug/1752419
 2018-03-08 09:48:34 +01:00
Seth Hillbrand 9c532dfada Eeschema: Prevent block duplicate from disappearing 
Duplicate is handled like move/drag but shouldn't mark the original
items as moving.  This prevents a redraw from drawing the original
items.

Fixes: lp:1750083
* https://bugs.launchpad.net/kicad/+bug/1750083
 2018-03-07 16:43:21 -08:00
Michael Kavanagh fabbc48b40 macOS: standardise CFBundleName to application names. 2018-03-05 01:14:00 +00:00
Seth Hillbrand 9c44d67f3b Eeschema: Simplify transformation representation 
Fixes: lp:1752745
* https://bugs.launchpad.net/kicad/+bug/1752745
 2018-03-05 01:05:21 +00:00
Jeff Young f4eb63f871 Size fields list correctly in symbol edit. 
Fixes: lp:1753323
* https://bugs.launchpad.net/kicad/+bug/1753323
 2018-03-05 00:07:50 +00:00
Maciej Suminski 2af51ef20f Eagle import: do not call TrimWire() on imported schematics 
It turns out that TrimWire() may remove legit Eagle wires and effectively
change the netlist.
 2018-03-04 18:04:19 +01:00
Maciej Suminski 1f09990618 Remove not used ListNets() methods 2018-03-04 18:04:19 +01:00
Maciej Suminski 260f680c6c Eagle import: fix memory leak on schematic sheets import 2018-03-04 16:47:26 +01:00
Maciej Suminski 8e8d95dd7f Eagle import: process all sheets when adding junctions; fix footprint LIB_IDs 2018-03-04 16:45:42 +01:00
Maciej Suminski 77346d81ce Eagle import plugin: add junction dots to fix connectivity 2018-03-04 16:45:42 +01:00
Maciej Suminski 1f078f533b Refactor Eagle project import to use Kiway::ExpressMail() 2018-03-04 16:45:42 +01:00
Russell Oliver 9016344bb3 Eagle Schematic Import: Fix netlist mapping for zones and vias. 2018-03-04 16:45:11 +01:00
Russell Oliver 3d9c25494c Revert "Eagle importer: use only global net labels" 
This reverts commit b1f456fade.
 2018-03-04 16:42:55 +01:00
Wayne Stambaugh 43147a3a7a Do not append "RESCUE" to symbol names when rescuing symbols. 
Fixes lp:1741755

https://bugs.launchpad.net/kicad/+bug/1741755
 2018-03-03 15:34:26 -05:00
Tomasz Włostowski 919b449595 Added 'show spice netlist' menu option in the simulator 
Fixes: lp:1745887
* https://bugs.launchpad.net/kicad/+bug/1745887
 2018-03-03 17:38:28 +01:00
Wayne Stambaugh aeae32b1a2 Fix file naming bug when importing Eagle projects with . in file name. 
Fixes lp:1747470

https://bugs.launchpad.net/kicad/+bug/1747470
 2018-03-03 08:35:53 -05:00