76cb15f545
Trim VRML export layers to board outline.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14557
2023-04-18 16:47:42 +01:00
e8a9485d5e
Markup fixes.
...
1) allow escape sequences inside markup sequences
2) keep overbar when inside nested markup
3) always place overbar at full height, not sub/superscript height
Fixes https://gitlab.com/kicad/code/kicad/issues/14553
Fixes https://gitlab.com/kicad/code/kicad/issues/13449
2023-04-17 17:52:11 +01:00
0736c141b9
pcbnew: Fix crash with differential routing
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14537
(cherry picked from commit 469fe76994
2023-04-17 09:48:18 +01:00
c599385c8b
footprint wizards: fixes and enhancements
...
From master branch
2023-04-16 17:32:31 +02:00
1d37d3fdf7
Performance.
...
(cherry picked from commit 2793bb1d68
2023-04-16 15:38:32 +01:00
f3db64af05
Multi-threading safety.
...
(Possible fix for KICAD-74.)
(cherry picked from commit b76ef8c7e2
2023-04-16 15:38:22 +01:00
7843e6a709
Python: re-add "def Duplicate(self)" with the correct call to C++ Duplicate().
...
From master branch.
2023-04-15 16:20:42 +02:00
1bf44561da
Allow setting 0 to min width, min track width, min via annular width, etc.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13822
(cherry picked from commit 299c88cfec
2023-04-15 13:22:52 +01:00
ad612864ce
Update DRC exclusions model to match terminology.
...
DRC exclusions were originally written following the C++
pragma model (ie: allow this violation here). However, the
"exclusion" terminology we used in the GUI suggests a model
model where the exclusions go away when the violation no
longer exists.
Fixes https://gitlab.com/kicad/code/kicad/issues/14351
2023-04-15 12:10:23 +01:00
1707436cad
Retire the lib-tree scoring algorithm.
...
It appears to cause more confusion than help.
Fixes https://gitlab.com/kicad/code/kicad/issues/13905
(cherry picked from commit d01c023d5a
2023-04-15 00:09:34 +01:00
b011d508f8
Clear board soldermask when undoing/redoing items that affect it.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13446
(cherry picked from commit 4a3f77cd9d
2023-04-15 00:08:14 +01:00
2d13ddc70c
Fix PNS_KICAD_IFACE_BASE::IsFlashedOnLayer() to be able to handle multi-layer queries.
2023-04-14 10:59:10 +01:00
0be01f3c24
Don't steal an existing via's hole.
...
(cherry picked from commit 6fb30398ca
2023-04-14 10:09:03 +01:00
eb492724c7
Further simplify PNS::ITEM::collideSimple().
...
Also brings text_pns_basic's mocks into line with their "real"
counterparts.
(cherry picked from commit 2f198bdcb2
2023-04-14 10:09:03 +01:00
3b05d03220
Add PNS::ITEM::BoardItem() call.
...
About 1/3 of callers to Parent() don't care if they get the immediate
parent or not, about 1/3 want only the immediate parent, and about 1/3
want the hole parent's Parent().
I had earlier changed PNS::ITEM::HOLE to override Parent() and return
the hole parent's Parent(), but since the callers are pretty evenly
split I've reverted that and added BoardItem() for callers who want the
eventual BOARD_ITEM (whether a direct parent or a grandparent).
(Also removes a dead routine so I didn't have to figure out which of
the two it wanted....)
(cherry picked from commit 6f0d963683
2023-04-14 10:09:03 +01:00
4c04233a20
Unify most special-case processing to the clearance if-then-else.
...
This also allows us to support hole-to-hole clearance when dragging
a via near another via on the same net.
Fixes https://gitlab.com/kicad/code/kicad/issues/12781
(cherry picked from commit 8a0c225efa
2023-04-14 00:10:48 +01:00
2b6d2fc117
Don't return holes that have a parent pad or via.
...
(While we don't currently have holes without a parent pad or via, you
could imagine using HOLEs in the future to represent a hole in a first-class
board outline, so better not to build this assumption in.)
(cherry picked from commit b18bf09208
2023-04-14 00:10:43 +01:00
f64ef39687
Post-merge cleanup of holes-as-first-class-citizens.
...
(cherry picked from commit 4cc289c6fb
2023-04-14 00:10:34 +01:00
c1fb392333
router: hole as first-class-object, initial version of rewritten collision check routine
...
Rebased and modified by Jeff Young <jeff@rokeby.ie> 6 April 2023
(cherry picked from commit 1532a83330
2023-04-14 00:10:07 +01:00
de60d5467c
router: further changes to the ownership model
...
- LINEs now own their vias optionally (depending whether a LINE with its VIA belongs to a node)
- get rid of unique_ptr on the internal NODE::Add API (and also made it private)
- make sure stack pointers are not added to the node
- use rvalue reference for NODE::Add/NODE::Replace
Manually rebased by Jeff Young <jeff@rokeby.ie> 5 April 2023
(cherry picked from commit d961cdce3f
2023-04-14 00:10:01 +01:00
c1274e24b0
router: hole as first class objects, wip
...
Rebased by Jeff Young <jeff@rokeby.ie> 5 April 2023
(Also includes a bug-fix for highlighting collisions with edge-cut
items.)
(cherry picked from commit bfbda978b8
2023-04-14 00:09:56 +01:00
7f593d3999
router: rework ITEM ownership model.
...
- prerequisite for holes as first class objects code
- introduced the OWNABLE_ITEM interface that defines the owning container (NODE/other ITEM/ITEM_SET)
- simplified the ITEM_SET interface
- constified a lot of APIs (ownership/JOINT management) as a side effect
Rebased and cleaned up by Jeff Young <jeff@rokeby.ie> 5 April 2023
- some STL cover types removed
(cherry picked from commit 1283c4713f
2023-04-14 00:09:49 +01:00
3a6a6097a7
router: pass collision query options in a structure
...
Selectively cherry-picked by Jeff Young <jeff@rokeby.ie> 4 April 2023
- Jon's user-clearance-epsilon algo kept intact
- Jeff's castellated-pad code kept intact
(cherry picked from commit eed05191a9
2023-04-14 00:07:47 +01:00
a51475a094
Performance improvement for GetShownColumns.
...
(This needs to be fast as it's called from OnUpdateUI events.)
(cherry picked from commit 8e29a054f3
2023-04-13 13:47:21 +01:00
8e579ec8e0
Remove python-based board_item duplicate method
...
This method shadows the C++ method, and doesn't properly handle updating
the duplicated object's KIID to be unique.
Also add tests to ensure the KIIDs are unique after duplication.
Fixes https://gitlab.com/kicad/code/kicad/issues/14460
(Cherry-picked from 5d0b5e16ff
2023-04-12 16:07:00 +01:00
5527c12a8d
Fix crash due to extra right parens in pcad files
...
Fixes sentry KICAD-TA
(cherry picked from commit 37eaa29679
2023-04-12 01:53:29 +00:00
fb1cc72013
Don't crash on empty pcad polygons
...
Fixes sentry KICAD-103
2023-04-12 01:41:06 +00:00
1f34883a27
Make symbol/footprint trees sensitive to language change.
...
(cherry picked from commit eef3492fc0
2023-04-12 00:01:58 +01:00
323a2d83fa
Ease acquisition of a target item.
...
pickSingleItem() had a two-attempt algorithm, but the second attempt
was never made because we'd check for no hits before throwing out the
aAvoidItems.
The second attempt would fail anyway because QueryHoverItems() ignored
the aUseClearance flag when not idle, and didn't factor in the actual
clearance.
(cherry picked from commit d040690f60
2023-04-09 23:13:44 +01:00
03c3393616
Handle more pad shapes when building diffpair gateways.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/1883
(cherry picked from commit 1d19672054
2023-04-09 23:07:38 +01:00
2ba6fad633
Centralize NPTH has-annulus processing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13437
(cherry picked from commit 3b63d70d01
2023-04-09 19:04:33 +01:00
c18181042f
Simplify test for substantial nubs
...
Substantial elements following a divot should be at least as far in each
cardinal direction from the origin point in order to be considered
substantial. This catches cases where the "substantial" element is
actually a straight segment away from the divot
Fixes https://gitlab.com/kicad/code/kicad/issues/14130
(cherry picked from commit 914b5a4d21
2023-04-07 16:41:11 -07:00
3de80d3b20
Plot gerber: fix a too zealous plot of negative objects on the silkscreen layers,
...
when merging layers to silkscreen layers.
From master branch
2023-04-07 11:34:42 +02:00
199e31ea3f
Eagle template footprints don't actually belong to board.
...
Set their parent to nullptr before deleting (as the board may have
already been deleted).
Likely fix for Sentry KICAD-79.
(cherry picked from commit 13e79af8a0
2023-04-04 14:21:19 +01:00
9a57c11348
Possible protection from acessing deleted window data.
...
(Long shot for Sentry KICAD-MM.)
(cherry picked from commit bd60f38569
2023-04-03 23:47:09 +01:00
1dbe8b2a79
Nullptr safety.
...
(This is a long shot for Sentry KICAD-MV, but you never know....)
(cherry picked from commit a4e8fa96d4
2023-04-03 23:47:00 +01:00
a21e7a5eee
Don't pass a FRAME-based UNITS_PROVIDER to a modeless dialog.
...
(The dialog may outlive said frame.)
Should fix Sentry KICAD-3A.
(cherry picked from commit 9b4627e782
2023-04-03 17:20:06 +01:00
927b5ae707
Use enums for column ids.
...
(The nickname, in particular, is no longer column 1.)
Fixes https://gitlab.com/kicad/code/kicad/issues/14291
2023-04-02 15:28:11 +01:00
f59626004c
PCB_TEXT::TransformTextToPolySet(): fix missing code for knockout texts.
...
From master branch
Fixes #14473
https://gitlab.com/kicad/code/kicad/issues/14473
2023-04-02 10:29:18 +02:00
2ece2719d0
Naming conventions and nullptr usage. No functional changes.
2023-04-01 15:14:35 +01:00
78ee542d8d
Naming conventions.
2023-04-01 14:11:56 +01:00
cea9b38815
Update local coords after changing footprint item properties.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14348
(cherry picked from commit 0f9a4ef7b7
2023-04-01 13:57:47 +01:00
cb8f6db68d
Add hole clearance to moutning hole keepouts for SPECCTRA.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14439
2023-04-01 13:57:47 +01:00
85038c2b46
Prevent PCB Editor from opening multiple board_setup
...
ShowBoardSetup can be called multiple times from multiple locations,
resulting in duplicate board setup dialog boxes. This is confusing and
should be prevented. We use the established patter from the symbol
picker to ensure that only one copy of the dialog is ever opened at a
time
(cherry picked from commit 7695d510d6
2023-03-30 15:34:42 -07:00
1e8055f504
CADSTAR PCB Importer: Ignore construction layers on outer surfaces
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14443
7.0 version of d5bc223ff2
2023-03-31 00:17:06 +02:00
a7a5f20d1c
Pcbnew: fix incorrect position of cached text shapes when moving a footprint.
...
when moving a footprint, the position of texts living in FP_TEXT_BOX was
not updated when the text shape was cached (non Kicad fonts).
From master branch.
Fixes #14452
https://gitlab.com/kicad/code/kicad/issues/14452
2023-03-30 17:33:44 +02:00
3d9047bec4
Revert "CADSTAR PCB importer: Fix incorrect position of overridden pads"
...
This reverts commit 5cab66fb18
2023-03-29 21:53:14 +00:00
08d65beb26
CADSTAR PCB importer: Fix loading of rounded rectangle pads
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14445
(cherry picked from commit aaeb8ca739
2023-03-29 20:56:14 +00:00
5cab66fb18
CADSTAR PCB importer: Fix incorrect position of overridden pads
...
(cherry picked from commit 89441d807d
2023-03-29 20:55:50 +00:00
9466624f9d
Footprint editor: always export the currently loaded footprint.
...
Previously, it was not always the edited footprint, but a footprint
selected from the library tree.
It was especially annoying when the footprint was loaded from the board editor:
The footprint was not the loaded footprint, but its copy from library.
From master branch
2023-03-29 20:30:25 +02:00
80b842a704
Footprint viewer: ensure the footprint is updated after new library selection
...
Previously, if the first fp of the new lib has the same name as the old
displayed fp, the old fp was not replace by the new fp.
From master branch
2023-03-29 16:59:12 +02:00
d513a9fe5c
Locked shadow needs to be in shadow color
...
Otherwise, text shadow is stroked by text color
(cherry picked from commit f93fde15b7
2023-03-28 13:02:18 -07:00
17a1dc18be
Properties: Hide Net Class from GUI
...
It is confusing users who want to change the netclass of a net.
(cherry picked from commit 3f42e6b702
2023-03-26 19:50:10 -04:00
23b03fd6ab
Properties: Rename methods to better reflect their purposes
...
(cherry picked from commit 65193487a6
2023-03-26 19:48:46 -04:00
97b273905a
Manual cherry-pick of a214ac0310.
2023-03-26 21:06:24 +01:00
e759c4d27a
Only report on clearances where there was one defined.
...
If it's 0, it's just a straight-up collision.
(cherry picked from commit 9976b9ce8c
2023-03-26 20:59:41 +01:00
76685ae2d9
Run SILK_CLEARANCE rules on mask layer when testing silk-to-mask clearance.
...
This allows custom rules to be authored without firing the auto-generated
rule from Board Setup > Silk Item Clearance (which should be only for silk-
to-silk clearances).
Fixes https://gitlab.com/kicad/code/kicad/issues/14417
(cherry picked from commit 0266d03f79
2023-03-26 20:59:36 +01:00
3fad3ceb35
Update allow-solder-mask-bridges when updating footprint from library.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14422
2023-03-26 16:25:54 +01:00
dede9e8549
Test silk/mask collisions on the correct layer.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14417
2023-03-26 16:25:54 +01:00
abb6404ab2
Move up a layer validity check to prevent crash
...
Fixes sentry crash KICAD-RF
(cherry picked from commit 604a7d69db
2023-03-25 21:13:38 +00:00
59a478bdc5
Allow solder mask bridges between net-tie-group pads.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14412
(cherry picked from commit c5e66361db
2023-03-25 16:15:46 +00:00
fbef9ea600
Keep track of single-pad-islands so we can discount spokes to them.
...
(cherry picked from commit d6dd58fff9
2023-03-25 15:37:57 +00:00
0688491e1b
Fix typo
...
(cherry picked from commit eb90448247
2023-03-24 23:55:24 +00:00
434161687e
Fix cli crash due to dialogs buried in the pcb parser...
...
Fixes sentry KICAD-Q2
(cherry picked from commit 8a8589b9db
2023-03-24 23:53:15 +00:00
edf23c4c18
Revert "Clean up various simplify steps"
...
This reverts commit 798e13f70d
2023-03-24 12:30:06 -07:00
b0b9e66fad
Move to requiring explicit action to save project settings
...
(cherry picked from commit 610e787adahttps://gitlab.com/kicad/code/kicad/issues/14414
2023-03-24 11:49:50 -07:00
798e13f70d
Clean up various simplify steps
...
Adds the option to simplify the output of Clipper ops that remove minor
detours from the output lines. These detours are not substantive, so
removing them speeds up the rest of the system by removing unimportant
vertices. This also prevents the introduction of inadvertant concave
points when unioning two, closely-sized rounded shapes
2023-03-24 09:42:01 -07:00
0f40894317
Pcbnew, APPEARANCE_CONTROLS: do not change objects visibility, when changing
...
layers visibility using Preset layers widget.
Fixes #14381
https://gitlab.com/kicad/code/kicad/issues/14381
2023-03-24 15:06:06 +01:00
c5caa23a63
Manager teardrops on arcs. From master branch.
2023-03-24 11:46:11 +01:00
5dc683c968
Fix crash editing footprint editor defaults
...
Missing one level of GetParent()....use a dynamic_cast to sanity check it in debug
Fixes sentry crash KICAD-R4
(cherry picked from commit d49562a7aa
2023-03-22 22:41:57 +00:00
30dbfc33a4
step exporter: fix missing initialization of a member (m_pcbBaseName)
...
EXPORTER_STEP: rename m_pcbName to m_pcbBaseName.
From master.
2023-03-21 09:52:41 +01:00
b3de5aa08e
Put the project name back into the step pcb label.
...
Software like Solidworks and other CAD treat STEP labels as unique entries.
When you import multi STEP files into the same project, it'll start deduplicating your design by those name.
So two completely unrelated PCBs with the same "PCB" name will result in one being replaced by another.
2023-03-21 01:18:33 +00:00
ba4773e448
Orthogonal dimension are always cardinal, even when their start points are not.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13728
(cherry picked from commit bb2a0f825a
2023-03-20 21:32:06 +00:00
121ea14fe4
Filter Selected Items... is inclusive, not exclusive.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14273
(cherry picked from commit 897984aa22
2023-03-19 21:31:08 +00:00
befd836ab4
Clean up items which weren't pasted from clipboard.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14335
(cherry picked from commit ad5d3d4eba
2023-03-18 23:38:09 +00:00
94fd0df2e2
BOARD_NETLIST_UPDATER: add missing count of warnings
...
From master branch
Fixes #14290
https://gitlab.com/kicad/code/kicad/issues/14290
2023-03-18 17:57:07 +01:00
e5087ca3db
Load the global fp-lib-table before running the Python DRC
...
Without this we get parity errors for all the KiCad footprints
2023-03-17 21:00:41 +00:00
819a9da599
Pcbnew: fix crash when loading a library with a ft containing a dimension.
...
(crash due to the use of a null pointer during loading)
(cherry picked from commit 5735a57504
2023-03-17 16:00:34 +00:00
c41b1e2f06
Manual cherry-pick of bug fix part of ee1d9c561c.
2023-03-17 13:35:23 +00:00
d28cf632e4
Coverity fixes and code cleaning.
...
(cherry picked from commit a1fb8e1b1d
2023-03-16 10:59:05 -04:00
1c06f4cf06
Don't create 0-length tracks when placing via in the middle of a track.
...
(cherry picked from commit 8fe78101db
2023-03-16 02:49:54 +00:00
10a27156c2
Defenses in depth for ratsnest drawing.
...
(cherry picked from commit e60837ec95
2023-03-14 12:00:03 +00:00
94057886a3
Support SHEET_PATH when printing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14233
(cherry picked from commit dc78797274
2023-03-14 11:56:33 +00:00
249bcd9e1a
Update dimension units when opening PCBs in CLI.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14170
(cherry picked from commit a0adb59437
2023-03-14 11:56:33 +00:00
9995b8714b
Check for dirtied items in the cluster
...
When drawing the ratsnest, we need to be careful to avoid accessing
CONN_ITEMs that have been changed by the underlying model. Checking for
dirty items instead of valid items will prevent us looking at data that
are out of date
Fixes https://gitlab.com/kicad/code/kicad/issues/14265
(cherry picked from commit 283770fc45
2023-03-13 16:11:27 -07:00
7b4dd2f7f5
DIALOG_BOARD_REANNOTATE: ensure indexes are not out of bound.
2023-03-13 20:25:54 +01:00
cc6b01cf88
Force initialization of board units
...
Unitialized variables are the devil's playground
(cherry picked from commit f0892598a4
2023-03-13 12:15:51 -07:00
74da0043b4
Move automatic dimension processing inside PCB_DIMENSION_BASE.
...
Also move dimension precision to an enum so it can get a proper dropdown
in the properties inspector.
(cherry picked from commit 461def2719
2023-03-12 21:04:09 +00:00
c0ddca12df
Add Property Inspector support for dimension objects.
...
Includes changing the class hierarchy so that dimension objects inherit
from PCB_TEXT rather than containing a PCB_TEXT member variable.
(cherry picked from commit 23accffc6d
2023-03-12 21:03:58 +00:00
bf55e610b9
Handle plotting of text on solder mask layer.
...
Admittedly this is an odd thing to do, but we should still be internally
consistent, and it has come up in customers' files.
Fixes https://gitlab.com/kicad/code/kicad/issues/14226
2023-03-12 21:00:19 +00:00
9f7b31b5c5
Do not try to process invalid ratsnest nodes
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14254
(cherry picked from commit 8eaa3cfac9
2023-03-11 21:12:33 +00:00
9e1fd16329
Coverity fixes and code cleaning.
...
(cherry picked from commit 4e99812145
2023-03-10 11:21:19 -05:00
51dc2b109e
Handle fully-nested zones
...
The logic to handle divots needs to account for fully nested, same net
zones. The process of subtracting led to us considering the inner zone
to be a zone knock-out (negative polygon). To avoid this, we need to
check if the inner, higher priority zone has any connection to the outer
zone. If it does not, then we can treat it as an isolated zone without
worrying about divots to the outer zone.
(cherry picked from commit 9146e38af4
2023-03-09 09:25:20 -08:00
2358ff6f07
Helper function to allow net.GetNetClassName()
...
(cherry picked from commit 734d3667a8
2023-03-09 14:03:02 +00:00
11788d2f39
Expose shared_ptr to swig
...
Possibly not the right way to go about it but technically works
(cherry picked from commit 182abd4652
2023-03-09 14:02:48 +00:00
541f7467c6
Fix python GetAllNetClasses
...
(cherry picked from commit 716328e511
2023-03-09 14:02:34 +00:00
411c9707ee
specctra export: fix handling of multi-layer zones.
...
(from master branch)
2023-03-07 15:45:28 +01:00
ee0ba17c03
Improve HiDPI handling of appearance/layer controls
...
(cherry picked from commit 43d3a18b86
2023-03-07 08:49:06 -05:00
64bc850d8f
Fix layer widget in HiDPI situations
...
(cherry picked from commit 89ef6b36f4
2023-03-07 08:49:06 -05:00
154f64dae3
Edge connectors shouldn't trigger edge clearance violations.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14199
(cherry picked from commit 33e7c78533
2023-03-07 12:23:56 +00:00
Jeff Young
Lucas Dumont
jean-pierre charras
Tomasz Wlostowski
Ian McInerney
Marek Roszko
Seth Hillbrand
Roberto Fernandez Bautista
Jon Evans
Salvador E. Tropea
Wayne Stambaugh
Alex
mitxela