haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
40,791 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

16260 Commits

Author SHA1 Message Date
jean-pierre charras d4ce2c8982 Fix a few Coverity warnings. 2023-11-25 11:44:01 +01:00
Jeff Young 2a198e22e2 Draw tuning pattern border when placing. 2023-11-23 23:25:49 +00:00
Jeff Young b6501ce632 Report current length on roll-over. 2023-11-23 23:25:49 +00:00
Ian McInerney 1194a91be4 Prompt if overwriting the net inspector CSV report 2023-11-23 11:49:40 +00:00
Ian McInerney 0508a9ce83 Don't write units to every field in net inspector CSV 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16147
 2023-11-23 11:46:24 +00:00
Jeff Young d437d872ab Re-enable corner radius of DP meanders. 
It appears whatever bugs it had have been addressed.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15257
 2023-11-22 19:45:56 +00:00
Jeff Young 85f760fc66 Run IsElementVisible() test on all markers, not just their shadows. 
The view item doesn't always get its layers updated early enough for
the paint.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16138
 2023-11-22 14:37:45 +00:00
Yang Hongbo f324b1b88d Merge remote-tracking branch 'origin/master' into last_net_inspector_settings 2023-11-22 07:21:03 +08:00
Yang Hongbo 5a1b30ea42 save and restore last used net inspector settings 2023-11-22 07:13:08 +08:00
Alex Shvartzkop 5de55b8c4a STEP export: fix a Bnd_BoundSortBox usage bug. 2023-11-21 14:21:12 +03:00
Alex Shvartzkop 58b9d68084 STEP export: make use of footprint names instead of "SOLID". 
Should help when importing into software that does deduplication
based on label names (e.g. SolidWorks).
 2023-11-21 14:11:16 +03:00
Alex Shvartzkop f3fdfa73e6 STEP export: Do not set BRepBuilderAPI precision. 
This caused issues when loading some STEP models.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15485
 2023-11-21 00:47:38 +03:00
Jon Evans 87ba1f7ea0 Fix expand selection for graphic shapes on graphic layers 2023-11-20 16:14:56 -05:00
Jeff Young d382a11c2a Apply new on-canvas-item marking to footprint editor tree. 2023-11-20 19:46:03 +00:00
jean-pierre charras ed1924b975 Pcbnew, place menu: some enhancements: 
- move place dimensions to a sub menu (they are not frequently used, and it
reduce the size of the place menu
- add reset drill origin, similar to reset grid origin.
 2023-11-20 13:23:16 +01:00
snhobbs 5cf244dd90 Added a ImportSpecctraSession overload that doesn't require a PCB_EDIT_FRAME 2023-11-20 03:06:27 +00:00
Alex Shvartzkop 8dfad68d69 ADDED: option to optimize exported STEP files (disable pcurves) 2023-11-19 15:23:17 +03:00
Alex Shvartzkop 1321c8c6af STEP export: fix an issue when cutting circular holes in zones. 2023-11-19 14:04:31 +03:00
jean-pierre charras 7fd9226bec Fix issue in CalcArcCenter( VECTOR2D& aStart, VECTOR2D& aMid, VECTOR2D& aEnd ) 
It happens when the segment (aStart, aMid) is horizontal
Probably also when the segment (aEnd, aMid) is horizontal
Slopes with value 0.0 are set to double:: epsilon(), but it was a too small values
generating broken calculations.
Now set to 1e-10 (it seems working).
Fixes #16089
https://gitlab.com/kicad/code/kicad/-/issues/16089
 2023-11-18 20:08:26 +01:00
Wayne Stambaugh 930b695b9f Board editor array dialog fixes. 2023-11-18 13:21:13 -05:00
Wayne Stambaugh 9e1caa0d39 Fix crash when creating an array of footprint fields in board editor. 
Attempting to create an array of footprint child objects other than a pad
causes the crash due to the fact that only pads where checked.  The change
now checks if any object has a footprint as a parent.  This should prevent
any future issues when new footprint child objects are added.

There was also another subtle bug fixed when more than one child object of
a footprint were selected, the array feature would make as many copies of
the footprint as selected child items.

https://gitlab.com/kicad/code/kicad/-/issues/16088
 2023-11-18 11:18:18 -05:00
Jeff Young 21d53d0b86 Make sure Use-Netclasses checkbox gets set when loading dialog. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16110
 2023-11-18 12:18:45 +00:00
Wayne Stambaugh a5c34c50d7 Use natural sorting for net inspector when sorting by net name. 
wxString sorting doesn't work when sorting strings with numbers which
results in 1,10,11...2 instead of 1,2,...9,10,11.

https://gitlab.com/kicad/code/kicad/-/issues/16100
 2023-11-17 15:25:07 -05:00
Jeff Young a4a946ab75 Clearer naming. 2023-11-17 18:36:33 +00:00
Jeff Young 78c46e5f4e Improved clarity and comments. 2023-11-17 18:36:33 +00:00
Alex Shvartzkop 76352234e5 ADDED: Support Altium .IntLib (Integrated Library) in fp/sym library tables. 2023-11-17 07:20:18 +03:00
Jon Evans 6cb046a4eb macOS: add a few more known file types 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14206
 2023-11-16 12:11:42 -05:00
jean-pierre charras ed9dd55fde DRAWING_TOOL::PlaceImportedGraphics() do not add twice items when adding to new group. 2023-11-16 12:53:00 +01:00
jean-pierre charras 83ee2ffdab Pcbnew, dialog import graphics: add tool-tips and minor cosmetic enhancements. 2023-11-16 12:50:45 +01:00
Jeff Young b218617469 Honour bounding-hull setting on closed shapes and chained segments. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16092
 2023-11-16 09:07:54 +00:00
jean-pierre charras a663dd7ec4 Pcbnew, import graphics: fixes and enhancements: 
- fix regression: allow grouping or not imported items
- store more settings in Pcbnew settings: all options are now stored.
- default tolerance to connect items is now 0.01 mm. 1 mm is a too big value,
and can create serious artifacts in imported outlines.
 2023-11-15 20:26:05 +01:00
Jeff Young 9bb6b11c1d Separate fields from text items in FPEdit's Defaults panel. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15135
 2023-11-15 10:56:14 +00:00
Jan Wichmann b1a044e22a pcbnew: ADDED new feature "Center on FP" in the dialog "Edit Text and Graphic Properties" 2023-11-14 16:35:01 +00:00
Jeff Young ca8cb5a206 Fix typo. 
We want recursion into descendants here.  Alternatively we could
change the caller to RunOnDescendents(), but it seemed cleaner to
omit the scoping of the Stage() call....

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16077
 2023-11-14 14:23:23 +00:00
jean-pierre charras e3bbe32793 drc_test_provider_library_parity: Better algo to compare footprint graphics 
Instead of changing the footprint in test to have a non flipped, non rotated
fp, change the footprint template from library to have the same transform.
It reduce problems like rounding and graphic shape convert for rectangles.
Fixes #16075
https://gitlab.com/kicad/code/kicad/-/issues/16075
 2023-11-13 18:38:30 +01:00
jean-pierre charras f6314e6401 FOOTPRINT::cmp_drawings(): fix a incorrect sort criteria for polygons: 
for polygons, GetStart() and GetEnd() have no meaning and cannotbe used
for sorting.
 2023-11-13 18:36:00 +01:00
jean-pierre charras d5a5d25623 rework on commit b564d0713c50e50282a0545ee23bb3ec51906cfd: better fix 2023-11-13 11:16:21 +01:00
Ian McInerney e5f688e865 Plot footprint edgecuts in PDF drill map file 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15247
 2023-11-12 23:21:46 +00:00
Zhuang Jiezhi 9b8fa85b32 feat:Add python API GetKicadCurrentLanguage 2023-11-12 22:52:54 +00:00
jean-pierre charras b564d0713c DRC: fix one of some things that can create false positive. 
in bool shapeNeedsUpdate(), if a shape is a rectangle and the other is a polygon,
we need to try to convert the polygon to a rectangle for comparison, because some
transforms ( and especially PCB_SHAPE::Normalize() ) can convert a polygon to a rectangle
So a poly and a rectangle can be in fact the same shape

Partial fix of bug 16075.
 2023-11-12 20:19:09 +01:00
Alex Shvartzkop 05e954ad5d Fixes for length tuning patterns. 2023-11-12 12:17:08 +03:00
Alex Shvartzkop 78c7dc85f0 Fix moving tuning patterns, disable rotation. 2023-11-12 02:24:35 +03:00
jean-pierre charras 0904231000 Partial revert of commit d8498b62e0, due to 
comments in PCB_TEXTBOX::TransformShapeToPolygon()
 2023-11-11 17:01:01 +01:00
jean-pierre charras d8498b62e0 PCB_TEXTBOX::TransformShapeToPolygon(): fix incorrect transform: when it 
is a polygon (rotated rect by a non cardinal angle) the polygon is not
filled, so the shape is just a set of thick segments.
Fixes #16072
https://gitlab.com/kicad/code/kicad/-/issues/16072
 2023-11-11 16:44:04 +01:00
Jeff Young 7e46e85c7d Update copyrights. 2023-11-11 15:29:34 +00:00
jean-pierre charras 75e0bf0cba Python fp wizards: Add a text ("${REFERENCE}") on fab layer to a few wizards. 2023-11-11 11:19:21 +01:00
Jeff Young 3e58425671 Flip rotation angle when board view is flipped. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15954
 2023-11-10 22:30:06 +00:00
Jeff Young 9ef05fb762 Don't store document values in global PROPERTY_MANAGER. 
At best it leads to the wrong units being used if they're different
between (for instance) PCB Editor and Footprint Editor.  (And this
will only get worse if we ever to to a single binary.)

At worst it causes crashes when accessing freed ORIGIN_TRANSFORMS.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16062
 2023-11-10 18:37:29 +00:00
Jeff Young d41f4ec842 Only disable unflashed layers when they're conditionally flashed. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16061
 2023-11-10 13:57:56 +00:00
Jeff Young e6081cf31a Use position of isolotaed spoke when reporting it. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16058
 2023-11-10 12:49:19 +00:00
jean-pierre charras 2f594e441b Fix a compil warning (shadowed variable). 2023-11-10 10:31:40 +01:00
Jeff Young 6ecfc89a4a Honour originTransforms in search panels. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15031
 2023-11-09 18:41:18 +00:00
Alex Shvartzkop 7589de6120 Optimize footprint/symbol library hover previews. 2023-11-09 19:02:10 +03:00
Jeff Young cc721c4907 Improve encapsulation of group internals. 
(It's still leaking into BOARD_COMMIT and some other places, but at
least it no longer leaks into all the edit tools.)

Also fixes some bugs when moving/copying/pasting multiple selections
containing length-tuning patterns.
 2023-11-09 14:05:35 +00:00
Jeff Young 78e00ade7a Clearer naming. 2023-11-09 14:05:35 +00:00
Ian McInerney dd933b7d0e Update CERN copyrights 2023-11-08 21:34:14 +00:00
Jeff Young a003515ee7 Enable drill/place file origin for plotting PDF. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15834
 2023-11-08 16:40:28 +00:00
Jeff Young 72c985bc07 Rewrite scoring algo again. (Third time's the charm?) 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16042
 2023-11-08 12:33:09 +00:00
Alex Shvartzkop 7abe2e3ea0 Restore clearance cache usage in PNS::NODE::NearestObstacle. 
This (and the other commit) restores router performance to pre-7.0.3 levels.

(cherry-picked from commit 5e93814283)
 2023-11-07 23:25:53 +03:00
Seneral 55c44966d9 Added a temporary item cache to improve router performance 
Some items only used within algorithms were never cached
Because they are hard to manually clean up
But caching them does help the algorithms a lot
So this solution is the best I can think of

(cherry picked from commit d29c07a663)
 2023-11-07 23:23:52 +03:00
Jeff Young 6d43ef5678 Don't specify sizes when we don't need to. 
However, in some places we *do* have to because otherwise wxWidgets
will pick a minimum size for us (and it's rather large).

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16039
 2023-11-07 14:53:41 +00:00
Jeff Young abda3c0d33 Handle various keepout flags independently. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16037
 2023-11-07 11:57:23 +00:00
Marek Roszko 23676eb988 Ensure output directory exists for drill files cli export 2023-11-06 21:11:35 -05:00
Jeff Young 5f6dab931a Save order of all-layers in Plot Dialog. 
Also adds an all-layers-specific context menu which includes an item
to sort in board-stackup order.
 2023-11-06 19:56:42 +00:00
Jeff Young 7788c8f21c Fix textbox mirroring and rotation (again). 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15576

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14159

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14912

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14178
 2023-11-06 14:03:58 +00:00
Alex Shvartzkop 6c21e0607b Use wxFileName::Mkdir instead of wxMkDir. 
wxMkDir is a CRT wrapper that doesn't actually return bool.
 2023-11-06 17:02:34 +03:00
Jeff Young c5520b3eef Save state of as-item-checkboxes checkbox. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13749
 2023-11-05 16:22:20 +00:00
jean-pierre charras d90981d981 Pcbnew: fix Swap command that improperly rotates footprints when flipping. 
Fixes #16025
https://gitlab.com/kicad/code/kicad/-/issues/16025
 2023-11-05 15:09:48 +01:00
Jeff Young f83d60a48f Clean up autosave files when reverting. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15998
 2023-11-05 12:20:31 +00:00
Jeff Young 1df5d9c48c Make sure to add enough wiggle room when MaxError is very large. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16024
 2023-11-04 23:11:51 +00:00
Alex Shvartzkop 8752f75ef9 EasyEDA Std: COPPERAREA parsing failsafe. 
Fixes KICAD-41Q
 2023-11-04 13:55:29 +03:00
Jeff Young ac172b944a Don't get stuck cycling through invisible layers. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16019
 2023-11-03 18:17:36 +00:00
Jeff Young bc99b42c08 ADDED: put Renumber Pads in the edit menu. 
Context-menu-only is too hidden.
 2023-11-03 12:36:30 +00:00
Jeff Young 141b953d12 Show selection before opening menu. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15922
 2023-11-03 12:36:30 +00:00
Jeff Young 92ae0f4793 Save Footprint chooser size and location. 
(We're using a FRAME to mimic a dialog, so we need some of the
DIALOG_SHIM logic inside it.)

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15807
 2023-11-03 10:34:27 +00:00
Jeff Young 50ff5e616f Don't delete text when cancelling changes. 
Also changes margins of compile button so it correctly lines up at
the top of the error window.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16002
 2023-11-02 18:37:55 +00:00
Wayne Stambaugh 91b503f875 Minor dialog layout fixes. 2023-11-02 09:37:44 -04:00
Jon Evans 1b4e77d53c Fix another gcc 11 compile error 2023-11-01 20:49:08 -04:00
Jeff Young 7f8e397dfb Behave (or assert) when source or target are null or dirty. 2023-11-01 17:11:42 +00:00
Jeff Young 2ce4adc739 Check physical_clearance rules in the router. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16007
 2023-11-01 14:13:16 +00:00
Jeff Young fb59f83683 Clean up references in RN_NETs when garbage collecting CN_ITEMs. 2023-11-01 13:53:30 +00:00
Jeff Young d93bb464bf When garbage collecting locally we also need to clear global references. 2023-11-01 12:47:54 +00:00
Jeff Young 67d8b13b02 And Font to properties manager for EDA_TEXT items. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16004
 2023-11-01 00:39:42 +00:00
jean-pierre charras d8be69c3c1 PAGE_INFO: use double instead of int to store the page size. 
For historical reasons, they are stored in mils, but using int create rounding
issues when converting to/from mils to IU in dialogs.
This is a minor but annoying issue.
Fixes #16000
https://gitlab.com/kicad/code/kicad/-/issues/16000
 2023-10-31 13:47:32 +01:00
Jeff Young e7fca68384 Don't double-delete unused nets (or anything else, for that matter). 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15979
 2023-10-31 12:10:21 +00:00
Alex Shvartzkop 3d5721a217 Fix some warnings. 2023-10-31 04:25:19 +03:00
Alex Shvartzkop e24c8de4b8 EasyEDA Std: Fix open polygon shapes in symbols. 2023-10-31 02:21:32 +03:00
Alex Shvartzkop f48a248db4 EasyEDA Std: Handle HTML escape characters in text. 2023-10-31 02:21:32 +03:00
Jeff Young b5d904b45d Ignore VVIAs when assembling length-tuning line. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15995
 2023-10-30 19:55:51 +00:00
Jeff Young 42d9bc4a98 Hook up Import Settings to tuning patterns and custom rules. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15980
 2023-10-30 18:12:42 +00:00
Jeff Young 87571ed8b8 Not all font sizes, fill properties or color properties are the same. 2023-10-30 17:30:15 +00:00
Wayne Stambaugh 6183a1e4de Coverity warning fixes. 2023-10-30 09:16:24 -04:00
Alex Shvartzkop 847ab093c8 ADDED: Project chooser dialog for EasyEDA Pro import. 2023-10-30 09:35:27 +03:00
Seth Hillbrand 6d957e9d65 Don't use KiROUND when we should trunc 
When calculating the viewport extents, we only need the maximum size
that can be represented.  Anything larger should be truncated.  We do
this in many other places (wx_view_controls, ruler_item,
ds_proxy_view_item, etc) and this brings pcb_selection_tool into
alignment with this, avoiding an unneeded warning message

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15529
 2023-10-29 10:42:33 -07:00
Jeff Young fc0017fc95 Normalize rects higher up. 
We don't want to normalize footprint children to their board-relative
coordinates.
 2023-10-29 11:45:16 +00:00
jean-pierre charras acda18465c DIALOG_EXPORT_STEP: fix missing init of m_outputFileName widget at opening. 
Add also a validity test for the filename.
 2023-10-29 10:20:51 +01:00
Jeff Young 0747d35228 Minor formatting fixes. 2023-10-28 17:58:33 +01:00
Jeff Young a2f19ea6bb Push m_forceMarkObstaclesMode down into the DRAGGER. 
The existing flag was never read anyway, and it's only the DRAGGER
that knows that the starting state is already colliding and that we
need to force mark-obstacles mode.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8641
 2023-10-28 17:52:15 +01:00
Jeff Young c1f01877a8 Improve length calculation for vias. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10690
 2023-10-28 13:14:21 +01:00
Jeff Young 4df5f9969a Remove unnecessarily restrictive IsCopper() checks. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11588
 2023-10-28 12:12:34 +01:00
Jeff Young 6c6a7cf862 Provide a callback for supplying file filters just-in-time. 
This allows us to make them dependent on the current plugin type in
the fp lib table.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/13959
 2023-10-28 11:18:17 +01:00
Ian McInerney 171458a27b Introduce action friendly names 
Friendly names can be used to display action information that is clearer
in non-hierarchical contexts (e.g. not in menus).

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8075
 2023-10-27 23:58:29 +01:00
Ian McInerney 9f21d0d719 Don't hardcode units for length/height/width in properties dialog 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15967
 2023-10-27 23:58:29 +01:00
Wayne Stambaugh 6269453416 Coverity warning fixes. 2023-10-27 16:48:14 -04:00
Seth Hillbrand 8b3ac31646 Update GenCAD export to handle arbitrary outline 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15961
 2023-10-27 12:46:37 -07:00
jean-pierre charras 0345e0f75c export gencad: clean and update old code. Should not really change the export. 
- code refactory.
- allows export to be done from kicad-cli (kicad-cli code is not yet updated)
Need more work.
 2023-10-27 20:03:12 +02:00
Wayne Stambaugh 98cae68ea5 Fix pad properties dialog control updating. 
This fixes an issue (at least on GTK builds) where the hidden controls
that change when selecting a different pad type and or pad shape get
shown are not laid out correctly.
 2023-10-26 13:36:32 -04:00
jean-pierre charras 93b5038382 FOOTPRINT_EDIT_FRAME: ensure the canvas type comes from the FOOTPRINT_EDITOR_SETTINGS config 
Previously, although the fp editor preferences has an option to select the canvas type,
it was read from the the PCBNEW_SETTINGS config, using Kiface().KifaceSettings().
 2023-10-26 17:58:33 +02:00
Jeff Young 8d3a3419f8 Honour 90-degree router mode in a few more places. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10421
 2023-10-26 14:18:28 +01:00
Jeff Young f7420bc820 Separate Footprint Editor's sketch modes from PCB Editor's. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15345
 2023-10-26 10:59:26 +01:00
Jeff Young 7bd6c9d623 Fix sloppy coding. 2023-10-26 10:43:21 +01:00
Jeff Young 2746626de0 Differentiate plane and signal clearances based on layer type. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15597
 2023-10-25 22:24:19 +01:00
Jeff Young 38e5e27a50 Import Eagle arc tracks as arcs. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14539
 2023-10-25 21:55:09 +01:00
Jeff Young 6a2aeeeae2 Import a few more rules from Altium board files. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15585
 2023-10-25 16:06:40 +01:00
Jeff Young fc4bc10d27 Separate out axes definitions between ModEdit and PCBNew. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5711
 2023-10-25 15:01:36 +01:00
jean-pierre charras 85210e5136 Pcbnew, export component placement: better string in menu (.gbr added). 
(Was missing in my commit 5bf241a5)
 2023-10-25 13:38:07 +02:00
jean-pierre charras 71475a4b56 Gerber place files: do not quote strings (fields, pad name, pad function ...) 
Double quotes have no special meaning, so adding them modify the texts
 2023-10-25 08:59:37 +02:00
Jeff Young fca1ad5285 Ask user if they want to delete original items after conversion. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15938
 2023-10-25 00:11:08 +01:00
Jeff Young 791aa64950 Functionally it's a "reference image". 
The implementation happens to be a "bitmap".

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15932
 2023-10-24 15:44:21 +01:00
Alex Shvartzkop e6cf5e5e01 Don't draw PCB bitmaps on layers not visible in high-contrast mode. 2023-10-24 03:39:48 +03:00
Seth Hillbrand cb8dd9e9a2 Don't leave deleted items in group 
We filter out ref/value text in copies so we need to remove them from
the copied group (if any) as well

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15930

(cherry picked from commit fb387a2c09)
 2023-10-23 13:34:53 -07:00
Alex Shvartzkop c8b2e2aa07 closestDist_sq should be ECOORD_MAX initially. 2023-10-23 22:18:45 +03:00
jean-pierre charras 4ffa013467 Fix minor compil and Coverity warnings (not initialized vars) 2023-10-23 20:13:46 +02:00
Jeff Young 435e3fab8d Support text variables in STEP export filename. 
Also fixes some other file browser titles to match Kicad's overall style.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15927
 2023-10-23 18:01:47 +01:00
jean-pierre charras dd166ce835 Pcbnew, legacy plugin: fix a minor issue about file version number. 
Some .brd files have a version number = 7, very similar to version 2.
So force version = 2 to import these files.
 2023-10-23 18:43:26 +02:00
Mike Williams 91b6bb8088 Grid helpers: remove view items on destruction 2023-10-23 09:39:08 -04:00
Jeff Young bf4529c1b5 Remember last tab for Pad Properties. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15925
 2023-10-23 14:13:49 +01:00
Jeff Young f4b872226b Fix wxFormBuilder switching the default tab. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15925
 2023-10-23 13:44:05 +01:00
jean-pierre charras 504b3cd174 FP editor: allows FOOTPRINT field to be editable. 
Although it had no meaning in FP editor, it needs to be edited in some cases,
as it is a member of a library footprint.
 2023-10-23 12:53:25 +02:00
Alex Shvartzkop 97901c9ac5 Fix footprints being difficult to select in high-contrast modes. 
(regression)
 2023-10-23 06:09:13 +03:00
Jeff Young fb84f4592b Check vias before holes as we assume any hole is non-pushable. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15840
 2023-10-22 22:46:19 +01:00
Jeff Young 7c08aa09d5 Don't generate virtual vias when editing a tuning pattern. 2023-10-22 20:35:15 +01:00
Jeff Young f1efae1e05 We don't want to do collision testing against virtual vias. 
(Which means they had better not have a hole.)
 2023-10-22 20:35:15 +01:00
Jeff Young ad676e22b8 Don't push a commit we don't own. 2023-10-22 20:35:14 +01:00
Jeff Young 5da35d7750 Don't modify dp-tuning when doing skew tuning. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15901
 2023-10-22 20:35:14 +01:00
Jeff Young 09e92fc3fc Cap self-intersecting outline violations. 2023-10-22 20:35:14 +01:00
Jon Evans 06a4bdbf4c Upgrade BITMAP_TOGGLE and GRID_BITMAP_TOGGLE to wxBitmapBundle 2023-10-22 14:02:06 -04:00
Jon Evans 50fe585827 REMOVED: manual icon scale preference 
This is now handled properly by wxWidgets on all platforms

See https://gitlab.com/kicad/code/kicad/-/issues/14119
 2023-10-22 14:02:06 -04:00
Jon Evans eb5b3db063 Add bitmap bundle support to BITMAP_SCALE 
Change a bunch of buttons and toolbars to use it

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14119
 2023-10-22 14:02:06 -04:00
Alex Shvartzkop 08e8e13f46 performance: Cache zone fill triangulation at draw. 2023-10-22 14:21:54 +03:00
Jeff Young 24a9245f81 Hook up via size & drill constraints to editors. 2023-10-21 19:10:38 +01:00
Jeff Young df46521b25 Don't separate netclass values from custom rule values. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15912
 2023-10-21 18:23:48 +01:00
Jeff Young b97d8ddef4 Make offset-zone check multi-layer aware. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15916
 2023-10-21 15:08:36 +01:00
Jeff Young f18ce8c6de Fix layer handling for create similar zone. 2023-10-20 22:20:30 +01:00
Jeff Young fc22e602e2 Coverity fixes. 2023-10-20 16:38:21 +01:00
Jeff Young f5e99338a9 Generators should respond to the selection filter that controls their children. 
(Tuning patterns to the track checkbox, stitching patterns to the
vias checkbox, etc.)

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15905
 2023-10-20 16:28:05 +01:00
Jeff Young 00fb542146 nullptr safety 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15906
 2023-10-20 16:28:05 +01:00
Jon Evans 32ee3bdabd Remove errant git2 link command 2023-10-20 11:26:22 -04:00
Jeff Young 1b04d8972e Missing update from last commit. 2023-10-20 14:09:21 +01:00
Seth Hillbrand d99641be40 ADDED: Git integration support 
Adds support for project-based git integration, branch support, commit,
revert and updates

Fixes https://gitlab.com/kicad/code/kicad/issues/10441
 2023-10-20 12:51:47 +00:00
Jeff Young 8f96009fe5 Hints and fixes for separate checking of milling cutter size and drill size. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15886
 2023-10-20 12:13:09 +01:00
Jeff Young 68a5753c80 Repair Rotate on PCB_GENERATOR items. 2023-10-19 23:34:52 +01:00
Wayne Stambaugh c4a9703f81 Minor dialog layout fixes. 2023-10-19 11:59:35 -04:00
Jeff Young 134685bc32 Optical alignment for capital 'T's. 2023-10-19 15:02:38 +01:00
Jeff Young 059a95a2f2 Lock generated tracks when routing. 
Otherwise they lose their group status when being replaced by the
router (even if they weren't otherwise modified).
 2023-10-19 11:39:01 +01:00
Jeff Young 24ddc728e8 Add PCB_ACTIONS::regenerateAllTuning.... 
... and move GENERATOR_TOOL to RegenerateAllOfType().
 2023-10-19 11:20:09 +01:00
Jeff Young 7447700735 Fix typo. 2023-10-19 11:20:09 +01:00
Jeff Young 16ec0faa7a Reduce line-breaking. 
Also simplifies handling of generator properties dialogs.
 2023-10-19 11:19:57 +01:00
Jeff Young 67f0f6e3b9 Rename class to match current terminology. 2023-10-19 01:31:13 +01:00
Jeff Young b089630b4c Simplify Import Graphics. 
Removed no-longer-required differentiation between importing
footprint vs board objects.

Renamed files to match the dialog.

Made Position At and Set Layer optional checkboxes.
Removed Group Items checkbox.  (In the unlikely event that you don't
want a group, do an UnGroup after importing.)

Flattened out labelled-sizers in the dialog.

Removed importers blacklist, which hasn't been active for at least 4
years.

Fixed undo/redo bug that caused items to be no-longer-grouped after
a redo.
 2023-10-19 01:31:13 +01:00
Mike Williams 70917a14e7 Route from end: fix crash and snapping bug 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13992
 2023-10-18 12:32:32 -04:00
Mike Williams 5cd5194e89 SCH/PCB: warn before deleting footprint-only fields on sync 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15342
 2023-10-18 11:33:17 -04:00
jean-pierre charras 599a8304a6 Pcbnew, ConnectBoardShapes(): do not add 0 size segments to outlines. 
Add also our standard copyright text.
 2023-10-18 11:14:43 +02:00
jean-pierre charras db9734923c DIALOG_CLEANUP_GRAPHICS: fix incorrect parameter passed to cleaner.CleanupBoard(). 
The fix board outlines was in fact always activated.
 2023-10-18 09:40:26 +02:00
Seth Hillbrand 4ed8b14c12 Fix Mac build 
Clang requires tighter forward declaration of derived enums
 2023-10-17 09:26:00 -07:00
Jeff Young e793e30360 Fix typo. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15881
 2023-10-17 13:34:58 +01:00
Jeff Young e5225abb62 Tuning mode is invariant. 
Don't show target skew for length tuning, and don't show
target length for skew tuning.
 2023-10-17 13:30:58 +01:00
Jeff Young 89011e888c More modern look & feel for tuning status popup. 
(Also includes min and max info, and move string processing out
of router.)
 2023-10-17 13:30:58 +01:00
Jeff Young 390bd44f18 Cleanup. 2023-10-17 13:30:58 +01:00
Jeff Young 9ed802e951 Support min/max rules in diff pair placer and skew placer. 2023-10-17 13:30:58 +01:00
Jeff Young 9c4bb464ac Improve tuning status popup colours. 2023-10-17 13:30:58 +01:00
Wayne Stambaugh f629898c8b Coding policy fixes. 2023-10-17 08:07:15 -04:00
Alex Shvartzkop be1008cbd8 ADDED: Heal Shapes; Fix discontinuities in gfx import and Cleanup dialog. 2023-10-17 10:29:43 +03:00
Marek Roszko bee6e6be01 AddMenuLanguageList should live in EDA_BASE_FRAME, its only user 2023-10-16 19:49:52 -04:00
Marek Roszko 584757f2df Move the menu helpers to ui_common instead of sitting in bitmap for some reason 2023-10-16 19:40:46 -04:00
Marek Roszko ba83e84b91 Move SaveCanvasImageToFile to EDA_DRAW_FRAME rather than leaking things to bitmaps 2023-10-16 18:33:11 -04:00
SYSUeric66 9d4e0ba439 add python api FocusOnItem 2023-10-16 22:28:47 +00:00
Wayne Stambaugh b5eee9dd7e Coverity warning fixes. 2023-10-16 17:04:14 -04:00
Jeff Young a2e35aabae Trim meander group items to just the tuning pattern. 2023-10-16 13:44:05 +01:00
Jeff Young 2c9d43474d Formatting. 2023-10-16 13:44:05 +01:00
Jeff Young 64cc8dd6aa Adjust dashed-box and edit-point locations to be outside meanders. 2023-10-16 13:44:05 +01:00
Jeff Young d51e058e24 Move diff-pair netname resolution to BOARD. 
Also adds reporting of dp gap constaints and max uncoupled to track
selections, and max uncoupled during routing.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/13748
 2023-10-15 22:46:23 +01:00
Jeff Young 2c02c26af4 Centralize min/opt/max printing. 2023-10-15 22:46:23 +01:00
Jeff Young ccc20348bf Don't start with MEANDER_SIDE_DEFAULT. 
It means we get a different default for left-to-right-drawn than we
do when going the other way.

Also fixes bug in PNS::DP_MEANDER_PLACER so that it honours side
specified in settings.
 2023-10-15 17:59:11 +01:00
Jeff Young 2450250ae7 Use "tuning pattern" in the GUI. 2023-10-15 17:59:11 +01:00
Jeff Young 6baac175c5 Status bar messages for meanders. 2023-10-15 17:59:11 +01:00
Jeff Young 2b28580f0c Comments. 2023-10-15 17:59:11 +01:00
jean-pierre charras 7efd414519 Fix minor Coverity and compil warnings 2023-10-15 15:55:31 +02:00
Alex Shvartzkop fd887ba929 Altium: support importing a single footprint. 2023-10-15 06:31:00 +03:00
Alex Shvartzkop 254c8accc2 Remove some debugging messages. 2023-10-15 03:28:25 +03:00
Jeff Young d5d07e64c9 Use IsShownOnScreen(), not IsShown(), if you really want to know if its visible. 2023-10-14 23:51:37 +01:00
Alex Shvartzkop a16bdb7288 ADDED: Support EAGLE libraries directly in Symbol Library Table. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2214
 2023-10-15 01:45:39 +03:00
Alex Shvartzkop 9ed19192de Improve editing values with {return} in text fields; Add hyperlink detection. 2023-10-15 01:45:39 +03:00
Jeff Young 14d5a404b2 Don't leave deleted items in a group. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15797
 2023-10-14 18:23:51 +01:00
Jeff Young 504652b972 Regularize RunOnChildren() at the BOARD_ITEM level. 
BOARD_ITEM sub-classes which don't have children simply don't
overrid it.
 2023-10-14 15:04:18 +01:00
Jeff Young 8028ea893f Reduce public API of PCB_GENERATOR_MEANDERS. 
It doesn't make a huge difference because the class is declared in
the .cpp file, but it still makes it easier to understand what is
conceptually public and what is not.
 2023-10-14 15:04:18 +01:00
Jeff Young 5f5113c80a Pick up current rule values when editing meanders. 2023-10-14 15:04:18 +01:00
Alex Shvartzkop 61bdee027b Fix a crash when using length tuning tools. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15874
 2023-10-14 16:53:28 +03:00
Alex Shvartzkop f7ed9cc5c7 Fix loading thru-hole pads when drill token is missing. 2023-10-14 15:42:13 +03:00
Alex Shvartzkop 83af481688 Improve EAGLE file header detection. 2023-10-14 15:42:13 +03:00
jean-pierre charras 805f1dfbc5 Pcbnew: when adding layers, do not change via layers. 
Via layers are not defined by a LSET, and the code that used the new LSET
broke the Via start and/or end layers (for blind/buried vias)
Fixes #15856
https://gitlab.com/kicad/code/kicad/-/issues/15856
 2023-10-14 08:48:22 +02:00
Jeff Young 0a111e9fbb Hook up layer-toggle command to router. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15812
 2023-10-13 21:33:27 +01:00
Jeff Young 2bc273f8bc Don't fire event-parameter asserts when looking for a click event. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/KICAD-2CK
 2023-10-13 20:31:01 +01:00
Jeff Young 8d3047d6eb Clear selection before deleting board layers. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15866
 2023-10-13 18:20:33 +01:00
Jeff Young a69869f72a Simplify undo/redo for pad edit mode. 
Also simplifies high-contrast-mode handling to fix a bug when exiting
pad edit mode via an undo.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15845
 2023-10-13 13:59:31 +01:00
Jeff Young 62d959ed0e Don't assume an error location for PAD::GetEffectivePolygon(). 
While ERROR_INSIDE was good for plotting, 3D generation, etc., it's
not good for generating router hulls.

Also reverts part of the change to always use polygons for PNS::SOLIDs.  A single shape in a SHAPE_COMPOUND will be faster (and
more accurate).

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14898
 2023-10-13 13:59:26 +01:00
jean-pierre charras 38c7fa6db9 Pcbnew: do not display the outlines of a very special zone used by DRC 
to show layer mask bridges created by DRC to show these bridges.
This is not a real ZONE, just a container to displays these filled areas.
 2023-10-13 14:25:49 +02:00
jean-pierre charras 57efde1bbb Pcbnew: rename ZONE* m_SolderMask to m_SolderMaskBridges 
(It is a container to build bridges on solder mask layers by DRC, not real zone)
Disable also this special zone selection by adding it in
PCB_SELECTION_TOOL::itemPassesFilter
 2023-10-13 09:57:21 +02:00
Jon Evans 96f9f2c658 PNS: Allow for approximation error in hull clearance 
Also revert to using exact hulls for non-compound shapes

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14898
 2023-10-12 22:55:34 -04:00
Jon Evans 660c407095 ADDED: Control of multi-layer plot order from plot dialog 
Enabled by 0b136ae0
 2023-10-12 21:52:37 -04:00
Thomas Pointhuber 7cb198e021 fix SEGV in pcb_generator_meanders 2023-10-12 21:47:34 +02:00
jean-pierre charras 79a45c4803 TestBoardOutlinesGraphicItems(): handle small arcs. 2023-10-12 19:59:11 +02:00
Jeff Young af020f4f9a Fixes for diff-pair meander rectangle & edit points. 2023-10-12 17:54:34 +01:00
Jeff Young 78ee6f2e42 Fix a couple of undo bugs. 
The first caused items coming back from undo to be hidden.

The second caused them to be ungrouped from the parent meander.
 2023-10-12 17:54:34 +01:00
Jeff Young cdc9c2e409 Fix undo bug where items come back hidden. 2023-10-12 17:54:34 +01:00
Jeff Young 16d904d47e Add support for diff-pair meanders. 2023-10-12 17:54:34 +01:00
Jeff Young d4b8b550f3 Go back to using VIEW::Hide() instead of ForcedTransparency(). 
(The issue was that the selection VIEW_GROUP drawing ignores the
HIDDEN flag so we need to make sure the PCB_GENERATOR_MEANDERS isn't
in the selection VIEW_GROUP while we're editing it.)
 2023-10-12 17:54:34 +01:00
Jeff Young 1b676985f6 Retire length tuning tool in favour of first-class meanders. 2023-10-12 17:54:34 +01:00
Jeff Young 1ca477aeee Unroll from PICKER_TOOL so we can handle amplitude/spacing events. 
Also fixes a bug where we didn't clear the router on an <ESC>.
 2023-10-12 17:54:34 +01:00
Jeff Young d6c2ad7503 Unroll from PICKER_TOOL so we can handle amplitude/spacing events. 
Also fixes a bug where we didn't clear the router on an <ESC>.
 2023-10-12 17:54:34 +01:00
Jeff Young 1aeccc5895 Unroll from PICKER_TOOL so we can handle amplitude/spacing events. 2023-10-12 17:54:34 +01:00
Jeff Young a57c9967f3 Draw meander borders while placing. 2023-10-12 17:54:34 +01:00
Jeff Young 4da3e0ff93 Make meander dashed-line borders constant size. 2023-10-12 17:54:34 +01:00
Jeff Young d04641c868 ADDED: support for editing target length in Meander Properties dialog. 
Also supports overriding the custom rules.
 2023-10-12 17:54:34 +01:00
Wayne Stambaugh e3c491424b Coding policy, Doxygen comment, and spelling fixes. 2023-10-12 12:27:30 -04:00
jean-pierre charras a7d540ce94 TestBoardOutlinesGraphicItems(): add missing case. 
DRC_TEST_PROVIDER_MISC::testOutline(): use a smaller size to dectedt small items.
 2023-10-12 15:53:21 +02:00
jean-pierre charras 499f3ca95b DRC_TEST_PROVIDER_MISC::testOutline(): add test to detect questionable items. 
Graphic items (segments, rects, circles) on Edge.Cuts can create issues when
building board outlines, when they are very small (a few nm in size), because
they are not easily handled when trying to search connected graphics.
Also protect RC_ITEM::SetItems() against null pointer.
Fixes #15865
https://gitlab.com/kicad/code/kicad/-/issues/15865
 2023-10-12 14:48:24 +02:00
Alex Shvartzkop 0ea85ec9f5 Restore fill polygons on proper layers when flipping zones. 2023-10-12 02:21:47 +03:00
Jon Evans 0b136ae0df CLI: Allow controlling layer order for multilayer plots 2023-10-11 00:18:58 +00:00
Jeff Young d8f35633d4 Modify interactive delete tool to respect groups & selection filter. 2023-10-10 16:04:54 +01:00
Jeff Young 8c017be24a Clearer naming. 2023-10-10 15:43:45 +01:00
Jeff Young 0683313ecb Fix ghosted image while moving meander. 
Also cleans up some undo description strings.  (They go in the menu
so they should be title-caps.)
 2023-10-10 15:24:58 +01:00
Jeff Young d3b50f0607 Cleanup (no functional changes). 2023-10-10 13:42:42 +01:00
Jeff Young 04e23bf5e3 Fix build. 2023-10-10 12:58:12 +01:00
Jeff Young d916e650f1 Tuning status popup for point editor. 2023-10-10 11:55:57 +01:00
Jeff Young bb74445dda Code clarity. 2023-10-10 11:14:47 +01:00
Jeff Young 4226839586 Switch to diff-pair mode if startItem is a diff-pair member. 2023-10-10 11:08:53 +01:00
Jeff Young 099e5dd9e7 More undo bugs. 2023-10-09 22:32:32 +01:00
Jeff Young 994f9f8823 Cleanup & compiler warnings. 2023-10-09 22:32:32 +01:00
Jeff Young 642938455e Add status popup for meander placer. 2023-10-09 22:32:32 +01:00
Jeff Young 1afa6ddbd5 Rename getLineBetweenPoints() to getLine(). 
While it uses the first point to find the line, it in fact returns
the entire connection, not just the part between the two points.
 2023-10-09 22:32:32 +01:00
Jeff Young 44e0821e13 Fix some issues with undo. 
Also fixes the baseline being visible while placing the meander.
 2023-10-09 22:32:32 +01:00
Jeff Young d10b0b053e Move meander placer picker tool from item highlighting to net highlighting. 2023-10-09 22:32:32 +01:00
Jeff Young b662ff4956 Improve graphical feedback while placing a meander. 2023-10-09 15:22:41 +01:00
Jeff Young 60a2439a53 Better spacing in the meander properties dialog. 2023-10-09 15:22:41 +01:00
Jeff Young 35d8635a6b Default skew tuning lenght to diff between N/P, but allow override. 2023-10-09 15:22:41 +01:00
Alex Shvartzkop 21adc0aac5 ADDED: Import vector graphics into Schematic editor (SVG, DXF). 2023-10-09 07:04:50 +03:00
Alex Shvartzkop 60d069757a ADDED: Import vector graphics into Symbol editor (SVG, DXF). 2023-10-09 07:04:50 +03:00
Alex Shvartzkop f4f8523c59 Rename pcbnew DIALOG_IMPORT_GFX -> DIALOG_IMPORT_GFX_PCB 2023-10-09 07:04:50 +03:00
jean-pierre charras c9d6e79d2d Fix minor compil warnings. 2023-10-08 15:04:45 +02:00