haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
38,070 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

9980 Commits

Author SHA1 Message Date
Jeff Young 4b427b2d0c Add second instance of "don't mess up user formatting" fix. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13989
 2023-02-25 16:31:16 +00:00
Jeff Young 2e5bf0210a Clear model name when switching to internal model. 
Also fixes a bug to ensure that a modelLine gets written when using
an internal model.

Fixes https://gitlab.com/kicad/code/kicad/issues/14083
 2023-02-25 15:22:20 +00:00
Jeff Young 9a0aeb4344 Adjust AC-small-signal plot names when saving placeholders. 
Fixes https://gitlab.com/kicad/code/kicad/issues/14016
 2023-02-25 13:26:33 +00:00
Jeff Young ee956673b1 Respect readOnly cells in GRID_TRICKS. 
Also fixes setting colors in the signals grid as it allows us to make
it editable again.

Fixes https://gitlab.com/kicad/code/kicad/issues/14079
 2023-02-25 11:02:12 +00:00
JamesJCode 9dca70a773 Eeschema netlist output: Propagate NC across hierarchical schematics 
Fixes #12580

Additionally does not export no_connect netlist annotation on pins
which are both connected to another pin and a NC item, unless all
connected pins are stacked at the symbol level.

Adds testing of pin types to netlist QA unit tests.
 2023-02-25 00:02:46 +00:00
Jeff Young 2b96161d0e Log new undo record at the start of Change Symbols. 
Also fixes a bug where the "screen" variable was used with stale
data.

Fixes https://gitlab.com/kicad/code/kicad/issues/14061
 2023-02-24 22:41:46 +00:00
Jeff Young 5a12e5ee76 Only write included models if they have overridden parameters. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13953
 2023-02-24 20:31:35 +00:00
Jeff Young c188318174 Change strategy for committing values from SIM_MODEL propGrid. 
Note that the PCB editor's propGrid doesn't seem to need this workaround,
but I haven't yet figured out what's different between it and the sim model
propGrid.

Fixes https://gitlab.com/kicad/code/kicad/issues/13852
 2023-02-24 14:22:00 +00:00
Jeff Young 200a06a677 Cleanup some dead code, and add a potentially needed fix for non-Mac. 
(The Mac bug is fixed in 4e5b1da81fce7cd9ffedaec878ed07bfcfff4fe2 in
our wxWidgets fork.)
 2023-02-24 12:44:55 +00:00
Jeff Young 8059edff0e Don't mess up user formatting if eval'ing didn't actually change value. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13989
 2023-02-24 12:44:55 +00:00
Jeff Young 71df3f9edb Don't allow extra text in Sim.* fields. 
(In particular, the field name.)

Fixes https://gitlab.com/kicad/code/kicad/issues/13996
 2023-02-24 12:44:55 +00:00
Jeff Young be54ab396e Move selection shadows to overlay. 
This change doesn't appear to have any effect, but I think it's
correct.
 2023-02-24 12:44:55 +00:00
Jeff Young ddf8d115c4 Handle de-highlighting items outside selection when selection changes. 
Also adds selection cleared event to handled events.

And a small performance boost to not scan items for selection changes
when find is not seleciton-based.
 2023-02-24 12:44:55 +00:00
jean-pierre charras 2b3eb0b522 fix minor compil warnings 2023-02-23 09:50:28 +01:00
Jeff Young 4917abe655 Make sure whitespace at end of command doesn't mess up detection. 
(Fixes the failing test case.)
 2023-02-22 23:29:13 +00:00
aris-kimi 22bca5c2a0 Disable link maps by default and fix compile issue with lld linker 
The link maps were actually disabled by default before
912f1d5cec, and required KICAD_MAKE_LINK_MAPS
to be provided to enable them. So switch back to disabling them by
default.

Also, The lld linker is unable to accept a single dash cref option, while
ld and gold can. Instead, use the double dash version that is supported
by all three.

xref: https://github.com/llvm/llvm-project/issues/60932

Co-authored-by: aris-kimi <aris_kimi@hotmail.com>
Co-authored-by: Ian McInerney <ian.s.mcinerney@ieee.org>
 2023-02-22 23:18:36 +00:00
Stefan 04165b22d1 Altium Schematic Import: add note that blanket's are not yet supported 2023-02-22 23:10:40 +00:00
Fabien Corona cdbb868198 sim - allow users to delete several measurements at once 2023-02-22 19:27:20 +01:00
Fabien Corona 9006f38e70 sim - Don't allow user to delete the type-in measure entry 2023-02-22 19:27:20 +01:00
Fabien Corona 1170fb2e18 sim - don't create measurement duplicates 2023-02-22 19:27:20 +01:00
Fabien Corona aa006e9b91 sim - allow to add several measurements at once. 2023-02-22 19:27:20 +01:00
Mike Williams 959a19a461 Power Symbols: automatically fix mismatched legacy symbols, add tests 
Has netlist generation test for legacy power symbols, and test for
fixing legacy mismatched power symbol text fields and invisible pin names.
 2023-02-22 18:01:47 +00:00
Mike Williams 5995e0e516 Power Symbols: make value editable, use as netname 
QA: update tests for editable power symbol values
 2023-02-22 18:01:47 +00:00
Mike Williams ca5004b1d2 Power Symbols: rename IsPowerConnection to IsGlobalPower 
It's kind of confusing because we have power type pins, and pins that
make global power nets as part of power symbols.
 2023-02-22 18:01:47 +00:00
Mike Williams dd461d6ad6 Power Symbols: drop requirement for invisible pins 2023-02-22 18:01:47 +00:00
Jeff Young 6fcae34f6b Clear operating points on all sim types. 
(We'll fill them back in if we have data.)

Also improves handling when a plot tab is closed.

Also fixes dirtying of the view for op changes.

Fixes https://gitlab.com/kicad/code/kicad/issues/13990
 2023-02-22 15:54:18 +00:00
Jeff Young fe2679d965 Implement default levels for JFETs, MOSFETs and MESFETs. 2023-02-22 15:54:18 +00:00
Fabien Corona ae3a5c1c5f sim - set the dialog list as read only 2023-02-22 15:54:49 +01:00
Fabien Corona f2419e9e9b sim - Fix power graphs 2023-02-22 13:18:12 +01:00
Jeff Young cb71ea872b Don't allow 0 field text size. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13987
 2023-02-22 11:40:49 +00:00
Fabien Corona e24ddd0be4 ADDED: Measurement on power signals and integrals 
Fixes #14028
 2023-02-22 12:11:09 +01:00
Jeff Young f828d50cb0 Better processing of single-empty-row rule for measurements grid. 2023-02-22 10:45:27 +00:00
Jeff Young 5fa7be0320 Update signals after running a sim. 
Fixes https://gitlab.com/kicad/code/kicad/issues/14016
 2023-02-22 10:45:27 +00:00
Jeff Young a126d961d8 More dead code removal and a bit of formatting and const& for strings. 2023-02-22 10:45:27 +00:00
Jeff Young 68fe146861 Remove most of SIM_VALUE in favour of good old wxString. 
This allows us to save the user's intent, including units, formatting,
and crucially variable references.
 2023-02-22 10:45:27 +00:00
Jeff Young 29f21cdde6 Terminology and more dead code. 2023-02-22 10:45:27 +00:00
Jeff Young 90adc26b73 Remove dead and redundant code. 2023-02-22 10:45:27 +00:00
Chris Morgan 80b55f5980 Symbol editor: simpler creation of a new derived symbol 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13407
 2023-02-22 01:49:46 +00:00
Ian McInerney 912f1d5cec Modernize setting link map linker flags 2023-02-22 01:44:06 +00:00
Ian McInerney bcb93e9aa7 Modernize setting of compiler definitions in CMake 
add_compile_definitions was added in 3.12, and our minimum is now
greater than that.
 2023-02-22 01:44:06 +00:00
Marek Roszko 39e69a3d29 Fix up handling of font names available in multiple names 
ttf fonts can declare multiple language names. Many by default opt to just declare one and not tag it any particular language.
However, there are CJK languages that typically leverage this function the most. They'll tag both a "en" and a cjk lang family name in CJK characters.

To be as user friendly as possible, we need to display said fonts in the CJK languages if KiCad to set to such a locale.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14011
 2023-02-21 20:26:41 -05:00
aris-kimi 543a3317b4 Fix typo 2023-02-21 18:01:13 +00:00
Jeff Young 761b59da90 Read and write user-defined signals and measurements to workbook file. 2023-02-21 13:32:01 +00:00
Jeff Young 7fd707952b Easier editing of new sim measurements. 2023-02-21 13:32:01 +00:00
Jeff Young 6fcb95b24e ADDED user-defined signals. 2023-02-21 13:32:01 +00:00
Jeff Young f6fcae479c Don't generate error messages fetching sim data we know isn't there. 2023-02-21 13:32:01 +00:00
jean-pierre charras b05b33a9ff Fix a compil issue with gcc12.2 and Coverity warnings. 2023-02-21 11:54:38 +01:00
Fabien Corona 3751b250c6 sim - fix a QA case for XSPICE 2023-02-20 19:40:59 +01:00
Fabien Corona 869447fedd sim - ngspice does not support .probe p(Adevice) 
Fixes #13979
 2023-02-20 19:30:45 +01:00
Fabien Corona 2a3b70b7eb sim - Remember the option to save powers 
Fixes #13978
 2023-02-20 19:30:45 +01:00
jean-pierre charras 31be74b8b3 Fix a few Coverity warnings 2023-02-20 09:25:01 +01:00
Marek Roszko d55e2049e5 Silence some warnings with static_casts 2023-02-18 23:36:50 -05:00
Marek Roszko aacc9746e3 Yeet the last of wxSize/wxPoint to stop leaking gdicmn everywhere 2023-02-18 22:57:18 -05:00
Marek Roszko dffd2da8c8 Fix the shared_lock added and micro-opt the reindex 2023-02-18 11:28:19 -05:00
Fabien Corona facd50f4fd sim - missing assignment 2023-02-18 15:36:47 +00:00
jean-pierre charras 07f79208b9 Minor fixes: Coverity and compil minor warnings. 2023-02-18 13:04:43 +01:00
Fabien Corona 5482bc2905 sim - Check FindParam() results before using them 2023-02-18 12:54:55 +01:00
Fabien Corona f5902dad28 sim - don't write dc parameter twice 2023-02-18 10:07:29 +00:00
Fabien Corona fa0cc09917 sim - allow sources that are both AC and TRAN 2023-02-18 02:17:48 +00:00
Fabien Corona 39a1b14a0f sim: VSIN - allow user to specify a phase 
TD is not the same as PHASE.
TD is the delay before the source turns on.
PHASE is ... the phase

If only TD is set, the signal starts later, but the phase is still 0 when compared to the t=0 of the simulation.
 2023-02-18 00:38:46 +00:00
qu1ck 2975f53647 PCM: auto reload global libs after dialog is run 
This adds Reset() method to KIFACE to reload global libs stored in
global static vars.
Also refactors some lib reload code in various frames to have
common MAIL_RELOAD_LIB handler.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/12500
 2023-02-17 17:24:32 +00:00
Jon Evans fc68b8d71a Make selected background layers translucent 
We can't render them underneath other objects, but we can at least
make it possible to see other objects through them.
 2023-02-16 22:45:29 -05:00
Alex bd4758e4df Keep image sizes when loading/saving 7.0- schematic file formats. 
Previously, images were assumed to have 300 PPI density when loading from
schematic, but not after initial placement.
 2023-02-17 03:53:44 +03:00
Alex ecb28ddf1c Prevent ghost image after canceling bitmap placement. 2023-02-17 03:53:44 +03:00
Jeff Young 8b1318c92f Update associated data structures after changing trace colour. 
Also removes likely benign but never-the-less useless grid even processing
during rebuilding of the grids.

Fixes https://gitlab.com/kicad/code/kicad/issues/13956
 2023-02-17 00:47:01 +00:00
Paweł Płóciennik 614755f24e Dialogs autocompletion with backspace support. 2023-02-16 23:28:27 +00:00
Jon Evans 053d20e13d Fix selection overlay being wiped when changing sheets 2023-02-16 17:14:08 -05:00
Jeff Young d5e50b70bb Display a generic "Value" column label when there are no cursors. 2023-02-16 16:55:26 +00:00
Jeff Young f50d114b27 Push gain & phase for .probe statements in AC analysis. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13941
 2023-02-16 16:14:25 +00:00
Jon Evans ec2fc161e1 Handle another case where schematic view was being cleared 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13944
 2023-02-16 08:25:18 -05:00
Jeff Young 5967ab9a4d Don't allow SCH_LABEL_LOCATE_ANY_T to steal SCH_LABEL_LOCATE_WIRE_T's items. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13936
 2023-02-16 13:21:00 +00:00
Jon Evans 955a5a13eb Symbol editor: stop removing overlay from view 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13944
 2023-02-16 08:17:12 -05:00
Jeff Young 95232edd0d Do a better job of looking for .probe commands in directives. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13941
 2023-02-16 12:42:54 +00:00
Jeff Young d8a4f9821e Smarten regex to accept ':' in signal names. 
(In fact, just accept anything up to the closing paren.)

Fixes https://gitlab.com/kicad/code/kicad/issues/13942
 2023-02-16 12:20:55 +00:00
Jon Evans 0f18a36f8f Fix handling of selection overlay in schematic editor 
We weren't actually using the overlay group at all

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11142
 2023-02-15 21:16:58 -05:00
Seth Hillbrand a761b0e860 Force DNP X to foreground 2023-02-15 11:35:24 -08:00
Jeff Young c618bb7046 Correctly netlist a voltage source with both AC and DC values. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13912
 2023-02-15 14:50:31 +00:00
Jon Evans e8a88411ea Set PPI properly in schematic bitmaps, too 2023-02-14 21:37:00 -05:00
Jeff Young 64f1808d60 Don't use the just-in-time model resolver when updating the dialog. 
If it changes in the middle it will leave you in a world of hurt.

Also don't update the library after a loss-of-focus unless the path
really changed.

Fixes https://gitlab.com/kicad/code/kicad/issues/13869

Fixes https://gitlab.com/kicad/code/kicad/issues/13854
 2023-02-15 00:31:04 +00:00
Jon Evans 29c4482bc8 Symbol chooser: save UI settings even when canceled 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13903
 2023-02-14 18:26:29 -05:00
Jon Evans 0913552f84 Handle custom columns in symbol tree synchronizing adapter 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13907
 2023-02-14 18:26:29 -05:00
aris-kimi dca1281263 Fix some typos 2023-02-14 23:47:05 +02:00
Mike Williams 18df4442bc Schematic: Find and Replace on Selection 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9293
 2023-02-14 14:04:59 -05:00
Seth Hillbrand 9f8b25a0b0 Don't desaturate the selection shadow 
Selection shadows are helpful when showing which elements are selected
and there is no benefit (and some downside) to having their color
removed.

Fixes https://gitlab.com/kicad/code/kicad/issues/13878
 2023-02-14 10:22:05 -08:00
Jeff Young 50eaba4211 Performance fix for switching pages. 2023-02-14 17:14:31 +00:00
Jeff Young 03484aedbc Workaround wxWidgets enforced min pen width by using transparent pen. 
Also fixes some bugs in our shape printing code when a border is not
specified but a fill is.

Fixes https://gitlab.com/kicad/code/kicad/issues/13891
 2023-02-14 14:44:04 +00:00
Mike Williams 76fb598ac2 Annotate: cleanup to use enum values instead of numbers 2023-02-14 08:21:43 -05:00
Mike Williams 4b07e3e413 Common Actions: Find Previous 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8968
 2023-02-14 08:21:37 -05:00
Mike Williams 3e715c99c8 Swap: take S key now that it's available 2023-02-14 07:42:06 -05:00
Jeff Young 9ce18dffdd Better startup experience for simulator. 
Pre-load signals list (and plot panel if there is an schText simulation
command).

Also fixes a bug where the workbook was getting dirtied on open because
the events would fire after the dirty flag had been cleared.
 2023-02-14 11:59:17 +00:00
Jeff Young be0a9e2738 Handle SPICE prefixes for operating point data. 
Also adjusts the min-pin lenght as some symbols have very short pins.
 2023-02-13 18:38:43 +00:00
Jeff Young b53e0a85b8 Don't display OP overlay when we have no data. 
Also fixes a copy-pasta bug with settings (and adds a fixup for those
already bitten by it).

Fixes https://gitlab.com/kicad/code/kicad/issues/13881
 2023-02-13 18:08:53 +00:00
Jeff Young 8bab429c7d Account for border when calculating text margin for text boxes. 
Also fixes some unnoticed issues with the textbox dialogs (probably
dating from the move to wxWidgets 3.2).

Fixes https://gitlab.com/kicad/code/kicad/issues/13877
 2023-02-13 17:08:29 +00:00
Jeff Young d6bef19811 Don't confuse .OP with .OPTIONS. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13849
 2023-02-13 13:33:26 +00:00
Jeff Young e6d45e27e8 Fix layout issue in IBIS fields. 2023-02-13 12:43:32 +00:00
Jeff Young df00585a55 ReadDataFields must be a separate step from Create. 
Create() is done without execption processing, while ReadDataFields
should have exception processing.

(This also fixes a case where exception processing on ReadDataFields
was missing.)

Also fixes a bug where the pinSelect menu wasn't checked for -1 before
fetching.

Fixes https://gitlab.com/kicad/code/kicad/issues/13856
 2023-02-13 12:43:25 +00:00
Marek Roszko 2cc3d8e9bc Prevent a crash when a spice SW_I lacks two pin net names 
Fixes KICAD-5D
 2023-02-12 22:26:19 -05:00
Jeff Young 74eb587291 Better sorting within sections (voltage, current, power). 
Fixes https://gitlab.com/kicad/code/kicad/issues/13846
 2023-02-12 23:16:45 +00:00
Marek Roszko 4665823089 Turn on and fix MSVC compliance mode issues 
We want /permissive- to enable debug performance improvements in MSVC 17.5+.
This flag is also default under C++20 so we'll have to deal with these compile issues anyway at some point in the future.

In particular, MSVC becomes pedantic about ternary types.
See https://learn.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-170#ambiguous-conditional-operator-arguments

MSFT cites https://cplusplus.github.io/CWG/issues/1805.html
 2023-02-12 16:30:37 -05:00
Graham Keeth 6af3dadaee Fix SPICE pins for BJTs and MESFETs 
- MESFETs don't have a substrate/bulk pin
- BJTs have a substrate pin, and HICUM/VBIC have TJ

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13848
 2023-02-12 21:20:02 +00:00
Jeff Young a22964a977 Prepend correct SPICE prefix when necessary for plotting currents. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13850
 2023-02-12 21:17:45 +00:00
Jeff Young 1e756dbdd8 Save cursor positions in sim workbook. 2023-02-12 20:40:23 +00:00
Jeff Young 83dd06e5d1 Allow opening of workbook when simulation frame is opened. 
This involved splitting creation of traces from setting of trace
data.

Also renamed SIM_WORKBOOK to SIM_NOTEBOOK.  This class is a subclass
of wxAiuNotebook and represents the collection of simulation plot tabs.
It is NOT the same thing as a simulation workbook, which contains other
stuff such as measurements, plotted signals, colours, etc.

This also removes a bunch of "friend" declarations.
 2023-02-12 20:40:23 +00:00
Jeff Young 78746b77c6 Save trace colors and cursor value formatting in sim workbook. 2023-02-12 20:40:23 +00:00
Jeff Young 84c72b087c Simplify (and fix) logic for starting new simulations. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13853
 2023-02-12 20:40:23 +00:00
jean-pierre charras 1fb2d138b4 Fix a compil issue. 2023-02-12 09:16:42 +01:00
Jeff Young 9d3a3d705d ADDED simulation measurements. 2023-02-11 21:11:07 +00:00
Jeff Young e5176ff4d6 ADDED power dissipation plotting and cursors. 
Also fixes a bug so that voltages, currents and power dissipations are
only probed if the flag is set -- this keeps ngspice from throwing an
error if you probe something twice (for instance, if you have .probe
commands in text and turn off the auto-probing).
 2023-02-11 21:11:07 +00:00
Jeff Young bc108023b3 ADDED operating point overlay for SCH_EDIT_FRAME. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11253
 2023-02-11 21:11:07 +00:00
Jeff Young 2a5bb71fbd ADDED operating point text variables for labels and symbols. 
ADDED formatting for cursors and operationg points

Also fixes a bunch of bugs to make the new cursors work with .ac sims.

Fixes https://gitlab.com/kicad/code/kicad/issues/11253

Fixes https://gitlab.com/kicad/code/kicad/issues/6965
 2023-02-11 21:11:07 +00:00
Jeff Young b3ffbd6258 Don't include unconnected nets in signals list. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4961
 2023-02-11 21:11:07 +00:00
Jeff Young 7e6c68b1d1 Remove (probably) redundant code. 2023-02-11 21:11:07 +00:00
Jeff Young 39d35a8bec Better cursor feedback for plot window. 2023-02-11 21:11:07 +00:00
Jeff Young 9a99106981 Cleanup. 2023-02-11 21:11:07 +00:00
Jeff Young f0bd25b397 ADDED use-settable simulation trace colors. 
Fixes https://gitlab.com/kicad/code/kicad/issues/2536
 2023-02-11 21:11:07 +00:00
Jeff Young 09822c7f18 ADDED direct access to signals & cursors. 
ADDED differential cursors.

Fixes https://gitlab.com/kicad/code/kicad/issues/4447

Fixes https://gitlab.com/kicad/code/kicad/issues/6221
 2023-02-11 21:11:07 +00:00
Jeff Young 95fb3825bd Fix some strings from V7's string freeze. 2023-02-11 21:11:07 +00:00
Jeff Young 6bc89ee180 Don't disable run when there's no command: just ask for a command. 2023-02-11 21:11:07 +00:00
Jeff Young 7d7a48070e Separate error messages when sim model and project paths are the same. 2023-02-11 21:11:07 +00:00
Jeff Young a1a1a49729 On-the-fly language updates for simulator window. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13357
 2023-02-11 21:11:07 +00:00
Jeff Young b000d68def Move simulator to tool framework. 2023-02-11 21:11:07 +00:00
Jeff Young 02e14b45ee Better predictability and error reporting for running external SPICE. 2023-02-11 21:11:07 +00:00
Jeff Young 946e0a4b98 ADDED support for e-series based tuning. 2023-02-11 21:11:07 +00:00
Jeff Young 7bc79c17d4 Make sure screen RTrees are updated when changing bounding boxes. 2023-02-11 20:43:00 +00:00
Jeff Young 9ce5978c3d Bug fixes for LIB_PIN boundbox generation. 2023-02-11 20:43:00 +00:00
Jeff Young 2e9ed67e05 Don't dirty connectivity when moving non-reference SCH_FIELD. 2023-02-11 20:43:00 +00:00
Jon Evans a6776edc26 Try to resolve worksheet filename before saving it 
The new code was added to handle saving imported worksheets,
but it is possible to specify relative paths to worksheets
not only to the project folder but also to the global
templates directories.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/13834
 2023-02-11 10:33:23 -05:00
Alex 93020cf78f Set select_pin_selects_symbol to false by default. 2023-02-11 16:51:55 +03:00
Alex 81a55c42a1 Fix unintentional string change in IBIS parser. 2023-02-11 02:19:06 +03:00
Paweł Płóciennik 06e3e63b96 Eeschema: text properties: reference field autocomplete ignores first char. 2023-02-10 21:56:03 +00:00
Marek Roszko c22fb390ec Set the text proeprties grid bag to avoid reserving space for hidden cells 2023-02-09 23:04:51 -05:00
Jeff Young d4ca54a798 Handle global label offset when plotting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13301
 2023-02-09 18:02:21 +00:00
jean-pierre charras 3d23d0e16a Fix compatibility with wxWidgets 3.0.5 
Fixes #13808
https://gitlab.com/kicad/code/kicad/issues/13808
 2023-02-07 21:09:03 +01:00
Jeff Young 77d4704b45 Don't return a lib-tree symbol if the lib-tree is hidden. 2023-02-07 15:53:14 +00:00
Chris Morgan e14f0848fa SCH_EDITOR_CONTROL::Paste() - Adjust refdes behavior to match when creating new symbols 
Pass 'false' as aStartAtCurrent to ReannotateByOptions(). Causes Pasing() symbols to start at the first available refdes after the currently
configured annotate start number, m_annotateStartNum.

Fixes #13342
 2023-02-06 14:05:04 +00:00
jean-pierre charras 4065e413ea Ibis parser: do not report activity when there are no errors. 
The dialog to add a library expects no message when there are no error.
Fixes #13794
https://gitlab.com/kicad/code/kicad/issues/13794
 2023-02-06 12:55:52 +01:00
jean-pierre charras 92724ff09f Coding style fix. 2023-02-06 07:59:17 +01:00
Jeff Young 3ecd6ec186 Fix variable updating in SCH_FIELDs (which are not directly in the view). 2023-02-05 20:51:03 +00:00
jean-pierre charras fb225acefc Eeschema, ExportSymbolsToLibrary(): fix not working replace library. 
When exporting symbols of the schematic to a new library, if this library
exists the dialog ask for overwriting it, but it did not work.
Fixed now.
 2023-02-05 18:41:58 +01:00
Wayne Stambaugh baeeeec492 Fix broken update symbol from library. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13782
 2023-02-05 10:36:18 -05:00
Jeff Young d1f6ba77e8 Better error reporting, and don't infer models with library references. 2023-02-04 20:55:52 +00:00
Jeff Young 9be872a85a Better bounds checking for DIALOG_SIM_MODEL::curModel(). 
Fixes https://gitlab.com/kicad/code/kicad/issues/13767
 2023-02-04 20:16:50 +00:00
Jeff Young 56a1cdb4dc Allow a limited set of un-braced expressions in SPICE model values. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13768
 2023-02-04 19:49:48 +00:00
Jeff Young f588da2bef Bounds checking for DIALOG_SIM_MODEL::curModel(). 2023-02-04 19:17:13 +00:00
Wayne Stambaugh 52b07b8bac Fix duplicate symbol value fields when importing Eagle schematic. 
Don't use the value field when adding Eagle part attributes to a symbol.
This issue was cause by using a mandatory symbol field ID instead of
using the next available field ID when adding new fields to as symbol.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/13468
 2023-02-04 12:37:41 -05:00
jean-pierre charras 6b5eeeb861 Preferences dialog: try to reduce its width, in non English languages. 
Remove some useless spacers, and do not force some widgets to have a to
large size (by removing empty areas).
Work in progress: one panel is still too big.
 2023-02-04 14:36:14 +01:00
Jeff Young e8397a33bb Refrain from copying SPICE_INFO. 2023-02-04 00:05:50 +00:00
Graham Keeth a51dc8c9de HiSIM_HV MOSFET models are *not* the default type 
The ngspice manual does not indicate that there is any default
model type. This change ensures we get a `level=xy` written out to the
.model line when we select a HiSIM_HV model.
 2023-02-04 00:03:25 +00:00
Graham Keeth 5abe1a201b spice: generate .model lines for all device types 
- generate .model lines in spice netlist for all device types that need
  one
- add "level=<n>" to .model line for non-default model levels. This is
  necessary to allow more sophisticated models to be used, and some
  devices *always* need a level specified (e.g. JFETs)
- add "version=<n>" to .model line for models that have multiple
  versions available (AFAIK only affects HiSIM_HV MOSFET models)

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13775
 2023-02-04 00:03:25 +00:00
Graham Keeth 41c4ee2245 ngspice requires J prefix for JFETs in netlist 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13774
 2023-02-04 00:03:25 +00:00
Jeff Young ed5fb2769f Allow more characters (in particular '_') in code model names. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13769
 2023-02-03 23:49:53 +00:00
Jeff Young 71b8a2112c Coverty fixes. 2023-02-03 15:09:24 +00:00
Wayne Stambaugh a94d8a7e78 Use references instead of copies in map pair for loops. 2023-02-03 10:00:09 -05:00
Wayne Stambaugh 9e03a71b44 Fix broken value and footprint field text values. 
Only update value and footprint fields from instance data if it's not
empty.  These fields were not always stored in the instance data so
loading them from instance data that does not contain them will clear
the fields.

https://gitlab.com/kicad/code/kicad/-/issues/13735
 2023-02-03 09:48:18 -05:00
jean-pierre charras 8ce0a84ca7 Fix compatibility with older wxWidgets versions. 
Fix also a compil warning
 2023-02-03 08:24:38 +01:00
Graham Keeth 9b9ebebb2d Add missing autocomplete for FILENAME, PROJECTNAME 2023-02-03 00:10:55 +00:00
Wayne Stambaugh c88c4e1200 Fix schematic update library symbols issues. 
Rather than update library symbols one at a time, queue them up by
schematic symbol to prevent multiple updates to the same symbol in
complex hierarchies.  This also removes all of the library symbols
first which will clear out all of the library symbol variants that
were created by modifying library symbols in place and/or changes to
the symbol in the library.

Don't add new variant library symbol if an equivalent variant already
exists in the schematic local cache.  This prevents duplicate library
symbols from being added to the local cache when the first variant in
the cache does not match that of the symbol being added.
 2023-02-02 15:54:24 -05:00
Jeff Young 8b03c093f9 Move potentiometer pin model to r0, wiper, r1, and remove flipping code. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13741
 2023-02-02 16:22:13 +00:00
Jeff Young ab0c4dd292 Must do pin swap in model pins, not item pins. 
Item pins might not be in the same order.

Fixes https://gitlab.com/kicad/code/kicad/issues/13741
 2023-02-02 12:44:55 +00:00
JamesJCode 71002dce28 Eeschema: Fix export symbols to new library 
Exporting symbols to new library now saves the library and forces
update of symbol links

Fixes #13494
 2023-02-02 11:31:18 +00:00
Graham Keeth 4a0a5f2265 Fix backwards display of ${DNP} 
${DNP} displayed "DNP" when DNP was cleared, and "" when DNP was set
 2023-02-01 22:40:58 +00:00
vinsfortunato 5b9b555fdf eeschema: fix sheet symbol pins changing side when resizing 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13719
 2023-02-01 15:53:59 +00:00
Mike Williams ab954456ee Symbol Fields Table: don't leave Qty editable on error 2023-02-01 10:19:23 -05:00
Jeff Young 4c18dfebb9 Add Show Name column to FormBuilder files. 2023-02-01 12:36:27 +00:00
Jeff Young b4a75cd1d5 Write out a diode .model for built-in diodes. 2023-02-01 12:36:27 +00:00
jean-pierre charras 29fd1b45d6 Ensure the DATASHEET field value only is used to know the datasheet URL. 
previously, if the field option "show name" is set, the field name was
added to the URL, that broke it.
Fixes #13729
https://gitlab.com/kicad/code/kicad/issues/13729
 2023-02-01 11:37:07 +01:00
Alex 56f900b14f Remove errant wxTextCtrl style flags. 2023-02-01 06:22:32 +03:00
Mike Williams 29a4e2c7fe Schematic: fix reversed tooltips for navigation buttons 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13707
 2023-01-31 13:05:37 -05:00
JamesJCode 8590745e9c Allow simulation probe of junctions 
Fixes https://gitlab.com/kicad/code/kicad/issues/13712
 2023-01-30 23:15:55 +00:00
Seth Hillbrand 418f8e6f14 Re-add outline shadows to stroke fonts 
If we draw using stroke fonts, we can still use the legacy shadow
routine to show nice highlights
 2023-01-30 22:42:26 +00:00
Jeff Young 123467c8dd Don't throw up debug message when signal is deleted. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13711
 2023-01-30 21:32:18 +00:00
Jeff Young c939b1ef76 Followed-by-3-digits doesn't guarantee a thousands separator. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13708
 2023-01-30 21:22:48 +00:00
vinsfortunato 3d52115ae7 eeschema: focus eeschema on symbol when its row is selected in the symbol fields table 2023-01-30 15:12:57 +00:00
Mike Williams 207b8d3273 Symbol Fields Table: fix duplicated fields 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13687
 2023-01-30 09:29:47 -05:00
Marek Roszko f28339ded8 Hookup the skip drawingsheet arg 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13703
 2023-01-30 07:50:16 -05:00
jean-pierre charras 241a283b03 DIALOG_TEXT_PROPERTIES_BASE: reduce the window min width. 2023-01-30 13:21:38 +01:00
Marek Roszko fb57eac5f9 Add \n to report for cli 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13704
 2023-01-30 07:11:36 -05:00
vinsfortunato 12101b6cad eeschema: use correct sheet title block for plotting 
Fixes: https://gitlab.com/kicad/code/kicad/issues/13690
 2023-01-29 21:21:31 +00:00
vinsfortunato 586f22c2f7 eeschema: Focus eeschema on symbol when symbol fields table cell is selected with keyboard 
Fixes: https://gitlab.com/kicad/code/kicad/issues/13688
 2023-01-29 19:42:28 +00:00
JamesJCode 413169782a Add SIM_ENABLE_FIELD column name when excluding symbol from simulation 
Fixes #13691
 2023-01-29 09:48:05 +00:00
Wayne Stambaugh 68decdd4f2 Fix static event table derived object definitions. 2023-01-28 14:10:06 -05:00
Ian McInerney 51c8f2c119 Fix library sort order in library viewers 
The lib table returns a properly sorted list of libraries already, which
we just iterate through. A std::set is a sorted collection, but uses a
different sorting function than the lib table, so appending to a
std::set breaks the initial sorting that was done already.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13530
 2023-01-27 23:39:50 +00:00
Ian McInerney a78e5b0141 Hide empty sizer in directive label dialog 
Possibly fixes: https://gitlab.com/kicad/code/kicad/-/issues/13675
 2023-01-27 22:25:33 +00:00
Ian McInerney a91d2c21b8 Fix missing quotation mark in BOM plugin 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13685
 2023-01-27 21:46:53 +00:00
Vincenzo Fortunato f4e22cdcdb altium: import component image only if part id matches 2023-01-27 16:28:38 +00:00
aris-kimi b72cc23a00 Change one translatable "eeschema" string to "Schematic Editor" 2023-01-27 16:14:09 +00:00
Jeff Young e5749d0cda Position intersheet refs in imported Eagle schematics. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13667
 2023-01-27 13:59:11 +00:00
Alex a872ed11bf Fix paths for Copy default global library table. 2023-01-27 09:24:52 +03:00
vinsfortunato 39e85015c2 Preserve pins positions when resizing sheet 2023-01-26 20:56:37 +01:00
vinsfortunato cf1d17b566 Fix unexpected resizing behaviour when using top left edit corner 2023-01-26 20:54:51 +01:00
vinsfortunato 843600cb7e Fix erratical sheet pins behavior when resizing 
Fixes https://gitlab.com/kicad/code/kicad/issues/13658
 2023-01-26 20:54:51 +01:00
Gary Kim 0e939993bc Only expand when opening alternate pin definitions 
When opening alternate pin definitions collapsible
pane, only increase the window size to accommodate
the pane.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/13596
 2023-01-26 17:30:38 +00:00
Mike Williams 96e9cd6ecc Schematic: added drag wires should copy stroke 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13666
 2023-01-25 12:34:40 -05:00
Jeff Young 51293858b3 Allow empty lib tables. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13653
 2023-01-24 23:45:55 +00:00
JamesJCode f683df0d1f Minor fix to ERC dialog 
Correctly displays ERC aux item description when tied to specific
sheet context
 2023-01-24 18:44:47 +00:00
Seth Hillbrand 43e4797d4d Don't double-tap Connectivity Recalculate 
SCH_EDIT_FRAME::RecalculateConnections() calls SchematicCleanup and then
resets the connectivity graph and recalculates it.  OnModify() also
calls RecalculateConnections().  For long calculation schematics, this
can impact usability
 2023-01-24 10:30:52 -08:00
Seth Hillbrand 420eceecbb Simplify name caching 
We don't need two functions to get driver names.  The map should be
mutable to allow updates when needed.  C++17 gives some extra syntactic
sugar for map manipulation
 2023-01-24 10:30:52 -08:00
Wayne Stambaugh a83313c4ab Fix another build warning introduced by recent ERC changes. 2023-01-24 12:21:52 -05:00
Wayne Stambaugh 5638122d3d Fix build warnings introduced by recent ERC changes. 2023-01-24 10:42:41 -05:00
JamesJCode fef3274e8e Eeschema: ERC checks handle connections between a common sub-circuit 
Fixes #10926

Contains the following changes:

    - Adds a new ERC_SCH_PIN_CONTEXT class which is used to provide deterministic
      comparison between items causing ERC violations (e.g. pins) when associated
      with a SCH_SHEET_PATH context.

    - Adds association of SCH_SHEET_PATHs for ERC_ITEMs and the sub-schematic items
      which caused an ERC violation. This allows correct display of markers on the
      sheets of interest only, and allows correct naming resolution and cross-probing
      from the ERC dialog.

    - Adds a new ERC_TREE_MODEL class, derived from RC_TREE_MODEL, which correctly
      resolves component references across heirarchical sheets using the associated
      SCH_SHEET_PATHs. This allows sheet-specific component references to be displayed
      correctly in the ERC results tree.

    - Updates SCH_MARKER to only draw sheet-specific markers on the sheet causing
      an ERC violation.

    - Increments the schematic file version.

    - When loading a schematic with legacy ERC exclusions, discards those of type
      ERCE_PIN_TO_PIN_WARNING, ERCE_PIN_TO_PIN_ERROR, ERCE_HIERACHICAL_LABEL, and
      ERCE_DIFFERENT_UNIT_NET as there is no safe way to automatically infer the
      information which is now stored with these exclusions (sheet paths for error
      location and related items). Requiring users to (once) re-add exclusions is
      preferable to silently incorrectly matching new ERC issues to legacy exclusions.
 2023-01-24 14:11:01 +00:00
Jeff Young 7a113a6a44 Fix misleading label (it filters label fields and other sheet fields as well). 2023-01-24 00:07:40 +00:00
Jeff Young 220c5a259b Refresh schematic's copy of template fieldnames after preferences. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13203
 2023-01-24 00:07:40 +00:00
Jeff Young 4de64b607a Finish implementation of export_current_sheet_as_root. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13643
 2023-01-24 00:07:40 +00:00
Jeff Young 25783f3b7e Add label fields to Edit Text and Graphics Properties dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13632
 2023-01-24 00:07:40 +00:00
Jeff Young 4e50c5313d More safety for array access. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13583
 2023-01-24 00:07:40 +00:00
Graham Keeth e4a8b9e76d subckt export: add missing tristate pintype 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13644
 2023-01-23 23:26:48 +00:00
Seth Hillbrand 00f93db2ff Convert wide chars before reading model 
The PEGTL parser used by KiCad for SPICE models only handles ASCII
characters.  Despite the docs stating that you can, in theory, parse a
UTF-8 character by reading the base string, in pratice this does not
work as the UTF-8 string is represented by unsigned chars and the PEGTL
string is based on signed char.

To work around this, we need to convert micro and mu to the ASCII 'u'
equivalent

Fixes https://gitlab.com/kicad/code/kicad/issues/13642
 2023-01-23 15:23:41 -08:00
Seth Hillbrand 442ee52905 Add versioning to lib tables 
Sets lib table version to allow easier migration between versions
 2023-01-23 22:21:12 +00:00
Seth Hillbrand efe12f2da5 Cleanup variable naming 
Also remove ancient/unused code for lazy resolving
 2023-01-23 22:21:12 +00:00
Seth Hillbrand a9ed47f06c Update KICAD6->KICAD7 2023-01-23 22:21:12 +00:00
Mike Williams b39aae6a93 Annotation: don't select hover item 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13352
 2023-01-23 16:50:45 -05:00
Seth Hillbrand 9861ed1a5f Don't special case power symbol re-annotation 
When the designer asks to reset annotations, we reset all annotations
including power symbols.  This may create additional churn in the files
but only when requested and is useful to fix schematic errors

Fixes https://gitlab.com/kicad/code/kicad/issues/13138
 2023-01-23 13:19:01 -08:00
Seth Hillbrand 67c703e9e2 Fix LIB_TEXT plotting alignment 
LIB_TEXT is not all aligned to the center, so place the proper flags
when calling Plot.  This requires handling alignment offsets properly
when rotated as well
 2023-01-23 12:23:14 -08:00
jean-pierre charras 2443d91265 SCH_FIELD: fix issue when try to clear its color from a previous color, 
the old color was still used to display the field
Fixes #13631
https://gitlab.com/kicad/code/kicad/issues/13631
 2023-01-23 10:22:42 +01:00
jean-pierre charras e0111f709b Fix minor cosmetic issues in Print dialogs 
Fixes #13629
https://gitlab.com/kicad/code/kicad/issues/13629
 2023-01-23 09:21:23 +01:00
Jon Evans 1bc3f77d2e Coverity fixes 2023-01-22 22:48:31 -05:00
Jon Evans e7a4d6d4da Exclude database libraries from the symbol library editor 
These libraries are metadata libraries and it does not make sense
to have them be shown in the symbol editor

Fixes https://gitlab.com/kicad/code/kicad/-/issues/12842
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12878
 2023-01-22 20:49:41 -05:00
Jon Evans e419b0bfe8 Support sub-libraries in symbol library browser 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12842
 2023-01-22 19:25:15 -05:00
Marek Roszko 0ff32d20cd wxS more things 2023-01-22 09:41:42 -05:00
jean-pierre charras 9c12a6ee1d Eeschema, eeschema_config.cpp: fix incorrect *.wks file path when trying to save it. 
And add tests to see if the file can be saved
Fix also an issue in sch_editor_control.cpp: The page setup dlg must generate changes
only if the OK button is clicked.
Fixes #13599
https://gitlab.com/kicad/code/kicad/issues/13599
 2023-01-22 13:17:05 +01:00
jean-pierre charras e900e472ce Fix compil and Coverity warnings 2023-01-22 09:40:09 +01:00
Jeff Young 542719c753 Add "all" mode to HSPICE emulation. 2023-01-21 19:32:25 +00:00
Wayne Stambaugh 0a7bd85cd6 Fix library symbol rescue issues. 
https://gitlab.com/kicad/code/kicad/-/issues/13494
 2023-01-21 10:35:14 -05:00
jean-pierre charras 4eb3a99bb5 SYMBOL_VIEWER_FRAME: fix some (minor) issues related to the symbol to display 
Fixes #13274
https://gitlab.com/kicad/code/kicad/issues/13274
 2023-01-21 11:29:01 +01:00
Seth Hillbrand ed0d57ddf6 Handle the forced propagation to subgraphs 2023-01-20 15:20:03 -08:00
Seth Hillbrand e6dbca051c Force realtime connectivity on 
The pressure relief valve was not useful for common work patterns as it
forced the recalculation on many common actions such as bus expansion.
This caused it to actually feel slower than with the pressure relief
valve off.

For most schematics, realtime is now fast enough to not need the valve
and for those that are extremely complex, removing the valve helps this
run more predictably
 2023-01-20 15:17:57 -08:00
Seth Hillbrand 6fa2eedb4b Avoid the obsolete GetNextPin() call 
This iterated over all pins to find the pin after a given item.  Because
out pattern is consistently to iterate in the outer loop, this means
that we were an O(n^2) loop for the pins just to find their names.  This
affected very large parts (e.g. FPGAs) when switching sheets to display
 2023-01-20 14:12:15 -08:00
Seth Hillbrand b8ee588a76 Don't do a full connection database reset on redraw 
All we need here is an updated intersheet reference, the connectivity
database remains valid and shouldn't be touched
 2023-01-20 14:11:23 -08:00
Seth Hillbrand 08c2828bd3 Remove extra call to RecalculatedConnections() 
This shouldn't happen when re-drawing, only on specific actions as it
will clog up our pipeline for other actions
 2023-01-20 13:26:23 -08:00
Seth Hillbrand 4d7ddf619a Remove unused var and cleanup 2023-01-20 13:26:11 -08:00
Jeff Young 3e55719831 May need to convert to UNIX style paths twice (before & after resolving). 
Fixes https://gitlab.com/kicad/code/kicad/issues/13591
 2023-01-20 18:06:17 +00:00
Jeff Young f7ebaf1bab Add compatibility mode for netlist code. 
(The non-A compatibility modes only run on included files.)

Fixes https://gitlab.com/kicad/code/kicad/issues/13589
 2023-01-20 18:06:17 +00:00
Jeff Young d9a90519f9 Flatten (and fix layout) of library table managers. 2023-01-20 14:19:58 +00:00
Marek Roszko a9cb8e9a8d Fix worksheets not loading in cli 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13489
 2023-01-19 23:47:41 -05:00
Jon Evans dee4f80680 DbLib: Load source symbol in editor when edit action is taken 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12840
 2023-01-19 22:45:46 -05:00
Jon Evans 6cce99e0d0 Support showing Value field in symbol chooser 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13527
 2023-01-19 22:14:10 -05:00
Jeff Young 27109bfc8a MRU path for simulation model libraries. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13581
 2023-01-20 00:18:55 +00:00
Mike Williams 5a2f4c445b Global Label Dialog: add power nets to dropdrown 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9118
 2023-01-19 12:47:32 -05:00
Jeff Young 49f3b21f5c Handle windows filepaths in SPICE include statements. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13591
 2023-01-19 14:55:34 +00:00
jean-pierre charras 87975b2833 SYMBOL_EDIT_FRAME: make UpdateMsgPanel() working. 
This is a virtual method, and the default method do nothing.
Now is calls SYMBOL_EDIT_FRAME::UpdateSymbolMsgPanelInfo()
Fixes #13586
https://gitlab.com/kicad/code/kicad/issues/13586
 2023-01-19 15:52:23 +01:00
Wayne Stambaugh ee3e285393 Correctly parent simulator netlist error dialogs. 2023-01-19 07:59:30 -05:00
Jeff Young 0e778f17db Add context menu for simulation cursors. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13580
 2023-01-19 12:50:21 +00:00
Jeff Young 715340b129 Fix erroneous early return. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13592
 2023-01-19 12:19:49 +00:00
Jeff Young 959e20f52c A fall-back model for FOO should supply FOO's pin names. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13589
 2023-01-19 12:14:50 +00:00
Seth Hillbrand 7e5a2450b8 Move multiple wxMessageBox to DisplayErrorMessage 
Also provide protection for headless running in multiple callsites

Fixes https://gitlab.com/kicad/code/kicad/issues/13575
 2023-01-18 16:54:01 -08:00
Mike Williams 171cffec28 Schematic: actually check for hover on duplicate 2023-01-18 13:52:49 -05:00
Mike Williams 144cd0b7f2 Schematic: duplicate on hover: grabs symbol instead of field 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13495
 2023-01-18 13:35:52 -05:00
Jeff Young 87377d1aac Stop stepping on user's data. 
Just because we can't find the file doesn't mean the path to it has
no value.  Don't delete it.  And don't crash afterwards either.

Fixes https://gitlab.com/kicad/code/kicad/issues/13578
 2023-01-18 13:50:40 +00:00
Dag Lem cff0560088 Eagle schematic import: Handling of escaped text 2023-01-18 12:33:36 +00:00
Jeff Young 3af9c658e6 Don't specify fonts in wxFormBuilder. It only leads to pain. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13547
 2023-01-18 12:28:07 +00:00
Jeff Young 47d88c5647 Nullptr safety. (Sentry KICAD-71) 2023-01-18 00:52:19 +00:00
Jeff Young 26c821962f Simplify and regularize text variable substitution architecture. 
EDA_ITEMs are responsible for giving their parent a crack at it if
they failed to resolve it.  This recurses all the way up to the schematic/
board, and then to the project.

Cross-reference handling is also move to the EDA_ITEMs.  It must be done
before bubbling up so that we don't end up in loops.  (The aDepth parameter
will break the loop, but without having done anything useful.)

Fixes https://gitlab.com/kicad/code/kicad/issues/13541
 2023-01-17 17:05:41 +00:00
Mike Williams 369c0efade Bitmaps: respect source DPI 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13565
 2023-01-17 11:20:17 -05:00
Wayne Stambaugh f81642bbb3 Fix broken graphics import file filters. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13570
 2023-01-17 11:19:53 -05:00
Jeff Young 8d28cccfe2 Rework >NAME and >VALUE special processing a bit. 
Earlier commit moved variable substition earlier (in loadSymbolText())
so we didn't have the correct info later when we tried to do the
special processing on it.

Fixes https://gitlab.com/kicad/code/kicad/issues/13541
 2023-01-17 12:48:39 +00:00
Marek Roszko d2c0f5fc2a More wxSing 2023-01-16 23:14:38 -05:00
Jeff Young 6de25e2284 Lifecycle safety for highlight net items. 
This possibly fixes Sentry issue KICAD-6E.
 2023-01-16 18:11:16 +00:00
aris-kimi 3defb7679a Schematic editor: move Update Schematic from PCB to the bottom 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13535
 2023-01-16 17:18:21 +00:00
Jeff Young a3a01a87e8 Resolve text variable references in LIB_TEXT and LIB_TEXTBOX. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13558
 2023-01-16 16:01:45 +00:00
Jeff Young 9315e885ee Substitute variables in imported symbol text. 
Also allows mulit-line text items to be imported.

Fixes https://gitlab.com/kicad/code/kicad/issues/13541
 2023-01-16 16:01:45 +00:00
Jeff Young 62649b868c Ensure good fonts in grid headers. 
Also moves rendering to a flat look for headers (instead of a beveled
border).

Fixes https://gitlab.com/kicad/code/kicad/issues/13547
 2023-01-16 02:47:14 +00:00
Marek Roszko 789db0cecb Some more wxS 2023-01-15 21:32:23 -05:00
Marek Roszko 57c66a50ac Add some missing wxS wraps 2023-01-15 20:24:29 -05:00
Jeff Young addaad4a96 Move notes foreground in front of device foreground and wires. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13098
 2023-01-15 22:57:01 +00:00
Jeff Young ca1fb732c8 Share Eagle var substitution between board and schematic importers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13541
 2023-01-15 22:27:19 +00:00
James Jackson 661eed7fed Eeschema: ensure wire / bus auto-start respects bus labels 
Fixes #13506 and further ensures correct behaviour for heirarchical labels and sheet pins
 2023-01-15 19:25:28 +00:00
jean-pierre charras e9da3e5ae9 Fix compatibility with wxWidgets version < 3.1.6 2023-01-15 20:19:53 +01:00
Roberto Fernandez Bautista 355e817302 Move DefaultTransform definition to transform.cpp, so it can be shared 2023-01-15 19:17:51 +01:00
Roberto Fernandez Bautista ff717fec3f Wait to save non-KiCad imported drawing sheet until user requests a save 2023-01-15 19:17:50 +01:00
Roberto Fernandez Bautista d063eb431b Move FixupJunctions to SCHEMATIC 2023-01-15 19:17:50 +01:00
Roberto Fernandez Bautista c4bde9c7e8 Extract SCH_LINE::BreakAt( aP ) from SCH_EDIT_FRAME::BreakSegment 2023-01-15 19:17:40 +01:00
Roberto Fernandez Bautista c7f33e21f8 Extract SCH_SCREEN::GetNeededJunctions from AddJunctionsIfNeeded 2023-01-15 19:17:39 +01:00
Roberto Fernandez Bautista 22cc861c9b Remove dead code in AddJunctionsIfNeeded 2023-01-15 19:17:39 +01:00
Roberto Fernandez Bautista 7332c0c54d Move SCH_EDIT_FRAME::GetSchematicConnections into SCH_SCREEN::GetConnections 2023-01-15 19:17:38 +01:00
Roberto Fernandez Bautista 64105dcf84 Extract GetBusesAndWires function out of SCH_EDIT_FRAME::BreakSegments 
This function is called by SCH_EDIT_FRAME::AddJunction
 2023-01-15 19:17:38 +01:00
Stefan Brüns 1df81b10e6 Explicitly convert std::string to wxString 
In wxWidgets STL builds the compiler has multiple, ambigous choices
for converting - both arguments to std::string first, or just the
first to wxString.

Fixes #13432.
 2023-01-14 22:58:54 +00:00
Jeff Young 06a2e950fd Add sheet field layers to SCH_LAYER_ORDER. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13518
 2023-01-14 20:38:12 +00:00
Marek Roszko 4b0b9a36bf Load custom drawing sheets in the cli export 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13489
 2023-01-14 14:07:58 -05:00
Dag Lem b3d1384896 Eagle schematic import: Corrected handling of plain/frame 2023-01-14 14:49:48 +00:00
Dag Lem 54f67cd6f5 Eagle schematic import: Corrected visibility for >NAME and >VALUE 2023-01-14 14:40:35 +00:00
Jeff Young 4c5a344629 Allow editing of raw SPICE models through code tab. 2023-01-14 02:43:34 +00:00
Jeff Young f1aee2fa18 Minor dialog tweaks. 2023-01-14 01:45:30 +00:00
Jeff Young 098d2b30a2 Support for simulation options in workbook and simulation command dlg. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13524

Fixes https://gitlab.com/kicad/code/kicad/issues/13523

Fixes https://gitlab.com/kicad/code/kicad/issues/13431
 2023-01-14 00:21:45 +00:00
Jeff Young e7e2085b2a Allow vector param values. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13431
 2023-01-13 21:59:06 +00:00
Jeff Young 453f1f393e Add scanning for coupled inductor declarations to SPICE directives. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13431
 2023-01-13 19:10:49 +00:00
Jeff Young 7fbad183db Gracefully handle Quit when simulator window is open. 2023-01-13 16:35:45 +00:00
Jeff Young 4391fc7a7a Don't be annoying about refusing to create traces when there's no data. 2023-01-13 16:35:45 +00:00
Jeff Young d8867b7a66 Remove attempting to parse SPICE text items when generating netlists. 
We don't do anything with the parse tree, and we have to check it for
directives again afterwards to account for when our parsing failed, so
there's not much point in parsing it to begin with.
 2023-01-13 16:35:45 +00:00
Seth Hillbrand bd6d0b6cb6 Ensure that all subgraphs are processed 
Don't skip subgraphs just because they do not have off-sheet connections
on their hierarchical ports
 2023-01-12 17:01:09 -08:00
Seth Hillbrand b222e4fd07 Remove unused file 2023-01-12 14:08:44 -08:00
Jeff Young cbfbd3a0de Don't attempt to recognize SPICE directives line-by-line. 
.model and .subckt can be multi-line without requiring the continuation-
line syntax.
 2023-01-12 16:49:09 +00:00
Jeff Young 6dc7c30174 Still have to write out includes from internal models... 
... even if we're no longer parsing included libraries.
 2023-01-12 16:36:00 +00:00
Jeff Young 52163c7b31 Hold off on one-library-per-SIM_LIB_MGR. It's too risky for 7.0. 2023-01-12 16:29:51 +00:00
Jeff Young cb58cb8cd3 Put new lines and junctions on the right layer. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13505
 2023-01-12 15:17:45 +00:00
Jeff Young d839f11d49 Rip out parsing of SPICE libraries for netlisting. 
We only need to parse the libraries for the Sim Model Editor dialog
(so that we can determine the models to put in the popup).  Doing it
for netlisting just opens us up to incorrectly parsing the SPICE, and
returns no value.

This also means that a SIM_LIB_MGR manages a single library, and
never multiple libraries.

This also allows the tidying-up of some error reporting structures to
better inform the user what went wrong.

Fixes https://gitlab.com/kicad/code/kicad/issues/13431
 2023-01-12 14:51:03 +00:00
Seth Hillbrand d07da51390 Fix copy-paste error 2023-01-11 20:37:42 -08:00
Jon Evans c530bdb5a1 Rename GetSelectMenuText to GetItemDescription 
This descriptive text is used for many more things than
just the select menu these days.
 2023-01-11 22:27:44 -05:00
Seth Hillbrand f4ac4be701 Fix naming of `updateTitle()` 
This is a private function so should be lowercased to avoid confusion
 2023-01-11 16:06:20 -08:00
Seth Hillbrand 8aff923710 Set dirty bit and handle undo for export remap 
When remapping the exported symbols, we should keep this in the undo
stack (remapping, not the existence of the new elements) and set the
dirty bit for the file to ensure it is saved/autosaved

Fixes https://gitlab.com/kicad/code/kicad/issues/13493
 2023-01-11 16:06:20 -08:00
Jeff Young c3c5468817 Sort all findNext candidates in a single list. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13483
 2023-01-11 23:42:45 +00:00
PJM 76a0d4c4c0 Eeeschema: Fixed logic to display unamed pins properly 
CHANGED:  This code previously checked "m_name.IsEmpty()" to choose the
correct formatting path, but that check fails if the pin is called "~"
which is the default for an empty pin name.  Instead we get the final
display string that will be shown and check if it's empty.

Fixes https://gitlab.com/kicad/code/kicad/issues/13332
 2023-01-11 21:45:32 +00:00
Seth Hillbrand a206f6717d Desaturate the symbols in DNP for print/plot 
The desaturation should match screen display

Fixes https://gitlab.com/kicad/code/kicad/issues/13481
 2023-01-11 13:44:08 -08:00
Graham Keeth 89a6e55e58 Add DNP columns/grouping info to BOM script headers 2023-01-11 20:42:44 +00:00
Seth Hillbrand 248399f771 Standardize print/plot terms 
Use choice box for color/bw selection
"border and title block" -> "drawing sheet"

Fixes https://gitlab.com/kicad/code/kicad/issues/13128
 2023-01-11 12:30:02 -08:00
Seth Hillbrand 8a26bf6c41 Tweak DNP display settings 
Use ERC error color
Make lines 3 * default line width (instead of 4 *)
 2023-01-11 11:29:46 -08:00
Wayne Stambaugh c7ffb85bf7 Fix Eagle schematic import on duplicate symbol library names. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13434
 2023-01-11 14:10:00 -05:00
Jeff Young c89925578d Move find/replace to own tool so it doesn't rob events from cross-probing. 2023-01-11 14:22:06 +00:00
Dag Lem bc4e559581 Eagle schematic import: Corrected handling of curved symbol/wire 2023-01-11 12:31:46 +00:00
Jeff Young f8ef15f174 Fix over-zealous delete. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13476
 2023-01-11 12:16:28 +00:00
Jeff Young 30c9deb9d5 Flat(er) look for paged dialogs. 2023-01-11 01:11:25 +00:00
Seth Hillbrand 6cd750bb9c Respect "Exclude from Board" flag in export 
When exporting to board-based netlists, skip components marked for
exclude from Board

Fixes https://gitlab.com/kicad/code/kicad/issues/13422
 2023-01-10 15:23:26 -08:00
Seth Hillbrand 786fc14df3 Explicitly call out DNP in BOM 
Add DNP column and group output based on DNP

Fixes https://gitlab.com/kicad/code/kicad/issues/13466
 2023-01-10 15:23:26 -08:00
Seth Hillbrand 3003d9476a Respect exclude from BOM 
Remove non-standard (and hidden) exclude from BOM field in favor of the
current standard flag
 2023-01-10 15:23:26 -08:00
Roberto Fernandez Bautista 33249d37b0 EAGLE SCH: Improve detail of curved shape imports (0.01mm error) 
Follow-up from https://gitlab.com/kicad/code/kicad/-/merge_requests/1445
 2023-01-10 22:45:46 +01:00
Roberto Fernandez Bautista 99d02ac7c0 CADSTAR SCH: Load symbol shapes with correct fill state 
Changes architecture of importer to use SHAPE_LINE_CHAIN.

For now lets just load symbol shapes like this, but we could update code
for all other loading operations (also in PCB).

FIxes https://gitlab.com/kicad/code/kicad/-/issues/8060
 2023-01-10 22:28:01 +01:00
Dag Lem 7e01816b73 Eagle schematic import: Handling of polygons with curved sides 2023-01-10 20:45:40 +00:00
Wayne Stambaugh 366c3e7142 Revert "Fix value field visibility issues when importing Eagle schematics." 
This reverts commit 4c5203fabf.
 2023-01-10 09:45:18 -05:00
Seth Hillbrand f99e374559 Make DNP more visible 
Adds red cross to the DNP display.  Allows showing the DNP even when
plotting black/white

Fixes https://gitlab.com/kicad/code/kicad/issues/13456
 2023-01-09 15:31:50 -08:00
Dag Lem 7c458c5aee Eagle schematic import: Handling of curved plain/wire and segment/wire 2023-01-09 17:02:14 +00:00
Mike Williams 4274bd0bb7 Schematic: handle rotations that include junctions 
Also fix lack of line cleanup on mirroring.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13436
 2023-01-09 11:05:30 -05:00
Wayne Stambaugh 4c5203fabf Fix value field visibility issues when importing Eagle schematics. 
Eagle schematics do not show the value field when it's not defined or
when not package (footprint) is defined for the symbol which is the
case for power symbols.  Don't show the value field in KiCad to bring
the view more in line with what Eagle displays.

Inspired by Stefan's merge request #13433.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13433
 2023-01-09 10:45:45 -05:00
Jeff Young c43050b91b Remove safety around reading default parameter from Value field. 
This should be OK now because we should be writing out all parameters
now (even if they're default value).

But perhaps more to the point, if we have the safety in there then
we miss cases where we really can't parse the model (value of "{VCC}")
and we need to fall back to a raw spice model.

Fixes https://gitlab.com/kicad/code/kicad/issues/13444
 2023-01-09 15:24:45 +00:00
jean-pierre charras be5810a1ce EEschema, "Change To" context menu: do not allow converting SCH_SHEET_PINs 
to something else.
SCH_SHEET_PIN are specific, handled by a SHEET, and the conversion to a label
cannot be done.
 2023-01-09 15:30:36 +01:00
Dag Lem 8c8b4f43e7 Eagle schematic import: Added missing plain elements 2023-01-09 14:18:23 +00:00
Marek Roszko 9f71e9af03 Add arg to plot hidden symbol pins in cli 2023-01-08 22:39:38 -05:00
Marek Roszko c514f6f094 Handle alias symbols in cli svg export 2023-01-08 22:19:06 -05:00
Wayne Stambaugh 9c0445ed98 Remove schematic editor standard dialog button static line separators. 2023-01-08 14:26:10 -05:00
Jeff Young d65cf1b457 Check parameters before assuming we can handle the model. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13444
 2023-01-08 18:00:22 +00:00
Jeff Young 063478b3dc Implement brightening for Find Next hotkey actions. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13421
 2023-01-08 14:34:38 +00:00
jean-pierre charras 4d5c4c4ea8 Ensure all selected items have their edit flags cleared after move. 
Some sub-items like fields can be selected, and are not in the main item list.
Fixes #13435
https://gitlab.com/kicad/code/kicad/issues/13435
 2023-01-08 11:52:21 +01:00
Jeff Young c3ca1ce014 Tune the hit-test extra-slop for lines (and apply it to arcs too). 
Fixes https://gitlab.com/kicad/code/kicad/issues/13429
 2023-01-07 23:06:51 +00:00
Jeff Young ee0e90e3b0 We no longer enforce either a non-empty value or name == value. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13424
 2023-01-07 22:42:52 +00:00
Jeff Young 22144ae0d0 Fix bogus format string replacement type. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13426
 2023-01-07 19:34:32 +00:00
Jeff Young 289d9bd6fb Remove missed check for empty fields. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13424
 2023-01-07 19:34:32 +00:00
jean-pierre charras c2f7dbfc15 Eeschema, AlignElements(): fix broken align of lines (bus, wire, graphic line) 
It was due to a recent change (commit d824b7f5)  for SCH_LINE_T in
SCH_MOVE_TOOL::moveItem()
 2023-01-07 09:06:03 +01:00
Seth Hillbrand 03e12535a8 Include symbol flags in swap 
Needed for undo/redo.  All properties should be listed in the swap

Fixes https://gitlab.com/kicad/code/kicad/issues/13409
 2023-01-06 14:40:39 -08:00
Jeff Young 8dc7baad3d Cleanup actions should not activate tools. It causes all manner of side-effects. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13331
 2023-01-06 22:15:20 +00:00
Seth Hillbrand 8cabc82f1c Add highlight hinting to pin severity 2023-01-06 13:30:58 -08:00
Jeff Young 5bdc3a5721 Keep sim-enabled checkbox in sync with edits to fields grid. 2023-01-06 20:43:33 +00:00
Wayne Stambaugh 411669ab88 Fix schematic power symbol annotation paste bug. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13405
 2023-01-06 13:55:13 -05:00
Seth Hillbrand 38a0b67e40 ngspice has specific chars that are reserved 
This replaces all known reserved characters with '_'

Fixes https://gitlab.com/kicad/code/kicad/issues/13404
 2023-01-06 09:36:49 -08:00
Jeff Young 4d7642a26c Add number of pulses parameter to pulsed voltage/current sources. 
Also don't suppress writing "0" valued parameters.

Fixes https://gitlab.com/kicad/code/kicad/issues/13401

Fixes https://gitlab.com/kicad/code/kicad/issues/13402
 2023-01-06 13:45:56 +00:00
Marek Roszko c57e6db79a Turn off plotting hidden fields in the svg export cli 2023-01-05 23:32:24 -05:00
Marek Roszko e056c96c10 Feed the sym svg export absolute paths for source lib 2023-01-05 22:28:01 -05:00
Seth Hillbrand b6b5a8ef6e Remove bus label syntax from severities dialog 2023-01-05 17:00:32 -08:00
Jeff Young 98f0959f39 Default common-to-all-units based on last-used setting. 
(Or whether or not the symbol has interchangeable units when a new
symbol is loaded.)

Fixes https://gitlab.com/kicad/code/kicad/issues/13391
 2023-01-06 00:34:16 +00:00
Seth Hillbrand c29dfe026e Force recursing annotation when set to auto 
Automatic annotation should always annotate new elements regardless of
where in the hierarchy they are

Fixes https://gitlab.com/kicad/code/kicad/issues/13378
 2023-01-05 15:03:38 -08:00
Jeff Young 933a5d45e1 Be more aggressive about clearing edit flags after operations. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13173

Fixes https://gitlab.com/kicad/code/kicad/issues/13385
 2023-01-05 18:08:22 +00:00
Jeff Young 7af718f1a5 Don't use std::string for things with wxString APIs. 
It's too bug-prone.

Fixes https://gitlab.com/kicad/code/kicad/issues/13380
 2023-01-05 14:16:39 +00:00
Jeff Young 3b021d98be Completely remove reading SCH grid sizes from config files. 
It messes up too many things if you put metric grids in there.

Fixes https://gitlab.com/kicad/code/kicad/issues/13345
 2023-01-05 12:25:43 +00:00
Stefan c5d7e447c7 Bugfix: remove trailing comma after last ref 2023-01-05 08:29:01 +00:00
Jeff Young 985414fef9 Collapse pin-conflicts-map generator back to (mostly) a single path. 2023-01-05 00:02:44 +00:00
Wayne Stambaugh 6f7af062ff Rename file component_reference_lister.cpp to sch_reference_list.cpp. 
This matches the naming of the header file.
 2023-01-04 16:31:17 -05:00
Seth Hillbrand 0e2943d781 Fix pinmap flat style on GTK 2023-01-04 12:48:15 -08:00
Wayne Stambaugh d99e09014b Rename SYMBOL_INSTANCE_REFERENCE to SCH_SYMBOL_INSTANCE. 2023-01-04 15:39:50 -05:00
Seth Hillbrand fc86998bf6 Ensure duplicate pin names get unique nets 
Same pin name != same net name unless the pins are explicitly connected

Also add pin number to all unconnected pads ensuring they have unique
nets

Fixes https://gitlab.com/kicad/code/kicad/issues/13236
 2023-01-04 11:32:15 -08:00
Jeff Young 7c0b6c1e87 Restore old pin-conflicts-map algo for MSW and GTK. 2023-01-04 18:32:06 +00:00
Mike Williams bd5d10cd7b Schematic: remove more extraneous dangling symbols 2023-01-04 11:07:23 -05:00
Graham Keeth fb9a388bce Fix icon spacing in Annotation dialog/panel 2023-01-04 13:52:19 +00:00
Jeff Young 33d31be9b5 Fix last commit. 2023-01-04 13:38:28 +00:00
Jeff Young b38370adae Test for viability of using fontsize for pin conflicts map positioning. 2023-01-04 13:16:15 +00:00
Wayne Stambaugh f5c5b00e40 Fix schematic annotation dialog bitmap layout issue. 2023-01-04 07:36:00 -05:00
Wayne Stambaugh 73b7dcbc35 Attempt to unify symbol annotation behavior between place and paste. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13330
 2023-01-04 07:36:00 -05:00
jean-pierre charras 575a84f76c Fix a compil issue on GTK 2023-01-04 13:15:56 +01:00
jean-pierre charras d0f9ce897e Do not use #elifdef , only available in C++23 
replaced by #elif defined
 2023-01-04 11:59:33 +01:00
Jeff Young a8d2f7f71d Round 2 for GTK. 2023-01-04 01:41:07 +00:00
Jeff Young b9f1106781 Adjustments for GTK. 2023-01-04 01:18:02 +00:00
Jeff Young c47de5a55d Another round of adjustments for MSW pin conflicts map. 2023-01-04 00:33:58 +00:00
Jon Evans ac3ed02283 Rework bitmap cache and enable it 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12405
 2023-01-04 00:26:45 +00:00
Marek Roszko 8ab9934143 Use our own cmake module path variable to avoid conflicting with the main ones listy functional 2023-01-03 19:18:16 -05:00
Jeff Young 7d84d323a6 Pin conflicts map adjustments for MSW. 2023-01-04 00:12:16 +00:00
Jeff Young 13d196c509 Fix some issue in the pin conflicts map with button alignment on Mac. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13333
 2023-01-03 23:39:48 +00:00
Graham Keeth 77ee82459e add ERCE_NETCLASS_CONFLICT and ERCE_ENDPOINT_OFF_GRID to schematic setup 2023-01-03 23:23:46 +00:00
Mike Williams 1ba9a6abe3 Rotate/Mirror: unbreak immediate mode actions 2023-01-03 16:05:52 -05:00
Seth Hillbrand cbe6cd3048 Don't move local vars 
Copy ellision allows optimization if we don't explicitly move a local
variable in the return
 2023-01-03 10:20:18 -08:00
Jeff Young baa13b885f Don't add Sim.Params unless it contains data, and update sallen key demo. 2023-01-03 17:20:23 +00:00
Jeff Young 9583b28063 Fix store-in-value bugs. 
1) Always honour the dialog checkbox value.
2) Don't expect the absence of the primary parameter in Sim.Params to
   mean that Value stores it.  It might be the default parameter value.
3) Update spiceTypeInfo when matching legacy data to an internal model.
4) Initialize the store-in-value checkbox depending on whether or not
   we found the primary parameter in the Value field.
 2023-01-03 17:20:23 +00:00
Jeff Young 9b9795a87d Reduce reliance on exception processing -- it's waay too bugy at present. 
This moves some stuff to REPORTER APIs.  Moving more stuff would be good,
but it probably too high-risk at present.  We'll wait for 8.0 for that....

Fixes https://gitlab.com/kicad/code/kicad/issues/13359
 2023-01-03 17:20:23 +00:00
Mike Williams d1c2ab957b Schematic: set current sheet after initializing screens 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13238
 2023-01-03 12:11:31 -05:00
Jeff Young fdc8f9c59d Fix accidental deletion in "TEXT_ATTRIBUTES" commit. 2023-01-03 01:23:18 +00:00
Jeff Young 7f35323416 Re-enable sim model ERC testing. 2023-01-03 00:59:14 +00:00
Jeff Young 056349e5ea Units for footprint preview widgets. 2023-01-02 22:12:26 +00:00
Jeff Young c5948de2af Update find status when switching sheets. 
(Not just when switching sheet during find.)

Fixes https://gitlab.com/kicad/code/kicad/issues/13351
 2023-01-02 18:49:28 +00:00
Jeff Young 277cd73204 TEXT_ATTRIBUTES doesn't hold the position. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13350
 2023-01-02 17:36:21 +00:00
Jeff Young fc346ea794 Iterator safety. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13341
 2023-01-02 11:36:54 +00:00
jean-pierre charras e8114dc49a Minor compil and Coverity warnings fixes. 2023-01-02 10:21:42 +01:00
Jeff Young 6f16678d2d Typo fix courtesy or aris-kimi. 2023-01-01 23:40:18 +00:00
jean-pierre charras 447d0d71d3 EEschema, Error/Info messages: do not add the unit id to single unit symbol ref 2023-01-01 11:21:05 +01:00
Gary Kim 8e8a3c7bdc
Do not translate name in version info 
Leave the application name in version info untranslated when
viewed, copied, or used in a bug report.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/13298
 2022-12-31 20:28:45 -05:00
Jeff Young 62f0843579 Fix grammar error in warning string. 2022-12-31 18:54:36 +00:00
Jeff Young 55b8f0bc00 Gracefully fall back to raw spice when we can't parse the data. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13329
 2022-12-31 18:52:26 +00:00
Jeff Young 77b361a077 Add reference material to SPICE model pin assignment tab. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13309
 2022-12-31 18:52:26 +00:00
jean-pierre charras 9f56771611 Fix a typo 2022-12-31 11:41:04 +01:00
Jeff Young 5deee405da Fill in built-in-model-type (which might not be the same as initial spice type). 
Fixes https://gitlab.com/kicad/code/kicad/issues/13324
 2022-12-31 01:07:46 +00:00
Jeff Young 62bec69d8c Migrate field text attrs from legacy fields. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13323
 2022-12-30 23:41:46 +00:00
Jeff Young e9ed56e9a4 Fix small alignment issue in field properties dialog. 2022-12-30 15:29:36 +00:00
Jeff Young c0e0cbceb0 Move eseries helper class to common. 
Also improves some terminology for english-speakers.

Also substitues [] vector access (which creates empty elements) over
at() (which throws if the item is not found).
 2022-12-29 18:05:57 +00:00
Jeff Young 4c63b4e061 Class name <-> file name sync. 2022-12-29 18:05:57 +00:00
Mike Williams 068b714908 Schematic: merge dual import sheet pin actions 
I believe I have managed to keep the slightly distinct functionality of
both implementations: the action will now use the selected sheet or find
one under the cursor if it's there.

It will also keep placing pins while they exist, which was inconsistent
in the behavior of the single click version before (other single click
commands keep placing until you cancel, e.g. no-connects )

Also, it will automatically end the tool when it runs out of sheet pins.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13296
 2022-12-29 09:36:29 -05:00
Mike Williams e65de51fc7 Schematic: label auto orientation needs to respect move/drag/change 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13226
 2022-12-28 14:30:57 -05:00
Mike Williams 495f337fa5 Schematic: remove unused variable 2022-12-28 12:27:57 -05:00
Mike Williams 6816ee937a Flags: remove unused IS_DRAGGING 2022-12-28 12:27:57 -05:00
Mike Williams 6cc17e4a16 Schematic: new flag IS_BROKEN for trimming BreakSegment danglers 2022-12-28 12:27:57 -05:00
Mike Williams f03fd5ad2d Schematic: remove IS_RESIZING 
Is unused/redundant with IS_MOVING
 2022-12-28 12:27:57 -05:00
Mike Williams 13f67aa7ce Schematic: remove unnecessary drag mirror/rotate control disabling 
The whole edit dialog is blocked while dragging if anything else is drag
selected, and if nothing is drag selected the rotations/mirroring will
be fine. Also, we already allow mirror and rotate while dragging, using
the keyboard shortcuts and menu items, and it works fine.
 2022-12-28 12:27:57 -05:00
Mike Williams b5b65e1455 Schematic: update dragged lines dangling state in realtime 
Makes the visuals a little nicer as we add bend lines
 2022-12-28 12:27:57 -05:00
Jeff Young e7300ffb5c Improved column sizing in library setup dialogs. 2022-12-28 16:27:03 +00:00
Jeff Young e927328ecf Don't rely on field ID for intersheetrefs. 
It will be -1, for instance, after a duplicate.
 2022-12-28 15:15:54 +00:00
Jeff Young a3fcc8bbf7 Move Exclude from Simulation to Symbol Properties. 
Also brings the layout of Symbol Properties for Symbol Editor more in
line with Symbol Properties for Schematic Editor.

Fixes https://gitlab.com/kicad/code/kicad/issues/13299
 2022-12-28 13:44:13 +00:00
Jeff Young 87448e0c55 Include sim command when running external SPICE. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13295
 2022-12-28 12:28:22 +00:00
Jeff Young d50b3550af Signals header is repetitive. 2022-12-28 10:40:23 +00:00
Jeff Young ef6001bfe6 Use consistent terminology: opposite of Add is Remove. 
Note: violating string freeze because this change should ease translation,
not make it harder.
 2022-12-28 10:40:23 +00:00
Jeff Young e11d39b0f2 If magnitude or phase is specified, don't add both. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13202
 2022-12-28 10:40:23 +00:00
Jeff Young 508b9e21a8 Put simulation in with other life-cycle tools. 2022-12-28 10:40:23 +00:00
Jeff Young 3767716f20 Menu IDs of 0 don't work on Mac. 2022-12-28 10:40:23 +00:00
Jeff Young 987eb4b46a Handle language changes for Schematic Hierarchy Navigator. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13291
 2022-12-28 00:11:28 +00:00
Mike Williams f1fab140a1 Schematic: make menu bar rotation items conditional 
Also fix some items not getting a context menu rotate action.
 2022-12-27 14:18:47 -05:00
Jeff Young 0b50e7fa37 A wee little hack for intersheet refs in legacy files. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13108
 2022-12-27 18:46:58 +00:00
Mike Williams 8ca8f83a18 Schematic: sheet pin dragging special case needs to check endpoints 
Otherwise we'll force the wrong end of a line to be special-cased
 2022-12-27 12:15:49 -05:00
Mike Williams 33b774685b Schematic: fix inconsistent selected-by-drag behavior of mid-line labels 
Two issues here:

Selected labels would half of the time add junctions splitting lines
when the lines would have been selected-by-drag (removing the need for a
junction).

Split lines aren't selected by drag by default, and we need to test
labels against lines that are selected by drag.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13224
 2022-12-27 12:15:49 -05:00
Mike Williams b82833200a Schematic: correct bus entry shadows size and selections 2022-12-27 10:09:45 -05:00
Jeff Young e64b356d93 Fix broken if/then/else logic. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13192
 2022-12-27 14:58:10 +00:00
Mike Williams 1ad373f2b2 Schematic: don't show unselected ends on bus entries 2022-12-27 09:37:21 -05:00
Jeff Young 572c10b2c4 If we don't recognize a var then it's an error, not 0.0. 2022-12-27 13:50:44 +00:00
Jeff Young 39a23fa9bc Only eval numeric properties. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13201
 2022-12-27 13:50:44 +00:00
Wayne Stambaugh e68bb16a28 Fix Eagle schematic import debug assertion. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13215
 2022-12-27 08:31:56 -05:00
Jon Evans 314c813aca Don't try to save hierarchical sheets with empty filenames 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11236
 2022-12-26 21:47:17 -05:00
Jeff Young 80f3abe082 Event safety. 
Sentry crash probably happens when an update title event fires either
too early or too late to have a simulator or simulator settings.

Sentry issue https://sentry.io/organizations/kicad/issues/3669444623/events/fce0179f7d5e4ff3a7dbb0d90a0570b4/
 2022-12-26 20:33:04 +00:00
Jeff Young 424cdf6699 Overflow safety. 
Sentry issue https://sentry.io/organizations/kicad/issues/3419671947/events/11212297e66c47c7af7144b5f075e88c/
 2022-12-26 20:33:04 +00:00
Wayne Stambaugh 78e2f0fd4d Sheet instance handling improvements. 2022-12-26 08:30:03 -05:00
Jeff Young b070ecf0c7 Don't run simulation while dragging tuning slider. 
It has all manner of issues with wxWidgets event processing.  The
primary one that Kicad stumbles over is that there is no kill-focus
when the mouse leaves the thumb if the sim is running, so subsequent
mouse-up events (even if in another window) generate thumb scrolls.
Another one that gets us is scroll events being generated when the
window is fronted, but this may be debugger-specific.

Fixes https://gitlab.com/kicad/code/kicad/issues/11366
 2022-12-26 10:51:30 +00:00
Jeff Young 90edcc8c42 Clarity and Clang-tidy warnings. 2022-12-26 10:51:30 +00:00
Jeff Young 13b73ed6b4 Remember dialog sizes for dialogs that might have lots of fields. 
This is mainly for simulation testing where the dialog has to be
grown every time you restart the app, but it might as well be applied
to the similar dialogs.

Fixes https://gitlab.com/kicad/code/kicad/issues/12887
 2022-12-24 22:20:03 +00:00
Jeff Young 833e76a0bc KiCad standard is left-aligned checkboxes. 2022-12-24 21:01:35 +00:00
Jeff Young ba4a7a979a Don't respond to Duplicate events while placing multiple copies of a symbol. 
It doesn't really make any sense as clicking will just create another copy
as well.

Fixes https://gitlab.com/kicad/code/kicad/issues/13253
 2022-12-24 19:40:39 +00:00
Jeff Young bf1c4e7bcd Allow translation of simulation error messages. 2022-12-24 11:30:56 +00:00
Jeff Young f00ec339fd Don't set IS_NEW flags during clean-up operations. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13252
 2022-12-24 11:17:13 +00:00
Jon Evans 5657ca5a04 No-connects might not be connected to a pin 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13256
 2022-12-23 20:50:49 -05:00
Jeff Young 6f44468385 Fix more lifetime issues in simulator tuning. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13257
 2022-12-23 22:03:24 +00:00
Jeff Young 981254543a Allow line-continuations in name=value parameters. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13255
 2022-12-23 20:05:16 +00:00
Jeff Young 00fe8f0f70 Minor tuner panel layout fixes. 2022-12-23 20:04:26 +00:00
Jeff Young 8069e5d5d6 Fix sim bug running a command the first time when no command in doc. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11366
 2022-12-23 18:21:26 +00:00
Jeff Young bfd3b40672 Bug fixes for tuning. 
1) Don't save SCH_ITEM pointers in long-lived structures.  Use KIIDs
   instead.

2) Use the correct sheet for the referenced item, not the current sheet.
 2022-12-23 17:40:36 +00:00
Jeff Young 604d7a72d6 Fix bug in tuning when value is stored in Value field. 2022-12-23 17:40:36 +00:00
Jeff Young e2f2f3518b Minor improvements to tuner panel look & feel. 2022-12-23 17:40:36 +00:00
jean-pierre charras e5363d164c Lib symbol editor, export SVG: fix incorrect position of the drawings. 
Fixes #13249
https://gitlab.com/kicad/code/kicad/issues/13249
 2022-12-23 16:31:35 +01:00
Jeff Young 66eafc56bb Don't suggest we're going to cancel already-added signals. 2022-12-23 12:46:18 +00:00
Jeff Young 3f49fa5361 Don't write sim.params for library model unless we actually have overrides. 2022-12-23 12:46:18 +00:00
Jeff Young cd7be966c0 Fix typo when un-escaping parameter name. 2022-12-23 12:46:18 +00:00
Jeff Young 7f60b87d1d Implement fallback models for SPICE .lib models that we can't parse. 2022-12-22 22:35:09 +00:00