3d852372ca
Handle nested unescaping (for buses in particular).
...
Also adds a few missing unescape() calls when showing netnames to the
user.
Fixes https://gitlab.com/kicad/code/kicad/issues/6400
2020-12-20 15:59:09 +00:00
0830f87ef4
Break wire segments on bus-wire entry endpoints
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6173
2020-12-20 10:22:59 -05:00
7bc42f387a
Make sure splitter sashes are visible.
...
Also might fix 6791, although that's probably a long-shot.
Fixes https://gitlab.com/kicad/code/kicad/issues/6791
2020-12-20 12:35:41 +00:00
9b0a137d6c
Stop bludgeoncompiling dialog_page_settings
...
Through the power of OOP!
Needs some more cleanup though
2020-12-19 10:40:37 -05:00
489db6adde
Handle case where multiple pins are moved
...
When synchronized, if multiple pins are selected to be moved, we need to
match each to a matching pin in the new unit
Fixes https://gitlab.com/kicad/code/kicad/issues/2589
2020-12-18 15:48:34 -08:00
0fd920a94c
Modify Synchronize Pins behavior
...
Consider a pin synchronized iff the names and electrical types match in
addition to the position, orientation and demorgan variant.
Also, only modify one matching pin per unit. This prevents
moving/editing a full stack of pins on the same unit when synchonized.
Fixes https://gitlab.com/kicad/code/kicad/issues/2590
2020-12-18 15:48:29 -08:00
2226e0b7aa
Do grid snapping earlier to avoid inconsistencies.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5908
2020-12-18 19:57:44 +00:00
189b1742f7
Naming conventions and formatting.
2020-12-18 19:57:44 +00:00
c0d2ad42ce
Remember state of RefDes and Value checkboxes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6755
2020-12-18 15:09:54 +00:00
5d400a9e11
Improve symbol library messages.
...
Includes both error messages and ERC messages.
Fixes https://gitlab.com/kicad/code/kicad/issues/6302
2020-12-18 12:49:20 +00:00
bf632ad771
Pick up root sheet KIID from sheet instances.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6725
2020-12-18 12:49:20 +00:00
b68b1692ec
Clean up some more user messages.
...
Mostly component -> symbol but also some I18N cleanup.
2020-12-18 12:49:20 +00:00
4ce91d3e92
HPGL improvements and optimizations for physical plotters
...
- Sort HPGL plots for speed
- Reduce HPGL circle precision for tiny circles
- Teach HPGL plotter about filled rectangles
2020-12-18 07:21:59 +00:00
1c0d4ac02d
Simplify some error messages.
2020-12-18 00:30:26 +00:00
91ab540d18
Naming conventions.
2020-12-18 00:30:26 +00:00
c875efb635
Prevent modal deadlock by using QuasiModal mode.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6779
2020-12-18 00:30:26 +00:00
bb232e6ac6
Unify LIB_IDs now that both are stored in sexpr files.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6764
2020-12-18 00:30:26 +00:00
7b9c21e290
Not connected pins should not get connected
...
This prevents splitting wires/busses on the NC pin end. It also keeps
NC pins out of the netlist.
Fixes https://gitlab.com/kicad/code/kicad/issues/6777
2020-12-17 11:56:42 -08:00
aab3c936f0
Move headers from common folders to appropriate include folders round 2.
2020-12-17 11:44:03 -05:00
11117a2d9a
Fix invalid access into empty string.
2020-12-17 14:18:27 +00:00
a6085fa88d
Consistency for gerbview toolbar icons and some other icon tweaks.
2020-12-17 14:02:23 +00:00
08cf9a1e20
Move headers from common folders to appropriate include folders round 1.
2020-12-17 08:12:18 -05:00
a484d10470
Ensure schematic autosave works if sheet path is invalid
2020-12-16 21:17:48 -05:00
fc20eaa083
Fix some compiler and Coverity warnings
2020-12-17 00:30:22 +00:00
5761666ad6
Don't let the flattened symbol go out of scope before we're done with it.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6760
2020-12-16 17:59:20 +00:00
5f9ed2583c
Don't put up double lock confirmation dialogs.
...
Also removes EditToolSelectionFilter which was misused in more places
than it was used correctly. The original point of the client filter
was to move the logic to the point of use, which the
EditToolSelectionFilter sort of obviated anyway.
Fixes https://gitlab.com/kicad/code/kicad/issues/6751
2020-12-15 22:34:24 +00:00
d05df4a9d4
Buffer bitmap buttons in pinmap for Mac
...
Mac bitmap buttons are not properly handled in wxWidgets, so the size of
the bitmap needs more buffer space to the button edge or the image will
clip
2020-12-15 12:47:03 -08:00
92db1d35e1
Formatting.
2020-12-15 17:11:14 +00:00
4cc43b3bd3
Don't print sheet backgrounds when printing in black & white.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6746
2020-12-15 17:11:09 +00:00
10e68daa37
Fix some bugs in Change Symbol and Update Symbols.
...
In particular, there was a typo that kept library values from being
updated, and there was missing logic to fetch the various field names
from the library parts (and the change-to part).
Also implements some performance gains by desisting from copying
LIB_FIELDs around every time we want to look at them.
Fixes https://gitlab.com/kicad/code/kicad/issues/6733
Fixes https://gitlab.com/kicad/code/kicad/issues/6749
2020-12-15 16:12:17 +00:00
70cbf59846
eeschema/intersheet: don't list own page
2020-12-15 01:06:00 +00:00
dad2e317e9
Modify edit text & graphics to use pencil
2020-12-14 17:03:35 -08:00
22a6b36257
Don't allow dbl-click to leak through to other tools.
...
This only applies if the tool doesn't handle properties (which also
handles double-click events).
Fixes https://gitlab.com/kicad/code/kicad/issues/6735
2020-12-14 22:15:43 +00:00
07bb2729f8
Clean up over-use of auto.
2020-12-14 22:15:43 +00:00
c1a74b427a
Translucent magnifying glass on footprint & library browser icons.
...
Also renamed.
2020-12-14 22:15:43 +00:00
797a588015
Aliases should inherit their descs, keywords, and fp filters.
...
Assuming they're not set locally, of course.
Also updates to new class structure order.
Fixes https://gitlab.com/kicad/code/kicad/issues/6051
2020-12-14 13:48:26 +00:00
3b35bfc0a5
Don't write out synthetic severities (they're headings).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6726
2020-12-14 13:34:53 +00:00
9dae57ae9d
Fix several bugs in SCH color printing and plotting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6723
2020-12-13 22:43:09 +00:00
9720fc80fe
Print sheet background colour if specified.
2020-12-13 22:43:09 +00:00
126d40f9d3
"Sheet label" too confusing w/ sheet names and fields. Use "sheet pin".
2020-12-13 22:43:09 +00:00
40200ceab5
Clean up the symbol browser toobar a bit.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6712
2020-12-13 13:41:25 +00:00
5b22cef984
Associate -> assign in the context of footprint assignments.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6708
2020-12-13 13:41:25 +00:00
bc99545eb2
ADDED Migrate Libraries button to Manage Symbol Libraries...
...
Allows easier conversion of legacy libraries.
Note that performance will be suboptimal as it must read/write each
library once for each symbol in the library. Doing otherwise would
require modifying the PlugIn API, which probably isn't worth it for
a one-time migration.
2020-12-13 11:42:03 +00:00
1db7ffad5e
Formatting.
2020-12-13 11:42:03 +00:00
d67cf2f9af
Replace wxFile usage with wxFFile
...
Buffered libc wxFFile is better thinking about syscall wxFile going wrong.
2020-12-12 13:16:23 -05:00
93d55e3d23
Tweak no-connect and label icons
2020-12-12 11:26:30 -05:00
6544dca056
Ensure driver connections are always properly initialized
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6694
2020-12-12 10:43:30 -05:00
7186a0c621
Remove canonical name column from view and make sash more obvious.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6693
2020-12-12 15:27:46 +00:00
b6e267b78d
Naming conventions.
2020-12-12 03:43:41 +00:00
cf6f0b9b92
Use trash icon where appropriate
2020-12-11 17:05:11 -08:00
412c9c8c4e
Save should be disabled only if the file is up-to-date.
...
Any other issues (such as locked files) need to produce a dialog
with info for the user.
2020-12-11 23:58:30 +00:00
e667d26854
Eeschema: use "board editor" instead of "PcbNew" in UI strings.
2020-12-11 15:24:42 -05:00
4516aff43e
Symbol Editor: don't show edit page number in context menu.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6711
2020-12-11 15:02:34 -05:00
5d028b82ed
Eeschema: tool tip improvements.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6708
2020-12-11 13:42:50 -05:00
dd4298bb94
Coverity fixes: 280374, 313611, 313648, 313649, and 314720.
2020-12-11 13:29:52 -05:00
224697d0b3
Sheet navigator tooltip.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6680
2020-12-11 16:43:55 +00:00
73b7b104cd
Fix some issues with Infobar sizing.
...
This also commits to the new strategy as it wasn't really compatible
with if-def-ing anymore.
2020-12-11 12:39:40 +00:00
ee6f37bdc7
Headings and groupings for ERC severities.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6673
2020-12-09 22:19:06 +00:00
e61f768fbc
Eeschema: add defensive code to symbol library cache I/O.
2020-12-09 11:46:10 -05:00
ad1aae40ec
Unify the saved file strings
2020-12-08 19:49:47 -05:00
f29f052aa7
Update an outlier from the component -> symbol rename.
2020-12-08 18:30:14 +00:00
b26a5972c5
LIB_TREE's SetFocus() override no longer getting called.
...
The KIPLATFORM stuff forces focus, but not through the SetFocus()
call.
Fixes https://gitlab.com/kicad/code/kicad/issues/6657
2020-12-08 17:46:10 +00:00
c611f62ade
Get rid of annoying double-draw when choosing a new symbol.
2020-12-08 15:27:50 +00:00
34be4b4666
Cleanup.
2020-12-08 15:27:43 +00:00
d1a9efa5fc
Try out an animating, obscuring infobar.
2020-12-08 15:05:35 +00:00
cbda1d7bf1
Remove more vestiges of old colored msg panel messages
2020-12-08 00:50:25 -05:00
b45eb56ddf
Cleanup some msg panel usage using the no longer support colors
...
The color was being passed to the aPadding param now.....
2020-12-08 00:34:36 -05:00
abb5cb8310
Fix up msg panel status on save slightly
...
- pcbnew should use status bar on success like eeschema
- Add a helper to clear msgpanel and set it in one go to avoid redraw delays due to doing processing in between
2020-12-08 00:28:07 -05:00
ac32d6a4b6
Symbol editor: add tool tip to clarify interchangeable symbol units.
2020-12-07 17:52:01 -05:00
893f1bb4c1
Clear view before deleting part.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6658
2020-12-07 15:49:57 +00:00
78129aabeb
Fix another case of 413ff4525b.
2020-12-07 14:25:55 +00:00
59527dff2a
Add infobar for derived symbol editing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6439
2020-12-06 22:44:30 +00:00
ad281f7538
Remove duplicated TestDanglingEnds routines.
...
Also adds a changedItemHandler so that the single remaining version
can update the view.
Fixes https://gitlab.com/kicad/code/kicad/issues/6581
2020-12-06 21:24:16 +00:00
4f90c03c7d
Allow snapItem to be re-activated.
...
Don't clear until another snapPoint is chosen. This allows line
snapping to re-appear when they move back in range.
Fixes https://gitlab.com/kicad/code/kicad/issues/5973
2020-12-05 23:57:33 +00:00
a3406e7514
Make snapping more predictable.
...
In particular, allow grid positions to override line snapping if
they're a better match (and do this independently on x and y axes).
We already allow a nearer anchor to override, but that should be
based on a cartesian distance rather than independent axes.
Fixes https://gitlab.com/kicad/code/kicad/issues/6626
2020-12-04 22:50:30 +00:00
9ece90a541
Fix off-by-one error in exporting netlist, and update testcases.
...
The golden file update entails the change to no-connects as well as
the introduction of natural number ordering.
2020-12-04 19:37:55 +00:00
7b347d793b
Change gears on no-connect net generation. See bug rpt.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6534
Fixes https://gitlab.com/kicad/code/kicad/issues/6615
2020-12-04 18:25:48 +00:00
2050e05944
Formatting.
2020-12-04 14:48:48 +00:00
8d72a768e0
eeschema/intersheet: add print and plot functions
2020-12-04 14:46:42 +00:00
c47871e775
EDA_BASE_FRAME::ShowInfoBarMsg: add option to show a close button.
...
Same for EDA_BASE_FRAME::ShowInfoBarError and EDA_BASE_FRAME::ShowInfoBarWarning
2020-12-04 14:45:14 +01:00
821128cb8e
Eeschema: Make auto-decrementing net labels stop at zero
...
CHANGED: If you set the auto-increment value to a negative number,
created a net label and hit the insert key, when the name got below zero,
the net labels tried to go negative but created bad labels instead.
Now the code caps decrementing at zero, warns users when it has
happened, and explains why.
Fixes https://gitlab.com/kicad/code/kicad/issues/6537
2020-12-04 12:48:32 +00:00
e882753ebf
Grid snapping fixes.
...
1) Uniformly honour the GAL grid snap settings
2) Make more uniform use of GRID_HELPERs
3) Smarten EDIT_LINE for mid-point snapping
Fixes https://gitlab.com/kicad/code/kicad/issues/6558
2020-12-03 19:55:58 +00:00
a19028a396
Hook up EE_GRID_HELPER to some more tools.
...
Also implements EE_GRID_HELPER layers so that connectable things
snap to connectable things and graphics snap to graphics.
Fixes https://gitlab.com/kicad/code/kicad/issues/5641
2020-12-03 15:16:34 +00:00
e79df4a3ed
Formatting.
2020-12-03 15:16:34 +00:00
fd3348690d
Symbol editor: enable save command when only libraries are modified.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6445
2020-12-03 08:17:09 -05:00
cf6620f8fa
eeschema: DIALOG_SYMBOL_PROPERTIES: fix crash when working on a old .sch file
...
Old .sch files do not store the symbol part description (stored in a cache lib)
So when using a .sch file, the part description can be not existing.
The fix tests for non existing part description.
Fixes #6580
https://gitlab.com/kicad/code/kicad/issues/6580
2020-12-03 10:45:47 +01:00
e5f340d176
Use monospace (teletype) font in show simulator netlist
...
May need fixing again for gtk (see #6587 )
2020-12-02 19:27:10 -05:00
43fe228367
Hook up a bit more of the EE_GRID_HELPER.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5985
2020-12-02 23:18:33 +00:00
64f555079a
Code cleanup related to zoom:
...
- remove outdated code or comment coming from old drawing code using wxDC
- move zoom values lists to zoom_defines.h
- fix incorrect zoom max and min values (gal scaling factor limits).
2020-12-02 18:35:28 +01:00
fcce62f0a4
cleanup related to zoom definitions
2020-12-02 18:35:27 +01:00
b7564f6f05
Don't modify RTree while iterating over it
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6582
2020-12-02 12:33:08 -05:00
8d3d648975
Update Change Symbols dialog to Update/reset terminology...
...
... as used in the Change Footprints dialog.
2020-12-02 14:27:43 +00:00
3d7c26b6bd
Get fields out of SYMBOL, not LIB_PART.
...
Also make sure the match-mode is initialised before we try and fetch
all the field names.
Fixes https://gitlab.com/kicad/code/kicad/issues/6589
2020-12-02 14:27:43 +00:00
d8fa37d5c2
Remove old root-schematic hacks. They don't work anymore anyway.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6583
2020-12-02 14:27:43 +00:00
71ab42e60a
Minor fixes and cleanup related to zoom definitions.
...
Mainly move 2 define relative to Zoom from convert_to_biu.h to zoom_defines.h.
Will make some changes/fixes in zoom code more easy.
2020-12-02 10:14:35 +01:00
05609dbc1d
Update screen r-tree after mirror operation
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6549
2020-12-01 19:19:12 -05:00
df262eaa06
Make prev/next marker work reliably on all platforms.
...
Requires us to move from arrow-keys to our own commands (the only
way that the OSX wxWidgets impl doesn't eat the keys when the dataVIew
has focus).
While there we might as well add a command to exlucde markers.
ADDED Prev Marker, Next Marker, Exclude Marker
Fixes https://gitlab.com/kicad/code/kicad/issues/6575
Fixes https://gitlab.com/kicad/code/kicad/issues/5501
2020-12-01 22:37:07 +00:00
3c521942ed
Smarten isEmpty checks to include nothing-but-whitespace.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6567
2020-12-01 16:39:06 +00:00
aa09418a14
Fixup memory lifespan of GAL options for the settings preview canvas
...
The canvas keeps a reference to the settings object, so we
can't pass one from the stack because it runs into lifetime
issues.
Also cleanup some loop-iterator problems.
Fixes https://gitlab.com/kicad/code/kicad/issues/6338
2020-12-01 01:12:07 +00:00
56fa5a23c3
SPICE export full precision data
...
Saving csv files loses precision when time/data steps are smaller than
10^-6. This switches to engineering notation when dealing with higher
precision.
Ref KiCad Services ticket 281
(cherry picked from commit 938859f10a
2020-11-30 13:27:38 -08:00
3ad5bce67f
Rewrite connected-lines dragger to not use EDA_ITEM flags.
...
We had some spurious bugs where both ends would get dragged to a
single point (making them disappear). While I never caught it
in the debugger, I'm guessing that the flags weren't getting
cleared properly or were getting overwritten or something. Anyway,
it now uses std::pair instead.
Fixes https://gitlab.com/kicad/code/kicad/issues/6550
Fixes https://gitlab.com/kicad/code/kicad/issues/6431
2020-11-30 19:30:03 +00:00
b1270bc9ab
eeschema page numbers: match print and plotting ordering to page number ordering
...
- new function SCH_SHEET_LIST::SortByPageNumbers() which uses SCH_SHEET::ComparePageNum for the sorting algorithm
- SortByPageNumbers() is called after every call to BuildSheetList()
2020-11-30 16:49:33 +00:00
9380d6f533
eeschema page numbers: match ordering in hierarchy navigator to sheet page number ordering
...
- update hierarchy navigator after any modifications to the SCH_EDIT_FRAME
- do not generate ghost selection events after updating hierarchy tree
- use Human Readable path in SCH_EDIT_TOOL::EditPageNumber
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5760
2020-11-30 16:49:33 +00:00
afcaa60faa
Remove "Order" field hack (partly reverts da1a89fc)
2020-11-30 16:49:33 +00:00
3a9a6e22bc
Fix issues in reporting netclasses.
...
1) make sure we get the default netclass when we want it
2) escape for HTML (particularly important for "<invalid>", but also
for reporting user rule names, netclass names, etc.)
2020-11-30 14:38:06 +00:00
3da0ab1a9a
Fix a couple of bugs in intersheet references.
...
1) init reference pages before trying to draw the SCH_FIELDs when
turning intersheet references on
2) don't double redraw because we accidentally cleared the last
hover item on a non-mouse-moved event.
3) make sure the root sheet gets a name for the hypertext menu.
2020-11-29 16:53:18 +00:00
56bb91b042
French translation update
2020-11-29 13:40:48 +01:00
09a1137f11
Fix a minor compil warning
2020-11-29 13:06:44 +01:00
9922b7b738
Redraw canvas after preferences. (Needed for grid changes, etc.)
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6433
2020-11-29 10:57:45 +00:00
becc811775
Make path substitutions grid read only in lib table dialog
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5624
2020-11-29 09:51:53 +00:00
ebf0cb3612
symbol viewer: fix closing issue when opened in modal mode
...
Fixes #6509
https://gitlab.com/kicad/code/kicad/issues/6509
2020-11-29 09:38:42 +01:00
095102614f
Eeschema: Fix non-visible source types in SPICE model dialog
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6540
2020-11-29 07:39:37 +00:00
6a28d6af27
CADSTAR Schematic Archive Importer: Fix loading of Schematic Sheet Pins and Orientation of Labels
...
- Find the intersection between the wire and the sheet and place the sheet pin there
- Fix orientation of hierarchical labels and global labels by applying opposite orientation to the connecting wire
2020-11-28 17:18:17 +00:00
ba77bf662c
CADSTAR Schematic Importer: Fix loading of buses
...
Place bus labels and correctly group nets for the bus in a BUS_ALIAS
2020-11-28 17:18:17 +00:00
0691e942f4
CADSTAR Archive Importer: Fix duplicate KIID for loaded elements
...
Don't use clone to copy an EDA_ITEM. Use Duplicate().
Even if you give the clone a new KIID, all its children will still be clones.
Create Duplicate() in LIB_PART
2020-11-28 17:18:17 +00:00
d2fbe12cfd
CADSTAR Schematic Archive Importer: Parse SCALE token in Symbol and warn user this is not supported
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6463
2020-11-28 17:18:17 +00:00
a058e26ddc
CADSTAR Schematic Archive Importer: Fix Loading of page numbers
...
Need to keep track of the hierarchy path in order to assign the page number
2020-11-28 17:18:17 +00:00
cba45ea257
CADSTAR Schematic Archive Importer: Fix orientation of components
...
- Fix the logic for the orientation of mirrored components
- Fix loading of angles/orientations from earlier versions of CADSTAR
2020-11-28 17:18:17 +00:00
49a2926a34
CADSTAR Schematic Archive Importer: Fix loading of graphical arc segments
...
Load the arc segments as piece-wise straight segments
2020-11-28 17:18:17 +00:00
71f9847601
CADSTAR Archive Importer: Only load the Master variant
2020-11-28 17:18:17 +00:00
f2ba9f7ac3
CADSTAR PCB Archive Importer: Correctly load the pad numbers as per the original design
...
To load the pad numbers correctly we need to also check the PART DEFINITION for each component
2020-11-28 17:18:17 +00:00
73ad503db3
CADSTAR Schematic Archive Importer: Parse missing TERMATTR node
2020-11-28 17:18:17 +00:00
13c63e3a50
Clearer warning about not back-annotating footprint deletes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6521
2020-11-26 19:30:16 +00:00
fc2bdc49de
Once more into the depths of hell... er, I mean fix a focus issue.
...
So the new steals-focus protection stuff works well when there's a
focused control, but not as well when there's a modal dialog up which
happens not to have a focused control (or worse, a focusable control).
This adds a second mechanism for also checking to see if a modal dialog
is up (something that wxWidgets, true to form, makes very difficult).
Fixes https://gitlab.com/kicad/code/kicad/issues/6520
2020-11-26 16:47:40 +00:00
c85ef8eb69
Make updating netnames in backannotate more discrete.
...
Trying to be too smart was producing unexpected results.
Fixes https://gitlab.com/kicad/code/kicad/issues/6480
2020-11-25 22:16:56 +00:00
d50d728d19
Cleanup compiler warnings
2020-11-25 00:08:09 +00:00
71ce00c5ce
Allow rotation of a single graphic line.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6487
2020-11-24 23:40:53 +00:00
9c7c05c161
Mostly formatting cleanup but a few type-casting cleanups too.
2020-11-24 22:16:41 +00:00
050d9e37ec
Fix rotation bugs in Eeschema.
...
Rotate text using the Rotate90() function which gets the orientation
right.
Also, when calculating the center point for rotation, don't include
labels if the selection contains other stuff. It just makes the
rotation odd, and tends to cause walking when continuing to rotate
(due to keep-upright being non-symmetrical).
Fixes https://gitlab.com/kicad/code/kicad/issues/git
2020-11-24 18:19:35 +00:00
44850e9409
Fix nullptr crash.
2020-11-24 14:13:03 +00:00
253f41c4f2
Fix minor dialog layout issue.
2020-11-23 23:57:26 +00:00
78b505f36a
Count head and tail lists as well.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6461
2020-11-23 23:54:54 +00:00
bf04fc3b72
Process all symbol instances as the ref, value, etc. may be different.
...
Also makes sure that the instance fields get set for reference, value
and footprint, and not just the base SCH_FIELD.
Also makes the translations easier.
Fixes https://gitlab.com/kicad/code/kicad/issues/6459
2020-11-23 22:09:15 +00:00
e91a5b3f81
Symbol editor: prevent derived symbol elements from being moved.
2020-11-23 15:46:03 -05:00
5f8a8c6850
Read/write "no net" (0) for pins with a no-connection marker.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2273
Fixes https://gitlab.com/kicad/code/kicad/issues/5587
2020-11-23 19:47:55 +00:00
c94001839b
Minor performance improvements to connection graph.
2020-11-23 19:47:55 +00:00
976c6262f4
French translation update (fix also trailing spaces in a few sentences)
2020-11-23 11:42:25 +01:00
dd60fd47b2
Cleanup and formatting.
2020-11-23 01:10:08 +00:00
baac9bfbf8
Don't try and rename lib entry when symbol is from board.
2020-11-22 15:40:44 +00:00
1f5831185e
Fix rotation of multiple global labels with intersheet references.
2020-11-21 23:44:26 +00:00
a9271e43cc
Read global fieldNameTemplates for project but don't write them.
...
Writing responsibility goes to the preferences dialog handler.
Fixes https://gitlab.com/kicad/code/kicad/issues/6450
2020-11-21 23:10:54 +00:00
3a4bd6fb8b
Fix uninitialized variable.
2020-11-21 20:57:36 +00:00
1391774f64
Re-factor boundary/courtyard checker error handling.
...
ADDED Footprint Checker dialog to display the results in.
Fixes https://gitlab.com/kicad/code/kicad/issues/6446
2020-11-21 20:57:35 +00:00
01b6cd08b5
lib_edit_tool.cpp: fix a wxWidgets 3.0.4 compatibility.
2020-11-21 11:56:32 +01:00
64636601b8
Eeschema: fix a Unicode/UTF8 management when pasting items from Clipboard.
...
Copy to clipboard save items (using S expr description) using wide strings
(not UTF8 encoding).
But Paste from clipboard was not converting the wide string to UTF8 string
when getting the stored data to send it as std::string to the S expr reader.
Fixes #6449
https://gitlab.com/kicad/code/kicad/issues/6449
2020-11-21 10:59:25 +01:00
3ff22fc882
Order symbols by unit/convert
...
This keeps the output symbol names in human-readable order
Fixes https://gitlab.com/kicad/code/kicad/issues/6376
2020-11-19 15:19:55 -08:00
c9fb595f64
Avoid assertion with invalid width
...
After adjusting col 0, the new width might be too large to handle. In
which case, allow the system to choose our best width
2020-11-19 15:19:55 -08:00
9e9946628a
Go back to arrow cursor on a cancel (or finish).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6421
2020-11-19 20:09:28 +00:00
c2ba68cdfa
Make sure intersheet references are updated on file-open.
2020-11-19 19:21:15 +00:00
826e47dde3
Hook up excluded ERC marker persistence.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6425
2020-11-19 18:22:52 +00:00
99796d359f
Honour include-in-board flag when back-annotating.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6438
2020-11-19 15:29:53 +00:00
801f385521
Eeschema: fix a UTF8 issue created by my commit 993a684
2020-11-19 14:37:51 +01:00
754e8e912c
Eeschema: some fixes in grid list and zoom list from config.
...
- slightly modify the zoom list.
- Do not use the values read from config: the user cannot change them,
so any issue in config cannot be easily solved.
Moreover, the grid list cannot be changed.
However the lists are still written in config, just in case.
2020-11-19 11:42:21 +01:00
99da663e82
Remove unused variables plus some more fixes from CppCheck
...
Remove unused variables plus a few more fixes from CppCheck
Remove unused variables plus a few more fixes from CppCheck
2020-11-19 02:28:47 +00:00
7c344e9be6
Mirroring for intersheet references.
2020-11-18 23:34:27 +00:00
c61c7b62aa
Start of impl for persisting ERC exclusions.
2020-11-18 23:34:27 +00:00
293795fd46
Support rotation on intersheet references.
2020-11-18 23:34:27 +00:00
0e44f5128c
Add const specifiers
2020-11-18 19:50:36 +00:00
f005335743
Resolve variables in Sheet Properties dialog's sheet path.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6409
2020-11-18 17:55:12 +00:00
55d0b79746
Make sure current sheet gets set when creating BOM.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6418
2020-11-18 17:32:40 +00:00
c1d1c12b41
Simplify message panel code.
...
We've had the colours turned off for two releases now without any
screaming or gnashing of teeth, so it's time to clean up the code.
2020-11-18 17:32:40 +00:00
cb5ec8bce1
Make Eeschema cursors update without waiting for mouse movement.
2020-11-18 17:32:40 +00:00
bd1f262a6b
Fix issues with Intersheet Ref highlighting and hover actions.
2020-11-18 17:32:40 +00:00
16e3e59495
Split out arrayDim and MIRROR templates from macros.h
...
These were not macros
2020-11-17 20:21:04 -05:00
a4201ea833
Fix crash in libedit
...
LIB_ITEM is not derived from SCH_ITEM but they share a selection model
2020-11-17 14:28:56 -08:00
c89676e39d
Require client to specify whether they want resolved values or not.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6408
2020-11-17 21:36:48 +00:00
94a358c592
fix 2 compil issues
2020-11-17 19:32:20 +01:00
8c5c902fa3
Re-write IntersheetRefs on top of SCH_FIELDs and textVars.
...
1) Generalize SCH_ITEM owners (SCH_COMPONENT, SCH_SHEET, and now
SCH_GLOBALLABEL)
2) Generalize hypertext items
3) Use SCH_FIELD autoplace infrastructure for placing intersheet
references
4) Use textVar infrastructure for buildin intersheet references.
As an important side-effect this also fixes the undo issues with
intersheet refs.
2020-11-17 16:05:49 +00:00
d616d5ad1f
Naming conventions.
2020-11-17 16:05:49 +00:00
a207bd97bb
Naming conventions.
2020-11-17 16:05:49 +00:00
dff5173baf
Exorcise some instances of "modedit".
2020-11-17 16:05:48 +00:00
b9cc9b0f74
sch_sexpr_plugin.cpp: fix incorrect calculation of a relative path on Windows.
...
On Windows paths have a disk identifier. but MakeRelativeTo() was called with
wxPATH_UNIX option, thus creating sometimes incorrect (non existent) relative paths.
2020-11-17 16:24:03 +01:00
9b2dac8df6
fix error in commit 993a684.
2020-11-17 14:56:34 +01:00
993a684959
.kicad_sym files: Fix an issue when a symbol name contains a double quote.
...
This char (accepted in dialog) was escaped in some places, but not all.
So if a symbol name contained a double quote, the lib file was broken.
2020-11-17 12:33:46 +01:00
1db15052b0
Remove unused schematic settings filed
...
It was never written to the file and never used.
2020-11-15 21:30:50 +00:00
b21e07d759
Allow spaces in SheetPins (for bus definitions).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6379
2020-11-15 20:23:15 +00:00
b227d2b910
More component -> symbol.
2020-11-15 20:23:15 +00:00
6e6e0aa644
Naming conventions (including some component -> symbol).
2020-11-15 20:23:15 +00:00
4e8072b8c2
Prefer relative paths.
...
This also prevents us from leaking private information into netlists
and PCBNew files.
Fixes https://gitlab.com/kicad/code/kicad/issues/6361
2020-11-15 20:23:15 +00:00
6654c03041
Embarking on the next adventure: component -> symbol.
2020-11-15 20:23:15 +00:00
9aa6e40b79
Eeschema, fields_grid_table.cpp: fix a crash when the eeschema settings are not available.
...
It happens if the svhematic is not open when opening the symbol editor.
Fix also a compil warning.
Fixes #6384
https://gitlab.com/kicad/code/kicad/issues/6384
2020-11-15 13:50:10 +01:00
d094f86b1a
Finish module cleanup (except for xpms).
2020-11-14 22:00:12 +00:00
d2a88234b6
Fix issue deleting footprint libraries from table.
...
wxWidgets pageChanged handler is evidently buggy. Who would have
guessed?
2020-11-14 20:12:49 +00:00
7bd31d5237
Naming conventions.
2020-11-14 18:26:03 +00:00
8bae52d1c3
Correct naming conventions.
2020-11-14 14:29:11 +00:00
f35736cdd7
Eeschema: minor dialog and panel layout fixes.
2020-11-14 07:40:17 -05:00
592cd99fd5
Pin dialog min size so that we don't wrap our (hacked) overbars.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6371
2020-11-13 17:55:54 +00:00
bdbb68f813
MODULE -> FOOTPRINT.
2020-11-13 16:04:03 +00:00
63a54d003e
More module -> footprint.
2020-11-13 15:16:24 +00:00
522d64968e
Yet more module -> footprint.
2020-11-13 15:16:24 +00:00
f0d0e17aab
Prepare for MODULE -> FOOTPRINT.
2020-11-13 15:16:24 +00:00
43a4cf7957
Coverity fixes.
...
CIDs 309391, 310711, 310712, and 313055.
2020-11-12 08:15:49 -05:00
787bd5109e
Copy properties but not values of datasheet and footprint fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6037
2020-11-11 17:52:15 +00:00
d88eaaf477
Fix various compiler and Coverity warnings
2020-11-11 00:41:02 +00:00
36a139acb3
Tighten up hittest logic for junctions and lines.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6348
2020-11-10 18:08:25 +00:00
4ea3914d4e
Coverity fixes.
...
CIDs: 312996, 305508, 305509, 305510, 312992, 312997, 312994, 312995,
312968, and 306650.
2020-11-10 08:50:16 -05:00
79dd6e6476
Eeschema, ERC: fix missing call to subgraph->ResolveDrivers() when test driver
...
conflicts (more than one name for a net) is disabled.
This missing call was creating issues in tests that need a full connection
calculation, especially ercCheckFloatingWires()
2020-11-10 11:30:30 +01:00
4889f9bb7c
Fix typo in net label orientation calculation.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6333
2020-11-09 12:07:40 +00:00
8665098757
Don't write translated strings from the plugin cache
...
Followup for b7f115bf5f
2020-11-09 07:33:46 +00:00
1f5213946e
Restore accidentally-removed allowsSpaces architecture.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6252
2020-11-08 00:34:04 +00:00
c6ba4cdd19
Naming conventions.
2020-11-07 21:55:18 +00:00
bfd8a62852
Formatting and naming conventions.
2020-11-07 18:50:30 +00:00
91ba002da7
Make sure move machinery gets initialized if we're going to use it.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6293
2020-11-06 12:21:31 +00:00
08ca80a2d8
Smooth out redrawing of toolbars by not letting wx pointlessly calculate both orientations
...
Monkey patch
Fix #5705
2020-11-05 20:56:14 -05:00
670fc645de
More fixes for initializing imported filenames.
2020-11-06 01:33:14 +00:00
3630f32c26
Initialize newly imported files with current schematic extension.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6083
2020-11-05 23:24:59 +00:00
44400ca413
Formatting, some i18n, and shorter log messages.
2020-11-05 23:19:47 +00:00
ae4614bfbd
Symbol editor: do not allow paste into derived symbols.
...
Don't allow select all, copy, cut, paste, or duplicate if the current
symbol is an alias.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6050
2020-11-04 15:00:09 -05:00
43176a5b29
Eeschema: Add Schematic Setup GUI to set junction dot size from list
...
CHANGED: In Schematic Setup->General->Formatting->Connections, added
pulldown for "Junction dot size" with values none, smallest, small
default, large, largest" Added support in "sch_painter.cpp" to not
paint junction when they have a diameter of "1" which is what "none"
sets as the diameter.
2020-11-04 01:49:41 +00:00
3d47eb0d49
Fix localization of the menu strings with accelerator strings
...
The accelerator strings really shouldn't be part of the translation,
and some translations have cause the accelerator keys to be incorrectly
handled. It is simpler to make it separate and just join them to the
translated string.
Make all accelerator modifiers use lowercased Ctrl instead of CTRL
to be the same as the other modifiers.
Fixes https://gitlab.com/kicad/code/kicad/issues/5992
2020-11-04 01:31:52 +00:00
123fe5a887
Sort root symbols by name in new symbol dialog
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5910
2020-11-04 01:31:52 +00:00
88abcc1287
Fix broken handling of closing ERC dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6277
2020-11-04 01:08:21 +00:00
5507575d64
Move ERC dialog to EE_INSPECTION_TOOL and kill when resetting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6111
2020-11-03 20:27:44 +00:00
4be6a27a39
Report error when pin for backannotate can't be found.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6263
2020-11-03 18:53:14 +00:00
2a8ea25209
Null pointer safety.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6263
2020-11-03 15:47:38 +00:00
52e9ec5954
Symbol editor: fix library symbol tree modified state bug.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5573
2020-11-03 09:33:06 -05:00
bd103c133d
Don't save junction colours when they're inherited.
...
Also fixes Edit Text & Graphics Properties to be able to clear
colours from junctions.
Fixes https://gitlab.com/kicad/code/kicad/issues/6018
2020-11-03 14:07:50 +00:00
6a3c868db5
Don't copy lastDriver when cloning connection.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6018
2020-11-03 14:07:50 +00:00
c1ecb4257d
Fix error with empty sheet paths.
2020-11-02 18:05:56 +00:00
20bb3b194f
Eeschema: Display the root sheet name to the user
...
Instead of just `/` denoting the root sheet, use the filename
in preparation for non-hierarchical multi-sheet schematics
2020-11-02 17:50:13 +00:00
644546cd83
Cleanup PathHumanReadable and remove dead code
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6152
2020-11-02 17:50:13 +00:00
2e92cc7958
ERC: use separate tests for input pins and power input pins.
...
Input pins can be driven by many pin types: output, passive, 3state, I/O
But Power pins can be driven by only power output pins, and cannot
use the same criteria in ERC tests.
2020-11-02 12:41:58 +01:00
7c505da368
Make sure ERC tests honour the severity settings.
...
(And in particular, IGNORE.)
Fixes https://gitlab.com/kicad/code/kicad/issues/6178
2020-11-01 17:38:24 +00:00
042e5956c2
Fix library table dialog tab labels.
2020-11-01 09:13:55 -05:00
cf59468de2
Fix library table dialog tab appearance in dark mode.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6236
2020-11-01 08:30:27 -05:00
fbcbed5543
Add acceleratedGraphics prompt for eeschema
2020-10-31 17:49:50 -04:00
7203a51fec
Fix bad include path
2020-10-31 16:42:24 -04:00
3dde4e5616
Eeschema: fix yet another symbol properties dialog layout issue.
...
Stop trying to make a read only wxTextCtrl with a custom font work
for displaying the symbol library identifier and use an ellipsized
wxStaticText control with the standard font instead.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6240
2020-10-31 08:36:59 -04:00
6cefec64ea
Commit pending changes before quitting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6239
2020-10-31 11:50:11 +00:00
92d6988f10
Keep pin positions stable when resizing sheet.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6196
2020-10-31 11:49:07 +00:00
bddc97df30
LibEdit -> SymbolEditor
2020-10-31 10:28:21 +00:00
0d8789935d
Refactoring. Push editing code to toolset.
2020-10-31 10:28:21 +00:00
de013ee60a
Selection center is center of visible items.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6188
2020-10-30 23:37:35 +00:00
4314e4dc93
Update French translation and fixes minor I18n issues.
2020-10-30 21:01:15 +01:00
9065908859
Update SCH_SCREEN's RTree when moving items.
...
Or when modifying geometric shape/properties.
Fixes https://gitlab.com/kicad/code/kicad/issues/5922
2020-10-30 15:26:07 +00:00
45618327cf
Fix crash bug closing schematic with sheet selected.
2020-10-30 15:26:07 +00:00
a1508d2531
Symbol editor: minor symbol properties dialog layout fixes.
2020-10-30 10:49:24 -04:00
a5e628a552
Symbol editor: fix missing footprint filter support for derived symbols.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6038
2020-10-30 09:28:54 -04:00
1d110d5414
Move a couple more dialogs to QuasiModal for syntax help.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5897
2020-10-29 22:55:33 +00:00
5abb61e195
DIALOG_FIELDS_EDITOR_GLOBAL: fix a few minor issues.
2020-10-29 17:27:38 +01:00
9101e61c06
Symbol editor, fix saving legacy symbol library bug.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6157
2020-10-29 08:22:38 -04:00
d26d93b32c
Remove shadow version of autoplace fields variable.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6199
2020-10-28 22:48:23 +00:00
c9d7bdc340
Hook up AutoplaceFields for sheets.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6197
2020-10-28 22:32:36 +00:00
d90d734166
Eeschema: fix symbol rescue bug.
...
Loading the schematic symbol preserves the invalid LIB_ID characters in
the symbol name. Unfortunately, loading the library symbol automatically
fixes the invalid characters so this caused the symbol rescue to not find
library symbols with invalid characters. Replacing the invalid characters
in the schematic symbol name during rescue fixed the issue. This fix
isn't perfect because there is the off chance that replacing the invalid
characters could lead to a name clash in the library resulting in the
incorrect symbol to be rescued.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2319
2020-10-28 09:31:10 -04:00
a6d4ce2a5c
Finish impl of alternate pins.
...
It appears this got shelved while waiting for the sexpr format to be
firmed up, and then I forgot about it.
Fixes https://gitlab.com/kicad/code/kicad/issues/6189
2020-10-28 13:01:42 +00:00
ceb4b56134
DIALOG_FIELDS_EDITOR_GLOBAL: fix crash due to a missing column used in code.
...
Fix column sizes.
Fixes #6191
https://gitlab.com/kicad/code/kicad/issues/6191
2020-10-28 11:22:52 +01:00
49fd95f58d
Bus-wire entries can't propagate through bus junctions
...
This fixes strange connectivity issues observed if you manage
to get a bus junction touching a bus-wire entry.
2020-10-27 22:05:35 -04:00
70c90266a8
Fix crash when loading new schematic with something selected
2020-10-27 22:05:35 -04:00
31d502735c
Better messages for bus entry conflict ERC
2020-10-27 22:05:35 -04:00
2d59bb8156
altium: initial code to insert sheets (but not parse them)
2020-10-27 15:51:57 +01:00
Jeff Young
Jon Evans
Marek Roszko
Seth Hillbrand
Alexis Lockwood
Wayne Stambaugh
Ian McInerney
Franck Jullien
Michael Kavanagh
jean-pierre charras
Peter Montgomery
Roberto Fernandez Bautista
Sylwester Kocjan
Dominik Wernberger
Thomas Pointhuber
PJM