haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
40,907 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

954 Commits

Author SHA1 Message Date
Jeff Young 4c63b4e061 Class name <-> file name sync. 2022-12-29 18:05:57 +00:00
Jeff Young fc15454dd1 Debounce button control drawing. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13288
 2022-12-27 23:55:28 +00:00
Jeff Young a18c2043c4 Minor adjustment for bitmap button size for GTK. 2022-12-26 23:13:22 +00:00
Jeff Young 340a8fb154 Default a library item selection if there is none. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13261
 2022-12-26 14:11:46 +00:00
Jon Evans fbaf4af489 Properties: Allow dynamic update of read-only state 2022-12-25 20:35:44 -05:00
Jon Evans 4a0588db7a Properties: translation fixes 2022-12-22 17:45:16 -05:00
Jon Evans 1590e48ec1 Use translated strings for property display 2022-12-21 18:03:15 -05:00
Seth Hillbrand fcc4b202db Set interpolation/anti-alias in plots 
This doesn't do much for Linux, but the interpolation modes for MSW and
Mac should clean up lines a bit in plotting

Fixes https://gitlab.com/kicad/code/kicad/issues/10239
 2022-12-21 12:03:47 -08:00
Tanay Gupta b0cbab5c4b Footprint Editor: Focus search field when window is first opened 
The search field on the Symbol Editor is focused when its window 
is first opened. Similar behavior has been implemented in the search
field of the Footprint Editor with this change.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13100
 2022-12-20 19:54:02 +00:00
Jeff Young 9a8a25a596 Don't dismiss an infobar that isn't shown to start with. 
On Mac (at least), we get a 1 second pause even if the bar wasn't shown.

Fixes https://gitlab.com/kicad/code/kicad/issues/13193
 2022-12-18 10:55:37 +00:00
J RB 5f0d26cbe2 Remove argument to wxButton::GetDefaultSize on wxGTK-3.0.x 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13181
 2022-12-16 22:40:37 +00:00
Jeff Young 0e2a4e3f15 Better handling of multi-monitor scaling. 2022-12-16 19:11:34 +00:00
Jeff Young 75a4de4744 Dim bitmap when button is disabled. 2022-12-16 01:22:50 +00:00
Jeff Young 355bfe1587 Blind attempt to fix MSW rendering bug. 2022-12-14 13:36:28 +00:00
Jeff Young c0872364d4 Get rid of bloated bitmap buttons on wxWidgets 3.2. 2022-12-13 20:48:02 +00:00
Jeff Young d3228dbab2 Differentiate search panel font between Mac and others. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13145
 2022-12-13 00:47:19 +00:00
Jeff Young 3144459939 Fix issue with text edit boxes being too narrow on wxWidgets 3.2. 2022-12-12 20:45:48 +00:00
Jeff Young 2a32bc4372 Pay attention to indeterminate state in onUnitsChanged(). 
Fixes https://gitlab.com/kicad/code/kicad/issues/13127
 2022-12-12 17:37:16 +00:00
Jeff Young 4e47b5c25f Fix some layout and selection issues on Mac. 
Some of these are due to moving to wxWidgets 3.2, but I'm not sure
all of them are.  In particular, the need for CallAfter() in the
search pane's selection handler is probably just a wxWidgets bug on
Mac (the control lies about the current selection inside the event
handler).

Also sets better column widths in the search pane.
 2022-12-11 00:56:46 +00:00
Jon Evans 2b0d7f65d0 Properties: sync wxPGGlobalVars map state with editor global state 
Thanks to @dsa-t for suggesting this

(maybe)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12297
 2022-12-08 07:55:57 -05:00
Jon Evans 435651237c Properties: Support overridden availability functions 2022-12-08 00:09:51 -05:00
Jon Evans 33d76f63b0 Properties: save and restore splitter position 2022-12-07 21:38:33 -05:00
Jon Evans ad8e5891d2 Properties: update evaluator locale when creating editors 2022-12-06 17:56:33 -05:00
Jon Evans d435ba6485 Properties: improve handling of enter/return 2022-12-06 09:10:59 -05:00
Jon Evans 1a0c774940 Properties: Space to toggle booleans; fix arrow keys 2022-12-06 08:56:13 -05:00
Jon Evans 071a2ec46d Properties: clean up some unit handling 
Make sure units show up properly in editor on focus kill
Make sure editor shows correct value initially
 2022-12-06 08:55:48 -05:00
Jon Evans 40f9a59255 Remove disconnects from SetControl 
These aren't needed as the control is going to be destroyed by the grid,
and can cause a crash on exit if the control is destroyed before the unit binder.
 2022-12-06 08:06:16 -05:00
Jon Evans 74fa88c0f6 Defer splitter calculation until next event 
Windows doesn't have valid sizes in the size event

Fixes https://gitlab.com/kicad/code/kicad/-/issues/13019
 2022-12-06 08:05:28 -05:00
Jon Evans b673202a4e Remove extraneous event binding 2022-12-05 20:44:47 -05:00
Jon Evans d0024bd9f7 Properties: clear text ctrl from unit binder before it is destroyed 
The lifetime of this text ctrl is managed by the property grid, so
we need to catch when it is hidden before destruction in order to avoid stale pointers being used to handle unit change events.

Credit to @dsa-t for the fix
 2022-12-05 19:33:20 -05:00
Seth Hillbrand 77b763f8ba Change binding with units 2022-12-05 15:34:23 -08:00
Seth Hillbrand 6f43915b25 Don't keep a stale iu reference around 
The IU memory areas are const but we need to be able to update this when
the frame changes, so use pointers instead
 2022-12-05 13:33:45 -08:00
Seth Hillbrand 54dd494ff2 Remove frame dependency from UNIT_BINDER 
Place the frame information into the event data instead of keeping a
pointer (potentially invalid) into the frame
 2022-12-04 16:50:27 -08:00
Jeff Young f6822120b3 Enable tab and return commit in property grid. 2022-12-04 11:51:44 +00:00
Jeff Young f805fd267f Divorce UNIT_BINDER from wxFrame. 
This allows us to supply Pcbnew or Eeschema as the unitsProvider when
called from the main frame.

Fixes https://gitlab.com/kicad/code/kicad/issues/13066
 2022-12-04 11:51:44 +00:00
Jon Evans 8f39dd69be Properties: fix caption text in dark mode on GTK 2022-12-02 22:43:11 -05:00
Jon Evans 4134db3c47 GCC fixes 2022-12-02 22:38:15 -05:00
Jon Evans 2091aaba2f Properties: Move angles to UNIT_BINDER 
Also add support for unicode degree sign in evaluator
 2022-12-02 21:25:42 -05:00
Jon Evans 5e352d2a66 Properties: improve handling of unit binders 2022-12-02 19:37:44 -05:00
Jon Evans 12b7e68703 Properties: Skipped group should not assert 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13028
 2022-11-29 18:12:28 -05:00
Jon Evans b2b3f5752f Properties: Add grouping and sorting by creation order 2022-11-27 22:40:23 -05:00
Jon Evans 5bbe21f540 Properties: don't rebuild the panel when closing an editor 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12984
 2022-11-27 14:29:16 -05:00
Jon Evans 96fe93618e Properties: Stop sorting by name 
It's more useful to have properties shown in add order,
since we can group them
 2022-11-25 16:29:56 -05:00
Jon Evans 5061f0556f Properties: implement ellipsization for name column 2022-11-25 12:37:47 -05:00
Jon Evans 220ef6fb44 Properties: Add some missing footprint properties; cleanup 
Add concept of "internal" properties that will be accessible from
Python/DRC but not shown in the Properties Manager
 2022-11-25 12:37:47 -05:00
Jon Evans 696a1cd39d Properties: improve handling of column splitter 2022-11-25 09:58:44 -05:00
Jon Evans 4285b38b74 Properties: Handle units changes correctly 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12885
 2022-11-24 17:15:07 -05:00
Jeff Young 93c6d99a6d Move saving preferences out of the destructor. 
For other reasons we wrap the adapters in a wxDataObject, which has
delayed destruction semantics, but that means the settings stuff may
no longer be around when the d'tor executes.

Fixes https://gitlab.com/kicad/code/kicad/issues/12371
 2022-11-14 20:01:37 +00:00
jean-pierre charras 9501f4303d Rename CreateWindow to CreateKiWindow to avoid a collision name with a windows header 
No code change, but it fix an issue specific to msys2 that bother me when
trying to fix issues with wx 3.0.x version
 2022-11-08 12:31:07 +01:00
Jon Evans 32b3f24f8b Thanks xorg 2022-11-06 18:27:18 -05:00
Jon Evans f708dad5cd Don't use frame events for PROPERTY_EDITOR_UNIT_BINDER 2022-11-06 18:26:17 -05:00
Jon Evans 68de92313e Properties: move to custom editor for distances; refactoring 
Also fix display of angle values since EDA_ANGLE was introduced

Fixes https://gitlab.com/kicad/code/kicad/-/issues/12290
 2022-11-06 11:40:45 -05:00
Jeff Young b385a4b60a Implement DarkMode for the Appearances Palette. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11734
 2022-11-06 00:34:45 +00:00
Jeff Young cf581137d8 Handle multiple unitProviders in a WX_GRID. 
This allows us to provide a more consistent and less buggy presentation
of the netclasses grid in both eeschema and pcbnew.

Fixes https://gitlab.com/kicad/code/kicad/issues/12826
 2022-11-05 10:23:12 +00:00
Jon Evans a5d685ff5c Handle coordinate transforms in properties system 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12320
 2022-10-31 23:01:52 -04:00
Marek Roszko c0f8810759 Don't fix the visibility icon size or it will never scale properly 
Related https://gitlab.com/kicad/code/kicad/-/issues/11880
 2022-10-30 15:03:00 -04:00
Jeff Young fb8493d0bc Move model pin editor to GRID_CELL_ICON_TEXT_POPUP. 
wxChoice is hopeless on Mac (it still doesn't highlight on rollover),
and using a char for the "assigned" graphic isn't great.
 2022-10-28 15:27:00 +01:00
Jeff Young 58ac62d493 Return cursor to arrow when leaving search ctrl. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12764
 2022-10-27 16:27:19 +01:00
Jeff Young c8261d13a5 Better platform fidelity on Mac for SPLIT_BUTTON. 2022-10-24 00:14:12 +01:00
Jeff Young 064e7f0f2c Dark mode hacks for SPLIT_BUTTON on OSX. 2022-10-23 17:56:44 +01:00
Jeff Young e02c05d38f Add unit and eval support to WX_GRIDs. 
Fixes https://gitlab.com/kicad/code/kicad/issues/1871

Fixes https://gitlab.com/kicad/code/kicad/issues/4285
 2022-10-11 23:40:58 +01:00
Seth Hillbrand b716afd6f1 Clarify various uses of "Center" 
Distinguish between the english verb "Center" and the noun "Center",
which may be translated differently

Fixes https://gitlab.com/kicad/code/kicad/issues/11109
 2022-10-03 12:48:57 -07:00
Jeff Young 01e6491046 Fix side-effect of multi-select in lib trees. 2022-10-03 19:11:31 +01:00
Jeff Young 230762053d Translate mod flags between wx and Kicad. 
Also we have to use wxEVT_CHAR_HOOK instead of wxEVT_CHAR or up/down
end up getting handed to COMMON_TOOLS.

Fixes https://gitlab.com/kicad/code/kicad/issues/11034
 2022-10-03 18:42:50 +01:00
Jeff Young 2422b9a7c8 Simplification, formatting, and spelling. 2022-10-03 18:42:50 +01:00
Jeff Young e335c1c612 Fix for LIB_TREE hotkeys over canvas and possible fix for over LIB_TREE itself. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11034
 2022-10-02 22:22:21 +01:00
Jeff Young c0a666507c Work around more instances of the wxWidgets color string locale bug. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12552
 2022-09-30 20:56:25 +01:00
Jeff Young f2de3e9f67 Minor cleanup. 2022-09-30 13:02:08 +01:00
Marek Roszko 46471247ff Some header cleanup 2022-09-27 23:25:20 -04:00
Marek Roszko 21c1c97bf3 Unbind search pane listview events on destruction to avoid event race 2022-09-27 19:16:29 -04:00
Jon Evans 375b530dad ADDED: Column selection and reordering in symbol chooser 2022-09-25 22:49:49 -04:00
jean-pierre charras 28165c6a31 SEARCH_PANE_TAB: fix a typo and add missing event handler. 2022-09-25 16:40:08 +02:00
Jeff Young 659a6e5b04 Replace macHack as its requirement sadly never went away. 2022-09-24 23:50:45 +01:00
Jon Evans dcfcfd5f29 Don't run context menu actions when clicking outside the menu 2022-09-23 23:44:08 -04:00
jean-pierre charras c44e54756a search panel: fix a crash and a refresh issue after selecting a second item 
at least on W10/msys2
 2022-09-21 19:36:35 +02:00
Jeff Young 8eb68ee472 Add pin/unpin context menu to Symbol Chooser and Footprint Chooser. 
Also moves some more code down into common so it can be shared.

Fixes https://gitlab.com/kicad/code/kicad/issues/12384
 2022-09-21 14:45:12 +01:00
jean-pierre charras 25f1f7b0df Fix a compil issue on GCC 2022-09-21 09:04:31 +02:00
Marek Roszko ec25463fed Allow multi-selecting from the search pane 
Fix https://gitlab.com/kicad/code/kicad/-/issues/12476
 2022-09-20 23:58:49 -04:00
Marek Roszko 30dbcbbcf5 Only search the current tab on events 2022-09-20 23:38:06 -04:00
Jeff Young 45d6b4a9fc Readability improvements. 2022-09-19 11:18:20 +01:00
Jeff Young 85e8d1eb38 Try re-organizing the events for the search ctrl to allow MSW icon to be shown. 
See further comments in bug report.

Fixes https://gitlab.com/kicad/code/kicad/issues/11743
 2022-09-16 17:04:46 +01:00
Jeff Young 4de264ddaa Don't steal up/down arrows from textboxes and the like. 2022-09-16 16:52:26 +01:00
Mark Roszko b00178adb3 Nuke base_units from orbit 2022-09-16 04:38:10 +00:00
Jeff Young 9a4a68fb5e Hide search button on MSW. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11743
 2022-09-15 23:23:23 +01:00
Jeff Young a21d24a4c8 Experiment with loading recent searches into the search menu. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11743
 2022-09-15 14:44:02 +01:00
Jon Evans da9be1a812 ADDED: Multi-selection cut/copy/paste in symbol editor library tree 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11505
 2022-09-14 22:20:38 -04:00
Mark Roszko f304e2d4f6 ADDED: Search/inspect pane 2022-09-14 02:59:57 +00:00
Jeff Young 52ea9d0bc5 Don't allow preview canvases to steal focus when keyboard navigating preferences tree. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10407
 2022-09-10 20:15:49 +01:00
Jeff Young f87bf3c46d Special case up-key so it can get past headers in paged dialogs. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10078
 2022-09-10 09:31:27 +01:00
Jeff Young c30a557810 ADDED netclass assignment from PCB canvas. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5975
 2022-09-03 19:29:59 +01:00
qu1ck 977b6cd8f3 PCM: add ability to pin packages 
Pinned packages don't affect available update notification and will not
be updated with "Update All" button. Manual update is still possible but
will trigger a confirmation dialog.
 2022-09-03 17:07:55 +00:00
Marek Roszko 03aa63bd50 Move 5 helpers to EDA_UNIT_UTILS since they aren't iu specific 2022-08-29 20:11:03 -04:00
Jeff Young 48f77973da Another try at getting the Link combobox working on MSW. 2022-08-28 23:25:01 +01:00
Roberto Fernandez Bautista bfdb39f418 Properties Panel: Plain-language descriptive noun function of EDA_ITEM 2022-08-22 21:32:33 -04:00
Jon Evans 91c15b7e21 Properties panel appearance tweaks 2022-08-22 21:32:33 -04:00
Jon Evans 3c6e8aea0f Properties panel: post-rebase fixes and hide by default 
Remove layer widget re-added by Orson's rebase
 2022-08-22 21:32:33 -04:00
Maciej Suminski 990ea5595e Properties: Fixed a startup crash 2022-08-22 21:32:33 -04:00
Maciej Suminski c37c429c75 Rename PROPERTY_PANEL::Update() to PROPERTY_PANEL::UpdateData() 
The base class (wxPanel) already provides Update() method,
which should not be overridden.
 2022-08-22 21:32:32 -04:00
Maciej Suminski 7f00efe6cf Properties: Fixed conditional properties using enum values in the conditions 
When wxAny holds an enum, it cannot be compared with an integer due to a
missing conversion function. In such case, conditional properties
compare a raw value rather than wxAny.
 2022-08-22 21:32:32 -04:00
Maciej Suminski 8fa513e903 Properties: fix Properties panel refresh 2022-08-22 21:32:32 -04:00
Maciej Suminski f6f6ebd5f9 WIP: Properties GUI 2022-08-22 21:32:32 -04:00
Jeff Young 32461c91e9 Wide status bars can afford to give the text more room. 2022-08-22 22:33:38 +01:00
Jeff Young f42b66bc1c Regularize ellipsization of menu and status text. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12257
 2022-08-22 17:52:58 +01:00
jean-pierre charras e0fbe2542f Fix a few compil and Coverity warnings. 2022-08-19 10:53:29 +02:00
qu1ck f4fa3b02c5 PCM: automatic check for repository updates 2022-08-18 20:41:43 +00:00
Jeff Young 2e2264cb74 Minor cleanup. 2022-08-09 08:46:12 +01:00
jean-pierre charras d1ff8f4781 PROGRESS_REPORTER_BASE: call code to resize it only if the message has change. 
In wxWidgets 3.15 (and perhaps older version) the call to GetTextExtent() probably
creates major issues when called too many times, at least oo msys2.
It was probably also time costly.
Calling it and resize the PROGRESS_REPORTER only when needed fixes these serious issues.
Issues happened only when the board has a lot of zones (when teardrops are added)
 2022-08-01 13:18:50 +02:00
Jeff Young 753f2f3e4c Display descriptions in second column of library trees. 
Also fixes some bugs in how the columns are sized.

Fixes https://gitlab.com/kicad/code/kicad/issues/12090
 2022-07-28 14:51:47 +01:00
Jeff Young 4a40d94b5a More hotkey label cleanup. 2022-07-27 12:29:01 +01:00
Jeff Young d9d579c895 Clean strings before displaying in hotkeys list. 
Also make sure the description column is wide enough.

Fixes https://gitlab.com/kicad/code/kicad/issues/11994
 2022-07-27 12:29:01 +01:00
jean-pierre charras 993c446fdf Fix some warnings detected by PVS-STUDIO (most are not used vars) 2022-07-25 18:23:52 +02:00
Jeff Young e10158ff10 ADDED show pin names on footprint pads when assigning to symbol. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4576
 2022-07-24 23:41:41 +01:00
Jeff Young def87c969e Redo the pinned-libraries storage architecture. 
1) always use preferences directly
2) allow nicknames from either preferences or project
3) store-after-modify

Fixes https://gitlab.com/kicad/code/kicad/issues/12000

Fixes https://gitlab.com/kicad/code/kicad/issues/11892
 2022-07-22 09:31:10 +01:00
luz paz 79fa911e0e Fix various typos 
Found via `codespell -q 3 -S *.po,./thirdparty,./Documentation/changelogs -L aactual,acount,aline,alocation,alog,anormal,anumber,aother,apoints,aparent,aray,ba,busses,dout,einstance,leaded,modul,ontext,ot,overide,serie,te,,tesselate,tesselator,tht`
 2022-07-21 16:31:41 +00:00
Seth Hillbrand 9faff78258 Keep the reset text correct 
Ensures that after setting the initial dialog page, we also set the
proper text in the reset button as the event does not get fired

Fixes https://gitlab.com/kicad/code/kicad/issues/11856
 2022-07-14 14:19:09 -07:00
Jeff Young 190fb23e88 Add pinned library support to Footprint and Symbol Viewers. 
Also includes adding libraray and symbol filters to Symbol Viewer.
 2022-07-09 17:41:10 -06:00
Seth Hillbrand 907d8fc018 Revert "Fix Swatch sizes" 
This reverts commit 25c3a4681f.

Windows default sizes are too big when they are the correct size on
Linux.  We need the DU scaling for swatches
 2022-07-01 11:37:55 -07:00
Seth Hillbrand 25c3a4681f Fix Swatch sizes 
The swatches are surrounded by non-scaling icons.  We should not scale
the swatches unless we also scale the icons.  This patch makes all
elements in the appearance panel equally non-scaling

This relates to https://gitlab.com/kicad/code/kicad/-/issues/11880
 2022-07-01 10:56:13 -07:00
Seth Hillbrand 89eeba3312 Correct WX check for DPI handler calls 2022-06-27 13:34:39 -07:00
Jeff Young 52bc2511cd Add a radioButton mode to IMAGE_BUTTON. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11797
 2022-06-12 20:09:46 +01:00
Mike Williams 857990a883 Hierarchy: turn into a left side pane 
Drop auto-closing option as well.
 2022-06-02 21:56:17 +00:00
Jon Evans f4372a2de9 UNIT_BINDER should support long long ints 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10870

(cherry picked from commit eb1164fc93)
 2022-05-31 21:54:51 -04:00
Seth Hillbrand 2da470e1f9 Prevent programatic changes from sending events 
When setting search history using the CTOR, we need to avoid triggering
an event that will run independent of the user interaction.  Our
LIB_TREE interface is fragile on GTK and needs explicit conditions to
avoid segfaults

Fixes https://gitlab.com/kicad/code/kicad/issues/11633
 2022-05-19 09:12:15 -07:00
Marek Roszko f85251ef75 Fix eda_doc not looking for schematic locally 
It looks like this was overlooked by Jeff in 2020 not realizing eda_doc isn't built under eeschema but common in cc9ac37a0e
 2022-05-10 21:28:48 -04:00
Jeff Young 47e002a33d Add font to status bar for text objects. 2022-04-26 18:52:53 +01:00
Jeff Young 7f4f5f2882 Save and re-load query string in Choose Symbol dialog. 
While this has been requested on its own, it's primarily done here
because wxWidgets decided to send a SEARCH_CANCEL from a wxSearchCtrl
when hitting <ENTER> if the search control holes the empty string.
This causes us to not do a symbol instert in the Chooser dialog.

Fixes https://gitlab.com/kicad/code/kicad/issues/10169

Fixes https://gitlab.com/kicad/code/kicad/issues/7699
 2022-04-17 00:33:56 +01:00
Seth Hillbrand 9722a05820 Attempt to fix the Mac DPI grid mixing 
When moving windows between monitors on Mac that changes the DPI, we
observe incorrect re-sizing of columns and rows.  This attempts to
rectify the situation by avoiding DPI changes for Mac builds.

Fixes https://gitlab.com/kicad/code/kicad/issues/10586
 2022-03-22 00:02:05 +00:00
jean-pierre charras 2bba277c5e Unit binder: fix hang and DIALOG_WIRE_BUS_PROPERTIES: fix uninitialized variable. 
The hang can be Windows specific.
 2022-03-19 10:22:41 +01:00
Seth Hillbrand ba4b8bfa69 Prevent WX_PROGRESS_REPORTER from dominating system 
Raising the window on each updateUI prevents multitasking by stealing
focus from the current window.
 2022-03-18 15:50:44 -07:00
Jeff Young ce21da8cbb Select all when UNIT_BINDER is a token rather than a string. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9757
 2022-03-16 14:56:32 +00:00
Marek Roszko 605dd8a580 Don't use wxScreenDC as this returns "a" screen but not "the" screen 
Windows supports per-monitor and per-app DPI. wxScreenDC is unable to resolve the actual DPI setting since it has no window context.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/10681
 2022-03-13 23:31:16 -04:00
Jeff Young 96f9ea286e Natural sorting for nets. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10534
 2022-03-08 13:22:20 +00:00
Jeff Young 1f16092e29 Infobar warning if symbol loading was cancelled. 
Also makes sure the progress dialog is closed when we're done reading
symbols (it used to stay up for much of the symbol editor initialization).

Also makes sure that any cancel in the preLoad step is honoured in the
sync step.  (The preload is done because it is multi-threaded and therefore
faster than the single-threaded sync.)

Also makes sure that individual threads pay attention to the cancellation,
not just the GUI thread.

Fixes https://gitlab.com/kicad/code/kicad/issues/8372
 2022-02-27 17:06:08 +00:00
Jeff Young cb16ad7557 Debounce layer visibility buttons and fix issues with FP Editor. 2022-02-23 17:52:08 +00:00
Jeff Young 9fb3032c77 Fix Mac button-text grid control spacing. 2022-02-17 12:42:10 +00:00
jean-pierre charras 0ed3bba108 Fix a wxWidgets alert 2022-02-17 10:06:19 +01:00
Jeff Young 8e26946567 Don't shrink progress reporter when message changes; only grow. 2022-02-15 19:19:02 +00:00
Jeff Young ca56de7816 Show DRC overflows in both tab titles and number badges. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10617
 2022-02-09 17:04:32 +00:00
jean-pierre charras ac7cbcce61 WX_GRID: highlight the selected cell after selection by tab or arrow keys. 
Fixes #9290
https://gitlab.com/kicad/code/kicad/issues/9290
 2022-02-04 12:36:27 +01:00
Seth Hillbrand b87e4efc68 Add additional buffer space around cell text buttons 
The baseline -1 buffer works for some GTK themes but not others.  -3
appears to work for chunky themes like those used in KDE (and others).

Fixes https://gitlab.com/kicad/code/kicad/issues/5690
 2022-01-26 12:44:11 -08:00
Jeff Young 0091c76a6f Excise deci-degrees from UNIT_BINDER. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10495
 2022-01-19 00:10:32 +00:00
Jeff Young 3f98769a77 More EDA_ANGLE. 
Includes bug fix for catastrophic error in Add() for converting to
radians.

Includes bug fixes for the fact that the pcbnew test can't seem to
find the ANGLE_* objects (getting all 0's instead).
 2022-01-15 01:30:04 +00:00
jean-pierre charras d0f2c20235 Define our kicad font name only once, and do not translate it. 
Especially using a translated name breaks kicad config and files because
in non English languages both translated and not translated names were used in code.
 2022-01-13 14:32:55 +01:00
Jeff Young 76368af7b9 Font cleanup and bug fixes. 2022-01-09 18:33:53 +00:00
Jeff Young 78cac128b7 Careful: symbol fonts have no language. 
Also a bit of clean up to shut up a false-positive in Coverity (and
clangd) on dereferencing a possibly (not) nullptr.
 2022-01-09 11:34:20 +00:00
Jeff Young eb58d7e44c Text glyph caches and bug fixes. 
1) Unify metrics between stroke and outline fonts
2) Unify handling of rotation and mirroring
3) Bug fixes in collision handling
4) Use of VECTOR2I (instead of VECTOR2D) for world-coordinates
5) Generate outline font overbar with rounded ends and fix rotation
bugs
6) Generate wxEVT_CHOICE events from FONT_CHOICE::SetFontSelection
7) Change text-item PNS SOLIDs to use compound shapes
 2022-01-08 16:47:45 +00:00
Jeff Young a2030a5956 GUI for font selection. 2022-01-08 16:47:45 +00:00
Jeff Young e21fa31f64 Rip out rest of macHack architecture. 2022-01-03 22:09:56 +00:00
Jeff Young 2fdbc41b8f Remove macHack. 
Either the recently added size-event works better than the version I
originally tried or it's simply no longer needed in wxWidgets 3.1.
In any case, I can't reproduce the wxGrid layout errors anymore.
 2022-01-03 18:24:26 +00:00
Jeff Young 27d8df1122 Don't update units for UNSCALED, PERCENT or DEGREES. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10020
 2022-01-01 20:46:45 +00:00
Wayne Stambaugh b5960fef38 Fix another broken tree book selection in paged dialogs. 2021-12-28 16:57:42 -05:00
Wayne Stambaugh 7b1b96c933 Fix broken tree book selection in paged dialogs. 
This only affected the tree controls that only parented sub-pages.  Do
not use the dialog ctor to select the initial page.  Queuing a page
changed event to fire after the dialog is shown is the proper solution.
 2021-12-28 09:43:57 -05:00
Wayne Stambaugh 14c148cb38 Expunge update UI event handler from paged dialog object. 
Use the book control page changing event to update any pages prior to
them being shown.  When the validation fails when changing pages, the
page change is vetoed until the invalid condition is fixed by the user.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/5049

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10139
 2021-12-27 18:40:12 -05:00
Jeff Young 03a2723b67 Improve GUI of lib item colors. 2021-12-24 21:21:11 +00:00
Jeff Young c3552a940a Make sure standard OK/Cancel buttons respond to current language. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9635
 2021-12-24 18:13:11 +00:00
Jeff Young a6dd1bf09b Implement Reset to Defaults for all preferences panels. 2021-12-24 17:38:39 +00:00
Jeff Young 889970a449 SCH_NETCLASS_FLAGs and SCH_FIELDs for labels. 
ADDED: a new label type for netclass flags.
ADDED: the ability to define fields on labels.
 2021-12-24 16:13:27 +00:00
Jeff Young d28714167c All the preferences, all the time. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7877

Fixes https://gitlab.com/kicad/code/kicad/issues/5153
 2021-12-24 13:08:44 +00:00
Jeff Young 28b279cb2d Units cleanup. 
It's 2021.  Time to move beyond ASCII.  This also makes spacing of
units consistent (space before abbreviated units, no space before
symbolic units).
 2021-12-23 22:17:10 +00:00
Jeff Young e26341d424 Cleanup. 2021-12-23 20:36:18 +00:00
Alex 5bf9bd3ebb Hotkey editor: prevent closing on Enter release 2021-12-14 19:52:24 +00:00
Wayne Stambaugh 0bfb5bab02 Fix some minor paged dialog object issues. 2021-12-14 08:15:02 -05:00
Jon Evans 6e51905e69 Kick wxWidgets to set column sizes the first time 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6396
 2021-12-13 18:37:36 -05:00
Wayne Stambaugh 755607b8f8 Fix a few wxUpdateUIEvent retrigger loops. 2021-12-13 15:46:13 -05:00
Wayne Stambaugh e32448edc2 Center preferences dialog correctly on initialization. 2021-12-13 09:17:42 -05:00
Jeff Young 48c3734eea Dark mode colors for HTML report generator. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9688
 2021-11-19 13:36:14 +00:00
Jeff Young 4e6a201881 Correct cursor for search control buttons. 2021-11-18 18:25:14 +00:00
Wayne Stambaugh e57ef66971 Fix build error with wxWidgets 3.0. 2021-11-17 12:28:23 -05:00
Jeff Young 1650d56838 Handle search cancel in the lib trees. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9671
 2021-11-17 14:01:53 +00:00
Jeff Young 66d9e7073f More discrete borders for Kicad mgr, PCM and appearances panels. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9616
 2021-11-14 15:01:44 +00:00
Jeff Young 0b48876ce5 Decouple left and right pane minimums for splitter window. 2021-11-12 02:12:44 +00:00
Jeff Young 7211c5a350 Kicad look & feel and reduce conceptual nesting depth of PCM. 2021-11-10 12:42:54 +00:00
Roberto Fernandez Bautista a79a221257 Array creator tool: Add option to assign unique reference designators 
ADDED: Option to assign unique reference designators to footprints
created with the array tool [pcbnew]

CHANGED: Array creator dialog no longer displays pad numbering properties
when in the board editor. [pcbnew]

Fixes https://gitlab.com/kicad/code/kicad/-/issues/2354
 2021-10-25 22:38:49 +01:00
Jeff Young 672b27f91a Formatting. 2021-10-15 12:45:43 +01:00
Mikolaj Wielgus 5f53019290 Substitute all wxHtmlWindow with HTML_WINDOW 
Remove other places where <body> tag is used to override the default
black-on-white theme.
 2021-10-12 07:07:15 +00:00
Seth Hillbrand 759abb7928 Make sure that relpath gets a value 
Even if we are not asking for normalized paths, we need to return a
value in the relpath.  This modifies 574bef2237

Fixes https://gitlab.com/kicad/code/kicad/issues/9363
 2021-10-11 09:19:41 -07:00
Jeff Young 95f841a037 A more nuanced method of making Board & Schematic Setup read-only. 
This one still allows you to scroll to see all contents.

Fixes https://gitlab.com/kicad/code/kicad/issues/9302
 2021-10-06 11:16:46 +01:00
Seth Hillbrand 9a8d1246cc We don't keep a CHANGELOG.TXT 
Direct interested readers to AUTHORS.TXT instead.
 2021-10-05 19:46:53 -07:00
Seth Hillbrand 9066165792 Fix compile error on Mac 2021-10-05 19:44:35 -07:00
Seth Hillbrand 548e5f49bd Clean up unused variable usage 
Unused variables in function calls can be commented out.  Unused
return variables get a new routine `ignore_unused()` that silences the
warnings with zero overhead.
 2021-10-05 10:00:30 -07:00
Jeff Young 574bef2237 Normalize drawing sheet path to env vars & prj, not just prj. 
Also cleans up the dialog a bit.

Also changes the workings of NormalizePath to return the input if
it couldn't be shortened which saves open coding that behaviour in
all its callers.

Fixes https://gitlab.com/kicad/code/kicad/issues/9036
 2021-10-02 23:39:45 +01:00
Jeff Young 4e9b747e86 Fix wx3.0 (presumably) compile issue. 2021-10-02 12:39:33 +01:00
Jeff Young 671e9f2dba A better algorithm for centering library items in the tree. 
It still doesn't center as wxWidgets' API is poorly suited for that.
But it does now at least keep it off the very top or bottom.
 2021-10-02 10:41:26 +01:00
Jeff Young c7f098ab25 Remove unused variable. 2021-09-24 16:03:13 +01:00
Seth Hillbrand 0f10748226 Disallow Ctrl-Tab and Ctrl-Shift-Tab as hotkeys 
Fixes https://gitlab.com/kicad/code/kicad/issues/9010
 2021-09-20 11:13:50 -07:00
Jeff Young 2479e1d7b1 Improve common settings property grouping. 
Also moves apply-icon-scaling-to-fonts to its own checkbox.  (We used
to try to infer when to do it, but that turns out to be a rathole.)
 2021-09-16 18:31:44 +01:00
jean-pierre charras 666f7ea38c WX_GRID::EnsureColLabelsVisible(): avoid updating column label size when not needed. 
Updating column label size generates a UI event and if EnsureColLabelsVisible()
is called inside a UI event, this is a bit annoying.
 2021-09-14 20:08:48 +02:00
Jeff Young a5247471f7 Expunge a bunch more fixed font specs from wxFormBuilder files. 
Also removes the -1 sizing of the status bar on GTK and MSW.

Fixes https://gitlab.com/kicad/code/kicad/issues/8608
 2021-09-12 13:53:12 +01:00
Jeff Young 9c78e4cf54 Mac needs different font size handling than MSW & GTK. 
Mac already uses diverse font sizes (for instance, smaller fonts for
radio button groups), and the anti-aliasing is a lot better.  The
other platforms need a more limited range of sizes.

Fixes https://gitlab.com/kicad/code/kicad/issues/8608
 2021-09-11 23:40:31 +01:00
Jeff Young ed8b63505d Fix font scaling issues in StatusBar and Selection Filter. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8608
 2021-09-11 18:25:11 +01:00
Jeff Young fbee62fc15 Tie font size scaling to when automatic icon scaling fails. 
It appears that SetSymbolicSize() and ConvertDialogToPixes() fail
under the same circumstances.
 2021-09-11 15:29:51 +01:00
Jeff Young cc13d6b2e8 Try out GTK font scaling based on icon scaling architecture. 
wxWidgets symbolic sizes fail on HiDPI GTK screens; the dialog pixel
stuff fails on non-scaled GTK screens.

Fixes https://gitlab.com/kicad/code/kicad/issues/8608
 2021-09-11 10:57:25 +01:00
Jeff Young ad59254be8 Another round of font sizing tweaks. 
It appears that both strategies in the last commit worked, leaving us
with squared scaling.  The dialog pixel architecture seems safer than
our icon scaling stuff, so this version attempts to use only it.

Also works around a bug where wxELLIPSIZE_MIDDLE doesn't work on Mac.

Fixes https://gitlab.com/kicad/code/kicad/issues/8608

Fixes https://gitlab.com/kicad/code/kicad/issues/8375
 2021-09-10 21:46:13 +01:00
Jeff Young 7a822b55aa Another round of changes to attempt to fix the GTK font size issue. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8608
 2021-09-10 15:59:50 +01:00
Jeff Young 7a035e2675 More font scaling changes. 
These may or may not fix scaling issues on GTK with HiDPI monitors.
 2021-09-09 11:17:21 +01:00
Jeff Young f013dbc7c4 More uniform handling of status fonts. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8608
 2021-09-08 21:34:22 +01:00
Jeff Young e7debc495b WIP 2021-09-08 20:17:59 +01:00
Seth Hillbrand 343dbf0f5b Change default 45° hotkey to shift-space 
This requires enabling the space key to be bound with shift, which was
disabled based on an overbroad limit of only allowing shift to be mapped
with letter keys
 2021-09-06 12:18:29 -07:00
Mike Williams 0b2e66d3b7 Infobar: Don't use animations on Windows/GTK 
Seems to cause issues on Windows where the animation locks the screen.
Doesn't effect Linux, possibly because wxWidgets uses a native GTK
infobar that doesn't animate anyway.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8987
 2021-08-27 17:38:16 +00:00
Jon Evans 5f2d238c93 Work around GTK issue with wxSearchCtrl 
Also remove redundant icons in LIB_TREE (recent GTK
search controls have an icon built-in)

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9019
 2021-08-24 23:04:28 -04:00
Jon Evans c80efb0f98 Fix save/load of appearance panel width on show/hide 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8982
 2021-08-19 21:15:14 -04:00
Wayne Stambaugh b14b8b5fb1 Move headers from common folders to the appropriate include folders. 2021-08-17 12:40:31 -04:00
Jeff Young 41619ebbe2 Decouple PROGRESS_REPORTER interface from implementations. 2021-08-14 21:05:49 +01:00
Jeff Young a10f2b284c Unify negative zero and percent handling in UNIT_BINDER. 
Some values, such as solder mask margins, are usually negative and it
helps to display zero as "-0.0".
 2021-08-06 18:16:38 +01:00
Jeff Young c5e195bdff Cleanup (includes and formatting). 2021-08-03 18:37:23 +01:00
Jeff Young c51b1dad72 Generalize infobar MESSAGE_TYPE handling and use for DRC errors. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8782
 2021-08-01 21:51:39 +01:00
Jeff Young 7033dd68c0 Default WX_GRID to no cell overflows. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8892
 2021-08-01 11:57:45 +01:00
Jeff Young 6aaf4413b3 Fix kicad_string.h / string.cpp mismatch. 
They don't define a KiCad string class, so the header file name was
somewhat misleading. But the fact that they didn't match definitely
made coding more difficult.
 2021-07-29 16:03:25 +01:00
Jeff Young f221220fe2 Rename layer ids file. 
It hasn't had anything to do with colors or visibility for some time
now.
 2021-07-29 16:03:25 +01:00
Jeff Young 293f207356 Hopefully the last of the symbol id escaping issues. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8694
 2021-07-28 19:44:42 +01:00
Jeff Young 6d4c454e8c Fix some more missing escaping for symbol ids. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8694
 2021-07-28 18:37:09 +01:00
Ian McInerney 36d66085f5 Add a column showing 3D model file loading errors 
This adds an icon to the left of the row with an error symbol if the
file can't be found or opened, and shows a tooltip over the icon with
and error string.

Fixes https://gitlab.com/kicad/code/kicad/issues/3815
 2021-07-28 16:42:22 +01:00
Jeff Young 484b6bae64 Make Reset to Defaults button responsive to current page. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8864
 2021-07-27 17:56:45 +01:00
Wayne Stambaugh 37b200cb3e Pass wxString objects by reference instead of on the stack. 2021-07-27 08:41:27 -04:00
Wayne Stambaugh 78e5e98ea0 Pass VECTOR2I objects by reference instead of on the stack. 2021-07-27 08:41:27 -04:00
Wayne Stambaugh 89b1fdabe9 Pass COLOR4D object by reference instead of on the stack. 2021-07-26 13:28:56 -04:00
Wayne Stambaugh 1a301d8eea Stop using wxDialog::EndModal() from inside dialogs. 
Calling wxDialog::EndModal() directly from inside the dialog is a
potential bug if the dialog is shown in the modeless or window modal
(quasi-modal).  Use the internal button events where possible and
check for the appropriate mode before calling the correct end dialog
function.
 2021-07-21 17:38:14 -04:00
Wayne Stambaugh bcd6bddfd4 Start expunging NULL. 
Given that KiCad is a C++ project, we should really be using nullptr
instead of NULL.
 2021-07-15 15:44:45 -04:00
Wayne Stambaugh 01515680b3 Code cleaning. 2021-07-14 15:47:32 -04:00
Jeff Young c3bf51c94b Remove unused variables. 2021-07-13 20:07:49 +01:00
Marek Roszko 759f0e9a75 Be sure to stop the timer during widget destruction 
Also fix a comment elsewhere :D

Fixes #8772
 2021-07-11 19:17:34 -04:00
jean-pierre charras fb246403d2 PROGRESS_REPORTER: avoid clipping the bottom of the dialog in some cases. 
It occurred on Windows, when the message to display is too long and was
displayed using 2 lines.
Now the dialog is resize after changing the message.
Fixes #7953
https://gitlab.com/kicad/code/kicad/issues/7953
 2021-07-11 17:52:54 +02:00
Wayne Stambaugh d6420d458e Fix wxWidgets version check. 2021-07-07 16:52:21 -04:00
Wayne Stambaugh 7ca48c42d9 Fix build error in library tree widget. 2021-07-07 15:50:04 -04:00
Jeff Young a4237c3346 Fix the search widget to process <enter>. 2021-07-07 17:54:22 +01:00
Jeff Young 1e76b7808f Don't post events if un-evaluated-value isn't any different. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8745
 2021-07-07 12:43:33 +01:00
Marek Roszko 5116fa6d12 Fix STEPPED_SLIDER glitchlyness on windows 
wxWidgets drives some of this problem, it blindly calls SetValue and invokes the win32 update position messages on all the scroll subevents and we end up fighting it as well by inserting the rounded position on each subevent rather than the final one
 2021-07-06 00:58:19 -04:00
Marek Roszko 70ce74ed4a Configure page and line size in STEPPED_SLIDER 2021-07-06 00:40:53 -04:00
Marek Roszko c356cd2aa9 Enable the tick marks to actually show on the STEPPED_SLIDER 2021-07-06 00:06:57 -04:00
Marek Roszko 96a177da3d Add more input controls to IsInputControlEditable 
O god this is going to eventual cause performance issues....but this fixes keyboard based form input in some places like pl_editor with its dropdowns
 2021-07-05 23:47:16 -04:00
Marek Roszko 1fb42c5e43 Try and cleanup the input focus/key event a little 2021-07-05 20:48:48 -04:00
Marek Roszko 12305990bb Fix focus stealing from wxDataViewCtrl 2021-07-05 13:45:06 -04:00
Marek Roszko f524d9bec2 Add search control to the focus guard 2021-07-05 11:39:05 -04:00
Marek Roszko 2d696c3606 Update SetHint to SetDescriptiveText 2021-07-05 11:32:00 -04:00
Marek Roszko d2aeddc6cb Add debouncing to the choose symbol dialog. 
More potato pc friendly in theory.
 2021-07-04 21:59:51 -04:00
Marek Roszko 3b33f94c56 Use a wxSearchCtrl instead of wxTextCtrl for the symbol chooser window 
This just makes it prettier with the search icon and cancel
 2021-07-04 21:24:03 -04:00
Jeff Young 5e30be66aa Quiet unused variable warning on Mac. 2021-07-03 23:39:34 +01:00
Jon Evans e95323a37e Revert "Remove unused variable." 
It's only unused on Mac

This reverts commit d3fb22014f.
 2021-07-03 16:48:46 -04:00
Jeff Young d3fb22014f Remove unused variable. 2021-07-03 21:16:15 +01:00
Wayne Stambaugh 3f6811f413 Minor dialog layout improvements. 2021-07-02 11:36:06 -04:00
Jeff Young 0c2ac9a711 Move GUI font code to common. 
This also allows the Mac fixes for font facenames to be more
compartmentalized.

Fixes https://gitlab.com/kicad/code/kicad/issues/8657
 2021-06-29 18:27:58 +01:00
Jeff Young a1dfc36233 More error message regularization. 2021-06-29 01:08:26 +01:00
david-beinder da833ad7dd Separate focus from hover state in BITMAP_BUTTON, trigger after mouse down+up 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8556
Adds AcceptDragInAsClick() to maintain support for use in toolbar palettes
 2021-06-13 17:00:41 +00:00
Jeff Young be980df1ca Fix uninitialized variable. 2021-06-12 11:33:18 +01:00
Jeff Young 7fdbe2f387 Fix uninitialized variable found by JP. 2021-06-11 19:38:16 +01:00
Jeff Young 44086ff2b2 Pull 3D preferences into KiCad preferences architecture. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5187
 2021-06-11 11:19:40 +01:00
Wayne Stambaugh fbc135e69f Rename SCH_COMPONENT to SCH_SYMBOL. 2021-06-10 10:34:49 -04:00
luz paz 5f1e9bc8a7 Fix typos in source code 2021-06-10 01:24:15 +00:00
luz paz f968fc8719 Fix source comment / documentation typos 2021-06-09 19:32:58 +00:00
Marek Roszko d946d6e68f Cleanup some pgm_base.h includes 2021-06-08 21:56:00 -04:00