haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
kicad/pcbnew/pcb_edit_frame.cpp

2588 lines
89 KiB
C++
Raw Normal View History

more layer widget work
2010-01-24 02:05:07 +00:00
/*
Application name capitalization fixes. * Correct all user strings and comments for the correct capitalization of application names according to JP. They are KiCad, Pcbnew, CvPcb, Eeschema, and GerbView. * Add a note the the user interface policy about the correct capitalization.
2011-09-30 18:15:37 +00:00
* This program source code file is part of KiCad, a free EDA CAD application.
more layer widget work
2010-01-24 02:05:07 +00:00
*
Plot dialog: fix broken dialog management. Previously, the dialog was created only once, with the current board setup and the current units selection. Therefore, after changes in board or units, the dialog was really broken. Now, the dialog is recreated when the plot command is run.
2018-05-25 16:33:00 +00:00
* Copyright (C) 2018 Jean-Pierre Charras, jp.charras at wanadoo.fr
Pcbnew: Autoplace functions: renamed spread footprint functions. Rewritten. Now footprints, after loaded by reading a netlist are grouped by sheets by the footprints spread function, and the grouping is better. Rename 2 files. Fix minor issues. Clean code
2013-11-27 13:20:42 +00:00
* Copyright (C) 2013 SoftPLC Corporation, Dick Hollenbeck <dick@softplc.com>
Pcbnew: fix update schematic from PCB file name bug. Use ctor wxFileName( path, name, extension) to create full schematic file name in update PCB from schematic code path. This prevents file names with dots '.' from being interpreted as the extension when using the wxFileName assignment operator.
2017-09-26 14:13:21 +00:00
* Copyright (C) 2013 Wayne Stambaugh <stambaughw@gmail.com>
Fix compatibility with older wxWidgets versions. Fix also a compil warning
2023-02-03 07:22:34 +00:00
* Copyright (C) 2013-2023 KiCad Developers, see AUTHORS.txt for contributors.
more layer widget work
2010-01-24 02:05:07 +00:00
*
Implement primitive icon scaling for high DPI This is meant as a stopgap for 5.0, with plans to add proper scaled icons in the 6.0 cycle. A function KiScaledBitmap() is added, which works like KiBitmap() except it scales the bitmap according to the calling window's font size. Controls have been added to all the main applications to let the user select scaling manually (these were omitted from smaller apps that didn't already have a place to put them). In addition, in eeschema only, the pixel height of the system font is shown in the options dialog for diagnostics. This is only for collecting feedback before 5.0 release from users with different displays and will be removed.
2018-01-08 04:05:03 +00:00
* This program is free software: you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by the
Fix inadvertent change to license text
2020-08-09 20:09:26 +00:00
* Free Software Foundation, either version 3 of the License, or (at your
Implement primitive icon scaling for high DPI This is meant as a stopgap for 5.0, with plans to add proper scaled icons in the 6.0 cycle. A function KiScaledBitmap() is added, which works like KiBitmap() except it scales the bitmap according to the calling window's font size. Controls have been added to all the main applications to let the user select scaling manually (these were omitted from smaller apps that didn't already have a place to put them). In addition, in eeschema only, the pixel height of the system font is shown in the options dialog for diagnostics. This is only for collecting feedback before 5.0 release from users with different displays and will be removed.
2018-01-08 04:05:03 +00:00
* option) any later version.
more layer widget work
2010-01-24 02:05:07 +00:00
*
Implement primitive icon scaling for high DPI This is meant as a stopgap for 5.0, with plans to add proper scaled icons in the 6.0 cycle. A function KiScaledBitmap() is added, which works like KiBitmap() except it scales the bitmap according to the calling window's font size. Controls have been added to all the main applications to let the user select scaling manually (these were omitted from smaller apps that didn't already have a place to put them). In addition, in eeschema only, the pixel height of the system font is shown in the options dialog for diagnostics. This is only for collecting feedback before 5.0 release from users with different displays and will be removed.
2018-01-08 04:05:03 +00:00
* This program is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
more layer widget work
2010-01-24 02:05:07 +00:00
*
Implement primitive icon scaling for high DPI This is meant as a stopgap for 5.0, with plans to add proper scaled icons in the 6.0 cycle. A function KiScaledBitmap() is added, which works like KiBitmap() except it scales the bitmap according to the calling window's font size. Controls have been added to all the main applications to let the user select scaling manually (these were omitted from smaller apps that didn't already have a place to put them). In addition, in eeschema only, the pixel height of the system font is shown in the options dialog for diagnostics. This is only for collecting feedback before 5.0 release from users with different displays and will be removed.
2018-01-08 04:05:03 +00:00
* You should have received a copy of the GNU General Public License along
* with this program. If not, see <http://www.gnu.org/licenses/>.
more layer widget work
2010-01-24 02:05:07 +00:00
*/
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
#include <advanced_config.h>
KIFACE_I -> KIFACE_BASE.
2021-09-14 22:45:14 +00:00
#include <kiface_base.h>
Update text variables even when they're changed from other binary. For instance, you might have PCBNew open but change the variable value through EEschema > Schematic Setup. Fixes https://gitlab.com/kicad/code/kicad/issues/4918
2020-07-17 20:04:14 +00:00
#include <kiway.h>
* KIWAY Milestone A): Make major modules into DLL/DSOs. ! The initial testing of this commit should be done using a Debug build so that all the wxASSERT()s are enabled. Also, be sure and keep enabled the USE_KIWAY_DLLs option. The tree won't likely build without it. Turning it off is senseless anyways. If you want stable code, go back to a prior version, the one tagged with "stable". * Relocate all functionality out of the wxApp derivative into more finely targeted purposes: a) DLL/DSO specific b) PROJECT specific c) EXE or process specific d) configuration file specific data e) configuration file manipulations functions. All of this functionality was blended into an extremely large wxApp derivative and that was incompatible with the desire to support multiple concurrently loaded DLL/DSO's ("KIFACE")s and multiple concurrently open projects. An amazing amount of organization come from simply sorting each bit of functionality into the proper box. * Switch to wxConfigBase from wxConfig everywhere except instantiation. * Add classes KIWAY, KIFACE, KIFACE_I, SEARCH_STACK, PGM_BASE, PGM_KICAD, PGM_SINGLE_TOP, * Remove "Return" prefix on many function names. * Remove obvious comments from CMakeLists.txt files, and from else() and endif()s. * Fix building boost for use in a DSO on linux. * Remove some of the assumptions in the CMakeLists.txt files that windows had to be the host platform when building windows binaries. * Reduce the number of wxStrings being constructed at program load time via static construction. * Pass wxConfigBase* to all SaveSettings() and LoadSettings() functions so that these functions are useful even when the wxConfigBase comes from another source, as is the case in the KICAD_MANAGER_FRAME. * Move the setting of the KIPRJMOD environment variable into class PROJECT, so that it can be moved into a project variable soon, and out of FP_LIB_TABLE. * Add the KIWAY_PLAYER which is associated with a particular PROJECT, and all its child wxFrames and wxDialogs now have a Kiway() member function which returns a KIWAY& that that window tree branch is in support of. This is like wxWindows DNA in that child windows get this member with proper value at time of construction. * Anticipate some of the needs for milestones B) and C) and make code adjustments now in an effort to reduce work in those milestones. * No testing has been done for python scripting, since milestone C) has that being largely reworked and re-thought-out.
2014-03-20 00:42:08 +00:00
#include <pgm_base.h>
fix code after renaming files
2018-01-29 20:58:58 +00:00
#include <pcb_edit_frame.h>
Naming conventions.
2021-08-05 12:03:59 +00:00
#include <3d_viewer/eda_3d_viewer_frame.h>
Pcbnew footprint library table work in progress. * Add code for loading, modifying, and saving the global and project footprint library tables. * Add code to load MODULE objects using the footprint library table to the footprint viewer. * Add static methods to FP_LIB_TABLE to support loading footprint library tables.
2013-05-20 14:49:20 +00:00
#include <fp_lib_table.h>
Move bitmaps.h out of base_struct.h bitmaps.h was included in nearly every file in the project due to it being included by base_struct.h Only about 130 files actually use the XPM definitions defined there, and many of those already included bitmaps.h themselves, or via menu_helpers.h. However, touching bitmaps.h would result in over 400 rebuilt files for pcbnew alone. This commit moves the bitmap-related types like BITMAT_DEF out to a new header, which is still included by base_struct.h, which is less avoidable for now, it's it's used in the interface. The icon list is still in bitmaps.h. This has the side effect that's it's now easier to automatically generate this file. Many classes in pcbnew and eeschema needed some functions moved to the implementaitons from the headers too.
2017-02-20 12:20:39 +00:00
#include <bitmaps.h>
dialog_board_statistics.h shouldn't leak confirm.h
2021-06-06 23:34:21 +00:00
#include <confirm.h>
Organize trace debugging code for ease of maintenance.
2018-04-13 13:58:25 +00:00
#include <trace_helpers.h>
switch to <> for includes from "" per conversation with Jean-Pierre and Wayne, adjust search paths
2012-01-23 04:33:36 +00:00
#include <pcbnew_id.h>
Implement a new settings framework across all of KiCad CHANGED: Settings are now stored in versioned sub-directories ADDED: First-run dialog for migrating settings from a previous version CHANGED: Settings are now stored as JSON files instead of wxConfig-style INI files CHANGED: Color settings are now all stored in a separate settings file CHANGED: The symbol editor and footprint editor now have their own settings files CHANGED: Color settings are no longer exposed through BOARD object CHANGED: Page layout editor now uses Eeschema's color scheme Settings are now managed through a central SETTINGS_MANAGER held by PGM_BASE. Existing settings will be migrated from the wxConfig format on first run of each application. Per-application settings are now stored in one class for each application.
2020-01-13 01:44:19 +00:00
#include <pcbnew_settings.h>
Reset active layer if it gets deleted in board setup. Fixes https://gitlab.com/kicad/code/kicad/issues/5118
2020-08-13 19:35:04 +00:00
#include <pcb_layer_box_selector.h>
fix code after renaming files
2018-01-29 20:58:58 +00:00
#include <footprint_edit_frame.h>
Decouple PLOT_CONTROLLER from UI dependencies.
2013-05-10 19:22:29 +00:00
#include <dialog_plot.h>
Pcbnew: implement Find Next Moves all of the find dialog control out of the selection tool similar to the schematic editor. Dialog is also non-modal now to match the schematic editor. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8966
2021-08-27 17:15:51 +00:00
#include <dialog_find.h>
Naming updates.
2020-10-14 23:37:26 +00:00
#include <dialog_footprint_properties.h>
Move DRC control to a tool; move assorted commands to ACTIONS.
2019-06-03 13:49:17 +00:00
#include <dialogs/dialog_exchange_footprints.h>
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
#include <dialogs/dialog_net_inspector.h>
Consolidate design rules UI. Implement new Board Setup paged dialog which includes: Layers Setup Design Rules Solder Mask & Paste Text & Drawings Moves line width and text properties to a layer-class-based system. Renames unlocked to upright (which also reverses the logic). New Edit Text and Graphic Properties dialog which replaces Edit Footprint Text and adds layer-class-based editing and the italic, upright and visibility properties. Adds Import Settings functionality which allows settings to be imported from another project at page granularity. Also UNIT_BINDERizes the dialog and adds editing of pcb text. Fixes: lp:1731952 * https://bugs.launchpad.net/kicad/+bug/1731952 Fixes: lp:1743464 * https://bugs.launchpad.net/kicad/+bug/1743464 Fixes: lp:1664761 * https://bugs.launchpad.net/kicad/+bug/1664761 Fixes: lp:1753362 * https://bugs.launchpad.net/kicad/+bug/1753362 Fixes: lp:1545427 * https://bugs.launchpad.net/kicad/+bug/1545427 Fixes: lp:1753775 * https://bugs.launchpad.net/kicad/+bug/1753775 Fixes: lp:1777692 * https://bugs.launchpad.net/kicad/+bug/1777692 Fixes: lp:1780670 * https://bugs.launchpad.net/kicad/+bug/1780670 Fixes: lp:1519601 * https://bugs.launchpad.net/kicad/+bug/1519601 (cherry picked from commit 3944a5e)
2018-04-28 15:22:25 +00:00
#include <dialog_board_setup.h>
1) Add 32 Cu Layers. 2) Change from legacy Cu stack to counting down from top=(F_Cu or 0). The old Cu stack required knowing the count of Cu layers to make sense of the layer number when converting to many exported file types. The new Cu stack is more commonly used, although ours still gives B_Cu a fixed number. 3) Introduce class LSET and enum LAYER_ID. 4) Change *.kicad_pcb file format version to 4 from 3. 5) Change fixed names Inner1_Cu-Inner14_Cu to In1_Cu-In30_Cu and their meanings are typically flipped. 6) Moved the #define LAYER_N_* stuff into legacy_plugin.cpp where they can die a quiet death, and switch to enum LAYER_ID symbols throughout. 7) Removed the LEGACY_PLUGIN::Save() and FootprintSave() functions. You will need to convert to the format immediately, *.kicad_pcb and *.kicad_mod (=pretty) since legacy format was never going to know about 32 Cu layers and additional technical layers and the reversed Cu stack.
2014-06-24 16:17:18 +00:00
#include <invoke_pcb_dialog.h>
Fail GAL on its header leaking audit Maybe we should rethink directly accessing GAL so much, but at least 600 files didn't need GAL leaked into them due to view_overlay.h
2023-09-18 23:52:27 +00:00
#include <gal/graphics_abstraction_layer.h>
Remove some "class_" prefixes from files.
2020-11-12 20:19:22 +00:00
#include <board.h>
Clean up including of board_design_settings.h
2021-06-06 19:03:10 +00:00
#include <board_design_settings.h>
Remove some "class_" prefixes from files.
2020-11-12 20:19:22 +00:00
#include <footprint.h>
Round 2 of Worksheet -> Drawing Sheet.
2021-02-22 23:47:17 +00:00
#include <drawing_sheet/ds_proxy_view_item.h>
pcbnew: Separating connectivity to subdir
2018-10-12 06:17:15 +00:00
#include <connectivity/connectivity_data.h>
Unified preferences dialog framework. (cherry picked from commit 8ee3e77)
2018-05-14 17:34:18 +00:00
#include <wildcards_and_files_ext.h>
#include <pcb_draw_panel_gal.h>
#include <functional>
CHANGED: Net highlight in PcbNew is now persistent to match Eeschema CHANGED: Highlight net tool changed to highlight display toggle; moved to left toolbar CHANGED: Multi-net highlight is now accessible when using the highlight net action ADDED: Highlight Net and Clear Highlight actions to Net Tools context menu ADDED: Default hotkey (Ctrl+`) for toggling net highlighting The current and previous net highlight state are now stored and can be toggled on or off with an action (no hotkey by default). Highlight is now treated as a persistent state rather than a tool that is entered, meaning there is no longer a special tool to enter in order to highlight nets. Highlighting can be controlled while any other tool is active using the hotkeys or context menu on a net object. Tweak the icons for highlight net and layer display mode to better disambiguate them. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8250
2021-05-29 15:53:55 +00:00
#include <pcb_painter.h>
Migrate PcbNew project settings to new framework Various architecture upgrades to support this. Creating a BOARD now requires a valid PROJECT, which caused some (mostly transparent) changes to the Python API internals. ADDED: Project local settings file CHANGED: Board design settings are no longer stored in PCB file CHANGED: Net classes are no longer stored in PCB file CHANGED: Importing board settings now reads boards, not just projects Fixes https://gitlab.com/kicad/code/kicad/-/issues/2578 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4070
2020-05-31 21:42:04 +00:00
#include <project/project_file.h>
Make sure appearance panel builds after project has been loaded OnBoardChanged must run after LoadProjectSettings. Move the local overrides to PCB_EDIT_FRAME::onBoardLoaded so that they are run after the panel is initialized.
2020-08-24 23:38:34 +00:00
#include <project/project_local_settings.h>
Working python window
2021-03-08 14:54:22 +00:00
#include <python_scripting.h>
Ensure the environment variables are synchronized between KiCad and Python Before this, the environment variables inside Python wouldn't reflect the updates to them made after the interpreter was started in Pcbnew. This will call into Python and set the variables when they are changed, since Python can't synchronize itself when running in an embedded interpreter. Fixes https://gitlab.com/kicad/code/kicad/issues/5071
2020-08-09 18:49:26 +00:00
#include <settings/common_settings.h>
Implement a new settings framework across all of KiCad CHANGED: Settings are now stored in versioned sub-directories ADDED: First-run dialog for migrating settings from a previous version CHANGED: Settings are now stored as JSON files instead of wxConfig-style INI files CHANGED: Color settings are now all stored in a separate settings file CHANGED: The symbol editor and footprint editor now have their own settings files CHANGED: Color settings are no longer exposed through BOARD object CHANGED: Page layout editor now uses Eeschema's color scheme Settings are now managed through a central SETTINGS_MANAGER held by PGM_BASE. Existing settings will be migrated from the wxConfig format on first run of each application. Per-application settings are now stored in one class for each application.
2020-01-13 01:44:19 +00:00
#include <settings/settings_manager.h>
pcbnew: hooked Tool Framework into the edit panel. Added a sample selection tool (not fully functional).
2013-08-02 14:53:50 +00:00
#include <tool/tool_manager.h>
#include <tool/tool_dispatcher.h>
Move hotkeys to ACTION architecture.
2019-06-09 21:57:23 +00:00
#include <tool/action_toolbar.h>
#include <tool/common_control.h>
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
#include <tool/common_tools.h>
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
#include <tool/properties_tool.h>
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
#include <tool/selection.h>
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
#include <tool/zoom_tool.h>
Make distinction between PCBNew-wide tools and Board-specific tools. The old names were really hard to keep straight (even for me, who named many of them).
2020-12-16 13:31:32 +00:00
#include <tools/pcb_selection_tool.h>
#include <tools/pcb_picker_tool.h>
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
#include <tools/pcb_point_editor.h>
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
#include <tools/edit_tool.h>
ADDED Properties Dialog for groups. ADDED memberOf() function for DRC rule expressions. Also fixes a bug in several of the pickers where the event wasn't being correctly passed. Fixes https://gitlab.com/kicad/code/kicad/issues/5647
2020-09-24 01:05:46 +00:00
#include <tools/group_tool.h>
Introduce GENERATOR_TOOL.
2023-10-07 01:19:25 +00:00
#include <tools/generator_tool.h>
Move DRC dialog to new DRC engine.
2020-09-14 17:54:14 +00:00
#include <tools/drc_tool.h>
Move global commands to ACTIONs. Also fixes a crash bug opening Edit Tracks and Vias dialog.
2019-06-03 20:06:58 +00:00
#include <tools/global_edit_tool.h>
ADDED: Tool for converting shape types in PcbNew Fixes https://gitlab.com/kicad/code/kicad/-/issues/2406 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2507
2018-11-13 13:30:56 +00:00
#include <tools/convert_tool.h>
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
#include <tools/drawing_tool.h>
Make distinction between PCBNew-wide tools and Board-specific tools. The old names were really hard to keep straight (even for me, who named many of them).
2020-12-16 13:31:32 +00:00
#include <tools/pcb_control.h>
#include <tools/board_editor_control.h>
#include <tools/board_inspection_tool.h>
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
#include <tools/pcb_editor_conditions.h>
Consolidate common viewer actions across cvpcb and pcbnew frames * Consolidate the measure tool into one tool (this gives cvpcb unit changing and snapping capabilities in its measure tool) * Transition cvpcb to use actions for the sketch modes * Replumb how magnetic items settings are stored and used
2020-05-22 18:27:05 +00:00
#include <tools/pcb_viewer_tools.h>
Make distinction between PCBNew-wide tools and Board-specific tools. The old names were really hard to keep straight (even for me, who named many of them).
2020-12-16 13:31:32 +00:00
#include <tools/board_reannotate_tool.h>
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
#include <tools/placement_tool.h>
#include <tools/pad_tool.h>
Refactor microwave parts into the microwave tool
2020-04-01 17:24:31 +00:00
#include <microwave/microwave_tool.h>
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
#include <tools/position_relative_tool.h>
#include <tools/zone_filler_tool.h>
#include <tools/pcb_actions.h>
#include <router/router_tool.h>
Fix signed/unsigned comparison that was destined to fail.
2020-08-31 11:53:15 +00:00
#include <autorouter/autoplace_tool.h>
Move pcbnew swig Separates the python scripts into those using swig and those needed for other scripting
2021-03-19 23:38:11 +00:00
#include <python/scripting/pcb_scripting_tool.h>
Add Open-Schematic tool to PcbNew. Fixes: lp:1780610 * https://bugs.launchpad.net/kicad/+bug/1780610
2018-07-22 21:33:01 +00:00
#include <gestfich.h>
#include <executable_names.h>
Pcbnew: housekeeping: move netlist code to netlist_reader sub directory.
2019-11-17 12:58:38 +00:00
#include <netlist_reader/netlist_reader.h>
Remove the universal sockets include
2021-06-03 21:57:41 +00:00
#include <wx/socket.h>
Pcbnew, layer manager: fix flicker when loading a file, and incorrect size on start when no file is loaded Fixes: lp:1840591 https://bugs.launchpad.net/kicad/+bug/1840591
2019-08-19 08:42:22 +00:00
#include <wx/wupdlock.h>
Pcbnew: avoid crash when closing pcbnew if the DRC dialog is open. Cvpcb: change from commit 9ceca583: the root class close event that save settings is now seeing the close event.
2019-09-19 07:11:45 +00:00
#include <dialog_drc.h> // for DIALOG_DRC_WINDOW_NAME definition
Round 2 of Worksheet -> Drawing Sheet.
2021-02-22 23:47:17 +00:00
#include <ratsnest/ratsnest_view_item.h>
ADDED: New appearance control widget for PcbNew Featuring: - Layer view presets - Per-type opacity for tracks, vias, pads, zones - Net and netclass color and visibility controls CHANGED: Simplified object visibilty controls Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951 Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
2020-07-11 17:42:00 +00:00
#include <widgets/appearance_controls.h>
ADDED: Search/inspect pane
2022-09-14 02:59:57 +00:00
#include <widgets/pcb_search_pane.h>
Class name <-> file name sync.
2022-12-28 22:03:03 +00:00
#include <widgets/wx_infobar.h>
ADDED: Persistent selection filter UI for PcbNew
2020-06-27 22:48:34 +00:00
#include <widgets/panel_selection_filter.h>
Move properties panel to widgets with the other AUI panels
2022-11-27 23:23:07 +00:00
#include <widgets/pcb_properties_panel.h>
Fix save/load of appearance panel width on show/hide Fixes https://gitlab.com/kicad/code/kicad/-/issues/8982
2021-08-20 01:15:14 +00:00
#include <widgets/wx_aui_utils.h>
Move shutdown blocker to kiplatform
2020-09-01 10:14:51 +00:00
#include <kiplatform/app.h>
Profile can live in core
2023-09-07 11:22:10 +00:00
#include <core/profile.h>
Optimize redrawNetnames. Using RTree is slower in this case. RTree: 25 ms when moving cursor This method: 5 ms when panning/zooming (cherry picked from commit 62fb5697b4a54bd8cdb09420ca564eebd85e37a1)
2024-06-19 17:55:33 +00:00
#include <math/box2_minmax.h>
Add profile counters for PCB mouse and paint events
2021-12-05 20:15:18 +00:00
#include <view/wx_view_controls.h>
Don't leave stranded symbols/footprints in editors when doc closes. Fixes https://gitlab.com/kicad/code/kicad/issues/10026
2021-12-22 14:27:38 +00:00
#include <footprint_viewer_frame.h>
Push most of DIALOG_CHOOSE_SYMBOL down into PANEL_SYMBOL_CHOOSER. Includes a dialog wrapper (DIALOG_SYMBOL_CHOOSER) and a frame wrapper (SYMBOL_CHOOSER_FRAME).
2023-09-28 13:09:45 +00:00
#include <footprint_chooser_frame.h>
pcbnew: Move ratsnest items to separate folder
2020-06-16 18:15:14 +00:00
Fix some issues with reloading of action plugins First issue: the C++ action plugins list should be cleared so that any plugins that fail to reload do not hang around on the toolbar. This is fixed on the C++ side. Second issue: inner dependencies of plugins that are modules were not reloaded before, which broke reloading for many plugin examples out there. This is fixed on the Python side by keeping track of dependencies and clearing them out before reloading a module (unfortunately there doesn't seem to be a way to do this in the standard library) Fixes https://gitlab.com/kicad/code/kicad/-/issues/7245
2021-02-20 16:19:24 +00:00
#include <action_plugin.h>
Prevent crash when a python script tries to use pcbnew too early. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15414
2023-08-24 21:09:53 +00:00
#include <pcbnew_scripting_helpers.h>
Working python window
2021-03-08 14:54:22 +00:00
#include "../scripting/python_scripting.h"
more layer widget work
2010-01-24 02:05:07 +00:00
Remove a useless "#include wx/wx.h" from wx_html_report_panel.h
2021-06-07 07:26:13 +00:00
#include <wx/filedlg.h>
Replace boost::function and boost::bind with their std:: counterparts
2016-06-29 10:23:11 +00:00
using namespace std::placeholders;
Introduced Cairo-based rendering backend using GAL. Moved switching canvas routines to pcbnew, as they are used only there right now (otherwise libgal would have to be linked to every Kicad application).
2013-04-15 15:57:03 +00:00
Minor fixes and lots of coding policy changes.
2010-12-08 20:12:46 +00:00
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
#define INSPECT_DRC_ERROR_DIALOG_NAME wxT( "InspectDrcErrorDialog" )
#define INSPECT_CLEARANCE_DIALOG_NAME wxT( "InspectClearanceDialog" )
#define INSPECT_CONSTRAINTS_DIALOG_NAME wxT( "InspectConstraintsDialog" )
#define FOOTPRINT_DIFF_DIALOG_NAME wxT( "FootprintDiffDialog" )
PCBNew control update bug fixes, fixes lp:725963. * Fix grid select box update bug on context menu. * Fix via size and track width select box update bugs. * Fix layer pair indicator button update bug. * Fix auto track width tool bar control enable bug. * Fix via size and track width select status bug in context menu. * Fix layer select box and layer control widget select bug when current layer is removed. * Add virtual function to notify objects derived from EDA_DRAW_FRAME that the units setting has changed. * Coding policy class naming fixes.
2011-03-01 19:26:17 +00:00
BEGIN_EVENT_TABLE( PCB_EDIT_FRAME, PCB_BASE_FRAME )
EVT_SOCKET( ID_EDA_SOCKET_EVENT_SERV, PCB_EDIT_FRAME::OnSockRequestServer )
EVT_SOCKET( ID_EDA_SOCKET_EVENT, PCB_EDIT_FRAME::OnSockRequest )
Enable 3D mouse support in Footprint viewer. The 3D mouse support is moved from PCB_EDIT_FRAME to PCB_BASE_FRAME. This allows all PCB_BASE_FRAME derived windows to have 3D mouse enabled 2D navigation support.
2021-10-25 12:18:48 +00:00
More comment translation and capitalization fixes.
2009-11-18 12:52:19 +00:00
Rollback wxChoice -> wxComboBox changes for now. wxComboBox still has serious issues on macOS. Fixes https://gitlab.com/kicad/code/kicad/issues/14399 Fixes https://gitlab.com/kicad/code/kicad/issues/14413
2023-04-09 21:59:01 +00:00
EVT_CHOICE( ID_ON_ZOOM_SELECT, PCB_EDIT_FRAME::OnSelectZoom )
EVT_CHOICE( ID_ON_GRID_SELECT, PCB_EDIT_FRAME::OnSelectGrid )
More comment translation and capitalization fixes.
2009-11-18 12:52:19 +00:00
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
EVT_SIZE( PCB_EDIT_FRAME::OnSize )
More comment translation and capitalization fixes.
2009-11-18 12:52:19 +00:00
Pcbnew: Rework on recovery files menu
2012-12-21 07:58:51 +00:00
EVT_TOOL( ID_MENU_RECOVER_BOARD_AUTOSAVE, PCB_EDIT_FRAME::Files_io )
More comment translation and capitalization fixes.
2009-11-18 12:52:19 +00:00
// Menu Files:
PCBNew control update bug fixes, fixes lp:725963. * Fix grid select box update bug on context menu. * Fix via size and track width select box update bugs. * Fix layer pair indicator button update bug. * Fix auto track width tool bar control enable bug. * Fix via size and track width select status bug in context menu. * Fix layer select box and layer control widget select bug when current layer is removed. * Add virtual function to notify objects derived from EDA_DRAW_FRAME that the units setting has changed. * Coding policy class naming fixes.
2011-03-01 19:26:17 +00:00
EVT_MENU( ID_MAIN_MENUBAR, PCB_EDIT_FRAME::Process_Special_Functions )
More comment translation and capitalization fixes.
2009-11-18 12:52:19 +00:00
Pcbnew, File menu: break Open (board) into 2 menu items: Open (only for Kicad board files) and Import (only for non Kicad board files)
2016-03-04 18:48:08 +00:00
EVT_MENU( ID_IMPORT_NON_KICAD_BOARD, PCB_EDIT_FRAME::Files_io )
Allow updating of file history size on the fly. Also updates the file menu IDs so that we can actually handle more than 9 items in the file history. Also adds configurable file history length to the other gerber files (zip, drill and job). Fixes: lp:1745729 * https://bugs.launchpad.net/kicad/+bug/1745729
2018-08-20 13:46:38 +00:00
EVT_MENU_RANGE( ID_FILE1, ID_FILEMAX, PCB_EDIT_FRAME::OnFileHistory )
Rework the file history menus to not need references to the file history Keeping a pointer to the actual file history inside a special file history menu led to many cases of use after free crashes, so instead rework the actual file history to add the menu items. Fixes https://gitlab.com/kicad/code/kicad/issues/3741
2020-02-25 15:46:56 +00:00
EVT_MENU( ID_FILE_LIST_CLEAR, PCB_EDIT_FRAME::OnClearFileHistory )
More comment translation and capitalization fixes.
2009-11-18 12:52:19 +00:00
PCBNew control update bug fixes, fixes lp:725963. * Fix grid select box update bug on context menu. * Fix via size and track width select box update bugs. * Fix layer pair indicator button update bug. * Fix auto track width tool bar control enable bug. * Fix via size and track width select status bug in context menu. * Fix layer select box and layer control widget select bug when current layer is removed. * Add virtual function to notify objects derived from EDA_DRAW_FRAME that the units setting has changed. * Coding policy class naming fixes.
2011-03-01 19:26:17 +00:00
EVT_MENU( ID_GEN_EXPORT_FILE_GENCADFORMAT, PCB_EDIT_FRAME::ExportToGenCAD )
EVT_MENU( ID_GEN_EXPORT_FILE_VRML, PCB_EDIT_FRAME::OnExportVRML )
3D Viewer: complete refactor of the 3D viewer. * Split and rewrite the preview window and canvas. * Create a new class for handling the board information. * Adds new render targets: openGL, legacy, and ray tracing. * Render targets take full advantage of the new 3D plugins system and 3D cache for a fast 3D model loading. * Faster board loading. * New OpenGL render is faster than the old one. * New ray tracing render target with a post processing shader. * Use of new 3D plugins (WRL, X3D, STEP and IGES) and 3D model caching. * Preview of 3D model while browsing the file name. * 3D preview of the footprint while adding / align 3D shapes. * Render of 3D models according to attributes: Normal, Normal+Insert, Virtual. * Pivot rotation centered in one point over the PCB board. * Shortcuts keys improved for XYZ orientation.. * Animated camera.
2016-07-19 17:35:25 +00:00
EVT_MENU( ID_GEN_EXPORT_FILE_IDF3, PCB_EDIT_FRAME::OnExportIDF3 )
Added STEP Export menu item and supporting code
2016-09-19 07:40:36 +00:00
EVT_MENU( ID_GEN_EXPORT_FILE_STEP, PCB_EDIT_FRAME::OnExportSTEP )
pcbnew: Hyperlynx Exporter - initial version
2019-04-08 00:09:07 +00:00
EVT_MENU( ID_GEN_EXPORT_FILE_HYPERLYNX, PCB_EDIT_FRAME::OnExportHyperlynx )
More comment translation and capitalization fixes.
2009-11-18 12:52:19 +00:00
Harvest -> Export
2020-11-09 16:45:36 +00:00
EVT_MENU( ID_MENU_EXPORT_FOOTPRINTS_TO_LIBRARY, PCB_EDIT_FRAME::Process_Special_Functions )
EVT_MENU( ID_MENU_EXPORT_FOOTPRINTS_TO_NEW_LIBRARY, PCB_EDIT_FRAME::Process_Special_Functions )
More comment translation and capitalization fixes.
2009-11-18 12:52:19 +00:00
Move quit back to wxIDs. wxWidgets like to muck around with the location on OSX.
2019-05-26 22:22:03 +00:00
EVT_MENU( wxID_EXIT, PCB_EDIT_FRAME::OnQuit )
Update exit strategy to match UI guidelines In singletop mode, all frames show the "Quit" option in the file menu and will quit on Ctrl-Q. When launched from the main KiCad interface, sub-programs show the "Close" option instead and will close with Ctrl-W. In this mode, Ctrl-Q will instruct the main program to exit. Fixes: lp:1779938 * https://bugs.launchpad.net/kicad/+bug/1779938
2019-06-25 04:44:34 +00:00
EVT_MENU( wxID_CLOSE, PCB_EDIT_FRAME::OnQuit )
Move quit back to wxIDs. wxWidgets like to muck around with the location on OSX.
2019-05-26 22:22:03 +00:00
More comment translation and capitalization fixes.
2009-11-18 12:52:19 +00:00
// menu Postprocess
PCBNew control update bug fixes, fixes lp:725963. * Fix grid select box update bug on context menu. * Fix via size and track width select box update bugs. * Fix layer pair indicator button update bug. * Fix auto track width tool bar control enable bug. * Fix via size and track width select status bug in context menu. * Fix layer select box and layer control widget select bug when current layer is removed. * Add virtual function to notify objects derived from EDA_DRAW_FRAME that the units setting has changed. * Coding policy class naming fixes.
2011-03-01 19:26:17 +00:00
EVT_MENU( ID_PCB_GEN_CMP_FILE, PCB_EDIT_FRAME::RecreateCmpFileFromBoard )
More comment translation and capitalization fixes.
2009-11-18 12:52:19 +00:00
// Horizontal toolbar
UNIT_BINDERize print and plot dialogs. Fixes: lp:1778560 * https://bugs.launchpad.net/kicad/+bug/1778560 Fixes: lp:1392991 * https://bugs.launchpad.net/kicad/+bug/1392991 Fixes: lp:1780362 * https://bugs.launchpad.net/kicad/+bug/1780362 (cherry picked from commit 9df9743)
2018-06-13 12:20:29 +00:00
EVT_TOOL( ID_GEN_PLOT_SVG, PCB_EDIT_FRAME::ExportSVG )
PCBNew control update bug fixes, fixes lp:725963. * Fix grid select box update bug on context menu. * Fix via size and track width select box update bugs. * Fix layer pair indicator button update bug. * Fix auto track width tool bar control enable bug. * Fix via size and track width select status bug in context menu. * Fix layer select box and layer control widget select bug when current layer is removed. * Add virtual function to notify objects derived from EDA_DRAW_FRAME that the units setting has changed. * Coding policy class naming fixes.
2011-03-01 19:26:17 +00:00
EVT_TOOL( ID_AUX_TOOLBAR_PCB_SELECT_AUTO_WIDTH, PCB_EDIT_FRAME::Tracks_and_Vias_Size_Event )
Replace WinEDAChoiceBox with wxComboBox.
2011-04-19 19:19:41 +00:00
EVT_COMBOBOX( ID_TOOLBARH_PCB_SELECT_LAYER, PCB_EDIT_FRAME::Process_Special_Functions )
Rollback wxChoice -> wxComboBox changes for now. wxComboBox still has serious issues on macOS. Fixes https://gitlab.com/kicad/code/kicad/issues/14399 Fixes https://gitlab.com/kicad/code/kicad/issues/14413
2023-04-09 21:59:01 +00:00
EVT_CHOICE( ID_AUX_TOOLBAR_PCB_TRACK_WIDTH, PCB_EDIT_FRAME::Tracks_and_Vias_Size_Event )
EVT_CHOICE( ID_AUX_TOOLBAR_PCB_VIA_SIZE, PCB_EDIT_FRAME::Tracks_and_Vias_Size_Event )
Pcbnew, python console: refinements.
2014-10-31 14:45:46 +00:00
More comment translation and capitalization fixes.
2009-11-18 12:52:19 +00:00
// Tracks and vias sizes general options
Sync GAL grid with layer visibility on doc-open. Fixes: lp:1843169 * https://bugs.launchpad.net/kicad/+bug/1843169
2019-09-08 22:08:15 +00:00
EVT_MENU_RANGE( ID_POPUP_PCB_SELECT_WIDTH_START_RANGE, ID_POPUP_PCB_SELECT_WIDTH_END_RANGE,
PCBNew control update bug fixes, fixes lp:725963. * Fix grid select box update bug on context menu. * Fix via size and track width select box update bugs. * Fix layer pair indicator button update bug. * Fix auto track width tool bar control enable bug. * Fix via size and track width select status bug in context menu. * Fix layer select box and layer control widget select bug when current layer is removed. * Add virtual function to notify objects derived from EDA_DRAW_FRAME that the units setting has changed. * Coding policy class naming fixes.
2011-03-01 19:26:17 +00:00
PCB_EDIT_FRAME::Tracks_and_Vias_Size_Event )
More comment translation and capitalization fixes.
2009-11-18 12:52:19 +00:00
All control state handling is now performed in wxUpdateUIEvent handlers. * Old control state handling code completely removed in all applications. * Factor common control state handlers into EDA_DRAW_FRAME. * Replaced EDA_ITEM test for newness with IsNew() method. * Factor vertical right toolbar command handlers out of giant edit command switch statement in EESchema and PCBNew.
2011-02-21 13:54:29 +00:00
// User interface update event handlers.
PCBNew control update bug fixes, fixes lp:725963. * Fix grid select box update bug on context menu. * Fix via size and track width select box update bugs. * Fix layer pair indicator button update bug. * Fix auto track width tool bar control enable bug. * Fix via size and track width select status bug in context menu. * Fix layer select box and layer control widget select bug when current layer is removed. * Add virtual function to notify objects derived from EDA_DRAW_FRAME that the units setting has changed. * Coding policy class naming fixes.
2011-03-01 19:26:17 +00:00
EVT_UPDATE_UI( ID_TOOLBARH_PCB_SELECT_LAYER, PCB_EDIT_FRAME::OnUpdateLayerSelectBox )
EVT_UPDATE_UI( ID_AUX_TOOLBAR_PCB_TRACK_WIDTH, PCB_EDIT_FRAME::OnUpdateSelectTrackWidth )
EVT_UPDATE_UI( ID_AUX_TOOLBAR_PCB_VIA_SIZE, PCB_EDIT_FRAME::OnUpdateSelectViaSize )
Make track/via sizes UI more predictable and compatible with DRC. Two main changes: netclass values need to go through the DRC engine so they can interact with other rules. They're also now dependent on the layer being routed as well as the start object. Also make the controls adjust to each other better. For instance, copy-track-width needs to turn off when you select a particular track width, and a particular track width needs to zero out when you choose copy-track-width. Fixes https://gitlab.com/kicad/code/kicad/issues/5951
2020-10-10 18:29:41 +00:00
EVT_UPDATE_UI( ID_AUX_TOOLBAR_PCB_SELECT_AUTO_WIDTH, PCB_EDIT_FRAME::OnUpdateSelectAutoWidth )
PCBNew control update bug fixes, fixes lp:725963. * Fix grid select box update bug on context menu. * Fix via size and track width select box update bugs. * Fix layer pair indicator button update bug. * Fix auto track width tool bar control enable bug. * Fix via size and track width select status bug in context menu. * Fix layer select box and layer control widget select bug when current layer is removed. * Add virtual function to notify objects derived from EDA_DRAW_FRAME that the units setting has changed. * Coding policy class naming fixes.
2011-03-01 19:26:17 +00:00
EVT_UPDATE_UI_RANGE( ID_POPUP_PCB_SELECT_WIDTH1, ID_POPUP_PCB_SELECT_WIDTH8,
PCB_EDIT_FRAME::OnUpdateSelectTrackWidth )
EVT_UPDATE_UI_RANGE( ID_POPUP_PCB_SELECT_VIASIZE1, ID_POPUP_PCB_SELECT_VIASIZE8,
PCB_EDIT_FRAME::OnUpdateSelectViaSize )
ADDED: Implement Drag and Drop dropping files to Kicad manager : *.kicad_pro, *.pro -> open project; gerber and job files -> open in Gerbview editor; Eagle and Cadstar files -> open project. dropping file to schematic editor -> append schematic; dropping library file to Symbol editor -> add library; dropping board file to PCB editor -> append board; dropping library or footprint file to Footprint editor -> add library or import footprint; dropping ZIP file or gerber files to Gerbview editor -> open files; dropping sheet file to Drawing Sheet editor -> open sheet. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11638
2022-09-14 22:28:09 +00:00
// Drop files event
EVT_DROP_FILES( PCB_EDIT_FRAME::OnDropFiles )
made m_CurrentItem private, beautification
2007-08-20 01:20:48 +00:00
END_EVENT_TABLE()
add files not currently available in source (e.g. docs, modules, etc.) set svn:eol-style property to native for all ascii files to support cross platform development
2007-06-05 12:10:51 +00:00
* KIWAY Milestone A): Make major modules into DLL/DSOs. ! The initial testing of this commit should be done using a Debug build so that all the wxASSERT()s are enabled. Also, be sure and keep enabled the USE_KIWAY_DLLs option. The tree won't likely build without it. Turning it off is senseless anyways. If you want stable code, go back to a prior version, the one tagged with "stable". * Relocate all functionality out of the wxApp derivative into more finely targeted purposes: a) DLL/DSO specific b) PROJECT specific c) EXE or process specific d) configuration file specific data e) configuration file manipulations functions. All of this functionality was blended into an extremely large wxApp derivative and that was incompatible with the desire to support multiple concurrently loaded DLL/DSO's ("KIFACE")s and multiple concurrently open projects. An amazing amount of organization come from simply sorting each bit of functionality into the proper box. * Switch to wxConfigBase from wxConfig everywhere except instantiation. * Add classes KIWAY, KIFACE, KIFACE_I, SEARCH_STACK, PGM_BASE, PGM_KICAD, PGM_SINGLE_TOP, * Remove "Return" prefix on many function names. * Remove obvious comments from CMakeLists.txt files, and from else() and endif()s. * Fix building boost for use in a DSO on linux. * Remove some of the assumptions in the CMakeLists.txt files that windows had to be the host platform when building windows binaries. * Reduce the number of wxStrings being constructed at program load time via static construction. * Pass wxConfigBase* to all SaveSettings() and LoadSettings() functions so that these functions are useful even when the wxConfigBase comes from another source, as is the case in the KICAD_MANAGER_FRAME. * Move the setting of the KIPRJMOD environment variable into class PROJECT, so that it can be moved into a project variable soon, and out of FP_LIB_TABLE. * Add the KIWAY_PLAYER which is associated with a particular PROJECT, and all its child wxFrames and wxDialogs now have a Kiway() member function which returns a KIWAY& that that window tree branch is in support of. This is like wxWindows DNA in that child windows get this member with proper value at time of construction. * Anticipate some of the needs for milestones B) and C) and make code adjustments now in an effort to reduce work in those milestones. * No testing has been done for python scripting, since milestone C) has that being largely reworked and re-thought-out.
2014-03-20 00:42:08 +00:00
PCB_EDIT_FRAME::PCB_EDIT_FRAME( KIWAY* aKiway, wxWindow* aParent ) :
Cross-probing/selection for multiple items (SCH->PCB)
2022-01-16 20:29:03 +00:00
PCB_BASE_EDIT_FRAME( aKiway, aParent, FRAME_PCB_EDITOR, _( "PCB Editor" ),
wxDefaultPosition, wxDefaultSize, KICAD_DEFAULT_DRAWFRAME_STYLE,
PCB_EDIT_FRAME_NAME ),
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
m_exportNetlistAction( nullptr ),
m_findDialog( nullptr ),
m_inspectDrcErrorDlg( nullptr ),
m_inspectClearanceDlg( nullptr ),
m_inspectConstraintsDlg( nullptr ),
m_footprintDiffDlg( nullptr ),
ADDED: Project chooser dialog for EasyEDA Pro import.
2023-10-30 06:34:45 +00:00
m_netInspectorDlg( nullptr ),
m_importProperties( nullptr )
add files not currently available in source (e.g. docs, modules, etc.) set svn:eol-style property to native for all ascii files to support cross platform development
2007-06-05 12:10:51 +00:00
{
Maximize main editors by default if config is missing Also set default size for other windows to something slightly larger than it was before
2020-10-18 18:38:40 +00:00
m_maximizeByDefault = true;
More EDA_DRAW_FRAME encapsulation work.
2011-12-14 20:03:15 +00:00
m_showBorderAndTitleBlock = true; // true to display sheet references
More NULL expunging.
2021-07-19 23:56:05 +00:00
m_SelTrackWidthBox = nullptr;
m_SelViaSizeBox = nullptr;
m_SelLayerBox = nullptr;
pcbnew: Added option in left tool bar to show/hide Layer manager tool bar
2010-01-21 20:36:48 +00:00
m_show_layer_manager_tools = true;
Reduce duplication of settings.
2021-12-02 20:19:15 +00:00
m_supportsAutoSave = true;
Cross-probing/selection for multiple items (PCB -> SCH) Fixes https://gitlab.com/kicad/code/kicad/issues/10469
2022-07-19 15:00:35 +00:00
m_probingSchToPcb = false;
ADDED: Search/inspect pane
2022-09-14 02:59:57 +00:00
m_show_search = false;
Pcbnew footprint library table work in progress. * Add code for loading, modifying, and saving the global and project footprint library tables. * Add code to load MODULE objects using the footprint library table to the footprint viewer. * Add static methods to FP_LIB_TABLE to support loading footprint library tables.
2013-05-20 14:49:20 +00:00
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
// We don't know what state board was in when it was last saved, so we have to
Check zone fills before plotting. Also adds a "Draft Plot" button for those who wish to sidestep zone checking (which can be slow). Fixes: lp:1712579 * https://bugs.launchpad.net/kicad/+bug/1712579
2018-05-03 22:23:47 +00:00
// assume dirty
m_ZoneFillsDirty = true;
Do not translate name in version info Leave the application name in version info untranslated when viewed, copied, or used in a bug report. Fixes https://gitlab.com/kicad/code/kicad/-/issues/13298
2022-12-31 23:39:04 +00:00
m_aboutTitle = _HKI( "KiCad PCB Editor" );
Pcbnew footprint library table work in progress. * Add code for loading, modifying, and saving the global and project footprint library tables. * Add code to load MODULE objects using the footprint library table to the footprint viewer. * Add static methods to FP_LIB_TABLE to support loading footprint library tables.
2013-05-20 14:49:20 +00:00
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
// Must be created before the menus are created.
if( ADVANCED_CFG::GetCfg().m_ShowPcbnewExportNetlist )
m_exportNetlistAction = new TOOL_ACTION( "pcbnew.EditorControl.exportNetlist",
AS_GLOBAL, 0, "", _( "Netlist..." ),
_( "Export netlist used to update schematics" ) );
Created a specialization of EDA_DRAW_PANEL_GAL: PCB_DRAW_PANEL_GAL. Moved View related routines & fields from PCB_{BASE,EDIT}_FRAME & BOARD to PCB_DRAW_PANEL_GAL.
2014-07-09 08:57:32 +00:00
// Create GAL canvas
Naming conventions.
2020-11-16 11:16:44 +00:00
auto canvas = new PCB_DRAW_PANEL_GAL( this, -1, wxPoint( 0, 0 ), m_frameSize,
Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal.
2019-06-13 17:28:55 +00:00
GetGalDisplayOptions(),
Remove canvas-switching from OSX. The Cairo renderer doesn't work on Retina displays. Fixes https://gitlab.com/kicad/code/kicad/issues/4788
2020-08-31 17:47:44 +00:00
EDA_DRAW_PANEL_GAL::GAL_FALLBACK );
Bulletproof canvas switching.
2015-08-21 08:33:36 +00:00
Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal.
2019-06-13 17:28:55 +00:00
SetCanvas( canvas );
++PCBNew * Removed Pcb_Frame argument from BOARD() constructor, since it precludes having a BOARD being edited by more than one editor, it was a bad design. And this meant removing m_PcbFrame from BOARD. * removed BOARD::SetWindowFrame(), and BOARD::m_PcbFrame * Removed the global BOARD_DESIGN_SETTINGS which was in class_board.cpp * added BOARD_DESIGN_SETTINGS to the BOARD class, a full instance * a couple dialogs now only change BOARD_DESIGN_SETTINGS when OK is pressed, such as dialog_mask_clearance, dialog_drc, etc. * Removed common/pcbcommon.cpp's int g_CurrentVersionPCB = 1 and replaced it with build_version.h's #define BOARD_FILE_VERSION, although there may be a better place for this constant. * Made the public functions in PARAM_CFG_ARRAY be type const. void SaveParam(..) const and void ReadParam(..) const * PARAM_CFG_BASE now has virtual destructor since we have various way of destroying the derived class and boost::ptr_vector must be told about this. * Pass const PARAM_CFG_ARRAY& instead of PARAM_CFG_ARRAY so that we can use an automatic PARAM_CFG_ARRAY which is on the stack.\ * PCB_EDIT_FRAME::GetProjectFileParameters() may no longer cache the array, since it has to access the current BOARD and the BOARD can change. Remember BOARD_DESIGN_SETTINGS are now in the BOARD. * Made the m_BoundingBox member private, this was a brutally hard task, and indicative of the lack of commitment to accessors and object oriented design on the part of KiCad developers. We must do better. Added BOARD::GetBoundingBox, SetBoundingBox(), ComputeBoundingBox(). * Added PCB_BASE_FRAME::GetBoardBoundingBox() which calls BOARD::ComputeBoundingBox()
2011-12-05 06:15:33 +00:00
SetBoard( new BOARD() );
more layer widget incorporation
2010-01-21 20:53:01 +00:00
Add multiple size icons for programs In theory, the WM should now choose the closest size icon for its purpose, making it easier to distinguish in space-constrained settings Fixes https://gitlab.com/kicad/code/kicad/issues/6798
2020-12-22 19:41:32 +00:00
wxIcon icon;
wxIconBundle icon_bundle;
Explicitly add 48, 128, 256 to icon bundles for each app
2024-01-16 22:21:01 +00:00
icon.CopyFromBitmap( KiBitmap( BITMAPS::icon_pcbnew, 48 ) );
icon_bundle.AddIcon( icon );
icon.CopyFromBitmap( KiBitmap( BITMAPS::icon_pcbnew, 128 ) );
icon_bundle.AddIcon( icon );
icon.CopyFromBitmap( KiBitmap( BITMAPS::icon_pcbnew, 256 ) );
Add multiple size icons for programs In theory, the WM should now choose the closest size icon for its purpose, making it easier to distinguish in space-constrained settings Fixes https://gitlab.com/kicad/code/kicad/issues/6798
2020-12-22 19:41:32 +00:00
icon_bundle.AddIcon( icon );
Rework bitmap system to load from archived PNGs Bitmaps are now identified by an enum class instead of by pointers. Bitmap loading and caching is now handled by a class in common, and we no longer compile most bitmaps into the binary, so there is no longer a bitmaps static library. Instead, bitmaps are archived to a .tar.gz file which is installed in ${KICAD_DATA}/resources/images.tar.gz The source PNGs are checked in to Git as the original CPP files were, so that people can build without the required dependencies to convert SVGs to PNGs. Initial support is also added for dark theme icons, although this is not yet exposed in the GUI. Stubs are present for multi-resolution image resources, but this is not fully-baked yet and could use some refinement.
2021-03-08 02:59:07 +00:00
icon.CopyFromBitmap( KiBitmap( BITMAPS::icon_pcbnew_32 ) );
Add multiple size icons for programs In theory, the WM should now choose the closest size icon for its purpose, making it easier to distinguish in space-constrained settings Fixes https://gitlab.com/kicad/code/kicad/issues/6798
2020-12-22 19:41:32 +00:00
icon_bundle.AddIcon( icon );
Rework bitmap system to load from archived PNGs Bitmaps are now identified by an enum class instead of by pointers. Bitmap loading and caching is now handled by a class in common, and we no longer compile most bitmaps into the binary, so there is no longer a bitmaps static library. Instead, bitmaps are archived to a .tar.gz file which is installed in ${KICAD_DATA}/resources/images.tar.gz The source PNGs are checked in to Git as the original CPP files were, so that people can build without the required dependencies to convert SVGs to PNGs. Initial support is also added for dark theme icons, although this is not yet exposed in the GUI. Stubs are present for multi-resolution image resources, but this is not fully-baked yet and could use some refinement.
2021-03-08 02:59:07 +00:00
icon.CopyFromBitmap( KiBitmap( BITMAPS::icon_pcbnew_16 ) );
Add multiple size icons for programs In theory, the WM should now choose the closest size icon for its purpose, making it easier to distinguish in space-constrained settings Fixes https://gitlab.com/kicad/code/kicad/issues/6798
2020-12-22 19:41:32 +00:00
icon_bundle.AddIcon( icon );
SetIcons( icon_bundle );
made m_CurrentItem private, beautification
2007-08-20 01:20:48 +00:00
Fix saving undo/redo limits in Eeschema.
2015-08-06 00:10:52 +00:00
// LoadSettings() *after* creating m_LayersManager, because LoadSettings()
// initialize parameters in m_LayersManager
LoadSettings( config() );
Repoint IU_PER_MILS
2022-09-16 23:25:07 +00:00
SetScreen( new PCB_SCREEN( GetPageSettings().GetSizeIU( pcbIUScale.IU_PER_MILS ) ) );
moving objects into BOARD which are saved in a *.brd file, for PLUGIN access
2011-12-31 05:44:00 +00:00
// PCB drawings start in the upper left corner.
GetScreen()->m_Center = false;
Use layer_widget in Gerbview Added sample gerber files for test (gerbview has problem with 2 files)
2010-02-03 14:05:17 +00:00
Implement ACTION_TOOLBAR and update some of the menus to ACTION_MENU. This gives us better separation of MVC in line with the design of the modern toolset. It also reduces a whole bunch of duplicated data.
2019-05-14 19:21:10 +00:00
setupTools();
Add a palette to the toolbars to display groups of actions This adds a palette to toolbar items that displays groups of actions when long-pressed on a button.
2020-09-26 23:55:59 +00:00
setupUIConditions();
made m_CurrentItem private, beautification
2007-08-20 01:20:48 +00:00
ReCreateMenuBar();
ReCreateHToolbar();
ReCreateAuxiliaryToolbar();
ReCreateVToolbar();
ReCreateOptToolbar();
Marco's AUI patch, basically
2009-11-02 22:24:55 +00:00
Do not create panel if disabled
2022-08-22 02:38:38 +00:00
Properties: enable in PCB editor for everyone Leaving the AC flag around for future use in the footprint editor etc Fixes https://gitlab.com/kicad/code/kicad/-/issues/2039
2022-12-08 22:38:36 +00:00
m_propertiesPanel = new PCB_PROPERTIES_PANEL( this, this );
Nullptr safety for various panels. Also moves preference saving out to parent as different parents save different settings.
2023-09-25 11:35:31 +00:00
float proportion = GetPcbNewSettings()->m_AuiPanels.properties_splitter;
Properties: enable in PCB editor for everyone Leaving the AC flag around for future use in the footprint editor etc Fixes https://gitlab.com/kicad/code/kicad/-/issues/2039
2022-12-08 22:38:36 +00:00
m_propertiesPanel->SetSplitterProportion( proportion );
Properties: save and restore splitter position
2022-12-08 02:38:33 +00:00
ADDED: Persistent selection filter UI for PcbNew
2020-06-27 22:48:34 +00:00
m_selectionFilterPanel = new PANEL_SELECTION_FILTER( this );
ADDED: New appearance control widget for PcbNew Featuring: - Layer view presets - Per-type opacity for tracks, vias, pads, zones - Net and netclass color and visibility controls CHANGED: Simplified object visibilty controls Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951 Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
2020-07-11 17:42:00 +00:00
m_appearancePanel = new APPEARANCE_CONTROLS( this, GetCanvas() );
ADDED: Search/inspect pane
2022-09-14 02:59:57 +00:00
m_searchPane = new PCB_SEARCH_PANE( this );
ADDED: New appearance control widget for PcbNew Featuring: - Layer view presets - Per-type opacity for tracks, vias, pads, zones - Net and netclass color and visibility controls CHANGED: Simplified object visibilty controls Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951 Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
2020-07-11 17:42:00 +00:00
More comment translation and capitalization fixes.
2009-11-18 12:52:19 +00:00
m_auimgr.SetManagedWindow( this );
Turn off live resize in pcbnew on Windows The performance of live resizing isn't great. Windows can send mouse moves at 1000 Hz which is faster than the complex appearance panel + canvas can paint properly.
2020-11-14 03:15:32 +00:00
Allow both aui-manager-based infobars and window overlay infobars.
2020-12-22 21:35:25 +00:00
CreateInfoBar();
Turn off live resize in pcbnew on Windows The performance of live resizing isn't great. Windows can send mouse moves at 1000 Hz which is faster than the complex appearance panel + canvas can paint properly.
2020-11-14 03:15:32 +00:00
unsigned int auiFlags = wxAUI_MGR_DEFAULT;
#if !defined( _WIN32 )
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
// Windows cannot redraw the UI fast enough during a live resize and may lead to all kinds
// of graphical glitches.
Fix typo in last commit
2020-11-14 03:16:23 +00:00
auiFlags |= wxAUI_MGR_LIVE_RESIZE;
Turn off live resize in pcbnew on Windows The performance of live resizing isn't great. Windows can send mouse moves at 1000 Hz which is faster than the complex appearance panel + canvas can paint properly.
2020-11-14 03:15:32 +00:00
#endif
m_auimgr.SetFlags( auiFlags );
AUI support into topmost CMakeLists.txt
2009-11-05 08:52:41 +00:00
Fix some issues with Infobar sizing. This also commits to the new strategy as it wasn't really compatible with if-def-ing anymore.
2020-12-11 12:09:37 +00:00
// Rows; layers 4 - 6
Some more wxS
2023-01-17 00:07:41 +00:00
m_auimgr.AddPane( m_mainToolBar, EDA_PANE().HToolbar().Name( wxS( "MainToolbar" ) )
Fix some issues with Infobar sizing. This also commits to the new strategy as it wasn't really compatible with if-def-ing anymore.
2020-12-11 12:09:37 +00:00
.Top().Layer( 6 ) );
Some more wxS
2023-01-17 00:07:41 +00:00
m_auimgr.AddPane( m_auxiliaryToolBar, EDA_PANE().HToolbar().Name( wxS( "AuxToolbar" ) )
Fix some issues with Infobar sizing. This also commits to the new strategy as it wasn't really compatible with if-def-ing anymore.
2020-12-11 12:09:37 +00:00
.Top().Layer( 5 ) );
Some more wxS
2023-01-17 00:07:41 +00:00
m_auimgr.AddPane( m_messagePanel, EDA_PANE().Messages().Name( wxS( "MsgPanel" ) )
Fix some issues with Infobar sizing. This also commits to the new strategy as it wasn't really compatible with if-def-ing anymore.
2020-12-11 12:09:37 +00:00
.Bottom().Layer( 6 ) );
// Columns; layers 1 - 3
Some more wxS
2023-01-17 00:07:41 +00:00
m_auimgr.AddPane( m_optionsToolBar, EDA_PANE().VToolbar().Name( wxS( "OptToolbar" ) )
Fix some issues with Infobar sizing. This also commits to the new strategy as it wasn't really compatible with if-def-ing anymore.
2020-12-11 12:09:37 +00:00
.Left().Layer( 3 ) );
Some more wxS
2023-01-17 00:07:41 +00:00
m_auimgr.AddPane( m_drawToolBar, EDA_PANE().VToolbar().Name( wxS( "ToolsToolbar" ) )
Fix some issues with Infobar sizing. This also commits to the new strategy as it wasn't really compatible with if-def-ing anymore.
2020-12-11 12:09:37 +00:00
.Right().Layer( 3 ) );
Some more wxS
2023-01-17 00:07:41 +00:00
m_auimgr.AddPane( m_appearancePanel, EDA_PANE().Name( wxS( "LayersManager" ) )
Fix some issues with Infobar sizing. This also commits to the new strategy as it wasn't really compatible with if-def-ing anymore.
2020-12-11 12:09:37 +00:00
.Right().Layer( 4 )
Clean up some OSX issues in new appearance panel.
2020-08-15 22:26:37 +00:00
.Caption( _( "Appearance" ) ).PaneBorder( false )
FromDIP the pcb aui sizes
2024-01-18 03:02:05 +00:00
.MinSize( FromDIP( 180 ), -1 ).BestSize( FromDIP( 180 ), -1 ) );
ADDED: New appearance control widget for PcbNew Featuring: - Layer view presets - Per-type opacity for tracks, vias, pads, zones - Net and netclass color and visibility controls CHANGED: Simplified object visibilty controls Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951 Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
2020-07-11 17:42:00 +00:00
Some more wxS
2023-01-17 00:07:41 +00:00
m_auimgr.AddPane( m_selectionFilterPanel, EDA_PANE().Name( wxS( "SelectionFilter" ) )
Fix some issues with Infobar sizing. This also commits to the new strategy as it wasn't really compatible with if-def-ing anymore.
2020-12-11 12:09:37 +00:00
.Right().Layer( 4 ).Position( 2 )
.Caption( _( "Selection Filter" ) ).PaneBorder( false )
FromDIP the pcb aui sizes
2024-01-18 03:02:05 +00:00
.MinSize( FromDIP( 180 ), -1 ).BestSize( FromDIP( 180 ), -1 ) );
Marco's AUI patch, basically
2009-11-02 22:24:55 +00:00
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
m_auimgr.AddPane( m_propertiesPanel, EDA_PANE().Name( PropertiesPaneName() )
Fix usage of AUI SetAuiPaneSize() hack in FOOTPRINT_EDIT_FRAME. This brings it in line with PCB_EDIT_FRAME, which seems to work reasonably well. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14297
2023-07-16 21:28:04 +00:00
.Left().Layer( 5 )
.Caption( _( "Properties" ) ).PaneBorder( false )
FromDIP the pcb aui sizes
2024-01-18 03:02:05 +00:00
.MinSize( FromDIP( wxSize( 240, 60 ) ) ).BestSize( FromDIP( wxSize( 300, 200 ) ) ) );
WIP: Properties GUI
2020-02-04 08:40:25 +00:00
Fix some issues with Infobar sizing. This also commits to the new strategy as it wasn't really compatible with if-def-ing anymore.
2020-12-11 12:09:37 +00:00
// Center
Some more wxS
2023-01-17 00:07:41 +00:00
m_auimgr.AddPane( GetCanvas(), EDA_PANE().Canvas().Name( wxS( "DrawFrame" ) )
Fix some issues with Infobar sizing. This also commits to the new strategy as it wasn't really compatible with if-def-ing anymore.
2020-12-11 12:09:37 +00:00
.Center() );
Fixed resize issue (moved GAL panel into pane). Tidied up event handlers.
2013-04-18 09:20:19 +00:00
Fix usage of AUI SetAuiPaneSize() hack in FOOTPRINT_EDIT_FRAME. This brings it in line with PCB_EDIT_FRAME, which seems to work reasonably well. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14297
2023-07-16 21:28:04 +00:00
m_auimgr.AddPane( m_searchPane, EDA_PANE().Name( SearchPaneName() )
.Bottom()
Don't specify sizes when we don't need to. However, in some places we *do* have to because otherwise wxWidgets will pick a minimum size for us (and it's rather large). Fixes https://gitlab.com/kicad/code/kicad/-/issues/16039
2023-11-07 13:40:24 +00:00
.Caption( _( "Search" ) ).PaneBorder( false )
FromDIP the pcb aui sizes
2024-01-18 03:02:05 +00:00
.MinSize( FromDIP( wxSize ( 180, 60 ) ) ).BestSize( FromDIP( wxSize ( 180, 100 ) ) )
.FloatingSize( FromDIP( wxSize( 480, 200 ) ) )
Fix usage of AUI SetAuiPaneSize() hack in FOOTPRINT_EDIT_FRAME. This brings it in line with PCB_EDIT_FRAME, which seems to work reasonably well. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14297
2023-07-16 21:28:04 +00:00
.CloseButton( true )
.DestroyOnClose( false ) );
ADDED: Search/inspect pane
2022-09-14 02:59:57 +00:00
Overhaul border drawing in all the Kicad frames. Primary change is to replace most control/window borders with AUI pane borders. We implement our own AUI border drawing routine which avoids the ugly one-pixel white frames around dark canvasses. Also increases the signal-to-noise ratio of all the pane creation code in the various frames.
2018-08-11 16:04:46 +00:00
m_auimgr.GetPane( "LayersManager" ).Show( m_show_layer_manager_tools );
ADDED: Persistent selection filter UI for PcbNew
2020-06-27 22:48:34 +00:00
m_auimgr.GetPane( "SelectionFilter" ).Show( m_show_layer_manager_tools );
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
m_auimgr.GetPane( PropertiesPaneName() ).Show( GetPcbNewSettings()->m_AuiPanels.show_properties );
Properties panel: post-rebase fixes and hide by default Remove layer widget re-added by Orson's rebase
2020-10-19 01:57:18 +00:00
ADDED: Search/inspect pane
2022-09-14 02:59:57 +00:00
m_auimgr.GetPane( SearchPaneName() ).Show( m_show_search );
ADDED: Persistent selection filter UI for PcbNew
2020-06-27 22:48:34 +00:00
// The selection filter doesn't need to grow in the vertical direction when docked
m_auimgr.GetPane( "SelectionFilter" ).dock_proportion = 0;
Allow both aui-manager-based infobars and window overlay infobars.
2020-12-22 21:35:25 +00:00
FinishAUIInitialization();
Fix some issues with Infobar sizing. This also commits to the new strategy as it wasn't really compatible with if-def-ing anymore.
2020-12-11 12:09:37 +00:00
Remember width of right AUI panel in PcbNew
2020-08-16 18:33:40 +00:00
if( PCBNEW_SETTINGS* settings = dynamic_cast<PCBNEW_SETTINGS*>( config() ) )
{
if( settings->m_AuiPanels.right_panel_width > 0 )
{
Some more wxS
2023-01-17 00:07:41 +00:00
wxAuiPaneInfo& layersManager = m_auimgr.GetPane( wxS( "LayersManager" ) );
Fix save/load of appearance panel width on show/hide Fixes https://gitlab.com/kicad/code/kicad/-/issues/8982
2021-08-20 01:15:14 +00:00
SetAuiPaneSize( m_auimgr, layersManager, settings->m_AuiPanels.right_panel_width, -1 );
Remember width of right AUI panel in PcbNew
2020-08-16 18:33:40 +00:00
}
Remember the last active tab on the appearance panel Fixes https://gitlab.com/kicad/code/kicad/-/issues/5216
2020-08-18 02:06:31 +00:00
Save and restore properties and search panel sizes
2022-11-25 14:11:20 +00:00
if( settings->m_AuiPanels.properties_panel_width > 0 && m_propertiesPanel )
{
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
wxAuiPaneInfo& propertiesPanel = m_auimgr.GetPane( PropertiesPaneName() );
Save and restore properties and search panel sizes
2022-11-25 14:11:20 +00:00
SetAuiPaneSize( m_auimgr, propertiesPanel,
settings->m_AuiPanels.properties_panel_width, -1 );
}
Fix Search pane not remembering docking sizes and positions Fixes https://gitlab.com/kicad/code/kicad/-/issues/14120
2023-05-18 20:03:33 +00:00
if( settings->m_AuiPanels.search_panel_height > 0
&& ( settings->m_AuiPanels.search_panel_dock_direction == wxAUI_DOCK_TOP
|| settings->m_AuiPanels.search_panel_dock_direction == wxAUI_DOCK_BOTTOM ) )
Save and restore properties and search panel sizes
2022-11-25 14:11:20 +00:00
{
wxAuiPaneInfo& searchPane = m_auimgr.GetPane( SearchPaneName() );
Fix Search pane not remembering docking sizes and positions Fixes https://gitlab.com/kicad/code/kicad/-/issues/14120
2023-05-18 20:03:33 +00:00
searchPane.Direction( settings->m_AuiPanels.search_panel_dock_direction );
Save and restore properties and search panel sizes
2022-11-25 14:11:20 +00:00
SetAuiPaneSize( m_auimgr, searchPane, -1, settings->m_AuiPanels.search_panel_height );
}
Fix Search pane not remembering docking sizes and positions Fixes https://gitlab.com/kicad/code/kicad/-/issues/14120
2023-05-18 20:03:33 +00:00
else if( settings->m_AuiPanels.search_panel_width > 0
&& ( settings->m_AuiPanels.search_panel_dock_direction == wxAUI_DOCK_LEFT
|| settings->m_AuiPanels.search_panel_dock_direction == wxAUI_DOCK_RIGHT ) )
{
wxAuiPaneInfo& searchPane = m_auimgr.GetPane( SearchPaneName() );
searchPane.Direction( settings->m_AuiPanels.search_panel_dock_direction );
SetAuiPaneSize( m_auimgr, searchPane, settings->m_AuiPanels.search_panel_width, -1 );
}
Remember the last active tab on the appearance panel Fixes https://gitlab.com/kicad/code/kicad/-/issues/5216
2020-08-18 02:06:31 +00:00
m_appearancePanel->SetTabIndex( settings->m_AuiPanels.appearance_panel_tab );
Remember width of right AUI panel in PcbNew
2020-08-16 18:33:40 +00:00
}
Separate immediate and delayed action dispatch Using a boolean argument just leads to a lot of trailing booleans in the function calls and is not user friendly. Instead, introduce PostAction() to send an action that runs after the coroutine (equivalent to passing false or the default argument), and leave RunAction as the immediate execution function.
2023-06-26 22:16:51 +00:00
GetToolManager()->PostAction( ACTIONS::zoomFitScreen );
Pcbnew saves the type of used canvas.
2015-08-07 17:15:47 +00:00
Fix initial zoom to fit size in schematic and board editors. This may affect other EDA_DRAW_FRAME objects as well but it doesn't seem to be as noticeable in the symbol, footprint, and worksheet editors. Fixes https://gitlab.com/kicad/code/kicad/issues/5248
2020-08-20 14:33:12 +00:00
// This is used temporarily to fix a client size issue on GTK that causes zoom to fit
// to calculate the wrong zoom size. See PCB_EDIT_FRAME::onSize().
Bind( wxEVT_SIZE, &PCB_EDIT_FRAME::onSize, this );
Keep netnames on tracks within the viewport when possible. Fixes https://gitlab.com/kicad/code/kicad/issues/2032
2021-10-24 10:14:54 +00:00
Bind( wxEVT_IDLE,
[this]( wxIdleEvent& aEvent )
{
Optimize redrawNetnames. Using RTree is slower in this case. RTree: 25 ms when moving cursor This method: 5 ms when panning/zooming (cherry picked from commit 62fb5697b4a54bd8cdb09420ca564eebd85e37a1)
2024-06-19 17:55:33 +00:00
BOX2D viewport = GetCanvas()->GetView()->GetViewport();
if( viewport != m_lastNetnamesViewport )
{
Pull netname bug fixes and performance improvements back from master.
2024-06-14 17:21:48 +00:00
redrawNetnames();
Optimize redrawNetnames. Using RTree is slower in this case. RTree: 25 ms when moving cursor This method: 5 ms when panning/zooming (cherry picked from commit 62fb5697b4a54bd8cdb09420ca564eebd85e37a1)
2024-06-19 17:55:33 +00:00
m_lastNetnamesViewport = viewport;
}
PCB_EDIT_FRAME: do not forget to pass wxIdleEvent to other clients.
2022-02-22 18:48:17 +00:00
// Do not forget to pass the Idle event to other clients:
aEvent.Skip();
Keep netnames on tracks within the viewport when possible. Fixes https://gitlab.com/kicad/code/kicad/issues/2032
2021-10-24 10:14:54 +00:00
} );
Naming conventions.
2020-11-16 11:16:44 +00:00
resolveCanvasType();
Fix 2 separate issues with saving the m_canvasType setting. Fixes: lp:1811982 * https://bugs.launchpad.net/kicad/+bug/1811982
2019-01-17 20:25:11 +00:00
Switch to showing metric/imperial units in comboboxes and menus This will always show 1 unit from each system, with the primary unit being the current frame unit and the secondary unit being the most recent unit used from the other system. These are saved in the settings, so they are saved between runs.
2020-10-05 19:26:33 +00:00
setupUnits( config() );
Update exit strategy to match UI guidelines In singletop mode, all frames show the "Quit" option in the file menu and will quit on Ctrl-Q. When launched from the main KiCad interface, sub-programs show the "Close" option instead and will close with Ctrl-W. In this mode, Ctrl-Q will instruct the main program to exit. Fixes: lp:1779938 * https://bugs.launchpad.net/kicad/+bug/1779938
2019-06-25 04:44:34 +00:00
Make sure DRC engine works at startup If we wait to initialize this until later, some routing operations will not work properly as the constraints will be empty
2023-12-11 04:00:19 +00:00
// Ensure the DRC engine is initialized so that constraints can be resolved even before a
// board is loaded or saved
try
{
m_toolManager->GetTool<DRC_TOOL>()->GetDRCEngine()->InitEngine( wxFileName() );
}
catch( PARSE_ERROR& )
{
}
Ensure the environment variables are synchronized between KiCad and Python Before this, the environment variables inside Python wouldn't reflect the updates to them made after the interpreter was started in Pcbnew. This will call into Python and set the variables when they are changed, since Python can't synchronize itself when running in an embedded interpreter. Fixes https://gitlab.com/kicad/code/kicad/issues/5071
2020-08-09 18:49:26 +00:00
// Ensure the Python interpreter is up to date with its environment variables
PythonSyncEnvironmentVariables();
PythonSyncProjectName();
Re-add code to refresh plugins at each frame load Should now be safe Fixes https://gitlab.com/kicad/code/kicad/-/issues/9781
2021-12-09 01:48:35 +00:00
// Sync action plugins in case they changed since the last time the frame opened
Separate immediate and delayed action dispatch Using a boolean argument just leads to a lot of trailing booleans in the function calls and is not user friendly. Instead, introduce PostAction() to send an action that runs after the coroutine (equivalent to passing false or the default argument), and leave RunAction as the immediate execution function.
2023-06-26 22:16:51 +00:00
GetToolManager()->RunAction( PCB_ACTIONS::pluginsReload );
Re-add code to refresh plugins at each frame load Should now be safe Fixes https://gitlab.com/kicad/code/kicad/-/issues/9781
2021-12-09 01:48:35 +00:00
Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal.
2019-06-13 17:28:55 +00:00
GetCanvas()->SwitchBackend( m_canvasType );
Remove some legacy cursor handling stuff.
2019-05-30 12:25:08 +00:00
ActivateGalCanvas();
Added STEP Export menu item and supporting code
2016-09-19 07:40:36 +00:00
Add shutdown blocking on Windows for pcbnew, eeschema and pleditor ADDED: Block shutdown/logoff on Windows when contents have been modified
2019-12-19 14:11:11 +00:00
// Default shutdown reason until a file is loaded
Move shutdown blocker to kiplatform
2020-09-01 10:14:51 +00:00
KIPLATFORM::APP::SetShutdownBlockReason( this, _( "New PCB file is unsaved" ) );
Add shutdown blocking on Windows for pcbnew, eeschema and pleditor ADDED: Block shutdown/logoff on Windows when contents have been modified
2019-12-19 14:11:11 +00:00
Added STEP Export menu item and supporting code
2016-09-19 07:40:36 +00:00
// disable Export STEP item if kicad2step does not exist
Fixed typo preventing compilation on MSWin
2016-09-19 21:29:38 +00:00
wxString strK2S = Pgm().GetExecutablePath();
Remove string translation wrappers used in commit 94891b75. Translating internal file name and path strings will almost certainly result in a bug on MacOS.
2018-06-18 16:14:10 +00:00
#ifdef __WXMAC__
More wxString wide literals.
2022-02-04 22:44:59 +00:00
if( strK2S.Find( wxT( "pcbnew.app" ) ) != wxNOT_FOUND )
Handle STEP export properly on MacOS when launched from standalone pcbnew.
2018-06-13 02:35:42 +00:00
{
// On macOS, we have standalone applications inside the main bundle, so we handle that here:
More wxString wide literals.
2022-02-04 22:44:59 +00:00
strK2S += wxT( "../../" );
Handle STEP export properly on MacOS when launched from standalone pcbnew.
2018-06-13 02:35:42 +00:00
}
Remove string translation wrappers used in commit 94891b75. Translating internal file name and path strings will almost certainly result in a bug on MacOS.
2018-06-18 16:14:10 +00:00
More wxString wide literals.
2022-02-04 22:44:59 +00:00
strK2S += wxT( "Contents/MacOS/" );
Remove string translation wrappers used in commit 94891b75. Translating internal file name and path strings will almost certainly result in a bug on MacOS.
2018-06-18 16:14:10 +00:00
#endif
More wxString wide literals.
2022-02-04 22:44:59 +00:00
wxFileName appK2S( strK2S, wxT( "kicad2step" ) );
Added STEP Export menu item and supporting code
2016-09-19 07:40:36 +00:00
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
#ifdef _WIN32
More wxString wide literals.
2022-02-04 22:44:59 +00:00
appK2S.SetExt( wxT( "exe" ) );
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
#endif
Added STEP Export menu item and supporting code
2016-09-19 07:40:36 +00:00
Rewrite window positioning logic Now only reposition a window if it is completely on a disconnected display or if only one corner is on screen and it is within a region close to the screen border. CHANGED: Window position on startup should be preserved more
2020-04-17 23:32:29 +00:00
// Ensure the window is on top
Raise();
Move place symbol to modern toolset.
2019-04-15 14:34:58 +00:00
// if( !appK2S.FileExists() )
// GetMenuBar()->FindItem( ID_GEN_EXPORT_FILE_STEP )->Enable( false );
Kick-start appearance panel to redraw on Mac Fixes https://gitlab.com/kicad/code/kicad/-/issues/6827
2020-12-25 15:44:18 +00:00
// AUI doesn't refresh properly on wxMac after changes in eb7dc6dd, so force it to
#ifdef __WXMAC__
if( Kiface().IsSingle() )
{
Don't capture references to local variables for CallAfter. Fixes https://gitlab.com/kicad/code/kicad/-/issues/16934
2024-02-14 18:15:49 +00:00
CallAfter( [this]()
Kick-start appearance panel to redraw on Mac Fixes https://gitlab.com/kicad/code/kicad/-/issues/6827
2020-12-25 15:44:18 +00:00
{
m_appearancePanel->OnBoardChanged();
} );
}
#endif
Ensure toolbar controls have the correct width on frame creation Otherwise they could be slightly too small and then look odd.
2021-03-27 21:49:38 +00:00
// Register a call to update the toolbar sizes. It can't be done immediately because
// it seems to require some sizes calculated that aren't yet (at least on GTK).
Don't capture references to local variables for CallAfter. Fixes https://gitlab.com/kicad/code/kicad/-/issues/16934
2024-02-14 18:15:49 +00:00
CallAfter( [this]()
Ensure toolbar controls have the correct width on frame creation Otherwise they could be slightly too small and then look odd.
2021-03-27 21:49:38 +00:00
{
// Ensure the controls on the toolbars all are correctly sized
UpdateToolbarControlSizes();
} );
Add profile counters for PCB mouse and paint events
2021-12-05 20:15:18 +00:00
if( ADVANCED_CFG::GetCfg().m_ShowEventCounters )
{
m_eventCounterTimer = new wxTimer( this );
Bind( wxEVT_TIMER,
[&]( wxTimerEvent& aEvent )
{
GetCanvas()->m_PaintEventCounter->Show();
GetCanvas()->m_PaintEventCounter->Reset();
KIGFX::WX_VIEW_CONTROLS* vc =
static_cast<KIGFX::WX_VIEW_CONTROLS*>( GetCanvas()->GetViewControls() );
vc->m_MotionEventCounter->Show();
vc->m_MotionEventCounter->Reset();
},
m_eventCounterTimer->GetId() );
m_eventCounterTimer->Start( 1000 );
}
ADDED: Implement Drag and Drop dropping files to Kicad manager : *.kicad_pro, *.pro -> open project; gerber and job files -> open in Gerbview editor; Eagle and Cadstar files -> open project. dropping file to schematic editor -> append schematic; dropping library file to Symbol editor -> add library; dropping board file to PCB editor -> append board; dropping library or footprint file to Footprint editor -> add library or import footprint; dropping ZIP file or gerber files to Gerbview editor -> open files; dropping sheet file to Drawing Sheet editor -> open sheet. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11638
2022-09-14 22:28:09 +00:00
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
Bind( EDA_EVT_CLOSE_DIALOG_BOOK_REPORTER, &PCB_EDIT_FRAME::onCloseModelessBookReporterDialogs,
this );
Bind( EDA_EVT_CLOSE_NET_INSPECTOR_DIALOG, &PCB_EDIT_FRAME::onCloseNetInspectorDialog, this );
Bind( EDA_EVT_UNITS_CHANGED, &PCB_EDIT_FRAME::onUnitsChanged, this );
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-28 02:10:01 +00:00
m_acceptedExts.emplace( FILEEXT::KiCadPcbFileExtension, &PCB_ACTIONS::ddAppendBoard );
m_acceptedExts.emplace( FILEEXT::LegacyPcbFileExtension, &PCB_ACTIONS::ddAppendBoard );
ADDED: Implement Drag and Drop dropping files to Kicad manager : *.kicad_pro, *.pro -> open project; gerber and job files -> open in Gerbview editor; Eagle and Cadstar files -> open project. dropping file to schematic editor -> append schematic; dropping library file to Symbol editor -> add library; dropping board file to PCB editor -> append board; dropping library or footprint file to Footprint editor -> add library or import footprint; dropping ZIP file or gerber files to Gerbview editor -> open files; dropping sheet file to Drawing Sheet editor -> open sheet. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11638
2022-09-14 22:28:09 +00:00
DragAcceptFiles( true );
add files not currently available in source (e.g. docs, modules, etc.) set svn:eol-style property to native for all ascii files to support cross platform development
2007-06-05 12:10:51 +00:00
}
solved: eeschema, small problem with fields selections in BOM generation
2008-06-04 13:17:33 +00:00
PCBNew control update bug fixes, fixes lp:725963. * Fix grid select box update bug on context menu. * Fix via size and track width select box update bugs. * Fix layer pair indicator button update bug. * Fix auto track width tool bar control enable bug. * Fix via size and track width select status bug in context menu. * Fix layer select box and layer control widget select bug when current layer is removed. * Add virtual function to notify objects derived from EDA_DRAW_FRAME that the units setting has changed. * Coding policy class naming fixes.
2011-03-01 19:26:17 +00:00
PCB_EDIT_FRAME::~PCB_EDIT_FRAME()
add files not currently available in source (e.g. docs, modules, etc.) set svn:eol-style property to native for all ascii files to support cross platform development
2007-06-05 12:10:51 +00:00
{
Prevent crash when a python script tries to use pcbnew too early. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15414
2023-08-24 21:09:53 +00:00
ScriptingOnDestructPcbEditFrame( this );
Fix race condition with ShowEventCounters on Windows
2021-12-26 13:29:54 +00:00
if( ADVANCED_CFG::GetCfg().m_ShowEventCounters )
{
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
// Stop the timer during destruction early to avoid potential event race conditions (that
// do happen on windows)
Fix race condition with ShowEventCounters on Windows
2021-12-26 13:29:54 +00:00
m_eventCounterTimer->Stop();
delete m_eventCounterTimer;
}
Gracefully shutdown tools when frames are closed If the tools are not gracefully exited, then the stack variables are never destroyed, so variable lifetime issues can occur. Fixes https://gitlab.com/kicad/code/kicad/issues/1753
2020-02-03 14:00:48 +00:00
// Shutdown all running tools
if( m_toolManager )
m_toolManager->ShutdownAllTools();
ADDED: Persistent selection filter UI for PcbNew
2020-06-27 22:48:34 +00:00
ADDED: New appearance control widget for PcbNew Featuring: - Layer view presets - Per-type opacity for tracks, vias, pads, zones - Net and netclass color and visibility controls CHANGED: Simplified object visibilty controls Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951 Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
2020-07-11 17:42:00 +00:00
if( GetBoard() )
Add RemoveAllListeners function for future addons
2022-08-11 03:10:58 +00:00
GetBoard()->RemoveAllListeners();
ADDED: New appearance control widget for PcbNew Featuring: - Layer view presets - Per-type opacity for tracks, vias, pads, zones - Net and netclass color and visibility controls CHANGED: Simplified object visibilty controls Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951 Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
2020-07-11 17:42:00 +00:00
ADDED: Persistent selection filter UI for PcbNew
2020-06-27 22:48:34 +00:00
delete m_selectionFilterPanel;
ADDED: New appearance control widget for PcbNew Featuring: - Layer view presets - Per-type opacity for tracks, vias, pads, zones - Net and netclass color and visibility controls CHANGED: Simplified object visibilty controls Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951 Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
2020-07-11 17:42:00 +00:00
delete m_appearancePanel;
Fix a wxWidget assert and a minor wxWidgets alert
2021-04-19 13:01:00 +00:00
delete m_exportNetlistAction;
Properties panel: post-rebase fixes and hide by default Remove layer widget re-added by Orson's rebase
2020-10-19 01:57:18 +00:00
delete m_propertiesPanel;
add files not currently available in source (e.g. docs, modules, etc.) set svn:eol-style property to native for all ascii files to support cross platform development
2007-06-05 12:10:51 +00:00
}
All control state handling is now performed in wxUpdateUIEvent handlers. * Old control state handling code completely removed in all applications. * Factor common control state handlers into EDA_DRAW_FRAME. * Replaced EDA_ITEM test for newness with IsNew() method. * Factor vertical right toolbar command handlers out of giant edit command switch statement in EESchema and PCBNew.
2011-02-21 13:54:29 +00:00
Use progress reporting in more places when loading a board Prevents application-not-responding events while opening large designs
2021-11-25 16:19:03 +00:00
void PCB_EDIT_FRAME::SetBoard( BOARD* aBoard, bool aBuildConnectivity,
PROGRESS_REPORTER* aReporter )
Added ratsnest for GAL
2013-11-25 15:50:03 +00:00
{
Cleanup. No changes to execution.
2020-09-30 22:02:05 +00:00
if( m_pcb )
m_pcb->ClearProject();
Migrate PcbNew project settings to new framework Various architecture upgrades to support this. Creating a BOARD now requires a valid PROJECT, which caused some (mostly transparent) changes to the Python API internals. ADDED: Project local settings file CHANGED: Board design settings are no longer stored in PCB file CHANGED: Net classes are no longer stored in PCB file CHANGED: Importing board settings now reads boards, not just projects Fixes https://gitlab.com/kicad/code/kicad/-/issues/2578 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4070
2020-05-31 21:42:04 +00:00
Use progress reporting in more places when loading a board Prevents application-not-responding events while opening large designs
2021-11-25 16:19:03 +00:00
PCB_BASE_EDIT_FRAME::SetBoard( aBoard, aReporter );
Added ratsnest for GAL
2013-11-25 15:50:03 +00:00
Variable substitution framework. This implements editing of variables and moving SCH_FIELDs, TEXTE_MODULEs, TEXTE_PCB and worksheet items over to the new framework.
2020-03-26 11:02:59 +00:00
aBoard->SetProject( &Prj() );
Remove some duplicate work when loading a board
2021-11-25 03:04:16 +00:00
if( aBuildConnectivity )
Move ratsnest exclusion processing to a post-pass. Also fixes a few cases where we were unnecessarily rebuilding connectivity more than once for an operation.
2022-09-29 16:07:42 +00:00
aBoard->BuildConnectivity();
Add a new color selector, to adjust color selection for GAL mode, with support of opacity (alpha channel) Pcbnew: save opacity value in color config, and keep it when switching between legacy and gal mode.
2017-07-04 10:48:47 +00:00
Round 2 of Worksheet -> Drawing Sheet.
2021-02-22 23:47:17 +00:00
// reload the drawing-sheet
Remove more legacy editing code.
2019-05-27 16:16:54 +00:00
SetPageSettings( aBoard->GetPageSettings() );
pcbnew: GAL updates the worksheet layout when it is reloaded.
2014-09-08 12:06:38 +00:00
}
BOARD_ITEM_CONTAINER class.
2016-05-13 15:31:54 +00:00
BOARD_ITEM_CONTAINER* PCB_EDIT_FRAME::GetModel() const
{
Cleanup. No changes to execution.
2020-09-30 22:02:05 +00:00
return m_pcb;
BOARD_ITEM_CONTAINER class.
2016-05-13 15:31:54 +00:00
}
Pull netname bug fixes and performance improvements back from master.
2024-06-14 17:21:48 +00:00
void PCB_EDIT_FRAME::redrawNetnames()
Keep netnames on tracks within the viewport when possible. Fixes https://gitlab.com/kicad/code/kicad/issues/2032
2021-10-24 10:14:54 +00:00
{
Pull netname bug fixes and performance improvements back from master.
2024-06-14 17:21:48 +00:00
/*
* While new items being scrolled into the view will get painted, they will only get
* annotated with netname instances currently within the view. Subsequent panning will not
* draw newly-visible netname instances because the item has already been drawn.
*
* This routine, fired on idle if the viewport has changed, looks for visible items that
* might have multiple netname instances and redraws them. (It does not need to handle pads
* and vias because they only ever have a single netname instance drawn on them.)
*/
More delay for netname drawing, and don't run through tracks if it's off.
2022-09-16 21:19:56 +00:00
PCBNEW_SETTINGS* cfg = dynamic_cast<PCBNEW_SETTINGS*>( Kiface().KifaceSettings() );
if( !cfg || cfg->m_Display.m_NetNames < 2 )
return;
Keep netnames on tracks within the viewport when possible. Fixes https://gitlab.com/kicad/code/kicad/issues/2032
2021-10-24 10:14:54 +00:00
KIGFX::VIEW* view = GetCanvas()->GetView();
Pull netname bug fixes and performance improvements back from master.
2024-06-14 17:21:48 +00:00
BOX2D viewport = view->GetViewport();
Keep netnames on tracks within the viewport when possible. Fixes https://gitlab.com/kicad/code/kicad/issues/2032
2021-10-24 10:14:54 +00:00
Optimize redrawNetnames. Using RTree is slower in this case. RTree: 25 ms when moving cursor This method: 5 ms when panning/zooming (cherry picked from commit 62fb5697b4a54bd8cdb09420ca564eebd85e37a1)
2024-06-19 17:55:33 +00:00
// Inflate to catch most of the track width
BOX2I_MINMAX clipbox( BOX2ISafe( viewport.Inflate( pcbIUScale.mmToIU( 2.0 ) ) ) );
Move early exit higher in netname redraw If the track is outside of the viewbox, GetLOD returns HIDE. This needs to be handled quickly in the loop before further processing Fixes https://gitlab.com/kicad/code/kicad/issues/13572
2023-01-17 23:36:02 +00:00
Optimize redrawNetnames. Using RTree is slower in this case. RTree: 25 ms when moving cursor This method: 5 ms when panning/zooming (cherry picked from commit 62fb5697b4a54bd8cdb09420ca564eebd85e37a1)
2024-06-19 17:55:33 +00:00
for( PCB_TRACK* track : GetBoard()->Tracks() )
{
// Don't need to update vias
if( track->Type() == PCB_VIA_T )
continue;
Cache LOD for netname redraw When panning, we should only redraw the netnames when they come into view or go out of view. Caching the LOD provides this preventing unneeded redraws while still redrawing on zoom changes Fixes https://gitlab.com/kicad/code/kicad/issues/12436
2022-11-03 20:47:13 +00:00
Optimize redrawNetnames. Using RTree is slower in this case. RTree: 25 ms when moving cursor This method: 5 ms when panning/zooming (cherry picked from commit 62fb5697b4a54bd8cdb09420ca564eebd85e37a1)
2024-06-19 17:55:33 +00:00
// Don't update invisible tracks
if( !clipbox.Intersects( BOX2I_MINMAX( track->GetStart(), track->GetEnd() ) ) )
continue;
Keep netnames on tracks within the viewport when possible. Fixes https://gitlab.com/kicad/code/kicad/issues/2032
2021-10-24 10:14:54 +00:00
Optimize redrawNetnames. Using RTree is slower in this case. RTree: 25 ms when moving cursor This method: 5 ms when panning/zooming (cherry picked from commit 62fb5697b4a54bd8cdb09420ca564eebd85e37a1)
2024-06-19 17:55:33 +00:00
if( track->ViewGetLOD( GetNetnameLayer( track->GetLayer() ), view ) < view->GetScale() )
view->Update( track, KIGFX::REPAINT );
}
Keep netnames on tracks within the viewport when possible. Fixes https://gitlab.com/kicad/code/kicad/issues/2032
2021-10-24 10:14:54 +00:00
}
pcbnew: GAL updates the worksheet layout when it is reloaded.
2014-09-08 12:06:38 +00:00
void PCB_EDIT_FRAME::SetPageSettings( const PAGE_INFO& aPageSettings )
{
PCB_BASE_FRAME::SetPageSettings( aPageSettings );
Round 2 of Worksheet -> Drawing Sheet.
2021-02-22 23:47:17 +00:00
// Prepare drawing-sheet template
Move drawing sheet datastructures to EDA_IU_SCALE. Or mostly, at least. Plotters still define their own mils-to-iu scale. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14934
2023-06-12 21:33:55 +00:00
DS_PROXY_VIEW_ITEM* drawingSheet = new DS_PROXY_VIEW_ITEM( pcbIUScale,
Round 2 of Worksheet -> Drawing Sheet.
2021-02-22 23:47:17 +00:00
&m_pcb->GetPageSettings(),
m_pcb->GetProject(),
Allow text variable resolution through properties in drawing sheet text. Fixes https://gitlab.com/kicad/code/kicad/issues/12473
2022-09-20 14:25:03 +00:00
&m_pcb->GetTitleBlock(),
&m_pcb->GetProperties() );
Worksheet -> (industry standard) Drawing Sheet.
2021-02-22 16:37:43 +00:00
drawingSheet->SetSheetName( std::string( GetScreenDesc().mb_str() ) );
Support SHEET_PATH when printing. Fixes https://gitlab.com/kicad/code/kicad/issues/14233
2023-03-12 22:23:48 +00:00
drawingSheet->SetSheetPath( std::string( GetFullScreenDesc().mb_str() ) );
Allow text variable resolution through properties in drawing sheet text. Fixes https://gitlab.com/kicad/code/kicad/issues/12473
2022-09-20 14:25:03 +00:00
Pcbnew, drawing sheet: use "First Page" option to draw/plot it. Some items can be drawn only on the first page or only on the other pages. a board has only a first page.
2022-01-01 08:29:18 +00:00
// A board is not like a schematic having a main page and sub sheets.
// So for the drawing sheet, use only the first page option to display items
drawingSheet->SetIsFirstPage( true );
Added ratsnest for GAL
2013-11-25 15:50:03 +00:00
Remove more legacy editing code.
2019-05-27 16:16:54 +00:00
BASE_SCREEN* screen = GetScreen();
Added ratsnest for GAL
2013-11-25 15:50:03 +00:00
More NULL expunging.
2021-07-19 23:56:05 +00:00
if( screen != nullptr )
Remove more legacy editing code.
2019-05-27 16:16:54 +00:00
{
Worksheet -> (industry standard) Drawing Sheet.
2021-02-22 16:37:43 +00:00
drawingSheet->SetPageNumber(TO_UTF8( screen->GetPageNumber() ) );
drawingSheet->SetSheetCount( screen->GetPageCount() );
Remove more legacy editing code.
2019-05-27 16:16:54 +00:00
}
The GAL view uses colors settings from the legacy canvas. Minor refactoring of PAINTER & RENDER_SETTINGS classes.
2014-05-21 21:13:30 +00:00
Worksheet -> (industry standard) Drawing Sheet.
2021-02-22 16:37:43 +00:00
if( BOARD* board = GetBoard() )
drawingSheet->SetFileName( TO_UTF8( board->GetFileName() ) );
pcbnew: Set filename in Page Layout template pcbnew refreshes the viewItem for the worksheet multiple times. This requires setting the filename to get parameters displayed on the worksheet correctly. Fixes: lp:1819000 * https://bugs.launchpad.net/kicad/+bug/1819000
2019-03-07 14:00:15 +00:00
Round 2 of Worksheet -> Drawing Sheet.
2021-02-22 23:47:17 +00:00
// PCB_DRAW_PANEL_GAL takes ownership of the drawing-sheet
Worksheet -> (industry standard) Drawing Sheet.
2021-02-22 16:37:43 +00:00
GetCanvas()->SetDrawingSheet( drawingSheet );
Added ratsnest for GAL
2013-11-25 15:50:03 +00:00
}
Unify IsSave and IsModify The flags and calls were used identically, leading to potential confusion/bugs. Testing for modification should go through IsContentModified()
2021-05-27 23:07:48 +00:00
bool PCB_EDIT_FRAME::IsContentModified() const
Unify unsaved changes detection logic in all frames Create an IsContentModified() function in each frame that provides if the content has been modified, and use that instead of always copying the checks.
2019-12-19 15:34:01 +00:00
{
Rename modification flag routines Differentiates better between the EDA_ITEM IsModified(), referring to items themselves changing and the EDA_SCREEN IsContentModified(), referring to whether we have made any unsaved changes.
2021-05-28 19:07:04 +00:00
return GetScreen() && GetScreen()->IsContentModified();
Unify unsaved changes detection logic in all frames Create an IsContentModified() function in each frame that provides if the content has been modified, and use that instead of always copying the checks.
2019-12-19 15:34:01 +00:00
}
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
SELECTION& PCB_EDIT_FRAME::GetCurrentSelection()
{
Make distinction between PCBNew-wide tools and Board-specific tools. The old names were really hard to keep straight (even for me, who named many of them).
2020-12-16 13:31:32 +00:00
return m_toolManager->GetTool<PCB_SELECTION_TOOL>()->GetSelection();
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
}
Fixed a few memory leaks and Valgrind warnings.
2014-07-09 13:02:56 +00:00
void PCB_EDIT_FRAME::setupTools()
{
// Create the manager and dispatcher & route draw panel events to the dispatcher
m_toolManager = new TOOL_MANAGER;
Cleanup. No changes to execution.
2020-09-30 22:02:05 +00:00
m_toolManager->SetEnvironment( m_pcb, GetCanvas()->GetView(),
Push a couple of layers of indirection out of grid settings.
2020-06-12 10:58:56 +00:00
GetCanvas()->GetViewControls(), config(), this );
Refactor COMMON_ACTIONS into a base and derived class New virtual class ACTIONS is added as a member to EDA_DRAW_FRAME so that the TOOL_DISPATCHER can have access to the appropriate derived version of TranslateLegacyId()
2017-02-21 12:42:08 +00:00
m_actions = new PCB_ACTIONS();
Remove ACTIONS::TranslateLegacyId and TOOL_DISPATCHER::DispatchWxCommand After commit 9535153f9e there were no more IDs inside the legacy ID system. Therefore the entire system for dispatching and looking up the legacy ideas and handling those events can now be removed and the tool dispatcher simplified (it no longer needs to know about the ACTIONS class).
2021-03-27 20:02:34 +00:00
m_toolDispatcher = new TOOL_DISPATCHER( m_toolManager );
Fixed a few memory leaks and Valgrind warnings.
2014-07-09 13:02:56 +00:00
// Register tools
Move hotkeys to ACTION architecture.
2019-06-09 21:57:23 +00:00
m_toolManager->RegisterTool( new COMMON_CONTROL );
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
m_toolManager->RegisterTool( new COMMON_TOOLS );
Make distinction between PCBNew-wide tools and Board-specific tools. The old names were really hard to keep straight (even for me, who named many of them).
2020-12-16 13:31:32 +00:00
m_toolManager->RegisterTool( new PCB_SELECTION_TOOL );
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
m_toolManager->RegisterTool( new ZOOM_TOOL );
Make distinction between PCBNew-wide tools and Board-specific tools. The old names were really hard to keep straight (even for me, who named many of them).
2020-12-16 13:31:32 +00:00
m_toolManager->RegisterTool( new PCB_PICKER_TOOL );
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
m_toolManager->RegisterTool( new ROUTER_TOOL );
m_toolManager->RegisterTool( new EDIT_TOOL );
Move global commands to ACTIONs. Also fixes a crash bug opening Edit Tracks and Vias dialog.
2019-06-03 20:06:58 +00:00
m_toolManager->RegisterTool( new GLOBAL_EDIT_TOOL );
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
m_toolManager->RegisterTool( new PAD_TOOL );
m_toolManager->RegisterTool( new DRAWING_TOOL );
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
m_toolManager->RegisterTool( new PCB_POINT_EDITOR );
Make distinction between PCBNew-wide tools and Board-specific tools. The old names were really hard to keep straight (even for me, who named many of them).
2020-12-16 13:31:32 +00:00
m_toolManager->RegisterTool( new PCB_CONTROL );
m_toolManager->RegisterTool( new BOARD_EDITOR_CONTROL );
m_toolManager->RegisterTool( new BOARD_INSPECTION_TOOL );
m_toolManager->RegisterTool( new BOARD_REANNOTATE_TOOL );
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
m_toolManager->RegisterTool( new ALIGN_DISTRIBUTE_TOOL );
m_toolManager->RegisterTool( new MICROWAVE_TOOL );
m_toolManager->RegisterTool( new POSITION_RELATIVE_TOOL );
m_toolManager->RegisterTool( new ZONE_FILLER_TOOL );
m_toolManager->RegisterTool( new AUTOPLACE_TOOL );
Move DRC dialog to new DRC engine.
2020-09-14 17:54:14 +00:00
m_toolManager->RegisterTool( new DRC_TOOL );
Consolidate common viewer actions across cvpcb and pcbnew frames * Consolidate the measure tool into one tool (this gives cvpcb unit changing and snapping capabilities in its measure tool) * Transition cvpcb to use actions for the sketch modes * Replumb how magnetic items settings are stored and used
2020-05-22 18:27:05 +00:00
m_toolManager->RegisterTool( new PCB_VIEWER_TOOLS );
ADDED: Tool for converting shape types in PcbNew Fixes https://gitlab.com/kicad/code/kicad/-/issues/2406 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2507
2018-11-13 13:30:56 +00:00
m_toolManager->RegisterTool( new CONVERT_TOOL );
ADDED Properties Dialog for groups. ADDED memberOf() function for DRC rule expressions. Also fixes a bug in several of the pickers where the event wasn't being correctly passed. Fixes https://gitlab.com/kicad/code/kicad/issues/5647
2020-09-24 01:05:46 +00:00
m_toolManager->RegisterTool( new GROUP_TOOL );
Introduce GENERATOR_TOOL.
2023-10-07 01:19:25 +00:00
m_toolManager->RegisterTool( new GENERATOR_TOOL );
Add Python Tool to pcbnew
2021-03-19 23:06:29 +00:00
m_toolManager->RegisterTool( new SCRIPTING_TOOL );
WIP: Properties GUI
2020-02-04 08:40:25 +00:00
m_toolManager->RegisterTool( new PROPERTIES_TOOL );
Allow registering TOOLs in any order.
2017-01-30 10:38:02 +00:00
m_toolManager->InitTools();
Fixed a few memory leaks and Valgrind warnings.
2014-07-09 13:02:56 +00:00
ADDED: automatic zone refilling. This is for the out-of-box experience for novice users. It is presumed that folks with larger more complicated boards will turn it off. Fixes https://gitlab.com/kicad/code/kicad/issues/6413
2022-02-24 09:59:54 +00:00
for( TOOL_BASE* tool : m_toolManager->Tools() )
{
if( PCB_TOOL_BASE* pcbTool = dynamic_cast<PCB_TOOL_BASE*>( tool ) )
pcbTool->SetIsBoardEditor( true );
}
Fixed a few memory leaks and Valgrind warnings.
2014-07-09 13:02:56 +00:00
// Run the selection tool, it is supposed to be always active
m_toolManager->InvokeTool( "pcbnew.InteractiveSelection" );
}
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
void PCB_EDIT_FRAME::setupUIConditions()
{
PCB_BASE_EDIT_FRAME::setupUIConditions();
ACTION_MANAGER* mgr = m_toolManager->GetActionManager();
PCB_EDITOR_CONDITIONS cond( this );
Treat undo as backspace and/or escape when drawing. Ignore redo. Undo == backspace when drawing a polygon or chained lines. Otherwise it's an escape. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14961
2023-06-16 20:44:16 +00:00
auto undoCond =
[ this ] (const SELECTION& aSel )
{
DRAWING_TOOL* drawingTool = m_toolManager->GetTool<DRAWING_TOOL>();
if( drawingTool && drawingTool->GetDrawingMode() != DRAWING_TOOL::MODE::NONE )
return true;
Unify go-back-one-step processing for drawing tools (and router). Also warps mouse on all go-back-one-step operations for better feedback. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14981 Fixes https://gitlab.com/kicad/code/kicad/-/issues/9985
2023-06-19 16:09:03 +00:00
ROUTER_TOOL* routerTool = m_toolManager->GetTool<ROUTER_TOOL>();
if( routerTool && routerTool->RoutingInProgress() )
return true;
Treat undo as backspace and/or escape when drawing. Ignore redo. Undo == backspace when drawing a polygon or chained lines. Otherwise it's an escape. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14961
2023-06-16 20:44:16 +00:00
return GetUndoCommandCount() > 0;
};
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
wxASSERT( mgr );
#define ENABLE( x ) ACTION_CONDITIONS().Enable( x )
#define CHECK( x ) ACTION_CONDITIONS().Check( x )
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
mgr->SetConditions( ACTIONS::save, ENABLE( SELECTION_CONDITIONS::ShowAlways ) );
Treat undo as backspace and/or escape when drawing. Ignore redo. Undo == backspace when drawing a polygon or chained lines. Otherwise it's an escape. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14961
2023-06-16 20:44:16 +00:00
mgr->SetConditions( ACTIONS::undo, ENABLE( undoCond ) );
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
mgr->SetConditions( ACTIONS::redo, ENABLE( cond.RedoAvailable() ) );
mgr->SetConditions( ACTIONS::toggleGrid, CHECK( cond.GridVisible() ) );
PCB: start of grid overrides Only works for moves.
2023-08-24 14:13:59 +00:00
mgr->SetConditions( ACTIONS::toggleGridOverrides, CHECK( cond.GridOverrides() ) );
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
mgr->SetConditions( ACTIONS::toggleCursorStyle, CHECK( cond.FullscreenCursor() ) );
mgr->SetConditions( ACTIONS::togglePolarCoords, CHECK( cond.PolarCoordinates() ) );
mgr->SetConditions( ACTIONS::millimetersUnits, CHECK( cond.Units( EDA_UNITS::MILLIMETRES ) ) );
mgr->SetConditions( ACTIONS::inchesUnits, CHECK( cond.Units( EDA_UNITS::INCHES ) ) );
mgr->SetConditions( ACTIONS::milsUnits, CHECK( cond.Units( EDA_UNITS::MILS ) ) );
mgr->SetConditions( ACTIONS::cut, ENABLE( cond.HasItems() ) );
mgr->SetConditions( ACTIONS::copy, ENABLE( cond.HasItems() ) );
Revert "Use lambdas to fix paste conditions" This reverts commit 65c7c77c3df1791bfde29a01a76007ec68e93c4c.
2021-05-31 01:25:42 +00:00
mgr->SetConditions( ACTIONS::paste,
ENABLE( SELECTION_CONDITIONS::Idle && cond.NoActiveTool() ) );
mgr->SetConditions( ACTIONS::pasteSpecial,
ENABLE( SELECTION_CONDITIONS::Idle && cond.NoActiveTool() ) );
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
mgr->SetConditions( ACTIONS::selectAll, ENABLE( cond.HasItems() ) );
Add Unselect all in menu
2023-09-06 23:44:39 +00:00
mgr->SetConditions( ACTIONS::unselectAll, ENABLE( cond.HasItems() ) );
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
mgr->SetConditions( ACTIONS::doDelete, ENABLE( cond.HasItems() ) );
mgr->SetConditions( ACTIONS::duplicate, ENABLE( cond.HasItems() ) );
Allow creation of groups with a single member. Fixes https://gitlab.com/kicad/code/kicad/-/issues/16586
2024-01-19 17:31:25 +00:00
mgr->SetConditions( PCB_ACTIONS::group, ENABLE( SELECTION_CONDITIONS::NotEmpty ) );
Introduce PCB_GENERATOR.
2023-10-06 17:04:00 +00:00
mgr->SetConditions( PCB_ACTIONS::ungroup, ENABLE( SELECTION_CONDITIONS::HasTypes(
{ PCB_GROUP_T, PCB_GENERATOR_T } ) ) );
PCB Editor: make locking menu items conditional Fixes: https://gitlab.com/kicad/code/kicad/-/issues/5202
2022-12-20 15:16:25 +00:00
mgr->SetConditions( PCB_ACTIONS::lock, ENABLE( PCB_SELECTION_CONDITIONS::HasUnlockedItems ) );
mgr->SetConditions( PCB_ACTIONS::unlock, ENABLE( PCB_SELECTION_CONDITIONS::HasLockedItems ) );
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
mgr->SetConditions( PCB_ACTIONS::padDisplayMode, CHECK( !cond.PadFillDisplay() ) );
mgr->SetConditions( PCB_ACTIONS::viaDisplayMode, CHECK( !cond.ViaFillDisplay() ) );
mgr->SetConditions( PCB_ACTIONS::trackDisplayMode, CHECK( !cond.TrackFillDisplay() ) );
Pcbnew menubar: View/Drawing Mode/Sketch Text Items and Skecth Graphic Items: Handle the Checked/Unchecked bitmap symbols of these 2 submenus.
2022-12-03 10:03:14 +00:00
mgr->SetConditions( PCB_ACTIONS::graphicsOutlines, CHECK( !cond.GraphicsFillDisplay() ) );
mgr->SetConditions( PCB_ACTIONS::textOutlines, CHECK( !cond.TextFillDisplay() ) );
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
Fix python console toggle to work across pcbnew/eeschema
2021-07-02 19:05:16 +00:00
if( SCRIPTING::IsWxAvailable() )
mgr->SetConditions( PCB_ACTIONS::showPythonConsole, CHECK( cond.ScriptingConsoleVisible() ) );
More NULL expunging.
2021-07-19 23:56:05 +00:00
Cleanup.
2023-06-12 10:14:27 +00:00
auto enableZoneControlCondition =
[this] ( const SELECTION& )
{
Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.
2023-06-12 11:38:50 +00:00
return GetBoard() && GetBoard()->GetVisibleElements().Contains( LAYER_ZONES )
Cleanup.
2023-06-12 10:14:27 +00:00
&& GetDisplayOptions().m_ZoneOpacity > 0.0;
};
Disable the zone display types if zones are hidden This prevents user confusion (a little) when the zones are hidden Fixes https://gitlab.com/kicad/code/kicad/issues/6783
2020-12-19 01:03:02 +00:00
Move zone fracture display mode to AdvancedCfg, and add triangulation. Fixes https://gitlab.com/kicad/code/kicad/issues/8762
2021-07-26 17:56:11 +00:00
mgr->SetConditions( PCB_ACTIONS::zoneDisplayFilled,
Cleanup.
2023-06-12 10:14:27 +00:00
ENABLE( enableZoneControlCondition )
Move show-bounding-boxes to a tool on the toolbars.
2022-01-17 11:55:55 +00:00
.Check( cond.ZoneDisplayMode( ZONE_DISPLAY_MODE::SHOW_FILLED ) ) );
Move zone fracture display mode to AdvancedCfg, and add triangulation. Fixes https://gitlab.com/kicad/code/kicad/issues/8762
2021-07-26 17:56:11 +00:00
mgr->SetConditions( PCB_ACTIONS::zoneDisplayOutline,
Cleanup.
2023-06-12 10:14:27 +00:00
ENABLE( enableZoneControlCondition )
Move show-bounding-boxes to a tool on the toolbars.
2022-01-17 11:55:55 +00:00
.Check( cond.ZoneDisplayMode( ZONE_DISPLAY_MODE::SHOW_ZONE_OUTLINE ) ) );
Move zone fracture display mode to AdvancedCfg, and add triangulation. Fixes https://gitlab.com/kicad/code/kicad/issues/8762
2021-07-26 17:56:11 +00:00
mgr->SetConditions( PCB_ACTIONS::zoneDisplayFractured,
Cleanup.
2023-06-12 10:14:27 +00:00
ENABLE( enableZoneControlCondition )
Move show-bounding-boxes to a tool on the toolbars.
2022-01-17 11:55:55 +00:00
.Check( cond.ZoneDisplayMode( ZONE_DISPLAY_MODE::SHOW_FRACTURE_BORDERS ) ) );
Move zone fracture display mode to AdvancedCfg, and add triangulation. Fixes https://gitlab.com/kicad/code/kicad/issues/8762
2021-07-26 17:56:11 +00:00
mgr->SetConditions( PCB_ACTIONS::zoneDisplayTriangulated,
Cleanup.
2023-06-12 10:14:27 +00:00
ENABLE( enableZoneControlCondition )
Move show-bounding-boxes to a tool on the toolbars.
2022-01-17 11:55:55 +00:00
.Check( cond.ZoneDisplayMode( ZONE_DISPLAY_MODE::SHOW_TRIANGULATION ) ) );
mgr->SetConditions( ACTIONS::toggleBoundingBoxes, CHECK( cond.BoundingBoxes() ) );
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
auto constrainedDrawingModeCond =
[this]( const SELECTION& )
{
return GetPcbNewSettings()->m_Use45DegreeLimit;
};
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
auto boardFlippedCond =
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
[this]( const SELECTION& )
{
Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.
2023-06-12 11:38:50 +00:00
return GetCanvas() && GetCanvas()->GetView()->IsMirroredX();
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
};
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
auto layerManagerCond =
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
[this] ( const SELECTION& )
{
return LayerManagerShown();
};
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
Properties panel: post-rebase fixes and hide by default Remove layer widget re-added by Orson's rebase
2020-10-19 01:57:18 +00:00
auto propertiesCond =
Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.
2023-06-12 11:38:50 +00:00
[this] ( const SELECTION& )
{
return PropertiesShown();
};
Properties panel: post-rebase fixes and hide by default Remove layer widget re-added by Orson's rebase
2020-10-19 01:57:18 +00:00
Manage the Search panel visibility state in view menu. Fixes #12533 https://gitlab.com/kicad/code/kicad/issues/12533
2022-10-02 08:20:26 +00:00
auto searchPaneCond =
Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.
2023-06-12 11:38:50 +00:00
[this] ( const SELECTION& )
{
return m_auimgr.GetPane( SearchPaneName() ).IsShown();
};
Manage the Search panel visibility state in view menu. Fixes #12533 https://gitlab.com/kicad/code/kicad/issues/12533
2022-10-02 08:20:26 +00:00
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
auto highContrastCond =
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
[this] ( const SELECTION& )
{
return GetDisplayOptions().m_ContrastModeDisplay != HIGH_CONTRAST_MODE::NORMAL;
};
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
auto globalRatsnestCond =
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
[this] (const SELECTION& )
{
Remove bad static_cast. (m_settings isn't a PCBNEW_SETTINGS in non-PCB_EDIT_FRAMEs)
2022-07-24 15:49:46 +00:00
return GetPcbNewSettings()->m_Display.m_ShowGlobalRatsnest;
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
};
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
auto curvedRatsnestCond =
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
[this] (const SELECTION& )
{
Remove bad static_cast. (m_settings isn't a PCBNEW_SETTINGS in non-PCB_EDIT_FRAMEs)
2022-07-24 15:49:46 +00:00
return GetPcbNewSettings()->m_Display.m_DisplayRatsnestLinesCurved;
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
};
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
CHANGED: Net highlight in PcbNew is now persistent to match Eeschema CHANGED: Highlight net tool changed to highlight display toggle; moved to left toolbar CHANGED: Multi-net highlight is now accessible when using the highlight net action ADDED: Highlight Net and Clear Highlight actions to Net Tools context menu ADDED: Default hotkey (Ctrl+`) for toggling net highlighting The current and previous net highlight state are now stored and can be toggled on or off with an action (no hotkey by default). Highlight is now treated as a persistent state rather than a tool that is entered, meaning there is no longer a special tool to enter in order to highlight nets. Highlighting can be controlled while any other tool is active using the hotkeys or context menu on a net object. Tweak the icons for highlight net and layer display mode to better disambiguate them. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8250
2021-05-29 15:53:55 +00:00
auto netHighlightCond =
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
[this]( const SELECTION& )
{
KIGFX::RENDER_SETTINGS* settings = GetCanvas()->GetView()->GetPainter()->GetSettings();
return !settings->GetHighlightNetCodes().empty();
};
CHANGED: Net highlight in PcbNew is now persistent to match Eeschema CHANGED: Highlight net tool changed to highlight display toggle; moved to left toolbar CHANGED: Multi-net highlight is now accessible when using the highlight net action ADDED: Highlight Net and Clear Highlight actions to Net Tools context menu ADDED: Default hotkey (Ctrl+`) for toggling net highlighting The current and previous net highlight state are now stored and can be toggled on or off with an action (no hotkey by default). Highlight is now treated as a persistent state rather than a tool that is entered, meaning there is no longer a special tool to enter in order to highlight nets. Highlighting can be controlled while any other tool is active using the hotkeys or context menu on a net object. Tweak the icons for highlight net and layer display mode to better disambiguate them. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8250
2021-05-29 15:53:55 +00:00
auto enableNetHighlightCond =
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
[this]( const SELECTION& )
{
BOARD_INSPECTION_TOOL* tool = m_toolManager->GetTool<BOARD_INSPECTION_TOOL>();
Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.
2023-06-12 11:38:50 +00:00
return tool && tool->IsNetHighlightSet();
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
};
CHANGED: Net highlight in PcbNew is now persistent to match Eeschema CHANGED: Highlight net tool changed to highlight display toggle; moved to left toolbar CHANGED: Multi-net highlight is now accessible when using the highlight net action ADDED: Highlight Net and Clear Highlight actions to Net Tools context menu ADDED: Default hotkey (Ctrl+`) for toggling net highlighting The current and previous net highlight state are now stored and can be toggled on or off with an action (no hotkey by default). Highlight is now treated as a persistent state rather than a tool that is entered, meaning there is no longer a special tool to enter in order to highlight nets. Highlighting can be controlled while any other tool is active using the hotkeys or context menu on a net object. Tweak the icons for highlight net and layer display mode to better disambiguate them. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8250
2021-05-29 15:53:55 +00:00
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
mgr->SetConditions( PCB_ACTIONS::toggleHV45Mode, CHECK( constrainedDrawingModeCond ) );
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
mgr->SetConditions( ACTIONS::highContrastMode, CHECK( highContrastCond ) );
mgr->SetConditions( PCB_ACTIONS::flipBoard, CHECK( boardFlippedCond ) );
mgr->SetConditions( PCB_ACTIONS::showLayersManager, CHECK( layerManagerCond ) );
mgr->SetConditions( PCB_ACTIONS::showRatsnest, CHECK( globalRatsnestCond ) );
mgr->SetConditions( PCB_ACTIONS::ratsnestLineMode, CHECK( curvedRatsnestCond ) );
Move show-bounding-boxes to a tool on the toolbars.
2022-01-17 11:55:55 +00:00
mgr->SetConditions( PCB_ACTIONS::toggleNetHighlight, CHECK( netHighlightCond )
.Enable( enableNetHighlightCond ) );
Properties panel: post-rebase fixes and hide by default Remove layer widget re-added by Orson's rebase
2020-10-19 01:57:18 +00:00
mgr->SetConditions( PCB_ACTIONS::showProperties, CHECK( propertiesCond ) );
Manage the Search panel visibility state in view menu. Fixes #12533 https://gitlab.com/kicad/code/kicad/issues/12533
2022-10-02 08:20:26 +00:00
mgr->SetConditions( PCB_ACTIONS::showSearch, CHECK( searchPaneCond ) );
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.
2023-06-12 11:38:50 +00:00
auto isArcKeepCenterMode =
[this]( const SELECTION& )
{
return GetPcbNewSettings()->m_ArcEditMode == ARC_EDIT_MODE::KEEP_CENTER_ADJUST_ANGLE_RADIUS;
};
Expose changing arc edit mode in arc button context menu and Preferences Ctrl+Space can still be used to cycle through modes. Fixes https://gitlab.com/kicad/code/kicad/issues/5412
2022-12-05 18:27:00 +00:00
Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.
2023-06-12 11:38:50 +00:00
auto isArcKeepEndpointMode =
[this]( const SELECTION& )
{
return GetPcbNewSettings()->m_ArcEditMode == ARC_EDIT_MODE::KEEP_ENDPOINTS_OR_START_DIRECTION;
};
Expose changing arc edit mode in arc button context menu and Preferences Ctrl+Space can still be used to cycle through modes. Fixes https://gitlab.com/kicad/code/kicad/issues/5412
2022-12-05 18:27:00 +00:00
mgr->SetConditions( PCB_ACTIONS::pointEditorArcKeepCenter, CHECK( isArcKeepCenterMode ) );
mgr->SetConditions( PCB_ACTIONS::pointEditorArcKeepEndpoint, CHECK( isArcKeepEndpointMode ) );
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
auto isHighlightMode =
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
[this]( const SELECTION& )
{
ROUTER_TOOL* tool = m_toolManager->GetTool<ROUTER_TOOL>();
Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.
2023-06-12 11:38:50 +00:00
return tool && tool->GetRouterMode() == PNS::RM_MarkObstacles;
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
};
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
auto isShoveMode =
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
[this]( const SELECTION& )
{
ROUTER_TOOL* tool = m_toolManager->GetTool<ROUTER_TOOL>();
Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.
2023-06-12 11:38:50 +00:00
return tool && tool->GetRouterMode() == PNS::RM_Shove;
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
};
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
auto isWalkaroundMode =
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
[this]( const SELECTION& )
{
ROUTER_TOOL* tool = m_toolManager->GetTool<ROUTER_TOOL>();
Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.
2023-06-12 11:38:50 +00:00
return tool && tool->GetRouterMode() == PNS::RM_Walkaround;
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
};
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
mgr->SetConditions( PCB_ACTIONS::routerHighlightMode, CHECK( isHighlightMode ) );
mgr->SetConditions( PCB_ACTIONS::routerShoveMode, CHECK( isShoveMode ) );
mgr->SetConditions( PCB_ACTIONS::routerWalkaroundMode, CHECK( isWalkaroundMode ) );
Consolidate some UI conditions from context menu enabling These conditions are for enabling/disabling a control, so place them inside the new UI conditions framework instead of the separate update routine.
2020-08-17 22:21:25 +00:00
auto haveNetCond =
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
[] ( const SELECTION& aSel )
Consolidate some UI conditions from context menu enabling These conditions are for enabling/disabling a control, so place them inside the new UI conditions framework instead of the separate update routine.
2020-08-17 22:21:25 +00:00
{
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
for( EDA_ITEM* item : aSel )
Consolidate some UI conditions from context menu enabling These conditions are for enabling/disabling a control, so place them inside the new UI conditions framework instead of the separate update routine.
2020-08-17 22:21:25 +00:00
{
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
if( BOARD_CONNECTED_ITEM* bci = dynamic_cast<BOARD_CONNECTED_ITEM*>( item ) )
{
if( bci->GetNetCode() > 0 )
return true;
}
Consolidate some UI conditions from context menu enabling These conditions are for enabling/disabling a control, so place them inside the new UI conditions framework instead of the separate update routine.
2020-08-17 22:21:25 +00:00
}
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
return false;
};
Consolidate some UI conditions from context menu enabling These conditions are for enabling/disabling a control, so place them inside the new UI conditions framework instead of the separate update routine.
2020-08-17 22:21:25 +00:00
ADDED netclass assignment from PCB canvas. Fixes https://gitlab.com/kicad/code/kicad/issues/5975
2022-09-03 18:29:02 +00:00
mgr->SetConditions( PCB_ACTIONS::showNetInRatsnest, ENABLE( haveNetCond ) );
mgr->SetConditions( PCB_ACTIONS::hideNetInRatsnest, ENABLE( haveNetCond ) );
Fix net highlight command enablement. These always need to be enabled so that the current highlight can be cleared. Fixes https://gitlab.com/kicad/code/kicad/issues/12058
2022-07-23 11:41:35 +00:00
mgr->SetConditions( PCB_ACTIONS::highlightNet, ENABLE( SELECTION_CONDITIONS::ShowAlways ) );
mgr->SetConditions( PCB_ACTIONS::highlightNetSelection, ENABLE( SELECTION_CONDITIONS::ShowAlways ) );
Consolidate some UI conditions from context menu enabling These conditions are for enabling/disabling a control, so place them inside the new UI conditions framework instead of the separate update routine.
2020-08-17 22:21:25 +00:00
mgr->SetConditions( PCB_ACTIONS::selectNet,
Move KICAD_T[] to std::initializer_list<KICAD_T>.
2022-08-20 09:27:35 +00:00
ENABLE( SELECTION_CONDITIONS::OnlyTypes( { PCB_TRACE_T, PCB_ARC_T, PCB_VIA_T } ) ) );
ADDED: Deselect net action You can now deselect nets and netclasses (i.e. remove them from the active selection) via the context menus in the appearance panel
2020-09-16 23:09:12 +00:00
mgr->SetConditions( PCB_ACTIONS::deselectNet,
Move KICAD_T[] to std::initializer_list<KICAD_T>.
2022-08-20 09:27:35 +00:00
ENABLE( SELECTION_CONDITIONS::OnlyTypes( { PCB_TRACE_T, PCB_ARC_T, PCB_VIA_T } ) ) );
PCB: Select Unconnected Selects the all unconnected items for each selected routable item.
2022-09-20 13:35:47 +00:00
mgr->SetConditions( PCB_ACTIONS::selectUnconnected,
ENABLE( SELECTION_CONDITIONS::OnlyTypes( { PCB_FOOTPRINT_T, PCB_PAD_T, PCB_TRACE_T, PCB_ARC_T, PCB_VIA_T } ) ) );
Consolidate some UI conditions from context menu enabling These conditions are for enabling/disabling a control, so place them inside the new UI conditions framework instead of the separate update routine.
2020-08-17 22:21:25 +00:00
mgr->SetConditions( PCB_ACTIONS::selectSameSheet,
Move KICAD_T[] to std::initializer_list<KICAD_T>.
2022-08-20 09:27:35 +00:00
ENABLE( SELECTION_CONDITIONS::OnlyTypes( { PCB_FOOTPRINT_T } ) ) );
Cross-probing/selection for multiple items (PCB -> SCH) Fixes https://gitlab.com/kicad/code/kicad/issues/10469
2022-07-19 15:00:35 +00:00
mgr->SetConditions( PCB_ACTIONS::selectOnSchematic,
ENABLE( SELECTION_CONDITIONS::HasTypes( { PCB_PAD_T, PCB_FOOTPRINT_T, PCB_GROUP_T } ) ) );
Consolidate some UI conditions from context menu enabling These conditions are for enabling/disabling a control, so place them inside the new UI conditions framework instead of the separate update routine.
2020-08-17 22:21:25 +00:00
Error messages for zone merging. Also fixes a bug where zones meeting at a point would get merged resulting in a self-intersecting zone. Also fixes a bug where undo would not be handled correctly when zones could not be merged. Fixes https://gitlab.com/kicad/code/kicad/issues/10466
2022-01-21 19:54:54 +00:00
SELECTION_CONDITION singleZoneCond = SELECTION_CONDITIONS::Count( 1 )
Collapse FP_* down into their PCB_* equivalents.
2023-03-30 11:49:23 +00:00
&& SELECTION_CONDITIONS::OnlyTypes( { PCB_ZONE_T } );
Consolidate some UI conditions from context menu enabling These conditions are for enabling/disabling a control, so place them inside the new UI conditions framework instead of the separate update routine.
2020-08-17 22:21:25 +00:00
Error messages for zone merging. Also fixes a bug where zones meeting at a point would get merged resulting in a self-intersecting zone. Also fixes a bug where undo would not be handled correctly when zones could not be merged. Fixes https://gitlab.com/kicad/code/kicad/issues/10466
2022-01-21 19:54:54 +00:00
SELECTION_CONDITION zoneMergeCond = SELECTION_CONDITIONS::MoreThan( 1 )
Collapse FP_* down into their PCB_* equivalents.
2023-03-30 11:49:23 +00:00
&& SELECTION_CONDITIONS::OnlyTypes( { PCB_ZONE_T } );
Consolidate some UI conditions from context menu enabling These conditions are for enabling/disabling a control, so place them inside the new UI conditions framework instead of the separate update routine.
2020-08-17 22:21:25 +00:00
Prepare for a more uniform implementation of H/V/45 mode.
2022-05-29 13:16:13 +00:00
mgr->SetConditions( PCB_ACTIONS::zoneDuplicate, ENABLE( singleZoneCond ) );
mgr->SetConditions( PCB_ACTIONS::drawZoneCutout, ENABLE( singleZoneCond ) );
Consolidate some UI conditions from context menu enabling These conditions are for enabling/disabling a control, so place them inside the new UI conditions framework instead of the separate update routine.
2020-08-17 22:21:25 +00:00
mgr->SetConditions( PCB_ACTIONS::drawSimilarZone, ENABLE( singleZoneCond ) );
Prepare for a more uniform implementation of H/V/45 mode.
2022-05-29 13:16:13 +00:00
mgr->SetConditions( PCB_ACTIONS::zoneMerge, ENABLE( zoneMergeCond ) );
Consolidate some UI conditions from context menu enabling These conditions are for enabling/disabling a control, so place them inside the new UI conditions framework instead of the separate update routine.
2020-08-17 22:21:25 +00:00
Prepare for a more uniform implementation of H/V/45 mode.
2022-05-29 13:16:13 +00:00
mgr->SetConditions( PCB_ACTIONS::toggleHV45Mode, CHECK( cond.Get45degMode() ) );
Add "Limit graphic lines to 45 deg" to line drawing tool context menu Fixes https://gitlab.com/kicad/code/kicad/issues/7181
2021-02-05 23:43:32 +00:00
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
#define CURRENT_TOOL( action ) mgr->SetConditions( action, CHECK( cond.CurrentTool( action ) ) )
Disable editing tools on the canvas when DRC is running
2020-09-21 19:39:46 +00:00
// These tools can be used at any time to inspect the board
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
CURRENT_TOOL( ACTIONS::zoomTool );
CURRENT_TOOL( ACTIONS::measureTool );
CURRENT_TOOL( ACTIONS::selectionTool );
CURRENT_TOOL( PCB_ACTIONS::localRatsnestTool );
Disable editing tools on the canvas when DRC is running
2020-09-21 19:39:46 +00:00
Cleanup.
2023-06-12 10:14:27 +00:00
auto isDRCIdle =
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
[this] ( const SELECTION& )
{
DRC_TOOL* tool = m_toolManager->GetTool<DRC_TOOL>();
Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.
2023-06-12 11:38:50 +00:00
return !( tool && tool->IsDRCRunning() );
Move H/V/45 mode from zone properties to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/8587
2022-05-29 20:28:10 +00:00
};
Disable editing tools on the canvas when DRC is running
2020-09-21 19:39:46 +00:00
Cleanup.
2023-06-12 10:14:27 +00:00
#define CURRENT_EDIT_TOOL( action ) \
mgr->SetConditions( action, ACTION_CONDITIONS().Check( cond.CurrentTool( action ) ) \
.Enable( isDRCIdle ) )
Disable editing tools on the canvas when DRC is running
2020-09-21 19:39:46 +00:00
// These tools edit the board, so they must be disabled during some operations
CURRENT_EDIT_TOOL( ACTIONS::deleteTool );
Fix a missed Module -> Footprint.
2021-01-25 13:58:30 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::placeFootprint );
Disable editing tools on the canvas when DRC is running
2020-09-21 19:39:46 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::routeSingleTrack);
Add length tuning menu to vertical pcb toolbar
2021-05-07 13:44:47 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::routeDiffPair );
Separate actions for single track and differential pair length tuning.
2024-02-08 14:21:28 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::tuneSingleTrack);
CURRENT_EDIT_TOOL( PCB_ACTIONS::tuneDiffPair );
Retire length tuning tool in favour of first-class meanders.
2023-10-11 16:10:48 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::tuneSkew );
Disable editing tools on the canvas when DRC is running
2020-09-21 19:39:46 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::drawVia );
CURRENT_EDIT_TOOL( PCB_ACTIONS::drawZone );
Rename "Keepout" to "Rule Area" These objects can now be used in advanced DRC rules and not just for keeping things out. Also remove the restriction that at least one of the "basic" keepout rules must be set, so that these areas can be used for more advanced rules.
2020-09-21 23:32:07 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::drawRuleArea );
Disable editing tools on the canvas when DRC is running
2020-09-21 19:39:46 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::drawLine );
CURRENT_EDIT_TOOL( PCB_ACTIONS::drawRectangle );
CURRENT_EDIT_TOOL( PCB_ACTIONS::drawCircle );
CURRENT_EDIT_TOOL( PCB_ACTIONS::drawArc );
CURRENT_EDIT_TOOL( PCB_ACTIONS::drawPolygon );
Functionally it's a "reference image". The implementation happens to be a "bitmap". Fixes https://gitlab.com/kicad/code/kicad/-/issues/15932
2023-10-23 17:23:24 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::placeReferenceImage );
Disable editing tools on the canvas when DRC is running
2020-09-21 19:39:46 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::placeText );
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::drawTextBox );
Disable editing tools on the canvas when DRC is running
2020-09-21 19:39:46 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::drawAlignedDimension );
ADDED: Orthogonal dimension object
2020-09-22 02:32:40 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::drawOrthogonalDimension );
Disable editing tools on the canvas when DRC is running
2020-09-21 19:39:46 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::drawCenterDimension );
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::drawRadialDimension );
Disable editing tools on the canvas when DRC is running
2020-09-21 19:39:46 +00:00
CURRENT_EDIT_TOOL( PCB_ACTIONS::drawLeader );
CURRENT_EDIT_TOOL( PCB_ACTIONS::drillOrigin );
CURRENT_EDIT_TOOL( PCB_ACTIONS::gridSetOrigin );
CURRENT_EDIT_TOOL( PCB_ACTIONS::microwaveCreateLine );
CURRENT_EDIT_TOOL( PCB_ACTIONS::microwaveCreateGap );
CURRENT_EDIT_TOOL( PCB_ACTIONS::microwaveCreateStub );
CURRENT_EDIT_TOOL( PCB_ACTIONS::microwaveCreateStubArc );
CURRENT_EDIT_TOOL( PCB_ACTIONS::microwaveCreateFunctionShape );
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
#undef CURRENT_TOOL
Disable editing tools on the canvas when DRC is running
2020-09-21 19:39:46 +00:00
#undef CURRENT_EDIT_TOOL
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
#undef ENABLE
#undef CHECK
}
Move quit back to wxIDs. wxWidgets like to muck around with the location on OSX.
2019-05-26 22:22:03 +00:00
void PCB_EDIT_FRAME::OnQuit( wxCommandEvent& event )
{
Update exit strategy to match UI guidelines In singletop mode, all frames show the "Quit" option in the file menu and will quit on Ctrl-Q. When launched from the main KiCad interface, sub-programs show the "Close" option instead and will close with Ctrl-W. In this mode, Ctrl-Q will instruct the main program to exit. Fixes: lp:1779938 * https://bugs.launchpad.net/kicad/+bug/1779938
2019-06-25 04:44:34 +00:00
if( event.GetId() == wxID_EXIT )
Kiway().OnKiCadExit();
if( event.GetId() == wxID_CLOSE || Kiface().IsSingle() )
Close( false );
Move quit back to wxIDs. wxWidgets like to muck around with the location on OSX.
2019-05-26 22:22:03 +00:00
}
Update DRC exclusions model to match terminology. DRC exclusions were originally written following the C++ pragma model (ie: allow this violation here). However, the "exclusion" terminology we used in the GUI suggests a model model where the exclusions go away when the violation no longer exists. Fixes https://gitlab.com/kicad/code/kicad/issues/14351
2023-04-15 09:54:53 +00:00
void PCB_EDIT_FRAME::ResolveDRCExclusions( bool aCreateMarkers )
Add user-defined severities, exclusions and colors to DRC markers. Exclusions are currently persisted in the project file. Fixes https://gitlab.com/kicad/code/kicad/issues/1989
2020-02-28 00:05:40 +00:00
{
BOARD_COMMIT commit( this );
Update DRC exclusions model to match terminology. DRC exclusions were originally written following the C++ pragma model (ie: allow this violation here). However, the "exclusion" terminology we used in the GUI suggests a model model where the exclusions go away when the violation no longer exists. Fixes https://gitlab.com/kicad/code/kicad/issues/14351
2023-04-15 09:54:53 +00:00
for( PCB_MARKER* marker : GetBoard()->ResolveDRCExclusions( aCreateMarkers ) )
Introduce new marker type so we can track DRC errors on the drawing sheet. Fixes https://gitlab.com/kicad/code/kicad/issues/12221
2022-08-15 16:59:34 +00:00
{
if( marker->GetMarkerType() == MARKER_BASE::MARKER_DRAWING_SHEET )
marker->GetRCItem()->SetItems( GetCanvas()->GetDrawingSheet() );
Update marker view when setting excluded. Fixes https://gitlab.com/kicad/code/kicad/issues/6254
2020-11-02 20:03:23 +00:00
commit.Add( marker );
Introduce new marker type so we can track DRC errors on the drawing sheet. Fixes https://gitlab.com/kicad/code/kicad/issues/12221
2022-08-15 16:59:34 +00:00
}
Add user-defined severities, exclusions and colors to DRC markers. Exclusions are currently persisted in the project file. Fixes https://gitlab.com/kicad/code/kicad/issues/1989
2020-02-28 00:05:40 +00:00
More safety around ratsnest state. Fixes https://gitlab.com/kicad/code/kicad/issues/13011
2022-11-30 12:18:58 +00:00
commit.Push( wxEmptyString, SKIP_UNDO | SKIP_SET_DIRTY );
Update marker view when setting excluded. Fixes https://gitlab.com/kicad/code/kicad/issues/6254
2020-11-02 20:03:23 +00:00
Naming conventions.
2020-11-14 18:11:28 +00:00
for( PCB_MARKER* marker : GetBoard()->Markers() )
Update marker view when setting excluded. Fixes https://gitlab.com/kicad/code/kicad/issues/6254
2020-11-02 20:03:23 +00:00
{
Custom rule severities. ADDED severity token to custom rule syntax. Each rule can now define its own severity. Fixes https://gitlab.com/kicad/code/kicad/issues/6148
2021-09-05 15:06:12 +00:00
if( marker->GetSeverity() == RPT_SEVERITY_EXCLUSION )
Remove DRC exclusions that no longer have items. Fixes https://gitlab.com/kicad/code/kicad/issues/13802
2023-02-07 18:25:18 +00:00
GetCanvas()->GetView()->Update( marker );
Update marker view when setting excluded. Fixes https://gitlab.com/kicad/code/kicad/issues/6254
2020-11-02 20:03:23 +00:00
}
Move ratsnest exclusion processing to a post-pass. Also fixes a few cases where we were unnecessarily rebuilding connectivity more than once for an operation.
2022-09-29 16:07:42 +00:00
GetBoard()->UpdateRatsnestExclusions();
Add user-defined severities, exclusions and colors to DRC markers. Exclusions are currently persisted in the project file. Fixes https://gitlab.com/kicad/code/kicad/issues/1989
2020-02-28 00:05:40 +00:00
}
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
bool PCB_EDIT_FRAME::canCloseWindow( wxCloseEvent& aEvent )
add files not currently available in source (e.g. docs, modules, etc.) set svn:eol-style property to native for all ascii files to support cross platform development
2007-06-05 12:10:51 +00:00
{
Add shutdown blocking on Windows for pcbnew, eeschema and pleditor ADDED: Block shutdown/logoff on Windows when contents have been modified
2019-12-19 14:11:11 +00:00
// Shutdown blocks must be determined and vetoed as early as possible
Move shutdown blocker to kiplatform
2020-09-01 10:14:51 +00:00
if( KIPLATFORM::APP::SupportsShutdownBlockReason() && aEvent.GetId() == wxEVT_QUERY_END_SESSION
&& IsContentModified() )
Add shutdown blocking on Windows for pcbnew, eeschema and pleditor ADDED: Block shutdown/logoff on Windows when contents have been modified
2019-12-19 14:11:11 +00:00
{
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
return false;
Add shutdown blocking on Windows for pcbnew, eeschema and pleditor ADDED: Block shutdown/logoff on Windows when contents have been modified
2019-12-19 14:11:11 +00:00
}
Don't allow quit while zone filler is running. Fixes https://gitlab.com/kicad/code/kicad/issues/13551
2023-01-16 15:07:24 +00:00
ZONE_FILLER_TOOL* zoneFillerTool = m_toolManager->GetTool<ZONE_FILLER_TOOL>();
if( zoneFillerTool->IsBusy() )
{
wxBell();
if( wxWindow* reporter = dynamic_cast<wxWindow*>( zoneFillerTool->GetProgressReporter() ) )
reporter->ShowWithEffect( wxSHOW_EFFECT_EXPAND );
return false;
}
Don't leave stranded symbols/footprints in editors when doc closes. Fixes https://gitlab.com/kicad/code/kicad/issues/10026
2021-12-22 14:27:38 +00:00
if( Kiface().IsSingle() )
{
auto* fpEditor = (FOOTPRINT_EDIT_FRAME*) Kiway().Player( FRAME_FOOTPRINT_EDITOR, false );
if( fpEditor && !fpEditor->Close() ) // Can close footprint editor?
return false;
auto* fpViewer = (FOOTPRINT_VIEWER_FRAME*) Kiway().Player( FRAME_FOOTPRINT_VIEWER, false );
if( fpViewer && !fpViewer->Close() ) // Can close footprint viewer?
return false;
Push most of DIALOG_CHOOSE_SYMBOL down into PANEL_SYMBOL_CHOOSER. Includes a dialog wrapper (DIALOG_SYMBOL_CHOOSER) and a frame wrapper (SYMBOL_CHOOSER_FRAME).
2023-09-28 13:09:45 +00:00
// FOOTPRINT_CHOOSER_FRAME is always modal so this shouldn't come up, but better safe than
// sorry.
auto* chooser = (FOOTPRINT_CHOOSER_FRAME*) Kiway().Player( FRAME_FOOTPRINT_CHOOSER, false );
Don't leave stranded symbols/footprints in editors when doc closes. Fixes https://gitlab.com/kicad/code/kicad/issues/10026
2021-12-22 14:27:38 +00:00
Push most of DIALOG_CHOOSE_SYMBOL down into PANEL_SYMBOL_CHOOSER. Includes a dialog wrapper (DIALOG_SYMBOL_CHOOSER) and a frame wrapper (SYMBOL_CHOOSER_FRAME).
2023-09-28 13:09:45 +00:00
if( chooser && !chooser->Close() ) // Can close footprint chooser?
Don't leave stranded symbols/footprints in editors when doc closes. Fixes https://gitlab.com/kicad/code/kicad/issues/10026
2021-12-22 14:27:38 +00:00
return false;
}
else
{
auto* fpEditor = (FOOTPRINT_EDIT_FRAME*) Kiway().Player( FRAME_FOOTPRINT_EDITOR, false );
if( fpEditor && fpEditor->IsCurrentFPFromBoard() )
{
if( !fpEditor->CanCloseFPFromBoard( true ) )
return false;
}
}
Unify unsaved changes detection logic in all frames Create an IsContentModified() function in each frame that provides if the content has been modified, and use that instead of always copying the checks.
2019-12-19 15:34:01 +00:00
if( IsContentModified() )
made m_CurrentItem private, beautification
2007-08-20 01:20:48 +00:00
{
Fix OSX button order issue in Unsaved Changes dialog. Also changes the presentation of the string when the checkbox appears so that the "Changes will be lost" warning isn't hidden by the turndown. This last part may require conditional compilation as it's undocumented. Lastly, regularizes the Unsaved Changes strings between the apps.
2019-06-17 15:59:39 +00:00
wxFileName fileName = GetBoard()->GetFileName();
Fix some problematic double-quotes.
2021-06-07 22:14:29 +00:00
wxString msg = _( "Save changes to '%s' before closing?" );
Fix button order and genralize Exit dialog so it can be shared more. This also fixes a bunch of bugs where an error during save would still close the window (rather than cancelling the close action). Fixes: lp:1785034 * https://bugs.launchpad.net/kicad/+bug/1785034
2018-08-01 23:06:12 +00:00
Fix OSX button order issue in Unsaved Changes dialog. Also changes the presentation of the string when the checkbox appears so that the "Changes will be lost" warning isn't hidden by the turndown. This last part may require conditional compilation as it's undocumented. Lastly, regularizes the Unsaved Changes strings between the apps.
2019-06-17 15:59:39 +00:00
if( !HandleUnsavedChanges( this, wxString::Format( msg, fileName.GetFullName() ),
Code style
2020-08-24 02:10:05 +00:00
[&]() -> bool
{
return Files_io_from_id( ID_SAVE_BOARD );
} ) )
made m_CurrentItem private, beautification
2007-08-20 01:20:48 +00:00
{
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
return false;
made m_CurrentItem private, beautification
2007-08-20 01:20:48 +00:00
}
}
3D preferences bug fixes. 1) Make sure prefs get saved when closing parent frame. 2) Add camera projection mode to settings. Fixes https://gitlab.com/kicad/code/kicad/issues/8110 Fixes https://gitlab.com/kicad/code/kicad/issues/8626
2021-06-17 11:21:06 +00:00
return PCB_BASE_EDIT_FRAME::canCloseWindow( aEvent );
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
}
Improve shutdown performance.
2020-08-21 18:12:51 +00:00
Eeschema: add schematic sheet page number. The groundwork has now been laid for per sheet instance data. Initially this only supports sheet page numbers but could be expanded to include other per sheet instance information. ADDED: Support for user defined schematic page numbers.
2020-10-18 20:30:37 +00:00
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
void PCB_EDIT_FRAME::doCloseWindow()
{
Remove more legacy editing code.
2019-05-27 16:16:54 +00:00
// On Windows 7 / 32 bits, on OpenGL mode only, Pcbnew crashes
// when closing this frame if a footprint was selected, and the footprint editor called
// to edit this footprint, and when closing pcbnew if this footprint is still selected
// See https://bugs.launchpad.net/kicad/+bug/1655858
// I think this is certainly a OpenGL event fired after frame deletion, so this workaround
// avoid the crash (JPC)
Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal.
2019-06-13 17:28:55 +00:00
GetCanvas()->SetEvtHandlerEnabled( false );
Workaround for this issue: Pcbnew crashes on exit in OpenGL display mode when a footprint on the board was edited in the fp editor Fixes: lp:1655858 https://bugs.launchpad.net/kicad/+bug/1655858
2017-01-17 12:16:16 +00:00
Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal.
2019-06-13 17:28:55 +00:00
GetCanvas()->StopDrawing();
Fixed freezing of GAL canvas if user chooses Cancel in the on close dialog..
2014-05-14 17:04:21 +00:00
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
// Clean up mode-less dialogs.
Unbind( EDA_EVT_CLOSE_DIALOG_BOOK_REPORTER,
&PCB_EDIT_FRAME::onCloseModelessBookReporterDialogs, this );
Unbind( EDA_EVT_CLOSE_NET_INSPECTOR_DIALOG, &PCB_EDIT_FRAME::onCloseNetInspectorDialog, this );
Unbind( EDA_EVT_UNITS_CHANGED, &PCB_EDIT_FRAME::onUnitsChanged, this );
wxWindow* open_dlg = wxWindow::FindWindowByName( DIALOG_DRC_WINDOW_NAME );
if( open_dlg )
open_dlg->Close( true );
if( m_findDialog )
{
m_findDialog->Destroy();
m_findDialog = nullptr;
}
if( m_inspectDrcErrorDlg )
{
m_inspectDrcErrorDlg->Destroy();
m_inspectDrcErrorDlg = nullptr;
}
if( m_inspectClearanceDlg )
{
m_inspectClearanceDlg->Destroy();
m_inspectClearanceDlg = nullptr;
}
if( m_inspectConstraintsDlg )
{
m_inspectConstraintsDlg->Destroy();
m_inspectConstraintsDlg = nullptr;
}
if( m_footprintDiffDlg )
{
m_footprintDiffDlg->Destroy();
m_footprintDiffDlg = nullptr;
}
if( m_netInspectorDlg )
{
RemoveBoardChangeListener( m_netInspectorDlg );
m_netInspectorDlg->Destroy();
m_netInspectorDlg = nullptr;
}
Pcbnew auto save improvements. * Factor auto save common code into base frame class so all frame windows can take advantage of the shiny new auto save goodness. * Use a timer instead of depending on mouse and keyboard events to trigger an auto save. * Check for auto save file when opening a board and ask user if they wish to use the auto save file or the last saved board file. * Protect all base frame public members.
2011-10-13 19:56:32 +00:00
// Delete the auto save file if it exists.
Script plotting patch
2012-08-29 16:59:50 +00:00
wxFileName fn = GetBoard()->GetFileName();
Pcbnew auto save improvements. * Factor auto save common code into base frame class so all frame windows can take advantage of the shiny new auto save goodness. * Use a timer instead of depending on mouse and keyboard events to trigger an auto save. * Check for auto save file when opening a board and ask user if they wish to use the auto save file or the last saved board file. * Protect all base frame public members.
2011-10-13 19:56:32 +00:00
Unify and correct Autosave functions Autosave was not working correctly, partly due to different implementations in eeschema and pcbnew and partly due to a mistaken refactor at some point during v5 development. This unifies the expected autosave prefix to _autosave- for both pcbnew and eeschema. It also unifies the expected suffix for the backup files to -bak. Fixes: lp:1820433 * https://bugs.launchpad.net/kicad/+bug/1820433
2019-03-18 12:22:33 +00:00
// Auto save file name is the normal file name prefixed with 'GetAutoSaveFilePrefix()'.
Pcbnew: fix several auto save file issues. * When Pcbnew is launched in the stand alone mode with no board file command line option, the project path is set to the current working directory. The user may not have write access to the current working directory which would cause the auto save to generate an error. If the user does not have write access to the current working directory, set the path to a platform specific temporary path that the user has write permission. * When Pcbnew is launched in the stand alone mode with no board file command line option, the default BOARD object has no file name. Set the file name to "noname.kicad_pcb" to fix incorrect auto save file name and set the path to the user's platform specific document folder. * Delete orphaned auto save files when closing without saving due to broken auto save file generation logic which prepended the file name with "$" rather than "_autosave-". * Fixes: lp:1596382
2016-08-11 19:13:47 +00:00
fn.SetName( GetAutoSaveFilePrefix() + fn.GetName() );
// When the auto save feature does not have write access to the board file path, it falls
// back to a platform specific user temporary file path.
if( !fn.IsOk() || !fn.IsDirWritable() )
fn.SetPath( wxFileName::GetTempDir() );
More wxString wide literals.
2022-02-04 22:44:59 +00:00
wxLogTrace( traceAutoSave, wxT( "Deleting auto save file <" ) + fn.GetFullPath() + wxT( ">" ) );
Pcbnew auto save improvements. * Factor auto save common code into base frame class so all frame windows can take advantage of the shiny new auto save goodness. * Use a timer instead of depending on mouse and keyboard events to trigger an auto save. * Check for auto save file when opening a board and ask user if they wish to use the auto save file or the last saved board file. * Protect all base frame public members.
2011-10-13 19:56:32 +00:00
// Remove the auto save file on a normal close of Pcbnew.
if( fn.FileExists() && !wxRemoveFile( fn.GetFullPath() ) )
Fix compatibility with older wxWidgets versions. Fix also a compil warning
2023-02-03 07:22:34 +00:00
{
The safety of running the event loop during doCloseWindow is debatable. (Possibly a fix for Sentry KICAD-7T.)
2023-01-24 10:28:53 +00:00
wxLogTrace( traceAutoSave, wxT( "The auto save file could not be removed!" ) );
Fix compatibility with older wxWidgets versions. Fix also a compil warning
2023-02-03 07:22:34 +00:00
}
Pcbnew auto save improvements. * Factor auto save common code into base frame class so all frame windows can take advantage of the shiny new auto save goodness. * Use a timer instead of depending on mouse and keyboard events to trigger an auto save. * Check for auto save file when opening a board and ask user if they wish to use the auto save file or the last saved board file. * Protect all base frame public members.
2011-10-13 19:56:32 +00:00
ADDED: Hide ratsnest for specific nets List of hidden nets stored in project local settings Hide/Show actions in context menu only for now, will add them to some more GUI places soon. Ref https://gitlab.com/kicad/code/kicad/-/issues/1951
2020-07-11 01:06:17 +00:00
// Make sure local settings are persisted
Move to requiring explicit action to save project settings
2023-03-04 19:25:07 +00:00
SaveProjectLocalSettings();
ADDED: Hide ratsnest for specific nets List of hidden nets stored in project local settings Hide/Show actions in context menu only for now, will add them to some more GUI places soon. Ref https://gitlab.com/kicad/code/kicad/-/issues/1951
2020-07-11 01:06:17 +00:00
Pcbnew: minor fix: avoid flicker in Layer Manager when closing Pcbnew. It was due to useless paint events during closing, on some platforms.
2018-10-03 07:46:17 +00:00
// Do not show the layer manager during closing to avoid flicker
// on some platforms (Windows) that generate useless redraw of items in
Fix source comment / documentation typos
2021-06-09 19:32:58 +00:00
// the Layer Manager
Pcbnew: minor fix: avoid flicker in Layer Manager when closing Pcbnew. It was due to useless paint events during closing, on some platforms.
2018-10-03 07:46:17 +00:00
if( m_show_layer_manager_tools )
WIP: Properties GUI
2020-02-04 08:40:25 +00:00
{
Some more wxS
2023-01-17 00:07:41 +00:00
m_auimgr.GetPane( wxS( "LayersManager" ) ).Show( false );
m_auimgr.GetPane( wxS( "TabbedPanel" ) ).Show( false );
WIP: Properties GUI
2020-02-04 08:40:25 +00:00
}
Pcbnew: minor fix: avoid flicker in Layer Manager when closing Pcbnew. It was due to useless paint events during closing, on some platforms.
2018-10-03 07:46:17 +00:00
Unlink board from project before close Fixes https://gitlab.com/kicad/code/kicad/-/issues/4876
2020-07-14 00:48:18 +00:00
// Unlink the old project if needed
GetBoard()->ClearProject();
Pcbnew: Fix a crash on exit when an item was previously deleted. Fix not working footprint exchange functions
2013-11-22 19:47:10 +00:00
// Delete board structs and undo/redo lists, to avoid crash on exit
// when deleting some structs (mainly in undo/redo lists) too late
pcbnew: ClearPcb() without queuing tools When exiting pcbnew, we only want to run the sections of ClearPcb that remove the old pcb data. We do not want to queue events that handle initializing a new pcb. These were caught after freeing memory in some cases, leading to segfaults. Fixes: lp:1831560 * https://bugs.launchpad.net/kicad/+bug/1831560
2019-06-02 02:27:17 +00:00
Clear_Pcb( false, true );
Pcbnew: Fix a crash on exit when an item was previously deleted. Fix not working footprint exchange functions
2013-11-22 19:47:10 +00:00
More comment translation and capitalization fixes.
2009-11-18 12:52:19 +00:00
// do not show the window because ScreenPcb will be deleted and we do not
// want any paint event
more about Netclasses work
2009-10-03 17:18:08 +00:00
Show( false );
Add EDA_BASE_FRAME::Show() and call SaveSettings() only from there for all derived wxFrames. Remove calls to SaveSettings() elsewhere.
2014-01-28 01:29:26 +00:00
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
PCB_BASE_EDIT_FRAME::doCloseWindow();
add files not currently available in source (e.g. docs, modules, etc.) set svn:eol-style property to native for all ascii files to support cross platform development
2007-06-05 12:10:51 +00:00
}
Remove some legacy cursor handling stuff.
2019-05-30 12:25:08 +00:00
void PCB_EDIT_FRAME::ActivateGalCanvas()
Added ratsnest for GAL
2013-11-25 15:50:03 +00:00
{
Remove some legacy cursor handling stuff.
2019-05-30 12:25:08 +00:00
PCB_BASE_EDIT_FRAME::ActivateGalCanvas();
Implement a new settings framework across all of KiCad CHANGED: Settings are now stored in versioned sub-directories ADDED: First-run dialog for migrating settings from a previous version CHANGED: Settings are now stored as JSON files instead of wxConfig-style INI files CHANGED: Color settings are now all stored in a separate settings file CHANGED: The symbol editor and footprint editor now have their own settings files CHANGED: Color settings are no longer exposed through BOARD object CHANGED: Page layout editor now uses Eeschema's color scheme Settings are now managed through a central SETTINGS_MANAGER held by PGM_BASE. Existing settings will be migrated from the wxConfig format on first run of each application. Per-application settings are now stored in one class for each application.
2020-01-13 01:44:19 +00:00
GetCanvas()->UpdateColors();
Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal.
2019-06-13 17:28:55 +00:00
GetCanvas()->Refresh();
Change from EDA_COLOR_T to COLOR4D globally; arbitrary color support eeschema now supports arbitrary colors for all object types, and pcbnew does in GAL canvas. When switching from GAL to legacy canvas, pcbnew will convert colors to the nearest legacy color.
2017-02-20 16:57:41 +00:00
}
Inform user of bad DRC rules when filling zones. ADDED: facility for hypertext links in infobar. Also made use of this for via constraint errors when routing. Fixes https://gitlab.com/kicad/code/kicad/issues/5800
2020-10-16 11:20:37 +00:00
void PCB_EDIT_FRAME::ShowBoardSetupDialog( const wxString& aInitialPage )
First work about net classes. This is a work in progress and a moving target
2009-07-18 11:44:19 +00:00
{
Prevent PCB Editor from opening multiple board_setup ShowBoardSetup can be called multiple times from multiple locations, resulting in duplicate board setup dialog boxes. This is confusing and should be prevented. We use the established patter from the symbol picker to ensure that only one copy of the dialog is ever opened at a time
2023-03-30 22:32:24 +00:00
std::unique_lock<std::mutex> dialogLock( DIALOG_BOARD_SETUP::g_Mutex, std::try_to_lock );
// One DIALOG_BOARD_SETUP dialog at a time.
if( !dialogLock.owns_lock() )
return;
Push panel_setup_netclasses down into common.
2020-07-03 22:30:23 +00:00
// Make sure everything's up-to-date
GetBoard()->BuildListOfNets();
Consolidate design rules UI. Implement new Board Setup paged dialog which includes: Layers Setup Design Rules Solder Mask & Paste Text & Drawings Moves line width and text properties to a layer-class-based system. Renames unlocked to upright (which also reverses the logic). New Edit Text and Graphic Properties dialog which replaces Edit Footprint Text and adds layer-class-based editing and the italic, upright and visibility properties. Adds Import Settings functionality which allows settings to be imported from another project at page granularity. Also UNIT_BINDERizes the dialog and adds editing of pcb text. Fixes: lp:1731952 * https://bugs.launchpad.net/kicad/+bug/1731952 Fixes: lp:1743464 * https://bugs.launchpad.net/kicad/+bug/1743464 Fixes: lp:1664761 * https://bugs.launchpad.net/kicad/+bug/1664761 Fixes: lp:1753362 * https://bugs.launchpad.net/kicad/+bug/1753362 Fixes: lp:1545427 * https://bugs.launchpad.net/kicad/+bug/1545427 Fixes: lp:1753775 * https://bugs.launchpad.net/kicad/+bug/1753775 Fixes: lp:1777692 * https://bugs.launchpad.net/kicad/+bug/1777692 Fixes: lp:1780670 * https://bugs.launchpad.net/kicad/+bug/1780670 Fixes: lp:1519601 * https://bugs.launchpad.net/kicad/+bug/1519601 (cherry picked from commit 3944a5e)
2018-04-28 15:22:25 +00:00
DIALOG_BOARD_SETUP dlg( this );
more about Netclasses work
2009-10-03 17:18:08 +00:00
Add shortcuts to setting dialogs for track widths, via sizes and grid sizes. Fixes: lp:1803671 * https://bugs.launchpad.net/kicad/+bug/1803671
2018-11-17 00:33:20 +00:00
if( !aInitialPage.IsEmpty() )
Better error reporting for DRC rule parsing.
2020-05-24 14:54:26 +00:00
dlg.SetInitialPage( aInitialPage, wxEmptyString );
Make the board setup window quasimodal By making it quasimodal, it allows the main KiCad window and Eeschema to be used still, if it were just modal then it blocks out all other windows. Fixes https://gitlab.com/kicad/code/kicad/issues/4023
2020-03-07 19:28:04 +00:00
if( dlg.ShowQuasiModal() == wxID_OK )
First work about net classes. This is a work in progress and a moving target
2009-07-18 11:44:19 +00:00
{
Re-resolve netclasses after assigning netclass to pattern. Fixes https://gitlab.com/kicad/code/kicad/issues/12965
2022-11-22 14:24:20 +00:00
GetBoard()->SynchronizeNetsAndNetClasses( true );
Move to requiring explicit action to save project settings
2023-03-04 19:25:07 +00:00
// We don't know if anything was modified, so err on the side of requiring a save
OnModify();
Consolidate design rules UI. Implement new Board Setup paged dialog which includes: Layers Setup Design Rules Solder Mask & Paste Text & Drawings Moves line width and text properties to a layer-class-based system. Renames unlocked to upright (which also reverses the logic). New Edit Text and Graphic Properties dialog which replaces Edit Footprint Text and adds layer-class-based editing and the italic, upright and visibility properties. Adds Import Settings functionality which allows settings to be imported from another project at page granularity. Also UNIT_BINDERizes the dialog and adds editing of pcb text. Fixes: lp:1731952 * https://bugs.launchpad.net/kicad/+bug/1731952 Fixes: lp:1743464 * https://bugs.launchpad.net/kicad/+bug/1743464 Fixes: lp:1664761 * https://bugs.launchpad.net/kicad/+bug/1664761 Fixes: lp:1753362 * https://bugs.launchpad.net/kicad/+bug/1753362 Fixes: lp:1545427 * https://bugs.launchpad.net/kicad/+bug/1545427 Fixes: lp:1753775 * https://bugs.launchpad.net/kicad/+bug/1753775 Fixes: lp:1777692 * https://bugs.launchpad.net/kicad/+bug/1777692 Fixes: lp:1780670 * https://bugs.launchpad.net/kicad/+bug/1780670 Fixes: lp:1519601 * https://bugs.launchpad.net/kicad/+bug/1519601 (cherry picked from commit 3944a5e)
2018-04-28 15:22:25 +00:00
Update text variables even when they're changed from other binary. For instance, you might have PCBNew open but change the variable value through EEschema > Schematic Setup. Fixes https://gitlab.com/kicad/code/kicad/issues/4918
2020-07-17 20:04:14 +00:00
Kiway().CommonSettingsChanged( false, true );
Refresh geometry when clearance changes if clearance lines are shown. Fixes https://gitlab.com/kicad/code/kicad/issues/7906
2021-03-16 11:41:21 +00:00
Implement changed notifiers for textvar, netclasses and severities. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15440
2023-09-17 14:49:46 +00:00
Prj().IncrementTextVarsTicker();
Prj().IncrementNetclassesTicker();
While flags are in prefs, actual clearance values are in board setup. Fixes https://gitlab.com/kicad/code/kicad/issues/10852
2022-02-15 21:59:46 +00:00
PCBNEW_SETTINGS* settings = GetPcbNewSettings();
Redraw pads when mask or paste layer is visible after board setup. Fixes https://gitlab.com/kicad/code/kicad/issues/11079
2022-03-10 17:52:50 +00:00
static LSET maskAndPasteLayers = LSET( 4, F_Mask, F_Paste, B_Mask, B_Paste );
Better cache invalidation for text objects with references. Fixes https://gitlab.com/kicad/code/kicad/issues/13059
2022-12-03 13:25:20 +00:00
GetCanvas()->GetView()->UpdateAllItemsConditionally(
[&]( KIGFX::VIEW_ITEM* aItem ) -> int
Update text variables when they change. Fixes https://gitlab.com/kicad/code/kicad/issues/10734
2022-02-04 00:12:59 +00:00
{
Redraw via mask layers when switching Tented Vias on/off. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15164
2023-07-10 22:15:17 +00:00
BOARD_ITEM* item = dynamic_cast<BOARD_ITEM*>( aItem );
int flags = 0;
if( !item )
return flags;
Redraw pads when mask or paste layer is visible after board setup. Fixes https://gitlab.com/kicad/code/kicad/issues/11079
2022-03-10 17:52:50 +00:00
Redraw via mask layers when switching Tented Vias on/off. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15164
2023-07-10 22:15:17 +00:00
if( item->Type() == PCB_VIA_T || item->Type() == PCB_PAD_T )
{
KIGFX::REPAINT is not enough if the item isn't in the view. Fixes https://gitlab.com/kicad/code/kicad/issues/11656 Fixes https://gitlab.com/kicad/code/kicad/issues/13217
2022-12-24 17:04:34 +00:00
// Note: KIGFX::REPAINT isn't enough for things that go from invisible
// to visible as they won't be found in the view layer's itemset for
// re-painting.
Tighten up refresh logic for net & netclass references. Also tightens it up a bit for text variables which can reference things like netnames and netclasses, but also board settings. Fixes https://gitlab.com/kicad/code/kicad/issues/13032
2022-11-29 15:17:38 +00:00
if( ( GetBoard()->GetVisibleLayers() & maskAndPasteLayers ).any() )
Redraw via mask layers when switching Tented Vias on/off. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15164
2023-07-10 22:15:17 +00:00
flags |= KIGFX::ALL;
}
if( item->Type() == PCB_TRACE_T || item->Type() == PCB_ARC_T || item->Type() == PCB_VIA_T )
{
if( settings->m_Display.m_TrackClearance == SHOW_WITH_VIA_ALWAYS )
flags |= KIGFX::REPAINT;
}
if( item->Type() == PCB_PAD_T )
{
if( settings->m_Display.m_PadClearance )
flags |= KIGFX::REPAINT;
While flags are in prefs, actual clearance values are in board setup. Fixes https://gitlab.com/kicad/code/kicad/issues/10852
2022-02-15 21:59:46 +00:00
}
Update text variables when they change. Fixes https://gitlab.com/kicad/code/kicad/issues/10734
2022-02-04 00:12:59 +00:00
Tighten up refresh logic for net & netclass references. Also tightens it up a bit for text variables which can reference things like netnames and netclasses, but also board settings. Fixes https://gitlab.com/kicad/code/kicad/issues/13032
2022-11-29 15:17:38 +00:00
EDA_TEXT* text = dynamic_cast<EDA_TEXT*>( aItem );
if( text && text->HasTextVars() )
Better cache invalidation for text objects with references. Fixes https://gitlab.com/kicad/code/kicad/issues/13059
2022-12-03 13:25:20 +00:00
{
text->ClearRenderCache();
text->ClearBoundingBoxCache();
Redraw via mask layers when switching Tented Vias on/off. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15164
2023-07-10 22:15:17 +00:00
flags |= KIGFX::GEOMETRY | KIGFX::REPAINT;
Better cache invalidation for text objects with references. Fixes https://gitlab.com/kicad/code/kicad/issues/13059
2022-12-03 13:25:20 +00:00
}
Tighten up refresh logic for net & netclass references. Also tightens it up a bit for text variables which can reference things like netnames and netclasses, but also board settings. Fixes https://gitlab.com/kicad/code/kicad/issues/13032
2022-11-29 15:17:38 +00:00
Redraw via mask layers when switching Tented Vias on/off. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15164
2023-07-10 22:15:17 +00:00
return flags;
Update text variables when they change. Fixes https://gitlab.com/kicad/code/kicad/issues/10734
2022-02-04 00:12:59 +00:00
} );
Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal.
2019-06-13 17:28:55 +00:00
GetCanvas()->Refresh();
Consolidate design rules UI. Implement new Board Setup paged dialog which includes: Layers Setup Design Rules Solder Mask & Paste Text & Drawings Moves line width and text properties to a layer-class-based system. Renames unlocked to upright (which also reverses the logic). New Edit Text and Graphic Properties dialog which replaces Edit Footprint Text and adds layer-class-based editing and the italic, upright and visibility properties. Adds Import Settings functionality which allows settings to be imported from another project at page granularity. Also UNIT_BINDERizes the dialog and adds editing of pcb text. Fixes: lp:1731952 * https://bugs.launchpad.net/kicad/+bug/1731952 Fixes: lp:1743464 * https://bugs.launchpad.net/kicad/+bug/1743464 Fixes: lp:1664761 * https://bugs.launchpad.net/kicad/+bug/1664761 Fixes: lp:1753362 * https://bugs.launchpad.net/kicad/+bug/1753362 Fixes: lp:1545427 * https://bugs.launchpad.net/kicad/+bug/1545427 Fixes: lp:1753775 * https://bugs.launchpad.net/kicad/+bug/1753775 Fixes: lp:1777692 * https://bugs.launchpad.net/kicad/+bug/1777692 Fixes: lp:1780670 * https://bugs.launchpad.net/kicad/+bug/1780670 Fixes: lp:1519601 * https://bugs.launchpad.net/kicad/+bug/1519601 (cherry picked from commit 3944a5e)
2018-04-28 15:22:25 +00:00
Refresh geometry when clearance changes if clearance lines are shown. Fixes https://gitlab.com/kicad/code/kicad/issues/7906
2021-03-16 11:41:21 +00:00
UpdateUserInterface();
ReCreateAuxiliaryToolbar();
Push panel_setup_netclasses down into common.
2020-07-03 22:30:23 +00:00
m_toolManager->ResetTools( TOOL_BASE::MODEL_RELOAD );
Consolidate design rules UI. Implement new Board Setup paged dialog which includes: Layers Setup Design Rules Solder Mask & Paste Text & Drawings Moves line width and text properties to a layer-class-based system. Renames unlocked to upright (which also reverses the logic). New Edit Text and Graphic Properties dialog which replaces Edit Footprint Text and adds layer-class-based editing and the italic, upright and visibility properties. Adds Import Settings functionality which allows settings to be imported from another project at page granularity. Also UNIT_BINDERizes the dialog and adds editing of pcb text. Fixes: lp:1731952 * https://bugs.launchpad.net/kicad/+bug/1731952 Fixes: lp:1743464 * https://bugs.launchpad.net/kicad/+bug/1743464 Fixes: lp:1664761 * https://bugs.launchpad.net/kicad/+bug/1664761 Fixes: lp:1753362 * https://bugs.launchpad.net/kicad/+bug/1753362 Fixes: lp:1545427 * https://bugs.launchpad.net/kicad/+bug/1545427 Fixes: lp:1753775 * https://bugs.launchpad.net/kicad/+bug/1753775 Fixes: lp:1777692 * https://bugs.launchpad.net/kicad/+bug/1777692 Fixes: lp:1780670 * https://bugs.launchpad.net/kicad/+bug/1780670 Fixes: lp:1519601 * https://bugs.launchpad.net/kicad/+bug/1519601 (cherry picked from commit 3944a5e)
2018-04-28 15:22:25 +00:00
//this event causes the routing tool to reload its design rules information
TOOL_EVENT toolEvent( TC_COMMAND, TA_MODEL_CHANGE, AS_ACTIVE );
Cleanup position handling for TOOL_EVENTs * Make the events generated by the selection of context menu items have the position where the menu was opened * Ensure that TC_COMMAND type events have their position set to be the cursor position where the event originated
2019-10-03 15:55:05 +00:00
toolEvent.SetHasPosition( false );
Consolidate design rules UI. Implement new Board Setup paged dialog which includes: Layers Setup Design Rules Solder Mask & Paste Text & Drawings Moves line width and text properties to a layer-class-based system. Renames unlocked to upright (which also reverses the logic). New Edit Text and Graphic Properties dialog which replaces Edit Footprint Text and adds layer-class-based editing and the italic, upright and visibility properties. Adds Import Settings functionality which allows settings to be imported from another project at page granularity. Also UNIT_BINDERizes the dialog and adds editing of pcb text. Fixes: lp:1731952 * https://bugs.launchpad.net/kicad/+bug/1731952 Fixes: lp:1743464 * https://bugs.launchpad.net/kicad/+bug/1743464 Fixes: lp:1664761 * https://bugs.launchpad.net/kicad/+bug/1664761 Fixes: lp:1753362 * https://bugs.launchpad.net/kicad/+bug/1753362 Fixes: lp:1545427 * https://bugs.launchpad.net/kicad/+bug/1545427 Fixes: lp:1753775 * https://bugs.launchpad.net/kicad/+bug/1753775 Fixes: lp:1777692 * https://bugs.launchpad.net/kicad/+bug/1777692 Fixes: lp:1780670 * https://bugs.launchpad.net/kicad/+bug/1780670 Fixes: lp:1519601 * https://bugs.launchpad.net/kicad/+bug/1519601 (cherry picked from commit 3944a5e)
2018-04-28 15:22:25 +00:00
m_toolManager->ProcessEvent( toolEvent );
First work about net classes. This is a work in progress and a moving target
2009-07-18 11:44:19 +00:00
}
Fix buttons in appearance panel in MSW Ensure we pass the focus back to the canvas when closing dialogs that might have been launched from the appearance panel Fixes https://gitlab.com/kicad/code/kicad/-/issues/5326
2020-08-23 19:42:20 +00:00
GetCanvas()->SetFocus();
First work about net classes. This is a work in progress and a moving target
2009-07-18 11:44:19 +00:00
}
Fix save last grid size and other minor updates. * Create single event handler for grid size events. * Fix all frame windows to use new grid size event handler. * Use offset relative to ID instead of ComboBox index to save last grid size. * Move last grid size load/save setting into WinEDA_DrawFrame. * Add equality and assignment operators the GRID_TYPE. * Add current grid helper methods to BASE_SCREEN. * Add GetPins helper to LIB_COMPONENT to replace GetNextPin where applicable. * Add AppendMsgPanel helper to WinEDA_DrawFrame. * Improve rounding for display of coordinates when millimeter units are selected.
2009-10-14 19:43:31 +00:00
Implement a new settings framework across all of KiCad CHANGED: Settings are now stored in versioned sub-directories ADDED: First-run dialog for migrating settings from a previous version CHANGED: Settings are now stored as JSON files instead of wxConfig-style INI files CHANGED: Color settings are now all stored in a separate settings file CHANGED: The symbol editor and footprint editor now have their own settings files CHANGED: Color settings are no longer exposed through BOARD object CHANGED: Page layout editor now uses Eeschema's color scheme Settings are now managed through a central SETTINGS_MANAGER held by PGM_BASE. Existing settings will be migrated from the wxConfig format on first run of each application. Per-application settings are now stored in one class for each application.
2020-01-13 01:44:19 +00:00
void PCB_EDIT_FRAME::LoadSettings( APP_SETTINGS_BASE* aCfg )
Fix save last grid size and other minor updates. * Create single event handler for grid size events. * Fix all frame windows to use new grid size event handler. * Use offset relative to ID instead of ComboBox index to save last grid size. * Move last grid size load/save setting into WinEDA_DrawFrame. * Add equality and assignment operators the GRID_TYPE. * Add current grid helper methods to BASE_SCREEN. * Add GetPins helper to LIB_COMPONENT to replace GetNextPin where applicable. * Add AppendMsgPanel helper to WinEDA_DrawFrame. * Improve rounding for display of coordinates when millimeter units are selected.
2009-10-14 19:43:31 +00:00
{
* KIWAY Milestone A): Make major modules into DLL/DSOs. ! The initial testing of this commit should be done using a Debug build so that all the wxASSERT()s are enabled. Also, be sure and keep enabled the USE_KIWAY_DLLs option. The tree won't likely build without it. Turning it off is senseless anyways. If you want stable code, go back to a prior version, the one tagged with "stable". * Relocate all functionality out of the wxApp derivative into more finely targeted purposes: a) DLL/DSO specific b) PROJECT specific c) EXE or process specific d) configuration file specific data e) configuration file manipulations functions. All of this functionality was blended into an extremely large wxApp derivative and that was incompatible with the desire to support multiple concurrently loaded DLL/DSO's ("KIFACE")s and multiple concurrently open projects. An amazing amount of organization come from simply sorting each bit of functionality into the proper box. * Switch to wxConfigBase from wxConfig everywhere except instantiation. * Add classes KIWAY, KIFACE, KIFACE_I, SEARCH_STACK, PGM_BASE, PGM_KICAD, PGM_SINGLE_TOP, * Remove "Return" prefix on many function names. * Remove obvious comments from CMakeLists.txt files, and from else() and endif()s. * Fix building boost for use in a DSO on linux. * Remove some of the assumptions in the CMakeLists.txt files that windows had to be the host platform when building windows binaries. * Reduce the number of wxStrings being constructed at program load time via static construction. * Pass wxConfigBase* to all SaveSettings() and LoadSettings() functions so that these functions are useful even when the wxConfigBase comes from another source, as is the case in the KICAD_MANAGER_FRAME. * Move the setting of the KIPRJMOD environment variable into class PROJECT, so that it can be moved into a project variable soon, and out of FP_LIB_TABLE. * Add the KIWAY_PLAYER which is associated with a particular PROJECT, and all its child wxFrames and wxDialogs now have a Kiway() member function which returns a KIWAY& that that window tree branch is in support of. This is like wxWindows DNA in that child windows get this member with proper value at time of construction. * Anticipate some of the needs for milestones B) and C) and make code adjustments now in an effort to reduce work in those milestones. * No testing has been done for python scripting, since milestone C) has that being largely reworked and re-thought-out.
2014-03-20 00:42:08 +00:00
PCB_BASE_FRAME::LoadSettings( aCfg );
Fix save last grid size and other minor updates. * Create single event handler for grid size events. * Fix all frame windows to use new grid size event handler. * Use offset relative to ID instead of ComboBox index to save last grid size. * Move last grid size load/save setting into WinEDA_DrawFrame. * Add equality and assignment operators the GRID_TYPE. * Add current grid helper methods to BASE_SCREEN. * Add GetPins helper to LIB_COMPONENT to replace GetNextPin where applicable. * Add AppendMsgPanel helper to WinEDA_DrawFrame. * Improve rounding for display of coordinates when millimeter units are selected.
2009-10-14 19:43:31 +00:00
Fixup some Coverity issues.
2020-03-21 16:31:48 +00:00
PCBNEW_SETTINGS* cfg = dynamic_cast<PCBNEW_SETTINGS*>( aCfg );
Implement a new settings framework across all of KiCad CHANGED: Settings are now stored in versioned sub-directories ADDED: First-run dialog for migrating settings from a previous version CHANGED: Settings are now stored as JSON files instead of wxConfig-style INI files CHANGED: Color settings are now all stored in a separate settings file CHANGED: The symbol editor and footprint editor now have their own settings files CHANGED: Color settings are no longer exposed through BOARD object CHANGED: Page layout editor now uses Eeschema's color scheme Settings are now managed through a central SETTINGS_MANAGER held by PGM_BASE. Existing settings will be migrated from the wxConfig format on first run of each application. Per-application settings are now stored in one class for each application.
2020-01-13 01:44:19 +00:00
wxASSERT( cfg );
* KIWAY Milestone A): Make major modules into DLL/DSOs. ! The initial testing of this commit should be done using a Debug build so that all the wxASSERT()s are enabled. Also, be sure and keep enabled the USE_KIWAY_DLLs option. The tree won't likely build without it. Turning it off is senseless anyways. If you want stable code, go back to a prior version, the one tagged with "stable". * Relocate all functionality out of the wxApp derivative into more finely targeted purposes: a) DLL/DSO specific b) PROJECT specific c) EXE or process specific d) configuration file specific data e) configuration file manipulations functions. All of this functionality was blended into an extremely large wxApp derivative and that was incompatible with the desire to support multiple concurrently loaded DLL/DSO's ("KIFACE")s and multiple concurrently open projects. An amazing amount of organization come from simply sorting each bit of functionality into the proper box. * Switch to wxConfigBase from wxConfig everywhere except instantiation. * Add classes KIWAY, KIFACE, KIFACE_I, SEARCH_STACK, PGM_BASE, PGM_KICAD, PGM_SINGLE_TOP, * Remove "Return" prefix on many function names. * Remove obvious comments from CMakeLists.txt files, and from else() and endif()s. * Fix building boost for use in a DSO on linux. * Remove some of the assumptions in the CMakeLists.txt files that windows had to be the host platform when building windows binaries. * Reduce the number of wxStrings being constructed at program load time via static construction. * Pass wxConfigBase* to all SaveSettings() and LoadSettings() functions so that these functions are useful even when the wxConfigBase comes from another source, as is the case in the KICAD_MANAGER_FRAME. * Move the setting of the KIPRJMOD environment variable into class PROJECT, so that it can be moved into a project variable soon, and out of FP_LIB_TABLE. * Add the KIWAY_PLAYER which is associated with a particular PROJECT, and all its child wxFrames and wxDialogs now have a Kiway() member function which returns a KIWAY& that that window tree branch is in support of. This is like wxWindows DNA in that child windows get this member with proper value at time of construction. * Anticipate some of the needs for milestones B) and C) and make code adjustments now in an effort to reduce work in those milestones. * No testing has been done for python scripting, since milestone C) has that being largely reworked and re-thought-out.
2014-03-20 00:42:08 +00:00
Fixup some Coverity issues.
2020-03-21 16:31:48 +00:00
if( cfg )
{
m_show_layer_manager_tools = cfg->m_AuiPanels.show_layer_manager;
Fix search panel not remembering visibility Fixes https://gitlab.com/kicad/code/kicad/-/issues/12494
2022-09-25 15:56:41 +00:00
m_show_search = cfg->m_AuiPanels.show_search;
Fixup some Coverity issues.
2020-03-21 16:31:48 +00:00
}
Fix save last grid size and other minor updates. * Create single event handler for grid size events. * Fix all frame windows to use new grid size event handler. * Use offset relative to ID instead of ComboBox index to save last grid size. * Move last grid size load/save setting into WinEDA_DrawFrame. * Add equality and assignment operators the GRID_TYPE. * Add current grid helper methods to BASE_SCREEN. * Add GetPins helper to LIB_COMPONENT to replace GetNextPin where applicable. * Add AppendMsgPanel helper to WinEDA_DrawFrame. * Improve rounding for display of coordinates when millimeter units are selected.
2009-10-14 19:43:31 +00:00
}
Implement a new settings framework across all of KiCad CHANGED: Settings are now stored in versioned sub-directories ADDED: First-run dialog for migrating settings from a previous version CHANGED: Settings are now stored as JSON files instead of wxConfig-style INI files CHANGED: Color settings are now all stored in a separate settings file CHANGED: The symbol editor and footprint editor now have their own settings files CHANGED: Color settings are no longer exposed through BOARD object CHANGED: Page layout editor now uses Eeschema's color scheme Settings are now managed through a central SETTINGS_MANAGER held by PGM_BASE. Existing settings will be migrated from the wxConfig format on first run of each application. Per-application settings are now stored in one class for each application.
2020-01-13 01:44:19 +00:00
void PCB_EDIT_FRAME::SaveSettings( APP_SETTINGS_BASE* aCfg )
Fix save last grid size and other minor updates. * Create single event handler for grid size events. * Fix all frame windows to use new grid size event handler. * Use offset relative to ID instead of ComboBox index to save last grid size. * Move last grid size load/save setting into WinEDA_DrawFrame. * Add equality and assignment operators the GRID_TYPE. * Add current grid helper methods to BASE_SCREEN. * Add GetPins helper to LIB_COMPONENT to replace GetNextPin where applicable. * Add AppendMsgPanel helper to WinEDA_DrawFrame. * Improve rounding for display of coordinates when millimeter units are selected.
2009-10-14 19:43:31 +00:00
{
* KIWAY Milestone A): Make major modules into DLL/DSOs. ! The initial testing of this commit should be done using a Debug build so that all the wxASSERT()s are enabled. Also, be sure and keep enabled the USE_KIWAY_DLLs option. The tree won't likely build without it. Turning it off is senseless anyways. If you want stable code, go back to a prior version, the one tagged with "stable". * Relocate all functionality out of the wxApp derivative into more finely targeted purposes: a) DLL/DSO specific b) PROJECT specific c) EXE or process specific d) configuration file specific data e) configuration file manipulations functions. All of this functionality was blended into an extremely large wxApp derivative and that was incompatible with the desire to support multiple concurrently loaded DLL/DSO's ("KIFACE")s and multiple concurrently open projects. An amazing amount of organization come from simply sorting each bit of functionality into the proper box. * Switch to wxConfigBase from wxConfig everywhere except instantiation. * Add classes KIWAY, KIFACE, KIFACE_I, SEARCH_STACK, PGM_BASE, PGM_KICAD, PGM_SINGLE_TOP, * Remove "Return" prefix on many function names. * Remove obvious comments from CMakeLists.txt files, and from else() and endif()s. * Fix building boost for use in a DSO on linux. * Remove some of the assumptions in the CMakeLists.txt files that windows had to be the host platform when building windows binaries. * Reduce the number of wxStrings being constructed at program load time via static construction. * Pass wxConfigBase* to all SaveSettings() and LoadSettings() functions so that these functions are useful even when the wxConfigBase comes from another source, as is the case in the KICAD_MANAGER_FRAME. * Move the setting of the KIPRJMOD environment variable into class PROJECT, so that it can be moved into a project variable soon, and out of FP_LIB_TABLE. * Add the KIWAY_PLAYER which is associated with a particular PROJECT, and all its child wxFrames and wxDialogs now have a Kiway() member function which returns a KIWAY& that that window tree branch is in support of. This is like wxWindows DNA in that child windows get this member with proper value at time of construction. * Anticipate some of the needs for milestones B) and C) and make code adjustments now in an effort to reduce work in those milestones. * No testing has been done for python scripting, since milestone C) has that being largely reworked and re-thought-out.
2014-03-20 00:42:08 +00:00
PCB_BASE_FRAME::SaveSettings( aCfg );
Fix save last grid size and other minor updates. * Create single event handler for grid size events. * Fix all frame windows to use new grid size event handler. * Use offset relative to ID instead of ComboBox index to save last grid size. * Move last grid size load/save setting into WinEDA_DrawFrame. * Add equality and assignment operators the GRID_TYPE. * Add current grid helper methods to BASE_SCREEN. * Add GetPins helper to LIB_COMPONENT to replace GetNextPin where applicable. * Add AppendMsgPanel helper to WinEDA_DrawFrame. * Improve rounding for display of coordinates when millimeter units are selected.
2009-10-14 19:43:31 +00:00
Finish with EDA_ANGLE.
2022-01-16 21:15:20 +00:00
PCBNEW_SETTINGS* cfg = dynamic_cast<PCBNEW_SETTINGS*>( aCfg );
Implement a new settings framework across all of KiCad CHANGED: Settings are now stored in versioned sub-directories ADDED: First-run dialog for migrating settings from a previous version CHANGED: Settings are now stored as JSON files instead of wxConfig-style INI files CHANGED: Color settings are now all stored in a separate settings file CHANGED: The symbol editor and footprint editor now have their own settings files CHANGED: Color settings are no longer exposed through BOARD object CHANGED: Page layout editor now uses Eeschema's color scheme Settings are now managed through a central SETTINGS_MANAGER held by PGM_BASE. Existing settings will be migrated from the wxConfig format on first run of each application. Per-application settings are now stored in one class for each application.
2020-01-13 01:44:19 +00:00
wxASSERT( cfg );
Fix save last grid size and other minor updates. * Create single event handler for grid size events. * Fix all frame windows to use new grid size event handler. * Use offset relative to ID instead of ComboBox index to save last grid size. * Move last grid size load/save setting into WinEDA_DrawFrame. * Add equality and assignment operators the GRID_TYPE. * Add current grid helper methods to BASE_SCREEN. * Add GetPins helper to LIB_COMPONENT to replace GetNextPin where applicable. * Add AppendMsgPanel helper to WinEDA_DrawFrame. * Improve rounding for display of coordinates when millimeter units are selected.
2009-10-14 19:43:31 +00:00
Fixup some Coverity issues.
2020-03-21 16:31:48 +00:00
if( cfg )
{
Nullptr safety for various panels. Also moves preference saving out to parent as different parents save different settings.
2023-09-25 11:35:31 +00:00
cfg->m_AuiPanels.show_layer_manager = m_show_layer_manager_tools;
Save and restore properties and search panel sizes
2022-11-25 14:11:20 +00:00
if( m_propertiesPanel )
{
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
cfg->m_AuiPanels.show_properties = m_propertiesPanel->IsShownOnScreen();
Save and restore properties and search panel sizes
2022-11-25 14:11:20 +00:00
cfg->m_AuiPanels.properties_panel_width = m_propertiesPanel->GetSize().x;
Nullptr safety for various panels. Also moves preference saving out to parent as different parents save different settings.
2023-09-25 11:35:31 +00:00
cfg->m_AuiPanels.properties_splitter = m_propertiesPanel->SplitterProportion();
Save and restore properties and search panel sizes
2022-11-25 14:11:20 +00:00
}
Fix broken autosave when board is modified. Fixes https://gitlab.com/kicad/code/kicad/-/issues/12700
2022-10-22 19:49:03 +00:00
Manage the Search panel visibility state in view menu. Fixes #12533 https://gitlab.com/kicad/code/kicad/issues/12533
2022-10-02 08:20:26 +00:00
// ensure m_show_search is up to date (the pane can be closed)
Fix Search pane not remembering docking sizes and positions Fixes https://gitlab.com/kicad/code/kicad/-/issues/14120
2023-05-18 20:03:33 +00:00
wxAuiPaneInfo& searchPaneInfo = m_auimgr.GetPane( SearchPaneName() );
m_show_search = searchPaneInfo.IsShown();
Fix search panel not remembering visibility Fixes https://gitlab.com/kicad/code/kicad/-/issues/12494
2022-09-25 15:56:41 +00:00
cfg->m_AuiPanels.show_search = m_show_search;
Save and restore properties and search panel sizes
2022-11-25 14:11:20 +00:00
cfg->m_AuiPanels.search_panel_height = m_searchPane->GetSize().y;
Fix Search pane not remembering docking sizes and positions Fixes https://gitlab.com/kicad/code/kicad/-/issues/14120
2023-05-18 20:03:33 +00:00
cfg->m_AuiPanels.search_panel_width = m_searchPane->GetSize().x;
cfg->m_AuiPanels.search_panel_dock_direction = searchPaneInfo.dock_direction;
Tidy up shutdown of APPEARANCE_CONTROLS. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15024
2023-09-24 17:26:42 +00:00
if( m_appearancePanel )
Nullptr safety for various panels. Also moves preference saving out to parent as different parents save different settings.
2023-09-25 11:35:31 +00:00
{
cfg->m_AuiPanels.right_panel_width = m_appearancePanel->GetSize().x;
cfg->m_AuiPanels.appearance_panel_tab = m_appearancePanel->GetTabIndex();
cfg->m_AuiPanels.appearance_expand_layer_display = m_appearancePanel->IsLayerOptionsExpanded();
cfg->m_AuiPanels.appearance_expand_net_display = m_appearancePanel->IsNetOptionsExpanded();
}
Fixup some Coverity issues.
2020-03-21 16:31:48 +00:00
}
Fix save last grid size and other minor updates. * Create single event handler for grid size events. * Fix all frame windows to use new grid size event handler. * Use offset relative to ID instead of ComboBox index to save last grid size. * Move last grid size load/save setting into WinEDA_DrawFrame. * Add equality and assignment operators the GRID_TYPE. * Add current grid helper methods to BASE_SCREEN. * Add GetPins helper to LIB_COMPONENT to replace GetNextPin where applicable. * Add AppendMsgPanel helper to WinEDA_DrawFrame. * Improve rounding for display of coordinates when millimeter units are selected.
2009-10-14 19:43:31 +00:00
}
pcbnew: Update Layer manager display when changing active layer (from hotkey or menus) fixed minor problems and fixed Layer Alignment Target bug.
2010-01-23 10:50:05 +00:00
All control state handling is now performed in wxUpdateUIEvent handlers. * Old control state handling code completely removed in all applications. * Factor common control state handlers into EDA_DRAW_FRAME. * Replaced EDA_ITEM test for newness with IsNew() method. * Factor vertical right toolbar command handlers out of giant edit command switch statement in EESchema and PCBNew.
2011-02-21 13:54:29 +00:00
Pcbnew: fix rotation angle issue in rotate commands. The value of this rotation was store in 2 places: the config and the editor frame. So after changing the rotation angle from the preferences, the value in editor frames were not updated, and the rotation angle not modified. Now only the config value is used.
2022-01-20 09:43:40 +00:00
EDA_ANGLE PCB_EDIT_FRAME::GetRotationAngle() const
{
PCBNEW_SETTINGS* cfg = dynamic_cast<PCBNEW_SETTINGS*>( config() );
return cfg ? cfg->m_RotationAngle : ANGLE_90;
}
Multiple improvements concerning colors, configuration handling and legacy features in pcbnew: - support for background color setting - removed several global config settings (such as g_Drc_On) - wrapped most of global config settings in PCB_GENERAL_SETTINGS class - reorganized PCB general options dialog to clearly mark which options concern only the legacy canvas - new GAL feature for legacy users: double-click (or E) to change track width available as an option. Fixes: lp:1530543 * https://bugs.launchpad.net/kicad/+bug/1530543 Fixes: lp:1707145 * https://bugs.launchpad.net/kicad/+bug/1707145
2017-08-04 12:43:02 +00:00
COLOR4D PCB_EDIT_FRAME::GetGridColor()
Code cleaning. Use new font.
2010-02-01 21:23:27 +00:00
{
ADDED: Enable color themes for PcbNew printing
2020-05-16 17:15:43 +00:00
return GetColorSettings()->GetColor( LAYER_GRID );
Code cleaning. Use new font.
2010-02-01 21:23:27 +00:00
}
All control state handling is now performed in wxUpdateUIEvent handlers. * Old control state handling code completely removed in all applications. * Factor common control state handlers into EDA_DRAW_FRAME. * Replaced EDA_ITEM test for newness with IsNew() method. * Factor vertical right toolbar command handlers out of giant edit command switch statement in EESchema and PCBNew.
2011-02-21 13:54:29 +00:00
Pass COLOR4D object by reference instead of on the stack.
2021-07-26 17:28:37 +00:00
void PCB_EDIT_FRAME::SetGridColor( const COLOR4D& aColor )
Code cleaning. Use new font.
2010-02-01 21:23:27 +00:00
{
GAL: apply grid offset when board is loaded and respect grid color setting. (fixes lp:1533168)
2016-01-13 18:37:52 +00:00
ADDED: Enable color themes for PcbNew printing
2020-05-16 17:15:43 +00:00
GetColorSettings()->SetColor( LAYER_GRID, aColor );
Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal.
2019-06-13 17:28:55 +00:00
GetCanvas()->GetGAL()->SetGridColor( aColor );
Code cleaning. Use new font.
2010-02-01 21:23:27 +00:00
}
All control state handling is now performed in wxUpdateUIEvent handlers. * Old control state handling code completely removed in all applications. * Factor common control state handlers into EDA_DRAW_FRAME. * Replaced EDA_ITEM test for newness with IsNew() method. * Factor vertical right toolbar command handlers out of giant edit command switch statement in EESchema and PCBNew.
2011-02-21 13:54:29 +00:00
Refactor layer enumerations to all live in the same place
2017-03-13 03:19:33 +00:00
void PCB_EDIT_FRAME::SetActiveLayer( PCB_LAYER_ID aLayer )
Currently selected layer is displayed on the top.
2013-09-12 16:24:53 +00:00
{
Performance enhancements to roundrect pads and clearance outlines. Aka: avoid Clipper at all costs. Fixes https://gitlab.com/kicad/code/kicad/issues/5900
2020-10-14 14:55:06 +00:00
PCB_LAYER_ID oldLayer = GetActiveLayer();
if( oldLayer == aLayer )
Performance enhancements. Don't redraw all pads when active layer is set unless it has really changed.
2020-10-11 16:06:28 +00:00
return;
{Set,Get}ActiveLayer moved from PCB_EDIT_FRAME to PCB_BASE_FRAME.
2014-07-09 09:50:27 +00:00
PCB_BASE_FRAME::SetActiveLayer( aLayer );
Currently selected layer is displayed on the top.
2013-09-12 16:24:53 +00:00
ADDED: New appearance control widget for PcbNew Featuring: - Layer view presets - Per-type opacity for tracks, vias, pads, zones - Net and netclass color and visibility controls CHANGED: Simplified object visibilty controls Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951 Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
2020-07-11 17:42:00 +00:00
m_appearancePanel->OnLayerChanged();
Currently selected layer is displayed on the top.
2013-09-12 16:24:53 +00:00
Separate immediate and delayed action dispatch Using a boolean argument just leads to a lot of trailing booleans in the function calls and is not user friendly. Instead, introduce PostAction() to send an action that runs after the coroutine (equivalent to passing false or the default argument), and leave RunAction as the immediate execution function.
2023-06-26 22:16:51 +00:00
m_toolManager->PostAction( PCB_ACTIONS::layerChanged ); // notify other tools
Update track, via and pad clearances for the current layer. Fixes https://gitlab.com/kicad/code/kicad/issues/5797
2020-09-27 20:32:42 +00:00
GetCanvas()->SetFocus(); // allow capture of hotkeys
Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal.
2019-06-13 17:28:55 +00:00
GetCanvas()->SetHighContrastLayer( aLayer );
Update track, via and pad clearances for the current layer. Fixes https://gitlab.com/kicad/code/kicad/issues/5797
2020-09-27 20:32:42 +00:00
KIGFX::REPAINT is not enough if the item isn't in the view. Fixes https://gitlab.com/kicad/code/kicad/issues/11656 Fixes https://gitlab.com/kicad/code/kicad/issues/13217
2022-12-24 17:04:34 +00:00
GetCanvas()->GetView()->UpdateAllItemsConditionally(
[&]( KIGFX::VIEW_ITEM* aItem ) -> int
Fix various rendering issues with non-through vias Correctly hide netnames in high contrast mode Correct highlighting for blind/buried/micro via drills Repaint vias when needed to support stacked microvias Fixes https://gitlab.com/kicad/code/kicad/-/issues/2593
2020-10-13 02:47:20 +00:00
{
KIGFX::REPAINT is not enough if the item isn't in the view. Fixes https://gitlab.com/kicad/code/kicad/issues/11656 Fixes https://gitlab.com/kicad/code/kicad/issues/13217
2022-12-24 17:04:34 +00:00
BOARD_ITEM* item = dynamic_cast<BOARD_ITEM*>( aItem );
if( !item )
return 0;
// Note: KIGFX::REPAINT isn't enough for things that go from invisible to visible
// as they won't be found in the view layer's itemset for re-painting.
if( GetDisplayOptions().m_ContrastModeDisplay == HIGH_CONTRAST_MODE::HIDDEN )
Performance enhancements to roundrect pads and clearance outlines. Aka: avoid Clipper at all costs. Fixes https://gitlab.com/kicad/code/kicad/issues/5900
2020-10-14 14:55:06 +00:00
{
Revise method of selecting footprints in contrast When working in high contrast mode, we want to be able to select a footprint with only elements in, e.g. silk and fab layers. The previous design for footprint IsOnLayer had one behavior of every other element and a different behavior for footprints. This leads to multiple bugs as new features use the overloaded IsOnLayer expecting it to report if the element exists on a layer or not. For footprints, we need a different routine to determine whether or not to select the footprint when clicking on it. IsOnLayer will report if the footprint has any elements on a specific layer but we don't want to use the bbox for a hittest because large footprints with through hole pads will exist on every layer and have an enormous bbox. Instead, we filter footprints based on the hittest of each element. This behaves in a more logical fashion, allowing you to select a footprint by clicking on a visible element of that footprint. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15284
2023-08-01 17:37:19 +00:00
if( item->IsOnLayer( oldLayer ) || item->IsOnLayer( aLayer ) )
KIGFX::REPAINT is not enough if the item isn't in the view. Fixes https://gitlab.com/kicad/code/kicad/issues/11656 Fixes https://gitlab.com/kicad/code/kicad/issues/13217
2022-12-24 17:04:34 +00:00
return KIGFX::ALL;
}
if( item->Type() == PCB_VIA_T )
{
PCB_VIA* via = static_cast<PCB_VIA*>( item );
Redo pad & via painting (again). New strategy isolates all draw/don't draw decisions to the ViewGetLOD routines, and all dimmed/not dimmed to PCB_RENDER_SETTINGS::GetColor. The actual drawing in PCB_PAINTER is more-or-less conditon free. Also adds new layers for pad and via hole walls so that they can be controlled for high-contrast mode. Also changes the drawing paradigm so that the pads are drawn even when not on the high contrast layer, just in low contrast. The hole wall is drawn in high contrast. This actually makes things clearer to the user (although to be honest was done to keep from having to re-render pads when the high contrast layer changes since we have two separate layers now that we can adjut colours on). Fixes https://gitlab.com/kicad/code/kicad/issues/7328
2021-01-30 14:41:31 +00:00
// Vias on a restricted layer set must be redrawn when the active layer
// is changed
KIGFX::REPAINT is not enough if the item isn't in the view. Fixes https://gitlab.com/kicad/code/kicad/issues/11656 Fixes https://gitlab.com/kicad/code/kicad/issues/13217
2022-12-24 17:04:34 +00:00
if( via->GetViaType() == VIATYPE::BLIND_BURIED
|| via->GetViaType() == VIATYPE::MICROVIA )
{
return KIGFX::REPAINT;
}
Smarten the UpdateAllItemsConditionally() tests in SetActiveLayer(). Fixes https://gitlab.com/kicad/code/kicad/-/issues/15329
2023-09-15 16:43:43 +00:00
if( via->GetRemoveUnconnected() )
return KIGFX::ALL;
// Clearances could be layer-dependent so redraw them when the active layer
// is changed
if( GetPcbNewSettings()->m_Display.m_TrackClearance == SHOW_WITH_VIA_ALWAYS )
return KIGFX::REPAINT;
Performance enhancements to roundrect pads and clearance outlines. Aka: avoid Clipper at all costs. Fixes https://gitlab.com/kicad/code/kicad/issues/5900
2020-10-14 14:55:06 +00:00
}
KIGFX::REPAINT is not enough if the item isn't in the view. Fixes https://gitlab.com/kicad/code/kicad/issues/11656 Fixes https://gitlab.com/kicad/code/kicad/issues/13217
2022-12-24 17:04:34 +00:00
else if( item->Type() == PCB_PAD_T )
Fix display of pads in high contrast mode Fixes https://gitlab.com/kicad/code/kicad/-/issues/6912
2021-01-02 19:15:52 +00:00
{
KIGFX::REPAINT is not enough if the item isn't in the view. Fixes https://gitlab.com/kicad/code/kicad/issues/11656 Fixes https://gitlab.com/kicad/code/kicad/issues/13217
2022-12-24 17:04:34 +00:00
PAD* pad = static_cast<PAD*>( item );
Smarten the UpdateAllItemsConditionally() tests in SetActiveLayer(). Fixes https://gitlab.com/kicad/code/kicad/-/issues/15329
2023-09-15 16:43:43 +00:00
if( pad->GetRemoveUnconnected() )
return KIGFX::ALL;
Redo pad & via painting (again). New strategy isolates all draw/don't draw decisions to the ViewGetLOD routines, and all dimmed/not dimmed to PCB_RENDER_SETTINGS::GetColor. The actual drawing in PCB_PAINTER is more-or-less conditon free. Also adds new layers for pad and via hole walls so that they can be controlled for high-contrast mode. Also changes the drawing paradigm so that the pads are drawn even when not on the high contrast layer, just in low contrast. The hole wall is drawn in high contrast. This actually makes things clearer to the user (although to be honest was done to keep from having to re-render pads when the high contrast layer changes since we have two separate layers now that we can adjut colours on). Fixes https://gitlab.com/kicad/code/kicad/issues/7328
2021-01-30 14:41:31 +00:00
// Clearances could be layer-dependent so redraw them when the active layer
// is changed
Remove bad static_cast. (m_settings isn't a PCBNEW_SETTINGS in non-PCB_EDIT_FRAMEs)
2022-07-24 15:49:46 +00:00
if( GetPcbNewSettings()->m_Display.m_PadClearance )
Performance enhancements to roundrect pads and clearance outlines. Aka: avoid Clipper at all costs. Fixes https://gitlab.com/kicad/code/kicad/issues/5900
2020-10-14 14:55:06 +00:00
{
// Round-corner rects are expensive to draw, but are mostly found on
// SMD pads which only need redrawing on an active-to-not-active
// switch.
Enum class PAD_ATTR_T Renamed such that python stays the same
2021-05-01 14:46:50 +00:00
if( pad->GetAttribute() == PAD_ATTRIB::SMD )
Performance enhancements to roundrect pads and clearance outlines. Aka: avoid Clipper at all costs. Fixes https://gitlab.com/kicad/code/kicad/issues/5900
2020-10-14 14:55:06 +00:00
{
if( ( oldLayer == F_Cu || aLayer == F_Cu ) && pad->IsOnLayer( F_Cu ) )
KIGFX::REPAINT is not enough if the item isn't in the view. Fixes https://gitlab.com/kicad/code/kicad/issues/11656 Fixes https://gitlab.com/kicad/code/kicad/issues/13217
2022-12-24 17:04:34 +00:00
return KIGFX::REPAINT;
Performance enhancements to roundrect pads and clearance outlines. Aka: avoid Clipper at all costs. Fixes https://gitlab.com/kicad/code/kicad/issues/5900
2020-10-14 14:55:06 +00:00
if( ( oldLayer == B_Cu || aLayer == B_Cu ) && pad->IsOnLayer( B_Cu ) )
KIGFX::REPAINT is not enough if the item isn't in the view. Fixes https://gitlab.com/kicad/code/kicad/issues/11656 Fixes https://gitlab.com/kicad/code/kicad/issues/13217
2022-12-24 17:04:34 +00:00
return KIGFX::REPAINT;
}
else if( pad->IsOnLayer( oldLayer ) || pad->IsOnLayer( aLayer ) )
{
return KIGFX::REPAINT;
Performance enhancements to roundrect pads and clearance outlines. Aka: avoid Clipper at all costs. Fixes https://gitlab.com/kicad/code/kicad/issues/5900
2020-10-14 14:55:06 +00:00
}
}
Redo pad & via painting (again). New strategy isolates all draw/don't draw decisions to the ViewGetLOD routines, and all dimmed/not dimmed to PCB_RENDER_SETTINGS::GetColor. The actual drawing in PCB_PAINTER is more-or-less conditon free. Also adds new layers for pad and via hole walls so that they can be controlled for high-contrast mode. Also changes the drawing paradigm so that the pads are drawn even when not on the high contrast layer, just in low contrast. The hole wall is drawn in high contrast. This actually makes things clearer to the user (although to be honest was done to keep from having to re-render pads when the high contrast layer changes since we have two separate layers now that we can adjut colours on). Fixes https://gitlab.com/kicad/code/kicad/issues/7328
2021-01-30 14:41:31 +00:00
}
KIGFX::REPAINT is not enough if the item isn't in the view. Fixes https://gitlab.com/kicad/code/kicad/issues/11656 Fixes https://gitlab.com/kicad/code/kicad/issues/13217
2022-12-24 17:04:34 +00:00
else if( item->Type() == PCB_TRACE_T || item->Type() == PCB_ARC_T )
Update track, via and pad clearances for the current layer. Fixes https://gitlab.com/kicad/code/kicad/issues/5797
2020-09-27 20:32:42 +00:00
{
Minor compil and Coverity warnings fixes.
2023-01-02 09:12:16 +00:00
PCB_TRACK* track = static_cast<PCB_TRACK*>( item );
KIGFX::REPAINT is not enough if the item isn't in the view. Fixes https://gitlab.com/kicad/code/kicad/issues/11656 Fixes https://gitlab.com/kicad/code/kicad/issues/13217
2022-12-24 17:04:34 +00:00
Redo pad & via painting (again). New strategy isolates all draw/don't draw decisions to the ViewGetLOD routines, and all dimmed/not dimmed to PCB_RENDER_SETTINGS::GetColor. The actual drawing in PCB_PAINTER is more-or-less conditon free. Also adds new layers for pad and via hole walls so that they can be controlled for high-contrast mode. Also changes the drawing paradigm so that the pads are drawn even when not on the high contrast layer, just in low contrast. The hole wall is drawn in high contrast. This actually makes things clearer to the user (although to be honest was done to keep from having to re-render pads when the high contrast layer changes since we have two separate layers now that we can adjut colours on). Fixes https://gitlab.com/kicad/code/kicad/issues/7328
2021-01-30 14:41:31 +00:00
// Clearances could be layer-dependent so redraw them when the active layer
// is changed
Remove bad static_cast. (m_settings isn't a PCBNEW_SETTINGS in non-PCB_EDIT_FRAMEs)
2022-07-24 15:49:46 +00:00
if( GetPcbNewSettings()->m_Display.m_TrackClearance )
Performance enhancements to roundrect pads and clearance outlines. Aka: avoid Clipper at all costs. Fixes https://gitlab.com/kicad/code/kicad/issues/5900
2020-10-14 14:55:06 +00:00
{
Redo pad & via painting (again). New strategy isolates all draw/don't draw decisions to the ViewGetLOD routines, and all dimmed/not dimmed to PCB_RENDER_SETTINGS::GetColor. The actual drawing in PCB_PAINTER is more-or-less conditon free. Also adds new layers for pad and via hole walls so that they can be controlled for high-contrast mode. Also changes the drawing paradigm so that the pads are drawn even when not on the high contrast layer, just in low contrast. The hole wall is drawn in high contrast. This actually makes things clearer to the user (although to be honest was done to keep from having to re-render pads when the high contrast layer changes since we have two separate layers now that we can adjut colours on). Fixes https://gitlab.com/kicad/code/kicad/issues/7328
2021-01-30 14:41:31 +00:00
// Tracks aren't particularly expensive to draw, but it's an easy check.
KIGFX::REPAINT is not enough if the item isn't in the view. Fixes https://gitlab.com/kicad/code/kicad/issues/11656 Fixes https://gitlab.com/kicad/code/kicad/issues/13217
2022-12-24 17:04:34 +00:00
if( track->IsOnLayer( oldLayer ) || track->IsOnLayer( aLayer ) )
return KIGFX::REPAINT;
Performance enhancements to roundrect pads and clearance outlines. Aka: avoid Clipper at all costs. Fixes https://gitlab.com/kicad/code/kicad/issues/5900
2020-10-14 14:55:06 +00:00
}
Redo pad & via painting (again). New strategy isolates all draw/don't draw decisions to the ViewGetLOD routines, and all dimmed/not dimmed to PCB_RENDER_SETTINGS::GetColor. The actual drawing in PCB_PAINTER is more-or-less conditon free. Also adds new layers for pad and via hole walls so that they can be controlled for high-contrast mode. Also changes the drawing paradigm so that the pads are drawn even when not on the high contrast layer, just in low contrast. The hole wall is drawn in high contrast. This actually makes things clearer to the user (although to be honest was done to keep from having to re-render pads when the high contrast layer changes since we have two separate layers now that we can adjut colours on). Fixes https://gitlab.com/kicad/code/kicad/issues/7328
2021-01-30 14:41:31 +00:00
}
Performance enhancements to roundrect pads and clearance outlines. Aka: avoid Clipper at all costs. Fixes https://gitlab.com/kicad/code/kicad/issues/5900
2020-10-14 14:55:06 +00:00
KIGFX::REPAINT is not enough if the item isn't in the view. Fixes https://gitlab.com/kicad/code/kicad/issues/11656 Fixes https://gitlab.com/kicad/code/kicad/issues/13217
2022-12-24 17:04:34 +00:00
return 0;
Redo pad & via painting (again). New strategy isolates all draw/don't draw decisions to the ViewGetLOD routines, and all dimmed/not dimmed to PCB_RENDER_SETTINGS::GetColor. The actual drawing in PCB_PAINTER is more-or-less conditon free. Also adds new layers for pad and via hole walls so that they can be controlled for high-contrast mode. Also changes the drawing paradigm so that the pads are drawn even when not on the high contrast layer, just in low contrast. The hole wall is drawn in high contrast. This actually makes things clearer to the user (although to be honest was done to keep from having to re-render pads when the high contrast layer changes since we have two separate layers now that we can adjut colours on). Fixes https://gitlab.com/kicad/code/kicad/issues/7328
2021-01-30 14:41:31 +00:00
} );
Update track, via and pad clearances for the current layer. Fixes https://gitlab.com/kicad/code/kicad/issues/5797
2020-09-27 20:32:42 +00:00
Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal.
2019-06-13 17:28:55 +00:00
GetCanvas()->Refresh();
Refactored code responsible for high contrast mode. Now it allows to have more than one layer on the top. Selecting layer using the dropdown list on the toolbar influences the layer displayed in high contrast mode.
2013-07-16 07:26:29 +00:00
}
Refactor post-load actions in PcbNew and apply them consistently Fixes: lp:1751589 * https://bugs.launchpad.net/kicad/+bug/1751589
2018-02-25 17:52:52 +00:00
void PCB_EDIT_FRAME::onBoardLoaded()
{
DRC bug fixes and debugging improvements. 1) Don't wait for UpdateUserInterface to build the (global) list of layer names. 2) Report clearance resolution between a silk layer and a mask layer. 3) When writing DRC reports, include info about the violating rule. 4) Report "no relevant layers" if we fail to find anything to write a clearance resolution report about. Fixes https://gitlab.com/kicad/code/kicad/issues/8963
2021-08-17 14:37:33 +00:00
ENUM_MAP<PCB_LAYER_ID>& layerEnum = ENUM_MAP<PCB_LAYER_ID>::Instance();
layerEnum.Choices().Clear();
layerEnum.Undefined( UNDEFINED_LAYER );
for( LSEQ seq = LSET::AllLayersMask().Seq(); seq; ++seq )
{
// Canonical name
layerEnum.Map( *seq, LSET::Name( *seq ) );
// User name
layerEnum.Map( *seq, GetBoard()->GetLayerName( *seq ) );
}
Allow selection of nested items (ie: pads) inside an entered group. Also moves some group-related functionality from BOARD to PCB_GROUP.
2020-09-26 16:06:32 +00:00
DRC_TOOL* drcTool = m_toolManager->GetTool<DRC_TOOL>();
Be more targetted on when we load DRC Rules for better performance.
2021-01-01 22:15:24 +00:00
try
{
drcTool->GetDRCEngine()->InitEngine( GetDesignRulesPath() );
}
Silence more unused exception var warnings
2021-02-20 16:58:12 +00:00
catch( PARSE_ERROR& )
Be more targetted on when we load DRC Rules for better performance.
2021-01-01 22:15:24 +00:00
{
// Not sure this is the best place to tell the user their rules are buggy, so
// we'll stay quiet for now. Feel free to revisit this decision....
}
Allow selection of nested items (ie: pads) inside an entered group. Also moves some group-related functionality from BOARD to PCB_GROUP.
2020-09-26 16:06:32 +00:00
Refactor post-load actions in PcbNew and apply them consistently Fixes: lp:1751589 * https://bugs.launchpad.net/kicad/+bug/1751589
2018-02-25 17:52:52 +00:00
UpdateTitle();
Add an infobar widget to display information above the canvas This widget allows for non-intrusive display of text above the editing canvas. Currently, this is used for displaying the read only status of the files.
2020-05-18 23:44:58 +00:00
wxFileName fn = GetBoard()->GetFileName();
// Display a warning that the file is read only
if( fn.FileExists() && !fn.IsFileWritable() )
{
m_infoBar->RemoveAllButtons();
m_infoBar->AddCloseButton();
Use MESSAGE_TYPE::OUTDATED_SAVE for read-only infobar messages as well. Fixes https://gitlab.com/kicad/code/kicad/issues/12252
2022-09-10 20:26:25 +00:00
m_infoBar->ShowMessage( _( "Board file is read only." ),
wxICON_WARNING, WX_INFOBAR::MESSAGE_TYPE::OUTDATED_SAVE );
Add an infobar widget to display information above the canvas This widget allows for non-intrusive display of text above the editing canvas. Currently, this is used for displaying the read only status of the files.
2020-05-18 23:44:58 +00:00
}
Refactor post-load actions in PcbNew and apply them consistently Fixes: lp:1751589 * https://bugs.launchpad.net/kicad/+bug/1751589
2018-02-25 17:52:52 +00:00
ReCreateLayerBox();
// Sync layer and item visibility
Cleanup. No changes to execution.
2020-09-30 22:02:05 +00:00
GetCanvas()->SyncLayersVisibility( m_pcb );
Refactor post-load actions in PcbNew and apply them consistently Fixes: lp:1751589 * https://bugs.launchpad.net/kicad/+bug/1751589
2018-02-25 17:52:52 +00:00
Remove bad static_cast. (m_settings isn't a PCBNEW_SETTINGS in non-PCB_EDIT_FRAMEs)
2022-07-24 15:49:46 +00:00
SetElementVisibility( LAYER_RATSNEST, GetPcbNewSettings()->m_Display.m_ShowGlobalRatsnest );
Fix grid settings in pcbnew/modedit/cvpcb * Make the grid display settings separate from the board object * Ensure that the grid is initialized on creation in all the frames Fixes: lp:1843169 * https://bugs.launchpad.net/kicad/+bug/1843169
2019-11-23 22:43:54 +00:00
Don't refresh appearance panel until after project is loaded
2020-08-22 18:55:24 +00:00
m_appearancePanel->OnBoardChanged();
Make sure appearance panel builds after project has been loaded OnBoardChanged must run after LoadProjectSettings. Move the local overrides to PCB_EDIT_FRAME::onBoardLoaded so that they are run after the panel is initialized.
2020-08-24 23:38:34 +00:00
// Apply saved display state to the appearance panel after it has been set up
PROJECT_LOCAL_SETTINGS& localSettings = Prj().GetLocalSettings();
m_appearancePanel->ApplyLayerPreset( localSettings.m_ActiveLayerPreset );
if( GetBoard()->GetDesignSettings().IsLayerEnabled( localSettings.m_ActiveLayer ) )
SetActiveLayer( localSettings.m_ActiveLayer );
Make sure auto-unit dimensions are updated on board load
2020-09-12 15:52:49 +00:00
// Updates any auto dimensions and the auxiliary toolbar tracks/via sizes
unitsChangeRefresh();
Refactor post-load actions in PcbNew and apply them consistently Fixes: lp:1751589 * https://bugs.launchpad.net/kicad/+bug/1751589
2018-02-25 17:52:52 +00:00
// Display the loaded board:
Zoom_Automatique( false );
Fix pad clearance bounding box and initial display Fixes https://gitlab.com/kicad/code/kicad/-/issues/7673
2021-02-24 03:15:39 +00:00
// Invalidate painting as loading the DRC engine will cause clearances to become valid
GetCanvas()->GetView()->UpdateAllItems( KIGFX::ALL );
Fix pcbnew: refresh canvas on opening a file only after mouse move Fixes: lp:1760819 * https://bugs.launchpad.net/kicad/+bug/1760819
2018-04-03 10:05:09 +00:00
Refresh();
Refactor post-load actions in PcbNew and apply them consistently Fixes: lp:1751589 * https://bugs.launchpad.net/kicad/+bug/1751589
2018-02-25 17:52:52 +00:00
SetMsgPanel( GetBoard() );
SetStatusText( wxEmptyString );
Add shutdown blocking on Windows for pcbnew, eeschema and pleditor ADDED: Block shutdown/logoff on Windows when contents have been modified
2019-12-19 14:11:11 +00:00
Move shutdown blocker to kiplatform
2020-09-01 10:14:51 +00:00
KIPLATFORM::APP::SetShutdownBlockReason( this, _( "PCB file changes are unsaved" ) );
Refactor post-load actions in PcbNew and apply them consistently Fixes: lp:1751589 * https://bugs.launchpad.net/kicad/+bug/1751589
2018-02-25 17:52:52 +00:00
}
ADDED: New appearance control widget for PcbNew Featuring: - Layer view presets - Per-type opacity for tracks, vias, pads, zones - Net and netclass color and visibility controls CHANGED: Simplified object visibilty controls Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951 Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
2020-07-11 17:42:00 +00:00
void PCB_EDIT_FRAME::OnDisplayOptionsChanged()
Code cleaning and more about work items visibility
2010-01-30 20:17:56 +00:00
{
ADDED: New appearance control widget for PcbNew Featuring: - Layer view presets - Per-type opacity for tracks, vias, pads, zones - Net and netclass color and visibility controls CHANGED: Simplified object visibilty controls Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951 Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
2020-07-11 17:42:00 +00:00
m_appearancePanel->UpdateDisplayOptions();
* Add PCB_EDIT_FRAME::syncLayerVisibilities(), PCB_LAYER_MANAGER::SyncLayerVisibilities(). * Save all visibilities, layer and render, in BOARD and restore on load.
2012-03-12 00:40:48 +00:00
}
Fix coding style policy violations and CMake version. Fix violations of 4.2.2 Function Definitions and 4.2.3 Control Statements. Set the minimum CMake version required to build to 3.1. Removed the Visual Studio solution and project files.
2021-07-05 08:04:36 +00:00
Refactor layer enumerations to all live in the same place
2017-03-13 03:19:33 +00:00
bool PCB_EDIT_FRAME::IsElementVisible( GAL_LAYER_ID aElement ) const
Code cleaning and more about work items visibility
2010-01-30 20:17:56 +00:00
{
Remove sine and cosine look up tables and other minor fixes. * Remove sine and cosine look up tables from trigo.cpp and replace them with sin() and cos() math functions. * Large include file clean up to prevent header ordering dependency build failures. * Translate French code names and comments. * Lots of coding style policy and doxygen comment fixes.
2011-09-20 13:57:40 +00:00
return GetBoard()->IsElementVisible( aElement );
}
Refactor layer enumerations to all live in the same place
2017-03-13 03:19:33 +00:00
void PCB_EDIT_FRAME::SetElementVisibility( GAL_LAYER_ID aElement, bool aNewState )
Remove sine and cosine look up tables and other minor fixes. * Remove sine and cosine look up tables from trigo.cpp and replace them with sin() and cos() math functions. * Large include file clean up to prevent header ordering dependency build failures. * Translate French code names and comments. * Lots of coding style policy and doxygen comment fixes.
2011-09-20 13:57:40 +00:00
{
pcbnew: Add option to show ratsnest while moving Re-works ratsnest display options in the configuration parameters rather than the board file. Moves ratsnest options to central preferences location. Fixes: lp:1826440 * https://bugs.launchpad.net/kicad/+bug/1826440 Fixes: lp:1821183 * https://bugs.launchpad.net/kicad/+bug/1821183
2019-06-13 00:32:47 +00:00
// Force the RATSNEST visible
if( aElement == LAYER_RATSNEST )
Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal.
2019-06-13 17:28:55 +00:00
GetCanvas()->GetView()->SetLayerVisible( aElement, true );
pcbnew: Add option to show ratsnest while moving Re-works ratsnest display options in the configuration parameters rather than the board file. Moves ratsnest options to central preferences location. Fixes: lp:1826440 * https://bugs.launchpad.net/kicad/+bug/1826440 Fixes: lp:1821183 * https://bugs.launchpad.net/kicad/+bug/1821183
2019-06-13 00:32:47 +00:00
else
Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal.
2019-06-13 17:28:55 +00:00
GetCanvas()->GetView()->SetLayerVisible( aElement , aNewState );
pcbnew: Add option to show ratsnest while moving Re-works ratsnest display options in the configuration parameters rather than the board file. Moves ratsnest options to central preferences location. Fixes: lp:1826440 * https://bugs.launchpad.net/kicad/+bug/1826440 Fixes: lp:1821183 * https://bugs.launchpad.net/kicad/+bug/1821183
2019-06-13 00:32:47 +00:00
Remove sine and cosine look up tables and other minor fixes. * Remove sine and cosine look up tables from trigo.cpp and replace them with sin() and cos() math functions. * Large include file clean up to prevent header ordering dependency build failures. * Translate French code names and comments. * Lots of coding style policy and doxygen comment fixes.
2011-09-20 13:57:40 +00:00
GetBoard()->SetElementVisibility( aElement, aNewState );
pcbnew: Update Layer manager display when changing active layer (from hotkey or menus) fixed minor problems and fixed Layer Alignment Target bug.
2010-01-23 10:50:05 +00:00
}
committed newfont patch. Pcbnew: board date automatically updated at each change.
2010-02-19 13:23:58 +00:00
All control state handling is now performed in wxUpdateUIEvent handlers. * Old control state handling code completely removed in all applications. * Factor common control state handlers into EDA_DRAW_FRAME. * Replaced EDA_ITEM test for newness with IsNew() method. * Factor vertical right toolbar command handlers out of giant edit command switch statement in EESchema and PCBNew.
2011-02-21 13:54:29 +00:00
Modular-Kicad milestone B), major portions: *) Rework the set language support, simplify it by using KIWAY. Now any major frame with a "change language" menu can change the language for all KIWAY_PLAYERs in the whole KIWAY. Multiple KIWAYs are not supported yet. *) Simplify "modal wxFrame" support, and add that support exclusively to KIWAY_PLAYER where it is inherited by all derivatives. The function KIWAY_PLAYER::ShowModal() is in the vtable and so is cross module capable. *) Remove the requirements and assumptions that the wxFrame hierarchy always had PCB_EDIT_FRAME and SCH_EDIT_FRAME as immediate parents of their viewers and editors. This is no longer the case, nor required. *) Use KIWAY::Player() everywhere to make KIWAY_PLAYERs, this registers the KIWAY_PLAYER within the KIWAY and makes it very easy to find an open frame quickly. It also gives control to the KIWAY as to frame hierarchical relationships. *) Change single_top to use the KIWAY for loading a KIFACE and instantiating the single KIWAY_PLAYER, see bullet immediately above. *) Add KIWAY::OnKiwayEnd() and call it from PGM_BASE at program termination, this gives the KIFACEs a chance to save their final configuration dope to disk. *) Add dedicated FRAME_T's for the modal frames, so m_Ident can be tested and these modal frames are distinctly different than their non-modal equivalents. KIWAY_PLAYER::IsModal() is !not! a valid test during the wxFrame's constructor, so this is another important reason for having a dedicated FRAME_T for each modal wxFrame. On balance, more lines were deleted than were added to achieve all this.
2014-05-03 17:40:19 +00:00
void PCB_EDIT_FRAME::ShowChangedLanguage()
Setting a new language now update the layer manager.
2010-02-26 15:39:10 +00:00
{
Modular-Kicad milestone B), major portions: *) Rework the set language support, simplify it by using KIWAY. Now any major frame with a "change language" menu can change the language for all KIWAY_PLAYERs in the whole KIWAY. Multiple KIWAYs are not supported yet. *) Simplify "modal wxFrame" support, and add that support exclusively to KIWAY_PLAYER where it is inherited by all derivatives. The function KIWAY_PLAYER::ShowModal() is in the vtable and so is cross module capable. *) Remove the requirements and assumptions that the wxFrame hierarchy always had PCB_EDIT_FRAME and SCH_EDIT_FRAME as immediate parents of their viewers and editors. This is no longer the case, nor required. *) Use KIWAY::Player() everywhere to make KIWAY_PLAYERs, this registers the KIWAY_PLAYER within the KIWAY and makes it very easy to find an open frame quickly. It also gives control to the KIWAY as to frame hierarchical relationships. *) Change single_top to use the KIWAY for loading a KIFACE and instantiating the single KIWAY_PLAYER, see bullet immediately above. *) Add KIWAY::OnKiwayEnd() and call it from PGM_BASE at program termination, this gives the KIFACEs a chance to save their final configuration dope to disk. *) Add dedicated FRAME_T's for the modal frames, so m_Ident can be tested and these modal frames are distinctly different than their non-modal equivalents. KIWAY_PLAYER::IsModal() is !not! a valid test during the wxFrame's constructor, so this is another important reason for having a dedicated FRAME_T for each modal wxFrame. On balance, more lines were deleted than were added to achieve all this.
2014-05-03 17:40:19 +00:00
// call my base class
Layout adjustments and language-change-updating for modview.
2018-08-04 11:59:04 +00:00
PCB_BASE_EDIT_FRAME::ShowChangedLanguage();
Modular-Kicad milestone B), major portions: *) Rework the set language support, simplify it by using KIWAY. Now any major frame with a "change language" menu can change the language for all KIWAY_PLAYERs in the whole KIWAY. Multiple KIWAYs are not supported yet. *) Simplify "modal wxFrame" support, and add that support exclusively to KIWAY_PLAYER where it is inherited by all derivatives. The function KIWAY_PLAYER::ShowModal() is in the vtable and so is cross module capable. *) Remove the requirements and assumptions that the wxFrame hierarchy always had PCB_EDIT_FRAME and SCH_EDIT_FRAME as immediate parents of their viewers and editors. This is no longer the case, nor required. *) Use KIWAY::Player() everywhere to make KIWAY_PLAYERs, this registers the KIWAY_PLAYER within the KIWAY and makes it very easy to find an open frame quickly. It also gives control to the KIWAY as to frame hierarchical relationships. *) Change single_top to use the KIWAY for loading a KIFACE and instantiating the single KIWAY_PLAYER, see bullet immediately above. *) Add KIWAY::OnKiwayEnd() and call it from PGM_BASE at program termination, this gives the KIFACEs a chance to save their final configuration dope to disk. *) Add dedicated FRAME_T's for the modal frames, so m_Ident can be tested and these modal frames are distinctly different than their non-modal equivalents. KIWAY_PLAYER::IsModal() is !not! a valid test during the wxFrame's constructor, so this is another important reason for having a dedicated FRAME_T for each modal wxFrame. On balance, more lines were deleted than were added to achieve all this.
2014-05-03 17:40:19 +00:00
Properties panel: post-rebase fixes and hide by default Remove layer widget re-added by Orson's rebase
2020-10-19 01:57:18 +00:00
m_auimgr.GetPane( m_appearancePanel ).Caption( _( "Appearance" ) );
m_auimgr.GetPane( m_selectionFilterPanel ).Caption( _( "Selection Filter" ) );
m_auimgr.GetPane( m_propertiesPanel ).Caption( _( "Properties" ) );
Setting a new language now update the layer manager.
2010-02-26 15:39:10 +00:00
m_auimgr.Update();
Update status bar and toolbars on language change. Fixes: lp:1392582 * https://bugs.launchpad.net/kicad/+bug/1392582 Fixes: lp:1748428 * https://bugs.launchpad.net/kicad/+bug/1748428
2018-02-03 22:55:13 +00:00
On-the-fly language updating for appearance panel & selection filter. Fixes https://gitlab.com/kicad/code/kicad/issues/10040
2022-02-19 14:58:07 +00:00
m_appearancePanel->OnLanguageChanged();
m_selectionFilterPanel->OnLanguageChanged();
Use translated strings for property display
2022-12-21 23:03:15 +00:00
m_propertiesPanel->OnLanguageChanged();
On-the-fly translations for pin electrical types. Also add on-the-fly translation for editor title bars. Fixes https://gitlab.com/kicad/code/kicad/issues/11324
2022-04-05 12:15:27 +00:00
UpdateTitle();
Setting a new language now update the layer manager.
2010-02-26 15:39:10 +00:00
}
Add PCBNew setting to remember last net list read and other minor fixes. * PCBNew remembers last net list read during the current editing session as well as between project editing sessions. Closes bug 576902. * Separate PCBNew application settings from project file settings and allocate them dynamically instead of statically to make it easier to eliminate global variables.
2010-04-23 14:46:00 +00:00
Save last-used-paths in export dialogs. Also fixes the export GenCAD dialog so that browse correctly updates the textbox. Fixes: lp:1793761 * https://bugs.launchpad.net/kicad/+bug/1793761
2019-08-03 03:03:03 +00:00
wxString PCB_EDIT_FRAME::GetLastPath( LAST_PATH_TYPE aType )
Add PCBNew setting to remember last net list read and other minor fixes. * PCBNew remembers last net list read during the current editing session as well as between project editing sessions. Closes bug 576902. * Separate PCBNew application settings from project file settings and allocate them dynamically instead of statically to make it easier to eliminate global variables.
2010-04-23 14:46:00 +00:00
{
Migrate PcbNew project settings to new framework Various architecture upgrades to support this. Creating a BOARD now requires a valid PROJECT, which caused some (mostly transparent) changes to the Python API internals. ADDED: Project local settings file CHANGED: Board design settings are no longer stored in PCB file CHANGED: Net classes are no longer stored in PCB file CHANGED: Importing board settings now reads boards, not just projects Fixes https://gitlab.com/kicad/code/kicad/-/issues/2578 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4070
2020-05-31 21:42:04 +00:00
PROJECT_FILE& project = Prj().GetProjectFile();
if( project.m_PcbLastPath[ aType ].IsEmpty() )
Save last-used-paths in export dialogs. Also fixes the export GenCAD dialog so that browse correctly updates the textbox. Fixes: lp:1793761 * https://bugs.launchpad.net/kicad/+bug/1793761
2019-08-03 03:03:03 +00:00
return wxEmptyString;
Add PCBNew setting to remember last net list read and other minor fixes. * PCBNew remembers last net list read during the current editing session as well as between project editing sessions. Closes bug 576902. * Separate PCBNew application settings from project file settings and allocate them dynamically instead of statically to make it easier to eliminate global variables.
2010-04-23 14:46:00 +00:00
Migrate PcbNew project settings to new framework Various architecture upgrades to support this. Creating a BOARD now requires a valid PROJECT, which caused some (mostly transparent) changes to the Python API internals. ADDED: Project local settings file CHANGED: Board design settings are no longer stored in PCB file CHANGED: Net classes are no longer stored in PCB file CHANGED: Importing board settings now reads boards, not just projects Fixes https://gitlab.com/kicad/code/kicad/-/issues/2578 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4070
2020-05-31 21:42:04 +00:00
wxFileName absoluteFileName = project.m_PcbLastPath[ aType ];
Save last-used-paths in export dialogs. Also fixes the export GenCAD dialog so that browse correctly updates the textbox. Fixes: lp:1793761 * https://bugs.launchpad.net/kicad/+bug/1793761
2019-08-03 03:03:03 +00:00
wxFileName pcbFileName = GetBoard()->GetFileName();
Add PCBNew setting to remember last net list read and other minor fixes. * PCBNew remembers last net list read during the current editing session as well as between project editing sessions. Closes bug 576902. * Separate PCBNew application settings from project file settings and allocate them dynamically instead of statically to make it easier to eliminate global variables.
2010-04-23 14:46:00 +00:00
Save last-used-paths in export dialogs. Also fixes the export GenCAD dialog so that browse correctly updates the textbox. Fixes: lp:1793761 * https://bugs.launchpad.net/kicad/+bug/1793761
2019-08-03 03:03:03 +00:00
absoluteFileName.MakeAbsolute( pcbFileName.GetPath() );
Add PCBNew setting to remember last net list read and other minor fixes. * PCBNew remembers last net list read during the current editing session as well as between project editing sessions. Closes bug 576902. * Separate PCBNew application settings from project file settings and allocate them dynamically instead of statically to make it easier to eliminate global variables.
2010-04-23 14:46:00 +00:00
return absoluteFileName.GetFullPath();
}
Save last-used-paths in export dialogs. Also fixes the export GenCAD dialog so that browse correctly updates the textbox. Fixes: lp:1793761 * https://bugs.launchpad.net/kicad/+bug/1793761
2019-08-03 03:03:03 +00:00
void PCB_EDIT_FRAME::SetLastPath( LAST_PATH_TYPE aType, const wxString& aLastPath )
Add PCBNew setting to remember last net list read and other minor fixes. * PCBNew remembers last net list read during the current editing session as well as between project editing sessions. Closes bug 576902. * Separate PCBNew application settings from project file settings and allocate them dynamically instead of statically to make it easier to eliminate global variables.
2010-04-23 14:46:00 +00:00
{
Migrate PcbNew project settings to new framework Various architecture upgrades to support this. Creating a BOARD now requires a valid PROJECT, which caused some (mostly transparent) changes to the Python API internals. ADDED: Project local settings file CHANGED: Board design settings are no longer stored in PCB file CHANGED: Net classes are no longer stored in PCB file CHANGED: Importing board settings now reads boards, not just projects Fixes https://gitlab.com/kicad/code/kicad/-/issues/2578 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4070
2020-05-31 21:42:04 +00:00
PROJECT_FILE& project = Prj().GetProjectFile();
Save last-used-paths in export dialogs. Also fixes the export GenCAD dialog so that browse correctly updates the textbox. Fixes: lp:1793761 * https://bugs.launchpad.net/kicad/+bug/1793761
2019-08-03 03:03:03 +00:00
wxFileName relativeFileName = aLastPath;
Script plotting patch
2012-08-29 16:59:50 +00:00
wxFileName pcbFileName = GetBoard()->GetFileName();
Add PCBNew setting to remember last net list read and other minor fixes. * PCBNew remembers last net list read during the current editing session as well as between project editing sessions. Closes bug 576902. * Separate PCBNew application settings from project file settings and allocate them dynamically instead of statically to make it easier to eliminate global variables.
2010-04-23 14:46:00 +00:00
Save last-used-paths in export dialogs. Also fixes the export GenCAD dialog so that browse correctly updates the textbox. Fixes: lp:1793761 * https://bugs.launchpad.net/kicad/+bug/1793761
2019-08-03 03:03:03 +00:00
relativeFileName.MakeRelativeTo( pcbFileName.GetPath() );
Migrate PcbNew project settings to new framework Various architecture upgrades to support this. Creating a BOARD now requires a valid PROJECT, which caused some (mostly transparent) changes to the Python API internals. ADDED: Project local settings file CHANGED: Board design settings are no longer stored in PCB file CHANGED: Net classes are no longer stored in PCB file CHANGED: Importing board settings now reads boards, not just projects Fixes https://gitlab.com/kicad/code/kicad/-/issues/2578 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4070
2020-05-31 21:42:04 +00:00
if( relativeFileName.GetFullPath() != project.m_PcbLastPath[ aType ] )
Add PCBNew setting to remember last net list read and other minor fixes. * PCBNew remembers last net list read during the current editing session as well as between project editing sessions. Closes bug 576902. * Separate PCBNew application settings from project file settings and allocate them dynamically instead of statically to make it easier to eliminate global variables.
2010-04-23 14:46:00 +00:00
{
Migrate PcbNew project settings to new framework Various architecture upgrades to support this. Creating a BOARD now requires a valid PROJECT, which caused some (mostly transparent) changes to the Python API internals. ADDED: Project local settings file CHANGED: Board design settings are no longer stored in PCB file CHANGED: Net classes are no longer stored in PCB file CHANGED: Importing board settings now reads boards, not just projects Fixes https://gitlab.com/kicad/code/kicad/-/issues/2578 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4070
2020-05-31 21:42:04 +00:00
project.m_PcbLastPath[ aType ] = relativeFileName.GetFullPath();
Move to requiring explicit action to save project settings
2023-03-04 19:25:07 +00:00
OnModify();
Add PCBNew setting to remember last net list read and other minor fixes. * PCBNew remembers last net list read during the current editing session as well as between project editing sessions. Closes bug 576902. * Separate PCBNew application settings from project file settings and allocate them dynamically instead of statically to make it easier to eliminate global variables.
2010-04-23 14:46:00 +00:00
}
}
Auto update 3D display after footprint or board edition.
2010-05-01 12:46:33 +00:00
All control state handling is now performed in wxUpdateUIEvent handlers. * Old control state handling code completely removed in all applications. * Factor common control state handlers into EDA_DRAW_FRAME. * Replaced EDA_ITEM test for newness with IsNew() method. * Factor vertical right toolbar command handlers out of giant edit command switch statement in EESchema and PCBNew.
2011-02-21 13:54:29 +00:00
Cleanup.
2022-04-09 12:59:59 +00:00
void PCB_EDIT_FRAME::OnModify()
Auto update 3D display after footprint or board edition.
2010-05-01 12:46:33 +00:00
{
PCBNew control update bug fixes, fixes lp:725963. * Fix grid select box update bug on context menu. * Fix via size and track width select box update bugs. * Fix layer pair indicator button update bug. * Fix auto track width tool bar control enable bug. * Fix via size and track width select status bug in context menu. * Fix layer select box and layer control widget select bug when current layer is removed. * Add virtual function to notify objects derived from EDA_DRAW_FRAME that the units setting has changed. * Coding policy class naming fixes.
2011-03-01 19:26:17 +00:00
PCB_BASE_FRAME::OnModify();
All control state handling is now performed in wxUpdateUIEvent handlers. * Old control state handling code completely removed in all applications. * Factor common control state handlers into EDA_DRAW_FRAME. * Replaced EDA_ITEM test for newness with IsNew() method. * Factor vertical right toolbar command handlers out of giant edit command switch statement in EESchema and PCBNew.
2011-02-21 13:54:29 +00:00
Remove bad static_cast. (m_settings isn't a PCBNEW_SETTINGS in non-PCB_EDIT_FRAMEs)
2022-07-24 15:49:46 +00:00
Update3DView( true, GetPcbNewSettings()->m_Display.m_Live3DRefresh );
Check zone fills before plotting. Also adds a "Draft Plot" button for those who wish to sidestep zone checking (which can be slow). Fixes: lp:1712579 * https://bugs.launchpad.net/kicad/+bug/1712579
2018-05-03 22:23:47 +00:00
More wxString wide literals.
2022-02-04 22:44:59 +00:00
if( !GetTitle().StartsWith( wxT( "*" ) ) )
Be more aggressive about updating title to show dirty status. Fixes https://gitlab.com/kicad/code/kicad/issues/7613
2021-02-19 21:58:22 +00:00
UpdateTitle();
Check zone fills before plotting. Also adds a "Draft Plot" button for those who wish to sidestep zone checking (which can be slow). Fixes: lp:1712579 * https://bugs.launchpad.net/kicad/+bug/1712579
2018-05-03 22:23:47 +00:00
m_ZoneFillsDirty = true;
Auto update 3D display after footprint or board edition.
2010-05-01 12:46:33 +00:00
}
More EESchema dialog file housekeeping
2010-11-17 21:47:27 +00:00
Make live 3D refresh optional Fixes https://gitlab.com/kicad/code/kicad/-/issues/8068
2021-04-08 02:39:30 +00:00
void PCB_EDIT_FRAME::HardRedraw()
{
Decouple 3D view dirty marking and refresh Fixes https://gitlab.com/kicad/code/kicad/-/issues/8154
2021-04-09 02:09:06 +00:00
Update3DView( true, true );
Make live 3D refresh optional Fixes https://gitlab.com/kicad/code/kicad/-/issues/8068
2021-04-08 02:39:30 +00:00
}
UNIT_BINDERize print and plot dialogs. Fixes: lp:1778560 * https://bugs.launchpad.net/kicad/+bug/1778560 Fixes: lp:1392991 * https://bugs.launchpad.net/kicad/+bug/1392991 Fixes: lp:1780362 * https://bugs.launchpad.net/kicad/+bug/1780362 (cherry picked from commit 9df9743)
2018-06-13 12:20:29 +00:00
void PCB_EDIT_FRAME::ExportSVG( wxCommandEvent& event )
More EESchema dialog file housekeeping
2010-11-17 21:47:27 +00:00
{
UNIT_BINDERize print and plot dialogs. Fixes: lp:1778560 * https://bugs.launchpad.net/kicad/+bug/1778560 Fixes: lp:1392991 * https://bugs.launchpad.net/kicad/+bug/1392991 Fixes: lp:1780362 * https://bugs.launchpad.net/kicad/+bug/1780362 (cherry picked from commit 9df9743)
2018-06-13 12:20:29 +00:00
InvokeExportSVG( this, GetBoard() );
More EESchema dialog file housekeeping
2010-11-17 21:47:27 +00:00
}
Add user write permission tests to PCBNew and other minor fixes. * Check user write permissions before saving project, board, and footprint library files. * Append read only to file name and path in title bar when the user does not have write privileges. * Rename class WinEDA_ModuleEditFrame to FOOTPRINT_EDIT_FRAME. * Lot's of Doxygen comment and coding style policy fixes.
2011-08-26 17:01:17 +00:00
void PCB_EDIT_FRAME::UpdateTitle()
{
Always enable save; move dirty bit to asterisk in title bar. Also unifies PCB Editor and Schematic Editor names with other locations in the GUI (which were still Pcbnew and Eeschema). Fixes https://gitlab.com/kicad/code/kicad/issues/7587 Fixes https://gitlab.com/kicad/code/kicad/issues/7594
2021-02-18 15:49:35 +00:00
wxFileName fn = GetBoard()->GetFileName();
bool readOnly = false;
bool unsaved = false;
Pcbnew: add a dialog to load a legacy file in "old" projects, when the .kicad_pcb file is not existing, and the correspoinding .brd file exists. Fix also an issue in pcb_parser when a netclass name is just a number (like a track width as name)
2012-12-15 13:39:36 +00:00
Always enable save; move dirty bit to asterisk in title bar. Also unifies PCB Editor and Schematic Editor names with other locations in the GUI (which were still Pcbnew and Eeschema). Fixes https://gitlab.com/kicad/code/kicad/issues/7587 Fixes https://gitlab.com/kicad/code/kicad/issues/7594
2021-02-18 15:49:35 +00:00
if( fn.IsOk() && fn.FileExists() )
readOnly = !fn.IsFileWritable();
Add user write permission tests to PCBNew and other minor fixes. * Check user write permissions before saving project, board, and footprint library files. * Append read only to file name and path in title bar when the user does not have write privileges. * Rename class WinEDA_ModuleEditFrame to FOOTPRINT_EDIT_FRAME. * Lot's of Doxygen comment and coding style policy fixes.
2011-08-26 17:01:17 +00:00
else
Always enable save; move dirty bit to asterisk in title bar. Also unifies PCB Editor and Schematic Editor names with other locations in the GUI (which were still Pcbnew and Eeschema). Fixes https://gitlab.com/kicad/code/kicad/issues/7587 Fixes https://gitlab.com/kicad/code/kicad/issues/7594
2021-02-18 15:49:35 +00:00
unsaved = true;
Unify window title formats Most window titles are now of the format "Application — file [info]", with adaptations as necessary. Version information has been removed from titles.
2016-09-26 17:15:33 +00:00
Work around MacOS printf/format issues MacOS wxWidgets implementation of wxPrintf/Format suffers from some issues when mixing string types. We avoid this by manually formatting the string ourselves. Fixes https://gitlab.com/kicad/code/kicad/issues/8404
2021-06-16 18:52:51 +00:00
wxString title;
Workaround a few more OSX printf problems. Also regularizes the frame title processing. Also fixes a type where the library name wasn't processed for variable expansion. Fixes https://gitlab.com/kicad/code/kicad/issues/7742
2021-06-20 21:46:41 +00:00
if( IsContentModified() )
title = wxT( "*" );
title += fn.GetName();
if( readOnly )
title += wxS( " " ) + _( "[Read Only]" );
if( unsaved )
title += wxS( " " ) + _( "[Unsaved]" );
title += wxT( " \u2014 " ) + _( "PCB Editor" );
Work around MacOS printf/format issues MacOS wxWidgets implementation of wxPrintf/Format suffers from some issues when mixing string types. We avoid this by manually formatting the string ourselves. Fixes https://gitlab.com/kicad/code/kicad/issues/8404
2021-06-16 18:52:51 +00:00
SetTitle( title );
Add user write permission tests to PCBNew and other minor fixes. * Check user write permissions before saving project, board, and footprint library files. * Append read only to file name and path in title bar when the user does not have write privileges. * Rename class WinEDA_ModuleEditFrame to FOOTPRINT_EDIT_FRAME. * Lot's of Doxygen comment and coding style policy fixes.
2011-08-26 17:01:17 +00:00
}
More encapsulation work and other minor improvements. * EDA_DRAW_FRAME completely encapsulated except for DrawFrame member. * Moved members specific to Pcbnew from EDA_DRAW_FRAME to PCB_BASE_FRAME or PCB_EDIT_FRAME as appropriate. * Replace EDA_TOOLBAR with wxAuiToolBar as EDA_TOOL bar provided no additional functionality and made code less readable. * Remove EDA_TOOLBAR class definition from wxstruct.h and delete file wineda_toolbar.cpp. * Rename tool bar members to something more descriptive since the horizontal and vertical references wont mean anything once the tool bars are movable. * Lots of dead code removal.
2011-12-16 13:32:23 +00:00
Modular KiCad Blueprint Milestone B), major portions: *) When kicad.exe closes a project, close any open KIFACEs so that they cannot get disassociated from their true PROJECT. *) Allow loading eeschema library editor from kicad.exe *) Allow loading pcbnew library editor from kicad.exe *) Rename LIB_COMPONENT to LIB_PART. *) Add class PART_LIBS, and PART_LIB. *) Make PART_LIBS non-global, i.e. PROJECT specific. *) Implement "data on demand" for PART_LIBS *) Implement "data on demand" for schematic SEARCH_STACK. *) Use RSTRINGs to retain eeschema editor's notion of last library and part being edited. *) Get rid of library search on every SCH_COMPONENT::Draw() call, instead use a weak pointer. *) Remove all chdir() calls so projects don't need to be CWD. *) Romove APPEND support from OpenProjectFiles(). *) Make OpenProjectFiles() robust, even for creating new projects. *) Load EESCHEMA colors in the KIWAY::OnKiwayStart() rather in window open, and save them in the .eeschema config file, not in the project file. *) Fix bug with wxDir() while accessing protected dirs in kicad.exe *) Consolidate template copying into PROJECT class, not in kicad.exe source. *) Generally untangle eeschema, making its libraries not global but rather held in the PROJECT.
2014-08-13 20:28:54 +00:00
Fix incorrect refresh of User Interface after running an action plugin, and add comments
2017-08-27 06:04:12 +00:00
void PCB_EDIT_FRAME::UpdateUserInterface()
{
// Update the layer manager and other widgets from the board setup
// (layer and items visibility, colors ...)
// Rebuild list of nets (full ratsnest rebuild)
GetBoard()->BuildConnectivity();
// Update info shown by the horizontal toolbars
ReCreateLayerBox();
Reset active layer if it gets deleted in board setup. Fixes https://gitlab.com/kicad/code/kicad/issues/5118
2020-08-13 19:35:04 +00:00
LSET activeLayers = GetBoard()->GetEnabledLayers();
if( !activeLayers.test( GetActiveLayer() ) )
SetActiveLayer( activeLayers.Seq().front() );
m_SelLayerBox->SetLayerSelection( GetActiveLayer() );
ADDED: New appearance control widget for PcbNew Featuring: - Layer view presets - Per-type opacity for tracks, vias, pads, zones - Net and netclass color and visibility controls CHANGED: Simplified object visibilty controls Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951 Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
2020-07-11 17:42:00 +00:00
ENUM_MAP<PCB_LAYER_ID>& layerEnum = ENUM_MAP<PCB_LAYER_ID>::Instance();
layerEnum.Choices().Clear();
layerEnum.Undefined( UNDEFINED_LAYER );
Fix incorrect refresh of User Interface after running an action plugin, and add comments
2017-08-27 06:04:12 +00:00
ADDED: New appearance control widget for PcbNew Featuring: - Layer view presets - Per-type opacity for tracks, vias, pads, zones - Net and netclass color and visibility controls CHANGED: Simplified object visibilty controls Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951 Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
2020-07-11 17:42:00 +00:00
for( LSEQ seq = LSET::AllLayersMask().Seq(); seq; ++seq )
Support for 'L' in DRC expression language. Also make layer testing work again against both canonical names and user names.
2020-09-27 18:43:44 +00:00
{
// Canonical name
layerEnum.Map( *seq, LSET::Name( *seq ) );
More NULL expunging.
2021-07-19 23:56:05 +00:00
Support for 'L' in DRC expression language. Also make layer testing work again against both canonical names and user names.
2020-09-27 18:43:44 +00:00
// User name
ADDED: New appearance control widget for PcbNew Featuring: - Layer view presets - Per-type opacity for tracks, vias, pads, zones - Net and netclass color and visibility controls CHANGED: Simplified object visibilty controls Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951 Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
2020-07-11 17:42:00 +00:00
layerEnum.Map( *seq, GetBoard()->GetLayerName( *seq ) );
Support for 'L' in DRC expression language. Also make layer testing work again against both canonical names and user names.
2020-09-27 18:43:44 +00:00
}
Fix incorrect refresh of User Interface after running an action plugin, and add comments
2017-08-27 06:04:12 +00:00
Make sure to show newly-enabled layers when changing board setup Fixes https://gitlab.com/kicad/code/kicad/-/issues/5478
2020-09-03 22:05:20 +00:00
// Sync visibility with canvas
Ensure visible layers are synchronized properly Fixes https://gitlab.com/kicad/code/kicad/-/issues/5873
2020-10-04 20:55:22 +00:00
for( PCB_LAYER_ID layer : LSET::AllLayersMask().Seq() )
Need to check enabled as well as visible. Fixes https://gitlab.com/kicad/code/kicad/issues/12786
2022-11-06 19:53:33 +00:00
GetCanvas()->GetView()->SetLayerVisible( layer, GetBoard()->IsLayerVisible( layer ) );
Make sure to show newly-enabled layers when changing board setup Fixes https://gitlab.com/kicad/code/kicad/-/issues/5478
2020-09-03 22:05:20 +00:00
ADDED: New appearance control widget for PcbNew Featuring: - Layer view presets - Per-type opacity for tracks, vias, pads, zones - Net and netclass color and visibility controls CHANGED: Simplified object visibilty controls Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951 Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173 Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
2020-07-11 17:42:00 +00:00
// Stackup and/or color theme may have changed
m_appearancePanel->OnBoardChanged();
Fix incorrect refresh of User Interface after running an action plugin, and add comments
2017-08-27 06:04:12 +00:00
}
Move some more menu commands to ACTIONs.
2019-05-28 13:51:47 +00:00
void PCB_EDIT_FRAME::SwitchCanvas( EDA_DRAW_PANEL_GAL::GAL_TYPE aCanvasType )
Pcbnew: keep layer manager synchronized with board items visibility after switching to a new canvas.
2017-08-09 07:48:56 +00:00
{
Remove more legacy editing code.
2019-05-27 16:16:54 +00:00
// switches currently used canvas (Cairo / OpenGL).
Move some more menu commands to ACTIONs.
2019-05-28 13:51:47 +00:00
PCB_BASE_FRAME::SwitchCanvas( aCanvasType );
Pcbnew: keep layer manager synchronized with board items visibility after switching to a new canvas.
2017-08-09 07:48:56 +00:00
}
Add Gerbers to Fabrication Outputs menu. Fixes: lp:1817124 * https://bugs.launchpad.net/kicad/+bug/1817124
2019-03-08 20:02:48 +00:00
Pcbnew: implement Find Next Moves all of the find dialog control out of the selection tool similar to the schematic editor. Dialog is also non-modal now to match the schematic editor. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8966
2021-08-27 17:15:51 +00:00
void PCB_EDIT_FRAME::ShowFindDialog()
{
if( !m_findDialog )
{
m_findDialog = new DIALOG_FIND( this );
m_findDialog->SetCallback( std::bind( &PCB_SELECTION_TOOL::FindItem,
m_toolManager->GetTool<PCB_SELECTION_TOOL>(), _1 ) );
}
Preload PCBnew find with selection when appropriate.
2022-03-19 00:17:07 +00:00
wxString findString;
PCB_SELECTION& selection = m_toolManager->GetTool<PCB_SELECTION_TOOL>()->GetSelection();
if( selection.Size() == 1 )
{
EDA_ITEM* front = selection.Front();
switch( front->Type() )
{
case PCB_FOOTPRINT_T:
Fix a bunch more issues with sheetpaths and allowExtraText. A sheetpath is required to correctly resolve text variables. Depending on currentSheet is rife with bugs. There are many places where we do *not* want to be prepending field names to the field values, such as netlisting, building PDF hypertext menus, etc. Also, Find/Replace needs to work on unresolved text, as that's what we're going to display (and if replace nuked your variable references you wouldn't be happy).
2023-05-05 13:21:56 +00:00
findString = UnescapeString( static_cast<FOOTPRINT*>( front )->GetValue() );
Preload PCBnew find with selection when appropriate.
2022-03-19 00:17:07 +00:00
break;
PCB: introduce PCB_FIELD_T
2023-06-06 15:09:34 +00:00
case PCB_FIELD_T:
Preload PCBnew find with selection when appropriate.
2022-03-19 00:17:07 +00:00
case PCB_TEXT_T:
Fix a bunch more issues with sheetpaths and allowExtraText. A sheetpath is required to correctly resolve text variables. Depending on currentSheet is rife with bugs. There are many places where we do *not* want to be prepending field names to the field values, such as netlisting, building PDF hypertext menus, etc. Also, Find/Replace needs to work on unresolved text, as that's what we're going to display (and if replace nuked your variable references you wouldn't be happy).
2023-05-05 13:21:56 +00:00
findString = UnescapeString( static_cast<PCB_TEXT*>( front )->GetText() );
Preload PCBnew find with selection when appropriate.
2022-03-19 00:17:07 +00:00
if( findString.Contains( wxT( "\n" ) ) )
findString = findString.Before( '\n' );
break;
default:
break;
}
}
m_findDialog->Preload( findString );
Pcbnew: implement Find Next Moves all of the find dialog control out of the selection tool similar to the schematic editor. Dialog is also non-modal now to match the schematic editor. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8966
2021-08-27 17:15:51 +00:00
m_findDialog->Show( true );
}
Common Actions: Find Previous Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8968
2023-01-26 14:36:41 +00:00
void PCB_EDIT_FRAME::FindNext( bool reverse )
Pcbnew: implement Find Next Moves all of the find dialog control out of the selection tool similar to the schematic editor. Dialog is also non-modal now to match the schematic editor. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8966
2021-08-27 17:15:51 +00:00
{
if( !m_findDialog )
Preload PCBnew find with selection when appropriate.
2022-03-19 00:17:07 +00:00
ShowFindDialog();
Pcbnew: implement Find Next Moves all of the find dialog control out of the selection tool similar to the schematic editor. Dialog is also non-modal now to match the schematic editor. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8966
2021-08-27 17:15:51 +00:00
Common Actions: Find Previous Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8968
2023-01-26 14:36:41 +00:00
m_findDialog->FindNext( reverse );
Pcbnew: implement Find Next Moves all of the find dialog control out of the selection tool similar to the schematic editor. Dialog is also non-modal now to match the schematic editor. Fixes https://gitlab.com/kicad/code/kicad/-/issues/8966
2021-08-27 17:15:51 +00:00
}
ACTION-ize fab outputs.
2019-06-04 20:59:59 +00:00
void PCB_EDIT_FRAME::ToPlotter( int aID )
Decouple PLOT_CONTROLLER from UI dependencies.
2013-05-10 19:22:29 +00:00
{
Add Gerbers to Fabrication Outputs menu. Fixes: lp:1817124 * https://bugs.launchpad.net/kicad/+bug/1817124
2019-03-08 20:02:48 +00:00
PCB_PLOT_PARAMS plotSettings = GetPlotSettings();
Remove a message used in a previous debug session.
2019-04-27 15:07:15 +00:00
ACTION-ize fab outputs.
2019-06-04 20:59:59 +00:00
switch( aID )
Add Gerbers to Fabrication Outputs menu. Fixes: lp:1817124 * https://bugs.launchpad.net/kicad/+bug/1817124
2019-03-08 20:02:48 +00:00
{
Change more enums over to scoped enums
2019-12-28 00:55:11 +00:00
case ID_GEN_PLOT_GERBER:
plotSettings.SetFormat( PLOT_FORMAT::GERBER );
break;
case ID_GEN_PLOT_DXF:
plotSettings.SetFormat( PLOT_FORMAT::DXF );
break;
case ID_GEN_PLOT_HPGL:
plotSettings.SetFormat( PLOT_FORMAT::HPGL );
break;
case ID_GEN_PLOT_PDF:
plotSettings.SetFormat( PLOT_FORMAT::PDF );
break;
case ID_GEN_PLOT_PS:
plotSettings.SetFormat( PLOT_FORMAT::POST );
break;
More wxString wide literals.
2022-02-04 22:44:59 +00:00
case ID_GEN_PLOT:
/* keep the previous setup */
break;
ACTION-ize fab outputs.
2019-06-04 20:59:59 +00:00
default:
More wxString wide literals.
2022-02-04 22:44:59 +00:00
wxFAIL_MSG( wxT( "ToPlotter(): unexpected plot type" ) ); break;
Pcbnew: suppress incorrect wx alert when opening the plot dialog from File/Plot menu
2019-04-11 15:36:51 +00:00
break;
Add Gerbers to Fabrication Outputs menu. Fixes: lp:1817124 * https://bugs.launchpad.net/kicad/+bug/1817124
2019-03-08 20:02:48 +00:00
}
SetPlotSettings( plotSettings );
DIALOG_PLOT: use a short living quasimodal dialog instead of a long living window. In this case, a quasimodal dialog is the right way. Fixes #10650 https://gitlab.com/kicad/code/kicad/issues/10650
2022-01-29 12:14:22 +00:00
DIALOG_PLOT dlg( this );
dlg.ShowQuasiModal( );
Decouple PLOT_CONTROLLER from UI dependencies.
2013-05-10 19:22:29 +00:00
}
Pcbnew: fix Bug #1370321 (Change Segment function applies last netclass used). Also update main toolbar track width and via size info in pns router mode, when starting a track, and other very minor update issue.
2014-09-28 14:44:47 +00:00
Avoid crashes when, for some reason, a dll cannot be loaded. In this case a null pointer was returned by the internal code. This pointer is now tested against nullptr to avoid the application crashing. Fixes #12080 https://gitlab.com/kicad/code/kicad/issues/12080
2022-07-24 17:42:50 +00:00
int PCB_EDIT_FRAME::TestStandalone()
One-click PCB update improvements - Fix repetitive undo/redo segfaults & assertions. - Add Update menu entry on PCB side. - Fix Python build error - Add spread footprints after updating
2016-01-29 14:43:40 +00:00
{
if( Kiface().IsSingle() )
Avoid crashes when, for some reason, a dll cannot be loaded. In this case a null pointer was returned by the internal code. This pointer is now tested against nullptr to avoid the application crashing. Fixes #12080 https://gitlab.com/kicad/code/kicad/issues/12080
2022-07-24 17:42:50 +00:00
return 0;
Support synchronous messaging over KIWAY EXPRESS. This allows us to make the various netlist and pcb update routines more atomic and less reliant on carefully sequenced asynchronous messages. This is also a prelude to adding support for footprint testing without a netlist.
2019-03-27 22:37:26 +00:00
// Update PCB requires a netlist. Therefore the schematic editor must be running
// If this is not the case, open the schematic editor
KIWAY_PLAYER* frame = Kiway().Player( FRAME_SCH, true );
Avoid crashes when, for some reason, a dll cannot be loaded. In this case a null pointer was returned by the internal code. This pointer is now tested against nullptr to avoid the application crashing. Fixes #12080 https://gitlab.com/kicad/code/kicad/issues/12080
2022-07-24 17:42:50 +00:00
// If Kiway() cannot create the eeschema frame, it shows a error message, and
// frame is null
if( !frame )
return -1;
Use IsShownOnScreen(), not IsShown(), if you really want to know if its visible.
2021-08-19 21:28:54 +00:00
if( !frame->IsShownOnScreen() )
Eeschema/Pcbnew: Update PCB From Schematics tool: ensure the netlist is reliable: warn user if a component is not annotated before exporting the netlist to Pcbnew (like in netlist creation dialog).
2016-10-22 18:02:15 +00:00
{
Pcbnew: fix issue when updating board from schematic. Fixes https://gitlab.com/kicad/code/kicad/issues/4607
2020-06-10 18:21:46 +00:00
wxFileName fn( Prj().GetProjectPath(), Prj().GetProjectName(),
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-28 02:10:01 +00:00
FILEEXT::KiCadSchematicFileExtension );
Support synchronous messaging over KIWAY EXPRESS. This allows us to make the various netlist and pcb update routines more atomic and less reliant on carefully sequenced asynchronous messages. This is also a prelude to adding support for footprint testing without a netlist.
2019-03-27 22:37:26 +00:00
Pcbnew: fix issue when updating board from schematic. Fixes https://gitlab.com/kicad/code/kicad/issues/4607
2020-06-10 18:21:46 +00:00
// Maybe the file hasn't been converted to the new s-expression file format so
// see if the legacy schematic file is still in play.
if( !fn.FileExists() )
{
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-28 02:10:01 +00:00
fn.SetExt( FILEEXT::LegacySchematicFileExtension );
Pcbnew: fix issue when updating board from schematic. Fixes https://gitlab.com/kicad/code/kicad/issues/4607
2020-06-10 18:21:46 +00:00
if( !fn.FileExists() )
{
DisplayError( this, _( "The schematic for this board cannot be found." ) );
Avoid crashes when, for some reason, a dll cannot be loaded. In this case a null pointer was returned by the internal code. This pointer is now tested against nullptr to avoid the application crashing. Fixes #12080 https://gitlab.com/kicad/code/kicad/issues/12080
2022-07-24 17:42:50 +00:00
return -2;
Pcbnew: fix issue when updating board from schematic. Fixes https://gitlab.com/kicad/code/kicad/issues/4607
2020-06-10 18:21:46 +00:00
}
}
frame->OpenProjectFiles( std::vector<wxString>( 1, fn.GetFullPath() ) );
Reimplement footprint checking on top of DRC architecture. This allows Import Netlist and Update PCB from Schematic to share the same checking code, and expose it through the DRC dialog. Fixes: lp:1685516 * https://bugs.launchpad.net/kicad/+bug/1685516 Fixes: lp:1809293 * https://bugs.launchpad.net/kicad/+bug/1809293
2019-03-28 19:30:51 +00:00
Support synchronous messaging over KIWAY EXPRESS. This allows us to make the various netlist and pcb update routines more atomic and less reliant on carefully sequenced asynchronous messages. This is also a prelude to adding support for footprint testing without a netlist.
2019-03-27 22:37:26 +00:00
// we show the schematic editor frame, because do not show is seen as
// a not yet opened schematic by Kicad manager, which is not the case
frame->Show( true );
Reimplement footprint checking on top of DRC architecture. This allows Import Netlist and Update PCB from Schematic to share the same checking code, and expose it through the DRC dialog. Fixes: lp:1685516 * https://bugs.launchpad.net/kicad/+bug/1685516 Fixes: lp:1809293 * https://bugs.launchpad.net/kicad/+bug/1809293
2019-03-28 19:30:51 +00:00
// bring ourselves back to the front
Cleanup re-annotation code style
2020-08-09 16:13:17 +00:00
Raise();
ADDED: Geographic Reannotation
2020-04-21 01:44:17 +00:00
}
Cleanup re-annotation code style
2020-08-09 16:13:17 +00:00
Avoid crashes when, for some reason, a dll cannot be loaded. In this case a null pointer was returned by the internal code. This pointer is now tested against nullptr to avoid the application crashing. Fixes #12080 https://gitlab.com/kicad/code/kicad/issues/12080
2022-07-24 17:42:50 +00:00
return 1; //Success!
ADDED: Geographic Reannotation
2020-04-21 01:44:17 +00:00
}
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
bool PCB_EDIT_FRAME::FetchNetlistFromSchematic( NETLIST& aNetlist,
const wxString& aAnnotateMessage )
ADDED: Geographic Reannotation
2020-04-21 01:44:17 +00:00
{
A few performance improvements from profiling. Most of them are very small; the removal of the Fracture() in DRC_TEST_PROVIDER_COPPER_CLEARANCE::testZonesToZones() is the only significant one.
2023-09-29 20:54:59 +00:00
int standalone = TestStandalone();
if( standalone == 0 )
Mostly formatting cleanup but a few type-casting cleanups too.
2020-11-24 22:16:41 +00:00
{
Inform user (and bail on UpdatePCB) if annotation failed. Fixes https://gitlab.com/kicad/code/kicad/issues/7310
2021-03-01 16:53:12 +00:00
DisplayErrorMessage( this, _( "Cannot update the PCB because PCB editor is opened in "
"stand-alone mode. In order to create or update PCBs from "
"schematics, you must launch the KiCad project manager and "
"create a project." ) );
return false; // Not in standalone mode
Support synchronous messaging over KIWAY EXPRESS. This allows us to make the various netlist and pcb update routines more atomic and less reliant on carefully sequenced asynchronous messages. This is also a prelude to adding support for footprint testing without a netlist.
2019-03-27 22:37:26 +00:00
}
One-click PCB update improvements - Fix repetitive undo/redo segfaults & assertions. - Add Update menu entry on PCB side. - Fix Python build error - Add spread footprints after updating
2016-01-29 14:43:40 +00:00
A few performance improvements from profiling. Most of them are very small; the removal of the Fracture() in DRC_TEST_PROVIDER_COPPER_CLEARANCE::testZonesToZones() is the only significant one.
2023-09-29 20:54:59 +00:00
if( standalone < 0 ) // Problem with Eeschema or the schematic
Avoid crashes when, for some reason, a dll cannot be loaded. In this case a null pointer was returned by the internal code. This pointer is now tested against nullptr to avoid the application crashing. Fixes #12080 https://gitlab.com/kicad/code/kicad/issues/12080
2022-07-24 17:42:50 +00:00
return false;
Inform user (and bail on UpdatePCB) if annotation failed. Fixes https://gitlab.com/kicad/code/kicad/issues/7310
2021-03-01 16:53:12 +00:00
Raise(); // Show
Support synchronous messaging over KIWAY EXPRESS. This allows us to make the various netlist and pcb update routines more atomic and less reliant on carefully sequenced asynchronous messages. This is also a prelude to adding support for footprint testing without a netlist.
2019-03-27 22:37:26 +00:00
Implement more precise annotation-required messages. Also moves the message to an infobar so it's more noticeable. Fixes https://gitlab.com/kicad/code/kicad/issues/7332
2021-01-30 16:30:35 +00:00
std::string payload( aAnnotateMessage );
Support synchronous messaging over KIWAY EXPRESS. This allows us to make the various netlist and pcb update routines more atomic and less reliant on carefully sequenced asynchronous messages. This is also a prelude to adding support for footprint testing without a netlist.
2019-03-27 22:37:26 +00:00
Kiway().ExpressMail( FRAME_SCH, MAIL_SCH_GET_NETLIST, payload, this );
One-click PCB update improvements - Fix repetitive undo/redo segfaults & assertions. - Add Update menu entry on PCB side. - Fix Python build error - Add spread footprints after updating
2016-01-29 14:43:40 +00:00
Inform user (and bail on UpdatePCB) if annotation failed. Fixes https://gitlab.com/kicad/code/kicad/issues/7310
2021-03-01 16:53:12 +00:00
if( payload == aAnnotateMessage )
{
Raise();
DisplayErrorMessage( this, aAnnotateMessage );
return false;
}
Support synchronous messaging over KIWAY EXPRESS. This allows us to make the various netlist and pcb update routines more atomic and less reliant on carefully sequenced asynchronous messages. This is also a prelude to adding support for footprint testing without a netlist.
2019-03-27 22:37:26 +00:00
try
{
auto lineReader = new STRING_LINE_READER( payload, _( "Eeschema netlist" ) );
KICAD_NETLIST_READER netlistReader( lineReader, &aNetlist );
netlistReader.LoadNetlist();
}
Display a nice error message instead of asserting When we mess up, it will be nice to not lose users' data. This requests a bug report if the netlist parsing breaks instead of throwing
2021-09-01 19:02:06 +00:00
catch( const IO_ERROR& e )
Support synchronous messaging over KIWAY EXPRESS. This allows us to make the various netlist and pcb update routines more atomic and less reliant on carefully sequenced asynchronous messages. This is also a prelude to adding support for footprint testing without a netlist.
2019-03-27 22:37:26 +00:00
{
Inform user (and bail on UpdatePCB) if annotation failed. Fixes https://gitlab.com/kicad/code/kicad/issues/7310
2021-03-01 16:53:12 +00:00
Raise();
Display a nice error message instead of asserting When we mess up, it will be nice to not lose users' data. This requests a bug report if the netlist parsing breaks instead of throwing
2021-09-01 19:02:06 +00:00
// Do not translate extra_info strings. These are for developers
More wxString wide literals.
2022-02-04 22:44:59 +00:00
wxString extra_info = e.Problem() + wxT( " : " ) + e.What() + wxT( " at " ) + e.Where();
Display a nice error message instead of asserting When we mess up, it will be nice to not lose users' data. This requests a bug report if the netlist parsing breaks instead of throwing
2021-09-01 19:02:06 +00:00
DisplayErrorMessage( this, _( "Received an error while reading netlist. Please "
"report this issue to the KiCad team using the menu "
"Help->Report Bug."), extra_info );
Support synchronous messaging over KIWAY EXPRESS. This allows us to make the various netlist and pcb update routines more atomic and less reliant on carefully sequenced asynchronous messages. This is also a prelude to adding support for footprint testing without a netlist.
2019-03-27 22:37:26 +00:00
return false;
One-click PCB update improvements - Fix repetitive undo/redo segfaults & assertions. - Add Update menu entry on PCB side. - Fix Python build error - Add spread footprints after updating
2016-01-29 14:43:40 +00:00
}
Support synchronous messaging over KIWAY EXPRESS. This allows us to make the various netlist and pcb update routines more atomic and less reliant on carefully sequenced asynchronous messages. This is also a prelude to adding support for footprint testing without a netlist.
2019-03-27 22:37:26 +00:00
return true;
}
Convert ShowEEschema to an ACTION so it can get a hotkey assignment. Fixes: lp:1686010 * https://bugs.launchpad.net/kicad/+bug/1686010
2019-07-08 23:43:08 +00:00
void PCB_EDIT_FRAME::RunEeschema()
Add Open-Schematic tool to PcbNew. Fixes: lp:1780610 * https://bugs.launchpad.net/kicad/+bug/1780610
2018-07-22 21:33:01 +00:00
{
wxString msg;
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
wxFileName schematic( Prj().GetProjectPath(), Prj().GetProjectName(),
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-28 02:10:01 +00:00
FILEEXT::KiCadSchematicFileExtension );
Add Open-Schematic tool to PcbNew. Fixes: lp:1780610 * https://bugs.launchpad.net/kicad/+bug/1780610
2018-07-22 21:33:01 +00:00
Handle dimensions in Edit Text and Graphics Properties. Fixes https://gitlab.com/kicad/code/kicad/issues/6340
2020-11-09 20:32:08 +00:00
if( !schematic.FileExists() )
Add Open-Schematic tool to PcbNew. Fixes: lp:1780610 * https://bugs.launchpad.net/kicad/+bug/1780610
2018-07-22 21:33:01 +00:00
{
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
wxFileName legacySchematic( Prj().GetProjectPath(), Prj().GetProjectName(),
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-28 02:10:01 +00:00
FILEEXT::LegacySchematicFileExtension );
Handle dimensions in Edit Text and Graphics Properties. Fixes https://gitlab.com/kicad/code/kicad/issues/6340
2020-11-09 20:32:08 +00:00
if( legacySchematic.FileExists() )
{
schematic = legacySchematic;
}
else
{
Fix some problematic double-quotes.
2021-06-07 22:14:29 +00:00
msg.Printf( _( "Schematic file '%s' not found." ), schematic.GetFullPath() );
Move multiple wxMessageBox to DisplayErrorMessage Also provide protection for headless running in multiple callsites Fixes https://gitlab.com/kicad/code/kicad/issues/13575
2023-01-19 00:53:16 +00:00
DisplayErrorMessage( this, msg );
Handle dimensions in Edit Text and Graphics Properties. Fixes https://gitlab.com/kicad/code/kicad/issues/6340
2020-11-09 20:32:08 +00:00
return;
}
Add Open-Schematic tool to PcbNew. Fixes: lp:1780610 * https://bugs.launchpad.net/kicad/+bug/1780610
2018-07-22 21:33:01 +00:00
}
if( Kiface().IsSingle() )
{
New paramaterized interface doesn't like quoted parameters. (At least on MSW, anyway.)
2021-10-02 13:08:36 +00:00
ExecuteFile( EESCHEMA_EXE, schematic.GetFullPath() );
Add Open-Schematic tool to PcbNew. Fixes: lp:1780610 * https://bugs.launchpad.net/kicad/+bug/1780610
2018-07-22 21:33:01 +00:00
}
else
{
KIWAY_PLAYER* frame = Kiway().Player( FRAME_SCH, false );
// Please: note: DIALOG_EDIT_LIBENTRY_FIELDS_IN_LIB::initBuffers() calls
// Kiway.Player( FRAME_SCH, true )
// therefore, the schematic editor is sometimes running, but the schematic project
// is not loaded, if the library editor was called, and the dialog field editor was used.
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
// On Linux, it happens the first time the schematic editor is launched, if
Add Open-Schematic tool to PcbNew. Fixes: lp:1780610 * https://bugs.launchpad.net/kicad/+bug/1780610
2018-07-22 21:33:01 +00:00
// library editor was running, and the dialog field editor was open
// On Windows, it happens always after the library editor was called,
// and the dialog field editor was used
if( !frame )
{
try
{
frame = Kiway().Player( FRAME_SCH, true );
}
catch( const IO_ERROR& err )
{
Move multiple wxMessageBox to DisplayErrorMessage Also provide protection for headless running in multiple callsites Fixes https://gitlab.com/kicad/code/kicad/issues/13575
2023-01-19 00:53:16 +00:00
DisplayErrorMessage( this, _( "Eeschema failed to load." ) + wxS( "\n" ) + err.What() );
Add Open-Schematic tool to PcbNew. Fixes: lp:1780610 * https://bugs.launchpad.net/kicad/+bug/1780610
2018-07-22 21:33:01 +00:00
return;
}
}
Avoid crashes when, for some reason, a dll cannot be loaded. In this case a null pointer was returned by the internal code. This pointer is now tested against nullptr to avoid the application crashing. Fixes #12080 https://gitlab.com/kicad/code/kicad/issues/12080
2022-07-24 17:42:50 +00:00
// If Kiway() cannot create the eeschema frame, it shows a error message, and
// frame is null
if( !frame )
return;
Use IsShownOnScreen(), not IsShown(), if you really want to know if its visible.
2021-08-19 21:28:54 +00:00
if( !frame->IsShownOnScreen() ) // the frame exists, (created by the dialog field editor)
// but no project loaded.
Add Open-Schematic tool to PcbNew. Fixes: lp:1780610 * https://bugs.launchpad.net/kicad/+bug/1780610
2018-07-22 21:33:01 +00:00
{
Handle dimensions in Edit Text and Graphics Properties. Fixes https://gitlab.com/kicad/code/kicad/issues/6340
2020-11-09 20:32:08 +00:00
frame->OpenProjectFiles( std::vector<wxString>( 1, schematic.GetFullPath() ) );
Add Open-Schematic tool to PcbNew. Fixes: lp:1780610 * https://bugs.launchpad.net/kicad/+bug/1780610
2018-07-22 21:33:01 +00:00
frame->Show( true );
}
// On Windows, Raise() does not bring the window on screen, when iconized or not shown
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
// On Linux, Raise() brings the window on screen, but this code works fine
Add Open-Schematic tool to PcbNew. Fixes: lp:1780610 * https://bugs.launchpad.net/kicad/+bug/1780610
2018-07-22 21:33:01 +00:00
if( frame->IsIconized() )
{
frame->Iconize( false );
Fix broken autosave when board is modified. Fixes https://gitlab.com/kicad/code/kicad/-/issues/12700
2022-10-22 19:49:03 +00:00
Add Open-Schematic tool to PcbNew. Fixes: lp:1780610 * https://bugs.launchpad.net/kicad/+bug/1780610
2018-07-22 21:33:01 +00:00
// If an iconized frame was created by Pcbnew, Iconize( false ) is not enough
// to show the frame at its normal size: Maximize should be called.
frame->Maximize( false );
}
frame->Raise();
}
}
Ensure the environment variables are synchronized between KiCad and Python Before this, the environment variables inside Python wouldn't reflect the updates to them made after the interpreter was started in Pcbnew. This will call into Python and set the variables when they are changed, since Python can't synchronize itself when running in an embedded interpreter. Fixes https://gitlab.com/kicad/code/kicad/issues/5071
2020-08-09 18:49:26 +00:00
void PCB_EDIT_FRAME::PythonSyncEnvironmentVariables()
{
Fix Python environment variable handling The variables in the common settings struct are only updated on save, so Python must use the ones from Pgm to get its values. This does lead to the observation that Python's changes to the variables do affect KiCad (they can break resolvers). So apparently it can mess with us but we can't mess with it easily. Also, improve the environment variable tracing infrastructure to capture more changes.
2020-08-11 23:11:48 +00:00
const ENV_VAR_MAP& vars = Pgm().GetLocalEnvVariables();
Ensure the environment variables are synchronized between KiCad and Python Before this, the environment variables inside Python wouldn't reflect the updates to them made after the interpreter was started in Pcbnew. This will call into Python and set the variables when they are changed, since Python can't synchronize itself when running in an embedded interpreter. Fixes https://gitlab.com/kicad/code/kicad/issues/5071
2020-08-09 18:49:26 +00:00
Kicad: fix environment variable changes after running Pcbnew in some cases. When pcbnew is built with python support, the env vars defined inside Kicad (and used mainly in paths) are rewritten for the python environment. Unfortunately, the values are rewritten as UTF8 string, but in Kicad they are just expected in utf32 unicode values. This is now fixed by rewriting the initial values in Kicad env, after the python environment is initialized.
2020-11-18 16:33:58 +00:00
// Set the environment variables for python scripts
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
// note: the string will be encoded UTF8 for python env
Cleanup.
2022-04-09 12:59:59 +00:00
for( const std::pair<const wxString, ENV_VAR_ITEM>& var : vars )
Working python window
2021-03-08 14:54:22 +00:00
UpdatePythonEnvVar( var.first, var.second.GetValue() );
Kicad: fix environment variable changes after running Pcbnew in some cases. When pcbnew is built with python support, the env vars defined inside Kicad (and used mainly in paths) are rewritten for the python environment. Unfortunately, the values are rewritten as UTF8 string, but in Kicad they are just expected in utf32 unicode values. This is now fixed by rewriting the initial values in Kicad env, after the python environment is initialized.
2020-11-18 16:33:58 +00:00
More NULL expunging.
2021-07-19 23:56:05 +00:00
// Because the env vars can be modified by the python scripts (rewritten in UTF8),
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
// regenerate them (in Unicode) for our normal environment
Cleanup.
2022-04-09 12:59:59 +00:00
for( const std::pair<const wxString, ENV_VAR_ITEM>& var : vars )
Kicad: fix environment variable changes after running Pcbnew in some cases. When pcbnew is built with python support, the env vars defined inside Kicad (and used mainly in paths) are rewritten for the python environment. Unfortunately, the values are rewritten as UTF8 string, but in Kicad they are just expected in utf32 unicode values. This is now fixed by rewriting the initial values in Kicad env, after the python environment is initialized.
2020-11-18 16:33:58 +00:00
wxSetEnv( var.first, var.second.GetValue() );
Ensure the environment variables are synchronized between KiCad and Python Before this, the environment variables inside Python wouldn't reflect the updates to them made after the interpreter was started in Pcbnew. This will call into Python and set the variables when they are changed, since Python can't synchronize itself when running in an embedded interpreter. Fixes https://gitlab.com/kicad/code/kicad/issues/5071
2020-08-09 18:49:26 +00:00
}
void PCB_EDIT_FRAME::PythonSyncProjectName()
{
wxString evValue;
wxGetEnv( PROJECT_VAR_NAME, &evValue );
Working python window
2021-03-08 14:54:22 +00:00
UpdatePythonEnvVar( wxString( PROJECT_VAR_NAME ).ToStdString(), evValue );
Kicad: fix environment variable changes after running Pcbnew in some cases. When pcbnew is built with python support, the env vars defined inside Kicad (and used mainly in paths) are rewritten for the python environment. Unfortunately, the values are rewritten as UTF8 string, but in Kicad they are just expected in utf32 unicode values. This is now fixed by rewriting the initial values in Kicad env, after the python environment is initialized.
2020-11-18 16:33:58 +00:00
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
// Because PROJECT_VAR_NAME can be modified by the python scripts (rewritten in UTF8),
// regenerate it (in Unicode) for our normal environment
Kicad: fix environment variable changes after running Pcbnew in some cases. When pcbnew is built with python support, the env vars defined inside Kicad (and used mainly in paths) are rewritten for the python environment. Unfortunately, the values are rewritten as UTF8 string, but in Kicad they are just expected in utf32 unicode values. This is now fixed by rewriting the initial values in Kicad env, after the python environment is initialized.
2020-11-18 16:33:58 +00:00
wxSetEnv( PROJECT_VAR_NAME, evValue );
Ensure the environment variables are synchronized between KiCad and Python Before this, the environment variables inside Python wouldn't reflect the updates to them made after the interpreter was started in Pcbnew. This will call into Python and set the variables when they are changed, since Python can't synchronize itself when running in an embedded interpreter. Fixes https://gitlab.com/kicad/code/kicad/issues/5071
2020-08-09 18:49:26 +00:00
}
MODULE -> FOOTPRINT.
2020-11-13 15:15:52 +00:00
void PCB_EDIT_FRAME::ShowFootprintPropertiesDialog( FOOTPRINT* aFootprint )
Remove a useless file and move the 2 methods to suitable files.
2018-01-31 13:54:31 +00:00
{
More NULL expunging.
2021-07-19 23:56:05 +00:00
if( aFootprint == nullptr )
Remove a useless file and move the 2 methods to suitable files.
2018-01-31 13:54:31 +00:00
return;
Pcbnew: don't fallback to software rendering after changing footprint Fixes https://gitlab.com/kicad/code/kicad/-/issues/8915
2021-08-26 15:24:52 +00:00
DIALOG_FOOTPRINT_PROPERTIES::FP_PROPS_RETVALUE retvalue;
/*
* Make sure dlg is destroyed before GetCanvas->Refresh is called
* later or the refresh will try to modify its properties since
* they share a GL context.
*/
{
DIALOG_FOOTPRINT_PROPERTIES dlg( this, aFootprint );
Config Paths help is now inside the dialog, so we don't need quasimodal here anymore.
2022-08-14 21:54:27 +00:00
dlg.ShowModal();
Pcbnew: don't fallback to software rendering after changing footprint Fixes https://gitlab.com/kicad/code/kicad/-/issues/8915
2021-08-26 15:24:52 +00:00
retvalue = dlg.GetReturnValue();
}
Remove a useless file and move the 2 methods to suitable files.
2018-01-31 13:54:31 +00:00
Exorcise some instances of "modedit".
2020-11-16 00:45:43 +00:00
/*
* retvalue =
* FP_PROPS_UPDATE_FP to show Update Footprints dialog
Pcbnew: load write board netlist to file tool action dynamically. Loading this advanced configuration option statically will cause it to show up in the hotkey list even when the option is disabled. Creating the tool action at run time resolves this issue.
2021-03-29 13:04:41 +00:00
* FP_PROPS_CHANGE_FP to show Change Footprints dialog
Exorcise some instances of "modedit".
2020-11-16 00:45:43 +00:00
* FP_PROPS_OK for normal edit
Better fix than 86b631b3
2020-12-07 17:28:06 +00:00
* FP_PROPS_CANCEL if aborted
Exorcise some instances of "modedit".
2020-11-16 00:45:43 +00:00
* FP_PROPS_EDIT_BOARD_FP to load board footprint into Footprint Editor
* FP_PROPS_EDIT_LIBRARY_FP to load library footprint into Footprint Editor
Remove a useless file and move the 2 methods to suitable files.
2018-01-31 13:54:31 +00:00
*/
Naming updates.
2020-10-14 23:37:26 +00:00
if( retvalue == DIALOG_FOOTPRINT_PROPERTIES::FP_PROPS_OK )
Fix compile error when not on OSX.
2018-10-15 19:53:53 +00:00
{
// If something edited, push a refresh request
Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal.
2019-06-13 17:28:55 +00:00
GetCanvas()->Refresh();
Fix compile error when not on OSX.
2018-10-15 19:53:53 +00:00
}
Naming updates.
2020-10-14 23:37:26 +00:00
else if( retvalue == DIALOG_FOOTPRINT_PROPERTIES::FP_PROPS_EDIT_BOARD_FP )
Remove a useless file and move the 2 methods to suitable files.
2018-01-31 13:54:31 +00:00
{
The user can cancel the opening of many editors. Don't play dice with the devil. Fixes https://gitlab.com/kicad/code/kicad/-/issues/17989 (cherry picked from commit a99377c1ec2e55cf960f7eca6c058000d7e733f7)
2024-05-08 17:19:24 +00:00
if( KIWAY_PLAYER* frame = Kiway().Player( FRAME_FOOTPRINT_EDITOR, true ) )
{
FOOTPRINT_EDIT_FRAME* fp_editor = static_cast<FOOTPRINT_EDIT_FRAME*>( frame );
Remove a useless file and move the 2 methods to suitable files.
2018-01-31 13:54:31 +00:00
The user can cancel the opening of many editors. Don't play dice with the devil. Fixes https://gitlab.com/kicad/code/kicad/-/issues/17989 (cherry picked from commit a99377c1ec2e55cf960f7eca6c058000d7e733f7)
2024-05-08 17:19:24 +00:00
fp_editor->LoadFootprintFromBoard( aFootprint );
fp_editor->Show( true );
fp_editor->Raise(); // Iconize( false );
}
Remove a useless file and move the 2 methods to suitable files.
2018-01-31 13:54:31 +00:00
}
Naming updates.
2020-10-14 23:37:26 +00:00
else if( retvalue == DIALOG_FOOTPRINT_PROPERTIES::FP_PROPS_EDIT_LIBRARY_FP )
Allow editing of library footprint from board reference.
2018-10-15 14:28:53 +00:00
{
The user can cancel the opening of many editors. Don't play dice with the devil. Fixes https://gitlab.com/kicad/code/kicad/-/issues/17989 (cherry picked from commit a99377c1ec2e55cf960f7eca6c058000d7e733f7)
2024-05-08 17:19:24 +00:00
if( KIWAY_PLAYER* frame = Kiway().Player( FRAME_FOOTPRINT_EDITOR, true ) )
{
FOOTPRINT_EDIT_FRAME* fp_editor = static_cast<FOOTPRINT_EDIT_FRAME*>( frame );
Allow editing of library footprint from board reference.
2018-10-15 14:28:53 +00:00
The user can cancel the opening of many editors. Don't play dice with the devil. Fixes https://gitlab.com/kicad/code/kicad/-/issues/17989 (cherry picked from commit a99377c1ec2e55cf960f7eca6c058000d7e733f7)
2024-05-08 17:19:24 +00:00
fp_editor->LoadFootprintFromLibrary( aFootprint->GetFPID() );
fp_editor->Show( true );
fp_editor->Raise(); // Iconize( false );
}
Allow editing of library footprint from board reference.
2018-10-15 14:28:53 +00:00
}
Naming updates.
2020-10-14 23:37:26 +00:00
else if( retvalue == DIALOG_FOOTPRINT_PROPERTIES::FP_PROPS_UPDATE_FP )
Remove a useless file and move the 2 methods to suitable files.
2018-01-31 13:54:31 +00:00
{
Naming updates.
2020-10-14 23:37:26 +00:00
ShowExchangeFootprintsDialog( aFootprint, true, true );
Remove a useless file and move the 2 methods to suitable files.
2018-01-31 13:54:31 +00:00
}
Naming updates.
2020-10-14 23:37:26 +00:00
else if( retvalue == DIALOG_FOOTPRINT_PROPERTIES::FP_PROPS_CHANGE_FP )
Remove a useless file and move the 2 methods to suitable files.
2018-01-31 13:54:31 +00:00
{
Naming updates.
2020-10-14 23:37:26 +00:00
ShowExchangeFootprintsDialog( aFootprint, false, true );
Remove a useless file and move the 2 methods to suitable files.
2018-01-31 13:54:31 +00:00
}
}
MODULE -> FOOTPRINT.
2020-11-13 15:15:52 +00:00
int PCB_EDIT_FRAME::ShowExchangeFootprintsDialog( FOOTPRINT* aFootprint, bool aUpdateMode,
bool aSelectedMode )
Move DIALOG_EXCHANGE_MODULE to dialogs dir DIALOG_EXCHANGE_MODULE class now has its own header file in the pcbnew/dialogs directory, and the xchgmod.cpp files was moved along with it. This has two aims: * (minor) Standardise the location of "base dialog" derived classes, like most other dialogs in KiCad. * (major) Allow inclusion of this dialog class into both legacy-mode pcbframe.cpp and into GAL tools.
2017-01-31 07:55:02 +00:00
{
MODULE -> FOOTPRINT.
2020-11-13 15:15:52 +00:00
DIALOG_EXCHANGE_FOOTPRINTS dialog( this, aFootprint, aUpdateMode, aSelectedMode );
Move DIALOG_EXCHANGE_MODULE to dialogs dir DIALOG_EXCHANGE_MODULE class now has its own header file in the pcbnew/dialogs directory, and the xchgmod.cpp files was moved along with it. This has two aims: * (minor) Standardise the location of "base dialog" derived classes, like most other dialogs in KiCad. * (major) Allow inclusion of this dialog class into both legacy-mode pcbframe.cpp and into GAL tools.
2017-01-31 07:55:02 +00:00
return dialog.ShowQuasiModal();
}
Implement primitive icon scaling for high DPI This is meant as a stopgap for 5.0, with plans to add proper scaled icons in the 6.0 cycle. A function KiScaledBitmap() is added, which works like KiBitmap() except it scales the bitmap according to the calling window's font size. Controls have been added to all the main applications to let the user select scaling manually (these were omitted from smaller apps that didn't already have a place to put them). In addition, in eeschema only, the pixel height of the system font is shown in the options dialog for diagnostics. This is only for collecting feedback before 5.0 release from users with different displays and will be removed.
2018-01-08 04:05:03 +00:00
Pcbnew, Update footprint: fix broken initialization of fields (especially ref and value) - Revert commit 86e0e1cc, broken - add comments to avoid a similar mistake - ensure Reference and Value are correctly handled. Fixes #15091 https://gitlab.com/kicad/code/kicad/-/issues/15091
2023-07-01 10:29:02 +00:00
/**
* copy text settings from aSrc to aDest
* @param aSrc is the PCB_TEXT source
* @param aDest is the PCB_TEXT target
Fix incorrect comment. No code change.
2023-07-01 12:17:57 +00:00
* @param aResetText is true to keep the default target text (false to use the aSrc text)
* @param aResetTextLayers is true to keep the default target layers setting
* (false to use the aSrc setting)
* @param aResetTextEffects is true to keep the default target text effects
* (false to use the aSrc effect)
Pcbnew, Update footprint: fix broken initialization of fields (especially ref and value) - Revert commit 86e0e1cc, broken - add comments to avoid a similar mistake - ensure Reference and Value are correctly handled. Fixes #15091 https://gitlab.com/kicad/code/kicad/-/issues/15091
2023-07-01 10:29:02 +00:00
* @param aUpdated is a refrence to a bool to keep trace of changes
*/
static void processTextItem( const PCB_TEXT& aSrc, PCB_TEXT& aDest,
bool aResetText, bool aResetTextLayers, bool aResetTextEffects,
bool* aUpdated )
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
{
Pcbnew, Update footprint: fix broken initialization of fields (especially ref and value) - Revert commit 86e0e1cc, broken - add comments to avoid a similar mistake - ensure Reference and Value are correctly handled. Fixes #15091 https://gitlab.com/kicad/code/kicad/-/issues/15091
2023-07-01 10:29:02 +00:00
if( aResetText )
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
*aUpdated |= aSrc.GetText() != aDest.GetText();
Pcbnew, Update footprint: fix broken initialization of fields (especially ref and value) - Revert commit 86e0e1cc, broken - add comments to avoid a similar mistake - ensure Reference and Value are correctly handled. Fixes #15091 https://gitlab.com/kicad/code/kicad/-/issues/15091
2023-07-01 10:29:02 +00:00
else
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
aDest.SetText( aSrc.GetText() );
Pcbnew, Update footprint: fix broken initialization of fields (especially ref and value) - Revert commit 86e0e1cc, broken - add comments to avoid a similar mistake - ensure Reference and Value are correctly handled. Fixes #15091 https://gitlab.com/kicad/code/kicad/-/issues/15091
2023-07-01 10:29:02 +00:00
if( aResetTextLayers )
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
{
*aUpdated |= aSrc.GetLayer() != aDest.GetLayer();
*aUpdated |= aSrc.IsVisible() != aDest.IsVisible();
Pcbnew, Update footprint: fix broken initialization of fields (especially ref and value) - Revert commit 86e0e1cc, broken - add comments to avoid a similar mistake - ensure Reference and Value are correctly handled. Fixes #15091 https://gitlab.com/kicad/code/kicad/-/issues/15091
2023-07-01 10:29:02 +00:00
}
else
{
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
aDest.SetLayer( aSrc.GetLayer() );
aDest.SetVisible( aSrc.IsVisible() );
}
Pcbnew, Update footprint: fix broken initialization of fields (especially ref and value) - Revert commit 86e0e1cc, broken - add comments to avoid a similar mistake - ensure Reference and Value are correctly handled. Fixes #15091 https://gitlab.com/kicad/code/kicad/-/issues/15091
2023-07-01 10:29:02 +00:00
if( aResetTextEffects )
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
{
*aUpdated |= aSrc.GetHorizJustify() != aDest.GetHorizJustify();
*aUpdated |= aSrc.GetVertJustify() != aDest.GetVertJustify();
*aUpdated |= aSrc.GetTextSize() != aDest.GetTextSize();
*aUpdated |= aSrc.GetTextThickness() != aDest.GetTextThickness();
*aUpdated |= aSrc.GetTextAngle() != aDest.GetTextAngle();
Collapse FP_* down into their PCB_* equivalents.
2023-03-30 11:49:23 +00:00
*aUpdated |= aSrc.GetFPRelativePosition() != aDest.GetFPRelativePosition();
Pcbnew, Update footprint: fix broken initialization of fields (especially ref and value) - Revert commit 86e0e1cc, broken - add comments to avoid a similar mistake - ensure Reference and Value are correctly handled. Fixes #15091 https://gitlab.com/kicad/code/kicad/-/issues/15091
2023-07-01 10:29:02 +00:00
}
else
{
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
// Careful: the visible bit and position are also set by SetAttributes()
bool visible = aDest.IsVisible();
aDest.SetAttributes( aSrc );
aDest.SetVisible( visible );
Collapse FP_* down into their PCB_* equivalents.
2023-03-30 11:49:23 +00:00
aDest.SetFPRelativePosition( aSrc.GetFPRelativePosition() );
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
}
aDest.SetLocked( aSrc.IsLocked() );
}
Pcbnew, Update footprint: fix broken initialization of fields (especially ref and value) - Revert commit 86e0e1cc, broken - add comments to avoid a similar mistake - ensure Reference and Value are correctly handled. Fixes #15091 https://gitlab.com/kicad/code/kicad/-/issues/15091
2023-07-01 10:29:02 +00:00
static PCB_TEXT* getMatchingTextItem( PCB_TEXT* aRefItem, FOOTPRINT* aFootprint )
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
{
Collapse FP_* down into their PCB_* equivalents.
2023-03-30 11:49:23 +00:00
std::vector<PCB_TEXT*> candidates;
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
for( BOARD_ITEM* item : aFootprint->GraphicalItems() )
{
dyn_cast<PCB_TEXT*> won't find PCB_FIELDs. We really should get rid of dyn_cast entirely.... Fixes https://gitlab.com/kicad/code/kicad/-/issues/15052
2023-06-24 14:48:27 +00:00
PCB_TEXT* candidate = dynamic_cast<PCB_TEXT*>( item );
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
if( candidate && candidate->GetText() == aRefItem->GetText() )
candidates.push_back( candidate );
}
if( candidates.size() == 0 )
return nullptr;
if( candidates.size() == 1 )
return candidates[0];
// Try refining the match by layer
Collapse FP_* down into their PCB_* equivalents.
2023-03-30 11:49:23 +00:00
std::vector<PCB_TEXT*> candidatesOnSameLayer;
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
Collapse FP_* down into their PCB_* equivalents.
2023-03-30 11:49:23 +00:00
for( PCB_TEXT* candidate : candidates )
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
{
if( candidate->GetLayer() == aRefItem->GetLayer() )
candidatesOnSameLayer.push_back( candidate );
}
if( candidatesOnSameLayer.size() == 1 )
return candidatesOnSameLayer[0];
// Last ditch effort: refine by position
Collapse FP_* down into their PCB_* equivalents.
2023-03-30 11:49:23 +00:00
std::vector<PCB_TEXT*> candidatesAtSamePos;
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
Collapse FP_* down into their PCB_* equivalents.
2023-03-30 11:49:23 +00:00
for( PCB_TEXT* candidate : candidatesOnSameLayer.size() ? candidatesOnSameLayer : candidates )
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
{
Collapse FP_* down into their PCB_* equivalents.
2023-03-30 11:49:23 +00:00
if( candidate->GetFPRelativePosition() == aRefItem->GetFPRelativePosition() )
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
candidatesAtSamePos.push_back( candidate );
}
if( candidatesAtSamePos.size() > 0 )
return candidatesAtSamePos[0];
else if( candidatesOnSameLayer.size() > 0 )
return candidatesOnSameLayer[0];
else
return candidates[0];
}
void PCB_EDIT_FRAME::ExchangeFootprint( FOOTPRINT* aExisting, FOOTPRINT* aNew,
BOARD_COMMIT& aCommit, bool deleteExtraTexts,
bool resetTextLayers, bool resetTextEffects,
bool resetFabricationAttrs, bool reset3DModels,
bool* aUpdated )
{
PCB_GROUP* parentGroup = aExisting->GetParentGroup();
bool dummyBool = false;
if( !aUpdated )
aUpdated = &dummyBool;
if( parentGroup )
{
parentGroup->RemoveItem( aExisting );
parentGroup->AddItem( aNew );
}
aNew->SetParent( GetBoard() );
PlaceFootprint( aNew, false );
// PlaceFootprint will move the footprint to the cursor position, which we don't want. Copy
// the original position across.
aNew->SetPosition( aExisting->GetPosition() );
if( aNew->GetLayer() != aExisting->GetLayer() )
aNew->Flip( aNew->GetPosition(), GetPcbNewSettings()->m_FlipLeftRight );
if( aNew->GetOrientation() != aExisting->GetOrientation() )
aNew->SetOrientation( aExisting->GetOrientation() );
aNew->SetLocked( aExisting->IsLocked() );
// Now transfer the net info from "old" pads to the new footprint
for( PAD* pad : aNew->Pads() )
{
PAD* pad_model = nullptr;
// Pads with no copper are never connected to a net
if( !pad->IsOnCopperLayer() )
{
pad->SetNetCode( NETINFO_LIST::UNCONNECTED );
continue;
}
// Pads with no numbers are never connected to a net
if( pad->GetNumber().IsEmpty() )
{
pad->SetNetCode( NETINFO_LIST::UNCONNECTED );
continue;
}
// Search for a similar pad on a copper layer, to reuse net info
PAD* last_pad = nullptr;
while( true )
{
pad_model = aExisting->FindPadByNumber( pad->GetNumber(), last_pad );
if( !pad_model )
break;
if( pad_model->IsOnCopperLayer() ) // a candidate is found
break;
last_pad = pad_model;
}
if( pad_model )
{
pad->SetLocalRatsnestVisible( pad_model->GetLocalRatsnestVisible() );
pad->SetPinFunction( pad_model->GetPinFunction() );
pad->SetPinType( pad_model->GetPinType() );
}
pad->SetNetCode( pad_model ? pad_model->GetNetCode() : NETINFO_LIST::UNCONNECTED );
}
for( BOARD_ITEM* item : aExisting->GraphicalItems() )
{
dyn_cast<PCB_TEXT*> won't find PCB_FIELDs. We really should get rid of dyn_cast entirely.... Fixes https://gitlab.com/kicad/code/kicad/-/issues/15052
2023-06-24 14:48:27 +00:00
PCB_TEXT* srcItem = dynamic_cast<PCB_TEXT*>( item );
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
if( srcItem )
{
Fix handling of dimensions in footprint updater Fixes https://gitlab.com/kicad/code/kicad/-/issues/16448
2023-12-26 19:08:39 +00:00
// Dimensions have PCB_TEXT base but are not treated like texts in the updater
if( dynamic_cast<PCB_DIMENSION_BASE*>( srcItem ) )
continue;
Collapse FP_* down into their PCB_* equivalents.
2023-03-30 11:49:23 +00:00
PCB_TEXT* destItem = getMatchingTextItem( srcItem, aNew );
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
if( destItem )
{
processTextItem( *srcItem, *destItem, false, resetTextLayers, resetTextEffects,
aUpdated );
}
else if( !deleteExtraTexts )
{
Fix handling of dimensions in footprint updater Fixes https://gitlab.com/kicad/code/kicad/-/issues/16448
2023-12-26 19:08:39 +00:00
aNew->Add( static_cast<BOARD_ITEM*>( srcItem->Clone() ) );
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
}
}
}
Pcbnew, Update footprint: fix broken initialization of fields (especially ref and value) - Revert commit 86e0e1cc, broken - add comments to avoid a similar mistake - ensure Reference and Value are correctly handled. Fixes #15091 https://gitlab.com/kicad/code/kicad/-/issues/15091
2023-07-01 10:29:02 +00:00
// Copy reference. The initial text is always used, never resetted
processTextItem( aExisting->Reference(), aNew->Reference(),
false,
resetTextLayers, resetTextEffects, aUpdated );
// Copy value
processTextItem( aExisting->Value(), aNew->Value(),
// reset value text only when it is a proxy for the footprint ID
// (cf replacing value "MountingHole-2.5mm" with "MountingHole-4.0mm")
aExisting->GetValue() == aExisting->GetFPID().GetLibItemName(),
resetTextLayers, resetTextEffects, aUpdated );
// Copy fields in accordance with the reset* flags
PCB Fields: fix up python, API Remove SetFields from both symbol and footprint, it doesn't handle mandatory fields and is unlikely to ever be safe.
2023-06-20 14:31:13 +00:00
for( PCB_FIELD* field : aExisting->GetFields() )
{
Pcbnew, Update footprint: fix broken initialization of fields (especially ref and value) - Revert commit 86e0e1cc, broken - add comments to avoid a similar mistake - ensure Reference and Value are correctly handled. Fixes #15091 https://gitlab.com/kicad/code/kicad/-/issues/15091
2023-07-01 10:29:02 +00:00
// Reference and value are already handled
if( field->IsReference() || field->IsValue() )
continue;
PCB Fields: fix up python, API Remove SetFields from both symbol and footprint, it doesn't handle mandatory fields and is unlikely to ever be safe.
2023-06-20 14:31:13 +00:00
PCB_FIELD* newField = aNew->GetFieldByName( field->GetName() );
if( !newField )
{
newField = new PCB_FIELD( *field );
aNew->Add( newField );
processTextItem( *field, *newField, true, true, true, aUpdated );
}
else
Pcbnew, Update footprint: fix broken initialization of fields (especially ref and value) - Revert commit 86e0e1cc, broken - add comments to avoid a similar mistake - ensure Reference and Value are correctly handled. Fixes #15091 https://gitlab.com/kicad/code/kicad/-/issues/15091
2023-07-01 10:29:02 +00:00
{
PCB Fields: fix up python, API Remove SetFields from both symbol and footprint, it doesn't handle mandatory fields and is unlikely to ever be safe.
2023-06-20 14:31:13 +00:00
processTextItem( *field, *newField, false, resetTextLayers, resetTextEffects, aUpdated );
Pcbnew, Update footprint: fix broken initialization of fields (especially ref and value) - Revert commit 86e0e1cc, broken - add comments to avoid a similar mistake - ensure Reference and Value are correctly handled. Fixes #15091 https://gitlab.com/kicad/code/kicad/-/issues/15091
2023-07-01 10:29:02 +00:00
}
PCB Fields: fix up python, API Remove SetFields from both symbol and footprint, it doesn't handle mandatory fields and is unlikely to ever be safe.
2023-06-20 14:31:13 +00:00
}
Update allow-solder-mask-bridges when updating footprint from library. Fixes https://gitlab.com/kicad/code/kicad/issues/14422
2023-03-26 12:27:24 +00:00
if( resetFabricationAttrs )
{
// We've replaced the existing footprint with the library one, so the fabrication attrs
// are already reset.
//
// We only have to do anything if resetFabricationAttrs is *not* set....
}
else
{
// Careful; allow-soldermask-bridges is in the m_attributes field but is not presented
// as a fabrication attribute in the GUI....
int libraryFlagsToKeep = aNew->GetAttributes() & FP_ALLOW_SOLDERMASK_BRIDGES;
int existingFlagsToKeep = aExisting->GetAttributes() & ~FP_ALLOW_SOLDERMASK_BRIDGES;
aNew->SetAttributes( existingFlagsToKeep | libraryFlagsToKeep );
}
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
Update allow-solder-mask-bridges when updating footprint from library. Fixes https://gitlab.com/kicad/code/kicad/issues/14422
2023-03-26 12:27:24 +00:00
if( reset3DModels )
{
// We've replaced the existing footprint with the library one, so the 3D models are
// already reset.
//
// We only have to do anything if reset3DModels is *not* set....
}
else
{
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
aNew->Models() = aExisting->Models(); // Linked list of 3D models.
Update allow-solder-mask-bridges when updating footprint from library. Fixes https://gitlab.com/kicad/code/kicad/issues/14422
2023-03-26 12:27:24 +00:00
}
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
// Updating other parameters
const_cast<KIID&>( aNew->m_Uuid ) = aExisting->m_Uuid;
aNew->SetPath( aExisting->GetPath() );
PCB: update footprint field when changing footprints Fixes: https://gitlab.com/kicad/code/kicad/-/issues/17598
2024-03-27 19:08:52 +00:00
aNew->SetSheetfile( aExisting->GetSheetfile() );
aNew->SetSheetname( aExisting->GetSheetname() );
aNew->SetFilters( aExisting->GetFilters() );
Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.
2023-01-24 12:54:05 +00:00
aCommit.Remove( aExisting );
aCommit.Add( aNew );
aNew->ClearFlags();
}
Update text variables even when they're changed from other binary. For instance, you might have PCBNew open but change the variable value through EEschema > Schematic Setup. Fixes https://gitlab.com/kicad/code/kicad/issues/4918
2020-07-17 20:04:14 +00:00
void PCB_EDIT_FRAME::CommonSettingsChanged( bool aEnvVarsChanged, bool aTextVarsChanged )
Implement primitive icon scaling for high DPI This is meant as a stopgap for 5.0, with plans to add proper scaled icons in the 6.0 cycle. A function KiScaledBitmap() is added, which works like KiBitmap() except it scales the bitmap according to the calling window's font size. Controls have been added to all the main applications to let the user select scaling manually (these were omitted from smaller apps that didn't already have a place to put them). In addition, in eeschema only, the pixel height of the system font is shown in the options dialog for diagnostics. This is only for collecting feedback before 5.0 release from users with different displays and will be removed.
2018-01-08 04:05:03 +00:00
{
Update text variables even when they're changed from other binary. For instance, you might have PCBNew open but change the variable value through EEschema > Schematic Setup. Fixes https://gitlab.com/kicad/code/kicad/issues/4918
2020-07-17 20:04:14 +00:00
PCB_BASE_EDIT_FRAME::CommonSettingsChanged( aEnvVarsChanged, aTextVarsChanged );
Implement primitive icon scaling for high DPI This is meant as a stopgap for 5.0, with plans to add proper scaled icons in the 6.0 cycle. A function KiScaledBitmap() is added, which works like KiBitmap() except it scales the bitmap according to the calling window's font size. Controls have been added to all the main applications to let the user select scaling manually (these were omitted from smaller apps that didn't already have a place to put them). In addition, in eeschema only, the pixel height of the system font is shown in the options dialog for diagnostics. This is only for collecting feedback before 5.0 release from users with different displays and will be removed.
2018-01-08 04:05:03 +00:00
Handle two panels both referencing same colour theme. Fixes https://gitlab.com/kicad/code/kicad/issues/5185
2020-09-20 23:11:44 +00:00
GetAppearancePanel()->OnColorThemeChanged();
Hook up 3D viewer to common preferences. Also removes nanny limits on text sizes. Fixes: lp:1794093 * https://bugs.launchpad.net/kicad/+bug/1794093 Fixes: lp:1794345 * https://bugs.launchpad.net/kicad/+bug/1794345
2018-09-25 19:23:54 +00:00
Remove bad static_cast. (m_settings isn't a PCBNEW_SETTINGS in non-PCB_EDIT_FRAMEs)
2022-07-24 15:49:46 +00:00
SetElementVisibility( LAYER_RATSNEST, GetPcbNewSettings()->m_Display.m_ShowGlobalRatsnest );
All the preferences, all the time. Fixes https://gitlab.com/kicad/code/kicad/issues/7877 Fixes https://gitlab.com/kicad/code/kicad/issues/5153
2021-08-29 23:33:08 +00:00
Remove bad static_cast. (m_settings isn't a PCBNEW_SETTINGS in non-PCB_EDIT_FRAMEs)
2022-07-24 15:49:46 +00:00
GetGalDisplayOptions().ReadWindowSettings( GetPcbNewSettings()->m_Window );
All the preferences, all the time. Fixes https://gitlab.com/kicad/code/kicad/issues/7877 Fixes https://gitlab.com/kicad/code/kicad/issues/5153
2021-08-29 23:33:08 +00:00
// Netclass definitions could have changed, either by us or by Eeschema, so we need to
// recompile the implicit rules
Make sure design rules get recompiled after netclass changes. Fixes https://gitlab.com/kicad/code/kicad/issues/7082
2021-01-13 12:07:06 +00:00
DRC_TOOL* drcTool = m_toolManager->GetTool<DRC_TOOL>();
WX_INFOBAR* infobar = GetInfoBar();
try
{
drcTool->GetDRCEngine()->InitEngine( GetDesignRulesPath() );
Generalize infobar MESSAGE_TYPE handling and use for DRC errors. Fixes https://gitlab.com/kicad/code/kicad/issues/8782
2021-08-01 20:51:08 +00:00
if( infobar->GetMessageType() == WX_INFOBAR::MESSAGE_TYPE::DRC_RULES_ERROR )
infobar->Dismiss();
Make sure design rules get recompiled after netclass changes. Fixes https://gitlab.com/kicad/code/kicad/issues/7082
2021-01-13 12:07:06 +00:00
}
Silence more unused exception var warnings
2021-02-20 16:58:12 +00:00
catch( PARSE_ERROR& )
Make sure design rules get recompiled after netclass changes. Fixes https://gitlab.com/kicad/code/kicad/issues/7082
2021-01-13 12:07:06 +00:00
{
wxHyperlinkCtrl* button = new wxHyperlinkCtrl( infobar, wxID_ANY, _( "Edit design rules" ),
wxEmptyString );
button->Bind( wxEVT_COMMAND_HYPERLINK, std::function<void( wxHyperlinkEvent& aEvent )>(
[&]( wxHyperlinkEvent& aEvent )
{
ShowBoardSetupDialog( _( "Custom Rules" ) );
} ) );
infobar->RemoveAllButtons();
infobar->AddButton( button );
infobar->AddCloseButton();
Generalize infobar MESSAGE_TYPE handling and use for DRC errors. Fixes https://gitlab.com/kicad/code/kicad/issues/8782
2021-08-01 20:51:08 +00:00
infobar->ShowMessage( _( "Could not compile custom design rules." ), wxICON_ERROR,
WX_INFOBAR::MESSAGE_TYPE::DRC_RULES_ERROR );
Make sure design rules get recompiled after netclass changes. Fixes https://gitlab.com/kicad/code/kicad/issues/7082
2021-01-13 12:07:06 +00:00
}
All the preferences, all the time. Fixes https://gitlab.com/kicad/code/kicad/issues/7877 Fixes https://gitlab.com/kicad/code/kicad/issues/5153
2021-08-29 23:33:08 +00:00
GetCanvas()->GetView()->MarkTargetDirty( KIGFX::TARGET_NONCACHED );
GetCanvas()->ForceRefresh();
Ensure the environment variables are synchronized between KiCad and Python Before this, the environment variables inside Python wouldn't reflect the updates to them made after the interpreter was started in Pcbnew. This will call into Python and set the variables when they are changed, since Python can't synchronize itself when running in an embedded interpreter. Fixes https://gitlab.com/kicad/code/kicad/issues/5071
2020-08-09 18:49:26 +00:00
// Update the environment variables in the Python interpreter
if( aEnvVarsChanged )
PythonSyncEnvironmentVariables();
Implement primitive icon scaling for high DPI This is meant as a stopgap for 5.0, with plans to add proper scaled icons in the 6.0 cycle. A function KiScaledBitmap() is added, which works like KiBitmap() except it scales the bitmap according to the calling window's font size. Controls have been added to all the main applications to let the user select scaling manually (these were omitted from smaller apps that didn't already have a place to put them). In addition, in eeschema only, the pixel height of the system font is shown in the options dialog for diagnostics. This is only for collecting feedback before 5.0 release from users with different displays and will be removed.
2018-01-08 04:05:03 +00:00
Layout();
SendSizeEvent();
}
Re-enabling lock/unlock context menus in legacy This partially reverts 36d36de and 3bac100, moving the legacy footprint lock/unlock code from the autorouter (which remains disabled) to pcb_edit_frame.
2018-05-02 16:06:10 +00:00
Add support for dark theme in plugin icons Action plugin authors can specify alternative icon path for dark theme. If it's not specified then standard icon will be used for both light and dark themes. If neither icon is specified then the default puzzle piece icon is used. Fixes #7984
2021-03-22 04:50:42 +00:00
void PCB_EDIT_FRAME::ThemeChanged()
{
PCB_BASE_EDIT_FRAME::ThemeChanged();
}
Ensure the environment variables are synchronized between KiCad and Python Before this, the environment variables inside Python wouldn't reflect the updates to them made after the interpreter was started in Pcbnew. This will call into Python and set the variables when they are changed, since Python can't synchronize itself when running in an embedded interpreter. Fixes https://gitlab.com/kicad/code/kicad/issues/5071
2020-08-09 18:49:26 +00:00
void PCB_EDIT_FRAME::ProjectChanged()
{
PythonSyncProjectName();
}
pcbnew: Hyperlynx Exporter - initial version
2019-04-08 00:09:07 +00:00
bool ExportBoardToHyperlynx( BOARD* aBoard, const wxFileName& aPath );
Convert remaining legacy drawing code to print code.
2019-05-31 12:15:25 +00:00
pcbnew: Hyperlynx Exporter - initial version
2019-04-08 00:09:07 +00:00
void PCB_EDIT_FRAME::OnExportHyperlynx( wxCommandEvent& event )
{
Convert remaining legacy drawing code to print code.
2019-05-31 12:15:25 +00:00
wxString wildcard = wxT( "*.hyp" );
pcbnew: Hyperlynx Exporter - initial version
2019-04-08 00:09:07 +00:00
wxFileName fn = GetBoard()->GetFileName();
fn.SetExt( wxT("hyp") );
Convert remaining legacy drawing code to print code.
2019-05-31 12:15:25 +00:00
wxFileDialog dlg( this, _( "Export Hyperlynx Layout" ), fn.GetPath(), fn.GetFullName(),
wildcard, wxFD_SAVE | wxFD_OVERWRITE_PROMPT );
pcbnew: Hyperlynx Exporter - initial version
2019-04-08 00:09:07 +00:00
if( dlg.ShowModal() != wxID_OK )
return;
fn = dlg.GetPath();
// always enforce filename extension, user may not have entered it.
Convert remaining legacy drawing code to print code.
2019-05-31 12:15:25 +00:00
fn.SetExt( wxT( "hyp" ) );
pcbnew: Hyperlynx Exporter - initial version
2019-04-08 00:09:07 +00:00
ExportBoardToHyperlynx( GetBoard(), fn );
}
Store the current filename in the history on close
2020-05-16 23:08:01 +00:00
wxString PCB_EDIT_FRAME::GetCurrentFileName() const
{
return GetBoard()->GetFileName();
}
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
bool PCB_EDIT_FRAME::LayerManagerShown()
{
Some more wxS
2023-01-17 00:07:41 +00:00
return m_auimgr.GetPane( wxS( "LayersManager" ) ).IsShown();
Migrate Pcbnew/footprint viewer/footprint editor to the new UI update system
2020-08-13 23:09:17 +00:00
}
Properties panel: post-rebase fixes and hide by default Remove layer widget re-added by Orson's rebase
2020-10-19 01:57:18 +00:00
bool PCB_EDIT_FRAME::PropertiesShown()
{
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
return m_auimgr.GetPane( PropertiesPaneName() ).IsShown();
Properties panel: post-rebase fixes and hide by default Remove layer widget re-added by Orson's rebase
2020-10-19 01:57:18 +00:00
}
Fix initial zoom to fit size in schematic and board editors. This may affect other EDA_DRAW_FRAME objects as well but it doesn't seem to be as noticeable in the symbol, footprint, and worksheet editors. Fixes https://gitlab.com/kicad/code/kicad/issues/5248
2020-08-20 14:33:12 +00:00
void PCB_EDIT_FRAME::onSize( wxSizeEvent& aEvent )
{
Use IsShownOnScreen(), not IsShown(), if you really want to know if its visible.
2021-08-19 21:28:54 +00:00
if( IsShownOnScreen() )
Fix initial zoom to fit size in schematic and board editors. This may affect other EDA_DRAW_FRAME objects as well but it doesn't seem to be as noticeable in the symbol, footprint, and worksheet editors. Fixes https://gitlab.com/kicad/code/kicad/issues/5248
2020-08-20 14:33:12 +00:00
{
// We only need this until the frame is done resizing and the final client size is
// established.
Unbind( wxEVT_SIZE, &PCB_EDIT_FRAME::onSize, this );
Separate immediate and delayed action dispatch Using a boolean argument just leads to a lot of trailing booleans in the function calls and is not user friendly. Instead, introduce PostAction() to send an action that runs after the coroutine (equivalent to passing false or the default argument), and leave RunAction as the immediate execution function.
2023-06-26 22:16:51 +00:00
GetToolManager()->RunAction( ACTIONS::zoomFitScreen );
Fix initial zoom to fit size in schematic and board editors. This may affect other EDA_DRAW_FRAME objects as well but it doesn't seem to be as noticeable in the symbol, footprint, and worksheet editors. Fixes https://gitlab.com/kicad/code/kicad/issues/5248
2020-08-20 14:33:12 +00:00
}
// Skip() is called in the base class.
EDA_DRAW_FRAME::OnSize( aEvent );
Fix broken autosave when board is modified. Fixes https://gitlab.com/kicad/code/kicad/-/issues/12700
2022-10-22 19:49:03 +00:00
}
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
DIALOG_BOOK_REPORTER* PCB_EDIT_FRAME::GetInspectDrcErrorDialog()
{
if( !m_inspectDrcErrorDlg )
m_inspectDrcErrorDlg = new DIALOG_BOOK_REPORTER( this, INSPECT_DRC_ERROR_DIALOG_NAME,
_( "Violation Report" ) );
return m_inspectDrcErrorDlg;
}
DIALOG_BOOK_REPORTER* PCB_EDIT_FRAME::GetInspectClearanceDialog()
{
if( !m_inspectClearanceDlg )
m_inspectClearanceDlg = new DIALOG_BOOK_REPORTER( this, INSPECT_CLEARANCE_DIALOG_NAME,
_( "Clearance Report" ) );
return m_inspectClearanceDlg;
}
DIALOG_BOOK_REPORTER* PCB_EDIT_FRAME::GetInspectConstraintsDialog()
{
if( !m_inspectConstraintsDlg )
m_inspectConstraintsDlg = new DIALOG_BOOK_REPORTER( this, INSPECT_CONSTRAINTS_DIALOG_NAME,
_( "Constraints Report" ) );
return m_inspectConstraintsDlg;
}
DIALOG_BOOK_REPORTER* PCB_EDIT_FRAME::GetFootprintDiffDialog()
{
if( !m_footprintDiffDlg )
m_footprintDiffDlg = new DIALOG_BOOK_REPORTER( this, FOOTPRINT_DIFF_DIALOG_NAME,
String and dialog layout fixes.
2023-12-13 16:07:09 +00:00
_( "Compare Footprint with Library" ) );
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
return m_footprintDiffDlg;
}
void PCB_EDIT_FRAME::onCloseModelessBookReporterDialogs( wxCommandEvent& aEvent )
{
if( m_inspectDrcErrorDlg && aEvent.GetString() == INSPECT_DRC_ERROR_DIALOG_NAME )
{
m_inspectDrcErrorDlg->Destroy();
m_inspectDrcErrorDlg = nullptr;
}
else if( m_inspectClearanceDlg && aEvent.GetString() == INSPECT_CLEARANCE_DIALOG_NAME )
{
m_inspectClearanceDlg->Destroy();
m_inspectClearanceDlg = nullptr;
}
else if( m_inspectConstraintsDlg && aEvent.GetString() == INSPECT_CONSTRAINTS_DIALOG_NAME )
{
m_inspectConstraintsDlg->Destroy();
m_inspectConstraintsDlg = nullptr;
}
else if( m_footprintDiffDlg && aEvent.GetString() == INSPECT_CONSTRAINTS_DIALOG_NAME )
{
m_footprintDiffDlg->Destroy();
m_footprintDiffDlg = nullptr;
}
}
DIALOG_NET_INSPECTOR* PCB_EDIT_FRAME::GetNetInspectorDialog()
{
if( !m_netInspectorDlg )
{
m_netInspectorDlg = new DIALOG_NET_INSPECTOR( this );
AddBoardChangeListener( m_netInspectorDlg );
}
return m_netInspectorDlg;
}
void PCB_EDIT_FRAME::onCloseNetInspectorDialog( wxCommandEvent& aEvent )
{
if( m_netInspectorDlg )
{
RemoveBoardChangeListener( m_netInspectorDlg );
m_netInspectorDlg->Destroy();
m_netInspectorDlg = nullptr;
}
}
void PCB_EDIT_FRAME::onUnitsChanged( wxCommandEvent& aEvent )
{
wxCommandEvent evt( EDA_EVT_UNITS_CHANGED );
if( m_netInspectorDlg )
m_netInspectorDlg->HandleWindowEvent( evt );
}