haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
39,315 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

1521 Commits

Author SHA1 Message Date
Jeff Young f076d07e9e Fix asserts. 2022-02-24 18:16:45 +00:00
Jeff Young f18aae679c Use router to update message panel when routing. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10068
 2022-02-20 16:50:30 +00:00
Jeff Young a2ca8cf413 Improve SNR. 2022-02-12 18:38:11 +00:00
Jeff Young 8dcc933fc3 Don't use bounding box cache during insideArea. 
For starters we can't rely on it having been updated, but we also
cache the entire result so there's no huge cost-savings anyway.

Fixes https://gitlab.com/kicad/code/kicad/issues/10821
 2022-02-12 18:38:11 +00:00
Marek Roszko 0a5ddb8d40 Add some vector reservations 2022-02-05 21:12:29 -05:00
Jeff Young b2e3f03222 More wide-string declarations. 2022-02-05 22:03:04 +00:00
Seth Hillbrand 92dc06ac9d Don't convert KIID on the fly 
Converting to string on save prevent unneeded ops

(cherry picked from commit 901685f01b)
 2022-02-03 10:35:31 -08:00
Seth Hillbrand 803675195d Be more diligent in preventing drag line errors 
They can happen even when there are no collisions, so we need to reset
the 'ok' flag before using the line again.

Fixes https://gitlab.com/kicad/code/kicad/issues/9555

(cherry picked from commit 833ce19221)
 2022-01-31 16:13:53 -08:00
Jeff Young 5739505aa3 TextBoxes for PCBNew. 2022-01-31 20:00:47 +00:00
Seth Hillbrand ad84b62b63 Prevent multiple single-point line solutions 
Suggested by @rivimey, we test the case where both lines return singular
point lines and prevent them leaking into our drag solution

Fixes https://gitlab.com/kicad/code/kicad/issues/9555

(cherry picked from commit 38a4894d92)
 2022-01-29 07:07:29 -08:00
Seth Hillbrand 7277fd6218 Don't allow degenerate lines in dragger 
If walkaround returns an invalid line, don't consider it for a track

Fixes https://gitlab.com/kicad/code/kicad/issues/9555

(cherry picked from commit 8ae304dcca)
 2022-01-28 15:19:06 -08:00
Tomasz Wlostowski 441e5fd486 router: don't reject non-45 degree lines in the LINE_PLACER 2022-01-22 00:28:11 +01:00
Tomasz Wlostowski ce28525172 router: include arc approximation tollerance in arc hull clearance calculation 
fixes: https://gitlab.com/kicad/code/kicad/-/issues/10470
 2022-01-22 00:28:11 +01:00
Jeff Young 14006495d5 Angle cleanup. 2022-01-20 22:35:41 +00:00
Jeff Young e61144d45a Finish with EDA_ANGLE. 2022-01-16 21:15:40 +00:00
Jeff Young e84c574830 Some more EDA_ANGLE cleanup. 2022-01-16 19:16:18 +00:00
Jeff Young 1539fa5af2 Move SHAPE_ARC to EDA_ANGLE. 2022-01-16 01:19:45 +00:00
Jeff Young 07013d00e1 More EDA_ANGLE. 2022-01-14 16:08:19 +00:00
Jeff Young abd3f5bc2b Move footprints to EDA_ANGLE. 2022-01-14 16:08:18 +00:00
Jeff Young d485eb2514 Move pads to EDA_ANGLE. 2022-01-14 16:08:18 +00:00
Jon Evans eac1936303 PNS: Do not clear layer pairs when importing new sizes 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10225

(cherry picked from commit 20bbf9b179)
 2022-01-13 20:38:08 -05:00
Jon Evans 3011ae1d51 PNS: Do not allow smart pads when in 90-degree mode 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10386

(cherry picked from commit cf4d46b24d)
 2022-01-13 20:38:01 -05:00
Tomasz Wlostowski 79fe0bf456 router: use VIA::PushoutForce() for via push force calculation in the shove algorithm 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10317
 2022-01-13 00:43:27 +01:00
Tomasz Wlostowski 4d0a317e3d router: fix via force propagation for vias where hole clearance > copper clearance 2022-01-13 00:42:50 +01:00
Jeff Young eb58d7e44c Text glyph caches and bug fixes. 
1) Unify metrics between stroke and outline fonts
2) Unify handling of rotation and mirroring
3) Bug fixes in collision handling
4) Use of VECTOR2I (instead of VECTOR2D) for world-coordinates
5) Generate outline font overbar with rounded ends and fix rotation
bugs
6) Generate wxEVT_CHOICE events from FONT_CHOICE::SetFontSelection
7) Change text-item PNS SOLIDs to use compound shapes
 2022-01-08 16:47:45 +00:00
Jeff Young 72340fcee2 Implement router and DRC collisions for outline fonts. 2022-01-08 16:47:45 +00:00
Jon Evans 60c0891c5f Exit router and invoke edit tool when attempting to drag an arc track 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10208

(cherry picked from commit 45182febaf)
 2022-01-02 16:10:50 -05:00
Marek Roszko c4c56de708 Neurotically update position wxPoint usages 2022-01-01 11:55:51 -05:00
Ian McInerney f744ddd11d Fix copy-paste error in PNS mouse trail tracer 
And also fix indentation of control flow.
 2021-12-31 00:04:11 +00:00
Ian McInerney 0e9cfd0af2 Add missing initialization values to variables 
Flagged by Coverity.
 2021-12-30 23:42:06 +00:00
Jeff Young 5e4a704155 Remove some more duplicated preferences. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10112
 2021-12-26 13:37:28 +00:00
Jeff Young 2538ad16aa Handle router collisions with filled shapes. 2021-12-24 21:10:28 +00:00
Jeff Young ed79f6e511 Clean up some TODOs. 2021-12-24 21:10:28 +00:00
Jeff Young 9ee28ea8f5 Flatten out some more preferences. 2021-12-24 15:43:20 +00:00
Tomasz Wlostowski 57af990066 router: fix layer switch issue when starting a track on via without fixed segments 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9915
 2021-12-16 00:55:17 +01:00
Mike Williams 956ac871c3 PCB Editor: changes to track width overrides starting track width 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8797
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8797
 2021-12-15 23:32:48 +00:00
Tomasz Wlostowski 97c2627de6 router: added missing case items (fixes regression in component dragging) 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10010
 2021-12-15 23:18:55 +01:00
Tomasz Wlostowski 965ab42938 router: when dragging segments, don't snap to other segments on the same layer. Fixes drag flickering for short segments. 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9720
 2021-12-15 01:48:04 +01:00
Tomasz Wlostowski 2ae3a83b54 router: fix use-after-free crash in single trace shove routing when m_endItem's owning NODE is erased by the springback algorithm. 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9994
 2021-12-15 01:33:05 +01:00
Jon Evans b291d6c810 Fix success conditions in DP placer 
The placer can sometimes generate segments that are not quite parallel.
Use a different tolerance for ApproxParallel to account for this.

Also set a minimum score for placement judging so that any placement
that doesn't violate DRC can be placed.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9948
 2021-12-12 13:05:38 -05:00
jean-pierre charras 6d0d4e0db9 Pcbnew, router tool: ensure switching layer by + or - works when starting routing. 
Fixes #9936
https://gitlab.com/kicad/code/kicad/issues/9936
 2021-12-11 09:54:03 +01:00
Seth Hillbrand 77fbb495f2 Highlight net during inline drag 
Keep consistent UX between inline drag and drag started in the router
tool itself by highlighting the net being dragged

Fixes https://gitlab.com/kicad/code/kicad/issues/9919
 2021-12-09 09:28:43 -08:00
Jeff Young 95087c6de5 Fix clearance outlines for router head. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9885
 2021-12-06 15:51:53 +00:00
Jon Evans 5ba215c8ea Use actual width when previewing PNS lines 2021-12-05 13:41:39 -05:00
Jon Evans 7de9e48b57 PNS: Fix tuning calculations through locked segments 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9727
 2021-12-05 13:35:28 -05:00
Jeff Young 5cb2641142 Fix nullptr dereference in router. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9844
 2021-12-02 13:20:44 +00:00
Jeff Young a596a1f2e2 ROUTER_TOOL needs to handle pads not handled by router itself. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9839
 2021-12-01 22:25:02 +00:00
Jeff Young 3c0b10b022 Don't use approximated shapes for router hulls. 
We only do 45-degree routing anyway so we might as well build an
octagonal-based hull from the get-go.

Fixes https://gitlab.com/kicad/code/kicad/issues/7672

Fixes https://gitlab.com/kicad/code/kicad/issues/9544

Fixes https://gitlab.com/kicad/code/kicad/issues/9833
 2021-12-01 19:44:30 +00:00
Jeff Young 09ed60feb3 Don't make inferences about object type based on shape. 2021-12-01 19:44:30 +00:00
Ian McInerney 63560ecd7b Remove RM_Smart state from router tool 
It was never fully implemented and there was no way to switch into this
route mode.
 2021-12-01 09:52:37 +00:00
Jon Evans a746d31038 PNS: Fix loop removal outside shove mode 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9680
 2021-11-27 15:21:47 -05:00
Jon Evans 8a0f8c329f PNS: Fix DP gateway generation when pad distance < gap 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9306
 2021-11-27 14:03:19 -05:00
Seth Hillbrand 4b226b8172 Unify our breakTracks routines 
Fixes https://gitlab.com/kicad/code/kicad/issues/9793
 2021-11-27 06:34:47 -08:00
Jeff Young 6652e5acf4 Draw pad holes when dragging. 
Most of the time they're under the pad, but the provide needed
info when the hole is larger than the pad.

Fixes https://gitlab.com/kicad/code/kicad/issues/9786
 2021-11-27 00:55:09 +00:00
Jeff Young 9547c72e73 Teach router about different keepout rules. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9786
 2021-11-27 00:55:04 +00:00
Jeff Young 99ec2b1801 Don't hide original object when highlight is only part of it. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9772
 2021-11-25 23:42:13 +00:00
Jon Evans da458535c4 PNS: Avoid flickering clearances on new items 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9773
 2021-11-25 15:38:04 -05:00
Jon Evans 63718323bc PNS: Holes need to be moved with solids 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9773
 2021-11-25 15:31:18 -05:00
Jon Evans b4342d813b Fix SHAPE_LINE_CHAIN::Slice when end is an arc followed by a point 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9770
 2021-11-25 10:05:33 -05:00
Jeff Young ade8fe4333 When dragging footprints pads with holes also need to be taken along. 
Otherwise (aside from not colliding with their dragged location) we
won't update their locations and then if they happen to be the first
pad in the footprint we'll try to update the footprint's location post-
drag with the pad offset (which will be {0,0}.

This is easily reproducible with the test document in the bug in the
"fixes" statement.

Fixes https://gitlab.com/kicad/code/kicad/issues/9391
 2021-11-25 14:54:12 +00:00
Jeff Young f9e1429c60 Naming conventions. 2021-11-25 14:54:12 +00:00
Jeff Young 5985a21b74 Offset internal items by drag amount. 
Some tools move only preview items while keeping the real items
hidden.  Those tools must use this new offset parameter.

Other tools move the real items.  Those tools can ignore this
parameter (which will default to {0,0}).

Fixes https://gitlab.com/kicad/code/kicad/issues/9391
 2021-11-25 14:54:12 +00:00
Jeff Young ba6ae4fa9b Kicad has many plugins. This one is for the pcb. 2021-11-25 12:56:46 +00:00
Jeff Young 1c3e1df3ca Not all holes are round. 
We currently only need this to work for vias as we're a long way
from being able to support it for pads, so just check the hole
shape.

Fixes https://gitlab.com/kicad/code/kicad/issues/9735
 2021-11-23 14:36:05 +00:00
Tomasz Wlostowski e56e61ffb5 router: fix typo in the DP tuning fix patch 2021-11-23 00:21:38 +01:00
Tomasz Wlostowski 89228e1ebe router: increase parallelity detection threshold for AssembleDiffPair() 
Partially fixes the misrecognized diff pairs issue.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8567
 2021-11-22 01:35:12 +01:00
Tomasz Wlostowski e60386f028 router: disable 'limit corner count' optimization for via dragging 
It seems to be completely preventing optimization instead of preventing over-optimization in case the head is a dragged via.
To be investigated in more details in V7.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8665
 2021-11-22 00:05:17 +01:00
Tomasz Wlostowski ccf9a72078 router: fix ghost dots issue in router preview items 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8665
 2021-11-22 00:05:17 +01:00
Roberto Fernandez Bautista bbafce6ab3 PNS: Don't clip the line in the middle of an arc - just start again 
In shove mode, returning an empty line results in keeping the current
head, which should be okay for now.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9023
 2021-11-21 19:53:03 +00:00
Roberto Fernandez Bautista 4e0ad07eb0 PNS::Shove Add margin when generating hulls for arc segments 
Partially fixes https://gitlab.com/kicad/code/kicad/-/issues/9023

There is still a case where if the shover does not find a solution,
we try clipping the arc and it still collides.
 2021-11-21 17:13:21 +00:00
Jon Evans b1878fcc54 ClipVertexRange: fix fallout of NextShape API change 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9711
 2021-11-21 11:03:22 -05:00
jean-pierre charras 302c5ab537 Fix an issue created by commit 9e3362d1. 
the issue was the graphic cursor was locked on the first snap point
in route mode, once a snap point is found.
 2021-11-21 15:37:03 +01:00
Tomasz Wlostowski c40e921cb3 router: remeber to make a shove lockpoint when placing a lone via 
Note to self: works around a possible bug in CommitPlacement()/RewindToLastLockedNode()

fixes: https://gitlab.com/kicad/code/kicad/-/issues/9695
 2021-11-21 00:18:20 +01:00
Jeff Young 9e3362d14c Snap mouse point before picking startItem. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9700
 2021-11-20 13:44:16 +00:00
Jeff Young 1f4858c314 Show holes in router preview items for vias. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9658
 2021-11-20 12:21:24 +00:00
Jon Evans ed478f5ec0 Revert to ERROR_INSIDE for complex pad shape hulls in PNS 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9544
 2021-11-15 19:15:05 -05:00
Jon Evans 8ec3ce99ae PNS: Update shover when autocompleting on item 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9598
 2021-11-10 18:17:56 -05:00
Jon Evans 59807d8d26 A better solution to discarding pending shove operations 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9553
 2021-11-09 00:00:54 -05:00
Johannes Pfister 64f77b3596 PNS: Add support for 90-degree corner modes 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6902
 2021-11-03 02:14:23 +00:00
Jon Evans 153594b9ea PNS: Actually implement the AbortRouting API 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9425
 2021-10-31 16:06:57 -04:00
Jon Evans 08700e3522 Router: show corner style in message panel 2021-10-30 09:08:52 -04:00
Jon Evans e6c3027531 Action string typo fixes 2021-10-30 08:47:36 -04:00
jean-pierre charras 63d4d84aaa pcbnew, router: fix a crash and some other issues related to microvias and blind/buried vias 
- fix crash when trying to create a microvia from a internal layer (boards with > 4 layers)
- fix a bug that allowed to create a non through hole via on only one layer
- fix a bug that allowed to create a microvia on non adjacent layer pair
- when placing a via and selecting the target layer from dialog, show only allowed layers.
Fixes #9477
https://gitlab.com/kicad/code/kicad/issues/9477
 2021-10-29 17:54:04 +02:00
Electro707 4afb59fda0 Added feature to switch between router modes 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9414
 2021-10-28 22:46:05 +00:00
Jon Evans 4a9b3d9673 PNS: clear leftover vias from previous trace in DP placer 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9283
 2021-10-27 21:58:42 -04:00
Jeff Young 36d11f745e Update ratsnest while dragging footprints. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9391
 2021-10-25 21:45:30 +01:00
Jon Evans 328d3d0d77 PNS: Fix rule resolution when starting from PTH 
Have to use the routing start layer, not the first
layer of the PTH, to get the appropriate sizes
 2021-10-23 22:46:31 -04:00
Jon Evans 3b18dce911 Remove vestigal setting 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9444
 2021-10-23 22:12:25 -04:00
Seth Hillbrand 2a6c73b8df Check for hole before highlighting 
Fixes https://gitlab.com/kicad/code/kicad/issues/9423
 2021-10-19 11:25:00 -07:00
Seth Hillbrand e9205a0740 Fix mistaken comparison in highlighting 
Need to compare between elements colliding

Fixes https://gitlab.com/kicad/code/kicad/issues/9413
 2021-10-18 13:38:27 -07:00
Seth Hillbrand faba2b06c2 Lock track width after placing segment 
We don't want to allow the full track width to change after placing a
segment when we are in follow-segment mode. This would require either
ripping up and re-solving the existing track or allowing potential DRC
errors.

Fixes https://gitlab.com/kicad/code/kicad/issues/9395
 2021-10-14 09:21:14 -07:00
Seth Hillbrand 35e90d0cf4 Allow changing router mode while routing 
Keeps shove active even when not using to allow switching modes during
routing.

Fixes https://gitlab.com/kicad/code/kicad/issues/9342
 2021-10-12 09:55:34 -07:00
Seth Hillbrand 7f1247a23c Update track width when changed 
Tracks starting from pads should change in response to the track width
changing despite having the "follow existing track" width selected.
 2021-10-12 09:55:34 -07:00
jean-pierre charras 4d6b1a4e36 pns_diff_pair_placer: fix empty message when a signal of a pair is not found. 
Fixes #9334
https://gitlab.com/kicad/code/kicad/issues/9334
 2021-10-08 14:57:01 +02:00
Seth Hillbrand a8ec3b58ed Use via's real drill value for hole size 
If the via drill is "Default" be sure to get the default value rather
than the placeholder

Fixes https://gitlab.com/kicad/code/kicad/issues/9313
 2021-10-06 11:00:58 -07:00
Roberto Fernandez Bautista 2e120528c8 Length Tuner: Allow single meander when it fits on its own 2021-09-28 18:50:31 +01:00
Roberto Fernandez Bautista 71156368c9 Length Tuner: Allow controlling the side of the meander using the cursor 
Also fixes an issue that did not allow single meanders to be placed
 2021-09-28 18:50:31 +01:00
Mike Williams 726f9ebe3d Pcbnew: Router tool should not block drag selection when idle 
The other drawing tools allow drag selection while idle. Also, it makes
it more obvious to the user when accidentally drag selecting while
routing than just doing nothing on a drag with the routing tool selected
and idle.
 2021-09-27 16:05:13 +00:00
Jeff Young 5f3c67bd2b Fill in some missing GetMsgPanelItems and make some others consistent. 
Also expunges a std::vector<MSG_PANEL_ITEM> cover type.
 2021-09-27 00:23:40 +01:00
Jon Evans a2ad204f4b Fix off-by-one in AssembleTuningPath 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9003
 2021-09-22 20:25:22 -04:00
Seth Hillbrand be799b49a8 Fix equality in dp matching 
A single count is found when dp ends with matching char.  .Right(0) will
return an empty wxString() which is still valid

Fixes https://gitlab.com/kicad/code/kicad/issues/9206
 2021-09-21 19:47:15 -07:00
Jon Evans cf53b053a1 Improve handling of dragging around locked segments 
Locked segments now are not modified if they weren't the start item.
If a locked segment is the start item, it is automatically unlocked.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9145
 2021-09-21 22:38:53 -04:00
Seth Hillbrand 22a29a42cf Generalize net DP matching 
The requirement of 1-2 numbers following P/N or +/- was arbitrary and
not needed.  We also add the _ to allowable suffixes to permit DP
matching of auto-renamed nets
 2021-09-20 15:30:47 -07:00
Roberto Fernandez Bautista dc1fd3d9ba PNS test app: Add logging information for curved track routing 2021-09-20 20:35:24 +01:00
Jon Evans 4d478d6f17 Fix ordering of initialization in length tuner 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9161
 2021-09-14 07:48:02 -04:00
Jeff Young fdfecf5932 Don't push view control settings to the previous active tool. 
See further comments in bug report.

Fixes https://gitlab.com/kicad/code/kicad/issues/9147
 2021-09-13 13:28:05 +01:00
Seth Hillbrand 092cdc0bb5 Move 45° limit to hotkey 
This assigns the "Tab" key to a general pcbnew 45° limitation.  Limit
can be enabled/disabled using context menu as well.

Removed the user preference for 45° limitation on graphic lines as that
is overlapping with the general limitation, which is not an editing
preference so much as a temporary adjustment to tool action.

Related to https://gitlab.com/kicad/code/kicad/-/issues/8490
 2021-09-05 13:42:51 -07:00
Tomasz Wlostowski a03b6f6fc9 router: use tail start point when saving the FIXED_TAIL 
fixes: https://gitlab.com/kicad/code/kicad/-/issues/8771
 2021-08-25 00:36:34 +02:00
Roberto Fernandez Bautista 4c17b7ab46 WALKAROUND::Route Check if path is empty before stepping 
singleStep expects a path with at least one point.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9020
 2021-08-24 20:17:19 +01:00
Jon Evans 09ea630d8e Don't log a potentially invalidated item 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9006
 2021-08-21 12:24:41 -04:00
Roberto Fernandez Bautista aa67abb681 PNS::NODE Use PointCount instead of calculating segment index manually 
There is no need to manually calculate the segment index - we know
that the last point that was added is the start point of the segment.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8945
 2021-08-13 19:09:33 +01:00
Roberto Fernandez Bautista 0120c5fa4b PNS Length Tuning: Recover original arc tracks after tuning 2021-08-09 21:10:33 +01:00
Jon Evans e91218b876 PNS: don't mark holes only if there's also a solid violation 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8874
 2021-08-08 15:41:39 -04:00
jean-pierre charras fa82fcb809 Router tool: ensure a internal layer exists when placing a microvia. 
Fix also a minor compil warning.
Fixes #8931
https://gitlab.com/kicad/code/kicad/issues/8931
 2021-08-07 20:29:49 +02:00
Jeff Young c51b1dad72 Generalize infobar MESSAGE_TYPE handling and use for DRC errors. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8782
 2021-08-01 21:51:39 +01:00
Jeff Young f221220fe2 Rename layer ids file. 
It hasn't had anything to do with colors or visibility for some time
now.
 2021-07-29 16:03:25 +01:00
Wayne Stambaugh 78e5e98ea0 Pass VECTOR2I objects by reference instead of on the stack. 2021-07-27 08:41:27 -04:00
Jeff Young 0fb864d596 Pull some name changes back from 7.0 to ease merging. 2021-07-21 20:58:59 +01:00
Wayne Stambaugh cf00319c85 More NULL expunging. 2021-07-20 07:27:18 -04:00
Jon Evans e61b1f03b8 PNS: Discard duplicate tracks in FixRoute 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8737
 2021-07-13 21:13:40 -04:00
Seth Hillbrand ff2e470a6e Remove virtual items from clearance calculations 
Extends 3ea970f8c9 to ensure that virtual items do not interfere with
DRC calculations while routing

Fixes https://gitlab.com/kicad/code/kicad/issues/8788
 2021-07-13 16:10:36 -07:00
Seth Hillbrand 3ea970f8c9 Don't add virtual items to the display 
By definition virtual vias should only exist in the backend, not
affecting users

Fixes https://gitlab.com/kicad/code/kicad/issues/8788
 2021-07-13 15:52:41 -07:00
luz paz 0446d35f0d Fix source comment/doc typos (follow-up) 
Found via `codespell -q 3 -S *.po,./thirdparty -L aactual,acount,aline,alocation,alog,anormal,anumber,aother,apoints,aparent,aray,dout,einstance,modul,ot,overide,serie,te,,tesselate,tesselator,tht`
 2021-07-13 10:48:17 +00:00
Jeff Young 2bd735b631 A little more safety in setting the router idle mode. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8765
 2021-07-09 10:26:12 +01:00
Jon Evans 00f1b609c4 PNS: Don't run fanout cleanup when manually forced 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8724
 2021-07-08 19:56:42 -04:00
Wayne Stambaugh 65c7958293 Coverity issue fixes. 
Issues #331869, #331875, #332203, #332159, #332171, #332180, and #332648.
 2021-07-08 08:33:08 -04:00
Jon Evans edc2be9018 Update width status when user choice changes 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8265
 2021-07-07 21:26:21 -04:00
Roberto Fernandez Bautista 4207165c26 Fix PNS deleting too many segments 
Don't exit the loop pre-emptively. Need to update lastLink.
 2021-07-07 19:54:19 +01:00
Roberto Fernandez Bautista cda26bd57b SHAPE_LINE_CHAIN::NextShape instead of explicitly calculating indices 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8738
 2021-07-07 19:46:47 +01:00
Roberto Fernandez Bautista 81fa40d659 Code style: Fix missing space 2021-07-05 20:39:42 +01:00
Roberto Fernandez Bautista 04ff8cde5e Drag & Fillet Tracks: Ignore mouse up / click events until move / drag 
Ensures that any click/mouse up events generated after clicking "OK"
in the "Override locks" dialog are ignored.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8123
 2021-07-05 20:29:25 +01:00
Jon Evans e0146f73b9 PNS: Pick up complete lines between pads when dragging components 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7614
 2021-07-03 20:00:54 -04:00
Jon Evans 91ea4a0569 PNS: Pick up segments directly between pads when dragging components 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7601
 2021-07-03 19:50:04 -04:00
Roberto Fernandez Bautista 3f73d8c2b5 SHAPE_LINE_CHAIN::Area() should always be positive 
The algorithm relied on the assumption that the points were
ordered anti-clockwise. When ordered in a clockwise fashion, the
result was correct but negative.

Refer to https://www.mathopenref.com/coordpolygonarea2.html
for more information.
 2021-07-03 19:37:50 +00:00
Roberto Fernandez Bautista c3051ba48a Refactor SHAPE_LINE_CHAIN to allow two shapes per point 
m_shapes now has two possible indices. The first one is populated if
the point is associated with an arc and the second index is populated
if the point is shared between two arcs.
 2021-07-03 19:37:50 +00:00
Jon Evans 252bf76452 Fix off-by-one in AssembleTuningPath 2021-07-03 14:37:52 -04:00
Jon Evans 3c59e452d6 PNS: Set tuned path correctly in skew tuner 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8708
 2021-07-03 14:06:30 -04:00
Jon Evans 277bf2b719 Add feedback showing current router state to the message panel 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8265
 2021-07-03 13:21:51 -04:00
Jeff Young 400f4ae506 Code cleanup. 2021-07-02 15:54:26 +01:00
Jeff Young 780a8a5154 Fix another place disallowing internal microvias. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8716
 2021-07-02 15:54:26 +01:00
jean-pierre charras 740b028180 pns_line_placer: do not constraint the 45deg of current segment in free angle mode. 
Fixes #8691
https://gitlab.com/kicad/code/kicad/issues/8691
 2021-07-01 16:38:31 +02:00
Roberto Fernandez Bautista 04b71f5167 Meander minimum spacing can be equal to track width + minimum clearance 
2x track width was too constraining in some scenarios

Also better wording "Min Spacing" to indicate to the user that
the actual spacing could be larger if there are any constraints.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8172
 2021-06-29 19:30:01 +01:00
Roberto Fernandez Bautista e402563087 Don't recalculate meander spacing. Use constrained value instead. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1776
 2021-06-29 19:30:01 +01:00
Jeff Young c159500101 Remove nags and make Sel Layer and add via commands uniform. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8686
 2021-06-28 19:17:01 +01:00
Jeff Young 0dfb5fcaf9 Error message cleanup. 
wxString::Format is redundant in a wxLogXXX call.
Error messages should generally be translatable.
Error messages should use generally consistent sentence forms.
 2021-06-26 22:53:24 +01:00
Jon Evans a7eb611744 Fix leftover vias in shove mode 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8597
 2021-06-23 22:13:35 -04:00
Jeff Young c6606a0582 Hook up delete to undo last segment when routing. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8362
 2021-06-19 11:37:20 +01:00
Jeff Young 096e342386 Prefix TRACK, ARC and VIA. 2021-06-11 22:07:02 +01:00
luz paz f968fc8719 Fix source comment / documentation typos 2021-06-09 19:32:58 +00:00
Marek Roszko d946d6e68f Cleanup some pgm_base.h includes 2021-06-08 21:56:00 -04:00
Marek Roszko 6e01ce84b9 Break out eda_item_flags.h, fix the typedef to std::uint32_t, fix some signed vars 2021-06-08 19:12:30 -04:00
Jon Evans 75ce97e260 Fix the last cause of duplicate segments when completing a route 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6863
 2021-06-07 20:34:09 -04:00
Seth Hillbrand d4edc70f65 Remove magic numbers where possible 
Constant scales will be pre-calculated during compilation, so we can
leave the actual formula in place without penalty
 2021-06-07 13:56:31 -07:00
Jon Evans 49c5130123 PNS: Implement final cleanup pass for redundant colinear segs 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6863
 2021-06-06 21:52:35 -04:00
Jon Evans 3c6b98a0d5 PNS: preserve auto-detected track width when changing via sizes 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8046
 2021-06-06 20:18:09 -04:00
Jon Evans 99710aba48 PNS: use slightly less greedy algo to reset the mouse trail 2021-06-06 19:47:52 -04:00
Jon Evans 6cb8154ec0 PNS: Remove code that broke width changes during placement 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8334
 2021-06-06 19:21:52 -04:00
Jon Evans 6789dac20b PNS: Keep most recent good placement around for a rainy day 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8562
 2021-06-06 18:56:33 -04:00
Jon Evans c9bc45f7ed PNS: Limit the maximum walkaround distance factor 
The constant chosen is somewhat arbitrary and may need
further tuning or a more complex algorithm, but in general
this will prevent churning when solutions can't be found or
a solution can be found but it is unrealistic (going around
the entire board)

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8558
 2021-06-06 16:03:03 -04:00
Jon Evans d32b9c1c25 Use debug group for line placer debug 2021-06-06 15:44:53 -04:00
Jon Evans f5185f6927 Revert part of the anti-churn change, it causes bad side-effects 
Further performance tuning could be useful but the part that
remains helps the most when hugging in large designs
 2021-06-06 15:44:53 -04:00
Marek Roszko 8377ebb0e1 Fix msvc warnings 2021-06-06 15:30:31 -04:00
Marek Roszko 10e60acf34 Clean up including of board_design_settings.h 2021-06-06 15:03:42 -04:00
Jon Evans 5349f47f95 PNS: Prevent walkaround churn in unsolvable situations 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8558
 2021-06-06 14:57:52 -04:00
Jon Evans 3475d0cebd PNS: Grab start item based on clearance if no direct hits found 
Fixes annoying "routing start point violates DRC" messages when
entering the router from the hotkey and not directly over a track.
 2021-06-06 14:57:52 -04:00
Jon Evans 17da050e69 Improve walkaround results when last point is inside the hull 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8563
 2021-06-06 12:55:32 -04:00
Jon Evans be61bf29dd Use more accurate hull shapes for round solids 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8561
 2021-06-06 09:53:51 -04:00
Marek Roszko b610b905fc Cleanup track.h includes 2021-06-06 09:06:55 -04:00
Jon Evans 3b7480c1c1 PNS: Invalidate start/end items after finishing a route 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8555
 2021-06-06 08:52:39 -04:00
Tomasz Wlostowski ab04e24f9a router: rhMarkObstacles should return a correct error status 
Long story short: a few days ago I fixed error handling in routeStep(), so it actually started to recognize the wrong error status returned
by rhMarkObstacles() and think that the trace is always incorrect.

fixes: https://gitlab.com/kicad/code/kicad/-/issues/8557
 2021-06-04 23:58:56 +02:00
Jeff Young 00791e1e37 Fix compile issues on clangd. 2021-06-03 23:41:06 +01:00
Marek Roszko 1c1ba25ffd Use char_str instead of c_str in previous commit 2021-06-03 18:13:35 -04:00
Marek Roszko daf510344f Fix build error due to pns changes 2021-06-03 18:05:48 -04:00
Tomasz Wlostowski 63fc7a1908 router: support for drag/walkaround/shove for joints between lines of different widths. 
fixes: https://gitlab.com/kicad/code/kicad/-/issues/1773
 2021-06-03 22:44:53 +02:00
Tomasz Wlostowski af26eab5fb router: even more debug in SHOVE 2021-06-03 22:44:53 +02:00
Tomasz Wlostowski a744857267 router: fix array out-of-bound error in HullIntersection() 
fixes: https://gitlab.com/kicad/code/kicad/-/issues/8538
 2021-06-03 22:44:53 +02:00
Tomasz Wlostowski 3e98c44636 router: LOGGER now stores UUIDs, not pointers to BOARD_ITEMs. 
Caused occasional crashes when saving the debug event log, as some of the BOARD_ITEMS could have been deleted before SaveLog call.
 2021-06-03 22:44:53 +02:00
Tomasz Wlostowski e5e588ebba router: temporarily export LINE::Walkaround() debug global variables 2021-06-03 22:44:53 +02:00
Tomasz Wlostowski 70ed5c1ae8 router: introduce concept of 'virtual' vias as a base for shoving/dragging joints of lines of different widths. 2021-06-03 22:44:53 +02:00
Ian McInerney 4f05262705 Cleanup includes in board.h and footprint.h 2021-06-03 20:19:52 +01:00
Marek Roszko 4df3cb912d Remove another leaky wx/log.h header 2021-06-03 08:11:15 -04:00
Marek Roszko cf2bb5692a Remove the wxLog calls from math/util.h for now 
This was leaking windows headers and partial wx headers to 1084 compilation units......
This also means math/util.h is leaking to 1084 compilation units which seems a bit high too.
 2021-06-01 18:44:22 -04:00
Jon Evans 247da631f9 Revert "Fix typo and clean up leftover tracks" 
This reverts commit ed66c0f14d.

Revert "Clean up co-linear tracks after finishing routing"

This reverts commit 1a102f03c0.

More complex solution needed

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8526
 2021-06-01 11:18:00 -04:00
Jon Evans 1a102f03c0 Clean up co-linear tracks after finishing routing 
This involved adding some extra infrastructure to be able
to handle the case where a track that is sitting in the
router's commit waiting to be added to the board actually
needs to be deleted instead.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8419
 2021-05-31 17:36:38 -04:00
Marek Roszko 382dca4e6f Fix uninitialized member warnings 
Based on PVS Studio report
 2021-05-30 20:01:01 -04:00
Tomasz Wlostowski 67f0bbc6d7 router: fixed crash in HullIntersection() when the path has 0 or 1 points. 
fixes: 8515
 2021-05-31 00:20:32 +02:00
Tomasz Wlostowski 614787caae router: clear head line geometry if current head routing failed + small improvement to follow-mouse optimization. 
Also added a lot of verbosity for the pns-log-viewer tool.

Fixes: 8511
 2021-05-31 00:18:42 +02:00
Tomasz Wlostowski dfd80e077c router: fix another corner case in LINE::Walkaround() (duplicated vertex triggered by feeding a closed loop as the input path) 
fixes: 1775
 2021-05-31 00:17:12 +02:00
Jon Evans 0da85ded2f PNS: Fix diff pair handling of microvias as start items 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8514
 2021-05-30 15:51:28 -04:00
Tomasz Wlostowski fcb89b99a3 router: walkaround algo should not copy the previous via position when the current iteration via placement fails. 
fixes: 7827
 2021-05-30 00:35:58 +02:00
Tomasz Wlostowski af2e163890 router: annotate source locations of WALKAROUND debug items 2021-05-30 00:35:54 +02:00
Jon Evans 3eb5a484e1 PNS: Don't clip tuning paths to pads on other layers 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8504
 2021-05-29 15:52:44 -04:00
Jon Evans 28f17c3ae6 PNS: Prevent wrong clearance being cached for new diff pairs 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8377
 2021-05-29 13:31:17 -04:00
Jon Evans 85ca85652d Do not add debug items to view if debug flag isn't enabled 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8510
 2021-05-29 12:40:24 -04:00
Jon Evans bd59da3642 PNS: Local min distance has a minimum points requirement 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8510
 2021-05-29 12:40:24 -04:00
Tomasz Wlostowski ebd957b08e router: rework router's debugging infrastructure to be more compatibile with the 'qa/pns/pns-log-viewer' tool. 
The log viewer tool lets you inspect all the intermediate stages of the routing algorithms. This patch:
- Adds source location tracking of the debug calls (need to use the PNS_DBG macro, sorry)
- Moves some wxLogTrace calls to DEBUG_DECORATOR::Message() so that messages can be displayed alongside the corresponding geometric shapes
 2021-05-29 00:13:24 +02:00
Tomasz Wlostowski 132eb53a40 router: clean some debug clutter 2021-05-29 00:13:24 +02:00
Tomasz Wlostowski b3caa3c4d4 router: fix ordering of colliding hulls in NODE::NearestObstacle() 
Replaced the generic SHAPE_LINE_CHAIN::Intersect() with PNS::HullIntersection() which correctly rejects
'non-penetrating' intersections.
 2021-05-29 00:13:24 +02:00
Tomasz Wlostowski e66bbfd1ec router: improve the feel of the walkaround algorithm 
Makes walkaround more 'huggy' - the trace being routed sticks to obstacles
instead of jumping around in uncontrollable way.
 2021-05-29 00:13:24 +02:00
Tomasz Wlostowski 8148b5d81f router: improvements in LINE::Walkaround() 
- Fix walk failure if the input path starts on the hull boundary
  (happens very often during tight walkaround)
- Input line can have a loop at the end now. Such condition happens when the routing
  destination point lies inside the hull of a colliding primitive.
 2021-05-29 00:13:24 +02:00
Tomasz Wlostowski d2ec3fc4ed router: P&S-specific hull/line interection function that correctly rejects segments/vertices that only touch the hull polygons without penetrating them 2021-05-29 00:13:24 +02:00
Tomasz Wlostowski 8c4361bbc6 router: adapt to new SHAPE_LINE_CHAIN::INTERSECTIONS structure 2021-05-29 00:13:24 +02:00
Jeff Young 5c9a73aa5e Correct position for grid even when we're not snapping to a point. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8125
 2021-05-25 21:57:19 +01:00
Jeff Young 4c69a74505 Force layers visible when routing on them. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8432
 2021-05-16 11:18:31 +01:00
david-beinder 75f49ba1b6 Add length tuner settings to toolbar context menu 2021-05-12 02:34:52 +00:00
Jon Evans bc6b9b527a Allow stackup height to be excluded from length calculations 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8384
 2021-05-10 22:11:58 -04:00
Jeff Young 7356f9568d Move grid disable modifier from ALT to CTRL. 
Also had to move the H/V/45 disable modifier from CTRL to SHIFT.

Fixes https://gitlab.com/kicad/code/kicad/issues/8124
 2021-05-09 20:17:40 +01:00
Jon Evans 1a45d9474b Don't show commands that cancel routing when routing is in progress 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8363
 2021-05-08 14:55:02 -04:00
Marek Roszko 03cf2b517f Enum class PAD_ATTR_T 
Renamed such that python stays the same
 2021-05-01 10:51:54 -04:00
Marek Roszko e20562b09b Some cleanup 2021-05-01 10:37:20 -04:00
Marek Roszko 21fde9b629 enum class PCB_SHAPE_TYPE_T 2021-04-30 22:36:12 -04:00
Tomasz Wlostowski a433451bd8 router: 'root line' tracking in the SHOVE algorithm. See comments for detailed explanation. 2021-04-27 14:13:16 +02:00
Tomasz Wlostowski 3a8744d054 router: introduce concept of a root lines in the OPTIMIZER. 
By 'root lines' we mean the oldest traceable ancestor of each track moved by the router
(i.e. after shoving for a while, the root of each shoved line is it's latest non-shoved version).

With this we can teach the OPTIMIZER more tricks, such as the LIMIT_CORNER_COUNT constraint. It ensures
the results of the optimization will not be less cornery than the original line, reducing the feeling
of the optimizer being too intrusive.
 2021-04-27 14:13:16 +02:00
Tomasz Wlostowski 76f8861e6e router: revert Seth's arc adjustment in StartDragging(). 
Fixes picking the last segment instead of the last vertex to drag (when one is requested).
I didn't notice any behaviour change of the dragger wrs to arcs.
 2021-04-27 14:13:16 +02:00
jean-pierre charras e27733587d Fix 2 minor Coverity warnings. 2021-04-23 19:57:36 +02:00
Jonathan Haas 075bd788eb Remove unused OBSTACLE_VISITOR::m_extraClearance 2021-04-23 01:53:09 +00:00
Ian McInerney ecd9bf696e Be consistent about using nullptr instead of 0 
0 can be too easily overloaded into an int, so ensure we use nullptr
when we mean pointers.
 2021-04-22 22:20:34 +01:00
Jon Evans cf47d665ea PNS: Dragged line needs to retain width 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8246
 2021-04-22 09:04:41 -04:00
Jon Evans 9b1890606d PNS: Do not allow resolved optimal values to go below board minimums 2021-04-21 22:43:26 -04:00
Jon Evans cbd7d698a9 Fix diff pair error message suffix suggestions 
We accept diff pairs that end in N/P, no underscore required
 2021-04-20 21:08:34 -04:00
Jon Evans 2535daf661 PNS: Account for via stack height in diff pair length tuner 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8256
 2021-04-20 19:31:10 -04:00
Jon Evans dd828bd964 PNS: Bring back original Highlight Collisions behavior 
From discussion with Tom, Jeff, and Wayne, it appears as though
we all agreed that Highlight Collisions should behave like it
did in 5.1, which is to say, always just highlight collisions,
never prevent them.  The Allow DRC Violations checkbox just
controls whether or not you can fix/commit the head line if it
has violations; you are not prevented from moving the head
line to violating positions in any case.

Right now, there does not seem to be much demand for a separate
"Stop at First Obstacle" mode since Walkaround basically does that
but better, but we agreed that if there is demand for it in the
future, it should be implemented as a new router mode rather than
a behavior of Highlight Collisions mode controlled by the Allow
DRC Violations checkbox.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/7828
 2021-04-18 21:01:07 -04:00
Tomasz Wlostowski 4538d78828 router: fix via shoving regression. 2021-04-19 00:43:30 +02:00
Tomasz Wlostowski 57de83897a router: VIA SetDrill() and SetPosition() must update the hole shape too. 2021-04-19 00:43:15 +02:00
Jon Evans ec6995697d PNS: even more free performance 
If this doesn't work, we have bigger problems
 2021-04-18 09:50:06 -04:00
Jon Evans 6425ad4118 PNS: Fix propagateDpHeadForces obstacle calculation 
Using a synthetic via here doesn't quite let us use VIA::PushoutForce
because it will use the wrong clearance, and also doesn't quite have
the logic we want.  I am not familiar enough with PushoutForce to know
if its logic is a bug in other cases, so instead I just brought in the
parts of its algorithm that are needed here.

Additionally, we prevent pushing more than once from a given obstacle,
which causes walkaround to be more successful when routing diff pairs
against a large collider such as a keepout area.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8232
 2021-04-17 22:37:30 -04:00
Jon Evans 5974446523 PNS: Let's make the r-tree work for us 
I'm not sure where the magic number of "4x worst" came from, but it's
been around forever.  This is extremely inefficient as it negates much
of the power of r-tree filtering in dense designs.  If we really trusted
it, we could set this just to worstClearance.  Keeping it above the worst
clearance by a little bit seems to provide enough of a speed improvement
to resolve the test cases I have, so I'll go with that for now.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/7777
 2021-04-17 21:37:11 -04:00
Jon Evans 1d7e5a0443 Fix merge error that prevented a previous change from working 2021-04-14 23:30:16 -04:00
Jon Evans 268d570941 PNS: keep last valid diff pair trace as current state 
This allows fixing/committing what is on screen even if the current
cursor position doesn't have a valid solution (the old behavior
would result in the current trace disappearing)
 2021-04-14 23:21:10 -04:00
Jon Evans c829dba88e PNS: Reduce minimum distance to start turn in diff pair placer 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8193
 2021-04-14 23:21:10 -04:00
Jon Evans cac4d70154 PNS: Respect fix-all in diff pair placer 2021-04-14 23:21:10 -04:00
Jon Evans 296a9df530 PNS: Pick up diff pair starting width from continuation track 2021-04-12 23:10:15 -04:00
Jon Evans 1d9ca181a2 PNS: Use existing seg direction if both DP segs are parallel 2021-04-12 22:34:13 -04:00
Jon Evans 311cde0984 Safety check suggested by Coverity 2021-04-12 20:42:50 -04:00
Jon Evans 2aa5e568e8 Refactoring 2021-04-12 20:40:05 -04:00
Jon Evans 73fb85a352 PNS: Calculate diff pair primitive orientation using anchors only 
The previous method fails if the primitive is an expanding or
contracting pair (diagonals going inward or outward) resulting in
incorrect orientation, which then leads to incorrect candidate
gateways being generated and no solution found.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8185
 2021-04-12 20:34:44 -04:00
Jon Evans 715c61ac9f PNS: Fix yet more arc edge cases 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8150
 2021-04-12 19:59:55 -04:00
Jon Evans 49a91414d7 PNS: Apply co-linear seg merging to drag operations 2021-04-11 22:32:11 -04:00
Jon Evans 1c431d9929 PNS: Fix some off-by-one errors with arc dragging 2021-04-11 22:12:53 -04:00
Jon Evans a26fc6d65d PNS: Fix several issues with arc dragging 
Do not merge vertices that belong to different arcs
Fix start segment identification after arcs
Fix free-angle drag after arc

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8173
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8150
 2021-04-11 17:56:40 -04:00
Jon Evans 7ba110bd77 PNS: Fix dragging of segments with arcs in line 2021-04-11 10:18:57 -04:00
Thomas Pointhuber a30894e5a1 Allow SHAPE_LINE_CHAIN and SHAPE_ARC to be mirrored using a SEG 2021-04-11 13:27:25 +00:00
Thomas Pointhuber fe8fbf1d5d Use arcs instead of line approximation for Miter shape 
TODO:

* The resulting line chain is broken with the arcs, and
this appears to be some subsequent issue I was not able to pin down.
* The requirement of a correction factor is not clear to me
 2021-04-11 13:27:25 +00:00
Jon Evans 5c448057c8 PNS: Prevent state flicker when starting drag 2021-04-10 16:31:39 -04:00
Jon Evans 7784d7cb12 PNS: Fix visible area restriction 
VIEW::GetBoundary() returns the entire view area, not the visible area.
Surprisingly, we had no API for this, so I added one.

Also, changed the dragger behavior to toggle between optimizing just the
modified area and optimizing the visible area, i.e. we will now never
optimize off-screen portions of the dragged track.
 2021-04-10 16:13:08 -04:00
Jon Evans 94afdcb92a PNS: Allow control of area-restricted drag optimization 
CHANGED: The interactive router settings now include a switch to
         enable or disable optimization of the entire dragged track,
         which is now disabled by default.  When enabled, the router
         will reroute the entire track (from the dragged segment to
         the closest pad/via in each direction) to be more optimal.
         When disabled, only the area around the dragged segment
         will be modified.

CHANGED: The "optimizer effort" slider is removed from the interactive
         router settings dialog, as this setting did not have any
         meaningful impact in most cases and was a source of confusion.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/5918
 2021-04-10 15:17:39 -04:00
Jeff Young dc0cf3b802 Clean up a confusing API. 
AllowDRCViolations is kept in any mode as a *setting*, but only
controls router behaviour when the mode is mark obstacles.

Fixes https://gitlab.com/kicad/code/kicad/issues/7795
 2021-04-10 11:08:02 +01:00
Jon Evans d878cbddbc PNS: a few forgotten cleanup items 2021-04-07 23:34:45 -04:00
Jon Evans c9040a5c53 PNS: fix some weirdness identified by PVS 2021-04-07 23:16:56 -04:00
Jon Evans d4957b112e PNS: Keep last valid drag solution in the node 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5450
 2021-04-07 21:59:23 -04:00
Jon Evans 26835f582c Some situations require more than one dummy 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7820
 2021-04-07 21:30:18 -04:00
Jon Evans 9432484394 PNS: Find origin segment correctly when arcs are present 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8139
 2021-04-07 20:28:30 -04:00
Jon Evans 9f957d3e08 Fix crash when attempting to tune discontinuous lines 
Also correctly find the tuning path through arcs

https://gitlab.com/kicad/code/kicad/-/issues/8131
 2021-04-06 09:07:11 -04:00
david-beinder b2f788adc1 PNS: Fix UseConnectedTrackWidth when starting from ARCs 2021-04-06 01:27:13 +00:00
Jon Evans e46c9d35ac Add undo/redo handling to length tuner event loop 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8129
 2021-04-05 19:58:14 -04:00
Jon Evans 24cd174a23 Don't dereference a possibly-invalid optional 2021-04-05 19:34:57 -04:00
Jon Evans a6c3d74a73 Pass active layer to StartRouting in length tuner 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7857
 2021-04-04 21:51:54 -04:00
Jon Evans a24bc34b66 Better colors for length tuning popup in dark mode 2021-04-04 20:33:59 -04:00
Jon Evans c7ecb51f77 Update PNS length tuning algorithm to match the new BOARD algorithm 
Now tracks inside pads are optimized to give a more accurate length.
Also, the start/end of the assembled line is used to identify the right
pad joints for pad-to-die length calculation.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/4204
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1765
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6877
 2021-04-04 20:27:22 -04:00
Jon Evans cdfb014ab6 CHANGED: Account for via height in track length calculations 2021-04-04 13:59:18 -04:00
Jon Evans 6b24abac8f PNS: Don't snap to end items if snapping is disabled by modifier key 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8033
 2021-04-04 10:22:23 -04:00
Jon Evans a8896ebd73 Don't show leading ratline for unconnected net 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8040
 2021-04-02 20:29:25 -04:00
Jeff Young f88d39b4f0 Fix state issue in router's switch layer handling. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7590
 2021-04-01 18:10:04 +01:00
Jeff Young 8cb6f15687 Warn when diff pair router can't start due to too-small-gap. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7795
 2021-03-30 19:49:23 +01:00
Jon Evans 78a60e9dfb PNS: Put polygon error outside pad shapes 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7672
 2021-03-29 19:49:59 -04:00
Jon Evans 6cbc3fb97d Fix a minor inconsistency between router and DRC 
Also make sure collision highlighting runs at the starting
location of a drag.

See: https://gitlab.com/kicad/code/kicad/-/issues/7672
 2021-03-29 19:41:17 -04:00
Jon Evans 8be9832153 PNS: Don't highlight Net 0 (the unconnected net) 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8040
 2021-03-29 17:45:07 -04:00
Jon Evans 132ec37b56 Handle arc in buildHullForPrimitiveShape 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8008
 2021-03-25 21:25:30 -04:00
Jeff Young 8be213e36f Trim includes (and use consistent terminology in error messages). 2021-03-21 20:15:47 +00:00
Jon Evans 5e0b65c3a8 Change wording of corner rounding action 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4505
 2021-03-21 15:55:56 -04:00
Jeff Young cad1cb0262 Improve naming. 2021-03-16 12:07:06 +00:00
Jon Evans 18037e2f65 Rework bitmap system to load from archived PNGs 
Bitmaps are now identified by an enum class instead of by pointers.
Bitmap loading and caching is now handled by a class in common, and
we no longer compile most bitmaps into the binary, so there is no
longer a bitmaps static library.

Instead, bitmaps are archived to a .tar.gz file which is installed
in ${KICAD_DATA}/resources/images.tar.gz

The source PNGs are checked in to Git as the original CPP files were,
so that people can build without the required dependencies to convert
SVGs to PNGs.

Initial support is also added for dark theme icons, although this
is not yet exposed in the GUI.

Stubs are present for multi-resolution image resources, but this is
not fully-baked yet and could use some refinement.
 2021-03-11 08:37:35 -05:00
Jon Evans 720147d272 Remove transitive inclusion of bitmaps.h 2021-03-07 16:08:57 -05:00
david-beinder df99ee39d9 PNS: new through vias should span all copper layers 
Fixes https://gitlab.com/kicad/code/kicad/issues/7576
 2021-03-07 17:58:43 +00:00
Wayne Stambaugh 79a9d69ff5 Coverity fixes for issues 314755, 316287, 324536, 324539, and 324539. 2021-03-02 08:10:37 -05:00
Jeff Young d06e8ef01c Honour pre-defined-size selections for diff pairs. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7759
 2021-03-02 12:12:05 +00:00
Jon Evans d269778cd4 PNS: disable smart pads in walkaround if posture is forced 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7710
 2021-02-27 13:48:01 -05:00
Jeff Young b36e1c741d Fix insidious bug which resets layer of SOLID when marking collision. 
It's supposed to be setting the layer of the collsion display object,
not the host object, but there's a typo.

Fixes https://gitlab.com/kicad/code/kicad/issues/7712
 2021-02-25 23:39:48 +00:00
Jeff Young 75032f3acd Use the more-constrained layer when running rules. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7639
 2021-02-25 22:58:07 +00:00
Tomasz Wlostowski 87ea540953 Fix whitespace errors 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski c79610e132 router: post-rebase fixes 2021-02-25 17:18:23 +01:00
Marek Roszko 6948cdd8ef router: Fix return type within pointInside2 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski 9bdfc13155 router: improve locality of post-shove optimization 
Fixes: #4359
 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski e1d4bb777c router: use new LINE::Walkaround in the walkaround algo 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski 045d02f818 router: add strict/loose area restriction constraint. WIP 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski 24574aa2f5 router: first insert intersections, then build graph in Walkaround() 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski 61e75a838b router: replace large stack variables with std::array 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski 028f209126 router: more robust LINE::Walkaround() implementation 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski e9c55cd0e3 router: if the drag anchor is not reachable by the mouse, use the closest point on dragged trace for optimizer restriction 
Fixes: #4056
 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski a141ed3444 router: feed view size change events to the router engine 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski 12dfb541fc router: expose current view area to the router algorithms so that the optimizer could know not to mess with traces/vias not currently visible to the user (wip) 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski 2831c7d24c router: fix compile error in DRAGGER 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski b67e5768a6 router: feature to save debug event log & board dump for easier recreation of router bugs and misbehaviours 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski ebdc68ac1d router: correctly handle line width in PREVIEW_ITEMs 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski 34c037684b router: partially migrate SHOVE algorithm to use new DEBUG_DECORATOR 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski 0e6cf3f56e router: fix board edge clearance queries 
Fixes: #7254
 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski 4574f52eac router: DRAGGER::CurrentNode() should always return non-null value 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski e221b11e3b GRID_HELPER: fixed arithmetic issue in segment snap distance check disguised as 'excessive optimization' by the dragger in the router 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski 325300bd76 router: don't use compound pad shapes if pad contains a single primitive shape 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski a4bd2ad8c6 router: drag in walkaround mode now works 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski f84836f51e router: factor out POSTURE_SOLVER to more generic MOUSE_TRAIL_TRACER class 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski af95235f47 router: report debug log events from DRAGGER 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski 0306d16748 router: make post-drag optimization less intrusive 
Fixes: #5918
 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski 14ce7a0ad7 router: implement area constraint in optimizer 2021-02-25 17:18:23 +01:00
Tomasz Wlostowski 64cf593ee9 router: debug points now have variable size 2021-02-25 17:18:23 +01:00
Jeff Young caa18c8e16 Fix bugs in diffPair hole-to-hole logic and add rule resolution. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7697
 2021-02-25 14:23:02 +00:00
Jeff Young fa89263c8f Push hole-to-hole min processing down a level. 
Also removes adding the track width to the via gap, which was
never right.

Fixes https://gitlab.com/kicad/code/kicad/issues/7173
 2021-02-24 21:42:00 +00:00
Jeff Young 7f892669cc Consistent punctuation. 2021-02-23 12:46:27 +00:00
Marek Roszko c12666ec43 Fix arg type of NODE::followLine 2021-02-20 11:58:55 -05:00
Marek Roszko 6fce39607e Fix return type within pointInside2 2021-02-20 11:58:55 -05:00
jean-pierre charras d0b91b1106 Router, place via: fix issue created by 45b2bc: cancelling via must be made 
only when the select layer is called.
Fixes #7606
https://gitlab.com/kicad/code/kicad/issues/7606
 2021-02-19 17:28:20 +01:00
Seth Hillbrand 54282dffe3 Move preview items using FP orientation 
Fixes https://gitlab.com/kicad/code/kicad/issues/7600
 2021-02-18 16:32:40 -08:00
Jeff Young 45b2bce698 Cancel placement of via if user cancels layer selection. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7578
 2021-02-18 11:53:36 +00:00
jean-pierre charras 5d2dc0b50e Fix a few (minor) issues: 
- Make DIALOG_SHIM::SetPosition working)
- rename PCB_BASE_FRAME::SelectLayer() to PCB_BASE_FRAME::SelectOneLayer()
- PCB_BASE_FRAME::SelectOneLayer(): make dismiss dialog by escape key working.
Fixes #7578
https://gitlab.com/kicad/code/kicad/issues/7578
 2021-02-17 20:56:43 +01:00
Jon Evans 0198d5a3bd PNS: don't lose track of pad offset when dragging footprints 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7500
 2021-02-16 19:47:52 -05:00
Seth Hillbrand 9212197c26 Grammar 2021-02-15 15:18:13 -08:00
Jeff Young e2f8b1a4b1 Interpreting wxDialog::ShowModal()'s retval as bool is never what you want. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7454
 2021-02-08 17:40:57 +00:00
Jeff Young 6272b48481 Make sure layer gets passed in to rules evaluation. 2021-02-08 14:53:49 +00:00
Jeff Young 7aa7e3fd43 Push undo/redo blocking down a level in LengthTuner tool. 
This way it's active only while tuning a single line, rather than
while the tool is selected.

Fixes https://gitlab.com/kicad/code/kicad/issues/7462
 2021-02-08 14:15:46 +00:00
Seth Hillbrand 792904557e Remember Parent data when routing 
Keeps parent information such as UUID and pad removal options for
elements that are just updated in routing rather than created fresh or
fully destroyed.

Fixes https://gitlab.com/kicad/code/kicad/issues/7460
 2021-02-07 17:08:43 -08:00
Jon Evans 721bf82603 Handle malformed lines in dragCornerInternal 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7398
 2021-02-03 20:55:22 -05:00
Jeff Young d7ddc62d7e Fix mouse warping and dialog placement for layer switcher. 
Fixes https://gitlab.com/kicad/code/kicad/issues/2607
 2021-02-02 17:20:01 +00:00
Marek Roszko dc4b73fcef Correct m_board check location in PNS_KICAD_IFACE_BASE::SyncWorld 2021-02-01 11:58:22 -05:00
Seth Hillbrand 73886aecb1 Ensure partially triangulated polys are not valid 
Moves rule area triangulation outside of layer iterator and keeps the
triangulation_valid flag false until the triangulation has been
completed.

Fixes https://gitlab.com/kicad/code/kicad/issues/7032
 2021-01-29 16:33:57 -08:00
Wayne Stambaugh 6a39b81647 Fix the last of broken Doxygen comment specifiers. 2021-01-27 17:39:44 -05:00
Mikołaj Wielgus 3e42ba18a9 Show dragging tools in context selection menu for components 
Show the dragging tools in the context selection menu when a single
component is selected. Prevent the dragging tools from appearing when
more than one object is selected, as they will not activate anyway.

Fixes https://gitlab.com/kicad/code/kicad/issues/7258
 2021-01-27 19:55:42 +00:00
Jon Evans b96bcc86b1 Don't restrict start item to same layer if snapping is enabled 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7276
 2021-01-25 21:19:26 -05:00
Jeff Young 3fcd0860c1 Make 'E' go straight to Custom Track Width dialog. 
Also fixes some mouse capture issues.

Fixes https://gitlab.com/kicad/code/kicad/issues/7198
 2021-01-20 18:19:55 +00:00
Jon Evans 330d717c69 Fix typo 2021-01-18 21:50:26 -05:00
Ian McInerney 44655b98de Initialize variables properly 2021-01-18 18:35:10 +00:00
Jeff Young 68efdb2fff Push shared parts of GRID_HELPERs into common. 2021-01-16 23:18:10 +00:00
Jeff Young 02ccd5fbdb Make sure properties commands don't go to other tools during routing. 
Brings up the track widths (or diff pairs) context menu instead,
which seems to be the closest parallel.

Fixes https://gitlab.com/kicad/code/kicad/issues/7099
 2021-01-14 15:19:09 +00:00
Dominik Wernberger dc02ec9758 Remove a few const_cast 2021-01-12 20:51:31 +00:00
Jon Evans 111fa99f9f PNS: Use last-segment posture optimization always 
Also when auto-posture is enabled, don't flutter
until area threshold has been met.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/6935
 2021-01-07 20:12:31 -05:00
hoijui 6ca9a42251 Removes 3 other instances of a potential encoding problem 
Signed-off-by: hoijui <hoijui.quaero@gmail.com>
 2021-01-07 17:36:49 +00:00
Jeff Young e41c06304b Don't show a leading ratline to a NPTH. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6960
 2021-01-07 12:25:04 +00:00
Jeff Young f702b64b8d Minor improvements to formatting & SNR. 2021-01-07 12:25:04 +00:00
Jon Evans 0234b7278a PNS: Make DIRECTION_45 North be up everywhere 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6935
 2021-01-06 21:47:06 -05:00
Jon Evans 46c4727783 Make MSVC happy again 2021-01-05 20:56:37 -05:00
Jon Evans e7b047660c PNS: Correctly assemble lines with reversed arcs 2021-01-05 17:57:21 -05:00
Jon Evans feda03f69b PNS: Fix arc orientation when assembling lines with backwards arcs 2021-01-05 17:57:21 -05:00
Jon Evans 7431d5c985 PNS: First pass at updating meander placers for arcs 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6464
 2021-01-05 17:57:21 -05:00
Jon Evans 8619086cf2 PNS: re-enable optimization of colinear segs in lines with arcs 2021-01-05 17:57:21 -05:00
Jon Evans 8901e71fc8 PNS: Fix loop removal, make walkaround less broken for arcs 2021-01-05 17:57:21 -05:00
Jeff Young 02cd8c99cd Better error messages when routing can't be started. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6541
 2021-01-05 18:47:58 +00:00
Jeff Young 88d42724e6 Remove diff-pair-gap handling from single-line-router. 
We can't really support it until we do min/max/opt shoving and
dragging.

Fixes https://gitlab.com/kicad/code/kicad/issues/6932
 2021-01-05 16:54:52 +00:00
Jeff Young d975f2f6aa Commenting and naming for clarity. 2021-01-05 16:54:52 +00:00
Jeff Young f7b20611c1 Enforce hole-to-hole min when placing diffpair vias. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6931
 2021-01-05 00:26:49 +00:00
Jeff Young 93bd2171ab Formatting. 2021-01-05 00:26:49 +00:00
Jeff Young d24b034cbc Cleanup (and a minor performance improvement). 2021-01-04 22:32:29 +00:00