4f36c1ddf8
Remove dp_low_read() and use exception protected dp_read()
2021-10-31 12:55:41 +01:00
f9d343af3e
cmsis: AP reads are posted. Read from RDBUFF.
2021-10-31 12:55:41 +01:00
d4ae308f9f
cmsis: implement srst_set_val()
2021-10-31 12:55:41 +01:00
166eb3ee3e
cmsis_dap: Always transfer 65 bytes with hid_read|write()
...
CMSIS-DAP Dragonprobe works on some devices. E.g. it does not work
on NUCLEO-F103
2021-10-31 12:55:41 +01:00
b343ebe06f
cmsis-dap/linux: Link against libhidapi-hidraw
...
libhidapi-libusb detaches a kernel module but does not reattach again.
This may wrack interaction with other programs using hidapi.
2021-10-31 12:55:41 +01:00
761e0230d4
cmsis-dap: Print messages when transfers fail.
...
Expect signal integrity errors when using jumper cables. Often probes switch
the SWJ GPIO with highest speed, resulting in possible reflections. Additional
ground wires may help. If there is isolation between probe and targets,
additional ground wires are a must or ground shift will wrack the transfer!
2021-10-31 12:55:41 +01:00
39fbffd3d2
stlinkv2: Fix low access to AP registers.
2021-10-31 12:55:41 +01:00
c13778139f
adiv5/hosted: Export the BMP_TYPE in DP.
2021-10-31 12:55:41 +01:00
485105221e
dap: Always work on a copy of the buffer when calling dbg_dap_cmd() in a loop
...
A better solution would use seperate buffers for dbg_dap_cmd. But as WAIT is
already handled in DAP, cahnces are low that loop re-entry is needed.
2021-10-31 12:55:41 +01:00
397fbd5749
cmsis: Only cmsis internal use must differentiate between HID and Bulk access
...
Missing DAP_SWD_SEQUENCE may eventually need a distinction visible from
outside later.
2021-10-31 12:55:41 +01:00
7b1eb6e6e3
bmp_libusb: reset type on every device.
2021-10-31 12:53:47 +01:00
80064c18a9
bmp_libusb: Fix CMSIS-DAP related memory leak.
2021-10-31 11:13:34 +01:00
c4b6b42dcf
stlinkv2: Read targetid on DPv2 devices.
2021-10-31 11:13:34 +01:00
e7e1bfdb53
mpsse: Fix using 60 MHz clock on fast devices.
2021-10-30 13:55:57 +02:00
99a5fdb6f8
bmp_remote: Better error propagation.
...
Negative values from platform_buffer_read are errors too!
2021-10-30 13:55:57 +02:00
f4117aa1b4
cdcacm: Use the USB strings.
2021-10-30 13:55:57 +02:00
f28f05952f
stlink: Add another STLINK-V3 ID.
2021-10-30 13:55:57 +02:00
e1a928beb1
Fixes to compile with gcc11 #925
...
Target code changes are pure for formal correctness and not tested!
2021-10-10 15:59:57 +02:00
e2d3161442
Removed -S message as debugger selection option since it is used for reading bytes
2021-10-09 21:38:48 +02:00
59282b6f66
Fixed typography
2021-10-09 21:18:52 +02:00
7274f55ff4
Fixed return value of hosted blackmagic in erase mode
2021-10-09 21:17:58 +02:00
3f54fba986
HOSTED_BMP_ONLY=0 by default on Linux.
...
The user is warned about missing dependencies.
2021-10-09 21:14:52 +02:00
7ccbdd98c0
hosted/dap: Copy command buffer in wait/retry loop.
...
The same buffer is used for both command and response, causing part of
the command to be overwritten before it’s retried. Solve this by saving
and restoring a copy of the command before retrying.
2021-10-05 23:21:07 +02:00
f69f29a660
f4discovery/blackpill: fix usbusart
2021-10-01 00:10:03 +02:00
554e34517e
Better reporting when monitor command fails.
2021-09-22 21:41:43 +02:00
64f756d627
Test voltage on VREF before enabling target power (mon tpwr), to avoid potential power conflict.
2021-09-22 20:45:18 +02:00
356325f563
ftdi_bmp: Fix bit select.
2021-09-22 15:16:20 +02:00
79066c950f
bmp_libusb: Remove duplicated libusb_init.
...
Thanks to Red Liu for noticing
2021-09-22 15:16:20 +02:00
da15cc3cb7
remote_jtagtap: Fix memory corruption in jtagtap_tdi_tdo_seq
2021-09-22 15:16:20 +02:00
a93e57e112
ftdi: Fixed wrong direction report in DEBUG.
2021-09-22 15:16:20 +02:00
01583560cd
hosted: Update Readme.md to use HOSTED_BMP_ONLY
2021-09-16 11:02:31 +02:00
ff79108f66
cl_utils: Increase worksize for increased speed.
...
H743 reads 2 MB in ~23 vs 27 seconds
2021-09-07 10:57:17 +02:00
a76a559656
pc/platform_delay: Wait ms and not us!
2021-09-07 10:57:17 +02:00
a297c8c8ad
hosted/Makefile.inc: Use gcc to build hosted, if not advised otherwise
2021-09-04 21:15:07 +02:00
698cfeb1f4
bmp_serial: Nag MACOS programmer to implement find_debuggers!
2021-09-04 21:15:07 +02:00
49122b50b6
hosted: Make HOSTED_BMP_ONLY the default.
...
Hopefully more people will use it when reporting errors!
2021-08-15 16:43:29 +02:00
2fcd4a878a
ftdi_bmp.h: Fix error when compiling with HOSTED_BMP_ONLY=1
2021-08-15 16:43:29 +02:00
6308506276
jtag: Make jtag_devs argument to jtag_handler.
2021-08-15 16:43:29 +02:00
f7670fcd44
ftdi_bmp: Add verbosity for libftdi_jtagtap_tdi_tdo_seq()
2021-08-15 16:43:29 +02:00
3df692ecb2
adiv5_swdp_scan: If SWD scan fails, try a JTAG scan.
2021-08-15 16:43:29 +02:00
5c8e277663
hosted/dap: Fix tdi_tdo_seq.
2021-08-15 16:43:29 +02:00
2d4a503135
jtag_scan: Rework chain detection
...
Fixme: stlinkv2/hosted probably does only handle STM devices. Check if
jtag_devs.c really needed.
2021-08-15 16:43:29 +02:00
e1a1865de9
remote/jtagtap_tdi_tdo_seq: Split up large transactions.
...
FIXME: One remote transaction still can only do up to 64 ticks, leaving
room for speed enhancement with larger transactions.
Firmware assumes (1LL << 65) == 0LL !
2021-08-15 16:43:29 +02:00
8084a75634
cl_utils: Allow Hardware reset from the command line
2021-08-15 16:43:29 +02:00
36836d0746
ftdi_bmp: Fix setting bits and FTDIJTAG srst.
2021-08-15 16:43:29 +02:00
cfdf55855e
ftdi_bmp: Export and use reset functions.
2021-08-15 16:43:29 +02:00
5eb43a1ddb
platforms: stm32f4x1 blackpillv2 as variant of f4discovery
...
Compile as make PROBE_HOST=f4discovery BLACKPILL=1
2021-08-13 16:18:05 +02:00
6d6a67b44b
timeout: Make sure we wait at least the period requested ( #900 , #902 )
...
Fixes bug introduced with last commit( Recover from bad AP access)
Let STM32 timers run at 100 Hz against 10 Hz before.
Programming STM32F103 failed random (#900 ) with 20 ms timeout requested
against the 100 ms timeout granularity provided up to now.
STM32 Firmware only ticked at 10 hertz, so the sequence "low_access",
"set timeout", "send out 8 bit command", "read 3 bit result" when
reading "wait" and timer increment tick happening during that sequence
will already hits the timeout even so only mininal time has elapsed
and not the requested timeout.
2021-07-27 10:59:03 +02:00
b887a8d355
stm32: Portability changes
...
Allow to compile on STM32F0 platform too.
2021-07-15 15:06:54 +02:00
3cfd8226ba
bmp_libusb: Check only for cmsis_dap if no cable has been found yet.
2021-06-18 11:44:50 +02:00
a0dbb2a787
Merge pull request #896 from RadinnAB/for-upstream
...
Add nRF51 erase UICR command and fix some warnings
2021-06-07 17:43:56 +02:00
ea4b232996
Fix de83dbb: duplicate BMP_MODE_FLASH_VERIFY -> BMP_MODE_FLASH_WRITE_VERIFY
2021-06-07 17:29:41 +02:00
711a87f7ba
Fix some warnings when compiling with -Wshadow
...
There are still a few more places that would need to be corrected
before -Wshadow could be added by default.
2021-06-03 12:55:28 +02:00
2a0d608b07
hosted: Fix last commit
...
-Wno-format-truncation may not be understood by all systems
2021-06-01 18:42:37 +02:00
1b49823f64
Fix hosted compile on MacOS. hidapi-libusb has a different name
2021-06-01 16:58:25 +02:00
de83dbb7e2
cl-utils: Fix bug introduced with 5288eef617
...
Always use the file size for write and verify.
2021-06-01 16:23:19 +02:00
c0437e7b25
bmp_serial: Autodetect more BMP string variants.
2021-06-01 16:23:19 +02:00
6454d0bc96
bmp_libusb: Invalidate manufacturer and product in case libusb_get_string_descriptor_ascii fails.
...
Prevent more false detections
2021-05-20 12:06:56 +02:00
7f1a560288
stm32/usbuart: Clear USART_ICR if provided.
...
Otherwise endless interrupts happened.
2021-05-20 12:06:56 +02:00
90534b3cf6
stm32: portability enhancements
...
Needed for e.g. stlinkv3
2021-05-20 12:06:56 +02:00
cb4cff2c71
hosted/ftdi: Compare only for length of the string given in the header
...
Devices may have added version like "Tigard V1.1" vs "Tigard"
2021-05-18 12:24:00 +02:00
c3fd198f0d
bmp_libusb: Reject non-BMP devices with VID 1d50.
2021-05-18 12:24:00 +02:00
36ad6efc6f
cmsis_dap.h: Fix wrong leftover argument.
2021-05-16 17:17:33 +02:00
f0dd8c9517
cl_utils: List -l option in the help.
2021-05-16 17:17:33 +02:00
e4421799ba
More header cleanup
2021-05-15 12:54:51 +02:00
8e438b9e5f
Add missing headers and remove double typedef.
2021-05-14 19:58:16 +02:00
cfbe9f1c94
pc/gdb_if.c: More verbosity for Error messages #873
...
Thanks to "pshri" for dissecting and adding messages, as problems with
Hpyer-V and port permissions happened on Win10
2021-05-09 11:49:32 +02:00
f121350fc9
hosted/cmsis_dap: Verify that a v2 interface has endpoints.
2021-04-27 11:39:43 +02:00
494524dd85
hosted/cmsis_dap: Add v2 support.
2021-04-27 10:26:06 +02:00
4f52a7b235
hosted/cmsis_dap: Add discovery by interface string and prepare for v2 support.
2021-04-26 21:56:24 +02:00
c4874fdf44
hosted/dap: Add parentheses around bitwise operator.
2021-04-26 21:54:38 +02:00
f9414d5826
cmsis-dap: Handle ADI DP22 devices on probes not multidrop capable.
2021-04-26 18:18:18 +02:00
923edc7f7e
cmsis-dap: Fix wrong handling when reading data not word-aligned
2021-04-26 15:08:09 +02:00
877a6e694c
Revert "cmsis_dap: Always write full reportsize + 1 buffers"
...
This reverts commit 61e237ec87
2021-04-25 22:53:40 +02:00
f98b7274b4
hosted/stlinkv3: Detect STlinkV3 in bootloader mode.
2021-04-25 16:02:20 +02:00
a83700d1cf
stm32/usbuart: DMA stream handling is not STM32F4 specific
2021-04-25 16:02:20 +02:00
1330288271
firmware: Unify serial number handling
...
Use one file in dfu and server
For STM32, provide 3 ways to handle
- BMP way (8 bytes)
- DFU way (12 Bytes)
- Full unique id (24 Bytes), as with STLINK(V3) Bootloader
2021-04-25 16:02:20 +02:00
ea92c8b8c8
cmsis-dap: Allow to use adiv5_swdp_scan.
2021-04-21 21:50:38 +02:00
04d1c9805b
swd: Remove swd_proc and swdptap.h.
2021-04-21 21:50:04 +02:00
61e237ec87
cmsis_dap: Always write full reportsize + 1 buffers
...
Expect short reads and other errors else
2021-04-21 21:50:04 +02:00
d6ade4d94e
cmsis-dap: Use SWD_SEQUENCE if available.
2021-04-21 21:50:04 +02:00
5abb288c7a
hosted: Provide the DP functions in swd_proc.
2021-04-21 21:50:04 +02:00
637d76b585
cl_utils.c: Try jtag scan if swd scan did not give results.
2021-04-21 21:22:59 +02:00
5288eef617
cl_utils: With no size given, read the size of the lowest block.
2021-04-20 18:48:27 +02:00
21b80949ff
Compile with -Os as default. Change like "make OPT_FLAGS=..."
...
SWD/JTAG Bitbang is compiled with -O3 for good bitbang speed.
2021-04-20 18:20:41 +02:00
806787529f
Use DMA for USBUSART TX/RX
2021-04-17 17:57:08 +02:00
cf5b4afb38
bmp_serial/linux: Honor opt_list_only (-l).
2021-04-17 16:19:57 +02:00
9ec7d05d8d
Put null terminating characters when scanning for BMP probes on linux
...
This patch puts null terminating characters for the 'type',
'version', and 'serial' strings extracted from blackmagic probe
id strings on linux systems.
2021-04-17 14:41:28 +02:00
299da8627c
libftdi: Remove unneeded explicit path.
2021-04-17 13:35:21 +02:00
739941dc5f
Verify right after programming
2021-03-31 13:06:52 +02:00
2982888b66
BMP_MODE_FLASH_WRITE_VERIFY combined operation
2021-03-31 12:07:53 +02:00
f85c54be97
Prepared -w option
2021-03-31 12:07:53 +02:00
e6a9a1a366
cmsis-dap: Get the firmware version.
2021-03-06 13:30:09 +01:00
3aa6f16964
serial_unix: Split timeout in seconds and microseconds
...
Macos exposed errors when tv_usec was > 1000000.
2021-03-05 16:49:19 +01:00
43770736f1
cl_utils: Rework Flash/Ram printout
2021-03-05 16:49:19 +01:00
d70fa8c7f6
hosted: Remove restrictions when gathering information on the debugger
...
That way, we find RPI Pico pico-debug.
2021-02-15 17:47:29 +01:00
c776e7a9a6
swd_scan: Add '-m' as targetid argument to swd_scan to prepare multi-drop.
...
In a real multi-drop setup, the device to use must be specified.
2021-02-15 17:47:29 +01:00
8e2f6937d5
hosted: Run target specific monitor commands with -M "command" .
...
Lists available commands: "blackmagic -M help"
Quote multi argument monitor commands, e.g. STM32F1: blackmagic -M "option help"
2021-02-15 17:47:29 +01:00
165560edd8
cl_utils: target selection '-n' argument needs optarg.
...
foreach now returns the number of targets.
2021-02-15 17:47:29 +01:00
4eb336277c
native: Remove high current draw ( #814 )
...
Special iRST_SENSE handling does not apply at least for BMP 2.1c.
On V2.1c, iRST_SENSE was set as output high and xRST high shorted
iRST_SENSE to ground via Q2
FIXME: Check for older versions!
2021-02-15 15:00:19 +01:00
3b8502c2e5
add space in USB product string (be consistent with ../stm32/dfucore.c)
...
This changes the USB identification from
"Black Magic Probe(STLINK/V2) v..." to
"Black Magic Probe (STLINK/V2) v..."
Signed-off-by: Martin <Ho-Ro@users.noreply.github.com>
2021-01-29 14:47:28 +01:00
d4dc3b2717
The USB CDC is no modem and does not use the AT protocol
...
Signed-off-by: Martin <Ho-Ro@users.noreply.github.com>
2021-01-29 14:47:28 +01:00
09c000eca8
hosted: Really handle setting tpwr on remote on the command line #817
...
Expect the command to fail, due to old firmware or remote not implementing
the power switch.
2020-12-19 16:36:09 +01:00
5f76169b95
hosted: remove ftdi include when built with BMP_ONLY #811
...
Signed-off-by: Sean Cross <sean@xobs.io>
2020-12-16 11:30:42 +01:00
98c92a6d18
hosted: Really fix the case of no serial number ( #807 )
2020-12-13 14:12:05 +01:00
6dbb5ff7ee
Frequency: Implementing for jlink.
...
SWD frequency is fixed for jlink according to the docs from 2010.
2020-12-12 18:33:09 +01:00
fdc654cfb3
stlink: Implementation of frequency setting.
2020-12-12 18:33:09 +01:00
de26ba6f73
hosted: Add is_jtag to the info structure
...
Needed for different frequency setting procedures on some platforms.
2020-12-12 18:33:09 +01:00
28a966a3e6
frequency: Implement for ftdi.
...
For all 2232H types, use undivided 60 Mhz.
FIXME: Check FT2322C/D for unsymetric clock at 6 MHz!
2020-12-12 18:33:09 +01:00
13e8a262e4
SWJ Frequency: Implement for cmsis-dap
2020-12-12 18:33:09 +01:00
1ca9f234f7
Infrastructure for setting maximum SWJ frequency.
...
Implement for BMP/firmware on STM32.
2020-12-12 18:33:09 +01:00
7365a44989
hosted: Implement SWJ test mode (-T).
...
Continious read/write-back some core register as NOP operation to allow scope
measurement of SWJ timing.
2020-12-12 18:33:09 +01:00
f796b774bd
hosted: Fix info.serial if USB device has no serial number #807
2020-12-12 18:32:15 +01:00
14498decd9
HOSTED_BMP_ONLY/linux: Fix case when no serial device is connected #806
2020-12-12 15:06:26 +01:00
b5172cf6df
Implement the 'find_debuggers()' function for hosted BMP on windows.
2020-12-11 18:36:48 +01:00
01f8628aed
Bugfix in detecting BMP probes by usb serial number.
2020-12-11 18:36:48 +01:00
170fe0c368
Remove spurious comment.
2020-12-11 18:36:16 +01:00
4c5ce0b16a
Hosted: Handle devices w/o serial number, e.g. GigaDevices GD-Link ARM/CMSIS-DAP
2020-12-11 18:36:16 +01:00
0f1fe9e438
hosted/linux: Find BMP devices without libusb.
2020-12-11 18:36:09 +01:00
bd5f4c6ed5
hosted: Consolidate ident output.
2020-12-11 17:55:31 +01:00
0870b778c0
hosted: Allow to build without libusb, libftdi and hidapi with HOSTED_BMP_ONLY=1
2020-12-11 17:50:16 +01:00
32db38ecf2
hosted/libusb: Move platform.c libusb related functions to own file.
2020-12-11 17:35:43 +01:00
41788f923b
ftdi/stlink/jlink: Provide dummy functions in the HOSTED_BMP_ONLY case
...
Do not allow multiple inclusion by not declaring the functions as static to
help keep code clean.
2020-12-11 17:31:25 +01:00
98b4ec58bc
Update to recent libopencm3 to undo unwanted change.
2020-12-07 21:51:22 +01:00
633c6a2e81
Recognize "J-Trace Cortex-M PRO V2" in hosted mode
2020-12-07 11:52:33 +01:00
17dfec3572
dfu/cdcacm: Consolidate usage of ST vs BMP serial number.
2020-12-06 15:18:08 +01:00
5c7e0eedb0
command.c: Consolidate "mon version" output
2020-12-06 15:18:08 +01:00
07c3699225
version.h: Remove from platform.h files
...
- Consolidate ident string generation
- Recompile only needed files
2020-12-06 15:18:08 +01:00
0a7bfd5923
dfu_f4: Fix sector_erase.
2020-12-06 15:18:08 +01:00
9e1b7fdac0
jlink/swd_low_access: Fix data direction during response read phase.
2020-11-29 15:48:50 +01:00
8903026c14
jlink/swd: swd frequency is fixed, not need to set.
2020-11-29 15:48:50 +01:00
3b6432912d
jlink: Catch another error with no target connected.
2020-11-29 15:48:50 +01:00
7df314e265
Firmware/Jlink: Fix double free when debug power-up fails ( #780 )
2020-11-29 15:48:50 +01:00
e1329499de
platform_adiv5_swdp_scan: Do not double free with early errors.
...
adiv5_dp_init() clean up itself if errors happen
2020-11-29 15:48:50 +01:00
bf548e92c0
swd: After write low_access, always append 8 clk to move data through SW-DP.
...
Especially needed when leaving the debugger or during debug unit power-up.
ARM Debug Interface Architecture Specification ADIv5.0 to ADIv5.2
tells to clock the data through SW-DP to either :
- immediate start a new transaction
- continue to drive idle cycles
- or clock at least 8 idle cycles
Implement last option to favour correctness over slight speed decrease
Implement only for adapters where we assemble the seq_out_parity in our code,
as on firmware, ftdi and jlink. Hopefully the high level adapters do it right.
Reverts 2c33cde63fcde7726b87
2020-11-27 22:26:48 +01:00
139e5d7e22
f4discovery: Compile time option to compile with ST bootloader
...
Just to keep things active. Prepare for F72 bootloader.
2020-11-27 22:26:48 +01:00
636bcee355
stlink/swlink: Remove the DFU upgrade utility.
...
Hopefully no old bootloaders are around. If otherwise, revert to last
commit before this and update the DFU bootloader.
2020-11-27 22:26:48 +01:00
27ef4569ca
stm32/dfucore.c: Use libopencm3 provided defines and functions.
2020-11-27 22:26:48 +01:00
9d55128ab8
cl_utils: Get voltage only once.
2020-11-27 22:26:48 +01:00
e6823f39de
Hosted: Print version with "-h" and "-t" option.
2020-11-27 22:26:48 +01:00
62d9f60f03
hosted/firmware: Waits for read response as long as cortexm_wait_timeout.
2020-11-27 22:26:48 +01:00
26a23dd1cb
stlinkv2: Try harder to open an AP.
...
Problem seen on STM32L0 with probably long sleep periods.
2020-11-27 22:26:48 +01:00
cda83d3084
Fix memleaks.
...
Happened e.g. when Stlink could not enter debug or when cortexm_prepare timed out.
2020-11-27 22:26:48 +01:00
824a1d8abc
hosted/find_debuggers: Do not check hubs. Print class of devices unable to open.
2020-11-27 22:26:48 +01:00
e68dd25813
cl_utils: Clarify -d option is BMP/firmware only and deprecate -d.
2020-11-27 22:26:48 +01:00
f71e18948a
GPIO for SWD: Slow down edges on more platforms.
2020-11-27 22:26:48 +01:00
80154c5c7a
adiv5_swdp: Fix more memory leak.
2020-11-27 22:26:48 +01:00
d75f3124b9
ftdi_bmp.c: Reapply fix from #715 : Check for libftdi 1.5
2020-11-01 12:09:27 +01:00
99142d1c0e
Add documentation details for building PC-hosted BMP in msys2.
2020-11-01 11:33:54 +01:00
18673d9a56
adiv5: Rework DP/AP refcounting.
...
ASAN non longer reports leaks with the STM32H745.
2020-10-23 09:40:15 +02:00
Uwe Bonnes
fabalthazar
Vegard Storheil Eriksen
Jeff Lutgen
Thiadmer Riemersma
Andy Makovec
aam335
Björn Mellström
Vestrel
Stoyan Shopov
Martin
Sean Cross
Emilio Lopes