Wayne Stambaugh
6427197962
Remove duplicate headers in plot and associated code.
2021-08-17 15:41:25 -04:00
jean-pierre charras
60c65c2a1d
Avoid loading python stuff when starting applications that do not use it.
...
It is useless, and debug is slightly easier (less constraints) at least on msys2
2021-08-17 19:48:55 +02:00
Wayne Stambaugh
8f30404e42
Plot code cleaning.
2021-08-17 13:44:11 -04:00
Wayne Stambaugh
b14b8b5fb1
Move headers from common folders to the appropriate include folders.
2021-08-17 12:40:31 -04:00
Jeff Young
8b5f393804
DRC bug fixes and debugging improvements.
...
1) Don't wait for UpdateUserInterface to build the (global) list of
layer names.
2) Report clearance resolution between a silk layer and a mask layer.
3) When writing DRC reports, include info about the violating rule.
4) Report "no relevant layers" if we fail to find anything to write
a clearance resolution report about.
Fixes https://gitlab.com/kicad/code/kicad/issues/8963
2021-08-17 15:41:12 +01:00
Wayne Stambaugh
8e1015fcc4
Remove all wxWidgets build dependencies from REPORTER object header.
2021-08-16 07:49:39 -04:00
Jeff Young
1a252b4f96
Add a compile error for ill-defined rules, and more performance.
...
Also adds const-safety to GetBoard().
2021-08-16 12:14:17 +01:00
jean-pierre charras
c6ce367f1e
Avoid duplicate strings to avoid typos and not synchronized strings
...
Fixes #8964
https://gitlab.com/kicad/code/kicad/issues/8964
2021-08-15 17:50:23 +02:00
Jeff Young
41619ebbe2
Decouple PROGRESS_REPORTER interface from implementations.
2021-08-14 21:05:49 +01:00
Jon Evans
aae0e7e121
Fix build on Linux
...
wxString does not automatically cast to std::string
2021-08-14 09:57:01 -04:00
Jeff Young
bff247b08a
Hook up 3D viewer colors to board stackup.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5173
2021-08-14 14:00:17 +01:00
Jeff Young
ef9f041279
Don't show 3D color opacities where they're not supported.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8938
2021-08-14 14:00:17 +01:00
Jeff Young
ed38028eaf
Fully resolve path list for Kicad2Step.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7670
2021-08-14 11:21:25 +01:00
Jon Evans
37fd7c785e
Make macOS path determination tolerant of bundle renaming
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8922
2021-08-13 17:00:45 -04:00
Jeff Young
4c3954aea8
Clearer DRC rule token name for hole_size.
2021-08-13 16:18:56 +01:00
jean-pierre charras
a0da252a6a
SETTINGS_MANAGER::Prj(): add a wxASSERT to allow python script debug before a crash
...
Due to a bug, SETTINGS_MANAGER::Prj() returns a null PROJECT when running a
python script from the python console. this wxASSERT helps debugging.
2021-08-13 11:15:12 +02:00
Jeff Young
c536a4c4f2
Work around annoying wxWidgets assert.
2021-08-10 16:51:30 +01:00
Jon Evans
6b48825aa0
Add support for ngspice >= 35 version reporting
2021-08-09 17:19:59 -04:00
Jeff Young
a10f2b284c
Unify negative zero and percent handling in UNIT_BINDER.
...
Some values, such as solder mask margins, are usually negative and it
helps to display zero as "-0.0".
2021-08-06 18:16:38 +01:00
jean-pierre charras
5f84071cfa
Gerber plotter, GERBER_PLOTTER::plotArc( SHAPE_ARC& aArc ): fix missing G75 command
2021-08-06 17:45:57 +02:00
Jeff Young
d6443d5a2c
Reduce type-casting a bit.
2021-08-04 17:11:35 +01:00
Jeff Young
ae99e627bd
Quiet Coverity.
2021-08-04 13:55:42 +01:00
Jeff Young
c5e195bdff
Cleanup (includes and formatting).
2021-08-03 18:37:23 +01:00
Jeff Young
95b87ba29a
Freshen microwave polygon dialog and remove a bunch of dead code.
2021-08-03 01:11:11 +01:00
david-beinder
c34f45f646
Split global label size expansion from TextOffset setting
...
Global label expansion ratio default is now 37.5%
Wire text offset default is now 15%
2021-08-02 16:40:36 +00:00
david-beinder
bab13debcb
Improve overbar rendering in PCB and global labels
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8584
Moves the font slightly down in global labels
Keeps font with overbar at the same size in PCB OpenGL renderer
2021-08-02 16:40:36 +00:00
Jeff Young
78fd268b18
Retire PARAM_OBSOLETE in favour of a schema migration.
2021-08-02 17:38:15 +01:00
Jeff Young
7d501e8a43
Add PARAM_OBSOLETE to clean out old JSON structures.
...
While not technically necessary, the old structures can be confusing
to users looking at the files.
Fixes https://gitlab.com/kicad/code/kicad/issues/8856
2021-08-02 12:53:57 +01:00
Jeff Young
4876e1b327
Make sure user.json file gets created if it didn't already exist.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8856
2021-08-02 02:48:23 +01:00
Jeff Young
6f1837b300
Formatting.
2021-08-02 01:52:58 +01:00
Jeff Young
c51b1dad72
Generalize infobar MESSAGE_TYPE handling and use for DRC errors.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8782
2021-08-01 21:51:39 +01:00
Jeff Young
e636fb32cf
Fix typo initializing buswidth with linewidth value.
...
Also reduces line-wrapping a bit.
I don't think this fixes the linked bug, but I can't reproduce it
and this was found while reviewing the code.
Fixes https://gitlab.com/kicad/code/kicad/issues/8810
2021-08-01 19:33:19 +01:00
Jeff Young
7033dd68c0
Default WX_GRID to no cell overflows.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8892
2021-08-01 11:57:45 +01:00
Ian McInerney
baf6798695
Check for column existence before checking for tooltip enabled
...
Otherwise we try to read a bitset at location -1, which triggers
and assert on MSVC.
Fixes https://gitlab.com/kicad/code/kicad/issues/8890
2021-07-29 23:18:26 +01:00
Jeff Young
8aea2cbd03
When ignoring click events don't ignore synthetic ones.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7255
2021-07-29 18:07:04 +01:00
Jeff Young
f024bf2289
Don't restrict page sizes unnecessarily.
...
Also don't validate custom sizes unless they are enabled.
Fixes https://gitlab.com/kicad/code/kicad/issues/8880
2021-07-29 16:47:45 +01:00
Jeff Young
6aaf4413b3
Fix kicad_string.h / string.cpp mismatch.
...
They don't define a KiCad string class, so the header file name was
somewhat misleading. But the fact that they didn't match definitely
made coding more difficult.
2021-07-29 16:03:25 +01:00
Jeff Young
f221220fe2
Rename layer ids file.
...
It hasn't had anything to do with colors or visibility for some time
now.
2021-07-29 16:03:25 +01:00
Jeff Young
293f207356
Hopefully the last of the symbol id escaping issues.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8694
2021-07-28 19:44:42 +01:00
Wayne Stambaugh
f233f4a0a9
Expunge EDA_FILE_SELECTOR.
...
EDA_FILE_SELECTOR was just an obfuscation of wxFileSelector().
2021-07-28 14:12:51 -04:00
Jeff Young
6d4c454e8c
Fix some more missing escaping for symbol ids.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8694
2021-07-28 18:37:09 +01:00
Ian McInerney
36d66085f5
Add a column showing 3D model file loading errors
...
This adds an icon to the left of the row with an error symbol if the
file can't be found or opened, and shows a tooltip over the icon with
and error string.
Fixes https://gitlab.com/kicad/code/kicad/issues/3815
2021-07-28 16:42:22 +01:00
Jeff Young
3a5d49f7b2
Make select-all hack work with Scintilla too.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8876
2021-07-28 00:16:18 +01:00
Jeff Young
29b23df7a1
Save both front and back soldermask colour preferences.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8856
2021-07-27 22:26:13 +01:00
Jeff Young
19de38bbae
Avoid Mac-standard Cmd+H as well.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8864
2021-07-27 22:26:13 +01:00
Jeff Young
484b6bae64
Make Reset to Defaults button responsive to current page.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8864
2021-07-27 17:56:45 +01:00
Jeff Young
886dc2f43e
Do-not-show-again section for common prefs & zone fill warning infobar.
...
Note that the dialogs which have mutliple options were not moved over
as it seems perahps not the right choice to have them save state between
sessions.
Fixes https://gitlab.com/kicad/code/kicad/issues/8762
2021-07-27 15:15:49 +01:00
Jeff Young
a2cb3e916a
Add a couple of OSX-standard keyboard cmds to Scintilla.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8865
2021-07-27 15:15:49 +01:00
Wayne Stambaugh
37b200cb3e
Pass wxString objects by reference instead of on the stack.
2021-07-27 08:41:27 -04:00
Wayne Stambaugh
78e5e98ea0
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-27 08:41:27 -04:00
Wayne Stambaugh
8fd83cbb95
Pass wxPoint objects by reference instead of on the stack.
2021-07-26 15:35:33 -04:00
Jeff Young
e62969d007
Move zone fracture display mode to AdvancedCfg, and add triangulation.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8762
2021-07-26 18:57:35 +01:00
Wayne Stambaugh
89b1fdabe9
Pass COLOR4D object by reference instead of on the stack.
2021-07-26 13:28:56 -04:00
Marek Roszko
8921eef0be
Add a "Open Demos Project" shortcut to the kicad launcher
...
Small UX improvement for the new user....
2021-07-25 21:58:57 -04:00
jean-pierre charras
1aadf45947
DIALOG_SHIM: fix not working initial size when creating a dialog.
...
The first time a DIALOG_SHIM was created, with a given size, this size
was not taken in account. This this is now forced.
(when recreated during a session, this is the last dialog size that is used)
2021-07-24 18:59:28 +02:00
jean-pierre charras
dbf17f83ed
Minor fixes (DIALOG_DISPLAY_HTML_TEXT_BASE: ensure min size is working).
2021-07-24 17:03:36 +02:00
Jeff Young
373f0335c8
Convert Altium radial dimensions to leaders.
...
This is because we don't yet support radial dimensions.
Also fixes a bug where we fail to read an Altium circular track. We
now convert it to a pair of 180-degree arcs.
Also fixes a bug where we were failing to import prefixes on linear
dimensions.
Fixes https://gitlab.com/kicad/code/kicad/issues/8789
2021-07-24 14:25:59 +01:00
Jeff Young
531f5480a7
Reduce line-breaks and increase SNR.
2021-07-24 14:25:59 +01:00
Jeff Young
3c1af1af74
Update selected tool string when language changes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8813
2021-07-23 20:16:53 +01:00
Wayne Stambaugh
1a301d8eea
Stop using wxDialog::EndModal() from inside dialogs.
...
Calling wxDialog::EndModal() directly from inside the dialog is a
potential bug if the dialog is shown in the modeless or window modal
(quasi-modal). Use the internal button events where possible and
check for the appropriate mode before calling the correct end dialog
function.
2021-07-21 17:38:14 -04:00
Pradeepa Senanayake
6001ac0704
Fixed the color picker double click event
2021-07-18 16:28:49 +00:00
Wayne Stambaugh
bcd6bddfd4
Start expunging NULL.
...
Given that KiCad is a C++ project, we should really be using nullptr
instead of NULL.
2021-07-15 15:44:45 -04:00
Mika Laitio
1e21daf781
fix if comparison with uninitialized member value
...
Fix the valgrind warning from the use of an uninitialized
member variable by setting the DEFAULT value for
m_currentNativeCursor in the constructors member initializer list.
This fixes the following warning caused by the SetNativeCursorStyle
method call later on the constructor.
==66660== Warning: client switching stacks? SP change: 0x1ffeffee40 --> 0xdf7efe8
==66660== to suppress, use: --max-stackframe=137187819096 or greater
==66660== Conditional jump or move depends on uninitialised value(s)
==66660== at 0x13F0764E: UnknownInlinedFun (graphics_abstraction_layer.cpp:276)
==66660== by 0x13F0764E: KIGFX::GAL::GAL(KIGFX::GAL_DISPLAY_OPTIONS&) (graphics_abstraction_layer.cpp:78)
Error can be reproduced and checked from the log.txt
by launching kicad with valgrind command
"valgrind --leak-check=full kicad > log.txt 2>&1"
and then launching the footprint editor from the kicad main dialog.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8784
Signed-off-by: Mika Laitio <lamikr@gmail.com>
2021-07-15 16:18:24 +00:00
Pradeepa Senanayake
6cde086ef9
Double click on defined colour executes OK action
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8778
2021-07-14 23:26:40 +00:00
Jon Evans
ae55db77c5
Allow hiding version from manager title bar with advanced config
2021-07-14 18:24:21 -04:00
Wayne Stambaugh
01515680b3
Code cleaning.
2021-07-14 15:47:32 -04:00
Wayne Stambaugh
346b876eb7
Fix Coverity issue #332157 .
2021-07-13 17:10:13 -04:00
Jeff Young
c3bf51c94b
Remove unused variables.
2021-07-13 20:07:49 +01:00
Jeff Young
2739cdbd43
Add error message logging to opening of drawing sheet.
2021-07-13 19:59:03 +01:00
Jeff Young
f0513978ff
Back-port some fixes from 7.0 branch.
2021-07-13 17:24:23 +01:00
david-beinder
8b3ccab0a3
Implement explicit polygon construction for most pad shapes
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8650
2021-07-13 14:51:58 +00:00
luz paz
0446d35f0d
Fix source comment/doc typos (follow-up)
...
Found via `codespell -q 3 -S *.po,./thirdparty -L aactual,acount,aline,alocation,alog,anormal,anumber,aother,apoints,aparent,aray,dout,einstance,modul,ot,overide,serie,te,,tesselate,tesselator,tht`
2021-07-13 10:48:17 +00:00
jean-pierre charras
1151783a34
Gerbview: fix an issue (Debug only) with RoundRect aperture macro.
...
When a RoundRect aperture macro was used with a radius = 0, a wxWidget assert
was generated, due to incorrect polygonal shape to draw.
2021-07-13 10:23:55 +02:00
jean-pierre charras
aefa969931
DIALOG_COLOR_PICKER: speedup the color map bitmaps build.
...
Use a wxImage to create the bitmap (much faster), instead of a wxMemoryDC.
Fixes #8779
https://gitlab.com/kicad/code/kicad/issues/8779
2021-07-12 13:11:03 +02:00
Marek Roszko
759f0e9a75
Be sure to stop the timer during widget destruction
...
Also fix a comment elsewhere :D
Fixes #8772
2021-07-11 19:17:34 -04:00
jean-pierre charras
fb246403d2
PROGRESS_REPORTER: avoid clipping the bottom of the dialog in some cases.
...
It occurred on Windows, when the message to display is too long and was
displayed using 2 lines.
Now the dialog is resize after changing the message.
Fixes #7953
https://gitlab.com/kicad/code/kicad/issues/7953
2021-07-11 17:52:54 +02:00
Marek Roszko
9162013132
Add advanced cfg to force reloading memory cached 3d models
2021-07-11 00:35:38 -04:00
Marek Roszko
7cb0f8f808
Add ADVANCED_CFG to always reload cached 3d models in memory
2021-07-11 00:31:06 -04:00
Marek Roszko
79b90813ec
Add ADVANCED_CFG to skip caching 3d models to file
2021-07-11 00:00:06 -04:00
Jeff Young
01d3a88faa
Allow unnamed embedded step files in altium boards.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7898
2021-07-10 16:37:45 +01:00
Jeff Young
353dc95f06
Improved spacing.
2021-07-10 10:19:01 +01:00
Jeff Young
625006ca30
Remove front/back SMD pad color now that we have opacity sliders.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8761
2021-07-10 10:13:55 +01:00
Jeff Young
a06b95bb1f
Even out spacing around various panels.
2021-07-09 23:42:45 +01:00
Wayne Stambaugh
6c3ba1c20b
Coverity issue fixes.
...
Issues #332032 , #332086 , #332157 , and #332171 .
2021-07-09 10:56:35 -04:00
Jeff Young
9975b8fb10
Attempt to handle deleting double-byte chars in Scintilla.
2021-07-08 20:44:04 +01:00
Jeff Young
f59ee53540
Comparen canonicalKey, not raw key.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7979
2021-07-08 15:53:08 +01:00
Jeff Young
a4263ebce5
Clean up Altium special string handling
...
1) Fix a couple of bugs in case processing
2) Make case processing more explicit to prevent more (1)
3) Move label processing to AltiumSpecialStringsToKiCadVariables
4) Strip double-quotes from special strings (and add test cases)
5) Change PROJECTNAME to just filename, not full path
6) PROJECTREV and REVISION are two different things
7) Add support for Altium's Application_BuildNumber
8) Fix some issues in trimming spaces around special strings
2021-07-08 15:34:38 +01:00
Wayne Stambaugh
65c7958293
Coverity issue fixes.
...
Issues #331869 , #331875 , #332203 , #332159 , #332171 , #332180 , and #332648 .
2021-07-08 08:33:08 -04:00
Jeff Young
3f165c70e1
Import more Alitum parameters.
...
ADDED CURRENT_DATE titleblock token (to go with existing ISSUE_DATE)
ADDED PROJECTNAME schematic token (to go with FILENAME and SHEETNAME)
Converts other parameters to project text variables.
2021-07-08 00:19:31 +01:00
Wayne Stambaugh
d6420d458e
Fix wxWidgets version check.
2021-07-07 16:52:21 -04:00
Wayne Stambaugh
7ca48c42d9
Fix build error in library tree widget.
2021-07-07 15:50:04 -04:00
Jeff Young
a4237c3346
Fix the search widget to process <enter>.
2021-07-07 17:54:22 +01:00
Jeff Young
1e76b7808f
Don't post events if un-evaluated-value isn't any different.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8745
2021-07-07 12:43:33 +01:00
Jeff Young
190b0ecdeb
Formatting.
2021-07-06 20:27:28 +01:00
Wayne Stambaugh
9d348d7e6d
Coverity issue fixes.
2021-07-06 13:32:34 -04:00
Jeff Young
799d6690c0
Only convert overbar syntax on names, refdes and text.
...
In particular, don't try and convert filenames which may be in
windows format.
Fixes https://gitlab.com/kicad/code/kicad/issues/git
2021-07-06 13:30:17 +01:00
Marek Roszko
5116fa6d12
Fix STEPPED_SLIDER glitchlyness on windows
...
wxWidgets drives some of this problem, it blindly calls SetValue and invokes the win32 update position messages on all the scroll subevents and we end up fighting it as well by inserting the rounded position on each subevent rather than the final one
2021-07-06 00:58:19 -04:00
Marek Roszko
70ce74ed4a
Configure page and line size in STEPPED_SLIDER
2021-07-06 00:40:53 -04:00
Marek Roszko
c356cd2aa9
Enable the tick marks to actually show on the STEPPED_SLIDER
2021-07-06 00:06:57 -04:00
Marek Roszko
96a177da3d
Add more input controls to IsInputControlEditable
...
O god this is going to eventual cause performance issues....but this fixes keyboard based form input in some places like pl_editor with its dropdowns
2021-07-05 23:47:16 -04:00
Marek Roszko
1fb42c5e43
Try and cleanup the input focus/key event a little
2021-07-05 20:48:48 -04:00
Marek Roszko
12305990bb
Fix focus stealing from wxDataViewCtrl
2021-07-05 13:45:06 -04:00
Marek Roszko
84092ce6d4
Update the event handling guard for focused controls
2021-07-05 13:45:06 -04:00
Jon Evans
4f3674bd1d
Fix mangling of direct json_pointer access
2021-07-05 12:33:08 -04:00
Jon Evans
3f55093bff
JSON_SETTINGS: Provide explicit CloneFrom
2021-07-05 12:26:21 -04:00
Marek Roszko
f524d9bec2
Add search control to the focus guard
2021-07-05 11:39:05 -04:00
Marek Roszko
2d696c3606
Update SetHint to SetDescriptiveText
2021-07-05 11:32:00 -04:00
Jeff Young
ea6769b702
The REPORTER interface is inherently line-based.
...
Also fixes a bunch of error messages that were similar but not
identical (which just increases translation burden).
Fixes https://gitlab.com/kicad/code/kicad/issues/8723
2021-07-05 13:41:06 +01:00
Jeff Young
6cc564aead
KiCad variable resolution is case sensitive OR all-upper-case.
...
Bring Altium variable references (which are case-insensitive) in as
all-upper-case.
Fixes https://gitlab.com/kicad/code/kicad/issues/6256
2021-07-05 11:05:46 +01:00
Marek Roszko
d2aeddc6cb
Add debouncing to the choose symbol dialog.
...
More potato pc friendly in theory.
2021-07-04 21:59:51 -04:00
Marek Roszko
3b33f94c56
Use a wxSearchCtrl instead of wxTextCtrl for the symbol chooser window
...
This just makes it prettier with the search icon and cancel
2021-07-04 21:24:03 -04:00
Marek Roszko
8e229a26c8
Fix define check added in dd11f86000
2021-07-04 18:50:58 -04:00
Jeff Young
dd11f86000
Don't show Ctrl-W for Close on MSW.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8391
2021-07-04 23:22:39 +01:00
Jeff Young
8f0104f921
Fix case of CLion getting a little carried away.
2021-07-04 16:23:57 +01:00
Mikolaj Wielgus
8b2b3ca797
Define .wbk in wildcards_and_files.{cpp,h}, cosmetic code changes
2021-07-04 14:04:03 +00:00
Jeff Young
c11ee69499
Save 3D prefs after editing, and load some of them into FP Props.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8712
2021-07-04 13:20:55 +01:00
david-beinder
f33ea6f997
Kiway: Improve performance by using IDs and clearing closed frame entries
2021-07-03 22:48:46 +00:00
david-beinder
a5308e5f5c
Fix python console toggle to work across pcbnew/eeschema
2021-07-03 22:48:46 +00:00
Jeff Young
5e30be66aa
Quiet unused variable warning on Mac.
2021-07-03 23:39:34 +01:00
Jon Evans
e95323a37e
Revert "Remove unused variable."
...
It's only unused on Mac
This reverts commit d3fb22014f
.
2021-07-03 16:48:46 -04:00
Jeff Young
d3fb22014f
Remove unused variable.
2021-07-03 21:16:15 +01:00
Wayne Stambaugh
3f6811f413
Minor dialog layout improvements.
2021-07-02 11:36:06 -04:00
Jeff Young
f8a34d98b3
Support for overbar syntax in Altium importer.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7979
2021-07-01 21:03:53 +01:00
Wayne Stambaugh
175b474c3e
Coverity issue fixes.
...
Fixes issues #280412 , #314755 , #329615 , #332459 , #332157 , #332167 ,
2021-06-30 18:08:49 -04:00
Jeff Young
6810912f09
Refuse to load schematics from the future.
...
Also fixes a bug where an empty window would get left when loading
a file from the KiCad manager window errored out.
Also fixes a bug where we were getting the wrong exception because
we were rethrowing the type-casted one (rather than just calling
throw).
Fixes https://gitlab.com/kicad/code/kicad/issues/8604
2021-06-30 18:32:07 +01:00
Jeff Young
5cac8afe1d
Remove long-dead revision support for LIB_IDs.
2021-06-30 13:12:57 +01:00
Jeff Young
b1b4caee6a
Escape "naughty" characters in symbol names.
...
It's tempting to say that we don't need to exclude filename chars
from symbols, but we might regret that decision down the road. Better
to just escape them.
Fixes https://gitlab.com/kicad/code/kicad/issues/8694
2021-06-30 13:12:57 +01:00
Jeff Young
0c2ac9a711
Move GUI font code to common.
...
This also allows the Mac fixes for font facenames to be more
compartmentalized.
Fixes https://gitlab.com/kicad/code/kicad/issues/8657
2021-06-29 18:27:58 +01:00
Jeff Young
1db33c7b3a
More safety (and better impl) for not sharing FP table/info stuff.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8657
2021-06-29 12:46:16 +01:00
Jeff Young
a1dfc36233
More error message regularization.
2021-06-29 01:08:26 +01:00
Jeff Young
3347531f70
Better zoom defaults for 3D viewer.
...
Also includes a fix for 3D model viewer in the file dialog for Retina
(and possibly other HIDPI) displays.
Fixes https://gitlab.com/kicad/code/kicad/issues/6144
2021-06-28 19:08:23 +01:00
Jeff Young
4594d88417
Help string for netclass colors.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7514
2021-06-28 13:23:41 +01:00
Jeff Young
d296bec5b8
Differentiate aSingleLine mode for SCINTILLA_TRICKS
...
This allows us to avoid the monospaced font (along with the tab-stop
handling), and process a <return> as an OK rather than just <shift> +
<return>.
Fixes https://gitlab.com/kicad/code/kicad/issues/8425
2021-06-28 11:20:12 +01:00
Jeff Young
062c4fda62
More error message regularization (and translatability improvements).
2021-06-28 00:45:24 +01:00
Jeff Young
4aa8318dc2
More error message regularization.
2021-06-27 14:24:02 +01:00
Jeff Young
0d72e253f0
Use correct error message box.
...
(Also updates the string to avoid the never-ending Mac double-quote
problem.)
2021-06-27 10:58:05 +01:00
Marek Roszko
ff2190630e
Optimize UnescapeString slightly to avoid repeated wxString::at calls
2021-06-27 00:54:52 -04:00
Marek Roszko
7802037495
Namespace the env_vars.h functions
2021-06-27 00:38:19 -04:00
Jeff Young
0f27618125
Use a list dialog that can be parented by the Board Setup dialog.
...
(The current one keeps pulling the Kicad Manager window to the front
on OSX.)
I also removed the UpdateUI stuff which was probably causing:
Fixes https://gitlab.com/kicad/code/kicad/issues/5049
2021-06-27 01:41:35 +01:00
Jeff Young
0dfb5fcaf9
Error message cleanup.
...
wxString::Format is redundant in a wxLogXXX call.
Error messages should generally be translatable.
Error messages should use generally consistent sentence forms.
2021-06-26 22:53:24 +01:00
Jeff Young
5c21f93803
Consistency in progress and error messages.
2021-06-26 13:23:43 +01:00
Thomas Pointhuber
e50eaed7b9
altium: Improve parsing of UTF-8 data
...
This is an implementation based on d4ccec05 from @fxtentacle
2021-06-26 13:58:56 +02:00
Jeff Young
95ec9c786c
Board setup spacing.
2021-06-26 10:55:31 +01:00
Jeff Young
1f4a56005e
Remove extraneous isPrinting test.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8609
2021-06-25 12:44:51 +01:00
Jeff Young
cbe7f9057b
Add link to wxWidgets bug report.
2021-06-25 10:09:49 +01:00
jean-pierre charras
964cbb95d3
gestfich.cpp: fix an issue on wxGTK when calling wxLaunchDefaultApplication()
...
- On wxGTK version < 3.1, the filename must be quoted if containing spaces,
and can be always quoted.
- On wxGTK version >= 3.1, the filename must *never* be quoted because
a quoted filename breaks wxLaunchDefaultApplication().
Fixes #8670
https://gitlab.com/kicad/code/kicad/issues/8670
2021-06-25 11:06:41 +02:00
Jeff Young
27804e40e2
Go back to using space-width for tabs (instead of max-char-width).
...
The max-char-width impl was buggy and never applied to PCBNew anyway.
Plus the stroke font has a max-char-width of 2.8 time the space width,
so it made for really wide tab spacing.
Also fixes a bug where the Scintilla editors weren't getting a
monospace font on Mac. (This bug may also exist on the other
platforms, but each would need its own fix.)
Also moves more of the Scintalla customizations to SCINTILLA_TRICKS
where they can be shared.
Fixes https://gitlab.com/kicad/code/kicad/issues/8666
2021-06-24 23:53:27 +01:00
jean-pierre charras
450b0c9e27
single_top.cpp: re-add lines removed by commit 5fa5a73c
, needed in stand-alone.
...
Otherwise, the main frame created in stand-alone mode is never shown.
2021-06-24 09:04:27 +02:00
Jeff Young
5fa5a73c6d
File open/import progress dialogs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6864
Fixes https://gitlab.com/kicad/code/kicad/issues/2166
2021-06-23 23:55:54 +01:00
Jeff Young
3269f45776
Add wxDataView-style defensive code to wxListView usage.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8657
2021-06-22 22:25:06 +01:00
Marek Roszko
c72914c43c
Use Normalize instead of MakeAbsolute
...
Ugh doing this while headhurts much
2021-06-21 18:07:23 -04:00
Marek Roszko
5184908dd1
Fix accidental oversight for linux run from build dir paths
2021-06-21 18:05:38 -04:00
Marek Roszko
aadb62bd42
Avoid generating paths on windows with ".." in them
...
This causes wxwidgets to failover to legacy windows dialogs as windows doesn't know how to handle them being passed to dialogs.
2021-06-21 18:03:55 -04:00
Jeff Young
fb4343bc8f
Expand text bounding boxes a bit for diacriticals, descenders, etc.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8551
2021-06-20 23:22:56 +01:00
Jeff Young
99da3d1336
Bail on single instance checker.
...
We lock the project file, board, and schematic now, so the second copy
can only open them read-only. While issues might remain, it's unclear
the warning ever prevented anyone from shooting themselves in the foot
anyway.
Fixes https://gitlab.com/kicad/code/kicad/issues/7465
2021-06-20 21:37:02 +01:00
Jeff Young
3d7e18561d
Checkpoint of app-specific single-instance checking.
...
(I'm about to nuke single-instance checking entirely, but wanted to
make sure this was captured in GIT somewhere.)
2021-06-20 21:37:02 +01:00
Jeff Young
8631d670a4
Don't selectall in GTK text boxes.
...
It's not clear that it's normal platform behaviour, and some GTK
window managers fail to non draw the selection in inactive text
boxes.
Fixes https://gitlab.com/kicad/code/kicad/issues/8197
2021-06-20 21:37:02 +01:00
Jeff Young
5a43392eae
Protect against double overbar format conversion.
2021-06-20 11:26:16 +01:00
Jeff Young
937f5138db
Make zoom-to-fit margin big enough for infobar.
...
Otherwise part of the document is obscured behind it by default.
2021-06-19 22:45:47 +01:00
Érico Nogueira
88a8ef949c
Remove OpenSSL locking from kicad_curl.
...
It's fair to assume all libcurl versions in circulation will already be
using OpenSSL>=1.1.0. This code is also unnecessary on platforms that
use other libcurl SSL backends, such as Debian's libcurl-gnutls package.
2021-06-19 19:43:54 +00:00
Jon Evans
518ccb3f9a
Fix typo
2021-06-19 15:10:35 -04:00
Jon Evans
5a832fc337
Fix assert that fires sometimes when closing windows on mac
2021-06-18 18:15:00 -04:00
Jon Evans
1edc232af1
Only run window position correction on wxMac
...
Other platforms seem to handle this properly already, and
fighting against size changes is not desirable
2021-06-18 12:47:10 -04:00
Jon Evans
4c8a4e3d47
Fix wx 3.0 build
2021-06-18 00:21:56 -04:00
Jon Evans
32c21f4a94
Fix several window sizing problems on macOS
...
- Remove outdated y-offset that prevented restoring full-height
(client area returned by wx is correct these days)
- Clamp frame geometry to fit new display when display is changed
- Handle when an automatic window reposition causes a DPI change
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8341
2021-06-17 23:59:19 -04:00
Jeff Young
7fde05e8ee
Add title to Save Changes dialog.
2021-06-17 18:23:58 +01:00
Jeff Young
1722bc03b0
Consistent terminology and punctuation.
2021-06-17 00:05:17 +01:00
Mikolaj Wielgus
2a3d8e22b6
Do not create overbar from "~~" when converting to new format
...
Fixes bug 4 from https://gitlab.com/kicad/code/kicad/-/issues/8591 .
2021-06-16 22:35:39 +00:00
Jeff Young
0d2ea6223b
Don't throw in a release build if the "keep" namespace is missing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8618
2021-06-16 17:31:31 +01:00
Marek Roszko
45c7c7c350
Remove unused m_crossHairPosition
2021-06-15 21:25:27 -04:00
Mikolaj Wielgus
9a42ec753f
Recognize ' ', '}', ')' as terminators of overbar in conversion
...
Fixes bug 3 in https://gitlab.com/kicad/code/kicad/-/issues/8591 .
2021-06-15 22:07:35 +00:00
Jeff Young
abc5a6e775
Migrate net names in netclass info.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8606
2021-06-15 00:17:39 +01:00
Jeff Young
38312f0aca
Don't rely on exception processing for normal flow.
...
Also make sure when we do update the json in the parent to use the
form that will create the object if it doesn't already exist.
2021-06-15 00:17:39 +01:00
Wayne Stambaugh
fb46cd8bc5
Expunge the use of the word component from Eeschema code.
...
The only exception to this is the SPICE simulator's use of component
when referring to physical component (R, L, C, etc.) values.
2021-06-14 14:00:21 -04:00
Jeff Young
2c1da70181
Write all variables to temp config file and have Kicad2Step use that.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7670
2021-06-14 16:54:45 +01:00
Michal Schulz
44978f00e3
Use compiler-agnostic designation of fall-through in switch/case.
2021-06-14 14:52:37 +00:00
Wayne Stambaugh
71c183d7bb
Rename LIB_PART to LIB_SYMBOL.
2021-06-14 07:11:17 -04:00
Mikolaj Wielgus
2af06a9d60
Fix stroke text size calculation and bitmap text overbar
...
Fixes bug 1 from https://gitlab.com/kicad/code/kicad/-/issues/8591 .
Fixes a bug where no overbar would appear in bitmap text.
2021-06-14 09:09:30 +00:00
david-beinder
da833ad7dd
Separate focus from hover state in BITMAP_BUTTON, trigger after mouse down+up
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8556
Adds AcceptDragInAsClick() to maintain support for use in toolbar palettes
2021-06-13 17:00:41 +00:00
Jon Evans
db276909ba
Get rid of screen border region logic
...
This prevents restoring perfectly-valid screen locations, and
I'm not sure what problem it is trying to solve (it's already
disabled on Windows, and this is confirmed to mess up restoring
locations on Mac/Linux).
If this was actually fixing a problem, the fix needs to be more
targeted, but since I don't know what the problem was, I'm just
going to take it out for now and wait for a potential problem
to pop up again.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8595
2021-06-13 12:52:09 -04:00
Jeff Young
74cefecaac
Add legacy empty-string token handling to EDA_TEXT.
2021-06-13 12:11:01 +01:00
Jeff Young
a64ac820db
Refresh canvas after running event from toolbar.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8592
2021-06-12 22:31:25 +01:00
Jeff Young
d044e6fed3
Don't try and convert legacy empty-string tokens to overbar syntax.
2021-06-12 20:40:41 +01:00
Jeff Young
db8cbad2d7
Add Ctrl-Q symbol to quit items in menus.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8391
2021-06-12 11:59:28 +01:00
Jeff Young
9328c78b08
Fix issue with overbars in bitmap text.
2021-06-12 11:49:12 +01:00
Jeff Young
be980df1ca
Fix uninitialized variable.
2021-06-12 11:33:18 +01:00
Seth Hillbrand
09e1a0dc48
Increase maximum zoom for pcbnew and gerbview
...
Zoom levels remain the same but high zooms reachable by mouse wheel
Fixes https://gitlab.com/kicad/code/kicad/issues/7093
2021-06-11 14:26:38 -07:00
Jeff Young
096e342386
Prefix TRACK, ARC and VIA.
2021-06-11 22:07:02 +01:00
Mikolaj Wielgus
63c263090f
Add versioning to page layout editor worksheets
2021-06-11 18:40:57 +00:00
Mikolaj Wielgus
ade38f48bc
Add conversion from old `~...~` to new `~{...}` notation
2021-06-11 18:40:57 +00:00
Mikolaj Wielgus
3d520ebe1e
Replace `~...~` overbar syntax with `~{...}`
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8134
Fixes https://gitlab.com/kicad/code/kicad/issues/4227
2021-06-11 18:40:57 +00:00
Jeff Young
7fdbe2f387
Fix uninitialized variable found by JP.
2021-06-11 19:38:16 +01:00
Jeff Young
16b0147af8
Prefix DIMENSION types.
2021-06-11 17:59:44 +01:00
Jeff Young
44086ff2b2
Pull 3D preferences into KiCad preferences architecture.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5187
2021-06-11 11:19:40 +01:00
Wayne Stambaugh
fbc135e69f
Rename SCH_COMPONENT to SCH_SYMBOL.
2021-06-10 10:34:49 -04:00
luz paz
5f1e9bc8a7
Fix typos in source code
2021-06-10 01:24:15 +00:00
luz paz
f968fc8719
Fix source comment / documentation typos
2021-06-09 19:32:58 +00:00
david-beinder
053bd66650
Fix localization of OS unsupported message, disallow bug reports from W7
2021-06-09 19:01:54 +00:00
jean-pierre charras
5cce3f6e18
Fix a few Coverity warnings (not initialized vars) and a minor compil warning
2021-06-09 19:03:44 +02:00
Jeff Young
9411d301a0
Repair recent pass-by-reference cleanup.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8576
2021-06-09 10:56:53 +01:00