8c3cd200d1
Clean up layer handling and normalize to remove magic numbers.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12747
(cherry picked from commit 5fe5534822
2022-10-25 14:21:03 +01:00
a5fd03df88
Don't delete pin out from under selection & move tools.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12610
(cherry picked from commit 3cb6a80954
2022-10-25 14:21:03 +01:00
2d2912c23d
Improve logic of Position Relative tool
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12672
2022-10-24 18:46:15 -04:00
3106f6c9f4
We must check clearance on all layers of multi-layer items.
...
(One layer may have a custom rule.)
Fixes https://gitlab.com/kicad/code/kicad/issues/12733
(cherry picked from commit 2dec37f806
2022-10-24 10:57:07 +01:00
fde2b429b9
Make sure pair caches are layer-specific where they need to be.
...
(cherry picked from commit 909358e643
2022-10-24 10:57:07 +01:00
0593663462
Fix 3D viewer canvas timer event clash.
...
Manual cherry-pick of commit f6297d328c
2022-10-23 07:53:51 -04:00
bce8c95647
Avoid netlist export dialog crash from trying to delete a non-custom format
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12229
2022-10-22 16:41:32 -04:00
4d729110d5
Fix build error due to C++17 use
2022-10-22 16:38:17 -04:00
6c2b9eb433
Bring 6.0 msvc ci in line with master
2022-10-22 17:12:29 +00:00
df223cced4
pl_editor: fix a crash when trying to delete an item during its creation.
...
Fixes #12717
https://gitlab.com/kicad/code/kicad/issues/12717
2022-10-22 18:32:46 +02:00
8e331628b6
Do not add a title/comment in mandatory field strings when writting netlists.
...
This is mainly for "Sheetfile" property because current it is the only one
that has a title when plotting/drawing it.
2022-10-22 15:38:26 +02:00
ceaf3fc72d
Ngspice: Preload a basically empty circuit to avoid error messages
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12481
(cherry picked from commit 6e874f4c1e
2022-10-21 09:22:53 -07:00
b004d7a1cb
Fix ERC global label unit tests
...
Need to test all units in the subgraph as there are chances that the
subgraph might have more than one label, which needs to be consistently
handled
(cherry picked from commit 60374daa49
2022-10-21 09:17:11 -07:00
f3ff9ddd31
Show ERC errors when any label only has 1 pin
...
To be connected, the label must have at least two pins on a subgraph
(or, in the case of a hierarchical label, two pins somewhere in its
connection)
Fixes https://gitlab.com/kicad/code/kicad/issues/7203
(cherry picked from commit 05cdf915d0
2022-10-21 09:11:24 -07:00
e5fa18c9b1
fix an issue in a bom script (extra empty lines created)
...
Fixes #10473
https://gitlab.com/kicad/code/kicad/issues/10473
(cherry picked from commit 380cb452b2
2022-10-21 09:10:30 -07:00
d52f246b2a
Allow up to three discarded characters when detecting gerbers
...
Some layout programs add a blank block at the beginning but include the
terminating '*' on a line before starting the actual data. This is
ignored by GerbView so we all this type of behavior in the mimetype file
detection as well
Suggested by Mark Jeronimus
Fixes https://gitlab.com/kicad/code/kicad/issues/12097
(cherry picked from commit 64335d94d7
2022-10-21 09:10:01 -07:00
3dfbe582db
Add "Letter-like character" Omega for Unicode x2126
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12531
(cherry picked from commit 1b38acd9c6
2022-10-21 09:08:58 -07:00
431aa88612
Allow printing backgrounds prior to foreground
...
Eeschema shows background fills on a different z-level than the rest of
the symbols/elements. Print the backgrounds prior to the foregrounds in
order to preserve this view for print output
Fixes https://gitlab.com/kicad/code/kicad/issues/12559
(cherry picked from commit e055302a3c
2022-10-21 09:00:13 -07:00
03a1a8e6d3
Fix missing token initializer
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12555
(cherry picked from commit fdf9fcc24d
2022-10-21 08:58:59 -07:00
5f6de83981
Ensure that token size is large enough
...
Input tokens can be arbitrary, so output needs to keep pace
Fixes https://gitlab.com/kicad/code/kicad/issues/12555
(cherry picked from commit 19378675f1
2022-10-21 08:40:30 -07:00
02d38db577
Fix about fix_swig_imports.py, useless or not working with swig 4, but needed by swig 3
...
fix_swig_imports.py cleans pcbnew.py, but the section to clean does not exist
in swig 4, only in swig 3.
2022-10-21 16:33:01 +02:00
bd1698f80e
Allow GAL_DRAWING_CONTEXT dtor to throw exceptions.
...
These destructors are implicitly noexcept, which woudnt't allow
OpenGL errors to be caught in DoRePaint.
Fixes https://gitlab.com/kicad/code/kicad/issues/12117
(cherry picked from commit 39089ad805
2022-10-21 17:24:11 +03:00
6de30b19a0
Don't sync the world twice in inline router tools.
...
Activate() already clears and syncs the world via PNS::TOOL_BASE::Reset,
so there's no need to sync in InlineDrag and InlineBreakTrack.
(cherry picked from commit cc4e34ef49
2022-10-21 17:21:24 +03:00
00ff5baf59
kiplatform: Add quotes to restart registration command line.
...
(cherry picked from commit 6e0d940b98
2022-10-21 17:20:29 +03:00
152252c685
Fix selecting pads of footprints in groups.
...
(cherry picked from commit 67985510a8
2022-10-21 17:19:05 +03:00
3b0466f3e8
Fix selection and entering in nested groups.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12586
(cherry picked from commit 0fea6f5ac3
2022-10-21 17:18:07 +03:00
2ca7a76693
Don't connect disparate nets
...
Only some elements get their nets assigned based on connectivity. Other
elements should be keps in different clusters for connection
Fixes https://gitlab.com/kicad/code/kicad/issues/12622
(cherry picked from commit c9f11827a7
2022-10-21 11:35:31 +01:00
af159c9841
Be sure to update UUID when placing new elements
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12588
(cherry picked from commit a5da46459c
2022-10-21 11:19:46 +01:00
de9ae28bdb
Fix typo.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12467
(cherry picked from commit bb1eb94aa0
2022-10-21 11:16:19 +01:00
9f151025b3
Fix typo found by dsa-t.
...
(cherry picked from commit 7e97dc6974
2022-10-21 11:14:05 +01:00
549dca1a05
Copy connected-only and keep-top-bottom properties.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12691
(cherry picked from commit 585fac19c6
2022-10-21 11:12:02 +01:00
da520f83ee
Use comma to separate diff pair nets/netclassse rather than /.
...
("/" is problematic because it's more likely to appear in netnames.)
Fixes https://gitlab.com/kicad/code/kicad/issues/12592
(cherry picked from commit 6fd195c389
2022-10-21 11:11:02 +01:00
47547713de
Broaden reset-sizes-after-layer-switch algorithm.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12576
(cherry picked from commit 40ad5b6de3
2022-10-21 11:09:47 +01:00
705570923e
Fix some outdated things (mainly about fix_swig_imports.py, useless with swig version 4)
...
From Master, commit 397a9302Fixes #12414
2022-10-20 17:12:57 +02:00
2827835720
board_stackup_manager: fix incorrect behavior when adding a new dielectric layer.
...
From Master branch
Fixes #12680
https://gitlab.com/kicad/code/kicad/issues/12680
2022-10-20 11:47:04 +02:00
bf95906f90
Re-entrancy guard for router tool.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12604
(cherry picked from commit 413fd82813
2022-10-19 18:24:33 +01:00
e8d2c222b6
We need both a tool-oriented delete and one that doesn't push/pop, etc.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12600
(cherry picked from commit 46752499df
2022-10-19 18:22:32 +01:00
f891c4641b
We were saving the old board pointer, but not updating the current one.
...
This also makes a few other adjustments to order and to where we look
for the enabled layers which should make it more robust.
Fixes https://gitlab.com/kicad/code/kicad/issues/10925
(cherry picked from commit 631980b0ab
2022-10-19 18:17:40 +01:00
a65fc7f82a
Pin 0-sized pads at 1um rather than throwing them out.
...
(See bug report for more commentary.)
Fixes https://gitlab.com/kicad/code/kicad/issues/12617
(cherry picked from commit 46a41e2e34
2022-10-19 18:15:49 +01:00
5bcd0a5828
Update router sizes when switching layers.
...
We may have layer-specific rules involved. Note that at some point
we also need to do something similar on every "fix route" step to
handle area-specific rules.
Fixes https://gitlab.com/kicad/code/kicad/issues/12576
(cherry picked from commit d8a3ba7917
2022-10-19 14:47:08 +01:00
74d8040e8c
Force flashing when generating SOLIDs.
...
We only have a single SOLID per pad, so the solid's shape must always
be the flashed shape and then we can do layer-specific flashing tests
internally.
Fixes https://gitlab.com/kicad/code/kicad/issues/12458
(cherry picked from commit 08260661b8
2022-10-19 14:43:13 +01:00
c5514d43c7
Don't reset editPad if it still exists after model reset.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12630
(cherry picked from commit 8b9cbd5805
2022-10-19 14:42:16 +01:00
0704e37eb5
Make sure a collector has a guide before handing it to a client filter.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12460
(cherry picked from commit 1566bd8b14
2022-10-19 14:41:30 +01:00
c94de31a8c
Try to reconcile SELECTION and BRIGHTENED use of overlay.
...
For some reason the overlay doesn't get redrawn during the PCBNew
selection disambiguation menu, so we need to not hide BRIGHTENED
items.
Fixes https://gitlab.com/kicad/code/kicad/issues/12547
(cherry picked from commit 436d75e7f9
2022-10-19 14:40:07 +01:00
2793e67bab
Bring adding-to-group and hiding in sync.
...
(cherry picked from commit 6a6ef9b1f4
2022-10-19 14:39:45 +01:00
3213ea582d
Avoid trying to draw empty pads.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12605
(cherry picked from commit e866dfe137
2022-10-19 14:38:40 +01:00
6003097411
Areas might have layers defined in area as well as rule.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12584
(cherry picked from commit 51c20da93e
2022-10-19 14:34:22 +01:00
6390633a7b
Use GetCurrentNets(), not m_startItem for message panel updates.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12592
(cherry picked from commit cbb997a3b5
2022-10-19 14:28:06 +01:00
dde5f2bed1
Respect DRCEpsilon in diff-pair coupling test.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12587
(cherry picked from commit 9119b5072a
2022-10-19 14:26:19 +01:00
7c4b8d50dd
Fix qa test.
2022-10-19 14:26:19 +01:00
Jeff Young
Jon Evans
Wayne Stambaugh
Marek Roszko
jean-pierre charras
Mikolaj Wielgus
Seth Hillbrand
Alex