haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
31,612 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

1112 Commits

Author SHA1 Message Date
Ian McInerney e08387ce3d Make the GAL responsible for the native cursor management 
The native cursor must be set on the GAL canvas wx object,
not its frame (otherwise on GTK the cursor is only set
when we get a request for it from the WM and not immediately).

Fixes https://gitlab.com/kicad/code/kicad/issues/6421
 2021-04-05 02:36:12 +01:00
Jeff Young 329577cc5c Add new text items/labels to the selection so rotate/mirror/etc. work. 
Also clears the selection after finding the sheet in the sheet pin
case so that the sheet itself doesn't get rotated/mirrored/etc.

Fixes https://gitlab.com/kicad/code/kicad/issues/8108
 2021-04-03 19:41:24 +01:00
Jeff Young 32e8a17cc0 Fix nullptr error. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8102
 2021-04-03 11:15:11 +01:00
Ian McInerney bb95761642 Remove unused variable 
item is already an SCH_ITEM, so the static cast is pointless.
 2021-04-02 19:26:22 +01:00
Jeff Young c7d689a022 Show field children when creating new labels. 
And in particular, show reasonable intersheet reference facsimiles.
 2021-04-02 15:15:07 +01:00
Ian McInerney 0a0935e0f3 Remove ACTIONS::TranslateLegacyId and TOOL_DISPATCHER::DispatchWxCommand 
After commit 9535153f9e there were no more IDs inside the legacy ID
system. Therefore the entire system for dispatching and looking up
the legacy ideas and handling those events can now be removed and
the tool dispatcher simplified (it no longer needs to know about
the ACTIONS class).
 2021-03-30 23:20:22 +00:00
Jeff Young f2e68e68d0 Add "Hide Tree" context menu options when tree has no selection. 
Also cleans up some other code to be more consistent between symbol
editor and footprint editor.

Fixes https://gitlab.com/kicad/code/kicad/issues/8052
 2021-03-29 12:02:00 +01:00
Jeff Young 14e73d24dc Naming conventions. 2021-03-29 11:46:05 +01:00
Jeff Young 455e7dc3a8 Reorder for better readability and consistency. 2021-03-29 11:04:06 +01:00
Jeff Young 1b163c5dd3 Don't eat delete event when there's no item being drawn. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8061
 2021-03-29 10:59:45 +01:00
Jeff Young 0561ce903e Don't remove IS_MOVED flag too early. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8056
 2021-03-28 20:05:41 +01:00
Jeff Young c32932a311 Naming conventions. 2021-03-28 20:05:41 +01:00
Ian McInerney 42c6af4bd8 Cleanup ACTION_MENU creation in some places 
The ACTION_MENU constructor now takes the tool as an argument,
so the call to SetTool() immediately following it can be removed
and the tool just passed into the constructor.
 2021-03-27 19:16:58 +00:00
jean-pierre charras bbd7b4ca8c Eeschema, selection tool: uniformize the cursor shape and the actual modifiers. 
SHIFT, CTRL, ALT modifier keys were handled in 2 different codes, one for
the selection tool and another to modify the mouse cursor shape, with 2
different configs.
Now the modifiers are managed from only one function.
Pcbnew: group also SHIFT, CTRL, ALT modifier keys management to a specific function.
Fixes #8021
https://gitlab.com/kicad/code/kicad/issues/8021
 2021-03-25 10:28:20 +01:00
Wayne Stambaugh b37b7d53b4 Fix geographic annotation bug when back annotating to schematic. 
For some reason, the footprint UUID was being prefixed to the sheet path
which caused the symbol look up by sheet path to fail.  An option was
added to not do this when the geographical back annotation to the schematic
is performed.
 2021-03-24 09:57:36 -04:00
Roberto Fernandez Bautista be51be22a7 Update Page Number when Duplicating or Pasting sheets 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7872

Also, update hierarchy before renaming pasted sheets
Avoids duplicate sheet names when pasting multiple sheets
 2021-03-23 02:48:07 +00:00
Jeff Young cf4cbea8a1 Use a more robust storage of items added to drag. 
We kept having various issues of the pointer list going stale.  This
will prevent all permutations of that.

Also while I was in there I fixed the double-move thing (see bug
number).

Fixes https://gitlab.com/kicad/code/kicad/issues/7910
 2021-03-22 13:51:10 +00:00
Jon Evans c5c348538e Fix some STL asserts in EE_SELECTION_TOOL 2021-03-21 22:01:45 -04:00
Jon Evans c04e19f9ac Include optimization: move some things from common.h to point-of-use 2021-03-20 12:09:18 -04:00
Jeff Young f0e6f812ff Edit One Field improvements. 
1) Accept <enter> as OK if the multiline textbox isn't shown.
2) Focus and select all in first control if multiline textbox isn't shown.
3) Make title be title caps ("Edit Sheet name Field" looked dorky).

Fixes https://gitlab.com/kicad/code/kicad/issues/7940
 2021-03-20 00:41:09 +00:00
Jeff Young 2e129d9b47 Naming conventions and other cleanup. 2021-03-19 23:06:19 +00:00
Jon Evans 4b46c0c954 Make sure nested settings get released in dtor 
Also fix a crash if sim window can't be created because
ngspice shared library could not be found

Fixes https://gitlab.com/kicad/code/kicad/-/issues/7969
 2021-03-19 19:04:27 -04:00
Jeff Young e206a9d39a Naming conventions. 2021-03-18 12:28:24 +00:00
Jeff Young cc70a9fa98 New components must be added to the screen. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7952
 2021-03-18 12:28:24 +00:00
Jeff Young 35d17929ff Add specific warning for no symbol library selected. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7954
 2021-03-18 12:28:24 +00:00
Jeff Young 7e682e9948 Don't allow pins on corners. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7917
 2021-03-16 22:03:08 +00:00
Jeff Young 30fdba4cbb Finish grid-snapping impl. 2021-03-16 22:03:08 +00:00
Mikolaj Wielgus ee4bc8b1d0 Fix default line width for symbol editor graphic items, add validation 
There was a mils to iu conversion missing for line width (the default
values are in mils).

Fixes https://gitlab.com/kicad/code/kicad/issues/7813
 2021-03-16 13:50:41 +00:00
Jeff Young 2bafc1af00 Give up on using preview layer for PlaceComponent. 
1) Cloning the component fails to select all its pins.
2) Something about the layer compositing causes light selection shadows
to get even lighter.  The default pretty much disappears.

Fixes https://gitlab.com/kicad/code/kicad/issues/7908
 2021-03-15 19:04:59 +00:00
Jeff Young 573dd36515 Handle <delete> in move and drawing tools. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7924
 2021-03-15 14:23:54 +00:00
Jeff Young afab60ae06 Fixes for autoplace fields. 
1) Don't factor in pin names when computing symbol body boundingbox.
2) Grid-snap only in the axis corresponding to the layout side.
3) We only need interline spacing *between* lines, not for each line.
4) Also cleans up the unit checking logic as the unit can't be more
than 0 unless it's a multi-unit symbol.

Fixes https://gitlab.com/kicad/code/kicad/issues/7907
 2021-03-15 02:23:29 +00:00
Jeff Young 7415bf0c62 Don't hide (or disable) options if it's not obvious why. 
It deprives us of the opportunity to inform the user what the conditions
are.
 2021-03-15 02:23:29 +00:00
Jeff Young e34734c230 Make sure pasted sheet instances get added. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7872
 2021-03-13 16:34:30 +00:00
Jon Evans 18037e2f65 Rework bitmap system to load from archived PNGs 
Bitmaps are now identified by an enum class instead of by pointers.
Bitmap loading and caching is now handled by a class in common, and
we no longer compile most bitmaps into the binary, so there is no
longer a bitmaps static library.

Instead, bitmaps are archived to a .tar.gz file which is installed
in ${KICAD_DATA}/resources/images.tar.gz

The source PNGs are checked in to Git as the original CPP files were,
so that people can build without the required dependencies to convert
SVGs to PNGs.

Initial support is also added for dark theme icons, although this
is not yet exposed in the GUI.

Stubs are present for multi-resolution image resources, but this is
not fully-baked yet and could use some refinement.
 2021-03-11 08:37:35 -05:00
Jeff Young 068e85c567 Reset moved flag after completing move. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7818
 2021-03-10 16:00:28 +00:00
Jeff Young e48f86bfd6 Move default assignment on Mac. 
CHANGED: add corner and repeat last command now default to 'I' instead
of '<insert>' on Mac.

1) wxWidgets doesn't currently display the correct graphic in the menu
for the insert key
2) Mac laptops don't have an instert key

Fixes https://gitlab.com/kicad/code/kicad/issues/5016
 2021-03-10 13:35:04 +00:00
Jeff Young 8be3ff5a0a Perform a slightly more aggressive cleanup. 
Also removes the functionality that selects the newly-added item as
we don't do that with any of the other drawing tools.

Fixes https://gitlab.com/kicad/code/kicad/issues/7833
 2021-03-09 21:42:35 +00:00
Jon Evans 720147d272 Remove transitive inclusion of bitmaps.h 2021-03-07 16:08:57 -05:00
Jeff Young 22b4a74bfa Don't forget intersheet refs when collecting non-view items. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7819
 2021-03-07 15:04:01 +00:00
Jeff Young 3ab1ef7b83 Formatting. 2021-03-07 15:04:01 +00:00
PJM 0fc8a9d89a Eeschema: Fix ctrl-MMB double click to perform 'Zoom to Objects' 
CHANGED: Ctrl-middle mouse button double click should perform
'Zoom to Objects' in Eeschema, but a change in modifier key handling
broke it.  This MR restores the functionality.

Fixes https://gitlab.com/kicad/code/kicad/issues/7803
 2021-03-04 22:43:03 -08:00
Jon Evans 4ddb942ec0 Do not allow drag selection or drag move when already moving something 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7800
 2021-03-04 19:01:31 -05:00
Wayne Stambaugh 7a00e01b3e Eeschema: fix false positive library symbol changed ERC errors. 
This fix required sorting all of the LIB_PART draw items to ensure
accurate comparison between the symbols stored in the schematic and the
original library symbols.  This has a noticeable impact on symbol library
load performance.  It may also cause significant changes the next time
the library is saved due to changes in the draw item sorting.  Hashing
may be a better solution here but this addressed the immediate problem.

A skeleton method SCH_SCREEN::SwapSymbolLinks() was added because there
is most likely an issue with orphaned symbols in the schematic library
symbol cache during undo/redo operations.  More testing is required to
verify this.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/7263
 2021-03-04 17:59:24 -05:00
Jon Evans 1fc399fa31 Fix a few more cases of picking up wrong mouse positions 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7745
 2021-03-03 20:09:24 -05:00
Ian McInerney 908de37e7c Don't hardcode the file extensions where possible 2021-03-03 01:13:59 +00:00
Jonathan Haas f90164f7cf Fix some typos and improve wording 2021-03-02 19:13:49 +01:00
Jon Evans 375cd12258 Eeschema: never replace event position in wire drawing tool 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7745
 2021-03-01 12:17:18 -05:00
jean-pierre charras 9797bc5f25 Left Mouse Button: use same modifiers for Pcbnew, Eeschema and pleditor for selection. 
It also means the "force disambiguation menu" uses now Ctrl in Eeschema and pleditor.
 2021-02-25 08:22:35 +01:00
Seth Hillbrand 0bab025832 Fixup toolchaining for immediate mode 
The move tool can stack on others, so when we re-enter the previous tool
this caused another immediate action.  We flag re-entry in the tool
stack to check for this and avoid unexpected tool starts
 2021-02-24 10:44:54 -08:00
Jeff Young 2fd5f25c3c Allow expand selection to work (even if you probably can't get there). 
I think the guessSelectionCandidates narrows down to a single item
in 99.9% of cases, so we can probably remove this entirely.  But for
now it's safer just to fix it.
 2021-02-24 14:12:32 +00:00
Wayne Stambaugh 1786ae8773 Eeschema: use symbol nomenclature for object file naming. 2021-02-24 08:48:02 -05:00
Seth Hillbrand 0518d9c546 Add more force-immediate tools 2021-02-23 17:05:03 -08:00
Seth Hillbrand 005622027f Add component/footprint is always immediate 
When a user clicks on the "Add Component", "Add Power" or "Add Footprint"
icon, they want to add the item.  Requiring an extra click on the screen
before selecting the component/footprint is not needed.
 2021-02-23 16:15:31 -08:00
Jeff Young 7318417ca4 Fix typo in expand-selection-disambiguation menu logic. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7654
 2021-02-23 22:09:00 +00:00
Jeff Young c0487e5c87 Don't leave the cursor position forced. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7665
 2021-02-23 21:43:41 +00:00
Jeff Young 8755f55956 Fix copy-paste error. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7674
 2021-02-23 17:50:11 +00:00
Jeff Young a9ea617069 Add some defensive code for double-moves. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7665

Fixes https://gitlab.com/kicad/code/kicad/issues/7502
 2021-02-23 16:38:18 +00:00
Jeff Young 9eb2113a50 Make TwoClickPlace cursor handling match SingleClickPlace. 2021-02-23 15:28:45 +00:00
Jeff Young d7b6d4a541 Warn user when placing a junction is just going to remove it again. 
Also removes a duplicate call to SaveCopyForRepeatItem (which has
already been done in AddItemToScreenAndUndoList).

Fixes https://gitlab.com/kicad/code/kicad/issues/7651
 2021-02-23 12:51:15 +00:00
Jeff Young a3b9e8ddb4 Round 2 of Worksheet -> Drawing Sheet. 2021-02-23 11:57:44 +00:00
Jeff Young cad5198ab7 Worksheet -> (industry standard) Drawing Sheet. 2021-02-22 17:35:46 +00:00
Jeff Young 09d3667bce Fix bone-headed mess up of two-click-place. 
Original architecture was to pass KICAD_T in to specify what kind of
object you wanted.  That didn't work well with things like cursor
shape so it was moved to setting booleans based on the ACTION.  When
I cleared out the old KICAD_T stuff I missed one case where it was
still used.  That is now corrected as well.

Fixes https://gitlab.com/kicad/code/kicad/issues/7651
 2021-02-22 11:54:03 +00:00
Jeff Young 781d293b60 Add option for text updating to Update Symbol. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6420
 2021-02-22 00:36:40 +00:00
Jeff Young afb4bbde47 Bug fixes to Eeschema context menu. 
1) Fix typo in SingleSymbolOrPower
2) Remove Edit reference/value/footprint items for power symbols
 2021-02-21 23:45:32 +00:00
Mikolaj Wielgus f9c42585fb Force immediate action for auto start wire feature 
Fixes https://gitlab.com/kicad/code/kicad/issues/7503
 2021-02-21 18:43:34 +00:00
Jeff Young 18d4d517b0 Implement RMB Import Sheet Pin as a single-shot. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7638
 2021-02-21 15:46:53 +00:00
Marek Roszko 907e282347 Silence some msvc warnings 
- exception variables that were unused
- RAYSEG2D improperly foward declared with class instead of struct
- unused vars
 2021-02-20 11:58:55 -05:00
Jeff Young 26cb05051b fixup! Whittle down library tree context menus to be more contextual. 2021-02-19 19:07:45 +00:00
Jeff Young 57e043e0e6 Don't allow moving markers. Do allow excluding them. 2021-02-19 19:07:45 +00:00
Jeff Young c2f68ca4da Whittle down library tree context menus to be more contextual. 
(From discussion on Zulip.)
 2021-02-19 19:07:45 +00:00
James Jackson 48853d0c88 Eeschema: Allow auto-wiring / drawing from unconnected bus and graphic line endpoints 
Fixes https://gitlab.com/kicad/code/kicad/issues/7537
 2021-02-19 17:15:27 +00:00
Jeff Young b43db7cd7d Fix assert in Symbol Editor. 
Also allows some symbol lib operations when we know the context even
if the library itself isn't selected.  (For instance, select a symbol,
copy, paste.)
 2021-02-18 18:08:37 +00:00
Seth Hillbrand a25dfcd1b4 Allow "Update Symbol" command on power symbols 
Power symbols can be modified in the library so it is useful to allow
them to be updated with the right-click menu
 2021-02-17 15:31:22 -08:00
Jeff Young 2c4d53d994 Minor cleanup. 2021-02-16 21:11:36 +00:00
Jeff Young 2a7e60960a Use standard mirror icons & terminology. 
Also use standard group icons.

Also put both (and rotate commands) in toolbar.

Fixes https://gitlab.com/kicad/code/kicad/issues/7504
 2021-02-16 21:11:36 +00:00
Seth Hillbrand 24795f5b12 Fix overzealous breakSegments() 
We cannot break segements that are merely close or on endpoints, so we
filter these prior to the break routine.  Failing to do this was
overloading our undo stack with bogus values

Fixes https://gitlab.com/kicad/code/kicad/issues/7553

Fixes https://gitlab.com/kicad/code/kicad/issues/7557

Fixes https://gitlab.com/kicad/code/kicad/issues/7554
 2021-02-16 10:12:30 -08:00
Seth Hillbrand d93ba0a06a Choose half-grid for mirror 
Using the half-grid allows for odd-grid counts to remain on-grid,
closer to the actual center.

Fixes https://gitlab.com/kicad/code/kicad/issues/7493
 2021-02-15 11:59:04 -08:00
Seth Hillbrand 55e34592a6 Fix expand selection option in Eeschema 2021-02-15 10:53:17 -08:00
James 9205f1571d EE_SELECTION_TOOL correctly identifies buses and wires for auto starting 2021-02-15 14:57:06 +00:00
Jeff Young cf42d692bf Remove some dead code. A little bit of comment cleanup as well. 2021-02-15 14:13:43 +00:00
Jeff Young ec20121114 Make sure schematic symbol fields get transferred to symbol editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7501
 2021-02-14 18:30:14 +00:00
Jeff Young 0f463ee84b Add Update Symbol Fields dialog for derived symbols. 
ADDED This allows one to update a derived symbol's fields from the
parent symbol.

Fixes https://gitlab.com/kicad/code/kicad/issues/7168
 2021-02-14 12:15:26 +00:00
Seth Hillbrand 02c7fcdc84 Fix BreakWire tool 
Adds ability to start new commit to eeschema, allowing all
AddItemsToUndoList to always append without foreknowledge.  Keeps newly
split wires on the tool until placed

Fixes https://gitlab.com/kicad/code/kicad/issues/7512
 2021-02-12 17:17:12 -08:00
Jon Evans 1bec10b6fa Make it easy to select small things overlapping symbols 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7487
 2021-02-11 12:13:46 -05:00
Jeff Young a0b9b0c3ee Improve IsSymbolEditable to differentiate fields. 
Fields are editable in Aliases, but still not in Legacy libraries,
locked libraries, etc.

Fixes https://gitlab.com/kicad/code/kicad/issues/7175
 2021-02-10 22:57:23 +00:00
Mikolaj Wielgus 1dc0ef01b3 Fix automatic wire tool in gridless mode 
The automatic wire tool was not working in the gridless mode because the
grid snapping on/off logic present in `EE_GRID_HELPER`, based on the
value of `m_enableGrid`, was not taking into account that another check,
but for the global KiCad setting, would be performed in the `Align()`
method, which is inherited from `GRID_HELPER`.

I've modified all tests of `m_enableGrid` value to also take the global
setting into account, and moved checks for it to `Align()` method, as
it's more consistent this way.

I've also removed an override of the `Align()` method in the
`PCB_GRID_HELPER` class, as it was made redundant by my changes.

Fixes https://gitlab.com/kicad/code/kicad/issues/7402
 2021-02-10 22:07:49 +00:00
Seth Hillbrand 67ccee338e Give cleanup to the move tool 
For unknown reasons, the move tool was not clearing the stack when
called from the edit tool.  This moves the call to move tool to after
clearing the edit tool from the stack.  The move tool handles cleanup,
so we skip the original reason for waiting on the move tool before
finalizing the edit tool routines

Fixes https://gitlab.com/kicad/code/kicad/issues/7481
 2021-02-10 10:01:05 -08:00
Jeff Young a30ae6a237 Pass un-pretty-printed bus names through menu help text. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7412
 2021-02-10 15:03:06 +00:00
Wayne Stambaugh 356c2d3508 Symbol editor: fix symbol save as menu enable logic issue. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7451
 2021-02-07 18:21:59 -05:00
Jeff Young d70cebcd62 Allow clicking on terminal point to finish a bus unfold. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7413
 2021-02-07 00:31:00 +00:00
Michael Kavanagh db66cd50d7 Use Save As icon for Save As action in symbol editor 2021-02-06 22:51:56 +00:00
Jeff Young c2dbd28101 Simplify and harmonize symbol editor and footprint editor menus. 
Some differences are due to difference between libraries being files
in symbol editor and directories in footprint editor, but this unifies
most of the rest.

It also dispenses with the save-to-library vs save-to-document distinction
in the GUI because it makes for too much variability in the GUI, was
implemented differently between the two editors, and isn't needed as much
anymore now that we have the highly visible infobar.

There was also an issue that the save-to-board icon occupies the same
location and has the same size/shape/colours as the Board Setup icon in
PCBNew.

Fixes https://gitlab.com/kicad/code/kicad/issues/7215
 2021-02-06 14:33:16 +00:00
Seth Hillbrand 2aa8a3724f Don't continue until the move tool completes 
Starting a new action (to add junctions) will break the move tool loop
and cancel placement.  We need to wait until the tool completes before
choosing where to place the junctions

Fixes https://gitlab.com/kicad/code/kicad/issues/7421
 2021-02-05 10:18:34 -08:00
Jeff Young b4a9792e23 Add a warning for hidden power pins. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6440
 2021-02-04 22:47:37 +00:00
Jeff Young 62254309b0 Don't rotate fields if their parent is selected. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7410
 2021-02-04 00:05:13 +00:00
Seth Hillbrand b07c8110c8 Follow grid snapping when moving 2021-02-02 20:23:12 -08:00
Seth Hillbrand 238aa2b5b0 Snap to eeschema lines 
Allows easier snapping to lines when drawing in eeschema.

Fixes https://gitlab.com/kicad/code/kicad/issues/7378
 2021-02-02 19:33:18 -08:00
Seth Hillbrand ea08f1b8cb Update action short names for clarity 2021-02-02 19:33:18 -08:00
Jeff Young 147c839857 Allow drag-select of fields. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6662
 2021-02-01 17:14:30 +00:00
Seth Hillbrand ae5d2efe07 Snap common single-click tools 
Fixes https://gitlab.com/kicad/code/kicad/issues/7362

Fixes https://gitlab.com/kicad/code/kicad/issues/7363
 2021-01-31 15:17:24 -08:00
Seth Hillbrand 08a932a969 Add smarts to switch selection on right-click 
Now looks at how hard it is to select the item (grids) and switches only
if the mouse is more than a grid square away and there is a new item
under the mouse.

Fixes https://gitlab.com/kicad/code/kicad/issues/4455
 2021-01-31 07:00:48 -08:00
Jon Evans abf0a46dce Refactor PICKER_TOOL and push up snapping disable functionality 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7348
 2021-01-31 09:50:41 -05:00
Wayne Stambaugh 7737489e57 Symbol editor: don't allow new or imported symbols in read only libraries. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7334
 2021-01-30 13:03:05 -05:00
Jeff Young 41234a8373 Implement more precise annotation-required messages. 
Also moves the message to an infobar so it's more noticeable.

Fixes https://gitlab.com/kicad/code/kicad/issues/7332
 2021-01-30 16:31:27 +00:00
Jon Evans 1d12f3fe4a Fix logic in selecting power symbols for net highlighting 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7339
 2021-01-30 10:28:26 -05:00
Seth Hillbrand b64611af7a Make highlight net flexible with grid 2021-01-29 14:28:26 -08:00
Seth Hillbrand ea6dc0d730 Make auto-wire use snapping behavior 
Forcing grid snap for the kick-start behavior loses snaps to pins that
may be desired.  This also adds force-snapping in select mode to match
the user's auto-start preferences

Fixes https://gitlab.com/kicad/code/kicad/issues/7293
 2021-01-29 14:09:33 -08:00
Seth Hillbrand 02954dfaa1 Fix another instance of modifying iterators 
We cannot modify the ee_rtree while iterating over it without
invalidating the iterators

Fixes https://gitlab.com/kicad/code/kicad/issues/7331
 2021-01-29 08:33:44 -08:00
Jeff Young ff7742c6b8 File naming and include cleanup. 2021-01-28 11:35:18 +00:00
Jeff Young 7d6a749285 Implement a more aggressive re-entrancy check for SCH drawing tools. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7259
 2021-01-27 19:51:11 +00:00
Jeff Young f3047829e5 Mark document dirty after drag; don't wait for point editor deactivation. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7285
 2021-01-26 19:01:31 +00:00
david-beinder 1598e870b6 Insert the same unit on all sheet instances when adding a symbol 
Fixes https://gitlab.com/kicad/code/kicad/issues/5898 (C)
 2021-01-26 18:12:49 +00:00
david-beinder 2e21489acf Copy unit numbers to symbol instances when pasting sheets 
Fixes https://gitlab.com/kicad/code/kicad/issues/5898 (B)
 2021-01-26 18:12:49 +00:00
david-beinder 4bcd56b1f6 Always include unit number when copying to clipboard 
Fixes https://gitlab.com/kicad/code/kicad/issues/5898 (A)
 2021-01-26 18:12:49 +00:00
Wayne Stambaugh 4619d5e112 Fix more broken Doxygen comment specifiers. 2021-01-26 12:17:52 -05:00
Jeff Young b576ccef61 Don't double-up tools on tool stack. 
Also make sure move tool gets cancelled by other tools being
activated.

Fixes https://gitlab.com/kicad/code/kicad/issues/7259
 2021-01-26 10:56:19 +00:00
Jeff Young f6b7817044 Init intersheet refs props when converting to global label. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7252
 2021-01-25 13:20:16 +00:00
Jon Evans 8ad448cbbc Don't leave point editor running when moving things in eeschema 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7227
 2021-01-24 12:59:42 -05:00
Jeff Young df2d0962c6 Drop hover selection in Symbol Editor after edit action. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7234
 2021-01-23 17:12:34 +00:00
Jeff Young d770284fa2 Add a bus instead of a wire for bus junctions. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7231
 2021-01-23 17:04:44 +00:00
Roberto Fernandez Bautista 4f0accb714 Allow only updating reference links during back-annotation 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7190
 2021-01-20 00:37:38 +00:00
Jeff Young 360953ba98 "comp" -> "symbol". 2021-01-19 23:50:40 +00:00
Michael Kavanagh d32c12b4b9 Banish new project from template to the menubar 
+ remove inappropriate icon from Eeschema ctx menu
 2021-01-19 22:57:25 +00:00
Michael Kavanagh 80dbc24326 Icons: remove superfluous icon 
Remove icons where menu text gives context
 2021-01-19 22:57:25 +00:00
Jeff Young 351074cc48 Better-encapsulate collector sources in the selection tool. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7191
 2021-01-19 21:10:43 +00:00
Seth Hillbrand 4da28cf8f4 Fix bad dereference 
Fixes https://gitlab.com/kicad/code/kicad/issues/7188
 2021-01-19 08:39:22 -08:00
Jeff Young 2c9da4daa4 Make sure Check Pins works on a flattened copy of the part. 
Also improved the reporting slightly (in particular for pins with
no names or pins with the empty flag ("~").

Fixes https://gitlab.com/kicad/code/kicad/issues/7165
 2021-01-18 15:20:15 +00:00
Michael Kavanagh 479487ceb1 Tidy up context menus a bit 
Try and put the common actions in the same places
 2021-01-17 22:42:03 +00:00
jean-pierre charras e10025db64 Hierarchy navigation: keep the last used zoom level in a sheet when go back to this sheet. 
Fixes #7107
https://gitlab.com/kicad/code/kicad/issues/7107
 2021-01-17 09:41:49 +01:00
Jeff Young 68efdb2fff Push shared parts of GRID_HELPERs into common. 2021-01-16 23:18:10 +00:00
Jeff Young bae5825d1b Fix copy/paste error. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7119
 2021-01-15 13:14:47 +00:00
Wayne Stambaugh 2d64613bbb Coverity fixes. 
Reports 314745, 316271, and 316269.
 2021-01-13 11:23:09 -05:00
Jeff Young d23b5f89b3 Don't save sheet multiple times on undo stack. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7063
 2021-01-12 23:56:35 +00:00
Michael Kavanagh 8fba0c257b Icons: remove more inconsistencies around Select 
Missed from 5d9b2d3fea
 2021-01-11 23:31:24 +00:00
Jeff Young 50889a9ed6 Promote mouse drag settings to full enums. 2021-01-11 22:09:36 +00:00
Jeff Young 6c648df4c6 Support 3 drag vs. select options, and unifiy with other drag prefs. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5493
 2021-01-11 11:50:14 +00:00
Wayne Stambaugh 0655f2c436 Symbol editor: do not disable tools and grey symbols from schematic. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6968
 2021-01-08 18:25:18 -05:00
Jeff Young 51e6846ca5 Don't edit fields when more than one is selected. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7005
 2021-01-08 20:43:02 +00:00
Michael Kavanagh 54724096ea Icons: consistency between Eeschema and Pcbnew 2021-01-06 00:35:20 +00:00
Michael Kavanagh b40e3a39f5 Minor cleanup. 2021-01-04 23:59:36 +00:00
Jeff Young dc65166ee7 Implement algin-to-grid for fields. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6530
 2021-01-03 22:39:58 +00:00
Michael Kavanagh 154e19b6e7 Icons: use common prefix for small 16x16 2021-01-02 23:16:33 +00:00
Michael Kavanagh 6d3c1c7716 Icons: remove unused sources/duplicates + rename 2021-01-02 23:16:33 +00:00
Seth Hillbrand a69a4be853 Fix build error with icon names 2021-01-01 13:13:33 -08:00
Seth Hillbrand 5a0c3bf4bc Icons updates 
- Remove 22px bitmaps
- Move 24px icons to icon_XXX_24 filenames
- Update convert icon thanks to MisterHW

Fixes https://gitlab.com/kicad/code/kicad/issues/6088
 2021-01-01 11:00:15 -08:00
Marek Roszko db0f3b42b4 Stop the cursor from reverting away from the window select in eeschema 
Fix #6590
 2020-12-29 19:51:34 -05:00
Slawomir Siudym 157ceedc12 Fix offset of repeated pin in Symbol Editor 2020-12-29 18:32:46 +00:00
jean-pierre charras 77f651639d Eeschema: fix crash using tune/probe function in spice simulator. 
Fixes #6875
https://gitlab.com/kicad/code/kicad/issues/6875
 2020-12-29 13:13:58 +01:00
Jon Evans ac1f7f93a2 Save context menu position for bus unfold 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6378
 2020-12-27 13:07:16 -05:00
Wayne Stambaugh 5069d20768 Symbol editor: make library and symbol save as operations explicit. 
Prior to this change the "Save As.." command would take a different action
based on the state of the editor which could be confusing.  There are now
separate commands for saving the currently selected library or symbol.

CHANGED: The implicit save as menu entry which would save the currently
selected library if no symbol was selected or the current symbol to a
different library.  There are now separate save as commands for libraries
and symbols to make it obvious what is being saved.
 2020-12-27 11:55:32 -05:00
Jeff Young c16dda4027 Make sure added wires (from junctions) don't get left selected. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6852
 2020-12-27 13:17:03 +00:00
Jeff Young c0e5e8eeee Formatting. 2020-12-27 13:17:03 +00:00
Jeff Young 8a720ef305 Update naming. 2020-12-25 23:37:01 +00:00
Michael Kavanagh eb1f07bade Icons: standardise `export_png` to match set 2020-12-24 01:02:03 +00:00
Michael Kavanagh d2018b122b Icons: unify export_svg with the rest of the set 2020-12-24 01:02:02 +00:00
Jeff Young 3a3ef19ccb When rotating during a drag/move, only rotate user-selected items. 
In particular, don't rotate wires that had to be picked up; just
keep them connected.

Fixes https://gitlab.com/kicad/code/kicad/issues/6789
 2020-12-23 14:24:35 +00:00
Jeff Young fb7ac450d9 Read-only dialogs for symbols in legacy libraries. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5211
 2020-12-22 12:16:27 +00:00
Wayne Stambaugh f311831c27 Coverity fixes. 
280252, 314742, 314745, 314747, 314755, 314756, 314757, 314758,
314935, 314936
 2020-12-20 13:24:47 -05:00
Marek Roszko 9b0a137d6c Stop bludgeoncompiling dialog_page_settings 
Through the power of OOP!
Needs some more cleanup though
 2020-12-19 10:40:37 -05:00
Seth Hillbrand 489db6adde Handle case where multiple pins are moved 
When synchronized, if multiple pins are selected to be moved, we need to
match each to a matching pin in the new unit

Fixes https://gitlab.com/kicad/code/kicad/issues/2589
 2020-12-18 15:48:34 -08:00
Seth Hillbrand 0fd920a94c Modify Synchronize Pins behavior 
Consider a pin synchronized iff the names and electrical types match in
addition to the position, orientation and demorgan variant.

Also, only modify one matching pin per unit.  This prevents
moving/editing a full stack of pins on the same unit when synchonized.

Fixes https://gitlab.com/kicad/code/kicad/issues/2590
 2020-12-18 15:48:29 -08:00
Jeff Young b68b1692ec Clean up some more user messages. 
Mostly component -> symbol but also some I18N cleanup.
 2020-12-18 12:49:20 +00:00
Jeff Young 91ab540d18 Naming conventions. 2020-12-18 00:30:26 +00:00
Jeff Young c875efb635 Prevent modal deadlock by using QuasiModal mode. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6779
 2020-12-18 00:30:26 +00:00
Jeff Young bb232e6ac6 Unify LIB_IDs now that both are stored in sexpr files. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6764
 2020-12-18 00:30:26 +00:00
Jeff Young a6085fa88d Consistency for gerbview toolbar icons and some other icon tweaks. 2020-12-17 14:02:23 +00:00
Ian McInerney fc20eaa083 Fix some compiler and Coverity warnings 2020-12-17 00:30:22 +00:00
Seth Hillbrand dad2e317e9 Modify edit text & graphics to use pencil 2020-12-14 17:03:35 -08:00
Jeff Young 22a6b36257 Don't allow dbl-click to leak through to other tools. 
This only applies if the tool doesn't handle properties (which also
handles double-click events).

Fixes https://gitlab.com/kicad/code/kicad/issues/6735
 2020-12-14 22:15:43 +00:00
Jeff Young 07bb2729f8 Clean up over-use of auto. 2020-12-14 22:15:43 +00:00
Jeff Young 126d40f9d3 "Sheet label" too confusing w/ sheet names and fields. Use "sheet pin". 2020-12-13 22:43:09 +00:00
Jeff Young 5b22cef984 Associate -> assign in the context of footprint assignments. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6708
 2020-12-13 13:41:25 +00:00
Jon Evans 93d55e3d23 Tweak no-connect and label icons 2020-12-12 11:26:30 -05:00
Jeff Young b6e267b78d Naming conventions. 2020-12-12 03:43:41 +00:00
Michael Kavanagh cf6f0b9b92 Use trash icon where appropriate 2020-12-11 17:05:11 -08:00
Jeff Young 412c9c8c4e Save should be disabled only if the file is up-to-date. 
Any other issues (such as locked files) need to produce a dialog
with info for the user.
 2020-12-11 23:58:30 +00:00
Wayne Stambaugh e667d26854 Eeschema: use "board editor" instead of "PcbNew" in UI strings. 2020-12-11 15:24:42 -05:00
Wayne Stambaugh 4516aff43e Symbol Editor: don't show edit page number in context menu. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6711
 2020-12-11 15:02:34 -05:00
Wayne Stambaugh 5d028b82ed Eeschema: tool tip improvements. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6708
 2020-12-11 13:42:50 -05:00
Wayne Stambaugh dd4298bb94 Coverity fixes: 280374, 313611, 313648, 313649, and 314720. 2020-12-11 13:29:52 -05:00
Jeff Young 224697d0b3 Sheet navigator tooltip. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6680
 2020-12-11 16:43:55 +00:00
Jeff Young 4f90c03c7d Allow snapItem to be re-activated. 
Don't clear until another snapPoint is chosen.  This allows line
snapping to re-appear when they move back in range.

Fixes https://gitlab.com/kicad/code/kicad/issues/5973
 2020-12-05 23:57:33 +00:00
Jeff Young a3406e7514 Make snapping more predictable. 
In particular, allow grid positions to override line snapping if
they're a better match (and do this independently on x and y axes).
We already allow a nearer anchor to override, but that should be
based on a cartesian distance rather than independent axes.

Fixes https://gitlab.com/kicad/code/kicad/issues/6626
 2020-12-04 22:50:30 +00:00
jean-pierre charras c47871e775 EDA_BASE_FRAME::ShowInfoBarMsg: add option to show a close button. 
Same for EDA_BASE_FRAME::ShowInfoBarError and EDA_BASE_FRAME::ShowInfoBarWarning
 2020-12-04 14:45:14 +01:00
Peter Montgomery 821128cb8e Eeschema: Make auto-decrementing net labels stop at zero 
CHANGED: If you set the auto-increment value to a negative number,
created a net label and hit the insert key, when the name got below zero,
the net labels tried to go negative but created bad labels instead.
Now the code caps decrementing at zero,  warns users when it has
happened, and explains why.

Fixes https://gitlab.com/kicad/code/kicad/issues/6537
 2020-12-04 12:48:32 +00:00
Jeff Young e882753ebf Grid snapping fixes. 
1) Uniformly honour the GAL grid snap settings
2) Make more uniform use of GRID_HELPERs
3) Smarten EDIT_LINE for mid-point snapping

Fixes https://gitlab.com/kicad/code/kicad/issues/6558
 2020-12-03 19:55:58 +00:00
Jeff Young a19028a396 Hook up EE_GRID_HELPER to some more tools. 
Also implements EE_GRID_HELPER layers so that connectable things
snap to connectable things and graphics snap to graphics.

Fixes https://gitlab.com/kicad/code/kicad/issues/5641
 2020-12-03 15:16:34 +00:00
Jeff Young 43fe228367 Hook up a bit more of the EE_GRID_HELPER. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5985
 2020-12-02 23:18:33 +00:00
Jon Evans 05609dbc1d Update screen r-tree after mirror operation 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6549
 2020-12-01 19:19:12 -05:00
Jeff Young df262eaa06 Make prev/next marker work reliably on all platforms. 
Requires us to move from arrow-keys to our own commands (the only
way that the OSX wxWidgets impl doesn't eat the keys when the dataVIew
has focus).

While there we might as well add a command to exlucde markers.

ADDED Prev Marker, Next Marker, Exclude Marker

Fixes https://gitlab.com/kicad/code/kicad/issues/6575

Fixes https://gitlab.com/kicad/code/kicad/issues/5501
 2020-12-01 22:37:07 +00:00
Jeff Young 3c521942ed Smarten isEmpty checks to include nothing-but-whitespace. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6567
 2020-12-01 16:39:06 +00:00
Jeff Young 3ad5bce67f Rewrite connected-lines dragger to not use EDA_ITEM flags. 
We had some spurious bugs where both ends would get dragged to a
single point (making them disappear).  While I never caught it
in the debugger, I'm guessing that the flags weren't getting
cleared properly or were getting overwritten or something.  Anyway,
it now uses std::pair instead.

Fixes https://gitlab.com/kicad/code/kicad/issues/6550

Fixes https://gitlab.com/kicad/code/kicad/issues/6431
 2020-11-30 19:30:03 +00:00
Roberto Fernandez Bautista 9380d6f533 eeschema page numbers: match ordering in hierarchy navigator to sheet page number ordering 
- update hierarchy navigator after any modifications to the SCH_EDIT_FRAME
- do not generate ghost selection events after updating hierarchy tree
- use Human Readable path in SCH_EDIT_TOOL::EditPageNumber
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5760
 2020-11-30 16:49:33 +00:00
Jeff Young 3da0ab1a9a Fix a couple of bugs in intersheet references. 
1) init reference pages before trying to draw the SCH_FIELDs when
turning intersheet references on

2) don't double redraw because we accidentally cleared the last
hover item on a non-mouse-moved event.

3) make sure the root sheet gets a name for the hypertext menu.
 2020-11-29 16:53:18 +00:00
Jeff Young 13c63e3a50 Clearer warning about not back-annotating footprint deletes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6521
 2020-11-26 19:30:16 +00:00
Jeff Young c85ef8eb69 Make updating netnames in backannotate more discrete. 
Trying to be too smart was producing unexpected results.

Fixes https://gitlab.com/kicad/code/kicad/issues/6480
 2020-11-25 22:16:56 +00:00
Ian McInerney d50d728d19 Cleanup compiler warnings 2020-11-25 00:08:09 +00:00
Jeff Young 71ce00c5ce Allow rotation of a single graphic line. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6487
 2020-11-24 23:40:53 +00:00
Jeff Young 9c7c05c161 Mostly formatting cleanup but a few type-casting cleanups too. 2020-11-24 22:16:41 +00:00
Jeff Young 78b505f36a Count head and tail lists as well. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6461
 2020-11-23 23:54:54 +00:00
Wayne Stambaugh e91a5b3f81 Symbol editor: prevent derived symbol elements from being moved. 2020-11-23 15:46:03 -05:00
Jeff Young dd60fd47b2 Cleanup and formatting. 2020-11-23 01:10:08 +00:00
Jeff Young 3a4bd6fb8b Fix uninitialized variable. 2020-11-21 20:57:36 +00:00
Jeff Young 1391774f64 Re-factor boundary/courtyard checker error handling. 
ADDED Footprint Checker dialog to display the results in.

Fixes https://gitlab.com/kicad/code/kicad/issues/6446
 2020-11-21 20:57:35 +00:00
jean-pierre charras 01b6cd08b5 lib_edit_tool.cpp: fix a wxWidgets 3.0.4 compatibility. 2020-11-21 11:56:32 +01:00
jean-pierre charras 64636601b8 Eeschema: fix a Unicode/UTF8 management when pasting items from Clipboard. 
Copy to clipboard save items (using S expr description) using wide strings
(not UTF8 encoding).
But Paste from clipboard was not converting the wide string to UTF8 string
when getting the stored data to send it as std::string to the S expr reader.

Fixes #6449
https://gitlab.com/kicad/code/kicad/issues/6449
 2020-11-21 10:59:25 +01:00
Jeff Young 9e9946628a Go back to arrow cursor on a cancel (or finish). 
Fixes https://gitlab.com/kicad/code/kicad/issues/6421
 2020-11-19 20:09:28 +00:00
Jeff Young 99796d359f Honour include-in-board flag when back-annotating. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6438
 2020-11-19 15:29:53 +00:00
Jeff Young 7c344e9be6 Mirroring for intersheet references. 2020-11-18 23:34:27 +00:00
Jeff Young 293795fd46 Support rotation on intersheet references. 2020-11-18 23:34:27 +00:00
Werni 0e44f5128c Add const specifiers 2020-11-18 19:50:36 +00:00
Jeff Young cb5ec8bce1 Make Eeschema cursors update without waiting for mouse movement. 2020-11-18 17:32:40 +00:00
Jeff Young bd1f262a6b Fix issues with Intersheet Ref highlighting and hover actions. 2020-11-18 17:32:40 +00:00
Seth Hillbrand a4201ea833 Fix crash in libedit 
LIB_ITEM is not derived from SCH_ITEM but they share a selection model
 2020-11-17 14:28:56 -08:00
Jeff Young 8c5c902fa3 Re-write IntersheetRefs on top of SCH_FIELDs and textVars. 
1) Generalize SCH_ITEM owners (SCH_COMPONENT, SCH_SHEET, and now
SCH_GLOBALLABEL)
2) Generalize hypertext items
3) Use SCH_FIELD autoplace infrastructure for placing intersheet
references
4) Use textVar infrastructure for buildin intersheet references.

As an important side-effect this also fixes the undo issues with
intersheet refs.
 2020-11-17 16:05:49 +00:00
Jeff Young a207bd97bb Naming conventions. 2020-11-17 16:05:49 +00:00
Jeff Young 6e6e0aa644 Naming conventions (including some component -> symbol). 2020-11-15 20:23:15 +00:00
Jeff Young 6654c03041 Embarking on the next adventure: component -> symbol. 2020-11-15 20:23:15 +00:00
Jeff Young bdbb68f813 MODULE -> FOOTPRINT. 2020-11-13 16:04:03 +00:00
Jeff Young 63a54d003e More module -> footprint. 2020-11-13 15:16:24 +00:00
Jeff Young 522d64968e Yet more module -> footprint. 2020-11-13 15:16:24 +00:00
Jeff Young f0d0e17aab Prepare for MODULE -> FOOTPRINT. 2020-11-13 15:16:24 +00:00
Jeff Young 4889f9bb7c Fix typo in net label orientation calculation. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6333
 2020-11-09 12:07:40 +00:00
Jeff Young bfd8a62852 Formatting and naming conventions. 2020-11-07 18:50:30 +00:00
Jeff Young 91ba002da7 Make sure move machinery gets initialized if we're going to use it. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6293
 2020-11-06 12:21:31 +00:00
Wayne Stambaugh ae4614bfbd Symbol editor: do not allow paste into derived symbols. 
Don't allow select all, copy, cut, paste, or duplicate if the current
symbol is an alias.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/6050
 2020-11-04 15:00:09 -05:00
Jeff Young 88abcc1287 Fix broken handling of closing ERC dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6277
 2020-11-04 01:08:21 +00:00
Jeff Young 5507575d64 Move ERC dialog to EE_INSPECTION_TOOL and kill when resetting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6111
 2020-11-03 20:27:44 +00:00
Jeff Young 4be6a27a39 Report error when pin for backannotate can't be found. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6263
 2020-11-03 18:53:14 +00:00
Jeff Young 2a8ea25209 Null pointer safety. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6263
 2020-11-03 15:47:38 +00:00
Jeff Young bd103c133d Don't save junction colours when they're inherited. 
Also fixes Edit Text & Graphics Properties to be able to clear
colours from junctions.

Fixes https://gitlab.com/kicad/code/kicad/issues/6018
 2020-11-03 14:07:50 +00:00
Jeff Young 92d6988f10 Keep pin positions stable when resizing sheet. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6196
 2020-10-31 11:49:07 +00:00
Jeff Young bddc97df30 LibEdit -> SymbolEditor 2020-10-31 10:28:21 +00:00
Jeff Young 0d8789935d Refactoring. Push editing code to toolset. 2020-10-31 10:28:21 +00:00
Jeff Young de013ee60a Selection center is center of visible items. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6188
 2020-10-30 23:37:35 +00:00
Jeff Young 9065908859 Update SCH_SCREEN's RTree when moving items. 
Or when modifying geometric shape/properties.

Fixes https://gitlab.com/kicad/code/kicad/issues/5922
 2020-10-30 15:26:07 +00:00
Jeff Young 45618327cf Fix crash bug closing schematic with sheet selected. 2020-10-30 15:26:07 +00:00
Jeff Young 1d110d5414 Move a couple more dialogs to QuasiModal for syntax help. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5897
 2020-10-29 22:55:33 +00:00
Jeff Young c9d7bdc340 Hook up AutoplaceFields for sheets. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6197
 2020-10-28 22:32:36 +00:00
Jeff Young c5a86126d2 Be more clever about making sheet names unique. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6123
 2020-10-23 23:55:45 +01:00
Jeff Young d785dae88b DIALOG_EDIT_COMPONENT_IN_LIB -> DIALOG_LIB_SYMBOL_PROPERTIES. 2020-10-22 10:41:21 +01:00
Seth Hillbrand b39fb3374d Fix fat fingered error 2020-10-21 14:41:14 -07:00
Seth Hillbrand 69d47c90ea Unify sentences in translation 2020-10-21 12:31:21 -07:00
Jeff Young 176f461b2c Fix a corner case of wire merging. 
We want to look for a junction before merging two touching colinear
segments, but the old code would also check for a junction when
merging two overlapping segments, which is not what you want.

Fixes https://gitlab.com/kicad/code/kicad/issues/5960
 2020-10-21 18:51:47 +01:00
Seth Hillbrand f8a4edb1c9 First pass renaming module to footprint 
This is mostly in comments and the few remainin text strings that
reference module
 2020-10-20 20:49:11 -07:00
Jeff Young e5089d783d Remove multi-label entry feature. 
It was causing problems with surprising behaviour and issues with
allowing spaces in existing labels.  We'll work on something better
for 7.0....

Fixes https://gitlab.com/kicad/code/kicad/issues/6073
 2020-10-20 22:53:44 +01:00
Jeff Young 83890f8d3a Move label editors to QuasiModal so the Syntax Help window can be shown. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5437
 2020-10-20 22:26:47 +01:00
Seth Hillbrand 4085757aeb Remove beginning/ending spaces in translations 
Adding space padding makes translations more difficult by increasing
string counts
 2020-10-20 12:08:04 -07:00
Wayne Stambaugh 8ff51d8899 Eeschema: add schematic sheet page number. 
The groundwork has now been laid for per sheet instance data.  Initially
this only supports sheet page numbers but could be expanded to include
other per sheet instance information.

ADDED: Support for user defined schematic page numbers.
 2020-10-19 14:05:45 -04:00
Jeff Young 6ce803b77c Push/pop move tool even when there's nothing to move. 
This keeps other tools from having the special-case an empty move.

Fixes https://gitlab.com/kicad/code/kicad/issues/6048
 2020-10-18 12:08:15 +01:00
Jeff Young 6dfcfb0177 Rename DIALOG_EDIT_COMPONENT_IN_SCHEMATIC -> DIALOG_SYMBOL_PROPERTIES 2020-10-18 00:26:37 +01:00
Marek Roszko a2c3bdec0d Remove kicad_string.h from netlist_exporter.h 2020-10-15 18:48:53 -04:00
Jeff Young 128910c602 Pass unhandled command events from Symbol Editor move tool. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6015
 2020-10-15 18:43:23 +01:00
Ian McInerney 5f4b0eb0fb Fix formatting and overzealous renaming for FILL_TYPE 2020-10-15 11:24:49 +01:00
Marek Roszko 1538d737e7 Split out FILL_T to its own header to avoid spreading eda_item everywhere 2020-10-14 21:51:23 -04:00
Marek Roszko 5302f7ce73 Remove kicad_string.h from eda_text.h 2020-10-14 19:18:38 -04:00
Jeff Young 90da5fccbd Disambiguate backannotation (Update Schematic from PCB) from Cvpcb. 2020-10-14 21:07:10 +01:00
Marek Roszko 12d21e34e2 Remove trigo.h from eda_text.h 2020-10-13 23:37:48 -04:00
Marek Roszko b2e9f6987d Split base_struct into eda_item and eda_rect 2020-10-13 21:24:50 -04:00
Marek Roszko 2c86363aa0 Relocate the page_layout includes to a page_layout folder 2020-10-13 20:33:33 -04:00
Jon Evans d1bdfb7253 Clear selection before adding new lines in immediate mode 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4266
 2020-10-13 19:16:48 -04:00
Jeff Young fd874d8345 Check to see if isolating junction is part of the drag or not. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5960
 2020-10-13 13:52:49 +01:00
Michael Kavanagh 5f6d309d36 Eeschema: REMOVED "Update from Symbol Library" 
This is effectively duplicated by "Update Symbol(s) from Library".

Fixes https://gitlab.com/kicad/code/kicad/issues/5217
 2020-10-12 22:44:53 +00:00
Michael Kavanagh 8930e48cf3 Cleanup dead code 
Remove leftovers from e4bc1eb3bf
 2020-10-12 22:44:53 +00:00
Michael Kavanagh c40483d18a Cleanup: Move KiCad files into plugins folder 2020-10-12 16:36:08 +00:00
Jeff Young 0efe073dec Add wires between selected wires and unselected junctions when dragging. 
Also fixes a bug where the auto-start-wire stuff was messing up the seleciton
when the selection tool wasn't at the top of the tool stack.

Fixes https://gitlab.com/kicad/code/kicad/issues/5960
 2020-10-12 11:46:08 +01:00
Marek Roszko 03074ae6ed Kick the selection tool to activate (and thus update cursors) on exiting some picker tools 2020-10-11 13:12:29 -04:00
PJM 91db6a770c Eeschema: Add missing tooltips to left toolbar buttons 
CHANGED: The button in the left toolbar for hiding/showing hidden
pins, and the button for forcing/relaxing H&V only wire mode had
no tooltips.  This MR adds them.
 2020-10-11 13:55:36 +00:00
Marek Roszko 558f4b4b51 Add new place cursor, fix cursor hotpoints again 2020-10-10 23:45:21 -04:00
Marek Roszko 310786333d Add missing cursors for bus, graphic lines, and hier labels 
Fix #5949
 2020-10-10 18:25:44 -04:00
Ian McInerney 5aa796b5fe Cleanup compiler warnings 2020-10-10 15:24:35 +01:00
Franck Jullien fc93a04751 eeschema: iref: use GetParentLabel instead of GetParent 2020-10-09 02:37:51 +00:00
Marek Roszko bd30a4a406 Add selection lasso and window cursors 2020-10-08 21:25:21 -04:00
Marek Roszko f238d05ead Add COMPONENT cursor 2020-10-08 20:52:58 -04:00
Marek Roszko 6cf4016a64 Add net and global label cursors 2020-10-08 20:52:58 -04:00
Jeff Young fd22fe8e37 Show preview item in drawing tool before mouse is moved. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5922
 2020-10-08 19:56:09 +01:00
Jeff Young 4095edda07 Add Properties support to Junction and Bus Entry tools. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5907
 2020-10-08 18:11:06 +01:00
Ian McInerney 2b839c6c9c Ensure command events are passed when placing junctions 
We only handle specific command events in the handler, so we
must pass the rest to allow other tools to work.

Fixes https://gitlab.com/kicad/code/kicad/issues/5922
 2020-10-08 17:58:06 +01:00
Marek Roszko 7e974e5ccc Use the snapped cursor position used for detection for the wire tool autostart 
Fixes #5902
 2020-10-07 23:57:26 -04:00
Marek Roszko f5e0754f65 Use the setCursor lambda pattern and fix up the initial cursor states 2020-10-07 23:26:14 -04:00
Mark Roszko d9485129c8 Implement more context specific cursors using both stock and custom cursors. 2020-10-08 00:50:28 +00:00
Jeff Young 809f4c2ffb Finish single-click-place drawing tool on double-click. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5907
 2020-10-07 18:30:55 +01:00
Jeff Young 4565631728 Finish moving eeschema assigned netclasses to sheet-path-relative. 
Also adds code for the case where a new label is created on a net
with an existing netclass assignment.

Fixes https://gitlab.com/kicad/code/kicad/issues/5886
 2020-10-07 16:31:55 +01:00
Jeff Young 63a0f537d8 Performance enhancement: check hierarchy validity only when necessary. 2020-10-05 13:49:29 +01:00
Jeff Young c9096c7168 Re-enable selection of intersheet references. 
Un-modified roll-overs and clicks still produce hypertext action, but
modified clicks and drag-selects will select.
 2020-10-05 11:55:33 +01:00
Jeff Young 44580acee2 Clean up some compiler warnings. 2020-10-03 22:55:34 +01:00
Marek Roszko 676f3221cc Fix symbol editor glitches due to autostart trying to start 2020-10-03 15:47:08 -04:00
Marek Roszko 0b2b8b150d Use the event position always instead of the view cursor position 
Fix #5850
 2020-10-03 15:20:32 -04:00
jean-pierre charras bda275de46 more cleanup about removing useless include 2020-10-03 11:48:16 +02:00
Marek Roszko b0ffbcaba1 Fix #5850 2020-10-03 02:10:56 +00:00
Jeff Young cc617b715f Implement hypertext links for intersheet references. 2020-10-02 21:18:34 +01:00
Jeff Young c1b34b02b5 Disallow selection of intersheet references. 2020-10-02 13:50:16 +01:00
Mark Roszko c940a45937 ADDED: Autostart wires in eeschema 
Allows wires to be automatically started by clicking over a connection point
 2020-10-01 23:53:47 +00:00
Jon Evans 71ed7ee707 Revert "Drag preselected items even when "prefer selection to dragging" enabled" 
This reverts commit d530e2c2cd.
 2020-10-01 18:23:30 -04:00
Franck Jullien 2fc49045d1 ADDED: eeschema: Add intersheets references function 
Add a new function to place intersheets references next to
global labels.
 2020-10-01 20:39:32 +00:00
Jon Evans d530e2c2cd Drag preselected items even when "prefer selection to dragging" enabled 
Not being able to drag an already-selected item feels broken
 2020-09-30 20:10:13 -07:00
PJM b0e05ad9bf Eeschema: Check for NULL pointer when using interactive delete tool 
CHANGED: If you start the interactive delete tool and the mouse pointer
isn't near anything, Eeschema tries to use a null EDA_ITEM pointer
which throws an exception.  This commit checks if the pointer is null
and exits if it is.
 2020-09-30 23:05:29 +00:00
Ian McInerney 2c49c406a0 Remove ignore other projects option from back annotation 
The new schematic format makes this option unneeded, and it isn't
used at all in the backannotation code - so it doesn't need to be
in the UI.
 2020-09-30 23:34:04 +01:00
Jeff Young e4bc1eb3bf Fold Update Fields from Library into Update Symbol. 
Also gives Change Symbol control over which fields to update.

Fixes https://gitlab.com/kicad/code/kicad/issues/5217
 2020-09-27 14:09:11 +01:00
PJM e77b7e3360 Make MMB double click perform 'Zoom to Fit' 
ADDED: Make middle mouse button double click do a 'Zoom to Fit'
in Eeschema, Pcbnew, and Gerbview.  Ctrl-MMB does a 'Zoom to Objects'
in Eeschema.

Fixes https://gitlab.com/kicad/code/kicad/issues/1988
 2020-09-22 23:21:44 +00:00