8177e3c723
hosted/remote_jtagtap: Refactored jtagtap_cycle and cleaned up
2022-07-30 16:26:04 -07:00
088eb6f01b
hosted/remote_jtagtap: Refactored jtagtap_next and cleaned up
2022-07-30 16:26:04 -07:00
7b5121c970
hosted/remote_jtagtap: reformatted with clang-format
2022-07-30 16:26:04 -07:00
f02304dfdb
hosted/remote_jtagtap: Implemented support for jtagtap_cycle
2022-07-30 16:26:04 -07:00
2bfd84d1b2
remote: Implemented support for using the new jtagtap_cycle call
2022-07-30 16:26:04 -07:00
1b39173780
remote: Fixed several clang-tidy warnings caused by bad (reserved) function naming
2022-07-30 16:26:04 -07:00
deadf9a78d
jtagtap: Implemented jtagtap_cycle for running extra clock cycles on the bus when needed
2022-07-30 16:26:04 -07:00
5e9a974c42
Fixed compatibility issues with CH32F1 target driver and other STM32F103 clones.
2022-07-30 09:57:28 +01:00
84ffdd3b21
fix: Add nop instruction for timing purpose
...
Adding a nop instruction in the no_delay TMS sequence routine fixes timing on the f4discovery platform
2022-07-30 02:49:56 +01:00
4d64edad7a
fix: Use standard macros for debug message formating
2022-07-29 21:22:17 +01:00
57fec4d0b6
adiv5: Cleaned up a couple of the debug prints
2022-07-29 21:22:17 +01:00
7c14b62419
target: fix probing for lpc1343
2022-07-26 05:14:30 +01:00
bf30580330
target/adiv5: add missing include in hosted build
...
Signed-off-by: Rafael Silva <perigoso@riseup.net>
2022-07-26 05:08:10 +01:00
8b5206fb8d
target: add weak aliasing to allow disabling targets
...
Signed-off-by: Rafael Silva <perigoso@riseup.net>
2022-07-26 05:08:10 +01:00
6f81cb6a68
adiv5: Removed an extraneous pair of perens as they suppress desirable warnings
2022-07-25 18:28:57 +01:00
3592658a26
adiv5: Cleaned up the loop in adiv5_ap_read_id
2022-07-25 18:28:57 +01:00
bb3e74062e
adiv5: Fixed the naming of a timeout in cortexm_prepare
2022-07-25 18:28:57 +01:00
013b2dee60
target/adiv5: further cleanup
2022-07-25 18:28:57 +01:00
0942d7047a
target/adiv5: saner designer code handling and cleanup
...
Signed-off-by: Rafael Silva <rafaelsilva@ajtec.pt>
2022-07-25 18:28:57 +01:00
ce3d80528e
command: clarify hex format
...
Signed-off-by: Rafael Silva <perigoso@riseup.net>
2022-07-25 18:28:57 +01:00
d1fa50336e
target/adiv5: clang format/tidy
2022-07-25 18:28:57 +01:00
37efd257e8
gdb_main: Fixed a small DEBUG_GDB regression for vFlashErase and vFlashWrite debugging
2022-07-20 23:03:31 -07:00
e2f07b359a
gdb_main: Implemented a notification to GDB that the "process" has exited when the user runs a new bus scan while attached to a target
2022-07-20 21:37:16 -07:00
c0b5f89148
gdb_packet: Implement notification packets
2022-07-20 21:37:16 -07:00
5ae5ffb7c3
gdb_main: Add some output in the scan commands to indicate when still attached that you aren't after the command, despite what GDB thinks
2022-07-20 21:37:16 -07:00
b47ee11537
gdb_main: Implemented qfThreadInfo and qsThreadInfo for GDB 11+
2022-07-20 21:37:16 -07:00
4ba77a60ca
gdb_main: Implemented vKill as it's required for GDB 11+
2022-07-20 21:37:16 -07:00
2378e8614e
gdb_main: Cleaned up the naming in the 'g' and 'G' packet handlers
2022-07-20 21:37:16 -07:00
bc5cca7a8b
hex_utils: Cleaned up and fixed the type confusion that was going on
2022-07-20 21:37:16 -07:00
adff7651b6
gdb_main: Reply to vAttach with TID 1 because GDB 11 and 12 are terminally broken otherwise
2022-07-20 21:37:16 -07:00
0c8ebc693d
gdb_main: Implemented support for qC queries
2022-07-20 21:37:16 -07:00
00c09b4156
gdb_main: More type confusion fixes and cleanup
2022-07-20 21:37:16 -07:00
75d7dd32d1
gdb_main: Implemented H[m|M|g|G|c] packet support
2022-07-20 21:37:16 -07:00
f448368d39
gdb_packet: Done a spring pass on the types situation and cleaned things up
2022-07-20 21:37:16 -07:00
a83e024eea
general: check _DEFAULT_SOURCE and _GNU_SOURCE
...
The _DEFAULT_SOURCE and _GNU_SOURCE defines must exist in order to
enable certian glibc features. Therefore, it is common to define these
either in header files or on the command line.
Some platforms define these in their system headers. For example,
ESP-IDF defines this in their `features.h` file. This results in
a clash when blackmagic is compiled.
Check that these defines do not already exist prior to defining them.
Signed-off-by: Sean Cross <sean@xobs.io>
2022-07-20 05:18:42 +01:00
c530bd077b
misc: Switched to using C11
2022-07-18 20:59:15 -07:00
52e5357e99
swdptap: Refactored swdptap_seq_out_parity and cleaned up
2022-07-18 18:57:10 -07:00
da1038313f
swdptap: Refactored swdptap_seq_out and cleaned up
2022-07-18 18:57:10 -07:00
29baa2725c
swdptap: Further cleanup to the seq_in functions
2022-07-18 18:57:10 -07:00
caaf7837a5
swdptap: Made the cycle code a little easier to reason about
...
This doesn't actually change the resulting binary size, so worth doing
2022-07-18 18:57:10 -07:00
c267327975
swdptap: Refactored swdptap_seq_in_parity and cleaned up
2022-07-18 18:57:10 -07:00
6f0bdf5f32
swdptap: Refactored swdptap_seq_in and cleaned up
2022-07-18 18:57:10 -07:00
92c7a11cd2
swdptap: Cleaned up swdptap_turnaround
2022-07-18 18:57:10 -07:00
10d30821e5
swdptap: Cleaned up the naming and and signatures of the SWDP implementation functions
2022-07-18 18:57:10 -07:00
1a362db5ab
hosted/cmsis_dap: Naming cleanup
2022-07-18 18:57:10 -07:00
a8c2082adf
jtagtap: Const-correctness
2022-07-18 18:57:10 -07:00
9a21ef043f
hosted/ftdi_bmp: Cleaned up and fixed the signature for libftdi_buffer_write
2022-07-18 18:57:10 -07:00
d1c24b4fec
jtagtap: Cleaned up and fixed the signatures for the JTAG TAP implementation functions
2022-07-18 18:57:10 -07:00
46958ba404
dap: Cleaned up the naming and signature of the JTAG TAP DAP functions
2022-07-18 18:57:10 -07:00
96cdd17974
remote: Cleaned up the REMOTE_NEXT state
2022-07-18 18:57:10 -07:00
bdae0b2ded
jtagtap: Refactored jtagtap_tdi_seq, cleaning up and fixing naming
2022-07-18 18:57:10 -07:00
131165701c
jtagtap: Fixed more of the naming for parameters to the JTAG TAP functions
2022-07-18 18:57:10 -07:00
124b3c79d7
jtagtap: Refactored jtagtap_tdi_tdo_seq and cleaned up
2022-07-18 18:57:10 -07:00
1671b97f61
jtagtap: Reworked jtagtap_tms_seq(), saving 8 bytes and simplifying things
2022-07-18 18:57:10 -07:00
303fa15171
jtagtap: Reformatted and begun cleaning up the JTAG TAP primitives implementation
2022-07-18 18:57:10 -07:00
a6f2b52d9b
jtagtap: Reformatted and cleaned up in the header
2022-07-18 18:57:10 -07:00
7b1c4a5565
hosted/cli: Remove the `-d`/`--device` deprecation warning
...
This option is still useful to many users and there isn't a particular reason for it to be marked deprecated
2022-07-18 17:13:52 -07:00
85d24e8289
target: Implemented a command to allow erasing Flash ranges on any target
2022-07-18 17:12:13 -07:00
52cad38fac
hosted/dap: Cleaned up some of the link reset pointer maths
2022-07-18 17:10:23 -07:00
8e8ad7dbd4
hosted/cmsis_dap: Removed one-bit SWD read while SWIO is undriven + pulled up which can cause issues with certain CMSIS-DAP adaptors
...
Many thanks to @mubes for finding this and suggesting a fix
2022-07-18 17:10:23 -07:00
1b8e522e87
nrf51: Add command to enable flash protection
...
Add braces for the while loop
2022-07-15 16:57:52 +01:00
6ae846ae24
target/nrf51: Add command to enable flash protection
...
Add command `mon protect_flash` to enable flash read/write protection
2022-07-15 16:57:52 +01:00
e19c2a7298
BMDA: Make the pkg-config checks work on older gnu make versions.
...
The .SHELLSTATUS variable was added in GNU Make 4.2. Mac OS for example
ships with 3.81.
2022-07-15 12:40:09 +01:00
d0c45cf095
BMDA: Using tabs outside of a target indent causes issues.
...
It is safer to only use spaces to indent make statements outside of
targets as each line that executes any shell code will fail if it is
indented with tabs.
2022-07-15 12:40:09 +01:00
a3d3a2326f
Add include path so that libusb headers found on OSX.
2022-07-15 02:19:03 +01:00
94b62ff924
target: Fixed several clang-tidy warnings which improve readability of the code
2022-07-14 16:19:43 -07:00
bdf4dc8731
nrf51: Fixed mass erase after run then user interrupt (Ctrl + C) not working
2022-07-14 14:19:14 -07:00
5607eac812
cortexm: Cleaned up formatting, types and const-correctness in cortexm_attach
2022-07-14 14:19:14 -07:00
069f05ea4b
target/efm32: stop hiding data in driver string
...
Signed-off-by: Rafael Silva <perigoso@riseup.net>
2022-07-14 13:11:19 +01:00
096927b0b8
target/efm32: bootloader lock word handling fix
...
Signed-off-by: Rafael Silva <perigoso@riseup.net>
2022-07-14 13:11:19 +01:00
c2589bc39f
target/efm32: mass erase correctness
...
Signed-off-by: Rafael Silva <perigoso@riseup.net>
2022-07-14 13:11:19 +01:00
00dd7f145f
target/efm32: code cleanup
...
Signed-off-by: Rafael Silva <perigoso@riseup.net>
2022-07-14 13:11:19 +01:00
42d36d9d10
target/efm32: general formatting/style cleanup
...
Signed-off-by: Rafael Silva <perigoso@riseup.net>
2022-07-14 13:11:19 +01:00
018fc517a1
stm32f4: Fixes erase_mass command return error.
...
The final erase_mass command check is looking for the EOP (End of
OPeration) bit to be set. This bit is only set when the EOP interrupts
(EOPIE = 1) are enabled. We are not enabling those on the target so this
bit will never get set. As we are monitoring the BSY flag to make sure
the erase_mass operation is still ongoing and finished it is enough if
we just check the error flags.
2022-07-13 20:57:09 -07:00
ae81d1635f
hosted/cmsis_dap: Enhanced the hid_open failure output on Linux to help users narrow down the issue faster
2022-07-13 19:37:35 -07:00
0d2fb6ab79
hosted/cmsis_dap: Broken up the dap_init function into multiple parts so they're easier to understand
2022-07-13 19:37:35 -07:00
ec5ac64bdc
hosted/cmsis_dap: Done a first pass at rewriting the HID serial number logic to be unicode-safe
2022-07-13 19:37:35 -07:00
50ff4a2dbe
hosted/dap: Fixed the definiiton of dap_info, adding const-correctness
2022-07-13 19:37:35 -07:00
2f9d280e2a
hosted/dap: Cleanup and named all the enums defined in dap.h
2022-07-13 19:37:35 -07:00
1765d2afbc
hosted/dap: Reformatted the header with clang-format
2022-07-13 19:37:35 -07:00
83191bb87d
hosted: Made ASAN globally available, not only on Linux.
2022-07-13 19:37:35 -07:00
4bea5cfe81
hosted/cmsis_dap: Added a call to hid_error() when hid_open fails
2022-07-13 19:37:35 -07:00
000b05e1eb
hosted: Updated the build system documentation
2022-07-13 19:37:35 -07:00
a43fe4f5bf
hosted: Reformatted Makefile.inc to make it easier to read
2022-07-13 19:37:35 -07:00
a0b20bba84
hosted: Fixed the ASAN build configuration as it's wrong when using Clang as the compiler
2022-07-13 19:37:35 -07:00
4e50b22775
hosted: Removed the custom HIDAPI implementation for windows
...
The HIDAPI library provides a perfectly cogent implementation that includes statically linkable objects.
Their implementation is more correct and more up to date than this, so use it.
2022-07-13 19:37:35 -07:00
6d7c6c5daf
lmi: Added progress dots for mass erase to stop GDB timing out
2022-07-13 19:34:57 -07:00
d64992ade8
rp: Cleanup in how we define some of the Flash constants
2022-07-13 19:34:57 -07:00
ce94169099
stm32l0: Added some links to the reference manuals
2022-07-13 19:34:57 -07:00
a22d6e5056
stm32l0: Run clang-format across the code
2022-07-13 19:34:57 -07:00
b84f883aeb
lmi: Implemented mass erase
2022-07-13 19:34:57 -07:00
90b7362162
stm32l4: Switched to the unified mass erase command and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
787d66fe95
stm32h7: Switched to the unified mass erase command, breaking up the implementation cleanly and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
980a1f140c
stm32g0: Switched to the unified mass erase command, breaking out the bank erase command and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
d82ad89715
stm32f4: Switched to the unified mass erase command and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
2f0d35de19
samx5x: Bracket and GDB message cleanup
2022-07-13 19:34:57 -07:00
591f05d7e5
samd: Cleanup and fixed a notification TODO
2022-07-13 19:34:57 -07:00
94d5c0576b
samd/samx5x: Switched to the unified mass erase command and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
e9b75ba4bc
rp: Switched to the unified mass erase command and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
ffd358824f
nrf51: Switched to the unified mass erase command for the recovery target and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
57d8e8f5d9
nrf51: braces cleanup in nrf51_flash_erase
2022-07-13 19:34:57 -07:00
ee694fcb75
nrf51: Switched to the unified mass erase command and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
8130b62bcf
lpc546xx: Switched to the unified mass erase command for the recovery target and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
9af2d2a413
lpc: Clean up part of the lpc_iap_call command wait loop
2022-07-13 19:34:57 -07:00
56ecbb3b89
lpc43xx: Switched to the unified mass erase command and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
6f57cdf6ba
lpc17xx: Switched to the unified mass erase command and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
ae1cb56ce0
kinetis: Switched to the unified mass erase command for the recovery target and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
9d46d0c5c6
target: Refactored out the progress printer to reduce Flash usage
2022-07-13 19:34:57 -07:00
b8ca831cfb
efm32: Switched to the unified mass erase command for the recovery target and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
c1758088cd
efm32: Switched to the unified mass erase command and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
17c04d585e
stm32f1: Switched to the unified mass erase command and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
c2d72b4825
kinetis: Switched to the unified mass erase command and added progress dots to stop GDB timing out
2022-07-13 19:34:57 -07:00
c35f65c6c0
target: Implemented a global target mass erase command
2022-07-13 19:34:57 -07:00
30e2106e40
target: Make the buffers used to program a target's Flash better bounded in lifetime and memory usage
2022-07-13 19:08:31 -07:00
3e9913e88b
Implement semihosting debug output redirection to usb-uart port.
2022-07-13 18:49:20 -07:00
c7b54d2eaa
BMP V2.3: Fix outdated ADC reads.
...
We are using GD32F103 on the BMP V2.3 hardware. The GD32F103 has an
errata for the ADC where the end of conversion (EOC) bit is not reset
when reading the ADC result. This resulted in us not waiting for the new
value to be acquired and reading an old value instead. The solution for
that is resetting the EOC bit manually after reading the ADC result, so
that on the next acquisision we wait for the conversion to finish.
This patch also increases the sampling time as the GD32 have lower ADC
impedance than the STM32 and this should help us read a more accuarate
target voltage.
2022-07-14 01:54:43 +01:00
4bc68409f8
kinetis: Clean up how kl_gen_flash_done builds the command buffers to send to ensure the security byte is OK
2022-07-11 17:12:23 -07:00
f0566979b0
kinetis: Fixed the flash write command generation for K64 devices
2022-07-11 17:12:23 -07:00
6f273cadd8
kinetis: Try to be safer about our FCCOB writes so the Flash controller's less likely to get mad
2022-07-11 17:12:23 -07:00
0c18fcefe3
kinetis: macro organization and clearer function naming
...
Signed-off-by: Rafael Silva <perigoso@riseup.net>
2022-07-09 15:55:37 -07:00
18a49ac853
kinetis: Run clang-format on the code
2022-07-09 15:45:06 -07:00
72e4f4d2b2
kinetis: Refactored out some common code from kinetis_probe for the S32K14 lineup
2022-07-09 15:45:06 -07:00
fee6f28915
kinetis: General formatting and readability cleanup
2022-07-09 15:45:06 -07:00
9b8d2fb822
stlink: Added documentation about the new SWIM_AS_UART build option
2022-07-03 18:05:02 -07:00
a95e2e80bc
stlink: Add option to turn SWIM/RST into UART RX/TX
...
Building for `stlink` with `SWIM_AS_UART=1` now enables the use of the
SWIM and RST ports as RX and TX on cheap ST-Link V2 clones.
This is done by using USART1 on the alternative port instead of USART2.
2022-07-03 18:05:02 -07:00
c26115b3f7
blackpillv2: clarify how to exit bootloader mode
...
There is no need to press any other "key" other than NRST button. So
update documentation according to that.
2022-07-01 06:56:57 -04:00
86a12ddaaa
blackpillv2: clarify how to enter to bootloader mode
...
According to [1] all PCB revisions have BOOT0 and NRST labels near
buttons. Reference those in README for ease of use.
PB2/BOOT1 has a 10k pull-down on PCB (in all revisions, according to
[1]), so there is no need to do anything on the board (like "jumpering
to GND") unless the board was modified by user. Hence don't reference
PB2/BOOT1 in the README, as it was just confusing to the user.
[1] https://github.com/WeActTC/MiniSTM32F4x1/tree/master/HDK
2022-07-01 06:56:57 -04:00
61c2724c9d
blackpillv2: fix PROBE_HOST in Readme.md
...
After renaming directory with s/blackpill/blackpillv2/, Readme.md still
contained the old 'blackpill' name in PROBE_HOST. Fix that by replacing
it with 'blackpillv2'.
Fixes: 3ccb0af21c
2022-07-01 06:01:06 -04:00
780ee7a2a8
Fix build error and logic ...
2022-06-28 06:31:16 -04:00
d78f7696cc
stm32/serialno: Run clang-format on the serial number code
2022-06-27 23:11:42 -07:00
fef40b701f
stm32/serialno: Fixed a typo in the 24 character serial number loop
...
before: 0670FF530000000000000000
after: 0670FF535567494867085055
2022-06-27 23:11:42 -07:00
d140b4b667
stlink: Fix the LED pinout on the Nucleo boards
2022-06-27 23:09:56 -07:00
1a963b81f6
target/stm32f1: GD32E230 option write special case handling
...
Signed-off-by: Rafael Silva <perigoso@riseup.net>
2022-06-27 18:13:52 -04:00
e7a7d82b33
target/stm32f1: remove unused code snippet and superfluous preprocessor check, less pedantic wording on warning
...
Signed-off-by: Rafael Silva <perigoso@riseup.net>
2022-06-27 18:13:52 -04:00
a5ebff14bb
target/stm32f1: remove redundant grouping ad for loop cleanup
...
Signed-off-by: Rafael Silva <perigoso@riseup.net>
2022-06-27 18:13:52 -04:00
90ed4fe31a
target/stm32f1: clang-format and code styling for better readability
...
Signed-off-by: Rafael Silva <perigoso@riseup.net>
2022-06-27 18:13:52 -04:00
5666fa2a2f
target/sam3x: add aditional check for valid EEFC addr
...
Signed-off-by: Rafael Silva <rafaelsilva@ajtec.pt>
2022-06-27 07:48:54 -04:00
1bca0323d9
target/sam3x: saner uninitialized variable prevention
...
Signed-off-by: Rafael Silva <perigoso@riseup.net>
2022-06-27 07:48:54 -04:00
3a02fdea9d
misc: Added a clang-tidy Makefile target so enforcing the formatting is easier
2022-06-26 18:55:04 -07:00
730a795f09
Add idcode for GD32F303CG detection
2022-06-26 21:00:26 -04:00
09f64b0627
misc: Added a HACKING.md to provide an explanation of nomenclature and how we handle reset terminology
2022-06-26 16:51:58 -07:00
c33d02bc19
hosted/stlink: Improved the information output and its consistency
2022-06-26 16:51:58 -07:00
aa9c80b37d
misc: Formatting consistency
2022-06-26 16:51:58 -07:00
2765811bbb
hosted/stlink: Naming consistency for 'stlink' global object
2022-06-26 16:51:58 -07:00
66b2d0659a
hosted: type naming consistency
2022-06-26 16:51:58 -07:00
baf84c9eb4
launchpad-icdi: Cleaned up and fixed some C89-isms
2022-06-26 16:51:58 -07:00
0139a349ab
hosted/FTDI: Cleaned up the error handling so the compiler can usefully tell us of errors in conditions
...
This also fixes an accidental assignment bug in libfti_max_frequency_set()
2022-06-26 16:51:58 -07:00
826840bf90
hosted/remote: Cleaned up the error handling so the compiler can usefully tell us of errors in conditions
2022-06-26 16:51:58 -07:00
fbe804f905
hosted/ftdi: Updated the 'cables' definitions
2022-06-26 16:51:58 -07:00
5ec848e948
hosted/jlink: Fixed use of 'int' where 'size_t' is more appropriate
2022-06-26 16:51:58 -07:00
dragonmux
grumat
ylm
Rafael Silva
Sean Cross
Giovanni Santana
Piotr Esden-Tempski
Jonathan Giles
Anti Sullin
Silke Hofstra
Marcin Niestroj
Manoel Brunnen