haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
28,507 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

12215 Commits

Author SHA1 Message Date
Jon Evans d8499e4914 I fixed the wrong typo in 6e272429, heh 2021-06-03 22:39:14 -04:00
Jon Evans 6e2724294a Fix typo in action description 2021-06-03 21:27:28 -04:00
Ian McInerney 0c879eead3 Cleanup headers in pcbnew pcad importer 2021-06-04 01:28:40 +01:00
Ian McInerney f94816fbd4 Cleanup wx includes in the filter reader 2021-06-04 01:26:58 +01:00
Seth Hillbrand 3d4ce0796e Add Gerber plot for SHAPE_ARC and SHAPE_LINE_CHAIN 2021-06-03 17:12:56 -07:00
Jeff Young 00791e1e37 Fix compile issues on clangd. 2021-06-03 23:41:06 +01:00
Marek Roszko 1c1ba25ffd Use char_str instead of c_str in previous commit 2021-06-03 18:13:35 -04:00
Marek Roszko daf510344f Fix build error due to pns changes 2021-06-03 18:05:48 -04:00
Marek Roszko 4e94b1fe86 Remove the universal sockets include 2021-06-03 17:59:46 -04:00
Jeff Young 6f5cb1f97d Fix printing of hidden refs and/or values. 
IsLayerVisible() is patched to always return true when printing
(even when "print according to appearance settings" is checked, and
that's too risky to change at this point.  So we also look to see
if the layer colour is set to the background colour.

Fixes https://gitlab.com/kicad/code/kicad/issues/8548
 2021-06-03 22:44:04 +01:00
Tomasz Wlostowski 63fc7a1908 router: support for drag/walkaround/shove for joints between lines of different widths. 
fixes: https://gitlab.com/kicad/code/kicad/-/issues/1773
 2021-06-03 22:44:53 +02:00
Tomasz Wlostowski af26eab5fb router: even more debug in SHOVE 2021-06-03 22:44:53 +02:00
Tomasz Wlostowski a744857267 router: fix array out-of-bound error in HullIntersection() 
fixes: https://gitlab.com/kicad/code/kicad/-/issues/8538
 2021-06-03 22:44:53 +02:00
Tomasz Wlostowski 3e98c44636 router: LOGGER now stores UUIDs, not pointers to BOARD_ITEMs. 
Caused occasional crashes when saving the debug event log, as some of the BOARD_ITEMS could have been deleted before SaveLog call.
 2021-06-03 22:44:53 +02:00
Tomasz Wlostowski e5e588ebba router: temporarily export LINE::Walkaround() debug global variables 2021-06-03 22:44:53 +02:00
Tomasz Wlostowski 70ed5c1ae8 router: introduce concept of 'virtual' vias as a base for shoving/dragging joints of lines of different widths. 2021-06-03 22:44:53 +02:00
Ian McInerney 4f05262705 Cleanup includes in board.h and footprint.h 2021-06-03 20:19:52 +01:00
Ian McInerney 23f8851409 Remove pcb_group include from board header 2021-06-03 20:03:31 +01:00
Ian McInerney 7bbf1b07b7 Fixup to expose PCB_GROUP in Python 2021-06-03 20:00:45 +01:00
Jean-Samuel Reynaud e2e963d14a Adding PCB_GROUP to python interface 2021-06-03 18:55:46 +00:00
Jeff Young 49d65a0765 Fix some includes. 2021-06-03 18:33:59 +01:00
Wayne Stambaugh 7c14e4e967 Common widget header housekeeping. 2021-06-03 12:02:45 -04:00
Seth Hillbrand f40f696c37 Don't extract dp segment info from minimal-length 
segments with 1IU of length are approximately parallel to everything and
the distance projections break down into rounding errors

Fixes https://gitlab.com/kicad/code/kicad/issues/8541
 2021-06-03 08:44:17 -07:00
Marek Roszko 4df3cb912d Remove another leaky wx/log.h header 2021-06-03 08:11:15 -04:00
Marek Roszko 7faee5eda5 Stop salt the eart with wxhtml.h 2021-06-03 07:49:49 -04:00
Ian McInerney d79dd39be3 Remove redundant headers 2021-06-03 02:19:36 +01:00
Ian McInerney 3ab69939f9 Remove wx.h from many files 2021-06-03 02:19:20 +01:00
Marek Roszko af2707929d Don't leak a wx header via eda_item.h 
Turns out this provided the translation header globally :D
 2021-06-02 19:18:48 -04:00
Ian McInerney 9a07b03b4c Replace boost::function with std::function 2021-06-02 18:39:43 +01:00
Seth Hillbrand 7f56ff4d42 Minor performance improvement 
Don't keep searching the DRC RTree for collisions after we detect a true
(not clearance-based) collision
 2021-06-02 08:15:37 -07:00
Jeff Young 00ed75b891 Fix DRC performance with multi-layer keepout zones. 
The main issue was a parameter mismatch which caused On^2 behaviour
for zone layers.

But there are several other performance optimizations here, along
with status bar updating for zones while running the dissallow test.

Fixes https://gitlab.com/kicad/code/kicad/issues/8521
 2021-06-02 14:11:43 +01:00
Marek Roszko eeb405c196 Cleanup some more excess math/util includes 2021-06-02 00:50:46 -04:00
Marek Roszko cf2bb5692a Remove the wxLog calls from math/util.h for now 
This was leaking windows headers and partial wx headers to 1084 compilation units......
This also means math/util.h is leaking to 1084 compilation units which seems a bit high too.
 2021-06-01 18:44:22 -04:00
Marek Roszko cfa2b57c68 Use logical OR to quiet static analyzer (no functional change) 2021-06-01 18:44:22 -04:00
Marek Roszko 65fee5b2ec Clear m_out pointer at end of save 2021-06-01 18:44:22 -04:00
Jeff Young d12e5d824e Renaming for clarity and a performance improvement in corner rounding. 2021-06-01 23:11:54 +01:00
Seth Hillbrand 208dd5cbd5 Cleanup string handling in fabmaster import 
Avoids round-tripping std::string->c_str->std::string and makes a few
auto references explicit
 2021-06-01 13:54:34 -07:00
Seth Hillbrand 63cc7d16b4 Repair board on open 
We need to ensure that boards do not have duplicated KIIDs, so we repair
the duplicates when opening an existing file.  This does not change the
file on disk until saved
 2021-06-01 13:39:59 -07:00
Seth Hillbrand e050d42658 Re-enable KICAD_SCRIPTING_WXPYTHON 
This keeps wxpython behind a build flag for platforms (mingw) that do
not yet support it.
 2021-06-01 20:18:24 +00:00
Seth Hillbrand 68a5d5dc01 Fix issue reloading plugins 2021-06-01 20:18:24 +00:00
Seth Hillbrand bbcc840989 Cleanup rebase fns 2021-06-01 20:18:24 +00:00
Seth Hillbrand 88e4b7f7c4 Update Python Helpers 2021-06-01 20:18:24 +00:00
Seth Hillbrand adf885b667 Move pcbnew swig 
Separates the python scripts into those using swig and those needed for
other scripting
 2021-06-01 20:18:24 +00:00
Seth Hillbrand bf1437899e Add Python Tool to pcbnew 2021-06-01 20:18:24 +00:00
Seth Hillbrand c7d188a8d0 Centralizing SCRIPTING class 2021-06-01 20:18:24 +00:00
Seth Hillbrand 192fbfd5e5 Finalize Python Frame 2021-06-01 20:18:24 +00:00
Seth Hillbrand 81d58bcea9 Working python window 2021-06-01 20:18:24 +00:00
Seth Hillbrand 6fbbba8db3 Adding Python shell KIFACE 2021-06-01 20:18:24 +00:00
Seth Hillbrand f274a00c08 Remove PYTHON_* compile options 2021-06-01 20:18:24 +00:00
Jon Evans 247da631f9 Revert "Fix typo and clean up leftover tracks" 
This reverts commit ed66c0f14d.

Revert "Clean up co-linear tracks after finishing routing"

This reverts commit 1a102f03c0.

More complex solution needed

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8526
 2021-06-01 11:18:00 -04:00
jean-pierre charras d7616fdca8 Fix a few compil or coverity warnings. 2021-06-01 09:04:37 +02:00
Jon Evans ed66c0f14d Fix typo and clean up leftover tracks 2021-05-31 22:42:56 -04:00
Jon Evans 1a102f03c0 Clean up co-linear tracks after finishing routing 
This involved adding some extra infrastructure to be able
to handle the case where a track that is sitting in the
router's commit waiting to be added to the board actually
needs to be deleted instead.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8419
 2021-05-31 17:36:38 -04:00
Jon Evans 6381ffd10a Fix diff pair coupling test when gap constraint is in a different rule 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8519
 2021-05-31 10:13:05 -04:00
Jeff Young c4cabb38d5 More worksheet -> drawing sheet cleanup. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8516
 2021-05-31 12:26:44 +01:00
Jeff Young 0598c82972 Terminology (use present tense for flags). 2021-05-31 12:26:44 +01:00
Marek Roszko 1b94534451 Revert "Use lambdas to fix paste conditions" 
This reverts commit 65c7c77c3d.
 2021-05-30 21:25:42 -04:00
Marek Roszko 5c543b62c5 Cleanup: Use make_unique for the legacy plugin board deleter 2021-05-30 20:56:44 -04:00
Marek Roszko 65c7c77c3d Use lambdas to fix paste conditions 
`SELECTION_CONDITIONS::Idle && ` was evaluating as always true because this was referencing the function pointer
 2021-05-30 20:37:16 -04:00
Marek Roszko a7d1ef9927 Fix some more uninitialized warnings 
From PVS Studio
 2021-05-30 20:05:37 -04:00
Marek Roszko 382dca4e6f Fix uninitialized member warnings 
Based on PVS Studio report
 2021-05-30 20:01:01 -04:00
Tomasz Wlostowski 67f0bbc6d7 router: fixed crash in HullIntersection() when the path has 0 or 1 points. 
fixes: 8515
 2021-05-31 00:20:32 +02:00
Tomasz Wlostowski 614787caae router: clear head line geometry if current head routing failed + small improvement to follow-mouse optimization. 
Also added a lot of verbosity for the pns-log-viewer tool.

Fixes: 8511
 2021-05-31 00:18:42 +02:00
Tomasz Wlostowski dfd80e077c router: fix another corner case in LINE::Walkaround() (duplicated vertex triggered by feeding a closed loop as the input path) 
fixes: 1775
 2021-05-31 00:17:12 +02:00
Jon Evans 0da85ded2f PNS: Fix diff pair handling of microvias as start items 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8514
 2021-05-30 15:51:28 -04:00
Jon Evans b7f32d7f53 Clean up some layout of pages in Board Setup 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8474
 2021-05-30 14:04:00 -04:00
Tomasz Wlostowski fcb89b99a3 router: walkaround algo should not copy the previous via position when the current iteration via placement fails. 
fixes: 7827
 2021-05-30 00:35:58 +02:00
Tomasz Wlostowski af2e163890 router: annotate source locations of WALKAROUND debug items 2021-05-30 00:35:54 +02:00
Jeff Young 8e2fb1bdb9 Treat Cut like a Delete while in a Move. 
Also fixes problem where second action wasn't getting executed because
the event was getting eaten.

Fixes https://gitlab.com/kicad/code/kicad/issues/8072
 2021-05-29 22:10:43 +01:00
Jon Evans 3eb5a484e1 PNS: Don't clip tuning paths to pads on other layers 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8504
 2021-05-29 15:52:44 -04:00
Jon Evans f6d6b7d263 Harmonize property names for zone/footprint/pad clearance and thermals 
Use "override" instead of "local" for better clarity.
 2021-05-29 14:12:23 -04:00
Jon Evans 28f17c3ae6 PNS: Prevent wrong clearance being cached for new diff pairs 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8377
 2021-05-29 13:31:17 -04:00
Jon Evans 85ca85652d Do not add debug items to view if debug flag isn't enabled 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8510
 2021-05-29 12:40:24 -04:00
Jon Evans bd59da3642 PNS: Local min distance has a minimum points requirement 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8510
 2021-05-29 12:40:24 -04:00
Jon Evans eff9746f34 CHANGED: Net highlight in PcbNew is now persistent to match Eeschema 
CHANGED: Highlight net tool changed to highlight display toggle; moved to left toolbar
CHANGED: Multi-net highlight is now accessible when using the highlight net action
ADDED: Highlight Net and Clear Highlight actions to Net Tools context menu
ADDED: Default hotkey (Ctrl+`) for toggling net highlighting

The current and previous net highlight state are now stored and can be toggled
on or off with an action (no hotkey by default).

Highlight is now treated as a persistent state rather than a tool that is entered,
meaning there is no longer a special tool to enter in order to highlight nets.
Highlighting can be controlled while any other tool is active using the hotkeys
or context menu on a net object.

Tweak the icons for highlight net and layer display mode to better disambiguate them.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8250
 2021-05-29 12:40:24 -04:00
jean-pierre charras 81c7fb61f8 Sub-menu "Preferences..." in main menu "Preferences": fix not working accelerator key. 
Accelerator keys are disable in our WX_MENUBAR. A common ACTION_MENU is used and
"Preferences..." is now shown in Hotkeys list.
 2021-05-29 18:09:49 +02:00
Tomasz Wlostowski ebd957b08e router: rework router's debugging infrastructure to be more compatibile with the 'qa/pns/pns-log-viewer' tool. 
The log viewer tool lets you inspect all the intermediate stages of the routing algorithms. This patch:
- Adds source location tracking of the debug calls (need to use the PNS_DBG macro, sorry)
- Moves some wxLogTrace calls to DEBUG_DECORATOR::Message() so that messages can be displayed alongside the corresponding geometric shapes
 2021-05-29 00:13:24 +02:00
Tomasz Wlostowski 132eb53a40 router: clean some debug clutter 2021-05-29 00:13:24 +02:00
Tomasz Wlostowski b3caa3c4d4 router: fix ordering of colliding hulls in NODE::NearestObstacle() 
Replaced the generic SHAPE_LINE_CHAIN::Intersect() with PNS::HullIntersection() which correctly rejects
'non-penetrating' intersections.
 2021-05-29 00:13:24 +02:00
Tomasz Wlostowski e66bbfd1ec router: improve the feel of the walkaround algorithm 
Makes walkaround more 'huggy' - the trace being routed sticks to obstacles
instead of jumping around in uncontrollable way.
 2021-05-29 00:13:24 +02:00
Tomasz Wlostowski 8148b5d81f router: improvements in LINE::Walkaround() 
- Fix walk failure if the input path starts on the hull boundary
  (happens very often during tight walkaround)
- Input line can have a loop at the end now. Such condition happens when the routing
  destination point lies inside the hull of a colliding primitive.
 2021-05-29 00:13:24 +02:00
Tomasz Wlostowski d2ec3fc4ed router: P&S-specific hull/line interection function that correctly rejects segments/vertices that only touch the hull polygons without penetrating them 2021-05-29 00:13:24 +02:00
Tomasz Wlostowski 8c4361bbc6 router: adapt to new SHAPE_LINE_CHAIN::INTERSECTIONS structure 2021-05-29 00:13:24 +02:00
Seth Hillbrand 752ae4d519 Rename modification flag routines 
Differentiates better between the EDA_ITEM IsModified(), referring to
items themselves changing and the EDA_SCREEN IsContentModified(),
referring to whether we have made any unsaved changes.
 2021-05-28 12:07:04 -07:00
Seth Hillbrand b1dcf74042 Use standard "Untitled" name for files without names 
Also translates to provide useful information regardless of language
 2021-05-28 11:51:54 -07:00
Seth Hillbrand d7f219e98f Unify IsSave and IsModify 
The flags and calls were used identically, leading to potential
confusion/bugs.  Testing for modification should go through
IsContentModified()
 2021-05-28 11:51:54 -07:00
david-beinder 64cd401bdb Delete Tool: Fix missing "Item Locked" popup 
Fixes problem identified in https://gitlab.com/kicad/code/kicad/-/issues/8392
Removes same popup from schematic tool because SCH_ITEM can not be locked
 2021-05-27 05:38:51 +00:00
Jeff Young 4fb643df93 Update POINT_EDITOR when locking/unlocking via Hotkey/RMB. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8489
 2021-05-26 16:03:35 +01:00
Seth Hillbrand ba73456d49 Allow point editor to persist 
After drawing a graphic, allow the control points to persist when
exiting the tool.

The effect of this is to make the first "Esc" press a
"return-to-select-tool" event without modifying the selection or control
points from within the drawing tools.  The section "Esc" press, when in
the selection tool will clear the selection and the control points
 2021-05-25 16:47:54 -07:00
Jeff Young 5c9a73aa5e Correct position for grid even when we're not snapping to a point. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8125
 2021-05-25 21:57:19 +01:00
Jeff Young 0eed73ea73 Make PCB_POINT_EDITOR honour locked flag. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8254
 2021-05-25 18:13:24 +01:00
Jeff Young 5f22025611 Don't drop text on Edge.Cuts when plotting. 
While -our- user model is that Edge.Cuts is just for edges, it's best
not to dictate a particular model to users.

ADDED a DRC error when text (or a dimension) appears on the Edge.Cuts
layer.

Fixes https://gitlab.com/kicad/code/kicad/issues/8470
 2021-05-24 19:54:52 +01:00
Jeff Young 8f3343b9e3 Clear UUID paths of unmatched footprints even when not deleting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8461
 2021-05-23 22:50:11 +01:00
Jeff Young ab8428bd68 Naming conventions. 2021-05-23 22:21:34 +01:00
Jeff Young 9554aaee7f Can't use wxDD_MULTIPLE before 3.1.4. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8465
 2021-05-22 22:19:37 +01:00
Jeff Young ee00d8386f Make sure dir case can handle multiple selection too. 
Files case already can.

Fixes https://gitlab.com/kicad/code/kicad/issues/8465
 2021-05-22 20:39:26 +01:00
Jeff Young baf868fce7 Add footprint repair tool (currently just for duplicate IDs). 2021-05-21 17:52:11 +01:00
Jeff Young 0d8a9a1091 Make sure that a tool never exits with autopan or capture. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8459
 2021-05-21 14:53:58 +01:00
Jeff Young 3de60231db Allow clearance debugging of exact items in DRC violation. 
ADDED: Run clearance resolution tool... RMB menu item to DRC
clearance errors.

Fixes https://gitlab.com/kicad/code/kicad/issues/8438
 2021-05-21 00:00:24 +01:00
Jeff Young e93e9fa3e5 Add rudimentary type checking to rule eval with reporter. 
Also cleaned up existing error reporting to not expend CPU cycles
when there was no reporter.

Fixes https://gitlab.com/kicad/code/kicad/issues/8438
 2021-05-20 23:06:24 +01:00
Jeff Young 4c3d78dec0 Break out separate holes-co-located violation. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8456
 2021-05-20 10:36:56 +01:00
jean-pierre charras 60dbda9dd2 Pcbnew: try to fix an issue about frame title. 
for Pcbnew, this issue (see bug 8404) is only seen on OSX.
So I am blindly trying to add to Pcbnew a fix made for Eeschema.
 2021-05-19 17:28:15 +02:00
jean-pierre charras be3a08bfa7 Pcbnew printing: fix missing zones on non copper layers. 2021-05-19 10:05:49 +02:00
Jeff Young ed2f2257ce Remove footprint locking in the footprint editor. 
(It doesn't make any sense there as the position is always {0, 0} in
the editor.)

For discussion see:
https://kicad.zulipchat.com/#narrow/stream/258851-Developer-Chat/topic/Is.20there.20a.20reason.20why.20kicad.20now.20seems.20to.20lock.20pads.3F
 2021-05-18 23:14:17 +01:00
Simon Richter 810a717e4e Remove unused NETINFO_MAPPING member 
The legacy plugin no longer implements saving, so no net code renumbering
is needed.
 2021-05-17 11:54:06 +00:00
jean-pierre charras c33b2cfa8d PANEL_SETUP_MASK_AND_PASTE_BASE: fix another cosmetic issue. 
On KDE, a text was truncated, although there is room to display it
 2021-05-16 13:22:48 +02:00
Jeff Young 4c69a74505 Force layers visible when routing on them. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8432
 2021-05-16 11:18:31 +01:00
jean-pierre charras 2354222188 Remove tool tips not related to the objects they are depending on. 
Probably due to a too zealous copy/paste.
 2021-05-16 10:03:12 +02:00
jean-pierre charras 057e2cd6b7 Pcbnew: fix some cosmetic issues in a few dialogs 
Depending of Window managers, some texts were truncated.
Also avoid to write a sentence with the beginning in one widget,
and the end in another widget: it makes the sentence not translatable
 2021-05-16 09:13:13 +02:00
Jeff Young 138a4b21c1 Smarten custom-pad-shape test for collapsing solder mask margins. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8413
 2021-05-16 00:41:19 +01:00
jean-pierre charras d1061b9683 3D viewer: Fix broken handling of text thickness, thus creating erroneous item positions 
Especially, texts having a not centered justification were shown with artifacts.
 2021-05-15 13:18:06 +02:00
Jeff Young ccaf9e11df Load footprint info when there's no cache available. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8371
 2021-05-14 22:24:21 +01:00
david-beinder 1642f0d784 Move microwave tools from toolbar to Place menu 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8233
 2021-05-12 02:34:52 +00:00
david-beinder 75f49ba1b6 Add length tuner settings to toolbar context menu 2021-05-12 02:34:52 +00:00
david-beinder 34145d8170 Add length tuning menu to vertical pcb toolbar 2021-05-12 02:34:52 +00:00
Jeff Young c49af57c2a Don't require a restart to get the current m_Live3DRefresh setting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8349
 2021-05-11 15:07:52 +01:00
Jon Evans bc6b9b527a Allow stackup height to be excluded from length calculations 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8384
 2021-05-10 22:11:58 -04:00
Jon Evans 5157c6c3b9 Use half copper thickness as the thickness of the start and end of vias 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8384
 2021-05-10 21:48:50 -04:00
Jon Evans 64c76d8067 Hide unimplemented controls in length tuner settings 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8383
 2021-05-10 21:40:52 -04:00
Jon Evans 1201ab5cac Clarify track segment length vs net length in message panel 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8396
 2021-05-10 21:06:17 -04:00
Jon Evans ce01a28aad Don't double-remove nets when netcodes are reused 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8206
 2021-05-10 19:52:19 -04:00
Jeff Young 7356f9568d Move grid disable modifier from ALT to CTRL. 
Also had to move the H/V/45 disable modifier from CTRL to SHIFT.

Fixes https://gitlab.com/kicad/code/kicad/issues/8124
 2021-05-09 20:17:40 +01:00
Ian McInerney 916a15793f Fix some OSX compiler warnings 2021-05-09 12:59:57 +01:00
jean-pierre charras a5ff27cae7 Pcbnew, EDIT_TOOL::GetAndPlace(): fix and issue, and allows execution only if 
called inside the board editor.
Fix also a broken behavior: the current action was not cancelled, and if it is
called during a move items (when typing the 'T' key), items were broken.
The actual bug is the fact it is called also in fp editor and footprint wizard frame,
because it is part of EDIT_TOOL action list, common to fp editor, and should not.
But a full change is much more costly than just a filter.
 2021-05-09 11:51:57 +02:00
Jeff Young b4b59c3b33 Fix uninitialized variable. 2021-05-08 20:49:51 +01:00
Jon Evans 1a45d9474b Don't show commands that cancel routing when routing is in progress 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8363
 2021-05-08 14:55:02 -04:00
Wayne Stambaugh 6e017b475d Warn user before removing invalid rows from library table entries. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8080
 2021-05-08 08:58:54 -04:00
jean-pierre charras aaffd0c137 Pcbnew: fix crash due to a not tested null pointer. 
Fixes #8369
https://gitlab.com/kicad/code/kicad/issues/8369
 2021-05-07 10:35:00 +02:00
Jeff Young e709e77870 Add missing locked setting to zone dialogs. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8255
 2021-05-06 22:50:03 +01:00
Allan Nordhøy cda70a66c3 Spelling fix vrml->VRML 
Closes https://gitlab.com/kicad/code/kicad/-/merge_requests/739
 2021-05-06 21:55:36 +01:00
jean-pierre charras 1b9a8564af Pcbnew: fix incorrect PCB_TEXT::TextHitTest( const EDA_RECT& aRect,... ). 
It was not taking in account the text rotation in block selection.
Fixes #8366
https://gitlab.com/kicad/code/kicad/issues/8366
 2021-05-06 18:48:23 +02:00
Jeff Young 2e3860de6f Naming conventions. 2021-05-05 22:58:40 +01:00
jean-pierre charras 56058314be Fix minor Coverity warnings and minor compil warnings. 
(uninitialized or shadowed vars)
 2021-05-05 08:58:55 +02:00
Fabien Corona 094dd2e08c pcbnew : rotate relatively to selection center 2021-05-04 09:13:20 +00:00
Wayne Stambaugh 16bb45208a Fix save accelerator key handling when library tree has focus. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8247
 2021-05-03 19:41:07 -04:00
Marek Roszko c7345096f8 Use wxFFileInputStream explicitly when loading xml documents 
wxFFile (FILE, buffered) is better than wxFile (syscalls)
 2021-05-03 19:39:56 -04:00
Tomasz Wlostowski 939b5e1932 PCB_EXPR_EVALUATOR: don't use string comparison to check for undefined enum values 2021-05-03 23:45:54 +02:00
Jeff Young d7e44b5181 Default delete-tracks-inside-pads to false. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8326
 2021-05-03 19:48:24 +01:00
Roberto Fernandez Bautista f2677340f2 Access the new paste behaviour via a new Paste Special... dialog 
ADDED Paste Special... action in pcbnew

CHANGED Additional options for Paste Special... in eeschema, including
"Assign unique reference designators to pasted instance"
 2021-05-03 19:38:32 +01:00
Roberto Fernandez Bautista 98c8f43320 eeschema and pcbnew paste: consistent paste behaviour 
Duplicates are reannotated on paste in the same way in pcbnew and
eeschema such that when copying and pasting the same block in the
pcb and schematic, the reference designators will match.
 2021-05-03 19:38:32 +01:00
Roberto Fernandez Bautista ae009e0758 Ensure clipboard data is available after KiCad closes 
Always Flush() after SetData()
 2021-05-03 19:38:31 +01:00
Jeff Young 688ee18989 Don't apply margin to "interior" shapes in a shape-set. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8345
 2021-05-03 12:12:03 +01:00
jean-pierre charras a6ad7a4a70 Python wizards: Fix a compatibility with "old" pythons scripts, after commit 21fde9b6. 
Temporary fix until a full python API exists.
 2021-05-02 16:06:11 +02:00
Marek Roszko c4801a4dd4 Catch oom for graphics importer 
Because DXFs and SVGs could be nasty sized
 2021-05-01 14:26:47 -04:00
Marek Roszko d4bb1cbc63 Make drawing sheet loading slightly smarter 2021-05-01 14:11:31 -04:00
jean-pierre charras f6f2284851 Fix missing includes on Linux after commit 0427bda7 2021-05-01 20:05:01 +02:00
jean-pierre charras 0427bda768 Remove useless wx/wx.h include, that create sometimes compil warnings on msys. 
wx/wx.h includes all wxWidgets .h files, and sometimes creates collision
names in #define between kicad and windows headers
Moreover, blindly including a lot of useless files is compil time consuming
 2021-05-01 19:32:15 +02:00
Marek Roszko 18ff8ea4a0 Try to catch memory allocation errors in pcbnew and eeschema 2021-05-01 13:11:10 -04:00
Marek Roszko 3a9a85b373 Enum class PAD_PROP_T 
Renamed such that it does not affect python
 2021-05-01 10:58:30 -04:00
Marek Roszko 03cf2b517f Enum class PAD_ATTR_T 
Renamed such that python stays the same
 2021-05-01 10:51:54 -04:00
Marek Roszko e20562b09b Some cleanup 2021-05-01 10:37:20 -04:00
Marek Roszko b243c2280d enum class PAD_SHAPE_T 2021-05-01 08:22:35 -04:00
Marek Roszko 21fde9b629 enum class PCB_SHAPE_TYPE_T 2021-04-30 22:36:12 -04:00
Jeff Young 7df9fa0631 Diffpair gap should only override clearance within a coupled diffpair. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7975
 2021-04-30 18:39:21 +01:00
Marek Roszko 6e874265fa Autosize all of the layer columns to ensure dpi match 
Fix #8202
 2021-04-29 20:01:07 -04:00
Jeff Young c149ed8905 Allow diffpair gap to override normal netclass clearance. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7975
 2021-04-29 10:23:49 +01:00
Jeff Young 91421f9908 Separate logic for multi-select and click-select when filtering. 
Also removes a bunch of old implementations of pad locking and
filtering which are no longer needed.  (They're now handled by the
uniform locking code.)

Also removes some of the auto-promotion logic.  Rotating a footprint
when a pad was selected is going to be surprising whether the pad
is locked or not.

Fixes https://gitlab.com/kicad/code/kicad/issues/8322
 2021-04-29 00:07:35 +01:00
Marek Roszko 39a0bc6252 Remove erroneous block check in dxf import added during previous improvements 2021-04-28 18:48:59 -04:00
jean-pierre charras 4d9829ec8b Fix some issues related to python scripts: 
- make PadArray.py compatible python2/3
- fix a wxWidgets warning in pcbnew_scripting_helpers.cpp shown in some cases
 2021-04-28 14:02:47 +02:00
Seth Hillbrand 78b555afa2 Filter Select All event against hierarchy 
Fixes https://gitlab.com/kicad/code/kicad/issues/8316
 2021-04-27 16:58:45 -07:00
Tomasz Wlostowski a433451bd8 router: 'root line' tracking in the SHOVE algorithm. See comments for detailed explanation. 2021-04-27 14:13:16 +02:00
Tomasz Wlostowski 3a8744d054 router: introduce concept of a root lines in the OPTIMIZER. 
By 'root lines' we mean the oldest traceable ancestor of each track moved by the router
(i.e. after shoving for a while, the root of each shoved line is it's latest non-shoved version).

With this we can teach the OPTIMIZER more tricks, such as the LIMIT_CORNER_COUNT constraint. It ensures
the results of the optimization will not be less cornery than the original line, reducing the feeling
of the optimizer being too intrusive.
 2021-04-27 14:13:16 +02:00
Tomasz Wlostowski 76f8861e6e router: revert Seth's arc adjustment in StartDragging(). 
Fixes picking the last segment instead of the last vertex to drag (when one is requested).
I didn't notice any behaviour change of the dragger wrs to arcs.
 2021-04-27 14:13:16 +02:00
jean-pierre charras 524ca442f3 Old python scripts: fix issues due to code change, and make them Python3/3 compatible 2021-04-27 11:55:56 +02:00
jean-pierre charras b63c482347 Fix a link issue with pcbnew_wrap.cxx (MSYS + Windows 64 bits specific) 
For some reason the .cxx file generated by SWIG cannot be linked if compiled
with debug options.
It creates a *lot* of not found symbols. So compile it with release mode (MSYS only)
 2021-04-27 07:40:34 +02:00
Jeff Young 5bf37a9b24 Don't allow selection crossing a parent/child relationship. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8292

Fixes https://gitlab.com/kicad/code/kicad/issues/7255
 2021-04-26 18:47:44 +01:00
Jeff Young b65b1f8e9c Revert NPTH commit, and add some comments. 2021-04-26 17:33:49 +01:00
Jon Evans 7afc3f7df9 Rearrange track width button to be more obvious 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8300
 2021-04-25 19:58:11 -04:00
david-beinder cbe8b1644a Fix segfault after using group properties dialog 
Fixes https://gitlab.com/kicad/code/kicad/issues/8302
 2021-04-25 22:15:19 +02:00
Jeff Young d2b6050792 Minor dialog spacing adjustment. 2021-04-25 19:26:05 +01:00
Jeff Young e6bf922a77 Make sure connectivity is locked for zone filling. 
See 1e33928b96
for the original addition and rationale.
 2021-04-25 18:09:53 +01:00
Jeff Young e3eacafbcb Run hole clearance tests on NPTH pads, but not copper clearance. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8295
 2021-04-25 17:55:43 +01:00
Jeff Young b7279c0bab Don't allow rounding errors to flag DRC violations in hole2hole. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8295
 2021-04-25 17:55:43 +01:00
Jeff Young 517bcb15b1 Formatting. 2021-04-25 17:55:43 +01:00
Jeff Young 953f579d59 Keep dialog fields in sync with dummyPad values. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8294
 2021-04-25 14:19:38 +01:00
jean-pierre charras 93d42e9902 Pcbnew: Fix crash when importing a netlist created by a 5.1 Eeschema version. 
Fixes #8293
https://gitlab.com/kicad/code/kicad/issues/8293
 2021-04-25 15:13:55 +02:00
Jeff Young eb85836234 Make sure we have footprint courtyards before depending on DRC rules. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8291
 2021-04-25 12:45:06 +01:00
Jeff Young 1e8b23402c Bump board format version for locked syntax fix. 2021-04-24 19:11:17 +01:00
jean-pierre charras e27733587d Fix 2 minor Coverity warnings. 2021-04-23 19:57:36 +02:00
jean-pierre charras 3be17ceb50 PANEL_SETUP_TRACKS_AND_VIAS: fix UI issues. 
Fixes #8264
https://gitlab.com/kicad/code/kicad/issues/8264
 2021-04-23 10:58:59 +02:00
Jon Evans 7569fc8aad Bring back live move of footprint in 3D view if live refresh is on 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8220
 2021-04-22 22:32:41 -04:00
Jon Evans 263e026ac4 Initialize grid visibility in appearance panel constructor 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8266
 2021-04-22 22:10:55 -04:00
Jonathan Haas 075bd788eb Remove unused OBSTACLE_VISITOR::m_extraClearance 2021-04-23 01:53:09 +00:00
Jon Evans 3e96fb851c Give diff pair toolbutton a menu also 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8233
 2021-04-22 21:37:15 -04:00
Ian McInerney ecd9bf696e Be consistent about using nullptr instead of 0 
0 can be too easily overloaded into an int, so ensure we use nullptr
when we mean pointers.
 2021-04-22 22:20:34 +01:00
Wayne Stambaugh 54e18f6b1f Pcbnew: remove update schematic option for geographical annotation dialog. 
REMOVED: Update schematic option from geographical annotation dialog due
to potential issues with incomplete and/or broken updates.  Use "Update
Schematic from PCB" tool to update reference designation changes.

Forcing the footprint reference designator changes back to the schematic
without checking any other board changes in the schematic could leave the
schematic in a undefined state.  The update schematic from board tool is
the correct method to sync any changes from the board.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8042
 2021-04-22 12:45:59 -04:00
Jon Evans cf47d665ea PNS: Dragged line needs to retain width 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8246
 2021-04-22 09:04:41 -04:00
Jon Evans 9b1890606d PNS: Do not allow resolved optimal values to go below board minimums 2021-04-21 22:43:26 -04:00
Jon Evans ae113ea299 DRC: inDiffPair should return false if the coupled net is missing 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8268
 2021-04-21 22:41:17 -04:00
Jon Evans e7d3bf29aa Don't save project for legacy board without explicit action 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7368
 2021-04-21 21:27:23 -04:00
Jeff Young e5d029af6b Margin layer missing from some edge clearance tests. 
Fixes bug reported on KiCad Forums.
 2021-04-21 21:58:47 +01:00
Jeff Young 61ce1b35ec R/W dimension lock flags and update format for all lock flags. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8255
 2021-04-21 19:59:27 +01:00
Jeff Young 3b049b32cf Show if pads, zones, and dimensions are locked in the status bar. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8255
 2021-04-21 19:58:18 +01:00
Adam Wolf 25e2f35308 Remove no-longer-needed macOS wxPython things. 2021-04-21 12:50:31 +00:00
Adam Wolf a06f0ca908 Clean up macOS Python3 paths 2021-04-21 12:50:31 +00:00
Adam Wolf 7357424efc Update macOS to Python 3, wx 3.1, and Phoenix. 
This is a work-in-progress.  It could use testing while I continue to fix
the remaining pieces.

There are some changes that will be needed for signing and notarization.

This currently relies on a Python tool I wrote (dyldstyle) to fixup
KiCad.app correctly. I would like any bundle fixing necessary to use a
built KiCad on macOS to live inside KiCad, rather than in
kicad-mac-builder or elsewhere.  While I was experimenting, I found this
worked, however, and I would love to get extra hands testing.

I added a CMake argument, MACOS_EXTRA_BUNDLE_FIX_DIRS, for devs and
packagers who have extra directories they need to add to
fixup_bundle on KiCad.app.

There's an issue about differing behavior when KiCad is opened via
the command line or via Finder/launchd.
 2021-04-21 12:50:31 +00:00
Jon Evans c973a447df Make sure board netinfo list is updated when net inspector renames a net 2021-04-20 21:15:42 -04:00
Jon Evans cbd7d698a9 Fix diff pair error message suffix suggestions 
We accept diff pairs that end in N/P, no underscore required
 2021-04-20 21:08:34 -04:00
Jon Evans 8792d7288d Net inspector: Fix calculation of via length 
We have a function for this in the BOARD_STACKUP now, and it returns
a more correct number (excluding the start and end copper layers)

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8256
 2021-04-20 20:03:38 -04:00
Jon Evans 2535daf661 PNS: Account for via stack height in diff pair length tuner 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8256
 2021-04-20 19:31:10 -04:00
Wayne Stambaugh a7f956581c Pcbnew: fix board file formatting issues. 
This does not required a board file version change.  All of the changes
are white space formatting fixes and improvements.
 2021-04-20 10:18:31 -04:00
Marek Roszko ce3a84f579 Consolidate wx aui dock art color setting 2021-04-19 21:12:02 -04:00
jean-pierre charras ba3f0d5d07 Fix a wxWidget assert and a minor wxWidgets alert 2021-04-19 15:01:00 +02:00
jean-pierre charras 287b0eea0f TRACK::GetMsgPanelInfo(): For arc, display shape ("TRACK (arc)") and radius. 
Also display "TRACK (arc)" in DRC error message, instead of just "Track".
 2021-04-19 10:00:46 +02:00
Jon Evans dd828bd964 PNS: Bring back original Highlight Collisions behavior 
From discussion with Tom, Jeff, and Wayne, it appears as though
we all agreed that Highlight Collisions should behave like it
did in 5.1, which is to say, always just highlight collisions,
never prevent them.  The Allow DRC Violations checkbox just
controls whether or not you can fix/commit the head line if it
has violations; you are not prevented from moving the head
line to violating positions in any case.

Right now, there does not seem to be much demand for a separate
"Stop at First Obstacle" mode since Walkaround basically does that
but better, but we agreed that if there is demand for it in the
future, it should be implemented as a new router mode rather than
a behavior of Highlight Collisions mode controlled by the Allow
DRC Violations checkbox.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/7828
 2021-04-18 21:01:07 -04:00
Tomasz Wlostowski 4538d78828 router: fix via shoving regression. 2021-04-19 00:43:30 +02:00
Tomasz Wlostowski 57de83897a router: VIA SetDrill() and SetPosition() must update the hole shape too. 2021-04-19 00:43:15 +02:00
jean-pierre charras dc3a73a2fb PAD::MergePrimitivesAsPolygon(): add option to approximate circles outside the actual shape 
When creating a polygon from an arc/circle, the small error due to approximation
can be now inside (when drawing/plotting the shape) or outside the circle
(when building a clearance area) like other pad shapes
Fixes #5313
https://gitlab.com/kicad/code/kicad/issues/5313
 2021-04-18 20:10:00 +02:00
Jon Evans ec6995697d PNS: even more free performance 
If this doesn't work, we have bigger problems
 2021-04-18 09:50:06 -04:00
jean-pierre charras 2d9bac804c Pcbnew: minor fix: remove extra spaces when outputting pad primitives section. 
No format change.
 2021-04-18 15:25:14 +02:00
Jon Evans 6425ad4118 PNS: Fix propagateDpHeadForces obstacle calculation 
Using a synthetic via here doesn't quite let us use VIA::PushoutForce
because it will use the wrong clearance, and also doesn't quite have
the logic we want.  I am not familiar enough with PushoutForce to know
if its logic is a bug in other cases, so instead I just brought in the
parts of its algorithm that are needed here.

Additionally, we prevent pushing more than once from a given obstacle,
which causes walkaround to be more successful when routing diff pairs
against a large collider such as a keepout area.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8232
 2021-04-17 22:37:30 -04:00
Jon Evans 5974446523 PNS: Let's make the r-tree work for us 
I'm not sure where the magic number of "4x worst" came from, but it's
been around forever.  This is extremely inefficient as it negates much
of the power of r-tree filtering in dense designs.  If we really trusted
it, we could set this just to worstClearance.  Keeping it above the worst
clearance by a little bit seems to provide enough of a speed improvement
to resolve the test cases I have, so I'll go with that for now.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/7777
 2021-04-17 21:37:11 -04:00
Jeff Young a577b6386d Fix missing status bar update after undo/redo. 
(Reported by Franck.)
 2021-04-17 17:21:54 +01:00
Jeff Young 13473420e5 Remove duplicated routine and fix bug in UTIL version. 2021-04-17 15:10:59 +01:00
Wayne Stambaugh 2ae264751f Rename class_board_stackup.{h|cpp} to board_stackup.{h|cpp}. 2021-04-16 17:07:06 -04:00
Jeff Young 3a6a919097 Improve clarity in the Print dialog around edge cuts layer. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8200
 2021-04-16 16:53:51 +01:00
Jon Evans 29c45743b7 Fix calculation of arc lengths; include them in net inspector 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8140
 2021-04-15 21:06:35 -04:00
Jon Evans 64c8befa01 Fix copy/paste error 2021-04-15 20:45:32 -04:00
Jon Evans 928d336bee Only try to copy design rules file if it exists 2021-04-15 20:43:35 -04:00
Jeff Young 23a1f8b17a Enforce board minimum clearance over local clearance overrides. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8199
 2021-04-15 21:44:04 +01:00
Jeff Young 311bb9c36e Save rules file when saving project. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8143
 2021-04-15 10:23:38 +01:00
Jeff Young 9a282f081a Document rules version clause. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8201
 2021-04-15 10:23:38 +01:00
Jon Evans 4920692bcd DIFF_PAIR_GAP_CONSTRAINT does not need to be restricted to two items 
We just need one item to see what netclass we're in; the constraint
itself is specific to diff pairs so the condition doesn't need to be.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8205
 2021-04-14 23:43:43 -04:00
Jon Evans 1d7e5a0443 Fix merge error that prevented a previous change from working 2021-04-14 23:30:16 -04:00
Jon Evans 433e148e08 Move some string formatting functions out of base_units 
Keeping them in base_units means that we can't introduce
any dependence on these functions to anything that needs to
compile without one of the unit defines (EESCHEMA, PCBNEW, etc)
 2021-04-14 23:21:10 -04:00
Jon Evans 268d570941 PNS: keep last valid diff pair trace as current state 
This allows fixing/committing what is on screen even if the current
cursor position doesn't have a valid solution (the old behavior
would result in the current trace disappearing)
 2021-04-14 23:21:10 -04:00
Jon Evans c829dba88e PNS: Reduce minimum distance to start turn in diff pair placer 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8193
 2021-04-14 23:21:10 -04:00
Jon Evans cac4d70154 PNS: Respect fix-all in diff pair placer 2021-04-14 23:21:10 -04:00
Jeff Young fe6cc0c3d8 Spokes are from center of pad, not from hole (ie: pad position). 
Fixes https://gitlab.com/kicad/code/kicad/issues/8195
 2021-04-14 11:34:26 +01:00
Jeff Young f7cc6d1e1e Fix save as and save copy as for project files. 2021-04-13 17:56:50 +01:00
Jeff Young d79057b83a Fix merge wreckage in building netclasses. 2021-04-13 17:56:50 +01:00
Jeff Young 94e8855c13 Generate changed message before making change. 
Otherwise we've lost the "before" value.

Fixes https://gitlab.com/kicad/code/kicad/issues/8186
 2021-04-13 13:43:30 +01:00
Jeff Young 55d2d0d93e Fix some bugs in file save as. 
The order of operations *appeared* to be a bit out of joint.
We need to create a new project in project mode as well as in standalone.

Fixes https://gitlab.com/kicad/code/kicad/issues/8143
 2021-04-13 13:34:40 +01:00
Jon Evans 296a9df530 PNS: Pick up diff pair starting width from continuation track 2021-04-12 23:10:15 -04:00
Jon Evans 1d9ca181a2 PNS: Use existing seg direction if both DP segs are parallel 2021-04-12 22:34:13 -04:00
Jon Evans 37dd4038eb Display options can change during the picker lifecycle 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7133
 2021-04-12 22:12:48 -04:00
Jon Evans 36ef198610 Clean up nets from items when deleting in the inspector 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8162
 2021-04-12 21:17:42 -04:00
Jon Evans 311cde0984 Safety check suggested by Coverity 2021-04-12 20:42:50 -04:00
Jon Evans 2aa5e568e8 Refactoring 2021-04-12 20:40:05 -04:00
Jon Evans 73fb85a352 PNS: Calculate diff pair primitive orientation using anchors only 
The previous method fails if the primitive is an expanding or
contracting pair (diagonals going inward or outward) resulting in
incorrect orientation, which then leads to incorrect candidate
gateways being generated and no solution found.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8185
 2021-04-12 20:34:44 -04:00
Jon Evans 94fad2944d ConvertOutlineToPolygon: Don't crash if we didn't find a segment owner 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8184
 2021-04-12 19:59:55 -04:00
Jon Evans 715c61ac9f PNS: Fix yet more arc edge cases 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8150
 2021-04-12 19:59:55 -04:00
Roberto Fernandez Bautista edb2136a0d CADSTAR PCB: KiCad's minimum permitted Through Drill is 0.0508mm(2mils) 2021-04-12 20:25:05 +01:00
Roberto Fernandez Bautista a3196a11a7 CADSTAR PCB: Be more specific with "allow thermal pads" DRC hack 
Only tag the footprint as such when we know it has overlaping copper
over the pads with different pad numbers
 2021-04-12 20:25:05 +01:00
Roberto Fernandez Bautista b5edd5f6a5 CADSTAR PCB: Fix loading of thermal pads 
- Create a pad if a component copper is associated with any other pads
  in the footprint.
- Rename/renumber 'PCB Only' pads that are associated with a component
  copper and make them all use the same pad name/number.
 2021-04-12 20:25:05 +01:00
Roberto Fernandez Bautista 2eb96279a2 Fix FOOTPRINT copy constructor so it maintains ordering of containers 2021-04-12 20:25:04 +01:00
Jeff Young a4c08e2af6 Apply Eeschema cursor updating architecture to PCBNew. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8135
 2021-04-12 11:11:11 +01:00
Jeff Young 2cba64b258 Fix missing env var expansion in pos file generation. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8178
 2021-04-12 10:17:42 +01:00
Jeff Young 34ea6891b0 Formatting. 2021-04-12 10:17:42 +01:00
jean-pierre charras 675ec70f0f PANEL_SETUP_BOARD_STACKUP: fix a wxassert due to a "C" locale test in a format function. 
A call to FormatInternalUnits() was made without switching to "C" locale.
In this case it was not necessary, but FormatInternalUnits() expects in some tests
this locale, thus creating issues (assert and incorrect conversion)

Fixes #8177
https://gitlab.com/kicad/code/kicad/issues/8177
 2021-04-12 09:57:40 +02:00
Jon Evans 49a91414d7 PNS: Apply co-linear seg merging to drag operations 2021-04-11 22:32:11 -04:00
Jon Evans 1c431d9929 PNS: Fix some off-by-one errors with arc dragging 2021-04-11 22:12:53 -04:00
Jon Evans a26fc6d65d PNS: Fix several issues with arc dragging 
Do not merge vertices that belong to different arcs
Fix start segment identification after arcs
Fix free-angle drag after arc

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8173
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8150
 2021-04-11 17:56:40 -04:00
Jeff Young 7d58c53e42 Apply new hole-dimming logic to via pads. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8144
 2021-04-11 17:51:38 +01:00
Jeff Young 2cde76a191 Don't do any hole clearance testing within a single footprint. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8141
 2021-04-11 16:03:16 +01:00
Jon Evans 7ba110bd77 PNS: Fix dragging of segments with arcs in line 2021-04-11 10:18:57 -04:00
Thomas Pointhuber a30894e5a1 Allow SHAPE_LINE_CHAIN and SHAPE_ARC to be mirrored using a SEG 2021-04-11 13:27:25 +00:00
Thomas Pointhuber fe8fbf1d5d Use arcs instead of line approximation for Miter shape 
TODO:

* The resulting line chain is broken with the arcs, and
this appears to be some subsequent issue I was not able to pin down.
* The requirement of a correction factor is not clear to me
 2021-04-11 13:27:25 +00:00
Jeff Young cc956695ae Hit test for worksheet before adding Properties to menu. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8171
 2021-04-11 14:18:35 +01:00
Jeff Young 6072f5831b Apply uniform spacing to orientation controls. 2021-04-11 10:33:26 +01:00
Jeff Young 29e5882637 Fix typo (found by Coverity). 2021-04-11 10:32:15 +01:00
Jeff Young 675444a646 Dim hole walls that don't pass through high-contrast layers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8144
 2021-04-10 22:41:38 +01:00
Jon Evans 5c448057c8 PNS: Prevent state flicker when starting drag 2021-04-10 16:31:39 -04:00
Jon Evans 7784d7cb12 PNS: Fix visible area restriction 
VIEW::GetBoundary() returns the entire view area, not the visible area.
Surprisingly, we had no API for this, so I added one.

Also, changed the dragger behavior to toggle between optimizing just the
modified area and optimizing the visible area, i.e. we will now never
optimize off-screen portions of the dragged track.
 2021-04-10 16:13:08 -04:00
Jon Evans 94afdcb92a PNS: Allow control of area-restricted drag optimization 
CHANGED: The interactive router settings now include a switch to
         enable or disable optimization of the entire dragged track,
         which is now disabled by default.  When enabled, the router
         will reroute the entire track (from the dragged segment to
         the closest pad/via in each direction) to be more optimal.
         When disabled, only the area around the dragged segment
         will be modified.

CHANGED: The "optimizer effort" slider is removed from the interactive
         router settings dialog, as this setting did not have any
         meaningful impact in most cases and was a source of confusion.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/5918
 2021-04-10 15:17:39 -04:00
Jonathan Haas 846e4aed42 Fix selection filter in Edit Text and Graphics dialog 
Fixes https://gitlab.com/kicad/code/kicad/issues/7966

Fixes https://gitlab.com/kicad/code/kicad/issues/8149
 2021-04-10 15:49:23 +00:00
Jeff Young dc0cf3b802 Clean up a confusing API. 
AllowDRCViolations is kept in any mode as a *setting*, but only
controls router behaviour when the mode is mark obstacles.

Fixes https://gitlab.com/kicad/code/kicad/issues/7795
 2021-04-10 11:08:02 +01:00
Jeff Young 176fcd43d8 Cleanup. 2021-04-10 10:04:02 +01:00
Jeff Young 252fad1cc7 These grids *must* have a border on OSX to render correctly. 2021-04-10 10:04:02 +01:00
Jeff Young f606069bf6 Formatting. 2021-04-10 10:04:02 +01:00
Mikolaj Wielgus 43d8145304 Pcbnew: Snap to the closest point on graphic polygon border 
Fixes https://gitlab.com/kicad/code/kicad/issues/8164
 2021-04-09 22:33:55 +00:00
Jonathan Haas 58dfb6539f Change orientation and flip sign of dimension height when rotating orthogonal dimensions. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6940
 2021-04-09 22:30:18 +00:00
Jeff Young d2c7df155b Don't show blind/microvia holes on layers they don't appear on. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8144
 2021-04-09 17:14:53 +01:00
Jeff Young 3450610977 Add ability to allow thermal vias to be implemented as pads. 
This is mostly just for CADSTAR.  Since we don't (yet) have general
purpose footprint attributes, this reuses the "net tie" hack.

Fixes https://gitlab.com/kicad/code/kicad/issues/8141
 2021-04-09 14:02:13 +01:00
Jon Evans 619a353c5e Decouple 3D view dirty marking and refresh 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8154
 2021-04-08 22:09:19 -04:00
Seth Hillbrand 7b3c7e1ef3 Fix some free/delete issues 
Removes the C-format memory management
 2021-04-08 16:58:45 -07:00
Ian McInerney 9939af3e27 Fix color handling in the stackup manager panel 
Fixes https://gitlab.com/kicad/code/kicad/issues/5671
 2021-04-09 00:56:31 +01:00
Ian McInerney 401bc53038 Move the DRC constraints page into a scrolled window 
We seem to be getting a lot of these now, and it was
being cutoff by default - so make it a scrolled window
like the severities.
 2021-04-09 00:56:31 +01:00
Ian McInerney 5490a85f97 Don't recompute the board thickness on UI update 
The thickness only needs to be computed when the actual
values change, so computing on UI update is a waste of
resources and can cause UI lag.

Fixes https://gitlab.com/kicad/code/kicad/issues/5049
 2021-04-09 00:56:31 +01:00
Mikolaj Wielgus d64de3808f Pcbnew: Snap to group items 
Fixes https://gitlab.com/kicad/code/kicad/issues/7694
 2021-04-08 23:22:19 +00:00
Jeff Young a8b40bf683 Avoid Clipper when possible. 
When expanding an error to the outside of a rounded corner pad we
need to trim it to the pad bounding box or else we get little ears
where the circle approximation meets the pad square.  This is expensive,
and for clearance lines we don't really care whether the error is
inside or outside.

Fixes https://gitlab.com/kicad/code/kicad/issues/8157
 2021-04-08 22:37:14 +01:00
Jeff Young 5ea68c7694 Copy some bug fixes from DRC dialog across to Footprint Checker. 2021-04-08 22:37:14 +01:00
Jon Evans 4521091cc1 Do not invalidate geometry when all we need is a repaint 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8157
 2021-04-08 17:35:51 -04:00
Jon Evans d878cbddbc PNS: a few forgotten cleanup items 2021-04-07 23:34:45 -04:00
Jon Evans c9040a5c53 PNS: fix some weirdness identified by PVS 2021-04-07 23:16:56 -04:00
Jon Evans e0f26fd525 Make live 3D refresh optional 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8068
 2021-04-07 22:39:30 -04:00
Jon Evans d4957b112e PNS: Keep last valid drag solution in the node 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5450
 2021-04-07 21:59:23 -04:00
Jon Evans 26835f582c Some situations require more than one dummy 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7820
 2021-04-07 21:30:18 -04:00
Jon Evans 9432484394 PNS: Find origin segment correctly when arcs are present 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8139
 2021-04-07 20:28:30 -04:00
Ian McInerney 18f07024a6 Simplify UI event handling in pcbnew global edit dialogs 
Instead of enabling/disabling the controls on every possible
UI event in these dialogs, only do it when the actual control
wants to know if it should change status.
 2021-04-07 17:39:48 +01:00
Ian McInerney 1a727558b0 Switch update event handlers to use the event instead of pointers 
It is safer to use the event to pass the enable/string
instead of pointers, since using the pointers could trigger
other UI events.
 2021-04-07 17:39:48 +01:00
Ian McInerney 29cc16a4c4 Push pcbnew layer alpha change update into base frame 
This code was shared between the footprint frame and
pcb edit frame, so push it into the base edit frame.
Also remove the dummy wxUpdateUIEvents that weren't
actually being used.
 2021-04-07 17:39:48 +01:00
Jeff Young 3fd3be9843 Layer fixes for PCBNew drawing tools. 
1) Implement layer changes for dimension drawing tool
2) Ensure drawing layer is visible for (1) and for the text drawing
tool.

Fixes https://gitlab.com/kicad/code/kicad/issues/8106
 2021-04-07 15:02:48 +01:00
Jeff Young e50b450092 Formatting and organisation. 2021-04-07 14:50:29 +01:00
Roberto Fernandez Bautista 85efdb85b0 CADSTAR PCB: Ensure continuous track routes 
When route offsetting, add an additional thin track to ensure
end point of one track and start point of the next are at the same
location.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8131
 2021-04-07 11:28:02 +00:00
Roberto Fernandez Bautista 211fd65c23 Move: Ignore mouse up and click events until a mouse move / drag event 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8123
 2021-04-06 17:29:52 +00:00
Jeff Young 09b2db3139 Test for group in footprint was snagging all footprint children. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8121
 2021-04-06 18:27:43 +01:00
Jon Evans 9f957d3e08 Fix crash when attempting to tune discontinuous lines 
Also correctly find the tuning path through arcs

https://gitlab.com/kicad/code/kicad/-/issues/8131
 2021-04-06 09:07:11 -04:00
Roberto Fernandez Bautista 235688e459 Less restrictive Arc Track Dragging tool 
Use the connecting straight tracks even if not exactly parallel - allow
an error margin configurable in ADVANCED_CFG (default 1 degree). Also
be less strict about end point matching and use the width of the track
as the criteria to determine suitability.

Finally, delete any short lengths of track at the end of the operation
and amend the arc end points to keep connectivity.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/7967
 2021-04-06 12:52:01 +00:00
Roberto Fernandez Bautista 0a2c8575ce ZONE properties: stage commit even if !Settings().m_AutoRefillZones 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8028
 2021-04-06 12:52:01 +00:00
Jeff Young 69fd0b38ff Remove a couple of unused OnUpdateUI handlers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5049
 2021-04-06 13:47:15 +01:00
Jeff Young daaf738c7f Add save-as files to file history. 
Also fixes where lock wasn't getting reset on a Save As.

Fixes https://gitlab.com/kicad/code/kicad/issues/8111
 2021-04-06 13:35:26 +01:00
david-beinder b2f788adc1 PNS: Fix UseConnectedTrackWidth when starting from ARCs 2021-04-06 01:27:13 +00:00
Jon Evans e46c9d35ac Add undo/redo handling to length tuner event loop 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8129
 2021-04-05 19:58:14 -04:00
Jon Evans 24cd174a23 Don't dereference a possibly-invalid optional 2021-04-05 19:34:57 -04:00
Jeff Young ec45855aed Make sure drawing layer is visible. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8106
 2021-04-06 00:06:23 +01:00
Roberto Fernandez Bautista 9a764126ce CADSTAR PCB: Keep all tracks as a single chain where possible 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8119
 2021-04-05 20:15:09 +01:00
Jon Evans a6c3d74a73 Pass active layer to StartRouting in length tuner 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7857
 2021-04-04 21:51:54 -04:00
Jon Evans a24bc34b66 Better colors for length tuning popup in dark mode 2021-04-04 20:33:59 -04:00
Jon Evans c7ecb51f77 Update PNS length tuning algorithm to match the new BOARD algorithm 
Now tracks inside pads are optimized to give a more accurate length.
Also, the start/end of the assembled line is used to identify the right
pad joints for pad-to-die length calculation.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/4204
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1765
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6877
 2021-04-04 20:27:22 -04:00
Jon Evans 41c54d383e Fix some edge cases with length calculation 2021-04-04 19:38:54 -04:00
Jon Evans cdfb014ab6 CHANGED: Account for via height in track length calculations 2021-04-04 13:59:18 -04:00
Jon Evans 80728f8d78 Improve algorithm for calculating net length; use it for netinfo message panel 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4258
 2021-04-04 12:27:09 -04:00
Jon Evans 6b24abac8f PNS: Don't snap to end items if snapping is disabled by modifier key 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8033
 2021-04-04 10:22:23 -04:00
Jeff Young 52ca7ed27c Naming conventions. 2021-04-04 10:43:56 +01:00
Jeff Young c1df77f59b Terminology. 2021-04-04 10:32:24 +01:00
Jeff Young 98e6a089ab Treat board edges same as graphics for locked/unlocked. 
It would appear that not using the locked/unlocked graphics filters
is confusing too (see deleted comments in code).

Fixes https://gitlab.com/kicad/code/kicad/issues/8114
 2021-04-04 10:27:26 +01:00
Jeff Young 2c3ee0d85f Don't forget CommitPendingChanges. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8083
 2021-04-04 01:02:31 +01:00
Ian McInerney 83ae28f04f Fix selection when pasting/duplicating items 
The item flags weren't getting reset after placing
the new items, so the next operation on them was
having weird behavior.

Fixes https://gitlab.com/kicad/code/kicad/issues/7528
 2021-04-03 19:09:21 +01:00
Carsten Schoenert cb17c9f3dd Typo fix: Correct various misspelled words 
agressive -> aggressive
decription -> description
miscellanous-> miscellaneous
rectange -> rectangle
Unkown -> Unknown
 2021-04-03 13:39:50 +00:00
Carsten Schoenert 8dff3725ac Typo fix: Correct 'allow to' -> 'allows one to' 2021-04-03 13:39:50 +00:00
Jeff Young 52aea0a2c9 Consistent terminology. 2021-04-03 11:15:11 +01:00
Jeff Young c5536b2cab Title case in menus. 2021-04-03 11:15:11 +01:00
Mikolaj Wielgus aa09d6448a Pcbnew: Allow Create Array on groups 
Also removes possible null pointer dereferencing.

Fixes https://gitlab.com/kicad/code/kicad/issues/7515
 2021-04-03 09:06:49 +00:00
Jon Evans a8896ebd73 Don't show leading ratline for unconnected net 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8040
 2021-04-02 20:29:25 -04:00
Mikolaj Wielgus d7a95e2af4 Rotate FP_TEST properly when flipping 
The angle was `-angle` instead of `180 deg - angle` when flipping top to
bottom.

Fixing that, in turn, created some problems with justification, which
was modified both by `FP_TEXT::Flip()` and `FP_TEXT::KeepUpright()`.

What's worse, `FP_TEXT` has another mechanism for keeping the text
upright: `FP_TEXT::GetDrawRotation()` returns different angles if the
"keep upright" flag is set. But there is no analogous behavior for
justification, so the text would sometimes get shifted, and sometimes
not, depending on which mechanism was engaged. And both are used,
apparently.

Clearly, such an arrangement an open invitation to bugs and
inconsistencies. One of these mechanisms should be removed. I haven't
done this yet, and would prefer to postpone this until V6 is out.

I've fixed the justification problems, but this was by trial-and-error,
and I don't feel I really understand the behavior responsible. But I
think it's a good sign that most of my changes are line removals, not
additions. Flipping is a simple operation, it's just mirroring and layer
change. If something simple has a complicated routine, then it's
probably full of hacks.

Fixes https://gitlab.com/kicad/code/kicad/issues/7289
 2021-04-02 21:13:21 +00:00
Mikolaj Wielgus 0a660c2364 Pcbnew: Remove 180 deg rotation when flipping PCB_TEXT in some cases 2021-04-02 21:13:21 +00:00
Mikolaj Wielgus 99fd872fce Pcbnew: Do not move footprint fields twice in align/distribution tools 
Fixes https://gitlab.com/kicad/code/kicad/issues/8094
 2021-04-02 21:09:36 +00:00
Mikolaj Wielgus 7655533412 Do not move footprint fields twice when performing Move Exactly 
Fixes https://gitlab.com/kicad/code/kicad/issues/8062
 2021-04-02 21:07:59 +00:00
Ian McInerney 1931677316 Ensure the layer dropdowns are correctly sized 
On GTK, the layer dropdown was sized based on an empty list,
so for non-default fonts it would be undersized and cutoff
the font.
 2021-04-02 21:33:31 +01:00
Ian McInerney 1db5e2bc96 Don't force an entire refresh of toolbars to update sizes 
Forcing an entire refresh of the toolbars is wasteful,
so instead just update the sizers directly.
 2021-04-02 19:12:21 +01:00
jean-pierre charras d3bf20e80b Pcbnew, place free via: take netcode from the pad, if the via is inside a pad. 
Fixes #8089
https://gitlab.com/kicad/code/kicad/issues/8089
 2021-04-02 17:19:44 +02:00
Jeff Young f88d39b4f0 Fix state issue in router's switch layer handling. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7590
 2021-04-01 18:10:04 +01:00
Jeff Young f6f31b7654 Get rid of save warning after Footprint Editor Save As. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8084
 2021-04-01 11:17:24 +01:00
Jeff Young 94470bfa15 Minor cleanup. 2021-04-01 11:10:01 +01:00
Jeff Young 0c4184f1a4 Split lib tree initialization into a two-pass affair. 
This is under the supposition that we can't set the column widths
on some Mac instances because the host controls haven't yet been
created.  This is primarily conjecture based on looking at things
that have the *possibility* of going wrong.  Why this only happens
in some installs is beyond me.

Fixes https://gitlab.com/kicad/code/kicad/issues/5479
 2021-04-01 10:51:29 +01:00
jean-pierre charras 90abc8ba8b Excellon drill files: slightly change comments inside files 2021-04-01 07:38:00 +02:00
Jeff Young b6f2941a06 Another try a allowing touching courtyards. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8076
 2021-03-31 22:54:30 +01:00
Roberto Fernandez Bautista a530c22eff Shorten "Allow free pads" tooltip and rename button "Skip Locked Items" 2021-03-31 18:28:18 +00:00
Roberto Fernandez Bautista 7077e59395 Make moving pads independent of footprint much harder with new setting 
It is still possible to move a pad independent of footprint through
the pad properties dialog. This is a much more conscious decision
than using the move tools.

ADDED: "Allow free pads" preference setting in pcbnew, default to off.
When enabled, allows moving unlocked pads independent of the footprint
(i.e. previous behaviour). When disabled (default), any attempt to move
a pad will move the parent footprint instead.

REMOVED: "Lock pads of newly added footprints" preference setting in
pcbnew. (Pad lock state is now loaded from the footprint definition)

CHANGED: There are now only two possible lock states for a footprint:
locked and unlocked. The lock state of the pads in the footprint is
now independent of the footprint lock state.

Also fixed a latent bug that would allow a pad to be moved when the
parent footprint was locked (see m_selectionTool->RequestSelection
lambdas in edit_tool.cpp)

Fixes https://gitlab.com/kicad/code/kicad/-/issues/7739
 2021-03-31 18:28:18 +00:00
Jeff Young 737262ffa8 Allow touching courtyards. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8076
 2021-03-31 10:44:59 +01:00
Ian McInerney 0a0935e0f3 Remove ACTIONS::TranslateLegacyId and TOOL_DISPATCHER::DispatchWxCommand 
After commit 9535153f9e there were no more IDs inside the legacy ID
system. Therefore the entire system for dispatching and looking up
the legacy ideas and handling those events can now be removed and
the tool dispatcher simplified (it no longer needs to know about
the ACTIONS class).
 2021-03-30 23:20:22 +00:00
Jeff Young 8cb6f15687 Warn when diff pair router can't start due to too-small-gap. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7795
 2021-03-30 19:49:23 +01:00
Roberto Fernandez Bautista b151dd02b9 CADSTAR PCB: Fix incorrect solder mask/paste clearance 
Need to divide by two as this is a clearance, not diameter.
 2021-03-30 13:03:56 +00:00
Roberto Fernandez Bautista ad2043eda6 CADSTAR PCB: DrillXoffset and DrillYoffset are zero when not specified 
Fixes an issue that resulted in pads being loaded 100nm off from the
original CADSTAR position.
 2021-03-30 13:03:56 +00:00
jean-pierre charras 6eb2e2a6e3 Fp editor: do not change item UUIDs when loading a footprint from library. 
Fixes #8066
https://gitlab.com/kicad/code/kicad/issues/8066
 2021-03-30 12:58:22 +02:00
Jon Evans 78a60e9dfb PNS: Put polygon error outside pad shapes 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7672
 2021-03-29 19:49:59 -04:00
Jon Evans 6cbc3fb97d Fix a minor inconsistency between router and DRC 
Also make sure collision highlighting runs at the starting
location of a drag.

See: https://gitlab.com/kicad/code/kicad/-/issues/7672
 2021-03-29 19:41:17 -04:00
Jon Evans 8be9832153 PNS: Don't highlight Net 0 (the unconnected net) 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8040
 2021-03-29 17:45:07 -04:00
Wayne Stambaugh 38c849bde7 Pcbnew: load write board netlist to file tool action dynamically. 
Loading this advanced configuration option statically will cause it to
show up in the hotkey list even when the option is disabled. Creating
the tool action at run time resolves this issue.
 2021-03-29 09:04:55 -04:00
jean-pierre charras 3c51964c57 drill report: use more digits in float values for diameters. 
(Use same resolution in map and rpt files)
 2021-03-29 13:02:43 +02:00
Jeff Young f2e68e68d0 Add "Hide Tree" context menu options when tree has no selection. 
Also cleans up some other code to be more consistent between symbol
editor and footprint editor.

Fixes https://gitlab.com/kicad/code/kicad/issues/8052
 2021-03-29 12:02:00 +01:00
Wayne Stambaugh 6d2f80b4cf Pcbnew: add write board netlist to file support. 
This is hidden behind an advanced configuration setting and is primarily
useful for developers trying to troubleshoot the netlist payload sent
from the board editor to the schematic editor.

Fixes https://gitlab.com/kicad/code/kicad/issues/8051
 2021-03-28 08:38:29 -04:00
Ian McInerney 475ac3697f Ensure toolbar controls have the correct width on frame creation 
Otherwise they could be slightly too small and then look odd.
 2021-03-28 13:07:56 +01:00
Jon Evans d0d6352a25 Fix crash launching footprint editor frame 
Apparently we get this event before the frame is fully-baked
 2021-03-27 23:48:07 -04:00
Ian McInerney 42c6af4bd8 Cleanup ACTION_MENU creation in some places 
The ACTION_MENU constructor now takes the tool as an argument,
so the call to SetTool() immediately following it can be removed
and the tool just passed into the constructor.
 2021-03-27 19:16:58 +00:00
Ian McInerney 9535153f9e Move the import graphics menu item to the action 2021-03-27 19:04:16 +00:00
Ian McInerney 7bfa8575fa Remove redundant information from import/export menu item labels 
Saying "Import/Export" on the labels when the submenu has "Import"
or "Export" in it is redundant.

Note that we can't just update the action text with the new name,
because that is used in the hotkey list and would become too confusing
without the "Import"/"Export" text.
 2021-03-27 18:50:35 +00:00
Konstantin Baranovskiy eb8744816e pcbnew: fix the i18n of the rules syntax help 2021-03-27 16:26:13 +00:00
Ian McInerney f6041fb52d Force update of some text when activation status changes 
The text areas aren't always redrawn when the window is activated
or deactivated, so we need to force a refresh of the text to ensure
it is the correct font color.
 2021-03-26 15:50:56 +00:00
jean-pierre charras d18323dcf0 Excellon file writer: remove not very useful comments outsider the header section. 
Looks like comments outside header section can create problems in some readers.
Note: comments inside header section are clearly allowed in Excellon file format)
(trial to fix bug 8032)
 2021-03-26 09:46:32 +01:00
Jon Evans 132ec37b56 Handle arc in buildHullForPrimitiveShape 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8008
 2021-03-25 21:25:30 -04:00
Roberto Fernandez Bautista 34a435cd56 CADSTAR PCB: Handle import of pads with different paste and mask sizes 
KiCad doesn't yet support full padstacks, but at least we can use the
solder mask / solder paste expansion to import a better result. Also
we can disable the specific layer if the shape has a size of zero.
 2021-03-25 17:54:56 +00:00
Roberto Fernandez Bautista 107a1990c9 CADSTAR PCB: Handle route offset 
The CADSTAR post processor has a peculiar feature called "route offset"
which effectively shortens tracks when the pad, track or via that it
connects to has a smaller width. This operation is not saved in the
design itself, but applied as a post processing operation meaning that
the importer has to apply it when loading on the board.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/6648
 2021-03-25 17:50:33 +00:00
Roberto Fernandez Bautista 1468764f83 CADSTAR PCB: Lock footprint pads after import 2021-03-25 17:50:33 +00:00
Jeff Young 3279e295ac Don't start filling zones with possibly stale caches. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8014
 2021-03-25 17:20:08 +00:00
Jeff Young a2ffb45698 Update diff pair rule syntax to be clearer. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8010
 2021-03-25 10:29:38 +00:00
jean-pierre charras bbd7b4ca8c Eeschema, selection tool: uniformize the cursor shape and the actual modifiers. 
SHIFT, CTRL, ALT modifier keys were handled in 2 different codes, one for
the selection tool and another to modify the mouse cursor shape, with 2
different configs.
Now the modifiers are managed from only one function.
Pcbnew: group also SHIFT, CTRL, ALT modifier keys management to a specific function.
Fixes #8021
https://gitlab.com/kicad/code/kicad/issues/8021
 2021-03-25 10:28:20 +01:00
jean-pierre charras 9a0f9575b6 Fix minor Coverity warnings 2021-03-25 09:12:24 +01:00
firebladed 41839f7e3f Update panel_setup_rules_help.md diff pair clearance example to use new A.isCoupledDiffPair() function 2021-03-25 03:33:19 +00:00
Jon Evans cb722c6bfa Code style 2021-03-24 18:11:32 -04:00
qu1ck 75819206a0 Add support for dark theme in plugin icons 
Action plugin authors can specify alternative icon path for dark theme.
If it's not specified then standard icon will be used for both light and
dark themes. If neither icon is specified then the default puzzle piece
icon is used.

Fixes #7984
 2021-03-24 21:59:30 +00:00
Wayne Stambaugh b37b7d53b4 Fix geographic annotation bug when back annotating to schematic. 
For some reason, the footprint UUID was being prefixed to the sheet path
which caused the symbol look up by sheet path to fail.  An option was
added to not do this when the geographical back annotation to the schematic
is performed.
 2021-03-24 09:57:36 -04:00
Marek Roszko e409b04538 More gracefully handle tinyspline not liking a spline definition 
Partial fix for #6634
 2021-03-24 00:37:01 -04:00
Jon Evans f57dcf2a34 Fix connectivity to only resolve conflicts on netlist load 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8007
 2021-03-23 17:43:24 -04:00
Jeff Young a94ce75c02 Fix multiple filter calls that were producing false cache positives. 
When processing a compound shape we'd decide the first of them didn't
collide and then put false into the cache.  The cache value would then
be used for all the other shapes in the compound shape, which very well
might actually collide.

Fixes https://gitlab.com/kicad/code/kicad/issues/8003
 2021-03-23 21:06:16 +00:00
Ian McInerney a94a481574 Fix compile warnings 
Some simple warnings and also a deprecation warning from wx
because they felt that a function should be renamed...
 2021-03-23 19:46:49 +00:00
Jon Evans 4dbeb15024 Use a worker thread to send socket commands 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6503
 2021-03-23 03:20:40 +00:00
Jon Evans 381cc27548 Add missing include 2021-03-22 21:25:03 -04:00
Jeff Young 49b1aceb8b Handle doc urls enclosed in parens. 
It seems this has become a common pattern in at least some of our
libraries.

Fixes https://gitlab.com/kicad/code/kicad/issues/7963
 2021-03-22 21:20:54 +00:00
Jeff Young f24f0d93a5 Make OK default in inspectors (and hook up to close window). 
Fixes https://gitlab.com/kicad/code/kicad/issues/7831
 2021-03-22 21:20:54 +00:00
Jonathan Haas a677998f47 Don't select new items after cancelling move following item duplication 
Fixes https://gitlab.com/kicad/code/kicad/issues/7956
 2021-03-22 18:49:43 +01:00
Jon Evans 9ce34102af Make sure projects get created for boards migrated from 5.x 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6886
 2021-03-21 16:21:44 -04:00
Jeff Young 8be213e36f Trim includes (and use consistent terminology in error messages). 2021-03-21 20:15:47 +00:00
Roberto Fernandez Bautista a9eb83201e Remove ZONE::ClearFilledPolysList() and fix ZONE::Unfill() 
ClearFilledPolysList is redundant and Unfill() was missing the clearing
of m_insulatedIslands

This fixes potential latent bugs in zone unfilling.
 2021-03-21 20:13:20 +00:00
Roberto Fernandez Bautista 50aafb9d2a Do not auto-refill zones when added or edited 
The only exception is when using the Zone Properties Dialog and
user preference is enabled
 2021-03-21 20:13:20 +00:00
Roberto Fernandez Bautista 7a255edc5f Panel Edit Options: Fix "Show Page Limits" tooltip message 2021-03-21 20:13:20 +00:00
Roberto Fernandez Bautista f6c4677189 ADDED Option to disable automatic zone filling in pcbnew 
The new setting is stored as 'editing.auto_fill_zones' and controls
whether zones should be refilled after certain actions or not.
 2021-03-21 20:13:20 +00:00
Roberto Fernandez Bautista a743e0c52b Add Zone fill to undo stack 
Allows undoing zone filling and reverting to previous fill state.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7440
 2021-03-21 20:13:20 +00:00
Jon Evans 5e0b65c3a8 Change wording of corner rounding action 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4505
 2021-03-21 15:55:56 -04:00
Jon Evans 37242f67e0 Connectivity: just pick the most popular net to update conflicting clusters 
CHANGED: when pad net assignments are changed in a conflicting way (i.e.,
         tracks exist that short out more than one net after the change,
         track nets will be updated to the net with the most pads).

Fixes https://gitlab.com/kicad/code/kicad/-/issues/7929
 2021-03-21 15:31:37 -04:00
jean-pierre charras f0ed5fab39 add missing include for wxWidgets 3.1.4 2021-03-21 17:35:20 +01:00
Jon Evans e1840ccbd3 Handle exceptions thrown by footprint library table 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7973
 2021-03-21 11:43:24 -04:00
Thomas Pointhuber 68f3d09ac1 altium: introduce tokenizer for query language 
Based on this tokenizer, a LL1 parser will be built in the future.
 2021-03-21 16:39:23 +01:00
Jeff Young fe196771d8 Implement isCoupledDiffPair() DRC rule function. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7975
 2021-03-20 23:07:36 +00:00
Jeff Young 44e2151ade Allow diffpair gap to override netclass clearance value. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7975
 2021-03-20 21:53:30 +00:00
Jeff Young ce46fe6581 Add insideFrontCourtyard and insideBackCourtyard DRC functions. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7972
 2021-03-20 21:53:30 +00:00
Jeff Young 07aea4339d Formatting. 2021-03-20 21:53:29 +00:00
jean-pierre charras 4a53917efa wrml exporter: optimize circle to segment approximation. 2021-03-20 18:16:58 +01:00
Jon Evans f1c599fa4d Tweak PCB selection behavior to reduce unintuitive behavior 
We were discarding shapes too aggressively for having a
larger area than a shape underneath.

Let's also try showing fewer disambiguation menus, in particular
always preferring items on the active layer when the candidates
include overlapping items of similar area on other layers.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/7949
 2021-03-20 13:11:51 -04:00