haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
42,415 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

16727 Commits

Author SHA1 Message Date
jean-pierre charras 4a945172db Pcbnew: do not select a PCB_REFERENCE_IMAGE if the LAYER_DRAW_BITMAPS is not visible. 
LAYER_DRAW_BITMAPS layer controls transparency and visibility of images on the board.
Fixes #16282
https://gitlab.com/kicad/code/kicad/-/issues/16282
 2024-03-04 11:46:45 +01:00
Seth Hillbrand 02cdb0c6b9 Mask aperture pads can have multiple layers 
But as long as they don't have copper, we should treat them as mask
apertures
 2024-03-03 20:56:39 +00:00
Alex Shvartzkop 85b1978408 Use 64-bit type to represent microseconds. 
int and long are 32-bit on Windows, causing overflows.
 2024-03-03 21:40:26 +03:00
Wayne Stambaugh 3eb5c52073 Improve zone manager dialog layout. 2024-03-03 12:09:01 -05:00
JamesJ 66b378087a Remove close button from pcbnew search panel 
For consistency with the other panels, removes the circular 'x' close
button from the search panel. Toggling visibility remains possible
through the View menu
 2024-03-03 16:18:23 +00:00
Marek Roszko 0c8e08ed58 Move some language changes to a event on the frame 2024-03-03 11:02:26 -05:00
jean-pierre charras 0bde79bd6c PCB_PAINTER: do not draw PCB_SHAPEs on netname layer in FP editor. 
Fixes #17250
https://gitlab.com/kicad/code/kicad/-/issues/17250
 2024-03-03 17:00:17 +01:00
Yon Uriarte fe1c73ed7c Performance: Cache BOARD::GetMaxClearanceValue 2024-03-03 13:54:46 +00:00
jean-pierre charras f6cf78fd7c plot_board_layers.cpp: when plotting pads, Save/restore corner radius ratio 
instead of corner radius.
The corner radius comes from corner radius ratio, so saving/restoring the corner
radius can create rounding errors when trying to recalculate the ratio from the radius.
 2024-03-03 11:56:41 +01:00
Jon Evans ed18a9bcc2 Correctly handle footprint graphic knockouts for no-net case 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17223
 2024-03-02 15:39:07 -05:00
Jon Evans 3a3ceb8ffc Allow specifying a minimum for a via_count constraint 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17234
 2024-03-02 15:26:28 -05:00
Roberto Fernandez Bautista a4929f9c27 Step exporter: handle circles correctly 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17137
 2024-03-02 19:09:33 +01:00
Roberto Fernandez Bautista d458bcad16 kicad_cli fp ugrade: create directory with extension 2024-03-02 18:21:13 +01:00
jean-pierre charras d81605f4ea DIALOG_PAD_PROPERTIES: fix a incorrect test to show a warning. 2024-03-02 17:16:27 +01:00
Roberto Fernandez Bautista 4508512343 Sanitise filename before saving footprint library 2024-03-02 13:06:23 +01:00
Roberto Fernandez Bautista a4a99e3aff kicad_cli: Allow upgrade of legacy and non-kicad footprint libraries 2024-03-02 13:06:23 +01:00
Jeff Young bd1d449cd3 Check for NETINFO_ITEM before dereferencing it. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17230
 2024-03-02 11:37:22 +00:00
jean-pierre charras 1ee49cca5e FOOTPRINT_CHOOSER_FRAME: rework on bottom panel to allow a long string in 
the check box for filter by FP names to be displayed without overlapping other
widgets.
 2024-03-02 11:24:54 +01:00
Jan Wichmann 1297ddc88d pcbnew: Added default master pad properties 
CHANGED: Automatically selects the right pad type for the footprint type. Resets the pad properties if the master pad properties do not match the pad type.

https://gitlab.com/kicad/code/kicad/-/issues/16563
 2024-03-02 00:13:39 +00:00
Seth Hillbrand 0129191ec0 Limit where the intersection of two lines can be 
This avoids generating lines where we are unable to select them because
they get too close to the border

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16959
 2024-03-01 15:57:24 -08:00
Jeff Young 8dddd9cc2c Separate "use board stackup colors" into separate checkbox. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17085
 2024-03-01 23:45:06 +00:00
Seth Hillbrand 14667e2033 Don't wait for unused events 
We only need the UI update and mouse/keyboard while updating our DRC
window.  Waiting for other events gets into a race condition with the
schematic editor that can cause a hang

Fixes https://gitlab.com/kicad/code/kicad/-/issues/17003
 2024-03-01 15:21:42 -08:00
Seth Hillbrand d3334ed9f0 Do not re-number aperture pads 
Aperture pads do not have numbers, so reserving space for them will
cause the actual numbered pads to become out of order
 2024-03-01 13:04:19 -08:00
jean-pierre charras 005affd473 FOOTPRINT_CHOOSER_FRAME: Fix a UI problem specific to Linux 
On the bottom on the frame, some widgets were not correctly placed.
Fixes #17217
https://gitlab.com/kicad/code/kicad/-/issues/17217
 2024-03-01 19:56:22 +01:00
Ethan Chien 8d19d27483 Fix zone manager crash when no board is loaded 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17187
 2024-03-01 15:58:01 +00:00
Alex Shvartzkop defcb49ac8 Support Altium Schematic ASCII import 2024-02-29 20:49:20 +00:00
aris-kimi 24529e5242 ADDED: library tree context menu option to open sym/fp library files from the defined text editor. 
Short description:

Works for Symbol and Footprint Editor behind an advanced config option.
For Symbol Editor it is shown for a single item selection (library or symbol).
For Footprint Editor it is shown for a footprint selection.
(fp editor allows a single tree item selection only).
Option stays hidden if current frame has been modified.

Also small fix(?) for similar action to the project manager.
(Call for the Execution has moved inside the file loop.)

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15736
 2024-02-29 19:01:59 +00:00
Jeff Young c23550dc0b Unflip when going to viewport which isn't flipped. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13773
 2024-02-29 17:37:48 +00:00
Alex Shvartzkop 39a0a81832 EasyEDA Std import: support multiline text on PCB. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17171


(cherry picked from commit 0dab086f0c)
 2024-02-29 00:54:46 +00:00
JamesJ b8748c4ef8 Add import netclass color menu items to PCB appearance widget 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16908

ADDED: Context menu item in PCB appearances widget to import netclass
color from schematic.
ADDED: Context menu item to reset PCB netclass color (replicating
same menu item from Nets inspector)
 2024-02-28 23:13:15 +00:00
Jeff Young 141de7ac11 Even up spacing in dialog. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16391
 2024-02-28 22:18:27 +00:00
Seth Hillbrand 6a8d2a7eb3 Store group id rather than group 
We only need the group storage id for lookup.  Storing the KIID instead
of a copy of the group avoids unneeded overhead

Fixes https://gitlab.com/kicad/code/kicad/-/issues/17175

(cherry picked from commit 7d1adff071)
 2024-02-28 13:27:38 -08:00
Jeff Young 27031dd2c5 Check env vars when testing for unresolved variables. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17174
 2024-02-28 17:16:58 +00:00
Jon Evans 9e7b4b7f89 Avoid nullptr dereference when loading group info 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17154
 2024-02-27 19:43:21 -05:00
Jon Evans 0df5cf7f75 Expose grid origin action in more places 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17007
 2024-02-27 18:50:44 -05:00
Seth Hillbrand a8880fb63e Fix memory leak in net inspector dialog 2024-02-27 19:49:13 +00:00
Seth Hillbrand b2a25cb59e Correct usage signature for PNS_NODE::Add() 
When moving a unique_ptr, you are actually passing the object, not a
reference to the object.  So we either std::move with the bare
unique_ptr parameter or we pass a reference.  But we should never pass
an rvalue reference for this or we'll make a copy without holding the
tracking (because it was moved)

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16839
 2024-02-27 19:49:13 +00:00
Jeff Young e6a2f3b87a Eagle text anchor points and alignment aren't linked. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17135
 2024-02-27 15:00:30 +00:00
Jeff Young 6e478f52f4 Fix wrong rotation centre. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17135
 2024-02-27 15:00:27 +00:00
jean-pierre charras ed4a4ec8ec Add option to Footprint Chooser to switch between the selected fp or its 3D view 
Fixes #16173
https://gitlab.com/kicad/code/kicad/-/issues/16173
 2024-02-27 10:17:00 +01:00
Jeff Young 43c45f3ee8 Fix copy pasta. 2024-02-26 12:39:01 +00:00
Jon Evans 2f6c9d1f3a ADDED: Selection filter for schematic editor 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14988
 2024-02-25 17:44:10 -05:00
Jeff Young 11774cc9fe Fix some dialog layout issues. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16391
 2024-02-25 22:10:51 +00:00
Jeff Young 9066e4b9d0 Reconcile solder_paste_ratio and solder_paste_margin_ratio. 2024-02-25 21:25:44 +00:00
Jeff Young aef87b9796 Push thickness handling down into EDA_TEXT::SetBold(). 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17077

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14875
 2024-02-25 17:28:52 +00:00
Jeff Young be83f276c4 Add a couple more tooltips. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16391
 2024-02-25 15:30:47 +00:00
Jeff Young dba2fdb6d3 Don't import invalid polygons. 
If we *do* get a 2-point polygon in SVG, import it as a segment.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/17091
 2024-02-25 12:28:19 +00:00
Jeff Young 4056428a08 Sigh. We use different tokens for FP and pad solder paste margin ratios. 
Seriously?  Afraid so: solder_paste_margin_ratio and solder_paste_ratio.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/17108
 2024-02-25 11:31:04 +00:00
Jeff Young 986dbfd235 Don't double-add pads to commit. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17087
 2024-02-25 11:31:04 +00:00
Jeff Young 6bbac26fd3 Fix merge conflict. 2024-02-24 20:05:51 +00:00
Jeff Young e27f859c11 Apply Pad Properties teardrop terminology to Via Properties. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17050
 2024-02-24 20:05:51 +00:00
Jeff Young f77de66f4e Generalize ERCItem inspections. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10539
 2024-02-24 20:05:51 +00:00
Jeff Young fa0ead98d8 Split out table editing and table cell editing. 2024-02-24 20:05:51 +00:00
Jeff Young 3282e4bb66 Formatting. 2024-02-24 20:05:51 +00:00
Jeff Young c3496e4af6 Implement min skew checking. 2024-02-24 20:05:51 +00:00
Jeff Young 782af3a918 Clear text before replacing in ImportSettingsFrom. 2024-02-24 20:05:51 +00:00
Jeff Young e760317af6 ADDED: Implement footprint link checking in ERC. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16842
 2024-02-24 20:05:51 +00:00
Jeff Young 6dc60598da Cleanup array dialog. 2024-02-24 20:05:51 +00:00
Jeff Young d7e4a8cebd ADDED: ERC/DRC exclusion comments. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16020
 2024-02-24 20:05:51 +00:00
Jeff Young 833ec402a0 Generalize DRCItem inspections. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10539
 2024-02-24 20:05:51 +00:00
Jeff Young 4eefbc7815 ADDED: textbox and tablecell margins. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10672

Fixes https://gitlab.com/kicad/code/kicad/-/issues/6806
 2024-02-24 20:05:51 +00:00
Jeff Young e445249720 ADDED: PCB tables. 2024-02-24 20:05:51 +00:00
Jeff Young 48f983826d Tooltip for "Prefer zone connections". 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16587
 2024-02-24 20:05:51 +00:00
Jeff Young 67cd446e6d Add textbox text to description. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16573
 2024-02-24 20:05:51 +00:00
Jeff Young ee3be0802c Move PCBNew overrides to nullable properties. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5562
 2024-02-24 20:05:51 +00:00
Jeff Young 4c5dbcd7f4 ADDED override locks checkbox for update from schematic. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16471
 2024-02-24 20:05:50 +00:00
Jeff Young 4a9df1e18e ADDED: actions for left-, center-, and right-justifying text items. 
(For both PCBNew and EESchema.)

Fixes https://gitlab.com/kicad/code/kicad/-/issues/12375
 2024-02-24 20:05:50 +00:00
Stefan ed6f900b70 adding No Layers to apprearance manger presets, fix #15625 2024-02-24 15:44:26 +00:00
Alex Shvartzkop 6347cb043e Add bottom panel to have correct background in fp/sym chooser frames. 
See https://gitlab.com/kicad/code/kicad/-/issues/15810

(cherry picked from commit 97ff48b426)
 2024-02-24 18:20:16 +03:00
Alex Shvartzkop 5578b2c954 Hide unused message panel in footprint/symbol chooser frames. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15810
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15889

(cherry picked from commit badc4e7411)
 2024-02-24 18:20:16 +03:00
Ethan Chien d72491a4a5 ADDED: zone manager 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9636
 2024-02-24 15:10:50 +00:00
Alex Shvartzkop 5900f6baa4 Do not call MakeShapes in AddCopperPolygonShapes when polyset is empty. 
Ease of debugging.

(cherry picked from commit 0184dfb625)
 2024-02-23 22:15:17 +03:00
Alex Shvartzkop d04d74c511 Highlight nets and show length tuning status when adding tuning patterns. 
Also fixes length preview when hovering over joints.
Also prevents asserts when hovering over arcs.
Also prevents adding a tuning pattern on other tuning pattern.

(cherry picked from commit 711c6141a8)
 2024-02-23 20:29:18 +03:00
Jeff Young c3bcbb6238 Update Edit Teardrops dialog to match other teardrop terminology. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17050

(cherry picked from commit c8b06d54cb)
 2024-02-23 16:53:36 +01:00
Jeff Young dfd97003ac Rule areas should be allowed on user layers. 
Non-board tech layers too.  We don't know how people will
write their custom DRC rules.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/17034

(cherry picked from commit 01d668c09d)
 2024-02-23 16:53:34 +01:00
Jeff Young 7b17646b71 Make sure nets get reassigned when name is changed. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17025

(cherry picked from commit f4a3613561)
 2024-02-23 16:53:34 +01:00
Jeff Young 5c026db27a Report fp library loading errors with libName & fpName. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16975

(cherry picked from commit 12922d9434)
 2024-02-23 16:53:34 +01:00
Jeff Young ca3cd706e5 Show friendly name in toolbar button tooltips. 
(Don't require the same text to be put into the tooltip.
It's error-prone and also disallows us from having a separate
tooltip for toolbar buttons.)

Fixes https://gitlab.com/kicad/code/kicad/-/issues/17009

(cherry picked from commit f4a085575a)
 2024-02-23 16:53:33 +01:00
Jeff Young a156b49e2c Comments. 
(cherry picked from commit 8a3cbce8f8)
 2024-02-23 16:53:33 +01:00
Jeff Young 3938c35f17 Repair copy/paste of footprint fields. 
Some of the code got lost in the move to PCB_FIELDs.

(cherry picked from commit a9c4a17c38)
 2024-02-23 16:53:33 +01:00
Jeff Young e7f18e7eab Warp after context menu only if actively drawing. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11080

(cherry picked from commit 1a7152d3eb)
 2024-02-23 16:53:32 +01:00
Jeff Young e68cd04d48 Don't modify reference point if already moving. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16524

(cherry picked from commit 08da9a4494)
 2024-02-23 16:53:32 +01:00
Jeff Young 898f60ea2f Add help text for DRC assertion clauses. 
(cherry picked from commit d36f189192)
 2024-02-23 16:53:31 +01:00
Jeff Young 345645bd8c Help documentation for "assertion" constraints. 
(cherry picked from commit 152c458b9c)
 2024-02-23 16:53:31 +01:00
Jeff Young 900962f9f1 Update syntax help for memberOfFootprint. 
(cherry picked from commit 7ae14f9630)
 2024-02-23 16:53:31 +01:00
Jeff Young 57dcf285c5 Various string issues held over from 8.0 string freeze. 
(cherry picked from commit a610542a19)
 2024-02-23 16:53:31 +01:00
Jeff Young 23c2104ffa Improve alignment tooltips. 
(cherry picked from commit 2ab492474e)
 2024-02-23 16:53:31 +01:00
Jeff Young 9ff66d0e71 Don't capture references to local variables for CallAfter. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16934

(cherry picked from commit 9d40374baf)
 2024-02-23 16:53:30 +01:00
Jeff Young 276171b85e Handle holes in shapes when creating bounding hulls. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16347

(cherry picked from commit 0ead8a14a1)
 2024-02-23 16:53:30 +01:00
jean-pierre charras ef6a5b6252 teardrops: calculate better points on track for track arc. 
Previously, a reference point to calculate teardrop length was calculated
using a track segment. It can create significant position error with track arcs.
Now a arc is used to find this reference point.
 2024-02-23 11:36:14 +01:00
Alex Shvartzkop 6ceea747b2 Swap to capitalized strings (translated). 2024-02-22 11:54:52 +03:00
Alex Shvartzkop dd6213051d Pick DP coupled segment closest to start item and baseline. 2024-02-20 22:06:00 +03:00
jean-pierre charras 01327b24b4 PANEL_SETUP_LAYERS: when removing a layer, do not delete items owned by footprints. 
Items owned by footprints are allowed to be on non existing layers on board.
Moreover, items owned by footprint cannot be deleted by the board editor.
Fixes #17038
https://gitlab.com/kicad/code/kicad/-/issues/17038
 2024-02-20 18:38:48 +01:00
Jeff Young 012b32e989 Don't leave dangling net pointers on PCB_SHAPEs. 
Also makes it harder for this type of error to occur in
future.
 2024-02-20 17:36:54 +00:00
Alex Shvartzkop 2e97d5d7cc Add missing check in tuning pattern outline. 2024-02-20 20:32:07 +03:00
Alex Shvartzkop cbfd757d28 Reduce amplitude snap value of tuning patterns. 2024-02-20 03:20:08 +00:00
Alex Shvartzkop 10e6ca8740 Show tuning pattern baselines when not editing them. 2024-02-20 03:20:08 +00:00
Alex Shvartzkop 59a0635b09 Disable local ratsnest when moving generators (tuning patterns). 
They're not moving like normal objects, leaving ghost ratsnest.
 2024-02-20 03:20:08 +00:00
Alex Shvartzkop ed712faf41 Disallow duplicating tuning patterns alone. 2024-02-20 03:20:08 +00:00
Alex Shvartzkop 5e5effaf3a Ensure minimum outline size in tuning patterns. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16847
 2024-02-20 03:20:08 +00:00
Tomasz Wlostowski 82312a0fae router: SplitAdjacentSegments() should check if the end segment we are about to split is in the same net that the head segment 
Otherwise, the router might add bogus segments to the node. The root of the problem is somewhere in the logic that delivers aEndItem to ROUTER::Move() though - as the end item (in line placement mode at least) should always be an item within the same net as the head and not belonging to the current head...
 2024-02-20 03:20:08 +00:00
Alex Shvartzkop 8d76e4e171 Allow DP meanders to (mostly) fit on adjacent segments. 2024-02-20 03:20:08 +00:00
Alex Shvartzkop 943c5fea59 Fix length calculations in DP meander placer. 2024-02-20 03:20:08 +00:00
Alex Shvartzkop 29188bdc53 Fix some edge-cases in DP tuning pattern outline. 2024-02-20 03:20:08 +00:00
Alex Shvartzkop 4227b1add9 Improve tuning pattern robustness. 2024-02-20 03:20:08 +00:00
Alex Shvartzkop 1a65c0091f Tweak default meander settings. 2024-02-20 03:20:08 +00:00
Alex Shvartzkop 35e73d7dee Restore green router collision color. 2024-02-20 03:20:08 +00:00
Alex Shvartzkop e9a881ed01 Reset placer when routing start fails to prevent crash on next usage. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17008
 2024-02-20 03:20:08 +00:00
Seth Hillbrand 89592d08bf Revise teardrop graphics sizes 
Sizes were too large on many systems.  Revised panel uses 615px on Linux
instead of 742.  Adjusted line sizes to remain minimum visible width at
new height.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/17018
 2024-02-19 12:48:36 -08:00
Mike Williams 60fe87a73c PCB: always parse ki_fp_filters as a property, not a field 2024-02-19 09:41:27 -05:00
Ian McInerney d3befd8bb8 Remove dummy items from group before they are deleted 
Board items should not be in a group when they are deleted, but these
are dummy ones, so their group membership doesn't matter.

Fixes KICAD-7P0
Fixes KICAD-6VX
Fixes KICAD-7KK
Fixes KICAD-6VH
 2024-02-16 12:20:00 +00:00
Marek Roszko b2c6e2de1f Fix file not found msg contents for step resolving 2024-02-15 23:10:57 -05:00
Marek Roszko 762c159b96 Fix KIPRJMOD by setting the project as active by modifying the board loading helper 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16973
 2024-02-15 23:06:41 -05:00
Seth Hillbrand 08bdf1abae Avoid drawing netnames when not in board editor 
Shouldn't be needed if we properly clear the netinfo but there's no
reason to keep netnames so better to avoid possible issues

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16981
 2024-02-15 17:17:22 -08:00
Marek Roszko c48fc7ebff Fix crash due to PCB_SHAPEs not being returned by BOARD::AllConnectedItems 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16981
 2024-02-15 19:58:21 -05:00
Jon Evans 4ec390838b Re-enable non-KiCad board import when non-standalone 
Partial revert of ec2cd99405

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16978
 2024-02-15 12:14:32 -05:00
Jon Evans 7b0bb59b37 Remove hard-coded versioned env vars in most places 2024-02-15 15:31:08 +00:00
Mike Williams 6c1273ca12 PCB Parsing: only parse old properties before PCB fields addition 2024-02-14 09:35:10 -05:00
jean-pierre charras 8e6fe0eaf0 Gerbview settings: store option "Page Limits" in gerbview config. 
Previously this appearance option in Layer Manager was not stored.
 2024-02-14 11:21:55 +01:00
jean-pierre charras 0d1945def7 Gerber drill file: do not flash oblong holes: they must be routed. 
Fixes #16962
https://gitlab.com/kicad/code/kicad/-/issues/16962
 2024-02-14 09:22:49 +01:00
Marek Roszko f73d45b0cf Add $schema prop to drc/erc 2024-02-13 19:08:55 -05:00
Ian McInerney b86bf19328 Make shape properties layer selection obey cancel command 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16735
 2024-02-13 20:31:05 +00:00
Mike Williams 3cd61a2d39 PCB: appending boards should not select existing generators 2024-02-13 10:15:30 -05:00
Jeff Young 0cf433b28e CONVERT_TOOL::CreateLines() doesn't use SKIP_STRUCT flag. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16930
 2024-02-12 23:59:33 +00:00
Roberto Fernandez Bautista ca148fb4d1 pns_debug_tool: Fix "save as" to save log file with new router state 2024-02-12 21:22:57 +01:00
jean-pierre charras 7e4e80a2e5 DRC library parity attribute tests: disable DNP and EXCLUDE from BOM. 
They are related to a design, not to a footprint, and are tested in
schematic parity tests.
 2024-02-12 10:55:56 +01:00
Marek Roszko 2afe4db945 Add some missing newlines in cli output without changing strings 2024-02-11 21:12:21 -05:00
Marek Roszko 6a37f99e94 Fix crash if we exit lib table setup 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16917
 2024-02-11 21:05:23 -05:00
Marek Roszko d694bb5960 Use file name rather than path for erc/drc json and text reports 2024-02-11 20:16:22 -05:00
Jon Evans 622c2f1316 Make sure connectivity is updated in undo/redo 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16945
 2024-02-11 20:01:15 -05:00
Marek Roszko e51ddc52b7 Fix crash writing json drc report 2024-02-11 17:36:56 -05:00
Alex b5982f7319 EasyEDA import: force close some line chains. 2024-02-11 23:52:56 +03:00
jean-pierre charras fe1579ebbd BOARD_NETLIST_UPDATER: fix issue when reading net-lists having no FOOTPRINT_FIELD 
they can be old net-lists or non Kicad net-lists.
Fixes #16931
https://gitlab.com/kicad/code/kicad/-/issues/16931
 2024-02-11 21:03:00 +01:00
Jon Evans e9be95741b Deconflict hotkey for Route from Other End 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16415
 2024-02-11 10:58:38 -05:00
Jon Evans ec2cd99405 Guard actions that change project against running in non-standalone mode 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16942
 2024-02-11 09:36:17 -05:00
Roberto Fernandez Bautista 3a6d74a3b3 Allow user to select location to save router event log 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16904

Note: no new strings added
"Unable to write '%s'." is from pagelayout_editor/files.cpp(182)
 2024-02-11 13:43:55 +01:00
Alex Shvartzkop 2b295f85f5 Fix corner radius for 0 amplitude meanders. 2024-02-10 08:36:50 +03:00
Alex Shvartzkop ff17a22e31 Internationalize Image Properties dialogs. 2024-02-10 08:34:19 +03:00
Seth Hillbrand cd548e392a Add document type icons 
Update Macos script to use doctype icons for icns builds

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14754
 2024-02-09 15:55:57 -08:00
Seth Hillbrand f303996f9c Add new icons for tools 
Align elements to grid
Cleanup graphics
Cleanup tracks/vias
Drag

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16206

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16205
 2024-02-09 15:55:57 -08:00
Seth Hillbrand cabbab9a5f Move pcbnew drag to move specific icon 2024-02-09 15:55:57 -08:00
Alex Shvartzkop fcdd34f58b Reserve strings for Tune Length 2024-02-10 02:44:05 +03:00
Alex Shvartzkop 2121227194 Fix nullptr group assert in tracks cleaner. 2024-02-10 00:44:05 +03:00
Alex Shvartzkop d4e89543de Length-tuning fixes/improvements: 
- Ensure correct amplitude values in tuning patterns.
- Support lower amplitudes in DP length tuning
- Ensure correct minimal inner radius in DP length tuning
 2024-02-10 00:44:05 +03:00
Lucas Dumont 2933cdf636 Extend NETLIST lifetime for JobExportDrc 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16925
 2024-02-09 22:14:36 +01:00
Alex Shvartzkop 453e185613 Increase unconstrained tuning length to 1km. 2024-02-09 19:25:46 +03:00
Jeff Young 63fc89cafd Import graphic items on copper layers. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16916
 2024-02-09 13:56:01 +00:00
Jeff Young 91e15634fc Re-use ERC's delete-exclusions-query dialog for DRC. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16914
 2024-02-09 11:21:06 +00:00
Jeff Young 4905c37712 Streamline explodePad undo. 
Also fixes a bug where new shapes were added to the view
twice.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16888
 2024-02-09 10:08:37 +00:00
Jon Evans 037f349585 Make expand connection work on generated tracks 2024-02-08 19:28:28 -05:00
Jeff Young 53d048921a Fix merge conflicts. 2024-02-09 00:04:43 +00:00
Jon Evans 7929d7cda2 Fix build 2024-02-08 17:33:34 -05:00
Jeff Young ecbe1df7c1 Update target length/skew to std::optional. 
Also fixes a bug in the router where the target length would
get trashed if set to maxLongLongInt.  (We'd add the default
tolerance to it sending it negative.)
 2024-02-08 18:14:31 +00:00
Jeff Young e62b4f8ff4 Add nullable int and double to property system. 2024-02-08 18:14:31 +00:00
Alex Shvartzkop 876449b83d Set DP skew meanders max length to INT32_MAX instead of 100 mm. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16860
 2024-02-08 19:34:17 +03:00
Alex Shvartzkop f4cf23e5cf Length tuning: fix status popup display when unconstrained. 2024-02-08 18:55:42 +03:00
Mike Williams b979f52364 FP Editor: show hidden texts when we should 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16909
 2024-02-08 10:28:23 -05:00
arturo182 abb1915114 Missed a checkbox for Select All in Import Settings 2024-02-08 15:01:23 +00:00
Alex Shvartzkop f1caa262a6 Separate actions for single track and differential pair length tuning. 2024-02-08 14:58:28 +00:00
Seth Hillbrand 6e0d97df76 Do not cache invisible text objects 
In some cases, extremely long, invisible texts can fill and crash opengl
buffers
 2024-02-07 15:26:41 -08:00
Jeff Young bce372c8a3 Don't clear the undo/redo list when we're just trimming it. 
We only allow a certain number of commands on the lists
and trim them when they overflow.  PCB_BASE_EDIT_FRAME and
PL_EDITOR_FRAME implemented this correctly; SCH_EDIT_FRAME
and SYMBOL_EDIT_FRAME did not.
 2024-02-07 14:52:10 +00:00
Jeff Young 1e6986d2f5 Don't report starved thermals when connected only to isolated islands. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16866
 2024-02-07 14:09:03 +00:00
Jeff Young e6929b2184 Tooltip for "Prefer zone connections". 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16587
 2024-02-05 19:22:41 +00:00
Jeff Young d30361b425 Increase artificial via preference further. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16880
 2024-02-05 19:20:33 +00:00
Jeff Young 1ff36f23b8 Clean up stale TODOs. 2024-02-05 15:49:57 +00:00
Jeff Young da46a96623 Update a few strings based on new string freeze policy. 2024-02-05 15:49:57 +00:00
Ian McInerney 7ea1568802 Fix selection tool behavior in footprint viewer 
The footprint viewer isn't an edit frame, so we need to access the
settings through the base frame type instead. Also, double click makes
no sense in the footprint viewer, and just leads to weird results
sometimes.

Fixes Sentry KICAD-7A2
 2024-02-05 14:50:17 +00:00
Marek Roszko 835500bf1c Hide the color prop from pcb editor 2024-02-05 01:13:16 -05:00
Marek Roszko 3960c53225 A few tweaks for hidpi 2024-02-05 00:52:11 -05:00
Jeff Young 0370db43ae A footprint does it's own child hit testing. 
We only need to add it for groups.
 2024-02-04 23:16:43 +00:00
Jeff Young 77c19fa99a Fill in missing zone properties. 
Also fixes some bugs with hatch properties being available
on rule areas.
 2024-02-04 23:01:31 +00:00
Marek Roszko 5d0abd3b01 Use CallAfter instead of Idle event hack for drc dialog item selection 2024-02-04 12:37:56 -05:00
Jeff Young cab351d249 Don't do a sided-test on a footprint which has no side. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15284
 2024-02-04 15:18:23 +00:00
Jeff Young 4e0b48a03a ZONE_SETTINGS init belongs in ZONE_SETTINGS's ctor. 
(Not in ZONE's ctor.)
 2024-02-03 20:17:31 +00:00
Jeff Young 5379a1d863 Nullptr protection. 2024-02-03 20:17:31 +00:00
Ian McInerney 2fc96c1d11 Ensure stackup material returned is correct after list item deletion 2024-02-03 18:06:40 +00:00
Alex 5c86247e21 Fix inactive cells being black in default settings panels on MSW. 2024-02-03 21:00:28 +03:00
Ian McInerney dc6fb73b40 Fix mistake in 7edda82b where any key could delete the material 2024-02-03 17:01:57 +00:00
Ian McInerney 7edda82b2a Hook up delete key in stackup materials list box 
Allow the delete key to delete a material from the stackup list, since
otherwise there is no way to delete materials from the list.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16854
 2024-02-03 16:39:56 +00:00
Wayne Stambaugh 92c2ddf77a Do not parent dialogs to non top level windows in panels or widgets. 2024-02-03 10:40:28 -05:00
Jeff Young 4d49762714 Remove Export Settings to Other Similar Zones. 
The UI for it is clunky (Cancel afterwards doesn't do what
you think it might), the undo code is all hand-rolled (and
possibly buggy?), and we have the Property Inspector now
for this type of stuff.
 2024-02-03 13:22:16 +00:00
Jeff Young 0890ac57dd Improve clarity of default zone settings. 2024-02-03 13:22:16 +00:00
Subaru Arai d9737a39bf remove qr footprint generator min pixel size 
The minimum pixel width should be left for the user to decide, since it
depends on the manufacturer and layer.
 2024-02-03 09:37:29 +00:00
Marek Roszko 239cbb4637 Use Fit to size the layer box after sitting min size 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16862
 2024-02-02 23:43:05 -05:00
Mark Roszko b354b24182 Revert "Call Layout after calculating layer combobox size to ensure it takes effect" 
This reverts commit cd8eb23c3e
 2024-02-03 04:32:36 +00:00
Marek Roszko cd8eb23c3e Call Layout after calculating layer combobox size to ensure it takes effect 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16862
 2024-02-02 23:11:48 -05:00
Jeff Young 7cc663ad77 Schematic parity checking for CLI DRC. 2024-02-02 23:05:37 +00:00
Wayne Stambaugh 2b1bf369f2 Do not parent file or directory dialogs to panels. 
Parenting dialogs to child windows of top level windows is most likely
not defined behavior.  It's also likely that this behavior varies across
platforms so it' best not to risk doing it.  wxWidgets does not check if
the dialog parent is actually a top level window.  There may be other
places we are doing this with our message dialogs so we should do an
audit.
 2024-02-02 09:20:36 -05:00
Alex Shvartzkop 4a1245e85a STEP: export copper plating for vias/pads (25 micrometers). 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16694
 2024-02-02 00:29:03 +03:00
Jeff Young a485a4815c Clear text before replacing in ImportSettingsFrom. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16851
 2024-02-01 17:37:27 +00:00
Alex 285067dad1 Altium PCB: support polygon id 65534 for keepout tracks on board outline. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16849
 2024-02-01 12:15:06 +03:00
Ma Han 7c6ee16b22 removed the dots for several strings in the settings dialog 
https://gitlab.com/kicad/code/kicad/-/issues/16651
 2024-02-01 08:52:57 +00:00
Alex Shvartzkop 1122d80388 Better support for arcs in tuning patterns. 2024-01-31 23:38:05 +03:00
Alex Shvartzkop 7d1888c756 Add parts of arcs to tuning patterns correctly. 2024-01-31 21:45:01 +03:00
Roberto Fernandez Bautista e9fbb36538 SHAPE_LINE_CHAIN: Fix and simplify NextShape() + remove PrevShape() 
NextShape() function was too complex (trying to go back and forwards).
We only used PrevShape() in one place, so removed that usage.

Added QA tests
 2024-01-31 19:17:46 +03:00
Roberto Fernandez Bautista 079478f989 EDA_ANGLE: use constexpr for constant angles 
Remove all statics in the class and instead use constexpr to
ensure correct ordering
 2024-01-31 19:17:46 +03:00
Jeff Young 19560f0281 Fix pad edit mode undo. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16835
 2024-01-31 15:45:58 +00:00
Marek Roszko 4b12534dbd Fix property editor for graphic circles 2024-01-30 22:00:09 -05:00
Marek Roszko c8d24b7613 Add missing IPC2581 cli support 2024-01-30 20:42:34 -05:00
Jeff Young 32d589a121 Don't rely on baselines for fetching DRC_RULE items. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16816
 2024-01-30 13:19:04 +00:00