a86a258f66
Improve symbol instance data file save ordering.
...
Use the root schematic UUID to order projects and sort symbol instance
data by KIID_PATH. This will ensure file changes to instance data are
more consistent by using a fixed ordering.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17737
2024-04-20 08:57:00 -04:00
95136494b3
RIP LIB_PIN.
2024-04-20 12:10:31 +01:00
6d11c85cad
Initialize all member variables.
2024-04-20 12:10:31 +01:00
4e6a3a50fc
Flip labels to match orientation
...
When changing from local to hierarchical or global, the label style is
typically flipped so that global/hierarchical labels hang off the line
while local labels are set on top. To make this more intuitive we flip
the initial orientation when changing
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17739
2024-04-19 16:09:30 -07:00
5da3dd1788
Restore parsing order in the legacy symbol library plugin
2024-04-19 22:33:28 +00:00
5d99aaf0a4
Use correct project name when adding new symbol instances.
...
When adding a sheet using a schematic from another project, set the
project name for the new symbol instance data to the current project
rather than the project name from the copied instance data.
2024-04-19 14:33:22 -04:00
909d43492b
Fix warning.
2024-04-19 18:26:20 +03:00
c04cd81231
Eeschema: fix color issues in symbol body graphic items drawings.
...
- fix incorrect colors (outlines and filled shapes)
- fix issues in DIALOG_SHAPE_PROPERTIES (incorrect colors)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17799
2024-04-19 15:26:15 +02:00
5f16c5892c
Handle hierarchical sheets in incremental change
...
The drivers need to get passed up and down the hierarchical sheets. In
order to do this, both the sheet pin and the hierarchical pin need to
be in the changed items. However, we only get sheets in the screen
items list while the pins are the elements that get set dirty
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17797
2024-04-18 21:18:27 -07:00
1bc34f7bd7
Always refresh the navigator when changing units
...
Units are displayed even if the net is not selected
2024-04-18 18:21:13 -07:00
d8b6e28890
Excise the remaining unused ifdef EESCHEMA
...
Common units are now shared between programs, so we need a different way
other than compile definitions to choose how many digits to display.
2024-04-18 18:21:13 -07:00
00538548f5
Handle net directive in navigator
2024-04-18 18:21:13 -07:00
17bcc27ff6
Fix missing instance data when reusing an already loaded schematic.
...
Remove duplicate sheet instance page numbering. It's already done when
the sheet is loaded from an exiting file or an already loaded schematic.
Remove the unnecessary page update code from the drawing tool.
2024-04-18 15:47:47 -04:00
f8a25d20f8
Remember to set the root sheet before loading
...
This is done in the frame for GUI loading so we need to explicitly set
this when loading files in the cli
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17790
2024-04-18 10:47:49 -07:00
b394d7eb96
Fix build breakage.
2024-04-18 15:20:58 +01:00
d2c512f422
Don't double-save transform for plotting DNP.
2024-04-18 11:03:37 +01:00
cc78196f81
Remove shadowed member variables.
2024-04-18 10:58:39 +01:00
e5cdf3785b
Make SCH_SHAPE::Normalize() upside-down-coords-aware.
...
Also fixes some typos in EE_POINT_EDITOR.
2024-04-18 10:27:36 +01:00
2f7cc5fa2b
Be sure that we are getting the SCH_SYMBOL values
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17782
2024-04-17 13:53:01 -07:00
d79619edd1
Minor net navigator improvements.
...
Ignore bus member connection subgraphs. They do not have a valid net
name nor do they contain schematic items. This prevents empty nodes
from being added to the tree. They can be reintroduced in the future
if someone wants to pursue it.
Freeze the wxTreeCtrl while populating it and thaw when done to prevent
any unnecessary repainting.
Add profiling to test how long it takes to rebuild the net navigator.
The recently added populate the navigator with all nets when no net
is highlighted has exposed some potential performances issues with some
versions of wxWidgets on certain platforms. Namely wxWidgets 3.2.4 on
Linux GTK.
Fix an issue where a sheet name change would not update the highlighted
net navigator resulting in a stale human readable sheet path.
Prevent the highlighted net navigator from being rebuilt twice when
loading a schematic. SCH_EDIT_FRAME::RefreshNetNavigator() was being
called from both SCH_EDIT_FRAME::UpdateHierarchyNavigator() and
SCH_EDIT_FRAME::RecalculateConnectivity().
Add a new trace helper "KICAD_UI_PROFILE" to show trace output when
profiling user interface performance. It's used in the net navigator
profiling mentioned above.
Reuse PROF_TIMER::Show() to generate string for PROF_TIMER::to_string().
2024-04-17 14:31:50 -04:00
a4073c2ace
Provide some user hints on editing fields.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17781
2024-04-17 18:30:37 +01:00
0e0ada8e4e
Allow NIC pins to be stacked
...
Previously, we only allowed pins of the same time as well as passive
pins to be stacked. This change allows NIC pins as well since they are
not internally connected, there is no reason that they cannot be tied to
another pin electrically
2024-04-17 10:00:00 -07:00
dee45a491e
Readability.
2024-04-17 11:03:07 +01:00
c842de24b9
HitTesting is the wrong place to do visibility checks.
2024-04-17 10:53:49 +01:00
657fe6e091
Fix background colour bug.
2024-04-16 23:41:48 +01:00
d761b4f22f
RIP LIB_TEXTBOX and LIB_SHAPE.
2024-04-16 16:31:16 +01:00
3efe504dcc
Collapse LIB_TEXT into SCH_TEXT.
2024-04-16 16:31:16 +01:00
5d7e96841b
Close bom file earlier
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17779
2024-04-16 12:39:03 +00:00
ea904c9fb1
Symbol Fields Table: configurable excluded from BOM filtering
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/17747
2024-04-15 13:08:04 -04:00
b7f035964f
Fields in symbols: Ensure visibility is correctly set when reading a file
...
Also ensure default fields visibility is correctly set when creating a symbol
Change default field visibility to true in SCH_FIELD Ctor
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17767
2024-04-15 18:19:19 +02:00
ac36feda41
EEschema: fix incorrect (missing) init of main layer of SCH_SHEET fields
...
These fields were not drawn when drawing a hierarchical sheet.
2024-04-15 09:56:19 +02:00
2a3b597ab9
Strip out no longer needed links on the top executables
...
Not needed due to kicommon
2024-04-14 07:52:02 -04:00
affcfed677
Fix some warnings.
2024-04-14 01:19:39 +03:00
14762e3d54
Handle layers for label fields.
2024-04-13 19:53:58 +01:00
d77eae3e7e
Collapse LIB_FIELD into SCH_FIELD.
2024-04-13 15:42:13 +01:00
c241796968
Minor improvements to readability.
2024-04-13 15:40:08 +01:00
0ce227fa92
Can't use forward declare with std::vector
...
Not allowed per C++ standard
See https://github.com/llvm/llvm-project/issues/57700
2024-04-13 08:22:20 -04:00
96cdfc7fa7
Update equality overloads for C++20
...
C++20 added new reverse and rewritten candidates. This can confuse the compiler because it'll test both A==B and B==A for overloads.
Because we were defining parent class equality overloads, A==B and B==A was considered ambigious due to both being compatible in casting.
So we needed to add explicit child class equality operator overloads
2024-04-12 23:05:58 -04:00
e3777758d9
Silence enum operation warning
2024-04-12 22:54:42 -04:00
8fb4901d4b
Fix more utf8 comparisons
2024-04-12 22:53:25 -04:00
c042b51be9
Fix another deprecated lambda capture
2024-04-12 22:49:50 -04:00
161cfbacd4
constexpr the let user{} format string
2024-04-12 22:48:34 -04:00
0675c62a24
Update two more lambda capture
2024-04-12 22:42:31 -04:00
e6be29daa0
Fix another UTF8 to wxString comparison
2024-04-12 22:38:38 -04:00
6c17e275fb
Revert "Re-enforce ordering"
...
This reverts commit b22fcf70cd
2024-04-12 14:14:06 -07:00
531a8b9db9
Revert "Compare function should return int"
...
This reverts commit 7727982478
2024-04-12 14:13:55 -07:00
b22fcf70cd
Re-enforce ordering
...
Instances, pins and graphics have started to wander around the files.
Sorts instances before writing.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17737
2024-04-12 11:58:30 -07:00
7727982478
Compare function should return int
...
Returning boolean is promoted to int and confuses false with '0'
indicating that the elements are identical
2024-04-12 11:30:16 -07:00
f08cacb30f
Revert "Re-enforce ordering"
...
Unexpected element loss after save. Reverting to fix
This reverts commit f2f4890342
2024-04-12 10:34:11 -07:00
f2f4890342
Re-enforce ordering
...
Instances, pins and graphics have started to wander around the files.
Sorts instances before writing. Uses compare with std::set (not
std::multiset) to enfore lib item ordering
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17737
2024-04-12 10:08:46 -07:00
e14e956c1d
Fully order schematic saves
2024-04-11 16:54:30 -07:00
e538b98286
Incremental updates should not clear globals
...
Netclass assignments are stored in the project level but
CONNECTION_GRAPH updates would clear the assignments. This keeps
existing netname->netclass assignments but updates any netnames that
were changed by the incremental updates. Absolute updates are not
affected and fully recreate the net name to netclass map
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17720
2024-04-11 15:57:49 -07:00
ac5fab190e
Check for valid shared pointer before locking
...
We don't neccesarily have a valid pointer to the parent lib symbol when
checking if it is a power symbol, so fall back to the local flag if this
is the case
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17182
(cherry picked from commit 4481fcc75e
2024-04-11 14:43:27 -07:00
cbef6d1cbf
BOM Export: default to ${PROJECTNAME}.csv for convenience
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/17049
2024-04-11 15:46:50 -04:00
9c058503d9
BOM Export: remember filename per project
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/17704
2024-04-11 15:05:59 -04:00
e7ac68d409
Support alternating table row colors in SCH_PIN_TABLE_DATA_MODEL.
...
See https://gitlab.com/kicad/code/kicad/-/issues/17482
2024-04-11 19:37:31 +03:00
067ef9657e
net navigator: handle no-connects
2024-04-11 10:21:18 -04:00
faca7ee05b
net navigator: show all nets when none are highlighted
2024-04-11 10:21:17 -04:00
ec310ac3ed
Update hierarchy navigator when undoing or redoing sheet name changes.
...
Use new schematic commit object in the edit sheet properties dialog.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17721
2024-04-11 10:11:02 -04:00
a9f35ba42e
Fix incremental connectivity
...
The connectivity routine would consider symbols, overwriting unused
subgraphs for pins that were not in the change list. This is resolved
by updating the full connectivity to only use pins in the graph since
symbols are not connected independently.
In the process of adding QA tests for this change, additional issues
with the schematic QA were discovered. Specifically, we were not
properly setting the root sheet UUID. This was partially masked by a
const_cast setting of the RefDes in sch_symbol when called the RefDes
getter. This exposed the fact that our QA ERC numbers did not match the
schematic editor stand alone ERC numbers. So the test value for one
check needed to be updated
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17528
2024-04-10 17:25:58 -07:00
3b66f64c19
Cleanup.
2024-04-10 10:26:59 +01:00
0d6822be0d
Remove shadowed member variables.
2024-04-10 10:26:59 +01:00
d45911f54b
add support to update an already existing field
2024-04-09 23:37:20 +00:00
1aa59b806c
Allow selection promotion when editing wrong field type.
...
Also fixes a bug where a CHT_MODIFY on a parent symbol with a
selected child doesn't trigger a selection modified event.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17696
2024-04-09 13:40:18 +01:00
56f6f44b3d
Formatting, type-cast and auto cleanup.
2024-04-09 12:55:44 +01:00
e7493c7851
Fix SCH_SYMBOL's operator=.
...
Also cleans up a few loose ends from LIB_ITEM collapse.
2024-04-08 21:24:32 +01:00
6c7946012c
Turn off hidden pins/fields for plot jobs handler.
...
(We only have CLI settings for them when plotting symbols.)
2024-04-08 16:56:36 +01:00
3ade857c7b
Honour parent symbol's transform when over-plotting pins.
2024-04-08 14:26:48 +01:00
1d753e0850
Respect showHiddenPins and showHiddenFields flags when plotting.
2024-04-08 13:32:11 +01:00
9c94967b52
Tidy renderSettings / jobsHandler APIs.
2024-04-08 12:26:56 +01:00
5abc7145da
Fold LIB_ITEM into SCH_ITEM.
2024-04-08 10:24:50 +01:00
494001ed4c
Harmonize more APIs.
2024-04-08 10:10:24 +01:00
968ca7c5c3
SNR
2024-04-08 10:10:24 +01:00
13038038d9
Remove unused method declaration in SCH_LINE
...
This is a tidy-up following on from b01796cb
2024-04-07 15:41:54 +00:00
ce846f5c22
Check for bus no-connects in ERC
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13285
2024-04-07 08:50:28 -04:00
1028a76e4a
Harmonize print/plot APIs.
2024-04-06 09:34:56 +01:00
5dd8747ecb
Harmonize mirroring APIs.
2024-04-06 09:34:56 +01:00
c5ed80af52
Harmonize rotate APIs.
2024-04-06 09:34:56 +01:00
7baccba01c
Coverity fixes
2024-04-05 08:16:29 -04:00
e83a82594e
net navigator: check for removal from net as well
2024-04-04 15:25:54 -04:00
e1548c0f9a
schematic: update highlighting when net changed
2024-04-04 14:10:18 -04:00
92910d5d0f
Factor common parts of SCH_ & LIB_SYMBOL into SYMBOL.
2024-04-04 13:18:55 +01:00
bf2b3b0b0f
Deconflict some LIB_TREE_ITEM APIs so they can remain non-const.
...
(The non-const is required by FOOTPRINT_INFO, which must load
footrpints to get some of the data.)
2024-04-04 13:18:55 +01:00
1dbe78c68b
Add QA tests and expand serialization for API
2024-04-02 19:51:18 -04:00
f613cd1cb4
ADDED: A new IPC API based on protobuf and nng
...
Details, documentation, and language bindings are works in
progress and will be evolving over the course of KiCad 9
development.
2024-04-02 19:34:36 -04:00
e67eae90e9
Check for read permissions before trying to import schematic file
...
This will display a better error message to the user, instead of saying
that no plugins to load the file are found (because the plugin tests
will also fail due to being unable to read the file).
2024-04-01 22:00:00 +01:00
02f6d38fe3
Fix merge error.
2024-03-31 12:59:52 +01:00
b01796cb84
Auto-fill new net global / local label names from connectivity
...
Currently, new global or local net labels are auto-filled with the
net name if the wire is driven by a global or local label. This
currently happens recursively within SCH_LINE. This fix moves this
to determining the driver from the connectivity graph, and removes
the determination from the SCH_LINE code where it does not belong.
2024-03-30 14:33:51 +00:00
3a430357bc
Cut/copy/paste for SCH tables.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17335
2024-03-28 14:34:11 +00:00
7cc7f238d7
SCH_SHAPE destructor marked virtual
2024-03-26 22:20:09 +00:00
0a89236f19
CLI: Add allegro and pads netlist output format options
2024-03-26 19:58:22 +08:00
f3ce3bc758
Close active cell editor when showing/hiding columns.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17425
2024-03-24 10:09:27 +00:00
a6e2746a08
Rewrite intersheet refs resolution to be sheet-path aware.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17533
2024-03-23 16:50:21 +00:00
1c7e3871b5
Fix warning due to unused angle in EasyEDA Pro schematic parser.
2024-03-23 17:51:19 +03:00
1e6eb652aa
Don't show hidden text in symbol previews.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17526
2024-03-23 12:48:52 +00:00
490dbfdf83
Fix build warnings
2024-03-23 08:34:59 -04:00
d7abed2d60
Footprint Chooser dialog: Allow toggle buttons to work simultaneously
2024-03-23 09:48:15 +00:00
90566eb735
Setup default colors in the COLOR_SWATCHes.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17517
2024-03-22 12:41:03 +00:00
db12f2af49
Disallow cross-probing when not on Symbol Fields Table Edit tab.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17531
2024-03-21 19:08:23 +00:00
58df9c96f4
ADDED: Expose units and DeMorgan to properties system.
...
(Also fixes inheritance bug in LIB_PIN's properties.)
2024-03-21 16:19:55 +00:00
c5c65f23a4
Internationalise pin info when language changes.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17224
2024-03-21 12:31:04 +00:00
913e6b47d7
Fix copy/pasta in tooltips.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17515
2024-03-21 12:31:04 +00:00
83ef5fd7d6
Move PGM_BASE to kicommon
2024-03-20 23:29:42 -04:00
7b904545e9
Fix explicit wxstring build breakage
2024-03-21 03:25:15 +00:00
f00f47df13
wxWidgets 3.3 compatibility: explicit wxString conversion
2024-03-20 22:02:41 -04:00
e7b6573717
wxWidgets 3.3 compatibility: properties API
2024-03-20 22:02:40 -04:00
773d241863
wxWidgets 3.3 compatibility: update enum name
2024-03-20 21:50:44 -04:00
3303c17c9b
fix minor compil warning (inused var)
2024-03-19 17:40:04 +01:00
f3966371be
Simulation: add export current plot to clipboard and current schematic
...
These exports are in file menu.
2024-03-19 17:05:55 +01:00
05cdd44404
Don't assume all glyphs are outline with an outline font.
...
Underline and overbar may be stroke glyphs.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17478
2024-03-18 22:21:01 +00:00
2311eed08a
Add new ERC rule to check for global labels with only one entry in the schematic
...
By default this rule is set to ignore to provide continuity for those using
single global labels to name nets (e.g. in simulation)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13212
2024-03-17 23:24:43 +00:00
797ab998cc
Maintain hierarchy navigator expansion state between edits.
...
Prevent the hierarchy navigator from being rebuilt unless there are actual
sheet changes that would cause a change to the tree.
Save the tree expansion state before rebuilding the tree and then restore
the expansion state to the previous state sans edits.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16635
2024-03-17 09:02:26 -04:00
383dbd983a
Don't skip transitions from netclass to empty.
2024-03-16 19:46:48 +00:00
a6e8370ddd
Pin names drive netnames.
2024-03-16 19:26:26 +00:00
17a93adb30
Netclasses also must be computed in connectivity updates.
2024-03-16 19:24:25 +00:00
116908c088
Formatting.
2024-03-16 12:00:15 +00:00
e30b6398b7
ADDED: optional PDF metadata from AUTHOR and SUBJECT variables.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17289
2024-03-14 17:40:04 +00:00
c27eade01e
Symbol Editor: do not allow to select fully invisible pins and fields
...
Of course, invisible pins or fields shown by using option Show invisible
pins or Show invisible fields can be selected.
2024-03-14 10:01:58 +01:00
4f4d9be8d1
Symbol Editor do not display bounding box of invisible pins and fields
2024-03-13 17:46:14 +01:00
eddf4883b6
Minor dialog layout improvements.
2024-03-13 11:45:33 -04:00
dac16a02cc
Default is a valid netclass, even if it's not in m_NetClasses.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17388
2024-03-13 15:30:07 +00:00
33566f88a9
Clean up debugging output accidentally left in previous commit.
2024-03-13 10:48:44 -04:00
0ff8d21459
Fix broken paste special keep existing symbol annotations.
...
This was only broken for symbols on the sheet where the symbols were
copied from. The symbol annotation for all sub-sheets was preserved.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17231
2024-03-13 09:39:41 -04:00
7341d4bf37
Update m_LastLegendPosition after setting dirty bit.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17411
2024-03-13 10:39:03 +00:00
b190f21b6c
Remove close buttons from schematic AUI
...
Harmonizes with PCB editor
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17415
2024-03-12 19:51:27 -04:00
628ec858a6
Label netlist exporters.
...
(Particularly useful for those that have no other settings and
otherwise look blank.)
Also replaces "Generator" terminology as it's a bit confusing
(and will only get more confusing with PCBNew Generators).
2024-03-12 17:47:24 +00:00
0f57d76ecd
Clean and standardize cross-probing action
...
Between schematic and pcb editors, we want the following actions:
- Single click on ERC/DRC item should show the item in the ERC/DRC
window. But if the window is not visible, it should only update the
status bar
- Double click on ERC/DRC item should show and raid the ERC/DRC window
as well as select the line item
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17383
2024-03-11 17:50:44 -07:00
d083593177
Table bug fixes.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17399
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17398
2024-03-11 22:58:12 +00:00
865225fcca
Use correct value field text when importing Eagle schematic symbols.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17130
2024-03-11 15:19:32 -04:00
ed61c5593f
Don't show normal cut/copy/paste items in Signals grid.
...
(Do allow a copy of signal names though.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17395
2024-03-11 18:14:38 +00:00
73f94175de
Formatting.
2024-03-11 17:46:09 +00:00
9281561938
Fix include paths and merge conflicts.
2024-03-11 12:11:00 +00:00
25abba7432
Add XSPICE node/port modifiers: %d [ ~ ] etc.
2024-03-11 12:03:37 +00:00
64812d3fe6
DIALOG_ERC: fix crash when set to ignore a an ERC violation.
...
If a ERC violation is set to ignore, all corresponding markers are deleted.
But if one of these markers is selected, a crash happens.
Now all selected objects are deselected before deleting markers.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17375
2024-03-11 10:17:11 +01:00
fbc433deaa
Make sure to initialize cell start location.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17379
2024-03-10 21:49:54 +00:00
9602151d6c
Fix typo in SelectRows().
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17378
2024-03-10 21:06:43 +00:00
bf7896a0e1
Add option to preserve custom power flag values in Update Symbols from Library dialog
2024-03-10 18:32:00 +00:00
4dcd1fb8e2
Fix formatting from simulator X/Y zoom changes
2024-03-10 12:43:18 +00:00
16de0a666c
Horizontal/vertical zoom for Simulator plots
...
ADDED: Horizontal/vertical zoom for simulator plots, via mouse wheel,
toolbar buttons, menu commands, and hotkeys.
ADDED: Simulator preferences panel, populated with mouse wheel
and trackpad settings that control pan and zoom of simulator plots.
ADDED: Zoom In/Out Horizontally/Vertically commands that can be bound
to hotkeys.
CHANGED: Simulator plot scroll wheel gestures are no longer hard-coded
and can now be configured via the new Simulator preferences panel.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16597
Other unreported bugs that were fixed:
- Fixed wierd, jumpy simulator plot view limiting behavior.
- Fixed Zoom In Center and Zoom Out Center commands not preserving
the simulator plot center point.
- Fixed simulator plot nudging when exported as PNGs.
- Fixed rectangular selection zoom being able to exceed simulator plot
view limits.
Notes:
- Provided new SIM_PREFERENCES struct to be used for future
simulator preferences set via the simulator preferences dialog.
- Bundled pre-existing EESCHEMA_SETTINGS::SIMULATOR settings into
EESCHEMA_SETTINGS::SIMULATOR::VIEW.
- Replaced mpWindow::EnableMouseWheelPan with more general
SetMouseWheelActions.
- Refactored and tidied up wxMathPlot's mpWindow code involved with
fitting, zooming, and panning.
- Consolidated long lists of duplicated member variable initializers to
a new mpWindow private delegated constructor.
- Provided provisional Zoom In/Out Horizontally/Vertically toolbar
icons that need improvement by a graphics designer.
- Provided gitignore entries for the Qt Creator IDE
2024-03-10 12:43:18 +00:00
1bf24da385
Schematic editor Table Properties and commenting for QuasiModal usage.
2024-03-10 12:18:50 +00:00
a12d79cd13
Performance improvements for multi-page dialogs.
2024-03-10 12:18:50 +00:00
e824e5a267
Compiler warning: C4555 result of expression not used
2024-03-09 17:11:38 +00:00
72ba31ba27
Pass symbol's netlist to footprint preview widget.
...
This allows us to show the pin functions on the corresponding
pads.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17349
2024-03-09 15:01:59 +00:00
cb01bca1f4
Add PADS netlist format export
2024-03-09 10:00:46 -05:00
c5a02fc266
Do not update schematic connectivity for irrelevant property changes.
...
Prior to this change, the schematic connectivity was updated any time a
change was made to a connectable object. Now the connectivity is only
updated when an object change actually affects the connectivity. Other
properties like line width, fill type, custom fonts, etc. will not cause
the connectivity graph to be rebuilt.
The SCH_COMMIT flag SKIP_CONNECTIVITY has been removed. All schematic
objects can test if they are connectable and if there have been changes
to any connection properties that require a connectivity rebuild.
Remove duplicate rebuild connectivity calls from editor control tool.
This was causing the tangling end test to get called four times on every
undo and redo action because the dangling end test is already called in
the connectivity graph calculation code.
Update connectivity when changing label names which fixes an unreported
connectivity bug.
2024-03-09 08:50:26 -05:00
5ac8449e1f
Minor compil and Coverity fixes
2024-03-06 13:05:21 +01:00
4bc69183ab
Set description on Altium imported symbols
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16943
2024-03-05 23:08:11 -05:00
1600d8bead
Prevent use-after-free of symbol screens
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17204
2024-03-05 22:53:51 -05:00
c1ba07e6bc
SelectAll should use the filter
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17157
2024-03-05 18:27:51 -05:00
1988aac2b3
Update a few more list/tree views for macOS
2024-03-05 08:38:46 -05:00
8cda72f8d5
Fix defects reported by Coverity scan introduced in !1765
...
Corrects lifetime performance issue where extra copies of SCH_SHEET_PATH objects were being passed on the stack.
2024-03-04 19:45:05 +00:00
62c961b8ba
Performance Mitigate "Edit all symbol fields" dialog slow closing.
...
GetSymbols will return all symbols. Call it once and cache it.
2024-03-04 19:41:01 +00:00
ff8ddae9bd
Convert OP text variables pin names/numbers to SPICE vectors.
...
Also fixes a wrap-around bug in SPICE_VALUE::Normalize() where
it would lose the run of itself if the value was already
normalized to either the largest or smallest UNIT_PREFIX.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17228
2024-03-04 14:25:29 +00:00
c056ef407a
EasyEDA Std: support multiple schematic sheets.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17219
2024-03-04 15:09:31 +03:00
cc181df916
EasyEDA Std: support Dot and Clock symbol pin styles.
2024-03-04 15:09:31 +03:00
69b15e83c5
EasyEDA Std: hide invisible text in symbols.
2024-03-04 15:09:31 +03:00
563278d0f6
EasyEDA Pro schematic: place items on root sheet when it's the only sheet.
2024-03-04 15:09:31 +03:00
13c647ef6f
Fix resources leak reported by coverity
...
For unique_ptr, release only set the ownership to null, but don't free the resource behind. On the other hand, reset do.
Closes Coverity ID 483269
Closes Coverity ID 471974
Closes Coverity ID 471973
2024-03-03 16:23:49 +00:00
c76c4ba304
schematic: do not skip item repaint if item's parent type != SCHEMATIC_T
...
the item repaint was skipped when unhighlightning symbols after dragging
and unselecting.
Fixes https://gitlab.com/kicad/code/kicad/issues/17193
Fixes https://gitlab.com/kicad/code/kicad/issues/17206
2024-03-03 16:21:29 +00:00
4851b0f1ac
Database library cache: fix memory leak
2024-03-03 16:20:32 +00:00
0c8e08ed58
Move some language changes to a event on the frame
2024-03-03 11:02:26 -05:00
66925ec2a2
Update net navigator when cross probing from board editor net highlight.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16838
2024-03-03 08:56:48 -05:00
612c7015a7
REMOVED: Clicking on pin selects symbol setting
...
This is now redundant with the selection filter
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17114
2024-03-02 22:18:51 -05:00
c51e9917ba
Fix ordering of selection filter and net navigator
2024-03-02 20:21:16 -05:00
9c371e2ef5
Don't draw the selection if it's not from the current screen.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17132
2024-03-02 18:57:39 +00:00
428f2087bd
Eeschema: fix crash when editing a old legacy schematic with missing libs,
...
and trying to edit a dummy symbol. (crash due to a null pointer due to missing lib)
Fixes #17232
https://gitlab.com/kicad/code/kicad/-/issues/17232
2024-03-02 15:23:23 +01:00
c97c69a2f0
First alt-pin menu item must be fetched from the LIB_PIN.
...
(The SCH_PIN will return any alt function already assigned.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17221
2024-03-02 12:17:22 +00:00
70fe2a8f1e
kicad_cli: Allow upgrade of legacy and non-kicad symbol libraries
2024-03-02 13:06:23 +01:00
0d03f2febc
When failing to import, ensure extant screen
...
We need at least the root screen in order to handle any action in
Eeschema. Because this is destroyed by starting to load the new
schematic, when failing, we need to reset to null.
This is not as good as resetting to the previous state but that will
take refactoring our file load routines in schematic editor
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16993
2024-03-01 18:48:14 +00:00
a902898522
schematic: legacy kicad schematic files don't have a default description field
...
Without this, we would parse a legacy schematic symbol field at the same
index as the new description field's index into description, instead of into
a user field.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/17202
2024-03-01 10:40:03 -05:00
defcb49ac8
Support Altium Schematic ASCII import
2024-02-29 20:49:20 +00:00
24529e5242
ADDED: library tree context menu option to open sym/fp library files from the defined text editor.
...
Short description:
Works for Symbol and Footprint Editor behind an advanced config option.
For Symbol Editor it is shown for a single item selection (library or symbol).
For Footprint Editor it is shown for a footprint selection.
(fp editor allows a single tree item selection only).
Option stays hidden if current frame has been modified.
Also small fix(?) for similar action to the project manager.
(Call for the Execution has moved inside the file loop.)
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15736
2024-02-29 19:01:59 +00:00
cd27f801f6
Allow .kicad_sym in Import Symbol filters.
2024-02-29 17:36:32 +03:00
39a0a81832
EasyEDA Std import: support multiline text on PCB.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17171
(cherry picked from commit 0dab086f0c
2024-02-29 00:54:46 +00:00
20ea299742
Cleanup.
2024-02-28 22:18:26 +00:00
d08e0e9eaa
_() -> _HKI() for group names.
2024-02-28 17:50:51 +00:00
141d03c266
Fix sheet pin align to grid issue.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16920
2024-02-28 11:57:49 -05:00
0314540fdb
Keep schematic text upright (especially when opening v6 schematic).
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17082
(cherry picked from commit bec068324e
2024-02-28 15:25:39 +00:00
9a9d6f2afb
Sheet synchronization dialog layout improvements.
2024-02-28 08:08:03 -05:00
fe349be48b
Eeschema, DIALOG_CHANGE_SYMBOLS: fix incorrect initial lib link name when
...
changing symbols: the "old" displayed link was in fact the new link because
the link was updated before the report is created.
Fixes #17162
https://gitlab.com/kicad/code/kicad/-/issues/17162
2024-02-28 11:21:17 +01:00
31fab831ad
Remove unnecessary assert
...
GetModifyHash can be called before a row is loaded
2024-02-27 19:03:06 -05:00
2dce618f9f
Expose text size for SCH_FIELDs.
2024-02-27 17:48:09 +00:00
a5fda819eb
Fix typo.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16991
2024-02-27 17:16:14 +00:00
3079f7c742
Fix copy pasta.
2024-02-26 22:29:29 +00:00
ac0758eca0
Only change pin assignments from user interaction.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16349
2024-02-26 19:02:00 +00:00
d16b5fb810
Handle single-source DC analyses correctly.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17119
2024-02-26 19:02:00 +00:00
23169ca1a7
Post merge request clean up.
2024-02-26 07:54:22 -05:00
2f6c9d1f3a
ADDED: Selection filter for schematic editor
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14988
2024-02-25 17:44:10 -05:00
aef87b9796
Push thickness handling down into EDA_TEXT::SetBold().
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17077
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14875
2024-02-25 17:28:52 +00:00
7789dfcfdc
fix a compil issue (missing include and nullptr_t -> std::nullptr_t)
2024-02-25 16:26:05 +01:00
f7721f385a
Symbol editor: add option (view menu+toolbar) to show/hide invisible pins and fields
...
Fixes #8020
https://gitlab.com/kicad/code/kicad/-/issues/8020
2024-02-25 16:09:50 +01:00
be81bce637
Add Feature: synchronize hierarchical labels and sheet pins
2024-02-25 14:23:59 +00:00
d939004bbd
Fix use-after-free in Altium importer
...
If the library already contains a symbol with the same name,
SaveSymbol will replace the existing symbol,
which will invalidate a cached pointer.
2024-02-25 08:47:07 -05:00
99948de45a
Support pin count and footprint filters in symbol editor.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17105
2024-02-25 13:14:31 +00:00
dba2fdb6d3
Don't import invalid polygons.
...
If we *do* get a 2-point polygon in SVG, import it as a segment.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17091
2024-02-25 12:28:19 +00:00
caa83ec9bd
Fix missing unit initialization.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17076
2024-02-24 22:34:41 +00:00
9a02712c4f
Update VDMOS models to ngspice-41 (and later) defaults.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17073
2024-02-24 20:05:51 +00:00
f77de66f4e
Generalize ERCItem inspections.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10539
2024-02-24 20:05:51 +00:00
e7abeb3c38
Cleanup.
2024-02-24 20:05:51 +00:00
fa0ead98d8
Split out table editing and table cell editing.
2024-02-24 20:05:51 +00:00
3282e4bb66
Formatting.
2024-02-24 20:05:51 +00:00
782af3a918
Clear text before replacing in ImportSettingsFrom.
2024-02-24 20:05:51 +00:00
e760317af6
ADDED: Implement footprint link checking in ERC.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16842
2024-02-24 20:05:51 +00:00
d7e4a8cebd
ADDED: ERC/DRC exclusion comments.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16020
2024-02-24 20:05:51 +00:00
c8d2a9340b
ADDED: ExpandAll/CollapseAll for hierarchy pane.
2024-02-24 20:05:51 +00:00
4eefbc7815
ADDED: textbox and tablecell margins.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10672
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6806
2024-02-24 20:05:51 +00:00
e445249720
ADDED: PCB tables.
2024-02-24 20:05:51 +00:00
91df43c97a
ADDED: schematic tables.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6806
2024-02-24 20:05:50 +00:00
4a9df1e18e
ADDED: actions for left-, center-, and right-justifying text items.
...
(For both PCBNew and EESchema.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12375
2024-02-24 20:05:50 +00:00
6347cb043e
Add bottom panel to have correct background in fp/sym chooser frames.
...
See https://gitlab.com/kicad/code/kicad/-/issues/15810
(cherry picked from commit 97ff48b426
2024-02-24 18:20:16 +03:00
5578b2c954
Hide unused message panel in footprint/symbol chooser frames.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15810
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15889
(cherry picked from commit badc4e7411
2024-02-24 18:20:16 +03:00
b7b64d959f
Performance UpdateDanglingState
...
Avoid O(N^2) by spatial sorting, don't run checks if the bounding boxes
don't overlap.
A second copy is ordered by type to help classes that only want to check
a few types having to walk the whole list.
2024-02-23 19:21:44 +00:00
f3c2083018
Performance SCH_EDIT_FRAME::SchematicCleanUp
...
Avoid O(N^2) comparisonis by spatial presorting. If bounding boxes don't
overlap there's no need to run expensive checks.
2024-02-23 19:21:44 +00:00
006f93773c
Fix collecting of signals for S-Parameters analysis
2024-02-23 18:34:21 +00:00
cb25c8620e
Performance optimizations for database libraries.
...
(cherry picked from commit e68df8e1d1
2024-02-23 20:29:18 +03:00
e5896374e3
Normalize SCH_PIN BBox to fix assert.
...
(cherry picked from commit 3e26e7b646
2024-02-23 20:29:18 +03:00
72354ac033
Eeschema: select graphical shapes based on effective shapes.
...
(cherry picked from commit a13e4e7d9f
2024-02-23 20:29:18 +03:00
12c21abdff
Don't use EQUALITY flag when doing a symbol diff with library.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16944
(cherry picked from commit adae4de438
2024-02-23 16:53:36 +01:00
4a561b04bc
Code cleanup and compiler warnings.
...
(cherry picked from commit 51848a0b43
2024-02-23 16:53:35 +01:00
98cd040952
Set up default netclass wire & bus widths.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17024
(cherry picked from commit 2d7f4faf72
2024-02-23 16:53:35 +01:00
2c49ba4252
Formatting.
...
(cherry picked from commit c75bb5d01a
2024-02-23 16:53:35 +01:00
19dedccd98
Improve layout of schematic colors preview.
...
Also, set pin name/number sizes. Don't use defaults (which
will get plucked out of the Symbol Editor's settings).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17043
(cherry picked from commit df8f043c16
2024-02-23 16:53:35 +01:00
17a37a55f0
When updating RefDes only update the prefix.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16991
(cherry picked from commit b6036f368e
2024-02-23 16:53:34 +01:00
2cd9fbab9d
Check known m_Desc field before m_Fields.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16971
(cherry picked from commit 25291d6e3a
2024-02-23 16:53:34 +01:00
ca3cd706e5
Show friendly name in toolbar button tooltips.
...
(Don't require the same text to be put into the tooltip.
It's error-prone and also disallows us from having a separate
tooltip for toolbar buttons.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17009
(cherry picked from commit f4a085575a
2024-02-23 16:53:33 +01:00
800bbd8841
Delete empty Netclass fields only if there are others.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16997
(cherry picked from commit a34b242f4e
2024-02-23 16:53:33 +01:00
57dcf285c5
Various string issues held over from 8.0 string freeze.
...
(cherry picked from commit a610542a19
2024-02-23 16:53:31 +01:00
23c2104ffa
Improve alignment tooltips.
...
(cherry picked from commit 2ab492474e
2024-02-23 16:53:31 +01:00
f161a1eaac
Ignore duplicate/repeat when drawing an existing item.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16885
(cherry picked from commit 3caede3799
2024-02-23 16:53:30 +01:00
9ff66d0e71
Don't capture references to local variables for CallAfter.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16934
(cherry picked from commit 9d40374baf
2024-02-23 16:53:30 +01:00
d464d7995b
Thread safety: replace ++m_modHash by IncrementModifyHash()
2024-02-23 14:59:10 +00:00
991ddfe6be
Add cache to SCH_IO_DATABASE to improve loading performance
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17031
2024-02-23 14:59:10 +00:00
07ab18a1e6
Legacy libraries: De-duplicate field names on load
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16902
2024-02-23 14:57:57 +00:00
420413969e
Altium: Don't create duplicate fields
2024-02-23 14:57:57 +00:00
1a6e6a06eb
Altium: Don't load library parameters with an owner for now
...
In Altium many objects can have parameters (including pins). For now
we will drop library parameters belonging to any sub-components of a
symbol.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17048
2024-02-23 14:57:57 +00:00
27911d9b5a
Fix crash when changing sheet file name that contains a highlighted net.
...
Performing a full connectivity rebuild after changing a sheet file name
ensures that there are no stale connectivity object pointers laying around.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17011
2024-02-17 08:50:22 -05:00
206a631135
Ensure stream is valid before checking for Eagle XML tag
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16989
Fixes KICAD-7QQ
2024-02-16 11:14:10 +00:00
f894a41dc2
LIB_SYMBOL::IsMulti() seems to be wrong, use the iterate conditional as the multi-unit check instead
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16932
2024-02-16 00:18:05 -05:00
9e08e6e4f1
USe setactive in cli in the LoadSchematic helper too
2024-02-16 00:08:10 -05:00
7b0bb59b37
Remove hard-coded versioned env vars in most places
2024-02-15 15:31:08 +00:00
0775d1364a
Add bezier icon
...
Fixes https://gitlab.com/kicad/code/kicad/issues/16830
2024-02-14 02:01:01 +01:00
f73d45b0cf
Add $schema prop to drc/erc
2024-02-13 19:08:55 -05:00
c92728715d
Schematic: import schematic sheet content, allow move and undo
...
Otherwise, the schematic is just plopped on the screen, causing
connections and junctions to be missing that should be present.
2024-02-13 12:18:46 -05:00
12c8f5b14d
Update compatibility mode and save flags in ngspice.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16955
2024-02-13 14:50:15 +00:00
2afe4db945
Add some missing newlines in cli output without changing strings
2024-02-11 21:12:21 -05:00
6a37f99e94
Fix crash if we exit lib table setup
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16917
2024-02-11 21:05:23 -05:00
d694bb5960
Use file name rather than path for erc/drc json and text reports
2024-02-11 20:16:22 -05:00
b5982f7319
EasyEDA import: force close some line chains.
2024-02-11 23:52:56 +03:00
bf9d085c15
EasyEDA schematic import: fix nan center for elliptic arcs.
2024-02-11 23:52:56 +03:00
22669bcc4d
Unselect saved image when reverting a commit if modified item is unselected
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16938
2024-02-11 11:55:02 -05:00
ec2cd99405
Guard actions that change project against running in non-standalone mode
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16942
2024-02-11 09:36:17 -05:00
ef0204a44b
Remove debug output
2024-02-11 09:04:10 -05:00
4eba781013
Try harder to remove stale pins from connectivity
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16846
2024-02-10 23:26:37 -05:00
24cf0c0c62
use new align-to-grid icon
2024-02-11 01:30:47 +00:00
e302261067
More issue #16846 invalid pointer checks.
...
This has now pushed the issue down to a broken RTree issue. Skipping the
asserts in debug builds will still crash but now it's pushed down to the
RTree.
2024-02-10 15:41:10 -05:00
b409aee28a
Force schematic symbol pin update when reverting a commit.
...
Apparently somewhere in our schematic code base we are allowing pins
to be added to symbols without correct setting the parent symbol object.
This causes all kinds of issues when the pin's parent object need to be
accessed.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16846
2024-02-10 08:49:41 -05:00
ae9175927b
Fix broken schematic pin selection caused by commit 1ac5666164.
2024-02-10 08:26:52 -05:00
ff17a22e31
Internationalize Image Properties dialogs.
2024-02-10 08:34:19 +03:00
d3ca82b0b5
Fix another build error
2024-02-09 20:18:13 -05:00
cd548e392a
Add document type icons
...
Update Macos script to use doctype icons for icns builds
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14754
2024-02-09 15:55:57 -08:00
f303996f9c
Add new icons for tools
...
Align elements to grid
Cleanup graphics
Cleanup tracks/vias
Drag
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16206
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16205
2024-02-09 15:55:57 -08:00
04ccf7e885
Explicitly create wxStrings for assignment to make MSVC builds happy.
2024-02-09 17:37:36 -05:00
9e9ee96181
Explicitly create wxString for return value.
2024-02-09 17:11:49 -05:00
dc48af3e5c
EDA_ITEM::SwapData() must not swap the parent pointer.
...
The image's parent pointer might have gone out of scope.
2024-02-09 20:10:12 +00:00
302038fbfd
Do not assume schematic child objects have a valid parent.
2024-02-09 13:16:07 -05:00
1ac5666164
Do not de-reference null library pin object pointers in SCH_PIN object.
2024-02-09 11:07:04 -05:00
3d690da305
Fix schematic editor crash when dragging symbols.
...
Do not set view items or update connectivity until after commit changes
are updated in the SCH_SREEN. Updating the screen can force LIB_SYMBOL
changes which and lead to stale LIB_PIN object pointers stored in SCH_PIN
objects.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16846
2024-02-09 10:38:29 -05:00
aef6b2a66e
nullptr safety and a bit of wxT'ing.
2024-02-09 13:56:01 +00:00
334b414826
Make sure SCH_PIN->LIB_PIN pointers get cleared
2024-02-09 08:09:19 -05:00
3c45145401
Set move flags at beginning of move.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16891
2024-02-09 10:19:39 +00:00
ca6b40ef1c
Make sure to create power axis when restoring state
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16912
2024-02-08 17:48:12 -05:00
f8b8bc78bd
Make m_originalColWidths impervious to init-order issues.
2024-02-08 15:09:07 +00:00
b4c361f5cc
Order matters in PEGTL grammar.
...
(Because a flagParam will also match "param", but not the
other way around.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16900
2024-02-08 14:54:54 +00:00
1a91bb369c
SCH<->PCB: fix pin cross probing
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16910
2024-02-08 09:02:03 -05:00
8efd90e6e8
Allow reading of 0 text sizes.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16902
2024-02-07 16:46:42 +00:00
bce372c8a3
Don't clear the undo/redo list when we're just trimming it.
...
We only allow a certain number of commands on the lists
and trim them when they overflow. PCB_BASE_EDIT_FRAME and
PL_EDITOR_FRAME implemented this correctly; SCH_EDIT_FRAME
and SYMBOL_EDIT_FRAME did not.
2024-02-07 14:52:10 +00:00
e55a803572
Altium schematic import: do not overwrite sheet name.
2024-02-07 05:06:49 +03:00
a32d5174a1
Altium schematic import: clear harness port list after parsing Additional.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16894
2024-02-07 05:06:49 +03:00
65c0a0a629
ConvertImageToPolygons: fix images with no alpha.
...
Fixes KICAD-714
2024-02-06 21:38:00 +03:00
08b02f2a1a
Add junction color property
2024-02-05 19:12:09 -05:00
899ed59f7b
Add missing pin numbers/names properties
2024-02-05 19:08:56 -05:00
0778a7d46d
Fix Windows build.
2024-02-06 00:38:21 +03:00
be1bbda8ce
Altium: Fix bug when symbol uses multiple display modes on one sheet.
2024-02-05 22:36:30 +03:00
d8c72e845c
Altium schematic: support component's DISPLAYMODE being a string.
2024-02-05 22:36:25 +03:00
82e353deb7
Notify property inspector after sheet properties dialog.
2024-02-05 19:10:22 +00:00
1ff36f23b8
Clean up stale TODOs.
2024-02-05 15:49:57 +00:00
da46a96623
Update a few strings based on new string freeze policy.
2024-02-05 15:49:57 +00:00
6a9914bf89
Lib Symbol Properties: make exclude from BOM string same as symbol props
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16876
2024-02-05 09:02:46 -05:00
a0c39715df
HTTP LIB - Fine tuning
2024-02-05 12:11:01 +00:00
c39e7b2225
Tweaks in eeschema for hidpi
2024-02-05 01:03:52 -05:00
92c2ddf77a
Do not parent dialogs to non top level windows in panels or widgets.
2024-02-03 10:40:28 -05:00
b58f318d3f
Add volume to IBIS cache path
...
Fixes #16655
2024-02-03 09:35:36 +00:00
7cc663ad77
Schematic parity checking for CLI DRC.
2024-02-02 23:05:37 +00:00
2b1bf369f2
Do not parent file or directory dialogs to panels.
...
Parenting dialogs to child windows of top level windows is most likely
not defined behavior. It's also likely that this behavior varies across
platforms so it' best not to risk doing it. wxWidgets does not check if
the dialog parent is actually a top level window. There may be other
places we are doing this with our message dialogs so we should do an
audit.
2024-02-02 09:20:36 -05:00
ff3288dab6
Add quotes around paths when KIBIS generates waveforms via ngspice
...
Fixes #16655
2024-02-01 17:20:16 +00:00
e8f51b61a6
EEschema, net navigator: save settings when closing Eeschema.
...
Fixes #16845
https://gitlab.com/kicad/code/kicad/-/issues/16845
2024-02-01 12:53:33 +01:00
7c6ee16b22
removed the dots for several strings in the settings dialog
...
https://gitlab.com/kicad/code/kicad/-/issues/16651
2024-02-01 08:52:57 +00:00
7664c345e2
Revert "Schematic performance enhancements"
...
This reverts commit df654ac12f
2024-02-01 09:00:13 +01:00
df654ac12f
Schematic performance enhancements
2024-02-01 02:28:09 +00:00
466c707e91
Check for invalid library pin object pointer.
2024-01-31 12:17:11 -05:00
Wayne Stambaugh
Jeff Young
Seth Hillbrand
Maciej Suminski
Alex Shvartzkop
jean-pierre charras
Mark Roszko
Mike Williams
afkiwers
JamesJ
Jon Evans
Ian McInerney
Ethan Chien
aris-kimi
Michal Grzegorzek
ecorm
Yon Uriarte
Lucas Dumont
Petri Hodju
Roberto Fernandez Bautista
Andrej Krpic
Graham Keeth
Andre Iwers
Ma Han