haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
36,815 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

9534 Commits

Author SHA1 Message Date
Jeff Young 66eafc56bb Don't suggest we're going to cancel already-added signals. 2022-12-23 12:46:18 +00:00
Jeff Young 3f49fa5361 Don't write sim.params for library model unless we actually have overrides. 2022-12-23 12:46:18 +00:00
Jeff Young cd7be966c0 Fix typo when un-escaping parameter name. 2022-12-23 12:46:18 +00:00
Jeff Young 7f60b87d1d Implement fallback models for SPICE .lib models that we can't parse. 2022-12-22 22:35:09 +00:00
Jeff Young d0d6dc6ce0 Clang-tidy warnings reduction. 2022-12-22 22:35:09 +00:00
Mike Williams 9b782fa827 Schematic: don't deselect line ends when right clicking off-selection 2022-12-22 14:16:38 -05:00
Mike Williams 8b7d0d71fb Schematic: show update/change symbols for multiple symbol selection 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13231
 2022-12-22 14:00:51 -05:00
Jon Evans 66799b60f8 DbLib: Reconnect if connection is lost 2022-12-22 12:15:04 -05:00
Mike Williams 3037f2b444 Schematic: don't require cursor on selected net to assign netclass 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13199
 2022-12-22 10:15:48 -05:00
Jeff Young 7abfa46531 Inferred sim value improvements, and a unit test for them. 2022-12-21 17:03:49 +00:00
Jeff Young e64852c833 Clearer naming. 2022-12-21 17:03:46 +00:00
Jeff Young e7e3f3bced SIM_MODEL code simplification. 
1) Reduce API surface.
2) Prefer for(int) loops when what we're looking for is the index of
   the item to be found
3) Move "_" escape processing to SIM_MODEL_NGSPICE (which is the only
   model which uses the escape mechanism)
 2022-12-21 17:01:58 +00:00
jean-pierre charras 8e4911bba2 Simulation: make a few errors thrown from PEGTL a bit more understandable. 2022-12-20 18:54:14 +01:00
Mike Williams 093c0c2c98 Schematic: add simulation button to toolbar 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/2331
 2022-12-20 08:56:36 -05:00
Mike Williams fc054bda8e Schematic: fix edit symbol assert 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13197
 2022-12-20 08:23:02 -05:00
Jeff Young 97010b598d Update all units when a schematic symbol is edited in the Symbol Editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13208
 2022-12-19 23:09:13 +00:00
Mike Williams 389f0655cd Schematic: re-enable old break wire functionality, add slice 
Also fix break/slice wires for multiple wires. The shortcut and code
always allowed it, the context menu just didn't appear.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13163
 2022-12-19 15:55:59 -05:00
Jeff Young 8db015bc0f Accept thousands separators in inferred values. 2022-12-19 20:05:54 +00:00
Jeff Young 58ce0bb804 Simulation bug fixes. 
1) Use C-locale when converting output of parsers to strings.

2) InferSimModel() must run on local copy of fields, not the fields in
the symbol (which might be different if they've already been edited in
the Symbol Properties Dialog, for instance).

3) InferSimModel() should accept a deviceType already set to RLC.

4) Don't output trailing decimal separators if there's no fraction.
 2022-12-19 18:14:13 +00:00
Jeff Young cbb70f0da1 Formatting and CLang-Tidy warning reduction. 2022-12-19 13:51:49 +00:00
Jeff Young 113fd83fdd Fix Clang-tidy warnings. 2022-12-19 13:19:21 +00:00
Jeff Young ebcc1ac062 Use current cursorPos when creating sheet pins. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13206
 2022-12-19 12:27:55 +00:00
Jeff Young a3a2e2e5b1 Update demos and legacy qa files SpiceMapping -> Spice_Node_Sequence. 
Also removes migration in the code as it will no longer be needed.
 2022-12-19 12:04:53 +00:00
Jeff Young 04f50ce687 Generate default pinMap from symbol's pins when we don't know SIM_MODEL's pins. 2022-12-19 11:40:52 +00:00
Jeff Young df8eb59854 Don't use SPICE_MODEL_SUBCKT::CreatePins to crate a default pinMap. 
(It creates a fully-unconnected map on the premise that it's easier
to add a pinMap than to edit one.  This is probably no longer true
now that you don't have to un-assign a pin before re-assigning it.)
 2022-12-19 11:40:52 +00:00
Jeff Young 1ce6cd6d4d Naming clarity. 2022-12-19 01:51:24 +00:00
Jeff Young 7433322778 Handle a couple more legacy formats found in legacy_sallen_key demo. 2022-12-19 01:47:23 +00:00
Jeff Young b06c245b8f Don't double-add DC parameters. 
(Remember that DC's inlineTypeString used to be "".)
 2022-12-19 01:19:55 +00:00
Jeff Young 7192c565b8 Add simple VI model inference. 2022-12-18 22:54:12 +00:00
jean-pierre charras a9acb2e215 Fix incorrect format in a wxString::Format() 2022-12-18 20:30:15 +01:00
Ian McInerney 618347ef50 Regenerate ibis dialog to remove unused sizer from header 
It appears the dialog had already been updated to remove it from the
formbuilder project and the cpp file, but the header wasn't checked in
at the same time.
 2022-12-17 23:37:24 +00:00
Ian McInerney 2f8cc194c1 Initialize variables inside file dialog customizer classes 2022-12-17 23:37:24 +00:00
Ian McInerney 0bd39516c4 Cleanup eeschema save as extra control creation to match pcbnew 2022-12-17 23:37:24 +00:00
Jeff Young 8324c0b0cc Fix event order bugs in Sim Model Editor dialog. 
onParamGridChanged was firing before CommitPendingChanges which meant
the edited value didn't get saved if the editor was still open when
OK was clicked.
 2022-12-17 22:33:00 +00:00
Jeff Young 321de57d7c Bug fixes for simulator. 
1) Finish removing pin-count based APIs.  We need to know the pin names
as well, not just the count.

2) Fix a bug in the regexp for SPICE functions to allow both lowercase
and uppercase function names

3) Move CreatePins() overrides to the new API so that we get pins on
raw SPICE models.

Fixes https://gitlab.com/kicad/code/kicad/issues/13190
 2022-12-17 20:29:24 +00:00
Jeff Young 6b70c679cf Migrate more V6 SPICE syntax to V7. 
Also fixes various bugs if symbols contained non-indexed pin numbers.
We really need to know the actual pin names when creating models, rather
than just assuming 1, 2... etc.

Fixes https://gitlab.com/kicad/code/kicad/issues/13183
 2022-12-17 15:23:51 +00:00
Jeff Young 09302296f4 Use SCH_SHEET_PATH interface to get page numbers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13021
 2022-12-16 22:49:42 +00:00
Jon Evans 5abf73e3c9 Never call ReCreateMenuBar inside a menu event handler 
As of wxWidgets 3.2, the wxWidgets event handler runs code after the
the client event handler that depends on the menu still existing.
Because there are potentially many paths to call ReCreateMenuBar from
within a menu event handler, let's just wrap this action in a CallAfter
to make sure it happens after the wx handler call completes.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/13149
 2022-12-16 16:37:51 -05:00
Jeff Young 65552df6ce Quite Coverity. 2022-12-16 19:11:34 +00:00
Jeff Young dba3c589d0 More bug fixes for escaped model parameters. 
Note that this whole escaping thing seems like a bad idea to me, but
I don't fully understand the difference between model parameters and
instance parameters so I don't know if there's a better way to handle
it or not....More bug fixes for escaped model parameters.

Note that this whole escaping thing seems like a bad idea to me, but
I don't fully understand the difference between model parameters and
instance parameters so I don't know if there's a better way to handle
it or not....More bug fixes for escaped model parameters.

Note that this whole escaping thing seems like a bad idea to me, but
I don't fully understand the difference between model parameters and
instance parameters so I don't know if there's a better way to handle
it or not....More bug fixes for escaped model parameters.

Note that this whole escaping thing seems like a bad idea to me, but
I don't fully understand the difference between model parameters and
instance parameters so I don't know if there's a better way to handle
it or not....More bug fixes for escaped model parameters.

Note that this whole escaping thing seems like a bad idea to me, but
I don't fully understand the difference between model parameters and
instance parameters so I don't know if there's a better way to handle
it or not....More bug fixes for escaped model parameters.

Note that this whole escaping thing seems like a bad idea to me, but
I don't fully understand the difference between model parameters and
instance parameters so I don't know if there's a better way to handle
it or not....More bug fixes for escaped model parameters.

Note that this whole escaping thing seems like a bad idea to me, but
I don't fully understand the difference between model parameters and
instance parameters so I don't know if there's a better way to handle
it or not....More bug fixes for escaped model parameters.

Note that this whole escaping thing seems like a bad idea to me, but
I don't fully understand the difference between model parameters and
instance parameters so I don't know if there's a better way to handle
it or not....More bug fixes for escaped model parameters.

Note that this whole escaping thing seems like a bad idea to me, but
I don't fully understand the difference between model parameters and
instance parameters so I don't know if there's a better way to handle
it or not....

Fixes https://gitlab.com/kicad/code/kicad/issues/13179
 2022-12-16 16:34:41 +00:00
Jeff Young 08a8a20794 Sort pins in numeric order before attempting to match to SPICE model. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13164
 2022-12-16 14:18:44 +00:00
Jeff Young 24786fe0e9 Fix multi-unit symbol bugs. 
1) SPICE pins need to include all units
2) Already-seen-unit-x needs to be reset when getting netlist again.

Fixes https://gitlab.com/kicad/code/kicad/issues/13164
 2022-12-16 13:57:46 +00:00
jean-pierre charras 89153ca75a Eeschema: fix incorrect calculation of unit id in reference: U1.A was shown as U1A. 
Fixes #13178
https://gitlab.com/kicad/code/kicad/issues/13178
 2022-12-16 11:48:26 +01:00
Seth Hillbrand 6d5a9153ab Move resolve function to general usage 
Libraries are created multiple times, so we need to resolve the library
locations each time

Fixes https://gitlab.com/kicad/code/kicad/issues/13083
 2022-12-15 15:34:48 -08:00
Seth Hillbrand e91c039ed3 Prevent event stackup when init pages 
The paged book initialization (and others) can generate events,
re-laying out the whole dialog multiple times during initialization.
This halts events during the layout period

Fixes https://gitlab.com/kicad/code/kicad/issues/13158
 2022-12-15 11:39:03 -08:00
Jeff Young a41f27a022 Silence Coverity. 2022-12-15 18:14:19 +00:00
Seth Hillbrand bb7682f913 Resolve using env/project if lib isn't found 
Relative include commands resolve in the following order:

1. local to the file from which they are included
2. local to the project
3. local to the SPICE_LIB_DIR directory

Fixes https://gitlab.com/kicad/code/kicad/issues/13083
 2022-12-15 09:41:25 -08:00
Wayne Stambaugh 84f927d057 Schematic import bug fix. 
Check for already loaded schematics in the current sheet path as well
as the current project root sheet path to prevent multiple loads of
shared schematic.  This bug was causing shared sheets to be loaded more
than once which caused instance data to get separated by each copy rather
than saved in one copy of the schematic which would result in all instance
data being lost except the last saved copy of the schematic.  This bug has
been around forever and may be the cause of some unexplained schematic
instance data corruption issues.  This bug does not apply when opening
the full project.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11076
 2022-12-15 09:58:39 -05:00
Jeff Young 1e812b8b69 Remove selection from grid before deleting rows. 2022-12-15 14:40:57 +00:00
Jeff Young a8e73cf92c Check for model existence in library. 2022-12-15 14:25:25 +00:00
Jeff Young 5ef9fbdd19 Fix broken loop logic. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13168
 2022-12-15 14:22:03 +00:00
Jeff Young af71c2d877 Clear hover selections after command. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13073
 2022-12-15 13:47:56 +00:00
Jeff Young 00a5fddda4 Simplify library model name from combobox to choice. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13168
 2022-12-15 12:13:16 +00:00
Graham Keeth ba585e9b3a Fix BOM script description 
script name aside, bom_csv_grouped_by_value.py also sorts by sym name
and footprint
 2022-12-15 07:08:53 +00:00
Seth Hillbrand f0a8182532 Update for wx3.0 compatibility 2022-12-14 16:41:52 -08:00
Seth Hillbrand c86688d280 Ensure we have a subgraph 2022-12-14 16:41:52 -08:00
Jeff Young b2e512bfab We must infer a pinMap when inferring other fields for RLC passives. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13162
 2022-12-14 23:23:41 +00:00
Jeff Young 93879532f7 More wxTextCtrl minimum widths. 2022-12-14 23:23:41 +00:00
Jeff Young a2ba9137b8 Use only first letter of prefix for RLC primary value name. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13162
 2022-12-14 23:23:41 +00:00
Seth Hillbrand 10a3d57193 Add sim_lib callback to resolve embeded libs 
Also teach parser to look for include directives in libraries

We get KiCad variable resolution in include pathnames for free.

Fixes https://gitlab.com/kicad/code/kicad/issues/13083
 2022-12-14 13:31:41 -08:00
jean-pierre charras cdcf875ec0 sim_model: Fix another not handled exception that fully freeze Eeschema. 
Can happens with schematics with old sim parameter syntax.
Fix also another crash in sim_model.
 2022-12-14 17:47:20 +01:00
Jeff Young ce6378fed3 Use symbol pin names for left-hand-side of auto-generated pinMaps. 2022-12-14 15:13:29 +00:00
Jeff Young 5984a6dddd Fixup a few more collapsing textEditCtrls on Mac. 2022-12-14 15:13:29 +00:00
Jeff Young 6abdfc76da Replace 1:1 pin map on legacy conversion now that we can accept indexes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13152
 2022-12-14 14:22:35 +00:00
Jeff Young 77998d7c51 Better fix for not selecting all of netlist. 2022-12-14 14:13:25 +00:00
Jeff Young 13d9b061ee Don't select all of netlist when showing it in simulator. 2022-12-14 13:36:29 +00:00
Jeff Young e41b0775db Fix a bug with underscores being appended to spice param names. 2022-12-14 13:36:29 +00:00
Jeff Young 50ccc4e6da Fix issue converting legacy SPICE models. 
1) if a legacy model references a library then we need to see if said
   libraray exists and read model from it if so
2) legacy node ordering is by index, not pin name
3) we can't auto-generate a pin map when we don't know the pin names,
   so don't try
 2022-12-14 13:36:28 +00:00
Jeff Young c0872364d4 Get rid of bloated bitmap buttons on wxWidgets 3.2. 2022-12-13 20:48:02 +00:00
Mike Williams af4e9968fc Schematic: remove internal Change Sheet action from hotkeys 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13157
 2022-12-13 13:55:23 -05:00
Mike Williams 5e72a1008b Schematic: don't trim unchanged segments that are connected 
Previously if you had a wire with two unconnected ends and dragged the
end of another wire to connect with one end, it would delete the first
wire.
 2022-12-13 09:03:23 -05:00
jean-pierre charras bbdb30135e sim_model: Fix a not handled exception that fully freeze Eeschema. 
Can happens with schematics with old sim parameter syntax.
 2022-12-13 11:15:02 +01:00
Marek Roszko 6eedbe4a14 Allow taking hidden fields into account for symbol unit bounding box 
Even the GUI export of svg wasn't taking fields into account which rendered the fields regardless of status
 2022-12-12 22:47:56 -05:00
Marek Roszko f1f5fff072 Add cli export of symbols from kicad libraries 2022-12-12 22:44:26 -05:00
Seth Hillbrand bc8366cd95 Don't report a pin if the pin is null 
The pins can exist on a different sheet from the no-connect.  In this
case, we do not set the ERC for the current sheet to the remote pins,
instead only link the NC
 2022-12-12 19:29:15 -08:00
Jeff Young f24372bc18 Layout adjustments for wxWidgets 3.2. 2022-12-13 00:47:19 +00:00
Seth Hillbrand 413637b732 Add missing translation string 2022-12-12 13:07:53 -08:00
Mike Williams 243727428a Selection: non-greedy box selection of wires ends only when dangling 
See discussion:
https://gitlab.com/kicad/code/kicad/-/issues/13022#note_1205902448
 2022-12-12 15:04:33 -05:00
Mike Williams d824b7f506 Schematic: move wires always moves the whole line 
Discussion here:
https://gitlab.com/kicad/code/kicad/-/issues/13022#note_1205922621
 2022-12-12 14:45:06 -05:00
Mike Williams fe01c65794 Schematic Lines: add marker for unselected, connected line ends 
Smaller, subtler version of the marking used for unconnected line ends.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13126
 2022-12-12 14:45:06 -05:00
Mike Williams 5ce0fe5998 Selection: drop non-greedy full line selection from middle 
It's too inconsistent to have greedy and non-greedy mode, and also have
tweaks to the non-greedy mode that make it greedier.
 2022-12-12 14:45:06 -05:00
aris-kimi 43d4dd0b7b Fix some eeschema textbox tooltips 2022-12-12 19:41:26 +00:00
Seth Hillbrand 15c8e87549 Allow passive pins in stacking def 2022-12-12 11:15:38 -08:00
jean-pierre charras 96a9ec4a0c Enhance compatibility with V6.0 for Intersheetrefs fields associated to GLOBAL labels. 
In V6.0, the identifier is "Intersheet References" and was not immediately
seen as Intersheetrefs field.
 2022-12-12 16:38:04 +01:00
Jeff Young ccbbd2ddd9 Clear seleciton so wxWidgets doesn't go looking for deleted row. 2022-12-12 14:43:37 +00:00
Jeff Young ca5c0e2ac5 Fix typo. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13137
 2022-12-12 14:42:45 +00:00
Jeff Young 2459b61aa6 Don't add second half of line and new juction to screen twice. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13129
 2022-12-12 13:44:47 +00:00
Jeff Young 45eae3e594 Don't Simplify() polys with arcs in them. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13134
 2022-12-12 12:54:34 +00:00
Jeff Young c7603372b5 Use consistent naming. 2022-12-12 12:54:34 +00:00
Jeff Young f75d18c7c8 Slight improvement to schematic editor title bar. 
Also improves some other clients of PathHumanReadable(), such as the
set page number dialog.
 2022-12-12 12:54:34 +00:00
Jeff Young 346530a5b1 Nullptr safety to attempt to prevent Sentry crash. 
https://sentry.io/organizations/kicad/issues/3712084175
 2022-12-12 12:54:34 +00:00
Jeff Young e890986e01 Fix crash when grid tries to access deleted field. 2022-12-11 23:12:55 +00:00
Jeff Young 419fe236ad Fix logic error in parsing sim command, and DC source types in dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9064
 2022-12-11 23:12:55 +00:00
Jeff Young b2498f5673 Coding standards & formatting. 2022-12-11 23:12:55 +00:00
jean-pierre charras bdf13ade7a Fix a compil issue on linux, round 2 2022-12-11 20:43:10 +01:00
jean-pierre charras 32995a31c6 Fix a compil issue 2022-12-11 20:19:56 +01:00
Jeff Young 5c53daadb0 Mostly coding standards, but also quote codemodel names before passing to spice. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12687
 2022-12-11 18:42:57 +00:00
Jeff Young 65538ccad4 Rename files and classes to match dialog name. 
Also a bit of formatting cleanup.
 2022-12-11 18:42:57 +00:00
jean-pierre charras a57ca559aa sch_field named Intersheetref in global labels: fix incorrect behavior when loading a sch file. 
This is a special field, always existing, that cannot be handled like other fields.
Also avoid using translated names when initializing the field name.
Translated names can be used only in UI, not in internal data.
fixes #13113
fixes #13125
 2022-12-11 18:56:14 +01:00
Jeff Young fbd2d66a75 Convert formatting constructs for SPICE consumption. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11383
 2022-12-11 15:53:26 +00:00
Jeff Young 9c129ed03f More dialog adjustments for wx 3.2. Also renames files to match dialog. 2022-12-11 15:49:29 +00:00
Jeff Young 56aae7a147 Reduce compiler warnings. 2022-12-11 13:39:59 +00:00
Jeff Young 3581a9773f Move simulator settings disposal earlier so it happens before parent. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12370
 2022-12-11 01:32:20 +00:00
Jon Evans 2b94b7df77 DbLibs: Support empty virtual table names 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12902
 2022-12-10 16:35:11 -05:00
Jon Evans 39a8ab8738 Make sure to set the lib table for a plugin before it gets used 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12847
 2022-12-10 16:04:54 -05:00
Jon Evans 966dee6730 A screen must always be generated for a new sheet 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13104
 2022-12-10 14:32:24 -05:00
Mike Williams f4fb70e04c Schematic: re-allow partial selection of line ends 
Also fix some XOR selecting issues.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13022
 2022-12-10 13:17:42 -05:00
jean-pierre charras be8f99e8fe Another fix to avoid conflict names issues with mingw + pegtl. 
Fixes #13118
https://gitlab.com/kicad/code/kicad/issues/13118
 2022-12-10 14:28:05 +01:00
jean-pierre charras e74654a20f Minor fix to avoid conflict names issues with mingw + pegtl. 2022-12-10 08:21:35 +01:00
Alexander Dewing 91290e8f75 vsrious cleanup, seeing if we dont need to ignore_item for python 2022-12-09 23:48:31 +00:00
Alexander Dewing 02325130fa Initial arm64 work 2022-12-09 23:48:31 +00:00
Jeff Young 1599490197 Formatting. 2022-12-09 22:25:14 +00:00
Jeff Young 1baec20cf6 Handle SPICE <-> SI conversions in inferred models. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13112
 2022-12-09 22:02:52 +00:00
Jeff Young 60c937186a When migrating simulation models update value to a reference. 2022-12-09 20:24:25 +00:00
Jeff Young 05b9836f60 Remove ugly hack of passing SCH_SYMBOL as parent of LIB_FIELD array. 
Also adds simulation model inference to Symbol Editor's Simulation Model
Editor, and adds write-back from both Simulation Model Editors to their
parent Symbol Fields Editor dialogs.

Fixes https://gitlab.com/kicad/code/kicad/issues/12505
 2022-12-09 20:24:25 +00:00
Jeff Young 3ae404f764 Move model inference to SIM_MODEL so it can also be used for behavioral models. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12505
 2022-12-09 20:24:25 +00:00
Wayne Stambaugh 945361ca65 Fix schematic editor crash when saving shared schematics. 
Shared schematics can have a root sheet instance when opened with the
schematic editor in stand alone mode.  This would cause a crash when
opening the shared schematic in a project where it was shared because
the root instance was trying to be saved in the normal sheet instance
data which is not valid.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/13102
 2022-12-09 10:02:16 -05:00
jean-pierre charras 9a2d8e6b6b Fix a collision name with a windows header (msys2) 
LoadLibrary is changed to LoadSymbolLibrary, due to a header included by pegtl
having a #define LoadLibrary ...
 2022-12-09 09:36:58 +01:00
Seth Hillbrand eaf56bc05a Fix NC and label connection logic 
label has 0 pins -> unconnected label warning
label has 1 pin -> OK only if also has a NC marker, otherwise unconnected pin warning
label has >1 pins -> OK only if has no NC marker, otherwise "NC is connected" warning

Thanks @craftyjon for helping work out the details
 2022-12-09 02:14:05 +00:00
Jeff Young 8931e55dd2 Templatize MigrateSimModel() so it can be used on LIB_SYMBOLs as well. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13080
 2022-12-08 23:57:43 +00:00
Jeff Young cfbf14ebfd Attempt to fix build issue with NGSPICE off. 2022-12-08 23:57:42 +00:00
Jeff Young 107025322c Better column width handling for sim params grid. 2022-12-08 23:57:42 +00:00
Jeff Young 6535f407a6 Remove version guard from sim migration, and add migration to paste. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13080
 2022-12-08 23:57:42 +00:00
Jeff Young e8980e9024 Centralize SPICE lib path resolution and support SPICE_LIB_DIR. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13081
 2022-12-08 23:57:42 +00:00
Jeff Young bb6544914e Bring simulator file menu commands more in line with rest of Kicad. 2022-12-08 23:57:42 +00:00
Mike Williams 0e75bf02fa Selection: refactor modifier checking 2022-12-08 14:12:12 -05:00
Mike Williams 78b5dbead6 Schematic: show partial selection of graphic lines 
Use the same inverted-dangling-shadow as regular wires

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13095
 2022-12-08 14:12:12 -05:00
Mike Williams 4b02e5efb4 Schematic: allowing ctrl/shift-clicking point editor points 2022-12-08 14:12:12 -05:00
Barabas Raffai add082548d Move timer used by SCH_EDITOR_CONTROL to member variable 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2430
 2022-12-08 17:33:19 +00:00
jean-pierre charras 0098dfa6dc Ensure exported spice netlist contains all spice directives found in schematic 2022-12-08 14:03:47 +01:00
Stefan 1fcdd94caf add missing whitespace 2022-12-08 07:36:59 +00:00
Marek Roszko 2fc0cd68ed Avoid crashing due to empty lib tables in cli 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13097
 2022-12-07 23:56:03 -05:00
Jon Evans 5251ea6f27 Prevent crash on exit due to simulator settings being double freed 2022-12-07 21:04:49 -05:00
Seth Hillbrand 9a5df73060 ERC: don't flag hierarchically connected NCs 
NCs require no more than one pin on the full net.  They may also have
multiple labels connecting them.
 2022-12-07 13:48:25 -08:00
Wayne Stambaugh b95ce69054 Disconnect event handlers in symbol properties dialog dtor. 
This is probably a good rule of thumb to prevent any event ordering
issues between platforms or unhandled events being trigger during
inherited object destruction.
 2022-12-07 14:27:36 -05:00
Jeff Young b15913bd53 Support env variables in spice library paths. 
Also removes a bunch of std::string stuff from the file handling in the
simulator.  All our file handling, env variable expansion, project path,
etc. stuff is wxString based, and jumping through std::string in between
just makes it more complex and increases the potential bug surface.

Also fixes a bug where you'd get two error messages when a spice model
library wasn't found.

Also fixes a bug where you'd get a spice model library not found error
when the text field was empty.

Also fixes a bug where we'd try to absolutize a path starting with an
unresolved text or environment variable.  If the path starts with a
variable it's probably absolute, and tacking on the project path in the
error message just obfuscates things.

Fixes https://gitlab.com/kicad/code/kicad/issues/13082
 2022-12-07 15:07:25 +00:00
jean-pierre charras 6130ce5d66 symbol_editor_control: fix incorrect bounding in SVG export. 
Fixes #13093
https://gitlab.com/kicad/code/kicad/issues/13093
 2022-12-07 13:13:35 +01:00
Jeff Young 4872dd7238 Don't put empty lines in the workbook. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12299
 2022-12-07 11:39:47 +00:00
Marek Roszko c0b5fe58c3 Implement output targeting of symlib/fplib upgrade per request 2022-12-06 21:20:27 -05:00
Jeff Young b9287968d6 Update symbol default prefixes after updating instance data. 
Also moves the sim model fixups after the instance data updating as
it uses the prefixes.
 2022-12-07 01:34:56 +00:00
Jeff Young 69448afb47 Don't run simulation twice when the sim command is overridden. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12731
 2022-12-07 01:34:56 +00:00
Wayne Stambaugh da0624286c Fix spelling error in schematic import exception handler. 2022-12-06 18:04:38 -05:00
Jeff Young 3836ec481f Add fixups for legacy syntax used during 7.0 development. 2022-12-06 16:01:18 +00:00
Jeff Young 39ad7c8205 Formatting and Kicad naming conventions. 2022-12-06 16:01:18 +00:00
Jeff Young 38906397d2 Move V6->V7 sim model migration from sheets to screens. 
Also moves passive RLC inference out from migration to just-in-time
creation for the simulator or netlisting.

Also fixes a version guard mismatch because the spice migration was
done inside UpdateSymbolInstances (which has its own version guard).

Also changed UpdateSymbolInstances to UpdateSymbolInstanceData so
someone else in the future doesn't think it's a general-purpose symbol
instance updater.
 2022-12-06 16:01:18 +00:00
Jeff Young f8e0a272c0 Remove a bunch of 'auto'. 2022-12-06 16:01:18 +00:00
Wayne Stambaugh 5001555f0e Fix crash in Altium schematic importer. 
The crash was caused by an unhandled exception. The uncaught exception
caused a cacophony of null configuration setting pointers so guards were
added to prevent crashes should other exceptions occur that do not get
handled correctly.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/13046
 2022-12-05 20:20:01 -05:00
Fabien Corona 4c76082f77 "Sim Params/Settings" -> "Sim Command" 
The window only really sets the simulation command.
In the future, we might want a simulation setting window with things such as SPICE optimizations.
 2022-12-05 23:12:04 +00:00
Jeff Young 8e4cd1e1a6 Check for sheet directive changes when running simulations. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10486
 2022-12-05 20:03:42 +00:00
Jeff Young 7e1fecaf2e Formatting. 2022-12-05 20:03:42 +00:00
Fabien Corona e861606871 sim: string change 2022-12-05 19:45:57 +00:00
Jeff Young b7d41e0e56 Update simulator with NUMERIC_EVAL, decimal separator processing, etc. 
Also includes fixes for instance data and resolving of textvar
references.

Also includes virtual d'tors for IBIS parser to get rid of all the
compile warnings on CLang.

Fixes https://gitlab.com/kicad/code/kicad/issues/12357
 2022-12-05 12:40:29 +00:00
Jeff Young f50b9799a6 Remove old code that was only needed when we auto-added netclasses... 
... to netclass flags.  They're now directive labels and the netclass
field isn't auto-added anymore.  However, we *do* auto-add an intersheet
refs field, and that's required.
 2022-12-04 21:06:35 +00:00
Jeff Young 1855885d1e Gracefully handle spice models not recognized by KiCad. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12689
 2022-12-04 21:06:35 +00:00
Jeff Young f29f0c5c0a Don't push a model that didn't load. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12689
 2022-12-04 21:06:35 +00:00
Jeff Young 672927e183 Clearer error message. 2022-12-04 21:06:35 +00:00
Jeff Young bed22272e5 Supply default values for random uniform voltage sources. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12861
 2022-12-04 21:06:35 +00:00
Jeff Young 49abd2682a Simulation model properties dialog improvements. 
1) Fix <TAB> processing
2) Don't hide/show controls where possible
3) Use a more concrete reference to primary parameter in Save to Value
checkbox
4) Move Save to Value checkbox into model section
 2022-12-04 21:06:35 +00:00
jean-pierre charras 6b9c82c975 eeschema: fix a crash when converting a old .sch file containing global labels. 2022-12-04 21:06:16 +01:00
jean-pierre charras 0562eaa7b1 Eeschema plot: fix some (minor) issues with page size option set to a fixed page-size 
Fixes #13062
Fixes #13056
Fixes #13057
However, DXF and HPGL is not perfect, but OTOH this is not an usual format for schematic.
PS format is not tested for now.
 2022-12-04 16:55:20 +01:00
Graham Keeth ef83d01455 Minor string changes: "eeschema" / "pcbnew" in tooltips, and power port terminology 2022-12-04 14:29:57 +00:00
Jeff Young adc5c9eb20 OpenGL render order appears to be the inverse of the drawing order. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13070
 2022-12-04 11:51:44 +00:00
Jeff Young 294a4804ed Minor dialog layout adjustments. 2022-12-04 11:51:44 +00:00
Jeff Young f805fd267f Divorce UNIT_BINDER from wxFrame. 
This allows us to supply Pcbnew or Eeschema as the unitsProvider when
called from the main frame.

Fixes https://gitlab.com/kicad/code/kicad/issues/13066
 2022-12-04 11:51:44 +00:00
Jeff Young f9b3f14dfa Bring intersheet refs in line with schematic setting when changing sheets. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13061
 2022-12-04 11:51:44 +00:00
Jeff Young 96819f6c01 Better cache invalidation for text objects with references. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13059
 2022-12-04 11:51:44 +00:00
jean-pierre charras 8ab8a48657 fix order of includes to avoid conflicts with a Windows header. 2022-12-03 10:59:46 +01:00
Fabien Corona bd235048f9 sim GUI: remove "Adjust value" checkbox. 
We had a change in notation and this checkbox became useless.
 2022-12-03 08:28:43 +00:00
Seth Hillbrand f9a36b9c91 Update thread_pool to 3.3 
Fixes an issue with `wait_for_tasks()` and adds a lower-overhead
`push_loop` helper.  We replace our usage of `parallelize_loop` with
`push_loop` as we didn't use the multi-future vector return and don't
need the extra overhead.
 2022-12-02 12:01:34 -08:00
Fabien Corona 6e45987005 fix build warning 2022-12-01 20:33:51 +00:00
Mike Williams 8f646fa9fb Schematic: fix XOR unselecting one end of fully selected line 2022-12-01 15:00:06 -05:00
Mike Williams 5b2020daf5 Schematic: only delete dangling lines not created directly by the user 2022-12-01 13:13:45 -05:00
Mikolaj Wielgus f38c5d8cd0 Sim: Add virtual destructor to SIM_SERDE 2022-12-01 17:18:55 +01:00
Mikolaj Wielgus 4ec7ea376e Sim Ibis: Minor code style changes 2022-12-01 17:13:37 +01:00
kliment 0f09172902 Eeschema: ibis_parser - Fix undefined behavior due to pointer aliasing in isNumberNA 2022-12-01 15:44:38 +00:00
Mikolaj Wielgus d2adcdfde0 Sim: Add "number of bits" parameter to KIBIS PRBS model and some more fixes 
The other fixes:

- PRBS's `m_bits` should be an integer.
- Fix some references to outdated parameter names.
 2022-12-01 09:19:41 +01:00
Marek Roszko bae8cb55c0 Rename the bom cli to pythonbom since we'll have a real bom system later 2022-11-30 19:56:59 -05:00
Seth Hillbrand d23f285f8c Avoid ngspice segfault 
When simulating an empty netlist, calling the `.save all` and `.probe
alli` commands gives a segfault in ngspice.  We can avoid this by
skipping these commands in KiCad.

Fixes https://gitlab.com/kicad/code/kicad/issues/12938
 2022-11-30 15:22:17 -08:00
Seth Hillbrand 01cf6d76d8 Remove newly dangling lines when dragging 
These lines are remnants from drag operations that should be cleaned
after commiting the new line positions

Fixes https://gitlab.com/kicad/code/kicad/issues/12870
 2022-11-30 13:46:38 -08:00
Wayne Stambaugh e517cad12b Fix broken hierarchical sheet file paths when adding nest sheets. 
The file path for each sheet must always be relative to it's parent sheet
or absolute if using a relative path is not possible.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/10868
 2022-11-30 15:44:59 -05:00
Seth Hillbrand ce63c37bfd Handle possible null in dynamic_cast 2022-11-30 12:30:49 -08:00
Wayne Stambaugh 0a62c17040 Remove schematic symbol value and footprint field instance data. 
https://gitlab.com/kicad/code/kicad/-/issues/12933
 2022-11-30 11:47:13 -05:00
Mikolaj Wielgus 7d207c5d2f Sim Ibis: Change some strings for consistency 2022-11-30 17:38:09 +01:00
Mikolaj Wielgus e39c0b20ea Sim: Universally initialize enum parameters with their default values 2022-11-30 12:45:59 +01:00
Mikolaj Wielgus 39cd9f8980 Sim: Fix Sim.Params field generation logic 
Don't generate the first parameter (e.g. for KIBIS it was 'vcc=""') when
it is empty in models without primary value.
 2022-11-30 12:45:58 +01:00
Seth Hillbrand 09cc6decaf ADDED: ERC for missing units 
Reports a warning (by default) for missing units
Reports an error for missing units with power input pins
Reports a warning for missing units with input pins
Reports a warning for missing units with bidi pins

Fixes https://gitlab.com/kicad/code/kicad/issues/1922
 2022-11-29 23:49:55 +00:00
Seth Hillbrand 4f4e355ce5 Reset existingRefs on cancel 
When placing, we need to keep our static pointer map valid.  If we
cancel the placement after annotation, we need to remove the annotated
symbol.  The safer way is to just recreate the map

Fixes https://gitlab.com/kicad/code/kicad/issues/12983
 2022-11-29 13:37:23 -08:00
Jeff Young 193e8715f9 Replace wxASSERT with wxCHECK2. 2022-11-29 21:12:53 +00:00
jean-pierre charras f3aff63726 Fix minor compil warnings 2022-11-29 20:05:58 +01:00
Jeff Young b2177718a1 Tighten up refresh logic for net & netclass references. 
Also tightens it up a bit for text variables which can reference things
like netnames and netclasses, but also board settings.

Fixes https://gitlab.com/kicad/code/kicad/issues/13032
 2022-11-29 15:18:36 +00:00
Jeff Young a105f6c297 Add asserting checking. 2022-11-29 14:24:20 +00:00
Mikolaj Wielgus ab6caca384 Sim: Remove duplicate parameters 2022-11-29 15:02:45 +01:00
Mikolaj Wielgus b025b103de Sim Model Editor: Make the VBIC model the first BJT model to select 2022-11-29 10:13:20 +01:00
Mikolaj Wielgus 8143522371 Sim: Fix VDMOS model parsing 2022-11-29 09:48:01 +01:00
Marek Roszko 21fed9fc8c Hotglue a symbol upgrade function in cli 2022-11-29 00:00:45 -05:00
Fabien Corona 6510afe699 Ibis: Show the parser log if the parser fails 2022-11-28 17:46:42 +00:00
jean-pierre charras ef6348606a altium schematic import: convert ports to hierarchical labels instead of global labels 2022-11-28 17:56:46 +01:00
jean-pierre charras 149ddf9ddb PANEL_SETUP_BUSES: make delete a bus member working. 
the member list was not updated when deleting a member.
Fixes #13024
https://gitlab.com/kicad/code/kicad/issues/13024
 2022-11-28 17:55:04 +01:00
Jeff Young 9a25464337 Prevent nullptr dereference. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12516
 2022-11-28 13:38:41 +00:00
Mikolaj Wielgus 20ea191f66 Sim: Fix model param vs. instance param duplicates in diode model 2022-11-28 08:00:49 +01:00
Mikolaj Wielgus 7b1a460649 Sim: Fix unhandled MODEL_TYPE in SIM_MODEL_NGSPICE 2022-11-28 07:59:24 +01:00
Mikolaj Wielgus d836fbaaaa Sim: Add VBIC model support 
Update generate_sim_model_ngspice_data.bash a little, but it's still
outdated.
 2022-11-28 04:45:36 +01:00
Wayne Stambaugh ef624199cd Fix Altium schematic import bug. 2022-11-27 19:34:46 -05:00
Mikolaj Wielgus bbcb0c04fc Sim: Don't crash when parsing unknown model in a Spice file 2022-11-27 08:59:54 +01:00
Mikolaj Wielgus 71d194071b Sim: Allow Numparam expressions in models inside subckts 
Global-level numparam expressions are not properly supported yet.

Fixes https://gitlab.com/kicad/code/kicad/issues/12953
 2022-11-27 06:32:17 +01:00
Seth Hillbrand f1556ed801 Prevent mirror of text elements 
While we never allow the creation of mirrored text elements in the
schematic and symbol library editors, external generation of symbols may
cause the property to be set, which can then never be changed.  This
leaves the property unset for all elements

Fixes https://gitlab.com/kicad/code/kicad/issues/13007
 2022-11-26 10:48:44 -08:00
Alex 754e82535a Symbol Fields Table: Highlight the first unit in multi-unit symbols. 2022-11-26 17:30:30 +05:00
Mikolaj Wielgus 0b5814f98f Sim: Allow .subckt parameter lists without "params:" 
And fix .subckt parameter list parsing, because it was broken.

Fixes https://gitlab.com/kicad/code/kicad/issues/12779
 2022-11-26 10:24:11 +01:00
Mikolaj Wielgus 6f630f7054 Sim: Make library path textbox editable 
Load the library from the path if enter is pressed or focus is lost if
the library exists. If a library under the same path as previously is
to be loaded this way, don't do anything.

Fixes https://gitlab.com/kicad/code/kicad/issues/12970
 2022-11-26 03:55:20 +01:00
Wayne Stambaugh a89102fdfc Fix Altium schematic import library symbol bug. 2022-11-25 19:38:13 -05:00
Mikolaj Wielgus acc760dc25 Sim: Fix generation of Sim.Pins field in multipart models 
Fixes https://gitlab.com/kicad/code/kicad/issues/12372
 2022-11-26 01:34:10 +01:00
Mikolaj Wielgus 6d5cc9e606 Sim: Sort the generated Sim.Pins by symbol pin numbers 
They were sorted by model pin numbers, which weren't the keys in the
key=value pairs generated into Sim.Pins.
 2022-11-26 01:34:10 +01:00
jean-pierre charras a48d06c40d Better fix than commit f2efb9c6 for issue #13003. 2022-11-25 17:29:03 +01:00
jean-pierre charras f2efb9c601 Make symbol highlighting from Symbol Fields Table working again. 
Fixes #13003
https://gitlab.com/kicad/code/kicad/issues/13003
 2022-11-25 16:17:34 +01:00
Jeff Young 7e0ba42f0e Bug fixes for dragging labels attached to wires in orthogonal mode. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12677
 2022-11-25 15:05:15 +00:00
Simon Richter 6d1ab81261 Mark unused parameter 2022-11-25 14:10:30 +01:00
jean-pierre charras 6f438b6cad altium export: add messages about skipped items (IEEE_SYMBOL and PIECHART) 2022-11-25 09:51:13 +01:00
jean-pierre charras e5877e0840 netlist_exporter_xml: ensure the list of parts is included in netlist. 
This is obviously mandatory to build a BOM
DIALOG_BOM: generate a full xml netlis. We don't know what is needed by scripts
Fixes #12918
https://gitlab.com/kicad/code/kicad/issues/12918
 2022-11-25 08:55:21 +01:00
Mikolaj Wielgus a65b35107d Sim: Make Sim.Pins have key-value pairs instead of a sequence 
Moreover, upgrade models on schematic load instead of on model load
 2022-11-25 05:38:21 +01:00
Mikolaj Wielgus f5ebd6fb47 Remove unused SCH_SYMBOL::GetAllPins() 2022-11-25 05:38:21 +01:00
jean-pierre charras a71c669543 Altium importer: try to import elliptical arcs rather to skip them. 
Some schematics use elliptical arcs to describe usual arcs.
 2022-11-24 19:43:00 +01:00
jean-pierre charras 199743e8b0 altium/sch_altium_plugin: do not initialize unit to -1 for common to units items. 
-1 as unit id is illegal and breaks the lib file. So ensure id >= 0
(id = 0 for common to units items)
 2022-11-23 14:47:55 +01:00
jean-pierre charras b1ec694905 Add string change (see commit 7aac53c6) to dialogs/dialog_sim_model_base.fbp 2022-11-23 14:46:18 +01:00
Jeff Young 651b3f1349 SCH_FIELDs are in parent's coord system. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12979
 2022-11-23 13:22:50 +00:00
Wayne Stambaugh f5707eeca7 Fix assertion in schematic copy formatter. 2022-11-22 16:45:38 -05:00
Wayne Stambaugh 4a27d856f7 Move schematic sheet instance information into file sheet definition. 
This will make it possible to maintain sheet instance information when
copying and pasting from any sheet other that the root sheet of a
project.

Setting and getting sheet page numbers must now be performed using a
sheet path.  This was done to ensure that the instance paths were not
getting changed unexpectedly from different code paths.
 2022-11-22 16:45:38 -05:00
Fabien Corona 226dc9de78 Ibis: Don't create unnecessary B source 2022-11-22 21:09:08 +00:00
Fabien Corona 5d4b323009 Ibis : correct net name for device generation 2022-11-22 21:08:26 +00:00
Fabien Corona 7aac53c611 String change: add *.ibs to spice model editor 2022-11-22 21:07:40 +00:00
Mike Williams 60d42a7b1e Spelling: fix various suppress misspellings 2022-11-22 13:47:10 -05:00
Simon Schaak bd74489b00 Clean up autosave file handling edge cases 2022-11-22 15:21:26 +00:00
Seth Hillbrand 6625afabb7 Restore subgraph removal behavior 
Commit 938645b29d had lines commented out
for debugging purposes.  This commit restores the original lines

Fixes https://gitlab.com/kicad/code/kicad/issues/12165

Fixes https://gitlab.com/kicad/code/kicad/issues/12814
 2022-11-22 05:43:53 -08:00
jean-pierre charras b0b8a8dd67 Fix the order of some includes to avoid a conflict with a Windows header 2022-11-22 07:33:14 +01:00
Mikolaj Wielgus 23480cdee3 Sim: Make empty Sim.Params mean storing primary value in Value 2022-11-22 07:09:52 +01:00
Mikolaj Wielgus 1550a1e3a4 Sim Model Editor: Add "Save {} in Value field as "{}"" checkbox 2022-11-22 07:09:52 +01:00
Seth Hillbrand 938645b29d Add terrible hack to get subgraph netname 
In certain cases, the subgraph does not receive the proper netname,
preventing us from checking for correct pin counts.  This is a backwards
iteration of the net name <-> subgraph map to extract the proper name
and sibling subgraphs

Fixes https://gitlab.com/kicad/code/kicad/issues/12165

Fixes https://gitlab.com/kicad/code/kicad/issues/12814
 2022-11-21 15:19:45 -08:00
Seth Hillbrand e3cc0a5bc7 Prevent crashes when pasting symbols 
When pasting a symbol that originates in a non-standard library, the
symbol may _only_ have an instance in the sheet and so adding it to the
sheet updates the instance data and needs to be refreshed before
annotating
 2022-11-21 13:30:06 -08:00
Mikolaj Wielgus d63eac9778 Sim: s/SIM_MODEL_MUTUAL_INDUCTOR/SIM_MODEL_L_MUTUAL/ 2022-11-21 05:01:12 +01:00
Mikolaj Wielgus e9fe59a28c Sim: Rename the missed Sim_* fields to Sim.* 2022-11-21 03:33:11 +01:00
Mikolaj Wielgus 48f97bfec3 Sim Model Editor: Enable type dropdown on load when it should be 2022-11-20 22:56:01 +01:00
Mikolaj Wielgus 6969362813 Sim Model Editor: Don't provide library-only models as builtins 2022-11-20 22:07:39 +01:00
Wayne Stambaugh 6f90a63381 Fix legacy schematic symbol instance data bug. 2022-11-20 14:57:37 -05:00
Alex 12a55f20d3 Fix a mistake in grip margin. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12952
 2022-11-21 00:25:19 +05:00
Fabien Corona 8498630876 Ibis: correctly load QA files up to v2.1 2022-11-20 19:10:46 +00:00
Jeff Young 2919490e92 Use hash (not page no) to determine when we've found the current sheet. 
Also enforces strict ordering in another page number sorter, although
this has nothing to do with the bug below.

Fixes https://gitlab.com/kicad/code/kicad/issues/12043
 2022-11-20 13:12:44 +00:00
Jeff Young 3747cae7dc Reinstate marker searching. 2022-11-20 13:12:44 +00:00
Kevin Lannen 9e5d96b9d3 Pin Table Dialog: Set the pin parent when creating pins 
Removes the possibility of a pin getting created without a parent.
This fixes a bug where the first pin is created without a parent and then trying to reference the parent later causes a segfault.
 2022-11-20 11:13:27 +00:00
Kevin Lannen 83ecd466ae Pin Table Dialog: Rename m_part to m_symbol to match LIB_SYMBOL naming 
LIB_PART was previously renamed to LIB_SYMBOL, this renames the member
variable on DIALOG_LIB_EDIT_PIN_TABLE
 2022-11-20 11:13:27 +00:00
Mikolaj Wielgus 59501dfa15 Sim: Rename Ibis_* fields to Sim.Ibis.* 2022-11-20 03:53:10 +01:00
Mikolaj Wielgus 059ca8fc48 Sim: Rename Sim_* fields to Sim.* 2022-11-20 03:37:54 +01:00
Mikolaj Wielgus 0bdb601d8e Sim Model Editor: Make IBIS widgets hidden by default 2022-11-20 00:37:17 +01:00
Jeff Young b84066610e Use drag origin instead of current mouse pos for drag checking. 2022-11-19 21:01:45 +00:00
Mikolaj Wielgus 9b6f7d5db7 Sim Model Editor: Use SIM_LIB_MGR class to manage library models 2022-11-19 01:55:38 +01:00
Mikolaj Wielgus 21ae2dd1c0 Sim Model Editor: Initialize all IBIS models as IBIS devices 2022-11-19 01:55:38 +01:00
Jeff Young bc271a8d15 Protect move tool from re-entrancy. 
m_dragInProgress is usually sufficient, except when we haven't started
one yet.  In any case, conflating the two is probably a bad idea.

Fixes https://gitlab.com/kicad/code/kicad/issues/12936
 2022-11-18 17:08:38 +00:00
Jeff Young e09e521162 Remove GUI calls from netlisting. 2022-11-18 15:29:16 +00:00
Wayne Stambaugh 3c6f1cd0f9 Fix broken legacy schematic file save. 
Manual cherry-pick from commit a22c466639.
 2022-11-18 03:08:33 -05:00
Mikolaj Wielgus 0f4cc2450d Sim Model Editor: Don't throw an error on opening a NONE model 2022-11-18 09:06:55 +01:00
Mikolaj Wielgus 28e978ccc9 Sim Model Editor: Fix switching to NONE model in the SME 2022-11-18 09:03:41 +01:00
Mikolaj Wielgus e7c43ca20a Sim: Remove inference from Reference and Value 2022-11-18 08:39:15 +01:00
Wayne Stambaugh db993bc8cc Fix broken Eagle schematic import. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12893
 2022-11-17 09:35:10 -05:00
Jeff Young a61ac363c2 Excise the remaining occurrences of "Alias" for derived symbols. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12895
 2022-11-16 18:37:40 +00:00
Jeff Young bb446c8d01 Set fields into instance data. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12915
 2022-11-16 13:33:55 +00:00
Jeff Young 1b3f03a800 Don't feed wxWidgets negative column widths. 2022-11-16 13:33:55 +00:00
jean-pierre charras b9ac486000 simulator: remove unused includes, and reorder a few includes to fix conflicts 
Conflicts happen only on msys2 with wxWidgets 3.0. But this minor reorder
allows me to test Kicad compilation with "old" wxWidgets, used on Linux.
 2022-11-16 10:09:54 +01:00
Jon Evans 120dd654ef Apply inherit_properties to built-in fields 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12904
 2022-11-15 21:27:43 -05:00
Jeff Young 13f5c78e89 More tightening of group parent lifecycles. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12908
 2022-11-16 00:42:38 +00:00
Jeff Young 93c6d99a6d Move saving preferences out of the destructor. 
For other reasons we wrap the adapters in a wxDataObject, which has
delayed destruction semantics, but that means the settings stuff may
no longer be around when the d'tor executes.

Fixes https://gitlab.com/kicad/code/kicad/issues/12371
 2022-11-14 20:01:37 +00:00
Jeff Young bc0a753238 Slight improvement to overly-wide checkbox columns. 2022-11-14 20:01:37 +00:00
Marek Roszko 5fc860b357 Add schematic loading null check to cli 2022-11-13 18:47:00 -05:00
Jeff Young 9d8fdd8d53 Fire selection events from SelectAll(). 
Fixes https://gitlab.com/kicad/code/kicad/issues/12896
 2022-11-13 22:59:21 +00:00
Marek Roszko 39d5cc31d4 Add schematic xml bom output 2022-11-12 21:51:32 -05:00
Marek Roszko e109b5883f Replace string with extension variable 2022-11-12 21:27:10 -05:00
Mikolaj Wielgus b288e162d2 Sim Model Editor: Remove Override checkbox 2022-11-13 02:13:44 +01:00
Mikolaj Wielgus ce3362ee12 Sim: Don't write inherited model params to symbol fields 2022-11-12 23:50:11 +01:00
Mikolaj Wielgus d66d810edc Sim Model Editor: Use SIM_LIB_MGR to store instance models 2022-11-12 23:27:22 +01:00
jean-pierre charras 7c9f3981ef Revert "Reorder includes is some simulator files to fix issues on msys2 (no code change)" 
This reverts commit 78e45fa1b9.
Looks like it creates a compil issue on MSVC
 2022-11-12 20:47:36 +01:00
jean-pierre charras 7e3964e5cb Missing fix in previous commit 2022-11-12 20:01:47 +01:00
jean-pierre charras 78e45fa1b9 Reorder includes is some simulator files to fix issues on msys2 (no code change) 
Due to pegtl.hpp included in some files, reordering include fix some conflicts:
wxWidgets files must be included before pegtl.hpp, to compile with wxWidgets 3.0
I sometimes use wxWidgets 3.0 for debugging purposes.
 2022-11-12 19:54:26 +01:00
Mikolaj Wielgus 0d42003247 Sim: Create missing SIM_MODEL factories in SIM_LIB_MGR 2022-11-12 18:20:56 +01:00
Fabien Corona 0d78ca8b1a Ibis: GUI fixes 2022-11-12 14:39:36 +00:00
Mikolaj Wielgus 4caa65d100 Sim Model Editor: Don't use shared_ptr 2022-11-12 04:29:07 +01:00
Mikolaj Wielgus fef6eaa8ba Sim Model Editor: Don't use shared_ptr to hack around lifetimes 2022-11-12 03:15:27 +01:00
Mikolaj Wielgus 95b6cc80f5 Sim: PULSE source y2 param is "Pulsed value", not "Initial value" 2022-11-11 05:19:53 +01:00
Mikolaj Wielgus f33cd3e383 Sim: Remove vestiges of (de)serialization from SIM_MODEL 2022-11-11 05:17:26 +01:00
Mikolaj Wielgus 490069c5e6 Move (de)serialization of models into fields to new SIM_SERDE class 2022-11-11 03:08:32 +01:00
Marek Roszko 43f039ef5f Add netlist export cli 2022-11-09 22:37:55 -05:00
Jon Evans 108d5b5433 Add new properties to fields grid table 2022-11-09 21:43:37 -05:00
Jon Evans d9d3ccd6eb DbLib: Allow inheriting field properties from source symbol 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12856
 2022-11-09 21:24:31 -05:00
Jon Evans dbd498f451 Re-add keyword mapping 2022-11-09 20:50:01 -05:00
Marek Roszko 8832c5239e Add missing connectiongraph recalculate for the cli schematic load 2022-11-08 23:09:50 -05:00
Jon Evans 7c71f65869 Add new field attributes to Update from Libraries 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12839
 2022-11-08 22:32:47 -05:00
Jon Evans c07477b94c Move to explicit symbol properties mapping 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12845
 2022-11-08 22:19:08 -05:00
jean-pierre charras ffd578ef70 Ibis parser: fix a collision name with a windows header (msys2 specific) 
This is recurrent conflict. (fixed by changing INPUT to INPUT_SDT).
 2022-11-08 17:35:57 +01:00
Jeff Young ece752d5a2 Move annotation error reporting to preflight before simulation. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9220
 2022-11-08 12:13:15 +00:00
Jeff Young 5af506777c Formatting and wxT 2022-11-08 12:13:15 +00:00
jean-pierre charras 9501f4303d Rename CreateWindow to CreateKiWindow to avoid a collision name with a windows header 
No code change, but it fix an issue specific to msys2 that bother me when
trying to fix issues with wx 3.0.x version
 2022-11-08 12:31:07 +01:00
jean-pierre charras 05336798ac try to fix a wx3.0/wx3.1 compatibility 2022-11-07 20:28:00 +01:00
Mikolaj Wielgus e8762da4f4 Revert "Support for variable references in SPICE models." 
This reverts commit 95ebfeeed1.
This reverts commit 672ce650a9.
 2022-11-07 19:37:40 +01:00
Jeff Young 095f02e6ef Fix encoding issues in Simulation Model dialog's property grid. 2022-11-07 15:03:18 +00:00
Jeff Young 672ce650a9 Basic ERC for simulation models. 2022-11-07 13:33:00 +00:00
Jeff Young 8fc08b9185 Erc for simulation models. 2022-11-07 12:28:11 +00:00
Jeff Young 95ebfeeed1 Support for variable references in SPICE models. 
Also fixes a couple of bugs where sheet instance data wasn't being
handled correctly.
 2022-11-07 10:57:34 +00:00
Jon Evans 311741a9a3 Symbol library browser needs an infobar too 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12843
 2022-11-06 18:50:29 -05:00
Jon Evans dd94b2d3a7 Rename PROPERTIES to STRING_UTF8_MAP for clarity 
This class has nothing to do with the properties system
 2022-11-06 11:51:52 -05:00
Jeff Young 2899ee1eb4 Restore labelling and layout changes lost in revert. 2022-11-05 16:50:54 +00:00
Jeff Young 5366fa8cee Add mapping for -rescue.lib in project Save As. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12503
 2022-11-05 16:50:54 +00:00
Jeff Young 5aa8f9880e Honour aQuitOnDraw flag when cancelling a segment. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12832
 2022-11-05 10:23:12 +00:00
Jeff Young ae9405a4d3 Handle string escaping for Find/Replace in labels. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12789
 2022-11-05 10:23:12 +00:00
Bevan Weiss 8444339681 Prevent Pin Properties Alternate Pin pane closing on subsequent dialog open 2022-11-04 12:04:32 +00:00
Graham Keeth 6f3e969529 Update BOM dialog help 2022-11-03 22:49:20 +00:00
Jeff Young 2dac73e421 Remove dangerous SCH_FIELD::IsVoid() call. 
This call didn't differentiate between GetText() and GetShownText() and
was used in instances where the difference matters.
 2022-11-03 17:19:59 +00:00
Jeff Young f33b158696 Honour 0-size pin names & numbers when printing and plotting. 2022-11-03 17:19:59 +00:00
Alex cc825ebafe ADDED: bom_csv_grouped_extra.py BOM generator. 2022-11-03 17:09:55 +00:00
jean-pierre charras 504adb3467 Eeschema Back annotation: fix broken handling of full sheet paths of symbols. 
Fixes #12767
https://gitlab.com/kicad/code/kicad/issues/12767
 2022-11-03 11:15:23 +01:00
Marek Roszko 55ca6145ea Stuff RecomputeIntersheetRefs into SCHEMATIC for reuse 2022-11-03 00:12:53 -04:00
Marek Roszko 0190606886 Kick SetSheetNumberAndCount to SCHEMATIC 2022-11-02 23:38:02 -04:00
Jon Evans 0e454054f1 Also include resolved name when checking for bus membership 2022-11-02 17:37:34 -04:00
Sylwester Kocjan a234d5a2c8 common,eeschema,pcbnew: path cleanup 2022-11-02 13:29:52 +00:00
Wayne Stambaugh e62f764678 Update Eagle schematic importer to handle recent instance data changes. 2022-11-02 08:25:58 -04:00
Alex c279a2e696 Hotfix build when KICAD_SPICE=OFF 2022-11-02 11:03:09 +05:00
Marek Roszko b60c42ea41 Add schematic cli plotting 2022-11-01 23:34:49 -04:00
Jeff Young 9eef638f0b Don't validate on keystrokes. 
KiCad policy is to validate on focus-loss so that you can make changes
which have intermediate states that are not valid.
 2022-10-31 14:09:30 +00:00
Jeff Young 1737a3b94e Fix bugs where values didn't get commited to param grid. 
This would happen if you click on another grid cell after changing
a value, or clicking OK in the dialog.  The old value would get
saved and the new value lost.
 2022-10-31 14:09:30 +00:00
Jeff Young 6390c28737 Don't conflate instance and ibis widgets. 2022-10-31 14:09:30 +00:00
Jeff Young 20a4d76635 Reduce line-breaking. 2022-10-31 14:09:30 +00:00
Wayne Stambaugh 349de90bb0 Fix Altium schematic importer bug(s). 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11412
 2022-10-31 10:03:35 -04:00
Mikolaj Wielgus 355d5014f5 Revert changing inference checkbox to radio button 
Reverts 5e1561fc22
and 6c84e0c2f0.
 2022-10-31 07:29:38 +01:00
Jon Evans 5689c4b625 Include overridden drivers when checking bus membership 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10945
 2022-10-30 19:17:04 -04:00
Mikolaj Wielgus 5eca8dd8de Undo hardcoding swapping of diode pins 
Revert commits d1e2acd3 70b4d1aa cff508fb
 2022-10-30 11:01:59 +01:00
Jeff Young 5e1561fc22 Some bug fixes for inferred models. 2022-10-29 18:44:49 +01:00
Jeff Young 6c84e0c2f0 Dialog changes for inferred models. 2022-10-29 17:08:06 +01:00
Jon Evans 3f68b7c5c1 Don't consider sheet pins as connections in ERC 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9828
 2022-10-29 09:06:31 -04:00
jean-pierre charras 50d2237f06 command_export_pcb_dxf.cpp: switch to "C" locale before exporting the file 
Fix also a minor Coverity warning
 2022-10-29 09:45:45 +02:00
Jeff Young fb8493d0bc Move model pin editor to GRID_CELL_ICON_TEXT_POPUP. 
wxChoice is hopeless on Mac (it still doesn't highlight on rollover),
and using a char for the "assigned" graphic isn't great.
 2022-10-28 15:27:00 +01:00
Jeff Young a42c60d493 Less repetition in pin numbers. 2022-10-28 15:27:00 +01:00
Mikolaj Wielgus d1e2acd3d8 Sim: Reverse Cathode and Anode strings in diode model data 2022-10-28 15:16:34 +02:00
Mikolaj Wielgus 70b4d1aac8 Commit sim_model_diode.{cpp,h} 2022-10-28 14:29:32 +02:00
Mikolaj Wielgus cff508fb3b Sim: Reverse diode model pin order to match diode symbols 2022-10-28 14:01:09 +02:00
Jon Evans 3a9ed47bf0 Prioritize power symbols over hidden power pins on regular symbols 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8400
 2022-10-27 22:54:36 -04:00
Jon Evans 141c1f020e ERC: Include power connections in multiple driver test 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12138
 2022-10-27 22:36:40 -04:00
Jeff Young f3ba10ac67 Usability improvements to Pin Assignments in Sim Model dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12720

Fixes https://gitlab.com/kicad/code/kicad/issues/12721
 2022-10-28 00:34:24 +01:00
Sylwester Kocjan c0191e589e eeschema: use instance-specific unit in xml exporter 2022-10-27 14:33:24 +00:00
Sylwester Kocjan d18d2eed51 eeschema: don't save and restore schematic sheet in exporter 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11488
 2022-10-27 14:33:24 +00:00
Mikolaj Wielgus 20ffb7d334 Sim: Don't throw exception for certain garbage characters in Value field 2022-10-27 06:42:43 +02:00
Jeff Young a9a2cc3e84 Enhance readability of Simulation Model dialog. 2022-10-27 00:01:38 +01:00
Wayne Stambaugh 6a0db3e7e2 Fix Coverity warnings. 2022-10-26 14:39:44 -04:00
Mikolaj Wielgus aa0e3666d1 Sim: Skip param name when writing primary param in model's Value field 2022-10-26 09:03:02 +02:00
Mikolaj Wielgus 01c69f1066 Sim: Swap pins instead of inverting position variable in potentiometers 2022-10-26 03:57:53 +02:00
Jeff Young 1240a3dd9f Minor dialog layout improvements. 2022-10-26 00:49:18 +01:00
Jeff Young 445657022b Don't attempt to read simulation model if symbol isn't included. 
Also collect up all errors for one dialog when preparing simulation.
Also translate error messages.

Fixes https://gitlab.com/kicad/code/kicad/issues/12686
 2022-10-26 00:41:31 +01:00
Jeff Young 7f0ebf9e3b Outline font adjustment is only for SCH_TEXT, not labels. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12746
 2022-10-25 16:51:21 +01:00
Jeff Young 5f3d440ce3 Fix compile error. 2022-10-25 13:29:38 +01:00
Fabien Corona 20b63f305e Sim: Ibis improvements and fixes 
Follow-up after the KIBIS and KIBIS GUI merge requests.

- Move KIBIS from Pcbnew to Eeschema space,
- Make KIBIS obtain the Ku/Kd coefficients via the `SPICE_SIMULATOR` class instead of calling the `ngspice` executable via `system()`,
- Allow to toggle between differential and single-ended model in the GUI,
- Various GUI fixes and improvements.
 2022-10-25 09:45:40 +00:00
jean-pierre charras 6794b0f4f9 EEschema, arcs in library: fix incorrect data after conversion of some old 
libraries to the new arc format using startPoint, midPoint, endPoint.
Now, arc angles are constrained to < 180 deg.
Fixes #12514
https://gitlab.com/kicad/code/kicad/issues/12514
 2022-10-25 09:07:30 +02:00
Mikolaj Wielgus 3e0f4a47b0 Sim: Remove pins field in all inferred models with linear pin mapping 2022-10-25 08:52:12 +02:00
Mikolaj Wielgus 80c426f577 Sim: Fix writing inferred model for tlines 2022-10-25 08:52:12 +02:00
Mikolaj Wielgus d10fd7bb09 Sim: Remove tuner (log) scale choice button 
We probably won't be using it for now.
 2022-10-25 04:38:09 +02:00
Jeff Young 6c9d8f1ae7 GUI improvements to hierarchy navigator. 
(1) and (3) from the linked issue.

Fixes https://gitlab.com/kicad/code/kicad/issues/11762
 2022-10-24 23:00:44 +01:00
Jeff Young d0d354872b Formatting. 2022-10-24 22:38:53 +01:00
Jeff Young 3cb6a80954 Don't delete pin out from under selection & move tools. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12610
 2022-10-24 20:49:34 +01:00
Jeff Young 4a489a5d16 Respect CTRL key when resizing rects and textboxes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12732
 2022-10-24 11:36:20 +01:00
Jeff Young a072c22b74 Show pin hidden state in menu text. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5625
 2022-10-24 11:35:45 +01:00
Mikolaj Wielgus 0399d08aaa Sim: Fix potentiometers 2022-10-24 11:04:47 +02:00
Mikolaj Wielgus 9b6cc6c505 Sim: Fix tuners 2022-10-24 11:04:47 +02:00
Mikolaj Wielgus 78b193af5f Sim: Add tuner param virtual getter 2022-10-24 11:04:47 +02:00
Mikolaj Wielgus d14de1ce78 Sim: Rename Value field's "principal value" to "primary value" 2022-10-24 11:04:47 +02:00
Jeff Young cef7cd8f7c Move default font to RENDER_SETTINGS. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12723
 2022-10-22 21:32:42 +01:00
jean-pierre charras 75a3209e55 Eeschema plot: fix incorrect background color used to generate dimmed color. 
This is for a LIB_TEXT and a SCH_FIELD.
Fixes #12709
https://gitlab.com/kicad/code/kicad/issues/12709
 2022-10-22 17:03:11 +02:00
jean-pierre charras 63002cec57 Do not add a title/comment in mandatory field strings when writting netlists. 
This is mainly for "Sheetfile" property because current it is the only one
that has a title when plotting/drawing it.
 2022-10-22 12:50:26 +02:00
Mikolaj Wielgus 958bd1897d Sim: Add potentiometer model 2022-10-22 04:33:52 +02:00
Mikolaj Wielgus 2a5bc9f87e Sim: Don't accept lone '.' as Value principal value 2022-10-22 04:33:52 +02:00
Jon Evans 014d536954 Ignore lastDriver in connectivity 
Using the last driver in driver sorting breaks the stability/reproducibility
of the netlisting algorithm.  The last driver still needs to be tracked for
efficient redraw dirty detection.

Partially reverts 81e1bc9
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10757
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11393
 2022-10-21 22:29:25 -04:00
Jeff Young 34742b386d Honour dimming when printing fields. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12708
 2022-10-21 22:55:31 +01:00
Jeff Young 0de540594a Used dimmed setting for pin texts and textbox borders. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12705
 2022-10-21 22:42:44 +01:00
Jeff Young c9ce8da10a Dim DNP textbox borders. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12709
 2022-10-21 22:28:49 +01:00
Jeff Young bad410948d Don't assume text is on LAYER_DEVICE. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12707
 2022-10-21 22:03:54 +01:00
Mikolaj Wielgus 209ff933e7 Sim: Ignore everything between principal value and parameter-value pairs 2022-10-21 18:55:40 +02:00
Mikolaj Wielgus f95e77499b Sim: Make exception messages slightly more verbose 2022-10-21 08:15:29 +02:00
Mikolaj Wielgus 9819fa43dd Sim: Allow principal value in Value field to be followed by regular params 2022-10-21 08:14:13 +02:00
Mikolaj Wielgus d01dcc1c51 Sim: Interpret anything starting with .inc as .include 2022-10-20 05:13:32 +02:00
Mikolaj Wielgus 662f6c7d83 Sim: Don't match newlines in model names 
This caused errors in AKO models with no overrides.
 2022-10-20 04:00:33 +02:00
Mikolaj Wielgus 7ad927671d Sim Ltspice compat: Narrow ignoring undocumented parameters 2022-10-20 04:00:33 +02:00
Mikolaj Wielgus 5878749ed2 Sim LTspice compat: Ignore undocumented LTspice diode parameters 2022-10-20 04:00:33 +02:00
Wayne Stambaugh 85805bdad7 Fix broken legacy file format symbol instance data import. 2022-10-19 12:23:28 -04:00
jean-pierre charras c4db7337d0 NETLIST_EXPORTER_SPICE: add missing switch to "C" locale (missing LOCALE_IO). 
It breaks spice netlist in countries using a comma as floating number separator.
 2022-10-19 11:50:35 +02:00
Mikolaj Wielgus 7378aaae9d Sim: Ignore the "mfg" parameter in all models 2022-10-19 06:53:39 +02:00
Mikolaj Wielgus 952f3da53f Sim: Only set sim command if the sheet sim command is different 2022-10-19 03:02:32 +02:00
Mikolaj Wielgus f68df09696 Sim: Fix analysis set from GUI 2022-10-19 02:32:50 +02:00
Mikolaj Wielgus 1965411bf5 Sim: Remove the parsing exception for LTspice compat 
Silently ignoring this may be a cure worse than disease.
 2022-10-18 23:19:48 +02:00
Wayne Stambaugh 2a13c0af2e Revert commented out code. 2022-10-18 16:07:14 -04:00
Jeff Young 1964087960 Fix some instance-data issues in netlist exporters. 
Also removes the final requirements for setting the current sheet so
that we no longer need to do a save/restore.
 2022-10-18 17:26:34 +01:00
Mikolaj Wielgus 6e874f4c1e Ngspice: Preload a basically empty circuit to avoid error messages 
Fixes https://gitlab.com/kicad/code/kicad/issues/12481
 2022-10-18 05:48:01 +02:00
Wayne Stambaugh 598b09821a Coverity fixes. 2022-10-17 15:30:20 -04:00
jean-pierre charras aa36e15d66 Eeschema, Print preview: fix a incorrect initial size on wx 3.1.7 (and later) 
Due to internal changes in wxWidgets, the initial size of the frame was not taken in account.
 2022-10-17 10:49:28 +02:00
Mikolaj Wielgus 2475a703d6 Sim Model Editor: Checkbox for toggling inference 2022-10-16 05:10:57 +02:00
Mikolaj Wielgus c8e13813d9 Sim: Rename Sim_Disabled field to Sim_Enable 2022-10-16 00:49:44 +02:00
Wayne Stambaugh b109136c5c Fix complex hierarchy instance data when loading legacy schematic. 2022-10-15 14:50:06 -04:00
Wayne Stambaugh f782323960 Fix yet another symbol instance issue when loading legacy schematics. 2022-10-15 14:16:03 -04:00
Jeff Young 254dff2813 Add do_not_autoplace to schematic parser and printer. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12657
 2022-10-15 19:09:25 +01:00
Mikolaj Wielgus c3d5b3b3e5 Sim: Only store device type in reference, not full model type 
Instead of Reference="VSIN1", Value="dc=1 ampl=2 f=3", it's now
Reference="V1", Value="SIN dc=1 ampl=2 f=3".
 2022-10-15 19:36:26 +02:00
Marek Roszko 6ce714d537 Use wxCHECK instead of wxCHECK2 2022-10-15 11:25:15 -04:00
Marek Roszko ce2d091588 wxCHECK2 needs an actual "op", in this case return 2022-10-14 21:01:49 -04:00
Seth Hillbrand 5c974f8cd0 Don't arbitrarily close tags that are not open 
Fixes https://gitlab.com/kicad/code/kicad/issues/12647
 2022-10-14 15:30:51 -07:00
Jeff Young 668180f96a Add "show field names" to Global Edit Text & Graphics Properties. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12641
 2022-10-14 23:04:09 +01:00
Jeff Young 7ffdfb1067 Clear Scintilla undo history after setting initial text. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12650
 2022-10-14 22:01:20 +01:00
Wayne Stambaugh 41461f7a69 Improve symbol rescue dialog. 
* Fix some minor layout issues on Linux.
* Use button labels to clarify rescue actions.
 2022-10-13 10:37:04 -04:00
Jeff Young f9a791e2b0 Copy font across when changing text type. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12629
 2022-10-12 23:49:40 +01:00
Wayne Stambaugh 430098791e Another attempt to fix schematic symbol rescue issues. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12624
 2022-10-12 16:57:09 -04:00
Jeff Young 8dea227da7 Special cases for sheet-pin dragging. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11949
 2022-10-12 16:36:54 +01:00
Jeff Young 3231bc5be3 Formatting and cleanup. 2022-10-12 16:36:54 +01:00
Jeff Young 5507748fa9 Make sure bounding box is not degenerate. 2022-10-12 16:36:54 +01:00
jean-pierre charras 806b5fab0e SYMBOL_LIBRARY_MANAGER::SaveLibrary(): Add missing code. 
It fixes an issue after deleting a symbol and trying to save the library:
The library, although saved, was always flagged as modified.
 2022-10-12 15:56:41 +02:00
Mikolaj Wielgus c857e533a9 Sim: Fix crash when a field tries to set an inexistent parameter 
Refactored SetParamValue() and friends to use exceptions instead of
return values.
 2022-10-12 04:27:48 +02:00
Mikolaj Wielgus 6ae333a116 Sim Model Editor: Fix crash when opening sources 2022-10-12 04:27:48 +02:00
Jeff Young bd1114d94d Move footprint properties dialogs to symbol properties grid resizing strategy. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9883
 2022-10-12 00:38:44 +01:00
Jeff Young e02c05d38f Add unit and eval support to WX_GRIDs. 
Fixes https://gitlab.com/kicad/code/kicad/issues/1871

Fixes https://gitlab.com/kicad/code/kicad/issues/4285
 2022-10-11 23:40:58 +01:00
Jeff Young ad5df7f4cc More busy cursor tightening. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11648
 2022-10-11 23:40:58 +01:00
Wayne Stambaugh 148467d2a1 Fix schematic symbol rescue issues. 
This fix makes some fundamental changes to the way symbols are rescued:

* The new symbol library file format is used when rescuing symbols defined
  in the symbol library table.
* The original library nickname is appended to the symbol name rather than
  the rescue library nickname when rescuing symbol defined in the symbol
  library table.
* Escaping strings has been removed from legacy library rescues since the
  legacy library file format never supported it.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/12525

Fixes https://gitlab.com/kicad/code/kicad/-/issues/12624
 2022-10-11 16:18:59 -04:00
Jeff Young 8206283a20 Code clarity. 2022-10-11 11:22:26 +01:00
Jeff Young 3967435f94 Tighter control of busy cursor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11648
 2022-10-11 11:22:26 +01:00
Jeff Young d3797dd183 Code clarity. (No functional changes.) 
Also some more error message cleanup for consistency.
 2022-10-11 11:22:26 +01:00
Jeff Young 8a9e92bc01 More consistency in error messages. 2022-10-11 11:22:26 +01:00
Mikolaj Wielgus d47752ad75 Sim Model Editor: Fix displaying Ibis pin list 2022-10-11 02:22:59 +02:00
Mikolaj Wielgus d9eb76eae0 Sim: Refactor SPICE_GENERATOR methods to accept a single SPICE_ITEM 2022-10-11 02:22:59 +02:00
Jeff Young 1825905011 Replace more-than-half-line algorithm with greedy/stingy check. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10860
 2022-10-10 20:23:48 +01:00
Jeff Young cb20a39693 Always select whole lines with greedy selection. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10869
 2022-10-10 20:17:15 +01:00
Jeff Young 3221877fe8 Push autosave-require down in to EDA_BASE_FRAME. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11790
 2022-10-10 14:03:52 +01:00
Jeff Young be6f08deca Code clarity. (No functional changes.) 2022-10-10 14:03:52 +01:00
Mikolaj Wielgus 6d958c5a3b Sim: Remove some superfluous class members 2022-10-10 13:49:43 +02:00
Mikolaj Wielgus 4931b80066 Sim: Resolve name collisions for generated model names 2022-10-10 13:38:35 +02:00
Mikolaj Wielgus 72402cf687 Sim: Override base model type if there's a Sim_Type field 2022-10-09 20:46:05 +02:00
jean-pierre charras 79c301800a Eeschema printing: fix some issues. 
The offset setting was incorrect when using wxAffineMatrix2D.
It was especially visible when printing more than one sheet.
Note also when not using wxAffineMatrix2D, all pages must have the same orientation
(PORTRAIT/LANDSCAPE is not managed)
Fixes #12211
https://gitlab.com/kicad/code/kicad/issues/12211
 2022-10-09 18:20:19 +02:00
jean-pierre charras f5fd12c002 Symbol Editor: Fix reverting changes on a root symbol: derived symbols are displayed wrong 
Reverting changes broke links between derived symbols and the root symbol.
Now fixed by do not delete and recreate reverted symbol.
Fixes #10792
https://gitlab.com/kicad/code/kicad/issues/10792
 2022-10-08 15:56:24 +02:00
Mikolaj Wielgus 994274fe9f Move IBIS model Spice code generation to SIM_MODEL_KIBIS 
IBIS drivers are temporarily broken. Will fix is subsequent commits.
 2022-10-08 03:01:52 +02:00
Seth Hillbrand a5da46459c Be sure to update UUID when placing new elements 
Fixes https://gitlab.com/kicad/code/kicad/issues/12588
 2022-10-07 16:32:41 -07:00
jean-pierre charras 8c19bf4815 eeschema: fix arc orientation issue when reading old symbol libs (version 20210619). 
Fixes #12514
https://gitlab.com/kicad/code/kicad/issues/12514
 2022-10-07 16:57:45 +02:00
jean-pierre charras 01a1d148e6 Make a sentence understandable and translatable. 
Fix a minor compil warning
 2022-10-07 10:11:02 +02:00
Seth Hillbrand b4c18dd22a Correct error message when unit counts differ 
Testing if the symbol associated with unit X has a different number of
total units than the symbol associated with unit Y should report the
actual error to the user.

This cleans the various display of these error messages

Fixes https://gitlab.com/kicad/code/kicad/issues/10237
 2022-10-06 15:41:16 -07:00
Seth Hillbrand f369cc23a9 Handle arbitrary unit counts 2022-10-06 15:41:16 -07:00
Jeff Young 19d270fe74 Text size sanity checking for TEXT_ITEMS_GRID. 
Oh dear, there was a bunch going on here.  Firstly the move from int
to long long int for ValueFromString() means that we were no longer
catching overflows (as we were C-style casting it back to int in many
places).  But even when the overflow is caught, it would run in to
wxWidgets' empty string bug while trying to log it.

Fixes https://gitlab.com/kicad/code/kicad/issues/12577
 2022-10-06 13:19:08 +01:00
Mikolaj Wielgus 6f2b2d7e19 Sim: Minor SIM_LIBRARY cleanup 2022-10-06 14:08:01 +02:00
Mikolaj Wielgus b95f4ec6bb Sim: Use the new library manager class in Spice netlist exporter 
Temporarily comment out IBIS processing.
 2022-10-06 09:49:29 +02:00
Alex c019ae3b89 Add missing include 2022-10-05 20:21:38 +03:00
Seth Hillbrand a0aff2dc70 Set the proper symbol parent when duplicating 
We need to handle both the case where the new symbol is an alias as well
as free the proper memory after loading symbols in the duplicate

Fixes https://gitlab.com/kicad/code/kicad/issues/12578
 2022-10-05 09:46:13 -07:00
Mikolaj Wielgus 6df774a62f Commit missing sin_lib_mgr.{cpp,h} 2022-10-05 18:08:25 +02:00
Mikolaj Wielgus 44799c830d Sim: Create a class to manage sim libs and inherited models 2022-10-05 17:19:28 +02:00
Wayne Stambaugh 0336cff8d6 Allow schematic symbol value and footprint fields to be instantiated. 2022-10-05 11:12:21 -04:00
Mikolaj Wielgus 8e34dae347 Sim Model Editor: Fix exclude symbol checkbox 
Fixes https://gitlab.com/kicad/code/kicad/issues/12344
 2022-10-05 11:24:46 +02:00
Wayne Stambaugh 03d847118a Fix crash when copying symbol in schematic editor. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12574
 2022-10-04 17:51:58 -04:00