haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
40,360 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

834 Commits

Author SHA1 Message Date
Jeff Young 2ec21c7720 Don't check for board edge collision on castellated pads. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10970
 2022-03-14 20:19:09 +00:00
Jeff Young 65185f53a1 Rotate fp zones before comparing with library versions. 
Also includes some performance fixes to not copy around triangulation
data when it's not needed.

Fixes https://gitlab.com/kicad/code/kicad/issues/10143
 2022-03-14 15:53:24 +00:00
Jeff Young ced1e68ea1 A bit of wxT(). 2022-03-13 16:09:06 +00:00
Jeff Young db0b733be5 Clear DRC caches before running soldermask tests again. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10922
 2022-03-12 19:44:34 +00:00
Jeff Young 89e61ff73b More performance enhancements for DRC. 2022-03-12 14:17:52 +00:00
Jeff Young 6f555b6258 wxT() and some cleanup in DRC. 2022-03-11 23:19:16 +00:00
Wayne Stambaugh eec528ae48 Fix GCC build error on Linux. 2022-03-11 17:03:01 -05:00
Jeff Young ae307e1b34 Parallelize DRC triangulation, keepout processing, and sliver checking. 
Also fixes issue with adding fractured polygons in sliver checking which
slowed the board from hell down to less than a crawl.
 2022-03-11 20:52:11 +00:00
Jeff Young 663edcf665 Better progress indication for board from hell. 2022-03-09 14:30:21 +00:00
Jeff Young e4b56ab7f1 Performance fixes for the board from hell.... 2022-03-08 23:54:34 +00:00
Jeff Young 1fc99dd2c0 Don't call GetLayer() on a multi-layer object. 2022-03-05 23:07:43 +00:00
Jeff Young 843a56c4e4 Implement two-staged zone priority: assigned priority followed by UUID. 2022-03-01 14:53:35 +00:00
Jeff Young 914e706023 Replace zone-with-no-pads test with isolated copper test. 
The later is far more discriminating.

Fixes https://gitlab.com/kicad/code/kicad/issues/11009
 2022-03-01 12:02:17 +00:00
Jeff Young 79c7859052 Apply a19d9105f0 to zone case as well. 
Also improves on the previous comments.

Fixes https://gitlab.com/kicad/code/kicad/issues/10922
 2022-02-21 13:48:34 +00:00
Jeff Young 86988225c3 Exclude some fab attrs from library parity check. 
Also excludes zone outline hatching, which is just a visualization
property.

Fixes https://gitlab.com/kicad/code/kicad/issues/10903
 2022-02-19 14:59:50 +00:00
Seth Hillbrand a19d9105f0 Fix SolderBridge check to only check across multiple 
We should not generate an error when overlapping a single copper element
with a soldermask that is not associated with copper.

Fixes https://gitlab.com/kicad/code/kicad/issues/10906
 2022-02-18 11:47:28 -08:00
Jeff Young 6f6cf995ba Don't ask for layer of multi-layer item. 2022-02-18 14:53:10 +00:00
Jeff Young 1ee3ce45e8 Don't ask for layer of multi-layer objects. 2022-02-18 14:19:13 +00:00
Jeff Young ce0233577b Don't try to fetch layer of multi-layer objects. 2022-02-18 13:20:36 +00:00
Jeff Young e09ecd8380 Don't ask for layer of multi-layer objects. 2022-02-18 13:20:36 +00:00
Jeff Young 2172810600 Performance: better sharing of zone fills. 2022-02-15 19:19:03 +00:00
Jeff Young 3deaf902bb Retire the V5 zone fill algorithm. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10578
 2022-02-11 13:10:52 +00:00
Jeff Young 50a4d610a6 Be cognizant of flashed layers when generating pad shapes. 2022-02-11 13:10:52 +00:00
Jeff Young ca56de7816 Show DRC overflows in both tab titles and number badges. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10617
 2022-02-09 17:04:32 +00:00
Wayne Stambaugh 06e00c7957 Fix shadow variable compile warning in text DRC provider. 2022-02-08 09:26:12 -05:00
Jeff Young 3b5474f190 Don't punt on TrueType char thickness; analyze it. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10740
 2022-02-08 14:10:37 +00:00
Jeff Young 137edbe3f3 Add disclaimer for TrueType fonts to thickness test. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10740
 2022-02-08 14:10:37 +00:00
Jeff Young 3c5ae6d317 Don't let zone cutout on different layer confuse us about intersections. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10583
 2022-02-08 14:10:37 +00:00
Jeff Young 091055fa1d Don't count track as a pre-existing connection. 2022-02-08 14:10:37 +00:00
Jeff Young 5ce559176d Overhaul the font metrics calcs for overbar, italics and bboxes. 2022-02-07 17:36:40 +00:00
Jeff Young e59aaf05c6 Make sure that GetConnectedItems searches from the root item. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10583
 2022-02-06 19:43:25 +00:00
Jeff Young b2e3f03222 More wide-string declarations. 2022-02-05 22:03:04 +00:00
Marek Roszko 193dee11e8 Add missing null check PVS V595 2022-02-05 11:25:09 -05:00
Jeff Young c8d14ade65 Only run starved-thermals checks when pad is actually connected to zone. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10583
 2022-02-02 13:09:27 +00:00
Jeff Young 63a3b1e20a Estimate outline font thickness for DRC readability checks. 2022-02-01 12:01:04 +00:00
Jeff Young 1f8c29c395 Coverity fixup. 2022-02-01 12:01:04 +00:00
Jeff Young 5739505aa3 TextBoxes for PCBNew. 2022-01-31 20:00:47 +00:00
Seth Hillbrand c01e2dcfec Fix large memory leak in DRC 
All elements get effective shapes, many of which get triangulated.  This
memory needs to be freed when destroying the tree

(cherry picked from commit c2707f3cc0)
 2022-01-28 17:08:33 -08:00
Jeff Young 29841ba315 Bring ERC & DRC dialogs into parity. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9350
 2022-01-22 22:27:41 +00:00
Jeff Young 14006495d5 Angle cleanup. 2022-01-20 22:35:41 +00:00
Jeff Young 038db715a3 Move zone hatch orientation to EDA_ANGLE. 2022-01-19 00:34:03 +00:00
Jeff Young f60c05fc67 Use epsilon compartor for doubles. 2022-01-18 18:40:55 +00:00
Jeff Young 8c246a761d Move EDA_ANGLE from int to double. 2022-01-17 20:57:54 +00:00
Jeff Young 0967cc82e2 Exclude rules which match no enabled layers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10227
 2022-01-15 01:30:03 +00:00
jean-pierre charras bc77a1e2dd drc_test_provider_library_parity: fix a crash due to a incorrect if()...else() logic. 
The incorrect logic allowed execution of the else sequence when it should not be executed.
 2022-01-14 18:17:27 +01:00
Jeff Young 07013d00e1 More EDA_ANGLE. 2022-01-14 16:08:19 +00:00
Jeff Young abd3f5bc2b Move footprints to EDA_ANGLE. 2022-01-14 16:08:18 +00:00
Jeff Young d485eb2514 Move pads to EDA_ANGLE. 2022-01-14 16:08:18 +00:00
jean-pierre charras cf11abda3d Fix test_drc_regressions.cpp: disable tests that need a footprint library 
DRCE_LIB_FOOTPRINT_ISSUES and DRCE_LIB_FOOTPRINT_MISMATCH imply a library
but the test cases do not have a library.
 2022-01-12 15:57:41 +01:00
jean-pierre charras ea3efac2b6 drc/drc_test_provider_library_parity.cpp: protect against null pointer use. 
qa tests, test_solder_mask_bridging.cpp: filter not relevant DRC tests
 2022-01-12 14:41:11 +01:00
Jeff Young 8c6c87eaf4 Separate footprint lib issues from footprint mismatch issues. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10132
 2022-01-11 22:28:24 +00:00
Marek Roszko fcfe42d67c Continue the war on wxPoint 2022-01-10 19:52:26 -05:00
Jeff Young 21790fcab7 Fix a pair of dereference-freed-pointers in DRC. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10335
 2022-01-10 21:06:03 +00:00
jean-pierre charras c24985e8cf drc_test_provider_sliver_checker.cpp: skip very small vertices when testing. 
Very small vertices (length <= 2 or 3 iu) are frequent in filled areas, and
create false positive detections because one cannot calculate a meaningful
orientation of these vertices.
 2022-01-10 11:50:29 +01:00
jean-pierre charras 2b20a58615 Zone fill: fix an issue that uses thermal spoke width as thermal gap. 
Fixes #10300
https://gitlab.com/kicad/code/kicad/issues/10300
 2022-01-08 14:24:14 +01:00
jean-pierre charras 33dbe92deb drc_test_provider_mechanical_clearance: add missing handling of SHAPE_T::RECT 
test_ee_item.cpp: add missing call to ClearFieldsAutoplaced();
 2022-01-08 10:49:47 +01:00
Jeff Young b70cf1473f Allow solder mask aperture objects to inherit nets during DRC. 
The issue is that object A (the solder mask aperture object) can
bridge objects B and C which have different nets.  Since we only do
object-to-object compares we don't find this.  By allowing object A
to inherit the first net it collides with (either object B's or
object C's), we'll generate a violation with the second collision.

Fixes https://gitlab.com/kicad/code/kicad/issues/10189
 2022-01-03 20:58:01 +00:00
Jeff Young 0365c6bf4b Coverity fixes. 2022-01-02 14:57:03 +00:00
Marek Roszko 7d671cff1e Scoop up some more wxPoints 2022-01-01 21:06:40 -05:00
Tomasz Wlostowski dafa8ec671 pcbnew: fix incorrect type cast in DRC_TEST_PROVIDER_TEXT_DIMS 
FP_TEXT cannot be casted to PCB_TEXT for obvious reasons, but what I don't understand is why downcasting to EDA_TEXT also crashes due to incorrect vtable method pointer (Clang10/Linux here).

I leave this as a curiosity for whoever knows C++.
 2022-01-01 22:42:16 +01:00
Marek Roszko c4c56de708 Neurotically update position wxPoint usages 2022-01-01 11:55:51 -05:00
Marek Roszko 347e03363a Convert wxPoint/wxSize starting from EDA_RECT usages 2022-01-01 11:30:33 -05:00
Ian McInerney 0e9cfd0af2 Add missing initialization values to variables 
Flagged by Coverity.
 2021-12-30 23:42:06 +00:00
Erwan Rouault dc98419d85 pcbnew: Add via height support in drc length 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10135

(cherry picked from commit 11c967b259)
 2021-12-30 09:35:10 -05:00
Jeff Young ab583a32f9 Better layer handling for DRC markers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10126
 2021-12-26 15:06:12 +00:00
Jeff Young 03a5bd5319 Handle flipped footprints in library compare algorithm. 
Also fixes a bug where line styles weren't taken into account.

Fixes https://gitlab.com/kicad/code/kicad/issues/10107
 2021-12-25 13:41:59 +00:00
Jeff Young 09b7e0b72b ADDED Exclude Footprint from Courtyard Requirement. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9881
 2021-12-24 21:10:28 +00:00
Jeff Young d649b288a6 Swap out autoplace rotation costs for private footprint layers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/2291

Fixes https://gitlab.com/kicad/code/kicad/issues/5391
 2021-12-24 21:10:28 +00:00
Jeff Young fa908e1f98 Dimensions for footprints. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8441
 2021-12-24 21:10:28 +00:00
Jeff Young ed79f6e511 Clean up some TODOs. 2021-12-24 21:10:28 +00:00
Jeff Young b4c5e64db2 Exclusions for Unconnected Items; Markers & exclusions for Parity checks 
Fixes https://gitlab.com/kicad/code/kicad/issues/5589

Fixes https://gitlab.com/kicad/code/kicad/issues/5504
 2021-12-24 21:10:28 +00:00
Jeff Young b7e196b710 ADDED assertion constraints for user-defined DRC checks. 2021-12-24 16:13:18 +00:00
Jeff Young 4ba3937f8a Cleanup. 2021-12-24 15:43:24 +00:00
Jeff Young 0332ec6016 ADDED exclude all violations of rule X. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5463
 2021-12-24 15:42:22 +00:00
Jeff Young 5f37c2b247 Custom rule severities. 
ADDED severity token to custom rule syntax.  Each rule can now define
its own severity.

Fixes https://gitlab.com/kicad/code/kicad/issues/6148
 2021-12-24 15:42:22 +00:00
Jeff Young b2dff6fa55 Fix solder mask plotting issues. 
1) Don't plot all footprint texts for each footprint graphic item.

2) Enforce min web thickness around board shapes and board text.

3) Enforce min web thickness around footprint shapes

4) Correctly handle multi-layer zones.

(1) and (4) will get cherry-picked back to 6.0, so after rebasing
won't actually appear in this changelist anymore....
 2021-12-24 12:36:45 +00:00
Jeff Young ef10b36948 Add mask-to-copper clearance parameter and rename mask margin. 2021-12-24 12:36:41 +00:00
Jeff Young 3aa6d73770 Allow min/max/opt to come from different rules. 2021-12-24 12:36:37 +00:00
Jeff Young 4b6f2f0658 Add mechanical copper clearance testing for shapes. 
Also includes going from distance-based neighbor exclusion to angle-
based.  (Distance doesn't work when very short segments are followed
by very long ones.)

Fixes https://gitlab.com/kicad/code/kicad/issues/2512
 2021-12-24 11:40:10 +00:00
Jeff Young 1305c2177f Add a checker for copper-to-copper clearance within a single zone. 
Fixes https://gitlab.com/kicad/code/kicad/issues/2512
 2021-12-24 11:40:06 +00:00
Jeff Young 5433684d3c Try to make gcc happy. 2021-12-23 23:59:48 +00:00
Jeff Young 235e0a430d Less flashing of the progress bar. 2021-12-23 22:31:33 +00:00
Jeff Young 56c85bd354 Improve clearance and constraint resolution reporting. 
1) Report on all applicable clearance types
2) Don't double-book constraints if they're used by more than one
test provider

Fixes https://gitlab.com/kicad/code/kicad/issues/8961
 2021-12-23 22:31:26 +00:00
Jeff Young 3f64b69917 Mechanical clearance rules. 
ADDED mechanical_clearance and mechanical_hole_clearance constraints.

Fixes https://gitlab.com/kicad/code/kicad/issues/2183
 2021-12-23 22:31:21 +00:00
Jeff Young a48867ea01 Solder mask integrity testing. 
ADDED DRC test for solder mask aperture bridging copper from different
nets.
ADDED visualization of minimum web width processing for solder masks.
ADDED allow_soldermask_bridges property for footprints.

Fixes https://gitlab.com/kicad/code/kicad/issues/2183

Fixes https://gitlab.com/kicad/code/kicad/issues/1792
 2021-12-23 22:31:14 +00:00
Jeff Young 533276e6b6 Copper sliver checking. 
ADDED DRCE_COPPER_SLIVER DRC error.
ADDED ADVANCED_CFG DRCSliverWidthTolerance and DRCSliverAngleTolerance.

Fixes https://gitlab.com/kicad/code/kicad/issues/2183
 2021-12-23 22:31:05 +00:00
Jeff Young a1e3f2b188 Starved thermals DRC checking. 
ADDED min_resolved_spokes constraint.
ADDED "Thermal relief connection to zone incomplete" violation.

Fixes https://gitlab.com/kicad/code/kicad/issues/2183
 2021-12-23 22:30:42 +00:00
Jeff Young 32721755bf Hook up zone-pad connections to custom rules. 
ADDED zone_connection constraint.
ADDED thermal_relief_gap and thermal_spoke_width constraints.

ADDED angle override for thermal relief spokes in Pad Properties.

Fixes https://gitlab.com/kicad/code/kicad/issues/4067
 2021-12-23 22:30:26 +00:00
Jeff Young 92e589b398 Use board maxError value, and return SH_ARC for unfilled circle. 2021-12-23 20:36:11 +00:00
Jeff Young 2bc86fa0a8 Shapes for schematic. 
ADDED arc, circle and rectangle shapes for schematic.  Shapes support
line styles and fill colors.

CHANGED sheet background color in Edit Text & Graphics Properties to
fill color (and it now affects shapes).

Pushed STROKE_PARAMS down into common and moved all shapes to using it
for stroke descriptions.
 2021-12-23 20:36:07 +00:00
Jeff Young 4b6bf3095a Radial dimensions. 
ADDED radial type dimensions.

Fixes https://gitlab.com/kicad/code/kicad/issues/2056
 2021-12-23 19:34:54 +00:00
Jeff Young 21eb928218 Add Ignored Violations tab to DRC dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7726
 2021-12-23 19:18:45 +00:00
Jeff Young 2001d08186 Add DRC tests for text height and text thickness. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8683
 2021-12-23 19:18:45 +00:00
Jeff Young 0a609dd48d Add footprint library checking to DRC. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6821
 2021-12-23 19:18:45 +00:00
Seth Hillbrand 24fe5bc2a8 Fix DRC thread locking 2021-12-15 06:05:40 -08:00
Seth Hillbrand 40d44c94cd Fix single-threaded loads/connectivity 
We cannot set thread counts to hardware_concurrency()-1 without
considering that single core machines will get a thread count of 0.
 2021-12-14 17:18:46 -08:00
Jeff Young 0dcbfa2b69 Always use UUIDs for implicit keepout rules. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9580
 2021-11-09 17:57:47 +00:00
Jeff Young 6af031be05 Use double-quotes for rule expressions. 
The Mac double-quote bug is now fixed and strings inside expressions
are single quoted making single-quoting the entire expression pretty
hard to visually parse.
 2021-11-08 20:53:59 +00:00
Jeff Young ffd1139cfe Make sure a pad is at least as big as its hole in the RTree. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9516
 2021-11-03 18:53:26 +00:00
jean-pierre charras 40e6a9a926 Fp editor: add DRC test for through hole pads without hole. 2021-10-19 14:47:29 +02:00
Jeff Young 856cc26d4c Allow vias the same same-net waiver that pads have for hole clearance 
Note that in 7.0 we have physical_hole_clearance rules to give a bit
more expressivity here.

Fixes https://gitlab.com/kicad/code/kicad/issues/9420
 2021-10-18 18:09:40 +01:00
Jeff Young b52529521e Replace individual LIB_* shapes with LIB_SHAPE (based on EDA_SHAPE). 
Also moves to more capable FILL_T model that can be shared.
 2021-10-15 12:45:43 +01:00
Seth Hillbrand fce054319c Update DRC MatchDPSuffix routine 
This matches the router matchDPSuffix routine until we merge the two
into a common utility
 2021-10-11 10:33:50 -07:00
Jeff Young dfe4997664 Fix nullptr crash. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9250
 2021-09-27 10:27:25 +01:00
Seth Hillbrand 3e7310a219 Move FP type check to FP DRC 
Checks for validity are better centrally located where they don't
interrupt user actions
 2021-09-25 08:56:27 -07:00
Jeff Young c38de1dcaf Pull back some 7.0 fixes to Custom Rules code completion. 2021-09-23 13:08:31 +01:00
Jon Evans 814b6b8e86 Fix disabled layer error text 2021-09-12 17:14:24 -04:00
Jeff Young 0ac765c5bb Special case footprint zones which can be on "inner layers". 
Also improves the reporting so that it reports the actual conflict
layer rather than just the first layer the object is on.

Fixes https://gitlab.com/kicad/code/kicad/issues/9144
 2021-09-12 13:53:12 +01:00
Jeff Young 1a43515128 Repair multi-layer disabled layer tests. 2021-09-09 16:43:47 +01:00
Jeff Young bb2efa0649 Improve disabled layer test. 
1) handle graphic items on copper layers
2) handle items on multiple layers
 2021-09-09 15:20:48 +01:00
Wayne Stambaugh 3b16c38756 Coverity issue fixes. 
Fix Coverity issues 157138, 338547, and 338716.
 2021-09-08 14:51:27 -04:00
Jeff Young a397e85589 Implement PTH/NPTH/courtyard collision tests. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9081
 2021-09-04 00:16:26 +01:00
Jeff Young 436ad0ede7 Add missing token to DRC rule parser. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9041
 2021-08-27 12:49:07 +01:00
Jeff Young f4905cb1ae Cherry-pick fix from 7.0 branch back to master. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9005
 2021-08-25 20:14:11 +01:00
Jeff Young e6ca9837a2 Clear numbers from non-numberable pads and don't run DRC on them. 
This was also the last straw on the misnamed PAD::GetName() and
PAD::SetName(), which are now PAD::GetNumber() and PAD::SetNumber().

Fixes https://gitlab.com/kicad/code/kicad/issues/9017
 2021-08-24 01:03:06 +01:00
Jeff Young fec34e8dd8 Get rid of an extraneous layer parameter. 
Also adds a bit of nullptr safety.
 2021-08-23 20:00:17 +01:00
Jeff Young 9770962ab4 Fix logic bug in rule processing. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9011
 2021-08-22 20:16:58 +01:00
Jeff Young 1fa5e43597 Fix some dodgy logic in clearance overrides. 2021-08-22 03:24:51 +01:00
Jeff Young 3e57700b21 Process rules in "natural" order using overrides. 
(We used to process in reverse order with first-match-wins, but
that doesn't allow min, max and opt to come from different rules.)

Fixes https://gitlab.com/kicad/code/kicad/issues/9004
 2021-08-21 16:43:11 +01:00
Jeff Young 1e23ce1c95 Pull some fixes back from 7.0. 
1) An earlier 6.0 fix to apply pad clearance overrides to NPTH pads
got broken, so this replaces it.

2) Allow min/max/opt to be set by different rules.

3) Fixes a bug where board minimum enforcement over a local override
didn't get the right message text.
 2021-08-21 16:43:11 +01:00
Jeff Young 8b5f393804 DRC bug fixes and debugging improvements. 
1) Don't wait for UpdateUserInterface to build the (global) list of
layer names.

2) Report clearance resolution between a silk layer and a mask layer.

3) When writing DRC reports, include info about the violating rule.

4) Report "no relevant layers" if we fail to find anything to write
a clearance resolution report about.

Fixes https://gitlab.com/kicad/code/kicad/issues/8963
 2021-08-17 15:41:12 +01:00
Jeff Young 1a252b4f96 Add a compile error for ill-defined rules, and more performance. 
Also adds const-safety to GetBoard().
 2021-08-16 12:14:17 +01:00
Jeff Young eaccbce48b Fix logic errors in progress reporting in a couple of DRC providers. 2021-08-15 22:24:44 +01:00
Jeff Young 1ec70d30af Cherry-pick some 7.0 Clearance Resolution improvements. 
6.0 will be in the field for a long time, and the better the debugging
tools we have available the less costly it will be to maintain.

Fixes https://gitlab.com/kicad/code/kicad/issues/8961
 2021-08-15 19:03:58 +01:00
Jeff Young 41619ebbe2 Decouple PROGRESS_REPORTER interface from implementations. 2021-08-14 21:05:49 +01:00
Jeff Young e5586fb974 Accept legacy hole token as well as new hole_size. 2021-08-13 21:28:11 +01:00
Jeff Young d34e9e8946 Code safety. 2021-08-13 21:28:11 +01:00
Jeff Young 4c3954aea8 Clearer DRC rule token name for hole_size. 2021-08-13 16:18:56 +01:00
jean-pierre charras f4a7565b9c fix a compil warning 2021-08-11 08:16:26 +02:00
Jeff Young 13fc16b03f Fix uninitialized variable. 2021-08-10 16:51:30 +01:00
Jeff Young a208dac8d8 Convert hole clearance tests from NPTH holes to all holes. 2021-08-09 22:26:00 +01:00
Jeff Young bafa105ed0 Enforce hole clearance on NPTHs in zones. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8924
 2021-08-06 18:16:38 +01:00
Jeff Young faa1ff4ec6 Add false-negative DRC tests (and fix first bug found by them). 2021-07-31 16:41:44 +01:00
Jeff Young 8c69a856fc Add zone filler tests. 
One test has pads of a bunch of different shapes and provokes some
errors to make sure they're caught.

The others are all past issues with the zone filler to make sure we
don't suffer any regressions.  (They should all just pass with no DRC
errors.)
 2021-07-30 17:09:24 +01:00
Jeff Young 6aaf4413b3 Fix kicad_string.h / string.cpp mismatch. 
They don't define a KiCad string class, so the header file name was
somewhat misleading. But the fact that they didn't match definitely
made coding more difficult.
 2021-07-29 16:03:25 +01:00
Jeff Young f221220fe2 Rename layer ids file. 
It hasn't had anything to do with colors or visibility for some time
now.
 2021-07-29 16:03:25 +01:00
Jeff Young 46338403e7 Unwrap some std::library typedefs. 2021-07-28 22:16:38 +01:00
Wayne Stambaugh 8fd83cbb95 Pass wxPoint objects by reference instead of on the stack. 2021-07-26 15:35:33 -04:00
Jeff Young 0fb864d596 Pull some name changes back from 7.0 to ease merging. 2021-07-21 20:58:59 +01:00
Wayne Stambaugh cf00319c85 More NULL expunging. 2021-07-20 07:27:18 -04:00
Wayne Stambaugh 6c3ba1c20b Coverity issue fixes. 
Issues #332032, #332086, #332157, and #332171.
 2021-07-09 10:56:35 -04:00
Jeff Young 4aa8318dc2 More error message regularization. 2021-06-27 14:24:02 +01:00
Jeff Young 81fc710a5d Use consistent terminology. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8681
 2021-06-26 10:11:41 +01:00
Jeff Young 232ffe97be Diff pair gap only overrides netclass clearance when it's smaller. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8676
 2021-06-24 16:56:53 +01:00
Jeff Young 096e342386 Prefix TRACK, ARC and VIA. 2021-06-11 22:07:02 +01:00
Jeff Young 16b0147af8 Prefix DIMENSION types. 2021-06-11 17:59:44 +01:00
luz paz f968fc8719 Fix source comment / documentation typos 2021-06-09 19:32:58 +00:00
Marek Roszko 10e60acf34 Clean up including of board_design_settings.h 2021-06-06 15:03:42 -04:00
Marek Roszko b610b905fc Cleanup track.h includes 2021-06-06 09:06:55 -04:00
Ian McInerney 4f05262705 Cleanup includes in board.h and footprint.h 2021-06-03 20:19:52 +01:00
Seth Hillbrand f40f696c37 Don't extract dp segment info from minimal-length 
segments with 1IU of length are approximately parallel to everything and
the distance projections break down into rounding errors

Fixes https://gitlab.com/kicad/code/kicad/issues/8541
 2021-06-03 08:44:17 -07:00
Seth Hillbrand 7f56ff4d42 Minor performance improvement 
Don't keep searching the DRC RTree for collisions after we detect a true
(not clearance-based) collision
 2021-06-02 08:15:37 -07:00
Jeff Young 00ed75b891 Fix DRC performance with multi-layer keepout zones. 
The main issue was a parameter mismatch which caused On^2 behaviour
for zone layers.

But there are several other performance optimizations here, along
with status bar updating for zones while running the dissallow test.

Fixes https://gitlab.com/kicad/code/kicad/issues/8521
 2021-06-02 14:11:43 +01:00
Jon Evans 6381ffd10a Fix diff pair coupling test when gap constraint is in a different rule 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8519
 2021-05-31 10:13:05 -04:00
Marek Roszko 382dca4e6f Fix uninitialized member warnings 
Based on PVS Studio report
 2021-05-30 20:01:01 -04:00
Jeff Young 5f22025611 Don't drop text on Edge.Cuts when plotting. 
While -our- user model is that Edge.Cuts is just for edges, it's best
not to dictate a particular model to users.

ADDED a DRC error when text (or a dimension) appears on the Edge.Cuts
layer.

Fixes https://gitlab.com/kicad/code/kicad/issues/8470
 2021-05-24 19:54:52 +01:00
Jeff Young e93e9fa3e5 Add rudimentary type checking to rule eval with reporter. 
Also cleaned up existing error reporting to not expend CPU cycles
when there was no reporter.

Fixes https://gitlab.com/kicad/code/kicad/issues/8438
 2021-05-20 23:06:24 +01:00
Jeff Young 4c3d78dec0 Break out separate holes-co-located violation. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8456
 2021-05-20 10:36:56 +01:00
jean-pierre charras 56058314be Fix minor Coverity warnings and minor compil warnings. 
(uninitialized or shadowed vars)
 2021-05-05 08:58:55 +02:00
Marek Roszko 03cf2b517f Enum class PAD_ATTR_T 
Renamed such that python stays the same
 2021-05-01 10:51:54 -04:00
Marek Roszko 21fde9b629 enum class PCB_SHAPE_TYPE_T 2021-04-30 22:36:12 -04:00
Jeff Young 7df9fa0631 Diffpair gap should only override clearance within a coupled diffpair. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7975
 2021-04-30 18:39:21 +01:00
Jeff Young c149ed8905 Allow diffpair gap to override normal netclass clearance. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7975
 2021-04-29 10:23:49 +01:00
Jeff Young b65b1f8e9c Revert NPTH commit, and add some comments. 2021-04-26 17:33:49 +01:00
Jeff Young e3eacafbcb Run hole clearance tests on NPTH pads, but not copper clearance. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8295
 2021-04-25 17:55:43 +01:00
Jeff Young b7279c0bab Don't allow rounding errors to flag DRC violations in hole2hole. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8295
 2021-04-25 17:55:43 +01:00
Jeff Young e5d029af6b Margin layer missing from some edge clearance tests. 
Fixes bug reported on KiCad Forums.
 2021-04-21 21:58:47 +01:00
Jeff Young 23a1f8b17a Enforce board minimum clearance over local clearance overrides. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8199
 2021-04-15 21:44:04 +01:00
Jon Evans 4920692bcd DIFF_PAIR_GAP_CONSTRAINT does not need to be restricted to two items 
We just need one item to see what netclass we're in; the constraint
itself is specific to diff pairs so the condition doesn't need to be.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8205
 2021-04-14 23:43:43 -04:00
Jeff Young d79057b83a Fix merge wreckage in building netclasses. 2021-04-13 17:56:50 +01:00
Jeff Young 2cde76a191 Don't do any hole clearance testing within a single footprint. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8141
 2021-04-11 16:03:16 +01:00
Jeff Young 3450610977 Add ability to allow thermal vias to be implemented as pads. 
This is mostly just for CADSTAR.  Since we don't (yet) have general
purpose footprint attributes, this reuses the "net tie" hack.

Fixes https://gitlab.com/kicad/code/kicad/issues/8141
 2021-04-09 14:02:13 +01:00
Carsten Schoenert cb17c9f3dd Typo fix: Correct various misspelled words 
agressive -> aggressive
decription -> description
miscellanous-> miscellaneous
rectange -> rectangle
Unkown -> Unknown
 2021-04-03 13:39:50 +00:00
Jeff Young b6f2941a06 Another try a allowing touching courtyards. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8076
 2021-03-31 22:54:30 +01:00
Jeff Young 737262ffa8 Allow touching courtyards. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8076
 2021-03-31 10:44:59 +01:00
Jeff Young 3279e295ac Don't start filling zones with possibly stale caches. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8014
 2021-03-25 17:20:08 +00:00
Jeff Young a2ffb45698 Update diff pair rule syntax to be clearer. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8010
 2021-03-25 10:29:38 +00:00
Jeff Young a94ce75c02 Fix multiple filter calls that were producing false cache positives. 
When processing a compound shape we'd decide the first of them didn't
collide and then put false into the cache.  The cache value would then
be used for all the other shapes in the compound shape, which very well
might actually collide.

Fixes https://gitlab.com/kicad/code/kicad/issues/8003
 2021-03-23 21:06:16 +00:00
Jeff Young fe196771d8 Implement isCoupledDiffPair() DRC rule function. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7975
 2021-03-20 23:07:36 +00:00
Jeff Young 44e2151ade Allow diffpair gap to override netclass clearance value. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7975
 2021-03-20 21:53:30 +00:00
Dominik Wernberger e2aa7be4b3 Added a lot of consts and refactored a few lines 2021-03-08 12:49:48 -08:00
Jeff Young 47145d349b Don't run insideArea on ruleAreas. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7826
 2021-03-07 17:55:30 +00:00
Jon Evans 65531accf6 DRC: allow testing against particular diff pair membership 2021-02-27 19:54:55 -05:00
Jeff Young 6d6765cdaf Improve DRC status reporting. 
1) Don't report on tests not run.
2) Don't cancel subsequent tests because the current test didn't
have any constraints
3) Exit a little bit quicker when cancelled

Fixes https://gitlab.com/kicad/code/kicad/issues/7724
 2021-02-27 13:44:45 +00:00
Jeff Young 4ede4e061e More DRC performance work. 
Push DRC zone RTrees into BOARD so that they can also be used by
insideArea.

All these caches are a bit of an encapsulation leak, but they make a
significant impact on performance.

Fixes https://gitlab.com/kicad/code/kicad/issues/7720
 2021-02-27 11:45:04 +00:00
Jeff Young f226373324 Add cache for insideArea() and insideCourtyard(). 
Fixes https://gitlab.com/kicad/code/kicad/issues/7720
 2021-02-26 19:22:25 +00:00
Jeff Young d523129929 Minor performance improvements. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7720
 2021-02-26 17:58:08 +00:00
Jeff Young a3b9e8ddb4 Round 2 of Worksheet -> Drawing Sheet. 2021-02-23 11:57:44 +00:00
Jeff Young cad5198ab7 Worksheet -> (industry standard) Drawing Sheet. 2021-02-22 17:35:46 +00:00
Marek Roszko 907e282347 Silence some msvc warnings 
- exception variables that were unused
- RAYSEG2D improperly foward declared with class instead of struct
- unused vars
 2021-02-20 11:58:55 -05:00
Jeff Young e89f9db438 Footprint disallow layer checking needs to be based on courtyards. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7620
 2021-02-20 14:13:36 +00:00
Jeff Young 6f9ebcfdb5 Make sure a pad has a hole before running hole test on it. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7567
 2021-02-17 14:08:53 +00:00
Jeff Young 015c4d5779 Don't force disallow tests to a particular layer. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7552
 2021-02-16 16:24:37 +00:00
Jeff Young 6272b48481 Make sure layer gets passed in to rules evaluation. 2021-02-08 14:53:49 +00:00
Jeff Young 78ba87be8f More explicit error message for unconnected items. 2021-02-04 22:47:37 +00:00
Jeff Young da8d0472f5 Layer must be between 0 and PCB_LAYER_ID_COUNT. 2021-02-04 01:00:20 +00:00
Jeff Young 8571687f51 Upgrade place via tool to new DRC. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7358
 2021-02-01 23:00:13 +00:00
Seth Hillbrand 23c6dbff38 Need to check track/track clearance 
The misplaced else prevented non-track/track intersection clearances
from being reported

Fixes https://gitlab.com/kicad/code/kicad/issues/7376
 2021-02-01 10:08:27 -08:00
Marek Roszko 9d0b16e814 bool/int type safety 2021-01-31 19:54:32 -05:00
Jeff Young 56ea55ae9c Make sure that NPTH pads still get handled in copper clearance checker. 
... because that's where we do hole-to-copper clearance testing.

Also augments the Clearance Resolution reporter to report on said
hole clearances.

And changes the interpretation of HOLE_CLEARANCE_CONSTRAINT to include
local pad clearance overrides.

Fixes https://gitlab.com/kicad/code/kicad/issues/7325
 2021-01-31 00:33:35 +00:00
Jeff Young 09eb4b35c6 Make sure footprint edges get checked. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7267
 2021-01-25 13:20:16 +00:00
Jeff Young 2d8cac658e Allow negative clearances to signal supression of DRC test. 2021-01-23 00:10:01 +00:00
Jeff Young da4b269783 Make sure pad local clearances get in to m_worstClearance. 2021-01-13 12:37:20 +00:00
jean-pierre charras 067b94c410 DRC: Fix a incorrect message and marker position when testing dangling vias. 
Commit 6ffb721 detects vias connected on only one layer.
But the DRC diag (marker position and error message) were not correctly initialized
for this new test.
 2021-01-10 10:21:24 +01:00
Jeff Young 3fd128a75b Performance enhancements. 2021-01-08 00:46:55 +00:00
Jeff Young a48f0d21f7 More consistency in clearance resolution messages. 2021-01-05 16:54:52 +00:00
Jeff Young 33aa6edb01 Don't run clearance tests on unflashed NPTH pad layers. 2021-01-04 00:03:21 +00:00
Jeff Young 7378c2c3b3 Implement max hole size DRC checks. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6893
 2021-01-04 00:03:21 +00:00
Jeff Young b5e7611696 Don't cross-pollute CONSTRAINTs. 
If you want the HOLE_CLEARANCE, then ask for it.
 2021-01-02 16:33:51 +00:00
Jeff Young 018c17399d SNR. 2021-01-01 23:17:49 +00:00
Jon Evans 241823647b DRC: Fix a minor memory leak 2020-12-29 14:58:45 -05:00
Jon Evans bc712a7383 Remove some stray printfs 2020-12-29 14:58:45 -05:00
Jeff Young 8300e17b69 Fix botched attempt to report hole violations between no-net items. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6851
 2020-12-26 16:24:51 +00:00
Jeff Young af2219ba7f Finish implementation of hole clearance checking. 
It appears we never did via hole testing, and pad hole testing didn't
appear to get much testing.
 2020-12-25 22:32:19 +00:00
Jeff Young 9c4d3add15 Fix typo. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6845
 2020-12-25 12:07:26 +00:00
Jeff Young ef25c78a04 Separate polygonization error from chaining error. 
This way we can report anything that doesn't exactly chain while still
applying  a fudge factor for our own stuff.

Fixes https://gitlab.com/kicad/code/kicad/issues/1795
 2020-12-24 21:02:14 +00:00
Jeff Young 38b8bc89ac Fix a pair of typos. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6839
 2020-12-24 19:32:24 +00:00
Jeff Young 17800b926f Honour couryard_clearance rules when checking for courtyard overlaps. 2020-12-23 17:34:21 +00:00
Wayne Stambaugh f311831c27 Coverity fixes. 
280252, 314742, 314745, 314747, 314755, 314756, 314757, 314758,
314935, 314936
 2020-12-20 13:24:47 -05:00
Jeff Young b68b1692ec Clean up some more user messages. 
Mostly component -> symbol but also some I18N cleanup.
 2020-12-18 12:49:20 +00:00
Jeff Young 3b35bfc0a5 Don't write out synthetic severities (they're headings). 
Fixes https://gitlab.com/kicad/code/kicad/issues/6726
 2020-12-14 13:34:53 +00:00
Jeff Young bc484784fc Make sure zones are triangulated for DRC. 
Normally this happens as a side-effect of rendering them but if done
from a script (or test case) this won't happen.

Fixes https://gitlab.com/kicad/code/kicad/issues/6635
 2020-12-12 15:27:46 +00:00
Wayne Stambaugh dd4298bb94 Coverity fixes: 280374, 313611, 313648, 313649, and 314720. 2020-12-11 13:29:52 -05:00
Ian McInerney be4b6ec06a Cleanup compiler warnings 2020-12-09 23:13:33 +00:00
Jeff Young b1f0bf7334 More consistent naming. 2020-12-08 13:05:39 +00:00
Jeff Young d0f9503ee0 Add grouping for violation severities. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6616
 2020-12-06 19:14:48 +00:00
Jeff Young b10aa230f7 Remove no-longer-used DRC violation code. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6616
 2020-12-06 15:19:33 +00:00
Jeff Young dbf273d5ec Don't leave HOLE_PROXY set; it messes subsequent tests. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6584
 2020-12-05 19:44:02 +00:00
Jeff Young 4c5567a627 Allow colliding pads in netties as well as graphic shapes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6584
 2020-12-05 19:44:02 +00:00
Jeff Young 4634802a58 Formatting. 2020-12-04 19:29:04 +00:00
Jeff Young 09bfb76545 Make sure dissallow constraints get added to rule. 
Also improves some error reporting.

Fixes https://gitlab.com/kicad/code/kicad/issues/6566
 2020-12-03 23:08:51 +00:00
Jeff Young dadfe03804 Reinstate 5.1 net-tie hack since "real" net-ties got pushed to 7.0. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6556
 2020-11-30 16:11:15 +00:00
Jeff Young 3a9a6e22bc Fix issues in reporting netclasses. 
1) make sure we get the default netclass when we want it
2) escape for HTML (particularly important for "<invalid>", but also
for reporting user rule names, netclass names, etc.)
 2020-11-30 14:38:06 +00:00
Jeff Young 3989c19c41 Don't test pad:track clearances in pad tester. 
They've already been tested in the track tester.

Fixes https://gitlab.com/kicad/code/kicad/issues/6554
 2020-11-30 14:38:06 +00:00
Jeff Young e09271ca0e Fixes for hole clearance and hole-to-hole tests. 
1) Separate out CONSTRAINT types
2) Filter both source and dest pads/vias for drilled holes when doing
   hole-to-hole checks.  We were checking the items being put into the
   DRC RTree, but not the items we were scanning.
3) Add hole clearance to Board Setup Constraints panel.

Fixes https://gitlab.com/kicad/code/kicad/issues/6546

Fixes https://gitlab.com/kicad/code/kicad/issues/4683
 2020-11-29 23:35:23 +00:00
Jeff Young e4d0ffd607 Retire old SKIP_STRUCT filtering. 
We already added the checkedPairs stuff which deals with a:b vs b:a
better, and the SKIP_STRUCT version had side-effects between the two
tests.

Fixes https://gitlab.com/kicad/code/kicad/issues/6539
 2020-11-29 00:08:23 +00:00
Jeff Young 1cae0b6c08 Make sure board edges have 0 width. 
When we divide up a rectangle or polygon (for better RTree usage)
we need to make sure the individual segments also have their widths
zeroed out.

Fixes https://gitlab.com/kicad/code/kicad/issues/6482
 2020-11-24 23:49:28 +00:00
Jeff Young 9c7c05c161 Mostly formatting cleanup but a few type-casting cleanups too. 2020-11-24 22:16:41 +00:00
Jeff Young 2f3f4c209e Make sure DRC reports a missing board outline. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6481
 2020-11-24 14:22:27 +00:00
Jeff Young 1391774f64 Re-factor boundary/courtyard checker error handling. 
ADDED Footprint Checker dialog to display the results in.

Fixes https://gitlab.com/kicad/code/kicad/issues/6446
 2020-11-21 20:57:35 +00:00
Jeff Young ff3bd7e72a Fix a crash bug in DRC, and equate Margin to Edge.Cuts. 2020-11-20 21:22:27 +00:00
Jeff Young b123318cf6 Encourage use of full DRC for board & footprint malformed outlines. 
It shows much more detail.  Removes some nag dialogs and places
hypertext links in others.

Also fixes the auto-layer-showing to correctly show Edge.Cuts or
F.CrtYd or B.CrtYd for errors relating to them.

Fixes https://gitlab.com/kicad/code/kicad/issues/6446
 2020-11-20 17:24:52 +00:00
Jeff Young 533d344e3f Honour pad falshing when colliding with DRC RTree. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6443
 2020-11-19 23:55:14 +00:00
Jeff Young 0d850f98cd Cleanup. 2020-11-19 22:48:18 +00:00
Jeff Young 6e0c58adec Include local clearances even if no implicit rule was found. 
The real test should be to apply it any time an explicit rule is
*not* found.

Fixes https://gitlab.com/kicad/code/kicad/issues/6426
 2020-11-19 22:48:18 +00:00
Jeff Young bfc4afc506 Restore the 5.1 NetTie hack. 
We really need to do first-class net ties....

Fixes https://gitlab.com/kicad/code/kicad/issues/6416
 2020-11-17 20:07:21 +00:00
Jeff Young 795e45836d Fix assert in DRC. 2020-11-17 17:41:57 +00:00
Jeff Young b2d86ec7c9 Don't double-check DRC clearances (a:b and b:a). 
Fixes https://gitlab.com/kicad/code/kicad/issues/6417
 2020-11-17 16:58:39 +00:00
Ian McInerney 8c08b861ab Cleanup some compiler and Coverity warnings 2020-11-15 21:41:38 +00:00
Jeff Young 1ce1e493d6 A rule zone is not really a BOARD_CONNECTED_ITEM. 
Or at least it shouldn't always be treated as one.

Fixes https://gitlab.com/kicad/code/kicad/issues/6382
 2020-11-15 20:23:15 +00:00
Jeff Young 7bd31d5237 Naming conventions. 2020-11-14 18:26:03 +00:00
Jeff Young 2eb71447e4 DRC RTree fixes. 
1) Don't collide against hidden text
2) Don't collide in both directions (a:b & b:a)
 2020-11-14 16:59:34 +00:00
Jeff Young bdbb68f813 MODULE -> FOOTPRINT. 2020-11-13 16:04:03 +00:00
Jeff Young 3451ac3088 PCB_MODULE_T -> PCB_FOOTPRINT_T 2020-11-13 15:16:24 +00:00
Jeff Young 63a54d003e More module -> footprint. 2020-11-13 15:16:24 +00:00
Jeff Young 9106cc19bf Yet another tranche of module -> footprint. 2020-11-13 15:16:24 +00:00
Jeff Young 52a46341db More module -> footprint. 2020-11-13 15:16:24 +00:00
Jeff Young f5443de7f9 D_PAD -> PAD. 2020-11-13 15:16:24 +00:00
Jeff Young 84dd5108ba Remove some "class_" prefixes from files. 2020-11-13 15:16:23 +00:00
Jeff Young f7333ad64a Update some classnames including archaic zone names. 2020-11-12 10:31:25 +00:00
Ian McInerney d88eaaf477 Fix various compiler and Coverity warnings 2020-11-11 00:41:02 +00:00
Jeff Young 81ea71fb80 More safety when fetching via sizes. 2020-11-07 18:50:30 +00:00
Jeff Young ae9afdd169 SNR. (Mostly for progammers, but a little for user messages.) 2020-11-02 16:20:00 +00:00
Jeff Young c351b3c31f Naming conventions. 2020-11-01 14:12:35 +00:00
Jeff Young f600450ee6 DRC_TEST_PROVIDER_COPPER_CLEARANCES is for copper only. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6248
 2020-11-01 14:12:35 +00:00
Jeff Young d2befca5af Clear subshapes before using again on a different layer. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6248
 2020-11-01 14:12:35 +00:00
Jeff Young 7676ba6f5d Coverity warning. 2020-11-01 14:12:35 +00:00
Jeff Young a9bf4bc6a6 Fix freed-memory crasher. 
While the DRC_ENGINE is not long-lived, it's test providers are,
and must be cleared for each use.
 2020-10-31 15:45:41 +00:00
Jeff Young 115fd1d7f3 Move track-to-zone testing to RTrees. 
Also implemente pad-to-zone testing and removes the control in the
GUI (now that it's fast).
 2020-10-31 15:45:41 +00:00
Jeff Young 1a1aef756e Reporting "actual" incompatible with exiting after first hit. 
But we're currently using this only as a rough collision check
anyway as it doesn't know the specific item-to-item clearance.
 2020-10-31 15:45:41 +00:00
Jeff Young 788a1e3bce Handle footprint zones in zone collision checks. 
Also fixes issue with progress reporter.
 2020-10-31 15:45:41 +00:00
Jeff Young cd93dbd324 Naming cleanup. 2020-10-31 15:45:41 +00:00
Jeff Young 8d4c9aeaac Fix Mac-style include. 2020-10-31 15:45:41 +00:00
Jeff Young d5addb692c Move a bunch of DRC tests to RTrees. 2020-10-31 15:45:41 +00:00
Jeff Young 776ea35040 Fix copy/paste error and some formatting issues. 2020-10-27 22:46:19 +00:00
Werni a7d5d1f091 Add more consts all over the place 2020-10-27 11:03:35 +00:00
Jeff Young 2e94be0855 Move geometric parts of Cleanup Tracks and Vias to RTree. 
Removes two separate O(n^2) traverses over the tracks.

Fixes https://gitlab.com/kicad/code/kicad/issues/6077
 2020-10-26 18:37:59 +00:00
jean-pierre charras c092e3f8b7 Fix a few minor Coverity warnings 2020-10-26 10:46:08 +01:00
Marek Roszko 1984581c46 Remove common.h from more headers 2020-10-25 22:29:53 -04:00
Jeff Young 45113f983b Fix test case. 
Silk tests were processing MODULE_Ts when they shouldn't have been.
 2020-10-25 23:19:39 +00:00
Jeff Young 2ee61f52ca Implement correct layer handling for keepout constraints. 2020-10-25 22:47:47 +00:00
Jeff Young 8c93fc76ae Don't require keepout zones to be named. 
insideArea() now takes A, B, a UUID or a zone name.  (Only the UUID
is new.)
 2020-10-25 21:08:09 +00:00
Jeff Young 5b1e1075a9 Allow an easy way for DRC tests to specify compound objects or not. 2020-10-25 20:24:47 +00:00
Jeff Young 386cefbe84 Do footprint keepouts by courtyard. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6162
 2020-10-25 18:17:58 +00:00
jean-pierre charras d6f91c810f Fix a few compil and Coverity warnings. 2020-10-25 10:02:07 +01:00
Marek Roszko e928b2d8fd Split EDA_UNITS out from common. 2020-10-25 00:02:52 -04:00
Jeff Young 7674d2ba91 Free allocated DRC structures when re-initializing. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6147
 2020-10-24 22:39:53 +01:00
David Shah 66bcfb3ffc drc_engine: Fix via type names 
There was a mismatch between the via type names used in the DRC engine
and the via type names defined in the class_track.cpp ENUM_MAP for
VIATYPE.

This fixes the discrepancy; which was breaking microvias altogether as
the route tool also uses the DRC code to determine the correct
diameter/drill (without this patch it was incorrectly using regular
dimensions for microvias.)
 2020-10-24 15:46:47 +00:00
Jeff Young 59f3fefd17 When polygonizing arcs don't use synthesized center and angle. 
Start, mid and end are the "real" properties and come with less
error.

Also collapses two arc polygonization routines into one.

Also fixes DRC checks to be cognizant of arc approximation error.

Fixes https://gitlab.com/kicad/code/kicad/issues/6039
 2020-10-23 23:55:45 +01:00
Seth Hillbrand 19bf594aa0 Remove unused point in polygon test 
There can be only one.
 2020-10-23 12:13:09 -07:00
Jeff Young 01ce881340 Honour NOT_IN_SCHEMATIC setting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6137
 2020-10-23 17:27:18 +01:00
Jeff Young cce557b9ad Redo the board-edge-building logic to return better error reports. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6119
 2020-10-22 21:29:04 +01:00
Jeff Young 41fd8293e8 Don't apply clearance to keepout zones. 
Also improves the clearance and keepout reporting.

Fixes https://gitlab.com/kicad/code/kicad/issues/6118
 2020-10-22 21:29:04 +01:00
Jeff Young 9ff49277e1 Add implicit rule generation for keepout areas. 
Also implements collision detection for SHAPE_POLY_SET.

Fixes https://gitlab.com/kicad/code/kicad/issues/6105
 2020-10-22 10:41:21 +01:00
Seth Hillbrand 4085757aeb Remove beginning/ending spaces in translations 
Adding space padding makes translations more difficult by increasing
string counts
 2020-10-20 12:08:04 -07:00
Jeff Young 18f9f3cf0b Add curved track support to track-to-zone DRC. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6039
 2020-10-20 13:38:09 +01:00
Wayne Stambaugh 8ff51d8899 Eeschema: add schematic sheet page number. 
The groundwork has now been laid for per sheet instance data.  Initially
this only supports sheet page numbers but could be expanded to include
other per sheet instance information.

ADDED: Support for user defined schematic page numbers.
 2020-10-19 14:05:45 -04:00
Jeff Young c5d45f8a78 Move DRC dialog to same DRC rule reporting mechanism as inspectors. 2020-10-17 20:40:05 +01:00
Jeff Young 6e54856e67 Don't halt other tests when one test's max is reached. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6035
 2020-10-17 12:13:04 +01:00
Jeff Young 1b2168af1e Don't throw implicit rules out after failing to compile user rules. 2020-10-16 12:44:20 +01:00