kicad

Commit Graph

Author	SHA1	Message	Date
Jeff Young	ef6866757e	Treat undo as backspace and/or escape when drawing. Ignore redo. Undo == backspace when drawing a polygon or chained lines. Otherwise it's an escape. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14961	2023-06-16 22:08:21 +01:00
Alex Shvartzkop	d3be62f644	Adapt panels to PAGED_DIALOG sizing algorithm. Also some cosmetic fixes (GTK).	2023-06-16 19:12:37 +03:00
Alex Shvartzkop	f5da58e17d	PAGED_DIALOG: allow setting initial size in ctor.	2023-06-16 18:53:00 +03:00
Jeff Young	da558f57d4	Don't leave selection lying around when swapping out footprints. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14971	2023-06-16 16:29:52 +01:00
Wayne Stambaugh	285f8a0e59	Command line PCB gerber export fix and improvement. The --board-plot-params argument was never parsed so it was always ignored. [ADDED] A '--no-protel-ext' option to allow plotting gerbers with the KiCad file extension (gbr) instead of the Protel gerber file extensions. (cherry picked from commit `4e79d1ecdd`)	2023-06-16 07:17:39 -04:00
jean-pierre charras	c37332bdb3	Plot Solder mask layer: do not add items on edge_cut, but not on mask layer it happened only when creating a solder mask plot with a minimum thickness. This was a legacy option, incorrect now. Fixes #14960 https://gitlab.com/kicad/code/kicad/-/issues/14960	2023-06-16 09:47:58 +02:00
Ian McInerney	63e91366e2	Add variable initializations	2023-06-15 23:49:24 +01:00
Ian McInerney	b73cc7db4a	Fix a few accidental copies in loop iterators	2023-06-15 22:57:05 +01:00
Ian McInerney	753cc6679b	Remove temp items from its group before deleting them The 1st level items being copied don't have their group information copied, and we assert that it has been removed from the group on deleting it, so we just reset the group membership to prevent the assert. Fixes sentry KICAD-22S	2023-06-14 23:33:41 +01:00
Ian McInerney	137640ac28	Remove group association before plotting board outline in drill map The plotter doesn't care about the grouping, and we expect the item to have no group on deletion, so temporary items like this shouldn't be part of one. (Sentry issue KICAD-24Y)	2023-06-14 00:26:46 +01:00
Yang Hongbo	fe1b1becef	Check visibility when switching layer in router tool When routing and using layerNext (hotkey '+') to switch to next layer, it will skip invisible layer, when click BUT_LEFT, the new line should be in the same layer (visible layer) Fixes https://gitlab.com/kicad/code/kicad/-/issues/14480	2023-06-13 09:46:12 -07:00
Jeff Young	9ed2458f00	Reset session drawing props after Board Setup. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14932	2023-06-13 11:06:10 +01:00
Marek Roszko	a87fada9e5	Minor tweaks to support wx3.3	2023-06-12 20:52:47 -04:00
Ian McInerney	1c138b4f3e	Rename function in Footprint wizard to prevent impoper override The ReloadFootprint function now exists in the base class with 1 argument, but this frame already had a similar function with no arguments. Rename this one to RegenerateFootprint to prevent warnings.	2023-06-12 23:14:56 +01:00
Jeff Young	782c73300b	Move drawing sheet datastructures to EDA_IU_SCALE. Or mostly, at least. Plotters still define their own mils-to-iu scale. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14934	2023-06-12 22:34:25 +01:00
Jeff Young	b7f0aae006	Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.	2023-06-12 12:38:50 +01:00
Jeff Young	aa8a903940	Cleanup.	2023-06-12 11:14:27 +01:00
Jeff Young	a3754785df	BoardDesignSettings are owned by FOOTPRINT_EDITOR_SETTINGS in the FP Editor. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14925	2023-06-12 10:08:41 +01:00
CraftedNightmare	aa667bea0f	eeschema: Fix Search pane not remembering docking sizes and positions Fixes https://gitlab.com/kicad/code/kicad/-/issues/14120 for eeschema Fixes that Show Search Panel Checkbox can get out of sync when restarting eeschema while the search pane is active	2023-06-11 20:23:24 +00:00
CraftedNightmare	d94e9b31b1	Fix Search pane not remembering docking sizes and positions Fixes https://gitlab.com/kicad/code/kicad/-/issues/14120	2023-06-11 20:23:24 +00:00
Jeff Young	93789e75b9	Re-create missing exclusion markers if DRC was cancelled. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14919	2023-06-11 12:14:27 +01:00
Jeff Young	3159391e28	Make sure infobar gets created earlier. (restoreLastFootprint() might want it.) Fixes https://gitlab.com/kicad/code/kicad/-/issues/14922	2023-06-11 11:40:51 +01:00
Jeff Young	4fc6047f91	Make sure infobar gets created earlier. restoreLastFootprint() might want it.	2023-06-11 11:02:56 +01:00
Roberto Fernandez Bautista	3d1b96d6ca	Cleanup jobs handlers (+Fix build)	2023-06-11 00:12:53 +02:00
Roberto Fernandez Bautista	3f758711fd	Use external REPORTER for EESCHEMA_JOBS_HANDLER / PCB_JOBS_HANDLER	2023-06-10 23:35:32 +02:00
Jeff Young	fcb156c323	Make sure opposite-corner rects test the same. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14907	2023-06-10 22:30:04 +01:00
Jeff Young	96a221ceba	Refresh delete immediately; don't wait for next mouse motion.	2023-06-10 21:11:05 +01:00
Jeff Young	111d0a2c14	Check for proxy references and values in Selectable(). Fixes https://gitlab.com/kicad/code/kicad/-/issues/14911	2023-06-10 17:47:29 +01:00
Jeff Young	f66b9f75a3	Allow EDA_COMBINED_MATCHER use in KiCad find architecture. Fixes https://gitlab.com/kicad/code/kicad/-/issues/12532	2023-06-10 14:50:06 +01:00
Jeff Young	d18b0c62f6	Make FOOTPRINT_PREVIEW_PANEL a FPHOLDER. Also makes sure it get its user_units set up. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14913	2023-06-10 13:36:17 +01:00
Roberto Fernandez Bautista	0159be8ddd	Fix build (broken in `90ff331c`)	2023-06-10 14:21:10 +02:00
Roberto Fernandez Bautista	90ff331c58	Refactor: Move static to be inside ZONE_SETTINGS	2023-06-10 12:03:41 +02:00
Alex	2450435131	Support --mirror option in "kicad-cli pcb export pdf"	2023-06-10 04:54:11 +03:00
Jeff Young	e698156975	Upgrade many editing actions to SCHEMATIC_COMMIT.	2023-06-09 22:41:47 +01:00
Jon Evans	3a2cc8f56f	Net Inspector: clear sort ordering during rebuild Fixes https://gitlab.com/kicad/code/kicad/-/issues/14697	2023-06-09 09:06:11 -04:00
jean-pierre charras	639da0eb5a	Fix a wxWidgets alert when deleting the last entry in a lib table.	2023-06-09 08:09:22 +02:00
jean-pierre charras	14c10d2a37	PANEL_FP_PROPERTIES_3D_MODEL: fix a wxWidgets alert. Happens when there is no 3D model in 3D grid list, and when trying to add a new 3D model, but canceling the 3D dialog file selector.	2023-06-08 17:46:38 +02:00
Tomasz Wlostowski	3667e4f6b2	router: correctly assign owner via/pad to its hole when committing the world state fixes #14852	2023-06-08 11:57:23 +02:00
Jeff Young	d5b5a3eaf4	Add action info to Undo/Redo menus. Note that this only works where a BOARD_COMMIT or SCHEMATIC_COMMIT is used. (BOARD_COMMIT is used almost universally in PCBNew, but SCHEMATIC_COMMIT has very little adoption in EEschema so far.)	2023-06-07 14:37:34 +01:00
Nils VAN ZUIJLEN	518741c52a	cli: add an option to the pcb exports for plotting negative svg and pdf ADDED: The -n or --negative option for exporting negative svg or pdf plots from kicad-cli. Example usage: kicad-cli pcb export svg -n -l B.Cu board.kicad_pcb	2023-06-07 13:28:52 +00:00
jean-pierre charras	f92271af2c	DIALOG_GEN_FOOTPRINT_POSITION: replace "Gerber (experimental)" by "Gerber X3" Gerber position file is now not experimental, and is accepted by some board houses.	2023-06-07 11:43:30 +02:00
Jeff Young	9a757e8e44	Restore over-aggressive CLion cleanup.	2023-06-06 15:49:41 +01:00
Jeff Young	9fe00bb808	Cleanup. No (intentional) functional changes.	2023-06-06 12:30:35 +01:00
Jeff Young	c5e7d800a4	Back out earlier diamond-to-rectangle fix for one that's more targeted. (And doesn't fail qa_pcbnew.) Fixes https://gitlab.com/kicad/code/kicad/-/issues/14828	2023-06-05 21:26:37 +01:00
Jeff Young	4ea41174c3	Variable names and minor performance fixes.	2023-06-05 21:26:37 +01:00
jean-pierre charras	6eda60e503	Pcbnew: UI change: move layer selector from main toolbar to auxiliary toolbar	2023-06-05 20:31:18 +02:00
Jeff Young	aafbbb4c63	Clean up includes.	2023-06-05 11:01:10 +01:00
Jeff Young	7a3a8b67c1	Exclude redraws during closing (particularly of RATSNEST_VIEW_ITEM).	2023-06-05 11:01:10 +01:00
Jeff Young	29aabcf77e	Naming clarity. No functional changes.	2023-06-05 11:01:10 +01:00
Jeff Young	f3d3ade1dc	Increased mutex safety. Don't even query the size() without having at least a shared_lock. May prevent KICAD-4S, but seems unlikely.	2023-06-05 11:01:10 +01:00
Marek Roszko	b41606ecf7	Use the correct printf format for the move individually status text Fixes sentry KICAD-1ZT	2023-06-04 21:08:13 -04:00
Jeff Young	0091b9f897	Prevent Sentry KICAD-MM crash. It'd be nicer to know what happens, but we don't have a reproducible case, so this "fix" will at least prevent that particular crash.	2023-06-04 23:00:44 +01:00
Jeff Young	1528f4700c	Treat canvas item as current when tree view contains no selection. Fixes https://gitlab.com/kicad/code/kicad/-/issues/12702	2023-06-04 20:52:12 +01:00
Seth Hillbrand	e4fe27993e	Fix wxCHECK_MSG in DRC The layers check needs to look for testing against technical layers for those vias that pass the outer layers	2023-06-03 20:25:35 -07:00
Jeff Young	5875f89531	Centralize text size clamping. Also introduces alg::clamp to improve readability of std::max( min, std::max( value, max ) ) Fixes https://gitlab.com/kicad/code/kicad/-/issues/14876	2023-06-03 20:29:51 +01:00
Wayne Stambaugh	bdee545841	Coverity warning fixes.	2023-06-03 07:28:17 -04:00
Seth Hillbrand	7f5d790610	Ensure we aren't trying to access a closed board	2023-06-02 15:47:46 -07:00
Jeff Young	97cf7c874e	Handle Altium dimension angles and non-unit suffixes. Fixes https://gitlab.com/kicad/code/kicad/-/issues/13751	2023-06-02 18:30:16 +01:00
Jeff Young	3c8d2bfca5	Assertion checking for hole/parent ownership mismatch. (This mismatch is the root of the problem in issue #14852.)	2023-06-02 18:30:16 +01:00
jean-pierre charras	9a47b34499	Replace PAD_SHAPE::RECT by PAD_SHAPE::RECTANGLE to avoid a collision NAME with a windows header on MSYS2, creating many compil warnings. No actual code change.	2023-06-02 12:18:24 +02:00
Tomasz Włostowski	3c3517cc36	router: can't add a clone of a VIA's hole when adding the via to INDEX - this will result in bogus colliding objects This commit partially reverts `deb3cbf8`. VIA and SOLID operator='s introduced in it do a good job but the cloning of holes in addHole() causes bogus collisions.	2023-06-01 22:47:02 +02:00
jean-pierre charras	db3cf4274b	Modify the order of an include to avoid a collision name with a windows header that prevent Kicad build (msys2 specific)	2023-06-01 16:26:19 +02:00
Jeff Young	deb3cbf89b	Prevent use-after-free crashes by not fighting over who owns a HOLE. The diff-pair placer creates DIFF_PAIRs on the stack, which have VIAs in them, which have HOLEs in them. The HOLEs get put in the NODE's index, and we then crash later when doing a collision after the stack variable has gone out of scope. The stack variable is also copied while doing a search for "best", and without the operator= definitions the "best" and the "original" both think they own the HOLE. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14852	2023-06-01 15:07:29 +01:00
Seth Hillbrand	c7758999af	Handle LOCKFILE logistics for ro We need to check if a lockfile is valid to determine if we should override the lock. Valid() is true if the lockfile couldn't be created b/c of permissions or if the lockfile could be created and acquired.	2023-05-31 17:04:32 -07:00
Seth Hillbrand	aacf8f50bf	Remove unneeded headers from pcbnew_scripting_helpers.h	2023-05-31 15:54:46 -07:00
Jeff Young	ddd2cb005b	Don't allow setting a pad width or height of 0. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14278	2023-05-31 23:41:43 +01:00
Tomasz Wlostowski	7966126040	router: invalidate items freed by PNS::NODE in the clearance cache This was causing intermittent shove hiccups/freezes as RULE_RESOLVER::GetClearance() could return a bogus clearance value, taking a cached value for an item that does not exist anymore. If the allocator/stack accidentally reclaimed such item's address - we were getting very nasty and difficult to reproduce misbehaviours of the shove algorithm. Hopefully this patch fixes this. More info in the comments. Note to self - I'm still not fully convinced I want PNS::ITEM pointers as the cache key, probably a unique counter would be better here.	2023-06-01 00:01:15 +02:00
Seth Hillbrand	14f6e32c74	ADDED: Change watcher for libraries When editing or viewing library symbols, the files are watched for underlying changes. If any occur, the user is either prompted to reload (if reloading would overwrite their current edits) or the file is silently updated to the current version on disk. This also sets a custom assertion handler to avoid unneeded crashes when recieving invalid SAMBA packets and turns off assertions entirely when running in release (non-debug) mode	2023-05-31 13:46:00 -07:00
Tomasz Wlostowski	15db42d9c8	router: fix use-after-free crash in drag walkaround mode	2023-05-31 22:20:28 +02:00
Tomasz Wlostowski	5100345c6e	router: prevent pushout/bogus collision of via with is own hole (or copper) when dragging The root cause was not removing the original (pre-dragging) via from the world, comparing the ITEM::Parent() pointers of the items was only hiding the main issue. This also fixes the PNSViaCollisions test in the qa/ suite.	2023-05-31 17:06:24 +02:00
Jeff Young	8baf2a832f	Make pad flipping work both from parent footprint and individually. The last fix was for individual pads, but it broke when the whole footprint was flipped for rotated footprints. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14829	2023-05-31 11:13:35 +01:00
Jon Evans	3783fc8f5a	Remove unused line	2023-05-30 20:06:18 -04:00
Jeff Young	4874537c40	Push/pop router tool for inline drag. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14832	2023-05-30 18:02:12 +01:00
Jeff Young	c36b0fcda7	Make sure 3D file browser is treated as modal by quit. (Otherwise we crash when freeing it during the quit.)	2023-05-30 14:58:46 +01:00
jean-pierre charras	6b845b9054	Fix compil warnings and a wxWidgets alert.	2023-05-30 09:00:46 +02:00
Jon Evans	141cc85ff3	PNS: Work around collision checking issues in shove mode Need to special-case shove mode since `942ee13c` introduced collision checking in all modes. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14836	2023-05-29 18:19:47 -04:00
Roberto Fernandez Bautista	bb90aa24b7	Add basic QA test to CADSTAR PCB footprint import	2023-05-29 23:29:28 +02:00
Roberto Fernandez Bautista	3b56b7bf68	Fix assert in PROPERTY_ENUM (ENUM_MAP<PCB_LAYER_ID> was not initialised)	2023-05-29 23:29:28 +02:00
Jeff Young	f5791f5dc6	Left some fixes out of previous commit.	2023-05-29 16:22:24 +01:00
Roberto Fernandez Bautista	9633c8af22	CADSTAR PCB: Fix regression in loading of thermal pads Due to removal of SetPos0 in `28028c94`, we now don't need to compensate for the position of the footprint while importing.	2023-05-29 16:41:47 +02:00
Jeff Young	65e53b8ecd	Move SHAPE_POLY_SET::Inflate's error spec from a seg-count to a max-deviation. 1) Also reorders parameters to make sure the compiler helps out. 2) This also makes it harder to mess up the discrepency between BOX2I/wxRECT/etc::Inflate() and SHAPE_POLY_SET::Inflate. 3) Also fixes a couple of bugs where the corner strategy was passed in as a segCount. 4) Also fixes a couple of bugs where the error wasn't forced to the outside to match the ERROR_LOCATION. 5) Also fixes a couple of bugs where the seg count was specified without regard to an already passed-in max deviation	2023-05-29 15:29:03 +01:00
jean-pierre charras	ef4dded915	PCB_TEXT::TransformTextToPolySet(): fix incorrect param when calling Inflate() This incorrect value created hang when clicking on a pcb text.	2023-05-29 14:21:10 +02:00
Roberto Fernandez Bautista	dfebe516c5	CADSTAR PCB: Fix memory leak	2023-05-28 23:56:43 +02:00
Roberto Fernandez Bautista	a119bd604d	Refactor: Move DIALOG_PLUGIN_OPTIONS to common and use enum for event ID	2023-05-28 23:56:41 +02:00
Jeff Young	c71cf21e2f	Use rendered text to generate bounding box for knockout text. Don't open-code knockout text shape generation in several different places. Make sure triangulated knockout text gets clearance added when specified. Collapse duplicated footprint text item plot routine (they're no longer any different from plotting pcb text items).	2023-05-28 17:20:11 +01:00
Jeff Young	95a09f686b	Revert attempt to use drawing code to generate text bounding boxes.	2023-05-27 22:11:34 +01:00
Jeff Young	cb53a18ee3	Bug fixes for handling boolean flags in DRC rules.	2023-05-26 18:44:33 +01:00
Jeff Young	768fbf5af2	Give up on trying to calculate text bounding boxes. It results in too many hacks strewn through the code. Just draw the text and measure it. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14803	2023-05-26 18:44:33 +01:00
Jon Evans	942ee13cd1	PNS: Allow width-caused DRC violations at start of route Also fix an issue where DRC violations introduced by the width change action could be committed in walk/shove mode. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14805	2023-05-25 23:10:00 -04:00
Jeff Young	50da4e483e	Tailor inspector text properties for dimension objects.	2023-05-25 16:18:37 +01:00
Jeff Young	05fef51d81	Push rendering portion of text cache generation down into CALLBACK_GAL.	2023-05-25 11:25:32 +01:00
Jeff Young	1518ddde74	Push much of text var autocomplete down into SCINTILLA_TRICKS. Shared code == fewer bugs. Well, in theory anyway....	2023-05-25 10:24:50 +01:00
Jeff Young	14f004d2a5	Hook up text variable auto-complete for PCBNew. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14777	2023-05-25 10:24:50 +01:00
Seth Hillbrand	48ecd742eb	Maintain file permissions when renaming Temporary and autosave files do not neccessarily have the correct permissions set to replace existing project files. This updates the permissions to match the existing values where possible Fixes https://gitlab.com/kicad/code/kicad/-/issues/13574	2023-05-24 17:09:38 -07:00
Seth Hillbrand	122be418bb	Upgrade file locking wxSingleInstanceChecker is meant for running programs, not file locking. This implements an RAII class for file locking that stores the lock files next to the file being locked, allowing it to be easily found and removed. Also includes the ability to override the lock, with information about the original owner Fixes https://gitlab.com/kicad/code/kicad/-/issues/14734	2023-05-24 13:51:54 -07:00
jean-pierre charras	76d66571e4	Pcbnew: fix crash when trying to save a board with a text with overbar and using a non Kicad font PCB_PLUGIN::formatRenderCache() was considering all shapes in cache are polygons, but this is not true: some items can be stroke shapes. Fixes #14804 https://gitlab.com/kicad/code/kicad/-/issues/14804	2023-05-24 18:21:50 +02:00
Jeff Young	2ac3f4cc9e	Undo strategy based on being in a footprint, not footprint editor. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14799	2023-05-23 17:56:12 +01:00
Jeff Young	56853a6209	Change teardrop edge shape to a checkbox.	2023-05-23 17:45:26 +01:00
Jeff Young	b442d769fd	Don't allow collisions with self. The previous test didn't handle is-self-tests between a hole and its override in a different NODE. When calculating the pushout force we don't remove the via (and its hole) from the current node until after the calculation, so we end up checking for collisions between the new (cloned) via's hole and the original hole in the root node. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14795	2023-05-23 14:10:22 +01:00
Wayne Stambaugh	5b539958a2	Fix track and via properties dialog radio buttons on GTK.	2023-05-22 13:54:13 -04:00
Jeff Young	00986484e0	Attempt to fix teardrop radio buttons on GTK.	2023-05-22 14:48:53 +01:00
Wayne Stambaugh	a13a49f45a	Fix clipped combobox entry in board editor text box dialog. The layer combobox color swatch was clipped when the combobox was closed when the dialog was launched. Setting the minimum width resolved the issue. This may have been a GTK only issue.	2023-05-22 08:54:48 -04:00
Jeff Young	df763eaf88	Reconcile PNS router with DRC. Hole-to-hole is only for drilled holes. NPTH slots also get EDGE_CLEARANCE applied. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14771	2023-05-21 19:58:00 +01:00
Jeff Young	7e51077992	STL is your friend... until it's not. Operator[] was creating an empty entry in the connectivity map, fooling us into thinking the item had already been added. Worryingly, this bug has been in there since 2017; a recent change in teardrops just happened to expose it. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14781	2023-05-21 17:56:43 +01:00
Jeff Young	ff9a5b8373	Remove change from teardrop merge that wasn't needed for final impl.	2023-05-21 16:39:18 +01:00
Jeff Young	502da2d03c	Performance improvements.	2023-05-21 11:23:56 +01:00
Jeff Young	08a9d4b26f	ADDED preference for ratsnest thickness. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14708	2023-05-21 00:07:08 +01:00
Jeff Young	80aef37cc4	Don't consider shorted items when opitmizing ratsnest. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14715	2023-05-20 22:54:44 +01:00
Jeff Young	ea341289de	Fix uninitialized variable (Coverity report).	2023-05-20 21:10:09 +01:00
Marek Roszko	8a7044c3fb	Fix some more warnings	2023-05-20 08:00:16 -04:00
Alex	9d452a6097	Fix opening boards with deprecated features.	2023-05-20 07:39:01 +03:00
Jeff Young	4c59365867	Blind attempt to fix pns-debug-tool linking issue.	2023-05-19 19:26:03 +01:00
Jeff Young	8b1fd62d35	Make pad & via teardrops 1st-class citizens (props of the pad/via) Change teardrop generation to rely more heavily on BOARD_CONNECTIVITY for improved performance. Add updating of teardrops on BOARD_COMMIT::Push(). Also converts m_CopperItemRTreeCache to std::shared_ptr. We don't copy it around anyway, and having to create a new set of std::unique_ptr's for each operation is likely to be more expensive than std::shared_ptr's overhead.	2023-05-19 18:02:03 +01:00
jean-pierre charras	86c75cf261	Fix a compil issue.	2023-05-19 09:24:49 +02:00
Marek Roszko	3bf2fb2c0e	Fix more C5266 warnings	2023-05-18 22:08:50 -04:00
Jon Evans	27afd22bbf	Specctra: remove grouped tracks from group before cleaning up Fixes https://gitlab.com/kicad/code/kicad/-/issues/14763	2023-05-17 23:03:06 -04:00
Seth Hillbrand	0de24bfd59	Cleanup text alignment between version 6 and 7 Version 7 text alignment changed subtly for stroke fonts from version 6. Additionally, the output has been different between screen and plotting, leading to offset text in plotted output relative to the text shown on screen. This introduces a fudge factor in FONT::getLinePositions to correct the offset in the plotting output relative to v6. This also changes the SCH_PAINTER and PCB_PAINTER to correct the relative offsets between GAL and PLOTTER classes. The source of these offsets is atm unclear. Fixes https://gitlab.com/kicad/code/kicad/issues/14755	2023-05-17 13:33:49 -07:00
Ian McInerney	20ec8ed303	Fix GitLab URLs to point to the correct project page GitLab 16.0 removes support for URLs that don't contain /-/ after the repository name, so the report bug feature and various links we had in the source (including the git-fixes script) would lead to a 404 error. See GitLab docs for deprecation/removal notice: https://docs.gitlab.com/ee/update/deprecations.html?removal_milestone=16.0#legacy-urls-replaced-or-removed Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14759	2023-05-17 11:23:00 +01:00
jean-pierre charras	66651327bd	STEP export: in board outlines, export Circles as Cylinders, round 2. Other arcs (not 360 deg arcs) are still exported as polylines	2023-05-16 13:39:16 +02:00
jean-pierre charras	99bdb82dff	Revert "STEP export: in board outlines, export Circles as Cylinders." This reverts commit `09515fe821`. It does not pass a QA test	2023-05-16 09:59:53 +02:00
jean-pierre charras	09515fe821	STEP export: in board outlines, export Circles as Cylinders. Other arcs (not 360 deg arcs) are still exported as polylines	2023-05-16 08:46:34 +02:00
Jon Evans	94130716a5	PNS: Collision search context may be null Fixes https://gitlab.com/kicad/code/kicad/-/issues/14741	2023-05-14 17:20:59 -04:00
Alex	d790865549	Make sure text bounding box exists when syncing PNS world. Fixes https://gitlab.com/kicad/code/kicad/issues/14733	2023-05-14 13:40:14 +03:00
jean-pierre charras	22de1c8813	Teardrop dialog: refinements. Show a PROGRESS_REPORTER when refilling zones.	2023-05-12 10:06:20 +02:00
Steve Bollinger	85f4f0d6c8	pcbnew: switching track posture may not work on first attempt If you drag a track out and connect to a pad then press the hotkey to switch the track posture it may not switch because the track posture selected when the pad was reached is different than the one that the mouse trail placer drew. As the aspect switching is done in the mouse trail placer it does not know that the line placer already override the track. To correct this, in LINE_PLACER::FlipPosture() if the aspect is not currently manually forced then copy the current aspect from the line placer to m_mouseTrailPlacer before calling the FlipPosture() method of m_mouseTrailPlacer. This will only be done once per dragging session as once the aspect is manually forced it remains manually forced. This seems to fix the issue with no undesirable side effects. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12369	2023-05-11 23:35:21 +00:00
Jon Evans	89aae88e96	PNS: make sure context options are used in collideSimple Fixes https://gitlab.com/kicad/code/kicad/-/issues/14659	2023-05-11 16:48:15 -04:00
Jon Evans	2e60315959	PNS: Don't use clearance epsilon for calculating shove distances Fixes https://gitlab.com/kicad/code/kicad/-/issues/14707	2023-05-11 13:09:03 -04:00
Jeff Young	35158a7db9	Use track opacity for teardrops.	2023-05-11 15:57:44 +01:00
Jeff Young	4da6d5ff28	Add "generate raw teardrops" option to Add Teardrops dialog. Fixes https://gitlab.com/kicad/code/kicad/issues/14711 Fixes https://gitlab.com/kicad/code/kicad/issues/14704	2023-05-11 15:47:42 +01:00
Jeff Young	daa3a1aae9	Revert addition of update-teardrops checkbox to DRC dialog.	2023-05-11 14:53:28 +01:00
Jeff Young	9481a218c7	Lazy loading of stackup UI widgets.	2023-05-11 14:37:48 +01:00
Jeff Young	3f44c811c7	Don't run onPageChanged() event handler during initialization.	2023-05-11 12:51:55 +01:00
Jeff Young	03c9b1c202	Move remainder of Board Setup to lazy loading.	2023-05-11 11:43:10 +01:00
Jeff Young	ddc6ecf7be	Lazy loading of Schematic Setup panels.	2023-05-11 11:43:10 +01:00
Jon Evans	932f171e96	Remove hard-coded safety margin from specctra output Fixes https://gitlab.com/kicad/code/kicad/-/issues/14713	2023-05-10 21:55:47 -04:00
Jeff Young	9ae8255202	Insta-prefs.	2023-05-10 18:14:14 +01:00
jean-pierre charras	31d613c746	Fix a few Coverity warnings (not initialized vars) It also fixes a potential crash when closing Kicad.	2023-05-10 09:21:39 +02:00
Jeff Young	245c3ba6e4	CLang can't do a dynamic_cast across the KiWay. Rely on DRC for text readability instead. (Fixes Sentry KICAD-R4 on Mac, and the assert when opening Preferences from a non-PCBNew-module window.)	2023-05-09 11:10:33 +01:00
Jeff Young	2dcbc10a09	Performance optimization.	2023-05-08 11:46:04 +01:00
Jeff Young	5b3798a370	Holes need a parent. SetHole() handles all this for us. Make sure it's called. Fixes https://gitlab.com/kicad/code/kicad/issues/14702	2023-05-08 11:41:12 +01:00
Jeff Young	f883b7fd4d	Fix layout inconsistencies in Gen Footprint Pos file dialog.	2023-05-08 10:57:43 +01:00
Jon Evans	b06f90335b	PNS: Remove holes when removing items with holes Related to https://gitlab.com/kicad/code/kicad/-/issues/14702	2023-05-07 22:12:11 -04:00
Jeff Young	7978941fa8	Don't allow thickness of 0 in case of an empty stackup. Fixes https://gitlab.com/kicad/code/kicad/issues/10790	2023-05-07 22:24:40 +01:00
Jeff Young	5bf450a89f	Performance. (Coverity)	2023-05-07 14:58:44 +01:00
Jeff Young	2762fa7787	ADDED: track width & via size filters in Edit Track & Via Properties Fixes https://gitlab.com/kicad/code/kicad/issues/13315	2023-05-06 23:20:39 +01:00
Jeff Young	7bb81f7573	Expand solder mask for pads defined to be on copper layers. Fixes https://gitlab.com/kicad/code/kicad/issues/14693	2023-05-06 21:39:01 +01:00
Lucas Dumont	a22e6db982	Add Zone when dragging component Fixes https://gitlab.com/kicad/code/kicad/-/issues/14629	2023-05-06 09:32:38 +00:00
Jeff Young	b41d446f58	Fix a bunch more issues with sheetpaths and allowExtraText. A sheetpath is required to correctly resolve text variables. Depending on currentSheet is rife with bugs. There are many places where we do not want to be prepending field names to the field values, such as netlisting, building PDF hypertext menus, etc. Also, Find/Replace needs to work on unresolved text, as that's what we're going to display (and if replace nuked your variable references you wouldn't be happy).	2023-05-05 17:23:52 +01:00
Jeff Young	cd43dccb18	Add missing property to footprint texts table. Fixes https://gitlab.com/kicad/code/kicad/issues/14357	2023-05-03 17:57:13 +01:00
jean-pierre charras	152f6d80e5	Use operator at() instead of [] to access a std::array item It helps debug.	2023-05-03 16:40:40 +02:00
jean-pierre charras	631dde3ed1	Pcbnew: fix crash when loading a file having vias on connected layers only. It was due to an access out of bounds in a std::array Fixes #14668 https://gitlab.com/kicad/code/kicad/issues/14668	2023-05-03 16:06:32 +02:00
Jeff Young	0eac5c6748	Tighten lifecycle management of CN_ANCHOR/CN_ITEM. In particular, when a CN_ITEM is freed set all its anchor's item pointers to NULL. (The anchors have a separate lifecycle due to being std::shared_ptrs.) Hopefully fixes Sentry KICAD-KV.	2023-05-03 10:50:31 +01:00
Jeff Young	b53f337938	More accurate terminology for cross-probe settings. Fixes https://gitlab.com/kicad/code/kicad/issues/13088	2023-05-03 10:50:31 +01:00
Jeff Young	f27bc16d62	Cleanup API and use text bounding box for routing. If someone wants to route around the text more tightly they can now convert the text to polygons. Fixes https://gitlab.com/kicad/code/kicad/issues/14252	2023-05-02 16:03:43 +01:00
Jeff Young	80f8cd2254	Commenting and formatting.	2023-05-02 14:16:02 +01:00
Jeff Young	df7d62fdd3	Added a sort-order dropdown to lib-tree filters. Also simplifies the scoring algorithm so that it only differentiates between exact-match, match-at-start and any-match. The rest of the position-based matching stuff is gone, as is the knowledge of the name vs the keywords vs the description. All that is left to the provider of the weighted search terms array.	2023-05-01 21:26:43 +01:00
Mike Williams	04a53ea40d	Picker Tools: make sure we know what tool we are Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14621	2023-05-01 12:43:09 -04:00
Mike Williams	39cc686dc4	Back Annotation: add support for DNP and Exclude from BOM attributes Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14584	2023-05-01 08:54:14 -04:00
Jeff Young	c31fb435e6	Add missing setting to Dimension Properties dialog. Also fixes a bug where during file save we were calling GetPosition() on the PCB_TEXT but getting the DIMENSION's version. Fixes https://gitlab.com/kicad/code/kicad/issues/8447	2023-04-30 22:45:19 +01:00
Jeff Young	2f9889ff62	Add settings for plotting PDF property popups. Fixes https://gitlab.com/kicad/code/kicad/issues/14450	2023-04-30 18:10:04 +01:00
jean-pierre charras	096af19d9a	Minor fix and cosmetic change: - SCH_SYMBOL::GetMsgPanelInfo(): slighly change the displayed lines to allow longer strings in Description and Keywords - panel_setup_rules_help.md: fix incorrect html link (URI), creating ERR 404	2023-04-30 17:37:30 +02:00
Jeff Young	1c6b765ba5	Formatting and cleanup.	2023-04-30 13:43:25 +01:00
Jeff Young	af7753c7cd	Record parent rule for DRC assertions. (Particularly important if the rule specified a severity.) Also fixes a bug looking up LSET layer names in the GetStandardLayerNames array (which aren't the same). https://forum.kicad.info/t/a-few-questions-about-custom-rules-syntax/40068/7	2023-04-30 13:01:09 +01:00
Seth Hillbrand	f4b43617e7	Add COMMIT structure to Schematic and Symbol editors Provides a single-point access for modifying the schematic and symbol elements that allows chaining updates and reverting partial changes. Standardizes the undo hierarchy between pcb and schematic editors As this is another layer on the existing undo/redo structure, the initial commit does not replace all undo/redo calls currently existing. These will be handled in a series of follow-on commits	2023-04-28 17:05:47 -07:00
Jeff Young	251161dbeb	Bring inspection reporting in line with zone filler 1) "clearance" rules don't apply to NPTH holes with no copper 2) local zone clearance applies even if other item has no copper Fixes https://gitlab.com/kicad/code/kicad/issues/14575	2023-04-28 22:15:10 +01:00
Jeff Young	16e000f2b0	Use Net() accessor uniformly; init hole parent in VIA::Clone() Fixes https://gitlab.com/kicad/code/kicad/issues/14603	2023-04-28 18:32:58 +01:00
Jeff Young	6807ca6f9f	Allow text input to Convert to Polygon/Zone/Keepout. Also fixes non-copper zone filler to honor fill keepouts. Fixes https://gitlab.com/kicad/code/kicad/issues/14566	2023-04-28 17:43:08 +01:00
Lucas Dumont	b1a4353c34	Update collide for hole As hole don't keep track of the net, update the collide function to keep it working	2023-04-28 10:20:55 +00:00
Jeff Young	b2a45023bc	Tighten ownership model of PNS::ITEM. In particular, ownership must be explicitly set. It is no longer inherited through copy/clone/etc.	2023-04-28 11:05:39 +01:00
Jeff Young	9646e3c1c0	Simplify PNS::VIA construction.	2023-04-28 00:32:49 +01:00
Lucas Dumont	c781fde236	pcbnew: don't move twice In pcbnew, if you press M to move your selection and press M again, then escape, you will trigger the https://gitlab.com/kicad/code/kicad/-/blob/master/common/tool/tools_holder.cpp#L106 assert	2023-04-26 15:37:18 +00:00
Lucas Dumont	2992d7c68b	Fix typo in QueryConstraint switch	2023-04-26 13:20:32 +00:00
jean-pierre charras	2f392352b5	EDIT_TOOL::doMoveSelection(): avoid calling PushTool() and, just after,PopTool() for the same event: TOOLS_HOLDER::PopTool() does not work fine in this case.	2023-04-26 13:00:50 +02:00
Seth Hillbrand	f7f52d77e4	Rework Copper Sliver check Adds QA checks to copper sliver tests. Adds the following checks: - Dot product between two arms (quickly avoids checks for >90°) - Checks the sliver is convex (area test) - Eliminates minor slivers with angles that are approximately 0 and ones with the opposite side width beneath a configurable level - Updates Clipper2 to fix a couple of jagged edges on inflate - Adds simplify during zone fill inflation to limit jaggies Fixes https://gitlab.com/kicad/code/kicad/issues/14549	2023-04-25 10:32:46 -07:00
jean-pierre charras	b9ed84b7db	Fix minor compil warnings	2023-04-25 12:43:15 +02:00
Lucas Dumont	e2e901de1d	Don't override clearance when routing The default `m_overrideClearance = -1` used here was changed to 1. Reseting it to -1 to solve linked issue Fixes https://gitlab.com/kicad/code/kicad/-/issues/14595	2023-04-25 09:18:53 +00:00
Jeff Young	676a15df65	Don't try to keep track of a HOLE's net. Keep track of it's parentPadVia instead. Fixes https://gitlab.com/kicad/code/kicad/issues/14603	2023-04-24 18:32:17 +01:00
jean-pierre charras	d180ce7865	Pcbnew, minor fix: make Image Properties dialog re-sizable.	2023-04-24 10:21:31 +02:00
jean-pierre charras	8fc70d577f	better QFNWizard.	2023-04-23 17:34:21 +02:00
jean-pierre charras	c617abe8e9	SCH_BITMAP and PCB_BITMAP: rename m_image to m_bitmapBase. Add more info in GetMsgPanelInfo() (PPI, scale). m_image name was confusing: it is not a wxImage, but a BITMAP_BASE item, and m_image name was already in use in BITMAP_BASE, used inside SCH_IMAGE. Bitmap properties dialog: show PPI value and add Title to dialog.	2023-04-22 17:28:06 +02:00
jean-pierre charras	0c544f1f45	FOOTPRINT_EDIT_FRAME: do not delete settings when closing the frame. They now are read when starting kicad, and must be not deleted.	2023-04-22 11:46:52 +02:00
Marek Roszko	dbed94e4b1	Fix gerbers and drill plot not logging errors Partial fix for https://gitlab.com/kicad/code/kicad/-/issues/14437	2023-04-20 23:39:59 -04:00
Marek Roszko	9f64c7f354	Load custom drawing sheets for pcb cli Fixes https://gitlab.com/kicad/code/kicad/-/issues/14171	2023-04-20 23:17:52 -04:00
Seth Hillbrand	990641d2eb	Cleanup printf bits	2023-04-20 15:19:04 -07:00
Seth Hillbrand	4b91c0c8ee	Handle multiple holes in footprints Our basic logic for whether we have a hole or an outline in a footprint checks if there is copper pads outside of the closed edge. This misses the case where the footprint is used to align multiple holes but has no copper. Since we do not support multiple outlines in a board, we can safely assume that multiple, closed edges in a footprint represent holes and not outlines Fixes https://gitlab.com/kicad/code/kicad/issues/14468	2023-04-20 14:56:36 -07:00
Seth Hillbrand	b56db30019	Ensure that even open paths with fills are filled SVG paths that are "open" can still have a fill internally, so avoid dropping fills for these non-standard polygons Fixes https://gitlab.com/kicad/code/kicad/issues/14518	2023-04-20 12:31:04 -07:00
jean-pierre charras	d4cf063e40	Fix a few more doxygen errors (no actual code change)	2023-04-19 20:24:42 +02:00
jean-pierre charras	a20f757d8c	undo a change (it was only a test) committed by mistake.	2023-04-19 16:57:35 +02:00
jean-pierre charras	1406341d2d	Fix a few doxygen errors (no actual code change)	2023-04-19 16:20:24 +02:00
Marek Roszko	ea077bc34d	Banish ignore.h to core	2023-04-18 22:44:04 -04:00
Seth Hillbrand	32d17547e5	Fixup settings loading Settings loading needs to account for potential chaining, so each instance should be created before being Load()ed. Additionally, add the settings loading to QA	2023-04-18 16:00:31 -07:00
Seth Hillbrand	e6ab9a88ce	Remove locks from settings Settings should be initialized on start-up. This removes the option of lazily loading the settings from file and instead requires all settings needed to be loaded on KiFACE start before requesting data from the settings object	2023-04-18 13:40:25 -07:00
Jeff Young	c682d11fa0	Trim VRML export layers to board outline. Fixes https://gitlab.com/kicad/code/kicad/issues/14557	2023-04-18 17:31:29 +01:00
jean-pierre charras	ba12f00c15	Pcbnew: re-add draw umbilical line for texts in footprints. It was lost after removing FP_TEXT in code.	2023-04-18 09:48:46 +02:00
Jeff Young	7e5fedef6a	Markup fixes. 1) allow escape sequences inside markup sequences 2) keep overbar when inside nested markup 3) always place overbar at full height, not sub/superscript height Fixes https://gitlab.com/kicad/code/kicad/issues/14553 Fixes https://gitlab.com/kicad/code/kicad/issues/13449	2023-04-17 17:56:54 +01:00
qu1ck	9b58f50c68	Add usable PCB_GROUP::GetItems() swig wrapper	2023-04-17 15:41:49 +00:00
Nimish Telang	51e55dd750	Convert sprintf to snprintf in most files	2023-04-17 15:39:34 +00:00
jean-pierre charras	d0676118c1	BOARD_NETLIST_UPDATER: better warning message (I hope...) in Report. Fixes #14548 https://gitlab.com/kicad/code/kicad/issues/14548	2023-04-17 14:30:47 +02:00
Lucas Dumont	469fe76994	pcbnew: Fix crash with differential routing Fixes https://gitlab.com/kicad/code/kicad/-/issues/14537	2023-04-17 14:17:14 +12:00
jean-pierre charras	725c2fd661	footprint wizards: fix for my previous commit `50502c4`	2023-04-16 17:16:54 +02:00
jean-pierre charras	50502c450f	footprint wizards: fixes and enhancements	2023-04-16 17:03:32 +02:00
Jeff Young	b76ef8c7e2	Multi-threading safety. (Possible fix for KICAD-74.)	2023-04-16 15:36:21 +01:00
Jeff Young	2793bb1d68	Performance.	2023-04-16 15:36:21 +01:00
Jeff Young	26c14271f2	Formatting and warnings cleanup. (No functional changes.)	2023-04-16 15:36:21 +01:00
jean-pierre charras	7545097d7f	Fix a compil issue on msys2/gcc12.2, due to changes in commit `dd1c58dc`	2023-04-16 15:28:34 +02:00
Marek Roszko	dd1c58dcf5	Fix MSVC C4840 warning va_start requires trivially copy able classes. wxString is not trivial. The correct thing to do is to use wxChar*	2023-04-16 07:36:41 -04:00
Jeff Young	299c88cfec	Allow setting 0 to min width, min track width, min via annular width, etc. Fixes https://gitlab.com/kicad/code/kicad/issues/13822	2023-04-15 13:20:34 +01:00
Jeff Young	2d15067453	ADDED allow update of teardrops before running DRC. Fixes https://gitlab.com/kicad/code/kicad/issues/14264	2023-04-15 12:18:41 +01:00
Jeff Young	521aa5b5ae	Update DRC exclusions model to match terminology. DRC exclusions were originally written following the C++ pragma model (ie: allow this violation here). However, the "exclusion" terminology we used in the GUI suggests a model model where the exclusions go away when the violation no longer exists. Fixes https://gitlab.com/kicad/code/kicad/issues/14351	2023-04-15 12:18:41 +01:00
jean-pierre charras	27ebba6b33	Python and footprint wizard: fix issues and update to be compatible with recent changes in Kicad code.	2023-04-15 10:30:33 +02:00
Jeff Young	4a3f77cd9d	Clear board soldermask when undoing/redoing items that affect it. Fixes https://gitlab.com/kicad/code/kicad/issues/13446	2023-04-15 00:06:58 +01:00
Jeff Young	d01c023d5a	Retire the lib-tree scoring algorithm. It appears to cause more confusion than help. Fixes https://gitlab.com/kicad/code/kicad/issues/13905	2023-04-14 23:35:27 +01:00
Salvador E. Tropea	d5c0bf3d0e	Load the global fp-lib-table before running the Python DRC Without this we get parity errors for all the KiCad footprints (cherry picked from commit `e5087ca3db`)	2023-04-14 12:09:48 -04:00
Jeff Young	26609bbf05	Fix PNS_KICAD_IFACE_BASE::IsFlashedOnLayer() to be able to handle multi-layer queries.	2023-04-14 12:02:36 +01:00
jean-pierre charras	b2bf3229e6	BOARD::Move(): o not move twice PCB_SHAPES in footprints. Altium importer: fix incorrect position of imported PCB_TEXTs in footprints.	2023-04-14 10:42:02 +02:00
jean-pierre charras	97a4e535dc	ConvertOutlineToPolygon(): fix handling of polygons living in footprints. Due to recent changes in PCB_SHAPE items, the polygon coordinates are now in board coordinates, not in coord relatives to the parent footprint. Fixes #14530 https://gitlab.com/kicad/code/kicad/issues/14530	2023-04-13 17:22:03 +02:00
Mike Williams	33b2b5b09d	STEP Export: Update options to reflect DNP and Unspecified filtering Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14125	2023-04-13 10:33:03 -04:00
Jeff Young	8e29a054f3	Performance improvement for GetShownColumns. (This needs to be fast as it's called from OnUpdateUI events.)	2023-04-13 13:45:22 +01:00
Ian McInerney	871f7e05a5	Remove use of wxGRIDTABLE_REQUEST_VIEW_GET_VALUES from the appearance panel That even was removed by upstream wxWidgets in `81570ae070` which is included in all versions after 3.1.1, so our 3.2 versions definitely aren't doing anything when we pass this event. The actual identifier has also been guarded behind a 3.0 compatibility define in wx as of 3.3.	2023-04-12 18:57:12 +01:00
Ian McInerney	8f3bbf36f8	Replace __WXGTK20__ with __WXGTK__ We no longer care about a GTK2 vs 3 difference, we only support GTK 3.	2023-04-12 18:57:12 +01:00
Ian McInerney	5d0b5e16ff	Remove python-based board_item duplicate method This method shadows the C++ method, and doesn't properly handle updating the duplicated object's KIID to be unique. Also add tests to ensure the KIIDs are unique after duplication. Fixes https://gitlab.com/kicad/code/kicad/issues/14460	2023-04-12 16:05:56 +01:00
Jeff Young	e1c9e0e6fc	ADDED memberOfFootprint() to DRC custom rules functions. Also added memberOfGroup(), and deprecated memberOf().	2023-04-12 14:06:09 +01:00
Jeff Young	6059e895d7	Fix a typo. Fixes https://gitlab.com/kicad/code/kicad/issues/14515	2023-04-12 10:45:24 +01:00
Marek Roszko	37eaa29679	Fix crash due to extra right parens in pcad files Fixes sentry KICAD-TA	2023-04-11 21:52:39 -04:00
Marek Roszko	ed94bc4bf9	Don't crash on empty pcad polygons Fixes sentry KICAD-103	2023-04-11 21:38:59 -04:00
Jeff Young	eef3492fc0	Make symbol/footprint trees sensitive to language change.	2023-04-11 23:51:58 +01:00
qu1ck	0c049eccc7	Fix a bunch of compiler warnings	2023-04-11 17:01:30 +00:00
Jeff Young	6fb30398ca	Don't steal an existing via's hole.	2023-04-11 17:48:27 +01:00
Jeff Young	ab0dbeb523	Post-holes-work cleanup.	2023-04-11 15:51:00 +01:00
Jeff Young	2f198bdcb2	Further simplify PNS::ITEM::collideSimple(). Also brings text_pns_basic's mocks into line with their "real" counterparts.	2023-04-11 15:51:00 +01:00
Jeff Young	6f0d963683	Add PNS::ITEM::BoardItem() call. About 1/3 of callers to Parent() don't care if they get the immediate parent or not, about 1/3 want only the immediate parent, and about 1/3 want the hole parent's Parent(). I had earlier changed PNS::ITEM::HOLE to override Parent() and return the hole parent's Parent(), but since the callers are pretty evenly split I've reverted that and added BoardItem() for callers who want the eventual BOARD_ITEM (whether a direct parent or a grandparent). (Also removes a dead routine so I didn't have to figure out which of the two it wanted....)	2023-04-11 15:51:00 +01:00
Jeff Young	8a0c225efa	Unify most special-case processing to the clearance if-then-else. This also allows us to support hole-to-hole clearance when dragging a via near another via on the same net. Fixes https://gitlab.com/kicad/code/kicad/issues/12781	2023-04-11 15:51:00 +01:00
Jeff Young	b18bf09208	Don't return holes that have a parent pad or via. (While we don't currently have holes without a parent pad or via, you could imagine using HOLEs in the future to represent a hole in a first-class board outline, so better not to build this assumption in.)	2023-04-11 15:51:00 +01:00
Jeff Young	4cc289c6fb	Post-merge cleanup of holes-as-first-class-citizens.	2023-04-11 15:51:00 +01:00
Tomasz Wlostowski	1532a83330	router: hole as first-class-object, initial version of rewritten collision check routine Rebased and modified by Jeff Young <jeff@rokeby.ie> 6 April 2023	2023-04-11 15:51:00 +01:00
Tomasz Wlostowski	d961cdce3f	router: further changes to the ownership model - LINEs now own their vias optionally (depending whether a LINE with its VIA belongs to a node) - get rid of unique_ptr on the internal NODE::Add API (and also made it private) - make sure stack pointers are not added to the node - use rvalue reference for NODE::Add/NODE::Replace Manually rebased by Jeff Young <jeff@rokeby.ie> 5 April 2023	2023-04-11 15:51:00 +01:00
Tomasz Wlostowski	bfbda978b8	router: hole as first class objects, wip Rebased by Jeff Young <jeff@rokeby.ie> 5 April 2023 (Also includes a bug-fix for highlighting collisions with edge-cut items.)	2023-04-11 15:51:00 +01:00
Jeff Young	507a25f150	Don't call BuildInitialTrace() for entry gateways. We're going to call it to connect the entry and target gateways anyway, so all we need are gateways at 22.5 degrees to setup entry at +/- 45 degrees from the current direction. Fixes https://gitlab.com/kicad/code/kicad/issues/14324 Fixes https://gitlab.com/kicad/code/kicad/issues/12459	2023-04-11 15:34:55 +01:00
Jeff Young	11995c1350	Improve readability.	2023-04-11 15:26:39 +01:00
Mike Williams	32eb1ef77e	Sch->PCB: propagate DNP from symbols to footprints attributes Also add a 3D viewer toggle.	2023-04-10 13:11:21 -04:00
Jeff Young	adc213a04d	Add Keep Upright to properties inspector. Fixes https://gitlab.com/kicad/code/kicad/issues/14421	2023-04-10 00:00:54 +01:00
Jeff Young	d040690f60	Ease acquisition of a target item. pickSingleItem() had a two-attempt algorithm, but the second attempt was never made because we'd check for no hits before throwing out the aAvoidItems. The second attempt would fail anyway because QueryHoverItems() ignored the aUseClearance flag when not idle, and didn't factor in the actual clearance.	2023-04-09 22:05:17 +00:00
Jeff Young	1d19672054	Handle more pad shapes when building diffpair gateways. Fixes https://gitlab.com/kicad/code/kicad/issues/1883	2023-04-09 22:05:17 +00:00
Jeff Young	374d3d52ef	Rollback wxChoice -> wxComboBox changes for now. wxComboBox still has serious issues on macOS. Fixes https://gitlab.com/kicad/code/kicad/issues/14399 Fixes https://gitlab.com/kicad/code/kicad/issues/14413	2023-04-09 23:00:33 +01:00
Jeff Young	e522e73e0e	Improve readability.	2023-04-08 15:06:49 +01:00
Jeff Young	3b63d70d01	Centralize NPTH has-annulus processing. Fixes https://gitlab.com/kicad/code/kicad/issues/13437	2023-04-08 15:06:49 +01:00
Seth Hillbrand	2cd854af14	Move Spacemouse to advanced config The spacemouse driver, particularly on Mac, is extremely unstable and causes crashes even when not being used. This places the interface behind an advanced config flag to ensure that users can affirmatively opt-in to the potential for crashes	2023-04-07 10:08:43 -07:00
jean-pierre charras	ca0e57f036	Plot gerber: fix two issues: - ensure the metadata GBR_NETINFO_CMP is added to all PCB_SHAPE living in a footprint - fix a too zealous plot of negative objects on the silkscreen layers, when merging layers to silkscreen layers.	2023-04-07 11:23:24 +02:00
Ian McInerney	18ea3be3f2	Revert "Reintroduce constexpr to COLOR4D" This reverts commit `33da9b2327` and the following commit `dc08c48f33`. C++17 changed the behavior of static class member variables that are constexpr defined. Previously this definition/declaration split was valid for constexpr members, but after C++17 the static constexpr member variables are automatically inlined, so the declaration is no longer exported in some compilers (GCC 9/10/11 seem to have problems). An alternate way of constexpr member variables is putting the initialization in the class definition, but we can't init a COLOR4D object when defining the COLOR4D class. For now, revert this change until we can figure out the proper way of architecting these colors.	2023-04-06 20:18:31 +01:00
Ian McInerney	dc08c48f33	Try to fix linking after constexpr change Somehow, GCC 10 and 11 were unable to locate the prebuild colors when they were constexpr in gal, so give them on the link line again.	2023-04-06 15:20:16 +01:00
Ian McInerney	311d5d5e26	Remove unused container header	2023-04-06 15:01:18 +01:00
Ian McInerney	ea62b145ff	Introduce core interface library This library is meant to move non-EDA items (language extensions, library extensions, etc.) into the lowest-level of our dependency chain. This library should never depend on anyother non-thirdparty code in the kicad codebase.	2023-04-06 15:01:18 +01:00
jean-pierre charras	4d05bd62da	drc_test_provider_library_parity: fix false positive. After last changes in PCB_SHAPES, there were issues when comparing coordinates of shapes. Use now a footprint not flipped, not rotated and at position 0,0 for comparisons. Fixes #14496 https://gitlab.com/kicad/code/kicad/issues/14496	2023-04-05 18:25:19 +02:00
Tomasz Wlostowski	1283c4713f	router: rework ITEM ownership model. - prerequisite for holes as first class objects code - introduced the OWNABLE_ITEM interface that defines the owning container (NODE/other ITEM/ITEM_SET) - simplified the ITEM_SET interface - constified a lot of APIs (ownership/JOINT management) as a side effect Rebased and cleaned up by Jeff Young <jeff@rokeby.ie> 5 April 2023 - some STL cover types removed	2023-04-05 11:21:31 +01:00
Tomasz Wlostowski	eed05191a9	router: pass collision query options in a structure Selectively cherry-picked by Jeff Young <jeff@rokeby.ie> 4 April 2023 - Jon's user-clearance-epsilon algo kept intact - Jeff's castellated-pad code kept intact	2023-04-05 11:21:31 +01:00
Jeff Young	a9b2234f4e	Use a softer Reset for grid settings. Fixes https://gitlab.com/kicad/code/kicad/issues/14458	2023-04-04 17:05:21 +01:00
Jeff Young	13e79af8a0	Eagle template footprints don't actually belong to board. Set their parent to nullptr before deleting (as the board may have already been deleted). Likely fix for Sentry KICAD-79.	2023-04-04 14:18:49 +01:00
Jeff Young	bd60f38569	Possible protection from acessing deleted window data. (Long shot for Sentry KICAD-MM.)	2023-04-03 23:44:40 +01:00
Jeff Young	a4e8fa96d4	Nullptr safety. (This is a long shot for Sentry KICAD-MV, but you never know....)	2023-04-03 23:44:40 +01:00
Jeff Young	9b4627e782	Don't pass a FRAME-based UNITS_PROVIDER to a modeless dialog. (The dialog may outlive said frame.) Should fix Sentry KICAD-3A.	2023-04-03 17:18:33 +01:00
Jeff Young	7a24672120	Improve naming. No functional changes.	2023-04-03 14:32:23 +01:00
Jeff Young	d9b0577ddd	Fix pad flipping.	2023-04-03 14:32:23 +01:00
Jeff Young	7286555529	Fix some issues editing pads via Pad Properties dialog. The offsets and orientations were being incorrectly handled.	2023-04-03 13:17:52 +01:00
Jeff Young	fd07f50c44	Report collisions of items with nets as SHORTING, not CLEARANCE. Fixes https://gitlab.com/kicad/code/kicad/issues/14312	2023-04-02 21:07:52 +01:00
Jeff Young	77639a540b	Add messages for clearance reports on footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/13874	2023-04-02 19:12:19 +01:00
Jeff Young	28028c941e	Retire Local/Draw coords distinction from PAD (the last object to have it).	2023-04-02 18:02:41 +01:00
Jeff Young	7252c7471c	Use enums for column ids. (The nickname, in particular, is no longer column 1.) Fixes https://gitlab.com/kicad/code/kicad/issues/14291	2023-04-02 15:10:06 +01:00
Jeff Young	b78e0a55b1	Naming conventions. (No functional changes.)	2023-04-02 11:48:23 +01:00
jean-pierre charras	054de5687c	Pcbnew: fix crash when trying to delete a PCB_TEXT.	2023-04-02 12:15:18 +02:00
jean-pierre charras	31354a2d91	PCB_TEXT::TransformTextToPolySet(): fix some issues: - incorrect rotation for texts with option "Keep Upright" - missing code for knockout texts. Fixes #14473 https://gitlab.com/kicad/code/kicad/issues/14473	2023-04-02 09:54:53 +02:00
jean-pierre charras	52315e4f02	specctra_export: fix unit conv PCB iu -> DSN	2023-04-01 17:28:50 +02:00
Jeff Young	bf9a42d7e1	Naming conventions and nullptr usage. No functional changes.	2023-04-01 15:41:59 +01:00
Jeff Young	4fbb85aa4f	Naming conventions.	2023-04-01 15:40:50 +01:00
Jeff Young	a8faa0e615	Add hole clearance to moutning hole keepouts for SPECCTRA. Fixes https://gitlab.com/kicad/code/kicad/issues/14439	2023-04-01 15:40:43 +01:00
Jeff Young	04cdca837e	Remove GUI dialogs from PCB plugin.	2023-04-01 11:37:34 +01:00
Jeff Young	b80a9014ff	Fix gcc warning.	2023-03-31 23:53:11 +01:00
Jeff Young	bbd6c80507	Collapse FP_* down into their PCB_* equivalents.	2023-03-31 22:57:46 +01:00
Seth Hillbrand	7695d510d6	Prevent PCB Editor from opening multiple board_setup ShowBoardSetup can be called multiple times from multiple locations, resulting in duplicate board setup dialog boxes. This is confusing and should be prevented. We use the established patter from the symbol picker to ensure that only one copy of the dialog is ever opened at a time	2023-03-30 15:34:23 -07:00
jean-pierre charras	061e423b1f	Pcbnew: fix incorrect position of cached text shapes when moving a footprint. when moving a footprint, the position of texts living in FP_TEXT_BOX was not updated when the text shape was cached (non Kicad fonts). Fixes #14452 https://gitlab.com/kicad/code/kicad/issues/14452	2023-03-30 17:25:25 +02:00
Roberto Fernandez Bautista	d5bc223ff2	CADSTAR PCB Importer: Ignore construction layers on outer surfaces Fixes https://gitlab.com/kicad/code/kicad/-/issues/14443	2023-03-29 23:46:22 +02:00
Roberto Fernandez Bautista	aaeb8ca739	CADSTAR PCB importer: Fix loading of rounded rectangle pads Fixes https://gitlab.com/kicad/code/kicad/-/issues/14445	2023-03-29 20:53:14 +02:00
Roberto Fernandez Bautista	89441d807d	CADSTAR PCB importer: Fix incorrect position of overridden pads	2023-03-29 20:53:14 +02:00
Wayne Stambaugh	28776f5745	Text attributes object improvements. * Add compare method to COLOR4D object. * Add unit test to validate COLOR4D comparison method. * Add missing color test in text attribute comparison method. * Add unit test for text attribute object. * Remove unnecessary headers from text attribute header. * Move text attribute code into separate source file.	2023-03-29 12:53:45 -04:00
jean-pierre charras	683a327200	Footprint editor: always export the currently loaded footprint. Previously, it was not always the edited footprint, but a footprint selected from the library tree. It was especially annoying when the footprint was loaded from the board editor: The footprint was not the loaded footprint, but its copy from library.	2023-03-29 18:47:39 +02:00
jean-pierre charras	0bd83d3096	Footprint viewer: ensure the footprint is updated after new library selection Previously, if the first fp of the new lib has the same name as the old displayed fp, the old fp was not replace by the new fp.	2023-03-29 16:53:49 +02:00
Seth Hillbrand	f93fde15b7	Locked shadow needs to be in shadow color Otherwise, text shadow is stroked by text color	2023-03-28 13:01:08 -07:00
Jeff Young	0f9a4ef7b7	Update local coords after changing footprint item properties. Fixes https://gitlab.com/kicad/code/kicad/issues/14348	2023-03-27 16:44:00 +01:00
Jon Evans	3f42e6b702	Properties: Hide Net Class from GUI It is confusing users who want to change the netclass of a net.	2023-03-26 19:46:00 -04:00
Jon Evans	65193487a6	Properties: Rename methods to better reflect their purposes	2023-03-26 19:43:16 -04:00
Jeff Young	a214ac0310	Better reporting of copper <--> keepout area clearances. (Keepout areas can keep-out copper, but they don't have a clearance to copper.) Fixes https://gitlab.com/kicad/code/kicad/issues/14375	2023-03-26 20:57:59 +01:00
Jeff Young	9976b9ce8c	Only report on clearances where there was one defined. If it's 0, it's just a straight-up collision.	2023-03-26 20:46:59 +01:00
Jeff Young	0266d03f79	Run SILK_CLEARANCE rules on mask layer when testing silk-to-mask clearance. This allows custom rules to be authored without firing the auto-generated rule from Board Setup > Silk Item Clearance (which should be only for silk- to-silk clearances). Fixes https://gitlab.com/kicad/code/kicad/issues/14417	2023-03-26 20:42:41 +01:00
Jeff Young	2443bc6e29	Update allow-solder-mask-bridges when updating footprint from library. Fixes https://gitlab.com/kicad/code/kicad/issues/14422	2023-03-26 16:27:09 +01:00
Jeff Young	04f6f04bed	Test silk/mask collisions on the correct layer. Fixes https://gitlab.com/kicad/code/kicad/issues/14417	2023-03-26 16:27:05 +01:00
Marek Roszko	604a7d69db	Move up a layer validity check to prevent crash Fixes sentry crash KICAD-RF	2023-03-25 17:12:22 -04:00
Jeff Young	c5e66361db	Allow solder mask bridges between net-tie-group pads. Fixes https://gitlab.com/kicad/code/kicad/issues/14412	2023-03-25 16:11:07 +00:00
Jeff Young	d6dd58fff9	Keep track of single-pad-islands so we can discount spokes to them.	2023-03-25 10:44:46 +00:00
Marek Roszko	eb90448247	Fix typo	2023-03-24 19:54:41 -04:00
Marek Roszko	8a8589b9db	Fix cli crash due to dialogs buried in the pcb parser... Fixes sentry KICAD-Q2	2023-03-24 19:52:48 -04:00
Seth Hillbrand	19d0aceda3	Remove superfluous m_status variable This used to be used to store information for the item similar to m_state but it has been deprecated and no uses remained	2023-03-24 09:38:39 -07:00
Wayne Stambaugh	244c37298f	Fix Doxygen commenting issues.	2023-03-24 11:57:52 -04:00
jean-pierre charras	2e2cbb0594	Pcbnew, APPEARANCE_CONTROLS: do not change objects visibility, when changing layers visibility using Preset layers widget. Fixes #13381 https://gitlab.com/kicad/code/kicad/issues/13381	2023-03-24 14:07:29 +01:00
Nimish Telang	8ea357f04d	Fix Doxygen directives in numerous headers	2023-03-24 13:02:13 +00:00
Nimish Telang	f7bf3011fb	Use bundled Find{CURL,ZLIB}.cmake	2023-03-24 12:54:52 +00:00
qu1ck	a86aa6fc3e	Don't disable reload button in action plugins preferences	2023-03-24 12:49:43 +00:00
jean-pierre charras	ac71227e75	Fix compil warnings.	2023-03-23 18:36:59 +01:00
Marek Roszko	d49562a7aa	Fix crash editing footprint editor defaults Missing one level of GetParent()....use a dynamic_cast to sanity check it in debug Fixes sentry crash KICAD-R4	2023-03-22 18:39:17 -04:00
Seth Hillbrand	2e2da951a5	Don't double-expand NPTH checks When filling the zone for the NPTH, the hole should not be considered as a copper element in terms of clearance. This prevents close but different knockout elements from being formed	2023-03-22 15:07:58 -07:00
Seth Hillbrand	914b5a4d21	Simplify test for substantial nubs Substantial elements following a divot should be at least as far in each cardinal direction from the origin point in order to be considered substantial. This catches cases where the "substantial" element is actually a straight segment away from the divot Fixes https://gitlab.com/kicad/code/kicad/issues/14130	2023-03-22 13:01:50 -07:00
jean-pierre charras	65eb84265b	Fix a compil warning issue (mingw specific) also avoid to include wx/wx.h in kicad_cli.cpp, it is compil time consuming.	2023-03-22 08:49:26 +01:00
David Holdeman	79fbde0894	Add option to use drill/place file origin for kicad-cli gerber export	2023-03-21 12:18:14 +00:00
jean-pierre charras	0c26014eaa	step exporter: fix missing initialization of a member (m_pcbName) in EXPORTER_STEP rename m_pcbName to m_pcbBaseName, to avoid using the same name used also in STEP_PCB_MODEL.	2023-03-21 09:30:11 +01:00
Marek Roszko	edf6828cf1	Put the project name back into the step pcb label. Software like Solidworks and other CAD treat STEP labels as unique entries. When you import multi STEP files into the same project, it'll start deduplicating your design by those name. So two completely unrelated PCBs with the same "PCB" name will result in one being replaced by another.	2023-03-20 21:11:28 -04:00
Jeff Young	bb2a0f825a	Orthogonal dimension are always cardinal, even when their start points are not. Fixes https://gitlab.com/kicad/code/kicad/issues/13728	2023-03-20 21:22:11 +00:00
Martin Thierer	45b94a4b3e	Pcbnew: Fix rotating bitmaps Fixes rotating bitmaps with "rotate counterclockwise", "rotate clockwise" and "move exactly" commands. Only rotation by 0, 90, 180 and 270 degrees is supported for bitmaps. Other values are rounded to the nearest 90 degree multiple. There is a different bug that this commit doesn't address, which is that BITMAP_BASE::Rotate() got its CW/CCW logic reversed ("m_image->Rotate( false )" should rotate CW, but does not). Fixes https://gitlab.com/kicad/code/kicad/issues/14197	2023-03-20 12:36:19 +00:00
Jeff Young	5d55fc41ae	Adds Teardrops as separate type in Global Deletions dialog. Also removes the nag dialog as undo has worked for Global Deletions for some time now.	2023-03-19 20:43:18 +00:00
Jeff Young	897984aa22	Filter Selected Items... is inclusive, not exclusive. Fixes https://gitlab.com/kicad/code/kicad/issues/14273	2023-03-19 20:43:18 +00:00
Jeff Young	129ccb891e	Use standard paradigm for macro scope limiting.	2023-03-19 20:43:18 +00:00
Alex	10c4b948cb	Support canceling initial global library table setup.	2023-03-19 14:30:53 +03:00
jean-pierre charras	5461dc6cd1	BOARD_NETLIST_UPDATER: add missing count of warnings Fixes #14290 https://gitlab.com/kicad/code/kicad/issues/14290	2023-03-18 17:54:03 +01:00
Jeff Young	ad5d3d4eba	Clean up items which weren't pasted from clipboard. Fixes https://gitlab.com/kicad/code/kicad/issues/14335	2023-03-17 23:17:15 +00:00
Jeff Young	ee1d9c561c	Improve zone & rule area reporting. Also removes a bunch of "wxEmptyString" where it was degrading readability. Also fixes a bug where footprint zones were getting sorted incorrectly due to rotation of coordinates. Fixes https://gitlab.com/kicad/code/kicad/issues/14322	2023-03-17 13:28:29 +00:00
Jeff Young	967ee2c85b	Improved macro protection.	2023-03-17 11:04:58 +00:00
Roberto Fernandez Bautista	55a379f61b	Fix build: Add missing header include	2023-03-16 22:07:04 +01:00
Roberto Fernandez Bautista	3d661585dd	Fix build errors and warnings from CADSTAR	2023-03-16 21:17:40 +01:00
Roberto Fernandez Bautista	5efec4cd51	CADSTAR PCB: Ensure pads have correct position and footprints at 0,0 Fixes a display issue in the footprint preview where all the pads were displayed at 0,0	2023-03-16 21:07:09 +01:00
Roberto Fernandez Bautista	2cefabc99a	CADSTAR PCB: Fix loading of filled circles (load as polygon for now) todo: need to detect if what we are drawing is a circle.	2023-03-16 21:07:09 +01:00
Roberto Fernandez Bautista	6f5321c481	ADDED: CADSTAR .cpa footprint libraries	2023-03-16 21:07:08 +01:00
Roberto Fernandez Bautista	8f83f27336	CADSTAR SCH: Refactor loading of symbols out of loading part info	2023-03-16 21:07:06 +01:00
Roberto Fernandez Bautista	738b36cf7d	CADSTAR csa / cpa ignore Hierarchy This node doesn't have any equivalent in KiCad so for now we ignore it. In future, we could parse it in detail, to obtain the tree-structure of symbols/footprints in a cadstar library	2023-03-16 21:07:06 +01:00
Alex	8fe78101db	Don't create 0-length tracks when placing via in the middle of a track.	2023-03-16 04:53:26 +03:00
jean-pierre charras	893a362d9e	Minor Coverity and compil warnings fix.	2023-03-15 20:09:04 +01:00
Jeff Young	e60837ec95	Defenses in depth for ratsnest drawing.	2023-03-14 11:53:16 +00:00
Jeff Young	37b0a5a504	Add quick DRC action for Diff Footprints. Also makes the strings match the GUI better so people will know where to find them later. And fixes a couple of ERC items that referred to Board Setup (oops).	2023-03-14 11:52:23 +00:00
Seth Hillbrand	283770fc45	Check for dirtied items in the cluster When drawing the ratsnest, we need to be careful to avoid accessing CONN_ITEMs that have been changed by the underlying model. Checking for dirty items instead of valid items will prevent us looking at data that are out of date Fixes https://gitlab.com/kicad/code/kicad/issues/14265	2023-03-13 16:10:39 -07:00
Jeff Young	725834b554	Don't use ViewBBox for zoom-to-fit. The ViewBBox can include the largest document clearance so that pad clearance lines get included. But the largest clearance can be, well, large. Fixes https://gitlab.com/kicad/code/kicad/issues/14276	2023-03-13 22:45:37 +00:00
Jeff Young	a0adb59437	Update dimension units when opening PCBs in CLI. Fixes https://gitlab.com/kicad/code/kicad/issues/14170	2023-03-13 20:26:11 +00:00
Seth Hillbrand	f0892598a4	Force initialization of board units Unitialized variables are the devil's playground	2023-03-13 11:38:17 -07:00
Jeff Young	b7a3b0967b	Commenting. No functional changes.	2023-03-13 18:29:55 +00:00
Jeff Young	0fb1ccff21	Commenting and formatting. No functional changes.	2023-03-13 18:29:55 +00:00
Wayne Stambaugh	664e5629f2	Document board change event listener code.	2023-03-13 13:59:01 -04:00
Wayne Stambaugh	66f6168163	Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.	2023-03-13 12:04:01 -04:00
Jeff Young	dc78797274	Support SHEET_PATH when printing. Fixes https://gitlab.com/kicad/code/kicad/issues/14233	2023-03-12 22:24:06 +00:00
Jeff Young	5427100539	Handle plotting of text on solder mask layer. Admittedly this is an odd thing to do, but we should still be internally consistent, and it has come up in customers' files. Fixes https://gitlab.com/kicad/code/kicad/issues/14226	2023-03-12 21:21:15 +00:00
Jeff Young	c4ef08bead	Exercise more caution with user filenames. In particular, don't assume "1" is an extension in "Schematic_1.1". Fixes https://gitlab.com/kicad/code/kicad/issues/14263	2023-03-12 15:52:45 +00:00
jean-pierre charras	e6945a85b0	fix compil and Coverity warnings.	2023-03-12 15:19:50 +01:00
Jon Evans	8eaa3cfac9	Do not try to process invalid ratsnest nodes Fixes https://gitlab.com/kicad/code/kicad/-/issues/14254	2023-03-11 16:12:10 -05:00
Jeff Young	74f064d3aa	Don't keep smart pointers to wxWindows, particularly modeless ones. wxWindows have their own lifecycle management.	2023-03-11 19:36:01 +00:00
jean-pierre charras	a264608368	drc_test_provider_library_parity.cpp: fix a typo that crashes Pcbnew.	2023-03-11 15:01:26 +01:00
Jeff Young	c9351dfd67	Drawing improvements for symbol & footprint diffs. Moves forced-transparency setting down into VIEW_ITEM so that it can be used to place forced-transparent objects in a different target. This keeps EnableDepthTest() from equalizing the alpha values between the two symbols (or two footprints).	2023-03-11 12:45:16 +00:00
Seth Hillbrand	d7a6875b0b	3dviewer: Show footprint board regardless of proj The settings for the project in terms of visibility should not impact our ability to preview the 3d model of a footprint Fixes https://gitlab.com/kicad/code/kicad/issues/14246	2023-03-10 15:18:45 -08:00
Jeff Young	9546a40662	Correct usage of elipses after menu items. (They should only be used when we collect more info before performing the command. If the command is something like showing the simulator, then there should be no elipsis as we don't collect more info before showing the window.) Also improves a few of the menu tooltips.	2023-03-10 21:33:06 +00:00
Mike Williams	b32ba16da4	UI: Add Numpad Enter as "Return" equivalent in missing places Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14244	2023-03-10 16:25:17 -05:00
Jeff Young	357427d803	Graphical diff for board vs library footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/13736	2023-03-10 17:16:40 +00:00
Ian McInerney	a6ebd60c3b	CMake: Modernize Boost import to use imported targets	2023-03-10 16:38:35 +00:00
jean-pierre charras	bb27717dda	DIALOG_BOARD_REANNOTATE: fix coding style issues.	2023-03-10 11:49:48 +01:00
jean-pierre charras	6fd79929be	DIALOG_BOARD_REANNOTATE: fix some issues, and protect against bad settings. Fixes #14234 https://gitlab.com/kicad/code/kicad/issues/14234	2023-03-10 10:46:55 +01:00
Jeff Young	6a46dbd306	Fix includes.	2023-03-09 23:49:01 +00:00
Seth Hillbrand	d2cc252fc7	Move via/track/grid selection widget to wxComboBox The wxComboBox drops nicely from the top of the screen, showing the full element list, opposed to the choice widget that centers the selection and places the list off the top of the screen if there are many elements. This was broke for MacOS until wx3.2 Fixes https://gitlab.com/kicad/code/kicad/issues/1866	2023-03-09 11:45:44 -08:00
Jeff Young	bc0d59801a	Graphical diff for schematic vs library symbols. Fixes https://gitlab.com/kicad/code/kicad/issues/13736	2023-03-09 18:04:52 +00:00
Jeff Young	2d6ab62da4	ADDED: schematic/library diff for symbols.	2023-03-09 18:04:52 +00:00
Seth Hillbrand	9146e38af4	Handle fully-nested zones The logic to handle divots needs to account for fully nested, same net zones. The process of subtracting led to us considering the inner zone to be a zone knock-out (negative polygon). To avoid this, we need to check if the inner, higher priority zone has any connection to the outer zone. If it does not, then we can treat it as an isolated zone without worrying about divots to the outer zone.	2023-03-08 10:36:53 -08:00
Mike Williams	74a9d79a8d	Router: fix Continue From End/ Attempt Finish work for diff pairs Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13772	2023-03-08 12:23:04 -05:00
Mike Williams	8d3e1eb52a	Continue From End: support other placement algos	2023-03-08 12:01:29 -05:00
Mike Williams	e7555aa45f	PNS Router: arcs are directional, too Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10391	2023-03-08 12:01:29 -05:00
Mike Williams	5bc018f7dc	PNS Diff Placer: fix invalid cast of Arc to Segment and derefence	2023-03-08 12:01:29 -05:00
jean-pierre charras	6343147bb3	Fix Coverity warnings.	2023-03-08 11:37:56 +01:00
Seth Hillbrand	6b4c366cb8	Cleanup DRC check for via layers Vias should only be placed on the layers through which they pass. if they pass through front or back copper, then they also pass through the tech layers on that side This is an update to `9d3f4bef6a`	2023-03-07 11:13:05 -08:00
jean-pierre charras	a20c5a765f	Specctra export: Fix typo	2023-03-07 15:08:23 +01:00
jean-pierre charras	5ccfc8e4ce	Add missing fix in commit `2c77888b`	2023-03-07 14:08:03 +01:00
jean-pierre charras	2c77888b49	DSN exporter: fix handling of multilayer copper zones, and broken zone layer id.	2023-03-07 14:01:32 +01:00
Jeff Young	33e7c78533	Edge connectors shouldn't trigger edge clearance violations. Fixes https://gitlab.com/kicad/code/kicad/issues/14199	2023-03-07 12:23:18 +00:00
jean-pierre charras	5735a57504	Pcbnew: fix crash when loading a library with a ft containing a dimension. (crash due to the use of a null pointer during loading)	2023-03-07 10:09:34 +01:00
jean-pierre charras	e7c3350482	fix compil warnings	2023-03-07 09:52:29 +01:00
Seth Hillbrand	7653a2bf99	Smarten connection width checker looking for splits Fractured polygons are always fractured along the x-axis, so when checking to see if a segment is a fracture point, we check if the y coordinate is equal. This avoids situations where there are multiple fracture points between two inflection points Additionally, we add a second check to ensure we don't hit spurious blobs (all kinks should be symmetric and therefore be substantial in each direction) Fixes https://gitlab.com/kicad/code/kicad/issues/14130	2023-03-06 16:14:34 -08:00
Jeff Young	25623552f6	ADDED: board/library inspection for footprint differences. Fixes https://gitlab.com/kicad/code/kicad/issues/13736	2023-03-06 23:08:59 +00:00
jean-pierre charras	636e63f0c5	more about step exporter (export more copper graphic objects).	2023-03-06 16:36:37 +01:00
Jeff Young	c54c254f96	Don't allow footprint editor pad tools to run outside footprint editor. (They can get called if a user re-assigns hotkeys to them.) Fixes https://gitlab.com/kicad/code/kicad/issues/14166	2023-03-06 14:43:57 +00:00
Jeff Young	9b9efb9002	Cache for netclass pattern assignments.	2023-03-06 13:56:04 +00:00
Wayne Stambaugh	a1fb8e1b1d	Coverity fixes and code cleaning.	2023-03-06 07:12:18 -05:00
jean-pierre charras	eeee3adb94	Step exporter: code cleaning and merge connected tracks in polygons	2023-03-06 11:59:09 +01:00
Jon Evans	61d30ee5bc	Use constraints to determine netclas width Fixes https://gitlab.com/kicad/code/kicad/-/issues/14190	2023-03-05 22:35:19 -05:00
qu1ck	88062c5fc3	Add vector3 to swig Fixes regression in 7.0 making fp 3d model offsets not accessible in python Fixes https://gitlab.com/kicad/code/kicad/-/issues/14179	2023-03-05 15:59:22 -08:00
Jon Evans	10d1ba59d8	Fix compile warning	2023-03-05 18:11:41 -05:00
Jeff Young	2994fa26cd	Allow separate processing of dimensions in Edit Text & Graphics Properties.	2023-03-05 15:19:06 +00:00
Jeff Young	461def2719	Move automatic dimension processing inside PCB_DIMENSION_BASE. Also move dimension precision to an enum so it can get a proper dropdown in the properties inspector.	2023-03-05 15:19:06 +00:00
jean-pierre charras	a3d834bef1	Step exporter: optimization: export round pad/via shapes as cylinders.	2023-03-05 14:54:16 +01:00
jean-pierre charras	f569cffa8e	Step exporter fixes and enhancements: - fix duplicate code and a few bugs (some are due to changes in code over the years) - ADDED: option to export tracks and vias on external layers Exporting tracks is very time consuming, and need a bit of optimization.	2023-03-05 12:55:15 +01:00
Jeff Young	23accffc6d	Add Property Inspector support for dimension objects. Includes changing the class hierarchy so that dimension objects inherit from PCB_TEXT rather than containing a PCB_TEXT member variable.	2023-03-04 23:16:46 +00:00
Jon Evans	610e787ada	Move to requiring explicit action to save project settings	2023-03-04 14:25:07 -05:00
Jon Evans	eba0783b38	Fix rotation/flipping properties for text boxes Fixes https://gitlab.com/kicad/code/kicad/-/issues/14159 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14164	2023-03-04 13:11:15 -05:00
Wayne Stambaugh	4e99812145	Coverity fixes and code cleaning.	2023-03-04 13:02:05 -05:00
Seth Hillbrand	f24deac017	Consider oblong holes with x/y equal size as drills An oblong hole with drillsizex = drillsizey is the same as a circular drill hit and should be converted to such in outputs (both excellon and DRC)	2023-03-03 00:42:44 +01:00
Seth Hillbrand	597ef81e53	Allow micro/buried via holes to be considered hole_to_hole clearance should account for all holes in the board. Previously, we had excluded non through holes from this test but that omits via holes that can still foul a future drill hit. Designers wanting the old behavior can explicitly set the hole_to_hole clearance to 0mm for specific ViaType pairs	2023-03-03 00:42:44 +01:00
Jeff Young	7638e23ff1	Add support for non-cardianlly-rotated text boxes. Also fixes a couple of bugs in text boxes in flipped footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/14112	2023-03-02 14:57:48 +00:00
Wayne Stambaugh	789bf6455a	Coverity fixes and code cleaning.	2023-03-02 09:04:47 -05:00
Seth Hillbrand	a0f99ea8ba	Allow for rounding error in connection width checker We perform checks using squared distance but this loses the integer rounding in the standard norm. To correct for this, we allow a single IU in the restriction, allowing fractionally smaller connection widths before calculating the squared limit Fixes https://gitlab.com/kicad/code/kicad/issues/14130 Fixes https://gitlab.com/kicad/code/kicad/issues/14131	2023-02-28 15:26:16 -08:00
Seth Hillbrand	daf70f9b6a	Export footprint pad holes to STEP regardless Footprint pad holes form a part of the board outline regardless of whether the footprint is in the BOM or not Fixes https://gitlab.com/kicad/code/kicad/issues/14013	2023-02-28 12:02:08 -08:00
Jeff Young	7bb2cdd658	Better error reporting for constraints (and a bug fix for no constraints). Fixes https://gitlab.com/kicad/code/kicad/issues/14070	2023-02-28 18:07:29 +00:00
Jeff Young	0ff8ba1d8c	Stage group children when staging group. Many operations such as move, rotate, etc. are applied directly to the group's children, so it's the children that need staging. Fixes https://gitlab.com/kicad/code/kicad/issues/13999	2023-02-28 16:51:23 +00:00
jean-pierre charras	7256a51e8e	Fixes in build board outlines as polygon and convert_shape_list_to_polygon: - Ensure Bezier curves have their polygon build before use it. - When building board outlines as polygon the same chaining epsilon value for DRC, export step and 3D view (default 0.01mm). Fixes #14115 https://gitlab.com/kicad/code/kicad/issues/14115 Fixes #14009 https://gitlab.com/kicad/code/kicad/issues/14009	2023-02-28 16:45:03 +01:00
Johannes Pfister	a87550a2c6	When importing legacy PCB dimension: Use automatic dimension when Unit couldn't be determined	2023-02-28 11:59:47 +00:00
Roberto Fernandez Bautista	bb8a3a7fdc	Add missing line from commit `b03366c9e8`	2023-02-28 00:12:50 +01:00
Roberto Fernandez Bautista	b03366c9e8	Fix CADSTAR importer memory leaks We were leaking the xml tree when throwing exceptions	2023-02-27 23:57:39 +01:00
jean-pierre charras	4766175d60	EXPORTER_STEP: handle sub-layers in dielectric layer. A dielectric layer (between 2 copper layers) can be made by more than one layer (composite dielectric). Not frequent, but possible. sub-layers where previously ignored.	2023-02-27 16:11:58 +01:00
jean-pierre charras	51d46c0e73	plotters rework: add plot fct to use TEXT_ATTRIBUTES class to pass text settings Old PLOTTER::Text is not (yet) removed, but it use negative text size to mirrored text, which is not really compatible with some plotters (especially PDF). Using TEXT_ATTRIBUTES is much easy and much better, so PLOTTER::PlotText() is added. Note: "old" PLOTTER::Text() is not removed yet.	2023-02-26 14:44:53 +01:00
qu1ck	733978dfd0	Fix swig mappings for PCB_BITMAP	2023-02-26 09:24:06 +00:00
jean-pierre charras	ece34e1a0c	Plot Gerber format: ensure all attributes are added to polygon items. Especially, TA.AperFunction,EtchedComponent for net tie footprints using polygons.	2023-02-25 19:06:46 +01:00
mitxela	734d3667a8	Helper function to allow net.GetNetClassName()	2023-02-25 13:14:55 +00:00
mitxela	182abd4652	Expose shared_ptr to swig Possibly not the right way to go about it but technically works	2023-02-25 13:14:55 +00:00
mitxela	716328e511	Fix python GetAllNetClasses	2023-02-25 13:14:55 +00:00
jean-pierre charras	bb62c21abc	python wizard: fix compatibility with current code	2023-02-25 11:06:01 +01:00
jean-pierre charras	d3c5f25be6	Pcbnew: optimize netname and num text size and position display on pad. Sizes where a bit too big. Fix also a difference between Cairo and OpenGL. Fixes #13872 https://gitlab.com/kicad/code/kicad/issues/13872	2023-02-25 11:05:21 +01:00
Jon Evans	8440d7258b	Do not invalidate board caches during DRC Footprints now modify their parent container when destroyed due to `26542796`, and a temporary footprint is created during DRC in some situations. This can lead to board caches being messed with during DRC which can cause unpredictable bad effects due to multithreading. Fixes https://gitlab.com/kicad/code/kicad/-/issues/13844	2023-02-24 22:55:32 -05:00
Jon Evans	b176881d49	Allow shorting copper zones through negative clearance This brings the zone filler in line with other places where we use negative clearance rules to disable constraints. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14069	2023-02-24 20:36:39 -05:00
Jeff Young	d9a77e6a64	Add DRCEpsilon to net-tie-exclusion testing. Fixes https://gitlab.com/kicad/code/kicad/issues/14008	2023-02-24 12:44:55 +00:00
jean-pierre charras	4fb104b238	Plot footprint texts: add code to plot Knockout texts. Fixes #14068 https://gitlab.com/kicad/code/kicad/issues/14068	2023-02-24 08:45:47 +01:00
Jon Evans	1651b44ab1	Fix some PCB_SHAPE properties Hide irrelevant position/start/end properties for shape classes that don't use them.	2023-02-23 20:23:44 -05:00
Seth Hillbrand	ffcc0e50b7	Handle excessively large values when hatching While unusual, ensure that hatched zones don't break KiCad if they are close to the integer limit Fixes https://gitlab.com/kicad/code/kicad/issues/14066	2023-02-23 14:40:57 -08:00
Seth Hillbrand	1b8b216ac8	Bitmaps are not actually copper We report bitmaps as being 'on' a copper layer because they are associated with it but they are not actually physical parts so should not be included in the DRC checks Additionally, Bitmaps effective shape starts are the top left corner rather than the center (unclear why that was there in the first place) Fixes https://gitlab.com/kicad/code/kicad/issues/14065	2023-02-23 14:16:28 -08:00
Alex	9d96edc44f	Print original netnames properly when reconnecting zones/vias. Using GetNetname() after SetNet() isn't a good idea to get the original name when updating PCB from Schematic.	2023-02-23 22:09:53 +03:00
Alex	f31e5ea783	pcbnew: Fix pads losing nets after Undo. Wasn't fixed in all places after being broken in `13f5c78e89`	2023-02-23 22:06:39 +03:00
qu1ck	f0dd32c3a7	Fix plugins in pcbnew breaking by opening fp editor	2023-02-23 14:20:03 +00:00
Marek Roszko	c2a4dd93e8	Fix typo in appearance_controls.cpp	2023-02-22 20:35:36 -05:00
Jon Evans	d8f4d04093	Disable auto-refill zones We need a more advanced dirtying system for this to work out for many users, it turns out. Right now too many changes cause full zone refills which interrupt workflow.	2023-02-22 20:13:55 -05:00
Seth Hillbrand	af10878954	Use Chamfer lines when deflating Rounded line ends when deflating leads to microscopic jags in the outline that are not visible but add substantial computation time and minor error when computing polygon offsets. Instead, the chamfer deflate method prevents these jagged lines by clipping angles < 90° by the error level. This does not impact deflate calls where we explicitly require the angles to be maintained	2023-02-22 16:24:26 -08:00
Seth Hillbrand	da61d31f44	Remove superfluous Simplify() call	2023-02-22 16:24:26 -08:00
aris-kimi	22bca5c2a0	Disable link maps by default and fix compile issue with lld linker The link maps were actually disabled by default before `912f1d5cec`, and required KICAD_MAKE_LINK_MAPS to be provided to enable them. So switch back to disabling them by default. Also, The lld linker is unable to accept a single dash cref option, while ld and gold can. Instead, use the double dash version that is supported by all three. xref: https://github.com/llvm/llvm-project/issues/60932 Co-authored-by: aris-kimi <aris_kimi@hotmail.com> Co-authored-by: Ian McInerney <ian.s.mcinerney@ieee.org>	2023-02-22 23:18:36 +00:00
Jon Evans	43d3a18b86	Improve HiDPI handling of appearance/layer controls	2023-02-22 09:20:36 -05:00
Jon Evans	89ef6b36f4	Fix layer widget in HiDPI situations	2023-02-22 09:20:30 -05:00
Ian McInerney	c6e417c19c	Fix missing override statements	2023-02-22 01:44:06 +00:00
Ian McInerney	912f1d5cec	Modernize setting link map linker flags	2023-02-22 01:44:06 +00:00
Ian McInerney	bcb93e9aa7	Modernize setting of compiler definitions in CMake add_compile_definitions was added in 3.12, and our minimum is now greater than that.	2023-02-22 01:44:06 +00:00
jean-pierre charras	e30e510354	gen drill map: fix duplicate suffix in map filenames if gbr drill fmt is selected Fixes #14026 https://gitlab.com/kicad/code/kicad/issues/14026	2023-02-21 14:22:50 +01:00
jean-pierre charras	db66419f02	Teardrops: fix incorrect shape in some cases.	2023-02-20 09:06:21 +01:00
jean-pierre charras	3a11d90d92	Teardrops: handle arcs in tracks. Fixes #13858 https://gitlab.com/kicad/code/kicad/issues/13858	2023-02-19 14:44:37 +01:00
Marek Roszko	30a49462fe	Fix crash parsing cadstar Fixes sentry KICAD-B2	2023-02-19 08:06:35 -05:00
Marek Roszko	aacc9746e3	Yeet the last of wxSize/wxPoint to stop leaking gdicmn everywhere	2023-02-18 22:57:18 -05:00
Mike Williams	bc8f81b14d	PCB Search Pane: show Board Setup / Net Classes on net activation	2023-02-18 15:41:26 -05:00
Marek Roszko	dffd2da8c8	Fix the shared_lock added and micro-opt the reindex	2023-02-18 11:28:19 -05:00
qu1ck	c7bb6f5778	Treat dimensions in fp as text for bbox calculations Fixes https://gitlab.com/kicad/code/kicad/-/issues/13976	2023-02-18 13:04:12 +00:00
Jon Evans	cad607ae84	Hide parent property in footprint editor	2023-02-17 20:40:09 -05:00
Jon Evans	f7d59f2e89	Enable properties panel in footprint editor	2023-02-17 20:35:56 -05:00
Jon Evans	f12f2b8420	PNS: Diff pairs can have different hole-to-hole size Fixes https://gitlab.com/kicad/code/kicad/-/issues/13993	2023-02-17 19:56:02 -05:00
Jon Evans	459473ccc3	PNS: Safety for evaluating item nets for rules Fixes https://gitlab.com/kicad/code/kicad/-/issues/13993	2023-02-17 19:56:02 -05:00
qu1ck	2975f53647	PCM: auto reload global libs after dialog is run This adds Reset() method to KIFACE to reload global libs stored in global static vars. Also refactors some lib reload code in various frames to have common MAIL_RELOAD_LIB handler. Fixes https://gitlab.com/kicad/code/kicad/-/issues/12500	2023-02-17 17:24:32 +00:00
Alex	ecb28ddf1c	Prevent ghost image after canceling bitmap placement.	2023-02-17 03:53:44 +03:00
Jeff Young	5b0f1376c0	Simplify code now that we no longer drop out on first rule fired.	2023-02-16 17:55:33 +00:00
Jeff Young	978c2b074e	Negative clearance means test will be ignored, not rule.	2023-02-16 17:39:47 +00:00
Jeff Young	407cdd63fb	Translatable strings.	2023-02-16 17:28:06 +00:00
jean-pierre charras	911e013850	Pcbnew: Do not change visibility objects when changing Visibility layers Fixes #13836 https://gitlab.com/kicad/code/kicad/issues/13836	2023-02-16 12:39:15 +01:00
qu1ck	9f10c142c4	Sync pcbnew selection with selected items after plugin is run	2023-02-16 02:29:06 +00:00
Seth Hillbrand	9d3f4bef6a	DRC: Verify overlapping layers in physical clearance When checking the physical clearance on a layer, it is critical to check that the via hole exists on that layer. Blind/buried and micro vias may not overlap, so should be excluded from this check when they don't exist on a particular layer Similarly, we should only be reporting a single physical clearance error for each item pair even though they may have multiple errors across multiple layers in the case of via-via clearance	2023-02-15 11:35:24 -08:00
jean-pierre charras	2032b8af59	Pcbnew: fix incorrect rotation of thermal spoke for rotated footprints. If the footprint rotation is not a multiple of 90°, the thermal spokes were not correctly rotated. Fixes #13919 https://gitlab.com/kicad/code/kicad/issues/13919	2023-02-15 18:19:34 +01:00
Jeff Young	40e1296a8b	Clear dirty flags after a move. Fixes https://gitlab.com/kicad/code/kicad/issues/11362	2023-02-15 14:50:31 +00:00
Jon Evans	2d7c5c5c0f	Router: Do not collide items within a net tie footprint Fixes https://gitlab.com/kicad/code/kicad/-/issues/13909	2023-02-14 21:08:36 -05:00
Jon Evans	473979d686	Fix handling of PPI when loading embedded images Fixes https://gitlab.com/kicad/code/kicad/-/issues/13884	2023-02-14 19:42:06 -05:00
Wayne Stambaugh	eb83f76bff	Allow plotting of multiple board layers per plot in Python. Since the always plot the edge cuts layer option was deprecate, the ability to plot multiple board layers was exposed through the PLOT_CONTROLLER object. Added the interactive plot information which was overlooked during version 7 development. Fixes https://gitlab.com/kicad/code/kicad/-/issues/13841	2023-02-14 09:49:20 -05:00
Mike Williams	4b07e3e413	Common Actions: Find Previous Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8968	2023-02-14 08:21:37 -05:00
Mike Williams	3e715c99c8	Swap: take S key now that it's available	2023-02-14 07:42:06 -05:00
Seth Hillbrand	e7fe69b97f	Better handling of vertex sorting Nominally, the zcode of a vertex is unique. This is not 100% true, however, as we must interlace two 32-bit numbers into a single 32-bit number. Sorting needs to account for the possibility that the zcode will be the same while other elements of the vertex are different. This commit fixes the broken boolean logic to more clearly handle these cases Fixes https://gitlab.com/kicad/code/kicad/issues/13867	2023-02-13 11:21:04 -08:00
Jeff Young	8bab429c7d	Account for border when calculating text margin for text boxes. Also fixes some unnoticed issues with the textbox dialogs (probably dating from the move to wxWidgets 3.2). Fixes https://gitlab.com/kicad/code/kicad/issues/13877	2023-02-13 17:08:29 +00:00
Mike Williams	71b687622b	PCB Search Pane: activate item opens properties dialog Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12475	2023-02-13 10:57:05 -05:00
jean-pierre charras	17059971e8	DIALOG_UNUSED_PAD_LAYERS: do not use TransferDataFromWindow for any button. TransferDataFromWindow is called only when closing by a wxID_OK button Fixes #13865 https://gitlab.com/kicad/code/kicad/issues/13865	2023-02-13 10:26:46 +01:00
Jeff Young	499b58f505	ADDED: user-specified gap and linewidth for bounding hull creation.	2023-02-12 23:16:45 +00:00
Marek Roszko	f409837d26	Fix a stray ternary hidden under #if	2023-02-12 16:46:34 -05:00
Jeff Young	837ba323fb	Add doc link to custom rules syntax help. Fixes https://gitlab.com/kicad/code/kicad/issues/13727	2023-02-12 21:34:35 +00:00
Marek Roszko	4665823089	Turn on and fix MSVC compliance mode issues We want /permissive- to enable debug performance improvements in MSVC 17.5+. This flag is also default under C++20 so we'll have to deal with these compile issues anyway at some point in the future. In particular, MSVC becomes pedantic about ternary types. See https://learn.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-170#ambiguous-conditional-operator-arguments MSFT cites https://cplusplus.github.io/CWG/issues/1805.html	2023-02-12 16:30:37 -05:00
Jeff Young	2a5bb71fbd	ADDED operating point text variables for labels and symbols. ADDED formatting for cursors and operationg points Also fixes a bunch of bugs to make the new cursors work with .ac sims. Fixes https://gitlab.com/kicad/code/kicad/issues/11253 Fixes https://gitlab.com/kicad/code/kicad/issues/6965	2023-02-11 21:11:07 +00:00
Jeff Young	e73366db5c	Add 3D viewer to toolbar. Fixes https://gitlab.com/kicad/code/kicad/issues/13559	2023-02-11 21:11:07 +00:00
Jeff Young	aab237852b	Flatten Reannotation dialog.	2023-02-11 21:11:07 +00:00
Jeff Young	0dcc34ddc8	Simplify Remove Unused Pads dialog.	2023-02-11 21:11:07 +00:00
Jeff Young	362d85ef50	Special selection mode when in high-contrast with courtyard layer active. Fixes https://gitlab.com/kicad/code/kicad/issues/13521	2023-02-11 21:11:07 +00:00
Jeff Young	95fb3825bd	Fix some strings from V7's string freeze.	2023-02-11 21:11:07 +00:00
Jon Evans	61dd4b7043	Properties: fix rebuilding when availability changes	2023-02-11 15:50:51 -05:00
Jon Evans	0b3928d38f	Properties: add some validators for PAD	2023-02-11 15:50:51 -05:00
Jeff Young	13391176ae	Remove DRC exclusions that no longer have items. Fixes https://gitlab.com/kicad/code/kicad/issues/13802	2023-02-11 20:43:00 +00:00
Marek Roszko	4d6e06d349	Add grid reset to place menubar.	2023-02-11 13:20:35 -05:00
Jon Evans	eb240fda9a	Properties: introduce validators; re-enable zone hatch settings	2023-02-11 11:44:58 -05:00
Jon Evans	254168c788	Properties: introduce method chaining for initialization	2023-02-11 11:44:58 -05:00
Jon Evans	6948a0bebd	Expose new netclass storage to SWIG Fixes https://gitlab.com/kicad/code/kicad/-/issues/13337	2023-02-11 09:50:24 -05:00
Alex	b5191c8c22	Fail-safety in spreadRectangles.	2023-02-11 16:42:27 +03:00
Jon Evans	b888714ed5	Don't discard temporary item being placed if placement is rejected Fixes https://gitlab.com/kicad/code/kicad/-/issues/13697	2023-02-11 08:40:33 -05:00
Jon Evans	e066454c61	Zones: use metric defaults and limits instead of mixed units Update testcases to reflect new defaults	2023-02-11 07:39:29 -05:00
Seth Hillbrand	fda3feaf3f	Revert "Add doc link to custom rules syntax help." This reverts commit `7874735810`.	2023-02-10 15:33:03 -08:00
Seth Hillbrand	90a388571e	Fix copy-pasta testing 'othervia' for dynamic_cast success needs to use `othervia` rather than `via` which might still be null Fixes Sentry issue KICAD-5K	2023-02-10 13:33:21 -08:00
Seth Hillbrand	6fb9d190ac	Use the common subset of nets for local update When adding new data, we may have differing sizes of the dynamic ratsnest and our local copy, so ensure that we are only referencing elements that exist in both	2023-02-10 12:50:29 -08:00
Alex	89429996da	Fix a crash in rectpack2D when unable to pack footprints.	2023-02-10 22:45:07 +03:00
Seth Hillbrand	f4825cdd8f	Allow same-net, same-priority zone filling When two zones with the same net and same priority overlap, they should both be filled, matching the behavior of v6. If you would like an explicit override of one or the other, you need to set the zone priority higher. Relying on the UUID as a tie breaker is good for zones with different nets but creates unexpected changes from v6 when applying it to zones of the same net	2023-02-10 11:07:08 -08:00
Jon Evans	e2353a2849	PANEL_BOARD_STACKUP: Ensure UI is re-linked to storage when importing Fixes https://gitlab.com/kicad/code/kicad/-/issues/13835	2023-02-10 12:58:04 -05:00
jean-pierre charras	538ee12188	Pcb editor: fix crash when trying to activate the "place anchor" tool. "place anchor" tool exists only in the Fp editor. However, the hotkey to activate this tool was also active in the board editor. Now disabled.	2023-02-09 16:29:33 +01:00
Jon Evans	92a61b187f	Properties: Hide zone fill type settings for now Fixes https://gitlab.com/kicad/code/kicad/-/issues/13811	2023-02-08 21:56:15 -05:00
Alex	b71fa91bc4	Don't write outside of overrides array on pad zone_layer_connections. Use std::array to catch future errors in Debug. Fixes https://gitlab.com/kicad/code/kicad/issues/13803	2023-02-08 01:32:52 +03:00
jean-pierre charras	a493a2c822	kicad-cli, pcbnew pàlot: honor the color options when ploting pdf files --black-and-white and -t were shown in help, but not handled Fixes #13805 https://gitlab.com/kicad/code/kicad/issues/13805	2023-02-07 20:20:45 +01:00
jean-pierre charras	82d9176782	FOOTPRINT::Flip(): add missing PCB_BITMAP_T. Fixes #13785 https://gitlab.com/kicad/code/kicad/issues/13785	2023-02-05 18:41:58 +01:00
Jeff Young	f2f54fe926	Improve zone-layer-connections terminology and comments. This makes it clearer that the overrides are not inverses of each other -- one overrides the flashing state and the other overrides the connection state (to other zones, not to everything). Also fixes a bug where we were failing to check the force-no-connect for pads.	2023-02-05 17:39:42 +00:00
Alex	c122fd0e36	Remove unused cache_optionally_flashed_connections.	2023-02-05 17:39:42 +00:00
Alex	f6fd85af85	CHANGED: Try to determine via/pad flashing state before filling zones. If removing unused via annular ring option is enabled on a layer, then the via will have the ring if both: - Via center is not inside a rule area with "Keep out copper fill" flag set - Highest-priority zone the via hole intersects with has the same net Pads will be flashed if: - Pad center is not inside a rule area with "Keep out copper fill" flag set - Highest-priority zone at the pad center has the same net Fixes https://gitlab.com/kicad/code/kicad/issues/12964	2023-02-05 17:39:42 +00:00
Alex	bf1a8f2582	router: Fix clamp in meander corner radius calculation. Fixes https://gitlab.com/kicad/code/kicad/issues/13781	2023-02-05 07:22:38 +03:00
Jeff Young	a59c1afa53	Fix two bugs in RTree polygon collions special case. 1) Special case doesn't work for polygons with holes 2) Fix special case to handle intersecting lines where neither end is in the polygon. Note that only (1) is required for the bug below. (2) was just discovered while implementing (1). Fixes https://gitlab.com/kicad/code/kicad/issues/13779	2023-02-04 13:46:40 +00:00
jean-pierre charras	6b5eeeb861	Preferences dialog: try to reduce its width, in non English languages. Remove some useless spacers, and do not force some widgets to have a to large size (by removing empty areas). Work in progress: one panel is still too big.	2023-02-04 14:36:14 +01:00
Seth Hillbrand	887c740c2e	Limit the number of potential netnames Don't set text if outside of the clipbox. Text is non-cached so will get redrawn on zoom Fixes https://gitlab.com/kicad/code/kicad/issues/13572	2023-02-04 11:17:09 +01:00
Jeff Young	8ecf64b6c5	Don't run DRC rules on non-existant layers. Fixes https://gitlab.com/kicad/code/kicad/issues/13753	2023-02-03 15:08:31 +00:00
Jeff Young	235925d62c	Clearer reporting of negative clearances.	2023-02-03 15:08:31 +00:00
Jeff Young	0d083d0230	AllCuMask() and AllTechMask() are static, they do NOT modify "this".	2023-02-03 15:08:31 +00:00
Seth Hillbrand	b427ad80f6	Don't make unneeded copies of std::pairs	2023-02-03 15:28:53 +01:00
Seth Hillbrand	dde336ee40	Split connectivity mutex locking Internal routines have no need for locking the mutex they already own. While external routines that want to recalculate the Ratsnest do need an exclusive lock before being allowed access Fixes https://gitlab.com/kicad/code/kicad/issues/13011	2023-02-03 15:26:19 +01:00
jean-pierre charras	8ce0a84ca7	Fix compatibility with older wxWidgets versions. Fix also a compil warning	2023-02-03 08:24:38 +01:00
Wayne Stambaugh	e20c86ad5e	Minor dialog layout improvements.	2023-02-02 16:54:52 -05:00
Seth Hillbrand	e60152e351	Fix island removal when copper->edge clearance is 0 Just testing a single point to find copper that is outside the board works until the arc->segment conversion moves the board outline just enough to have the filled copper slightly (few IU) outside of the converted outline. Instead, we do an expensive check of comparing the size of the intersection between the island and the island's intersection with the board. If the intersection is at least half as large as the original island, we can say with certainty that the island is inside. The margin could be much smaller than half but this preserves the intent without picking an arbitrary number that might be violated Fixes https://gitlab.com/kicad/code/kicad/issues/13717	2023-02-02 19:19:26 +00:00
jean-pierre charras	fcefb5f86d	Re-allows selection of bitmaps not owned by a footprint. It was broken by my commit `f8051d95` Fixes #13747 https://gitlab.com/kicad/code/kicad/issues/13747	2023-02-02 18:09:37 +01:00
Jon Evans	200bf696af	Fix importing of legacy netclasses Fixes https://gitlab.com/kicad/code/kicad/-/issues/13746	2023-02-02 08:29:43 -05:00
jean-pierre charras	737318a24d	struct ZONE_DESC: ensure ENUM_MAP<PCB_LAYER_ID> is initialized before use it. ENUM_MAP<PCB_LAYER_ID> is tested initialized in some other XXX_DESC, but not in ZONE_DESC Fixes #13699 https://gitlab.com/kicad/code/kicad/issues/13699	2023-02-02 09:11:27 +01:00
Jon Evans	26b9d2f5ac	DRC: Allow disabling DP constraints in specific areas Fixes https://gitlab.com/kicad/code/kicad/-/issues/13743	2023-02-01 23:11:39 -05:00
Jeff Young	7874735810	Add doc link to custom rules syntax help. Fixes https://gitlab.com/kicad/code/kicad/issues/13727	2023-02-01 23:40:53 +00:00
Alex	6543d23d9f	router: Re-add electrical path lines drawing for length tuning.	2023-02-01 20:36:52 +03:00
Alex	7d6218acb4	Unify checkbox borders in Interactive Router Settings.	2023-02-01 07:46:42 +03:00
Alex	1c2345776e	Remove unused variable.	2023-02-01 07:28:55 +03:00
Jon Evans	48e4005111	Fix diff pair router checking of min clearance Fixes https://gitlab.com/kicad/code/kicad/-/issues/13720	2023-01-31 19:53:35 -05:00
Kliment	68eac74458	pcbnew: Fix strokeWidth truncation to integer mm in SVG polygons import The polygon conversion algorithm mistakenly stored the stroke width of filled polygons in an integer variable. As a result, all stroke widths were rounded down to the next smaller integer mm size. This commit changes the types in the relevant functions and variables from int to double.	2023-01-31 20:34:25 +00:00
Seth Hillbrand	f34aa947d3	Allow on-outline zones to be considered inside Also ensure that calculated areas for island removal are absolute. The on-outline zone can happen when the clearance to the edge is particularly small. Fixes https://gitlab.com/kicad/code/kicad/issues/13717	2023-01-31 12:32:23 -08:00
jean-pierre charras	f8051d954a	Better handling of PCB_BITMAP items in a footprint. - Ensure they can be erased in the FP editor - Ensure they cannot be selected in the PCB editor (they are not show) Fixes #13714 https://gitlab.com/kicad/code/kicad/issues/	2023-01-31 11:16:38 +01:00
Roberto Fernandez Bautista	44cfb1ea43	CADSTAR PCB: Don't create zero sized text items Partially addresses https://gitlab.com/kicad/code/kicad/-/issues/13693	2023-01-30 19:56:22 +00:00
Roberto Fernandez Bautista	963e82ee7f	CADSTAR PCB: Correctly handle anticlockwise arcs Also add some qa tests for EDA_SHAPE::SetAngleAndEnd Fixes https://gitlab.com/kicad/code/kicad/-/issues/13626	2023-01-30 19:56:22 +00:00
Jeff Young	50e9685490	Check for tented vias before expanding solder mask. Fixes https://gitlab.com/kicad/code/kicad/issues/13705	2023-01-30 17:56:35 +00:00
Chris Morgan	ce06171561	Convert additional sprintf to snprintf	2023-01-30 16:22:03 +00:00
Marek Roszko	e928d72c3b	Fix relative step file export Forgot to set the project relative path, and the library search path Fixes https://gitlab.com/kicad/code/kicad/-/issues/13696	2023-01-29 22:19:37 -05:00
vinsfortunato	5bdaf20af6	eagle: determine and use the minimum copper layer stackup count Fixes: https://gitlab.com/kicad/code/kicad/issues/13484	2023-01-29 21:13:41 +00:00
Jon Evans	971abcfc1a	Fix DP meander placer when tuning from an uncoupled section Fixes https://gitlab.com/kicad/code/kicad/-/issues/12212	2023-01-28 22:25:46 -05:00
Wayne Stambaugh	68decdd4f2	Fix static event table derived object definitions.	2023-01-28 14:10:06 -05:00
Marek Roszko	d4a5e2caad	Fix crash when .kicad_pcb is renamed to .kicad_mod and load library attempted Pick a random error message used elsewhere	2023-01-28 10:42:46 -05:00
Jon Evans	d04cda35c5	Handle hidden attribute in fp-lib-table Fixes https://gitlab.com/kicad/code/kicad/-/issues/13689	2023-01-28 09:23:25 -05:00
Jeff Young	b1018e8eeb	Relax no-zone-commands constraint on interactive placer tools. These tools are initialized with an item (via/pad/microwave) so there's no way to tell between during-placement and idle. Besides, they don't update the ratsnest so they probably won't fall afoul of the original bug (https://gitlab.com/kicad/code/kicad/-/issues/12736). Fixes https://gitlab.com/kicad/code/kicad/issues/13686	2023-01-28 10:42:24 +00:00
Marek Roszko	4d811ba975	Enable layer arg for fp export svg	2023-01-27 23:45:42 -05:00
Jon Evans	b4994a7fa1	Locked shadows should not be on overlay These are supposed to render under the component and do not need to be pulled to the front for overlay. Fixes https://gitlab.com/kicad/code/kicad/-/issues/12486	2023-01-27 22:09:42 -05:00
Ian McInerney	51c8f2c119	Fix library sort order in library viewers The lib table returns a properly sorted list of libraries already, which we just iterate through. A std::set is a sorted collection, but uses a different sorting function than the lib table, so appending to a std::set breaks the initial sorting that was done already. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13530	2023-01-27 23:39:50 +00:00
Kliment	f6dc48ead7	Pcbnew: Make "Substitute similarly named models" on by default in STEP export.	2023-01-27 23:32:23 +00:00
kliment	a3e3231605	Pcbnew: Increase the default size of the board setup dialog	2023-01-27 22:00:39 +00:00
Alex	8603c06ef3	Fix netnames.	2023-01-27 19:35:41 +03:00
Alex	13ce2ebf46	15% rendering optimization in PCB_TRACK::ViewGetLOD.	2023-01-27 18:37:43 +03:00
Jeff Young	8268234aa1	Reverse shown-source logic so we report if it's the netclass width. (whether or not it's also the previous track width).	2023-01-27 15:31:02 +00:00
Jon Evans	675b6b5d5c	Fix logic error in `ec4d377d` Also fixup goldens for importers for new default island mode	2023-01-27 10:16:56 -05:00
Jon Evans	ec4d377d15	Stop removing islands for fully-isolated zones It is hard for a user to tell what is going on when their zone just doesn't fill at all. We catch isolated areas in the DRC so we can just leave them alone here until the zone has at least one non-isolated filled area. Also change default back to always remove islands to reduce confusion Fixes https://gitlab.com/kicad/code/kicad/-/issues/13271	2023-01-27 08:57:18 -05:00
Alex	e3fa447f0c	router: Remove extra qualification.	2023-01-27 11:56:23 +03:00
Alex	0ff6cb49d6	router: When dragging tracks, don't snap to parts of the original line. Fixes https://gitlab.com/kicad/code/kicad/issues/10113	2023-01-27 11:06:36 +03:00
Alex	52edbf91dc	Better synchronization of various ratsnest visibility controls.	2023-01-27 10:01:12 +03:00
Alex	a872ed11bf	Fix paths for Copy default global library table.	2023-01-27 09:24:52 +03:00
Seth Hillbrand	a0236113da	Attempt fix to RATSNEST crash We call 'RecalculateRatsnest' in multiple locations, this will invalidate various pointers needed by VIEW::Redraw(). When this is called through the normal connectivity routines, we have the mutex locked to prevent conflict but we've added more locations that update just the Ratsnest. The std::adopt_lock should take over the existing lock when needed Fixes https://gitlab.com/kicad/code/kicad/issues/13011	2023-01-26 17:32:38 -08:00
Seth Hillbrand	ec9e7eed90	Don't link DNP with Exclude from Pos files Exclude from Pos file property follows the footprint but may be different from the DNP property Fixes https://gitlab.com/kicad/code/kicad/issues/13616	2023-01-25 13:54:12 -08:00
Seth Hillbrand	a6badd0313	Fix compile warning	2023-01-25 13:53:13 -08:00
Jeff Young	2312cf34c4	Pay attention to knockout text when adding to DRC Rtrees.	2023-01-25 18:34:03 +00:00
jean-pierre charras	b2f6c13b6a	Fp editor and Fp viewer: fix missing info on msg panel after loading a fp Fix also duplicate/not used code Fixes #11404 https://gitlab.com/kicad/code/kicad/issues/11404	2023-01-25 17:47:04 +01:00
Mike Williams	a76a4f9788	Router: don't unnecessarily change track widths on layer change Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13546	2023-01-25 09:34:17 -05:00
Marek Roszko	ae812bdf39	Try to use the theme setting for the cli pcb svg export	2023-01-24 22:57:28 -05:00
Jeff Young	e886ccacbd	Cleanup unused local variable.	2023-01-24 23:45:55 +00:00
Jon Evans	769afa6fe6	Properties: refactoring	2023-01-24 12:08:37 -05:00
Jon Evans	890103a012	Properties: Fix handling of mixed value selections	2023-01-24 11:51:26 -05:00
Simon Richter	05198b896f	Move PCB_EDIT_FRAME::ExchangeFootprint to pcb_edit_frame.cpp No idea why it was in the dialog file, but there is no good reason for that.	2023-01-24 12:54:05 +00:00
Jeff Young	00e2bbac5a	Special-case net-ties for solder mask bridging. Fixes https://gitlab.com/kicad/code/kicad/issues/13646	2023-01-24 11:33:08 +00:00
Jeff Young	b0ec006b81	The safety of running the event loop during doCloseWindow is debatable. (Possibly a fix for Sentry KICAD-7T.)	2023-01-24 11:33:08 +00:00
Jeff Young	8eae75e8d6	Suppress handling of selection events until delete is done. Fixes https://gitlab.com/kicad/code/kicad/issues/13451	2023-01-24 00:07:40 +00:00
Seth Hillbrand	e713a3eac2	Handle cleanup safely Make sure that the connectivity has successfully completed before attempting to merge segments. Also avoids reaching into the shared_ptr if we don't need to Fixes https://gitlab.com/kicad/code/kicad/issues/13639	2023-01-23 15:56:46 -08:00
Jon Evans	12b0a12d74	Handle DP checks for board minimum rules Fixes https://gitlab.com/kicad/code/kicad/-/issues/13640	2023-01-23 17:45:16 -05:00
Seth Hillbrand	efe12f2da5	Cleanup variable naming Also remove ancient/unused code for lazy resolving	2023-01-23 22:21:12 +00:00
Seth Hillbrand	a9ed47f06c	Update KICAD6->KICAD7	2023-01-23 22:21:12 +00:00
Jeff Young	509b39e9e4	Propagate nets within non-conflicting clusters immediately. Fixes https://gitlab.com/kicad/code/kicad/issues/13601	2023-01-23 16:25:29 +00:00
Jeff Young	ece775c53c	Blind/buried vias are drilled, and drilled holes need to avoid prior-burned holes. Fixes https://gitlab.com/kicad/code/kicad/issues/13627	2023-01-23 16:25:29 +00:00
Jeff Young	c430c88f9d	Immediate update of no-net objects when they're connected to something else. Fixes https://gitlab.com/kicad/code/kicad/issues/13601	2023-01-23 16:25:29 +00:00
Jon Evans	4a55b7998a	Standardize on longer phrasing Fixes https://gitlab.com/kicad/code/kicad/-/issues/13514	2023-01-23 08:59:18 -05:00
Jon Evans	e11012fe06	Properties: show via friendly name Fixes https://gitlab.com/kicad/code/kicad/-/issues/13635	2023-01-23 08:56:21 -05:00
aris-kimi	09b83b95d0	PCB Editor: Locked filter unchecked by default And some minor code style improvement in one place Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13246	2023-01-23 11:36:06 +00:00
jean-pierre charras	136c150460	plot_brditems_plotter: fix crash (null poiner use) when run from kicad-cli, with a not initialized plotter render settings. Fixes #13633 https://gitlab.com/kicad/code/kicad/issues/13633	2023-01-23 11:50:27 +01:00
jean-pierre charras	e0111f709b	Fix minor cosmetic issues in Print dialogs Fixes #13629 https://gitlab.com/kicad/code/kicad/issues/13629	2023-01-23 09:21:23 +01:00
Jon Evans	1bc3f77d2e	Coverity fixes	2023-01-22 22:48:31 -05:00
Alex	1aca216f18	Add DRC suggestions for Via_Type	2023-01-23 05:14:06 +03:00
Alex	91d154cd28	Add DRC suggestions for Shape	2023-01-22 22:35:12 +03:00
Alex	05eafdc08b	Add missing DRC Type suggestions.	2023-01-22 22:35:12 +03:00
Jeff Young	bf8762c57c	Streamline color lookup (and a bit of wxS).	2023-01-22 17:18:03 +00:00
Jon Evans	09cb222252	Change indeterminate checkbox behavior to be more intuitive Fixes https://gitlab.com/kicad/code/kicad/-/issues/13604	2023-01-22 12:10:45 -05:00
Jon Evans	351f668645	Separate selection change updates from properties updates Fixes https://gitlab.com/kicad/code/kicad/-/issues/13624	2023-01-22 12:10:45 -05:00
Jeff Young	729b2deb5c	Use board layer names for properties grid. Fixes https://gitlab.com/kicad/code/kicad/issues/13553	2023-01-22 15:47:57 +00:00
Marek Roszko	0ff32d20cd	wxS more things	2023-01-22 09:41:42 -05:00
Jeff Young	03a64492e8	Handle all member vars if not doing a std::swap on "this". Fixes https://gitlab.com/kicad/code/kicad/issues/13621	2023-01-22 13:00:18 +00:00
aris-kimi	86c12d35b4	Small order change for three View menu items	2023-01-22 01:04:17 +00:00
Jeff Young	005648f4db	The net inspector is a modeless panel, not a dialog. No need for OK button.	2023-01-22 00:14:02 +00:00
Jeff Young	8a9a63134c	Minor dialog adjustments.	2023-01-22 00:14:02 +00:00
Jon Evans	3a9ef02fdf	Clean up handling of selection changes Fixes https://gitlab.com/kicad/code/kicad/-/issues/13620 Fixes https://gitlab.com/kicad/code/kicad/-/issues/13609	2023-01-21 17:37:29 -05:00
jean-pierre charras	df4f9d4c94	FP editor: fix crash when trying to save a footprint after removing its library Fixes #13619 https://gitlab.com/kicad/code/kicad/issues/13619	2023-01-21 18:18:38 +01:00
Jeff Young	12215647f1	Handler blind/buried/micro via drawing when all layers are hidden. Fixes https://gitlab.com/kicad/code/kicad/issues/13607	2023-01-20 19:09:12 +00:00
Mike Williams	6586a2ca66	PCB Editor: prevent scroll wheel on track size opening board settings Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13218	2023-01-20 12:13:16 -05:00
Seth Hillbrand	34810d24a5	Remove unique dummy text Text that will be replaced programmatically should be specified as "dummy" in wxFormBuilder to avoid adding unneeded translation strings	2023-01-20 09:11:08 -08:00
Jeff Young	89d434255c	Run clearance rules for router status bar. Fixes https://gitlab.com/kicad/code/kicad/issues/13605	2023-01-20 14:19:58 +00:00
Jeff Young	d9a90519f9	Flatten (and fix layout) of library table managers.	2023-01-20 14:19:58 +00:00
Jeff Young	24dd402e29	Finish processing last pad in pad group, and trim whitespace from pads.	2023-01-19 15:48:32 +00:00
Mike Williams	67eae77e9d	PCB/SCH/3D: Implement 3D cross-probing from schematic Fixes: https://gitlab.com/kicad/code/kicad/-/issues/3859	2023-01-19 10:39:47 -05:00
Mike Williams	b8352b07c5	PCB: Immediate mode copy should deselect if hover selecting	2023-01-19 09:45:47 -05:00
Seth Hillbrand	7e5a2450b8	Move multiple wxMessageBox to DisplayErrorMessage Also provide protection for headless running in multiple callsites Fixes https://gitlab.com/kicad/code/kicad/issues/13575	2023-01-18 16:54:01 -08:00
Seth Hillbrand	b99bd7633d	Allow commas, spaces in pad names for net-ties Net tie groups are currently separated by comma. But comma is also an allowed, albeit rare character for pad names. To allow pad names with commas in net tie groups, the group definition must be escaped with a forward slash for commas (and forward slashes). Pad 1,2 Pad 2,3 Net-tie group "1\,2,2\,3" Fixes https://gitlab.com/kicad/code/kicad/issues/13001	2023-01-18 14:45:52 -08:00
Seth Hillbrand	8f4486752d	Fix build error	2023-01-18 10:20:20 -08:00
Seth Hillbrand	7fa15b3fbb	Only update items that can be affected When updating the view, don't force repaint all items. Changing the line width only affects elements with lines Fixes https://gitlab.com/kicad/code/kicad/issues/13579	2023-01-18 09:59:00 -08:00
Dag Lem	cff0560088	Eagle schematic import: Handling of escaped text	2023-01-18 12:33:36 +00:00
Jeff Young	3af9c658e6	Don't specify fonts in wxFormBuilder. It only leads to pain. Fixes https://gitlab.com/kicad/code/kicad/issues/13547	2023-01-18 12:28:07 +00:00
jean-pierre charras	90c76fa4bc	Pcbnew: display first and last layer ID on buried and micro vias. Fixes #13566 https://gitlab.com/kicad/code/kicad/issues/13566	2023-01-18 09:56:25 +01:00
jean-pierre charras	940d88c47d	PCB_SHAPE::swapData() : Do not swap twice a parameter Fixes #13576 https://gitlab.com/kicad/code/kicad/issues/13576	2023-01-18 08:37:34 +01:00
Jeff Young	7844602210	Nullptr safety.	2023-01-18 01:30:40 +00:00
Jeff Young	f90b04c715	Nullptr safety. (Sentry KICAD-5N)	2023-01-18 01:05:27 +00:00
Jeff Young	f45d44a639	Don't leave temp footprints attached to a board.	2023-01-18 00:46:59 +00:00
Seth Hillbrand	f35a02d57a	Move early exit higher in netname redraw If the track is outside of the viewbox, GetLOD returns HIDE. This needs to be handled quickly in the loop before further processing Fixes https://gitlab.com/kicad/code/kicad/issues/13572	2023-01-17 15:56:04 -08:00
Jeff Young	3cc960a872	Push nets to free pads when they're used. Fixes https://gitlab.com/kicad/code/kicad/issues/13516 Fixes https://gitlab.com/kicad/code/kicad/issues/13517	2023-01-17 23:29:47 +00:00
Seth Hillbrand	1d223d1439	Safely load python plugins Catch potential exceptions when doing the initial python plugin load Fixes https://gitlab.com/kicad/code/kicad/issues/12231	2023-01-17 12:56:15 -08:00
Seth Hillbrand	60ba245474	Remove Eagle islands by default unless told otherwise Fixes https://gitlab.com/kicad/code/kicad/issues/13503	2023-01-17 12:49:44 -08:00
Jeff Young	26c821962f	Simplify and regularize text variable substitution architecture. EDA_ITEMs are responsible for giving their parent a crack at it if they failed to resolve it. This recurses all the way up to the schematic/ board, and then to the project. Cross-reference handling is also move to the EDA_ITEMs. It must be done before bubbling up so that we don't end up in loops. (The aDepth parameter will break the loop, but without having done anything useful.) Fixes https://gitlab.com/kicad/code/kicad/issues/13541	2023-01-17 17:05:41 +00:00
Jeff Young	9820062c71	Fix clipping issue in Pad Properties dialog.	2023-01-17 17:05:41 +00:00
Wayne Stambaugh	022c913e8f	Fix another broken graphics import file filter.	2023-01-17 11:34:51 -05:00
Mike Williams	369c0efade	Bitmaps: respect source DPI Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13565	2023-01-17 11:20:17 -05:00
Wayne Stambaugh	f81642bbb3	Fix broken graphics import file filters. Fixes https://gitlab.com/kicad/code/kicad/-/issues/13570	2023-01-17 11:19:53 -05:00
jean-pierre charras	90c5ede1e6	pcbnew: move DIALOG_PAD_PROPERTIES_BASE from dialog_pad_properties to its own files. dialog_pad_properties_base.fbp included to many dialog descriptions.	2023-01-17 09:44:28 +01:00
Marek Roszko	ac94995f70	Some more wxS	2023-01-16 19:07:50 -05:00
Felix Schneider	08295c795b	Add vertical justification buttons to pcbnew text dialog kicad 6 default behaviour was not achievable through the UI. Addresses #13423 and #2375	2023-01-16 18:40:08 +00:00
Jeff Young	22497502e6	Don't leave a dummyPad in a group. Freeing it will cause problems. Fixes https://gitlab.com/kicad/code/kicad/issues/13556	2023-01-16 17:30:40 +00:00
Jeff Young	e490728226	Don't run the footprint checker's shorting pads routine at board level. Fixes https://gitlab.com/kicad/code/kicad/issues/13555	2023-01-16 16:44:16 +00:00
jean-pierre charras	c4ccf46cc7	DIALOG_PAD_PRIMITIVES_PROPERTIES: fix incorrect display of polygon primitive. Fixes #13557 https://gitlab.com/kicad/code/kicad/issues/13557	2023-01-16 17:32:22 +01:00
Jeff Young	f0b2902b8c	Don't allow quit while zone filler is running. Fixes https://gitlab.com/kicad/code/kicad/issues/13551	2023-01-16 16:01:45 +00:00
Jeff Young	62649b868c	Ensure good fonts in grid headers. Also moves rendering to a flat look for headers (instead of a beveled border). Fixes https://gitlab.com/kicad/code/kicad/issues/13547	2023-01-16 02:47:14 +00:00
Jeff Young	ca1fb732c8	Share Eagle var substitution between board and schematic importers. Fixes https://gitlab.com/kicad/code/kicad/issues/13541	2023-01-15 22:27:19 +00:00
Jeff Young	91c5bb9175	Block user-initiated zone-fill actions, but not system ones. Fixes https://gitlab.com/kicad/code/kicad/issues/13536	2023-01-15 19:16:36 +00:00
Jeff Young	0328cae94c	Detach revert footprint copy from parent board. Fixes https://gitlab.com/kicad/code/kicad/issues/13537	2023-01-15 17:26:44 +00:00
Wayne Stambaugh	744fd3a71e	Fix GCC build issue on Linux.	2023-01-15 12:18:56 -05:00
Jeff Young	bf4b9ef6e2	Remove sorting by priority before filling. We can't fill lower-priority zones until the higher-priority ones have been tesselated, and as the tesselation step always gets pushed to the back of the queue after the fill finishes having them sorted by priority accomplishes little. (We're also going to push all other layers of the high-priority zone to the back as the first layer will have the lock, further degrading the usefulness of sorting.)	2023-01-15 15:52:24 +00:00
Jeff Young	0c8f95aa02	Make sure tesselate_lambda has lock before modifying zone. Also implements locking for upating pad & tracks' zoneConnectionCaches. Fixes https://gitlab.com/kicad/code/kicad/issues/13531	2023-01-15 15:52:24 +00:00
Jeff Young	45a71a205c	Don't wait for degenerate zones.	2023-01-15 15:52:24 +00:00
Jeff Young	f1aee2fa18	Minor dialog tweaks.	2023-01-14 01:45:30 +00:00
Jeff Young	ea4c3a267b	Be more discerning about dirtying zones for auto-refill. In particular, record which children caused a parent footprint to be added to the commit so we can determine if they have intersecting bounding boxes and/or layers. Fixes https://gitlab.com/kicad/code/kicad/issues/13512	2023-01-13 19:09:22 +00:00
Jeff Young	f358749b28	Import copper pour cutouts from Eagle packages (footprints). Fixes https://gitlab.com/kicad/code/kicad/issues/13503	2023-01-13 16:35:45 +00:00
Tomasz Wlostowski	761e754294	router: trying to improve the 'guess posture' algorithm to work well with both fix-all and fix-last-segment on click	2023-01-12 23:37:07 +01:00
Tomasz Wlostowski	65def26b4d	router: follow up ROUTER::GetUpdatedItems() API changes in the ROUTER_TOOL	2023-01-12 23:37:07 +01:00
Tomasz Wlostowski	d07d6c9a30	router: fix 'Bowen knot'-looking hulls for 0-length segments	2023-01-12 23:37:07 +01:00
Tomasz Wlostowski	0595440d79	router: minor improvements in shove algorithm handling of vias	2023-01-12 23:37:07 +01:00
Tomasz Wlostowski	213d30cad6	router: workaround for assertion fail on NODE::Add(unique_ptr<LINE>)	2023-01-12 23:37:07 +01:00
Tomasz Wlostowski	aa7271e55a	router: expose the 'head' traces in a separate list for debug logs	2023-01-12 23:37:07 +01:00
Seth Hillbrand	79f567cff4	Standardize BOM nomenclature Fixes https://gitlab.com/kicad/code/kicad/issues/13499	2023-01-12 13:54:12 -08:00
Jeff Young	631fd54f9f	Don't suppress writing of empty values. They have meaning. Fixes https://gitlab.com/kicad/code/kicad/issues/13507	2023-01-12 15:24:59 +00:00
Jon Evans	595bf70d5d	Do not try to read from UI elements that haven't been initialized yet Fixes https://gitlab.com/kicad/code/kicad/-/issues/13480	2023-01-12 09:16:22 -05:00
Jon Evans	c530bdb5a1	Rename GetSelectMenuText to GetItemDescription This descriptive text is used for many more things than just the select menu these days.	2023-01-11 22:27:44 -05:00
Jon Evans	1ff1571849	Bring back deprecated net properties to rules system	2023-01-11 22:14:52 -05:00
qu1ck	2654279678	Cleanup zone bbox cache in destructor	2023-01-12 00:21:51 +00:00
Seth Hillbrand	248399f771	Standardize print/plot terms Use choice box for color/bw selection "border and title block" -> "drawing sheet" Fixes https://gitlab.com/kicad/code/kicad/issues/13128	2023-01-11 12:30:02 -08:00
Jeff Young	8238973bf4	Make sure std::unique_ptr gets initialized. (Fixes unit test failure.)	2023-01-11 18:28:29 +00:00
Jeff Young	096cc7a5ad	Suppress unflashed annular rings only when copper layer is primary. Fixes https://gitlab.com/kicad/code/kicad/issues/13471	2023-01-11 18:15:46 +00:00
Jeff Young	c85dcbc4e1	Improve performance of IncrementTimestamp so it can be called at will.	2023-01-11 17:41:08 +00:00

... 11 12 13 14 15 ...

15787 Commits