haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
40,452 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

3014 Commits

Author SHA1 Message Date
Alex 75053cfc57 Remove normally unused code from Move function. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13222
 2022-12-21 19:06:32 +03:00
Mike Williams 5d94d2634e PCB Editor: make locking menu items conditional 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/5202
 2022-12-21 10:34:54 -05:00
jean-pierre charras 44ab6876d9 fp editor: remove useless "Unroute Selected" from context menu. 
Fixes #13229
https://gitlab.com/kicad/code/kicad/issues/13229
 2022-12-21 13:11:51 +01:00
Mike Williams bd24e85289 PCB: Add Copy With Reference to the Positioning Menu 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11947
 2022-12-20 11:54:05 -05:00
Jeff Young 5327ea5823 Respect selectabiltiy when adding wholy-selected groups. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13092
 2022-12-15 17:57:58 +00:00
Seth Hillbrand 279edcefdc Don't break tracks without snap 
If the user asks to not snap to a track, we should also prevent the
track from snapping to the via

Fixes https://gitlab.com/kicad/code/kicad/issues/13142
 2022-12-14 13:51:42 -08:00
Jeff Young 9d13e419c2 Reduce compiler warnings. 2022-12-13 00:47:19 +00:00
Seth Hillbrand 4fe35d0df1 More push/pop tool issues 
We need to pop the move tool off when it doesn't find anything to act on
so that the pushed tools under it on the stack can re-activate

Fixes https://gitlab.com/kicad/code/kicad/issues/13114
 2022-12-12 12:56:35 -08:00
jean-pierre charras 96a9ec4a0c Enhance compatibility with V6.0 for Intersheetrefs fields associated to GLOBAL labels. 
In V6.0, the identifier is "Intersheet References" and was not immediately
seen as Intersheetrefs field.
 2022-12-12 16:38:04 +01:00
Jeff Young 45eae3e594 Don't Simplify() polys with arcs in them. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13134
 2022-12-12 12:54:34 +00:00
Alex 5e8227b54a pcbnew: Support dragging arc center in "Keep endpoints" mode. 2022-12-12 13:00:44 +03:00
Alex 3eb31befed Fix a delay when dragging arc endpoints in pcbnew. 2022-12-12 09:39:56 +03:00
Alex da1e5a80a8 Restore removeCorner transition in PCB editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13133
 2022-12-12 07:04:20 +03:00
Alex b01d950071 Remove start pt when collinear with neighboring pts in zone/poly draw. 2022-12-10 06:21:54 +03:00
Alex b4b25a7009 Fix Pack & Move footprints when working with groups. 2022-12-09 20:42:35 +03:00
Alex c1f82d0c80 Canceling Move cancels Pack too in Pack & Move footprints. 2022-12-09 20:41:56 +03:00
Alex 3d2b1aaf90 Improve H/V/45 deg mode when drawing zones and polygons. 2022-12-09 19:11:56 +03:00
Mike Williams 0e75bf02fa Selection: refactor modifier checking 2022-12-08 14:12:12 -05:00
Alex 6d513e7ecf Expose changing arc edit mode in arc button context menu and Preferences 
Ctrl+Space can still be used to cycle through modes.

Fixes https://gitlab.com/kicad/code/kicad/issues/5412
 2022-12-05 21:28:16 +03:00
Graham Keeth ef83d01455 Minor string changes: "eeschema" / "pcbnew" in tooltips, and power port terminology 2022-12-04 14:29:57 +00:00
Jeff Young 96819f6c01 Better cache invalidation for text objects with references. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13059
 2022-12-04 11:51:44 +00:00
Jon Evans 0bc06d506c Properties: reselect after canceled move 2022-12-02 21:40:21 -05:00
jean-pierre charras 93c631af44 drawing_stackup_table_tool: fix incorrect color of dielectric sublayers. 
when a dielectric has sublayers, the printed color was always the main layer color.
 2022-12-02 10:41:20 +01:00
Jeff Young 20791c99ac Allow conversion of single track segments and vias. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13047
 2022-12-01 17:15:29 +00:00
Jeff Young 6befa1c57e A bit of cleanup to recent convert tool changes. 2022-12-01 14:53:13 +00:00
Jeff Young 4d8e73a630 Allow tracks as input to bounding hull generation. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13047
 2022-12-01 14:53:13 +00:00
Seth Hillbrand b31349b679 Get consistent point for gfx import 
TopLeftItem() should always return same element for our import

Fixes https://gitlab.com/kicad/code/kicad/issues/13041
 2022-11-30 12:25:34 -08:00
Seth Hillbrand cf33f33899 Standardize placement tool modifiers 
PlaceImage, PlaceImportedGraphics and PlaceText need to handle the grid
and hotpoint snapping as well as the modifiers to disable them
 2022-11-30 10:57:42 -08:00
Jeff Young 3c4c4e5166 Remove shortened debug time from zone refill message. 
Also adds a time-out for it.
 2022-11-30 17:38:02 +00:00
Jeff Young 074c087c21 Allow disabling of grid snapping while placing imported image. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13040
 2022-11-30 14:38:22 +00:00
Jeff Young 98ab078905 Remember conversion strategy. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13043
 2022-11-30 14:29:16 +00:00
Mike Williams 17bb57cc73 PCB: fix stale ratsnest between moves in Move Individually 2022-11-30 09:11:37 -05:00
Jeff Young 8dbd6fee00 Go back to smaller chaining epsilon. 
Using a large epsilon here to allow for sloppy drawing can cause
the algorithm to miss very short segments in a converted bezier.
So use an epsilon only large enough to cover for rouding errors in
the conversion.

Fixes https://gitlab.com/kicad/code/kicad/issues/12951
 2022-11-30 13:26:45 +00:00
Jeff Young 19eab62516 More safety around ratsnest state. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13011
 2022-11-30 13:00:21 +00:00
Jeff Young 9fa8b9e49f Fix memory leak and re-code non-memory-leak so Coverity can understand it. 2022-11-30 13:00:20 +00:00
Alex 8c468dcffc Use ecoords for distance comparison in PCB grid helper. 
Fixes a bug where a cursor would jump to a far location while hovering
over some 45-degree tracks.
 2022-11-30 08:18:19 +03:00
Jon Evans 41ca2789a6 Get rid of shadowing warning 2022-11-29 18:12:39 -05:00
Jeff Young abd818a426 Update msgpanel after entering or exiting group. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13031
 2022-11-29 21:33:04 +00:00
Jeff Young 31eb91e9e5 Infobar for slow zone auto-refill. 2022-11-29 21:09:16 +00:00
Jeff Young b6bd74d822 Replace single zone fill under "draft" terminology. 
Also sets Autofill Zones to default to on.
 2022-11-29 18:13:36 +00:00
Mike Williams ad6ef35c9f PCB: Add skip action to Move Individually 2022-11-29 15:42:03 +00:00
Jeff Young b2177718a1 Tighten up refresh logic for net & netclass references. 
Also tightens it up a bit for text variables which can reference things
like netnames and netclasses, but also board settings.

Fixes https://gitlab.com/kicad/code/kicad/issues/13032
 2022-11-29 15:18:36 +00:00
Jeff Young 8165fc6c44 Give up trying to infer what kind of polygon the user wants. 
In many instances there are 3 valid answers: mimic linewidths, use
centerlines, and build a bounding hull.

Fixes https://gitlab.com/kicad/code/kicad/issues/12950
 2022-11-28 22:12:53 +00:00
Mike Williams 4a4fab78a3 PCB: allow swap while moving 2022-11-28 14:16:08 -05:00
Mike Williams 3042633f4a PCB: block unroute and move individually when already moving 2022-11-28 14:16:08 -05:00
Jon Evans 64f315c649 Move properties panel to widgets with the other AUI panels 2022-11-27 22:40:23 -05:00
Jeff Young ec9c6a8053 Separate creation of polygons for open and closed shapes. 
This allows us to create a bounding hull from an open shape-line-chain,
which is useful for defining milled slots.
 2022-11-27 18:29:41 +00:00
Jon Evans 8c7691fbc3 Harmonize on "Manager" for now, since we use that in the docs 2022-11-25 09:13:23 -05:00
Jon Evans bbea5b3fbc Save and restore properties and search panel sizes 2022-11-25 09:11:30 -05:00
Seth Hillbrand 47d86e5d9e Don't crash when canceling graphics import 
Grouped graphics need to have their group removed from the preview
before deleting the elements to avoid reading freed memory when
redrawing
 2022-11-23 16:21:06 -08:00
Jeff Young 8b1ffca7fa Better reporting of nets and netclasses. 2022-11-22 14:54:08 +00:00
Jeff Young 97fd99ec99 Re-resolve netclasses after assigning netclass to pattern. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12965
 2022-11-22 14:54:08 +00:00
Jeff Young 226529235c Mostly const safety, but also performance opt. by avoiding shared_ptr overhead. 2022-11-22 12:21:30 +00:00
Seth Hillbrand 3b31955d98 Get hit test in group members 
Fixes https://gitlab.com/kicad/code/kicad/issues/12957
 2022-11-21 09:28:49 -08:00
Seth Hillbrand 01138a2e19 Fix fillet action for lines 
Generalize fillet action behavior to all straight lines in pcbnew

Fixes https://gitlab.com/kicad/code/kicad/issues/4742
 2022-11-21 07:01:14 -08:00
Jeff Young c1510f07d8 Fix some issues with group bounding boxes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12958
 2022-11-20 23:57:36 +00:00
Jeff Young 0120df014e Give group the right parent when pasting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12954
 2022-11-20 22:52:06 +00:00
Alex 12a55f20d3 Fix a mistake in grip margin. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12952
 2022-11-21 00:25:19 +05:00
Alex dd2f19ca5f Allow router cursor snapping to points on the arc. 
Also don't disable grid snapping when holding Shift over arcs.
 2022-11-20 16:56:25 +05:00
Alex 110bc6abd1 Fix router cursor glitching on H/V track segments. 
Also don't disable grid snapping when holding Shift over tracks.
 2022-11-20 16:56:25 +05:00
Alex 38fd1c9985 pcbnew: Improve performance when something is selected. 2022-11-19 01:53:30 +05:00
Jeff Young c409646aad Update message panel after rebuilding connectivity. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10122
 2022-11-18 15:29:16 +00:00
Jeff Young bba6d503d4 Don't keep value of user or grid anchors between invocations. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12065
 2022-11-17 00:51:52 +00:00
Jeff Young cefc5268ab Allow pads in selection and filter them for free-pads later. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12912
 2022-11-16 18:37:40 +00:00
Jeff Young 9724f6e736 Don't allow zone filling during other editing operations. 
It's a very heavy op, and is likely to violate all manner of
assumptions the other ops make.

Fixes https://gitlab.com/kicad/code/kicad/issues/12736
 2022-11-14 23:39:49 +00:00
jean-pierre charras f51db4e093 Fix some Coverity and compil warnings. 2022-11-14 09:02:40 +01:00
Jeff Young 9d8fdd8d53 Fire selection events from SelectAll(). 
Fixes https://gitlab.com/kicad/code/kicad/issues/12896
 2022-11-13 22:59:21 +00:00
Jeff Young 7089e99f4b Integrate move individually into move algo so other commands don't choke. 
Also adds commands to cancel and finish move individually.

Fixes https://gitlab.com/kicad/code/kicad/issues/12750

Fixes https://gitlab.com/kicad/code/kicad/issues/12749
 2022-11-13 13:18:42 +00:00
jean-pierre charras 248181e62d Fix Coverity and compil warnings. 2022-11-12 16:02:24 +01:00
Jeff Young d9987e9569 Orig_items will have been invalidated by Revert. 
Don't use it to rebuild the selection.  Use the board_item flags instead.

Fixes https://gitlab.com/kicad/code/kicad/issues/12882
 2022-11-11 22:57:38 +00:00
Jeff Young 138f835672 Retire group bbox cache. 
It's too hard to maintain when changes to other items (the groups
members) affect it.
 2022-11-11 20:31:31 +00:00
Jeff Young 3fc727bb91 Clear selection before deleting objects during conversion. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12879
 2022-11-11 17:53:01 +00:00
Jeff Young 03ba14c6d3 Tighten lifecycle management of parent group pointers. 
Also adds some debugging to try to catch dangling pointers.

Also adds a cache for group bounding boxes (which will be expensive
to calculate for large groups).

Fixes https://gitlab.com/kicad/code/kicad/issues/12875
 2022-11-11 17:27:28 +00:00
Alex 0b4fc8f50d Fix bugs in PCB arc editing. 2022-11-11 15:00:36 +05:00
Alex 46d4861187 Use the 45-degree limit button to apply alternative constraint. 2022-11-11 15:00:36 +05:00
Alex 8b0f3f1ee7 Set keeping the center as the default arc editing mode. 2022-11-11 15:00:36 +05:00
Jeff Young 3f63f9fc57 Don't prune inner layers of through-hole parts. 
For historical reasons we've always included ALL inner layers in these
items and changing that has uncovered several latent bugs.  Rather
than find all the rest this late in the game, I went back to storing
all inner layers, even those the board doesn't currently have.

Fixes https://gitlab.com/kicad/code/kicad/issues/12863
 2022-11-09 15:58:14 +00:00
Jeff Young 4066850f37 Use event point to determine if we're still in draggable item. 2022-11-09 13:09:01 +00:00
Seth Hillbrand 056f45cd70 Fixup most intersecting polygon points 
Remaining is the intersecting complex pad, so this keeps the error
message when drawing

Fixes https://gitlab.com/kicad/code/kicad/issues/12806
 2022-11-08 16:05:04 -08:00
Jeff Young 2cfe78170c Honour selection filter when picking move anchors. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12773
 2022-11-08 16:27:18 +00:00
jean-pierre charras cb3d215b6a Fix compil and Coverity warnings. 2022-11-08 11:53:13 +01:00
Jeff Young be8bbcaac3 Send Selected event even if the result is an empty selection. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12849
 2022-11-07 19:47:51 +00:00
Jeff Young b5f62da5d9 Respect synthetic layer visibility when selecting footprint texts. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12850
 2022-11-07 19:26:14 +00:00
Jeff Young ae741b93e6 Resore push/pop-less PickerTool. 
(Functionality was accidentallly lost when we removed the opt command
strings.)
 2022-11-07 19:11:12 +00:00
dsa-t 0b3ecdd968 Revert "Fix handling of self-intersecting polygons" 
This reverts commit ed309e20da
 2022-11-07 09:41:56 +00:00
Jon Evans dd94b2d3a7 Rename PROPERTIES to STRING_UTF8_MAP for clarity 
This class has nothing to do with the properties system
 2022-11-06 11:51:52 -05:00
Jeff Young bb618f2d55 Update pointEditor after cancelled move. 2022-11-05 16:50:54 +00:00
Seth Hillbrand 8bc9d456c3 Fix area selection calculation 
area was a double value for comparison of large numbers.  But the
promotion from int happened after the multiplication (and overflow) for
large images

Fixes https://gitlab.com/kicad/code/kicad/issues/12821
 2022-11-03 11:46:40 -07:00
Seth Hillbrand ed309e20da Fix handling of self-intersecting polygons 
We allow temporary self-intersection but before committing, we reduce
the polygon to a single outline (optionally with holes)

Fixes https://gitlab.com/kicad/code/kicad/issues/12806
 2022-11-01 13:09:11 -07:00
Seth Hillbrand c7c4439027 Allow bezier->line/poly conversion 
Fixes https://gitlab.com/kicad/code/kicad/issues/12778
 2022-10-31 12:48:53 -07:00
Jeff Young 3b3e6de515 Disable mirror commands when a single footprint is selected. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12752
 2022-10-28 19:20:24 +01:00
Wayne Stambaugh 6a0db3e7e2 Fix Coverity warnings. 2022-10-26 14:39:44 -04:00
Jon Evans 960c92634f Improve logic of Position Relative tool 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12672

(cherry picked from commit 2d2912c23d)
 2022-10-24 18:47:38 -04:00
Jeff Young d16b23d16e Name shortening and line-break reduction. 2022-10-21 18:41:39 +01:00
Jeff Young e3842514e7 Move courtyard collision setting to preferences. 
Also cleans up PCBNew/FPEditor edit options panel to be more in sync
with each other.
 2022-10-19 11:33:11 +01:00
Jeff Young 403cc50e7c Don't exit group when the cancel went to another tool. 
Also fixes a bug where the group border didn't get updated immediately
on enter/exit.

Fixes https://gitlab.com/kicad/code/kicad/issues/12669
 2022-10-18 17:53:06 +01:00
Jeff Young 4633d251a5 Remove single-zone-fill and unfill. 
These are incompatible with our zone-priority-based algorithms.
 2022-10-18 13:45:28 +01:00
Wayne Stambaugh 598b09821a Coverity fixes. 2022-10-17 15:30:20 -04:00
Jeff Young 46752499df We need both a tool-oriented delete and one that doesn't push/pop, etc. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12600
 2022-10-17 13:21:07 +01:00
Jeff Young e9f8454a67 No DRC engine in footprint editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12658
 2022-10-16 18:39:37 +01:00
Jeff Young 4af98827fd Revert change for 11299, and update removed-pad items after zone fills. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12645
 2022-10-15 16:06:57 +01:00
Seth Hillbrand 697056fa7e Correctly sort positions for default align 
When not aligning under mouse cursor, choose the X-most element where X
is top/bottom/left/right.  Previous sorting was not correct for two
directions

Fixes https://gitlab.com/kicad/code/kicad/issues/12627
 2022-10-14 16:15:06 -07:00
Jeff Young de5980b92e Share more of the courtyard collision highlighting code. 2022-10-14 10:42:07 +01:00
Jeff Young 11dc5424cb Pull interactive courtyard checker out of move tool to share with router. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12594
 2022-10-14 00:48:37 +01:00
Jeff Young 8f1b4a9c03 Include cleanup. 2022-10-13 23:15:41 +01:00
Jeff Young 8b9cbd5805 Don't reset editPad if it still exists after model reset. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12630
 2022-10-13 00:07:30 +01:00
jean-pierre charras d0d625dcb5 BOARD_INSPECTION_TOOL::LocalRatsnestTool(): set a suitable cursor when activated. 2022-10-12 15:56:41 +02:00
Jeff Young 83310659fd Basic geometry: R != D. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12601
 2022-10-10 19:18:37 +01:00
Jeff Young 8470b178cd Use actual pad shapes or built outline instead of effective shpaes for anchors. 
The effective shapes don't work very well in the custom pad or rounded
rectangle cases, and they're somewhat slower in some of the other cases.

Fixes https://gitlab.com/kicad/code/kicad/issues/12601
 2022-10-10 18:11:32 +01:00
Jeff Young 79dabdd484 Fix typo. 2022-10-07 23:52:47 +01:00
Jeff Young 04fec5016b Add keepout zones set to keepout footprints to footprint courtyard checker. 
(This is for the move tool, not DRC.  DRC uses more sophisticated keepout
processing which is too slow for the move tool, and doesn't let us know which
keepout area collided for collision highlighting.)

Fixes https://gitlab.com/kicad/code/kicad/issues/12594
 2022-10-07 22:23:37 +01:00
Alex 165654f114 Expose Switch Arc Posture in context menu. 2022-10-07 08:28:13 +03:00
Alex d26b59a0bf Improve arc construction using angles from arc geometry manager. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11713
 2022-10-07 06:51:00 +03:00
Alex 22917860ef Move Enter Group for easier access. 2022-10-07 03:03:33 +03:00
aris-kimi f818f3a445 Fix footprint rule and zone area anchors 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12575
 2022-10-06 15:29:18 +00:00
Jeff Young 436d75e7f9 Try to reconcile SELECTION and BRIGHTENED use of overlay. 
For some reason the overlay doesn't get redrawn during the PCBNew
selection disambiguation menu, so we need to not hide BRIGHTENED
items.

Fixes https://gitlab.com/kicad/code/kicad/issues/12547
 2022-10-04 17:01:56 +01:00
Jeff Young 524a43f95e Don't select footprints on the wrong side if not visible. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12483
 2022-10-04 13:22:06 +01:00
Jeff Young ba630971af Possible fix for move/esc/esc crash. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12553
 2022-09-30 23:05:55 +01:00
Jeff Young 6a6ef9b1f4 Bring adding-to-group and hiding in sync. 2022-09-30 16:45:00 +01:00
Mike Williams c1da59b560 Swap: disallow swapping tracks / wires 
Also fix missed shortcut change for S -> Shift-S

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12538
 2022-09-29 17:04:43 -04:00
Jeff Young d67437a2aa Move ratsnest exclusion processing to a post-pass. 
Also fixes a few cases where we were unnecessarily rebuilding
connectivity more than once for an operation.
 2022-09-29 17:08:49 +01:00
Seth Hillbrand 9894acea76 Spelling 2022-09-28 17:09:43 -07:00
Alex 4095172259 ADDED: Pack and Move Footprints, improved footprint spread algorithm. 2022-09-28 13:37:23 +00:00
Jeff Young 3a7068b346 Iterate on a copy of the selection since we're going to delete from it. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12484
 2022-09-27 23:54:19 +01:00
Mike Williams 700edb95e3 PCB Actions: Grab Unconnected 
Grabs the nearest unconnected item for each selected footprint/pad.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/1986
 2022-09-26 16:17:41 -04:00
Mike Williams f4a3062684 PCB: Select Unconnected 
Selects the all unconnected items for each selected routable item.
 2022-09-26 16:17:41 -04:00
Mike Williams e66393c4dd PCB Tools: Move Individually 
Allows moving a selection of components one by one.
 2022-09-26 16:17:41 -04:00
Marek Roszko 2490ad1458 Fix search panel not remembering visibility 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12494
 2022-09-25 11:56:41 -04:00
Marek Roszko 59d62f7df1 Untangle some includes 2022-09-25 11:37:06 -04:00
Jeff Young 7e71dc084c Implement Mirror H/V for tracks and vias. 
While not that often useful, it's really annoying that it doesn't work
when you *do* find a use-case for it.

Fixes https://gitlab.com/kicad/code/kicad/issues/6853
 2022-09-24 19:55:48 +01:00
Jeff Young 328cc27020 Add pad-recombining to FPEditor's Cleanup Graphics. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12487
 2022-09-24 19:34:06 +01:00
jean-pierre charras 28f836ab5c Fix overzealous string replacement 2022-09-23 10:56:58 +02:00
Jeff Young 897135a4f0 Support mirroring on the board too. 
Also fixes a few bugs in FP item mirroring.

Fixes https://gitlab.com/kicad/code/kicad/issues/2168
 2022-09-22 15:05:58 +01:00
Jeff Young 8eb68ee472 Add pin/unpin context menu to Symbol Chooser and Footprint Chooser. 
Also moves some more code down into common so it can be shared.

Fixes https://gitlab.com/kicad/code/kicad/issues/12384
 2022-09-21 14:45:12 +01:00
Jeff Young 513fc872bb Support both X and Y mirroring in FPEditor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12409
 2022-09-21 00:16:27 +01:00
Seth Hillbrand 0150655ed3 Fix missing DRC check with via 
When the via is first and not second in our ordering, the hole-copper
clearance was not checked as the track did not have a hole.

We also calculated the NPTH-via clearance incorrectly in the inspector
 2022-09-20 13:43:01 -07:00
Jeff Young 64a6fc0fd4 Push UNITS_PROVIDER down into a low-level mixin. 
This allows us to also construct cheap UNIT_PROVIDERs for specific
tasks when necessary.
 2022-09-19 17:10:59 +01:00
jean-pierre charras 5990595619 When adding a bitmap, do not clone it during moving. 
Cloning is not necessary, and is memory consuming.
 2022-09-19 17:41:47 +02:00
Mike Williams ca0c9f12e0 PCB Editor: Unroute Footprint 
Also works on selected pads.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/1955
 2022-09-19 10:37:10 -04:00
Mike Williams 9304607624 TOOL_EVENT: make command string non-optional 
We're getting segfaults in places where this isn't checked. Also, add
some asserts so we can catch bad tool push/pop.

Removes all uses of GetCommandStr() and makes it private.
 2022-09-19 10:23:09 -04:00
Jeff Young 45d6b4a9fc Readability improvements. 2022-09-19 11:18:20 +01:00
Jeff Young 1566bd8b14 Make sure a collector has a guide before handing it to a client filter. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12460
 2022-09-18 18:14:47 +01:00
Marek Roszko 3d5913c825 Remove convert_to_biu.h, merge contents to base_units.h 2022-09-16 21:09:28 -04:00
Marek Roszko 66e8931405 Remove IU_PER_MM thats standalone 2022-09-16 21:09:27 -04:00
Marek Roszko e6ed275c25 Repoint IU_PER_MILS 2022-09-16 21:09:26 -04:00
Marek Roszko a8613ee80f Combine Iu2Millimeter & remove PcbMm2iu 2022-09-16 21:09:26 -04:00
Jeff Young 107f409106 Use router's connectivity algorithm, not CONNECTIVITY_DATA's. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-09-16 22:49:20 +01:00
Jeff Young d9f75556bd Fix old copy/paste error (from 2017, believe it or not). 
Fixes https://gitlab.com/kicad/code/kicad/issues/11487
 2022-09-16 11:25:27 +01:00
Mark Roszko b00178adb3 Nuke base_units from orbit 2022-09-16 04:38:10 +00:00
Jeff Young ce9adeaf51 Don't set FreeVia when we can't find a net. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12421
 2022-09-15 23:16:08 +01:00
lulu731 0180bcf90a ADDED: Implement Drag and Drop 
dropping files to Kicad manager :
  *.kicad_pro, *.pro -> open project;
  gerber and job files -> open in Gerbview editor;
  Eagle and Cadstar files -> open project.
dropping file to schematic editor -> append schematic;
dropping library file to Symbol editor -> add library;
dropping board file to PCB editor -> append board;
dropping library or footprint file to Footprint editor -> add library or import footprint;
dropping ZIP file or gerber files to Gerbview editor -> open files;
dropping sheet file to Drawing Sheet editor -> open sheet.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11638
 2022-09-14 22:28:09 +00:00
Jeff Young 2d3b8d6393 Fix logic around Select All inside an entered group. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12411
 2022-09-14 12:24:51 +01:00
Jeff Young 281b9d405a ADDED ability to specify where pad number (& net name) go on custom shaped pads. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6627
 2022-09-14 11:37:20 +01:00
Jeff Young f91487aa36 Don't overwrite titleblock and pageinfo when appending board. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11650
 2022-09-14 11:37:20 +01:00
Mark Roszko f304e2d4f6 ADDED: Search/inspect pane 2022-09-14 02:59:57 +00:00
Mike Williams 1a023f5dd0 PCB Editor: (Auto)Route Selected (From Other End) 
3x Selection-Based Routing Tools. Takes a selection of routable objects
and routes them one at a time individually, with an attempted finish, or
from the other end, depending on the action given.
 2022-09-13 15:06:36 +00:00
Jeff Young 0a5ca5b485 Display crosshairs in picker tools. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10183
 2022-09-13 01:40:43 +01:00
Jeff Young c2643f53cf Tighter control over lambda capture. 2022-09-12 20:51:15 +01:00
Jeff Young eaccd40c75 Allow vias to connect <no net> tracks even when DRC checking is on. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12403
 2022-09-12 20:38:21 +01:00
Mike Williams 37d2addf0e Icons: add swap 2022-09-12 11:11:49 -04:00
Mike Williams f70e1d0f22 SCH/PCB: Set Swap hotkey to 'S' 
* Move Add Sheet to Shift+S in Schematic Editor
* Move Set Grid Origin to Shift+S in PCB Editor
 2022-09-12 11:11:49 -04:00
Mike Williams de6e368ac6 PCB: Swap Tool 2022-09-12 09:39:43 -04:00
Jeff Young 9cf3c529d3 Apply the same accuracy band to connectivity as we use for hittesting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-09-09 21:42:21 +01:00
Jeff Young 5b3bd9be83 Prune pasted data of non-enabled layers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11997
 2022-09-09 21:02:08 +01:00
Jeff Young 98e760da93 Coverity-suggested improvements. 2022-09-09 13:41:13 +01:00
Jeff Young 2743fd583f More improvements to drag tool selection disambiguation. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-09-08 23:43:07 +01:00
Jeff Young a619ef9d53 Improve drop-a-knee-selection-to-a-single-segment algorithm. 
In particular, don't rely on there being only two items in the
collector at the start.

Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-09-08 14:10:18 +01:00
jean-pierre charras 6b3d36b6c3 CONVERT_TOOL: also show the "Create From Selection" menu if a array can be created 
The "Create Array" sub-menu was recently moved to this menu, so it must me
shown as soon as an array can be created.
 2022-09-07 10:53:27 +02:00
Alex d67c81a657 When deselecting items, pick only selected ones. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10292
 2022-09-06 19:44:29 +00:00
jean-pierre charras 963a17f5b5 fix a compil warning 2022-09-05 18:33:17 +02:00
Jeff Young 895a8a8dbc Work around focus issues for status popups. 
Autoscroll wasn't working on Mac because the status popup's panel
has the focus.  This *may* also fix a problem on MSW of the auto-scroll
not being cancel-able.

Fixes https://gitlab.com/kicad/code/kicad/issues/11425
 2022-09-04 21:08:01 +01:00
Jeff Young efae2bbb4c Better feedback for netclass assignment patterns. 2022-09-03 21:33:56 +01:00
Jeff Young c30a557810 ADDED netclass assignment from PCB canvas. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5975
 2022-09-03 19:29:59 +01:00
Jeff Young 09773e3e2e Make sure dirty flag gets set, and leave save enabled regardless. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11824
 2022-09-01 14:27:16 +01:00
Jeff Young 9188838e50 RIP EDA_RECT. 2022-08-31 23:57:24 +01:00
Jeff Young b4492e0bd2 More EDA_RECE yeetage. 2022-08-31 17:19:50 +01:00
Jeff Young ebe9617e77 More EDA_RECT expungification, and an attempt to fix the python test. 2022-08-31 17:19:48 +01:00
Jeff Young 5679b9dbdc Remove a few EDA_RECT instances. 2022-08-31 01:22:49 +01:00
Jeff Young 0c8787cbb9 Some more wxPoint/EDA_RECT yeeting. 2022-08-31 00:44:33 +01:00
Seth Hillbrand b736460e71 Move optional access from value() to *operator 
`value()` throws.  Where we check for existence, we don't need to use
the throwing version and should just use the unprotected variant
 2022-08-30 13:59:39 -07:00
Mike Williams a176bf383e Properties: pick up single selections 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12302
 2022-08-30 13:59:37 -04:00
Seth Hillbrand 91fbb5c957 Don't prevent immediate actions while router active 
Immediate actions that can take place are useful.  We should only be
preventing immediate actions while actively routing or dragging

Fixes https://gitlab.com/kicad/code/kicad/issues/12311
 2022-08-30 10:31:29 -07:00
Jeff Young 63386ba64d Pointer safety for ERC/DRC dialogs. 
Also makes the "Edit ingored violations" easier to find.

Fixes https://gitlab.com/kicad/code/kicad/issues/12308
 2022-08-30 12:07:19 +01:00
Jeff Young 2d68cdff94 Better reporting of hole-to-hole clearances and clearance resolutions. 2022-08-29 17:37:49 +01:00
Jeff Young b886ec728e Copy shape data when converting PCB TEXTBOX to FP. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12298
 2022-08-28 21:34:13 +01:00
jean-pierre charras 3b4c5f0dc4 French translation update 2022-08-27 09:10:02 +02:00
Jeff Young 09511d176c Quiet Coverity. 2022-08-26 17:05:25 +01:00
Seth Hillbrand 06786c34d7 Blacklist hashes for 2d integer elements 
The hash table for integer hashes is extremely limited and places most
elements in the same buckets.  This leads to a linear search time for
structures built on this.

This blocks hashes, directing the coder to utilize std::set or std::map
structures instead of hash tables for implementing integer-based
lookups.
 2022-08-26 08:43:37 -07:00
Seth Hillbrand f1261e71d4 Replace boost::optional with std::optional 2022-08-25 15:50:47 -07:00
Seth Hillbrand fb74bdb059 Don't consider rule area zones in priority calc 2022-08-25 10:12:58 -07:00
Seth Hillbrand e661545ecf Choose the first unused priority value for zones 
Default the new zone priority value to the lowest available unused
priority.  Ensures that, by default, a new zone has a unique priority
level preventing zones from unintenionally shorting
 2022-08-25 10:05:30 -07:00
Seth Hillbrand 418df36790 Avoid teardrops in priority calculation 
When choosing a new priority value, don't look at teardrops (which have
high priority)
 2022-08-25 08:41:14 -07:00
Seth Hillbrand 3e4cfab254 Set new zone priority to unique number 
Previously new zones' priorities were all set to 0.  This is almost
always wrong and can lead to unintended conflicts.  The new zone default
value is now set to one higher than the largest number on the board.
This is a better default value because it will not conflict with
existing values.
 2022-08-24 16:37:57 -07:00
Jeff Young 1871812f2b Consolidate on a more widely used sub-type architecture. 2022-08-23 12:57:55 +01:00
Maciej Suminski f6f6ebd5f9 WIP: Properties GUI 2022-08-22 21:32:32 -04:00
Jeff Young 1e68c353f1 Account for groups in undo of Position Relative To. 
Also fixes a bug were pads weren't correctly being found for anchoring
the selection before the Position Relative To.

Fixes https://gitlab.com/kicad/code/kicad/issues/11793
 2022-08-22 22:33:38 +01:00
Alex 3a76d42630 Cross-probing/selection for multiple items (PCB -> SCH) 
Fixes https://gitlab.com/kicad/code/kicad/issues/10469
 2022-08-22 19:33:39 +00:00
Jeff Young 03454684fa Commenting. 2022-08-22 12:43:57 +01:00
Jeff Young 4f0136db3b Attempt to fix std::initializer_list lifetime issue. 2022-08-21 20:54:41 +01:00
Jeff Young 28f7221cc3 Allow selection of Footprint Checker markers. 
(And do a cross-probe to the Footprint Checker dialog.)
 2022-08-20 11:30:25 +01:00
Jeff Young aa2ad3b44c Move KICAD_T[] to std::initializer_list<KICAD_T>. 2022-08-20 10:28:11 +01:00
Jeff Young 46df421064 ADDED defined pad groups for net-tie footprints 
Each pad group is allowed to short nets with other pads in its group.

Legacy footprints with the "net tie" keyword hack will get a single
group auto-created with all the footprint's pads in it.

DRC and the router now allow a track to collide with copper graphic items
while entering a net-tie pad as long as the closest point in the collision
is within the pad.

DRC (and the footprint checker) now check for copper items in the
footprint shorting pads which are not in the same pad group.

Fixes https://gitlab.com/kicad/code/kicad/issues/2265
 2022-08-19 18:54:20 +01:00
jean-pierre charras a60053c800 selectAllItemsOnSheet(): fix a typo that prevent selection of items in root sheet. 2022-08-19 11:12:16 +02:00
jean-pierre charras e0fbe2542f Fix a few compil and Coverity warnings. 2022-08-19 10:53:29 +02:00
Mike Williams f06e28b7a7 PCB: Finish Route, Route From End 
Adds restart routing from other ratsnest' end and automatically finish
routing.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/5051
 2022-08-17 03:15:46 +00:00
Alex 371f6d917f Use VECTOR2I::extended_type instead of long, and int for numeric limits. 2022-08-16 12:08:55 +00:00
Alex 405be8d15f Bounds-awareness in Move, Rotate, point editor, drawing tool 2022-08-16 12:08:55 +00:00
Alex b81a3f0533 GetClampedCoords: Better usability for rounding 2022-08-16 12:08:55 +00:00
Alex 4d7d367b25 Use KiROUND for BBox calculation, change parameter name, block negative padding. 2022-08-16 12:08:55 +00:00
Seth Hillbrand 759e1a64ef Fix broken const ref in wildcard 2022-08-15 12:09:30 -07:00
Seth Hillbrand 35ac39844f Clean up some auto usage 
Don't make new copies of shared_ptr if we can use references.  Keep auto
usage down to hard-to-type-out sequences
 2022-08-15 11:29:45 -07:00
Jeff Young 1f347582f8 Introduce new marker type so we can track DRC errors on the drawing sheet. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12221
 2022-08-15 18:03:03 +01:00
Jeff Young a9536b5de9 CHANGED netclass assignments now done via canvas or via patterns. 2022-08-14 22:56:29 +01:00
Jeff Young d6cd55e133 ADDED esc-removes-net-highlight preference to PCBEditor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8760
 2022-08-09 08:46:12 +01:00
jean-pierre charras ea914eac9a Pcbnew: fix regression: Display board info when clicking on a empty place. 
Previously: the displayed info was "Selected Items 0".
 2022-08-05 13:49:01 +02:00
Jeff Young 96f01d33c8 Performance improvements. 
1) Move a bunch of std::map's to std::unordered_map to get constant-time
look-ups
2) Lengthen progress-reporting intervals to spend more time doing work
and less time talking about it
3) Reverse order of SHAPE_LINE_CHAINs in thermal intersection checks to
make (much) better use of bbox caches
4) Don't re-generate bboxes we already have
5) Fix some autos that weren't by reference (and were therefore copying
large datasets)
6) Rename delta progressDelta so it's easier to search for in future
7) Get rid of a few more autos (because I don't like them)
8) Pass large items to lambdas by reference

Fixes https://gitlab.com/kicad/code/kicad/issues/12130
 2022-08-03 11:59:42 +01:00
Jeff Young 43df863df2 Fix issue with caches not being initialized when printing msg bar. 2022-08-01 13:09:51 +01:00
Jeff Young 0304ad4494 Move connection width testing to rule system. 
Also copies connection width progress reporting architecture over to
the sliver checker.
 2022-08-01 13:09:51 +01:00
Jeff Young 927bc8141b Init member variables. 2022-08-01 13:09:51 +01:00
Jeff Young 54213bb7f1 Cleanup and move to DRC_ENGINE's status reporter. 
1) brace formatting
2) get rid of some autos
3) get rid of a dyn_cast that CLion claims is bad
4) use DRC_ENGINE's status reporter
 2022-08-01 13:09:51 +01:00
Jeff Young 6f49b57f9b Cleanup & performance enhancements. 2022-08-01 13:09:51 +01:00
Marek Roszko a8505d9c76 SEARCH_RESULT -> INSPECT_RESULT 
To fix the name squatting it's doing for future functionality
 2022-07-29 20:01:10 -04:00
Jeff Young f0b9e67212 Add ignore-line-widths mode to CONVERT_TOOL. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5911
 2022-07-29 21:39:03 +01:00
Jeff Young fc1afa6298 Improvements to convert tool. 
1) Handle filled shapes
2) If a chained outline can't be found, build hulls of the individual
segments
3) Combine intersecting shapes
4) Simplify code

Fixes https://gitlab.com/kicad/code/kicad/issues/git

Fixes https://gitlab.com/kicad/code/kicad/issues/5911
 2022-07-27 18:57:45 +01:00
Jeff Young 2bf33321d1 Update constraint mode in status bar during move. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10465
 2022-07-27 18:57:45 +01:00
jean-pierre charras aabc3b3cc6 FP editor: fix crash when duplicating a footprint. 
Fixes #12098
https://gitlab.com/kicad/code/kicad/issues/12098
 2022-07-27 19:08:27 +02:00
Jeff Young cb6a2552d9 Use the FPEditor's status bar messages for FPBrowser. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11404
 2022-07-26 18:45:02 +01:00
jean-pierre charras 4d48376eae Fix some warnings detected by PVS-STUDIO (not used vars) 2022-07-26 16:00:14 +02:00
Jeff Young 1bad72f14f Remove bad static_cast. 
(m_settings isn't a PCBNEW_SETTINGS in non-PCB_EDIT_FRAMEs)
 2022-07-24 23:41:41 +01:00
jean-pierre charras c16d0603c6 Add fix missing in my commit 8eee7667 2022-07-24 09:10:51 +02:00
jean-pierre charras 8eee766791 Fix Cvpcb DISPLAY_FOOTPRINTS_FRAME: some display options not working. Commit 5e4a7041 moved 4 settings used in Cvpcb to a PCBNEW_SETTINGS struct. But in Cvpcb, this config struct does not exist. So these 4 settings are now moved to a section (PCB_VIEWERS_SETTINGS_BASE) common to Cvpcb and Pcbnew config. 2022-07-23 18:45:13 +02:00
Jeff Young 9dd3bbf2cb Change highlight net hotkey default. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12051
 2022-07-23 12:34:48 +01:00
Jeff Young f41af10007 Clean up hole shapes for safety (smart pointer) and consistency. 2022-07-22 23:06:07 +01:00
Jeff Young 5442d284f4 Improve strings for highlight net commands. 2022-07-22 09:31:11 +01:00
Jeff Young def87c969e Redo the pinned-libraries storage architecture. 
1) always use preferences directly
2) allow nicknames from either preferences or project
3) store-after-modify

Fixes https://gitlab.com/kicad/code/kicad/issues/12000

Fixes https://gitlab.com/kicad/code/kicad/issues/11892
 2022-07-22 09:31:10 +01:00
Jeff Young b80fd5329d Clear dimension pointer after committing. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11864
 2022-07-22 09:31:09 +01:00
Jeff Young 004abcd370 Leave originally selected items selected after cancelled move. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12024
 2022-07-22 09:31:08 +01:00
Seth Hillbrand 16e3d40552 ADDED: Display calculated clearance in status bar 
In addition to showing resolved clearance, we also show the calculated
clearance in the same method as is used for DRC.  This will allow users
to better examine their system while working.

Fixes https://gitlab.com/kicad/code/kicad/issues/7934
 2022-07-21 15:44:48 -07:00
jean-pierre charras 49bf717c0e fix minor compil warnings 2022-07-17 20:29:59 +02:00
Jeff Young 2de10080cd Add edge and margin clearances to message panel. 2022-07-15 16:14:32 +01:00
Jeff Young c98826c8b0 Open newly-pasted footprint on canvas of Footprint Editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11398
 2022-07-15 14:13:39 +01:00
Mike Williams 99f8b21ed1 PCB: Add bitmap layer per board layer 2022-07-14 11:23:23 +00:00
Mike Williams 3669cb4673 PCB Editor: Add User Background Images 2022-07-14 11:23:23 +00:00
Seth Hillbrand b5bf1da251 Keep track of blocking windows 
Allows the calling KiWAY player to send messages to the blocking window
before signaling a separate call

Fixes https://gitlab.com/kicad/code/kicad/issues/11891

Fixes https://gitlab.com/kicad/code/kicad/issues/11772
 2022-07-13 19:25:24 -07:00
Seth Hillbrand 20a372ff69 ADDED Clearance data in PCB editor status bar 
When selecting two objects, display the resolved clearance and
(optionally) hole clearance in the status bar
 2022-07-13 15:04:32 -07:00
Seth Hillbrand e87ba10a5a Enforce group selection to abide by L/R behavior 
When selecting greedy (right to left), selecting any part of the group
will get the whole group.  When selecting left to right, we must select
all items in the group to get the grouped items unless we are in the
group itself

Fixes https://gitlab.com/kicad/code/kicad/issues/11902
 2022-07-12 11:01:34 -07:00
Jeff Young 57acce9e55 Share more code between selection tools. 2022-07-11 19:04:08 -06:00
Alex aaf99eb0cc Performance optimizations. 2022-07-11 21:25:12 +00:00
Jeff Young 19b4844102 Avoid OSX system shortcut. 
CHANGED toggle net highlight from ctrl-` to opt-`.

Fixes https://gitlab.com/kicad/code/kicad/issues/10160
 2022-07-10 20:20:22 -06:00
Jeff Young e122dc38bd Add context menu item for clearing net highlighting. 
In selection tools, drawing tools, router tool, line_wire_bus tool.

Fixes https://gitlab.com/kicad/code/kicad/issues/11920
 2022-07-10 17:15:20 -06:00
Jeff Young 654740b90d Add newly-drawn objects to any entered group. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11912
 2022-07-08 17:27:05 -06:00
Jeff Young 8a9bf02b7e Smarten up silk clearance & tented item handling. 
The inspection tool will report whether or not the item is tented
(indicating in that case that any clearance will only be applied
to any hole).

The DRC test ignores tented items without a hole, and runs the
clearance test against the hole for items with a hole.

Fixes https://gitlab.com/kicad/code/kicad/issues/11954

Fixes https://gitlab.com/kicad/code/kicad/issues/11951
 2022-07-08 17:27:05 -06:00
Seth Hillbrand 0c47a09517 Ensure rectangles are normalized 
Normalize on creation and fixup rectangles previously saved with
inverted coordinates

Fixes https://gitlab.com/kicad/code/kicad/issues/11965
 2022-07-07 10:40:18 -07:00
jean-pierre charras 7b28804f67 Fix a minor compil and Coverity warning 2022-07-06 13:54:17 +02:00
jean-pierre charras f00de04336 FP editor: fix incorrect mirroring of zones in footprint. 
This is due to a call to Mirror() with incorrect parameter.
Unfortunately, depending on FP items, one Mirror parameter has the opposite
meaning about mirror axis.
Fixes #11952
https://gitlab.com/kicad/code/kicad/issues/11952
 2022-07-04 11:14:47 +02:00
Seth Hillbrand cde30d3dba Clarify cross-probing options 
Previous the cross-probing options were mixed between sending and
receiving cross-probe events.  This clarifies so that all of the pcbnew
cross-probe options deal with whether the cross-probe is seen in pcbnew
and all of the eeschema options deal with seeing the event in eeschema.

Also updates the wording in the options panels to be the same where
possible and adds tooltips

Fixes https://gitlab.com/kicad/code/kicad/issues/11454
 2022-07-01 16:47:09 -07:00
luz paz af6ba1a16e Fix typos in pcbnew sub-directory 
Found via `codespell -q 3 -S *.po,./thirdparty,./Documentation/changelogs -L aactual,acount,aline,alocation,alog,anormal,anumber,aother,apoints,aparent,aray,ba,busses,dout,einstance,leaded,modul,ontext,ot,overide,serie,te,,tesselate,tesselator,tht`
 2022-06-30 09:39:45 -04:00
Mike Williams 64b89639cf PCB Editor: Make Ctrl-Click net highlighting configurable 
Defaults to ctrl-click is exclusive or selection like other
applications. Footprint editor can only be exclusive or.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10810
 2022-06-28 16:29:14 +00:00
Jeff Young ab9c42d427 Fix a typo which leads to a bogus type-cast. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11886
 2022-06-27 23:07:06 -06:00
Jeff Young 23e8bafd9c Don't run courtyard conflicts in footprint editor. 2022-06-20 22:25:39 +01:00
Jeff Young 298edb09c3 Initialize TEXT_ATTRIBUTES justifications for text & textboxes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11805
 2022-06-20 17:03:37 +01:00
Jeff Young 73836b50fc Add proper collision test to via placer. 
Also moves DISALLOW constraint processing outside the loop as it
performs it's own loop over any objects referenced by the rules.

Fixes https://gitlab.com/kicad/code/kicad/issues/11832
 2022-06-19 21:57:49 +01:00
Jeff Young 5da817649b Fix nullptr bug. 2022-06-18 13:04:06 +01:00
Jeff Young 97b0005780 More caching for DRC. 
Also fixes a bug where some physical clearance tests would be run even
if the clearance was 0 (or if the rule was set to IGNORE).
 2022-06-17 23:58:31 +01:00
Jeff Young d40664d171 Handle double-click in dimension drawing tool. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11815
 2022-06-15 18:07:50 +01:00
Marek Roszko 87f10ea206 Split off the netlist export content helper but it's advancedcfg 2022-06-11 23:09:47 -04:00
Jeff Young 9b70308f5c Nullptr defensive code. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11690
 2022-06-11 22:32:12 +01:00
Jeff Young d31bd4ea3e Use default text properties for textboxes. 
Also make sure text is mirrored when placed on back of board.

Fixes https://gitlab.com/kicad/code/kicad/issues/11739
 2022-06-03 18:48:09 +01:00
Jeff Young bd51b33f65 Clear point editor before recombining pad. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11731
 2022-06-02 15:55:35 +01:00
Jeff Young de12c63de6 Repair point editing of rotated text boxes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11432
 2022-06-02 10:42:57 +01:00
Jeff Young f8829de5ea Formatting. 2022-06-02 10:42:57 +01:00
Jeff Young 155620cc9a Move H/V/45 mode from zone properties to toolbar. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8587
 2022-05-29 21:30:15 +01:00
Jeff Young 1fb7532859 Prepare for a more uniform implementation of H/V/45 mode. 2022-05-29 21:30:14 +01:00
Mike Williams 21a7e050ab REMOVED: PCB Editor Layer Alignment Target 
No longer used by modern PCB processes.

Only the code to add the target to the board has been removed. Parsing
code for existing designs with targets is left in place.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10006
 2022-05-26 08:47:02 -04:00
Jeff Young f7fcc310f8 Select next/prev copper layer whether we start on copper or not. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11600
 2022-05-20 15:59:29 +01:00
jean-pierre charras a09bd4ae12 Fix a bug in commit 57e59a49 2022-05-20 15:08:50 +02:00
jean-pierre charras 57e59a4959 Pcbnew, on line DRC when moving footprints: add visible collisions between courtyards 2022-05-20 12:58:05 +02:00
Jeff Young 23fb4c7433 Uniformly use a single facility for location-less prime events. 
Also implements a uniform mechanism for avoiding auto-scroll after
a prime event or dialog which results in a mouse position at the
edge of the canvas.

Fixes https://gitlab.com/kicad/code/kicad/issues/11057
 2022-05-16 23:43:00 +01:00
Jeff Young f2fc78f380 Don't copy modifiers to prime events. 
The modifiers go with the hotkey, not with the action.

Fixes https://gitlab.com/kicad/code/kicad/issues/11618
 2022-05-16 13:51:40 +01:00
Jeff Young 37838dffb9 Make sure physical_clearance rules are run against courtyard layers. 2022-05-10 23:02:53 +01:00
Jeff Young 30ecca464d Rename mechanical_clearance -> physical_clearance. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11554
 2022-05-06 15:54:46 +01:00
Jeff Young 5d0d2201f3 Improve clearance report messages. 
Removes some duplicated terms; puts in some more headers to make
visual parsing easier, and makes non-connected-pads report the correct
data.

Also fixes a bug where zone-connection overrides of none weren't getting
handled correctly.

Fixes https://gitlab.com/kicad/code/kicad/issues/11544
 2022-05-03 16:30:04 +01:00
Jeff Young 5f10c15a87 Fix zone merge intersection algorithm. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11492
 2022-04-29 22:17:53 +01:00
Jeff Young f5d612eaed Switch <insert> replacement on OSX to <f1>. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11413
 2022-04-25 10:01:33 +01:00
Jeff Young 90bfe2d94b Remove Save Copy As from fp editor, and rename to Save a Copy elsewhere. 
It's still used by Eeschema and PCBNew when not in stand-alone mode.

Fixes https://gitlab.com/kicad/code/kicad/issues/9185
 2022-04-24 19:46:57 +01:00
Jeff Young f0dab2e07b Fix some layer handling issues. 2022-04-23 21:29:46 +01:00
Jeff Young c6f83b6dec ADDED Duplicate Footprint, Rename Symbol and Rename Footprint. 2022-04-22 22:06:51 +01:00
Mike Williams b42365190e Schematic/PCB: deleting fields sets them to invisible 2022-04-21 16:20:23 +00:00
jean-pierre charras 26370583fa French translation update and fix a typo. 2022-04-18 11:25:51 +02:00
Jeff Young 71c2cb3180 ADDED revert for pcbnew and eeschema. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6802
 2022-04-17 20:02:58 +01:00
Jeff Young 9ff1ae5bdc Better inspection reporting for netclasses, custom rules and DRC. 2022-04-17 00:33:56 +01:00
Jeff Young 7f3a75bccd Add a bunch more inspections for rule resolution. 2022-04-15 22:10:13 +01:00
Jeff Young c78a47c3fb Remove extra test. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10364

Fixes https://gitlab.com/kicad/code/kicad/issues/10364
 2022-04-14 17:09:27 +01:00
Jeff Young a49bb792bd Insert chevrons when placing vias near tracks. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10898
 2022-04-11 16:26:36 +01:00
Jeff Young 29eb5931c2 Be more careful with forced cursor positions. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9977
 2022-04-10 23:14:57 +01:00
Jeff Young c17b90c8dc Run pinning on sides as well as corners. 
Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the
upside-down coordinate system.

Fixes https://gitlab.com/kicad/code/kicad/issues/11339
 2022-04-07 11:51:58 +01:00
Seth Hillbrand 9fcc641808 Don't set the dirty bit when running DRC 
Dirty bit is set in the zone filler separately, there is no action in
the DRC that needs to be saved

Fixes https://gitlab.com/kicad/code/kicad/issues/11344

(cherry picked from commit 821fe6ea42)
 2022-04-06 17:05:19 -07:00
Jeff Young f272056f20 Fix assert. 2022-04-04 20:43:08 +01:00
Jeff Young 7f7910d922 Dirty text caches in pcb point editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11319
 2022-04-04 17:39:58 +01:00
Seth Hillbrand 737d65fd36 Skip zero-size elements when converting 
Also fixes an assertion when converting to polygon from the board editor

Fixes https://gitlab.com/kicad/code/kicad/issues/11313

(cherry picked from commit 6706a5c462)
 2022-04-01 13:24:10 -07:00
Jeff Young d174af4006 Handle textboxes moving back to RECT shape (ie: cardinal rotation). 2022-04-01 16:12:23 +01:00
Jeff Young a35ae8cdce Don't re-fetch selection when running select-in-same-sheet. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11110
 2022-03-28 21:54:24 +01:00
Mike Williams e51ab86225 Schematic Drag: fixes and improvements 
Fixes:
* Various special cases around junctions on pins and dragging.

* Some rotations of endpoints resulting in a 45 degree rotate.

* Some cases where it was possible to get a line with neither
  endpoint selected, and also substractive unselecting only one of two
  selected endpoints unselecting both.

* Use line midpoint for sorting.  Start and endpoints aren't
  consistent in the order they appear on the X or Y axis. So,
  we need to use the midpoint for our position for consistent
  sorting when dragging groups of parallel lines where some
  have the start and end reversed.

Other:
* Rename TEMP_SELECTED TO SELECTED_BY_DRAG. This is the actual meaning
  of the flag, and should reduce confusion as
  to when it should be used.

* Move usage of TEMP_SELECTED as an algorithmic mark to CANDIDATE
  instead.

* Fix mistaken clearing of START_POINT and ENDPOINT.

* Move endpoint setting and clearing out of narrowSelection, and into
  selectPoint and selectMultiple.

* Don't show dangling end warnings on new lines
 2022-03-28 16:02:48 -04:00
Jeff Young 343b2681d4 Midpoints for eeschema rectangles and text boxes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10362
 2022-03-28 11:16:39 +01:00
Wayne Stambaugh 7da7864f5e Fix some Coverity issues. 2022-03-25 15:51:05 -04:00
Wayne Stambaugh 7b2d9dfc0c Fix some Coverity uninitialized scalar variable issues. 2022-03-24 13:17:07 -04:00
Jeff Young cf611f1742 Better safety around layersets. 2022-03-21 18:19:00 +00:00
Jeff Young 4f62960334 Update message panel from PCB point editor and SCH drawing tools. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11186
 2022-03-21 10:32:36 +00:00
Jeff Young fa5a484797 Remove unused variable. 2022-03-16 14:56:32 +00:00
Jeff Young 06c1bccccd Exclude hidden text from selection in FP Editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11111
 2022-03-12 23:29:01 +00:00
Fabien Corona d452f79860 pcbnew: search for nets 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10601
 2022-03-10 23:12:30 +00:00
Seth Hillbrand b5c2f0d39a Remove the open array in favor of std containers 
The containers allow iteration, size knowledge and lower bug surface
 2022-03-03 16:03:26 -08:00
Jeff Young ec5b7a57ec Consistency in via dimensions terminology. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11024
 2022-03-03 22:40:18 +00:00
Seth Hillbrand 2fafa55647 Maintain width of converted tracks 2022-03-02 10:45:53 -08:00
Seth Hillbrand 7e836ae27a Select the copper layer before processing 
If we are converting to tracks, the copper layer needs to be selected
before any other elements are processed, otherwise, we end up with the
default undefined layer

Fixes https://gitlab.com/kicad/code/kicad/issues/11025

(cherry picked from commit 9396735733)
 2022-03-02 10:41:44 -08:00
Jeff Young 1966972fc1 Retire no-pads warning in favour of defaulting to area-based remove islands strategy. 2022-03-01 19:19:18 +00:00
Jeff Young 843a56c4e4 Implement two-staged zone priority: assigned priority followed by UUID. 2022-03-01 14:53:35 +00:00
Jeff Young a4a3f6ff74 Fix zone/connectivity deadlock. 2022-03-01 12:02:17 +00:00
Seth Hillbrand fab78af176 Remove TEDIT 
This marker is not used in KiCad and creates merge conflicts when two
different users edit the same file
 2022-03-01 00:25:44 +00:00
Jeff Young 58b8d63ff8 Draw boundary based on first zone layer. 2022-02-28 21:40:36 +00:00
Jeff Young d299ddbc7e Cleanup. 2022-02-27 12:05:39 +00:00
Jeff Young ae85f57577 Drop a knee between tracks to a single item when dragging. 
This prevents the disambiguation menu from coming up when we don't
really care which element we start the drag on.

Fixes https://gitlab.com/kicad/code/kicad/issues/10745
 2022-02-26 22:54:23 +00:00
Jeff Young 89c14f01f7 Repair algorithm to avoid slow movement issue. 
This goes back to the previous code for this one part.

Fixes https://gitlab.com/kicad/code/kicad/issues/10976
 2022-02-26 15:58:44 +00:00
Seth Hillbrand 535ea800c0 Honor modifier keys in diambiguation 
Needs to be reset for the new action before selecting elements at a
point.

Fixes https://gitlab.com/kicad/code/kicad/issues/9712

(cherry picked from commit a30ad0b54a)
 2022-02-25 16:16:15 -08:00
Seth Hillbrand 283aaff2df Use board polygon instead of bbox for size 
Board BBox uses the visible size of the board, which includes edge cut
thickness.  This is not appropriate for the Board characteristics.
Using the outline polygon gives accurate results and falls back to a
bounding box in the case where the outline is invalid

Fixes https://gitlab.com/kicad/code/kicad/issues/10972

(cherry picked from commit 54f621c570)
 2022-02-25 11:14:54 -08:00
jean-pierre charras a7b8a1446b fix minor compil warnings. 2022-02-25 14:26:37 +01:00
Jeff Young bc51c89c90 Reconcile zone-auto-fill with undo. 2022-02-25 13:05:49 +00:00
Jeff Young 5c54f40eae Layer visibilities aren't stored in project for footprint editor. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10953
 2022-02-25 00:08:49 +00:00
Jeff Young d65f9ad2d8 Implement multi-layer stitching via logic. 2022-02-24 21:32:43 +00:00
Jeff Young 369f53bb19 Better DRC checking when placing vias. 2022-02-24 21:32:43 +00:00
Jeff Young b7be42375d Add an infobar warning when trying to fill a zone which is not connected. 2022-02-24 21:32:43 +00:00
Jeff Young d465eb6425 ADDED: automatic zone refilling. 
This is for the out-of-box experience for novice users.  It is presumed
that folks with larger more complicated boards will turn it off.

Fixes https://gitlab.com/kicad/code/kicad/issues/6413
 2022-02-24 18:16:45 +00:00
Jeff Young f076d07e9e Fix asserts. 2022-02-24 18:16:45 +00:00
Jeff Young 41f6e634c6 Partially integrate grid snapping with constraints. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10941
 2022-02-22 22:19:55 +00:00
Jeff Young df3291c59d Fix nullptr error (no router tool in footprint editor). 2022-02-20 16:56:53 +00:00
Jeff Young f18aae679c Use router to update message panel when routing. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10068
 2022-02-20 16:50:30 +00:00
Jeff Young 85805b95ba Cancel or commit pad edit mode when switching footprints. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10209
 2022-02-19 19:36:19 +00:00
Jeff Young 5efa354f0f Add asserts to flush out incorrect uses of GetLayer(). 2022-02-18 12:14:38 +00:00
Jeff Young 662fb40605 Slightly cleaner impl. 2022-02-17 12:48:29 +00:00
jean-pierre charras 5a9fb08778 zone_filler_tool: fix crash due to a null pointer use in zone filler. 
Fixes #10875
https://gitlab.com/kicad/code/kicad/issues/10875
 2022-02-17 09:21:14 +01:00
Jeff Young b1bd8421e0 Performance: remove associated triangle sets when removing outline. 
This saves us having to re-triangulate at the end of zone filling.
 2022-02-16 17:00:54 +00:00
Jeff Young 5c9e718407 Performance enhancements for connectivity. 
1) Generate SHAPE_POLY_SET triangulation by outline so they can be
shared between connectivity system and other clients.
2) Don't add items to connectivity when reading board; we're going
to do a total rebuild anyway.
3) Use multithreading when caching triangulation.
 2022-02-15 12:20:34 +00:00
Jeff Young 98b9c6e2a1 Better progress reporting and a slight performance boost on commit. 2022-02-15 12:20:34 +00:00
Jeff Young d2de114d21 More performance optimizations. 2022-02-15 12:20:34 +00:00
jean-pierre charras 876061369b Fix some Pcbnew crashes due to null pointers 2022-02-14 13:46:05 +01:00
Jeff Young a2ca8cf413 Improve SNR. 2022-02-12 18:38:11 +00:00
Jeff Young 00934fdd84 Move GUI queries in PLUGIN to a callback. 
Also makes sure legacy zone fills get deleted and re-filled (since
just dropping the outline will change them).
 2022-02-11 22:09:22 +00:00
dsa-t 68655540eb Clamp cursor to limits of coordinates representation 
Also improves large distance handling.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8846
 2022-02-11 16:42:52 +00:00
Jeff Young 50a4d610a6 Be cognizant of flashed layers when generating pad shapes. 2022-02-11 13:10:52 +00:00
Seth Hillbrand 51d7b49067 Don't halt expansion on zero-length 
We avoid counting endpoints for tracks that have no length
 2022-02-07 13:53:42 -08:00