6f818f4c2e
Editing support for sheet-pin fonts, text styles and text colors.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11300
2022-04-01 19:26:27 +01:00
5d9668938b
SYMBOL_EDITOR_CONTROL::DuplicateSymbol(): fix incorrect validation test.
...
DuplicateSymbol() is called both to duplicate and paste. Only duplicate
needs a test to know if a symbol is selected.
Fixes #11053
https://gitlab.com/kicad/code/kicad/issues/11053
2022-04-01 10:42:20 +02:00
49c48e2fe0
Consistently handle env/prj variables
...
User-defined variables cannot be used for internally-reserved variables
Fixes https://gitlab.com/kicad/code/kicad/issues/11232
(cherry picked from commit c23679d9bd
2022-03-31 17:05:53 -07:00
6b99a937d8
Look for sheet pins inside sheets.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11297
2022-03-31 22:10:45 +01:00
1a9ef4bd0f
Add support for using a SpaceMouse to pan & zoom in the schematic editor.
2022-03-31 19:03:41 +00:00
e8a543f1ea
Colors for text in PL_Editor and Eeschema.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/1952
2022-03-31 19:43:56 +01:00
748cc1a59a
Pay better attention to aPlotter->GetColorMode().
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11287
2022-03-30 20:38:24 +01:00
7c21a0bdd4
Dirty text render caches in point editor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11284
2022-03-30 16:32:23 +01:00
5c7b022f40
Be more pedantic about setting GAL line width.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11280
2022-03-30 16:32:23 +01:00
91ea0903d0
Add infobars for individual-item-color-overrides.
2022-03-29 20:41:03 +01:00
8dc680adbb
Implement align-to-grid for sheets.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11201
2022-03-29 19:31:02 +01:00
719874fe9c
Thread the connectivity vector updates
...
Now that we are dealing with individual connection elements that do not
update their connected elements as well, we can thread the update, just
being careful to guard any remaining updates (bus_enty/busLine) that
need reciprocal updating
Fixes https://gitlab.com/kicad/code/kicad/issues/10974
(cherry picked from commit 6a53e318e5
2022-03-28 15:36:55 -07:00
6a33bcdc78
Avoid generating SCH_CONNECTION if not needed
...
If the SCH_ITEM has already been processed, the extra time needed to
iterated over the memberset and get the SCH_CONNECTION when we won't use
it is not neccesary.
Fixes https://gitlab.com/kicad/code/kicad/issues/10974
(cherry picked from commit 776a28a10e
2022-03-28 15:36:55 -07:00
41f7354b7a
Handle connection vector inline
...
Normally, you will gain by resursing a nested loop only over the
pairs that are not already handled. In this case, however, you lose
time because you step outside of the cache by adding the reciprocal test
at each step.
Instead, we process one element at a time, keeping it cached and loop
over all other elements to add to the connection. This saves us about
75% of the time for larger loops (e.g. stacked power pins on a large
BGA)
Fixes https://gitlab.com/kicad/code/kicad/issues/10974
(cherry picked from commit 3a98eacdb9
2022-03-28 15:36:55 -07:00
09ba7468ae
A better is-modified test.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10791
2022-03-28 21:54:24 +01:00
4ee6f9e138
Make sure setting the cursor gets put into the right tool context.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10141
2022-03-28 21:54:24 +01:00
8706bea3c6
Fix renamed flag
...
Snuck in between MR reviews
2022-03-28 13:50:44 -07:00
2a726a882f
Schematic: new feature, force 45 degree lines
...
* New modes to force 45 deg angle at beginning or end of line
* Backspace will undo most recent segment added
* / will toggle posture of 90 and 45 degree lines
* Added alg::signbit for convenience
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10869
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9175
2022-03-28 16:07:23 -04:00
e51ab86225
Schematic Drag: fixes and improvements
...
Fixes:
* Various special cases around junctions on pins and dragging.
* Some rotations of endpoints resulting in a 45 degree rotate.
* Some cases where it was possible to get a line with neither
endpoint selected, and also substractive unselecting only one of two
selected endpoints unselecting both.
* Use line midpoint for sorting. Start and endpoints aren't
consistent in the order they appear on the X or Y axis. So,
we need to use the midpoint for our position for consistent
sorting when dragging groups of parallel lines where some
have the start and end reversed.
Other:
* Rename TEMP_SELECTED TO SELECTED_BY_DRAG. This is the actual meaning
of the flag, and should reduce confusion as
to when it should be used.
* Move usage of TEMP_SELECTED as an algorithmic mark to CANDIDATE
instead.
* Fix mistaken clearing of START_POINT and ENDPOINT.
* Move endpoint setting and clearing out of narrowSelection, and into
selectPoint and selectMultiple.
* Don't show dangling end warnings on new lines
2022-03-28 16:02:48 -04:00
47f4503564
SCH textboxes start/end -> at/size.
...
The at token can handle an angle; start/end does not.
Fixes https://gitlab.com/kicad/code/kicad/issues/11252
2022-03-28 11:16:39 +01:00
343b2681d4
Midpoints for eeschema rectangles and text boxes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10362
2022-03-28 11:16:39 +01:00
265ff90e19
Use selection highlight color for sel shadows even when brightened.
...
This allows Find & Change to show both matches and current match.
Fixes https://gitlab.com/kicad/code/kicad/issues/11101
2022-03-28 11:16:39 +01:00
cfe0003ca4
Eeschema: fix misplaced nullptr test that prevent saving SCH_TEXT items.
...
Fixes #11250
https://gitlab.com/kicad/code/kicad/issues/11250
2022-03-27 18:48:55 +02:00
38bd612c01
sch_sexpr_parser.cpp: allows reading a polyline descr with more than 2 points
...
In symbols, a polyline descr is already a true polyline / polygon descr.
In schematic, a polyline descr was restricted to only 2 points (a line).
A true polyline / polygon descr is now allowed in schematic that support already
polygons.
For compatibility reason, a 2 points polygon (SCH_SHAPE) is converted to a SCH_LINE.
2022-03-27 10:31:21 +02:00
48dd810cd1
ADDED grouping of selected pins in Pin Table.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4956
2022-03-26 21:07:10 +00:00
a54457386c
Enable immediate mode for pin tool.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10156
2022-03-26 21:07:10 +00:00
53ccd8bd67
eeschema,sim: refactor NETLIST_EXPORTER_PSPICE_SIM creation
2022-03-26 15:50:15 +00:00
9a342458fa
Fix a few Coverity and compil warnings.
2022-03-26 16:21:23 +01:00
0652c7b429
More visible Synchronized Pins Mode informatics.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10340
2022-03-26 15:16:08 +00:00
1c158a4ea4
Use a standard HTML reporter for Symbol Checker.
2022-03-26 14:22:31 +00:00
d5533e7999
ADDED unit-filtering for pin table.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9382
2022-03-26 11:53:48 +00:00
e6c2b12ddf
ADDED allow pin conversion to be edited in Pin Table.
...
Added a De Morgan column.
2022-03-26 11:53:48 +00:00
2681ad6cfc
Don't rely on HasConversion() for Symbol Properties in Symbol Editor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11200
2022-03-26 11:53:48 +00:00
7da7864f5e
Fix some Coverity issues.
2022-03-25 15:51:05 -04:00
c686105afc
Correctly order swap test
...
MapAngles() will modify parameters and C++ does not guarantee LTR
evaluation, so we need to separate the calls into the proper order
before comparing the returns
Fixes https://gitlab.com/kicad/code/kicad/issues/11135
2022-03-24 09:23:50 -07:00
92a229eec7
ADDED separate user-defined color for page limits.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5271
2022-03-24 14:11:41 +00:00
b87fc45e33
Fix broken symbol field table editor dialog.
...
Do not use the symbol field string to populate the value and footprint
grid cells. The field strings may be empty because the symbol has not
been instantiated yet by entering a sheet. This fix makes an incorrect
assumption that the first instance value and footprint data in the symbol
is the same for all instances.
Note: this fix is incomplete because the value and footprint fields are
can now be different between sheet instances. The entire field
table editor design will need to be rethought because the current
grouping doesn't allow different value and footprint instance
changes.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11194
2022-03-23 11:46:49 -04:00
535ecb9b7b
Don't leave dangling pointers to old document when importing.
...
This goes for both selection pointers and undo/redo pointers.
Fixes https://gitlab.com/kicad/code/kicad/issues/10145
2022-03-22 18:08:05 +00:00
8eb10c41d8
Name any unnamed fields so they don't clobber each other.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10039
2022-03-22 18:08:05 +00:00
21144481d2
PLOTTER: do not clamp coordinates to an arbitrary value.
...
Previously, coordinates were clamped to +- 60 inches. It makes no sense to
clamp them at plotter level: max cooed depends on the editor (schematic/board...)
Rename MAX_PAGE_SIZE_MILS to MAX_PAGE_SIZE_EESCHEMA_MILS and use it only for Eeschema.
Fixes #11196
https://gitlab.com/kicad/code/kicad/issues/11196
2022-03-22 10:32:36 +01:00
e336a0e403
Improve sheet schematic import messages and simplify code.
...
There was also a logic bug when the selected schematic was in a different
path than the current project and was already part of the current project.
The symbol library table reconciliation code was still run which was wrong.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11075
2022-03-21 17:09:49 -04:00
2fed8aa4b8
eeschema: Add sync functions to SPICE_SIMULATOR
...
SPICE simulator can be called also during IBIS model determination,
and in the future in ERC. Therefore a necessity arises to implement
exclusive access.
2022-03-21 19:10:08 +00:00
e77a71bf7a
Fix typo found in code review.
2022-03-21 10:32:36 +00:00
4f62960334
Update message panel from PCB point editor and SCH drawing tools.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11186
2022-03-21 10:32:36 +00:00
58c146a7c0
ADDED ki_description and ki_keywords to footprint properties.
...
Also a bunch of wxT().
Fixes https://gitlab.com/kicad/code/kicad/issues/7783
2022-03-19 23:16:56 +00:00
cc165129fd
Special case undo for items with instance data.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11102
2022-03-19 19:37:01 +00:00
63b5ad7df1
Fix some issues with global-label fields' bounding boxes.
2022-03-19 19:37:01 +00:00
2bba277c5e
Unit binder: fix hang and DIALOG_WIRE_BUS_PROPERTIES: fix uninitialized variable.
...
The hang can be Windows specific.
2022-03-19 10:22:41 +01:00
7b82c2ba85
Preload eeschema find with selection when appropriate.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11148
2022-03-18 23:31:30 +00:00
41c0009c51
Off-grid ERC warnings.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10379
2022-03-17 20:23:56 +00:00
77c52ad5df
Fix a compil warning (shadowed var).
2022-03-17 20:13:17 +01:00
400cff994d
Update value & footprint from clipboard whether keeping annotation or not.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11116
2022-03-17 18:19:13 +00:00
deb7a0beff
Avoid marking symbols that will not be processed
...
We want to shorting the processing time by marking symbols that have
already been processed. But we must avoid marking symbols that will not
be processed due to their other flags
Fixes https://gitlab.com/kicad/code/kicad/issues/11164
(cherry picked from commit 2208e0db16
2022-03-17 10:10:56 -07:00
05bca282f7
Re-entrancy blocker for line/wire/bus tool.
...
Also clear infobar messages after a cancelInteractive.
Fixes https://gitlab.com/kicad/code/kicad/issues/11155
2022-03-17 15:27:33 +00:00
e68e2e973e
Separate Line Properties dialog from Bus/Wire, and handle Junctions in Bus/Wire.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9979
2022-03-16 14:56:32 +00:00
1434988bf8
Formatting.
2022-03-16 14:56:32 +00:00
c16090cc42
Improve sheet schematic import from different project message.
...
https://gitlab.com/kicad/code/kicad/-/issues/11075
2022-03-15 18:16:56 -04:00
1f5ec30566
Fix and issue about 180 deg arcs in symbols from "old" libraries.
...
Can be seen with lib version 20201005, not with latest version.
The fix is similar to commit 8a17fb8dFixes #11130
https://gitlab.com/kicad/code/kicad/issues/11130
2022-03-15 11:31:58 +01:00
2cb719f0cf
Fix crash in SCH_LABEL_BASE::IsType() when the item is not living in a schematic.
...
It happens for instance when copying the item from the clipboard.
Fixes #11128
https://gitlab.com/kicad/code/kicad/issues/11128
2022-03-14 09:23:16 +01:00
38cde901b0
Don't use last-resolved caches for graphic lines.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11127
2022-03-14 00:31:56 +00:00
ec44dfa60f
Unescape value fields when pasting from legacy schematics.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11124
2022-03-13 22:17:44 +00:00
d653484d72
Move connected_items from hash table to tree
...
This gains about 10% speed in heavily connected sheets
Fixes https://gitlab.com/kicad/code/kicad/issues/10974
(cherry picked from commit 187aa1c171
2022-03-11 16:58:38 -08:00
5b5c7d41b4
Break up buildConnectionGraph for debugging
...
Needed to find bottlenecks in fns, so break out individual sections of
the massive function for easier understanding.
buildItemSubgraphs (one section of the previous function) would build
millions of connections that were never used as stacked pins created X!
connections. Also tested using sets instead of lists and keeping unique
lists to avoid flagging but none of these were as performant as using
flags to remember which items had already been processed.
Fixes https://gitlab.com/kicad/code/kicad/issues/10974
(cherry picked from commit 17b1b68ac7
2022-03-11 16:58:38 -08:00
7ab4d67e94
Make sure line style comboboxes get a default entry.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11083
2022-03-11 23:19:16 +00:00
dd1dbb81f6
Improve shared schematic file churn heuristics.
...
The previous solution cleared all of the fields and force the unit setting
to unit one which would have less than desirable effects when reusing a
schematic in another project. This solution forces all of the instance
settings to the first sheet instance of the current project to prevent file
change churn when changing shared sheets in the current project.
This will not prevent shared schematic file changes when the first sheet
instance data differs between projects.
2022-03-11 12:37:30 -05:00
bf5d585e24
Reduce shared schematic file change churn.
2022-03-11 00:32:34 +00:00
a9eb7a0e28
Make sure LIB_ID escape context allows for formatting constructs.
...
Also make sure that value field is updated from name changes when the
symbol is a power symbol (even if it's from the schematic instead of
the library).
Fixes https://gitlab.com/kicad/code/kicad/issues/11093
2022-03-10 13:46:42 +00:00
16a266301a
Remove double-call of settings from Netlister
...
Double-calls are no longer needed when using settings. They can
interfere depending on how the system executes the commands.
Removing keeps the last used plugin as the default, rather than the last
selected
Fixes https://gitlab.com/kicad/code/kicad/issues/11094
(cherry picked from commit e8ef863861
2022-03-09 17:12:41 -08:00
fd59179cd2
Avoid implementation dependent on events
...
Adding a page in the ctor can generate events that change the default
page. Instead, we set the default after all pages have been added,
avoiding the reset
Fixes https://gitlab.com/kicad/code/kicad/issues/10910
(cherry picked from commit 5314ba6440
2022-03-09 15:42:29 -08:00
6934bc124c
Move temp save files to temporary directory
...
Avoid excess writes to the project directory to dodge issues with remote
file systems not fully writing data.
wxRename works across disk boundaries (in theory) and falls back to
wxCopy/wxRemove when it fails
Fixes https://gitlab.com/kicad/code/kicad/issues/10747
2022-03-07 20:13:28 -08:00
c9fb95b888
Fix the order of evaluation in the arc printing
...
MapAngles will adjust by small amounts the angles t1 and t2. This
adjustment will determine the CW/CCW drawing. Therefore, the MapAngles
needs to be called explicitly before the Normalize180() call.
Left-to-Right evaluation is not a given for MSVC
Fixes https://gitlab.com/kicad/code/kicad/issues/11050
2022-03-07 16:43:13 -08:00
bf0f2aa4a8
Adjust bitmap text spacing a bit so it's closer to the stroke font.
...
This helps the text better match the highlighting when it gets small
enough that we switch to the bitmap font for performance.
2022-03-07 20:30:50 +00:00
1f745b000d
Special-case synthetic click after tool selection.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11057
2022-03-07 20:30:50 +00:00
39fa4e2065
Include textbox in movable objects.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11058
2022-03-07 10:33:59 +00:00
d3716b9956
Reentrancy block for symbol editor symbol properties dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11060
2022-03-07 10:26:18 +00:00
4923f02651
Reset GAL pen width between drawing text and border.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11059
2022-03-06 20:32:28 +00:00
3969045009
Don't bitmap multi-line SCH_TEXT.
...
The linespacing isn't even close and multi-line text is also likely to
have longer lines which makes the X offset get way off too.
2022-03-06 20:17:56 +00:00
6b3ed89248
Handle justified LIB_TEXT.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11052
2022-03-06 19:54:06 +00:00
14304215b3
Copy m_private flag in LIB_TEXT's clone().
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11051
2022-03-06 17:00:13 +00:00
c919817c18
Don't reserve space for private items when autoplacing.
2022-03-06 16:12:49 +00:00
dbfdd3fb56
Fix some Coverity warnings.
2022-03-06 09:48:33 +01:00
8fd87e1f04
Change connectivity item group from set to vector
...
Reserve space for new items to speed construction of connectivity graph
Fixes https://gitlab.com/kicad/code/kicad/issues/10974
(cherry picked from commit 7aebc4b11f
2022-03-05 13:04:11 -05:00
cd7141fd10
Cache read arc data for stability
...
Arcs can be altered by the process of changing from on-disk
representation to in-memory representation. Saving back to disk without
modifying the arc should not modify the calculated values.
This stores a copy of the on-disk representation that is only used to
save back to disk in the event that the arc is not modified during
editing.
Fixes https://gitlab.com/kicad/code/kicad/issues/10442
2022-03-04 15:20:31 -08:00
7ecc70a79d
Duplicate from selected or current
...
When double-clicking to open a symbol, it is no longer selected in the
tree. We need to use the `GetTargetLibId()` to pick the correct symbol
(first selected, then current) when using the duplicate command
Fixes https://gitlab.com/kicad/code/kicad/issues/11034
(cherry picked from commit 802d20c409
2022-03-03 16:04:22 -08:00
c025b4c73d
Save all stroke parameters of sch & lib shapes.
...
We were failing to save the line style, which caused ERC errors when
DEFAULT != SOLID.
2022-03-03 14:37:04 +00:00
76535d8572
Make LIB_ITEM::COMPARE_FLAGS really a flags field, and add ERC.
...
Before they were 1/2 treated as flags and 1/2 treated as a mode enum.
The ERC flag relaxes constraints on data that is settable in the
schematic editor.
Fixes https://gitlab.com/kicad/code/kicad/issues/11018
2022-03-03 13:27:18 +00:00
a0d68b8426
SCH_DIRECTIVE_LABEL: add missing virtual SwapData.
...
Fixes #11027
https://gitlab.com/kicad/code/kicad/issues/11027
2022-03-03 10:27:17 +01:00
c5d85e0b7e
Don't try to open cell editor on first focus.
...
It hasn't worked since we rejiggered the default grid selection mode
anyway, and for some reason it eats <esc> key events after the dialog
has been resized.
Fixes https://gitlab.com/kicad/code/kicad/issues/11015
2022-03-03 02:06:48 +00:00
fd4b4533b1
Remove some code that isn't used anymore.
2022-03-03 02:06:48 +00:00
548936bb22
Fix broken unit select context menu
...
The fix for https://gitlab.com/kicad/code/kicad/issues/10529 kicked the
subsequent IDs for unit selection off the maximum ID value for popup
menus. This increases the maximum popup number (integers are free)
(cherry picked from commit 79b6991d7b
2022-03-02 16:33:28 -08:00
8c36ba3653
Explicitly give unit values
...
Removes the ability to hide symbol units in file formats. This was
mostly the case for a while but there remained corner cases where we
left a default/hidden option
Fixes https://gitlab.com/kicad/code/kicad/issues/10888
2022-03-02 16:01:08 -08:00
984eb0fb40
Handle locally-coded file names for sheets
...
Windows can accidentally create forward slash-coded files. This simply
converts them to the proper unix-coded value when set
Fixes https://gitlab.com/kicad/code/kicad/issues/10964
(cherry picked from commit 429544c188
2022-03-01 17:23:30 -08:00
61acd607ad
Ensure fields are properly ordered
...
When reading sheet fields, we need to maintain a consistent order for
the mandatory fields as they are dereferenced by place. We force this
during the `SetFields()` call.
(cherry picked from commit 8385ce3021
2022-03-01 17:10:35 -08:00
ac87d5e940
Resolve text when requested
...
Getting resolved text for a symbol should always happen, even if we have
unresolved data in the instances
Fixes https://gitlab.com/kicad/code/kicad/issues/11003
(cherry picked from commit acb5ce7108
2022-03-01 15:11:06 -08:00
79ad15b4fa
Fix copy/pasta.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11005
2022-03-01 14:59:29 +00:00
4dc652497d
Put device-coloured fills on device layer.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10993
2022-02-28 21:11:01 +00:00
eb06ecab10
Avoid resolving text vars without screen
...
We need to keep the screen blank while initially loading a sheet before
the hierarchy is developed. Avoid resolving text variables during this
process
Fixes https://gitlab.com/kicad/code/kicad/issues/11000
(cherry picked from commit 63b06af6b1
2022-02-28 12:28:02 -08:00
b55bda8d6f
Font support for drawing sheet editor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10306
2022-02-28 18:05:26 +00:00
5503afc09a
Schematic: disallow center rotation, allow both endpoint rotations
...
Center rotation will often misalign lines to the grid, which is bad
until fix off grid items on the schematic.
We can rotate a connection end into a new connection or to become
collinear with an existing line, so we need to check for this at the end
of rotation.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10565
(cherry picked from commit 7d4cb91f39
2022-02-28 08:50:12 -08:00
f241617478
Be more careful about non-visible elements in fields autoplacer.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10774
2022-02-28 00:18:39 +00:00
c4d2ac570f
Don't allow break commands (or labelling cmds) on multiple wire selections.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10934
2022-02-27 23:15:07 +00:00
1f16092e29
Infobar warning if symbol loading was cancelled.
...
Also makes sure the progress dialog is closed when we're done reading
symbols (it used to stay up for much of the symbol editor initialization).
Also makes sure that any cancel in the preLoad step is honoured in the
sync step. (The preload is done because it is multi-threaded and therefore
faster than the single-threaded sync.)
Also makes sure that individual threads pay attention to the cancellation,
not just the GUI thread.
Fixes https://gitlab.com/kicad/code/kicad/issues/8372
2022-02-27 17:06:08 +00:00
535ea800c0
Honor modifier keys in diambiguation
...
Needs to be reset for the new action before selecting elements at a
point.
Fixes https://gitlab.com/kicad/code/kicad/issues/9712
(cherry picked from commit a30ad0b54a
2022-02-25 16:16:15 -08:00
78620347c8
Fixing Eagle refs that do not work with KiCad
...
KiCad has stricter requirements for what consititutes an annotated
symbol. This checks for and corrects annotations that begin with '#',
do not begin with a non-numeric character or do not end with a number
2022-02-25 23:42:47 +00:00
faa3829ad4
Add MRU to image placement tools
2022-02-25 13:18:43 -08:00
6d8507d44f
Formatting.
2022-02-25 17:36:35 +00:00
4c81bac9e3
Eeschema: ensure ERC exclusions list is up to date before saving it in *.kicad_pro
...
Fixes #10339
https://gitlab.com/kicad/code/kicad/issues/10339
2022-02-25 18:21:46 +01:00
67eb138a4b
Fix copy/pasta.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10957
2022-02-25 00:49:41 +00:00
a29968fa91
Make sure bitmap fallback is only used for non-cached text.
...
Also fixes backwards vertical justification for bitmap text.
Fixes https://gitlab.com/kicad/code/kicad/issues/10956
2022-02-24 18:16:45 +00:00
2042b08127
Performance optimizations for drawing (small) text.
2022-02-23 12:09:36 +00:00
d58427a519
Don't kill entire OpenGL cache on undo.
...
The comment regarding bitmaps was true for one more month in 2018, but
hasn't been true for the last 3 years, and clearing the cache is a huge
performance hit.
2022-02-22 23:09:55 +00:00
c7dda3fbec
Formatting.
2022-02-22 22:19:55 +00:00
e35c3f2b99
Schematic: handle switching h/v mode better while drawing lines
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10859
2022-02-21 17:03:43 +00:00
a2772b3363
Don't crash on highight net during drag.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10866
2022-02-21 13:30:15 +00:00
b0d7c82e64
Disable grid when ctrl/cmd key is down.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9995
2022-02-20 16:50:30 +00:00
d0749c4e9a
Schematic: more drag undo fixes
...
Drag was not clearing IS_CHANGED status of items that were moved by the
drag, but weren't selected or created by it.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10845
2022-02-20 11:49:18 +00:00
d1a4daefbb
wxPoint->VECTOR2I correction for master
2022-02-19 19:14:41 -08:00
24ac516135
Trim wires based on how many pins they intersect
...
If a wire intersects more than 2 pins from the same symbol, we don't
trim connections. If the wire intersects exactly two pins from a single
symbol, we remove the wire between the pins.
We avoided doing this before because we didn't have a good metric for
trimming vs. not. But the per-symbol calculation feels like the least
surprising option.
Fixes https://gitlab.com/kicad/code/kicad/issues/10909
Fixes https://gitlab.com/kicad/code/kicad/issues/1857
(cherry picked from commit 75a4036e45
2022-02-19 16:54:45 -08:00
8ef7252330
altium: Don't use string concatenation for paths pointing in the compound file
...
* std::vector do not need to be split apart again
* supports backslash in footprint names
2022-02-19 16:46:20 +01:00
510dc28a5c
Resolve text variables before attempting to open datasheet.
2022-02-19 14:59:50 +00:00
8a22dab83d
Fix crash bug when adding rows to pin table and then pasting to unit.
2022-02-18 17:12:46 +00:00
a678b78091
Implement SCH_MARKER::GetSeverity().
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10893
2022-02-18 12:14:38 +00:00
944fe9637d
Fix error that prevent drawing pin selection highlighting.
2022-02-17 19:02:51 +00:00
35f85dd900
Eeschema: fix broken symbol library rescue.
...
Apparently at some point during V5 development, symbol cache library names
were saved by replacing the LIB_ID separator character ':' with '_'. This
caused the cache look up to fail there by skipping the symbol rescue which
could result in broken schematics.
I have no idea where this happened during V5 development. The video demo
in the HEAD of the 5.1 branch shows the issue. All of the other demo cache
libraries are correct.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10488
(cherry picked from commit c6c4f9ae4b
2022-02-17 09:16:33 -05:00
9584849aba
Fix type which results in global fieldname templates being added to project.
2022-02-17 12:42:10 +00:00
d60ed70d54
Sync all fields between units when symbol is edited.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10610
2022-02-17 12:42:10 +00:00
e499793147
Update alt pin assignments in other units.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10849
2022-02-17 12:42:10 +00:00
567168fffc
Schematic: make grabbing whole lines more intuitive
...
Selecting end and midpoint will select whole line. Some changes for
orthogonal dragging made this worse than in 6.0.
Improves, but does not fully resolve:
https://gitlab.com/kicad/code/kicad/-/issues/10860
2022-02-16 19:15:55 +00:00
bc7742cb2e
Various text object defaults don't necessarily match file defaults.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10862
2022-02-15 23:25:59 +00:00
ab5489ad30
Fix typo.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10390
2022-02-15 22:40:24 +00:00
97797c44b9
Schematic: added drag wires undo/redo fix
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10845
2022-02-15 19:31:17 +00:00
45a1a9a715
Replace awkward double cast with binary logic
...
The use of XOR with integers here is needed as MSVC doesn't implement
the use of std::signbit for integers and casting up to double just to
get the signbit feels wrong
2022-02-15 10:13:59 -08:00
414dfb4745
Eeschema, DIALOG_TEXT_PROPERTIES and DIALOG_LIB_TEXTBOX_PROPERTIES: fix minor issues
...
Fixes #10863
https://gitlab.com/kicad/code/kicad/issues/10863
2022-02-15 15:38:08 +01:00
3129f96686
Add awkward cast to double due to msvc conflict
...
https://github.com/microsoft/STL/issues/519
2022-02-14 21:43:11 -05:00
9c59c4ee12
Schematic: orthogonal drag bends should depend on move direction
...
Prevents overlapping lines when possible.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10844
2022-02-14 22:52:34 +00:00
876061369b
Fix some Pcbnew crashes due to null pointers
2022-02-14 13:46:05 +01:00
4e5b30ad80
Rewrite autostart to not need connectivity.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10579
2022-02-14 01:15:06 +00:00
1090403ca2
Schematic Preferences: fix grid assert on negative width
2022-02-13 22:27:41 +00:00
013d6d088f
Eeschema: fix pin starting wire bus bug
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10819
2022-02-13 15:02:09 +00:00
7e6829e834
Fix minor compil warnings
2022-02-12 11:43:38 +01:00
33e57930bc
Implement undo for Eeschema find/replace.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10824
2022-02-11 22:09:22 +00:00
21b59b4b6a
Eeschema: fix bus label drag adding a line
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10822
2022-02-11 21:30:50 +00:00
940e03e567
Remove arc end swapping when parsing.
...
See: 2366b06e77 (note_839061664)
2022-02-11 13:10:52 +00:00
946f62d949
Add separate wildcard for OrCAD netlists
2022-02-11 09:24:20 +00:00
082c6f5bd6
Make sure plotter uses default font when specified.
2022-02-10 20:33:06 +00:00
f11b8011cd
Separate plotting into background and foreground.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10390
2022-02-10 20:33:06 +00:00
a5e8575091
Eeschema: Implement orthogonal dragging
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1956
2022-02-10 18:38:40 +00:00
2366b06e77
Don't parse multiple items in a single c'tor or function call.
...
The C++ optimizer is not always your friend and may do them in the
reverse order.
2022-02-10 17:54:13 +00:00
d33d092e8e
Add a second fix for backwards arcs.
...
This one *should* also be good when we support larger-than-180
degree arcs.
2022-02-10 15:46:02 +00:00
cb8e803788
Formatting.
2022-02-10 13:04:29 +00:00
b9843a23eb
Eeschema, legacy *lib files: fix issues with 180 deg arcs.
...
180 deg arcs are a limit, so when importing them convert them to slightly
smaller arc (arc angle = 179.5 deg)
Fixes #10455
https://gitlab.com/kicad/code/kicad/issues/10455
2022-02-10 12:45:54 +01:00
7b84e0a7d9
Make printing/plotting/drawing of LIB and SCH arcs consistent.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10801
2022-02-10 00:35:24 +00:00
3f8f90db9f
Factor out common s-expression library cache source code.
2022-02-09 11:20:14 -05:00
7181f0b40b
Fix clang broken build.
2022-02-09 07:55:50 -05:00
fe82f2dd40
Factor out common schematic s-expression source code.
2022-02-08 14:44:38 -05:00
58c38d2830
Don't nanny users about what constitutes quality graphics.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10788
Fixes https://gitlab.com/kicad/code/kicad/issues/10374
2022-02-08 17:35:48 +00:00
3600b2ce3f
Make sure temp sheet has a parent.
2022-02-08 17:09:17 +00:00
2f79f579cc
DIALOG_TEXT_PROPERTIES: do not show fill option for texts.
...
It make sense only for text boxes.
Fixes #10786
https://gitlab.com/kicad/code/kicad/issues/10786
2022-02-08 09:42:22 +01:00
7c91cd73e3
Eeschema: unconnected ends of wire entries should allow auto start wires
2022-02-07 23:31:24 +00:00
fc3cad0b54
Hash symbol libraries per library rather than statically per cache type.
2022-02-07 15:40:21 -05:00
f9b27a53b2
Eeschema: Edit pin numbers while grouped
...
ADDED: The pin table pin numbers column supports editing the list of pin
numbers to add, remove, and rename pins.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/5620
2022-02-07 17:45:16 +00:00
631d5155ef
Eeschema: Pin table support for multi unit symbols
...
ADDED: Symbol editor pin table supports editing which unit each pin is
displayed on
Note: 6513 mentions being able to change the pin unit from the edit pin
menu. This does not add that feature.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6513
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/5470
2022-02-07 17:45:16 +00:00
56794ab829
Eeschema: Add pin count column to pin table
...
ADDED: When the pin table is showing grouped pins, display a read-only column
that displays the number of pins in each row.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2416
2022-02-07 17:45:16 +00:00
08ca19f95d
Eeschema: Display pin count and duplicate pin list in pin table dialog
2022-02-07 17:45:16 +00:00
624dc393bf
Fix tooltip.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10708
2022-02-07 17:36:40 +00:00
79c7d55a40
Add a checkbox for LIB_SHAPE borders. (We already have them for LIB_TEXTBOXes.)
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10365
2022-02-06 19:43:25 +00:00
0ffa1288ee
Regularize how penWidths are fetched.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/git
2022-02-06 19:43:25 +00:00
aedfe08bad
Show pin dangling symbols in Symbol Editor.
...
Even though we don't have connections they're a still a good visual
indication of which end of the pin is which.
Fixes https://gitlab.com/kicad/code/kicad/issues/10742
2022-02-06 19:43:25 +00:00
b1cc784582
Harmonize interchangeable units checkboxes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10708
2022-02-06 19:43:25 +00:00
cc69849719
Fix definition of nonFields to include textboxes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10771
2022-02-06 19:43:25 +00:00
b57ac3d517
Handle SCH_TEXTBOX in SCH_SEXPR_PLUGIN::Format.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10771
2022-02-06 19:43:25 +00:00
d9c04da407
Sprinkle in some make_unique
2022-02-05 21:26:36 -05:00
41f54349a5
Replace inserts/push_backs with emplace in some spots
2022-02-05 19:53:31 -05:00
7ccac79192
More wxString wide literals.
2022-02-05 21:29:34 +00:00
8d3e1639d0
Update text variables when they change.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10734
2022-02-04 12:52:46 +00:00
ca7840334c
Mark some limits as constexpr
...
gcc doesn't need it and computes during compile regardless, but experimenting in godbolt, both clang and MSVC actually do need it or else it's partially computed at runtime
2022-02-04 07:50:13 -05:00
3badd53a96
Setup selection when repeating
...
We need the item to be currently selected when repeating the last symbol
insert. This ensures we have a valid selection before starting the move
tool and possibly getting odd system behavior from mouse positions
Fixes https://gitlab.com/kicad/code/kicad/issues/10619
(cherry picked from commit 7642a9db79
2022-02-03 17:09:59 -08:00
b9eb3e9b05
Be more explicit about string conversions.
2022-02-03 23:07:41 +00:00
b7c31d3b5b
When undoing creation of the sheet, get out first
...
We can't stay in a sheet that is deleted by the action of undo. Checks
the current sheet and, if we are currently using it, ensures that the
following action is to leave the current sheet
Fixes https://gitlab.com/kicad/code/kicad/issues/10733
(cherry picked from commit ccf2a63f45
2022-02-03 11:19:51 -08:00
3d0b03515d
Fix bad field names when ID == -1.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10548
2022-02-03 12:38:56 +00:00
fa1d316d84
Fix windows build error
2022-02-02 17:43:47 -05:00
e590d07224
Fix clang build error.
2022-02-02 07:44:11 -05:00
9260431fe4
Abstract out symbol library parser object.
2022-02-02 07:07:39 -05:00
6fcc6f7c9d
Factor out common legacy schematic and symbol library parser code.
2022-02-01 16:30:15 -05:00
bebfbce9b2
Move pcb file rep of text_boxes to strokes.
2022-02-01 16:29:59 +00:00
a1009d7899
Fix assertion failure for labels.
2022-02-01 12:01:04 +00:00
59e43527a0
Add dummy defaults for textbox
2022-01-31 16:26:37 -08:00
4243d7b055
Bug fixes for color handling.
2022-02-01 00:21:08 +00:00
098e8f7d9b
Revert "cmake: adding KICAD_MACOSX_APP_BUNDLE option"
...
This reverts commit ea9f960cc1
2022-01-31 15:57:56 -08:00
f3cd36d1d7
Bring EEschema textboxes in line with PCBNew's.
...
Also adds Border checkboxes and fixes a bunch of bugs.
2022-01-31 21:46:40 +00:00
5739505aa3
TextBoxes for PCBNew.
2022-01-31 20:00:47 +00:00
60bcfd1bf1
Bug fixes in arc & textbox printing.
...
Also removal of the no-longer-used clipping code from GR*.
2022-01-31 20:00:47 +00:00
25a7de730c
eeschema/CMakeLists.txt Sort sources alphabetically
2022-01-31 19:51:01 +00:00
64f2adbc31
SCH_PAINTER, draw filled LIB_SHAPE: fix incorrect selection of fill color.
2022-01-30 10:20:49 +01:00
b4826ce304
LIB_TEXT: fix incorrect position of the drawn text.
...
Fixes #10654
https://gitlab.com/kicad/code/kicad/issues/10654
2022-01-30 09:11:16 +01:00
38706fdd95
Fully select a line for transformation
...
When not trying to select points, we need to ensure that the full
line is selected for transformation
Fixes https://gitlab.com/kicad/code/kicad/issues/10566
(cherry picked from commit 70d00689ca
2022-01-29 17:37:30 -08:00
b36e31c49f
Factor out common and remove dead legacy symbol library code.
2022-01-29 14:13:00 -05:00
ea9f960cc1
cmake: adding KICAD_MACOSX_APP_BUNDLE option
...
ADDED: with cmake KICAD_MACOSX_APP_BUNDLE option the user can disable
the macOS app bundle creation when compiling on macOS. This permit to
use/install KiCad like any other *nix platform (/usr/bin, /usr/share,
ecc.). By default, cmake build the app bundle.
2022-01-28 15:49:37 -08:00
c6a8100d46
Schematic and symbol text boxes.
...
Also fixes some plot bugs with arcs.
Also moves polygonization of arcs (when required) in plotting code
from 5 degrees to calculated based on ARC_HIGH_DEF.
Fixes https://gitlab.com/kicad/code/kicad/issues/5017
2022-01-28 21:38:15 +00:00
3409783d9f
Break sch_text.h/.cpp into sch_text and sch_label.
...
Also moves SCH_NETCLASS_FLAG to SCH_DIRECTIVE_LABEL, and remaps Altium
harnesses from SCH_TEXT to SCH_DIRECTIVE_LABEL.
2022-01-28 21:38:15 +00:00
79403ef075
Readd yield call to give slice to system.
...
Note:
- wxYield does not work here, indicating the need for locking
- wxYieldIfNeeded does not work, possibly for the same reason as wxYield
- Both Layout() and m_fieldGrid->Layout() need to be called even though
the first should call the second.
Fixes https://gitlab.com/kicad/code/kicad/issues/5690
2022-01-28 13:02:39 -08:00
a6203617d9
Fix Altium schematic port component import assertion.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10322
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10401
2022-01-28 15:52:30 +00:00
ecb32b1fb0
Eeschema: hover start from wire end should copy wire properties
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10128
2022-01-27 17:17:45 +00:00
9ab2eb391f
Move delay selection out of UpdateUI
...
Calling actions from within UpdateUI can cause loops that crash or
substantially slow
Fixes https://gitlab.com/kicad/code/kicad/issues/10616
2022-01-26 16:05:40 -08:00
8a17fb8d19
SCH_SEXPR_PARSER::parseArc(): fix a very annoying issue: each time the lib or
...
sch files are saved and reopened, 180 deg arcs were flipped.
This fix is a workaround, but avoid flipped arcs after saving/reopening these files.
2022-01-26 18:19:52 +01:00
2dc031ee34
Prevent auto-column sizing when editor opens
...
On GTK, some configurations will trigger a column resize, which will
close the current editor. This blocks the column resize while the
editor is open, unless the resize continues, which indicates dragging of
the window edge
Fixes https://gitlab.com/kicad/code/kicad/issues/5690
2022-01-25 17:59:15 -08:00
b6ecbc596e
Fix mistaken use of `m_width`
...
This is a protected var in Linux but doesn't exist in Mac/MSW. We use
the new m_fieldsSize
2022-01-25 12:45:09 -08:00
efb323d57d
Another stab at https://gitlab.com/kicad/code/kicad/-/issues/5690
...
This time, ensure that the grid is increased and the main form gets an
event
2022-01-24 16:30:30 -08:00
a054a46136
Force a size event to avoid multiple yields
...
When the grid editor is shown, we also want to ensure that the grid gets
resized to account for the new editor. Queuing the event will ensure
that happens after the editor is emplaced in the grid
Fixes https://gitlab.com/kicad/code/kicad/issues/5690
(cherry picked from commit fddfce4fb1
2022-01-24 15:32:17 -08:00
be5bb8c4bd
Enforce strictly weak ordering in sheets
...
This ensures that irreflexivity is given in sort ordering. This may
have been triggering issues in MacOS when adding sheets
Fixes https://gitlab.com/kicad/code/kicad/issues/10557
(cherry picked from commit a1615cce7e
2022-01-24 10:41:21 -08:00
175c4fe67c
Allow time to update editor
...
On GTK, the full editor needs to be shown and, for some systems, the
editor will not show correctly. By yielding we should allow the time to
recalculate sizes for the editor in the grid
Fixes https://gitlab.com/kicad/code/kicad/issues/5690
(cherry picked from commit 871556ebda
2022-01-24 09:58:10 -08:00
0926eb3287
Get all eeschema layers properly ordered
...
Layers not in the given order are drawn behind everyone else. Missing
the text prevents global labels from showing properly in GAL order
Fixes https://gitlab.com/kicad/code/kicad/issues/10546
(cherry picked from commit f12d0cb0e2
2022-01-23 10:04:32 -08:00
58e167013d
SPICE: Add support for transmission lines
2022-01-23 17:23:22 +00:00
2dbc89e5f2
DIALOG_SIM_SETTINGS: fix incorrect validation of DC souces in DC Transfer panel
...
Fixes #10568
https://gitlab.com/kicad/code/kicad/issues/10568
2022-01-23 16:22:12 +01:00
0283e2c246
Highlighting for schematic shapes when fill shapes is turned off.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10372
2022-01-22 22:27:41 +00:00
29841ba315
Bring ERC & DRC dialogs into parity.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9350
2022-01-22 22:27:41 +00:00
de49f5090d
Formatting (and auto reduction).
2022-01-22 12:16:07 +00:00
4665cdcdc5
Allow more (lots more) unfold from bus menu entries.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10529
2022-01-21 17:41:05 +00:00
242e66355c
SYMBOL_VIEWER_FRAME: fix refresh of the canvas after selecting a new symbol.
2022-01-21 16:37:58 +01:00
694ae59664
fix a minor compil warning (shadowed vars)
2022-01-21 14:09:42 +01:00
c8a50d9b50
Remove unit-less angles from VECTOR2I/D APIs.
2022-01-20 23:58:20 +00:00
16aca901df
Clear Undo list when renaming
...
Our undo/redo list is tied to the screen that gets cleared when we
reload the file after renaming. We need to clear the Undo list at this
point to prevent possible crashes when moving too far back in the stack
Fixes https://gitlab.com/kicad/code/kicad/issues/10504
(cherry picked from commit 323a069738
2022-01-20 11:29:05 -08:00
cffc99e384
Don't close filled polylines when printing
...
Eeschema/libedit support open, filled polylines. When printing, this
should be drawn as a fill, followed by the polyline to avoid assumptions
about closed polygons in the graphic code
Fixes https://gitlab.com/kicad/code/kicad/issues/10537
(cherry picked from commit 615eda816e
2022-01-20 10:54:36 -08:00
3ba89f50ef
Maybe, just maybe, fix LibEdit arc parsing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10455
2022-01-19 22:22:18 +00:00
8445783216
Fix backwards arcs in legacy LIB_ARCs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10455
2022-01-18 14:08:47 +00:00
380cb452b2
fix an issue in a bom script (extra empty lines created)
...
Fixes #10473
https://gitlab.com/kicad/code/kicad/issues/10473
2022-01-18 13:49:50 +01:00
25fca2abb7
fix a minor compil warning
2022-01-18 13:49:50 +01:00
f310a5b986
Excise deci-degrees from trigo.
2022-01-18 11:44:55 +00:00
b828355206
A bit more angle cleanup.
2022-01-18 09:48:24 +00:00
de31b813f3
Angle cleanup in the Cadstar importer.
2022-01-18 02:31:37 +00:00
622f94e7b9
Angle cleanup in Altium importer.
2022-01-18 02:31:37 +00:00
0218b782f4
Angle cleanup in Eagle importer.
2022-01-18 02:31:37 +00:00
dcaec78cc5
A bit more angle cleanup.
2022-01-18 02:18:55 +00:00
0129e49b79
altium: Introduce new ALTIUM_COMPOUND_FILE object to handle file opening and searching for streams at a central place
2022-01-17 19:54:26 +01:00
2defd8d911
Move show-bounding-boxes to a tool on the toolbars.
2022-01-17 11:56:40 +00:00
5cc3368b14
Fix bounding boxes and hittesting for arcs in eeschema.
2022-01-16 23:54:59 +00:00
e61144d45a
Finish with EDA_ANGLE.
2022-01-16 21:15:40 +00:00
bc1ff6756f
Cross-probing/selection for multiple items (SCH->PCB)
2022-01-16 20:29:03 +00:00
e84c574830
Some more EDA_ANGLE cleanup.
2022-01-16 19:16:18 +00:00
516d038bdf
Eeschema: fix incorrect stored rotation value in file of the global and hierarch. labels.
...
The stored value was the rotation of the text (always 0 or 90 deg), but these labels can also
be rotated by -90 or 180 deg
Fixes #10450
https://gitlab.com/kicad/code/kicad/issues/10450
Fixes #10457
https://gitlab.com/kicad/code/kicad/issues/10457
2022-01-16 17:19:36 +01:00
9b661aea10
EDA_ANGLE for plotters.
...
Also fixes a compile error in the PNS Playground.
2022-01-16 01:19:45 +00:00
2b14b60c32
Resolve text variables in eeschema before passing to pcbnew.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10429
2022-01-15 01:30:03 +00:00
a533d64417
Apply default line style.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10388
2022-01-14 16:08:19 +00:00
07013d00e1
More EDA_ANGLE.
2022-01-14 16:08:19 +00:00
1b19ff5f42
More EDA_ANGLE changes.
2022-01-14 16:08:19 +00:00
70ad554343
Coverity fixes.
2022-01-14 16:08:18 +00:00
e048e51f5d
Improve SNR of EDA_ANGLE stuff.
2022-01-14 16:08:18 +00:00
d0f2c20235
Define our kicad font name only once, and do not translate it.
...
Especially using a translated name breaks kicad config and files because
in non English languages both translated and not translated names were used in code.
2022-01-13 14:32:55 +01:00
e244ce1431
Fix cherry-picked wxPoint
2022-01-12 15:49:03 -08:00
d3f24308e6
Handle rotated symbol rectangles in Eagle import
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10360
(cherry picked from commit dcb8f29317
2022-01-12 15:11:18 -08:00
8373180cbb
Handle Unicode clipboard data in pcbnew and symbol editor
...
Fixes #10323
2022-01-12 17:15:47 +00:00
5a3d53d9e4
Catch default autowire case
...
Since we are dereferencing the optional, we need to ensure it exists in
all cases
Fixes https://gitlab.com/kicad/code/kicad/issues/10394
(cherry picked from commit 56d87a8613
2022-01-12 09:03:44 -08:00
a709d97a32
SCH_LABEL_BASE::Plot(): Plot fields.
2022-01-12 11:08:34 +01:00
b3072cc16b
SCH_PAINTER, DrawLine: gives a minimal length to lines having a 0 length
...
Lines with start point = end point always create problems in OpenGL (not drawn).
2022-01-12 09:44:30 +01:00
3d8288f919
Remove unused vars, verified there was no other intention with them;
...
rectangle are OK
2022-01-11 20:16:35 +00:00
062f5e3177
Undo for SCH_SHAPEs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10373
2022-01-11 18:33:54 +00:00
a23f6e4e92
Handle border colors for SCH_SHAPEs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10361
2022-01-11 18:18:11 +00:00
184bcf6520
Fix failure of SCH_SHAPE to pick up default line width.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10376
2022-01-11 17:40:49 +00:00
f9927ab675
Fix Text Properties dialog layout.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10368
2022-01-11 16:00:38 +00:00
267eca28cd
Font support for global edit text & graphics dialogs.
2022-01-11 15:34:24 +00:00
8f7d2dd06a
More VECTOR2D -> VECTOR2I and wxPoint cleanup.
2022-01-11 14:20:14 +00:00
d5faac7614
Better fix for missing end segment
...
Rather than skipping our endEdit() call in libedit, we need to
parameterize whether we want the shape open/closed. Closed will remove
the last segment if it lands on the first point. We don't want that
but we do want to remove the last point if it duplicates the second to
last (in the case of double-clicking)
Fixes https://gitlab.com/kicad/code/kicad/issues/10334
(cherry picked from commit 55020c2b89
2022-01-10 13:39:39 -08:00
7d032f9c2f
Outline font rendering for Cairo, plotter, printer and 3D viewer.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10319
2022-01-10 01:54:28 +00:00
76368af7b9
Font cleanup and bug fixes.
2022-01-09 18:33:53 +00:00
92d5a3e763
Clear caches when changing global default font.
2022-01-09 11:34:20 +00:00
27c967421c
Commenting and "auto" reduction.
2022-01-08 16:47:45 +00:00
04c76f10e9
Performance enhancements for fonts.
2022-01-08 16:47:45 +00:00
438c63f587
Fix outline font boundingbox issues.
2022-01-08 16:47:45 +00:00
aef2a3fca4
Default font for eeschema.
2022-01-08 16:47:45 +00:00
a2030a5956
GUI for font selection.
2022-01-08 16:47:45 +00:00
72b69e8d7f
File format changes for fonts.
2022-01-08 16:47:45 +00:00
04c46a8fd2
Correct return type in mapCoords
2022-01-07 09:08:40 -08:00
3d88f37949
Switch mapCoords to VECTOR2I
2022-01-07 08:37:37 -08:00
eb271ca7fb
Don't deduplicate schematic polygon points
2022-01-07 08:29:34 -08:00
4cdc9d3857
Don't deduplicate symbol polygons
...
SHAPE_LINE_CHAIN will, by default, remove duplicate points when
appending. We don't want to do this when constructing our polygons in
symbol editor, so we need to explicitly call the routine without
deduplication
Fixes https://gitlab.com/kicad/code/kicad/issues/10289
(cherry picked from commit 62f8603353
2022-01-07 08:25:49 -08:00
c9fc15b5eb
Clear edited point when exiting tool
...
When leaving the main point editor loop, we need to ensure that the edit
point is cleared as well. This is usually cleared by a ClearEvent call
but in case this is missed, we need to ensure that other tools are not
caught out
Fixes https://gitlab.com/kicad/code/kicad/issues/10288
(cherry picked from commit 9a2332dfcf
2022-01-07 08:25:49 -08:00
e00e9ff41f
PANEL_TEMPLATE_FIELDNAMES: fix incorrect management of boolean options
...
(it was impossible to disable them)
Fixes #10280
https://gitlab.com/kicad/code/kicad/issues/10280
2022-01-06 19:00:52 +01:00
3ace4446e7
Use 'special' escaping for certain fields
...
Most fields are escaped using the `\` notation. But the VALUE field and
the symbol name need to be escaped using braces notation.
Fixes https://gitlab.com/kicad/code/kicad/issues/10097
(cherry picked from commit 71e7b4b77b
2022-01-05 17:19:36 -08:00
88a8ad2ca1
Keep symbol synced with edit tool
...
Undo/Redo can change the symbol referenced by the symbol drawing tool.
This updates the current symbol before important steps to keep the
system synced
Fixes https://gitlab.com/kicad/code/kicad/issues/10125
(cherry picked from commit b8a7a66a0a
2022-01-05 16:52:02 -08:00
5a8b0921eb
Don't remove last point in libedit
...
SHAPE_LINE_CHAIN in libedit doesn't make a polygon, so we always need
the last point and it shouldn't be closed
Fixes https://gitlab.com/kicad/code/kicad/issues/9934
(cherry picked from commit 55087a9e82
2022-01-05 16:06:38 -08:00
3ced3afa68
eeschema: automatic generated symbol library from EAGLE plugin does not include footprint reference
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10262
2022-01-05 19:48:40 +00:00
e4961cb956
Update pin cache when undoing
...
The pin cache is invalidated by swap, so we need to ensure that it is
reset when we undo a change to the pins in schematic editor
Fixes https://gitlab.com/kicad/code/kicad/issues/10272
(cherry picked from commit 7f1648934f
2022-01-05 11:33:35 -08:00
502e34349e
eeschema: EAGLE plugin does not reference footprint with library suffix
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10261
2022-01-05 19:14:27 +00:00
30549a5e6a
Don't strip extensions twice in BOM export
...
Exporting the Bill of Materials uses the netlist exporter. Both of
these routines were stripping the extension, leading to projects like
"test.project.kicad_pro" having the project name stripped. We separate
the BOM netlist export from generic plugin netlist export to allow the
correct behavior when exporting netlists and generating BOMs
Fixes https://gitlab.com/kicad/code/kicad/issues/10270
(cherry picked from commit bef762e652
2022-01-05 11:07:49 -08:00
9ca41cc8ee
Set readable flags correctly on open
...
Missing files may be thrown during open. These should have existence
and readable flags set correctly
(cherry picked from commit a05ec04ee8
2022-01-05 09:55:51 -08:00
cd0ac9e698
eeschema, DIALOG_FIELD_PROPERTIES: fix a few issues.
...
(incorrect handling of H and V justify bitmap buttons
Fixes #10267
https://gitlab.com/kicad/code/kicad/issues/10267
2022-01-05 17:25:18 +01:00
b0fddef9b4
Don't rename existing schematic file
...
We should never leave a situation where the schematic file may no longer
exist (if the first rename succeeds and the second fails). So, make a
backup copy of the original schematic file and then attempt to rename
the autosave over the first file. In this case, if either attempt
fails, we do not lose the original file
Fixes https://gitlab.com/kicad/code/kicad/issues/10074
Fixes https://gitlab.com/kicad/code/kicad/issues/10256
Fixes https://gitlab.com/kicad/code/kicad/issues/10219
(cherry picked from commit b1658fdf9a
2022-01-04 20:28:21 -08:00
726d873c53
Tear down the wxPoint trigo helpers
2022-01-04 21:23:11 -05:00
dda569d486
Don't split legacy paths
...
The '.' is a valid character in the legacy preferences, not a separator.
Also adds fail-safe catch for JSON throws
Fixes https://gitlab.com/kicad/code/kicad/issues/10211
(cherry picked from commit a326d777f0
2022-01-04 11:09:40 -08:00
c2b54faceb
CvPcb: fix crash due to a null pointer: pcbconfig() can return null.
...
CvPcb has no config option and pcbconfig() returns nullptr.
In this case use default settings.
Fixes #10250
https://gitlab.com/kicad/code/kicad/issues/10250
2022-01-04 14:51:32 +01:00
ac715d2e51
Scoop up some more wxPoint instances
2022-01-03 20:00:53 -05:00
e21fa31f64
Rip out rest of macHack architecture.
2022-01-03 22:09:56 +00:00
2d3624a016
Rename ComparePageNumAndName -> ComparePageNum
2022-01-02 23:20:17 +00:00
9daa4d0e2c
Move duplicate field handling into field parser
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10130
(cherry picked from commit ea99c42df6
2022-01-02 13:19:54 -05:00
89c0f8e297
Move to new font engine.
2022-01-02 14:57:03 +00:00
c108d25897
Fix mirroring tests issues in qa tests for eeschema
2022-01-02 15:44:52 +01:00
e6087f361a
Add forgotten fix
2022-01-02 15:08:09 +01:00
797de9d327
Fix some issues (but not all) in qa tests for eeschema
...
The main fix is for errors in SCH_TEXT and derived:
qa test expects 4 rotations is an identity transform:
This is false if the item has autoplaced fields.
The fix clears autoplaced flags.
2022-01-02 14:54:27 +01:00
d25fe17b28
Bump minimum required CMake version to 3.11
...
Signed-off-by: Marek Roszko <mark.roszko@gmail.com>
2022-01-01 21:35:08 -05:00
a365afde3c
Ensure merged line gets selected if either parent is
...
We were only checking for the selection of a single line that gets
merged. This prevents the merged line from being highlighted but not
selected after merging
Fixes https://gitlab.com/kicad/code/kicad/issues/10202
(cherry picked from commit addc5574b4
2022-01-01 16:53:52 -08:00
93018375f8
Fix some test errors and update gold files for better netnames.
2022-01-01 20:46:45 +00:00
32dec0127e
Fix some issues with Eeschema's Shape Properties dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10140
2022-01-01 20:46:45 +00:00
34e90e5045
Silence MSVC warnings about type mismatch and unused var
2022-01-01 14:41:36 -05:00
c91d3e3cf9
Remove some more wxPoint
2022-01-01 14:12:20 -05:00
a0d708e04d
Use virtual page number when real page numbers are blank
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10158
2022-01-01 18:36:56 +00:00
ea613cf448
Another batch of point changes
2022-01-01 13:17:12 -05:00
d1552c3fec
Some more wxPoint removal
2022-01-01 12:11:21 -05:00
c4c56de708
Neurotically update position wxPoint usages
2022-01-01 11:55:51 -05:00
cadc0639eb
Update BASE_SCREEN to VECTOR2I
2022-01-01 11:30:33 -05:00
347e03363a
Convert wxPoint/wxSize starting from EDA_RECT usages
2022-01-01 11:30:33 -05:00
640cc60bf4
fix a compil warning.
2021-12-31 15:53:24 +01:00
0e9cfd0af2
Add missing initialization values to variables
...
Flagged by Coverity.
2021-12-30 23:42:06 +00:00
0f2e649b18
Cleanup formatting and warnings in tuner_slider
2021-12-30 23:03:13 +00:00
701e256b3f
Correctly handle excluding an ERC marker in eeschema when right clicking
...
In addition, hide the option to exclude a marker if the selected marker
is already excluded.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10173
2021-12-30 17:14:36 +00:00
480a548171
PCB_PAINTER: do not show track arc clearance when not needed
...
fix also a minor compil warning.
Fixes #10137
https://gitlab.com/kicad/code/kicad/issues/10137
2021-12-30 09:21:35 +01:00
7c3f0612f1
DIALOG_SPICE_MODEL: fix a cosmetic issue (no room for the help text)
...
Fixes #10170
https://gitlab.com/kicad/code/kicad/issues/10170
2021-12-30 09:19:00 +01:00
44dc602d6b
Yeet wxPoint/wxSize out of PLOTTER
2021-12-29 19:02:50 +00:00
ccb94fd1a7
APIs for passing KIFONT::FONT pointers around.
...
Also some clean-up and bug fixes.
2021-12-29 17:32:19 +00:00
dd6cd7d184
Pull some more improvements in from rockola/kicad-strokefont.
...
This one is primarily about pushing TEXT_ATTRIBUTES in to the GAL
API, but it also includes adding EDA_ANGLE signatures to some trig
routines to ease integration.
2021-12-29 17:32:19 +00:00
906eee68a5
Another small cleanup after !490
2021-12-29 17:41:21 +01:00
3f711b8958
Add win32 VERSION_INFO resource blocks for the DLLs
2021-12-28 23:54:27 -05:00
bf2c4c1584
Eeschema: draw dangling end shadows
2021-12-29 00:06:12 +00:00
56a31900d3
Formatting.
2021-12-28 22:47:05 +00:00
86cb57f4a7
Cherry-pick TEXT_ATTRIBUTES and EDA_ANGLE from rockola/kicad-strokefont
2021-12-28 22:15:20 +00:00
a0c4f05c17
Small cleanup after !490
2021-12-28 23:07:30 +01:00
7b1b96c933
Fix broken tree book selection in paged dialogs.
...
This only affected the tree controls that only parented sub-pages. Do
not use the dialog ctor to select the initial page. Queuing a page
changed event to fire after the dialog is shown is the proper solution.
2021-12-28 09:43:57 -05:00
8167c69508
Add transformation function for characteristic curves of tuners
2021-12-28 02:53:39 +01:00
f004665df8
Add tuner support for potentiometer code model
2021-12-28 02:53:39 +01:00
e618ef98e9
Add potentiometer code models to model selection
2021-12-28 02:53:39 +01:00
705aa64c24
Fix parent of schematic setup parent nodes
2021-12-27 19:08:41 -05:00
9ba733f23f
altium: Import POLY shape instead of line approximation ( #8741 )
2021-12-27 17:22:28 +01:00
82ab04c1d6
altium: Use newly introduced RECT shape, apply fill and improve stroke handling ( #8741 )
2021-12-27 16:50:30 +01:00
8b714deae1
altium: Add support for circle and arc in schematic ( #8741 )
2021-12-27 16:02:12 +01:00
d105e773a1
Update columns when height changes too
2021-12-25 15:26:43 +00:00
45c50535c5
Use GetUnobscuredSize in dialogs/panels
2021-12-25 15:26:43 +00:00
c4a4862e8f
Try with KIPLATFORM
2021-12-25 15:26:43 +00:00
b0cca4a89e
Symbol Fields Table: Make list look as good as possible on Windows too
2021-12-25 15:26:43 +00:00
933b82495d
Use ISO 128-2 values for dashed line defaults.
2021-12-25 14:00:57 +00:00
ec104e4ab0
Add hint to symbol editor defaults.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9776
2021-12-24 23:25:07 +00:00
03a2723b67
Improve GUI of lib item colors.
2021-12-24 21:21:11 +00:00
e2fc105201
Add custom fill color selection to shape properties dialog
2021-12-24 21:21:04 +00:00
45d7f68f38
Use actual custom fill color for painting
2021-12-24 21:20:59 +00:00
80e7b6eb1f
Save and load fill color of SHAPE_T objects properly
2021-12-24 21:20:54 +00:00
3b04fc7dca
Use real text measurement for pin bounding boxes.
2021-12-24 21:10:28 +00:00
29c942816e
Reduce duplication of settings.
2021-12-24 21:10:28 +00:00
24ce4d8aa2
Improve help text now that we're past string freeze.
2021-12-24 18:13:26 +00:00
e48d4a653a
Pick better auto-generated netnames.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4312
2021-12-24 18:13:16 +00:00
c3552a940a
Make sure standard OK/Cancel buttons respond to current language.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9635
2021-12-24 18:13:11 +00:00
af13533b42
Add show/hide controls for ERC markers.
...
ADDED show/hide controls for ERC warnings, ERC errors and ERC exclusions.
Fixes https://gitlab.com/kicad/code/kicad/issues/7270
2021-12-24 17:38:50 +00:00
a6dd1bf09b
Implement Reset to Defaults for all preferences panels.
2021-12-24 17:38:39 +00:00
4cf3f44532
More consistency with hint messages.
2021-12-24 17:23:41 +00:00
9de62d1dd4
Promote to cell selection for spreadsheet-style paste.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9211
2021-12-24 16:29:23 +00:00
889970a449
SCH_NETCLASS_FLAGs and SCH_FIELDs for labels.
...
ADDED: a new label type for netclass flags.
ADDED: the ability to define fields on labels.
2021-12-24 16:13:27 +00:00
f7721dd274
Add highlight shadows for highlighted nets.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8817
2021-12-24 15:43:28 +00:00
9ee28ea8f5
Flatten out some more preferences.
2021-12-24 15:43:20 +00:00
68d2630d08
Flatten a layer of indirection out of 3D config settings.
2021-12-24 13:08:54 +00:00
d28714167c
All the preferences, all the time.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7877
Fixes https://gitlab.com/kicad/code/kicad/issues/5153
2021-12-24 13:08:44 +00:00
f1410f0240
Line styles for PCBNew shapes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2150
2021-12-24 12:36:59 +00:00
e92efebb5f
Formatting.
2021-12-24 11:39:57 +00:00
295a6408c3
User-configureable dash styles (and dash-dot-dot).
...
ADDED: Schematic Setup properties for dash length and gap length.
ADDED: dash-dot-dot line style
Fixes https://gitlab.com/kicad/code/kicad/issues/2206
2021-12-23 20:36:24 +00:00
e26341d424
Cleanup.
2021-12-23 20:36:18 +00:00
92e589b398
Use board maxError value, and return SH_ARC for unfilled circle.
2021-12-23 20:36:11 +00:00
2bc86fa0a8
Shapes for schematic.
...
ADDED arc, circle and rectangle shapes for schematic. Shapes support
line styles and fill colors.
CHANGED sheet background color in Edit Text & Graphics Properties to
fill color (and it now affects shapes).
Pushed STROKE_PARAMS down into common and moved all shapes to using it
for stroke descriptions.
2021-12-23 20:36:07 +00:00
f089cf44a7
Allow a 0 pin-symbol-size.
...
This is particularly important when reading legacy projects as 0 is
what signals the painter to use the old algorithm (1/2 pin name/number
size).
Fixes https://gitlab.com/kicad/code/kicad/issues/10100
2021-12-23 16:54:03 +00:00
6e2460ad37
Add hot-updating of units in common wxGrids.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10020
2021-12-23 16:54:03 +00:00
9af33cdfe8
Don't leave stranded symbols/footprints in editors when doc closes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10026
2021-12-23 16:54:03 +00:00
ee5db73113
Use a bigger hammer to update adjacent segments.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9927
2021-12-23 16:54:03 +00:00
aa4dcb2bf1
Make sure undo/redo of pagesetup is done to correct sheet.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9999
2021-12-23 16:54:03 +00:00
8b52e969d6
Restore units to a bunch of wxGrids.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10063
2021-12-23 16:54:03 +00:00
160328abc7
Fix arc printing for flipped shapes.
2021-12-20 18:07:27 +00:00
f2ad8bffe0
Fix a mistake in Altium parser
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10011
2021-12-16 05:49:39 +03:00
40d44c94cd
Fix single-threaded loads/connectivity
...
We cannot set thread counts to hardware_concurrency()-1 without
considering that single core machines will get a thread count of 0.
2021-12-14 17:18:46 -08:00
1ca90f31bf
Fix hidden column in DIALOG_SYMBOL_FIELDS_TABLE.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9987
2021-12-15 00:03:33 +00:00
2dbc6ef6ca
If present, tune Spice_Model instead of Value
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9880
2021-12-14 14:02:25 +01:00
4fd5c9cfa8
Adjust macOS BOM plugin Python path
2021-12-13 22:52:31 +00:00
5e2ca2aa2a
Install kicad_utils.py BOM plugin helper
2021-12-13 22:52:31 +00:00
755607b8f8
Fix a few wxUpdateUIEvent retrigger loops.
2021-12-13 15:46:13 -05:00
653c7b78d7
Move NC pin logic so we set it before we need it.
...
Also fixes drawing the dangling symbol in the Pin Properties dialog
and when printing.
Fixes https://gitlab.com/kicad/code/kicad/issues/9962
2021-12-12 22:25:36 +00:00
067fa65756
Eeschema: fix a multitude of LIB_FIELD object comparison and index bugs.
...
It is no longer acceptable to set a LIB_FIELD index to -1. This was
trashing the sorting on load cause all kinds of false field comparison
failures. There are now assertions when attempting to use -1 as a field
index.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9811
2021-12-12 17:06:32 -05:00
4ccfc21324
Fix event id intersections when toggling some columns via popup.
...
Also increases maximum show/hide column count to 50.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9765
2021-12-13 00:35:44 +03:00
885979ba75
Fix selection logic to handle LIB_ITEM as well as SCH_ITEM.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9954
2021-12-12 17:38:38 +00:00
88fc6d25a7
Correctly handle deleting multiple selections in some grids.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9952
2021-12-12 17:28:17 +00:00
d1e6c216e1
And the modify bit wasn't getting set either.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9926
2021-12-11 01:09:13 +00:00
15d1abeeef
Sigh. But addCorner() *does* need mapCoords().
...
And it's got an off-by-one error in it too. I don't think this
ever worked at all.
Fixes https://gitlab.com/kicad/code/kicad/issues/9926
2021-12-11 01:06:36 +00:00
1f126c5619
Hittesting already handles inverse coordinate system.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9926
2021-12-11 00:32:24 +00:00
91dace3e5e
Update Eagle importer
...
Fixes arc orientation
Sets root schematic and page numbers
Fixes https://gitlab.com/kicad/code/kicad/issues/9907
2021-12-10 15:41:25 -08:00
8c5dd46861
Undo for SCH add/remove corner.
...
(PCB_POINT_EDITOR uses a BOARD_COMMIT and so already handles undo.)
Fixes https://gitlab.com/kicad/code/kicad/issues/9925
2021-12-10 23:08:16 +00:00
1b2a278de9
Don't put "exclude from board" symbols in CvPCB netlist.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9939
2021-12-10 23:00:50 +00:00
65cbf2d2b7
Eeschema: fix draw issue for global labels in Cairo mode.
...
Fixes #9933
https://gitlab.com/kicad/code/kicad/issues/9933
2021-12-10 20:47:17 +01:00
0ad0627bb0
Overhaul drag-select logic to handle children better.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6662
2021-12-10 18:44:07 +00:00
4f60d7ac78
Don't use lib tree target if lib tree isn't shown.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9913
2021-12-10 00:34:22 +00:00
832eb0d019
Fix off-by-one error in grid snapping.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9013
2021-12-09 16:35:11 +00:00
af280f80e0
Fix debug assertion in Altium and CADSTAR schematic importers.
2021-12-09 12:56:03 +00:00
b7af66e3f9
Eeschema: fix broken page numbers when renaming a sheet file name.
...
Always use full sheet paths when storing sheet instances. Partial sheet
paths cannot be full resolved resulting in lost page numbers when renaming
sheet file name.
Fixes #9782
2021-12-09 12:56:03 +00:00
f7fb756f78
All imported schematics need connectivity update
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9907
2021-12-08 16:27:24 -08:00
9c619d8f4e
Allow some navigation tools when selecting
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9565
2021-12-07 23:00:39 +00:00
3d97138d92
Bug fix for dangling symbols on pins.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9667
2021-12-07 21:39:06 +00:00
c4336de868
Bug fixes in new dangling symbol drawing code.
2021-12-07 21:31:42 +00:00
84cdc9701f
Partially reverts d877f041
...
Based on discussion in https://gitlab.com/kicad/code/kicad/-/merge_requests/1029
we will keep the original behavior. The new routines to get stock paths
are still useful (possibly in scripting) and are kept
2021-12-06 16:14:40 -08:00
73b39e836d
Set modify bit when editing page layout.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9891
2021-12-06 23:08:33 +00:00
2e342ed8c9
Draw dangling symbols on a separate layer.
...
This allows us to draw them in front of wires, pins, and most
importantly, junction dots.
Fixes https://gitlab.com/kicad/code/kicad/issues/9667
2021-12-06 18:50:50 +00:00
a03e6e4926
Revert "Eeschema: fix broken page numbers when renaming a sheet file name."
...
This reverts commit a468a79948
2021-12-06 07:47:18 -05:00
5ae844ba93
Revert "Fix SCH_SHEET object assignment operator bug."
...
This reverts commit 37d53a7147
2021-12-06 07:47:02 -05:00
a205595404
PROF_COUNTER -> PROF_TIMER
...
I want to add an event counter, and this one is a timer
2021-12-05 14:25:37 -05:00
10be483430
Make an exception for SCH_TEXT in SELECTION::GetCenter()
...
And undo the previous changes in SCH_TEXT::Rotate().
We continue hitting this with a wrench until it gets fixed or becomes
broken beyond any recognition.
2021-12-04 05:32:48 +01:00
cb482eb8eb
Symbol Fields Table: Highlight proper symbols even if they aren't annotated
2021-12-03 20:35:54 +00:00
9efbeaa064
Dark theme support for SPICE model editor
2021-12-03 03:41:32 +01:00
83162364e7
Restore old rotation behavior for SCH_LABEL
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9861
2021-12-03 01:43:02 +01:00
d877f04198
fixe paths
2021-12-02 20:23:00 +00:00
863699f2d1
Fix logic error in selection tool.
...
Any new selection made by clicking is not a hover selection.
Fixes https://gitlab.com/kicad/code/kicad/issues/9857
2021-12-02 16:56:47 +00:00
4ba110e1ec
Restore original SCH_TEXT::GetBoundingBox()
...
Didn't intend to commit this, it was a mistake.
2021-12-02 16:43:19 +01:00
bb08ef2f41
Fix SCH_TEXT rotation around a reference point
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9690
2021-12-02 16:35:35 +01:00
50c1a91d44
Add a simple open wrapper for the bom python plugins to handle directory creation
2021-12-02 01:07:55 -05:00
3960c2441b
Snap rotation center to half-grid, not grid
2021-12-01 17:53:42 +01:00
9f568d3658
Eeschema: Add support for leading zeroes when auto-incrementing names ( fixes #9831 )
2021-12-01 13:20:35 +00:00
37d53a7147
Fix SCH_SHEET object assignment operator bug.
2021-12-01 07:19:30 -05:00
3a00d76207
Fix a compil warning (shadowed var) and add a comment.
2021-12-01 11:05:16 +01:00
bfe595819a
Prevent error when loading bitmaps from some old schematics
2021-12-01 09:54:48 +00:00
6d8642e44c
Remove default settings missed in 025d9f82ea
2021-12-01 01:59:40 +00:00
85ab4e5886
Don't deselect wires when aligning
...
This makes undo/redo look really strange as the other elements get
aligned but the wires do not (or rather their unconnected ends do not)
Fixes https://gitlab.com/kicad/code/kicad/issues/9275
2021-11-30 16:30:28 -08:00
a468a79948
Eeschema: fix broken page numbers when renaming a sheet file name.
...
Remove duplicate instance data saved in both root SCH_SCREEN and SCH_SHEET
objects that was causing them to be out of sync. All sheet instance data
is stored in the SCH_SHEET object itself and rebuilt on the fly so it is
always current.
Remove Get/SetPageNumber from SCH_SHEET_PATH object so it doesn't obfuscate
where the actual sheet page number information exists.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9782
2021-11-30 08:11:24 -05:00
5750e38102
Re-enable and fix Move+Autoplace Fields
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9766
2021-11-29 20:48:16 +00:00
a0711bdb56
Keep previous commit from violating string freeze.
2021-11-29 20:09:35 +00:00
78be5df39a
Don't allow negative line widths to shrink bounding box.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9776
2021-11-29 20:02:03 +00:00
a0f1d77eaa
Quiet wxWidgets assert.
2021-11-29 18:54:47 +00:00
91363dd93c
PANEL_EESCHEMA_COLOR_SETTINGS: fix a minor cosmetic issue.
2021-11-29 15:30:38 +01:00
3a51fb6ac6
Be more consistent about annotation warngings.
...
This can be a particular problem if you go to run ERC, it shows the
annotation warnging so you re-annotate (but don't notice that your
scope is set to Selection).
Also adds some missing defensive code around closing a modeless RC
checker before the document (which we had for DRC dialog but not the
ERC dialog).
Also fixes a missing override of GetSeverity which kept ERC messages
from having the right prefix.
2021-11-29 14:24:45 +00:00
a224d8dd6c
Disable autoplace fields when dragging/moving.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9766
2021-11-28 19:18:08 +00:00
9bb370e6b4
SCH_SHEET_PIN: Rename GetEdge, SetEdge to GetSide, SetSide
2021-11-28 20:07:06 +01:00
80d6b9e76d
Tighten up hittesting for symbols and other items.
...
Grid-based accuracy doesn't need to be any larger than 1/2 the
diagonal as we'll snap to one side or the other. And symbols don't
need as much slop as other items since there's plenty of "meat" on
them.
Fixes https://gitlab.com/kicad/code/kicad/issues/9805
2021-11-28 19:03:51 +00:00
71bfbfaa70
Test SCH_PIN rotation and mirroring
2021-11-28 19:37:13 +01:00
2e1862de1c
Run AutoAutoplaceFields() in SCH_SHEET constructor
...
A constructor should create a fully initialized object.
2021-11-28 18:46:28 +01:00
75d750a3cb
Copy lastResolved stuff when pasting.
...
This of course assumes the paste came from the same document. If not
then pasted items will get default lastResolved stuff.
2021-11-28 17:09:24 +00:00
58b5ac4970
Don't create SCH_LINE till we know the layer.
...
The CTOR makes some decisions on initialization based on the layer.
2021-11-28 17:09:24 +00:00
f23cd9c9e5
Clearer naming.
2021-11-28 17:09:24 +00:00
d7f5917fb0
ERC: flag duplicated local labels with no pins as floating
...
See https://gitlab.com/kicad/code/kicad/-/issues/9593
2021-11-27 22:34:11 -05:00
65af3a8568
Make sheet pin positions invariant to four rotations more often
2021-11-28 02:18:18 +01:00
dd219419a0
Quiet wxWidgets asserts (sheet & symbol properties dialogs)
...
Ensure we don't set column size smaller than 1. If so, set to
-1 to auto size.
2021-11-27 21:03:42 +00:00
3660597082
Use canonical names when saving sheet name and filename fields
2021-11-27 20:38:51 +00:00
f35b0446e6
Properly initialize SCH_TEXT spin style
2021-11-27 19:42:11 +01:00
9f7db24871
Selection bug fixes for Symbol Editor.
...
1) Make sure the y-coord is correctly inverted before calling collision
routines.
2) Give LIB_SHAPE poly lines the same extra slop as SCH_LINEs.
Fixes https://gitlab.com/kicad/code/kicad/issues/9791
2021-11-27 15:17:05 +00:00
87e71072b1
Default line width to 0 in symbol editor.
...
Also removes some atrophied settings for repeated non-pins in
symbol editor (which only ever repeats pins).
Fixes https://gitlab.com/kicad/code/kicad/issues/9776
2021-11-27 11:53:38 +00:00
b8b8c0d34c
dialog text properties: fix a focus issue.
...
Fixes #9792
https://gitlab.com/kicad/code/kicad/issues/9792
2021-11-27 10:08:30 +01:00
698a668af7
Coverity fixes.
2021-11-26 18:14:29 +00:00
08cb573e11
Do not propagate bus entries across buses and wires at the same point
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9678
2021-11-25 13:36:30 -05:00
aa5f496727
Properly migrate bus-bus entries on load of legacy schematic
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9678
2021-11-25 12:12:01 -05:00
5863bc0937
Put Repair Schematic behind Advanced Config.
2021-11-25 12:56:46 +00:00
c7dd98fb1a
Fix outdated syntax in help text
2021-11-25 12:53:29 +00:00
9f6910f1e6
Expand autoplace collision search to include potential field locations
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9762
2021-11-25 07:48:05 -05:00
5e6da9f964
Auto-start-wire tool requires an up-to-date connectivity.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
2021-11-25 01:24:35 +00:00
5d751bef74
Be cognizant of connectivity dirtiness when cloning wires.
...
While the root case is wires, it really applies to all SCH_ITEMs.
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
2021-11-25 01:24:35 +00:00
f11cc904d2
More fixes for realtime connectivity being off.
...
Don't update net highlighting until after connectivity has been
rebuilt.
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
2021-11-25 01:24:35 +00:00
ed705986e0
No realtime connectivity fixes for junctions.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
2021-11-25 01:24:35 +00:00
2eb5d4fa7a
Symbol Editor: Allow save as all the time, as long as we have a symbol to save
...
There doesn't appear to be any reason why the LIBID needs to be populated
before a "save as", seeing as the user will be inputting the new lib name
and lib nickname via the dialog.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9744
2021-11-24 19:43:09 +00:00
7fc04c3cf2
Fixes for realtime connectivity being off.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
2021-11-24 13:20:44 +00:00
9e999f4de4
ADDED Repair Schematic.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9749
2021-11-24 13:20:44 +00:00
228edd4121
Don't generate duplicate IDs in line/wire/bus tool.
...
Also cleans up existing duplicate IDs when reading.
Fixes https://gitlab.com/kicad/code/kicad/issues/9749
2021-11-24 13:20:44 +00:00
b052d56c7b
R/W uuids for junctions.
2021-11-24 13:20:44 +00:00
696f7c47fb
Reduce use of auto.
2021-11-24 13:20:44 +00:00
65fc47cb8f
Don't lose track of the sheet's screen
...
Corner cases need to clear screen before loading a new file. Aborting
needs to restore the screen or risk segfaults
Fixes https://gitlab.com/kicad/code/kicad/issues/9739
2021-11-23 10:57:12 -08:00
126563c839
Fix initilization project / ordering
...
We cannot resolve the Canvas type without the canvas being initialized.
But saving settings sometimes requests canvas access. This protects the
calls against failure by checking for canvas before saving
canvas-specific settings
Fixes https://gitlab.com/kicad/code/kicad/issues/9729
2021-11-22 11:47:42 -08:00
3f2d86adec
Make OpenGL default for all apps
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9699
2021-11-21 12:33:07 -08:00
016a98df86
Increment numbers which have suffixes too.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9706
2021-11-21 18:02:17 +00:00
15f309c8a8
Add a SCH_ITEM::operator= so the connections caches don't get copied.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9710
2021-11-21 16:54:46 +00:00
c1703212dc
"Document" properties go in File menu; Edit menu is for item props.
2021-11-20 22:44:43 +00:00
2159acc9ce
Fix missing handler for multiple labels
...
This was intended to handle multiple labels but we missed the selection
condition.
Fixes https://gitlab.com/kicad/code/kicad/issues/9704
2021-11-20 14:37:18 -08:00
5a5af91d88
Tidy up the SCH_PREVIEW_PANEL visibility flags.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9701
2021-11-20 15:28:17 +00:00
766a09c338
Remove autocomplete when we lose focus
...
Prevents the excess dropdown from persisting over windows
Fixes https://gitlab.com/kicad/code/kicad/issues/9651
2021-11-19 17:24:16 -08:00
c01649fc6e
Make it easier to open legacy files.
2021-11-19 13:36:14 +00:00
7bda077f69
Disable EE_POINT_EDITOR for uneditable symbol graphics.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9675
2021-11-18 15:38:46 +00:00
1bb750814d
Cleanup dead code.
2021-11-17 12:49:53 +00:00
9238b27f63
Silence IsWritable warning message
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9656
2021-11-16 21:02:32 -05:00
969bef9a36
Fix stroking error when printing polygons.
2021-11-17 01:53:44 +00:00
7760d3275d
Fix printing of LIB_SHAPE arcs.
2021-11-17 01:39:16 +00:00
20328ab331
Back out last arc change.
2021-11-17 01:03:22 +00:00
18d8053a6c
Fix an arithmetic precedence order bug and fine tune autoplacement.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9345
2021-11-17 00:49:42 +00:00
b4ac53d93d
Attempt #1 to fix LIB_SHAPE arc printing.
2021-11-17 00:34:05 +00:00
399f2c116e
Symbol editor: save changed field properties
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9648
2021-11-15 20:40:32 +01:00
12a75ffb94
A fuller implementation of allowing cut/copy/paste in search boxes.
...
This one also works for other text entry widgets, and also works
for other frames.
2021-11-15 18:13:35 +00:00
9941a52e75
fix for issue #9345 autoplacing in schematic
...
this fix moves designator fields to the side in case of collision with
symbols or wires.
2021-11-14 18:02:36 +01:00
ae24daa033
Do not include text when computing drag origin for a group
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9630
2021-11-14 11:54:04 -05:00
b747ae5bdf
Make sure redraw happens regardless of order of panel commits.
...
(We don't control the order of the TransferDataFromWindow calls
for the various panels and here the junction dot size is dependant
on the default netclass wire size. So that calc has to be done
after all the various TransferDataFromWindow calls are made.)
Fixes https://gitlab.com/kicad/code/kicad/issues/9541
2021-11-13 23:20:56 +00:00
025d9f82ea
Remove atrophied schematic default wire and bus widths.
...
(They're now in the netclasses, and specifically the default netclass
if no other netclass is assigned.)
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
2021-11-13 22:56:50 +00:00
efc64e972c
Fix pasting into LIB_TREE search control.
...
We have a hack for turning accelerator keys that wxWidgets turns into
menu commands back in to accelerator keys -- but it requires that the
corresponding menu items be enabled in order to work.
2021-11-13 19:45:10 +00:00
cc6e3841ae
Formatting.
2021-11-13 19:45:10 +00:00
80c5b1efb1
File formatting improvements and fixes.
...
Symbol library IDs included the library nickname which is incorrect
and meaningless since it will be overwritten by the symbol library
table code. This is not a file format change as there are no behavioral
differences.
2021-11-13 12:57:18 -05:00
53f5d616aa
Coverity issue fixes.
2021-11-13 11:38:31 -05:00
e218471d24
DIALOG_CHANGE_SYMBOLS: fix a bug introduced by my commit 686b32db
...
the filtering for mandatory fields was disabled.
2021-11-13 13:47:09 +01:00
1e151b1bcb
Fix effective pen width when plotting wires.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9625
2021-11-12 16:27:55 +00:00
da58e9ee4c
Don't rely on selection when updating edited symbol in schematic.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9600
2021-11-11 16:43:06 +00:00
686b32dbd3
fix issue in DIALOG_CHANGE_SYMBOLS, in non English locale.
...
Mandatory field names where compared in list, using translated and not translated names.
Fixes #9596
https://gitlab.com/kicad/code/kicad/issues/9596
2021-11-11 10:56:09 +01:00
54e00569d8
Don't fetch the root sheet's UUID out of the sheet instances.
...
1) we're storing it now anyway
2) the root sheet UUID is the one UUID that's *not* in the instance
array, and previously we were erroneously grabbing the first sub-sheet's
UUID (producing duplicate UUIDs).
2021-11-09 16:07:30 +00:00
6e5a918377
Writeable -> Writable
2021-11-08 15:56:51 -08:00
de93a071e2
Fix error in python command string generation.
...
(We can now go back to using double-quotes since that bug is fixed.)
Fixes https://gitlab.com/kicad/code/kicad/issues/9552
2021-11-08 21:05:54 +00:00
cd3ecdfc78
Fix sort to be irreflexive
...
Switching the order of the parameters must switch the sort order (no <=)
otherwise the sort is non-determinant and fails std::sort preconditions
2021-11-08 11:25:13 -08:00
38bd4b07e4
Close the simulator before changing schematic
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9501
2021-11-07 23:35:06 +00:00
04a30638f0
eeschema: Pasted items are moving as soon as they are pasted
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9539
2021-11-07 15:14:11 +00:00
f9a282278c
Update junction-dot-size-cache when Schematic Setup changes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9541
2021-11-07 14:12:44 +00:00
b572781a8a
eeschema: Update anchor position of pasted items after initial move
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9534
2021-11-06 16:03:41 +00:00
d1bab3116d
eeschema: Warp to origin when moving - add missing text items
...
Schematic fields and text items were not being warped to origin when
moving.
2021-11-06 15:19:22 +00:00
2f22b9dd81
Do not replace delimiter " by ' inside a command string, round 2.
2021-11-05 18:28:44 +01:00
83e5208213
Fix a couple of holes in the IsTestEnabled() checks.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7270
2021-11-04 16:24:06 +00:00
996a5b85a6
Overhaul IsJunctionNeeded logic to support all the different cases.
...
Several clients were using this with different needs. The API is
now more explicit (and there are more options under the hood).
Fixes https://gitlab.com/kicad/code/kicad/issues/9518
2021-11-04 12:57:16 +00:00
cf6b18ec7e
Remove escaped double-quotes
...
For some reason, escaped double quotes in wxString::Format cause issues
on Mac. We can replace them with single quotes in most places without
loss of clarity
2021-11-03 17:03:14 -07:00
179628d1d2
Repair field properties dialog for rotation and mirroring.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9508
2021-11-03 18:11:59 +00:00
5e040ad126
eeschema settings: Default to mouse drag is drag action on first install
...
This is to be consistent with other EDA tools like Altium and CADSTAR.
2021-11-03 16:58:11 +00:00
c2371f3943
Revert e4b61de792.
...
It doesn't seem to fix the testcase on Linux, and the tests pass on
my machine in either configuration.
2021-11-03 10:30:34 +00:00
e4b61de792
Special case sheet ordering in file.
2021-11-02 23:14:01 +00:00
7cf72aaa41
Fix bezier import in Altium schematics
2021-11-02 15:45:30 -07:00
4d46445ce1
Fix Bezier reading.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9512
2021-11-02 22:19:41 +00:00
4acff58c7a
Implement a forced ordering for LIB_ITEMs until we have UUIDs.
...
(Once we read/write the UUIDs, we should just compare the type
and then the UUID like we do for SCH_ITEMs.)
2021-11-02 20:07:34 +00:00
eaf10a04dd
Improved naming.
2021-11-02 20:07:34 +00:00
21cb56dfe7
Formatting.
2021-11-02 20:07:34 +00:00
9e760512ac
Update schematic when saving tuned value
...
Also avoids a known(!) crash when the existing item has been deleted
while tuning.
Fixes https://gitlab.com/kicad/code/kicad/issues/9502
2021-11-01 17:05:22 -07:00
f79cb382c4
Symbol editor: fix name corruption in pin table
...
Discard changes to pin numbers of grouped pins in the pin table to avoid
setting all pins of the group to the same number.
2021-11-01 22:10:13 +00:00
af95a4b424
Fix duplicate stroke when formatting circles.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9507
2021-11-01 21:29:46 +00:00
40b4052ad4
Improve text hittesting in schematics.
...
Text has a fairly big bounding box to account for descenders, overbars,
etc., but it makes it feel too sloppy for hittesting. This change
allows selection disambiguation to look at the actual strokes of the
text when deciding what's "closest".
Fixes https://gitlab.com/kicad/code/kicad/issues/9506
2021-11-01 21:13:12 +00:00
bf85ddd577
Eeschema: fix bug printing polygon (possibly other) filled shapes.
2021-11-01 16:09:32 -04:00
9f806d9304
Don't assume the grid size.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9013
2021-11-01 15:26:39 +00:00
cec788d454
Must use GetEffectivePenWidth for output.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9504
2021-11-01 14:49:12 +00:00
b6c12b6b55
CADSTAR Sch: Fix positioning of symbol fields when the symbol is mirrored
...
The text aligment needs to be rotated and/or mirrored depending on whether
the text field is vertical or horizontal.
2021-10-31 16:12:08 +00:00
8367c7f238
CADSTAR Sch: Fix calculation of page size
...
Don't attempt to calculate bounding box of text variables. We do not
know the resolution of the text variable inside the importer. The
resolved text could be shorter than the text variable (e.g. ${#}
page number)
2021-10-30 21:49:34 +01:00
0aba025d66
CADSTAR Sch: Autoplace intersheet references (instead of 0,0)
2021-10-30 21:49:34 +01:00
18e36155a5
CADSTAR sch: Include gate in error message when symbols are scaled
2021-10-30 21:49:34 +01:00
52a936ac61
CADSTAR Sch: Fix spurious pin length and orientation of some symbols
...
Ensure deterministic sorting of std::map in fixUpLibraryPins
2021-10-30 21:49:34 +01:00
f345eacf13
Be more careful with undo, and don't re-merge a bus over a bus entry.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9475
2021-10-30 19:58:09 +01:00
c5cdda26ae
Fix crash in libedit when moving/editing pins in synchronised mode
...
Unit numbers start at 1, not 0. Our vector needs to be size + 1 if we want
to use the unit number as an index.
0 is reserved for "all units"
2021-10-30 18:14:23 +01:00
c1515dd31c
CADSTAR Sch: Fix block names - load as stand-alone text items instead
...
KiCad doesn't support multi-line text in fields, so we can't load it as
a text field (even if that would be the closest thing).
We should update this when KiCad supports multi-line text in fields.
2021-10-30 18:14:23 +01:00
d426abafd7
Handle empty shape in removeCornerCondition
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9495
2021-10-30 13:10:12 -04:00
80e372b7d9
Fix blank DC sources causing crash in dialog creation
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9482
2021-10-30 11:17:10 -04:00
5f8e0ef1e0
Patch up arc hit-testing and printing for 6.0
...
This could use another look when we're not so near release. We
really shouldn't need to special case eeWinding vs. not eeWinding.
Fixes https://gitlab.com/kicad/code/kicad/issues/9491
2021-10-30 15:10:07 +01:00
b967610e05
Remove confirmation for De Morgan (and spell his name right).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9483
2021-10-29 20:30:37 +01:00
1fa9ad227a
Repair new junction logic for crossing wires.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9484
2021-10-29 19:09:02 +01:00
fe6cb7dbb4
Mirror sheet fields when mirroring sheet.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9479
2021-10-28 21:45:22 +01:00
0cdffa16d4
Fix off-by-one error in fill mode writing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9111
2021-10-28 19:29:47 +01:00
8fdfc0e63d
Replace legacy sch writing code for rescue functionality.
2021-10-28 15:11:15 +01:00
cf6acae791
TUNER_SLIDER: add missing skip event in wxFocusEvents.
2021-10-27 20:33:51 +02:00
18318c73b5
Fix swapped parameters
2021-10-27 08:59:39 -07:00
c3a4c40d4c
DIALOG_CHANGE_SYMBOLS: add missing skip event in wxFocusEvents.
...
Fixes #9467
https://gitlab.com/kicad/code/kicad/issues/9467
2021-10-27 17:17:44 +02:00
cb1709b4ca
Improve Eagle importer's label positioning.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9466
2021-10-27 13:49:13 +01:00
e14864b35c
Invert Y axis for pin root bounding box.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9465
2021-10-27 01:44:15 +01:00
3d2ffc12c1
Fix bugs in B&W plotting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9411
2021-10-26 22:58:55 +01:00
dd99b2dc2f
Add action to edit symbol from Library
...
Analog of ea4e06124e
2021-10-26 12:59:59 -07:00
f724fe7eff
Move bbox padding to RTrees so it doesn't interfere with hittesting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9361
2021-10-26 13:46:30 +01:00
8e5cbc5cf0
Fix highlighting complex connections from subsheets
...
Sheet() can't be used for local sheet recall in these cases
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9403
2021-10-25 22:14:48 -04:00
c52cb229d0
Add unsaved-changes indication to Symbol Properties.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9443
2021-10-25 12:35:04 +01:00
e30d867439
Use consistent terminology for various constraint modes.
2021-10-23 12:18:08 +01:00
30027030b5
Threading safety.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9399
2021-10-23 11:38:03 +01:00
3ea3d5274c
CADSTAR Schematic: Hide all KiCad sheet properties
...
Sheet name/filename not applicable in CADSTAR so displaying it just
makes the import look messy.
2021-10-23 10:58:15 +01:00
927b633c01
Make sure spice command doesn't assert
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4328
2021-10-22 16:50:29 -07:00
4dcc847f85
Remove artificial limits from label increment control.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9340
2021-10-22 22:20:20 +01:00
29756278e0
eeschema: fix crash when the simulator frame is open and the Tune tool is actived.
...
In some cases when the Tune tool is actived and a symbol is selected, if the tool
is deactivated from the right toolbar in Eeschema, Eeschema crashes.
2021-10-22 20:00:14 +02:00
28d7a2d7c9
Sim: Update tuner dialog values when focus is lost
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7841
2021-10-21 13:34:27 +00:00
0795fcb810
Minor dialog layout fixes.
2021-10-21 08:59:55 -04:00
bb4330db1e
DIALOG_BOM: do not quote filename when calling the editor.
...
Due to previous changes in code, filenames must be not quoted.
Fixes #9436
https://gitlab.com/kicad/code/kicad/issues/9436
2021-10-21 13:53:52 +02:00
c5e5d8e0d4
Fix multi-sheet find/replace issues.
...
1) When replacing symbol fields, make sure we do it for all sheets
2) Honour "find on current sheet only"
Fixes https://gitlab.com/kicad/code/kicad/issues/9431
2021-10-20 18:28:57 +01:00
75b5bcf46d
Make Coverity happy.
2021-10-19 17:14:04 +01:00
1e1da55840
Coverity fixes.
2021-10-19 07:42:27 -04:00
512ba167e8
Escape symbols when adding to library
...
Can't escape by default because the allowed characters differ in the
read-only libraries and existing schematics that reference them. So,
escape when we import into standard KiCad Libraries
Fixes https://gitlab.com/kicad/code/kicad/issues/9419
2021-10-18 10:42:58 -07:00
9b4c293f14
Ensure that any excess spaces removed
...
The sim command may have additional whitespace between the type and
first char
2021-10-18 10:12:53 -07:00
4e48a16847
Look for all types of label conficts in ERC.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9367
2021-10-18 18:09:40 +01:00
b8d193485d
Respect selection reference point when set.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8520
2021-10-18 18:09:40 +01:00
1d4d83cb7c
Fix copy/paste error.
2021-10-18 18:09:40 +01:00
82ba456567
Remove unnecessary RegEx
...
This broke for signals using underscores. More critically, RegEx is
fragile and should not be used with user input if at all possible
Fixes https://gitlab.com/kicad/code/kicad/issues/9421
2021-10-18 10:08:29 -07:00
64bcaaefd1
Fix radiobox order for FILL_T
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9412
2021-10-17 17:01:21 -07:00
5817a8b5f4
Remove unused m_host variable
...
This variable isn't needed anymore after 5f53019290
2021-10-18 00:29:40 +01:00
280743d9e9
Fix missing reference in for loop
2021-10-18 00:29:10 +01:00
d6d800ccbb
CADSTAR Schematic: Fix crash when trying to fix library pins
...
Need to copy the chain as we might have deleted it.
2021-10-17 17:57:51 +01:00
a1c1f60665
Coverity fixes.
2021-10-16 16:27:35 +01:00
ce55dd2893
Fix botched merge.
2021-10-15 21:27:16 +01:00
ec10b12c6a
On macOS, copy libngspice dylibs and symlinks
...
Now that ngspice creates soversion'ed libraries, we need to tweak
how we copy the dylibs around.
This is meant to address
https://gitlab.com/kicad/code/kicad/-/issues/9143 .
2021-10-15 17:34:27 +00:00
f9861b4a6c
Finish arc rework and push out to file formats.
2021-10-15 12:45:43 +01:00
b52529521e
Replace individual LIB_* shapes with LIB_SHAPE (based on EDA_SHAPE).
...
Also moves to more capable FILL_T model that can be shared.
2021-10-15 12:45:43 +01:00
9b9e379aa0
Overhaul arc internal model to not over-specify information.
2021-10-15 12:45:43 +01:00
c61af21da8
Eeschema: don't stat files when updating title bar text.
...
The tests for file existence and write status perform two file stats
which cause performance issues on slow network shares. Now the file
state is determined at load time and stored in the SCH_SCREEN object
so file access is no longer required.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9343
2021-10-14 10:52:58 -04:00
c4d0a06701
Eeschema: fix broken auto save feature.
...
Make auto save recover all auto saved sheet files not just the root sheet.
This does not fix existing auto save issues because recovery would require
an iterative reload for each automatically saved sheet file and would only
happen once.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9288
2021-10-13 14:51:00 -04:00
5f53019290
Substitute all wxHtmlWindow with HTML_WINDOW
...
Remove other places where <body> tag is used to override the default
black-on-white theme.
2021-10-12 07:07:15 +00:00
7aa3514042
CADSTAR Schematic: Add net labels for named nets on symbol pins
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9371
2021-10-11 18:30:21 +01:00
52bbfb9109
Remove dependency of dot size on linear mils
...
Changes a dot to be a square pixel (linewidth x linewidth). This allows
the removal of IU dependencies and ensures that a dot is always visible
on screen. Also makes sure that cairo is setting the current linewidth
during its stroke routines
Fixes https://gitlab.com/kicad/code/kicad/issues/9362
2021-10-10 09:40:26 -07:00
48f9dfa988
Revert "Fix grid cell highlight not functioning on Windows in the symbol pin table"
...
This reverts commit 94552ed838
2021-10-10 08:04:11 -07:00
57c7d663b0
Fix bone-headed mistake when moving panel disabling.
2021-10-07 00:17:42 +01:00
b5cd976845
Don't arbitrarily exclude components from BOM
...
We already exclude components based on the schematic property when
generating the XML. Don't make a hidden second pass in the python
netlist reader by default
Fixes https://gitlab.com/kicad/code/kicad/issues/9326
2021-10-06 12:58:05 -07:00
2c7da5e2bd
Handle deleting segment
...
Edited point needs to clear to allow us to use the click timer for
left-click after the drawing is deleted.
Fixes https://gitlab.com/kicad/code/kicad/issues/9320
2021-10-06 10:21:04 -07:00
95f841a037
A more nuanced method of making Board & Schematic Setup read-only.
...
This one still allows you to scroll to see all contents.
Fixes https://gitlab.com/kicad/code/kicad/issues/9302
2021-10-06 11:16:46 +01:00
935a307674
Formatting and iterator safety.
2021-10-06 11:13:16 +01:00
bb5c58b3cf
Set default force cursor off in auto-lines
...
Leaving the forced position on results in the auto-line linking to a pin
for far longer than we intend if there are other hits in the area of the
cursor
Fixes https://gitlab.com/kicad/code/kicad/issues/9321
2021-10-05 20:28:05 -07:00
854472d550
Prevent automatic RTree recaching
...
Calling UpdateItem() may be performed by in a common loop, e.g. for(
SCH_ITEM* item : GetScreen()->Items() ) or similar. We cannot call
GetScreen()->Update( SCH_ITEM* ) in this routine as it will remove and
re-add the item to the RTree, invalidating iterators. If needed, the
items need to be cached to an external container before updating
Fixes https://gitlab.com/kicad/code/kicad/issues/9318
2021-10-05 20:13:15 -07:00
9a8d1246cc
We don't keep a CHANGELOG.TXT
...
Direct interested readers to AUTHORS.TXT instead.
2021-10-05 19:46:53 -07:00
548e5f49bd
Clean up unused variable usage
...
Unused variables in function calls can be commented out. Unused
return variables get a new routine `ignore_unused()` that silences the
warnings with zero overhead.
2021-10-05 10:00:30 -07:00
92008a089a
Disable Board & Schematic Setup controls when project is locked.
...
(or missing).
Fixes https://gitlab.com/kicad/code/kicad/issues/9302
2021-10-04 16:47:27 +01:00
7c432d7a50
When annotating for another feature, make sure scope is entire schematic.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9303
2021-10-03 19:42:29 +01:00
574bef2237
Normalize drawing sheet path to env vars & prj, not just prj.
...
Also cleans up the dialog a bit.
Also changes the workings of NormalizePath to return the input if
it couldn't be shortened which saves open coding that behaviour in
all its callers.
Fixes https://gitlab.com/kicad/code/kicad/issues/9036
2021-10-02 23:39:45 +01:00
10dd70881c
New paramaterized interface doesn't like quoted parameters.
...
(At least on MSW, anyway.)
2021-10-02 14:08:36 +01:00
94552ed838
Fix grid cell highlight not functioning on Windows in the symbol pin table
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9290
2021-10-01 23:44:16 -04:00
ef74421922
Move centering of lib-tree item to idle event.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9294
2021-10-01 22:46:14 +01:00
5f5ee7335d
Formatting.
2021-10-01 21:49:14 +01:00
f606679164
Proper numeric sorting for intersheet refs.
...
Also expunges the horrifically named std::remove and std::remove_if
(neither of which remove anything).
2021-10-01 18:29:21 +01:00
5d579d14c1
Give intersheet refs a bit more breathing room.
2021-10-01 18:29:21 +01:00
dd1d36d40a
Fix segfault when check for editing points
...
The point editor is not always available when checking for points. We
need to handle the missing tool without crashing
2021-09-30 17:25:33 -07:00
b9596a0a5d
Update dangling flags in color settings' preview.
2021-09-30 18:53:39 +01:00
c7e6c273b4
Fix missing RTREE update.
2021-09-30 18:53:39 +01:00
13d913a014
Choose centering after zoom
...
When we zoom after centering, the screen does not display the item at
the appropriate location until you center again. Choose the zoom first
to set the appropriate scale before translating the viewport
2021-09-29 16:30:52 -07:00
12b726ba2f
Prevent the point editor from fighting with other tools.
...
1) Don't start a long-click timer when the point editor is active.
2) Don't auto-start a wire when the point editor is active.
Fixes https://gitlab.com/kicad/code/kicad/issues/9270
2021-09-29 19:16:06 +01:00
9cf9abbd66
Don't allow Text Properties dialog on intersheets references field.
2021-09-29 16:04:36 +01:00
62ef27e372
Remove hard-coded anchor color in eeschema
2021-09-28 20:26:47 -04:00
2225c4e4ed
Replace GetRows() with GetNumberRows() because wx
2021-09-28 10:48:04 -07:00
880f209563
When deleting pin row, show new highlight
...
When the user deletes a pin row, they need to see which row is now
selected for them to delete again. Otherwise, deleting will have
unexpected consequences
2021-09-28 09:29:55 -07:00
42a21e15f0
Check before dereference
...
Fixes a crash where the screen was destroyed during new loading but
still gets dereferenced by the UI update. Also puts defensive checks in
the UI conditions against null configuration settings
2021-09-28 08:42:55 -07:00
f73042fe24
Some minor performance enhancements.
2021-09-28 14:28:35 +01:00
7089a837f6
Update Editing Options Panel in eeschema with latest modifier keys
...
We now use Long Click, Ctrl and Shift (Alt is no longer used)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9234
2021-09-27 21:11:56 +01:00
d90dc77e00
Selection: Don't drop small moves
...
If we do a real drag, the timer will be cancelled. If we don't, then
the user is still holding the mouse button down and would probably like
to see the menu. Otherwise it appears the action is dropped.
2021-09-27 16:44:32 +00:00
d362cbc530
EEschema: change Save Copy As... to Save Current Sheet Copy As...
...
Save Copy As did not work with hierarchies (was not able to manage subsheets)
Fixes #9245
https://gitlab.com/kicad/code/kicad/issues/9245
2021-09-27 18:23:11 +02:00
c508c89a81
Pretty-up some warning messages.
2021-09-27 13:24:53 +01:00
5f3c67bd2b
Fill in some missing GetMsgPanelItems and make some others consistent.
...
Also expunges a std::vector<MSG_PANEL_ITEM> cover type.
2021-09-27 00:23:40 +01:00
8636afdc73
Use FocusOnLocation for symbol fields cross-probing too.
2021-09-27 00:23:40 +01:00
5bf042fcc1
Use individual parameter version of wxExecute.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9236
2021-09-26 15:03:06 +01:00
f6571c18cb
Formatting.
2021-09-26 11:02:57 +01:00
c9aebb8529
Fix symbol fields sorting.
...
In the symbol fields table the reference contains only the letter, so
the number must be appended. Conversely, we don't want the unit suffix
as all units are folded into a single symbol.
Fixes https://gitlab.com/kicad/code/kicad/issues/9238
2021-09-25 21:24:16 +01:00
f11687c5e5
Do not allow sheet filename change from DIALOG_SCH_FIELD_PROPERTIES.
...
It does not work. Changing a sheet filename is complex, and can be
made only in sheet properties dialog.
2021-09-25 18:28:19 +02:00
0dc585e518
Use different dangling state initialization for wires and graphic lines.
2021-09-25 00:34:51 +01:00
1b8506c6b6
Default dangling state to true. A wire on it's own is dangling.
2021-09-24 20:59:37 +01:00
7901d705ba
Fix optimization to not fetch all possible endpoints for non-connectable.
2021-09-24 20:08:42 +01:00
fad385785d
Fix botched merge.
2021-09-24 20:08:29 +01:00
a1a2076aee
Include pin roots for symbols that don't have well-defined bodies.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8508
2021-09-24 16:19:54 +01:00
a4f83073e3
Use RTree to optimize searches.
...
Should produce an order of magnitude speedup on dangling end tests
in some documents.
2021-09-24 12:42:22 +01:00
2d72ccb6ae
Simplify dangling end stuff a bit and remove graphic lines from it.
2021-09-24 12:19:27 +01:00
d39f79b55b
Fix schematic custom paper size check to use same limits as rest of eeschema
...
Fix #9223
2021-09-24 00:46:02 -04:00
42687f5d9d
Give selection preference to pins over wires.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9063
2021-09-23 23:59:20 +01:00
9ea6b44ee8
Formatting.
2021-09-23 23:59:20 +01:00
064ab933dd
Always update the hierarchy navigator when setting the current sheet in the frame
...
Fix #9221
2021-09-23 18:14:44 -04:00
71602475eb
Allow rotate/mirror even when dragging
...
Keeps the lines connected but doesn't solve the crossed-wire mixups.
This allows common usage (mirroring labels/rotating segments) and leaves
prevention of the crossed wires to the user.
We can't really prevent crossed wires when rotating e.g. a part with
wires connected to 4 sides and users will not expect that. But we
should not disable useful features like mirroring multiple parallel
items to avoid a known impossible situation
Also provides an alternative solution to 345f506f0chttps://gitlab.com/kicad/code/kicad/issues/8403
Fixes https://gitlab.com/kicad/code/kicad/issues/8523
2021-09-23 14:47:49 -07:00
4b38bd1543
Favour junction dots to wires inside the dot.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9187
2021-09-23 22:13:56 +01:00
552f053a55
Remove pins from symbol hit-testing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8508
2021-09-23 22:07:51 +01:00
671aec5da6
In fallback selection, handle cancelled menu
...
doSelectionMenu returns false to indicate a cancelled menu. This needs
to be handled in selectPoint when directly accessing doSelectionMenu in
the same manner as SelectionMenu() events
Fixes https://gitlab.com/kicad/code/kicad/issues/9218
2021-09-23 11:48:29 -07:00
3b04b602d9
Don't walk text/labels when mirroring
...
We have a fixed bottom-align for the text and labels in eeschema.
Therefore, mirroring vertically needs to account for the text's offset
from the bounding box center.
Fixes https://gitlab.com/kicad/code/kicad/issues/9208
2021-09-22 09:24:16 -07:00
ec2ac181a2
Further simplify selection logic.
...
The select-single-wire stuff is no longer needed, and the prefer-wire-ends
stuff needs to be distance-based.
Also improved wire hit-testing to include bubbles the size of the dangling
symbol at each end.
Fixes https://gitlab.com/kicad/code/kicad/issues/9187
2021-09-21 20:27:35 +01:00
2ec1c215cd
Drop selection after hiding items.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8605
2021-09-21 17:02:34 +01:00
469d3ea329
Don't add global labels when a power symbol is connected.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7497
2021-09-20 21:31:19 +01:00
ae8f817938
Use consistent label size and fix issues with rotation.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5950
2021-09-20 21:31:19 +01:00
40b4e5c024
Formatting.
2021-09-20 21:31:19 +01:00
c67d560538
Remove unused and shadowed variables
2021-09-20 11:45:27 -07:00
fada53d90c
Fix SCH_SCREENS::HasNoFullyDefinedLibIds(): incorrectly returned true if no symbol found.
...
Fixes #9195
https://gitlab.com/kicad/code/kicad/issues/9195
2021-09-20 18:29:26 +02:00
6e7ce09572
Use more descriptive terminology for preferred text editor.
...
Also improves execution to allow the preferred editor to include
parameters, such as "/usr/bin/open -e".
Fixes https://gitlab.com/kicad/code/kicad/issues/9131
2021-09-19 15:17:26 +01:00
e7814915db
Call UpdateHierarchyNavigator on find jump in schematic in case we cross pages
...
Fix #8971
2021-09-19 08:35:51 -04:00
0400c0a775
Prevent crash with RTree modification invalidating iterator.
2021-09-19 11:34:43 +01:00
a5c4bace60
Improve (and simplify) wire and pin hit-testing.
...
1) Expand the accuracy to at least the grid spacing
2) Move pin-selects-symbol logic to Selectable()
3) Recode pick-closest algorithm to handle exactHits and inexactHits
separately
4) Remove pin target from bounding box in favour of expanding it to
at least as wide as the pin decoration (this prevents the accuracy
off the end of the pin from growing too large)
2021-09-19 11:34:43 +01:00
a291cae2fd
Make sure intersheetRef bounding boxes get updated in RTree.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9177
2021-09-18 18:32:19 +01:00
4779850c10
Add done messages to various plotters.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9172
2021-09-18 10:39:57 +01:00
4b3490a2b9
Intercept rotate command when drawing wires.
...
If unfolding from bus rotate the label; otherwise beep.
Fixes https://gitlab.com/kicad/code/kicad/issues/9178
2021-09-17 22:01:17 +01:00
5c07441e24
Remove Setup Dialog assignment of netclasses to buses.
...
Also removes the message bar display of assigned netclass for
buses and bus-to-bus entries.
Also fixes a bug where assigning a netclass via the canvas only
looked at the first level of bus members (and not any nested
members).
Also fixes a bug where the bus name validator tried to validate
a vector bus first -- which doesn't work as a vector bus may be
nested in a group bus.
Also fixes a bug where we were failing to check for illegal
chars in bus definitions which otherwise passed the bus parsers.
See additional comments in the bug report.
Fixes https://gitlab.com/kicad/code/kicad/issues/9160
2021-09-17 22:01:17 +01:00
d32ca5b287
Fix bus validation.
...
Bus groups must be checked first as they can contain vectors inside
them.
2021-09-17 22:01:17 +01:00
ca33ec05df
Eeschema: fix incorrect rotation (CW versus CCW) of some items.
...
For some (not all) items and for blocks the rotation CCW was in fact a CW rot.
Fixes #9176
https://gitlab.com/kicad/code/kicad/issues/
2021-09-17 18:30:23 +02:00
cc14dfe3ca
Make canvas netclass assignment mirror Setup Dialog assignment.
...
While it would make more sense to have them both use the old canvas
algorithm (of only assigning to the members), I'd be *very* hesitant
to change the Setup Dialog and underlying machinery this late in the
6.0 release.
Fixes https://gitlab.com/kicad/code/kicad/issues/9160
2021-09-17 14:40:12 +01:00
d7bfd1eb77
Restore use of floating point precision in pin name/number placement.
...
It's actually required here to get the shadows centred directly under
the text.
2021-09-17 12:37:53 +01:00
b10f337299
Don't auto-zoom when page settings were cancelled.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8978
2021-09-17 12:37:53 +01:00
d90094de39
Fix progress dialog main frame focus issue on Linux.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8718
2021-09-16 15:53:18 -04:00
2479e1d7b1
Improve common settings property grouping.
...
Also moves apply-icon-scaling-to-fonts to its own checkbox. (We used
to try to infer when to do it, but that turns out to be a rathole.)
2021-09-16 18:31:44 +01:00
8aa7e8d9f4
Fix compil warning (shadowed vars)
2021-09-16 18:21:07 +02:00
4663da4709
Eeschema: don't escape document file alias names in legacy plugin.
...
Escaping the document file (.dcm) alias names breaks the link between the
document file and the library (.lib) file. This causes the information in
the document file to be lost.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9130
2021-09-16 09:09:44 -04:00
684d15895c
Box highlighting of selected text was never finished.
...
In particular, pin numbers and names weren't done.
2021-09-15 21:17:18 +01:00
e2ce2e6ca9
Correct slight misalignment in Library Link fields.
2021-09-15 21:17:18 +01:00
ca6e43d1e1
Fix segfault when discarding changes on open
...
When opening new schematic, the undo/redo list is invalidated.
CleanupSchematic uses it before presenting the new schematic to the
user, so we need to make sure that old data are not preserved here past
their pointer lifetimes
2021-09-14 16:41:25 -07:00
b84d1456d5
KIFACE_I -> KIFACE_BASE.
2021-09-14 23:45:14 +01:00
3aae3c6f65
Dark mode for a bunch of HTML dialogs.
...
WX_HTML_REPORT_BOX
WX_HTML_REPORT_PANEL
HTML_MESSAGEBOX
DIALOG_DISPLAY_HTML_TEXT
Fixes https://gitlab.com/kicad/code/kicad/issues/9157
Fixes https://gitlab.com/kicad/code/kicad/issues/9156
2021-09-14 21:23:57 +01:00
3b121359ae
Fix a couple of escape-string issues.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9167
2021-09-14 18:30:19 +01:00
4b436fb86d
Narrow down collector
...
RTree keeps track of position as well. We can use this to reduce the
amount of time spent in the collector routine
2021-09-13 20:24:07 -07:00
1c409ff90a
Fix typo in previous commit
2021-09-13 20:23:52 -07:00
2fdd805eda
Override SCH_GLOBALLABEL::HitTest
...
Global labels can optionally have intersheet references. When enabled,
they expand the bounding box of the label. Because they can be far away
from the actual label, the bounding box is not a good approximation for
the hittest
2021-09-13 19:55:48 -07:00
484eaa01b9
Try harder to avoid loop contention
...
We have two cases where we might be requesting a disambiguation menu.
In one case, we already have the event loop waiting and we need to run
the selectionMenu through the action system. In the other case, the
tool isn't on the stack and won't activate. Here we need to run
directly and we are assured of not crashing because the tool isn't
active.
Fixes https://gitlab.com/kicad/code/kicad/issues/9154
2021-09-13 10:17:04 -07:00
fdfecf5932
Don't push view control settings to the previous active tool.
...
See further comments in bug report.
Fixes https://gitlab.com/kicad/code/kicad/issues/9147
2021-09-13 13:28:05 +01:00
efc9279a19
Fix unfortunate line-break.
2021-09-13 13:28:05 +01:00
52f99e41e6
Fix merge screw up.
2021-09-12 22:57:25 +01:00
558ba855a2
Copy default hotkey for Clear Highlight from pcbnew to eeschema
2021-09-12 17:38:02 -04:00
ed342d0cc0
Do not clear highlighting on a cancel event
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9035
2021-09-12 17:35:44 -04:00
a5247471f7
Expunge a bunch more fixed font specs from wxFormBuilder files.
...
Also removes the -1 sizing of the status bar on GTK and MSW.
Fixes https://gitlab.com/kicad/code/kicad/issues/8608
2021-09-12 13:53:12 +01:00
9c78e4cf54
Mac needs different font size handling than MSW & GTK.
...
Mac already uses diverse font sizes (for instance, smaller fonts for
radio button groups), and the anti-aliasing is a lot better. The
other platforms need a more limited range of sizes.
Fixes https://gitlab.com/kicad/code/kicad/issues/8608
2021-09-11 23:40:31 +01:00
625e56676a
Add progress reporting to CADSTAR Schematic & PCB importers
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8685
2021-09-11 17:50:19 +01:00
fbee62fc15
Tie font size scaling to when automatic icon scaling fails.
...
It appears that SetSymbolicSize() and ConvertDialogToPixes() fail
under the same circumstances.
2021-09-11 15:29:51 +01:00
c736bd3fd0
Patch Altium import of oddly constructed line segments.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8974
2021-09-11 15:29:51 +01:00
09ddcdbbca
Fix logic error setting bold text.
...
(Reported on Forum.)
2021-09-11 12:01:41 +01:00
7a822b55aa
Another round of changes to attempt to fix the GTK font size issue.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8608
2021-09-10 15:59:50 +01:00
29c2f3b7d4
Prevent jumping into disambiguation if moved
...
Moving points should not be overrided by disambiguation menu, so we
track where the disambiguation event started and only trigger the menu
if the mouse hasn't moved a full unit in x/y
Fixes https://gitlab.com/kicad/code/kicad/issues/9132
2021-09-09 16:24:18 -07:00
451f8eefc0
Eeschema: fix broken project symbol rescue bug.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9111
2021-09-09 10:21:09 -04:00
5325dce862
Naming consistency with DRC reports.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9121
2021-09-09 13:37:57 +01:00
fe608bfcef
eeschema, sim: clean signal list when last panel is closed
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9119
2021-09-09 01:11:47 +00:00
1c9e10f34e
Disable simulator notebook splitting
...
Using this feature freezes the simulator.
2021-09-09 01:07:23 +00:00
f9c5c97f74
eeschema, sim: fix wrong names of the signals
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9062
2021-09-08 23:15:29 +02:00
f013dbc7c4
More uniform handling of status fonts.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8608
2021-09-08 21:34:22 +01:00
c8b2e69332
Check if selection is primary tool
...
Previously, we were checking if the selection tool was the top of the
stack but this ignored many other "secondary" tools that might be
running such as the point editor. These still allow the selection tool
to handle events such as clicks. This change allows the selection tool
to handle clicks when it is the primary tool on the stack rather than
the top
Fixes https://gitlab.com/kicad/code/kicad/issues/9110
2021-09-07 10:42:01 -07:00
4ee0b28ffc
Coverity issue fixes.
...
Fix Coverity issues 338623, 338716, and 338717.
2021-09-07 13:38:56 -04:00
41c7089417
Minor dialog layout improvements.
2021-09-07 08:06:02 -04:00
9cf7c7800b
Use same text positioning algorithm in LibEdit and Eeschema.
...
Also fixes some uninitialized variables in PCB painter.
Fixes https://gitlab.com/kicad/code/kicad/issues/8947
2021-09-07 12:33:06 +01:00
ad7275f0a3
Repair saving of default line styles.
...
Note that the file format version was NOT bumped because we were
correctly reading the default, just no writing it.
Fixes https://gitlab.com/kicad/code/kicad/issues/9045
2021-09-07 00:14:18 +01:00
0f38a35531
Be sure to stop the timer when triggering d-click
...
Some mice apparently trigger double-click without triggering a click, so
stop the timer when we receive this event
Fixes https://gitlab.com/kicad/code/kicad/issues/9106
2021-09-06 12:27:31 -07:00
c1130535fb
PCM: make DIALOG_MANAGE_REPOSITORIES_BASE resizable.
2021-09-06 08:36:06 +02:00
240c3b75c4
Move selection disambiguation to long-click
...
This standardizes selection tools in SELECTION_TOOL class to be able to
handle a long-click as asking for a non-heuristic disambiguation menu.
Fixes https://gitlab.com/kicad/code/kicad/issues/8490
2021-09-05 13:42:51 -07:00
c58562aebf
Sigh. Values in the LibEdit are LIB_IDs; in Eeschema they are not.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9098
2021-09-05 21:23:55 +01:00
07f0662ba9
Fix some issues in dialog_netlist.cpp , round 2 (work in progress)
...
The netlist plugins added in dialog_netlist are now stored in eeschema config.
2021-09-05 16:13:52 +02:00
74b8f14ec3
Don't find when the dialog isn't open or the search is blank (which resulted in full highlighting)
...
Fix #9056
2021-09-04 23:48:06 -04:00
6818539f6d
Repair is-selected logic in various global editors.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9090
2021-09-04 18:10:25 +01:00
1fe4aaa64f
fix some issues in dialog_netlist.cpp (work in progress)
2021-09-03 20:38:29 +02:00
a06f3f1d14
Don't update text items until modified explicitly
...
Ensures that any complex formatting in text items created by importers
or pasted S-expressions is preserved.
2021-09-03 19:25:53 +01:00
7e2abf545b
Eeschema: add python script netlist_form_OrcadPcb2.py and netlist_form_pads-pcb-asc.py
...
to replace netlist_form_OrcadPcb2.xsl and netlist_form_pads-pcb.asc.xsl
2021-09-02 17:15:49 +02:00
bc8245ca7b
Attempt to untangle junction dot preferences.
2021-09-02 12:41:16 +01:00
243631a095
Fix logic error in polyline hittesting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9030
2021-09-01 21:38:32 +01:00
651981b2a0
Remove atrophied property from appsettings.
2021-09-01 21:20:07 +01:00
8268c4ad17
CADSTAR Schematic: Ensure library ID is valid
...
Previously the library created was invalid - opening it resulted
in a parsing error due to invalid characters in the name.
2021-09-01 20:25:39 +01:00
be9ff7a7d5
CADSTAR Schematic: Load text sizes for pin names/numbers and net labels
2021-09-01 20:25:39 +01:00
0aa37d1173
Fix issues with new overbar syntax
...
- Update sch text help (~~ no longer gets converted to single ~)
- Update Eagle importer to correctly handle new overbar syntax
- Update CADSTAR importer to correctly handle new overbar syntax
2021-09-01 20:25:39 +01:00
130958e48e
Eeschema: add python script netlist_form_cadstar.py to replace netlist_form_cadstar.xsl
2021-09-01 21:06:00 +02:00
8a305eec32
Remove broken RefDesStringCompare
...
This function attempted a poor-man's natural compare but it assumed
specific structure of the string. This broke for strings with
numberings that looked like decimals.
Instead, we use our natural string comparison function and remove the
references to this older function and its similar elements.
Fixes https://gitlab.com/kicad/code/kicad/issues/9067
2021-09-01 11:48:01 -07:00
bc0302fafe
Replace RefDesCmp with better StrNumCmp
2021-09-01 11:48:01 -07:00
d92d9898ad
Scale junction dots from wirewidth, not linewidth.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9040
2021-09-01 19:44:18 +01:00
b0ba8b01c4
Update RTree when rotating components
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9061
2021-08-31 16:36:38 -07:00
2cdd3c9ebf
Work-around incorrect spacing (and order) of buttons on Mac.
2021-08-31 22:39:25 +01:00
345f506f0c
Ignore STARTPOINT/ENDPOINT in multiple item rot
...
Rotating multiple items does not allow for individual end points to be
selected. This can happen when we narrowSelection by hovering on end
points.
2021-08-31 14:34:05 -07:00
3e32c2e5a7
eeschema: Make pasted text left aligned so that it is editable
...
Previously it was pasted as centre aligned, which is not supported in
the GUI.
2021-08-31 20:02:20 +01:00
b5a3385ea9
Overhaul file locking system.
...
See bug report for details.
Fixes https://gitlab.com/kicad/code/kicad/issues/8919
2021-08-31 15:04:31 +01:00
21365fff3e
Disambiguate JunctionDiameter from EffectiveJunctionDiameter.
...
ADDED Junction Size and Color to Edit Text & Graphics properties.
The added feature is only because it's the only way to recover from
the buggy behaviour having changed all your junctions to overridden
values.
Also adds help texts to the Junction Dot Properties dialog to
specify how to get schematic dot sizes and eeschema colors.
Also fixes the terminology in the Line/Wire/Bus Properties dialog
(the default widths come from the netclasses, not from eeschema).
Fixes https://gitlab.com/kicad/code/kicad/issues/9040
2021-08-31 12:18:02 +01:00
ddba9e2351
eeschema: fix of not updating spice primitive field
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8835
2021-08-31 06:27:36 +00:00
897269f33f
Eeschema: schematic object context menu improvements.
...
Don't show the clean up sheet pins context menu entry when the selected
sheet doesn't have any pins to clean up.
Remove sheet has no pins to clean up nag dialog now that the context menu
entry isn't shown unless there are pins to clean up.
2021-08-30 11:52:40 -04:00
6c16846b21
Remove unused lambda.
2021-08-30 13:44:28 +01:00
9da8f04cb4
Cleanup sheet pins doesn't make any sense when drawing sheets.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9044
2021-08-30 13:11:37 +01:00
0cd8a4d846
CADSTAR Schematic: Load line thickness in symbols
2021-08-29 19:55:47 +01:00
871bdbc952
Search sheets in hierarchy-order
...
Also fixes an issue where multiple sub-sheets were skipped in certain
cases
Fixes https://gitlab.com/kicad/code/kicad/issues/8972
2021-08-27 13:03:18 -07:00
d18d993eac
Eeschema: find next key shouldn't launch find dialog
...
Adds some general cleanups of overridden find functions while I'm in there.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8967
2021-08-27 18:15:36 +00:00
0b2e66d3b7
Infobar: Don't use animations on Windows/GTK
...
Seems to cause issues on Windows where the animation locks the screen.
Doesn't effect Linux, possibly because wxWidgets uses a native GTK
infobar that doesn't animate anyway.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8987
2021-08-27 17:38:16 +00:00
69fac89e86
Fix some issues with incorrectly scaled defaults given in mils.
2021-08-25 20:04:06 +01:00
a5560bb5f9
Eeschema, Add new symbol to schematics: update Value and Footprint texts
...
to be currently displayed.
Fixes #9025
https://gitlab.com/kicad/code/kicad/issues/9025
2021-08-25 15:13:40 +02:00
17a17586a6
Don't use REALPATH to find shared/dynamic libraries
...
We require API compatibility in the ngspice library because we
dynamically load the library and assign function pointers to specific
names/signatures. This should be consistent for all versions of the the
library until the soversion changes.
Fixes https://gitlab.com/kicad/code/kicad/issues/8878
2021-08-24 11:44:56 -07:00
0463fc4c2b
Fix several bugs and refactor schematic saving
...
Having the logic split between three different paths was
a bit much, this should hopefully be a bit easier to
maintain. All save logic now goes through SaveProject;
individual file writing is now a private function.
Also change Save As to Save Copy As in project manager
mode, as we don't want to change projects from inside
the editor in project manager mode.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9015
2021-08-23 23:01:08 -04:00
4ac2aa675a
lib symbols: make fp filter tolerant to spaces in names.
...
For historical reasons they are stored in a string using spaces as separators.
So each fp filter is now escaped to remove spaces (replaced by {space})
Fixes #9009
https://gitlab.com/kicad/code/kicad/issues/9009
2021-08-23 18:01:31 +02:00
9f22baf109
netlist xml exporter: fix incorrect keyword change (field was changed to f)
...
Keywords cannot be changed without a very good reason. the keyword is now field.
Fixes #9016
https://gitlab.com/kicad/code/kicad/issues/9016
2021-08-23 17:14:45 +02:00
3bddadc03d
Fix a typo in reference clearing.
...
Also fixes an unrelated bug where all values/footprints were getting
reset rather than just the instance versions.
Fixes https://gitlab.com/kicad/code/kicad/issues/8891
2021-08-22 19:55:20 +01:00
7561715ffe
Unescape symbol fields going out to XML netlist.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8995
2021-08-21 22:03:24 +01:00
0814219513
Clean up some handling of project files in standalone
...
Add control of project creation to Eeschema; change defaults
to enable project creation in both programs. Properly set
project on newly-created schematics so "Save As" doesn't
get triggered repeatedly.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9000
2021-08-21 12:09:21 -04:00
4da0c897bc
Fix flagging power pin in ERC check
...
IsPowerConnection() is too restrictive a check
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8881
2021-08-21 11:19:09 -04:00
44ea3a75f2
Simulator: Use last workbook path stored in .kicad_pro as initial path in dialogs
...
Previously this was done using a static variable, which was not loaded
from .kicad_pro on simulator launch, causing unexpected behavior
Fixes https://gitlab.com/kicad/code/kicad/issues/8799
2021-08-20 23:23:23 +00:00
1d8fd22cd8
Symbol editor: fix message panel units when selecting from combo box.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8991
2021-08-20 15:45:57 -04:00
eefac5cc59
eeschema: fix in populating DC sim settings tab
...
When filling drop-down list with sources, previous selection should be
saved in local variable and restored if it is still available.
2021-08-20 19:23:13 +00:00
691b53d125
eeschema: add missing virtual destructors
2021-08-20 19:23:13 +00:00
bee3d78d78
Limit Eeschema find/replace entries
...
Standardize maximum find/replace entries to 10
Fixes https://gitlab.com/kicad/code/kicad/issues/9007
2021-08-20 11:48:02 -07:00
75e4fa9b75
Handle multiple annotation in search
...
New schematic format needs to search client screen paths instead of
maintaining multiple copies in a flat format.
2021-08-20 10:24:08 -07:00
6470be11c3
Add clarifying comments to EE_RTREE ordering
2021-08-20 08:49:43 -07:00
729ba1e301
Ensure deterministic Find/Replace ordering
...
Sorts first by x and then by y when returning search order
Fixes https://gitlab.com/kicad/code/kicad/issues/8972
2021-08-20 08:42:06 -07:00
09be1a8c78
Ensure sheets are deterministically sorted
...
Even if a sheet exists at the same x/y coordinate as another, the sort
needs to ensure a deterministic ordering
2021-08-20 08:31:01 -07:00
13083c80c2
Eeschema, dialog Find: do not force a position on screen when reopen dlg.
...
The last position will be used.
Fixes #8969
https://gitlab.com/kicad/code/kicad/issues/8969
2021-08-19 15:40:38 +02:00
dfacac5eb6
Repair label incrementer to handle formatting constructs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8992
2021-08-19 00:08:37 +01:00
9549a227ad
Fix typo.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8993
2021-08-18 23:38:11 +01:00
8879b887df
Fix missing overbar notation conversions in legacy library parsing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8981
2021-08-18 22:48:29 +01:00
Jeff Young
jean-pierre charras
Seth Hillbrand
markus-bonk
Mike Williams
Sylwester Kocjan
Wayne Stambaugh
Steffen Mauch
Thomas Pointhuber
Marek Roszko
Werni
Kevin Lannen
Roberto Fernandez Bautista
Davide Gerhard
Franck
Fabien Corona
dsa-t
dana
Ola Rinta-Koski
Jon Evans
Simon Richter
Ian McInerney
Mikolaj Wielgus
Frank Zeeman
Jonathan Haas
Adam Wolf
kliment
Simon Schaak
Christian Pfluger