Jeff Young
78e00ade7a
Clearer naming.
2023-11-09 14:05:35 +00:00
Alex Shvartzkop
b596568ce4
Use utf8. Partially reverts e35174d64b
2023-11-09 02:12:10 +03:00
Alex Shvartzkop
e35174d64b
Use buffered file io; use fn_str() more.
2023-11-09 01:24:54 +03:00
Ian McInerney
dd933b7d0e
Update CERN copyrights
2023-11-08 21:34:14 +00:00
Alex Shvartzkop
819c0f2082
CADSTAR: fix arcs in symbol libraries.
2023-11-08 23:29:27 +03:00
Alex Shvartzkop
62d735d710
CADSTAR: fix hierarchy grammar for some part libraries.
2023-11-08 22:31:07 +03:00
Alex Shvartzkop
37a56472b7
CADSTAR: use eolf for attributes in parts lib grammar.
2023-11-08 21:27:19 +03:00
Alex Shvartzkop
f1a4c9ce5b
CADSTAR: update parts lib grammar to support ')' in attributes.
2023-11-08 20:08:11 +03:00
Jeff Young
72c985bc07
Rewrite scoring algo again. (Third time's the charm?)
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16042
2023-11-08 12:33:09 +00:00
Jeff Young
6d74cc031e
Refine Scintilla margin recognition.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16044
2023-11-07 15:02:49 +00:00
Jeff Young
6d43ef5678
Don't specify sizes when we don't need to.
...
However, in some places we *do* have to because otherwise wxWidgets
will pick a minimum size for us (and it's rather large).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16039
2023-11-07 14:53:41 +00:00
Alex Shvartzkop
6c21e0607b
Use wxFileName::Mkdir instead of wxMkDir.
...
wxMkDir is a CRT wrapper that doesn't actually return bool.
2023-11-06 17:02:34 +03:00
Jeff Young
1b6048b6d5
Handle non-binary font weights.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14502
2023-11-05 14:21:13 +00:00
Wayne Stambaugh
d34e6636d0
Dialog layout fixes.
2023-11-05 08:09:51 -05:00
Jeff Young
f83d60a48f
Clean up autosave files when reverting.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15998
2023-11-05 12:20:31 +00:00
Wayne Stambaugh
19e309d2d2
Dialog layout and coding policy fixes.
2023-11-04 13:57:31 -04:00
Alex Shvartzkop
48855ebe40
Graphics import: support open polygons.
2023-11-04 17:10:26 +03:00
Jeff Young
50ff5e616f
Don't delete text when cancelling changes.
...
Also changes margins of compile button so it correctly lines up at
the top of the error window.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16002
2023-11-02 18:37:55 +00:00
Wayne Stambaugh
91b503f875
Minor dialog layout fixes.
2023-11-02 09:37:44 -04:00
Jon Evans
ab4d9bcb14
Fix sloppy path handling in migration for old color settings
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15964
2023-10-31 23:38:44 -04:00
Jon Evans
c6c808a7fa
Support system-installed color themes
...
Install to ${KICAD_DATA}/colors/
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15920
2023-10-31 23:05:08 -04:00
Jeff Young
67d8b13b02
And Font to properties manager for EDA_TEXT items.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16004
2023-11-01 00:39:42 +00:00
Jon Evans
5d5682a225
Fix missing wxRB_GROUP
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15990
2023-10-31 20:15:40 -04:00
Jeff Young
64c692a42e
Allow a:b to represent either lib:item_name or key:value.
...
Also changes the scoring algorithm to start at 0 and then increment
to 1 (the value that tells us to show, but not expand) only if the
search terms and lib filters are empty.
2023-10-31 23:20:59 +00:00
jean-pierre charras
d8be69c3c1
PAGE_INFO: use double instead of int to store the page size.
...
For historical reasons, they are stored in mils, but using int create rounding
issues when converting to/from mils to IU in dialogs.
This is a minor but annoying issue.
Fixes #16000
https://gitlab.com/kicad/code/kicad/-/issues/16000
2023-10-31 13:47:32 +01:00
Jeff Young
e7fca68384
Don't double-delete unused nets (or anything else, for that matter).
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15979
2023-10-31 12:10:21 +00:00
Alex Shvartzkop
3d5721a217
Fix some warnings.
2023-10-31 04:25:19 +03:00
Alex Shvartzkop
e24c8de4b8
EasyEDA Std: Fix open polygon shapes in symbols.
2023-10-31 02:21:32 +03:00
Alex Shvartzkop
f48a248db4
EasyEDA Std: Handle HTML escape characters in text.
2023-10-31 02:21:32 +03:00
Marek Roszko
d0b26ae600
Add a hack to avoid spamming sentry events due to recursive asserts
2023-10-30 19:03:54 -04:00
Jeff Young
87571ed8b8
Not all font sizes, fill properties or color properties are the same.
2023-10-30 17:30:15 +00:00
Wayne Stambaugh
6183a1e4de
Coverity warning fixes.
2023-10-30 09:16:24 -04:00
jean-pierre charras
0f2beed54a
LIB_TREE: use GetAssociatedDocument() to display the doc from a wxHtmlLinkEvent
...
One cannot always use the string given in the wxHtmlLinkEvent without expanding
Env Vars.
Fixes #15984
https://gitlab.com/kicad/code/kicad/-/issues/15984
2023-10-30 11:27:08 +01:00
Alex Shvartzkop
847ab093c8
ADDED: Project chooser dialog for EasyEDA Pro import.
2023-10-30 09:35:27 +03:00
Seth Hillbrand
6633eadfc8
Enclose wxCHECK* macros in braces
...
The macros are if/else statements without enclosing structures which
leads to unexpected evaluation when expanding in an existing conditional
that does not have braces already.
2023-10-29 10:52:05 -07:00
Jeff Young
fc0017fc95
Normalize rects higher up.
...
We don't want to normalize footprint children to their board-relative
coordinates.
2023-10-29 11:45:16 +00:00
Jeff Young
84d42a2669
Normalize rectangles after rotation/flipping.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14341
2023-10-28 20:55:46 +01:00
Wayne Stambaugh
84f58f36d4
Coding policy fixes.
2023-10-28 14:45:44 -04:00
Wayne Stambaugh
2f19112212
Revert fix for false positive Coverity warning.
2023-10-28 14:34:21 -04:00
Jeff Young
6c6a7cf862
Provide a callback for supplying file filters just-in-time.
...
This allows us to make them dependent on the current plugin type in
the fp lib table.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13959
2023-10-28 11:18:17 +01:00
Ian McInerney
171458a27b
Introduce action friendly names
...
Friendly names can be used to display action information that is clearer
in non-hierarchical contexts (e.g. not in menus).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8075
2023-10-27 23:58:29 +01:00
Seth Hillbrand
1c847889e7
Use deprecated GIT defines
...
Older Ubuntus/Debians use libgit2 that does not support the new defines.
Newer libgit2 provides a name define translation
2023-10-27 14:59:15 -07:00
Wayne Stambaugh
6269453416
Coverity warning fixes.
2023-10-27 16:48:14 -04:00
Jeff Young
3651cad7fd
Don't fire events when going back to original text in onSetFocus().
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15851
2023-10-27 14:58:30 +01:00
jean-pierre charras
4d593aa21e
PG_CELL_RENDERER, PGPROPERTY_COLOR4D: clear DC before drawing the color swatch.
...
Otherwise the previous background can be displayed on the not redrawn area.
Fixes #15955
https://gitlab.com/kicad/code/kicad/-/issues/15955
2023-10-27 08:54:38 +02:00
jean-pierre charras
06074d9192
Simulator, plot panel: Honor dragging in Y direction.
...
Fixes #15914
https://gitlab.com/kicad/code/kicad/-/issues/15914
2023-10-27 08:13:44 +02:00
jean-pierre charras
93b5038382
FOOTPRINT_EDIT_FRAME: ensure the canvas type comes from the FOOTPRINT_EDITOR_SETTINGS config
...
Previously, although the fp editor preferences has an option to select the canvas type,
it was read from the the PCBNEW_SETTINGS config, using Kiface().KifaceSettings().
2023-10-26 17:58:33 +02:00
Jeff Young
a3fc07b6a0
Fix build.
2023-10-25 18:41:45 +01:00
Jeff Young
fc4bc10d27
Separate out axes definitions between ModEdit and PCBNew.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5711
2023-10-25 15:01:36 +01:00
Jeff Young
881cf9dfcf
Minor improvements to clarity and conformity for Display Options.
2023-10-25 15:01:36 +01:00
Jeff Young
791aa64950
Functionally it's a "reference image".
...
The implementation happens to be a "bitmap".
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15932
2023-10-24 15:44:21 +01:00
Alex Shvartzkop
00904e8e23
Set UNPACK_ALIGNMENT properly for RGB bitmaps,
2023-10-24 06:58:46 +03:00
Alex Shvartzkop
0e4553b1fa
Fix variable shadowing.
2023-10-24 04:25:31 +03:00
Alex Shvartzkop
977912dcd5
Fix up 75c758e5f4
for masked images.
2023-10-24 03:59:03 +03:00
Alex Shvartzkop
71d0c7f6af
OpenGL: Improve logic when bitmap cache memory is exhausted.
...
Don't remove the front entry, as it will likely be needed for the next bitmap.
Instead, implement neuristics based on access times.
2023-10-24 03:36:51 +03:00
Alex Shvartzkop
ccc29e9776
Improve bitmap caching performance.
2023-10-24 01:27:53 +03:00
jean-pierre charras
4ffa013467
Fix minor compil and Coverity warnings (not initialized vars)
2023-10-23 20:13:46 +02:00
Jeff Young
0cf6679bfe
Try to get the scoring logic right (again).
...
Also adds matching against a library name.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15875
2023-10-23 18:24:25 +01:00
Jon Evans
4c1da16d6f
Don't attempt to take the size of invalid bitmap
2023-10-23 13:02:38 -04:00
Jeff Young
435e3fab8d
Support text variables in STEP export filename.
...
Also fixes some other file browser titles to match Kicad's overall style.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15927
2023-10-23 18:01:47 +01:00
Jon Evans
96d203477e
Fix launcher buttons on macOS
2023-10-23 08:56:02 -04:00
Jeff Young
bc0fe74f72
Score initializing is done by LIB_TREE_NODE::ResetScore().
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15875
2023-10-23 13:09:41 +01:00
Jeff Young
ab89038fa8
More protection for drawing dashed lines on MSW.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15888
2023-10-23 12:58:19 +01:00
Jon Evans
9d455ca399
Fix rendering of ACTION_TOOLBAR_PALETTE buttons at non-normal sizes
2023-10-22 15:40:17 -04:00
Jon Evans
47e25d617e
ADDED: Icon scaling for toolbars only
...
Unlike the old "icon scale" (that actually scaled all bitmaps)
this one actually changes the toolbar size while making use
of the new bitmap bundle functionality
Add more resolutions for all tool icon bitmaps
Wouldn't want Mark's eyes to bleed
2023-10-22 14:02:06 -04:00
Jon Evans
06a4bdbf4c
Upgrade BITMAP_TOGGLE and GRID_BITMAP_TOGGLE to wxBitmapBundle
2023-10-22 14:02:06 -04:00
Jon Evans
50fe585827
REMOVED: manual icon scale preference
...
This is now handled properly by wxWidgets on all platforms
See https://gitlab.com/kicad/code/kicad/-/issues/14119
2023-10-22 14:02:06 -04:00
Jon Evans
e2cc678231
Add 2x scale icons
...
See https://gitlab.com/kicad/code/kicad/-/issues/14119
2023-10-22 14:02:06 -04:00
Jon Evans
eb5b3db063
Add bitmap bundle support to BITMAP_SCALE
...
Change a bunch of buttons and toolbars to use it
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14119
2023-10-22 14:02:06 -04:00
Jeff Young
3e4d5d776d
Add --exclude-pdf-property-popups to schematic plotting CLI.
2023-10-22 12:33:55 +01:00
Jeff Young
54277b1e8b
Fix plot clipping when edge values are interpolated.
2023-10-21 16:35:33 +01:00
Jeff Young
85c218f794
Fix missing member variable initialization.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15914
2023-10-21 16:35:33 +01:00
Seth Hillbrand
91a151deb1
Coverity fixes
2023-10-21 17:31:58 +02:00
jean-pierre charras
f87065bf0b
Fix compil issues on msys2 , gcc13
2023-10-21 08:40:08 +02:00
Marek Roszko
aa2a0cdd16
We dont actually need to link to openssl
2023-10-20 19:57:33 -04:00
Seth Hillbrand
6e50b4c5f7
Add libgit compatibility header
2023-10-21 00:55:57 +02:00
Jon Evans
e251bbd217
gmtime requires an explicit cast on some platforms
2023-10-20 11:26:22 -04:00
Jon Evans
5dd3631df2
Revert "Add security library include in CMake for MacOS"
...
This reverts commit 36b0aa6050
.
2023-10-20 11:26:22 -04:00
Alex Shvartzkop
8c7fe9b071
Use fn_str for ifstream in Git dialog.
2023-10-20 18:14:20 +03:00
Seth Hillbrand
36b0aa6050
Add security library include in CMake for MacOS
2023-10-20 16:39:37 +02:00
Seth Hillbrand
5c5a38af21
Update fixes for MacOS
2023-10-20 16:21:31 +02:00
Seth Hillbrand
81214e1f0f
Remove unneeded headers
2023-10-20 15:17:10 +02:00
Seth Hillbrand
d99641be40
ADDED: Git integration support
...
Adds support for project-based git integration, branch support, commit,
revert and updates
Fixes https://gitlab.com/kicad/code/kicad/issues/10441
2023-10-20 12:51:47 +00:00
Wayne Stambaugh
c4a9703f81
Minor dialog layout fixes.
2023-10-19 11:59:35 -04:00
Jeff Young
134685bc32
Optical alignment for capital 'T's.
2023-10-19 15:02:38 +01:00
Jeff Young
b089630b4c
Simplify Import Graphics.
...
Removed no-longer-required differentiation between importing
footprint vs board objects.
Renamed files to match the dialog.
Made Position At and Set Layer optional checkboxes.
Removed Group Items checkbox. (In the unlikely event that you don't
want a group, do an UnGroup after importing.)
Flattened out labelled-sizers in the dialog.
Removed importers blacklist, which hasn't been active for at least 4
years.
Fixed undo/redo bug that caused items to be no-longer-grouped after
a redo.
2023-10-19 01:31:13 +01:00
Jeff Young
89011e888c
More modern look & feel for tuning status popup.
...
(Also includes min and max info, and move string processing out
of router.)
2023-10-17 13:30:58 +01:00
Jeff Young
9c4bb464ac
Improve tuning status popup colours.
2023-10-17 13:30:58 +01:00
Alex Shvartzkop
be1008cbd8
ADDED: Heal Shapes; Fix discontinuities in gfx import and Cleanup dialog.
2023-10-17 10:29:43 +03:00
Marek Roszko
63ba3b8ea7
Remove BITMAP_OPAQUE just like the TODO said :D
2023-10-16 20:16:30 -04:00
Marek Roszko
bee6e6be01
AddMenuLanguageList should live in EDA_BASE_FRAME, its only user
2023-10-16 19:49:52 -04:00
Marek Roszko
584757f2df
Move the menu helpers to ui_common instead of sitting in bitmap for some reason
2023-10-16 19:40:46 -04:00
Marek Roszko
ba83e84b91
Move SaveCanvasImageToFile to EDA_DRAW_FRAME rather than leaking things to bitmaps
2023-10-16 18:33:11 -04:00
Jeff Young
2c02c26af4
Centralize min/opt/max printing.
2023-10-15 22:46:23 +01:00
Jeff Young
d5d07e64c9
Use IsShownOnScreen(), not IsShown(), if you really want to know if its visible.
2023-10-14 23:51:37 +01:00
Alex Shvartzkop
a16bdb7288
ADDED: Support EAGLE libraries directly in Symbol Library Table.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2214
2023-10-15 01:45:39 +03:00
Alex Shvartzkop
9ed19192de
Improve editing values with {return} in text fields; Add hyperlink detection.
2023-10-15 01:45:39 +03:00
Jeff Young
372c5d7963
Remove hack that's no longer necessary.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14020
2023-10-14 19:17:09 +01:00
Jeff Young
87621817bf
Fix typo.
2023-10-14 18:22:17 +01:00
Jeff Young
5f5113c80a
Pick up current rule values when editing meanders.
2023-10-14 15:04:18 +01:00
Wayne Stambaugh
50ec069a01
Fix build warnings.
2023-10-12 10:10:09 -04:00
jean-pierre charras
499f3ca95b
DRC_TEST_PROVIDER_MISC::testOutline(): add test to detect questionable items.
...
Graphic items (segments, rects, circles) on Edge.Cuts can create issues when
building board outlines, when they are very small (a few nm in size), because
they are not easily handled when trying to search connected graphics.
Also protect RC_ITEM::SetItems() against null pointer.
Fixes #15865
https://gitlab.com/kicad/code/kicad/-/issues/15865
2023-10-12 14:48:24 +02:00
Alex Shvartzkop
b0f4adf052
Improve borderless items logic in schematic plotting.
2023-10-12 08:40:37 +03:00
Alex Shvartzkop
d9c123b1ec
HPGL plotting: write rects as polygons to prevent always filling.
2023-10-12 06:11:12 +03:00
Alex Shvartzkop
45791ff8d6
HPGL plotting: fix random lines connecting to circles.
2023-10-12 06:11:12 +03:00
Alex Shvartzkop
4c0a75cbd4
Fix an assert in HPGL plotter.
2023-10-12 06:11:11 +03:00
Alex Shvartzkop
3e82e59c24
DXF plotting: write zero-sized rects and circles as points.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15862
2023-10-12 06:11:11 +03:00
Alex Shvartzkop
843bd4f79c
PDF plotting: fix zero-sized or too thick rectangles.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15862
2023-10-12 06:11:11 +03:00
Marek Roszko
5a1c300cff
Remove unused headers in pgm_base
2023-10-11 07:22:50 -04:00
Jon Evans
0b136ae0df
CLI: Allow controlling layer order for multilayer plots
2023-10-11 00:18:58 +00:00
Seth Hillbrand
dc47d251f5
Fix richio vprint
...
stdlib checks do not allow dereferencing the first element of a vector
when there are no elements in the vector (regardless of whether we have
allocated memory for them). This whole function is rather
over-engineered, setting up multiple allocations and branches depending
of the string size. This commit reduces the function to the actions
needed (get the string size, print it into the output)
2023-10-10 10:58:37 -07:00
jean-pierre charras
42384bcbd0
OPENGL_GAL: ensure 0 sized rect with thickness is shown (already shown by Cairo)
...
Fixes #15850
https://gitlab.com/kicad/code/kicad/-/issues/15850
2023-10-10 18:31:10 +02:00
Jeff Young
35d8635a6b
Default skew tuning lenght to diff between N/P, but allow override.
2023-10-09 15:22:41 +01:00
Jeff Young
5793abd310
Fix build on MacOS.
2023-10-09 15:22:41 +01:00
Alex Shvartzkop
21adc0aac5
ADDED: Import vector graphics into Schematic editor (SVG, DXF).
2023-10-09 07:04:50 +03:00
Alex Shvartzkop
60d069757a
ADDED: Import vector graphics into Symbol editor (SVG, DXF).
2023-10-09 07:04:50 +03:00
Alex Shvartzkop
b77df1eea4
Use advanced_config key EnableGenerators to enable menu entries for generators.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
6cfb05b4a3
Save/load generative objects in PCB file.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
7b645aa541
Introduce GENERATORS_MGR.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
be72e07e61
Introduce PCB_GENERATOR.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
0fcb36bc2e
Add reselectItem action.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
471bfb1131
Add EDA_UNIT_UTILS::ParseInternalUnits
2023-10-08 02:41:17 +00:00
Jeff Young
420cadab34
Separate meander settings from target length/skew.
...
Settings move to Board Setup, while target length is sourced from
the custom rules (or a text-entry dialog if no rules are active for
the track).
Target skew is sourced from the coupled-trace-length minus the
trace-to-be-tuned length.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12075
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15826
2023-10-06 19:46:55 +01:00
Jeff Young
b9e1908ffe
Try to find a happier medium for text entry box widths.
...
Most dialogs have units outside the text entry, and the likelihood
of 14 significant digits & units is low enough to allow scrolling
in that case.
2023-10-06 19:46:55 +01:00
Alex Shvartzkop
113208455d
Add dashed lines and circles to preview draw context.
2023-10-06 15:56:20 +03:00
Alex Shvartzkop
d7863b09c5
Move CORNER_STRATEGY out of SHAPE_POLY_SET.
2023-10-06 15:42:50 +03:00
Ian McInerney
0876fb0985
Re-implement direct layer switching in the router tool
...
Also add a new framework to allow grouping actions that are similar into
a single context that can then be used for mass comparisons.
2023-10-05 13:34:25 +01:00
Ian McInerney
fb3bfc3c57
Move About dialog to an action
2023-10-04 22:17:47 +01:00
Jeff Young
31c488bc23
NETINFO_ITEMs are owned by BOARD.
...
Lifecylce management must go through BOARD_COMMIT (or at least
the frame's undo/redo lists).
2023-10-04 21:01:33 +01:00
jean-pierre charras
37df47a3e7
genDrillMapFile: reduce the pen width used to plot oval shapes (better look)
2023-10-04 15:47:47 +02:00
Jeff Young
10d62ed766
Replace wxWidgets-Mac-specific API with a general one.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15817
2023-10-03 23:40:42 +01:00
Jeff Young
f2c0f4c87f
Fix logic screw-up in earlier commit.
2023-10-03 20:53:52 +01:00
Jeff Young
336a38695a
MacOS fix for expanded items; MSW fix for selected event
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15817
2023-10-03 20:09:37 +01:00
jean-pierre charras
23e064aaaf
fix buf in PLOTTER::sketchOval()
...
(incorrect parameters to plot arcs).
Fixes #15816
https://gitlab.com/kicad/code/kicad/-/issues/15816
2023-10-03 19:39:21 +02:00
Jeff Young
9f5e583ced
Readability.
2023-10-03 17:14:03 +01:00
Jeff Young
6fbbf981f0
Handle justification when hit-testing fields.
...
This steals the algo used in SCH_PAINTER to get the right coords
for the text.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15722
2023-10-03 14:36:13 +01:00
Jeff Young
89f444c38b
Fix missing include.
2023-10-03 13:32:00 +01:00
jean-pierre charras
a60411b159
Fix a few compil and Coverity minor warnings.
2023-10-03 08:22:03 +02:00
Marek Roszko
5759823ca0
Move JOB_EXPORT_SCH_PLOT to kicommon horribly pending further refactor of plotting
2023-10-02 20:48:26 -04:00
Marek Roszko
aa0d39dfe4
Fix the moving truck leaving behind IO_ERROR and friends
2023-10-02 18:16:17 -04:00
Jeff Young
06446bb80e
Only expand lib tree when filtering.
2023-10-02 16:24:53 +01:00
Marek Roszko
6d3b846eb5
Add more missing destructor event cleanups
2023-10-02 07:22:00 -04:00
Marek Roszko
8d5e53f4e8
Unbind LIB_TREE events in destructor
2023-10-01 22:03:58 -04:00
Marek Roszko
d801037c93
Unbind ACTION_MENU events in destructor
2023-10-01 22:03:58 -04:00
Mark Roszko
3c0f9ec510
Revert "Give wxTheApp to python scripts that end up touching Pgm().App()"
...
This reverts commit 672265b564
2023-10-02 00:23:52 +00:00
Marek Roszko
672265b564
Give wxTheApp to python scripts that end up touching Pgm().App()
...
Fixes KICAD-QG
2023-10-01 19:02:49 -04:00
Marek Roszko
3a567a3ae1
Unbind event handlers in the DIALOG_SHIM destructor to prevent late event crashes
...
Fixes KICAD-1XF
2023-10-01 17:54:25 -04:00
Jeff Young
cf02bb171f
Expose exclusion flags in search pane.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15776
2023-10-01 22:46:34 +01:00
Thomas Pointhuber
7005dd7c48
altium: make special string parsing on pcb a bit more generic
...
Only special strings starting with a dot are supported. Parsing of concatenated special strings using quotes needs to be implemented, but at least a few test-cases are already there now.
2023-10-01 15:10:50 +02:00
Jeff Young
34769cec63
Filter line-endings from single-line Scintilla editors.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15793
2023-10-01 14:04:45 +01:00
Thomas Pointhuber
3b3e4fd34a
Move duplicated code of plugin.cpp and sch_plugin.cpp into a new plugin_utils located in commons
2023-10-01 13:58:38 +02:00
John Beard
311f041421
ADDED: Polygon boolean operations in PCB editor
...
This allows common operations like merging a pin courtyard
into the body courtyard in the fooprint editor, taking a
"bite" out of a polygon and so on,
For now, this only supports polygons made of straight lines.
There are some wierd cases when the operations result in nothing
(e.g. wen a big polygon is substracted from a smaller one that
it contains entirely). I have tried to do something senisble in
these cases, but there may be more optimal ways to handle it.
Relates-To: https://gitlab.com/kicad/code/kicad/-/issues/13025
2023-10-01 00:10:10 +01:00
Jeff Young
3c1478367f
Handle flipped state when checkging item against viewport.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15768
2023-09-30 22:54:45 +01:00
Jeff Young
d6a862cafe
It's "internal units", not "user interface".
2023-09-30 22:54:45 +01:00
Jeff Young
867ca2d0da
Don't confuse Coverity.
2023-09-30 22:54:45 +01:00
Jeff Young
9805aca5a0
Handle backslash-escaped quotes in libeval.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15786
2023-09-30 17:38:44 +01:00
jean-pierre charras
c2db20d745
Fix a link issue on mingw in debug mode.
2023-09-30 16:08:54 +02:00
Marek Roszko
a347aa7647
StartPlot can fail and leave a broken file handle
...
Related https://gitlab.com/kicad/code/kicad/-/issues/15782
2023-09-29 19:52:21 -04:00
Jeff Young
b5dacc659d
Don't hide preview when mouse is in the preview window.
2023-09-29 23:13:59 +01:00
Jeff Young
fa11e9138d
ADDED support for pin and fp filtering in FOOTPRINT_CHOOSER.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7176
2023-09-29 17:03:50 +01:00
Alex Shvartzkop
3b28ba83c6
EasyEDA Pro: don't fail on attributes for dimensions.
2023-09-29 12:17:30 +03:00
Jeff Young
b592a6634e
Cleanup.
2023-09-29 00:13:13 +01:00
Jeff Young
974da4ea7c
Push most of DIALOG_CHOOSE_SYMBOL down into PANEL_SYMBOL_CHOOSER.
...
Includes a dialog wrapper (DIALOG_SYMBOL_CHOOSER) and a frame
wrapper (SYMBOL_CHOOSER_FRAME).
2023-09-29 00:13:12 +01:00
Seth Hillbrand
c73c2360a4
Force focus back to canvas after popup
...
Following the hotkey popup, we need to place the input focus back to the
canvas to receive the next event
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15737
2023-09-28 10:52:12 -07:00
Marek Roszko
6b12a12b3e
On second thought rename PROJECT_PCBNEW to PROJECT_PCB
2023-09-27 23:15:54 -04:00
Marek Roszko
8c6899b0d3
Tear out the eeschema conditional compile of PROJECT
2023-09-27 23:05:30 -04:00
Marek Roszko
7e8b18035f
Eliminate the conditional pcbnew/cvpcb definition of PROJECT
2023-09-27 20:53:46 -04:00
Jeff Young
1047130046
Push most of footprint chooser into PANEL_FOOTPRINT_CHOOSER.
...
Create 2 wrappers for it: DIALOG_FOOTPRINT_CHOOSER and
FOOTPRINT_CHOOSER_FRAME. The first now gets called from wxGrid
editors, text button editors (such as Change Footprints), etc.
Retire FOOTPRINT_VIEWER_FRAME_MODAL. FOOTPRINT_VIEWER_FRAME still
exists, but has very few uses at this point.
2023-09-27 16:02:13 +01:00
jean-pierre charras
e1d7d1bca7
Fix a link issue on mingw/msys2
2023-09-27 10:20:18 +02:00
Marek Roszko
4746bde4b3
gal as a shared lib, gaasl!
2023-09-26 22:31:31 -04:00
Marek Roszko
464179894d
Another set of movement to kicommon
2023-09-26 22:30:42 -04:00
Jeff Young
54171ec030
Add action for switching to Project Manager.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15740
2023-09-26 17:25:57 +01:00
Jeff Young
aab0696bb6
Zoom undo/redo for simulator.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14580
2023-09-26 13:19:41 +01:00
Marek Roszko
37e8a008ab
Remove obsolete config_params.h includes
2023-09-25 20:40:29 -04:00
Jeff Young
43edbcc622
Add batch edit for visible flag.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14519
2023-09-26 00:31:37 +01:00
Marek Roszko
7010f7963c
EDA_ITEM does not belong in VIEW
2023-09-25 19:30:42 -04:00
Jeff Young
04214983cf
Repair standalone application 3D plugin path resolution.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15322
2023-09-25 18:03:27 +01:00
Jeff Young
902e5df2e8
Report unsupported DXF features on import.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15614
2023-09-25 16:21:11 +01:00
Jeff Young
88e34fd482
Coding style.
2023-09-25 16:21:11 +01:00
Marek Roszko
050f812f5e
Move fontconfig to kicommon for now to de-duplicate the font cache
2023-09-24 22:58:18 -04:00
Marek Roszko
c006482feb
Add SETTINGS_MANAGER::GetUserSettingsPath back because swig
2023-09-24 20:10:32 -04:00
Seth Hillbrand
91450c22cc
Allow disambiguation menu configurability
...
Adds an advanced config flag to all testing different values for
different users.
Related to https://gitlab.com/kicad/code/kicad/-/issues/15128
2023-09-24 16:33:05 -07:00
Marek Roszko
98b35b1a7f
Start using the sentry environment tag
2023-09-24 14:42:00 -04:00
Andre Iwers
f2fdf0f3df
httplib: add support for exclude attributes
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15720
2023-09-24 13:37:01 +00:00
Marek Roszko
e3285c234a
Move executable path to PATHS to avoid a circular dependency
2023-09-23 20:21:37 -04:00
Marek Roszko
3c18e216b1
Move configparams to kicommon
2023-09-23 20:06:58 -04:00
Marek Roszko
121ea99824
Move the settings path to PATHS to allow shifting other classes into kicommon
2023-09-23 20:06:58 -04:00
Marek Roszko
37479c4154
HIDPI_GL_3D_CANVAS needs CAMERA so move it over
2023-09-23 20:06:57 -04:00
Marek Roszko
563cd522eb
confirm is now free to live in kicommon
2023-09-23 10:24:47 -04:00
Marek Roszko
eb84c29414
Remove confirms dependence on pgm_base and unused header
2023-09-23 10:20:31 -04:00
Marek Roszko
1c11a599c8
Move trace_helpers to kicommon
2023-09-23 09:37:47 -04:00
Marek Roszko
f8e33be07f
Break out the boundary violating parts of gal into common through subclassing
2023-09-23 09:37:47 -04:00
Jeff Young
0f94b467ba
Fix arg parsing in ExecuteFile.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15326
2023-09-23 14:34:54 +01:00
Jeff Young
722a90213c
Correct path of pcb drawing sheet file on saveAs.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15551
2023-09-22 18:48:29 +01:00
Alex Shvartzkop
3ee2086f95
Don't freak out when can't warp the pointer.
2023-09-22 05:10:42 +03:00
afkiwers
a1708637fc
fixed missing desciption in symbol chooser
2023-09-22 01:15:32 +00:00
jean-pierre charras
e152f97f35
Fix minor Coverity warnings. Small code cleaning in pcb_parser.cpp
2023-09-21 11:33:29 +02:00
Seth Hillbrand
b2ef620ea6
Focus back to the main window after dialog
...
Mouse actions would focus the window but we explicitly set it here to
allow keyboard shortcuts
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15603
2023-09-20 17:38:06 -07:00
Jon Evans
0cf09fe374
macOS: fix errant rpath
2023-09-20 14:37:44 -04:00
Mike Williams
9541e45502
BOM Exporter: allow using presets from the command line
2023-09-20 10:57:43 -04:00
Marek Roszko
ee91b550d8
gl_context_mgr and gl_util belong in the gal folder
2023-09-19 23:06:44 -04:00
Marek Roszko
43a59275c3
Remove unused header
2023-09-19 21:14:26 -04:00
Jon Evans
9973dd3e5d
Fix sentry compile issues on macOS
2023-09-19 20:31:14 -04:00
Marek Roszko
9deff07ca6
Save 470KB by not re-initializing lineTypeNames over a thousand cpp files it leaks into
...
I saved a bunch of money on my car insurance by switching to Extern
2023-09-19 20:05:55 -04:00
Jeff Young
dedefb743b
Even out spacing in GAL display options.
2023-09-19 17:47:30 +01:00
Jeff Young
58889f8120
Improve shape properties dialog layout.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15683
2023-09-19 17:04:05 +01:00
Jon Evans
1635df57a3
httplib: code style fixes
2023-09-18 21:37:34 -04:00
Jon Evans
8f6ae8c6b3
httplib: code style / spelling fixes
2023-09-18 21:27:39 -04:00
Andre Iwers
2bcad18cc2
ADDED: HTTP library support
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12027
2023-09-19 01:09:21 +00:00
Marek Roszko
22b733209d
Fail GAL on its header leaking audit
...
Maybe we should rethink directly accessing GAL so much, but at least 600 files didn't need GAL leaked into them due to view_overlay.h
2023-09-18 19:52:27 -04:00
jean-pierre charras
a568e4f4d3
Fiw a few compil and Coverity warnings.
2023-09-18 18:15:02 +02:00
Alex Shvartzkop
1decd31baf
Vertically center wxGrid cells by default.
2023-09-18 17:15:34 +03:00
Alex Shvartzkop
768d4a6782
Wayland: fix cursor warping on KDE and Weston, add logging.
2023-09-18 12:56:54 +00:00
Alex Shvartzkop
06463fd35a
Fixes for Wayland cursor warping:
...
- Emulate the mouse position, since no motion events are sent after warp
- Do not call wl_surface_commit to prevent an assert
- Re-organize code a bit
2023-09-18 12:56:54 +00:00
Clément Saccoccio
ad62b165fe
Fixed infinite mouse-drag with fast movement on Wayland.
2023-09-18 12:56:54 +00:00
Marek Roszko
4a53c8f330
newstroke_font can live in kicommon
...
Turns out, gal doesnt even use newstroke_font.h anymore, stop bleeding it everywhere due to the gal header
2023-09-18 07:40:02 -04:00
Jeff Young
93a5d01230
Unroll ACTIONS::CURSOR_EVENT_TYPE into a flat enum.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15666
2023-09-18 12:38:34 +01:00
Jeff Young
ef92429ac2
Implement changed notifiers for textvar, netclasses and severities.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15440
2023-09-17 17:35:15 +01:00
Jon Evans
6f9af10912
DbLib: support columns with numeric data
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15662
2023-09-16 22:37:12 -04:00
Marek Roszko
2de38f8d75
Force jobs to be instantiated in kicommon
...
This is important since these get passed between modules at runtime
2023-09-16 21:02:33 -04:00
Marek Roszko
ab8bcf537e
EDA_UNITS_UTIL to kicommon
2023-09-16 19:43:49 -04:00
Marek Roszko
d504b77af7
Remove unneeded pgm_base.h include
2023-09-16 19:41:50 -04:00
Marek Roszko
0b99d77fb5
Move layers to kcommon
2023-09-16 19:12:55 -04:00
Marek Roszko
2b90607dcd
Shuffle color4d into kicommon since its used many places
2023-09-16 19:12:55 -04:00
Alex
e603ba4f3e
wxGTK: add GDK display type to version info.
2023-09-16 21:53:47 +03:00
Josue Huaroto
33f5483bc9
Change Y min/max limits in simulation plot window
2023-09-15 17:50:02 +00:00
Mark Roszko
21c81a5392
Fix version_header depend for kicommon
2023-09-15 17:01:38 +00:00
jean-pierre charras
5a81977024
Fix a link issue on msys2
2023-09-15 08:47:42 +02:00
Marek Roszko
4af68a70d1
Manifest kicommon on msvc
2023-09-14 20:21:01 -04:00
Marek Roszko
285f8c0b88
KIID kicommon
2023-09-14 19:21:55 -04:00
Marek Roszko
cb7d7b09e3
config_params doesnt need color4d
2023-09-14 19:21:55 -04:00
Alex Shvartzkop
e6d6a06480
Fixes for wx 3.3 in pg_editors.cpp
2023-09-14 19:05:46 +03:00
Alex Shvartzkop
ff49d5ada9
Fix ambiguous overloads on wx 3.3
2023-09-14 19:05:46 +03:00
Jeff Young
c7e865e4a2
Safety for negative pen widths.
2023-09-14 13:39:35 +01:00
jean-pierre charras
931401b5be
Fix a compil issue (missing header) and a minor compil warning
2023-09-14 08:44:09 +02:00
Marek Roszko
5b9aab9070
fontconfig.cpp doesn't need pgm_base.h
2023-09-13 23:14:50 -04:00
Marek Roszko
e2c2875765
BITMAP_INFO kicommon
2023-09-13 23:11:03 -04:00
Marek Roszko
2b0d091636
MARKUP_PARSER kicommon
2023-09-13 21:37:35 -04:00
Marek Roszko
d1f2b14ee2
wx_filename to kicommon
2023-09-13 21:16:27 -04:00
Alex
66922b3bd2
Add hacks for EGL on Wayland
2023-09-14 03:54:01 +03:00
Jeff Young
e492efe3c5
Finish up custom-shaped pad spoke templates.
...
Also fixes a bug in number box for rotated pads.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13962
2023-09-13 23:34:25 +01:00
Jeff Young
d6b75c64e1
ADDED: custom-shaped pad spoke templates.
2023-09-13 23:34:25 +01:00
Marek Roszko
66021f0657
Low hanging fruit to kicommon
2023-09-11 21:52:10 -04:00
Marek Roszko
a4bf2ff41d
LIB_ID to kicommon
2023-09-11 21:52:04 -04:00
Marek Roszko
f0987821b5
Move locale_io to kicommon
2023-09-11 21:51:58 -04:00
Marek Roszko
4ac5404822
Move HTML_WINDOW to widgets folder, also fix some fbps that were wrongly not edited
...
Somebody manually edited at least 3 files fixed here....so the fbps were wrong
2023-09-11 19:10:16 -04:00
Jeff Young
402b701c9e
Formatting.
2023-09-11 22:05:24 +01:00
Alex Shvartzkop
9f63820ed4
Fix a bug in RebuildBezierToSegmentsPointsList.
2023-09-11 09:35:07 +03:00
Marek Roszko
b5d5eb842a
Start a kicommon shared lib
2023-09-09 18:04:50 -04:00
Alex Shvartzkop
ead44d58a0
Fix bezier curves drawing in schematic/libedit.
2023-09-09 20:28:49 +03:00
jean-pierre charras
b4c5d46825
wx_filename.cpp: replace include macro.h by include string_utils.h
...
(missing change in commit 11de9577
)
2023-09-09 09:38:44 +02:00
Marek Roszko
11de95778b
Unwrap the FROM_UTF8 macro in favor of direct function
...
The extern just gets annoying to try to export the func later. We also yeet TO_UTF8 to string_utils.h for parity.
2023-09-09 00:10:57 -04:00
Alex Shvartzkop
bc846f5fca
SVG import: skip shapes that are not stroked and not filled.
2023-09-08 14:46:04 +03:00
Marek Roszko
3cd60007c5
Dont leak richio into everything
2023-09-07 22:29:40 -04:00
Marek Roszko
1a6d459fb1
Fix wrong path slash
2023-09-07 22:09:26 -04:00
Marek Roszko
5da88d1d0e
Move UTF8 to core
2023-09-07 20:55:16 -04:00
Marek Roszko
6e04c2835a
Remove unused header
2023-09-07 20:46:08 -04:00
Marek Roszko
e83f87520c
Transform is right at home in kimath
2023-09-07 18:03:33 -04:00
Jeff Young
0310973e3f
Push TEXT_SPIN_STYLE from SCH_TEXT out to SCH_LABEL_BASE.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15444
2023-09-07 17:42:51 +01:00
Marek Roszko
7505fd0f37
Profile can live in core
2023-09-07 07:47:01 -04:00
jean-pierre charras
3e6f7ab3e5
Fix compil issues (especially easyeda_parser_base.xx) and compil warnings
...
Compil issues can be gcc13/msys2 specific.
2023-09-07 13:41:25 +02:00
Alex Shvartzkop
21ee65aa9c
ADDED: Importers for EasyEDA (JLCEDA) Standard / Professional.
2023-09-07 11:02:40 +03:00
Alex Shvartzkop
024622b0f6
SVG import: skip invisible shapes.
2023-09-07 10:57:02 +03:00
Alex Shvartzkop
05a8e59884
Move wxString and std::optional JSON serializers to core header.
2023-09-07 10:57:02 +03:00
Alex Shvartzkop
5b438d6398
Optimize makeEffectiveShapes for polygons.
2023-09-07 10:57:02 +03:00
Alex Shvartzkop
1b8abdfde7
ADDED: Basic STEP manipulation utils available to Python.
2023-09-07 10:57:02 +03:00
Marek Roszko
e944a61830
Nothing but the pcb calc will use eseries for the forseeable future
2023-09-06 23:44:41 -04:00
Marek Roszko
96bec8c553
promote base64.cpp to core
2023-09-06 23:27:08 -04:00
Marek Roszko
72669df354
Kick out strtok_r, all our platforms should have it (or strtok_s)
2023-09-06 23:18:55 -04:00
Marek Roszko
f45d61ef18
OUTLINE_FONT does not need Pgm() or settings or EDA_TEXT
2023-09-06 22:12:59 -04:00
Marek Roszko
19db0f943f
Restore gal recursive link to common
2023-09-06 21:59:01 -04:00
Marek Roszko
10c495952e
Snip 2 useless includes in transform.cpp
2023-09-06 21:34:02 -04:00
Marek Roszko
5c62b98e7c
observable can live in core
2023-09-06 21:25:24 -04:00
Marek Roszko
81c069c1a3
Lets see if any platform barfs dropping gal's link to common
2023-09-06 20:33:51 -04:00
Marek Roszko
67b031adab
Painter base class should just live in gal instead of being in denial
2023-09-06 20:23:19 -04:00
Marek Roszko
a6a20bf8dc
Evict the Pgm() dependency in GAL
2023-09-06 20:13:46 -04:00
Josue Huaroto
cef0f176d3
Add Unselect all in menu
2023-09-06 23:44:39 +00:00
Marek Roszko
a7a642e090
Remove one errant gal dependency on python
2023-09-06 18:41:13 -04:00
Marek Roszko
a4d8c021aa
Remove rouge gdicmn include
2023-09-06 18:33:22 -04:00
Marek Roszko
4d77fd48ef
Shove thread_pool to core
2023-09-06 17:50:12 -04:00
Seth Hillbrand
c7868f0832
Altium Plugin updates
...
Handle Altium multiple display modes (e.g. DeMorgan)
Handle Altium overbar format (o\v\e\r\b\a\r\)
Transform ellipses and elliptical arcs into approximate arcs
Add remaining unknown RECORD ids
2023-09-06 19:15:35 +00:00
Seth Hillbrand
1b63d11adf
Speed up Altium compound file reader
...
Just read the footprint list once and store the cache for later use.
2023-09-06 19:15:35 +00:00
Seth Hillbrand
24d3df5416
ADDED: Altium SchLib Support
2023-09-06 19:15:35 +00:00
Seth Hillbrand
f9b745f3d2
Allow multiple format image saving
...
- Keep original image data. When loading JPEG, this avoid recompression
that changes file data and decreases image quality
- Allow schematic and page layout editors to store non-PNG data as well
- Move page layout editor to store base64 instead of hex-coded data
2023-09-06 12:12:32 -07:00
Seth Hillbrand
0e382669d0
ADDED: Support for saving JPEG files in kicad_pcb
...
When users add an image to the board, this change keeps the original
file format when saving instead of converting the files into PNG-format,
which had the effect of making some board files much larger and slower
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14892
2023-09-06 12:12:32 -07:00
Jeff Young
6a73f48106
Disable previews when context menu active and when scrolling.
2023-09-06 16:23:13 +01:00
Jeff Young
634524dde5
Validate new symbol / save as symbol info before exiting dialog.
2023-09-05 22:07:58 +01:00
Jeff Young
0dddb27408
Include underscore in word chars.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14779
2023-09-05 19:44:53 +01:00
jean-pierre charras
cbcaaa001c
fix some Coverity and compil warnings.
2023-09-05 20:30:08 +02:00
jean-pierre charras
679733cc42
remove useless includes.
2023-09-05 18:57:17 +02:00
Alex Shvartzkop
a84c01b1ed
Fix properties crash when selecting libedit arc and non-EDA_SHAPE.
2023-09-05 14:07:43 +03:00
Jeff Young
d57b726c90
Bug fix for lib-tree previews when lib-tree is hidden.
2023-09-04 22:21:39 +01:00
Alex Shvartzkop
3215223ee2
Move fix_board_shape.cpp to pcbcommon.
2023-09-04 22:26:47 +03:00
Marek Roszko
07ecdc5fbb
Force close the splash
2023-09-04 09:20:05 -04:00
Marek Roszko
ec64ceeff2
Add a custom wx splash class to nullify the filterevent that causes crashes
2023-09-04 08:51:30 -04:00
Jeff Young
fe0fb92441
Reduce visual clutter in GAL display options.
2023-09-04 13:06:46 +01:00
Jeff Young
4eb51be0a2
Streamline fetching topLevelParent.
2023-09-04 11:12:34 +01:00
jean-pierre charras
ddb141ff08
GAL_OPTIONS_PANEL: replace 2 wxSpinCtrlDouble to try to fix a locale issue.
...
Sometimes the grid thickness setting does not work, depending on some locale setting.
Core developers are not able to reproduce this issue related to a double conversion.
So these wxSpinCtrlDouble are replaced by a wxSpinCtrl (using ints) and a wxChoice.
2023-09-04 11:32:55 +02:00
Josue Huaroto
e7d6c84aef
Replace ':' to '{', '}' for alias in variable path
2023-09-03 20:52:29 +00:00
Josue Huaroto
91d8dabca3
Change behavior of ZOOM_FIT_ALL and ZOOM_FIT_OBJECTS for PCB_EDITOR
2023-09-03 19:58:28 +00:00
Josue Huaroto
a8e18e2d8c
Flip Viewport when Flip board is enabled
2023-09-03 12:30:32 +00:00
Jeff Young
e6b0a6abca
ADDED: lib tree previews.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2418
2023-09-02 23:30:22 +01:00
Alex Shvartzkop
3bd8ff442d
SVG import: set C locale to make fractional units work.
2023-09-02 18:57:18 +03:00
Alex Shvartzkop
8a4f203963
Altium: remove illegal chars from library name.
2023-09-02 10:36:03 +03:00
Alex Shvartzkop
0317a1f687
Fix arcs in gerber export once again.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15559
2023-09-02 00:00:34 +03:00
Jeff Young
69a1b30b8a
Implement undo/redo around Pad Edit Mode changes.
2023-09-01 18:48:46 +01:00
Marek Roszko
f357e79f77
Add --define-var / -D to the cli opts for some commands
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15437
2023-08-31 21:46:37 -04:00
Marek Roszko
b542539546
Add --drawing-sheet arg for various cli commands for overriding the project sheet
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15438
2023-08-31 19:53:23 -04:00
Josue Huaroto
27048ad4d2
Half number of ticks according to window size
2023-08-31 22:50:14 +00:00
Jeff Young
c9acca1342
Make fromHotkey parameter explicit, and don't set it for non-hotkeys.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15527
2023-08-31 17:01:14 +01:00
Marek Roszko
cd884211ef
Actually use the sentry dsn define
2023-08-31 06:57:31 -04:00
Jeff Young
09288ecbe2
Formatting.
2023-08-31 11:36:39 +01:00
Marek Roszko
2dcb7caacf
Add an explicit border property to textboxes
...
This means it can remember the last border stroke between enabling/disabling the border
2023-08-30 22:33:55 -04:00
Marek Roszko
87513b4a04
Change the sentry dsn to be build time defined
...
We ultimately don't want people running personal builds to turn on sentry and start sending us crash logs we can't decipher
2023-08-30 22:17:38 -04:00
Alex Shvartzkop
e128896ba6
Schematic plugins refactoring, fixes for PCB plugins.
...
- Move PLUGIN_FILE_DESC to common.
- SCH_PLUGIN: rename Load -> LoadSchematicFile, Save -> SaveSchematicFile.
- Use PLUGIN_FILE_DESC and CanRead* in schematic plugins.
- Return none/unknown types from Find/GuessPluginType functions.
- Iterate over file types for file wildcards.
- Clean-up header checking in IO plugins.
- Use PCB plugin list in IO_MGR::GuessPluginTypeFromLibPath.
2023-08-31 05:08:03 +03:00
Jon Evans
1a8fcdfdd7
Do not crash if PARAM_LIST backing data contains unexpected type
2023-08-30 14:31:27 -04:00
Mike Williams
b8a61719c3
Grids: make overrides use existing grids (choice box)
2023-08-30 13:33:04 -04:00
Mike Williams
b1a388ca69
Grids: Support X and Y for all grids, add optional names
2023-08-30 11:22:19 -04:00
Mike Williams
9002ade554
Schematic: default editors to mils
2023-08-30 11:22:19 -04:00
jean-pierre charras
17775e5377
UNIT_BINDER: allows more room to show values (especially inches need room)
...
Fixes #15539
https://gitlab.com/kicad/code/kicad/-/issues/15539
2023-08-30 09:12:59 +02:00
Josue
94e86a69be
Update RECT to RECTANGLE
2023-08-29 11:50:22 -05:00
Josue
6429051750
change Rectangle property: Length to Height
2023-08-29 11:50:05 -05:00
Josue
c3766bb250
Implement Length and Width for RECT
2023-08-29 11:50:02 -05:00
Josue
5061ca54e7
add length and angle properties to segment
2023-08-29 11:49:55 -05:00
Ian McInerney
040d192690
Migrate common actions to new constructor
2023-08-29 00:19:19 +01:00
Ian McInerney
49705a711e
Update fake hotkey action to new constructor
2023-08-29 00:19:19 +01:00
Roberto Fernandez Bautista
32b6deb8b1
ADDED Migrate libraries button in Footprint Library Table
...
Allows easy migration of legacy and non-KiCad footprint libraries
2023-08-28 22:44:10 +02:00
jean-pierre charras
7ac3e09a08
PANEL_SETUP_SEVERITIES::ImportSettingsFrom(): fix crash: ensure the option
...
actually exists before setting it.
Fixes #15525
https://gitlab.com/kicad/code/kicad/-/issues/15525
2023-08-28 18:19:10 +02:00
Jeff Young
0e8ca6e952
Increase minimum panel sizes a bit.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15523
2023-08-28 15:55:37 +01:00
Mike Williams
b5cfd91268
Preferences: reset tools after grid changes
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15522
2023-08-28 08:15:27 -04:00
Mike Williams
3edcef0229
Grids: remove more uses of old user grid in UI
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15515
2023-08-28 07:27:25 -04:00
Roberto Fernandez Bautista
7037076360
Symbol Library Table: Show CADSTAR Parts Libraries in file selector
...
Even if same extension, it is good to display it as a way of showing what
we support
2023-08-27 20:52:45 +02:00
Jeff Young
a946f7ab1b
Handle non-cardinal major-axis arcs when importing DXF.
2023-08-27 16:36:12 +01:00
Jeff Young
eba8acf602
Attempt to fix presumed event ordering issue on MSW.
2023-08-27 13:25:39 +01:00
Jeff Young
75b160e83a
Handle DXF arcs with a flipped coord system.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14905
2023-08-27 13:16:49 +01:00
Ian McInerney
375c2db844
Fix index calculation in grid submenu
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15514
2023-08-26 22:10:13 +01:00
Marek Roszko
208d146a03
Force fontconfig to look at the correct path for fonts.conf on windows
2023-08-26 13:53:43 -04:00
Marek Roszko
53bf7b71c6
Don't call FcInitLoadConfigAndFonts after FcInit() already happened
...
We are only the default global FcConfig created by calling FcInitLoadConfigAndFonts inside FcInit().
Calling FcInitLoadConfigAndFonts does nothing but creating another FcConfig option that never gets disposed or used because we use the FcConfig functions with null
2023-08-26 13:53:43 -04:00
Marek Roszko
25967b4a0f
Fix font map cache access creating invalid entries (and crashes)
2023-08-26 09:24:47 -04:00
Jeff Young
4fefd95e0c
Move grid definitions to Prefs and grid origin to a separate dlg.
...
Grid origin is document-wide, while grid definitions are app-wide.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2262
2023-08-26 13:32:24 +01:00
Marek Roszko
cbc60d90ec
Add missing line style prop to eda_shape
2023-08-24 22:32:12 -04:00
Marek Roszko
d193334a10
Add vrml export to cli
...
Roughcut as the vrml exporter needs some loving
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15472
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13952
2023-08-24 20:39:21 -04:00
Alex Shvartzkop
16c35857bf
Fix arcs drawing in Cairo.
2023-08-25 00:09:56 +03:00
Mike Williams
c7abbccfac
Grids: update context menu on changes to grids
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15492
2023-08-24 14:20:02 -04:00
Mike Williams
2764e59400
Grids: add buttons to re-order grids
2023-08-24 13:58:22 -04:00
Mike Williams
1628b65d79
Grid Settings: keep sane via value when hidden in schematic editors
2023-08-24 12:38:54 -04:00
Mike Williams
d00a6b4987
Dialogs: add some margins back for GTK
2023-08-24 12:38:54 -04:00
Jeff Young
0f81dd3b5e
Give Grid Settings a more standard KiCad look and feel.
...
Also simplifies the dialog by removing the user grid (now that you
can add as many user grids as you want).
This does mean that you can no longer have an asymmetric grid, but
it gets too complex if we allow everything for everyone.
2023-08-24 16:41:08 +01:00
Mike Williams
d9c2e0ab54
PCB: start of grid overrides
...
Only works for moves.
2023-08-24 10:29:09 -04:00
Mike Williams
0f781f328e
GRID_HELPER: push code to parent class
...
Prep'ing for PCB grid overrides
2023-08-24 10:29:09 -04:00
Seth Hillbrand
db8e15ce88
Require wxWidgets 3.2
...
Removes old defines and work arounds for earlier wx versions and adds a
CMake requirement to use at least 3.2 (or the minimum matching wxPython
version)
2023-08-23 22:02:56 +00:00
Jeff Young
0c37e3c443
Remove realistic-mode (and duplicated settings from preferences).
...
Most of these settings are now available in the appearances panel.
It was concluded in a Zulip discussion that any missing items can
be added back in time if people find they need them (ie: complain).
Also hooks up 3DViewer to the common language framework.
2023-08-23 14:07:58 +01:00
Alex Shvartzkop
10e2e4a12d
Another try at fixing arcs.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15471
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15469
2023-08-22 16:10:58 +03:00
Mike Williams
f770500bb4
Grids: make user editable
2023-08-21 15:48:25 -04:00
Jeff Young
55a7b9e6bf
More consistent naming.
...
(Also better differentiates the PCBEXPR_ classes from PCB_
objects.)
2023-08-21 15:26:33 +01:00
Mike Williams
d150803dee
Grid Tricks: entering editor needs to set selection to edited cell
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15453
2023-08-21 09:14:27 -04:00
Jeff Young
3a40b59cd3
Ensure lazy evaluation of DRC rules works on all compilers.
2023-08-21 13:05:37 +01:00
Marek Roszko
b52b05ebbb
Add zone export to step export
...
Mileage may vary on performance, decent enough for my board.
Warning, freecad chokes on boards with zones, but commerical tools are fine
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15234
2023-08-20 22:11:45 -04:00
Jeff Young
cf22d5b99b
Preferences setting for force-show-fields-when-fp-selected.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15215
2023-08-20 18:10:28 +01:00
jean-pierre charras
1c11a2c7bd
Capture exceptions thrown by FP_LIB_TABLE::FindRow() in some places.
...
FindRow() exception is unfortunately not captured in all places using it.
The result is the application closes.
2023-08-20 12:27:37 +02:00
Marek Roszko
ea3101587a
Add gltf export to step dialog
2023-08-19 19:01:29 -04:00
Marek Roszko
50ac5db8d2
Add binary GLTF export option to kicad-cli
...
Not by any means finished
2023-08-19 16:47:42 -04:00
Marek Roszko
5870b4f373
Mini-refactor step to a generic "3d" cli option (step command still exists for now)
2023-08-19 16:47:41 -04:00
Jeff Young
a2627fec60
Don't snap to footprint-private items.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15447
2023-08-19 21:03:05 +01:00
Alex Shvartzkop
865fa10fb2
Fix pad arcs in Gerber plot when aperture macros are disabled.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15452
2023-08-19 22:49:37 +03:00
Jon Evans
373fb56fb7
Fix legacy lib table loading logic
...
Also enforce locking of the mutex
2023-08-18 22:46:33 -04:00
Jeff Young
6c9ba52f18
Clean up naming.
2023-08-18 22:20:09 +01:00
Seth Hillbrand
57ba38560c
Optimize library load time for Altium plugin
...
Load times were >20min for moderate sized libraries as EnumFiles
iterated over the entire list for each operation. The update modifies
our third-party lib to allow a return value, stopping the iteration when
we find our desired entry. This also provides a short-circuit for
ASCII-based names, allowing single-level parsing if available
2023-08-18 13:50:15 -07:00
Alex Shvartzkop
5131dae568
Graphics import improvements/fixes:
...
- add support for color
- support non-uniform scale
- add GetImageBBox()
- fix SVG GetImageWidth/Height not being in mm
- fix import offset not being in mm
- add graphics importer for LIB_SYMBOL
2023-08-18 22:52:49 +03:00
Alex Shvartzkop
4e43d4e0db
Graphics import: support loading from memory buffer.
2023-08-18 22:52:40 +03:00
Alex Shvartzkop
26a52ecfe9
Move parts of import_gfx to common.
2023-08-18 22:43:54 +03:00
Jeff Young
988a90d5ee
Ignore LOD scale for selections, but not things explicitly hidden.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15215
2023-08-18 12:35:32 +01:00
jean-pierre charras
bc59ed08b4
EDA_SHAPE::TransformShapeToPolygon() for filled SHAPE_T::POLY: use another algo:
...
previously, for aClearance/width > 0, a seg of segments (width = aClearance*2) was added
to the polygon shape. This is acceptable for polygons having not a log of vertices.
It does not work fine (bad shape, extremeny long calculation time) if there are
a **lot** of vertices.
Now the polygonal shape is just inflated by width/2. Much faster and better shape.
2023-08-18 12:58:48 +02:00
Rastersoft
5936960c1e
Allow to reverse the mouse wheel movement
...
This MR adds a CheckBox in the preferences window to reverse the
horizontal pan direction
2023-08-17 19:17:50 +00:00
Rastersoft
43fe1eec84
Unify mouse movements
2023-08-17 18:20:22 +00:00
Jeff Young
88db775d32
Disable "Override individual item colors" on read-only themes.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15426
2023-08-17 11:23:58 +01:00
jean-pierre charras
53b2fda184
Fix some minor compil and Coverity warnings.
2023-08-17 10:06:17 +02:00
Alex Shvartzkop
556120554e
SVG plotter: fix hidden text orientation when plot is mirrored.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15422
2023-08-16 10:43:24 +03:00
Jon Evans
e0d4cf2d5b
DbLib: Provide more useful feedback when table is misconfigured
...
(cherry picked from commit 8f57fd82a0
)
2023-08-15 20:45:52 +00:00
Jeff Young
686704bb31
ADDED: plot control over FP text.
...
(Also adds said control to "Follow Plot Settings" in 3D viewer.)
2023-08-15 16:56:46 +01:00
Jeff Young
8c33c6c099
Remove unused variable.
2023-08-15 14:08:19 +01:00
Jeff Young
f28d29ce1a
Center paged dialog after lazy-loading first page.
2023-08-15 12:55:40 +01:00
Alex Shvartzkop
76e0d5981d
Import system refactor for PCB plugins.
2023-08-15 05:26:12 +03:00
Jeff Young
f45760062b
ADDED: appearances manager for 3D viewer.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12413
2023-08-14 18:08:36 +01:00
Marek Roszko
5d001d4858
ADDED: ERC over cli....mostly
2023-08-13 20:31:19 -04:00
Marek Roszko
87d36dbfd8
Fix up erc json a little
2023-08-13 19:19:20 -04:00
Marek Roszko
061d18cbb0
Support json reports as option in erc/drc dialogs
2023-08-13 19:19:19 -04:00
Marek Roszko
14a0fa435c
ADDED: DRC JSON report
2023-08-13 14:59:10 -04:00
Marek Roszko
34a13cb0c5
Add more thread safety to background jobs
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15395
2023-08-11 22:37:43 -04:00
jean-pierre charras
7fe80abdff
PCB_GRID_HELPER::BestSnapAnchor() fix overflow due to use of int.
...
GRID_HELPER::GetVisibleGrid() needs double, does not work with int (overflow).
Fixes #15389
https://gitlab.com/kicad/code/kicad/-/issues/15389
2023-08-11 17:59:24 +02:00
Jon Evans
f70b9920cb
Fix some warnings
2023-08-10 22:01:55 -04:00
Jon Evans
a77e630901
ADDED: Connectivity for graphic shapes on copper layers
...
Graphic shapes (excluding text) can now have nets when on
copper layers. Shapes behave like tracks in that they will
pick up nets from connected pads, and follow track opacity
settings.
2023-08-10 21:47:43 -04:00
Marek Roszko
812143ac69
ADDED: Run PCB DRC via cli
2023-08-10 20:20:40 -04:00
jean-pierre charras
e82f9e0305
Fix a change committed by mistake (fortunately in a not used code) in cff2583f
2023-08-10 16:28:41 +02:00
jean-pierre charras
cff2583f15
Minor fixes to help translations:
...
- do not translate a debug message.
- remove useless spaces at end of lines (always annoying for translators).
2023-08-10 10:16:24 +02:00
Marek Roszko
241375f41c
Add sort indicator to search pane
2023-08-09 20:09:14 -04:00
Alex Shvartzkop
9b2ac10002
LTspice spelling.
2023-08-10 00:31:21 +03:00
Alex Shvartzkop
712d61d2c1
KICAD_CURL_EASY: add SetPostFields().
2023-08-10 00:29:19 +03:00
Jeff Young
da86593625
ADDED: Implement sorting for search panes.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12614
2023-08-09 18:31:33 +01:00
Marek Roszko
4a54ea3b11
Try and fix multi-threading issues with the background job widgets
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15377
2023-08-09 07:19:38 -04:00
Jeff Young
8bb895373a
Allow GetLayer() to be used with single-layer zones.
...
Also fixes a bug in GetFirstLayer() where we were checking
m_layerSet.size() (which is always 60) rather than
m_layerSet.count() (which is the number of set layers).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15233
2023-08-08 12:43:22 +01:00
Ian McInerney
54759389de
Re-add event handler for the menu events generated on macOS
...
macOS' application menu generates command events and can't call our tool
framework directly, so we have to keep the event table handlers around
to handle these events.
2023-08-08 11:50:24 +01:00
Ian McInerney
a3a701a95e
Move preferences to an action instead of a wx event
2023-08-08 00:51:22 +01:00
Josue Huaroto
670936096e
Change behavior of polygons at the end of drawing.
2023-08-07 22:58:52 +00:00
Jeff Young
7b71e55ab9
Don't allow updates to shown_text outside of cacheShownText().
...
But also don't use cacheShownText() in c'tors, as it will not call
the subclass's version.
2023-08-07 23:22:09 +01:00
Roberto Fernandez Bautista
3bf9797620
PNS: add new "EnableRouterDump" kicad_advanced setting
2023-08-07 23:43:54 +02:00
Jeff Young
60f0db09aa
Make sure text gets rendered in correct colour.
2023-08-07 21:44:04 +01:00
Jeff Young
778213ba8f
LEGACY_FACTOR was upside-down.
...
(Should be 1.68/1.61, not 1.61/1.68.)
2023-08-07 14:01:58 +01:00
Jeff Young
f5c7455901
Better spacing for page settings.
2023-08-07 14:01:58 +01:00
Jeff Young
f43b90b15f
Lazy context handling for SVG plotting.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15325
2023-08-07 14:01:58 +01:00
Jon Evans
256c7fa788
Fix character specifier in validator format string
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15367
2023-08-07 08:38:19 -04:00
Alex Shvartzkop
717ee350c8
Support >180 deg arcs in schematic.
2023-08-07 14:18:38 +03:00
Jeff Young
b993311d47
Archive simulator workbook files.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15364
2023-08-06 21:57:02 +01:00
Marek Roszko
74ce1de3f4
Allow KICAD_TEST_NOTI to work with no existing file
2023-08-06 16:27:42 -04:00
Jeff Young
5e112ca78e
ADDED: parameterize font metrics and allow customization of overbar height.
2023-08-06 20:57:41 +01:00
Marek Roszko
a0ebedc0ac
Add a KICAD_TEST_NOTI env var for a fake notification on launch
2023-08-06 15:51:35 -04:00
Jon Evans
5cbe3c5d42
PNS: Fix a few issues with debug logging
...
Hide non-copper layers for clarity
Fix saving of router settings
2023-08-06 15:30:58 -04:00
Marek Roszko
ca55656850
Prevent negative center calc on BITMAP_BUTTON
2023-08-06 13:53:34 -04:00
Marek Roszko
856b70b4df
Add an extra spacer field for macOS statusbar
...
macOS lacks grippers and lets status bar fields use the rounded corner which we don't want
2023-08-06 12:05:06 -04:00
jean-pierre charras
5e04e90fb3
LENGTH_TUNER_TOOL: fix a bug (missing initialization) creating a serious isse.
...
m_inLengthTuner was not initialized, preventing the tool to be started (sometimes)
Fix also a few not initialized members.
2023-08-06 13:20:43 +02:00
Jon Evans
4c4bbdc8f3
Stricter API for LIB_TABLE
...
Prevent nickname map or row parent getting out of sync
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15315
2023-08-06 00:56:51 -04:00
Jeff Young
77c19261f6
Fix build.
2023-08-05 18:52:02 +01:00
jean-pierre charras
f18feb2a46
kicad-cli, export plot PDF and SVG: add missing option --drill-shape-opt.
...
It allows pad/via holes to ber plotted at actual size, small size, or not.
This option exists in GUI, but was missing in kicad-cli.
2023-08-05 18:18:18 +02:00
Marek Roszko
084ec1d669
Add no notifications text, declare frame border style
2023-08-05 11:53:04 -04:00
Jeff Young
0413270012
ADDED: Move Corner To... and Move Midpoint To...
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5012
2023-08-05 16:43:55 +01:00
Marek Roszko
5319316815
Enhance the status bar with background progress and notifications
2023-08-04 22:06:08 -04:00
Seth Hillbrand
c38ed7044a
ADDED: DNP flag for position file export
...
Adds ability to exclude footprints with DNP flag from position files in
dialog and cli
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15353
2023-08-04 11:02:54 -07:00
Seth Hillbrand
02335010ff
Don't try to get a translated empty string
...
Hashing an empty string can be crashy. And empty strings are reserved
in gettext, so we shouldn't try.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15354
2023-08-04 10:08:30 -07:00
Jeff Young
c697a934b2
Update layer names to current terminology.
...
Also fixes some out-of-date tooltips/names.
2023-08-04 11:37:46 +01:00
Ian McInerney
f463b9d017
Don't calculate minor ticks when there are no major ticks to be between
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15179#note_1480427547
2023-08-03 22:27:38 +01:00
Mike Williams
a75fb44349
Common: add fast grid cycling
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12339
2023-08-03 11:57:51 -04:00
Mike Williams
22c609fb7b
Schematic: handle aligning unaligned sheet pins in aligned sheet
...
Also fix a rounding bug.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15050
2023-08-03 11:11:34 -04:00
Jeff Young
686dfba77a
ADDED autocomplete for value field in Symbol Properties dialog.
2023-08-02 20:45:52 +01:00
Jeff Young
8ac49d0bab
General cleanup, coding standards, removal of dead code, etc.
2023-08-02 16:56:56 +01:00
Jeff Young
f897b4bac1
Remove cover routines for std::vector.
...
They just make it harder to see if we're following std::vector's
contract.
2023-08-02 16:56:56 +01:00
Josue Huaroto
74695b0995
Change variable substitution for paths in Windows.
2023-08-02 15:40:57 +00:00
Mike Williams
37fdcce0a0
Fields Editor Table: add checkboxes for fields representing attributes
...
DNP, Exclude from ..., etc.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15300
2023-08-01 14:33:30 -04:00
Mike Williams
25e391719e
Fields Table: convert special strings like Quantity to named variables
...
Before, we did not actually prevent users from adding a field also named
Quantity to their symbols. This of course does not play nicely with the
assumptions that Quantity is a special column in the fields editor.
By making it a named variable, the user can safely add it to a symbol
and it will not be editable, and will also work in the fields table
editor as expected.
2023-08-01 10:55:32 -04:00
Jon Evans
148e111579
Refactor pin orientation to be an enum class
...
Add various LIB_PIN properties
2023-07-26 23:46:15 -04:00
Kuba Sunderland-Ober
589030d672
Add the fraction numeric form glyphs.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14398
2023-07-25 16:58:16 +00:00
Mike Williams
132a0ada73
Grid Overrides: support grids-per-type that override the current grid.
...
Schematic only at this point while we test and refine.
PCB support is a future addition.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14756
2023-07-25 10:17:57 -04:00
jean-pierre charras
a16ab0aae1
Replace SHAPE_T::RECT by SHAPE_T::RECTANGLE: RECT creates a collision name
...
issue with a Windows header on msys2.
Change very similar to the commit 9a47b344
about class PAD_SHAPE.
No actual code change
2023-07-25 09:11:55 +02:00
Kuba Sunderland-Ober
b8fc45b14d
Implement fontconv in Python.
...
This fixes metrics of U+1F98 (ᾘ)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14398
2023-07-24 22:23:11 +00:00
Seth Hillbrand
32ad42a435
Add 3dconnexion driver version check
...
Re-enable 3dconnexion driver by default as we are able to gate the
driver versions
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13362
2023-07-24 18:09:52 +00:00
Mike Williams
7d9f791518
kicad-cli: sch bom export: fix inability to disable grouping
...
Just set --group-by default to "" (No default grouping), and drop the
additional --group option. Also fix the exclude DNP option.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15246
2023-07-23 13:59:28 -04:00
aris-kimi
ce58208d77
Add missing licence lines in iec60664 and naming update
2023-07-23 14:12:03 +00:00
Alex Shvartzkop
24452f41ad
Improvements to Altium PCB/footprint importer:
...
- Support unicode footprint names
- Set default footprint text size and thickness to match KLC
- Position Reference at the top, Value at the bottom of fp bounding box
2023-07-22 08:55:53 +05:00
Seth Hillbrand
7fe83993cf
Be smarter about releasing lockfiles
...
If KiCad crashes or exits without deleting the lockfile, don't show the
warning message unless we are not the one who locked it or there are
other KiCad instances running locally.
This should catch 99% of the cases where the message is shown
incorrectly. There may be some corner cases where the lock file is
created on a network drive using two different machines with the same
name and same user but these cases should be (famous last words)
sufficiently rare as to not be observed in practice
2023-07-21 15:40:19 -07:00
Seth Hillbrand
e71422d2cf
Avoid bulking drawing sheet polygons
...
On the drawing sheet, the polygons are always filled and shouldn't have
additional stroking
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15242
2023-07-21 11:22:32 -07:00
Jeff Young
06f19aa761
Implement y axis locking for secondary y axes.
...
Still a bit of a work-in-progress.
Also fixes some bugs with formatting of measurements and cursor values.
2023-07-20 17:21:19 +01:00
Jeff Young
9c08d4febe
ADDED support for simulation plot margins and GUI for Y axis locking.
2023-07-19 23:40:10 +01:00
Jeff Young
65f66755ee
Reduce overhead for unused code.
2023-07-19 23:25:05 +01:00
Jeff Young
764913207c
Read legend position from workbook.
2023-07-19 23:25:04 +01:00
jean-pierre charras
df11673f86
GetISO8601CurrentDateTime(): use %z format on msys2 build ucrt64
...
(however ucrt64 on msys2 has an issue (crash) with json validator and
can be used only for tests)
2023-07-18 11:23:09 +02:00
Ian McInerney
da1e82d57e
Fix the fix done in fa0338a9e6
2023-07-17 22:15:11 +01:00
Jeff Young
fa0338a9e6
Streamline Mac patches.
2023-07-17 22:07:36 +01:00
Jeff Young
f23f75866f
Remove dead code.
2023-07-17 22:06:45 +01:00
Jeff Young
64fea38e61
Seems linux impl is different....
2023-07-17 22:05:04 +01:00
Jeff Young
19073b3e61
Fix background drawing for disabled LAYER_BOX_SELECTOR.
2023-07-17 20:30:52 +01:00
Jon Evans
4e3fd816cb
Properties: rework color editor
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15145
2023-07-16 17:37:36 -04:00
Roberto Fernandez Bautista
6f035de988
Revert "Fix crash when opening schematic setup dialog"
...
This reverts commit 1a5fb68ace
.
[It was already fixed by b7d53e4b18
]
2023-07-16 21:47:27 +02:00
Roberto Fernandez Bautista
1a5fb68ace
Fix crash when opening schematic setup dialog
...
m_openPreferencesButton was not correctly initialised to nullptr
2023-07-16 21:42:05 +02:00
jean-pierre charras
58a9b75883
Eechema: Do Not Place markers: add a specific setting for their color.
...
Previously, the color was the ERROR ERC marker color.
Now they have a specific color.
2023-07-16 20:46:30 +02:00
Jeff Young
b7d53e4b18
Fix uninitialized var.
...
(Also follow Mac GUI guidelines, odd as they are.)
2023-07-16 19:29:38 +01:00
Jeff Young
7b81e964ab
Don't copy lock files during project Save As.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15207
2023-07-16 15:40:17 +01:00
Jeff Young
63c83b3aed
Remove dead code, and some formatting cleanup.
2023-07-16 14:43:29 +01:00
jean-pierre charras
0741471092
GetISO8601CurrentDateTime(): workaround on msys2 to fix a format issue.
...
on msys2 the format %z is seen as %Z, which is not acceptable here.
so %z format is removed on msys2
2023-07-16 09:31:28 +02:00
jean-pierre charras
0ecf5033e2
string_utils: Add From_UTF8( const char* cstring ) and From_UTF8( const std::string aString ),
...
mainly because we now use std::string in a lot of function using previously char*
FROM_UTF8(const char* cstring) now calls From_UTF8(const char* cstring)
2023-07-16 08:21:43 +02:00
Marek Roszko
76cef27014
Remove needless utf8 conversion due to sleepyness
2023-07-15 13:34:34 -04:00
Marek Roszko
3233bbe0ba
Make exported date time strings use ISO8601 format
...
Also rename the function to be explicit on its result format
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15185
2023-07-14 23:24:12 -04:00
Marek Roszko
cbb8835c87
Add policy to alter curl revoke settings on windows
2023-07-13 19:01:04 -04:00
Marek Roszko
b0fa2561b6
Add support for enum based policies
2023-07-13 19:01:04 -04:00
Mike Williams
c0a5be4e9f
Hotkeys: add support for alternate hotkeys
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/4422
2023-07-13 10:11:46 -04:00
Josue Huaroto
4cad021ef4
Add Open preferences folder button in Preferences Dialog
2023-07-13 14:10:31 +00:00
jean-pierre charras
34e9de72ae
fix a compil warning (shadowed var)
2023-07-13 07:46:08 +02:00
Ian McInerney
5aff8b6a6e
Switch to string_view in tool action construction
...
The TOOL_ACTION_ARGS construction method is supposed to be fairly light
weight, so instead of creating/destroying strings all the time, pass
string_views to the actual string data instead.
wx doesn't currently support string_view -> wxString implicitly
currently, so we have to do the conversion ourself.
2023-07-13 00:53:06 +01:00
Ian McInerney
e926952f66
Break long header link with TOOL_ACTION and TOOLS_HOLDER
2023-07-13 00:18:20 +01:00
John Beard
09c0f713cd
Add fillet and chamfer icons
2023-07-12 19:21:47 +01:00
Jeff Young
56752e9bad
Move some MRU paths from app to project.
...
Also augments Save As path updating to handle these newly-moved paths,
and to handle absolute paths that point into the project directory.
2023-07-12 17:30:42 +01:00
Mike Williams
265720ec65
BOM Export: add DNP to Group By * defaults
...
Closer to the BOM export scripts we are trying to replace, and gives the
user a clue that fields with variables names are way to export other
data.
2023-07-12 12:16:14 -04:00
Mike Williams
e2f47ecabb
Common: add GetTextVars for unexpanded variable names
2023-07-12 12:16:14 -04:00
Mike Williams
500779fc80
Properties: add ability to override writeable attribute
2023-07-12 12:16:14 -04:00
Marek Roszko
8abd32c97c
HideSplash() earlier before the initial frame->Show()
...
There are instances we can throw modals very fast on frame show :/
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15168
2023-07-12 06:55:01 -04:00
Mark Roszko
a38875d6dd
Add env variable to turn on curl verbose
2023-07-11 01:42:51 +00:00
mitxela
12be115c78
Prevent horizontal scrolling while zoom modifier is held
2023-07-10 19:37:46 +00:00
Jeff Young
eedf319ba4
Don't double-offset effective text shapes.
...
Also fixes several bugs with intersheet ref fields. (It's possible for
other fields to have an ID of 0.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15165
2023-07-10 19:32:00 +01:00
Alex Shvartzkop
176b308128
Update graphics error message, don't try drawing after.
2023-07-10 09:32:21 +05:00
Alex Shvartzkop
bad08f88a0
Restart drawing after switching backend to fallback.
2023-07-10 09:32:21 +05:00
Alex Shvartzkop
6a123e2381
OpenGL GAL: fix reserved vertices calculation in drawSegmentChain.
2023-07-10 09:32:21 +05:00
jean-pierre charras
4f3e7e6821
*.wks files: always save text font when it is not the default font.
...
Fixes #15154
https://gitlab.com/kicad/code/kicad/-/issues/15154
2023-07-09 10:51:33 +02:00
Jeff Young
692e060ff4
Fill in missing EDA_ITEM_DESC KICAD_T.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15144
2023-07-08 20:40:30 +01:00
Jeff Young
c8e8b71198
TestDanglingEnds needs to test sheet pins as well.
...
Also fixes a bug where zooming doesn't get a redraw until mouse moves.
Also fixes a couple of bugs where dangling markers on SCH_SHEET_PINs
and SCH_HIERLABELs weren't getting drawn.
Also simplifies drawing algorithm by removing aesthetic offset (which
wasn't implemented when pin is drawn as part of selection VIEW_GROUP).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15129
2023-07-08 12:55:45 +01:00
Alex Shvartzkop
2689037bde
PDF plotting: support bitmaps with transparency.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5979
2023-07-07 23:29:46 +05:00
Jeff Young
bde9c2cbc5
ADDED FFT analyses.
...
CHANGED abandon the unpredictable behaviour of the Simulation Command
dialog. You now separately add simulation tabs (which have invariant
command types once created), and the dialog edits the current tab.
Also a bunch of bug fixes to make multiple simulation plots actually
work.
2023-07-07 12:33:50 +01:00
jean-pierre charras
27072e52f7
Fix a compil and Coverity warnings
2023-07-07 10:28:01 +02:00
John Beard
10d32bb1d6
Explain wxASSERT in COMMIT::Stage
2023-07-06 21:11:51 +01:00
jean-pierre charras
88ffcec4b5
Plotters (especially DXF) add more precision when plotting arcs (and others)
...
- in DXF coordinates were using 6 digits for coordinate mantissa: this is not
enough for coord in inches. Now use 16 digits
- Arc( VECTOR2I& aCentre, EDA_ANGLE& aStartAngle, EDA_ANGLE& aEndAngle, ...)
was using integers for coord. This creates significant errors for start point
and end points of the arc. Now the center is given in double, and its position
is calculated from angle end points (and radius) to do not generate a position error
for these end points (previously the error could be 20 ... 50 nm)
Fixes #15056
https://gitlab.com/kicad/code/kicad/-/issues/15056
2023-07-06 18:09:38 +02:00
Kuba Sunderland-Ober
bb27f09108
Fix the missing segments in certain newstroke glyphs.
...
Fixes #14987 https://gitlab.com/kicad/code/kicad/-/issues/14987
2023-07-05 17:19:01 +00:00
Ian McInerney
2baf4db2b6
Fix tool manager handling in ACTION_MENU event processing
...
The event handler may not have access to a tool manager, so we must
always check for it.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15107
2023-07-04 21:40:14 +01:00
Alex Shvartzkop
e892405738
Altium PCB import: read and apply TrueType font names to text.
2023-07-04 13:29:42 +03:00
Alex Shvartzkop
afe176abe2
Optimize PDF plot data size for property popups; fix unicode escape.
...
Adds a document-level action JSInit, which defines ShM function,
allowing more compact data representation. Also reduces whitespaces.
2023-07-04 08:57:29 +03:00
Jeff Young
87c106965d
Code clarity.
2023-07-03 15:46:05 +01:00
Alex Shvartzkop
698fffb128
PDF plotting: Fix "Show Page" in Foxit PDF Reader.
...
pageNum is an Integer. Acrobat seems to convert automatically.
2023-07-03 09:13:37 +03:00
Alex Shvartzkop
b242779f3b
Put background color behind transparent bitmaps in eeschema printing.
...
Most virtual printers don't support alpha blending via AlphaBlend (MSW)
properly, nor masks.
2023-07-03 02:15:05 +03:00
Alex Shvartzkop
4cb7e92aad
Fix overlapping transparent images covering each other in OpenGL GAL.
2023-07-03 02:15:05 +03:00
Alex Shvartzkop
f286015bc7
Fix bitmap transparency in Cairo GAL.
...
Cairo ARGB32 format needs alpha pre-multiplied with color.
2023-07-03 02:15:05 +03:00
Alex Shvartzkop
0d7b4bbb09
Blend transparent images with background color in PDF plotter.
2023-07-03 02:15:05 +03:00
Alex Shvartzkop
7b5e725b98
Improve GAL panel refresh logic.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15041
2023-07-03 02:15:05 +03:00
Ian McInerney
236de6679c
Avoid copying tool parameter in intermediate function call
2023-07-02 22:18:24 +01:00
Ian McInerney
5e740c354e
Don't skip loading the wxWidgets message catalogs
...
The wxWidgets message catalog contains translations for strings that are
in the wx-provided dialogs, and these strings aren't contained in our
message catalog.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15035
2023-07-02 19:21:14 +01:00
Jon Evans
632e94ef81
Add a few more schematic properties
2023-07-01 22:24:25 -04:00
Jeff Young
980ef55356
Fix grammatical error in opt-in request.
...
Also makes it even more clear that design files aren't shared.
2023-07-01 15:47:12 +01:00
Jeff Young
773e1a1ab6
Actions with a COMMIT must be run synchronously.
...
Note that "immediate" doesn't mean quite the same thing: while it will
enter the tool immediately, it won't necessarily finish the tool during
the call if the tool has an event loop. So for something like Rotate
"immediate" and "synchronous" have the same behaviour, but for something
like Move they do not.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15085
2023-06-30 18:57:37 +01:00
Jon Evans
2ae646136e
Prevent crashes on invalid use of tools
...
See https://gitlab.com/kicad/code/kicad/-/issues/15085
2023-06-29 23:45:22 -04:00
Jon Evans
8fcd58038b
Properties: fix click not working multiple times on a color
2023-06-29 23:11:50 -04:00
Jon Evans
59495971ee
Properties: fixes to color swatches
2023-06-29 22:53:06 -04:00
Ian McInerney
e17cd5abc6
Allow action description to be different from tooltip
...
The tooltip should be short and easy to read, the description can be
longer and more detailed.
2023-06-30 00:06:03 +01:00
Ian McInerney
8b8586f54b
Add case to ignore the unused scroll events in the view framework
2023-06-29 23:21:15 +01:00
Jon Evans
3487124a4a
Properties: Improve color picker UX
2023-06-28 23:54:27 -04:00
Jon Evans
0e617774dd
DbLib: Remove slashes from table display names
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15074
2023-06-28 19:38:21 -04:00
Ian McInerney
107c79484d
Give default nullptr to gridSetOrigin to denote no known origin
...
Fixes KICAD-2BE
2023-06-29 00:17:12 +01:00
Youbao
4cb993d872
ADDED: Cadence Allegro PCB Designer netlist exporter
2023-06-28 22:47:30 +00:00
Kuba Sunderland-Ober
1edb9bb0ce
Get rid of VECTOR2U.
2023-06-28 20:48:07 +00:00
Jeff Young
c2f2247ae3
Don't process SCINTILLA_TRICKS onCharHook when autocomplete is active.
...
(ESC being the exception that proves the rule.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15001
2023-06-28 00:05:38 +01:00
Kuba Sunderland-Ober
95b9196703
Update the scripts to make the font source file fully reproducible.
2023-06-27 20:23:22 +00:00
Ian McInerney
2a940a5f70
Add COMMIT to TOOL_EVENTs instead of passing as a parameter
2023-06-27 00:57:59 +01:00
Ian McInerney
2fb6f19a84
Separate immediate and delayed action dispatch
...
Using a boolean argument just leads to a lot of trailing booleans in the
function calls and is not user friendly. Instead, introduce PostAction()
to send an action that runs after the coroutine (equivalent to passing
false or the default argument), and leave RunAction as the immediate
execution function.
2023-06-27 00:57:59 +01:00
Steve Bollinger
a318c57d77
Move E-series resistor selector table out of resistor value
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14627
2023-06-26 23:21:40 +00:00
Jeff Young
1b7473c353
Make sure Help menu is at end of menubar.
2023-06-26 14:11:13 +01:00
Jon Evans
c7f6b20405
Properties: Use color picker dialog
2023-06-25 16:32:43 -04:00
Jon Evans
a2ff3bce7d
Properties: custom rendering for COLOR4D
2023-06-25 16:13:07 -04:00
Jon Evans
bf2e9f8261
Properties for SCH_LINE
...
Also rename an incongruous setter
2023-06-24 20:08:42 -04:00
jean-pierre charras
1094cc5331
Fix issues related to the splash screen when no config file found:
...
- do not show it before the application is actually started.
- hide the splash screen before displaying dialogs.
Fixes #15047
https://gitlab.com/kicad/code/kicad/-/issues/15047
2023-06-24 18:09:43 +02:00
Jeff Young
5195bc28fe
Don't prune already-added items from the COMMIT.
...
We perform undo/redo backwards from each other specificially to allow
multiple entries (for instance, a wire is modified and then deleted).
This bus is almost certainly in 7.0 as well, but it comes up mostly
in schematics where 7.0 doesn't use COMMIT. It's also possible that it
will cause unwanted effects in some cases, so I'm leaving it only in
master.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15032
2023-06-24 15:08:26 +01:00
jean-pierre charras
965aaa217c
RULER_ITEM: fix incorrect position of the shadow text shape (round 3).
...
Depending on the text orientation, the shadow shape position was incorrect.
2023-06-23 12:50:56 +02:00
jean-pierre charras
1698fb6608
Refinement of commit 355575e4
(drawing shadow texts of RULER_ITEM and pin names)
...
Also handle non Kicad fonts (that do not use shadow texts)
Fixes #15019
https://gitlab.com/kicad/code/kicad/-/issues/15019
2023-06-23 10:32:23 +02:00
Jon Evans
3a0f8214fa
ADDED: Properties panel for schematic editor
...
Initial infrastructure work; follow-ons will add more
properties for schematic items.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-22 22:32:24 -04:00
Jon Evans
39a5929f33
Database libraries performance improvements
...
Rework caching system and optimize queries
2023-06-22 18:49:37 -04:00
3GO
206f66aee2
Make user cache path adjustable by env var.
2023-06-22 13:35:48 +00:00
jean-pierre charras
355575e477
Fix some (minor) issues when drawing shadow texts of RULER_ITEM and pin names.
...
Fixes #15019
https://gitlab.com/kicad/code/kicad/-/issues/15019
2023-06-22 13:28:43 +02:00
Kuba Sunderland-Ober
b60f7d4136
Make comparison operators const.
2023-06-21 08:49:26 +00:00
Marek Roszko
74d6dc6642
ADDED: Startup splashscreen
...
This is purely loading in the background based and has no artificial delay.
Will be more useful once kicad.exe ends up loading more on launch immediately ;)
Right now the splash is probably visible the longest launching pcbnew standalone.
The actual splash image can be considered a placeholder
2023-06-20 20:51:08 -04:00
Ian McInerney
480223f67c
More RunAction specialization
2023-06-20 21:52:50 +01:00
Ian McInerney
b0363023a5
Parameterize the tool manager RunAction function to ensure type stabilty
2023-06-20 21:52:50 +01:00
Ian McInerney
3718ecfcd8
Simplify forcing action parameters to have a specific type
2023-06-20 21:52:50 +01:00
Ian McInerney
07cc85e76c
Fix more places where casts into RunAction were happening
2023-06-20 21:52:50 +01:00
Ian McInerney
6c031a4aa4
Fix some more incorrect types in event parameters
2023-06-20 21:52:50 +01:00
Ian McInerney
55a7cfcf36
Translate doDelete action to new framework and add default parameter
2023-06-20 21:52:50 +01:00
Ian McInerney
9ebe6e7614
Update tool manager to handle the std::any parameters
2023-06-20 21:52:50 +01:00
Ian McInerney
b04e54dbea
Switch TOOL_EVENT and TOOL_ACTION to have a std::any parameter
...
Using std::any from C++17 allows for proper type handling in the
parameter field, removing the need for casting to void* and then casting
the void* to the desired type.
2023-06-20 21:52:50 +01:00